review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

robertphillips@google.com [Thu, 18 Jul 2013 18:33:39 +0000 (18:33 +0000)]

Fix for Ubuntu compiler complaint

git-svn-id: http://skia.googlecode.com/svn/trunk@10151 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 18:20:20 +0000 (18:20 +0000)]

Yet another build fix for r10148

git-svn-id: http://skia.googlecode.com/svn/trunk@10150 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 18:07:39 +0000 (18:07 +0000)]

Fix build breakages due to r10148

git-svn-id: http://skia.googlecode.com/svn/trunk@10149 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:39:14 +0000 (17:39 +0000)]

Improve null gpu's memory handling

https://codereview.chromium.org/19678010/

git-svn-id: http://skia.googlecode.com/svn/trunk@10148 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 18 Jul 2013 17:22:30 +0000 (17:22 +0000)]

Fix Android bench bots for Xoom due to OOM errors.

BUG= 1422
BUG= 1430
R=borenet@google.com

Review URL: https://codereview.chromium.org/19672007

git-svn-id: http://skia.googlecode.com/svn/trunk@10147 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:12:57 +0000 (17:12 +0000)]

The rest of: Add purgeAsNeeded calls before addResource calls

https://codereview.chromium.org/19591003/

git-svn-id: http://skia.googlecode.com/svn/trunk@10146 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:11:45 +0000 (17:11 +0000)]

Add purgeAsNeeded calls before addResource calls

https://codereview.chromium.org/19591003/

git-svn-id: http://skia.googlecode.com/svn/trunk@10145 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 13:47:01 +0000 (13:47 +0000)]

add FilterLevel API to SkPaint, replacing various Flag bits

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19769005

git-svn-id: http://skia.googlecode.com/svn/trunk@10138 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 18 Jul 2013 13:03:03 +0000 (13:03 +0000)]

pdfviewer: fix warning in release

Review URL: https://codereview.chromium.org/19773002

git-svn-id: http://skia.googlecode.com/svn/trunk@10137 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 18 Jul 2013 11:13:51 +0000 (11:13 +0000)]

Whitespace change to trigger builds.

git-svn-id: http://skia.googlecode.com/svn/trunk@10135 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 18 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10134 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:55:08 +0000 (21:55 +0000)]

[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics

resubmit r10063

BUG=1088
R=bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19668002

git-svn-id: http://skia.googlecode.com/svn/trunk@10133 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:58 +0000 (21:39 +0000)]

Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned.

BUG=260708
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19580003

git-svn-id: http://skia.googlecode.com/svn/trunk@10132 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:54 +0000 (21:39 +0000)]

Avoid lineTo() duplication in SkPath::dump().

Currently, SkPath.dump() produces duplicate entries for lineTo():

path.moveTo(0, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 0);
path.lineTo(0, 0);
path.close();

R=bungeman@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19540004

git-svn-id: http://skia.googlecode.com/svn/trunk@10131 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:42 +0000 (21:39 +0000)]

Replace all instances of GrRect with SkRect.

And remove the typedef in GrRect.h. The same with GrIRect.

R=robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19449002

git-svn-id: http://skia.googlecode.com/svn/trunk@10130 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:28 +0000 (21:39 +0000)]

Add getRectCount to SkRegtion

It is useful to know how many rects comprise a region,
since in some situations we can optimize code based on
the complexity of the region. For instance, if we use
SkRegion for tracking invalidation we might opt to use
the region bounds as invalidation instead of iterating
over each rect.

R=reed@google.com, tomhudson@chromium.org, caryclark@google.com, robertphillips@google.com

Author: vmpstr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19366008

git-svn-id: http://skia.googlecode.com/svn/trunk@10129 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Wed, 17 Jul 2013 19:30:41 +0000 (19:30 +0000)]

Add bench for hairline paths.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19238003

git-svn-id: http://skia.googlecode.com/svn/trunk@10128 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Wed, 17 Jul 2013 19:29:19 +0000 (19:29 +0000)]

make OpenCL optional for skpdiff

- add CPU based different pixels metric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19374006

git-svn-id: http://skia.googlecode.com/svn/trunk@10127 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 17 Jul 2013 19:00:33 +0000 (19:00 +0000)]

pdfviewer: fixes (indents) in input pdf spec

Review URL: https://codereview.chromium.org/19665002

git-svn-id: http://skia.googlecode.com/svn/trunk@10126 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 17 Jul 2013 07:01:13 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10122 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 17 Jul 2013 00:09:10 +0000 (00:09 +0000)]

rebaseline.py: re-record already succeeding test results, just in case
TBR=borenet

Review URL: https://codereview.chromium.org/19459002

git-svn-id: http://skia.googlecode.com/svn/trunk@10121 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 23:49:46 +0000 (23:49 +0000)]

in experimental/ : roll back a few expected GM image checksums, for testing

git-svn-id: http://skia.googlecode.com/svn/trunk@10120 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 23:37:01 +0000 (23:37 +0000)]

svndiff.py: fix --add-new for JSON-format expectations

Review URL: https://codereview.chromium.org/19444003

git-svn-id: http://skia.googlecode.com/svn/trunk@10119 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 22:55:03 +0000 (22:55 +0000)]

Missed this is r9949 (Allow the resource cache to (indirectly) flush the InOrderDrawBuffer - https://codereview.chromium.org/18466005/)

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/19401002

git-svn-id: http://skia.googlecode.com/svn/trunk@10118 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 21:10:54 +0000 (21:10 +0000)]

rebaseline.py: fix --add-new for JSON files
TBR=borenet

Review URL: https://codereview.chromium.org/19415002

git-svn-id: http://skia.googlecode.com/svn/trunk@10117 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:43:08 +0000 (20:43 +0000)]

experimental/json-expectations: reformat to match output of rebaseline.py

Created using reformat-json.py script from https://codereview.chromium.org/19289011

Review URL: https://codereview.chromium.org/19289012

git-svn-id: http://skia.googlecode.com/svn/trunk@10116 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:20:04 +0000 (20:20 +0000)]

commit updated JSON expectations to experimental (based on gm-expectations at r10113)

Review URL: https://codereview.chromium.org/19399003

git-svn-id: http://skia.googlecode.com/svn/trunk@10115 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:14:11 +0000 (20:14 +0000)]

experimental/json-expectations: mark all JSON files as plaintext, so diff tools work

git-svn-id: http://skia.googlecode.com/svn/trunk@10114 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 18:56:32 +0000 (18:56 +0000)]

svndiff.py: add ability to compare before-and-after JSON files, not just raw images

This should complete step 3 of https://goto.google.com/ChecksumTransitionDetail !

R=borenet@google.com

Review URL: https://codereview.chromium.org/19112002

git-svn-id: http://skia.googlecode.com/svn/trunk@10113 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 18:34:14 +0000 (18:34 +0000)]

NIT MASTER 9000

fixed nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19394004

git-svn-id: http://skia.googlecode.com/svn/trunk@10112 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 18:21:46 +0000 (18:21 +0000)]

Add the lazy decoder from PictureFlags to SkImageDecoder

R=caryclark@google.com, scroggo@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19109002

git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 17:39:08 +0000 (17:39 +0000)]

More PathUtilsTest.cpp nits

Reordered the includes, changed define to a constant global var.

more PathUtils Nits

BUG=
R=robertphillips@google.com, tfarina@chromium.org

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19272014

git-svn-id: http://skia.googlecode.com/svn/trunk@10110 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 17:35:39 +0000 (17:35 +0000)]

rebaseline.py: add --keep-going-on-failure option, off by default

R=borenet@google.com

Review URL: https://codereview.chromium.org/18092004

git-svn-id: http://skia.googlecode.com/svn/trunk@10109 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 16:36:47 +0000 (16:36 +0000)]

Fixed PathUtils nits.

Fixed PathUtils nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19392002

git-svn-id: http://skia.googlecode.com/svn/trunk@10108 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Tue, 16 Jul 2013 16:11:16 +0000 (16:11 +0000)]

harden and speed up path op unit tests

PathOps tests internal routines direcctly. Check to make sure that
test points, lines, quads, curves, triangles, and bounds read from
arrays are valid (i.e., don't contain NaN) before calling the
test function.

Repurpose the test flags.
- make 'v' verbose test region output against path output
- make 'z' single threaded (before it made it multithreaded)

The latter change speeds up tests run by the buildbot by 2x to 3x.

BUG=

Review URL: https://codereview.chromium.org/19374003

git-svn-id: http://skia.googlecode.com/svn/trunk@10107 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 16 Jul 2013 15:47:07 +0000 (15:47 +0000)]

add table pregeneration script for pmetric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19256002

git-svn-id: http://skia.googlecode.com/svn/trunk@10106 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 16 Jul 2013 14:59:24 +0000 (14:59 +0000)]

Split TLS implementation into its own translation unit.

SkTLS has it's own header separate from SkThread, and having SkThread own
the platform implementation of SkTLS is problematic with Chromium. The
simplest way to clean this up is to put the implementation in its own set
of files, where it is also more easily found.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19240007

git-svn-id: http://skia.googlecode.com/svn/trunk@10105 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Tue, 16 Jul 2013 13:05:27 +0000 (13:05 +0000)]

Move implementation of SkFilterShader into its source file.

Since SkFilterShader has its own header file, makes more sense to have a
separate source file to implement it rather than placing it in a "random"
SkColorFilter.cpp file.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19305004

git-svn-id: http://skia.googlecode.com/svn/trunk@10101 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 16 Jul 2013 12:57:29 +0000 (12:57 +0000)]

improve convolve speed of skpdiff using direct pointers

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19107002

git-svn-id: http://skia.googlecode.com/svn/trunk@10099 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 16 Jul 2013 12:34:24 +0000 (12:34 +0000)]

Widen range for flaky performance trigger baseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10098 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 16 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10096 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 22:49:37 +0000 (22:49 +0000)]

Export SkProxyCanvas and SkNWayCanvas for external use.

R=robertphillips@google.com, fmalita@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19240008

git-svn-id: http://skia.googlecode.com/svn/trunk@10095 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 22:47:14 +0000 (22:47 +0000)]

Const-ify SkDebugCanvas::getSize().

This is an obviously const method, no reason not to mark it as such.

R=robertphillips@google.com, fmalita@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19289003

git-svn-id: http://skia.googlecode.com/svn/trunk@10094 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 15 Jul 2013 20:50:24 +0000 (20:50 +0000)]

call newOneOff instead of oneOff

calling the latter instead of the former walked off the end of the
array causing mysterious bugs

TODO: safeguard against NaNs in the input

BUG=

Review URL: https://codereview.chromium.org/19280002

git-svn-id: http://skia.googlecode.com/svn/trunk@10093 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 15 Jul 2013 19:52:13 +0000 (19:52 +0000)]

Update SkGScalerContext to properly forward onCountGlyphs.

git-svn-id: http://skia.googlecode.com/svn/trunk@10090 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 15 Jul 2013 19:42:57 +0000 (19:42 +0000)]

Implement onCountGlyphs and onGetUPEM on Windows.

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/19231003

git-svn-id: http://skia.googlecode.com/svn/trunk@10089 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 15 Jul 2013 18:20:58 +0000 (18:20 +0000)]

pdfviewer: native inline images support

Review URL: https://codereview.chromium.org/19243003

git-svn-id: http://skia.googlecode.com/svn/trunk@10087 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 17:33:57 +0000 (17:33 +0000)]

Fix build error

git-svn-id: http://skia.googlecode.com/svn/trunk@10086 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 17:16:48 +0000 (17:16 +0000)]

PathUtilsTest valgrind patch

https://codereview.chromium.org/18401005/

git-svn-id: http://skia.googlecode.com/svn/trunk@10085 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 15:48:48 +0000 (15:48 +0000)]

Reduce verylargebitmap GM's memory footprint

https://codereview.chromium.org/19217002/

git-svn-id: http://skia.googlecode.com/svn/trunk@10083 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 15:47:10 +0000 (15:47 +0000)]

Added newlines at the end of SkGpuBlurUtils.*

git-svn-id: http://skia.googlecode.com/svn/trunk@10082 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 15:38:55 +0000 (15:38 +0000)]

Fix compiler warning/error in r10079

git-svn-id: http://skia.googlecode.com/svn/trunk@10081 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 15 Jul 2013 15:06:54 +0000 (15:06 +0000)]

Move gaussianBlur functionality to src\effects

https://codereview.chromium.org/18771004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10080 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 15 Jul 2013 15:00:58 +0000 (15:00 +0000)]

add florin tests

hopefully fix build

BUG=

Review URL: https://codereview.chromium.org/19183005

git-svn-id: http://skia.googlecode.com/svn/trunk@10079 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 15 Jul 2013 14:21:17 +0000 (14:21 +0000)]

fix linux point compare

fix linux pt compare

BUG=

Review URL: https://codereview.chromium.org/19203002

git-svn-id: http://skia.googlecode.com/svn/trunk@10076 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 13:54:06 +0000 (13:54 +0000)]

Remove possiblity of NULL effect in GrEffectStage

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/18295008

git-svn-id: http://skia.googlecode.com/svn/trunk@10075 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 15 Jul 2013 13:50:35 +0000 (13:50 +0000)]

Disable bench_pictures GPU config on Nexus 10

(RunBuilders:Perf-Android-Nexus10-MaliT604-Arm7-Release)

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19192002

git-svn-id: http://skia.googlecode.com/svn/trunk@10074 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 15 Jul 2013 13:29:13 +0000 (13:29 +0000)]

path ops near exact

Modify line intersections to first
- match exact ends
- compute intersections
- match near ends
where the exact ends are preferred, then near matches, then
computed matches. This pulls matches towards existing end points
when possible, and keeps intersection distances consistent with
different line/line line/quad and line/cubic computations.

BUG=

Review URL: https://codereview.chromium.org/19183003

git-svn-id: http://skia.googlecode.com/svn/trunk@10073 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 13:10:31 +0000 (13:10 +0000)]

ARM Skia NEON patches - 01 - Simple fixes

This series contains a few fairly non-controversial fixes.

Misc: remove dead references to neon 4444 functions

Misc: avoid the double _neon_neon suffix in the clamp matrix functions.
MAKENAME already adds the _neon suffix

Misc: a few stupid / obvious fixes

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18666004

git-svn-id: http://skia.googlecode.com/svn/trunk@10072 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 13:00:45 +0000 (13:00 +0000)]

ARM Skia NEON patches - 08 - Cleaning / possible fix

Misc: use SK_PMCOLOR_BYTE_ORDER where appropriate

Before SK_PMCOLOR_BYTE_ORDER was introduced, I had written my own
macro for the same purpose. I had at the time spotted these two
places where it seemed to be useful.

The change in SkCreateCGImageRef.cpp may be a bugfix or a bug for the
second occurrence, I'm not sure...

BUG=
R=djsollen@google.com, caryclark@google.com, reed@google.com, tomhudson@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18024003

git-svn-id: http://skia.googlecode.com/svn/trunk@10071 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 12:40:54 +0000 (12:40 +0000)]

ARM Skia NEON patches - 03 - Duplicate code removal

Misc: remove some duplicate code

SkAlphaMul does exactly the same thing as the mul function above,
so use it.

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18997003

git-svn-id: http://skia.googlecode.com/svn/trunk@10070 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 15 Jul 2013 12:20:36 +0000 (12:20 +0000)]

ARM Skia NEON patches - 07 - Equation simplification

Misc: simplify the equation of the exclusion Xfermode

The equation can be dramatically simplified. The results with gm are
the same except that the code is faster.

BUG=
R=djsollen@google.com, reed@google.com, bsalomon@google.com, cabanier@adobe.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18112016

git-svn-id: http://skia.googlecode.com/svn/trunk@10069 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 14 Jul 2013 13:41:53 +0000 (13:41 +0000)]

Flaky Ubuntu performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10068 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sun, 14 Jul 2013 07:01:15 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10067 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Sun, 14 Jul 2013 01:44:59 +0000 (01:44 +0000)]

fix trivial matrix computation

Revert "Reverted 10056-10059"

This reverts commit bab4ebcaa7270c3b866a8e10917c39b055ebd51a.

Fix broken GM test, reintroduce image scaling.

BUG=

Review URL: https://codereview.chromium.org/18721006

git-svn-id: http://skia.googlecode.com/svn/trunk@10066 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 19:50:40 +0000 (19:50 +0000)]

More valgrind suppressions

git-svn-id: http://skia.googlecode.com/svn/trunk@10065 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 18:33:27 +0000 (18:33 +0000)]

Reverting 10063 due to Win7 crashes in RenderPDFs step

git-svn-id: http://skia.googlecode.com/svn/trunk@10064 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 13 Jul 2013 17:24:30 +0000 (17:24 +0000)]

[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics

BUG=1088
R=bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18886005

git-svn-id: http://skia.googlecode.com/svn/trunk@10063 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 13 Jul 2013 17:24:24 +0000 (17:24 +0000)]

Make GrPaint have a variable sized array of color and coverage stages rather than a fixed size.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/18686007

git-svn-id: http://skia.googlecode.com/svn/trunk@10062 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 17:11:59 +0000 (17:11 +0000)]

More valgrind suppressions

git-svn-id: http://skia.googlecode.com/svn/trunk@10061 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 15:37:25 +0000 (15:37 +0000)]

Reverted 10056-10059

git-svn-id: http://skia.googlecode.com/svn/trunk@10060 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 13 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10059 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 22:15:12 +0000 (22:15 +0000)]

fix windows warning

git-svn-id: http://skia.googlecode.com/svn/trunk@10058 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 21:25:05 +0000 (21:25 +0000)]

64bitmac buildfix

git-svn-id: http://skia.googlecode.com/svn/trunk@10057 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 21:14:33 +0000 (21:14 +0000)]

Working plumb of image scaling:

1) always generate mipmaps if we detect that we are downsampling.
2) pre-scale the image if we detect that we are upsampling
(currently valid for scale+translate only)
3) A few miscellaneous bug fixes related to image scaling.

Still need SSE/Neon versions of these image scalers.

BUG=
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18978014

git-svn-id: http://skia.googlecode.com/svn/trunk@10056 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Fri, 12 Jul 2013 20:15:34 +0000 (20:15 +0000)]

Add implicit hairline conic rendering to GPU

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18258005

git-svn-id: http://skia.googlecode.com/svn/trunk@10055 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 19:58:37 +0000 (19:58 +0000)]

Fix valgrind suppressions file

git-svn-id: http://skia.googlecode.com/svn/trunk@10054 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 18:44:23 +0000 (18:44 +0000)]

Fix leak in SkAutoSTArray

https://codereview.chromium.org/18915010/

git-svn-id: http://skia.googlecode.com/svn/trunk@10053 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 12 Jul 2013 18:36:12 +0000 (18:36 +0000)]

clean up extra printfs in count_effects.lua

git-svn-id: http://skia.googlecode.com/svn/trunk@10052 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 12 Jul 2013 18:31:59 +0000 (18:31 +0000)]

Add newline for r10050.

git-svn-id: http://skia.googlecode.com/svn/trunk@10051 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 12 Jul 2013 18:22:49 +0000 (18:22 +0000)]

R=mtklein@google.com

Review URL: https://codereview.chromium.org/18503009

git-svn-id: http://skia.googlecode.com/svn/trunk@10050 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 12 Jul 2013 18:11:04 +0000 (18:11 +0000)]

If a user requests a try on "all" builders, ask for confirmation

Addresses https://code.google.com/p/skia/issues/detail?id=1208
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/18190006

git-svn-id: http://skia.googlecode.com/svn/trunk@10049 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 17:29:30 +0000 (17:29 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10048 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 12 Jul 2013 15:52:59 +0000 (15:52 +0000)]

gm: since we don't record output of gpudebug test, don't record checksums either
BUG=https://code.google.com/p/skia/issues/detail?id=1410
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19096012

git-svn-id: http://skia.googlecode.com/svn/trunk@10046 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 12 Jul 2013 13:39:53 +0000 (13:39 +0000)]

modularize the display of diffs for skpdiff

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18925004

git-svn-id: http://skia.googlecode.com/svn/trunk@10044 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 12 Jul 2013 13:31:51 +0000 (13:31 +0000)]

Revert "switch all the arm7 devices to build with thumb for a while"

This reverts r10028 which has altered the GM expectations.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/18762006

git-svn-id: http://skia.googlecode.com/svn/trunk@10043 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 12 Jul 2013 12:32:32 +0000 (12:32 +0000)]

rebaseline.py: until we fix bug 1410, keep going if we can't download an actual GM result

Review URL: https://codereview.chromium.org/19096007

git-svn-id: http://skia.googlecode.com/svn/trunk@10037 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 12 Jul 2013 07:01:14 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10033 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 11 Jul 2013 23:49:56 +0000 (23:49 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10031 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 22:29:29 +0000 (22:29 +0000)]

The two leaks are:
missing unrefs in megalooper GM
missing reset capability in oval renderer

This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet)

R=bsalomon@google.com, jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/18461007

git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 11 Jul 2013 20:50:10 +0000 (20:50 +0000)]

Initialize the matrix used when recursing from a GPU image filter -> raster image filter.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/5636027884503040

git-svn-id: http://skia.googlecode.com/svn/trunk@10029 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 20:28:38 +0000 (20:28 +0000)]

switch all the arm7 devices to build with thumb for a while

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/18563004

git-svn-id: http://skia.googlecode.com/svn/trunk@10028 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Thu, 11 Jul 2013 20:28:30 +0000 (20:28 +0000)]

reenable the scale benchmark, and only bench actual canvas draw commands
instead of direct invocations of the (now private) bitmap scale method

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/18941009

git-svn-id: http://skia.googlecode.com/svn/trunk@10027 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 20:28:24 +0000 (20:28 +0000)]

ARM Skia NEON patches - 13 - S32A_Opaque

Blitrow32: S32A_Opaque code cleaning and speed improvement

- the old way of calculating alpha doesn't seem to be used anymore,
  so remove the remaining code
- adding prefetching allows to improve performance greatly in some
  cases at the expense of a little trade-off:

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1,2   | 0         | 0          |
+-------+-----------+------------+
| 4     | 0         | -3%        |
+-------+-----------+------------+
| 8     | 0         | -4%        |
+-------+-----------+------------+
| 16    | 0         | -5%        |
+-------+-----------+------------+
| 64    | +14%      | 0          |
+-------+-----------+------------+
| 256   | +14%      | +12%       |
+-------+-----------+------------+
| 1024  | +115%     | +15%       |
+-------+-----------+------------+

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18459008

git-svn-id: http://skia.googlecode.com/svn/trunk@10026 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 11 Jul 2013 19:20:30 +0000 (19:20 +0000)]

rebaseline.py: skip any platforms we don't have actual results for, with warning message

R=borenet@google.com

Review URL: https://codereview.chromium.org/19052007

git-svn-id: http://skia.googlecode.com/svn/trunk@10022 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:46:30 +0000 (18:46 +0000)]

Disable soft floating point on ChromeOS

Should fix the Daisy build.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18812006

git-svn-id: http://skia.googlecode.com/svn/trunk@10020 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:11:56 +0000 (18:11 +0000)]

Make ChromeOS build exit nonzero on failure

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18621004

git-svn-id: http://skia.googlecode.com/svn/trunk@10018 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:05:25 +0000 (18:05 +0000)]

Add script to verify that image files exist for every actual_result checksum

Should help with https://code.google.com/p/skia/issues/detail?id=1410
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/18743006

git-svn-id: http://skia.googlecode.com/svn/trunk@10017 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 11 Jul 2013 17:51:26 +0000 (17:51 +0000)]

check JSON-format expectations into experimental/ for manual testing

Review URL: https://codereview.chromium.org/19052006

git-svn-id: http://skia.googlecode.com/svn/trunk@10016 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 11 Jul 2013 16:25:55 +0000 (16:25 +0000)]

SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask.

Test one SaveFlags bit at a time instead of exploring the whole value space.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18034028

git-svn-id: http://skia.googlecode.com/svn/trunk@10014 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom