Krzysztof Jackiewicz [Tue, 23 May 2023 09:07:23 +0000 (11:07 +0200)]
Workaround for GCM IV length issue
GCM implementation was ignoring IV bytes except first 12B. The issue has
been fixed but we need to support the decryption of the data encrypted
the old way.
This workaround retries the decryption with an IV truncated to 12B if
the decryption with original IV length fails.
Unit-test included.
Change-Id: Ia1c06d9a7c6f3b75a69c2e1cb3e5f0801776e057
Krzysztof Jackiewicz [Mon, 22 May 2023 19:29:17 +0000 (21:29 +0200)]
Fix GCM IV length setting
IV length was not properly set in case of GCM. The default 12B IV was
used at all times.
GCM supports 1 to 2^64-1 byte long IVs. Reflect it in the SW backend
implementation, its tests and client API description.
Change-Id: Idfa18c1c3cfd06de6618b4ac7632133ace6ab8dc
Krzysztof Jackiewicz [Tue, 23 May 2023 06:45:16 +0000 (08:45 +0200)]
Test proper GCM IV length handling
GCM implementation was using only the first 12B of IV regardless of its
actual length. This modification makes the test check if the remaining
bytes of the IV are ignored.
Change-Id: I94281747bbe9363854484844fa038ae9bcd47a19
Krzysztof Jackiewicz [Thu, 18 May 2023 12:50:41 +0000 (14:50 +0200)]
Rename DataType::isSKey
Change-Id: I59e553cbf067baf3ad7209e07e5376b6601c5a6a
Krzysztof Jackiewicz [Tue, 16 May 2023 13:35:30 +0000 (15:35 +0200)]
Fix backend selection logic
In some cases the backend selection was not working properly:
- Key derivation, wrapped key import: the backend compatibility was not
checked at all. This resulted in a possibility of saving an exportable
key in TZ backend which normally is not allowed.
- Encrypted initial values could have been imported to incompatible SW
backend if the TZ backend fails to initialize or the SW backend is
forced.
The Decider API was also unclear and different policies were in force
depending on the usecase.
This commit introduces following changes:
* Keep the policy in a single place.
* Return a prioritized list of backends compatible with given use case.
* Add backend check to key derivation and wrapped key import.
* Do not assume SW backend is suitable for all cases.
* Handle illegal cases by returning empty list of compatible backends.
Change-Id: I2d5dbbb3c4ba9385ac756eb419f95ac877cdd532
Krzysztof Jackiewicz [Mon, 8 May 2023 18:43:51 +0000 (20:43 +0200)]
Fix default value for KBKDF LLEN parameter
Change the default value of CKMC_PARAM_KBKDF_LLEN from 0 to 32
according to API description.
Change-Id: I972d95227b047394c5f59addc9242d43c9c68be7
Krzysztof Jackiewicz [Thu, 27 Apr 2023 09:33:20 +0000 (11:33 +0200)]
Backend info API
New API:
- getting backend associated with given object
- getting backend information for given backend
- getting max encryption chunk size from backend information
Change-Id: I8c66e623ba49ebda0a9fad28dcb3b48bd21b175f
Krzysztof Jackiewicz [Wed, 26 Apr 2023 10:17:14 +0000 (12:17 +0200)]
Multi-stage encryption API
Change-Id: If56a367a40f1ca3a6d4dcebfbb38543c7ec44fd5
Krzysztof Jackiewicz [Fri, 5 May 2023 12:38:16 +0000 (14:38 +0200)]
Fix ckmc_key_derive API description
Describe input and output key/secret types in detail.
Change-Id: I1f82fe45f4a8b5145b7236b9b8d5db998959b1ed
Krzysztof Jackiewicz [Tue, 18 Apr 2023 09:08:24 +0000 (11:08 +0200)]
Release 0.1.51
* Unify variable naming in key export
* Fix documentation issues in E2EE API
* Fix documentation issues
Change-Id: I211ecfb0a2fa8fb705fc355158e17e5cd9021356
Krzysztof Jackiewicz [Mon, 17 Apr 2023 10:01:09 +0000 (12:01 +0200)]
Unify variable naming in key export
Change-Id: Ic89b6105e420b9eceb93e9e6bdf112c4de3c1a65
Krzysztof Jackiewicz [Thu, 6 Apr 2023 13:41:12 +0000 (15:41 +0200)]
Fix documentation issues in E2EE API
* Issues raised by check-header.py (see:
https://github.sec.samsung.net/RPO7-TIZEN/tizen-native-api-review-script)
* Other issues raised during ACR.
* Own initiative cleanup.
Changes done separately to simplify ACR review.
Change-Id: I346b979cd16f1cda8a0fd970ae38f7db7bb093d7
Krzysztof Jackiewicz [Thu, 6 Apr 2023 14:37:45 +0000 (16:37 +0200)]
Fix documentation issues
* Issues raised by check-header.py (see:
https://github.sec.samsung.net/RPO7-TIZEN/tizen-native-api-review-script)
* Other issues raised during ACR.
* Own initiative cleanup.
Change-Id: If38c6477ecb782e12651766bd2ef344ccaae1e84
Krzysztof Jackiewicz [Tue, 4 Apr 2023 13:18:42 +0000 (15:18 +0200)]
Release 0.1.50
* Fix svace/coverity issues
Change-Id: I618080688b381fd110248331f615fce26cc30b30
Krzysztof Jackiewicz [Mon, 3 Apr 2023 15:46:07 +0000 (17:46 +0200)]
Fix svace/coverity issues
Change-Id: I681fd80cddf5f56bc99b35546940e111d29a5311
Tomasz Swierczek [Mon, 3 Apr 2023 05:47:41 +0000 (07:47 +0200)]
Release 0.1.49
* Fix build for 64-bit architectures
Change-Id: Ib0e29f479d86f012872a25388d927a4c37f77e26
Tomasz Swierczek [Mon, 3 Apr 2023 05:41:27 +0000 (07:41 +0200)]
Fix build for 64-bit architectures.
Change-Id: I5d658ee32d7d631145ea759c8bb3cb72b13359cd
Krzysztof Jackiewicz [Fri, 31 Mar 2023 12:50:02 +0000 (14:50 +0200)]
Release 0.1.48
* E2EE implementation
Change-Id: Id51fe9009dbc7ef78322274415153df855dde8ea
Krzysztof Jackiewicz [Fri, 31 Mar 2023 12:44:54 +0000 (14:44 +0200)]
Merge branch 'e2ee' into 'tizen'
Change-Id: I61dd5bf5a3d73b766e4d4f126783f8ded90a6f62
Krzysztof Jackiewicz [Thu, 23 Mar 2023 08:21:05 +0000 (09:21 +0100)]
Key wrapping implementation in TZ backend
Change-Id: I3d33a0b41e8eb4b58706a32fb298b0476a0525cc
Krzysztof Jackiewicz [Wed, 22 Mar 2023 08:48:31 +0000 (09:48 +0100)]
Key unwrapping implementation in TZ backend
Change-Id: I1ada1788c7f436b9cdd22cc7734eb3ab0159c544
Dariusz Michaluk [Fri, 31 Mar 2023 10:14:39 +0000 (12:14 +0200)]
Change code formatting in import/export wrapped key
Change-Id: If8932f5f9b3a1f2cdb2003895b348b89b7a15321
m.ksiezak [Thu, 16 Mar 2023 10:56:02 +0000 (11:56 +0100)]
Implementation of ckmc_export_wrapped_key
Change-Id: I2769be74b1ad3d76537d31bc3f7ac4659946029f
m.ksiezak [Fri, 17 Feb 2023 13:57:55 +0000 (14:57 +0100)]
Implementation of ckmc_import_wrapped_key
Change-Id: Ic8d2a865de2a705d39a4de06e9b91de5a6f30ef5
Krzysztof Jackiewicz [Tue, 28 Mar 2023 16:16:18 +0000 (18:16 +0200)]
Use new types in key derivation
Change-Id: I379f6a1c53c278c0adbaa71269b6232176601769
Krzysztof Jackiewicz [Tue, 28 Mar 2023 10:48:12 +0000 (12:48 +0200)]
isSKey mistake counter + a refactoring promise
Change-Id: I9fd0a98db92c8c0a6c2c7091fc9da22d0325b16a
Krzysztof Jackiewicz [Thu, 23 Mar 2023 08:19:41 +0000 (09:19 +0100)]
Simplify DB::Row/Token extraction
For wrapped key export we need to pass 1 object to be wrapped by
another. GObjUPtr is insufficient as it loses information about the
specific type. We'll need that info in TZ backend.
The wrapping API can be then made look as follows:
RawBuffer GObj::wrap(const CryptoAlgorithm ¶ms,
const Token &keyToWrap,
const Password &keyToWrapPass);
Change-Id: Ifeea08cbef43c6e86c067e37c68627d6b819bfcf
Krzysztof Jackiewicz [Mon, 27 Mar 2023 10:47:45 +0000 (12:47 +0200)]
Enable EC key pair generation in TZ backend
Until now, the decider was redirecting such requests to SW backend at
all times.
Change-Id: Ibbda55fa8ecdb3b5b8b3803754bfbf226a612704
Krzysztof Jackiewicz [Fri, 24 Mar 2023 15:52:05 +0000 (16:52 +0100)]
Make unpack a static GStore method
Needed for key wrapping.
Change-Id: I1ac65d92176237d61719944f7eb1688588c67117
Krzysztof Jackiewicz [Wed, 22 Mar 2023 08:15:34 +0000 (09:15 +0100)]
Replace 'virtual' with 'override' in TZ Store
Change-Id: I5a5406be8a4e8f3429ddb18cc9603a8647ec66a2
Krzysztof Jackiewicz [Thu, 16 Mar 2023 11:45:45 +0000 (12:45 +0100)]
Key derivation in TZ backend
Change-Id: I76a9b93d0e2deb82724ba941b97dcc4c995b08d7
Krzysztof Jackiewicz [Tue, 21 Mar 2023 07:34:49 +0000 (08:34 +0100)]
Implement EC key pair generation in TZ backend
Change-Id: Id1199d174146dfeb7b75081783dca90624fe12de
Krzysztof Jackiewicz [Fri, 24 Mar 2023 16:01:55 +0000 (17:01 +0100)]
Remove unused function
Change-Id: I157503be4e191edc35c12453d0b780c8d1ed466b
Krzysztof Jackiewicz [Mon, 20 Mar 2023 09:41:57 +0000 (10:41 +0100)]
TZ backend helpers
Change-Id: I4d81f000ca130a468352c31060608d9c78b771ce
Krzysztof Jackiewicz [Mon, 20 Mar 2023 12:32:40 +0000 (13:32 +0100)]
Use proper constant in TZ data import
Change-Id: I4510a29f1bb8d8dfc2216199465cd2a76701ddb6
Krzysztof Jackiewicz [Fri, 20 Jan 2023 19:41:55 +0000 (20:41 +0100)]
Add ECDH+KBKDF example
Add an ECDH+KBKDF example in form of a doxygen snippet. The code used in it is
compiled together with the project.
Disclaimer:
I don't know how to generate Tizen API documentation. Basing on other projects
I made an assumption that doxygen's EXAMPLE_PATH points to doc subdirectory.
With such assumption, vanilla doxygen generates the code snippet properly.
Change-Id: I7cdc98ff204238be0ad2440a8816ed53a61e7efc
Krzysztof Jackiewicz [Mon, 13 Feb 2023 09:10:39 +0000 (10:10 +0100)]
KBKDF HMAC implementation in sw backend
Unit tests included
Change-Id: If4287b38c61fe3842024c5e7baf4934685f92566
Krzysztof Jackiewicz [Fri, 10 Feb 2023 15:02:15 +0000 (16:02 +0100)]
Custom KBKDF HMAC implementation
There's no KBKDF support in openssl1.1. Added implementation based on
NIST spec, openssl3.0 KBKDF implementation (as a reference) and
openssl1.1 HMAC.
Test vector validation included (supported PRFs only)
Change-Id: If1dc6070e8e8fc35582876c6fd4b4be4497c7de4
Krzysztof Jackiewicz [Thu, 9 Feb 2023 08:11:02 +0000 (09:11 +0100)]
Sw backend ECDH implementation
Unit tests included
Change-Id: I8e91ebbba587451e3b96212d7e74a3585e480702
Krzysztof Jackiewicz [Thu, 9 Feb 2023 08:59:15 +0000 (09:59 +0100)]
Make pack() a SW Store's static method
This is necessary to let SW object pack newly derived key/secret.
Change-Id: Ib9cb635e384ae3dfcee7cf4c60cbea80d2c86861
Krzysztof Jackiewicz [Wed, 1 Feb 2023 16:00:34 +0000 (17:00 +0100)]
Key derivation implementation: client & server
Client and server part (no implementation in backend)
Change-Id: I38d9be59b2c07ed59b61374f461383b58e4c98d0
Krzysztof Jackiewicz [Fri, 17 Mar 2023 09:18:09 +0000 (10:18 +0100)]
Remove API doc leftover
Change-Id: I2b28fa37206b72adb6d68255305718508ab2d70d
Krzysztof Jackiewicz [Tue, 14 Mar 2023 12:35:17 +0000 (13:35 +0100)]
Cleanup TZ backend API
Change-Id: Id0042379e7a85d6960609f7efad3dbe7483eeaf1
Krzysztof Jackiewicz [Thu, 9 Feb 2023 08:55:08 +0000 (09:55 +0100)]
Keep the backend id in GObj
This is necessary for key derivation & wrapping, when one object
creates another.
Update SW and TZ backend.
Change-Id: I898b75b0cc093414d089ed4130827571d592315f
Krzysztof Jackiewicz [Thu, 23 Feb 2023 08:47:44 +0000 (09:47 +0100)]
Allow saving unexportable data
Now it makes sense as such data can be used for key derivation.
Change-Id: Ie8db9cca5b83831045dce45cfadde8215c79a608
Krzysztof Jackiewicz [Mon, 20 Feb 2023 07:53:36 +0000 (08:53 +0100)]
Fix the forgotten scheme-test
Make the test properly handle key migration.
Change-Id: Id1e468b1da807d52f6054ee7d0edb9c0472264fd
Krzysztof Jackiewicz [Fri, 17 Feb 2023 20:13:46 +0000 (21:13 +0100)]
Fix decryption with unexpected password
Passing a password when a row was not additionally encrypted with one
did not fail as it should. Make it do so.
Change-Id: Ifd84cca1b55c67ef7e5b470cc42bb4efac6a0703
Krzysztof Jackiewicz [Thu, 16 Feb 2023 11:09:20 +0000 (12:09 +0100)]
Derivation API extension
Allows configuration of following KBKDF parameters:
- counter location,
- fixed input or label + context,
- length of counter representation,
- length of length suffix representation,
- existence of length suffix,
- existence of zero octet separator.
Change-Id: I685e4f38d28c4bc0a9d79fd6fbbd9da870534be8
Krzysztof Jackiewicz [Fri, 10 Feb 2023 12:52:28 +0000 (13:52 +0100)]
Encryption performance test
Change-Id: Ifacdbff488e977eca69417d6362273f32feeea11
Krzysztof Jackiewicz [Thu, 12 Jan 2023 18:29:47 +0000 (19:29 +0100)]
E2EE API draft
- Key wrapping API
- Key agreement/derivation API
- Updated encryption API doc
Change-Id: Iaa7add5cf102679aa8ad9464fcbea38d52cf9c3f
Krzysztof Jackiewicz [Wed, 8 Feb 2023 09:27:14 +0000 (10:27 +0100)]
Remove unnecessary helpers from CkmLogic
Change-Id: I32df8f2f0f17b22e2d72ac99708e79f7b8ebde81
Krzysztof Jackiewicz [Mon, 6 Feb 2023 08:50:25 +0000 (09:50 +0100)]
Unify CKMLogic methods and fix PKCS12 support
Add helper functions for frequently repeated code (input parameter
checks, database selection, permission checks, hash calculation,
transaction start)
Fixed object Id is calculated from uid, pkg_id & alias. PKCS12
components are stored under common alias differing only by type. As a
result, all PKCS12 components are saved with identical object id which
may lead to conflicts.
For PKCS12 add type information as hash function input.
Change-Id: Id54c5eb4e0ad5b3521f2661df64619316cf4a9ea
Krzysztof Jackiewicz [Thu, 9 Feb 2023 14:34:03 +0000 (15:34 +0100)]
Fix indentation
Change-Id: Ic98aea95c673fb94dc022eee9cac66fc4d1a5b9e
Krzysztof Jackiewicz [Mon, 6 Feb 2023 09:28:36 +0000 (10:28 +0100)]
Unify app key loading
Change-Id: Ic10c86c01fd71311477a1695fb9a5e3d60ca1f54
Krzysztof Jackiewicz [Fri, 3 Feb 2023 12:11:15 +0000 (13:11 +0100)]
Simplify explicit to effective owner translation
Change-Id: Iaae22210f7d08c4973d779f8330f4abb6f1f1c73
Krzysztof Jackiewicz [Fri, 3 Feb 2023 09:23:12 +0000 (10:23 +0100)]
Pass proper owner to hashing function
Explicit owner may be empty. In such case the default owner value
should be taken from user's credentials.
Change-Id: I59dc0d421975bc7b329a609ebddc35420cea446c
Krzysztof Jackiewicz [Fri, 3 Feb 2023 09:05:55 +0000 (10:05 +0100)]
Move system db owner check to AccessControl
Change-Id: I28daefd12f0492a93b63f66c11b0a6fdda9d302d
Krzysztof Jackiewicz [Fri, 3 Feb 2023 07:27:56 +0000 (08:27 +0100)]
Fix indentation
Change-Id: I1f4e3d3c0c3ec9d4d7da436979236e177ad86c6a
Krzysztof Jackiewicz [Wed, 1 Feb 2023 15:30:21 +0000 (16:30 +0100)]
SW backend API cleanup
Get rid of unnecessary "virtual" specifiers.
Use "override" instead.
Remove unnecessary destructors.
Change-Id: Ide0892647acee5fe2046653d6e65bfa09b2fbe01
Krzysztof Jackiewicz [Tue, 11 Oct 2022 15:42:57 +0000 (17:42 +0200)]
Add more KeyProvider tests
This includes tests for newly added key format and migration.
Change-Id: I852fa672ad39599dc89ac3a7b334c7e914c71bde
Krzysztof Jackiewicz [Wed, 5 Oct 2022 13:51:33 +0000 (15:51 +0200)]
Refactor KeyProvider
Apply modifications while keeping key file format and encryption scheme
unchanged:
* Remove unused code
* Deduplicate code
* Unify key naming
* Simplify structures keeping various forms of keys and their metadata
* Update tests
Change-Id: I38caceb6c38bfecbdbbb290df39042ba7b17b394
isaac2.lee [Thu, 6 Oct 2022 01:17:12 +0000 (10:17 +0900)]
add debug log and fix a bug
Change-Id: I35d284cb29ec3bfe53500f4473994ed5c8217e61
Dongsun Lee [Wed, 5 Oct 2022 10:07:05 +0000 (19:07 +0900)]
Release 0.1.47
* add the se-backend for db encryption
Change-Id: Id0c036cb08a11215e74be5e6bb2343785fd6bc93
ì´ì´ì/System Security Lab(SR)/ìĵìħì ì [Wed, 5 Oct 2022 07:10:38 +0000 (16:10 +0900)]
add the se-backend for db encryption
* add the se-backend for db encryption
* change se-backend include dependancy and remove the unavailable codes
* remove migration DBDEK and rearrange KeyProvider structures
Change-Id: I52e07ac5af7b41d0f79b7fee818221f25b1d60cd
Krzysztof Jackiewicz [Mon, 26 Sep 2022 14:28:11 +0000 (16:28 +0200)]
Release 0.1.46
* Fix encryption request handling
* Add Samsung's Analysis Hub service configuration
* Remove unused sec_build_binary_debug_enable build macro
Change-Id: I909ddd67218797199f44d35582d20fb77e47f9ef
Krzysztof Jackiewicz [Mon, 26 Sep 2022 10:47:24 +0000 (12:47 +0200)]
Fix encryption request handling
The key used in m_requestMap is not unique which may lead to errors when
requests from multiple clients are processed.
Use a separate request counter as the key.
Change-Id: Iffbf0a3c43ea0c091eb3d714ef0a77211f9b3a78
Tomasz Swierczek [Wed, 21 Sep 2022 10:30:25 +0000 (12:30 +0200)]
Add Samsung's Analysis Hub service configuration
Configuration allows skipping sqlcipher.c file,
which is external open source, from static analysis.
Change-Id: Ia1ed85e403c8feefdfe659018b660af5dbe27daa
Dariusz Michaluk [Thu, 25 Nov 2021 10:46:28 +0000 (11:46 +0100)]
Remove unused sec_build_binary_debug_enable build macro
Change-Id: I3fc241eabb7ba6b8f737149f99410da0af028953
Tomasz Swierczek [Tue, 27 Jul 2021 06:39:17 +0000 (08:39 +0200)]
Release 0.1.45
* Deprecate ckmc_ocsp_check API
Change-Id: I248a647047782f6a7f403cd51b3c9b76152936b0
Tomasz Swierczek [Tue, 27 Jul 2021 06:01:47 +0000 (08:01 +0200)]
Deprecate ckmc_ocsp_check API
OCSP test certificate management is problematic, and Tizen platform
has another ocsp API in OpenSSL which can be officially recommended.
Change-Id: Ifc115c300e79a64b65361deaa848ee396e654240
MichaĊ Szaknis [Mon, 28 Jun 2021 12:22:49 +0000 (14:22 +0200)]
Release 0.1.44
* Use fixed object ID in TZ backend
* Add more tests to increase coverage
Change-Id: I989df7e1b5b8c9f783014b40b4eb700c263d1cd3
MichaĊ Szaknis [Wed, 21 Apr 2021 15:28:08 +0000 (17:28 +0200)]
Use fixed object ID in TZ backend
Calculate the object ID as a hash of credentials and alias instead of
using a random ID.
Change-Id: Ice164d6f8eda9acd157c4d74f47d45fef49f6ddc
MichaĊ Szaknis [Fri, 21 May 2021 14:17:20 +0000 (16:17 +0200)]
Add tests for `try_catch` and `try_catch_enclosure`
Change-Id: If74b22ad53961a32c75d3d7feae48f2a41d09508
MichaĊ Szaknis [Fri, 21 May 2021 08:18:35 +0000 (10:18 +0200)]
Add tests for ckmc-type-converter.cpp
Change-Id: Idd90ad6f954ec491d718b955bea2f43624986160
MichaĊ Szaknis [Thu, 20 May 2021 15:16:14 +0000 (17:16 +0200)]
Add tests for AliasSupport class
Change-Id: I509160e10ca4ac00418d3ee408c32915c6aa5511
MichaĊ Szaknis [Thu, 20 May 2021 10:30:06 +0000 (12:30 +0200)]
Add test to xml-utils.cpp
Change-Id: I74c1130c20245ade53dbb86c72e38528409be23f
Krzysztof Jackiewicz [Thu, 13 May 2021 13:34:32 +0000 (15:34 +0200)]
Release 0.1.43
* Open legacy db in R/W mode
* Fix coverage generation in rpm 4.14.1
* Suppress TEEC deprecated declarations warnings
* Remove unnecessary cast to double in db perf test
Change-Id: I44b581084930e2253ea3112e362733f47a0c9479
Krzysztof Jackiewicz [Thu, 13 May 2021 12:53:32 +0000 (14:53 +0200)]
Open legacy db in R/W mode
If due to a failure during previous transaction a rollback journal is
generated, the original legacy database has to be restored to the
original state before it can be dumped. However, it can't be done
unless the database is opened in R/W mode.
Change-Id: Icc455f4e820a5be8b0628e95895680e9cbb14eb6
Tomasz Swierczek [Wed, 3 Mar 2021 13:56:26 +0000 (14:56 +0100)]
Fix coverage generation in rpm 4.14.1
Debug source package directories now have different names.
Change-Id: I40f13e79fc90569b9f2f8d03a5a03c3759186363
Dariusz Michaluk [Thu, 18 Feb 2021 12:16:28 +0000 (13:16 +0100)]
Suppress TEEC deprecated declarations warnings
Change-Id: Iaaf6d24ceef6f981398f6c780f41c420555ee191
Krzysztof Jackiewicz [Thu, 18 Feb 2021 09:43:19 +0000 (10:43 +0100)]
Remove unnecessary cast to double in db perf test
Change-Id: I7ef26e137010f303c378cb135404a39bf13ec181
Tomasz Swierczek [Tue, 9 Feb 2021 10:03:25 +0000 (11:03 +0100)]
Release 0.1.42
* Updated to match recent systemd changes
Change-Id: I053812d12e9ae4fce5664def0d8bf8adde9f379e
INSUN PYO [Tue, 2 Feb 2021 08:57:32 +0000 (17:57 +0900)]
Change systemd-devel package name
Change-Id: Ia1df8a4567c2f72ef1777bd70b831220fce0b0a4
Krzysztof Jackiewicz [Wed, 3 Feb 2021 13:31:31 +0000 (14:31 +0100)]
Release 0.1.41
* Remove useless socket description timeout initialization
* Check sockets received from services
* Cynara socket tests
* Make SocketDescription getters const
* Validate cynara sockets
* Refrain from retrying close(int) (per man 2 close)
* Catch exceptions before returning to cynara
* Use eventfd instead of pipes for notifications
* Add randomized socket manager stress test
* Prevent writing to a socket marked as closed
* Refactor SocketManager's timeout queue
* Add timeout queue stress test
* Add check for connection counter in the server
* Start SocketManager as not working
Change-Id: I40682e7d061bbc4e522b1193b328e81abbe6e8e9
Krzysztof Jackiewicz [Tue, 2 Feb 2021 10:09:00 +0000 (11:09 +0100)]
Remove useless socket description timeout initialization
* Socket description vector uses raw monotonic clock for timeouts.
* Not all sockets use timeouts.
* Those that use are initialized at later stage.
Change-Id: Ifd9ce8c29882fc9f8cf8752a0dbd0a72b953b8f3
Krzysztof Jackiewicz [Tue, 2 Feb 2021 10:07:42 +0000 (11:07 +0100)]
Check sockets received from services
Change-Id: Ibb4b79a9e4e1c36223409c695c58c40f695e538c
Krzysztof Jackiewicz [Mon, 25 Jan 2021 09:40:58 +0000 (10:40 +0100)]
Cynara socket tests
Change-Id: I6615bf57b4a0a8bde39c14a7f82d21b000c52286
Krzysztof Jackiewicz [Mon, 25 Jan 2021 15:01:56 +0000 (16:01 +0100)]
Make SocketDescription getters const
Change-Id: Ide41dc35598b423f8dac320b02b136b17a21c3cf
Krzysztof Jackiewicz [Mon, 25 Jan 2021 08:09:05 +0000 (09:09 +0100)]
Validate cynara sockets
Socket descriptors received from cynara are not validated which may lead
to:
- m_socketDescriptionVector buffer overflow/UB
- reuse of already opened descriptors for cynara
- growing m_socketDescriptionVector
- closure of descriptors used by other parts of code
- more than one cynara socket opened at the same time
Change-Id: I5c6cd521fbde2a461f24e175571b74885d163b50
Konrad Lipinski [Fri, 29 Jan 2021 15:58:37 +0000 (15:58 +0000)]
Merge "Catch exceptions before returning to cynara" into tizen
Konrad Lipinski [Tue, 26 Jan 2021 09:09:17 +0000 (10:09 +0100)]
Refrain from retrying close(int) (per man 2 close)
Change-Id: I3343546c8aa2590e0147b89dc3c336d5e47a2d07
Krzysztof Jackiewicz [Mon, 25 Jan 2021 08:07:44 +0000 (09:07 +0100)]
Catch exceptions before returning to cynara
Callbacks registered in cynara may throw. Let's not propagate exceptions
to cynara.
Change-Id: Idc3bec6208495d0bfdb4d41c3ea0451352c9715b
Krzysztof Jackiewicz [Thu, 21 Jan 2021 12:10:45 +0000 (13:10 +0100)]
Use eventfd instead of pipes for notifications
The kernel overhead of an eventfd file descriptor is much lower than
that of a pipe, and only one file descriptor is required.
Change-Id: Ie6d04d1ea8125190c35e1ef1655f517406eff807
Krzysztof Jackiewicz [Thu, 14 Jan 2021 20:35:46 +0000 (21:35 +0100)]
Add randomized socket manager stress test
Registers several test services in the manager.
In a loop:
* Selects a random service
* Selects a random action:
* Create a new connection
* Disconnect a random existing connection
* Send random data through a random connection
* Try to receive data from a random connection
Change-Id: Id208e3a6ffbd1db82cd3389ba72bd0ff998d7c61
Krzysztof Jackiewicz [Thu, 14 Jan 2021 12:54:15 +0000 (13:54 +0100)]
Prevent writing to a socket marked as closed
It is possible that select() marks a descriptor as ready for both read
and write operation. If, additionally, the socket becomes closed in
ReadyForRead(), the following call to ReadyForWrite() will attempt to
write to a closed socket. It is harmless, unless the closed descriptor
is already reused by another thread at the time of write().
This commit prevents it.
Change-Id: Idaa829ef74d6df9f24c263f289aeca910b679713
Krzysztof Jackiewicz [Wed, 13 Jan 2021 09:40:17 +0000 (10:40 +0100)]
Refactor SocketManager's timeout queue
SocketManager changes:
* Remove timeout queue elements on socket closure. Until now it was
possible to make the timeout queue grow because its elements were not
removed upon socket closure.
* The queue now contains only socket numbers of corresponding
m_socketDescriptionVector elements. The code responsible for timeout
updates in the queue is no longer neccessary and has been removed.
* Modify the timeout queue only if corresponding socket has a timeout
enabled.
* Remove unnecessary 'open' and 'timeout' socket flag check if a
timeout occurs. Only the main thread modifies these flags. If there's
a timeout, it must have been triggered by an opened socket with
timeout enabled.
Growing queue test changes:
* Compare timeout queue size and connection count in the SocketManager
thread.
* Assume that first AcceptEvent is triggered by the most reccent
connection attempt.
* Match client and server sockets to properly detect CloseEvents.
* Add more stress to the test with more initial connections.
* Throw std exceptions from SocketManager thread.
* Wrap SocketManager thread in an object. Check a possible exception in
the destructor.
* Get rid of unnecessary timeouts.
Change-Id: Icd63696a58c4ef6a66c2e487819423df610ca580
Krzysztof Jackiewicz [Tue, 12 Jan 2021 11:37:18 +0000 (12:37 +0100)]
Add timeout queue stress test
While one socket connection is active and its timeout not reached yet,
we can open and close many new connections, which will push items on
SocketManager::m_timeoutQueue. Because first socket has an earliest
timeout, the second connection elements won't be touched. Because
m_timeoutQueue elements are not removed on socket close, the queue will
grow. Still nothing bad should happen.
Change-Id: Ied20d2e1517ad471e465c6fa601e368469a4cc37
Krzysztof Jackiewicz [Tue, 12 Jan 2021 11:30:01 +0000 (12:30 +0100)]
Add check for connection counter in the server
This is just a precaution targeted more at stress tests rather than
regular key-manager usage.
Also remove unused ConnectionID operator.
Change-Id: I090b7bd29594d8a47cc4142a7713ccfb4c9b121e
Krzysztof Jackiewicz [Tue, 12 Jan 2021 11:33:53 +0000 (12:33 +0100)]
Start SocketManager as not working
The m_working flag should be set to true only inside MainLoop().
Change-Id: I47138d2036ff87712b4b5ac4b4df385917cd866b
Dariusz Michaluk [Fri, 8 Jan 2021 16:31:00 +0000 (17:31 +0100)]
Release 0.1.40
* packaging: rpm scriptlet cleanup, handle -p /sbin/ldconfig
* Use memcpy to avoid unaligned access
* Make IEncryptionService destructor protected
Change-Id: Id6c04467097f0a89c58403c5e824d8b2d0a35aea