platform/core/csapi/xsf.git
5 years agoCheck if Control is ready before interacting with Native control (#7523)
Shane Neuville [Sun, 15 Sep 2019 00:40:55 +0000 (18:40 -0600)]
Check if Control is ready before interacting with Native control (#7523)

* Check if control is ready before setting Text

* - make 7.0 compatible

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 12 Sep 2019 22:52:45 +0000 (15:52 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoWarn on Styles validation instead of throwing exception (#7495)
Mahmoud Ali [Thu, 12 Sep 2019 22:36:02 +0000 (19:36 -0300)]
Warn on Styles validation instead of throwing exception (#7495)

* Warn on Styles validation instead of throwing exception

* Correct tests
fixes #6907

5 years ago[iOS] If ListView is disposed before callback happens, return early (#7428)
Samantha Houts [Thu, 12 Sep 2019 20:02:49 +0000 (13:02 -0700)]
[iOS] If ListView is disposed before callback happens, return early (#7428)

* Add test case

* Update Issue7371.cs

* Update Issue7371.cs

* [iOS] If ListView is disposed before callback happens, return early

fixes #7371

5 years agomove await to Begin Invoke and check for disposed (#7192)
Shane Neuville [Wed, 11 Sep 2019 16:28:21 +0000 (10:28 -0600)]
move await to Begin Invoke and check for disposed (#7192)

5 years agoWrong type checked after casting to type being searched for (#7461)
Shane Neuville [Wed, 11 Sep 2019 07:14:27 +0000 (01:14 -0600)]
Wrong type checked after casting to type being searched for (#7461)

* wrong type checked when searching for parent

* Update Xamarin.Forms.Platform.Android/ViewExtensions.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* - add api level check for ui tests

- fixes #7329

5 years agoDispose of HttpResponseMessage after stream is used (#7431)
Shane Neuville [Wed, 11 Sep 2019 07:10:59 +0000 (01:10 -0600)]
Dispose of HttpResponseMessage after stream is used (#7431)

- fixes #7248

5 years agoUpdate support libraries from 28.0.0.1 to 28.0.0.3 (#7389)
Shane Neuville [Tue, 10 Sep 2019 21:25:17 +0000 (15:25 -0600)]
Update support libraries from 28.0.0.1 to 28.0.0.3 (#7389)

* update support to 28.0.0.3

* - bump sandbox support versions

* - update nuspecs

5 years agoQueue Page.Display actions until platform is ready (#7316)
Shane Neuville [Sat, 7 Sep 2019 07:09:47 +0000 (01:09 -0600)]
Queue Page.Display actions until platform is ready (#7316)

* Queue Page.Display actions until platform is ready

* - fix click

* - set IsPlatformEnabled enabled for Display tests

5 years ago[X] do not throw here
Stephane Delcroix [Thu, 5 Sep 2019 12:18:03 +0000 (14:18 +0200)]
[X] do not throw here

5 years agoFix RTL behavior for MasterDetailsPage when running on iOS 13 iPads (#7271)
Shane Neuville [Thu, 5 Sep 2019 00:28:24 +0000 (18:28 -0600)]
Fix RTL behavior for MasterDetailsPage when running on iOS 13 iPads (#7271)

* Fix RTL on iOS 13 tablets with MDP

* - add backgrounding extension for iOS
fixes #7224
fixes #7266

5 years agoFix iOS footer and header to layout left and right for horizontal layout (#7308)...
Shane Neuville [Tue, 3 Sep 2019 23:52:42 +0000 (17:52 -0600)]
Fix iOS footer and header to layout left and right for horizontal layout (#7308) fixes #7246

* fix iOS footer and header to layout left and right for horizontal layout

* - however much

5 years ago[X] Reuse baseclass namescope if it exists (#7356)
Stephane Delcroix [Tue, 3 Sep 2019 20:45:22 +0000 (22:45 +0200)]
[X] Reuse baseclass namescope if it exists (#7356)

* [X] chain debug ctors

* unit test for 7097

* [X] Reuse baseclass namescope if it exists

If a xaml control derives from another xaml control, thy both should share the same
NameScope. This add a check if the xaml root already has a NameScope (set by the base)
and reuses it.

This fixes 2 regressions introduced by #7040 and some other unreported edge cases.

- fixes #7097
- fixes #7286

* avoid repeting linq queries

5 years ago[Android] fix animations not animating (#7298)
bentmar [Mon, 2 Sep 2019 20:26:57 +0000 (22:26 +0200)]
[Android] fix animations not animating (#7298)

* [Android] fix animations not animating

fixes #7255
fixes #7291
fixes #7278

I found that if the Animation duration scale setting has never been changed in the developer settings, the scale we get will allways be 0. So instead of defaulting to 0 we default to 1. This means if i havent touched the setting it will behave as it did pre 4.2.

Also if somehow the context is null, we should default to enabling animations since this is far more "normal" than disabling animations.

* Update Xamarin.Forms.Platform.Android/AndroidTicker.cs

Co-Authored-By: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com>
* Fix code

* Use tabs, return false if fail, enable warning

5 years agofix merge issue
Stephane Delcroix [Mon, 2 Sep 2019 08:22:06 +0000 (10:22 +0200)]
fix merge issue

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 2 Sep 2019 06:39:59 +0000 (08:39 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Mon, 2 Sep 2019 06:38:00 +0000 (08:38 +0200)]
Merge branch '4.0.0' into 4.1.0

5 years ago[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)
Samantha Houts [Thu, 29 Aug 2019 18:39:40 +0000 (11:39 -0700)]
[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)

* [iOS] Allows views that don't implement ITabStop to be accessible

Also added ITabStop to the WebView renderers

fixes #6894

* [iOS] Don't exclude layouts from a11y tree

fixes #7053

* Add test for 7053

* Add test for 6894

* [iOS] Clear accessibility elements when visibility changes

fixes #6929

* Add test for 6929

* Update Issue6894.cs

5 years agoAdd priority parameter to HandlerAttribute to thwart priority by assembly order ...
Shane Neuville [Thu, 29 Aug 2019 17:42:59 +0000 (11:42 -0600)]
Add priority parameter to HandlerAttribute to thwart priority by assembly order (#7113) fixes #6939

* add priority parameter to handler to thwart priority by assembly order

* - internalize priority

* - fix ui tests

* - remove from uwp

* - registrar fix

5 years agoFix Android FlyoutBehavior Disabled and add UI Tests (#7254)
Shane Neuville [Wed, 28 Aug 2019 21:27:59 +0000 (15:27 -0600)]
Fix Android FlyoutBehavior Disabled and add UI Tests (#7254)

* fix android flyout behavior and add ui tests

* - fix ui test

* - FlyoutLocked fixes
fixes #7238
fixes #6261

5 years agofix android content offset on navigated to page (#7265)
Shane Neuville [Wed, 28 Aug 2019 15:59:11 +0000 (09:59 -0600)]
fix android content offset on navigated to page (#7265)

5 years agoAutomated UI Tests (#5880)
Pedro Jesus [Tue, 27 Aug 2019 14:14:32 +0000 (11:14 -0300)]
Automated UI Tests (#5880)

* - automated the Bugzilla43663 and 44476

* - Add instructions in the test

* - Automated Bugzilla43519

* - Add Category in Bugzilla43469

* -Add instructions in Bugzilla42832

* - Automated 42329

* - Automated Bugzilla41271

* - style code

* - Automated Bugzilla40955

* - Automated Bugzilla40824

* - Add instructions to Bugzilla40824

* - Automated and Add instructions Bugzilla40408

* - fix code style in consts

* - Automated Bugzilla40092

* - Automated Bugzilla40092

* - Add instructions in B40092

* - B39987 Fix the preserve atribute; Automated
- Fix B40092 tests

* - Improve in B40092

* Review Bugzilla:
- 40092
- 41271
- 43663

* - Fix the build fails (changed const name)

* -Fix the mapRenderer error

* - Bugzilla 40408 pass in UWP

* - 41271 fix in uwp

* - Fix B42329 in UWP

* - code adjust

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40824.cs

Co-Authored-By: pictos <pedrojesus.cefet@gmail.com>
* - REmove obsolet refernece

* - Revert the Bugzilla40824

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* - Fidex B42329

* - Fixed B41271

* - Fixed B43519

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40092.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43663.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40408.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39987.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* - B42329 runs only on Android

5 years agoFix android to not duplicate titleview with shell (#7276)
Shane Neuville [Tue, 27 Aug 2019 07:19:52 +0000 (01:19 -0600)]
Fix android to not duplicate titleview with shell (#7276)

5 years agofixes toolbox snippet for CollectionView (#7259)
Pavel Yakovlev [Mon, 26 Aug 2019 11:33:14 +0000 (14:33 +0300)]
fixes toolbox snippet for CollectionView (#7259)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 26 Aug 2019 08:24:04 +0000 (10:24 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years ago[iOS] fix accessibility of Picker (#5145)
Pavel Yakovlev [Thu, 22 Aug 2019 11:57:45 +0000 (14:57 +0300)]
[iOS] fix accessibility of Picker (#5145)

5 years agoUpdate SafeShellTabBarAppearanceTracker.cs (#7165) fixes #6739
Gerald Versluis [Thu, 22 Aug 2019 11:17:26 +0000 (13:17 +0200)]
Update SafeShellTabBarAppearanceTracker.cs (#7165) fixes #6739

5 years agoUpdate Forms.cs
Samantha Houts [Sat, 17 Aug 2019 01:22:38 +0000 (18:22 -0700)]
Update Forms.cs

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Sat, 17 Aug 2019 00:51:53 +0000 (17:51 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Sat, 17 Aug 2019 00:46:46 +0000 (17:46 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 17 Aug 2019 00:41:04 +0000 (17:41 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoFix MDP for iPads running iOS13 (#7173)
Shane Neuville [Sat, 17 Aug 2019 00:34:42 +0000 (18:34 -0600)]
Fix MDP for iPads running iOS13 (#7173)

* Fix MDP for iPads running iOS13

* - remove s_respondsTosetNeedsUpdateOfHomeIndicatorAutoHidden

* - missing ;

5 years ago[Core] FIX RelativeLayout layout error when only width or height specified (#5694)
kicsiede [Fri, 16 Aug 2019 21:23:29 +0000 (23:23 +0200)]
[Core] FIX RelativeLayout layout error when only width or height specified (#5694)

fixes #5581

5 years ago[Shell] Fix back button behavior so that it only applies the property you've set...
Shane Neuville [Fri, 16 Aug 2019 21:22:14 +0000 (15:22 -0600)]
[Shell] Fix back button behavior so that it only applies the property you've set opposed to replacing the entire thing (#6762)

* Fix backbutton behavior to only apply what you've set opposed to replacing everything

* - move GetPropertyIfSet to Core.Internals

* - make GetPropertyIfSet public.
fixes #5744

5 years ago[Tizen] Fix Forms namespace correctly (#7193)
Samantha Houts [Fri, 16 Aug 2019 21:09:25 +0000 (14:09 -0700)]
[Tizen] Fix Forms namespace correctly (#7193)

5 years agoFix MDP for iPads running iOS13 (#7171)
Shane Neuville [Fri, 16 Aug 2019 21:09:00 +0000 (15:09 -0600)]
Fix MDP for iPads running iOS13 (#7171)

5 years agoForce iOS 13 to use Full Screen for Modal (#7174)
Shane Neuville [Fri, 16 Aug 2019 19:33:05 +0000 (13:33 -0600)]
Force iOS 13 to use Full Screen for Modal (#7174)

* Force iOS 13 to use Full Screen for Modal
- Once we are on xCode 11 and can account for swipe dismiss we can make this better

* - Removed s_respondsTosetNeedsUpdateOfHomeIndicatorAutoHidden

5 years ago[Android] Cache typefaces in font image source handler (#6470)
Tomasz Ścisłowicz [Fri, 16 Aug 2019 18:43:30 +0000 (20:43 +0200)]
[Android] Cache typefaces in font image source handler (#6470)

* cache typefaces in font image source handler

* remove private modifier

* use concurrent dictionary

* move caching to FontExtensions

* convert null fontFamily parameter to empty string
fixes #6317
fixes #6949

5 years agoForce iOS 13 to use Full Screen for Modal (#7172)
Shane Neuville [Fri, 16 Aug 2019 18:32:59 +0000 (12:32 -0600)]
Force iOS 13 to use Full Screen for Modal (#7172)

- Once we are on xCode 11 and can account for swipe dismiss we can make this better

5 years agoUpdate Xamarin.Forms.nuspec (#7189)
Gerald Versluis [Fri, 16 Aug 2019 17:28:51 +0000 (19:28 +0200)]
Update Xamarin.Forms.nuspec (#7189)

fixes #7184

5 years ago[Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer (#7163)
Samantha Houts [Fri, 16 Aug 2019 16:39:53 +0000 (09:39 -0700)]
[Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer (#7163)

* Add test case

* [Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer

fixes #6994

* [Android] Don't crash when ListView ItemSource collection cleared

* Update Issue6994.cs

* Update Issue6994.cs

* await
fixes #6994

5 years ago[UWP] Value does not fall with in the expected range Exception while creating NativeV...
Gerald Versluis [Fri, 16 Aug 2019 00:18:01 +0000 (02:18 +0200)]
[UWP] Value does not fall with in the expected range Exception while creating NativeView (#6557)

* Added repro, fix and test

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Merged in double UI test somehow

* Made test Win specific and made it work!
fixes #5886

5 years ago[C] force update size on View updated (#6936)
Stephane Delcroix [Thu, 15 Aug 2019 22:41:06 +0000 (00:41 +0200)]
[C] force update size on View updated (#6936)

5 years agononappcompat check if MDP Icon is null (#7162)
Shane Neuville [Thu, 15 Aug 2019 22:37:52 +0000 (16:37 -0600)]
nonappcompat check if MDP Icon is null (#7162)

fixes #6958

5 years ago[iOS] Moved `UITableView` setup selection to `ListViewRenderer` (#7122)
Vinicius Jarina [Thu, 15 Aug 2019 15:45:07 +0000 (11:45 -0400)]
[iOS] Moved `UITableView` setup selection to `ListViewRenderer` (#7122)

* [iOS] Moved `UITableView` setup selection to `ListViewRenderer`

* Setup the selection  from the `ContectActionCell` was causing the Xamarin.Forms previewer to crash.

TL;DR:  The previewer was crashing for a few scenarios, and rendering `ItemPage.xaml` from the Master Detail template.

From stack trace it seems that the `GestureReconizer` of the `ContextActionCell` was collected or disposed, when UIKit calls `GetCell` or `LayoutSubviews`, which calls `SetupSelection` https://github.com/xamarin/Xamarin.Forms/blob/57d507ef0b47d54d4026a07632f88a39a40de0c9/Xamarin.Forms.Platform.iOS/ContextActionCell.cs#L651 the GestureReconizer isn't there anymore, and X.iOS tries to resurrect it, causing a `MissingCtor` exception
https://gist.github.com/viniciusjarina/407952739b7f19eee15df6a5a021192b

The problem seems related to a regression on Mono/Xamarin.iOS, this patch workaround the problem avoiding Xamarin.Forms to try to setup the selection twice, hence avoiding calling `table.GestureRecognizers`.

Fixes: AB#889294
Fixes: AB#927358

* Update Xamarin.Forms.Platform.iOS/ContextActionCell.cs

5 years agofix merge (#7164)
Stephane Delcroix [Thu, 15 Aug 2019 06:30:07 +0000 (08:30 +0200)]
fix merge (#7164)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 14 Aug 2019 18:41:24 +0000 (20:41 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Wed, 14 Aug 2019 18:38:33 +0000 (20:38 +0200)]
Merge branch '4.0.0' into 4.1.0

5 years agoRemove NestedScrollView from the default shell layout (#7032)
Shane Neuville [Wed, 14 Aug 2019 16:06:54 +0000 (10:06 -0600)]
Remove NestedScrollView from the default shell layout (#7032)

* Remove NestedScrollView from the default shell layout

* only set NestedScrollingEnabled if parent is NestedScrollView

* Automate UI Tests

* - remove C#  7.1 feature and fix UI tests for iOS

* -additional c# 7.1 fixes

* -change ui tests to use gestures for scrolling

5 years agoFixes issue #7109 in XF 4.0 branch (#7151)
Jonathan Goldberger [Wed, 14 Aug 2019 14:59:50 +0000 (04:59 -1000)]
Fixes issue #7109 in XF 4.0 branch (#7151)

5 years agoUse NSIndexPath.Item instead of .Row in CollectionView (#7107)
E.Z. Hart [Wed, 14 Aug 2019 14:10:45 +0000 (08:10 -0600)]
Use NSIndexPath.Item instead of .Row in CollectionView (#7107)

* Use NSIndexPath.Item in CollectionView (instead of .Row)
Fixes #6737

* Missed a couple of .Row usages

5 years agoAdded missing NamedSizes for WPF (#7116)
Gerald Versluis [Tue, 13 Aug 2019 09:59:37 +0000 (11:59 +0200)]
Added missing NamedSizes for WPF (#7116)

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

5 years agoadd wait before WaitForNoElement (#7132)
Shane Neuville [Tue, 13 Aug 2019 09:31:43 +0000 (03:31 -0600)]
add wait before WaitForNoElement (#7132)

5 years agoUpdate ScrollViewRenderer.cs (#6151) (#7133)
Shane Neuville [Tue, 13 Aug 2019 06:41:09 +0000 (00:41 -0600)]
Update ScrollViewRenderer.cs (#6151) (#7133)

5 years ago[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread funct...
Pavel Yakovlev [Tue, 13 Aug 2019 06:32:08 +0000 (09:32 +0300)]
[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread function (#7044)

5 years ago[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)
thisisthekap [Mon, 12 Aug 2019 21:08:16 +0000 (23:08 +0200)]
[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)

* disable AndroidTicker if AnimatorDurationScale is equal or below 0

* made IsAnimatorEnabled null safe

* changed defautl behavior of IsAnimatorEnabled to disable animations if android context or context resolver are null

5 years ago[UITest] Fix 2951 and moved extension method to be more visible (#7108)
Shane Neuville [Fri, 9 Aug 2019 17:56:00 +0000 (11:56 -0600)]
[UITest] Fix 2951 and moved extension method to be more visible (#7108)

* [UITest] Fix 2951 and moved extension method to be more visible

* fix spacing

* tabs

5 years ago[Bug] NullReferenceException Closing Window During Animation (#7067)
Gerald Versluis [Fri, 9 Aug 2019 00:51:06 +0000 (02:51 +0200)]
[Bug] NullReferenceException Closing Window During Animation (#7067)

* Added null check to current application for WPF

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
fixes #7061

5 years agoUpdate Issue2577.cs (#7088)
Gerald Versluis [Thu, 8 Aug 2019 16:49:21 +0000 (18:49 +0200)]
Update Issue2577.cs (#7088)

5 years agoUpdate Issue2499.cs (#7086)
Gerald Versluis [Thu, 8 Aug 2019 16:47:13 +0000 (18:47 +0200)]
Update Issue2499.cs (#7086)

5 years agoUpdate Issue4187.cs (#7087)
Gerald Versluis [Thu, 8 Aug 2019 10:49:36 +0000 (12:49 +0200)]
Update Issue4187.cs (#7087)

5 years ago[XamlC] throw XPE on missing resource key (#7073)
Stephane Delcroix [Thu, 8 Aug 2019 08:46:17 +0000 (10:46 +0200)]
[XamlC] throw XPE on missing resource key (#7073)

When a resource was missing a key (non-implicit resource), XamlC was throwing
an AssemblyResolutionException instead of a proper XamlParseException when the
type of the resource was in a different xmlns than the default Forms one.

All the other cases are fine (default xmlns, or non-compiled Xaml)

- fixes AB#946693

5 years ago[C] Dispose the Disposable (#7020)
Stephane Delcroix [Thu, 8 Aug 2019 08:44:22 +0000 (10:44 +0200)]
[C] Dispose the Disposable (#7020)

Dispose the disposable readers while parsing StyleSheets

- fixes #6986

5 years ago[iOS] CollectionView Header/Footer (#7094)
Shane Neuville [Thu, 8 Aug 2019 07:07:16 +0000 (01:07 -0600)]
[iOS] CollectionView Header/Footer (#7094)

* [iOS] CollectionView Header/Footer

* - add iOS tests

* - fix comments

5 years ago[Android] Click on the center of the down stepper button (#7080)
Shane Neuville [Wed, 7 Aug 2019 17:16:03 +0000 (11:16 -0600)]
[Android] Click on the center of the down stepper button (#7080)

* Locate the actual stepper button for clicking

* Leave iOS test alone

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/InputTransparentTests.cs

5 years agoFix bug where wrong buttons were acted on (#6961)
Gerald Versluis [Tue, 6 Aug 2019 09:13:36 +0000 (11:13 +0200)]
Fix bug where wrong buttons were acted on (#6961)

5 years agodisable gestures on shell View Pager (#7030)
Shane Neuville [Tue, 6 Aug 2019 01:48:17 +0000 (19:48 -0600)]
disable gestures on shell View Pager (#7030)

fixes #6310
fixes #6060

5 years ago[XamlC] don't reset the NameScope if it exists (#7040)
Stephane Delcroix [Tue, 6 Aug 2019 01:24:29 +0000 (03:24 +0200)]
[XamlC] don't reset the NameScope if it exists (#7040)

if the object creation already creates a namescope (because it's created from xaml), do not override the namescope

- fixes #6192
- fixes #AB957727
- fixes #6902

5 years ago[UITest] Change Query to WaitForElement on 45125 and change GetResult to await for...
Shane Neuville [Mon, 5 Aug 2019 20:26:34 +0000 (14:26 -0600)]
[UITest] Change Query to WaitForElement on 45125 and change GetResult to await for Performance Gallery testing (#7057)

* change query to waitforelement and use async over GetResult

* - ConfigureAwait(false)

5 years agoEnsure FlowDirection propagates to EmptyView when not using a template (#6998)
E.Z. Hart [Mon, 5 Aug 2019 20:05:30 +0000 (14:05 -0600)]
Ensure FlowDirection propagates to EmptyView when not using a template (#6998)

* Make sure FlowDirection propagates to EmptyView when not using a template

* Resolve rebase issues

* Fix stuck EmptyView

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 1 Aug 2019 20:32:14 +0000 (13:32 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years ago[UWP] The SelectedItem in a ListView is not highlighted when set while constructing...
Gerald Versluis [Thu, 1 Aug 2019 11:28:29 +0000 (13:28 +0200)]
[UWP] The SelectedItem in a ListView is not highlighted when set while constructing a page (#6973)

* Enable selection of an item from constructor

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

5 years agoUse Xamarin.Forms.Size instead of Android.Util.Size to work with API < 21 (#7033...
E.Z. Hart [Thu, 1 Aug 2019 10:30:27 +0000 (04:30 -0600)]
Use Xamarin.Forms.Size instead of Android.Util.Size to work with API < 21 (#7033) fixes #6815

Fixes #6815

5 years agoPrevent DisplayEnd for cell on bounce (#7028)
Gerald Versluis [Thu, 1 Aug 2019 09:55:29 +0000 (11:55 +0200)]
Prevent DisplayEnd for cell on bounce (#7028)

5 years agoModify UI Test 6286 to await push and pop (#7022)
Shane Neuville [Wed, 31 Jul 2019 15:59:30 +0000 (09:59 -0600)]
Modify UI Test 6286 to await push and pop (#7022)

* Modify 6286 test to await push and pop

* convert over to use Tasks

5 years agoAndroid CollectionView Header/Footer (non-sticky) (#6948)
E.Z. Hart [Tue, 30 Jul 2019 18:54:43 +0000 (12:54 -0600)]
Android CollectionView Header/Footer (non-sticky) (#6948)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Tue, 30 Jul 2019 14:32:14 +0000 (16:32 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Tue, 30 Jul 2019 14:31:31 +0000 (16:31 +0200)]
Merge branch '4.0.0' into 4.1.0

5 years agoMake it easier to create custom renderers for alternate CV layouts on Android (#6990)
E.Z. Hart [Tue, 30 Jul 2019 10:27:36 +0000 (04:27 -0600)]
Make it easier to create custom renderers for alternate CV layouts on Android (#6990)

Demo of StaggeredGridLayoutManager on Android

5 years ago[UWP] Register the Xaml assembly (#7004)
Stephane Delcroix [Tue, 30 Jul 2019 07:45:11 +0000 (09:45 +0200)]
[UWP] Register the Xaml assembly (#7004)

the Xaml asssembly need to be scanned for DependecyServices. The
code in place intended it, but was referring to the wrong type...

 - fixes #6974

5 years ago[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView ...
Gerald Versluis [Tue, 30 Jul 2019 06:25:59 +0000 (08:25 +0200)]
[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView (#6910)

* Fix and UI test

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Last typo fix

5 years agoUWP CollectionView cleanup (#6928)
E.Z. Hart [Mon, 29 Jul 2019 23:50:11 +0000 (17:50 -0600)]
UWP CollectionView cleanup (#6928)

* Move files to CollectionView folder for consistency with other platforms
Move SelectableItemsViewRenderer to Setup/Teardown pattern
Fix event handler naming
Use Is method for property changed check

* Rebase cleanup

5 years ago[UWP] Fixes default button padding (#6455)
Pavel Yakovlev [Mon, 29 Jul 2019 23:49:18 +0000 (02:49 +0300)]
[UWP] Fixes default button padding (#6455)

fixes #6450

5 years agofixes .create-nuget script (#6913)
Pavel Yakovlev [Mon, 29 Jul 2019 21:11:38 +0000 (00:11 +0300)]
fixes .create-nuget script (#6913)

5 years agoCollectionView Android - Fix adapter update (#6840)
Andrei Nitescu [Mon, 29 Jul 2019 17:37:52 +0000 (20:37 +0300)]
CollectionView Android - Fix adapter update (#6840)

* CollectionView Android - Fix adapter update #6840

* Fix missing end tag

* Added APP compiler directive

* Update Issue6644.xaml.cs

fixes #6644
fixes #6839

5 years agoImplement DataTemplateSelector support for CollectionView on UWP (#6918)
E.Z. Hart [Mon, 29 Jul 2019 17:10:20 +0000 (11:10 -0600)]
Implement DataTemplateSelector support for CollectionView on UWP (#6918)

fixes #6898

5 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Mon, 29 Jul 2019 09:23:54 +0000 (10:23 +0100)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Mon, 29 Jul 2019 09:22:33 +0000 (10:22 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoiOS - Test and fix for VoiceOver crash on a ContentPage not having any Content define...
Samantha Houts [Mon, 29 Jul 2019 09:01:24 +0000 (02:01 -0700)]
iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926

* Added test case for showing crash for issue 6926.

* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.

5 years ago[Android] add check for double dispose scrollview/page/platform (#6923)
Shane Neuville [Fri, 26 Jul 2019 07:54:10 +0000 (01:54 -0600)]
[Android] add check for double dispose scrollview/page/platform (#6923)

5 years agoAdded UpdateScreenSize call at instantiation (#6912)
Gerald Versluis [Thu, 25 Jul 2019 20:24:31 +0000 (22:24 +0200)]
Added UpdateScreenSize call at instantiation (#6912)

5 years ago[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108
Pavel Yakovlev [Thu, 25 Jul 2019 16:39:08 +0000 (19:39 +0300)]
[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108

* [Android] fixes previewer exceptions with SearchBar

* added comment

5 years ago[Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView...
adrianknight89 [Thu, 25 Jul 2019 13:07:28 +0000 (08:07 -0500)]
[Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView (#5754)

* infinite scroll capability

* remove added line

* scroll event implementation

* add offset calculation for GridLayoutManager

* removed custom layout managers

* renamed variables

* changed comment

* implement CenterItemIndex

* fixed pageSize

* removed artifact

* handle the case when the layout manager is not linear

* fix comment

* call base dispose

* code review changes

* remove unused references

* indentation fix

* fix compilation issues

* revert cleanup

* fix

* fix crash

* fix test

* fix index issue

* removed unused method

* fix

* moved private variables into app scope

* Added back UI test

* Name to AutomationID

* added command parameter and addressed minor suggestions

5 years agoFixes #6539 (#6969)
kingces95 [Thu, 25 Jul 2019 09:52:36 +0000 (23:52 -1000)]
Fixes #6539 (#6969)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Tue, 23 Jul 2019 16:12:34 +0000 (18:12 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years ago[Android] Fix previewer exceptions with TabbedPage (#6897)
Pavel Yakovlev [Mon, 22 Jul 2019 16:53:28 +0000 (19:53 +0300)]
[Android] Fix previewer exceptions with TabbedPage (#6897)

* [Android] Fix previewer exceptions with TabbedPage

* - consolidated code

5 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Sun, 21 Jul 2019 19:56:23 +0000 (20:56 +0100)]
Merge branch '4.1.0' into 4.2.0

5 years ago[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
Alan Grgic [Fri, 19 Jul 2019 10:58:59 +0000 (05:58 -0500)]
[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728

* add reproduction

* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh

5 years agoFix - Prevent race condition between activity create and dispose. (#6596)
Kevin Petit [Fri, 19 Jul 2019 10:50:02 +0000 (12:50 +0200)]
Fix - Prevent race condition between activity create and dispose. (#6596)

5 years agoMacOS: Allow third party libs to display animated images correctly (#6302)
Daniel Luberda [Fri, 19 Jul 2019 10:43:39 +0000 (12:43 +0200)]
MacOS: Allow third party libs to display animated images correctly (#6302)

* Mac Animated NSImage support