James Zern [Thu, 29 Mar 2018 19:01:34 +0000 (19:01 +0000)]
Merge "test: use testing::*tuple instead of std::tr1"
Marco Paniconi [Thu, 29 Mar 2018 18:49:26 +0000 (18:49 +0000)]
Merge "vp9-svc: Fix in pickmode for key frames."
Jerome Jiang [Thu, 29 Mar 2018 18:44:35 +0000 (18:44 +0000)]
Merge "VP9 SVC: Add enum type for framedrop_mode."
Jerome Jiang [Wed, 28 Mar 2018 23:23:26 +0000 (16:23 -0700)]
VP9 SVC: Add enum type for framedrop_mode.
Change-Id: I3d4697b00729553e0860762b9264e29b8a89b9d4
xiwei gu [Thu, 29 Mar 2018 01:05:33 +0000 (01:05 +0000)]
Merge "vp9: [loongson] optimize vpx_convolve8 with mmi."
Marco Paniconi [Wed, 28 Mar 2018 23:10:17 +0000 (16:10 -0700)]
vp9-svc: Fix in pickmode for key frames.
For the fixed/default SVC patterns, GOLDEN is the
spatial reference, except on key frames, where LAST
is labeled as the spatial reference.
The current code was assuming GOLDEN is always the
spatial reference for the purpose of selecting the
subpel motion (due to the downsampling filter).
Fix is make sure flag_svc_subpel is set and used
with spatial_ref, which is labeled as the proper
spatial reference before entering mode check.
Some quality improvement on key frames.
Change-Id: Id236bcd47055b035731cc910ed84449d7e29f50c
Marco Paniconi [Wed, 28 Mar 2018 21:29:35 +0000 (21:29 +0000)]
Merge "vp9-svc: Modify logic for frame dropping with spatial layers."
Marco Paniconi [Wed, 28 Mar 2018 19:09:54 +0000 (12:09 -0700)]
vp9-svc: Modify logic for frame dropping with spatial layers.
In the constrained framedrop mode for svc: modify the buffer check
condition relative to (non-zero) dropmark to include uppper spatial layers,
in addition to the current spatial layer.
But keep the single layer check if the buffer goes below zero, since
in this case (buffer underflow) we should force drop of that layer
regardless of upper layers.
Change-Id: Id277f0b4a3ae6275effdd5f5f0c80e3229c17424
James Zern [Wed, 28 Mar 2018 19:42:27 +0000 (12:42 -0700)]
test: use testing::*tuple instead of std::tr1
googletest imports tuple into testing to allow for compatibility across
c++ versions where tuple may be in std::tr1 or std. fixes deprecation
warnings under visual studio 2017
Change-Id: Id78b372d5478b12d8c8f63fd3f2166fec25aa8be
Linfeng Zhang [Wed, 28 Mar 2018 19:39:37 +0000 (19:39 +0000)]
Merge "Add speed test in SADx4Test"
Linfeng Zhang [Thu, 22 Mar 2018 20:37:49 +0000 (13:37 -0700)]
Add speed test in SADx4Test
Change-Id: I42dd3df8c13c0a6d08ce28e27e8917b5d831fc1a
gxw [Thu, 25 Jan 2018 01:38:28 +0000 (09:38 +0800)]
vp9: [loongson] optimize vpx_convolve8 with mmi.
1. vpx_convolve8_vert_mmi
2. vpx_convolve8_horiz_mmi
3. vpx_convolve8_mmi
4. vpx_convolve8_avg_mmi
5. vpx_convolve8_avg_vert_mmi
Change-Id: I41a6b3b4f327d6b67d282e0163cfa0aee8648abe
Marco Paniconi [Wed, 28 Mar 2018 17:28:14 +0000 (10:28 -0700)]
vp9-svc: Add check in datarate unittests for frame-dropping.
Add verfication for constrained svc framedrop mode: check that
if a given spatial is dropped, all uppper layers must be dropped.
Change-Id: I9b4821b23c95d1d9d0c031a41af19984647ec5dc
Marco Paniconi [Tue, 27 Mar 2018 03:25:57 +0000 (20:25 -0700)]
vp9-svc: Add logic to enable for constrained framedrop.
Add the logic for the constrained framdrop mode for SVC.
Add test case in datarate unittests.
Also lower target bitrates in the tests to better test
frame dropper.
Change-Id: I8ee1b8cb56d835c233ad1fbe0fc1456cb2e7291f
Johann Koenig [Tue, 27 Mar 2018 01:08:12 +0000 (01:08 +0000)]
Merge "third_part/googletest: update to release-1.8.0-742-g7857975"
Marco Paniconi [Mon, 26 Mar 2018 17:53:38 +0000 (10:53 -0700)]
vp9-svc: Allow for setting frame drop thresholds per layer.
Add encoder control to set the frame drop thresholds per
spatial layer, and add a frame drop mode: 0 = per-layer drop,
and 1 = constrained drop mode (a drop on a given layer forces
drops to all upper layers).
Default is mode 0 (per-layer dropping).
Implementation for mode 1 will come in subsequent change.
If the control is not used, then the spatial layer frame
drop thresholds (water mark) are all equal and set to the value
given by the encoder config (oxcf->drop_frames_water_mark).
Bump up the ABI version.
Change-Id: Id038d4181b86fa98b3d44d026f96d5f344d81629
Johann [Mon, 26 Mar 2018 18:24:26 +0000 (11:24 -0700)]
third_part/googletest: update to release-1.8.0-742-g7857975
Address std::tr1::tuple warnings:
https://github.com/google/googletest/issues/1111
The unsigned overflow fix has been superseded by:
https://github.com/google/googletest/pull/1180
Change-Id: I92dc0ba08a4d0d63f5e5b2da7b64f4a4642ed9ab
Johann [Tue, 20 Mar 2018 00:00:44 +0000 (17:00 -0700)]
msvs build: only fix_file_list when it is broken
Clears a warning when generating VS project files with older versions of
bash:
declare: -n: invalid option
Change-Id: Id0c0bc17dc5a1599f7d2d73e3cc9259a45540f3f
Paul Wilkins [Sat, 24 Mar 2018 11:27:12 +0000 (11:27 +0000)]
Merge "Adjustment to initial q range estimate and kf boost."
Martin Storsjö [Fri, 23 Mar 2018 22:04:43 +0000 (22:04 +0000)]
Merge "Restore emms usage on x86_64 after
726b021a12c1b"
Martin Storsjo [Fri, 23 Mar 2018 10:48:42 +0000 (12:48 +0200)]
Restore emms usage on x86_64 after
726b021a12c1b
Even on x86_64, emms has to be called if the x87 state has
been clobbered - the calling code (either within libvpx or
in a caller outside of libvpx) may be using the x87 instructions,
even though use of them isn't all that common on x86_64.
This fixes builds with clang for mingw/x86_64.
Change-Id: I1f6072835590b862bad156f17331ba65c813ddd9
Martin Storsjö [Fri, 23 Mar 2018 19:54:01 +0000 (19:54 +0000)]
Merge "thumb: Remove a brittle, ugly and unused arm->thumb conversion"
Martin Storsjö [Fri, 23 Mar 2018 19:49:40 +0000 (19:49 +0000)]
Merge changes from topic "llvm-mingw"
* changes:
configure: Add an arm64-win64-gcc target
test: Check for ARCH_X86_64 in addition to _WIN64
configure: Add an armv7-win32-gcc target
ads2gas: Add a -noelf option
Johann Koenig [Fri, 23 Mar 2018 18:04:35 +0000 (18:04 +0000)]
Revert "remove fldcw/fstcw from Win64 builds"
This reverts commit
60a3cb9ad840377d46286bfd703c30a4a4ee56e2.
Reason for revert: x87 instruction usage might not be as
clear cut as I would like. At the very least, llvm mingw
builds appear to having issues with emms.
Original change's description:
> remove fldcw/fstcw from Win64 builds
>
> _MCW_PC (Precision control) is not supported on x64:
> https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/control87-controlfp-control87-2
>
> The x87 FPU is not used on Win64 or ARM so setting the x87 control word
> is not necessary. The SSE/SSE2 and ARM FPUs don't have a precision
> control - the precision is embedded in each instruction - so the need to
> set the control word is also gone.
BUG=webm:1500
Change-Id: I25bcfa96bc9c860f6c7e03315d75fa6fd1d88ec5
Johann Koenig [Fri, 23 Mar 2018 13:23:58 +0000 (13:23 +0000)]
Merge "remove fldcw/fstcw from Win64 builds"
Johann [Mon, 5 Mar 2018 21:48:35 +0000 (13:48 -0800)]
remove fldcw/fstcw from Win64 builds
_MCW_PC (Precision control) is not supported on x64:
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/control87-controlfp-control87-2
The x87 FPU is not used on Win64 or ARM so setting the x87 control word
is not necessary. The SSE/SSE2 and ARM FPUs don't have a precision
control - the precision is embedded in each instruction - so the need to
set the control word is also gone.
BUG=webm:1500
Change-Id: I014513282a7dc320d1cdeaec48249d98a66bf09f
Martin Storsjo [Wed, 21 Mar 2018 12:15:13 +0000 (14:15 +0200)]
configure: Add an arm64-win64-gcc target
This configuration doesn't require any extra custom settings, since
it only uses neon intrinsics that are handled automatically by the
compiler (no external assembly).
Change-Id: I35415c68f483a430c0672e060a7bbd09a3469512
Martin Storsjo [Wed, 21 Mar 2018 12:13:33 +0000 (14:13 +0200)]
test: Check for ARCH_X86_64 in addition to _WIN64
_WIN64 is also defined when targeting windows on aarch64.
Change-Id: I42b84e14079c19d0ba9362a06d8c6e7287644373
Martin Storsjo [Wed, 21 Mar 2018 12:12:04 +0000 (14:12 +0200)]
configure: Add an armv7-win32-gcc target
This builds for windows on arm, with llvm-mingw. The target triplet
is named -gcc since that's how similar existing targets are named,
even though it technically runs clang (via frontends named
"$CROSS-gcc").
Assemble using $CC -c since there's no standalone assembler
available (except perhaps llvm-mc).
Change-Id: I2c9a319730afef73f811bad79f488dcdc244ab0d
Martin Storsjo [Wed, 21 Mar 2018 12:09:04 +0000 (14:09 +0200)]
ads2gas: Add a -noelf option
This allows skipping elf specific features from the output.
Change-Id: I739299ba41286ca10415e056b4ffd561be5e0350
Martin Storsjo [Fri, 23 Mar 2018 11:06:41 +0000 (13:06 +0200)]
thumb: Remove a brittle, ugly and unused arm->thumb conversion
The relevant code that this conversion handled was removed in
c26a9ecaa21f4.
Change-Id: Iee40f95134e609c291c7c4e06bc50dcb895bc5e3
James Zern [Fri, 23 Mar 2018 03:56:50 +0000 (03:56 +0000)]
Merge changes Ied91c7ef,If2dcc6e2,Ib7397e71,Ib6392c79
* changes:
Fix implicit-fallthrough warnings
Fix dangling-else warnings
Fix a strict-overflow warning
Rename several static NEON iht functions
Jerome Jiang [Fri, 23 Mar 2018 01:41:21 +0000 (01:41 +0000)]
Merge "vp9 svc frame drop: enable adaptive rd for row mt."
Jerome Jiang [Tue, 20 Mar 2018 22:39:02 +0000 (15:39 -0700)]
vp9 svc frame drop: enable adaptive rd for row mt.
adaptive_rd_threshold_mt is set to 1 when speed >= 7 for SVC.
QVGA in SVC uses speed 5 which set adaptive_rd_threshold_mt to 0.
If VGA or HD is dropped for the last super frame, the flag is still 0
when the encoder is destroyed. Thus memory won't be released.
Change the bitrate threshold in datarate test.
Change-Id: I55352cc0b030568d38eb735d99c2fa29058d3690
Linfeng Zhang [Thu, 22 Mar 2018 17:58:37 +0000 (10:58 -0700)]
Fix implicit-fallthrough warnings
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
Change-Id: Ied91c7ef3d25c3ef44a1f667656176e2709b4f44
Linfeng Zhang [Thu, 22 Mar 2018 17:46:02 +0000 (10:46 -0700)]
Fix dangling-else warnings
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
Change-Id: If2dcc6e215a2990cde575f0e744ce0c7a44a15f1
Linfeng Zhang [Thu, 22 Mar 2018 01:00:40 +0000 (18:00 -0700)]
Fix a strict-overflow warning
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
./libvpx/vp9/encoder/vp9_denoiser.c:374:9: assuming signed overflow
does not occur when assuming that (X + c) < X is always false
[-Wstrict-overflow]
for (j = 0; j < xmis; j++) {
Change-Id: Ib7397e718ff717bdabc088fc4c6e1771381fb522
Linfeng Zhang [Wed, 21 Mar 2018 20:06:02 +0000 (13:06 -0700)]
Rename several static NEON iht functions
Change-Id: Ib6392c79d0269a43dbe180a89f2571482d98844d
Marco Paniconi [Wed, 21 Mar 2018 17:56:09 +0000 (10:56 -0700)]
vp9-svc: Fix to sample encoder
Get the correct computation of number of input
layers to account for frame drops.
Change-Id: I39637381e1981b53c930da67a5c525191de6907d
James Zern [Wed, 21 Mar 2018 17:52:47 +0000 (17:52 +0000)]
Merge "vp9_highbd_iht8x8_add_neon: rm unused functions"
Jerome Jiang [Tue, 20 Mar 2018 18:12:16 +0000 (11:12 -0700)]
VP9 SVC: Add control to disable inter layer prediction.
Add VP9E_SET_SVC_INTER_LAYER_PRED to disable inter layer (spatial)
prediction.
0: prediction on
1: prediction off for all frames
2: prediction off for non key frames
Bump up ABI version.
Change-Id: I5ab2a96b47e6bef202290fe726bed5f99bd4951f
Marco Paniconi [Tue, 20 Mar 2018 21:46:36 +0000 (21:46 +0000)]
Merge "vp9-svc: Improve frame dropper for spatial layers."
Marco Paniconi [Mon, 19 Mar 2018 03:46:30 +0000 (20:46 -0700)]
vp9-svc: Improve frame dropper for spatial layers.
SVC frame dropper: modify the logic to allow for individual
spatial layers to drop. This removes the constraint that all
upper spatial layers must drop when a given spatial layer drops.
Add a flag to the pkt to indicate whether a spatial layer is
encoded or dropped. This is needed for applications that enable
this feature (frame dropping for SVC).
For a current spatial layer, if its previous spatial layer is
dropped, then disable certain features for that layer:
inter-layer prediction, base_mv, partition_reuse, copy partition.
Also add the constraint to never drop a spatial layer if its
base layer is a key frame.
Updates to sample encoder (vp9_spatial_svc_encoder) and the
SVC datarate unittests to properly handle frame dropping.
Bump up ABI version.
Change-Id: I7d14ccf67b8d014a7abfce5ba3989fc623e94067
Johann [Mon, 19 Mar 2018 23:46:06 +0000 (16:46 -0700)]
visual studio: add yasm instructions
Change-Id: Ied2a1fc0e1d1a2245d63f267669add8889dd0cec
Johann Koenig [Tue, 20 Mar 2018 17:06:18 +0000 (17:06 +0000)]
Merge "x86 android: default on realtime-only"
Johann Koenig [Tue, 20 Mar 2018 17:06:05 +0000 (17:06 +0000)]
Merge "build: remove stale .git files"
Johann Koenig [Tue, 20 Mar 2018 17:05:17 +0000 (17:05 +0000)]
Merge "reland "use intrinsics for 'emms'""
Johann [Mon, 19 Mar 2018 22:57:29 +0000 (15:57 -0700)]
build: remove stale .git files
These were used for an older style of Visual Studio configurations.
Change-Id: I51f07b30ad51c4da0c5caf1ede36cdb69b2d2b19
Johann [Wed, 14 Mar 2018 23:57:57 +0000 (16:57 -0700)]
reland "use intrinsics for 'emms'"
Only target 32bit builds. Visual Studio does not define _mm_empty for
64bit configurations.
Rename emms.asm and remove from 32 bit builds to avoid empty file
warnings.
Don't check register state on 64bit builds.
BUG=webm:1500
This reverts commit
60beb781c140b61c1957abd2a6717d2e9a831933.
Change-Id: I5ac4cf6c67249ff24f7da19792144de20527bfce
Jerome Jiang [Mon, 19 Mar 2018 19:00:55 +0000 (19:00 +0000)]
Merge "VP8: Fix out of range index for mvcost."
James Zern [Mon, 19 Mar 2018 01:24:41 +0000 (18:24 -0700)]
vp9_highbd_iht8x8_add_neon: rm unused functions
their use was removed in:
d8424d289 Fix a bug in vp9_highbd_iht8x8_64_add_neon
Change-Id: I041800f3fb34ffbb7cfa7401370c5a5ceeab01c6
James Zern [Sat, 17 Mar 2018 00:47:56 +0000 (17:47 -0700)]
CopyFrameTest: reduce max size for 32-bit targets
avoids potential OOM when allocating 3 buffers for 16383x16383; 3840 is
used as a replacement
this test was missed in:
215bddf32 vpx_scale_test: reduce max size for 32-bit targets
Change-Id: I515adf5999c6ef1724394ccd62d677134bd35e6d
Jerome Jiang [Wed, 21 Feb 2018 23:28:54 +0000 (15:28 -0800)]
VP8: Fix out of range index for mvcost.
Clamp index between 0 and MVvals.
Bit exact for speed -8, -6 and -4 on RTC set.
BUG=b/
72510002
Change-Id: I61bdb02a0924e157b3c1980f74fbbfe5ce51bc44
James Zern [Sat, 17 Mar 2018 00:47:56 +0000 (17:47 -0700)]
vpx_scale_test: reduce max size for 32-bit targets
avoids potential OOM when allocating 3 buffers for 16383x16383; 3840 is
used as a replacement
Change-Id: I92116ab69b10db6820fc651d3626bd9699700208
paulwilkins [Mon, 26 Feb 2018 17:44:50 +0000 (17:44 +0000)]
Adjustment to initial q range estimate and kf boost.
Adjustment to initial active based on image size.
Add extra breakout case for kf boost loop.
Small adjustment to q delta calculation for key frames.
Net % improvements for all standard tests sets (-ve values) measured
using c-bvr mode.
(Overall PSNR, SSIM, PSNR-HVS)
Low Res: -0.223 -0.229 -0.107
Mid Res: -0.175 0.008 -0.180
High Res: -0.131 0.106 -0.206
NFlix 2K: -0.390 -0.271 -0.489
NFlix 4K: -1.370 -0.825 -1.590
Change-Id: I06a39de43594e1a99bb0cb281af15cdb8058a8ed
Marco Paniconi [Wed, 14 Mar 2018 17:03:31 +0000 (10:03 -0700)]
vp9-svc: Frame dropper for SVC.
If a given spatial layer decides to drop, due to the
buffer/overshoot conditions for that layer, then drop
that current spatial layer and all spatial layers above.
In the current implementation the svc frame counter
(and hence the pattern for the non-flexible SVC case)
are updated on frame drops.
Also add last spatial layer encoded to the pkt.
This is useful for RTC applications that enable
frame dropping for SVC.
Update to the SVC datarate tests:
enabled frame dropper on all SVC datarate tests, and
made a fix to properly set the temporal_layer_id, which
works now even on frame drops.
Change-Id: If828c193f3cb6b1839803fd52fe9fbbda5b5a039
James Zern [Fri, 16 Mar 2018 03:52:02 +0000 (03:52 +0000)]
Merge "libs.mk,vcxproj generation: split srcs in invocation"
James Zern [Fri, 16 Mar 2018 02:11:52 +0000 (02:11 +0000)]
Merge "Revert "vp9_loopfilter.c: zero lfl_uv""
James Zern [Thu, 15 Mar 2018 21:43:29 +0000 (21:43 +0000)]
Revert "vp9_loopfilter.c: zero lfl_uv"
This reverts commit
13d0955b250bcb7eac99034e7b1677d3d026b569.
Reason for revert:
this should be investigated further to ensure the memset is really
necessary outside of the static analysis pass.
Original change's description:
> vp9_loopfilter.c: zero lfl_uv
>
> The initialization depends on cm and mi_row which static
> analysis does not approve of.
>
> Clears a static analysis warning:
> warning: The right operand of '+' is a garbage value
> const loop_filter_thresh *lfi = lfthr + *lfl;
>
> Change-Id: I8c863ced2b1e9a7e10103b7281098f20941a6ca2
TBR=johannkoenig@google.com,marpan@google.com,builds@webmproject.org,jianj@google.com
Change-Id: Icadb6438fbcddba747622f06f2eadebdb333edf6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Johann Koenig [Thu, 15 Mar 2018 21:16:43 +0000 (21:16 +0000)]
Merge changes I5501d0d6,I8c863ced,I19895d06,Ifa39353d,I09bd209b
* changes:
vp9_resize.c: assert vp9_highbd_resize_plane conditions
vp9_loopfilter.c: zero lfl_uv
vp8 rdopt.c: zero rd.[rate_uv|distortion_uv]
vp8 mfqe: zero map[]
temporal svc: zero layer_target_bitrate
Johann Koenig [Thu, 15 Mar 2018 19:26:16 +0000 (19:26 +0000)]
Merge "remove spatial svc experiment"
Linfeng Zhang [Thu, 15 Mar 2018 19:21:36 +0000 (19:21 +0000)]
Merge "Add vp9_highbd_iht16x16_256_add_neon()"
James Zern [Tue, 27 Jun 2017 01:55:09 +0000 (18:55 -0700)]
libs.mk,vcxproj generation: split srcs in invocation
this avoids truncation under mingw which would result in link failures
BUG=webm:1434
Change-Id: I6eb45d94f02966532b3cdf02860a5bf2e5d3efef
Linfeng Zhang [Thu, 15 Mar 2018 18:05:08 +0000 (18:05 +0000)]
Merge changes I9e0bf2c7,I695b4090
* changes:
Fix a bug in vp9_highbd_iht8x8_64_add_neon
Fix a bug in vp9_highbd_iht4x4_16_add_neon()
Marco Paniconi [Thu, 15 Mar 2018 00:00:27 +0000 (17:00 -0700)]
vp9-svc: Bugfix to dyanmic enabling/disabling of layers.
Fix a bug when middle and top spatial layer are skip encoded
(disabled) and then re-enabled again, during the sequence.
Issue is that pending_frame_count in the packing may
be incremented on middle layer, even though that layer is skipped
(not encoded and hence zero size). Fix is to add size check.
Modified existing unitest to reproduce the issue.
Change-Id: I86d806a112d468e06b04fbf7c46ae07db9e0ad93
Johann [Wed, 14 Mar 2018 21:45:23 +0000 (14:45 -0700)]
vp9_resize.c: assert vp9_highbd_resize_plane conditions
Clears static analysis warnings similar to the low bitdepth version:
commit
c4367b9b51782969d3b37ead6694d19ef9bfb58c
Author: James Zern <jzern@google.com>
Date: Wed Mar 18 14:34:30 2015 -0700
vp9_resize_plane: quiet some static analysis warnings
Change-Id: I5501d0d6ad7c7720d746d53ec07078cb9051d0d7
Johann [Tue, 13 Mar 2018 00:23:41 +0000 (17:23 -0700)]
remove spatial svc experiment
Change-Id: Ifda11caaf992d10f2d93d6cd1d07b79b6047be05
Johann Koenig [Wed, 14 Mar 2018 22:00:08 +0000 (22:00 +0000)]
Merge "spatial svc: set window_size to 15"
Johann [Wed, 14 Mar 2018 21:22:08 +0000 (14:22 -0700)]
vp9_loopfilter.c: zero lfl_uv
The initialization depends on cm and mi_row which static
analysis does not approve of.
Clears a static analysis warning:
warning: The right operand of '+' is a garbage value
const loop_filter_thresh *lfi = lfthr + *lfl;
Change-Id: I8c863ced2b1e9a7e10103b7281098f20941a6ca2
Johann [Wed, 14 Mar 2018 20:25:05 +0000 (13:25 -0700)]
vp8 rdopt.c: zero rd.[rate_uv|distortion_uv]
These values are not consistently set before calling update_best_mode.
In vp9_rdopt.c they are individual values instead of a struct and are
zero'd at declaration.
Clears a static analysis warning:
warning: The right operand of '-' is a garbage value
RDCOST(x->rdmult, x->rddiv, (rd->rate2 - rd->rate_uv - other_cost),
warning: The right operand of '-' is a garbage value
(rd->distortion2 - rd->distortion_uv));
Change-Id: I19895d062e7c0ac67937126ebc5dcb0afd3a2931
Johann [Wed, 14 Mar 2018 20:10:08 +0000 (13:10 -0700)]
vp8 mfqe: zero map[]
The loop appears to set map[i] with the intention of running
the 'j' loop up to that point. However, without zero'ing map[]
first the behavior is unpredictable.
Fixes a static analysis warning:
warning: Branch condition evaluates to a garbage value
for (j = 0; j < 4 && map[j]; ++j) {
Change-Id: Ifa39353d8aa5cc47b467a7d3d8cdd3b5319fd997
Johann [Wed, 14 Mar 2018 19:52:49 +0000 (12:52 -0700)]
temporal svc: zero layer_target_bitrate
These values are set in main() from user input. Ensure
they are cleared out first.
Clears a static analysis warning:
warning: The right operand of '*' is a garbage value
1000.0 * rc->layer_target_bitrate[0] / rc->layer_framerate[0];
Change-Id: I09bd209be5aff31b87597a24d37a9673fa99381b
Johann Koenig [Wed, 14 Mar 2018 19:06:57 +0000 (19:06 +0000)]
Revert "use intrinsics for 'emms'"
This reverts commit
118a57045bf5b49ab7c2f7f930543b9217fd422e.
Reason for revert: Fails on Visual Studio builds:
vpxmdd.lib(vpx_ports_emms_mmx.obj) : error LNK2019: unresolved
external symbol _m_empty referenced in function
vpx_clear_system_state
Original change's description:
> use intrinsics for 'emms'
>
> BUG=webm:1500
>
> Change-Id: I3235d8c2abc01dd3a35e14c5cbcfe20283ff8fb2
Change-Id: Ia9c40bc103c57cced83353249c55218eaf2f0b0c
Marco Paniconi [Wed, 14 Mar 2018 20:13:34 +0000 (20:13 +0000)]
Merge "vp9-svc: Fix to update layer counters when layer is skipped."
Johann [Wed, 14 Mar 2018 01:31:26 +0000 (18:31 -0700)]
spatial svc: set window_size to 15
Static analysis does not recognize that output_rc_stat guards
the usage of window_size. Clears this warning:
The right operand of '>' is a garbage value
if (frame_cnt > (unsigned int)rc.window_size) {
set_rate_control_stats sets window_size to 15. Zeroing it
just introduces another static analysis warning.
Change-Id: Ieee7b81a385f986e42189101cfa39279e519b368
Marco Paniconi [Wed, 14 Mar 2018 18:49:25 +0000 (11:49 -0700)]
vp9-svc: Fix to update layer counters when layer is skipped.
Update layer counters when layer is skipped,
for any spatial layer.
Change-Id: Ie37c4a16ccafdef3390b651dec473beb5d926896
Johann [Wed, 14 Mar 2018 01:22:40 +0000 (18:22 -0700)]
spatial svc: zero sizes
This should be taken care of by parse_superframe_index but
the static analysis is not recognizing it because it depends
on 'marker' which is read from the bitstream.
Clears a static analysis warning:
The right operand of '*' is a garbage value
rc.layer_encoding_bitrate[layer] += 8.0 * sizes[sl];
Change-Id: I8ee48a98f907bc7b46869fd27a351f33e2e7de71
Johann [Wed, 14 Mar 2018 00:37:28 +0000 (17:37 -0700)]
spatial svc: remove vpx_svc_get_message
Print error messages as they are encountered. This was the default
behavior.
Removes a static analysis warning regarding the use of strncat:
Null pointer argument in call to string length function
As this is the only use of strncat in the library, remove it and the
associated public function.
Change-Id: Id55305c5a4d65f11da88c3a2203ff824200f526f
Linfeng Zhang [Wed, 28 Feb 2018 01:06:01 +0000 (17:06 -0800)]
Add vp9_highbd_iht16x16_256_add_neon()
BUG=webm:1403
Change-Id: I2293c11666786be276909d48ee78dacb40a89e25
Linfeng Zhang [Tue, 6 Mar 2018 00:25:08 +0000 (16:25 -0800)]
Fix a bug in vp9_highbd_iht8x8_64_add_neon
This bug was introduced in
29b6a30c.
BUG=webm:1403
Change-Id: I9e0bf2c7a01d8ff1c714c12236f7985b772b0540
Johann [Wed, 14 Mar 2018 00:11:48 +0000 (17:11 -0700)]
spatial svc: remove unused locals
Clears static analysis warning:
Value stored to 'tl' is never read
Change-Id: If047a74f508288c63d5b83ed0f3ad34f791f9312
Johann Koenig [Tue, 13 Mar 2018 23:51:08 +0000 (23:51 +0000)]
Merge "use intrinsics for 'emms'"
Linfeng Zhang [Tue, 13 Mar 2018 23:10:00 +0000 (16:10 -0700)]
Fix a bug in vp9_highbd_iht4x4_16_add_neon()
This bug was introduced in
36363304.
BUG=webm:1403
Change-Id: I695b409047e41ab7e0460981524310d78753751a
Johann [Tue, 13 Mar 2018 21:37:39 +0000 (14:37 -0700)]
spatial svc: rescope sl
sl was passed to set_frame_flags_bypass_mode, triggering
an uninitialized variable warning. Inside the function it
is only used as a local variable.
Change-Id: If743626e9e10fd41d135e3b4ad6196dc4dc90172
Johann [Mon, 5 Mar 2018 22:27:04 +0000 (14:27 -0800)]
use intrinsics for 'emms'
BUG=webm:1500
Change-Id: I3235d8c2abc01dd3a35e14c5cbcfe20283ff8fb2
Johann [Mon, 12 Mar 2018 22:20:28 +0000 (15:20 -0700)]
x86 android: default on realtime-only
Like the arm-based target, set realtime-only on by default.
BUG=webm:873
Change-Id: I2e04cfc43390953435e985716a25f32b8d4fadda
Johann [Mon, 12 Mar 2018 21:54:48 +0000 (14:54 -0700)]
autodetect macOS High Sierra
Add darwin17 target
Change-Id: I349a2f6a0396c59269f567a03ae813e3e59ccefa
Johann Koenig [Mon, 12 Mar 2018 20:56:30 +0000 (20:56 +0000)]
Merge "vp8 temporal_filter: ignore return value"
Johann [Tue, 31 Jan 2017 23:45:12 +0000 (15:45 -0800)]
vp8 temporal_filter: ignore return value
Clears up static clang analysis warning regarding a dead store.
Change-Id: I6a90e6fd5f2775d933c46c7553811635bd2def21
Marco Paniconi [Mon, 12 Mar 2018 19:18:35 +0000 (12:18 -0700)]
vp9-svc: Update layer frame counters when layer is skipped.
When an enhancement spatial layer is skipped, we should check
for updating the layer frame counters.
Change-Id: Ib79d0955c62fb465f59ef2f9ac45240ae2614d7b
Marco Paniconi [Mon, 12 Mar 2018 05:09:14 +0000 (22:09 -0700)]
vp9-SVC: Fix to choose_partition when LAST ref is NULL.
This causes assert to trigger in choose_partitioning().
This can happen in some cases when enhancement layers
are enabled midway during the stream.
Change-Id: I69c3c8b4b1e3f1c7d8d7294d633ca5ddca148e8b
James Zern [Thu, 8 Mar 2018 21:13:09 +0000 (21:13 +0000)]
Merge "vpx_scale_test: add w/h output to alloc failure"
Paul Wilkins [Thu, 8 Mar 2018 13:34:15 +0000 (13:34 +0000)]
Merge "Change to KF frame boost calculation."
James Zern [Thu, 8 Mar 2018 07:07:51 +0000 (23:07 -0800)]
vpx_scale_test: add w/h output to alloc failure
Change-Id: Ib5df91d9fcd7fe973a2f7d8e73a204259beddc07
James Zern [Thu, 8 Mar 2018 03:41:27 +0000 (03:41 +0000)]
Merge changes If96fd6f1,I84b27337
* changes:
Fix a bug in vp9_iht16x16_256_add_neon()
Fix a bug in vp9_iht8x8_64_add_neon()
Johann [Tue, 6 Mar 2018 02:51:10 +0000 (18:51 -0800)]
add worst-case frame size cap
The largest frame is currently in choose_partitioning:
warning: stack frame size of 44156 bytes in function 'choose_partitioning'
but adding HBD amplifies other things:
warning: stack frame size of 51480 bytes in function 'dec_build_inter_predictors'
Add some padding for sanitizer and variances between compilers.
BUG=webm:1498
Change-Id: I0d94d4f94d25dafafca9d7484881c2ce5f8de371
Linfeng Zhang [Tue, 6 Mar 2018 00:14:35 +0000 (16:14 -0800)]
Fix a bug in vp9_iht16x16_256_add_neon()
This bug was introduced in
88c23864.
BUG=webm:1403
Change-Id: If96fd6f102be6b9bda866e55e574257287746f4a
Linfeng Zhang [Mon, 5 Mar 2018 23:16:49 +0000 (15:16 -0800)]
Fix a bug in vp9_iht8x8_64_add_neon()
This bug was introduced in
b14b616d.
BUG=webm:1403
Change-Id: I84b2733734982e52b66548850d61758c772b5494
Johann [Sun, 4 Mar 2018 20:31:04 +0000 (12:31 -0800)]
move vp8 encodeopt to block_error_sse2
The file contains sse2 implementations related to various block error
functions. Update the .mk file to include it only when sse2 is
requested.
BUG=webm:1500
Change-Id: I67b766faed425fd7a96db8541b13c69670b65fec
James Zern [Sat, 3 Mar 2018 20:47:24 +0000 (12:47 -0800)]
disable vp9_highbd_iht{4x4_16,8x8_64}_add_neon
these causes test vector failures
BUG=webm:1403
Change-Id: I08218f0bf26651eb367ece4feec6d704e0189bd8