platform/upstream/libSkiaSharp.git
8 years agoUpdate SKP version
update-skps [Sun, 25 Oct 2015 07:29:20 +0000 (00:29 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1411383007

8 years agoFix dm compilation on Google3.
benjaminwagner [Sat, 24 Oct 2015 14:55:31 +0000 (07:55 -0700)]
Fix dm compilation on Google3.

BUG=skia:

Review URL: https://codereview.chromium.org/1414113005

8 years agoSkRecord refactor: fill bounds array instead of BBH directly
mtklein [Sat, 24 Oct 2015 14:45:47 +0000 (07:45 -0700)]
SkRecord refactor: fill bounds array instead of BBH directly

This should be a strict refactor, just pulling out the bounds array.
(It's the rescued nice parts of a dead-end CL targeting skia:4492.)

BUG=skia:

Review URL: https://codereview.chromium.org/1424553002

8 years agoRevert of Experimental CL to stop using subdata (patchset #1 id:1 of https://coderevi...
joshualitt [Fri, 23 Oct 2015 20:54:12 +0000 (13:54 -0700)]
Revert of Experimental CL to stop using subdata (patchset #1 id:1 of https://codereview.chromium.org/1413263006/ )

Reason for revert:
might be breaking tsan

Original issue's description:
> Experimental CL to stop using subdata
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1409123004

8 years agoUse SkAutoTExclusive in SkGlyphCache.
herb [Fri, 23 Oct 2015 18:31:38 +0000 (11:31 -0700)]
Use SkAutoTExclusive in SkGlyphCache.

This replaces the local AutoAcquire class.

Review URL: https://codereview.chromium.org/1424563002

8 years agoAdd more cases to bleed GM and more variants
bsalomon [Fri, 23 Oct 2015 18:13:01 +0000 (11:13 -0700)]
Add more cases to bleed GM and more variants

Review URL: https://codereview.chromium.org/1423793002

8 years ago[tracing] Remove counter logic and just use address on glyph cache dumps
ssid [Fri, 23 Oct 2015 17:49:35 +0000 (10:49 -0700)]
[tracing] Remove counter logic and just use address on glyph cache dumps

This CL removes the logic of counting the index of glyphs and uses the
address of the glyph object for dump name. This makes the dump names
consistent across multiple dumps.

BUG=543479

Review URL: https://codereview.chromium.org/1425443002

8 years agoUse SkAutoTExclusive guard in DirectWrite port.
herb [Fri, 23 Oct 2015 17:48:26 +0000 (10:48 -0700)]
Use SkAutoTExclusive guard in DirectWrite port.

Review URL: https://codereview.chromium.org/1417873005

8 years agoFix some GPU filters to use the correct size constraint.
senorblanco [Fri, 23 Oct 2015 16:56:48 +0000 (09:56 -0700)]
Fix some GPU filters to use the correct size constraint.

BUG=skia:

Review URL: https://codereview.chromium.org/1412863006

8 years agoNarrow the distribution of GrDrawTarget a bit
robertphillips [Fri, 23 Oct 2015 16:38:03 +0000 (09:38 -0700)]
Narrow the distribution of GrDrawTarget a bit

BUG=skia:4094
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1420043002

8 years agoUse SkSwizzler to convert from CMYK
scroggo [Fri, 23 Oct 2015 16:29:22 +0000 (09:29 -0700)]
Use SkSwizzler to convert from CMYK

Move convert_CMYK_to_RGBA into two functions in SkSwizzler: one for 565
and one for 8888.

For simplicity, when converting to 8888, we no longer convert in place.

BUG=skia:4476

Committed: https://skia.googlesource.com/skia/+/450ee8f26d39f975cf6af37a27de658ae5a9fa10

Review URL: https://codereview.chromium.org/1411083009

8 years agoUpdate SrcRectConstraint doc. Previous doc never matched the implementation or the...
bsalomon [Fri, 23 Oct 2015 16:27:42 +0000 (09:27 -0700)]
Update SrcRectConstraint doc. Previous doc never matched the implementation or the c2d spec.

Review URL: https://codereview.chromium.org/1411103003

8 years agoExperimental CL to stop using subdata
joshualitt [Fri, 23 Oct 2015 16:12:02 +0000 (09:12 -0700)]
Experimental CL to stop using subdata

BUG=skia:

Review URL: https://codereview.chromium.org/1413263006

8 years agoMove GrGLBufferImpl's GL calls to behind GrGLGpu
joshualitt [Fri, 23 Oct 2015 16:08:08 +0000 (09:08 -0700)]
Move GrGLBufferImpl's GL calls to behind GrGLGpu

BUG=skia:

Review URL: https://codereview.chromium.org/1417313003

8 years agoAdd immediate mode option for gpu configs in dm
bsalomon [Fri, 23 Oct 2015 16:06:59 +0000 (09:06 -0700)]
Add immediate mode option for gpu configs in dm

Review URL: https://codereview.chromium.org/1421853002

8 years agoRevert of Use SkSwizzler to convert from CMYK (patchset #4 id:60001 of https://codere...
scroggo [Fri, 23 Oct 2015 15:39:58 +0000 (08:39 -0700)]
Revert of Use SkSwizzler to convert from CMYK (patchset #4 id:60001 of https://codereview.chromium.org/1411083009/ )

Reason for revert:
Breaking ASAN. See http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/2879

Original issue's description:
> Use SkSwizzler to convert from CMYK
>
> Move convert_CMYK_to_RGBA into two functions in SkSwizzler: one for 565
> and one for 8888.
>
> For simplicity, when converting to 8888, we no longer convert in place.
>
> BUG=skia:4476
>
> Committed: https://skia.googlesource.com/skia/+/450ee8f26d39f975cf6af37a27de658ae5a9fa10

TBR=msarett@google.com,scroggo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4476

Review URL: https://codereview.chromium.org/1411193006

8 years agoUse SkSwizzler to convert from CMYK
scroggo [Fri, 23 Oct 2015 15:01:06 +0000 (08:01 -0700)]
Use SkSwizzler to convert from CMYK

Move convert_CMYK_to_RGBA into two functions in SkSwizzler: one for 565
and one for 8888.

For simplicity, when converting to 8888, we no longer convert in place.

BUG=skia:4476

Review URL: https://codereview.chromium.org/1411083009

8 years agoRemove mac buffer impl war
joshualitt [Fri, 23 Oct 2015 14:33:54 +0000 (07:33 -0700)]
Remove mac buffer impl war

BUG=skia:

Review URL: https://codereview.chromium.org/1419203002

8 years agoSkTime::GetNSecs()
mtklein [Fri, 23 Oct 2015 14:02:06 +0000 (07:02 -0700)]
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

Committed: https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63

Review URL: https://codereview.chromium.org/1422513003

8 years agoRevert of SkTime::GetNSecs() (patchset #11 id:200001 of https://codereview.chromium...
mtklein [Fri, 23 Oct 2015 13:40:33 +0000 (06:40 -0700)]
Revert of SkTime::GetNSecs() (patchset #11 id:200001 of https://codereview.chromium.org/1422513003/ )

Reason for revert:
Times don't look like they make sense on Windows.

Original issue's description:
> SkTime::GetNSecs()
>
>    - Move high-precision wall timers from tools/timer to SkTime.
>    - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
>    - Delete unused tools/timer code.
>
> I have no idea what's going on there in src/animator.
> I don't intend to investigate.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c
>
> Committed: https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63

TBR=caryclark@google.com,reed@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1422623003

8 years agoSkTime::GetNSecs()
mtklein [Fri, 23 Oct 2015 13:24:07 +0000 (06:24 -0700)]
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

Review URL: https://codereview.chromium.org/1422513003

8 years agoRevert of SkTime::GetNSecs() (patchset #10 id:180001 of https://codereview.chromium...
mtklein [Fri, 23 Oct 2015 00:49:22 +0000 (17:49 -0700)]
Revert of SkTime::GetNSecs() (patchset #10 id:180001 of https://codereview.chromium.org/1422513003/ )

Reason for revert:
https://codereview.chromium.org/1412453006

Original issue's description:
> SkTime::GetNSecs()
>
>    - Move high-precision wall timers from tools/timer to SkTime.
>    - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
>    - Delete unused tools/timer code.
>
> I have no idea what's going on there in src/animator.
> I don't intend to investigate.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c

TBR=caryclark@google.com,reed@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1417753003

8 years agoSkTime::GetNSecs()
mtklein [Thu, 22 Oct 2015 20:33:21 +0000 (13:33 -0700)]
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot

Review URL: https://codereview.chromium.org/1422513003

8 years agotunnel down texture-size-constraint to imagefilters
reed [Thu, 22 Oct 2015 20:20:20 +0000 (13:20 -0700)]
tunnel down texture-size-constraint to imagefilters

BUG=skia:

Review URL: https://codereview.chromium.org/1421493003

8 years agoRevert of SkTime::GetNSecs() (patchset #9 id:160001 of https://codereview.chromium...
caryclark [Thu, 22 Oct 2015 20:03:02 +0000 (13:03 -0700)]
Revert of SkTime::GetNSecs() (patchset #9 id:160001 of https://codereview.chromium.org/1422513003/ )

Reason for revert:
broke chromeos

Original issue's description:
> SkTime::GetNSecs()
>
>    - Move high-precision wall timers from tools/timer to SkTime.
>    - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
>    - Delete unused tools/timer code.
>
> I have no idea what's going on there in src/animator.
> I don't intend to investigate.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1420923003

8 years agoSkTime::GetNSecs()
mtklein [Thu, 22 Oct 2015 19:47:04 +0000 (12:47 -0700)]
SkTime::GetNSecs()

   - Move high-precision wall timers from tools/timer to SkTime.
   - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs().
   - Delete unused tools/timer code.

I have no idea what's going on there in src/animator.
I don't intend to investigate.

BUG=skia:

Review URL: https://codereview.chromium.org/1422513003

8 years agoForce the s4 to use highp for transforming to NDS
egdaniel [Thu, 22 Oct 2015 18:08:08 +0000 (11:08 -0700)]
Force the s4 to use highp for transforming to NDS

This seems to fix some rendering issues. Currently this will use highp
for all draws on the s4, but if we see perf issues we can refine this
later to specific types of draws.

BUG=skia:

Review URL: https://codereview.chromium.org/1419593003

8 years agoRemove unused functions from GrGLVertexBuffer / IndexBuffer
joshualitt [Thu, 22 Oct 2015 17:00:24 +0000 (10:00 -0700)]
Remove unused functions from GrGLVertexBuffer / IndexBuffer

BUG=skia:

Review URL: https://codereview.chromium.org/1416303002

8 years agoFix force high precision for arm gpus
egdaniel [Thu, 22 Oct 2015 16:40:36 +0000 (09:40 -0700)]
Fix force high precision for arm gpus

This fixes a bug introduced by recent changes to GLSL caps.

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1422553004

8 years agoAdd version string and force highp NDS transfrom to GLSLCaps
egdaniel [Thu, 22 Oct 2015 15:20:00 +0000 (08:20 -0700)]
Add version string and force highp NDS transfrom to GLSLCaps

This also include the use of any() in the shaders.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/cef4bce8e260b49bf3417eadbac806cf7d39cdc8

Review URL: https://codereview.chromium.org/1417993004

8 years agoImplementation of SkBitmapRegionDecoder using SkAndroidCodec
msarett [Thu, 22 Oct 2015 14:29:19 +0000 (07:29 -0700)]
Implementation of SkBitmapRegionDecoder using SkAndroidCodec

Includes testing in DM and nanobench

BUG=skia:

Review URL: https://codereview.chromium.org/1402863002

8 years agoReland of path ops: fix conic weight and partial coincidence (patchset #1 id:1 of...
caryclark [Thu, 22 Oct 2015 14:23:52 +0000 (07:23 -0700)]
Reland of path ops: fix conic weight and partial coincidence (patchset #1 id:1 of https://codereview.chromium.org/1408923003/ )

Reason for revert:
suppressions have landed in chrome

Original issue's description:
> Revert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001 of https://codereview.chromium.org/1413763002/ )
>
> Reason for revert:
> path ops change breaks svg clipping layout tests -- conic is now more accurate, changing edge of circle in clip
>
> These need to be rebaselined
>
> svg/clip-path/clip-path-child-clipped.svg
> svg/clip-path/clip-path-nonzero.svg
> svg/clip-path/clip-path-evenodd-nonzero.svg
> svg/clip-path/clip-path-nonzero-evenodd.svg
>
> Original issue's description:
> > The remaining 1m skp bugs are asserts that can be harmlessly
> > suppressed and bugs around conics.
> >
> > The conic calculation for a subdivided w was just wrong.
> >
> > Also added debugging to template intersection to initialize
> > reused structures and dump additional data.
> >
> > TBR=reed@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/f428df1be3e96d3f8970d0f7f415b862f7da5404

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1407003016

8 years agoRevert of Suppression for valgrind bug (patchset #1 id:1 of https://codereview.chromi...
scroggo [Thu, 22 Oct 2015 14:23:21 +0000 (07:23 -0700)]
Revert of Suppression for valgrind bug (patchset #1 id:1 of https://codereview.chromium.org/1410953002/ )

Reason for revert:
We believe this was suppressing an out of date error that was being triggered because the valgrind bot was not rebuilding nanobench. The valgrind bot has been fixed (is there a bug tracking that?), so this suppression is probably not necessary.

Original issue's description:
> Suppression for valgrind bug
>
> TBR=msarett@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> BUG=skia:4478
>
> Committed: https://skia.googlesource.com/skia/+/82e341ff8764ef6168a0c9322089c391d657ae7f

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4478

Review URL: https://codereview.chromium.org/1406333006

8 years agoRevert of Add version string and force highp NDS transfrom to GLSLCaps (patchset...
egdaniel [Thu, 22 Oct 2015 14:08:37 +0000 (07:08 -0700)]
Revert of Add version string and force highp NDS transfrom to GLSLCaps (patchset #3 id:40001 of https://codereview.chromium.org/1417993004/ )

Reason for revert:
breaking bots

Original issue's description:
> Add version string and force highp NDS transfrom to GLSLCaps
>
> This also include the use of any() in the shaders.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/cef4bce8e260b49bf3417eadbac806cf7d39cdc8

TBR=bsalomon@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1420033002

8 years agoStop running nanobench on GalaxyS4
borenet [Thu, 22 Oct 2015 14:06:28 +0000 (07:06 -0700)]
Stop running nanobench on GalaxyS4

BUG=skia:3214

Review URL: https://codereview.chromium.org/1422683002

8 years agoAdd version string and force highp NDS transfrom to GLSLCaps
egdaniel [Thu, 22 Oct 2015 13:54:15 +0000 (06:54 -0700)]
Add version string and force highp NDS transfrom to GLSLCaps

This also include the use of any() in the shaders.

BUG=skia:

Review URL: https://codereview.chromium.org/1417993004

8 years agoRevert of Dependencies are now added between the drawTargets in GrPipeline (patchset...
robertphillips [Thu, 22 Oct 2015 12:31:32 +0000 (05:31 -0700)]
Revert of Dependencies are now added between the drawTargets in GrPipeline (patchset #6 id:120001 of https://codereview.chromium.org/1414903002/ )

Reason for revert:
Breaking bots

Original issue's description:
> Dependencies are now added between the drawTargets in GrPipeline
>
> This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)
>
> BUG=skia:4094
>
> Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be
>
> Committed: https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4094

Review URL: https://codereview.chromium.org/1417263002

8 years agoDependencies are now added between the drawTargets in GrPipeline
robertphillips [Thu, 22 Oct 2015 12:19:50 +0000 (05:19 -0700)]
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

Review URL: https://codereview.chromium.org/1414903002

8 years agoAdd lighter weight lock guards.
herb [Thu, 22 Oct 2015 02:11:13 +0000 (19:11 -0700)]
Add lighter weight lock guards.

BUG=skia:

Review URL: https://codereview.chromium.org/1417583005

8 years agoFix uninitialized memory on kIndex8 divisor tests in Gold
msarett [Wed, 21 Oct 2015 20:26:59 +0000 (13:26 -0700)]
Fix uninitialized memory on kIndex8 divisor tests in Gold

Turns out bitmap.eraseColor() does nothing if the bitmap
is kIndex8.  We need a more reliable way to initialize
all of the pixels that we look at in Gold.

The input SkCanvas* is always zero initialized, so let's
only draw pixels to the canvas if we have initialized them.

BUG=skia:

Review URL: https://codereview.chromium.org/1418913002

8 years agoOmit Math from DM on Google3 because it fails under the MSAN config.
benjaminwagner [Wed, 21 Oct 2015 20:07:07 +0000 (13:07 -0700)]
Omit Math from DM on Google3 because it fails under the MSAN config.

BUG=skia:

Review URL: https://codereview.chromium.org/1418903002

8 years agoSkRemote: more refactoring
mtklein [Wed, 21 Oct 2015 19:34:01 +0000 (12:34 -0700)]
SkRemote: more refactoring

    - move Client / Server definitions to .cpp
    - rename Client / Server to Canvas / Decoder

No diffs:
https://gold.skia.org/search2?issue=1409113005&unt=true&query=source_type%3Dgm&master=false&include=true

BUG=skia:

Review URL: https://codereview.chromium.org/1409113005

8 years agoMove SkChecksum::Murmur3 out of the header.
mtklein [Wed, 21 Oct 2015 18:53:27 +0000 (11:53 -0700)]
Move SkChecksum::Murmur3 out of the header.

As we use this more and more, we end up with more and more inline copies.
On my desktop, this makes Skia ~16K smaller.

Boy perf trybots would be neat.

BUG=skia:

Review URL: https://codereview.chromium.org/1415133003

8 years agoRevert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (patchs...
caryclark [Wed, 21 Oct 2015 18:39:06 +0000 (11:39 -0700)]
Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (patchset #3 id:40001 of https://codereview.chromium.org/1405103003/ )

Reason for revert:
Test to see if patch fixes Nexus 6.

Original issue's description:
> Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader
>
> Use an SkImage generator/shader instead.
>
> R=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d

TBR=reed@google.com,fmalita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1407043008

8 years agoSkRemote: refactoring
mtklein [Wed, 21 Oct 2015 17:46:02 +0000 (10:46 -0700)]
SkRemote: refactoring

  - Cache becomes CachingEncoder that wraps another Encoder
  - Encoders provide IDs
  - syntaxy improvements to Client
  - ID isn't really protocol sensitive.
  - I don't think we need Type::kNone.

No diffs.
https://gold.skia.org/search2?issue=1418863002&unt=true&query=source_type%3Dgm&master=false&include=true

BUG=skia:

Review URL: https://codereview.chromium.org/1418863002

8 years agoMove GrGLShaderVar to GrGLSL
egdaniel [Wed, 21 Oct 2015 17:45:48 +0000 (10:45 -0700)]
Move GrGLShaderVar to GrGLSL

BUG=skia:

Review URL: https://codereview.chromium.org/1417123002

8 years agoCreate an SkAndroidCodec API separate from SkCodec
msarett [Wed, 21 Oct 2015 17:27:10 +0000 (10:27 -0700)]
Create an SkAndroidCodec API separate from SkCodec

We will implement this API using SkCodecs.

SkAndroidCodecs will be used to implement the
BitmapRegionDecoder Java API (and possibly
BitmapFactory).

BUG=skia:

Review URL: https://codereview.chromium.org/1406223002

8 years agoAdd a mutex to protect the DWrite calls.
herb [Wed, 21 Oct 2015 16:24:37 +0000 (09:24 -0700)]
Add a mutex to protect the DWrite calls.

BUG=skia:4479

Review URL: https://codereview.chromium.org/1421433004

8 years agoForce VisualBench to reset GLContext on GrContext reset
joshualitt [Wed, 21 Oct 2015 15:04:24 +0000 (08:04 -0700)]
Force VisualBench to reset GLContext on GrContext reset

BUG=skia:

Review URL: https://codereview.chromium.org/1416063002

8 years agoFix build targets for some bots
borenet [Wed, 21 Oct 2015 14:50:57 +0000 (07:50 -0700)]
Fix build targets for some bots

Valgrind bot is not building nanobench. Some bots are building nanobench and then not running it.

BUG=skia:

Review URL: https://codereview.chromium.org/1412243004

8 years agoMove shader precision modifier check onto GLSLCaps
egdaniel [Wed, 21 Oct 2015 14:14:17 +0000 (07:14 -0700)]
Move shader precision modifier check onto GLSLCaps

BUG=skia:

Review URL: https://codereview.chromium.org/1414373002

8 years agoStop creating static GrProcessor instances
bsalomon [Wed, 21 Oct 2015 13:57:30 +0000 (06:57 -0700)]
Stop creating static GrProcessor instances

R=joshualitt@google.com

BUG=skia:4483

Review URL: https://codereview.chromium.org/1414733007

8 years agoRevert of Dependencies are now added between the drawTargets in GrPipeline (patchset...
caryclark [Wed, 21 Oct 2015 11:16:19 +0000 (04:16 -0700)]
Revert of Dependencies are now added between the drawTargets in GrPipeline (patchset #5 id:100001 of https://codereview.chromium.org/1414903002/ )

Reason for revert:
this may have broken the TSAN and ASAN bots

Original issue's description:
> Dependencies are now added between the drawTargets in GrPipeline
>
> This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)
>
> BUG=skia:4094
>
> Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be

TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4094

Review URL: https://codereview.chromium.org/1419613005

8 years agoRevert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001...
caryclark [Wed, 21 Oct 2015 11:02:51 +0000 (04:02 -0700)]
Revert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001 of https://codereview.chromium.org/1413763002/ )

Reason for revert:
path ops change breaks svg clipping layout tests -- conic is now more accurate, changing edge of circle in clip

These need to be rebaselined

svg/clip-path/clip-path-child-clipped.svg
svg/clip-path/clip-path-nonzero.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-nonzero-evenodd.svg

Original issue's description:
> The remaining 1m skp bugs are asserts that can be harmlessly
> suppressed and bugs around conics.
>
> The conic calculation for a subdivided w was just wrong.
>
> Also added debugging to template intersection to initialize
> reused structures and dump additional data.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1408923003

8 years agoValgrind experiment
msarett [Tue, 20 Oct 2015 23:45:56 +0000 (16:45 -0700)]
Valgrind experiment

I don't really expect this to fix the errors, but I think
it's worth it to try shaking up the valgrind bot overnight.
There's some strange behavior with regard to color type on
the valgrind bot that I can't reproduce and that we aren't
seeing on any of the other bots.

TBR=mtklein,scroggo

BUG=skia:

Review URL: https://codereview.chromium.org/1418723002

8 years agoSkRemote: shaders
mtklein [Tue, 20 Oct 2015 22:04:22 +0000 (15:04 -0700)]
SkRemote: shaders

https://gold.skia.org/search2?issue=1417703003&unt=true&query=source_type%3Dgm&master=false&include=true&limit=60

BUG=skia:

Review URL: https://codereview.chromium.org/1417703003

8 years agoUse the current OpengGL standard to determine blur precision, rather than kGLES
Brian Salomon [Tue, 20 Oct 2015 21:33:26 +0000 (17:33 -0400)]
Use the current OpengGL standard to determine blur precision, rather than kGLES

TBR=ethannicholas@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/1408123004 .

8 years agoClean up some dead code.
mtklein [Tue, 20 Oct 2015 21:29:10 +0000 (14:29 -0700)]
Clean up some dead code.

This cleans up tools/ code, or code that should have been in tools/.

The only interesting code change trims features off of PictureRenderer.
It's still in use by a few useful-looking tools.

BUG=skia:

Review URL: https://codereview.chromium.org/1416913003

8 years agoThe remaining 1m skp bugs are asserts that can be harmlessly
caryclark [Tue, 20 Oct 2015 20:42:25 +0000 (13:42 -0700)]
The remaining 1m skp bugs are asserts that can be harmlessly
suppressed and bugs around conics.

The conic calculation for a subdivided w was just wrong.

Also added debugging to template intersection to initialize
reused structures and dump additional data.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1413763002

8 years agoDependencies are now added between the drawTargets in GrPipeline
robertphillips [Tue, 20 Oct 2015 20:41:16 +0000 (13:41 -0700)]
Dependencies are now added between the drawTargets in GrPipeline

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Review URL: https://codereview.chromium.org/1414903002

8 years agoInclude resources directory in google3 sync.
benjaminwagner [Tue, 20 Oct 2015 20:00:48 +0000 (13:00 -0700)]
Include resources directory in google3 sync.

Also other minor improvements in sync scripts.

In BUILD.public, include all files under resources as data dependencies for DM. Omit newly failing DM tests and add newly passing DM tests.

Adds the OpenClipart "license" to LICENSE per comment in google3 CL 100158380.

Corresponding google3 CL is 105602927.

BUG=skia:

Review URL: https://codereview.chromium.org/1406283002

8 years agoremove debug statement
caryclark [Tue, 20 Oct 2015 18:09:41 +0000 (11:09 -0700)]
remove debug statement

R=djsollen@google.com

Review URL: https://codereview.chromium.org/1415603004

8 years agoRemove SkThread::setProcessorAffinity()
mtklein [Tue, 20 Oct 2015 18:05:06 +0000 (11:05 -0700)]
Remove SkThread::setProcessorAffinity()

It's only used by a couple unit tests.  We have other ways of getting
the same quality testing of our ref-count code now (e.g. TSAN).

BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot

Review URL: https://codereview.chromium.org/1408213005

8 years agoImage filters: Replace all use of tryAllocPixels() with createDevice().
senorblanco [Tue, 20 Oct 2015 17:17:34 +0000 (10:17 -0700)]
Image filters: Replace all use of tryAllocPixels() with createDevice().

In order to have a central pinch point for bitmap allocation, change all
filters to use Proxy::createDevice() instead of allocating memory
directly with SkBitmap::tryAllocPixels().

This will aid in moving filter backing stores and caches to
discardable memory.

BUG=skia:

Review URL: https://codereview.chromium.org/1414843003

8 years agoRevert of Update feSpotLight to match spec (patchset #2 id:20001 of https://coderevie...
caryclark [Tue, 20 Oct 2015 17:04:03 +0000 (10:04 -0700)]
Revert of Update feSpotLight to match spec (patchset #2 id:20001 of https://codereview.chromium.org/1403403003/ )

Reason for revert:
re-land once layout test have been disabled (so they can be rebased)

Original issue's description:
> Update feSpotLight to match spec
>
> This change updates feSpotLight to match the spec via two changes:
>
> 1) specularExponent is ignored if the spotlight has no coneAngle (GPU
>    bug only). This change updates the GPU path so that it matches the
>    CPU path and the spec in this regard.
>
> 2) specularExponent is clamped to the 1-128 range. The spec does not
>    specify a clamp for the specularExponent attribute of feSpotLight.
>    Note that the spec *does* specify this clamp for the
>    specularExponent attribute of feSpecularLighting. It looks like we
>    incorrectly applied this to both specularExponent attributes.
>
>    This change (along with a parallel change in Blink) allows us to pass
>    the SVG filter effects conformance test here:
>    http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/filters-light-01-f.html
>
>    Additionally, this brings our behavior in line with Safari and Edge’s
>    behavior on this filter.
>
> Two new cases were added to gm/lighting.cpp to catch these issues:
> - The existing spotlight case exercised the path where our specular
>   exponent was between 1-128 and had a limiting cone angle.
> - The first new spotlight case exercises the path where our specular
>   exponent is between 1-128 and we do not have a limiting cone angle.
> - The second new spotlight case exercises the path where the specular
>   exponent is not within the 1-128 range, to ensure that we don’t
>   incorrectly clip to this range.
>
> BUG=472849
>
> Committed: https://skia.googlesource.com/skia/+/c84ccb070258db2803a9e8f532bfe7239a737063

TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com,ericrk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472849

Review URL: https://codereview.chromium.org/1417463006

8 years agouse (temp) gpu-imagefilter-cache for applyFilter
reed [Tue, 20 Oct 2015 16:56:52 +0000 (09:56 -0700)]
use (temp) gpu-imagefilter-cache for applyFilter

BUG=skia:

Review URL: https://codereview.chromium.org/1414653003

8 years agoMove GrDrawingManager methods to their own .cpp file
robertphillips [Tue, 20 Oct 2015 16:54:32 +0000 (09:54 -0700)]
Move GrDrawingManager methods to their own .cpp file

Small cleanup

Review URL: https://codereview.chromium.org/1407393004

8 years agoSkRemote: add xfermodes
mtklein [Tue, 20 Oct 2015 15:26:54 +0000 (08:26 -0700)]
SkRemote: add xfermodes

Note this changes the default ID for each type from a valid non-null value to a nullptr.
All the ()++ are now ++(), so we always work with non-null IDs when we define things.

Some of this is prematurely generalized with an eye for supporting other effects and ref-counted things.

https://gold.skia.org/search2?issue=1412223002&unt=true&query=source_type%3Dgm&master=false&include=true

BUG=skia:

Review URL: https://codereview.chromium.org/1412223002

8 years agoRewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object...
bsalomon [Tue, 20 Oct 2015 14:58:01 +0000 (07:58 -0700)]
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done.

Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

Committed: https://skia.googlesource.com/skia/+/1a197ea31e0aac7ea312e9a6c0d9f5df626b0350

Review URL: https://codereview.chromium.org/1409163002

8 years agoAdd debugging helper to GrDrawTarget
robertphillips [Tue, 20 Oct 2015 14:50:00 +0000 (07:50 -0700)]
Add debugging helper to GrDrawTarget

This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)

BUG=skia:4094

Review URL: https://codereview.chromium.org/1416753002

8 years agonanobench: Add some Valgrind failure paranoia.
mtklein [Tue, 20 Oct 2015 14:45:29 +0000 (07:45 -0700)]
nanobench: Add some Valgrind failure paranoia.

Trying to figure out

http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/586/steps/nanobench/logs/stdio

BUG=skia:4482

Review URL: https://codereview.chromium.org/1418633002

8 years agoAdd the machinery to GrDrawTarget to enable topological sorting
robertphillips [Tue, 20 Oct 2015 14:37:58 +0000 (07:37 -0700)]
Add the machinery to GrDrawTarget to enable topological sorting

This relies on https://codereview.chromium.org/1414503003/ (Add SkTTopoSort) landing first.

BUG=skia:4094

Review URL: https://codereview.chromium.org/1414773002

8 years agoUpdate feSpotLight to match spec
ericrk [Mon, 19 Oct 2015 21:44:56 +0000 (14:44 -0700)]
Update feSpotLight to match spec

This change updates feSpotLight to match the spec via two changes:

1) specularExponent is ignored if the spotlight has no coneAngle (GPU
   bug only). This change updates the GPU path so that it matches the
   CPU path and the spec in this regard.

2) specularExponent is clamped to the 1-128 range. The spec does not
   specify a clamp for the specularExponent attribute of feSpotLight.
   Note that the spec *does* specify this clamp for the
   specularExponent attribute of feSpecularLighting. It looks like we
   incorrectly applied this to both specularExponent attributes.

   This change (along with a parallel change in Blink) allows us to pass
   the SVG filter effects conformance test here:
   http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/filters-light-01-f.html

   Additionally, this brings our behavior in line with Safari and Edge’s
   behavior on this filter.

Two new cases were added to gm/lighting.cpp to catch these issues:
- The existing spotlight case exercised the path where our specular
  exponent was between 1-128 and had a limiting cone angle.
- The first new spotlight case exercises the path where our specular
  exponent is between 1-128 and we do not have a limiting cone angle.
- The second new spotlight case exercises the path where the specular
  exponent is not within the 1-128 range, to ensure that we don’t
  incorrectly clip to this range.

BUG=472849

Review URL: https://codereview.chromium.org/1403403003

8 years agoThe SkArithmeticMode_gpu GL filters support clamping to valid
ericrk [Mon, 19 Oct 2015 21:41:11 +0000 (14:41 -0700)]
The SkArithmeticMode_gpu GL filters support clamping to valid
premultiplied colors, however the flag for whether or not to do this,
which is present in their parent filters, is dropped when creating the
GL implementations. This change adds logic to forward the value from
the parent filter to the GL implementation.

This makes GPU behavior match software and fixes a WebKit
LayoutTest. See referenced bug.

BUG=473186

Review URL: https://codereview.chromium.org/1410553002

8 years agoSkRemote: fix Misc hash function.
mtklein [Mon, 19 Oct 2015 21:39:45 +0000 (14:39 -0700)]
SkRemote: fix Misc hash function.

Misc only has data in the first 10 bytes of its 12 byte layout.
We need to stop hashing at 10 bytes.

C.f. http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/581

BUG=skia:

Review URL: https://codereview.chromium.org/1409273006

8 years agoModifications to get 'blaze build -c opt //third_party/skia/HEAD/...' to work.
benjaminwagner [Mon, 19 Oct 2015 20:55:55 +0000 (13:55 -0700)]
Modifications to get 'blaze build -c opt //third_party/skia/HEAD/...' to work.

BUG=skia:

Review URL: https://codereview.chromium.org/1413973002

8 years agoAdd SkTTopoSort
robertphillips [Mon, 19 Oct 2015 19:15:55 +0000 (12:15 -0700)]
Add SkTTopoSort

BUG=skia:4094

Review URL: https://codereview.chromium.org/1414503003

8 years agoRevert recent CLs around GrTextureMaker/GrTextureParamsAdjuster
Brian Salomon [Mon, 19 Oct 2015 19:12:32 +0000 (15:12 -0400)]
Revert recent CLs around GrTextureMaker/GrTextureParamsAdjuster

Review URL: https://codereview.chromium.org/1411353002 .

8 years agoUpload stretched bmp rather than original after doing CPU stretch for min texture...
Brian Salomon [Mon, 19 Oct 2015 18:22:51 +0000 (14:22 -0400)]
Upload stretched bmp rather than original after doing CPU stretch for min texture size

BUG=skia:

Review URL: https://codereview.chromium.org/1411323002 .

8 years agoSkRemote: DrawPaint is an inverse empty path.
mtklein [Mon, 19 Oct 2015 17:41:15 +0000 (10:41 -0700)]
SkRemote: DrawPaint is an inverse empty path.

Drawing with SkRect::MakeLargest() isn't actually working.

This appears to work correctly, and even be correct.
(It's a case explicitly handled by SkCanvas::onDrawPath).

BUG=skia:

Review URL: https://codereview.chromium.org/1411303002

8 years agoMove definitions of GrGL basic types (e.g. GrGLenum) to their own header.
bsalomon [Mon, 19 Oct 2015 16:03:23 +0000 (09:03 -0700)]
Move definitions of GrGL basic types (e.g. GrGLenum) to their own header.

Review URL: https://codereview.chromium.org/1410333003

8 years agoAdd override to Bitmap_GrTextureParamsAdjuster::refOriginalTexture
Brian Salomon [Mon, 19 Oct 2015 15:53:40 +0000 (11:53 -0400)]
Add override to Bitmap_GrTextureParamsAdjuster::refOriginalTexture

TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1417553002 .

8 years agoFix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.
ethannicholas [Mon, 19 Oct 2015 15:38:16 +0000 (08:38 -0700)]
Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

BUG=skia:2860

Review URL: https://codereview.chromium.org/1395693011

8 years agoMisc: Don't run etc1 bench with invalid image and fix VS2015 build warning
bsalomon [Mon, 19 Oct 2015 15:29:16 +0000 (08:29 -0700)]
Misc: Don't run etc1 bench with invalid image and fix VS2015 build warning

Review URL: https://codereview.chromium.org/1409993003

8 years agochange SkImage_Gpu to handle all filters (w/ and w/o gpu support
reed [Mon, 19 Oct 2015 15:24:21 +0000 (08:24 -0700)]
change SkImage_Gpu to handle all filters (w/ and w/o gpu support

The result is that the set of "generic" imagefilters (e.g. SkColorFilterImageFilter) that use drawing commands to return their results will now stay in the same domain as their src (i.e. gpu-src --> gpu-dst).

ApplyFilterGM exercises this, and now asserts this same-domain invariant.

BUG=skia:4467

Review URL: https://codereview.chromium.org/1401053003

8 years agoRewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object...
bsalomon [Mon, 19 Oct 2015 15:24:08 +0000 (08:24 -0700)]
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done.

Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

Review URL: https://codereview.chromium.org/1409163002

8 years agoRemove unused member variables in GrGLProgram
egdaniel [Mon, 19 Oct 2015 14:23:02 +0000 (07:23 -0700)]
Remove unused member variables in GrGLProgram

BUG=skia:

Review URL: https://codereview.chromium.org/1416523003

8 years agoAdd imgblur tool to assist BlurMaskFilter debugging
robertphillips [Mon, 19 Oct 2015 13:39:17 +0000 (06:39 -0700)]
Add imgblur tool to assist BlurMaskFilter debugging

imgblur is intended to establish a ground truth for debugging mask blur issues. It performs a brute force (non-separable) Gaussian blur of the provided image.

The blur code itself is in sk_tools_utils so it can be more easily used programmatically in other places (e.g., blur unit tests).

Review URL: https://codereview.chromium.org/1384203002

8 years agoskia: Make the validate match interface for *_draw_instanced
hendrikw [Mon, 19 Oct 2015 13:13:55 +0000 (06:13 -0700)]
skia: Make the validate match interface for *_draw_instanced

For whatever reason, on the Mac, the command buffer is reporting
ARB_draw_instanced as a valid extension. This is probably a bug in the
command buffer and I'll look into this later.

In Skia, we don't check for ARB_draw_instanced in GLES2 when building
the interface, but during the validate, we do, so we ended up failing
the validation.

Looking a bit further at the specs, ARB_draw_instanced is GL only,
whereas EXT_draw_instanced is both GL and GLES.  I've updated the code
to reflect this.

See:
https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/specs/ARB/draw_instanced.txt
https://www.opengl.org/registry/specs/EXT/draw_instanced.txt

Everything above also applies to ARB/EXT_instanced_arrays

https://www.khronos.org/registry/gles/extensions/EXT/EXT_instanced_arrays.txt
https://www.opengl.org/registry/specs/ARB/instanced_arrays.txt

Review URL: https://codereview.chromium.org/1409053003

8 years agoSkRemote: impl drawRRect
halcanary [Sun, 18 Oct 2015 12:12:58 +0000 (05:12 -0700)]
SkRemote:  impl drawRRect

Review URL: https://codereview.chromium.org/1412013002

8 years agoUpdate SKP version
update-skps [Sun, 18 Oct 2015 07:23:36 +0000 (00:23 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1410283002

8 years agoSkRemote: simple impl of onDraw*Text*
halcanary [Sat, 17 Oct 2015 22:46:29 +0000 (15:46 -0700)]
SkRemote:  simple impl of onDraw*Text*

Review URL: https://codereview.chromium.org/1409273004

8 years agoSkRemote: impl onDrawDRRect
halcanary [Sat, 17 Oct 2015 22:18:35 +0000 (15:18 -0700)]
SkRemote: impl onDrawDRRect

Review URL: https://codereview.chromium.org/1410223002

8 years agoTest SkRemote on GCE bots.
mtklein [Sat, 17 Oct 2015 16:25:21 +0000 (09:25 -0700)]
Test SkRemote on GCE bots.

This will get us gathering GM images.
I will set up ignores on gold.skia.org so no one's bothered.

BUG=skia:

Review URL: https://codereview.chromium.org/1414563002

8 years agoRemove DrawingMgr shims from GrContext
robertphillips [Sat, 17 Oct 2015 14:43:27 +0000 (07:43 -0700)]
Remove DrawingMgr shims from GrContext

BUG=skia:4094

Review URL: https://codereview.chromium.org/1413673002

8 years agoSkRemote: impl drawPaint()
halcanary [Sat, 17 Oct 2015 13:11:52 +0000 (06:11 -0700)]
SkRemote: impl drawPaint()

Review URL: https://codereview.chromium.org/1409253003

8 years agoLookupScope does not need to be in SkRemote.h
mtklein [Fri, 16 Oct 2015 22:33:18 +0000 (15:33 -0700)]
LookupScope does not need to be in SkRemote.h

It's only used by Cache and Client.
This moves it to SkRemote.cpp, where they live.

BUG=skia:

Review URL: https://codereview.chromium.org/1409273002

8 years agoSuppression for valgrind bug
scroggo [Fri, 16 Oct 2015 21:42:47 +0000 (14:42 -0700)]
Suppression for valgrind bug

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

BUG=skia:4478

Review URL: https://codereview.chromium.org/1410953002

8 years agoRevert of Rewrite GrTextureMaker to disentangle bitmap case from base class and give...
egdaniel [Fri, 16 Oct 2015 20:59:14 +0000 (13:59 -0700)]
Revert of Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what… (patchset #4 id:60001 of https://codereview.chromium.org/1409163002/ )

Reason for revert:
breaking nanobench

Original issue's description:
> Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done.
>
> Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

TBR=reed@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1409923003

8 years agoRewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object...
bsalomon [Fri, 16 Oct 2015 20:35:10 +0000 (13:35 -0700)]
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done.

Review URL: https://codereview.chromium.org/1409163002