Miha Zupan [Thu, 10 Aug 2023 17:08:35 +0000 (19:08 +0200)]
Flow the IMeterFactory to SocketsHttpHandler on Mobile (#90298)
Ivan Diaz Sanchez [Thu, 10 Aug 2023 16:14:51 +0000 (09:14 -0700)]
Restored Crossgen2's optimizations in CoreCLR builds and reenabled the poisoning tests since the problem has been addressed. (#90278)
Jackson Schuster [Thu, 10 Aug 2023 16:13:51 +0000 (11:13 -0500)]
[ComInterfaceGenerator] Add implementation and test for CallerAllocateBufferType parameters (#90263)
Meri Khamoyan [Thu, 10 Aug 2023 15:45:21 +0000 (19:45 +0400)]
Enable isolates storage tests on maccatalyst (#90150)
Brennan [Thu, 10 Aug 2023 15:28:45 +0000 (08:28 -0700)]
Eliminate cancellation deadlock in RateLimiter implementations (#90285)
Viktor Hofer [Thu, 10 Aug 2023 15:15:41 +0000 (17:15 +0200)]
Mark Microsoft.NetCore.Platforms as non-shipping (#90297)
The full RID graph is frozen and won't change anymore. Mark the Microsoft.NETCore.Platforms nuget package as non-shipping as only the sdk repository still requires it.
Contributes to https://github.com/dotnet/runtime/issues/90000
Qiao Pengcheng [Thu, 10 Aug 2023 15:03:22 +0000 (23:03 +0800)]
[LoongArch64] Fix the `la.local` between the JIT_PatchedCodeStart (#90143)
* [LoongArch64] Fix the `la.local` between the JIT_PatchedCodeStart
and the JIT_PatchedCodeLast for the upstream's LA-compiler-bugs.
* Also update the `g_GCShadowEnd`.
* amend the code for CRs.
Pavel Savara [Thu, 10 Aug 2023 14:40:17 +0000 (16:40 +0200)]
[browser] make cachedResourcesPurgeDelay configurable (#90264)
Steve Harter [Thu, 10 Aug 2023 14:01:48 +0000 (09:01 -0500)]
For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory (#90119)
dotnet-maestro[bot] [Thu, 10 Aug 2023 13:58:47 +0000 (09:58 -0400)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230807.1 (#90146)
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23405.1 -> To Version 3.11.0-beta1.23407.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tomas Weinfurt [Thu, 10 Aug 2023 13:47:29 +0000 (06:47 -0700)]
make Https_MultipleRequests_TlsResumed Linux specific (#90286)
Jakob Botsch Nielsen [Thu, 10 Aug 2023 13:01:51 +0000 (15:01 +0200)]
JIT: Remove an overeager assert (#90302)
Physical promotion invokes `fgForwardSubStatement`, providing its own
liveness information, meaning that early liveness is no longer the only
source of liveness information in this function. This made it possible
to hit an assert when early liveness was disabled via
`DOTNET_JitEnableEarlyLivenessRange`.
Remove the overeager assert and leave it up to the caller to ensure that
there is valid liveness information (`GTF_VAR_DEATH`) when forward sub
is invoked.
Fix #90295
Lakshan Fernando [Thu, 10 Aug 2023 12:16:51 +0000 (05:16 -0700)]
Remove EnableNativeEventPipe property (#90274)
Jakob Botsch Nielsen [Thu, 10 Aug 2023 12:12:45 +0000 (14:12 +0200)]
Fix intrinsics test failure log messages (#90267)
Johan Lorensson [Thu, 10 Aug 2023 11:06:11 +0000 (13:06 +0200)]
Add additional filter capabilities to dotnet-pgo tool. (#89853)
Mono adopted PGO in .net7 as a replacement for a
solution called profiled AOT in mono/mono used by Android
SDK. In the replaced solution there was a concept of
a stop trigger, meaning that the user could collect methods
up to a stop trigger (a method name) meaning that the
profiled AOT image would only include methods up to that point.
When using EventPipe and nettrace there is limited ability to
get the same fine grained control over what methods that ends
up in the nettrace file. dotnet-monitor includes ways to stop
tracing if it hits for example a specific method, but due to the
nature of EventPipe, there could still be additional methods added
to the trace when closing session. dotnet-trace currently don't offer
any ability to do something similar, but if implemented, it
would probably come with the same limitations as dotnet-monitor.
Adding better filter capabilities to dotnet-pgo would add additional
capabilities, giving users more control on what methods that gets
included into the generated mibc file. That would give Mono's
profiled AOT better control to include methods up to a stop trigger.
dotnet-pgo alread had capabilities to include events based on timestamp
interval. This commit extends that to select the lower/upper timestamp
based on a regular expression matching methods. This commit also
adds capabilities to add a method include/exclude filters using regular
expression, giving users fine grained control on what methods to
include/exclude in the generated mibc file.
The additional filter capabilities could be used by Android SDK to
for example create a mibc file including all methods up to Main,
replacing the stop trigger features used in old profiled AOT solution.
---------
Co-authored-by: mdh1418 <mitchhwang1418@gmail.com>
Kunal Pathak [Thu, 10 Aug 2023 11:05:46 +0000 (04:05 -0700)]
Lsra JitStressRegs mode SpillAlways fixes (#89720)
* fix few scenarios for spillAlways()
* Include JitStressRegs=0x800
* Revert "Include JitStressRegs=0x800"
This reverts commit
170233235b3e24530386f48569a3e6f9d1de2b70.
Matous Kozak [Thu, 10 Aug 2023 08:47:51 +0000 (10:47 +0200)]
[mono] Adding support for Vector128::ExtractMostSignificantBits intrinsics on amd64 (#89997)
* Extract MSB amd64
* add SSSE3 check
Miha Zupan [Thu, 10 Aug 2023 06:53:34 +0000 (08:53 +0200)]
Report exception type name in Http metrics (#90221)
* Report exception type name in Http metrics
* Mention 'Unknown' in a comment instead
Mark Plesko [Thu, 10 Aug 2023 06:45:43 +0000 (23:45 -0700)]
Fix "Passed test" output
Andy Gocke [Thu, 10 Aug 2023 05:46:00 +0000 (22:46 -0700)]
Remove --flat from default dsymutil options (#89358)
--flat is a diagnostic-only option and not fully supported. It
can still be specified if necessary through the DsymUtilOptions
property and NativeSymbolExt property, but it will no longer be
the default.
Aaron Robinson [Thu, 10 Aug 2023 04:22:23 +0000 (21:22 -0700)]
Address some code nits (#90289)
Steve Pfister [Thu, 10 Aug 2023 03:59:20 +0000 (20:59 -0700)]
[iOS] Disable failing CI tests (#90181)
A few System.Formats.Tar tests are failing due to the length of the path exceeding the limit. Additionally, other customer scenario tests that we don't need to run on mobile configurations weren't being skipped, but now are.
Tom McDonald [Thu, 10 Aug 2023 01:39:00 +0000 (21:39 -0400)]
Debugger IPC creation failure should not abort coreclr startup (#90161)
* Debugger IPC creation failure should not abort coreclr startup
* Add log message for debugger pipe init failure
* Use Stress log instead of COMPLUS logging
Mitchell Hwang [Thu, 10 Aug 2023 00:33:34 +0000 (20:33 -0400)]
[libs][Android] Reenable Trace_ClearTraceListeners_StopsWritingToDebugger test (#90242)
Removes unnecessary ActiveIssue discovered in https://github.com/dotnet/runtime/issues/50570#issuecomment-
1671049438
Sven Boemer [Thu, 10 Aug 2023 00:32:37 +0000 (17:32 -0700)]
Use current runtime version in ILLink.Tasks package (#90197)
The ILLink.Tasks package should have a runtimeconfig.json that
matches the runtime version bundled with the SDK that references
it. This used to be done by stomping the runtime version in the
dotnet/sdk build, but ILLink.Tasks is no longer bundled with the
SDK so we need to do this ourselves.
Tests that use live ILLink bits need to continue working with the
SDK specified in global.json, so this preserves the existing
illink.runtimeconfig.json in the build output, but defines an
additional illink.runtimeconfig.pack.json file that uses the
current runtime version. The pack.json file is included in the
package (with the name illink.runtimeconfig.json) instead of the
original.
This includes a fix for
429a5c3a2ea096758c2b9b8907a8231d4e686a46:
we weren't actually using live illink for tests due to an
ordering issue introduced in response to feedback on that change.
The Directory.Build.props is imported too early (before the nuget
props that this is trying to override), so we need to import
Microsoft.NET.ILLink.props directly from the project file.
---------
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Steve Pfister [Thu, 10 Aug 2023 00:27:57 +0000 (17:27 -0700)]
[iOS] Add Macatalyst support for library mode (#90237)
This change allows you to target maccatalyst for building full, self-contained libraries.
Aaron Robinson [Wed, 9 Aug 2023 23:15:05 +0000 (16:15 -0700)]
Fix up `InlineArray` tests (#90192)
* Convert invalid C# to IL project
Ruihan-Yin [Wed, 9 Aug 2023 22:55:58 +0000 (15:55 -0700)]
Add `emitDispEmbBroadcastCount` to display the embedded broadcasted element count. (#90123)
* Add `emitDispEmbBroadcastCount` to display
the embedded broadcasted element count.
* Resolve comments:
rename the previous `emitGetMemOpSize` to `emitGetBaseMemOpSize`,
the new `emitGetMemOpSize` will check if EVEX.b is set and return the
memory size accordingly.
* bug fixes:
added 2 missing break
* resolve comments:
1. remove un-needed helper function.
2. move the Evexb check into the display function.
Jakob Botsch Nielsen [Wed, 9 Aug 2023 22:39:17 +0000 (00:39 +0200)]
JIT: Fix emitSplit to properly handle the remainder (#90246)
emitSplit did not handle the edge case where the last instruction group
of the function/funclet resulted in the size to overflow the max. Use a
lambda so we can call the necessary code both as part of the loop and
after the loop.
Fix #85063
David Mason [Wed, 9 Aug 2023 22:31:53 +0000 (15:31 -0700)]
Add debug output to BasicEventSourceTests.TestsManifestGeneration.Test_EventSource_EtwManifestGenerationRollover (#90198)
Vladimir Sadov [Wed, 9 Aug 2023 21:28:50 +0000 (14:28 -0700)]
[NativeAOT][8.0] Make casting logic closer to CoreCLR (#90234)
* Refactored AssignmentVariation
* refactored similar to coreclr
* fix build
* simpler selection of runtime helpers for casts
* add a codegen test
Jackson Schuster [Wed, 9 Aug 2023 20:16:30 +0000 (15:16 -0500)]
Reword diagnostic about which types can use [out], remove unused diagnostics (#90188)
Stephen Toub [Wed, 9 Aug 2023 19:01:53 +0000 (15:01 -0400)]
Add CollectionBuilder attribute to some immutable collection interfaces (#89459)
Tomáš Rylek [Wed, 9 Aug 2023 18:59:35 +0000 (20:59 +0200)]
Remove spurious assertion check causing .NET Core crashes (#89986)
* Remove spurious assertion check causing .NET Core crashes
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Pavel Savara [Wed, 9 Aug 2023 18:53:49 +0000 (20:53 +0200)]
[browser] doc node SIMD+EH, dev tools (#90147)
Will Smith [Wed, 9 Aug 2023 18:50:13 +0000 (11:50 -0700)]
[JIT] ARM64 vector right-shift must dead-code eliminate if the constant is zero. (#90051)
* ARM64 vector right-shift must dead-code eliminate if the constant is zero
* Update emitarm64.cpp
* Use proper size
* Formatting
* Formatting
* Fixing test
* Add comment
* Add comment
Alexander Köplinger [Wed, 9 Aug 2023 18:46:45 +0000 (20:46 +0200)]
Add IgnoreForCI property to certain no-op test suites (#90238)
A couple projects have all tests disabled, it makes no sense to send them to Helix to run 0 tests.
dotnet-maestro[bot] [Wed, 9 Aug 2023 16:03:28 +0000 (12:03 -0400)]
[main] Update dependencies from dotnet/roslyn (#89977)
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23403.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230804.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23404.11
* Update dependencies from https://github.com/dotnet/roslyn build
20230805.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23405.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230806.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23406.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230807.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23407.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230808.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23403.1 -> To Version 4.8.0-1.23408.8
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ilona Tomkowicz [Wed, 9 Aug 2023 15:40:37 +0000 (17:40 +0200)]
[Blazor] Add basic ICU tests (#89771)
* Fix the logic + add simple tests.
* Fix non-icu-sharding tests.
* Split ICU WBT file - it was running long on CI.
* Add new wbt files to CI jobs.
* Split sharding wbt into classes ~equal no. of test cases.
* And update job list.
* Fix `File sizes don't match for dotnet.native.wasm`.
* Move file to fix class not found.
* Cleanup.
* Propagate warning update.
* @radical's suggestions.
* Build fix.
* Null test cases.
* Add running the apps.
* @radical's feedback
* Changing type of template required update in options.
* Fix "file sizes don't match for dotnet.native.wasm".
Steve Pfister [Wed, 9 Aug 2023 15:40:05 +0000 (08:40 -0700)]
[iOS][Android] Fix up library mode build (#90133)
This change makes sure the mobile build task assembly is properly imported, corrections on the LLVM path, and other small minor tweaks.
Jakob Botsch Nielsen [Wed, 9 Aug 2023 15:35:49 +0000 (17:35 +0200)]
JIT: Fix intrinsic recognition for System.Math.Tanh (#90227)
Fix #88451
Steve Harter [Wed, 9 Aug 2023 14:58:54 +0000 (09:58 -0500)]
Add extension methods for creating OptionsBuilder with ValidateOnStart support (#89973)
Steve Harter [Wed, 9 Aug 2023 14:00:33 +0000 (09:00 -0500)]
Abort startup if Starting, Start or Started fails (#90183)
anatawa12 [Wed, 9 Aug 2023 13:53:36 +0000 (22:53 +0900)]
Make ComHost.Create throw InvalidTypeLibraryException if type library is empty file (#90220)
Milos Kotlar [Wed, 9 Aug 2023 13:27:45 +0000 (15:27 +0200)]
Add LLVM-AOT support to the sample app (#90152)
Ilona Tomkowicz [Wed, 9 Aug 2023 13:06:10 +0000 (15:06 +0200)]
Fix tests for NodeJS. (#90223)
Thays Grazia [Wed, 9 Aug 2023 12:56:55 +0000 (09:56 -0300)]
[mono][debugger] Support debug inline array (#90026)
* Support debug inline array for wasm
* Removing extra tab
* Changing behavior to use the same protocol version on wasm and on debugger-libs.
* Revert last changes
* Adding changes for debugger-libs support
* Change where we send the information about inline array.
* fix wasm compilation
* Addressing @radical comments
Fixing other tests.
* Fix wrong change.
* Adding more tests as suggested by @radical
Alexander Köplinger [Wed, 9 Aug 2023 12:41:26 +0000 (14:41 +0200)]
Apply objc_msgsend fix to src/mono too and fix build on earlier Xcode (#90217)
We were missing the objc_msgsend fix from https://github.com/dotnet/runtime/pull/89932 in the mono build.
Also fix an issue where CMake would complain about wrong number of arguments when CLR_CMAKE_COMMON_OBJC_FLAGS is empty, we need put the variable in quotes.
rhirano0715 [Wed, 9 Aug 2023 12:19:38 +0000 (21:19 +0900)]
Unified to throw NotSupportedException when SendFile() for connectionless sockets (#87108)
* Unified to throw NotSupportedException when SendFile() for connectionless sockets
The issue was that the Socket.SendFile() threw inconsistent exceptions when the platform was Windows and the protocol was UDP.
The first call would throw a SocketException, while the second call would throw a NotSupportedException.
With this commit, SendFile() will consistently throw NotSupportException on all platforms when the protocol is UDP.
Fix #47472
* Change to throws `NotSupportedException` if `!IsConnectionOriented` or `!Connected`.
Before:.
Throws `NotSupportedException` on UDP.
After:
Throws `NotSupportedException` if `!IsConnectionOriented` or `!Connected`.
* Changed test case `UdpConnection_ThrowsException` to run regardless of platform.
* Update src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs
Co-authored-by: Karel Zikmund <karelz@microsoft.com>
---------
Co-authored-by: Karel Zikmund <karelz@microsoft.com>
Natalia Kondratyeva [Wed, 9 Aug 2023 09:46:11 +0000 (10:46 +0100)]
[HttpClientFactory] Remove dependency on ILoggerFactory (#89531)
* Remove dependency on ILoggerFactory
* Add test
* PR feedback & add more tests
* PR feedback
Alexander Köplinger [Wed, 9 Aug 2023 09:45:15 +0000 (11:45 +0200)]
Bump timeouts on Android/iOS devices jobs (#90178)
The Helix queues on these jobs are often backed up which causes failed builds that we can avoid by bumping the timeout.
Aleksey Kliger (λgeek) [Wed, 9 Aug 2023 05:47:42 +0000 (01:47 -0400)]
[hot_reload] ignore modified MONO_TABLE_TYPEDEF rows in update (#90166)
* Add test that deletes a custom attribute from a class
* just ignore modified MONO_TABLE_TYPEDEF rows in updates
We may want to validate that Parent, Interfaces and Attributes columns haven't changed, but it's tricky and might be overly restrictive
Per Lundberg [Wed, 9 Aug 2023 05:04:18 +0000 (08:04 +0300)]
Fix Dragon4 tutorial URL (#90186)
Elinor Fung [Wed, 9 Aug 2023 01:42:37 +0000 (18:42 -0700)]
Remove some unnecessary indirection to DiagnosticServerAdapter/EventPipeAdapter in nativeaot (#90132)
Egor Bogatov [Wed, 9 Aug 2023 01:30:21 +0000 (03:30 +0200)]
Ignore some tests on macOS only due to small stack size (#90116)
Pavel Savara [Wed, 9 Aug 2023 01:07:41 +0000 (03:07 +0200)]
[browser] fix order of libraryInitializers execution (#90189)
Eduardo Velarde [Wed, 9 Aug 2023 01:01:00 +0000 (18:01 -0700)]
Enable IOPack, IOEnqueue, and IODequeue on Windows (#88894)
Enable IOPack, IOEnqueue and IODequeue for the Windows Threadpool (the one NativeAOT uses by default).
Aaron Robinson [Wed, 9 Aug 2023 00:45:51 +0000 (17:45 -0700)]
Enable support for generic methods with IDIC (#90180)
Jackson Schuster [Tue, 8 Aug 2023 23:42:56 +0000 (18:42 -0500)]
Add Fact (#90202)
Tomas Weinfurt [Tue, 8 Aug 2023 23:23:44 +0000 (16:23 -0700)]
add ReceiveFromAsync and SendToAsync with SocketAddress overload (#90086)
* cleanup
* update
* cleanup
* feedback
* udpdate
* pal
* windows
* equals
Jackson Schuster [Tue, 8 Aug 2023 22:37:37 +0000 (17:37 -0500)]
PinnedMarshal after marshalling in unmanaged to managed (#90117)
PinnedMarshal has the "FromManaged" call in stateful marshallers, so that needs to happen before marshal in unmanaged to managed stubs.
Alexander Soldatov [Tue, 8 Aug 2023 22:20:16 +0000 (01:20 +0300)]
[RISC-V] Add g_GCShadowEnd to JIT_WriteBarrier_Table (#90036)
lla pseudo instruction which used for access to g_GCShadowEnd
in JIT_WriteBarrier implemented via PC-relative addressing. But when
W^X enabled, copy of JIT_WriteBarrier is being created and this PC-related
addressing is not valid, which cause crash.
This change moves address of g_GCShadowEnd to JIT_WriteBarrier_Table like
others variables used in Write Barrier.
Tom McDonald [Tue, 8 Aug 2023 21:48:58 +0000 (17:48 -0400)]
Add EnableDiagnostics sub-configs for IPC, debugger, and profiler (#90159)
Jackson Schuster [Tue, 8 Aug 2023 21:47:45 +0000 (16:47 -0500)]
Cleanup caller allocated and callee allocated resources separately (#89982)
This PR separates cleaning up caller allocated resources and callee allocated resources into separate stages in the managed to unmanaged direction. Caller allocated parameters (anything except 'out') will clean up the same way. Callee allocated parameters ('out' parameters) will be cleaned up only if the invocation succeeded.
Tarek Mahmoud Sayed [Tue, 8 Aug 2023 19:20:25 +0000 (12:20 -0700)]
Fix Activity Baggage logging scope (#90127)
Marek Fišera [Tue, 8 Aug 2023 19:03:23 +0000 (21:03 +0200)]
[browser] Read `AssetTraitValue` to get culture for resource during webcil transformation (#89600)
* Read AssetTraitValue when determining culture for resource during webcil transformation
* Add WBT with Blazor with resources in two cultures and build+publish
* Check for emcc-link.rsp instead of that for-build directory exists
* track api changes in main
* Avoid using unicode character in an unrelated test name. it breaks emcc build on windows
---------
Co-authored-by: Ankit Jain <radical@gmail.com>
Tomáš Rylek [Tue, 8 Aug 2023 18:43:50 +0000 (20:43 +0200)]
Crossgen2 support for static virtual method resolution (take 2) (#87438)
This change adds SVM resolution support to Crossgen2. We still resort to
runtime JIT in case we cannot resolve the SVM call at compile time (typically for
canonical generic methods); some of these cases are just due to current limitations
of the JIT interface and can be fixed in the future.
Thanks
Tomas
Jackson Schuster [Tue, 8 Aug 2023 17:56:48 +0000 (12:56 -0500)]
use correct marshaller for elements (#90176)
Miha Zupan [Tue, 8 Aug 2023 17:44:03 +0000 (19:44 +0200)]
Simplify Http2Connection shutdown/dispose logic (#90094)
* Simplify Http2Connection shutdown/dispose logic
* Add a test for SocketsHttpHandler disposal mid request
Jo Shields [Tue, 8 Aug 2023 17:31:27 +0000 (13:31 -0400)]
Try to fix missing libc++.so.1 errors in arm64 llvmaot perf run (#88705)
* Try to fix missing libc++.so.1 errors in arm64 llvmaot perf run
* Pass required flags for AOT build of Mono
Steve Pfister [Tue, 8 Aug 2023 16:29:57 +0000 (09:29 -0700)]
[iOS] Generate unique class name for MonoDeadLetter (#89956)
In library mode, it is possible to have multiple shared libraries (runtimes) loaded in the same process. On iOS, we have a small bit of objc to make sure we know when threads die so we can properly detach the runtime. Unfortunately, the class name we use is not unique and results in a crash when calling into a 2nd library.
This change makes the class name partially unique to avoid such a circumstance.
Jeremy Koritzinsky [Tue, 8 Aug 2023 16:28:09 +0000 (09:28 -0700)]
Use bidirectional marshallers for elements. (#90056)
anatawa12 [Tue, 8 Aug 2023 16:18:54 +0000 (01:18 +0900)]
Crossplatform ResourceUpdater (#89303)
This enables cross-builds of windows applications on non-windows to have updated win32 resources. It also removes the need to open/write the app host multiple times during build.
Meri Khamoyan [Tue, 8 Aug 2023 15:53:11 +0000 (19:53 +0400)]
[iOS][non-icu] HybridGlobalization implement calendar data (#90004)
Implement calendar info for hybrid mode on iOS
Pavel Savara [Tue, 8 Aug 2023 15:36:49 +0000 (17:36 +0200)]
[browser] don't propagate JS errors in WS abort (#90148)
Aaron Robinson [Tue, 8 Aug 2023 14:38:54 +0000 (07:38 -0700)]
Support `DllImportSearchPath.AssemblyDirectory` for NativeAOT applications (#90120)
* NativeAOT - Suppress OS dialog for LoadLibrary failures
on Windows.
* Update NativeAOT to load from application
directory when DllImportSearchPath.AssemblyDirectory
is defined.
Lakshan Fernando [Tue, 8 Aug 2023 13:35:41 +0000 (06:35 -0700)]
Cleanup work (#89976)
* Cleanup work
* FB
* test fix
* Implement per-thread activity_id
* FB
* Update src/coreclr/nativeaot/Runtime/eventpipeinternal.cpp
Co-authored-by: Elinor Fung <elfung@microsoft.com>
* replace pThread with activityIdHandle
* increase helix timeout for checked aot run
---------
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Vlad Brezae [Tue, 8 Aug 2023 13:30:43 +0000 (16:30 +0300)]
[tests] Attempt to enable test (#89498)
Egor Bogatov [Tue, 8 Aug 2023 13:16:10 +0000 (15:16 +0200)]
Mark XxHash64.Complete as noinline (#90142)
Pavel Savara [Tue, 8 Aug 2023 12:00:57 +0000 (14:00 +0200)]
[browser] app start benchmark fix, loadBootResource fix (#89857)
Co-authored-by: Ankit Jain <radical@gmail.com>
Eirik Tsarpalis [Tue, 8 Aug 2023 09:37:01 +0000 (12:37 +0300)]
Ensure OuterLoop test doesn't use reflection in SG test suite. (#90137)
James Newton-King [Tue, 8 Aug 2023 09:06:26 +0000 (17:06 +0800)]
Fix host debug view not showing services before start (#89610)
Egor Bogatov [Tue, 8 Aug 2023 08:10:39 +0000 (10:10 +0200)]
Change generation for NonGC objects for debugger (#89927)
Eirik Tsarpalis [Tue, 8 Aug 2023 07:50:11 +0000 (10:50 +0300)]
Fix analyzer warning that is breaking the build (#90136)
Mike McLaughlin [Tue, 8 Aug 2023 03:12:16 +0000 (20:12 -0700)]
Serialize createdump core dump generation (#90130)
* Serialize createdump core dump generation
Only allow one thread at a time to generate a core dump.
Issue: https://github.com/dotnet/runtime/issues/82989
* Code review feedback. Move serializing code into PROCCreateCrashDump
* Code review feedback - put while (true) around poll()'s
Steve Pfister [Tue, 8 Aug 2023 03:02:08 +0000 (20:02 -0700)]
[iOS] Remove cmake build dependency for library mode (#89869)
This change removes cmake as a build dependency and instead uses clang directly when building for iOS/tvOS/Macatalyst library mode.
Will Smith [Tue, 8 Aug 2023 02:43:48 +0000 (19:43 -0700)]
[JIT] Do not force creation of a new IG if the current IG has no instructions (#89876)
* Added 78891 test
* Fix name
* Fix test
* Feedback
* 78891 test is process isolated to use the environment variables. When enabling GC in the emitter, if the current IG has no instructions, do not force a new IG.
* Remove extend flag
* Quick cleanup
* Quick cleanup
* Update Runtime_78891.csproj
* Feedback
* Fix test
* Fix test
* Reset flags
* Fix test
* Fixing test again...
* Only set the NOGCINTERRUPT flag accordingly
Aaron Robinson [Tue, 8 Aug 2023 02:00:24 +0000 (19:00 -0700)]
Replace `SetErrorMode` with `SetThreadErrorMode`. (#90122)
* Replace SetErrorMode with SetThreadErrorMode.
Replaces all possible locations.
Removed SetErrorMode from PAL.
Egor Bogatov [Tue, 8 Aug 2023 01:11:30 +0000 (03:11 +0200)]
Check IsBaselineSimdIsaSupported in LocalAddressVisitor (#90099)
Juan Hoyos [Tue, 8 Aug 2023 00:46:45 +0000 (17:46 -0700)]
Update DAC's CMakeLists to create longname pdb (#90109)
Thays Grazia [Tue, 8 Aug 2023 00:05:30 +0000 (21:05 -0300)]
[wasm][debugger] Support indexing Dictionary by string key (#90108)
* Enabling tests, they are working.
* Adding more tests.
Jackson Schuster [Tue, 8 Aug 2023 00:01:45 +0000 (19:01 -0500)]
Make [In] the default for blittable arrays that are pinned (#90054)
* Make [In] the default for blittable arrays that are pinned
Miha Zupan [Mon, 7 Aug 2023 23:53:21 +0000 (01:53 +0200)]
Simplify invalid hostname check in DomainNameHelper (#90088)
Ankit Jain [Mon, 7 Aug 2023 23:24:51 +0000 (19:24 -0400)]
[wasm] perf: Use node 16.x, and update v8 paths to track that (#90113)
Anton Firszov [Mon, 7 Aug 2023 22:39:59 +0000 (00:39 +0200)]
add units to http metrics (#90020)
Wasiim Hosenbocus [Mon, 7 Aug 2023 22:27:30 +0000 (18:27 -0400)]
Inconsistent DebuggerDisplay formatting - Fix space, equal for name/value and Indirect Value (#89370)
* Fix space, equal for name/value in DebuggerDisplay
Task 1 - Replace colons with equal, added spaces in between key/value
* Fix failing test
* Update src/libraries/System.Speech/src/Result/SemanticValue.cs
Co-authored-by: James Newton-King <james@newtonking.com>
* Update src/libraries/System.Threading/src/System/Threading/Barrier.cs
Co-authored-by: James Newton-King <james@newtonking.com>
* Update src/libraries/System.Threading/src/System/Threading/CountdownEvent.cs
Co-authored-by: James Newton-King <james@newtonking.com>
* Changes to indirect value in Debugger
Changing string in indirect value; either part of a variable or a method
* Revert Stopwatch debug string
---------
Co-authored-by: James Newton-King <james@newtonking.com>
Jakob Botsch Nielsen [Mon, 7 Aug 2023 22:13:53 +0000 (00:13 +0200)]
SPMI: Fix build (#90118)
Jackson Schuster [Mon, 7 Aug 2023 21:58:17 +0000 (16:58 -0500)]
GetUnmanagedValues[Source|Destination] by marshal direction, not stub direction (#90057)
Jakob Botsch Nielsen [Mon, 7 Aug 2023 21:02:32 +0000 (23:02 +0200)]
SPMI: Throw distinguished exception for recorded exceptions (#89978)
Switch back to this scheme, since only looking for the managed exception
code does not handle crossgen2/ilc (they throw exceptions across the
JIT-EE interface as normal C++ exceptions).
I've verified that the JIT does not look closely at the exception codes
thrown in any of the places it does EH, which comes down to
`impJitErrorTrap` and `runWithErrorTrap`. So changing the exception code
should not result in any behavior differences.
Ilona Tomkowicz [Mon, 7 Aug 2023 20:51:42 +0000 (22:51 +0200)]
[browser][non-icu] `HybridGlobalization` calendar data (#89255)
* Calendar WIP.
* Genitive months.
* Short pattern.
* NativeCalendarName does not exist on WebAPI - use EnglishCalendarName.
* Fix failures in Locales caused by calendars data removal.
* Fix to previous commit.
* Whitespace.
* Implemented Eras.
* Populate NativeName with EnglishName.
* Fix tests.
* Typos + comments removal + block failing test.
* AM/PM designators are not in ICU anymore.
* ShortTimePattern is ready.
* Fix some failing tests.
* LongTimePatterns is ready.
* Ask about all culture info from JS at once.
* Fix remaining tests.
* Calendar Globalization tests fixed.
* Adding test files to projects.
* Build fix.
* Fix the fix.
* .
* Fix tests.
* Load locale info on request + fix Browser scenario tests.
* Fix test on v8.
* Forgotten clean-up.
* Small cleanup in ts.
* V8 11 is behaves more like browser.
* Fixed skipped failing tests.
* Syntax
* V8 returns the same as Browser.
* This API is not affected, no need to test. + Add documentation.
* Revert unintentional change.
* Feedback.
* @radical's feedback + fix after removing unnecessary set.
* Fix.
* Feedback.
* Fix tests.