platform/core/csapi/xsf.git
5 years agoMerge branch '4.2.0'
Samantha Houts [Thu, 11 Jul 2019 22:45:25 +0000 (15:45 -0700)]
Merge branch '4.2.0'

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 11 Jul 2019 22:44:58 +0000 (15:44 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoFixed: Button CornerRadius doesn't work in explicit style (#6753)
Mike Schwörer [Thu, 11 Jul 2019 08:52:18 +0000 (10:52 +0200)]
Fixed: Button CornerRadius doesn't work in explicit style (#6753)

- fixes #5046

* Fixed #5046 - Button CornerRadius doesn't work in explicit style

* Added Unit Test

* Requested changes from PR

* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests

* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Do not add ButtonCornerRadius in csproj

* removed dangling changes in ButtonUnitTest.cs

5 years agocleanup: moved closing brace to new line (#6793)
Geoffrey Huntley [Thu, 11 Jul 2019 01:38:41 +0000 (11:38 +1000)]
cleanup: moved closing brace to new line (#6793)

5 years agoAdd protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
Andrei Nitescu [Thu, 11 Jul 2019 01:35:25 +0000 (04:35 +0300)]
Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)

fixes #6747

5 years ago[Android] Uniformize handler name (CollectionView) (#6720)
Kevin Petit [Thu, 11 Jul 2019 01:34:26 +0000 (03:34 +0200)]
[Android] Uniformize handler name (CollectionView) (#6720)

* CollectionView - Uniformize handler name.

* Address naming feedback.

* Revert BOM.

5 years agoAuto-focus next view from Entry with ReturnType.Next (#6706)
Joe Manke [Wed, 10 Jul 2019 17:18:42 +0000 (13:18 -0400)]
Auto-focus next view from Entry with ReturnType.Next (#6706)

* Automatically focus the next view after hitting the Return key on an Entry with ReturnType.Next

* UWP implementation

5 years agoMerge branch '4.2.0'
Stephane Delcroix [Wed, 10 Jul 2019 12:24:32 +0000 (14:24 +0200)]
Merge branch '4.2.0'

5 years ago[X] hide TypedBinding from Intelisense
Stephane Delcroix [Wed, 10 Jul 2019 10:18:17 +0000 (12:18 +0200)]
[X] hide TypedBinding from Intelisense

5 years agoFix Page implicit and inherited style with ControlTemplate #6657 (#6661)
Andrei Nitescu [Wed, 10 Jul 2019 02:03:16 +0000 (05:03 +0300)]
Fix Page implicit and inherited style with ControlTemplate #6657 (#6661)

* Fix Page implicit and inherited style with ControlTemplate #6657

* Update StyleTests.cs
fixes #6657

5 years ago[Android] Fix KeyNotFoundException during Shell Navigation (#6740)
Alan Grgic [Wed, 10 Jul 2019 00:24:10 +0000 (19:24 -0500)]
[Android] Fix KeyNotFoundException during Shell Navigation (#6740)

* fix android shell nav crash

* add reproduction test

* add automation and address feedback

* move fragmet creation of stack items to after switch statement

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* [iOS] fix shell section disposals so multiple page renderers don't get assigned

5 years agoImplemented Padding on WPF Button (#6791)
Gerald Versluis [Tue, 9 Jul 2019 21:46:35 +0000 (23:46 +0200)]
Implemented Padding on WPF Button (#6791)

* Implemented Padding on WPF Button

* Update Padding when BorderWidth is updated

* Implemented Padding for ImageButton

* Apply suggestions from code review

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6790

5 years agocleanup: corrected spelling mistake (#6794)
Geoffrey Huntley [Tue, 9 Jul 2019 20:18:59 +0000 (06:18 +1000)]
cleanup: corrected spelling mistake (#6794)

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Tue, 9 Jul 2019 17:50:41 +0000 (10:50 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoRelativeSource Binding (#4375)
Peter Moore [Tue, 9 Jul 2019 10:10:13 +0000 (05:10 -0500)]
RelativeSource Binding (#4375)

RelativeSource Binding

- fixes #3847

Implement RelativeSource binding modes for Self, TemplatedParent, and FindAncestor. Add unit tests. Pare down TemplateBinding class to use RelativeSource binding mechanism.

* Include RelativeSource member in Binding.Clone

* Fix issue of unit tests being tricked by async in Binding.Apply; permit "Source={RelativeSource...}" in addition to "RelativeSource={RelativeSource..."; allow FindAncestor relative binding source mode to be based on BindingContext type or control type

* Fix unit test wasn't actually testing "Source={RelativeSource...}" syntax.

* Address @StephaneDelcroix's comments. Make FindAncestor relative source binding work even when the ancestor changes.

* Much better mechanism for detecting when a parent changes for relativesource

* Cleanup

* more cleanup

* more cleanup

* Remove async/await for identifying templated parent and ancestor type binding source

* Remove unused code; fix linting

* Update Xamarin.Forms.Core/Binding.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Ensure TemplateBinding works correctly when reparenting. Cleanup.

* Finish addressing comments; linting cleanup

* Remove private modifier where unneeded

5 years agoMerge branch '4.2.0'
Samantha Houts [Tue, 9 Jul 2019 01:55:31 +0000 (18:55 -0700)]
Merge branch '4.2.0'

5 years agoFix for Switch on Android losing shadow #6798 (#6798)
Andrei Nitescu [Mon, 8 Jul 2019 23:51:37 +0000 (02:51 +0300)]
Fix for Switch on Android losing shadow #6798 (#6798)

5 years agoReimplement ITabStop to return the EditText on Android Material renderers that use...
Joe Manke [Mon, 8 Jul 2019 23:17:05 +0000 (19:17 -0400)]
Reimplement ITabStop to return the EditText on Android Material renderers that use TextInputLayout as the native Control (#6732)

fixes #5102

5 years ago[X] Allow x:Null for x:DataType (#6822)
Stephane Delcroix [Mon, 8 Jul 2019 23:03:32 +0000 (01:03 +0200)]
[X] Allow x:Null for x:DataType (#6822)

- fixes #6648

5 years ago[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
Shane Neuville [Sun, 7 Jul 2019 22:08:31 +0000 (16:08 -0600)]
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)

* [ios] fix safeareas and use marging to offset flyout

* android fixes for margin

* [iOS] frame size and inset fixes

* android fix header offset

* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* top offset fixes

* add mask back in for scrolling header

* fix NRE when FlyoutHeader is null

* tweak Bugzilla26993Test

5 years agoMerge branch '4.2.0'
ShaneN [Sat, 6 Jul 2019 19:59:12 +0000 (13:59 -0600)]
Merge branch '4.2.0'

5 years agoClear global routes on unit tests and process global routes in the right place (...
Shane Neuville [Sat, 6 Jul 2019 19:56:10 +0000 (13:56 -0600)]
Clear global routes on unit tests and process global routes in the right place (#6781)

* Clear global routes on unit tests and process global routes in the right place

* - route with current item in case shellSection is null

* inset ui test fix

* Fix ColorFilter for API 19

* add missing file

5 years agoFix for #6444: Propagate binding context for children of shell sections (#6730)
Christopher Dresel [Fri, 5 Jul 2019 18:29:42 +0000 (20:29 +0200)]
Fix for #6444: Propagate binding context for children of shell sections (#6730)

* Propagate binding context for children of shell sections

* Added a few more BindingContext Propagation tests

5 years agoCreate UI test template for XAML pages (#5853)
adrianknight89 [Thu, 4 Jul 2019 04:09:02 +0000 (23:09 -0500)]
Create UI test template for XAML pages (#5853)

* create template for XAML pages

* update existing template

* added BindingContext

* removed whitespace

* move BindingContext

* change class name to Issue

* fixed absolute path

5 years agobump gitinfo
Samantha Houts [Thu, 4 Jul 2019 03:58:43 +0000 (20:58 -0700)]
bump gitinfo

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 4 Jul 2019 03:49:49 +0000 (20:49 -0700)]
Merge branch '4.1.0'

5 years agoFix Map Gallery page (#6603)
Andrei Nitescu [Thu, 4 Jul 2019 00:31:27 +0000 (03:31 +0300)]
Fix Map Gallery page (#6603)

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 4 Jul 2019 00:16:32 +0000 (17:16 -0700)]
Merge branch '4.1.0'

5 years agoAdd Color.ToHex() (#6272)
David Roqueni [Thu, 4 Jul 2019 00:13:01 +0000 (17:13 -0700)]
Add Color.ToHex() (#6272)

* Updated Color to have ToHex() method. Created Unit tests to ensure method is working as expected.

* Updated ToHex() use uint values. Updated unit tests for ToHex.
fixes #6003

5 years agoSwitch ThumbColor (#6312)
Andrei Nitescu [Thu, 4 Jul 2019 00:08:56 +0000 (03:08 +0300)]
Switch ThumbColor (#6312)

fixes #5415

5 years agoAdd constructor in WkWebViewRenderer to use custom configuration (#6578)
Ravinder Jangra [Thu, 4 Jul 2019 00:05:55 +0000 (05:35 +0530)]
Add constructor in WkWebViewRenderer to use custom configuration (#6578)

5 years agoMap MoveToLastRegionOnLayoutChange Property (#6601)
Andrei Nitescu [Thu, 4 Jul 2019 00:05:17 +0000 (03:05 +0300)]
Map MoveToLastRegionOnLayoutChange Property (#6601)

fixes #6222

5 years ago[UWP] fixes crash after reset corner radius (#6744)
Pavel Yakovlev [Thu, 4 Jul 2019 00:03:13 +0000 (03:03 +0300)]
[UWP] fixes crash after reset corner radius (#6744)

5 years ago[Shell] Apply Query string parameters even if they aren't present and correctly apply...
Shane Neuville [Wed, 3 Jul 2019 23:57:46 +0000 (17:57 -0600)]
[Shell] Apply Query string parameters even if they aren't present and correctly apply them to nested pages (#6695)

* apply query string parameters if they aren't there
- apply query string parameters correctly to nested pages

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
fixes #6543

5 years agoShell lifecycle (#6527)
Shane Neuville [Wed, 3 Jul 2019 23:53:45 +0000 (17:53 -0600)]
Shell lifecycle (#6527)

* shell appearing and disappearing events

* life cycle UI tests and fixes

* - fix appearing on shell content to only fire when page gets created
- fix navigated to only fire after shell content is appearing

* OnNavigatedOnlyFiresOnce
fixes #6486

5 years agoUnhook Page from embedded Application on disposal (#6735)
E.Z. Hart [Wed, 3 Jul 2019 23:46:47 +0000 (17:46 -0600)]
Unhook Page from embedded Application on disposal (#6735)

* Unhook Page from embedded Application on disposal

* Update Xamarin.Forms.Core/Application.cs

fixes #4671

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Wed, 3 Jul 2019 23:42:03 +0000 (16:42 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years ago[UWP] fixes crash after reset text color (#6435)
Pavel Yakovlev [Wed, 3 Jul 2019 23:24:57 +0000 (02:24 +0300)]
[UWP] fixes crash after reset text color (#6435)

5 years agodon't throw exception if registering same route factory to same route name (#6775)
Shane Neuville [Wed, 3 Jul 2019 23:22:23 +0000 (17:22 -0600)]
don't throw exception if registering same route factory to same route name (#6775)

5 years ago[GTK] Fix navigation (#6692)
nels83 [Wed, 3 Jul 2019 22:59:37 +0000 (00:59 +0200)]
[GTK] Fix navigation (#6692)

Commit 491947606d03647124bffffcea8547e135869027
introduced this change :

* [GTK] Don't recreate the toolbar on each change

However when changing page, toolbar needs to be recreated.

5 years agoRename some tests to better identify purpose and change query to WaitForElement ...
Shane Neuville [Wed, 3 Jul 2019 15:44:14 +0000 (09:44 -0600)]
Rename some tests to better identify purpose and change query to WaitForElement (#6759)

5 years ago[ios] Shell inset, general SafeArea fixes for shell and non shell embedded pages...
Shane Neuville [Wed, 3 Jul 2019 14:27:51 +0000 (08:27 -0600)]
[ios] Shell inset,  general SafeArea fixes for shell and non shell embedded pages, entry scrolling fixes (#6457)

* [ios] insets, keyboard scroll, safearea

* ui tests

* small fixes

* ui tests

* additional ui test

* reset default padding more intelligently

* ios10 fixes

* ios10 fixes

* use safe area only if tabbar or navbar is present

* better searching for uiscrollview

* ios11 ui test fixes

* slight delay for scroll to resolve before checking

* Update Xamarin.Forms.Platform.iOS/Renderers/PageRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/KeyboardInsetTracker.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellInsets.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* try to fix ui tests apply pr suggestions

* more app center ios10 tweaks

* ios 10 fixes

* Update Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* PR comments

* fix inset change thrashing and only send offset when changed

* add delay for loading url images and rename shell test

* add null check to extension

5 years agoImplement CollectionView grouping on iOS (#6590)
E.Z. Hart [Tue, 2 Jul 2019 21:34:45 +0000 (15:34 -0600)]
Implement CollectionView grouping on iOS (#6590)

* Implement CollectionView grouping for iOS

* Add grouping UI tests

* Fix invalidcast when source is not INotifyCollectionChanged

* Remove old TODO comments

* Apply suggestions from code review

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* IsGroupingEnabled -> IsGrouped

* Update empty source workaround

* Fix incorrect group counting for empty collections

* Iron out all section counts; remove unsavory empty view workaround;

* Fix crash when filter is null

* Handle sections for add/remove to/from empty sources; check for empty sources when handling sections;

* Prevent random test failures for test 5793

* Remove now-unnecessary size check on transition from empty to non-empty source

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/CollectionViewGrouping.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
5 years agoMake building easier on Windows by setting PowerShell execution policy (attempt 2...
Eilon Lipton [Tue, 2 Jul 2019 20:36:22 +0000 (13:36 -0700)]
Make building easier on Windows by setting PowerShell execution policy (attempt 2) (#6755)

* Make building easier on Windows by setting PowerShell execution policy

* Update build.cake to reference cmd as well as ps1

* remove . on instructions

5 years agoCherry pick Issue4597 fixes back to branch 4.0.0 (#6724)
Shane Neuville [Mon, 1 Jul 2019 16:42:41 +0000 (10:42 -0600)]
Cherry pick Issue4597 fixes back to branch 4.0.0 (#6724)

* Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

* fix automationid binding

* remove extra file

* fix tabs

5 years agoMerge branch '4.1.0'
ShaneN [Sun, 30 Jun 2019 16:02:55 +0000 (10:02 -0600)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
ShaneN [Sun, 30 Jun 2019 16:02:26 +0000 (10:02 -0600)]
Merge branch '4.0.0' into 4.1.0

5 years agorequest layout of measure changes force layout if it doesn't (#6704)
Shane Neuville [Sun, 30 Jun 2019 16:00:34 +0000 (10:00 -0600)]
request layout of measure changes force layout if it doesn't (#6704)

5 years agofix NRE in InvokeOnMainThreadAsync (#6708)
campersau [Sun, 30 Jun 2019 08:25:53 +0000 (10:25 +0200)]
fix NRE in InvokeOnMainThreadAsync (#6708)

5 years agoMerge branch '4.1.0'
Rui Marinho [Sat, 29 Jun 2019 14:19:17 +0000 (15:19 +0100)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Sat, 29 Jun 2019 14:18:41 +0000 (15:18 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoSplit up Issue4597 into separate testable chunks (#6654)
Shane Neuville [Sat, 29 Jun 2019 13:53:38 +0000 (07:53 -0600)]
Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

5 years agoUpdate README.md
Samantha Houts [Fri, 28 Jun 2019 18:21:03 +0000 (11:21 -0700)]
Update README.md

5 years agoUpdate README.md
Samantha Houts [Fri, 28 Jun 2019 18:11:56 +0000 (11:11 -0700)]
Update README.md

5 years ago[Android] Fix various issues in object dispose methods. (#6467)
Kevin Petit [Fri, 28 Jun 2019 10:53:49 +0000 (12:53 +0200)]
[Android] Fix various issues in object dispose methods. (#6467)

* Android - Fix various issues in object dispose methods.

* Tear down old element before disposing the ItemViewAdapter.

* More fixes.

* NavigationPageRenderer - Reorder ResetToolbar and remove view before dispose
ShellSectionRenderer - Call base.Destroy last + Remove and destroy _scrollview

* Remove obsolete code.

* Fix build.

5 years ago[Shell] MenuItem font image fix (#6628) fixes #6559
Felipe Momm [Fri, 28 Jun 2019 10:52:59 +0000 (07:52 -0300)]
[Shell] MenuItem font image fix (#6628) fixes #6559

* [Shell] FontImageSource not working with MenuItem

* [Shell] Adds missing Binding (FlyoutIcon) for ShellItem

* Revert changes and adjust to change the binding instead

* Replace magic strings for nameof

5 years agoreturn empty dictionary instead of null (#6675) fixes #6614
Shane Neuville [Fri, 28 Jun 2019 10:17:11 +0000 (04:17 -0600)]
return empty dictionary instead of null (#6675) fixes #6614

* return empty dictionary instead of null

* add warning if Element is being reparented

* fix warning message

* only fire warning if parent has inner children

5 years agoAdds FontImage Markup Extension for FontImageSource (#6398)
Andrew Hoefling [Fri, 28 Jun 2019 00:23:32 +0000 (20:23 -0400)]
Adds FontImage Markup Extension for FontImageSource (#6398)

* Added FontImage markup extension which simplifies usage of FontImageSource into any ImageSource

* Added unit tests to cover TabBar which is used in Shell

* Cleaned up xaml for test code

* Removed class references from unit test project which were added by mistake

* Removed FontImageExtension from markup parser

* Added ContentProperty to markup extension

* Added Size to FontImageExtension

* Updated unit tests for new properties

* added unit tests to certify each property was set correctly by the markup extension

* Added content property test to certify that Glyph is being set correctly

* Flipped order in unit tests of expected and actual

* Updated default value for Size to use the FontImageSource default's value. This will keep it in sync if that value ever changes

fixes #6376

5 years agoValidate style target at runtime (#6677)
Andrei Nitescu [Fri, 28 Jun 2019 00:19:47 +0000 (03:19 +0300)]
Validate style target at runtime (#6677)

* Check Style target type at runtime #6268

* Use IsAssignableFrom internal version
fixes #6268
fixes #6535

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 27 Jun 2019 23:50:21 +0000 (16:50 -0700)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 27 Jun 2019 23:49:07 +0000 (16:49 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agomake ShouldChangeText virtual (#6634)
adrianknight89 [Thu, 27 Jun 2019 23:37:25 +0000 (18:37 -0500)]
make ShouldChangeText virtual (#6634)

5 years ago[iOS] Provide a base CarouselViewRenderer (#6686)
Rui Marinho [Thu, 27 Jun 2019 23:34:52 +0000 (00:34 +0100)]
[iOS] Provide a base CarouselViewRenderer (#6686)

* [iOS] Don't provide a CarouselViewRenderer

* [iOS] Fix CarouselViewRenderer

* Update CarouselViewRenderer.cs

5 years agoUpdate nightly feed (#6411)
Rui Marinho [Thu, 27 Jun 2019 21:03:19 +0000 (22:03 +0100)]
Update nightly feed (#6411)

* Update README.md

* [Docs]Update to aka.ms link

* Update README.md

5 years ago[Bugfix] Catching ReflectionTypeLoadException in the VisualTypeConverter (#6646)
Sergej Derjabkin [Thu, 27 Jun 2019 18:46:33 +0000 (21:46 +0300)]
[Bugfix] Catching ReflectionTypeLoadException in the VisualTypeConverter (#6646)

* - Bugfix: Catching ReflectionTypeLoadException in the VisualTypeConverter

* - Fixed formatting

* - Removed empty line

5 years agoButton Layout gallery page: don't set initial Padding (#6599) fixes #6469
Andrei Nitescu [Thu, 27 Jun 2019 10:42:42 +0000 (13:42 +0300)]
Button Layout gallery page: don't set initial Padding (#6599) fixes #6469

5 years agotry to generate more unique names (#6669)
Stephane Delcroix [Thu, 27 Jun 2019 09:30:11 +0000 (11:30 +0200)]
try to generate more unique names (#6669)

- fixes #6668

5 years ago[Tizen] Added support AutomationProperties (#6080)
Kangho Hur [Wed, 26 Jun 2019 16:10:09 +0000 (01:10 +0900)]
[Tizen] Added support AutomationProperties (#6080)

5 years agoFix flaky tests. (#6510)
Kevin Petit [Wed, 26 Jun 2019 15:57:36 +0000 (17:57 +0200)]
Fix flaky tests. (#6510)

Found issues on some tests when running on my local machine.
The test Bugzilla 31333 dont wait the input to take focus (so on a fast machine it fail).
The test Issue1733 use the current culture to parse number which can fail (and indeed fail on my machine).

5 years agowait for animation to complete (#6652)
Shane Neuville [Wed, 26 Jun 2019 15:57:26 +0000 (09:57 -0600)]
wait for animation to complete (#6652)

5 years ago[Tizen] Add Checkbox (#6526) fixes #1728
Kangho Hur [Wed, 26 Jun 2019 15:52:22 +0000 (00:52 +0900)]
[Tizen] Add Checkbox (#6526) fixes #1728

5 years ago[UWP] CollectionView SelectionMode (#6629) fixes #3172 fixes #6489 fixes #5844 fixes...
humhei [Wed, 26 Jun 2019 15:37:08 +0000 (23:37 +0800)]
[UWP] CollectionView SelectionMode (#6629) fixes #3172 fixes #6489 fixes #5844 fixes #5625

* UWP CollectionView SelectionMode

* Null check

* SelectItems get property

* ItemTemplatePair type check

* Avoid mutually trigger OnSelectionChange

* Extended -> Multiple + Avoid creating new SelectedItems

5 years ago[X] resolve event handlers in base generic types (#6194)
Stephane Delcroix [Wed, 26 Jun 2019 12:35:54 +0000 (14:35 +0200)]
[X] resolve event handlers in base generic types (#6194)

* [XamlC] fix Debug harness generation code

* [X] resolve event handlers in base generic types

- fixes #6176

5 years agoIssue1733 change Query to WaitForElement (#6588)
Shane Neuville [Wed, 26 Jun 2019 04:52:09 +0000 (22:52 -0600)]
Issue1733 change Query to WaitForElement (#6588)

- rename test

5 years ago[Shell] Fail when trying to add a duplicated route (#6613)
Felipe Momm [Tue, 25 Jun 2019 23:05:03 +0000 (20:05 -0300)]
[Shell] Fail when trying to add a duplicated route (#6613)

5 years agoBackport41 (#6651)
Stephane Delcroix [Tue, 25 Jun 2019 22:20:55 +0000 (00:20 +0200)]
Backport41 (#6651)

* use a BP for QueryAttributes (#6569)

* use a BP for QueryAttributes

* Update Xamarin.Forms.Core/Shell/ShellContent.cs

* Allow tracking of StyleSheets (#6502)

* remove excess code and clean up sandbox (#6503)

* Allow tracking of StyleSheets

*  ¯\_(ツ)_/¯

5 years agoDon't reset implicit style (#6641) (#6641)
Andrei Nitescu [Tue, 25 Jun 2019 18:45:50 +0000 (21:45 +0300)]
Don't reset implicit style (#6641) (#6641)

fixes #6635

5 years agoMerge branch '4.1.0'
Samantha Houts [Mon, 24 Jun 2019 23:38:27 +0000 (16:38 -0700)]
Merge branch '4.1.0'

5 years agoFix compiler warnings in WPF platform project (#6616)
Eilon Lipton [Mon, 24 Jun 2019 22:10:17 +0000 (15:10 -0700)]
Fix compiler warnings in WPF platform project (#6616)

5 years agoUndo broken change in un-watching empty view observer;
E.Z. Hart [Mon, 24 Jun 2019 19:47:46 +0000 (13:47 -0600)]
Undo broken change in un-watching empty view observer;
This may cause a small leak in some corner cases, but that leak is fixed by

5 years agoClean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)
E.Z. Hart [Mon, 24 Jun 2019 19:01:57 +0000 (13:01 -0600)]
Clean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)

5 years agoMerge branch '4.1.0'
Samantha Houts [Fri, 21 Jun 2019 00:39:25 +0000 (17:39 -0700)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Fri, 21 Jun 2019 00:10:59 +0000 (17:10 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agoUpdate ItemsViewLayout.cs (#6583)
E.Z. Hart [Thu, 20 Jun 2019 17:48:36 +0000 (11:48 -0600)]
Update ItemsViewLayout.cs (#6583)

Unsubscribe from PropertyChanged during Dispose() on ItemsViewLayout (iOS).

5 years agoUpdate ItemsViewLayout.cs (#6583)
Elias Puurunen [Thu, 20 Jun 2019 17:46:19 +0000 (13:46 -0400)]
Update ItemsViewLayout.cs (#6583)

Unsubscribe from PropertyChanged during Dispose() on ItemsViewLayout (iOS).

5 years ago[XamlC] Do not try to set a value to bound source property if unavailable (#6564)
Akihiko Odaki [Thu, 20 Jun 2019 09:37:42 +0000 (18:37 +0900)]
[XamlC] Do not try to set a value to bound source property if unavailable (#6564)

5 years ago[Android] Change elevation to use float.minvalue instead of negative infinity (#6560)
Shane Neuville [Thu, 20 Jun 2019 02:54:07 +0000 (20:54 -0600)]
[Android] Change elevation to use float.minvalue instead of negative infinity (#6560)

* change negative infinity to float.minvalue

* api 19 fixes

5 years agoImplement ItemSizingStrategy.MeasureFirstItem on Android (#6422)
E.Z. Hart [Thu, 20 Jun 2019 02:28:43 +0000 (20:28 -0600)]
Implement ItemSizingStrategy.MeasureFirstItem on Android (#6422)

* Implement ItemSizingStrategy.MeasureFirstItem on Android

* Remove unnecessary method

5 years ago[UWP] fixes hangs ListView when using Narrator (#6431)
Pavel Yakovlev [Thu, 20 Jun 2019 02:27:53 +0000 (19:27 -0700)]
[UWP] fixes hangs ListView when using Narrator (#6431)

fixes #5340

5 years ago[Android] Dispose the collection view item adapter (#6525)
Kevin Petit [Thu, 20 Jun 2019 02:27:25 +0000 (04:27 +0200)]
[Android] Dispose the collection view item adapter (#6525)

* [Android] Dispose the collection view adapter.

* More complete fix.

5 years ago[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)
Gerald Versluis [Thu, 20 Jun 2019 02:27:04 +0000 (04:27 +0200)]
[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)

* Update NavigationPageRenderer.cs

* Add reproduction for #2577

* Update NavigationPageRenderer.cs

* Taking into account MasterDetailPage and GetHasBackButton correctly

* Update NavigationPageRenderer.cs
fixes #2577

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 20 Jun 2019 02:25:10 +0000 (19:25 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agodon't setup webview if running as designer (#6592)
Shane Neuville [Wed, 19 Jun 2019 23:52:31 +0000 (17:52 -0600)]
don't setup webview if running as designer (#6592)

5 years agoAdded missing named sizes (#6591)
Gerald Versluis [Wed, 19 Jun 2019 23:40:59 +0000 (01:40 +0200)]
Added missing named sizes (#6591)

fixes #6517

5 years agoMake ShellTabLayoutAppearanceTracker public (#6530)
Gerald Versluis [Wed, 19 Jun 2019 23:30:33 +0000 (01:30 +0200)]
Make ShellTabLayoutAppearanceTracker public (#6530)

fixes #6529

5 years ago[Android] Fixes loading image from uri (#6394)
Pavel Yakovlev [Wed, 19 Jun 2019 23:26:41 +0000 (16:26 -0700)]
[Android] Fixes loading image from uri (#6394)

* [Android] Fixes loading image form uri

* - modified Issue4597 test

* nested function is removed

* moved redundant code

* Update Xamarin.Forms.Platform.Android/Extensions/ImageViewExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6313

5 years ago[Android] Fixes layout in AppCompat ButtonRenderer (#6329)
Pavel Yakovlev [Wed, 19 Jun 2019 23:24:51 +0000 (16:24 -0700)]
[Android] Fixes layout in AppCompat ButtonRenderer (#6329)

* [Android] Fixes layout in AppCompact ButtonRenderer

* - fixes button alignment when fast changing padding
- fixes material button alignment

* refactoring

* forceLayout

* generalize force layout

* if APP check on ui test
fixes #6282

5 years ago[Android] fix accessibility of Picker (#5125)
Pavel Yakovlev [Wed, 19 Jun 2019 23:23:00 +0000 (16:23 -0700)]
[Android] fix accessibility of Picker (#5125)

* [Android] fix accessibility of Picker

* fix NRE

* fixes read selected item with accessibility

* refactoring test

* added dispose of accessibility delegate

* fix build uitest

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
5 years ago[Android] Add disposed check to MasterDetailPageRenderer (#6354)
Samantha Houts [Wed, 19 Jun 2019 22:55:59 +0000 (15:55 -0700)]
[Android] Add disposed check to MasterDetailPageRenderer (#6354)

* [Android] Add disposed check to MasterDetailPageRenderer

Co-Authored-By: Felipe Silveira <transis2@users.noreply.github.com>
* Fix dispose pattern

a la #6305

* apply same set of changes to NavigationPageRenderer

fixes #3489
closes #4586

5 years ago[Android] hide keyboard after tapping on pickers (#6284)
Pavel Yakovlev [Wed, 19 Jun 2019 22:54:00 +0000 (15:54 -0700)]
[Android] hide keyboard after tapping on pickers (#6284)

fixes #6235