Kazu Hirata [Mon, 10 Apr 2023 17:11:41 +0000 (10:11 -0700)]
Fix warnings
This patch fixes:
mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp:1334:51:
warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
lld/wasm/Writer.cpp:250:39: warning: suggest parentheses around ‘&&’
within ‘||’ [-Wparentheses]
Michael Jones [Mon, 10 Apr 2023 17:01:31 +0000 (10:01 -0700)]
[libc][obvious] fix new assert typo
Jeremy Kun [Mon, 10 Apr 2023 15:57:34 +0000 (08:57 -0700)]
Add support for math.ctlz in convert-math-to-funcs
This change adds a software implementation of the `math.ctlz` operation
and includes it in `--convert-math-to-funcs`.
This is my first change to MLIR, so please bear with me as I'm still learning
the idioms of the codebase.
The context for this change is that I have some larger scale project in which
I'd like to lower from a mix of MLIR dialects to CIRCT, but many of the CIRCT
passes don't support the `math` dialect.
I noticed the content of `convert-math-to-funcs` was limited entirely to
the `pow` functions, but otherwise provided the needed structure to implement
this feature with minimal changes.
Highlight of the changes:
- Add a dependence on the SCF dialect for this lower. I could have lowered
directly to cf, following the pow lowerings in the same pass, but I felt it
was not necessary given the existing support for lowering scf to cf.
- Generalize the DenseMap storing op implementations: modify the callback
function hashmap to be keyed by both OperationType (for me this effectively
means the name of the op being implemented in software) and the type
signature of the resulting function.
- Implement the ctlz function as a loop. I had researched a variety of
implementations that claimed to be more efficient (such as those based on a
de Bruijn sequence), but it seems to me that the simplest approach would make
it easier for later compiler optimizations to do a better (platform-aware)
job optimizing this than I could do by hand.
Questions I had for the reviewer:
- [edit: found mlir-cpu-runner and added two tests] What would I add to the filecheck invocation to actually run the resulting MLIR on a value and assert the output is correct? I have done this manually with the C implementation but I'm not confident my port to MLIR is correct.
- Should I add a test for a vectorized version of this lowering? I followed suit with the ` VecOpToScalarOp` but I admit I don't fully understand what it's doing.
Reviewed By: vzakhari
Differential Revision: https://reviews.llvm.org/D146261
Tue Ly [Fri, 7 Apr 2023 01:45:45 +0000 (21:45 -0400)]
[libc][math] Update range reduction step for logf and reduce its latency.
Simplify the range reduction steps by choosing the reduction constants
carefully so that the reduced arguments v = r*m_x - 1 and v^2 are exact in double
precision, even without FMA instructions, and -2^-8 <= v < 2^-7. This allows the
polynomial evaluations to be parallelized more efficiently.
Reviewed By: santoshn, zimmermann6
Differential Revision: https://reviews.llvm.org/D147755
Michael Jones [Fri, 7 Apr 2023 21:02:39 +0000 (14:02 -0700)]
[libc] clean up ctype negative handling
The ctype functions will sometimes be passed negative numbers, such as
EOF. Some of the previous implementations didn't handle these properly.
Additionally, the tests did not check any negative numbers. These
problems have been fixed.
This patch fixes https://github.com/llvm/llvm-project/issues/62000
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D147813
Aaron Ballman [Mon, 10 Apr 2023 16:53:50 +0000 (12:53 -0400)]
Fix wording in a release note; NFC
This change happened due to post-commit feedback on the review.
Frederik Gossen [Mon, 10 Apr 2023 16:30:27 +0000 (12:30 -0400)]
Fix invalid op result access in SparseTensorCodegen
This trigges an assertion introduced in https://reviews.llvm.org/D147883
Differential Revision: https://reviews.llvm.org/D147950
Jay Foad [Mon, 6 Mar 2023 16:33:49 +0000 (16:33 +0000)]
[AMDGPU] Fix AddedComplexity for s_buffer_load patterns. NFCI.
We set AddedComplexity = 100 for s_load patterns to prefer them over
global loads, but for s_buffer_load patterns there is no need to do
this and it was quietly overriding the AddedComplexity of each
individual GCNPat that is defined inside SMLoad_Pattern (but in practice
that did not appear to make any difference).
Differential Revision: https://reviews.llvm.org/D145396
Bing1 Yu [Mon, 10 Apr 2023 16:14:04 +0000 (00:14 +0800)]
Change dyn_cast to cast
Reviewed By: pengfei
Differential Revision: https://reviews.llvm.org/D147923
Spenser Bauman [Mon, 10 Apr 2023 15:55:54 +0000 (15:55 +0000)]
[mlir][tosa] Lowering of tosa.gather operations with dynamic dimensions
The existing TOSA->Linalg lowering of tosa.gather only supports gathers
with either a static shape or a single dynamic batch dimension.
This change extends support to arbitrary number of dynamic dimensions on
both the values and indices of the gather operation.
Reviewed By: rsuderman
Differential Revision: https://reviews.llvm.org/D147810
Valentin Clement [Mon, 10 Apr 2023 15:33:52 +0000 (08:33 -0700)]
[flang][NFC] Extract TypeConverter from header file
Extract the type converter definitions into its own .cpp
file so the type converter can be used by passes.
Reviewed By: PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D147824
Corentin Jabot [Mon, 10 Apr 2023 09:52:30 +0000 (11:52 +0200)]
[Clang] Check type-constraints applied to placeholder types
(and deduced return types)
Previously, only type constraints applied to type parameter
were semantically checked.
A diagnostic would still be emitted on instantiation, but it was
too late, lacked clarity, and was inconsistent with type parameters.
Reviewed By: erichkeane
Differential Revision: https://reviews.llvm.org/D147925
Alvin Wong [Sun, 2 Apr 2023 18:26:30 +0000 (02:26 +0800)]
[asan][test] Fix two test cases on Windows
Fixes global-location-nodebug and heavy_uar_test for both MSVC and MinGW
targets.
Differential Revision: https://reviews.llvm.org/D147445
Alvin Wong [Sun, 2 Apr 2023 15:19:23 +0000 (23:19 +0800)]
[sanitizer][win] Fix `Atexit()` on MinGW asan_dynamic runtime
Some functions of asan depends on `Atexit()` handlers. On Windows, this
is implemented in
ad3ec82bb1c7217b0187a1e16bb22642e194ce94 to queue the
handlers in a vector then register them with `atexit()` only after the
CRT is fully initialized. However, this is broken on MinGW with
asan_dynamic runtime due to different initialization order. This change
fixes the issue by making sure that `Atexit()` can call `atexit()`
directly past the pre-initialization phase.
This fixes two asan test cases on MinGW.
Differential Revision: https://reviews.llvm.org/D147413
Piotr Zegar [Mon, 10 Apr 2023 14:41:32 +0000 (14:41 +0000)]
[clang-tidy] Added IgnoreVirtual option to misc-unused-parameters
Added option to ignore virtual methods in this check.
This allows to quickly get rid of big number of
potentialy false-positive issues without inserting
not-needed comments.
Fixes #55665.
Reviewed By: njames93
Differential Revision: https://reviews.llvm.org/D147918
Anna Thomas [Thu, 6 Apr 2023 18:42:14 +0000 (14:42 -0400)]
[LoopPredication] Fix where we generate widened condition. PR61963
Loop predication's predicateLoopExit pass does two incorrect things:
It sinks the widenable call into the loop, thereby converting an invariant condition to a variant one
It widens the widenable call at a branch thereby converting the branch into a loop-varying one.
The latter is problematic when the branch may have been loop-invariant
and prior optimizations (such as indvars) may have relied on this
fact, and updated the deopt state accordingly.
Now, when we widen this with a loop-varying condition, the deopt state
is no longer correct.
https://github.com/llvm/llvm-project/issues/61963 fixed.
Differential Revision: https://reviews.llvm.org/D147662
Anna Thomas [Mon, 10 Apr 2023 14:28:19 +0000 (10:28 -0400)]
Simplify test with deopt state in D147662. NFC
Jake Egan [Mon, 10 Apr 2023 13:43:31 +0000 (09:43 -0400)]
[NFC][tests] Disable new gmodules-preferred-name-* tests on AIX and z/OS
Objective-C is not supported on AIX and z/OS. Precedent here: D109060
skc7 [Mon, 10 Apr 2023 13:07:17 +0000 (18:37 +0530)]
[AMDGPU][NFC] Regenerate test checks for merge-tbuffer.mir
Aaron Ballman [Mon, 10 Apr 2023 12:45:56 +0000 (08:45 -0400)]
Fix the buildbots after
636dd1e8a1782e22f9bdee640428ed5c50a4a4f2
This addresses issues found by:
http://45.33.8.238/linux/103908/step_4.txt
https://lab.llvm.org/buildbot/#/builders/216/builds/19607
and others
Piotr Zegar [Mon, 10 Apr 2023 12:42:24 +0000 (12:42 +0000)]
[clang-tidy][NFC] Remove trailing spaces from ReleaseNotes.rst
Cleanup some trailing whitespaces from ReleaseNotes.rst
Aaron Ballman [Mon, 10 Apr 2023 12:29:21 +0000 (08:29 -0400)]
Make explicit the single-argument constructors of AttributeCommonInfo; NFC
The single-argument constructors of this class were not marked explicit
and that led to some incorrect uses that slipped under the radar (see
changes in SemaDeclAttr.cpp). This makes the constructors explicit,
changes the benignly incorrect uses, and updates the tablegen code to
emit the correct support code to call the explicit constructors.
While this does correct a misuse, that incorrect usage could not be
observed except via a debugger and so no additional tests are added.
Differential Revision: https://reviews.llvm.org/D147661
Shengchen Kan [Mon, 10 Apr 2023 12:21:06 +0000 (20:21 +0800)]
[TableGen] Fix compile fail when compiling llvm with MSVC due to typo in
931418667063
Florian Hahn [Mon, 10 Apr 2023 12:02:44 +0000 (13:02 +0100)]
[VPlan] Use VPLiveOut to update FOR live-out users.
Instead of iterating over all LCSSA phis in the exit block, collect all
LiveOut users of the FOR splice VPInstruction and only update those
users.
Building on top of D147471, this removes an access to the cost model
after VPlan execution.
Depends on D147471.
Reviewed By: Ayal, michaelmaitland
Differential Revision: https://reviews.llvm.org/D147472
Congcong Cai [Mon, 10 Apr 2023 11:42:32 +0000 (13:42 +0200)]
[clang-tidy] avoid colon in namespace cause false positve
Refactor the Namespaces with NamespaceDecl[][].
First level stores non nested namepsace.
Second level stores nested namespace.
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D147893
mmarjano [Fri, 7 Apr 2023 11:27:27 +0000 (13:27 +0200)]
[AMDGPU] Extend tbuffer_load_format merge
Add support for merging _IDXEN and _BOTHEN variants of
TBUFFER_LOAD_FORMAT instruction.
Vlad Serebrennikov [Mon, 10 Apr 2023 10:17:04 +0000 (13:17 +0300)]
[clang] Mark CWG536 as N/A
[[https://wg21.link/p1787 | P1787]]: CWG536 (long partially resolved) is resolved by specifying that unqualified lookup occurs for any kind of unqualified-id as an id-expression.
Wording: An unqualified name is a name that <...>. Unless otherwise specified, such a name undergoes unqualified name lookup from the point where it appears. ([basic.lookup.unqual]/4)
Reviewed By: #clang-language-wg, aaron.ballman
Differential Revision: https://reviews.llvm.org/D147564
Piotr Zegar [Mon, 10 Apr 2023 09:50:00 +0000 (09:50 +0000)]
[clang-tidy][NFC] Rename test files for simplify-boolean-expr to match check name
Change simplify-bool-expr -> simplify-boolean-expr
Max Kazantsev [Mon, 10 Apr 2023 09:37:10 +0000 (16:37 +0700)]
[SCEV] Improve AddRecs' range computation in Expensive Range Sharpening mode
Apply loop guards to AddRec's start in range computation for
non-self-wrapping AddRecs.
According to CT measurements, this has a wide negative compile time impact,
so we hold it in expensive range sharpening mode where it's not so critical.
However, we need to find a way to share benefits of this mode with default mode.
Patch by Aleksandr Popov!
Differential Revision: https://reviews.llvm.org/D147557
Reviewed By: mkazantsev
Luo, Yuanke [Mon, 10 Apr 2023 07:37:05 +0000 (15:37 +0800)]
[Coverity] avoid array overflow when use -1 as index.
Craig Topper [Mon, 10 Apr 2023 06:13:51 +0000 (23:13 -0700)]
[TableGen] Pass size to std::vector constructor instead of using resize. NFC
Craig Topper [Mon, 10 Apr 2023 04:39:57 +0000 (21:39 -0700)]
[TableGen] Make TreePatternNode::InlinePatternFragments a static method. NFC
Previously we were passing 'this' and the std::shared_ptr version
of 'this'. This replaces all uses of 'this' with the shared_ptr and
makes the method static.
Craig Topper [Mon, 10 Apr 2023 03:53:45 +0000 (20:53 -0700)]
[TableGen] Move vectors into DAGInstruction instead of copying them. NFC
Max Kazantsev [Mon, 10 Apr 2023 06:57:51 +0000 (13:57 +0700)]
[NFC][IRCE] Do not store latch exit count
It is not actually used for any computations. Its only purpose is to
check that the loop is finite and find out the type of computed exit
count. Refactor code so that we only store this type.
skc7 [Tue, 28 Mar 2023 18:05:02 +0000 (23:35 +0530)]
[AMDGPU] Introduce SIInstrWorklist to process instructions in moveToVALU
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D147168
Noah Goldstein [Mon, 10 Apr 2023 00:23:30 +0000 (19:23 -0500)]
[X86] Add inst fixup for `unpckps` -> `unpckdq`.
`unpckps` has the same performance as `unpckpd` (only port5) wereas
`unpckdq` can run on p15 on some newer architectures.
`unpckdq` is in the integer domain, so only do the transform if the
target has no bypass delay on shuffles (SKL+).
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D147729
Noah Goldstein [Mon, 10 Apr 2023 00:23:26 +0000 (19:23 -0500)]
[X86] Add inst fixup for `unpckpd` -> `unpckqdq`.
`unpckqdq` seems to be treated as a shuffle from bypass delay
perspective (which makes sense it appears to have shared shuffle units
for all micro-arch).
`unpckqdq` is slightly preferable to `shufpd` as it saves 1-byte of
code size and can be used to replace the micro-fused `rm` version. So,
if the target has no bypass delay, we should do `unpckpd` ->
`unpckqdq` instead of `shufpd.
Reviewed By: pengfei
Differential Revision: https://reviews.llvm.org/D147728
Noah Goldstein [Mon, 10 Apr 2023 00:23:23 +0000 (19:23 -0500)]
[X86] Fix perf bug in `permilps` -> `shufd` in X86FixupInstTuning.
We shouldn't do the transformation if we either have bypass delay OR
the new opcode has worse performance. Previous code was incorrectly
using AND.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D147727
Noah Goldstein [Mon, 10 Apr 2023 00:23:19 +0000 (19:23 -0500)]
[X86] Improve inst tuning tests for X86FixupInstTuning Pass; NFC
1) Add tests for `unpckps`.
2) Add explicit test for fast shuffles (ICX+) but WITH bypass delay.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D147726
Chen Zheng [Mon, 10 Apr 2023 05:11:26 +0000 (01:11 -0400)]
[GlobalISelEmitter] add case for D141247, NFC.
Mehdi Amini [Mon, 10 Apr 2023 04:21:56 +0000 (21:21 -0700)]
Revert "[MLIR] Add an assert in Operation::getOpResultImpl for out of range result"
This reverts commit
13b21971fbf5cd47dc3acb0c593aae8ae980c8d8.
Multiple bots are broken.
Anoop J S [Mon, 10 Apr 2023 03:40:49 +0000 (09:10 +0530)]
[mlir][affine] Fix crash on -affine-loop-invariant-code-motion pass with affine.prefetch Op
Affine Prefetch Op impelements AffineMapAccessInterface but does not implement
AffineReadOpInterface or AffineWriteOpInterface. Prefetch Op was cast to
AffineWriteOpinterface causing the crash.
Reviewed By: bondhugula
Differential Revision: https://reviews.llvm.org/D146836
Nelson Chu [Fri, 15 Apr 2022 04:25:36 +0000 (21:25 -0700)]
[RISCV] Support assembler and dis-assembler for VCIX extension.
Spec: https://sifive.cdn.prismic.io/sifive/
c3829e36-8552-41f0-a841-79945784241b_vcix-spec-software.pdf
Differential Revision: https://reviews.llvm.org/D144530
Ben Shi [Mon, 10 Apr 2023 03:13:07 +0000 (11:13 +0800)]
wangpc [Mon, 10 Apr 2023 02:57:00 +0000 (10:57 +0800)]
[MachineOutliner] Add IsOutlined to MachineFunction
We add a field `IsOutlined` to indicate whether a MachineFunction
is outlined and set it true for outlined functions in MachineOutliner.
Reviewed By: paquette
Differential Revision: https://reviews.llvm.org/D146191
Ben Shi [Sun, 9 Apr 2023 09:37:32 +0000 (17:37 +0800)]
[AVR] Reject invalid LDD instruction with explicit error
We should reject "ldd Rn, X" with explicit error message
rather than "llvm_unreachable" in llvm's release build.
Fixes https://github.com/llvm/llvm-project/issues/62012
Reviewed By: Miss_Grape
Differential Revision: https://reviews.llvm.org/D147877
Chen Zheng [Fri, 7 Apr 2023 10:22:31 +0000 (10:22 +0000)]
[AMDGPU][Global-ISel] reuse extension related patterns in td file
However the imported rules can not be used for now because Global ISel
selectImpl() seems has some bug/limitation to create a illegl COPY
from VGPR to SGPR. So currently workaround this by not auto selecting these
patterns.
Fixes #61468
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D147780
Craig Topper [Mon, 10 Apr 2023 00:12:27 +0000 (17:12 -0700)]
[X86] Add an additional ReadAfterLoad to EVEX FMA instructions.
These instructions have 3 sources. 2 of them are registers when
the load is folded. So we need 2 ReadAfterLoad SchedReads.
Craig Topper [Sun, 9 Apr 2023 23:33:47 +0000 (16:33 -0700)]
[X86] Correct the scheduling information for AVX-VNNI and AVX512-VNNI instructons.
The AVXVNNI load instructions weren't using the Folded load write
class and they had no ReadAdvance.
The YMM versions were using the XMM schedule class.
The AVX512VNNI instructions had the right classes, but not enough
ReadAdvances to account for the 2 sources.
Noticed while investigating #62026.
Reviewed By: pengfei
Differential Revision: https://reviews.llvm.org/D147872
Craig Topper [Sun, 9 Apr 2023 23:32:54 +0000 (16:32 -0700)]
[TableGen] Use map::try_emplace to construction DAGInstruction in the Instructions map. NFC
We add entries to the map in two places. One already used
std::piecewise_construct with map::emplace. The other was using
map::insert. Change both to map::try_emplace.
Shivam Gupta [Sun, 9 Apr 2023 12:57:07 +0000 (18:27 +0530)]
[MLIR] Add an assert in Operation::getOpResultImpl for out of range result
This fix https://github.com/llvm/llvm-project/issues/61962.
Calling op->getResult(0) on a function like operation with no results
returned a garbage pointer.
This patch add assert to check number is in range.
Differential Revision: https://reviews.llvm.org/D147883
Florian Hahn [Sun, 9 Apr 2023 20:01:10 +0000 (21:01 +0100)]
[VPlan] Don't assign slots for external defs (NFCI).
External defs are VPValues wrapping an IR value and hence will get
printed as ir<>. We don't need to assign a slot for a VPValue number.
Michael Liao [Sun, 9 Apr 2023 19:55:38 +0000 (15:55 -0400)]
[clang][AST] Fix `-Wuninitialized`. NFC
- Adjust the declaration order as non-static member are initialized in
order of declaration in the class definition.
Florian Hahn [Sun, 9 Apr 2023 19:32:09 +0000 (20:32 +0100)]
[LV] Update tests checking VPlans to use patterns for VPValues.
This makes the tests more robust to changes in value numbering for
VPValues.
Craig Topper [Sun, 9 Apr 2023 17:56:06 +0000 (10:56 -0700)]
[TableGen] Remove TypeSetByHwMode::isDefaultOnly(). Use InfoByHwMode<T>::isSimple(). NFC
InfoByHwMode is the base class of TypeSetByHwMode. The two methods
did the same thing. No reason to have two ways to do it.
Also use the getSimple() access instead of Map.begin()->second.
LLVM GN Syncbot [Sun, 9 Apr 2023 15:57:26 +0000 (15:57 +0000)]
[gn build] Port
e8cfbfd05a95
Mark de Wever [Sat, 8 Apr 2023 15:29:31 +0000 (17:29 +0200)]
[libc++] Granularize system_error.
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D147853
Congcong Cai [Sun, 9 Apr 2023 14:23:28 +0000 (16:23 +0200)]
[clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces
Fixed https://github.com/llvm/llvm-project/issues/57530
Add pre check to avoid false positive for namespace with attributes like
```
namespace [[deprecated]] ns {}
```
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D147857
Mark de Wever [Sat, 8 Apr 2023 12:59:09 +0000 (14:59 +0200)]
[libc++] Implements isblank.
This omission seems to be there for a long time, it's in the initial
libc++ import. This was discovered while working on the std modules.
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D147850
Mark de Wever [Fri, 17 Feb 2023 20:27:08 +0000 (21:27 +0100)]
[libc++][format] Addresses LWG3720.
LWG3720 Restrict the valid types of arg-id for width and precision in
std-format-spec
Depends on D144325
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D144326
Mark de Wever [Thu, 5 May 2022 16:57:32 +0000 (18:57 +0200)]
[libc++][format] range-default-formatter for strings.
Implements the range-default-formatter specialization range_format::string
and range_format::debug_string.
Implements parts of
- P2286R8 Formatting Ranges
- P2585R0 Improving default container formatting
Depends on D145847
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D145853
OCHyams [Sun, 9 Apr 2023 10:21:55 +0000 (11:21 +0100)]
Revert (3) "[Assignment Tracking] Enable by default"
Revert D146987.
This reverts commit
f11e1475c97c1ba6b418838f3592de930677c3d0 which
reapplies D146987.
Buildbot: https://lab.llvm.org/buildbot/#/builders/70/builds/36103
OCHyams [Sun, 9 Apr 2023 08:59:26 +0000 (09:59 +0100)]
Reapply (2) "[Assignment Tracking] Enable by default"
Re-land D146987.
This reverts commit
64fba207a683a355d9059cd57adb8a139c2f5dda
which reverts D146987.
OCHyams [Sun, 9 Apr 2023 08:47:09 +0000 (09:47 +0100)]
[Assignment Tracking] Fix fragments for assignments to variables smaller than the alloca
Prior to this patch the trackAssignments function would attribute all stores to
an alloca to all variables linked to the alloca. This is wrong in the case
where the alloca contains variables which are smaller than the alloca, and
caused erroneous fragment information to be generated.
Now stores outside the variable bounds are discarded, and we check whether a
fragment is needed based on whether the store covers the entire variable as
opposed to whether it covers the entire alloca (except for variables of unknown
size).
Note that trackAssignments doesn't yet understand whole variables sitting at
anything other than offset 0 in an alloca - those variables are still tracked
using dbg.declares.
Fixes https://lab.llvm.org/buildbot/#/builders/70/builds/36007
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D147777
Jorge Pinto Sousa [Sun, 9 Apr 2023 08:45:07 +0000 (08:45 +0000)]
[clang-tidy] Fix AST Library documentation link
The link was pointing to the 'Lexer and Preprocessor Library'
instead.
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D147874
Florian Hahn [Sun, 9 Apr 2023 08:15:42 +0000 (09:15 +0100)]
[VPlan] Don't add live-outs if scalar epilogue is required.
Instead of clearing live outs when a scalar epilogue is required late,
don't add live outs during VPlan construction if a scalar epilogue is
required.
This enables more VPlan-based DCE (if the live out would be the only
user in the plan) and is a step towards removing an access of the cost
model in fixedVectorizedLoop (which is after VPlan execution).
Depends on D147468.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D147471
Craig Topper [Sun, 9 Apr 2023 07:42:35 +0000 (00:42 -0700)]
[TableGen] Reorder some checks in TreePatternNode::isIsomorphicTo to speedup -gen-dag-isel for RISC-V.
Comparing types is quite expensive when hardware modes are being
used. Checking the operator first can let us detect mismatches
earlier without checking types.
Hristo Hristov [Sat, 1 Apr 2023 08:51:03 +0000 (11:51 +0300)]
[libc++][spaceship] Implement `operator<=>` for `time_point`
Depends on D145881
Implements parts of **P1614R2**: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1614r2.html
Implements `operator<=>` for `time_point`
Reviewed By: #libc, Mordante
Differential Revision: https://reviews.llvm.org/D146250
Craig Topper [Sun, 9 Apr 2023 01:54:56 +0000 (18:54 -0700)]
[TableGen] Slightly improve the efficiency of InfoByHwMode::get.
This avoids some double map lookups. Also use Map.begin() to find
the default mode instead of going through find.
Shengchen Kan [Sun, 9 Apr 2023 01:29:41 +0000 (09:29 +0800)]
[X86][mem-fold][NFC] Simplify code by transform A != 0 - > A
Nikolas Klauser [Sun, 8 Jan 2023 15:47:53 +0000 (16:47 +0100)]
[libc++] Remove <cstdlib> includes
We changed the `abort` calls when trying to throw exceptions in `-fno-exceptions` mode to `__verbose_abort` calls, which removes the dependency in most files.
Reviewed By: ldionne, #libc
Spies: dim, emaste, mikhail.ramalho, smeenai, libcxx-commits
Differential Revision: https://reviews.llvm.org/D146076
Lang Hames [Sat, 8 Apr 2023 23:48:13 +0000 (16:48 -0700)]
[ORC][MachO] Remove unused variables.
Kazu Hirata [Sat, 8 Apr 2023 23:22:39 +0000 (16:22 -0700)]
[CodeGen] Use range-based for loops (NFC)
Lang Hames [Sat, 8 Apr 2023 23:09:45 +0000 (16:09 -0700)]
[ORC] Fix reference to struct member in
f448d44663a.
A map value was converted from a tuple to a struct during development, but I
missed a use in an assert.
Joshua Cao [Sat, 8 Apr 2023 22:55:21 +0000 (15:55 -0700)]
[SCEV][NFC] Fix `Do not use 'else' after 'return'`
Follow LLVM coding standards and make clangd emit less warnings.
Lang Hames [Fri, 7 Apr 2023 21:40:05 +0000 (14:40 -0700)]
[ORC][ORC-RT][MachO] Use _objc_(map|load)_images for ObjC & Swift registration.
This patch drops the individual registration calls to the ObjC and Swift
runtimes (for selectors, classes, etc.), and instead creates a Mach header and
load commands that can be passed to _objc_map_images and _objc_load_images to
trigger registration and execution of +load methods. This approach supports
categories (for which there is no current registration API), and more closely
follows dyld's ObjC & Swift registration path.
Kazu Hirata [Sat, 8 Apr 2023 22:44:18 +0000 (15:44 -0700)]
[mlir] Use DenseMap::contains (NFC)
Joshua Cao [Sat, 8 Apr 2023 22:14:12 +0000 (15:14 -0700)]
[SCEV] Add test for huge trip multiples
Sergei Barannikov [Sat, 8 Apr 2023 22:08:41 +0000 (01:08 +0300)]
[AMDGPU] Update mcp-overlap-after-propagation.mir test
The test was added in D69953, but since D67794 landed a bit later it no
longer catches the bug. Update the test to be representative again.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D146934
Lang Hames [Sat, 8 Apr 2023 17:38:52 +0000 (10:38 -0700)]
[ORC][LLJIT] Improve debugging output, tighten assertion.
Clients can provide an ExecutionSession or an ExecutorProcessControl object to
LLJITBuilder, but should not provide both.
Craig Topper [Sat, 8 Apr 2023 19:46:15 +0000 (12:46 -0700)]
[TableGen] Reimplement union_modes for InfoByHwMode to be avoid a secondary set.
Previously we collected both modes in a set and iterated over that set.
Instead, iterate over the two maps in parallel and detect the differences
as we go.
Craig Topper [Sat, 8 Apr 2023 18:55:55 +0000 (11:55 -0700)]
[TableGen] Use InfoByHwMode::getSimple() in place of *InfoByHwMode::begin(). NFC
Congcong Cai [Sat, 8 Apr 2023 19:03:58 +0000 (21:03 +0200)]
[clang-tidy] fix hint use correct range to replace last NamespaceDecl
range of replacing last namespace decl should be from last non nested namespace to last namespace
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D147843
Nikolas Klauser [Fri, 31 Mar 2023 12:47:33 +0000 (14:47 +0200)]
[libc++][NFC] Only run the preprocessor in transitive_includes.sh.cpp
This cuts the time it takes to run the test in half.
Reviewed By: Mordante, #libc
Spies: libcxx-commits
Differential Revision: https://reviews.llvm.org/D147320
Min-Yih Hsu [Fri, 7 Apr 2023 17:57:32 +0000 (10:57 -0700)]
[M68k] Basic FP register files and FMOVE implementations
- FP registers and register classes definitions
- MC support for FP registers
- MC support for the FPDR -> FPDR variant of FMOVE/FSMOVE/FDSMOVE
Note that we don't implement 32/64-bit FP registers with subregisters since
f32/f64 values will be converted to f80 upon storing into a register,
rather than occupying part of the register.
So we only use register classes with different value types to distinguish
them.
Differential Revision: https://reviews.llvm.org/D147480
Piotr Zegar [Sat, 8 Apr 2023 17:17:12 +0000 (17:17 +0000)]
[clang-tidy] Fix extern fixes in readability-redundant-declaration
Currently check does not look into LinkageSpecDecl
when removing redundant variable re-declarations.
This were leaving code in non-compiling state.
Fix patch fixes this and adds removal also of 'extern C'.
Fixes: https://github.com/llvm/llvm-project/issues/42068
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D146904
Mark de Wever [Sat, 18 Feb 2023 17:30:56 +0000 (18:30 +0100)]
[libc++][format] Implements formatter thread::id.
Since stacktrace header is WIP and it's not sure that will be done
before LLVM17 update the documentation. When the header is implemented
implementing the formatter is trivial, so that can be done quickly
afterwards.
Implements parts of:
- P2693R1 Formatting thread::id and stacktrace
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D144331
Timm Bäder [Sat, 8 Apr 2023 13:44:11 +0000 (15:44 +0200)]
[clang][Interp] Add missing static_assert message
Timm Bäder [Sat, 8 Apr 2023 13:26:46 +0000 (15:26 +0200)]
[clang][Interp][NFC] Add test for e7f55bb
Timm Bäder [Sat, 8 Apr 2023 09:59:59 +0000 (11:59 +0200)]
[clang][Interp] Fix a crash when calling invalid constexpr functions
Differential Revision: https://reviews.llvm.org/D147845
Mark de Wever [Sun, 20 Mar 2022 12:40:02 +0000 (13:40 +0100)]
[libc++][chrono] Add sys_time formatter.
Partially implements:
- P1361 Integration of chrono with text formatting
- P2372 Fixing locale handling in chrono formatters
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D144739
Mark de Wever [Fri, 3 Mar 2023 19:23:51 +0000 (20:23 +0100)]
[libc++][format] Implements LWG3892.
This LWG issue is based on the discussion regarding
P2733R3 Fix handling of empty specifiers in std::format
This paper was disussed and changed a few times in LEWG during the
Issaquah meeting. The paper was not voted in, instead LEWG asked for
a DR against C++26.
This LWG issue contains the direction voted by LEWG. This issue has not
been voted in yet. However it fixes some of the defencies on the
container based formatting. Without this fix the range-default-formatter
for strings looks bad when used in containers.
The changes of this issue match the intended changes of P27333.
type fmt before after (if changed)
---------------------------------------------------------------
char {} a
char {:?} 'a'
array<char, 1> {} ['a']
array<char, 1> {::} [a]
array<char, 1> {::c} [a]
array<char, 1> {::?} ['a']
map<char, char> {} {a: a} -> {'a': 'a'}
map<char, char> {::} {'a': 'a'}
set<char> {} {'a'}
set<char> {::} {a}
set<char> {::c} {a}
set<char> {::?} {'a'}
tuple<char> {} ('a')
stack<char> {} ['a']
stack<char> {::} [a]
stack<char> {::c} [a]
stack<char> {::?} ['a']
array<array<char, 1>, 1> {} [[a]] -> {'a': 'a'}
array<array<char, 1>, 1> {::} [['a']]
array<array<char, 1>, 1> {:::} [[a]]
array<array<char, 1>, 1> {:::c} [[a]]
array<array<char, 1>, 1> {:::?} [['a']]
array<tuple<char>, 1> {} [(a)] -> [('a')]
tuple<tuple<char>> {} ((a)) -> (('a'))
tuple<array<char, 1>> {} ([a]) -> (['a'])
Note the optimization text as mentioned in the tuple formatter can't be
done. The call to parse may affect the formatter so its state needs to
be preserved.
Reviewed By: ldionne, #libc, EricWF
Differential Revision: https://reviews.llvm.org/D145847
Florian Hahn [Sat, 8 Apr 2023 12:04:08 +0000 (13:04 +0100)]
[VPlan] Require VFRange.End to be a power-of-2. (NFCI)
This removes the need to convert the end of the range to the next
power-of-2 for the end iterator after
4bd3fda5124962 and was suggested
as follow-up TODO in D147468.
Matt Arsenault [Sun, 5 Mar 2023 19:53:06 +0000 (15:53 -0400)]
AMDGPU: Add baseline test for issue 61083
Matt Arsenault [Sat, 8 Apr 2023 11:07:29 +0000 (07:07 -0400)]
llvm-reduce: Actually change to the temporary directory in test
Hopefully fixes issue #61132
Matt Arsenault [Sun, 5 Mar 2023 11:07:23 +0000 (07:07 -0400)]
AMDGPU: Fix LiveVariables verifier error for values defined before SI_END_CF
GlobalISel happens to insert some constant materializes before SI_END_CF
in one test. These need to be excluded from AliveBlocks since they
are defined in the original block and used in the split block,
so they aren't fully alive through either block.
The case where the value defined in the first block which was originally used
in a later block is still broken.
Avoids a verifier error in a future patch.
Matt Arsenault [Sun, 5 Mar 2023 01:14:08 +0000 (21:14 -0400)]
AMDGPU: Fix missing MIR serialization for PSInputAddr/PSInputEnable
Resuming any mir test for a pixel shader would assert in the AsmPrinter.
Florian Hahn [Sat, 8 Apr 2023 09:19:56 +0000 (10:19 +0100)]
[VPlan] Add VFRange::begin() and end() iterators. (NFCI)
Add an iterator to iterate over all VFs in VFRange. This simplifies some
existing code and allows using all_of,any_of and none_of on a VFRange.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D147468
Aiden Grossman [Sat, 8 Apr 2023 07:45:55 +0000 (07:45 +0000)]
[Docs][llvm-remarkutil] Fix dangling reference in documentation
D147710 introduced a new annotation-count subcommand to llvm-remarkutil
and added in documentation. However, the reference added under the
subcommands list never actually pointed to anything. This patch adds a
marker for the reference to point to so that the link works and the
sphinx build finishes without any errors.
Jay Foad [Thu, 6 Apr 2023 16:26:05 +0000 (17:26 +0100)]
[AMDGPU] Fix a case of updating LiveIntervals in SIOptimizeExecMaskingPreRA
This was causing two test failures when I applied D129208 to enable
extra verification of LiveIntervals:
LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking-wave32.mir
LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking.mir
Differential Revision: https://reviews.llvm.org/D147721