Alex Perovich [Sat, 25 Feb 2017 06:46:59 +0000 (00:46 -0600)]
Move S.Buffers and S.IO sources shared with corert into shared folder (dotnet/coreclr#9778)
Commit migrated from https://github.com/dotnet/coreclr/commit/
532c45a27aa2f804ed43448ef1666beeef6c96ae
Andy Ayers [Sat, 25 Feb 2017 01:51:10 +0000 (17:51 -0800)]
Merge pull request dotnet/coreclr#9756 from AndyAyersMS/RefCountGenericContext
JIT: keep ref count for runtime generic context lookups
Commit migrated from https://github.com/dotnet/coreclr/commit/
46994b9b3dd6de48f581f6d30eff0ad5c4092556
Stephen Toub [Sat, 25 Feb 2017 01:39:44 +0000 (20:39 -0500)]
Use clock_gettime(CLOCK_REALTIME) in DateTime.UtcNow (dotnet/coreclr#9772)
gettimeofday() is currently used in DateTime.UtcNow. Depending on the system, it may have accuracy and precision in line with either clock_gettime(CLOCK_REALTIME) or clock_gettime(CLOCK_REALTIME_COARSE), but in returning its data it's necessarily limited by struct timeval's tv_usec field (microseconds), whereas clock_gettime uses struct timespec which has tv_nsec (nanoseconds). This commit switches to use clock_gettime(CLOCK_REALTIME) to gain the additional precision (though the FILETIME through which the data is returned only supports 100-nsec precision). On my machine, there was no measurable impact to throughput.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3fe022eb723479d0b7acf17856e76a1973668ca6
Ahson Ahmed Khan [Sat, 25 Feb 2017 01:27:54 +0000 (17:27 -0800)]
Merge pull request dotnet/coreclr#9598 from ahsonkhan/OptimizeSpanClear
Optimize span clear
Commit migrated from https://github.com/dotnet/coreclr/commit/
da44463552689930c4d4ead5aa01a437fcbea622
Aditya Mandaleeka [Sat, 25 Feb 2017 00:37:26 +0000 (16:37 -0800)]
Remove optimizedtls.cpp (dotnet/coreclr#9777)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b927ad12373efd5840be34f011bb3c67ab1e156f
Jan Vorlicek [Fri, 24 Feb 2017 21:47:31 +0000 (22:47 +0100)]
Remove NakedThrowHelper and ifdef-out its callers (dotnet/coreclr#9771)
This change removes NakedThrowHelper function for Unix since it was not used.
It also ifdefs out its upstream callers.
Commit migrated from https://github.com/dotnet/coreclr/commit/
65053424c296f1fecb4c293276771accfe838e62
Andy Ayers [Fri, 24 Feb 2017 21:35:37 +0000 (13:35 -0800)]
review feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
b515aeee2d58c9bcf3d2d2114b8c1df60ce67368
Pat Gavlin [Fri, 24 Feb 2017 21:17:56 +0000 (13:17 -0800)]
Merge pull request dotnet/coreclr#9336 from mikedn/const-fold
Fix incorrect cast in gtFoldExprConst
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a98a60545b94cb0be5e2998109222640a76654b
Ian Hays [Fri, 24 Feb 2017 21:08:17 +0000 (13:08 -0800)]
Merge pull request dotnet/coreclr#9769 from ianhays/filelock_osx
Remove OSX FileStream Lock/Unlock
Commit migrated from https://github.com/dotnet/coreclr/commit/
70d8a4d7b244ec08e5e5aa1a0998a8cbbd35d251
Jan Vorlicek [Fri, 24 Feb 2017 20:29:15 +0000 (21:29 +0100)]
Remove getcontext and setcontext usage (dotnet/coreclr#9759)
It turns out that the getcontext and setcontext that I have used in my stack
oveflow reporting change are not present e.g. on Alpine Linux or on Android.
So I am replacing their usage with RtlCaptureContext and RtlRestoreContext
instead.
I have also found that the addition of the .cfi_adjust_cfa_offset to the
PROLOG_SAVE_REG_PAIR has broken unwinding of all helpers that use
PROLOG_WITH_TRANSITION_BLOCK, because the PROLOG_STACK_ALLOC macro
updates the CFA offset. So I am fixing that by removing the CFA offset
updating from the PROLOG_STACK_ALLOC and adding explicit one to the
ARM64 CallSignalHandlerWrapper.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d97861ce3fecc41b35d4c2e61f60ab7e54eedee8
Bruce Forstall [Fri, 24 Feb 2017 20:28:50 +0000 (12:28 -0800)]
Merge pull request dotnet/coreclr#9732 from hseok-oh/fix_9442
Fix code generation for array length check in legacy JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
12f575c6043e0316429df7c331121ddaefe30097
Mike Danes [Sat, 4 Feb 2017 10:17:13 +0000 (12:17 +0200)]
Enable DevDiv_377155
Commit migrated from https://github.com/dotnet/coreclr/commit/
63b5b05fdfbac6bbff44c06abf5745b4dc2f145c
Mike Danes [Sat, 4 Feb 2017 10:14:54 +0000 (12:14 +0200)]
Fix incorrect cast in gtFoldExprConst
The fact that an operation is unsigned affects the operation itself but that doesn't mean that the result of the operation is also unsigned. Constants are stored as ssize_t and the node type is TYP_INT so the result has to be sign extended, not zero extended.
Otherwise code that uses the return of IconValue() without first narrowing it to int will behave incorrectly. Such code does exists, even gtFoldExprConst does this when folding shift operations:
uint a = uint.MaxValue;
uint b = 0;
int r = (int)checked(a + b);
Console.WriteLine((r >> 2).ToString("X"));
The above code prints
3FFFFFFF instead of the expected
FFFFFFFF.
This also makes gtFoldExprConst consistent with ValueNumStore::EvalFuncForConstantArgs which evaluates TYP_INT nodes as int and then casts to ssize_t.
Commit migrated from https://github.com/dotnet/coreclr/commit/
176e2c7964846bf5dea22557f0828475deac05e1
Ian Hays [Fri, 24 Feb 2017 19:46:25 +0000 (11:46 -0800)]
Update FileLock/Unlock PNSE message for OSX
Commit migrated from https://github.com/dotnet/coreclr/commit/
10c6689e4cff982b49300428ce7d6627bbbbbdf7
Justin Van Patten [Fri, 24 Feb 2017 19:08:08 +0000 (11:08 -0800)]
Avoid unnecessary branch in CultureAwareComparer (dotnet/coreclr#9767)
* Avoid unnecessary branch in CultureAwareComparer
Determine the CompareOptions up-front instead of during each operation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc6b30e1b5d6fb2cb3aee084868c573c204a8338
William Godbe [Fri, 24 Feb 2017 18:54:40 +0000 (10:54 -0800)]
Merge pull request dotnet/coreclr#9749 from wtgodbe/XunitCopyStuff
Use -f instead of -n when copying from Core_Root in runtest.sh
Commit migrated from https://github.com/dotnet/coreclr/commit/
60969edc642693e82f34f091399aad55a86692b5
Ian Hays [Thu, 23 Feb 2017 22:46:15 +0000 (14:46 -0800)]
Remove OSX FileStream Lock/Unlock
OSX doesn't support usage of both fcntl and flock. Since we're already using one in FileShare for the entire file, we cannot enable partial file locking like we do on other Unix platforms. The alternative is to throw a PNSE and suggest using FileShare on the whole file instead.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0daa63e9ed40323b6f248ded8959530ea94f19aa
Stephen Toub [Fri, 24 Feb 2017 18:35:48 +0000 (13:35 -0500)]
Merge pull request dotnet/coreclr#9766 from discostu105/patch-1
fix typo in sos_md.h
Commit migrated from https://github.com/dotnet/coreclr/commit/
e75f17e47b874354f40dd038821fc3e06d47821b
Sean Gillespie [Fri, 24 Feb 2017 18:12:26 +0000 (10:12 -0800)]
[Local GC] Move workstation GC DAC globals to a struct shared between GC and DAC (dotnet/coreclr#9255)
* [Local GC] Move workstation GC DAC globals to a struct shared between
the GC and the DAC
* (Some) code review feedback and bug fixes for issues found while debugging on OSX
* Address some code review feedback:
1. Make g_gcDacGlobals a pointer and dacvar on the VM side, so
that publishing the GC dac vars is done atomically (through
a pointer assignment). This fixes a race that Noah noticed.
2. Remove the requirement for the GC's generation class struct
to be known at compile-time, by using a dacvar as the size
of the generation class at run-time (for pointer arithmetic)
3. Move all DAC-interesting fields to be at the start of GC
internal classes, so that the DAC does not need to know the
size or exact layout of the class past the fields it cares
about.
* Split the definition of the size of several arrays across the SOS/DAC and GC/DAC interfaces, and add static asserts that they are the same
* Repair the Windows Release build
* Implement the GC DAC scheme for Server GC and eliminate the duplicate GC dac vars
* Some work
* Decouple use of the GC generation table from a write barrier by having the EE store a copy of the global during initialization
* Actually make it work with server GC
* Checkpoint
* Checkpoint where everything works
* Code cleanup
* Fix debugger test failures
* Additional code cleanup
* Address code review feedback by adding a static assert and standardizing the way that we iterate over the generation table
* Repair the Windows x86 build
* Revert "Decouple use of the GC generation table from a write barrier by having the EE store a copy of the global during initialization"
This reverts commit dotnet/coreclr@
573f61a16b4fa8c2fc4c568c0b968a921230f31c.
* Revert "Repair the Windows x86 build"
This reverts commit dotnet/coreclr@
188c22d87e1d65abf00ab8fa28f46ad607a9028f.
* Partial revert, move `generation_table` back the global namespace for a single-proc allocation helper
* Fix a debugger test failure
* Repair crash dump scenarios
Commit migrated from https://github.com/dotnet/coreclr/commit/
6f6fda958dac38896abe9487def2242add822809
Christoph Neumüller [Fri, 24 Feb 2017 14:52:11 +0000 (15:52 +0100)]
fix typo in sos_md.h
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb21c38e5a050f191dbdad64be70fab79d4e141c
Jonghyun Park [Fri, 24 Feb 2017 14:48:58 +0000 (23:48 +0900)]
[Linux/ARM,ARM64] Fix undefined FixContextHandler issue (dotnet/coreclr#9755)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3392356945aabd5a3ebac5317ff4a0e0361dc9ad
Sujin Kim [Fri, 24 Feb 2017 14:43:15 +0000 (23:43 +0900)]
Fix segmentation fault when using ZapImage::PrintStats() (dotnet/coreclr#9731)
Currently, ZapImage::PrintStats is not used anywhere. But I want to get detailed informations about Native Image(ni.dll) components.
So I just used ZapImage::PrintStats when called ZapImage::SaveImage. After that I met the segmentation fault likes dotnet/coreclr#9680.
I found the reason for this issue is accessing the null pointer to get sizes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e876e8147d06a213f562021a4d02a5a60ba63c99
John Gorter [Fri, 24 Feb 2017 14:41:42 +0000 (15:41 +0100)]
typo in CMakeLists.txt (dotnet/coreclr#9763)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7716164c1d69b10b32a46060ec55d17d77ff5bd8
Stephen Toub [Fri, 24 Feb 2017 12:43:36 +0000 (07:43 -0500)]
Merge pull request dotnet/coreclr#9738 from stephentoub/ordinalignorecase_hashing
Tweak OrdinalComparer for OrdinalIgnoreCase
Commit migrated from https://github.com/dotnet/coreclr/commit/
9d066ad753629d57d1d263851d6d6c7bd1674e9c
Hanjoung Lee [Fri, 24 Feb 2017 07:02:21 +0000 (16:02 +0900)]
[x86/Linux] Initial patch for EH funclet (dotnet/coreclr#9601)
- Generate a simple EH funclet frame and support SP-based stack unwinding for funclets.
- Introduce assembly helpers : CallEHFunclet and CallEHFilterFunclet
Commit migrated from https://github.com/dotnet/coreclr/commit/
77f2ad4c07b24fcfe1298dd7cd260876ef46e6c3
Bruce Forstall [Fri, 24 Feb 2017 06:34:58 +0000 (22:34 -0800)]
Merge pull request dotnet/coreclr#9758 from seanshpark/fixx86break
Fix build break for !FEATURE_FIXED_OUT_ARGS
Commit migrated from https://github.com/dotnet/coreclr/commit/
687e0fbfe1b753653968308d1cd17c079c5a87fc
Sivarv [Fri, 24 Feb 2017 04:35:39 +0000 (20:35 -0800)]
Merge pull request dotnet/coreclr#9723 from fiigii/is4byte
Simplify and streamline Is4ByteAVXInstruction() and Is4ByteSSE4Instruction() functions
Commit migrated from https://github.com/dotnet/coreclr/commit/
93c35cd5dd3ee76460ec31948f0d4d222cdbe70d
Stephen Toub [Thu, 23 Feb 2017 18:15:27 +0000 (13:15 -0500)]
Address PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
109feb786bf010b2c34a78e6219be763656c9e65
Stephen Toub [Thu, 23 Feb 2017 16:25:03 +0000 (11:25 -0500)]
Improve CompareOrdinalIgnoreCaseHelper by removing return from loop
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2eed087d4e74361ef7fe71bc7b10e1d8a3edc26
Stephen Toub [Thu, 23 Feb 2017 16:37:23 +0000 (11:37 -0500)]
Strongly type StringComparer static comparer fields
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e85fdd61991a898f2bd208df929a005c26b8805
Stephen Toub [Thu, 23 Feb 2017 14:28:30 +0000 (09:28 -0500)]
Split OrdinalIgnoreCaseComparer from OrdinalComparer
They're both used very frequently, and we can eliminate the branches on checking _ignoreCase from every operation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a15b54477fb9503d2787b751e2c0b25c12becf37
Jan Kotas [Fri, 24 Feb 2017 02:51:03 +0000 (18:51 -0800)]
Reject byref-like object in FormatterServices.GetUninitializedObject (dotnet/coreclr#9754)
Fixes dotnet/coreclr#9739
Commit migrated from https://github.com/dotnet/coreclr/commit/
5957f2dde0f90c2bdaa4f0a83339c87140cc657b
Jonghyun Park [Fri, 24 Feb 2017 02:01:10 +0000 (11:01 +0900)]
[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL (dotnet/coreclr#9752)
* [x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL
* Move FeatureStubsAsIL into Windows-specific block
Commit migrated from https://github.com/dotnet/coreclr/commit/
70b21c84b90aa2c37bb7366ea175f59a03512ae4
SaeHie Park [Fri, 24 Feb 2017 01:03:26 +0000 (10:03 +0900)]
Fix build break for !FEATURE_FIXED_OUT_ARGS
Commit migrated from https://github.com/dotnet/coreclr/commit/
3f21d76a5466838accb8e15cfa9c55a89743adf2
Bruce Forstall [Fri, 24 Feb 2017 01:03:58 +0000 (17:03 -0800)]
Merge pull request dotnet/coreclr#9681 from mskvortsov/ryujit-arm32-reload
[RyuJIT/ARM32] Fix helper kill mask and call target consuming
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9749b431bf74c00b7e346a1f2e80e2032fd2b21
Stephen Toub [Fri, 24 Feb 2017 00:43:58 +0000 (19:43 -0500)]
Use GetSystemTimePreciseAsFileTime if available in DateTime.UtcNow (dotnet/coreclr#9736)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ec5c2f859f8ff1dc99a2bb95b640b82d2937cc8
Tanner Gooding [Fri, 24 Feb 2017 00:36:20 +0000 (16:36 -0800)]
Merge pull request dotnet/coreclr#9717 from tannergooding/math-intrinsics2
Updating codegenxarch to support single-precision CORINFO_INTRINSIC_Sqrt
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e494d0068d17b3692c88ab4247ca3c607a9b618
Andy Ayers [Sat, 18 Feb 2017 04:51:59 +0000 (20:51 -0800)]
JIT: keep ref count for runtime generic context lookups
Keep a ref count for runtime generic context lookups, and track when
an inlinee requires a runtime lookup but then ignores the resulting
context. Only report/keep the context alive if there are known uses.
This pattern happens frequently in inlined generic code that uses
type tests to extract properties of types.
Addresses dotnet/coreclr#1691.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5a1e02cd6f056cebdd1c240d400ac7a34234d43a
Sivarv [Fri, 24 Feb 2017 00:08:41 +0000 (16:08 -0800)]
Merge pull request dotnet/coreclr#9742 from sivarv/singleField
Enable promotion of structs containing fields of structs with a single pointer-sized scalar type field.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d3ee9301e88c6fea43072ac59fc451c7685a872a
Andy Ayers [Fri, 24 Feb 2017 00:08:23 +0000 (16:08 -0800)]
Merge pull request dotnet/coreclr#9748 from AndyAyersMS/FixJitTestDir
Move jit tests to directory with proper casing
Commit migrated from https://github.com/dotnet/coreclr/commit/
4def9e5bd59029fe9f84a260268ba12c25b5fb83
wtgodbe [Thu, 23 Feb 2017 22:29:41 +0000 (14:29 -0800)]
Use -f instead of -n when copying from Core_Root in runtest.sh
Commit migrated from https://github.com/dotnet/coreclr/commit/
3eab59fc71cf9fc99f0d555d41974e310465c54b
Alex Perovich [Thu, 23 Feb 2017 23:20:04 +0000 (17:20 -0600)]
Merge pull request dotnet/coreclr#9726 from alexperovich/codeFormat
Run dotnet/codeformatter on S.P.CoreLib sources.
Commit migrated from https://github.com/dotnet/coreclr/commit/
68f72dd2587c3365a9fe74d1991f93612c3bc62a
Andy Ayers [Thu, 23 Feb 2017 22:53:00 +0000 (14:53 -0800)]
Add jit test project checker as jit test (dotnet/coreclr#9721)
Add the tool used to fix/repair projects as a test case. It will
fail with an error code if any project file in the jit test subtree
needs fixing.
This test requires CORE_ROOT to point at the test overlay and
that directory be rooted under the repo (other test cases already
have similar requirements).
CodeGenBringUp tests are noted as needing fixes, but are accounted
for under the category of "deferred fixes".
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdea3db0927e279c6d9bd6531bff84e4cbd94eaa
Andy Ayers [Thu, 23 Feb 2017 22:52:10 +0000 (14:52 -0800)]
JIT: defer setting outgoing args size until after optimization (dotnet/coreclr#9683)
For fixed out args ABIs, the jit currently computes the size of the
out arg area during morph, as it encounters calls that must pass arguments
via the stack.
Subsequently, the optimizer may delete calls, either because they are
pure and the results are unused, or because they are conditional and the
guarding predicates are resolved by the optimizer in such a way that
the call is no longer reachable.
In particular if all the calls seen by morph are subsequently removed by
the optimizer, the jit may generate a stack frame that it never uses and
doesn't need. If only some calls are removed then the stack frame may end
up larger than necessary.
One motivating example is the inlining of a shared generic method that
ignores its generic context parameter. The caller typically must invoke a pure
helper to determine the proper argument to pass. Post inline the call's result
is unused, and the helper call is deleted by the optimizer.
This change defers the outgoing arg size computation until fgSimpleLowering,
which runs after optimization. The code in morph now simply records the
needed size for each call in the associated fgArgInfo.
As before, the outgoing arg size computation ignores fast tail calls, since
they can use the caller-supplied scratch area for memory arguments.
The jit may introduce helper calls after optimization which could seemingly
invalidate the out args area size. The presumption here is that these calls
are carefully designed not to use the caller-supplied scratch area. The
current code makes the same assumption.
This change introduces some unanticipated diffs. Optcse estimates the
frame size to decide how aggressive it should be about cses of local
variable references. This size estimate included the out args area, which
appears to be something of an oversight; there are no cse opportunities
in this area and the offsets of the other local variables are not impacted
by the size of this area. With this change the out args area size is seen
as zero during optimization and so the cse strategy for a method may be
different.
Commit migrated from https://github.com/dotnet/coreclr/commit/
eaf5835d6a0e914edfdbb6ad1a8af2660e87a08c
Pat Gavlin [Thu, 23 Feb 2017 22:20:45 +0000 (14:20 -0800)]
Merge pull request dotnet/coreclr#9582 from pgavlin/vzeroupper_x86_epilog
Do not report FP restores in x86 epilogs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0abb98f1dc88845c82722bd48b4127ed1c728534
Brian Sullivan [Thu, 23 Feb 2017 21:56:09 +0000 (13:56 -0800)]
Merge pull request dotnet/coreclr#9454 from mikedn/cgtun-to-cne
Morph (x GT_GT.unsigned 0) into (x GT_NE 0)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f47c6fd43ba50cd59fa77e523dbc562df7f98c2c
Andy Ayers [Thu, 23 Feb 2017 21:46:20 +0000 (13:46 -0800)]
Move jit tests to directory with proper casing
Closes dotnet/coreclr#9747.
Commit migrated from https://github.com/dotnet/coreclr/commit/
891773bc76162439e8fe8fd06f3bb7227879548a
Alex Perovich [Wed, 22 Feb 2017 23:23:44 +0000 (15:23 -0800)]
Run codeformatter on S.P.CoreLib sources
Commit migrated from https://github.com/dotnet/coreclr/commit/
ea9bee5ac2f96a1ea6b202dc4094b8d418d9209c
Alex Perovich [Wed, 22 Feb 2017 23:23:25 +0000 (15:23 -0800)]
Manual change to make codeformatter work
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ace58ac2bba14ffd469ecb89f972b8e9b8fd61d
Fei Peng [Wed, 22 Feb 2017 18:38:52 +0000 (10:38 -0800)]
Rewrite Is4ByteAVXInstruction() and Is4ByteSSE4Instruction()
Commit migrated from https://github.com/dotnet/coreclr/commit/
d14d26a8ef2b8c46b14c9f6be7e61be5438e1083
sivarv [Thu, 23 Feb 2017 18:59:28 +0000 (10:59 -0800)]
Enable promotion of structs containing fields of structs with a single pointer-sized scalar type field.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc35e361b1c1ddeb9e36dbb293f1456a211f5216
Wes Haggard [Thu, 23 Feb 2017 21:23:53 +0000 (13:23 -0800)]
Merge pull request dotnet/coreclr#9743 from weshaggard/UpdateUsingYourBuildDocs
Update UsingYourBuildDocs to use .NET Core 2.0 SDK
Commit migrated from https://github.com/dotnet/coreclr/commit/
45d14be87c2ca02c6d190ca38fe0d8c585d56c5e
Wes Haggard [Thu, 23 Feb 2017 19:13:59 +0000 (11:13 -0800)]
Update UsingYourBuild docs to use .NET Core 2.0 SDK
Commit migrated from https://github.com/dotnet/coreclr/commit/
53d0f39ba6784397ce95399fe2e99ba093f0b0be
Brian Robbins [Thu, 23 Feb 2017 20:12:00 +0000 (12:12 -0800)]
Merge pull request dotnet/coreclr#9741 from brianrob/issue-9733
Disable Test Broken By CoreFX PR # 15767
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a95e4ece8cb415b3cd3a7c10a0ce1a9ac6d2873
Brian Sullivan [Thu, 23 Feb 2017 19:22:03 +0000 (11:22 -0800)]
Merge pull request dotnet/coreclr#9655 from sdmaclea/PR-ARM64-JITGC-WIP3
[Arm64] Correct CORINFO_HELP_ASSIGN_BYREF killed mask
Commit migrated from https://github.com/dotnet/coreclr/commit/
f78bf7d393501c279821bb0e7fa4c26550cc898c
Pat Gavlin [Thu, 23 Feb 2017 18:48:25 +0000 (10:48 -0800)]
Format code.
Commit migrated from https://github.com/dotnet/coreclr/commit/
187255c281084156bbc103d2c17729a0ab0c96b6
Pat Gavlin [Thu, 23 Feb 2017 18:39:10 +0000 (10:39 -0800)]
Address PR feedback.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bd4028154190a245f322d859484fd39375201d00
Brian Robbins [Thu, 23 Feb 2017 18:27:58 +0000 (10:27 -0800)]
Disable broken tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4c760c55ae357aa3e78b33ac497f05edc3d0ce54
Bruce Forstall [Thu, 23 Feb 2017 17:26:55 +0000 (09:26 -0800)]
Merge pull request dotnet/coreclr#9727 from BruceForstall/DontBuildJitLib
Speed up JIT builds
Commit migrated from https://github.com/dotnet/coreclr/commit/
5932d885cb60427c895aca7bceae83a34e36be3a
Peter Kukol [Thu, 23 Feb 2017 16:13:34 +0000 (09:13 -0700)]
Simplified MinOpts GC ref tracking. (dotnet/coreclr#9231)
Simplified MinOpts GC ref tracking - when a method is compiled with MinOpts for targets with the 64-bit GC info encoder we mark all GC slots as untracked and we omit encoding call sites with no live tracked GC refs explicitly in the GC tables; this can be controlled using the new COMPlus_JitMinOptsTrackGCrefs environment flag.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d7509df9635ca92c1a3cf75dc2516ae51b0e03d6
Frederik Carlier [Thu, 23 Feb 2017 10:09:24 +0000 (02:09 -0800)]
Android: workaround absence of getcontext/setcontext (dotnet/coreclr#9725)
* Android: workaround absence of getcontext/setcontext
use RtlCaptureContext and RtlRestoreContext
Commit migrated from https://github.com/dotnet/coreclr/commit/
08581d8e9515ef1a348e7509785ea29195a9de37
Mikhail Skvortcov [Mon, 20 Feb 2017 14:56:54 +0000 (17:56 +0300)]
RyuJIT/ARM32: Fix helper kill mask and call target consuming
Commit migrated from https://github.com/dotnet/coreclr/commit/
79817a4110f0fcf016f44432dc47fb56d7891b0c
Hyeongseok Oh [Thu, 23 Feb 2017 05:54:03 +0000 (14:54 +0900)]
Fix code generation for array length check in legacy JIT
check array index is in register and reload it if spilled
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e7e09d3b58bb7adff5dac3a51c5b6eee78c7c90
Stephen Toub [Thu, 23 Feb 2017 07:22:43 +0000 (02:22 -0500)]
Reduce code in SafeHandleAddRef (dotnet/coreclr#9724)
If DangerousAddRef returns rather than throws, its argument will be true, so there's no need to branch on it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6af4182d058df3520103d81c3912899e8d29f884
Tanner Gooding [Thu, 23 Feb 2017 03:07:32 +0000 (19:07 -0800)]
Porting the CoreMangLib/cti/system/math tests to CoreMangLib/cti/system/mathf
Commit migrated from https://github.com/dotnet/coreclr/commit/
74057cb5df9a3bcf31cfe72ab0fc7f45ce95f09c
Ben Adams [Thu, 23 Feb 2017 03:15:57 +0000 (03:15 +0000)]
Faster List Add (dotnet/coreclr#9539)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d9e01719d29b9dda2d1f53fe15461f9b371e604
[Arm64] Fix genCodeForCpObj()
CORINFO_HELP_ASSIGN_BYREF is the functional equivalent to
*dst = *src;
++dst;
++src;
Note: Description ignores barriers.
Since src and dst are incremented the registers are marked dead.
In genCodeForCpObj(), the incremented values are will be reused
and therefore must be treated as live. Add code to explicitly
force them live for this use case.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a5d464837248bae64845fb3e8207821d29f316d8
Tanner Gooding [Mon, 6 Feb 2017 01:58:28 +0000 (01:58 +0000)]
Updating codegenxarch to support single-precision CORINFO_INTRINSIC_Sqrt
Commit migrated from https://github.com/dotnet/coreclr/commit/
59d834e4711c351cf9f7326b636294ece42675eb
Tanner Gooding [Thu, 23 Feb 2017 01:36:12 +0000 (17:36 -0800)]
Merge pull request dotnet/coreclr#9363 from tannergooding/math-intrinsics
Updating jit/valuenum to properly handle the single-precision versions of the math intrinsics.
Commit migrated from https://github.com/dotnet/coreclr/commit/
116752f4138f9e26237c9435bdcde129d4aa3398
Pat Gavlin [Wed, 22 Feb 2017 19:05:25 +0000 (11:05 -0800)]
Do not report FP restores in x86 epilogs.
The x86 unwinder neither needs nor expects to see these restores (which
right now consist solely of a `vzeroupper` instruction that is emitted
to eliminate AVX <-> SSE transition penalties), which was causing unwind
failures under GC stress. This change stops reporting these restores as
part of a function epilog.
Fixes dotnet/coreclr#9452.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce70f4c2acae22fd8eaee1588c3f54596e521c8a
ahsonkhan [Wed, 22 Feb 2017 23:56:04 +0000 (15:56 -0800)]
Changing AddNative to AddByteOffset
Commit migrated from https://github.com/dotnet/coreclr/commit/
ec6fb88e7009457f54f31ba83da915af395f4bd6
Bruce Forstall [Wed, 22 Feb 2017 23:43:18 +0000 (15:43 -0800)]
Speed up JIT builds
We don't need to build the static lib and crossgen static lib
versions of the JIT unless FEATURE_MERGE_JIT_AND_ENGINE is set.
And, since we currently don't set it, this means doing two
fewer JIT builds.
Commit migrated from https://github.com/dotnet/coreclr/commit/
91681810db13a23fa7fc0437340946bf8cfe140b
Jarret Shook [Wed, 22 Feb 2017 23:30:14 +0000 (15:30 -0800)]
Merge pull request dotnet/coreclr#9654 from sdmaclea/PR-ARM64-JITGC-WIP2
[WIP] [Arm64] Fix GC liveness for CodeGen::genPutArgStk()
Commit migrated from https://github.com/dotnet/coreclr/commit/
989bf9e101e072c185b58aed175d4ae181c4f57b
Jarret Shook [Wed, 22 Feb 2017 23:30:03 +0000 (15:30 -0800)]
Merge pull request dotnet/coreclr#9653 from sdmaclea/PR-ARM64-JITGC-WIP1
[WIP] [Arm64] Fix GC hole in CodeGen::genCodeForCpObj()
Commit migrated from https://github.com/dotnet/coreclr/commit/
bbfa7f72292f7dd26993fb108e5eeb1b573c580f
Jan Vorlicek [Wed, 22 Feb 2017 22:18:01 +0000 (23:18 +0100)]
Improve stack overflow reporting (dotnet/coreclr#9650)
* Improve stack overflow reporting
This change modifies the SIGSEGV handling to use an alternate stack so that
we can safely detect and report stack overflow even in case when we are
really out of stack. Before, we were able to detect stack overflow and report
it only when JIT inserted stack probes (for functions with frames larger than
4kB) and so there was still space on the stack to run the sigsegv handler.
It brings in some additional complexity, since we need to switch to the original
stack of the thread once we figure out the sigsegv is not a stack overflow and
if we return from the hardware exception handler, we need to switch back to the
alternate stack before returning from the sigsegv handler.
Also, the alternate stack is created per thread and so we need to correctly destroy
it when a thread terminates and also install it on foreign threads that enter PAL.
This also requires creating fake stack frames to enable the libunwind to walk
the stack from the exception handler to the sigsegv location.
* Fix stack unwinding in CallDescrWorkerInternal
While testing the change to enable stack overflow handling, I've noticed that
the PROLOG_SAVE_REG_PAIR and PROLOG_SAVE_REG_PAIR_INDEXED macros are missing
.cfi_def_cfa_register fp. That resulted in inability to unwind through the
CallDescrWorkerInternal, since this function dynamically allocates stack slots
and so the default sp based frame doesn't work.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f193024a5ef8f277f08bed3721e2e8e730aabdb9
Frederik Carlier [Wed, 22 Feb 2017 22:17:01 +0000 (14:17 -0800)]
CMake configuration for cross building for Android (dotnet/coreclr#9174)
* Configuration files for cross building for Android arm64
* Simplify toolchain script
* Fix trymake values for Android
Commit migrated from https://github.com/dotnet/coreclr/commit/
09fd5fbd08d376aa0d7b2602e5115aaabcd7b352
Andy Ayers [Wed, 22 Feb 2017 20:20:08 +0000 (12:20 -0800)]
Merge pull request dotnet/coreclr#9712 from AndyAyersMS/FixSomeTestProjFiles
Fix jit test projects to specify debug type and optimization flags
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2f85611eaf2560282c420731428d7204d169317
Michal Strehovský [Wed, 22 Feb 2017 20:04:37 +0000 (12:04 -0800)]
Add test coverage for ldtoken with members (dotnet/coreclr#9713)
The test coverage for `ldtoken field X` and `ldtoken method X` in the
repo is very small - this test tries to improve things a little.
In particular, it tests that we get the right reflection objects, and
that we can do this from shared and unshared code.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ae7ce48780c2db9ca8b4208c89b0db6aae97187
Bruce Forstall [Wed, 22 Feb 2017 19:29:58 +0000 (11:29 -0800)]
Merge pull request dotnet/coreclr#9714 from BruceForstall/FixRegMasks
Fix non-Windows amd64 register mask initialization
Commit migrated from https://github.com/dotnet/coreclr/commit/
27d5d92f6a07f515dff2074a77f4ee63477e5456
Michelle McDaniel [Wed, 22 Feb 2017 19:00:39 +0000 (11:00 -0800)]
Merge pull request dotnet/coreclr#9702 from adiaaida/fixX86PerfTesting
Fix x86 perf testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
4bc6f91f2e86cd6d0e5a1def8f7d57244434764f
[Arm64] Fix GC hole in CodeGen::genCodeForCpObj()
Update tempreg liveness
Commit migrated from https://github.com/dotnet/coreclr/commit/
35243a54053787ed6d6cccc9e67571a2bed0c0f4
[Arm64] Fix GC liveness for CodeGen::genPutArgStk()
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f7b37f5220ac7d14ca75a7dd01da0665a3b13e7
Tanner Gooding [Wed, 22 Feb 2017 15:25:26 +0000 (07:25 -0800)]
Updating ValueNumStore to no longer upcast float to double when performing evaluations.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f05f425d0e3dbdf70ccc2cf4bb6e9886def0019
James Ko [Wed, 22 Feb 2017 18:01:40 +0000 (13:01 -0500)]
Separate Comparer and EqualityComparer creation logic into a non-generic class (dotnet/coreclr#9640)
Commit migrated from https://github.com/dotnet/coreclr/commit/
84092471c678da00bb59d86fb5fcd0890a524472
Andy Ayers [Wed, 22 Feb 2017 17:31:14 +0000 (09:31 -0800)]
Fix projects that specified DebugType incorrectly
Make conditional DebugType properties uncondtional. Fix debug type
and optimize settings for _d and _do suffixed tests. Remove conditional
DebugType propery if there is also an unconditonal property.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e36c46a2e53dabb008e89b10ed138f0ccf7f192a
Pat Gavlin [Wed, 22 Feb 2017 17:29:58 +0000 (09:29 -0800)]
Merge pull request dotnet/coreclr#9704 from pgavlin/corefx15913
Correctly pass 12-byte GT_SIMD nodes on x86.
Commit migrated from https://github.com/dotnet/coreclr/commit/
749180a3799da8a495981ba85734dfffd09115f3
Gaurav Khanna [Wed, 22 Feb 2017 16:58:43 +0000 (08:58 -0800)]
Merge pull request dotnet/coreclr#9660 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25021-03, beta-25022-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbe12daf0cd0f9911fa50f07adb5149aac7f360c
dotnet-bot [Wed, 22 Feb 2017 15:16:14 +0000 (15:16 +0000)]
Update CoreClr, CoreFx to beta-25021-03, beta-25022-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
c0edf93600bc6ab39ec484177c129ebf178e8d2e
Jonghyun Park [Wed, 22 Feb 2017 14:43:30 +0000 (23:43 +0900)]
Clean up ClrUnwindEx (dotnet/coreclr#9482)
* Clean up ClrUnwindEx
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f5cae07e65d646fd57fdca7376d4b2f1dccad00
Tanner Gooding [Wed, 22 Feb 2017 14:09:37 +0000 (06:09 -0800)]
Dropping some unnecessary conditional statements in jit\valuenum.cpp
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f69d1f0dd82d1452d82080aabfbc751fdc2886d
Tanner Gooding [Mon, 6 Feb 2017 06:44:14 +0000 (06:44 +0000)]
Updating jit/valuenum to properly handle the single-precision versions of the math intrinsics.
Commit migrated from https://github.com/dotnet/coreclr/commit/
43ea736713dd1bf83957c8685a2f8a8a6d2ff88d
ahsonkhan [Wed, 22 Feb 2017 03:24:59 +0000 (19:24 -0800)]
Fixing places where Add to AddNative was missed along with ifdef on BIT64
Commit migrated from https://github.com/dotnet/coreclr/commit/
34f5129bbe9c26dece6e6aeca08ff8ee59d1e37f
ahsonkhan [Wed, 22 Feb 2017 02:48:06 +0000 (18:48 -0800)]
Using BIT64 ifdefs to use ints instead of longs
Commit migrated from https://github.com/dotnet/coreclr/commit/
703396bab40d260d9c704d016c617c65bf7bed42
ahsonkhan [Wed, 22 Feb 2017 02:33:56 +0000 (18:33 -0800)]
Adding Unsafe.Add that takes nuint instead of int32
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c27868bc544c619cbabad9322b21f9b177c44b5
Bruce Forstall [Wed, 22 Feb 2017 01:06:46 +0000 (17:06 -0800)]
Fix non-Windows amd64 register mask initialization
The arrays were being initialized with register numbers, not
register masks. The arrays are only used on non-Windows amd64
for homing circular incoming argument conflicts. Perhaps we
never saw this happen?
Commit migrated from https://github.com/dotnet/coreclr/commit/
f8646043219a5367b2090e9e9a0f504734c8e6e3
Andy Ayers [Wed, 22 Feb 2017 02:13:25 +0000 (18:13 -0800)]
Fix jit test projects to specify debug type and optimization flags
This partially addresses the issues raised in dotnet/coreclr#4124 and dotnet/coreclr#4724 by explicitly
and unconditionally setting DebugType and Optimize flags for various test
project files.
The projects that were fixed are those that did not specify any debug
flag settings at all. The fix is to set DebugType to PdbOnly and to set
Optimization to true, unless the test has an _r or _rel suffix, in which
case Optimization is set false.
This impacts 1497 projects, skipping over 311 projects flagged as needing
fixes. The projects that remain are the CodeGenBringUp set (for which we plan
to clone projects to test the various flag combinations), projects that
specify flags but do so in ways where the effective flag settings may vary
from DBG to RET, projects that specify the flags redundantly, or projects
where the flags are not consistent with the "test case name suffix" rules.
The edits were done by a tool using linq-to-xml and so some incidental
reformatting has happened.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f60e421e3cc6c6c7160bc3b679e8a08530ae275a
Michelle McDaniel [Tue, 21 Feb 2017 19:35:04 +0000 (11:35 -0800)]
Fix x86 perf testing
We did not use a different architecture in run-xunit-perf.cmd, so all the
x86 runs were uploading to the same architecture. This change fixes it so
x86jit32 runs upload to their own architecture. Also fixes the delayed
expansion issue for testenv.
Commit migrated from https://github.com/dotnet/coreclr/commit/
be7cd4d6b59d65b5a74feb8a698b90b641732cec
Michal Strehovský [Wed, 22 Feb 2017 00:37:04 +0000 (16:37 -0800)]
Use CORINFO_CALLCONV to check for unmanaged calls (dotnet/coreclr#9697)
`GTF_CALL_UNMANAGED` is a member of the wrong enum and it's something
that would be set on `call->gtFlags` except that at this point it isn't.
Check against the actual unmanaged calling conventions.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b4e58ac7a455640a5410b6f647ca3044426ea56
SaeHie Park [Wed, 22 Feb 2017 00:26:21 +0000 (09:26 +0900)]
[x86/Linux] Fix framepointer while unwinding (dotnet/coreclr#9678)
Use pCallerContext when getting frame pointer
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d7eedbbfd0d259659517ca68de05b82ec7f87a5
Pat Gavlin [Tue, 21 Feb 2017 23:15:22 +0000 (15:15 -0800)]
Add a regression test.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ea0a3cd0967abdfd0ab6392a82cae45568d14503