ChunEon Park [Fri, 6 Apr 2012 07:14:10 +0000 (07:14 +0000)]
elementary/popup - [E-devel] [Patch][elementary] elc_popup, focus next hook implementation
Current Issue:
Focus does not go to Popup content and action area.
Reason:
focus_next hook is returning EINA_FALSE in focus_next_hook.
Change Description:
1. Routed the focus_next call to the internal notify object.
2. Set the visibility of action area layout in edc to True as the
visibility of the action area layout returns zero even if due to state
change it is set to visible state in edje.
3. Deleted the show event callback "_popup_show" in del_pre_ hook.
Signed-Off-By: RAJEEV RANJAN<rajeev.r>@samsumg.com>
SVN revision: 69947
Daniel Juyung Seo [Fri, 6 Apr 2012 07:10:29 +0000 (07:10 +0000)]
elm genlist: Get the stringlist only when it does not exist. Free the stringlist when we change the item class.
SVN revision: 69946
Daniel Juyung Seo [Fri, 6 Apr 2012 07:10:26 +0000 (07:10 +0000)]
elm genlist: Renamed internal variables. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:13 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> It simple renaming patch for elm_genlist.
> I rename two variables.
>
> deco_all_obj -> deco_all_view
> deco_all_textss -> deco_all_texts
>
> Thanks
SVN revision: 69945
Daniel Juyung Seo [Fri, 6 Apr 2012 07:10:20 +0000 (07:10 +0000)]
elm genlist: Patch for elm_genlist_item_fields_update. Patch by
Hyoyoung Chang <hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:12 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I made a patch for elm_genlist_fields_update to selective content
update.
> a genlist item can update any content regardless of its mode.
>
> Thanks.
>
> PS: It assumed my previous patch is applied ([patch] elm_genlist -
> split flip content from item's content)
SVN revision: 69944
ChunEon Park [Fri, 6 Apr 2012 06:19:16 +0000 (06:19 +0000)]
elementary/win - [E-devel] [Patch][Elementary] Patch for elm_win to fix the focus chain issue in case of a widget added as a normal sub-object, not a resizable object
Current Issue:
Currently when we add a widget to window as a sub-object, e.g.
elm_notify_add(win) which internally calls elm_widget_sub_object_add
then the focus chain using <TAB> includes only
the first focusable subitem of the widget, not all.
Whereas with elm_win_resize_object_add, it works fine and cycles to
all focusable sub-items of the widget.
Reason:
The reason is that we are appending sub-object to the list in
elm_win which is used for focus chain, only in case of
elm_win_resize_object_add.
Change Description:
Added a new API: EAPI Eina_List
*elm_widget_sub_object_list_get(const Evas_Object *obj);
This API returns the list of sub-objects of an elementary widget
(sd->subobjs) where sd is Smart_Data pointer obtainted using
elm_widget_smart_data_get(obj).
We have used this API in elm_win for focus_next_hook implementation.
Signed-Off-By: RAJEEV RANJAN<rajeev.r>@samsumg.com>
SVN revision: 69943
ChunEon Park [Fri, 6 Apr 2012 05:58:50 +0000 (05:58 +0000)]
elementary/cnp - [E-devel] [Patch] elm_cnp notify_handler patch
When pasting data to entry, notify_handler_text sent incorrect string.
Because notify_handler_text received string including garbage value.
I cut string as its data length.
Signed-By-Off: Minseok Kim <minseok3.kim@samsung.com>
SVN revision: 69942
Daniel Juyung Seo [Fri, 6 Apr 2012 04:14:48 +0000 (04:14 +0000)]
elm genlist: Refactored flip mode. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>
On Wed, Apr 4, 2012 at 9:23 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> in genlist flip mode, a item shares its content and flip content.
> it's split flip content patch.
>
> Thanks.
SVN revision: 69941
Jihoon Kim [Fri, 6 Apr 2012 00:56:06 +0000 (00:56 +0000)]
elementary: ignore key event of keypad when NumLock is turned on in calendar, diskselector, gengrid, genlist, and player
SVN revision: 69939
ChunEon Park [Thu, 5 Apr 2012 08:19:26 +0000 (08:19 +0000)]
elementary/genlist - [E-devel] [Patch][Genlist] removed unnecessary code in _clear_cb
Dear ALL,
If the block that must be removed/freed, it has already removed/freed in
_item_block_del.
So I removed the code in _clear_cb.
Thanks
Joey
Submitted-By-Off ChankWook Jung<jchanwook@gmail.com>
SVN revision: 69929
Jihoon Kim [Thu, 5 Apr 2012 01:18:51 +0000 (01:18 +0000)]
elm/list: igonore key event of keypad when NumLock is turned on.
SVN revision: 69922
Daniel Zaoui [Wed, 4 Apr 2012 09:04:39 +0000 (09:04 +0000)]
elm layout: Fixed handling of NULL in part_content_set.
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 69918
Jaehwan Kim [Wed, 4 Apr 2012 08:13:39 +0000 (08:13 +0000)]
The animation have to be stopped just if the scroller is not holded or freezed.
SVN revision: 69916
ChunEon Park [Tue, 3 Apr 2012 15:18:09 +0000 (15:18 +0000)]
elementary/route,mapbuf,segment_control, slideshow - removed unnecessary code and left FIXMEs
SVN revision: 69907
ChunEon Park [Tue, 3 Apr 2012 14:59:27 +0000 (14:59 +0000)]
elementary/flip - removed unnecesarry code. and leaved FIXMEs
SVN revision: 69906
ChunEon Park [Tue, 3 Apr 2012 14:47:05 +0000 (14:47 +0000)]
elementary/flip - fixed incorrect
SVN revision: 69904
ChunEon Park [Tue, 3 Apr 2012 14:29:38 +0000 (14:29 +0000)]
elementary/widget - let the child unset the clip on smart_member_del
SVN revision: 69903
Daniel Juyung Seo [Tue, 3 Apr 2012 14:26:17 +0000 (14:26 +0000)]
elm test.c: Fixed formatting.
SVN revision: 69902
Daniel Juyung Seo [Tue, 3 Apr 2012 14:26:09 +0000 (14:26 +0000)]
elm test: Separated test menu creation function.
SVN revision: 69901
Daniel Juyung Seo [Tue, 3 Apr 2012 12:53:23 +0000 (12:53 +0000)]
elm test_genlist.c: Use proper test name for genlist decorate item/all modes.
SVN revision: 69895
WooHyun Jung [Tue, 3 Apr 2012 11:40:06 +0000 (11:40 +0000)]
elementary : Removing duplicate codes when _content_unset.
SVN revision: 69894
Daniel Juyung Seo [Tue, 3 Apr 2012 09:56:53 +0000 (09:56 +0000)]
elm genlist: Renamed internal variables and functions. Patch by Hyoyoung Chang <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:44 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all
>
> It renames genlist internal variables and functions.
>
> decorate_type -> decorate_it_type
> mode_set -> decorate_it_set
>
> It also includes that a api arguments' naming is changed.
> -EAPI void
> elm_genlist_item_decorate_mode_set(Elm_Object_Item *it, const char
> *mode_type, Eina_Bool mode_set);
> +EAPI void
> elm_genlist_item_decorate_mode_set(Elm_Object_Item *it, const char
> *decorate_it_type, Eina_Bool decorate_it_set);
>
> Thanks.
SVN revision: 69893
Daniel Juyung Seo [Tue, 3 Apr 2012 09:56:49 +0000 (09:56 +0000)]
elm genlist: Renamed internal variables/functions. Patch by Hyoyoung Chang <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:39 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all
>
> It renames genlist internal variables/functions.
>
> decorate_mode->decorate_all_mode
> _decorate_mode_item_*->_decorate_all_item_*
>
> thanks.
SVN revision: 69892
Daniel Juyung Seo [Tue, 3 Apr 2012 09:56:44 +0000 (09:56 +0000)]
elm genlist: Internal variable rename. Patch by Hyoyoung Change <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:39 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Oops sorry.
> Adding attachment patch file.
>
> On Mon, Apr 2, 2012 at 8:36 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
>> Dear all
>>
>> it renames genlist internal variables.
>>
>> mode_view ->deco_it_view
>> decorate_mode_item_realized->decorate_all_item_realized
>>
>> thanks.
SVN revision: 69891
ChunEon Park [Tue, 3 Apr 2012 07:30:11 +0000 (07:30 +0000)]
elementary/widget - removed item smart callback internal infra.
Not exposed and not used anywhere.
We don't recommend to apply this.
SVN revision: 69889
Vincent Torri [Mon, 2 Apr 2012 16:39:08 +0000 (16:39 +0000)]
Elm: second doc patch
Patch by Jérôme Pinot
SVN revision: 69866
WooHyun Jung [Mon, 2 Apr 2012 12:33:29 +0000 (12:33 +0000)]
elementary/button : Some codes were duplicated in _sub_del and
_content_unset_hook.
SVN revision: 69861
ChunEon Park [Mon, 2 Apr 2012 08:13:26 +0000 (08:13 +0000)]
elementary/mapbuf - super trivial changes
SVN revision: 69857
ChunEon Park [Mon, 2 Apr 2012 07:51:11 +0000 (07:51 +0000)]
elementary/index - removed unnecessary code
SVN revision: 69856
WooHyun Jung [Mon, 2 Apr 2012 06:33:40 +0000 (06:33 +0000)]
elementary/elm_entry : fix a mistake in commit 69829
SVN revision: 69850
Vincent Torri [Mon, 2 Apr 2012 06:28:10 +0000 (06:28 +0000)]
Elm: update Doxyfile and remove doxygen documentation for deprecated widgets:
- anchorblock
- anchorview
- pager
Patch by Jérôme Pinot
SVN revision: 69849
Daniel Juyung Seo [Mon, 2 Apr 2012 06:20:28 +0000 (06:20 +0000)]
elm bin: Use convenient utility function elm_win_util_standard_add()
instead of elm_win_add() + elm_bg_add(). This is for normal style
(ELM_WIN_BASIC) window.
SVN revision: 69848
Daniel Juyung Seo [Mon, 2 Apr 2012 06:20:22 +0000 (06:20 +0000)]
Revert a wrong commit. Un-wanted files are committed together.
Revert "elm bin: Use convenient utility function elm_win_util_standard_add() instead of elm_win_add() + elm_bg_add(). This is for normal style (ELM_WIN_BASIC) window."
This reverts commit
31b24a0edb0028528d7c859070e03236ba42867b.
SVN revision: 69847
ChunEon Park [Mon, 2 Apr 2012 06:20:01 +0000 (06:20 +0000)]
elementary/datetime - Elm_datetime open source patch : Datetime enhancements
Change Description:
- Year min/max values are moved to elm_config.
- Format specifier must come along with % followed by any separator. ( % 123d is not supported but %d will denote Date format specifier)
- Field separator can constitute multiple spaces, Space followed by any other non format specifier is also treated as the separator till its max length. ( %d x/ %b #2 format displays 27 x/ Mar #2 )
Thanks, Sumanth
Submitted-By-Off Sumanth Krishna Mannam<sumanth.m@samsung.com>
SVN revision: 69846
Daniel Juyung Seo [Mon, 2 Apr 2012 06:07:58 +0000 (06:07 +0000)]
elm bin: Use convenient utility function elm_win_util_standard_add() instead of elm_win_add() + elm_bg_add(). This is for normal style (ELM_WIN_BASIC) window.
SVN revision: 69845
ChunEon Park [Mon, 2 Apr 2012 05:00:39 +0000 (05:00 +0000)]
elementary/dayselector - pretty better.
SVN revision: 69844
ChunEon Park [Mon, 2 Apr 2012 04:53:39 +0000 (04:53 +0000)]
elementary/dayselector - improve design
SVN revision: 69843
ChunEon Park [Mon, 2 Apr 2012 04:22:46 +0000 (04:22 +0000)]
elementary/colorselector - send signal when mode is changed so as to set the padding properly
SVN revision: 69842
Daniel Juyung Seo [Mon, 2 Apr 2012 02:37:05 +0000 (02:37 +0000)]
elm genlist: Changed internal variables correctly. Patch by Hyoyoung
Chang <hyoyoung@gmail.com>
On Fri, Mar 30, 2012 at 5:17 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> I talked with seoz. and agreed with previous naming changing is
insufficient.
>
> so changed like this
> "mode_" -> "deco_it_"
> "edit_" -> "deco_all_"
>
> Thanks
>
> On Fri, Mar 30, 2012 at 3:33 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> After edit mode naming is changed, some legacy naming is remained.
>> I changed naming to follow API naming changes.
>>
>> "edit_" -> "deco_"
>> and also some explicit edc part names are changed.
>>
>> Some naming are remained as is, I'll fix at next patches.
>>
>> Thanks.
>
SVN revision: 69836
Daniel Juyung Seo [Mon, 2 Apr 2012 02:36:55 +0000 (02:36 +0000)]
elm genlist: Reverted Hyoyoung's first patch. He sent another patch
for this change.
Revert "After edit mode naming is changed, some legacy naming is remained."
This reverts commit
5e1aa3c8b0382a0ca471150f4c219cd32dbdbe22.
SVN revision: 69835
ChunEon Park [Mon, 2 Apr 2012 02:13:40 +0000 (02:13 +0000)]
elementary/colorselector - removed the unnecessaries
SVN revision: 69833
ChunEon Park [Mon, 2 Apr 2012 01:48:25 +0000 (01:48 +0000)]
elementary/colorselector - updated for elm_colorselector_mode_set test
SVN revision: 69832
ChunEon Park [Mon, 2 Apr 2012 00:55:04 +0000 (00:55 +0000)]
elementary/colorselector - more proper parents passing
SVN revision: 69831
ChunEon Park [Mon, 2 Apr 2012 00:50:57 +0000 (00:50 +0000)]
elementary/colorselector - removed unnecesary layout
SVN revision: 69830
WooHyun Jung [Mon, 2 Apr 2012 00:50:56 +0000 (00:50 +0000)]
elementary/elm_entry : Fixed a bug. While appending big sized string,
elm_entry_entry_get caused segfault because memcpy could be tried with
NULL pointer + "> 0" length.
SVN revision: 69829
Daniel Juyung Seo [Fri, 30 Mar 2012 12:31:11 +0000 (12:31 +0000)]
elm: Set timer/animator to NULL after they're deleted.
SVN revision: 69796
Daniel Juyung Seo [Fri, 30 Mar 2012 12:31:01 +0000 (12:31 +0000)]
elm gengrid: Changed internal function and variable names.
item_moving_effect_timer -> item_reorder_move_animator
_reorder_item_moving_effect_timer_cb -> _reorder_item_move_animator_cb
SVN revision: 69795
Carsten Haitzler [Fri, 30 Mar 2012 10:34:31 +0000 (10:34 +0000)]
After edit mode naming is changed, some legacy naming is remained.
I changed naming to follow API naming changes.
"edit_" -> "deco_" and also some explicit edc part names are changed.
Some naming are remained as is, I'll fix at next patches.
SVN revision: 69793
Carsten Haitzler [Fri, 30 Mar 2012 10:10:53 +0000 (10:10 +0000)]
protect ethumb with the ifdef as provided in example.
SVN revision: 69791
cnook [Fri, 30 Mar 2012 09:56:22 +0000 (09:56 +0000)]
From: cnook <kimcinoo@gmail.com>
Subject: [E-devel] [patch][elementary] elc_popup, restack issue
The elc_popup does not raise to the top of its layer even though
evas_object_raise() is called with the popup object.
Because the elm_widget_resize_object_set(); makes notify object which is
internally used in the popup have a smart parent.
Ultimately, the callback function for EVAS_CALLBACK_RESTACK of the
notify
is not called.
So I removed elm_widget_resize_object_set(); from the popup and added
some
implementations to show the popup properly.
Moreover, I have added test code also in the attached patch. Then,
please
review the patch and give any feedbacks. Thanks.
SVN revision: 69790
Daniel Juyung Seo [Fri, 30 Mar 2012 09:25:58 +0000 (09:25 +0000)]
elm genlist: Set long_timer to NULL after it's deleted.
SVN revision: 69789
WooHyun Jung [Fri, 30 Mar 2012 09:22:49 +0000 (09:22 +0000)]
elementary/genlist : set NULL for swipe_timer.
SVN revision: 69788
Daniel Juyung Seo [Fri, 30 Mar 2012 07:28:04 +0000 (07:28 +0000)]
elm genlist: Fixed genlist infinite loop bug.
SVN revision: 69785
Daniel Juyung Seo [Fri, 30 Mar 2012 06:34:07 +0000 (06:34 +0000)]
elm examples: Removed macro for data dir. Used elm_app_info_set and elm_app_data_dir_get instead.
SVN revision: 69783
Daniel Juyung Seo [Fri, 30 Mar 2012 06:34:04 +0000 (06:34 +0000)]
elm index_example_02.c: Fix index behavior properly.
SVN revision: 69782
Daniel Juyung Seo [Fri, 30 Mar 2012 06:33:57 +0000 (06:33 +0000)]
elm bg_example_03.c: Fixed window size to see the contents properly.
SVN revision: 69781
ChunEon Park [Fri, 30 Mar 2012 05:28:42 +0000 (05:28 +0000)]
elementary/naviframe - fixed to keep title_visiblility status after item_style_set
SVN revision: 69780
Mike Blumenkrantz [Fri, 30 Mar 2012 02:04:16 +0000 (02:04 +0000)]
clean up this logic a bit as well
SVN revision: 69779
Mike Blumenkrantz [Fri, 30 Mar 2012 01:50:37 +0000 (01:50 +0000)]
why use two loops when one is fine?
SVN revision: 69778
Mike Blumenkrantz [Fri, 30 Mar 2012 01:33:07 +0000 (01:33 +0000)]
this was redundant and confusing so I hit it with a hammer
SVN revision: 69777
Mike Blumenkrantz [Fri, 30 Mar 2012 01:17:04 +0000 (01:17 +0000)]
also rename widget data variable to be consistent with every other occurrence
SVN revision: 69776
Mike Blumenkrantz [Fri, 30 Mar 2012 01:15:26 +0000 (01:15 +0000)]
this is not actually unused...
SVN revision: 69775
Michael BOUCHAUD [Thu, 29 Mar 2012 23:05:54 +0000 (23:05 +0000)]
elementary: oops, mistake
SVN revision: 69773
Michael BOUCHAUD [Thu, 29 Mar 2012 22:59:11 +0000 (22:59 +0000)]
elementary: add an enum for the weekdays, with magic numbers fixes
SVN revision: 69772
Michael BOUCHAUD [Thu, 29 Mar 2012 22:14:30 +0000 (22:14 +0000)]
elementary: add 2 API, the first one is to set the first day of week in elm_calendar, and the second to get the info. I use a more trivial way to set headers ^^
SVN revision: 69771
Vincent Torri [Thu, 29 Mar 2012 21:24:00 +0000 (21:24 +0000)]
Elm: remove some warnings when no X
SVN revision: 69770
Jonas M. Gastal [Thu, 29 Mar 2012 20:55:55 +0000 (20:55 +0000)]
Remove warnings about unused parameters in examples.
SVN revision: 69769
Daniel Vieira Franzolin [Thu, 29 Mar 2012 20:44:42 +0000 (20:44 +0000)]
Fixes compilation instructions of examples to work on ubuntu.
Patch by: "Daniel Vieira Franzolin" <daniel@profusion.mobi>
SVN revision: 69766
Mike Blumenkrantz [Thu, 29 Mar 2012 20:31:35 +0000 (20:31 +0000)]
new test for naviframe, move naviframe tests to naviframe category so it can actually be found
SVN revision: 69765
Mike Blumenkrantz [Thu, 29 Mar 2012 19:27:13 +0000 (19:27 +0000)]
for the last time: CONFIG.H ALWAYS GETS INCLUDED FIRST. AAAAAAAALLLLLLLLLLLLLLLLLLLLLLLWAAAAAAAAAAAAAAAAAAAAAAAAAAAYYYYYYYYYYYYYYYYYYYYYSSSSSSSSSSSSSSSSSSS
SVN revision: 69764
Carsten Haitzler [Thu, 29 Mar 2012 12:00:14 +0000 (12:00 +0000)]
make elm robust and handle if u DONT set compile time dirs.. and work
anyway.
SVN revision: 69750
Daniel Juyung Seo [Thu, 29 Mar 2012 11:09:45 +0000 (11:09 +0000)]
elm: Fixed formatting. Added a space after 'if/while/for'
SVN revision: 69744
Daniel Juyung Seo [Thu, 29 Mar 2012 11:09:40 +0000 (11:09 +0000)]
elm elm_object: Fixed part content set hooks.
1. delete old content object
2. check whether new content object is same as old content object
3. added some doxygen description.
SVN revision: 69743
Daniel Juyung Seo [Thu, 29 Mar 2012 11:09:34 +0000 (11:09 +0000)]
elm genlist: Fixed _item_content_set_hook. Use _item_content_unset_hook internally.
SVN revision: 69742
Daniel Juyung Seo [Thu, 29 Mar 2012 10:08:37 +0000 (10:08 +0000)]
elm elm_object_item: Fixed item part content set hooks.
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738
Carsten Haitzler [Thu, 29 Mar 2012 09:54:21 +0000 (09:54 +0000)]
fix next calgrind bitch. yay!
SVN revision: 69737
Carsten Haitzler [Thu, 29 Mar 2012 09:40:23 +0000 (09:40 +0000)]
fix segv on elm_config exiting - entry bug! free(wd) AFTEr u have
finishing ACCESING IT!
SVN revision: 69736
Carsten Haitzler [Thu, 29 Mar 2012 09:39:54 +0000 (09:39 +0000)]
tone down smoothing even more.
SVN revision: 69735
Carsten Haitzler [Thu, 29 Mar 2012 09:28:13 +0000 (09:28 +0000)]
warn-- for non-x
SVN revision: 69734
Carsten Haitzler [Thu, 29 Mar 2012 09:21:32 +0000 (09:21 +0000)]
fix formatting! no if( ... space pls!
SVN revision: 69732
Carsten Haitzler [Thu, 29 Mar 2012 09:19:09 +0000 (09:19 +0000)]
adjust default configs for scroll smoothing to have a smaller window.
SVN revision: 69731
Daniel Juyung Seo [Thu, 29 Mar 2012 08:22:26 +0000 (08:22 +0000)]
elm genlist: Fixed flip bug. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>
On Thu, Mar 29, 2012 at 4:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> I made a patch about flip_realize.
> Currently flip feature uses content_objs, so it should keep its
content_objs.
> However it's lost at _item_flips_realize().
> So i fixed to initialize with its content_objs.
>
> Thanks
SVN revision: 69725
Carsten Haitzler [Thu, 29 Mar 2012 07:46:59 +0000 (07:46 +0000)]
use new ref_get func in object cleanup for windows.
SVN revision: 69723
Daniel Juyung Seo [Thu, 29 Mar 2012 07:19:23 +0000 (07:19 +0000)]
elm genlist: Remove tree_effect_animator on genlist _del_hook.
SVN revision: 69721
ChunEon Park [Thu, 29 Mar 2012 07:08:22 +0000 (07:08 +0000)]
elementary/panes - Patch to handle deletion of current contents while setting new ones
Attached to the mail is a patch for elm_panes.
I have a query that shall we hide the unset content in the widget itself or should application explicitly hide them after unsetting!
In case of edje_object_part_unswallow, application needs to do it explicitly and it is documented but in case of elm_object_part_content_unset, there is no documentation available.
Details of the patch:
Existing Issue before this change:
1. Panes deletes the older content while setting a new content even though both are same.
2. left and right content are being unswallowed in the content_left_set and _content_right_unset functions. So when the reparenting happens, say when the content is put inside a layout then only _sub_del gets called and
unswallowing does not happen as these functions do not get called.
e.g. @@ -253,8 +250,6 @@ _content_left_unset(Evas_Object *obj)
if (!wd->contents.left) return NULL;
Evas_Object *content = wd->contents.left;
elm_widget_sub_object_del(obj, content); //wd->contents.left already gets set to NULL in _sub_del
- edje_object_part_unswallow(wd->panes, content); // can be unswallowed in _sub_del as in case of reparenting like setting content in a layout, only _sub_del will get called, not this function
- wd->contents.left = NULL; //this instruction is redundent as it happens in _sub_del anyway
return content;
}
Change Description:
1. Unswallowing the contents now in _sub_del as this is a common function to be executed when subobject removal happens.
2. Comparing the current content with new before deleting.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
Thanks.
Regards,
Rajeev
SVN revision: 69720
WooHyun Jung [Thu, 29 Mar 2012 06:41:23 +0000 (06:41 +0000)]
elementary/toolbar : can_focus should be set as EINA_TRUE.
SVN revision: 69719
WooHyun Jung [Thu, 29 Mar 2012 06:38:34 +0000 (06:38 +0000)]
elementary/conform theme : Rearranging some parts in conform theme.
SVN revision: 69718
Daniel Juyung Seo [Thu, 29 Mar 2012 06:26:16 +0000 (06:26 +0000)]
elm conform: Revised code. More proper NULL check and aded spacing.
SVN revision: 69717
WooHyun Jung [Thu, 29 Mar 2012 06:00:06 +0000 (06:00 +0000)]
elementary/conform : wd->content is set as NULL in _sub_del function,
so can not be used anymore.
SVN revision: 69716
WooHyun Jung [Thu, 29 Mar 2012 05:21:07 +0000 (05:21 +0000)]
elementary/toolbar : toolbar should be focusable as default.
SVN revision: 69714
ChunEon Park [Wed, 28 Mar 2012 10:04:55 +0000 (10:04 +0000)]
elementary/naviframe - more clean tree
SVN revision: 69702
ChunEon Park [Wed, 28 Mar 2012 10:03:45 +0000 (10:03 +0000)]
elementary/widget - fixed to update the some status -color, clip, visibitliy- even if the memebers are added later.
SVN revision: 69701
Daniel Juyung Seo [Wed, 28 Mar 2012 09:02:22 +0000 (09:02 +0000)]
elm: Fixed formatting.
SVN revision: 69700
Daniel Juyung Seo [Wed, 28 Mar 2012 08:42:24 +0000 (08:42 +0000)]
elm examples: Adjust directory names.
SVN revision: 69699
Daniel Juyung Seo [Wed, 28 Mar 2012 08:42:20 +0000 (08:42 +0000)]
elm examples: I removed __UNUSED__ and config header inclusion. This code is an example for other developers so we don't need that extra macros. But how can I ignore this warning while building elementary?
SVN revision: 69698
Daniel Juyung Seo [Wed, 28 Mar 2012 08:42:13 +0000 (08:42 +0000)]
elm elc_player.c: Fixed slider usage.
SVN revision: 69697
Daniel Juyung Seo [Wed, 28 Mar 2012 07:17:46 +0000 (07:17 +0000)]
elm thumb_example_01.c: Revert wrong #if 0, #endif. Why this was added?
SVN revision: 69695
Daniel Juyung Seo [Wed, 28 Mar 2012 07:17:43 +0000 (07:17 +0000)]
elm slider_example.c: Use proper callback declarations according to elm API change.
SVN revision: 69694
Daniel Juyung Seo [Wed, 28 Mar 2012 07:04:14 +0000 (07:04 +0000)]
elm slider: Changed format function callback's const char * to char *.
The string will be freed in application's callback later. So 'const' is
not appropriate.
In elm_slider_indicator_format_function_set and
elm_slider_units_format_function_set.
SVN revision: 69692
Daniel Juyung Seo [Wed, 28 Mar 2012 06:23:18 +0000 (06:23 +0000)]
elm genlist: Fixed tree effect bug. Patch by Chanwook Jung
<jchanwook@gmail.com>
On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey
SVN revision: 69691
Daniel Juyung Seo [Wed, 28 Mar 2012 06:04:36 +0000 (06:04 +0000)]
elm examples: Use standard way of elementary applications. EAPI_MAIN, elm_shutdown, ELM_MAIN()
SVN revision: 69690