platform/upstream/dotnet/runtime.git
8 years agoMove dllexport to platformdefines.h.
Aditya Mandaleeka [Thu, 31 Mar 2016 00:04:53 +0000 (17:04 -0700)]
Move dllexport to platformdefines.h.

Commit migrated from https://github.com/dotnet/coreclr/commit/064744a23663cb0a34c6364618c3be308ee87933

8 years agoAdd test for exception handling on foreign threads.
Aditya Mandaleeka [Wed, 30 Mar 2016 03:11:55 +0000 (20:11 -0700)]
Add test for exception handling on foreign threads.

Commit migrated from https://github.com/dotnet/coreclr/commit/77f4b171604a66b14e85f25be2167aaa09e4d5ba

8 years agoMerge pull request dotnet/coreclr#3843 from AndyAyersMS/DataGathering
Andy Ayers [Tue, 22 Mar 2016 02:00:19 +0000 (19:00 -0700)]
Merge pull request dotnet/coreclr#3843 from AndyAyersMS/DataGathering

Inliner: initial data gathering for code size estimates

Commit migrated from https://github.com/dotnet/coreclr/commit/6cbd27ede090e1731b96d4d2b18813adb67e1487

8 years agoMerge pull request dotnet/coreclr#3854 from mikem8361/docs
Mike McLaughlin [Tue, 22 Mar 2016 01:35:07 +0000 (18:35 -0700)]
Merge pull request dotnet/coreclr#3854 from mikem8361/docs

Update SOS documentation

Commit migrated from https://github.com/dotnet/coreclr/commit/b9db17e8b509962e0c4fde2d964a100dabf37955

8 years agoMerge pull request dotnet/coreclr#3847 from dotnet-bot/from-tfs
Jan Kotas [Tue, 22 Mar 2016 00:20:43 +0000 (17:20 -0700)]
Merge pull request dotnet/coreclr#3847 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/fc2246d77a951ac2111f242f3bb408af39903270

8 years agoUpdate SOS documentation.
Mike McLaughlin [Mon, 21 Mar 2016 23:58:20 +0000 (16:58 -0700)]
Update SOS documentation.

Commit migrated from https://github.com/dotnet/coreclr/commit/d43ff1141a781066b7eda413dba38704483be609

8 years agoMerge pull request dotnet/coreclr#3815 from briansull/struct16-fp-args
Brian Sullivan [Mon, 21 Mar 2016 23:11:43 +0000 (16:11 -0700)]
Merge pull request dotnet/coreclr#3815 from briansull/struct16-fp-args

Fixes issue 3750 - passing fp arguments

Commit migrated from https://github.com/dotnet/coreclr/commit/f11845dae37f27023b23f0935129f5be6e76768e

8 years agoInliner: initial data gathering for code size estimates
Andy Ayers [Fri, 18 Mar 2016 00:23:19 +0000 (17:23 -0700)]
Inliner: initial data gathering for code size estimates

Some initial work to gather data to drive the modelling of inline
code size impact. See dotnet/coreclr#3775 for context.

Update the `DiscretionaryPolicy` to capture more observations.

Add a limit feature `JitInlineLimit` so the jit will stop inlining after
a given number of successful inlines.

Add a `DumpData` method to `InlinePolicy` which will display all the
observations that were made to evaluate an inline. Implement this for the
`DiscretionaryPolicy`. Add a matching `DumpSchema` that writes out
column headers for each of the observations.

Modify `InlineResult` to cache the last successful policy on the root
compiler instance. Use that along with the `JitInlineLimit` and
`DumpData` to display detailed information about the last sucessful
inline along with the code size for the method. All this is displayed
if `JitInlineDumpData ` is enabled.

This allows for isolating code size measurements as follows. Compile or
jit something with `JitInlineLimit = 0` and `JitInlineDumpData =1` (and
for now, `JitInlinePolicyDiscretionary = 1`, since other policies do not
implement any interesting data dumping).

Record the this root set of method sizes and IDs. Repeat with
`JitInlineLimit=1`. For each method where there was an inline, the size
impact of that inline can be computed by comparing this version versus
the version from the root set. Repeat with `JitInlineLimit=2`, comparing
versus the `=1` versions.

Currently the method token is used to identify the root method. This is
not sufficiently unique but unfortunately there currently aren't
substantially better alternatives. See dotnet/coreclr#1957 for some discussion.

Commit migrated from https://github.com/dotnet/coreclr/commit/5c7dd45d7c035445a33a321c595a03fba73da93f

8 years agoMerge pull request dotnet/coreclr#3840 from wtgodbe/HardwareEh
William Godbe [Mon, 21 Mar 2016 22:37:10 +0000 (15:37 -0700)]
Merge pull request dotnet/coreclr#3840 from wtgodbe/HardwareEh

Disable OutOfMemoryException test in HardwareEh test

Commit migrated from https://github.com/dotnet/coreclr/commit/0dbc5078010500386c1ddef0c0c452e9c94dc85a

8 years agoMerge pull request dotnet/coreclr#3841 from kyulee1/exclusion
Kyungwoo Lee [Mon, 21 Mar 2016 22:24:12 +0000 (15:24 -0700)]
Merge pull request dotnet/coreclr#3841 from kyulee1/exclusion

ARM64: Apply exclusion list to Tests.lst file

Commit migrated from https://github.com/dotnet/coreclr/commit/09b6bf06fdd69d6f5450685fadf479b1fbf9f3a9

8 years agoTrim Windows-specific System.Security.Principal types from CoreCLR mscorlib
Jan Kotas [Mon, 21 Mar 2016 21:02:42 +0000 (14:02 -0700)]
Trim Windows-specific System.Security.Principal types from CoreCLR mscorlib

[tfs-changeset: 1588225]

Commit migrated from https://github.com/dotnet/coreclr/commit/c39309e16b872a9a015500e5ddda37802f2da44b

8 years agoDisable OutOfMemoryException test in HardwareEh test
wtgodbe [Mon, 21 Mar 2016 17:10:16 +0000 (10:10 -0700)]
Disable OutOfMemoryException test in HardwareEh test

Commit migrated from https://github.com/dotnet/coreclr/commit/1493edbb852879b35509308284143f24cc8002c0

8 years agoTests and fixes for struct16 arguments and floating point arguments
Brian Sullivan [Fri, 18 Mar 2016 23:58:50 +0000 (16:58 -0700)]
Tests and fixes for struct16 arguments and floating point arguments

Updated Tests.lst with 50 new passing tests
Updated this fix to be under #ifdef ARM64 only

Commit migrated from https://github.com/dotnet/coreclr/commit/7f2ec614cf710155850ddb0d37058de6b5b546a9

8 years agoARM64: Apply exclusion list to Tests.lst file
Kyungwoo Lee [Mon, 21 Mar 2016 17:48:14 +0000 (10:48 -0700)]
ARM64: Apply exclusion list to Tests.lst file

Currently ARM64 tests run all tests even if those are excluded in
issues.targets, which is not only waste of resource but also confusing
ourselves to track such issues.
This adds a script to apply excluded tests specified in issues.targets to
Tests.lst file. Also new Tests.lst file is accordingly updated with 101
tests removed.

Commit migrated from https://github.com/dotnet/coreclr/commit/2756bcf7c0a23496b9235b7bac838e8e9848f0e0

8 years agoMerge pull request dotnet/coreclr#3833 from JohnChen0/master
John Chen [Mon, 21 Mar 2016 14:54:23 +0000 (07:54 -0700)]
Merge pull request dotnet/coreclr#3833 from JohnChen0/master

Add documentation for CrossGen

Commit migrated from https://github.com/dotnet/coreclr/commit/6120148c2f3df11ea902989675fb33dd0d71723c

8 years agoAdd documentation for CrossGen
John Chen [Fri, 18 Mar 2016 22:48:41 +0000 (15:48 -0700)]
Add documentation for CrossGen

Commit migrated from https://github.com/dotnet/coreclr/commit/30a327c1aae7bc7270b9ee57b8577fc5ffbd048d

8 years agoMerge pull request dotnet/coreclr#3563 from adityamandaleeka/threading_test_port_2
Sergiy Kuryata [Sun, 20 Mar 2016 23:39:36 +0000 (16:39 -0700)]
Merge pull request dotnet/coreclr#3563 from adityamandaleeka/threading_test_port_2

Open source even more threading tests

Commit migrated from https://github.com/dotnet/coreclr/commit/9378be6bf70d68552dd9ee62143680bb1827a0a8

8 years agoMove all new tests to Pri 1.
Aditya Mandaleeka [Sun, 20 Mar 2016 03:53:43 +0000 (20:53 -0700)]
Move all new tests to Pri 1.

Commit migrated from https://github.com/dotnet/coreclr/commit/7c0cefd4f100ab55454c7610674109383020316b

8 years agoAdd waitallex8 and waitallex8a to x86 legacy issues.
Aditya Mandaleeka [Sat, 19 Mar 2016 17:46:26 +0000 (10:46 -0700)]
Add waitallex8 and waitallex8a to x86 legacy issues.

Commit migrated from https://github.com/dotnet/coreclr/commit/aa3ab77037292a94b0465f1bdc5b293d99b912ff

8 years agoDelete tests that rely on Thread Abort functionality
Aditya Mandaleeka [Fri, 18 Mar 2016 18:16:45 +0000 (11:16 -0700)]
Delete tests that rely on Thread Abort functionality

Commit migrated from https://github.com/dotnet/coreclr/commit/01f3e98f6bf8e356ffb58e2a3ee8a5d6eed177b6

8 years agoUpdate project.json files.
Aditya Mandaleeka [Tue, 15 Mar 2016 23:03:33 +0000 (16:03 -0700)]
Update project.json files.

Commit migrated from https://github.com/dotnet/coreclr/commit/7d40932dd7b9141ee0312bc267fa2d50d2b134ac

8 years agoAdd some new threading tests to testsUnsupportedOutsideWindows
Aditya Mandaleeka [Mon, 7 Mar 2016 23:35:14 +0000 (15:35 -0800)]
Add some new threading tests to testsUnsupportedOutsideWindows

Commit migrated from https://github.com/dotnet/coreclr/commit/b530ba7e09a363867faa588e5b721391bfcd7a9b

8 years agoOpen source more threading tests.
Aditya Mandaleeka [Mon, 7 Mar 2016 23:16:27 +0000 (15:16 -0800)]
Open source more threading tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/51033e700c1fb5854962f1f31ebc4b144d5d49d7

8 years agoMerge pull request dotnet/coreclr#3831 from dotnet-bot/from-tfs
Sergiy Kuryata [Sat, 19 Mar 2016 23:37:29 +0000 (16:37 -0700)]
Merge pull request dotnet/coreclr#3831 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/18579f6ac83c7e8578fb694f5ebebae11f3f5e47

8 years agoFix a CrossGen CreatePDB issue that caused a Windows build break
John Chen [Sat, 19 Mar 2016 16:53:24 +0000 (09:53 -0700)]
Fix a CrossGen CreatePDB issue that caused a Windows build break

CrossGen /CreatePDB command gives preference to the TPA list while loading assemblies. So if the TPA contains the IL version of the input assembly but not the NI version, we would end up loading the IL instead of NI. This causes the CreatePDB command to fail, since it can't operate on IL images. This is fixed by putting the input file as the first entry in the TPA list.

Another issue is when the above error does occur, the error message is very unclear (it only shows "Unspecified error"). This is fixed with a better error message.

[tfs-changeset: 1587876]

Commit migrated from https://github.com/dotnet/coreclr/commit/ed0e57978f1f60b5de9d416fb5bb476a75b83212

8 years agoMerge pull request dotnet/coreclr#3810 from kyulee1/FixPath
Kyungwoo Lee [Sat, 19 Mar 2016 04:22:01 +0000 (21:22 -0700)]
Merge pull request dotnet/coreclr#3810 from kyulee1/FixPath

ARM64: Prepend toolset path

Commit migrated from https://github.com/dotnet/coreclr/commit/88c4927ff341439ec4fb4b0624689026746a2ba6

8 years agoMerge pull request dotnet/coreclr#3655 from sejongoh/fix_u64_to_f64_cast
Sejong Oh [Sat, 19 Mar 2016 02:23:15 +0000 (19:23 -0700)]
Merge pull request dotnet/coreclr#3655 from sejongoh/fix_u64_to_f64_cast

Fix inconsistent uint64-to-double cast

Commit migrated from https://github.com/dotnet/coreclr/commit/1cd5d1b112295f45cd283448ee922b774dd587be

8 years agoMerge pull request dotnet/coreclr#3813 from briansull/update-tests-lst
Brian Sullivan [Fri, 18 Mar 2016 23:35:31 +0000 (16:35 -0700)]
Merge pull request dotnet/coreclr#3813 from briansull/update-tests-lst

ARM64: Native test build -  Update Tests.lst with passing/failing Interop tests

Commit migrated from https://github.com/dotnet/coreclr/commit/62787214eea10c1916823f669d3af21a3f1bb56c

8 years agoFix inconsistent uint64-to-double cast
Sejong OH [Fri, 11 Mar 2016 07:30:23 +0000 (23:30 -0800)]
Fix inconsistent uint64-to-double cast

Commit migrated from https://github.com/dotnet/coreclr/commit/38d980d00d5cf5c59975dc3e803c373f8836bead

8 years agoMerge pull request dotnet/coreclr#3812 from janvorli/fix-stub
Jan Vorlicek [Fri, 18 Mar 2016 22:37:56 +0000 (23:37 +0100)]
Merge pull request dotnet/coreclr#3812 from janvorli/fix-stub

Fix instantiating stub for methods of value types

Commit migrated from https://github.com/dotnet/coreclr/commit/639f185ea0f6c3d6900b57a417a0aebaaf42d5c5

8 years agoRemoving Tests.sav
Brian Sullivan [Fri, 18 Mar 2016 22:23:10 +0000 (15:23 -0700)]
Removing Tests.sav

Commit migrated from https://github.com/dotnet/coreclr/commit/b31f7e156a980e9c51e69569f3e681639bd8456a

8 years agoUpdated one UNSTABLE test
Brian Sullivan [Fri, 18 Mar 2016 22:10:00 +0000 (15:10 -0700)]
Updated one UNSTABLE test

Commit migrated from https://github.com/dotnet/coreclr/commit/4453b156a719c794b6eb8021d0ef9d6d33b63807

8 years agoMerge branch 'master' into update-tests-lst
Brian Sullivan [Fri, 18 Mar 2016 22:09:17 +0000 (15:09 -0700)]
Merge branch 'master' into update-tests-lst

Commit migrated from https://github.com/dotnet/coreclr/commit/68c236a120cfcd66d751fb64a4ec7b4b0791206d

8 years agoMerge pull request dotnet/coreclr#3809 from wtgodbe/utf8
Jan Vorlicek [Fri, 18 Mar 2016 21:31:30 +0000 (22:31 +0100)]
Merge pull request dotnet/coreclr#3809 from wtgodbe/utf8

Ported managed Utf8/Unicode encoder/decoder to C++ for usage in PAL

Commit migrated from https://github.com/dotnet/coreclr/commit/6932907a2953436eadbb5f698f43efc9a523781c

8 years agoUpdate with passing Interop tests
Brian Sullivan [Fri, 18 Mar 2016 20:08:35 +0000 (13:08 -0700)]
Update with passing Interop tests

Commit migrated from https://github.com/dotnet/coreclr/commit/c88d9c1785b1a665b9a16c3a26f3b6585b8d8c55

8 years agoARM64: Prepend toolset path
Kyungwoo Lee [Fri, 18 Mar 2016 19:41:04 +0000 (12:41 -0700)]
ARM64: Prepend toolset path

Currently ARM64 build requires a plain CMD environment which often causes
a trouble when we use a different CMD or other native tools are in the path.
The fix is to simply prepend the tool path instead of appending it.

Commit migrated from https://github.com/dotnet/coreclr/commit/7b4e301fc106fa787ae133502a15a8d436c1ba03

8 years agoFix instantiating stub for methods of value types
Jan Vorlicek [Fri, 18 Mar 2016 14:46:20 +0000 (15:46 +0100)]
Fix instantiating stub for methods of value types

This change fixes a problem with instantiating stubs for methods of value types.
The problem was that the CreateInstantiatingILStub didn't take into account the
fact that methods of value types need to have "this" passed "byref".
The issue manifested itself as a rare corruption of references in array of structs
that were thin wrappers for string reference during GC stack scan. GC thought that
the reference to an array entry is an object reference that starts with method table.
GC marks method table pointers by setting their bit zero to 1. But in this case,
it has accidentally modified an object reference instead and a test was crashing
with wrong object address.

The root cause of the problem is that the instantiating stubs were placed on a global
singleton reference class no matter whether the target method was on a reference class
or a value type.

I have fixed it by putting the stubs on the instantiated target generic type instead.

Commit migrated from https://github.com/dotnet/coreclr/commit/fde6f26b140c5fcfa9a01267565686efcfff361f

8 years agoPorted managed Utf8/Unicode encoder/decoder to C++ for usage in PAL
William Godbe [Thu, 21 Jan 2016 23:14:48 +0000 (15:14 -0800)]
Ported managed Utf8/Unicode encoder/decoder to C++ for usage in PAL

Commit migrated from https://github.com/dotnet/coreclr/commit/eef4ca509b156597cea92d689672dacbac2cb7e1

8 years agoMerge pull request dotnet/coreclr#3808 from mmitche/arm64-cross-label
Matt Mitchell [Fri, 18 Mar 2016 17:32:26 +0000 (10:32 -0700)]
Merge pull request dotnet/coreclr#3808 from mmitche/arm64-cross-label

Update label for arm and arm64 cross builds on Ubuntu

Commit migrated from https://github.com/dotnet/coreclr/commit/1a9eb1c5f4d9f257f3f96ef5205a0eb1a23395c3

8 years agoUpdate label for arm and arm64 cross builds on Ubuntu
Matt Mitchell [Fri, 18 Mar 2016 17:23:13 +0000 (10:23 -0700)]
Update label for arm and arm64 cross builds on Ubuntu

Update the label to the newer image which contains the required rootfs.

Commit migrated from https://github.com/dotnet/coreclr/commit/c6332a950f02bf2625916f26c69d77e7dc5a4c7a

8 years agoMerge pull request dotnet/coreclr#3757 from leemgs/upstream-crossgen-skip-for-arm
Jan Kotas [Fri, 18 Mar 2016 16:22:23 +0000 (09:22 -0700)]
Merge pull request dotnet/coreclr#3757 from leemgs/upstream-crossgen-skip-for-arm

The architecture of host pc must be same architecture with target.

Commit migrated from https://github.com/dotnet/coreclr/commit/16f33e9ec9dedebd42d9f55c2530f8d64a1b2de0

8 years agoMerge pull request dotnet/coreclr#3799 from AndyAyersMS/AdjustInlineObservations
Andy Ayers [Fri, 18 Mar 2016 14:55:10 +0000 (07:55 -0700)]
Merge pull request dotnet/coreclr#3799 from AndyAyersMS/AdjustInlineObservations

Inliner: make more observations unconditional

Commit migrated from https://github.com/dotnet/coreclr/commit/e00fe575e9dee6aa64f4d9d471a08b5a26720159

8 years agoArchitecture of host must be compitable architecture with target.
Geunsik Lim [Wed, 16 Mar 2016 13:42:14 +0000 (22:42 +0900)]
Architecture of host must be compitable architecture with target.

Let's make exception handling for different architecture between
host pc and target board during build-time.

V3:
- Simplify the existing 'if' statement

V2:
- Added $HostArch variable to handle the required architectures.

V1:
- Handle "time ./build.sh arm debug clean verbose" command
in case that generate only mscorlib.dll for Linux/ARM as well as the
existing case of if [ $__CrossBuild != 1 ]

In this case, we need to add additional if statements because the
architecture of host pc must be same architecture with target.

Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/27a646569f549173c4a846a2283228d4f863b422

8 years agoMerge pull request dotnet/coreclr#3801 from dotnet-bot/from-tfs
Jan Kotas [Fri, 18 Mar 2016 12:44:46 +0000 (05:44 -0700)]
Merge pull request dotnet/coreclr#3801 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/a84aceff7dd8fda99b84a83779314c26fdbe47ad

8 years agoMerge pull request dotnet/coreclr#3796 from kyulee1/fixalignchk
Kyungwoo Lee [Fri, 18 Mar 2016 11:12:20 +0000 (04:12 -0700)]
Merge pull request dotnet/coreclr#3796 from kyulee1/fixalignchk

Fix Stack Alignment Check

Commit migrated from https://github.com/dotnet/coreclr/commit/8417eff38ad3514c726190bdf09f4d861848a499

8 years agoMerge pull request dotnet/coreclr#3783 from mikem8361/fixsosbp
Mike McLaughlin [Fri, 18 Mar 2016 04:37:09 +0000 (21:37 -0700)]
Merge pull request dotnet/coreclr#3783 from mikem8361/fixsosbp

Fixed problem with bpmd not working sometimes.

Commit migrated from https://github.com/dotnet/coreclr/commit/3bef2394b5dcd2e09bc61dae5e55d35ab43936e3

8 years agoMerge pull request dotnet/coreclr#3745 from manu-silicon/docs
Jan Kotas [Fri, 18 Mar 2016 03:24:10 +0000 (20:24 -0700)]
Merge pull request dotnet/coreclr#3745 from manu-silicon/docs

Ensure proper spelling of COMPlus_xxx environment variables

Commit migrated from https://github.com/dotnet/coreclr/commit/6aae434fbf79975d1e17d12c65f18a9208f36f7e

8 years agoMerge pull request dotnet/coreclr#3797 from svick/patch-2
Jan Kotas [Fri, 18 Mar 2016 03:17:27 +0000 (20:17 -0700)]
Merge pull request dotnet/coreclr#3797 from svick/patch-2

Update out of date comment in List<T>

Commit migrated from https://github.com/dotnet/coreclr/commit/34e834f86dde701462c8c5898eefe8a684ea7906

8 years agoAdd back some APIs needed by legacy test runner, for now
Jan Kotas [Fri, 18 Mar 2016 00:32:11 +0000 (17:32 -0700)]
Add back some APIs needed by legacy test runner, for now

[tfs-changeset: 1586974]

Commit migrated from https://github.com/dotnet/coreclr/commit/3f22776315a1c4a911a7ace5a8c68c180ee0dc83

8 years agoFix Stack Alignment Check
Kyungwoo Lee [Thu, 17 Mar 2016 14:33:10 +0000 (07:33 -0700)]
Fix Stack Alignment Check

This fixes https://github.com/dotnet/coreclr/issues/3747.
If JIT saves the first single store (not pair store) with stack adjustment
required (```spDelta != 0```), we expect the offset to be 8 to account for alignment.
This API ```genPrologSaveReg``` is invoked twice from INT and FP saving respectively
while JIT stores/allocates stacks once for these saving registers back to back.
So, the assertion is not quite right. For instance when we have 1 INT and
1 FP registers to be saved, JIT failed to assert the offset to be 8 in the
first invocation for INT. In fact, for this case, the offset should be 0
(no alignment is required) since we store 2 registers which are already
aligned on 16 byte.

We should consider whether or not the total number of saved registers is odd.
Not only that, even for the pair store, we should assert the offset either
0 or 8 depending on the total number of saved registers. For instance, 2
INT and 3 FP, we want the offset to be 8 when we store the first pair with
stack adjustment required (```spDelta != 0```).
I refactored the code to reflect this issue in ```genSaveCalleeSavedRegistersHelp``` while taking out the
existing assertion in ```genPrologSaveReg``` which is too local.
Similar change is made for the restore case.

Commit migrated from https://github.com/dotnet/coreclr/commit/4da11d5d54789a887b6eb238d5415514df64b66e

8 years agoMerge pull request dotnet/coreclr#3749 from briansull/update-tests-lst
Brian Sullivan [Thu, 17 Mar 2016 23:30:18 +0000 (16:30 -0700)]
Merge pull request dotnet/coreclr#3749 from briansull/update-tests-lst

Enable running of the full Pri0 and Pri1 set of tests

Commit migrated from https://github.com/dotnet/coreclr/commit/25b3709047fc54233889fdc29e1a9de0f7cb91f8

8 years agoEnable running of the full Pri0 and Pri1 set of tests
Brian Sullivan [Tue, 15 Mar 2016 01:23:05 +0000 (18:23 -0700)]
Enable running of the full Pri0 and Pri1 set of tests

Updated with EXPECTED_PASS and EXPECT_FAIL
Marked 50 test with NEW_PASS that will pass after the next test update
Fixed the location of 5 the threadstatic tests

Commit migrated from https://github.com/dotnet/coreclr/commit/6c5a283b5f14ae0f1bbf08066f8f44e104f67600

8 years agoInliner: make more observations unconditional
Andy Ayers [Thu, 17 Mar 2016 20:46:13 +0000 (13:46 -0700)]
Inliner: make more observations unconditional

There are still some observations within `fgFindJumpTargets` that are
only made when inlining. This change enables them to also be made for
the prejit root case. This partially addresses the inconsistencies
noted in dotnet/coreclr#3482.

Most notably, the simple stack model is now fully enabled for the
prejit root case, and the policy is able to more broadly observe
things like `CALLEE_LOOKS_LIKE_WRAPPER` and
`CALLEE_ARG_FEEDS_CONSTANT_TEST`.  As before, the `LegacyPolicy`
ignores these observations for the prejit root. Forthcoming policies
will likely behave differently.

Two observations that were fatal -- `CALLEE_UNSUPPORTED_OPCODE` and
`CALLEE_STORES_TO_ARGUMENT` -- are now conditionally fatal, since they
do not cause failure for the prejit root case (though arguably they
should).

The `CALLEE_IS_MOSTLY_LOAD_STORE` observation has been removed, and
the conditions under which it fired have been encapsulated within the
`LegacyPolicy`.

No change in behavior is expected. I verified crossgen of mscorlib
still makes all the same inline decisions for the same reasons.

Commit migrated from https://github.com/dotnet/coreclr/commit/08761ef79a68c86b551e987e5dc395a4d2647b30

8 years agoMerge pull request dotnet/coreclr#3781 from rahku/helixFix
Rahul Kumar [Thu, 17 Mar 2016 23:14:46 +0000 (16:14 -0700)]
Merge pull request dotnet/coreclr#3781 from rahku/helixFix

Update buildtools version. Shorten filename of tests

Commit migrated from https://github.com/dotnet/coreclr/commit/1ba7457077eb546baac4ce22bb3d0d2d9aa27d57

8 years agoMerge pull request dotnet/coreclr#3798 from dotnet-bot/from-tfs
Matt Ellis [Thu, 17 Mar 2016 22:46:15 +0000 (15:46 -0700)]
Merge pull request dotnet/coreclr#3798 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/68b47323ed8d523abf0a4977000a9137cef8ca6a

8 years agoMerge pull request dotnet/coreclr#3793 from jkotas/hostprotectionattribute
Jan Kotas [Thu, 17 Mar 2016 21:58:42 +0000 (14:58 -0700)]
Merge pull request dotnet/coreclr#3793 from jkotas/hostprotectionattribute

Add back HostProtectionAttribute to mscorlib

Commit migrated from https://github.com/dotnet/coreclr/commit/9b876720047b13164936c52eed34801208a4f297

8 years agoUpdate out of date comment in List<T>
Petr Onderka [Mon, 14 Mar 2016 15:53:42 +0000 (16:53 +0100)]
Update out of date comment in List<T>

Comment for parameterless constructor of List<T> claimed that
the default non-zero capacity was 16, even though _defaultCapacity
is actually 4.

Updated the comment to refer to _defaultCapacity,
to make sure it doesn't need to be updated again
if _defaultCapacity changes in the future.

Commit migrated from https://github.com/dotnet/coreclr/commit/33891a0d2f374037d70508946a1179922ef1ac18

8 years agoUse "debian.8" instead of "debian.8.2"
Matt Ellis [Thu, 17 Mar 2016 21:36:55 +0000 (14:36 -0700)]
Use "debian.8" instead of "debian.8.2"

CoreFX uses "debian.8" as the rid for debain packages, whereas CoreCLR
was still on "debian.8.2". Move to "debian.8" because it matches what's
in /etc/os-release and what the CLI will generate by default.

[tfs-changeset: 1586899]

Commit migrated from https://github.com/dotnet/coreclr/commit/706d59b1e8f21680955386f4b4eba4201f6c722a

8 years agoUpdate buildtools version. Shorten filename of tests
Rahul Kumar [Thu, 17 Mar 2016 01:25:02 +0000 (18:25 -0700)]
Update buildtools version. Shorten filename of tests

Commit migrated from https://github.com/dotnet/coreclr/commit/03d99d51d40f7db8b827d349fe5039aa5c34f217

8 years agoAdd back HostProtectionAttribute to mscorlib
Jan Kotas [Thu, 17 Mar 2016 18:21:55 +0000 (11:21 -0700)]
Add back HostProtectionAttribute to mscorlib

Commit migrated from https://github.com/dotnet/coreclr/commit/b4ee6bbdeaa1697e68d28605e10d9c7288cf0f10

8 years agoMerge pull request dotnet/coreclr#3780 from AndyAyersMS/DiscretionaryInliner
Andy Ayers [Thu, 17 Mar 2016 17:56:03 +0000 (10:56 -0700)]
Merge pull request dotnet/coreclr#3780 from AndyAyersMS/DiscretionaryInliner

Inliner: create DiscretionaryPolicy

Commit migrated from https://github.com/dotnet/coreclr/commit/d43310566af1303682cf85c5d40df24e721b7b30

8 years agoMerge pull request dotnet/coreclr#3790 from wtgodbe/timeout
William Godbe [Thu, 17 Mar 2016 17:31:51 +0000 (10:31 -0700)]
Merge pull request dotnet/coreclr#3790 from wtgodbe/timeout

Increase timeouts for R2R jobs to 4 hours. Also enable mistakenly disabled CentOS R2R jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/d3b6e6e0cc83fe3bc7dfb47d451828e9b1343a5d

8 years agoMerge pull request dotnet/coreclr#3770 from sejongoh/fix_setup_runtime_dep_cmd
Sejong Oh [Thu, 17 Mar 2016 17:29:10 +0000 (10:29 -0700)]
Merge pull request dotnet/coreclr#3770 from sejongoh/fix_setup_runtime_dep_cmd

Fix setup-runtime-dependencies.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/fe87c7a2ed7af702e27ed4f199dff192aac2e41a

8 years agoMerge pull request dotnet/coreclr#3782 from sergiy-k/runtestsfix2
Matt Mitchell [Thu, 17 Mar 2016 17:24:52 +0000 (10:24 -0700)]
Merge pull request dotnet/coreclr#3782 from sergiy-k/runtestsfix2

Patch runtest.sh to skip netstandard15aot assemblies

Commit migrated from https://github.com/dotnet/coreclr/commit/0232df486c1d246d49b9f6c4b7dbb92cc8090ff8

8 years agoIncrease timeouts for R2R jobs to 4 hours. Also enable mistakenly disabled CentOS...
wtgodbe [Thu, 17 Mar 2016 17:17:18 +0000 (10:17 -0700)]
Increase timeouts for R2R jobs to 4 hours. Also enable mistakenly disabled CentOS R2R jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/4b2ad95564507a3b03dd75bb373cc5d8334d69e1

8 years agoMerge pull request dotnet/coreclr#3786 from jashook/arm64_ci_timeouts
Jarret Shook [Thu, 17 Mar 2016 17:16:29 +0000 (10:16 -0700)]
Merge pull request dotnet/coreclr#3786 from jashook/arm64_ci_timeouts

Arm64 Windows timeout increase

Commit migrated from https://github.com/dotnet/coreclr/commit/35697832c73e9a5971c608bb40b761c6db952fb9

8 years agoMerge pull request dotnet/coreclr#3773 from wtgodbe/WindowsPri1
William Godbe [Thu, 17 Mar 2016 17:08:38 +0000 (10:08 -0700)]
Merge pull request dotnet/coreclr#3773 from wtgodbe/WindowsPri1

Switch default Windows x64 Release PR test to pri1 in CI

Commit migrated from https://github.com/dotnet/coreclr/commit/07428ec21467754cc72bc18f9381b054401132ad

8 years agoArm64 Windows timeout increase
jashook [Thu, 17 Mar 2016 14:57:30 +0000 (07:57 -0700)]
Arm64 Windows timeout increase

Currently the arm64 ci is timing out at 2 hours. When this happens the arm64 machines are left in a undefined state. Increasing the timeout to avoid this.

Commit migrated from https://github.com/dotnet/coreclr/commit/fefd91dd46a463d6e121432491404327ace7d5f1

8 years agoFixed problem with bpmd not working sometimes.
Mike McLaughlin [Wed, 16 Mar 2016 04:38:28 +0000 (21:38 -0700)]
Fixed problem with bpmd not working sometimes.

Fix some too earlier SOS initialization problem. Now returns an error.

The DAC interface (IXCLRDataProcess) was being created everytime an command was run and the JIT and GC notification tables where being reinitialized each time losing any JIT notifications needed to resolve a breakpoint. Only create the DAC interface instance once. It does need to be flushed each time sos is entered though.

Enable the module load and unload and exception callbacks when the DAC instance is created. This is what windbg does on Windows (along with flushing the DAC each time the target is restarted). It simplifies the breakpoint code; it no longer needs to enable/disable these notification flags.

Cleaned up places where the DAC instance (direct calls to LoadClrDebugDll) and not released properly.

Commit migrated from https://github.com/dotnet/coreclr/commit/36ac82a4c9a2137cc9b213adc340d3a4490d4811

8 years agoMerge pull request dotnet/coreclr#3771 from jashook/smarty_scripts
Jarret Shook [Thu, 17 Mar 2016 15:02:49 +0000 (08:02 -0700)]
Merge pull request dotnet/coreclr#3771 from jashook/smarty_scripts

Add lst_creator tool and smarty output parser

Commit migrated from https://github.com/dotnet/coreclr/commit/37fcb847444a1cec60d7910eb825b07032ccbbbb

8 years agoMerge pull request dotnet/coreclr#3777 from dotnet-bot/from-tfs
Jan Kotas [Thu, 17 Mar 2016 07:46:21 +0000 (00:46 -0700)]
Merge pull request dotnet/coreclr#3777 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/d7e926410537c2c6c7d7e9a9c4fa1c2398373a4e

8 years agoMerge pull request dotnet/coreclr#3774 from rahku/Helix
Rahul Kumar [Thu, 17 Mar 2016 06:25:11 +0000 (23:25 -0700)]
Merge pull request dotnet/coreclr#3774 from rahku/Helix

Add xunit console runner dependency

Commit migrated from https://github.com/dotnet/coreclr/commit/20fa72e6f36185bae5ddf2be9e3623de25fc2e39

8 years agoPatch runtest.sh to skip netstandard15aot assemblies.
Sergiy Kuryata [Thu, 17 Mar 2016 03:38:30 +0000 (20:38 -0700)]
Patch runtest.sh to skip netstandard15aot assemblies.

Commit migrated from https://github.com/dotnet/coreclr/commit/d0cd3ec4ead057e210f12bac84ecb9ec132d1294

8 years agoMerge pull request dotnet/coreclr#3740 from ramarag/createlayouts
Rama krishnan Raghupathy [Thu, 17 Mar 2016 02:02:33 +0000 (19:02 -0700)]
Merge pull request dotnet/coreclr#3740 from ramarag/createlayouts

Creates RunTime Dependency Layout as a seperate step

Commit migrated from https://github.com/dotnet/coreclr/commit/b49ce37d1191d8bd9234f9e7573fdc3b02396403

8 years agoMerge pull request dotnet/coreclr#3779 from briansull/issue-3778
Brian Sullivan [Thu, 17 Mar 2016 01:40:06 +0000 (18:40 -0700)]
Merge pull request dotnet/coreclr#3779 from briansull/issue-3778

Fix  for Issue 3778

Commit migrated from https://github.com/dotnet/coreclr/commit/5d1a15ef4aa44778b47142bd1bb0f8f944b52c09

8 years agoInliner: create DiscretionaryPolicy
Andy Ayers [Wed, 16 Mar 2016 23:02:54 +0000 (16:02 -0700)]
Inliner: create DiscretionaryPolicy

The `DiscretionaryPolicy` is similar to the `LegacyPolicy`, but does not
use size limits. So there is no "always" inline class and no "too big to
inline" class. Also, discretionary failures do not trigger noinline
stamping.

It is installed if `JitInlinePolicyDiscretionary` is set nonzero.

See dotnet/coreclr#3775 for some background on where this new policy will be used.
This is a first cut and further refinement is likely.

Also removed the unused `NoteDouble` methods since the double-valued
observations now are kept internally within `LegacyPolicy` and it's
not very likely we'll introduce new cases where doubles are needed.

Commit migrated from https://github.com/dotnet/coreclr/commit/548582b31d9e627dcb252bce2914002bdd5ebe6c

8 years agoAdd xunit console runner dependency
Rahul Kumar [Wed, 16 Mar 2016 22:51:49 +0000 (15:51 -0700)]
Add xunit console runner dependency

Commit migrated from https://github.com/dotnet/coreclr/commit/5f382176db5245b4485f066ccdeac74f7495fc4d

8 years agoUpdate version based on new content of clrconfigvalues.h
Manu [Thu, 17 Mar 2016 00:05:15 +0000 (09:05 +0900)]
Update version based on new content of clrconfigvalues.h

Commit migrated from https://github.com/dotnet/coreclr/commit/538c4c0e6e3715a091dd12cd6b91157b169c592e

8 years agoFix setup-runtime-dependencies.cmd
Sejong Oh [Tue, 15 Mar 2016 20:56:41 +0000 (13:56 -0700)]
Fix setup-runtime-dependencies.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/62e0f5c054524a14ab35f93d78e6ee820c4e03aa

8 years agoMerge branch 'master' into issue-3778
Brian Sullivan [Wed, 16 Mar 2016 23:47:42 +0000 (16:47 -0700)]
Merge branch 'master' into issue-3778

Commit migrated from https://github.com/dotnet/coreclr/commit/400ff7761887079d70e368ae08663fb15646fd46

8 years agoFix issue 3778
Brian Sullivan [Wed, 16 Mar 2016 23:45:28 +0000 (16:45 -0700)]
Fix issue 3778

Move the initialization of compGenTreeID to earlier in Compiler::compCompileHelper

Commit migrated from https://github.com/dotnet/coreclr/commit/a79b94e0c1dd8e7e7dbaa4afbdfc38d5f6a59718

8 years agoRemove unused files from CoreCLR
Jan Kotas [Wed, 16 Mar 2016 23:04:10 +0000 (16:04 -0700)]
Remove unused files from CoreCLR

[tfs-changeset: 1586532]

Commit migrated from https://github.com/dotnet/coreclr/commit/ba19076843e369ac6be89e634bcaf5947b6a94c7

8 years agoMerge pull request dotnet/coreclr#3762 from AndyAyersMS/FixInconsistentPolicy
Andy Ayers [Wed, 16 Mar 2016 22:59:39 +0000 (15:59 -0700)]
Merge pull request dotnet/coreclr#3762 from AndyAyersMS/FixInconsistentPolicy

Use root compiler instance for inline result and policy

Commit migrated from https://github.com/dotnet/coreclr/commit/8258a31961abbf37a157c6374f4e0ebd59f0c686

8 years agoSwitch default Windows x64 Release PR test to pri1 in CI
wtgodbe [Wed, 16 Mar 2016 22:24:50 +0000 (15:24 -0700)]
Switch default Windows x64 Release PR test to pri1 in CI

Commit migrated from https://github.com/dotnet/coreclr/commit/376d2e8469f2806c5a3080ed37838d577e60ae26

8 years agoAdd lst_creator tool and smarty output parser
jashook [Wed, 16 Mar 2016 02:23:20 +0000 (19:23 -0700)]
Add lst_creator tool and smarty output parser

Commit migrated from https://github.com/dotnet/coreclr/commit/3a06bb29d0254b191bebd96e45fbd494507d82b6

8 years agoMerge pull request dotnet/coreclr#3751 from jashook/arm64_enable_dbg_chk
Jarret Shook [Wed, 16 Mar 2016 21:33:12 +0000 (14:33 -0700)]
Merge pull request dotnet/coreclr#3751 from jashook/arm64_enable_dbg_chk

Remove release only check.

Commit migrated from https://github.com/dotnet/coreclr/commit/414126e0c0e9d1681b2fe3f71789ef1bbc743a76

8 years agoMerge pull request dotnet/coreclr#3752 from dotnet-bot/from-tfs
Jan Kotas [Wed, 16 Mar 2016 20:52:22 +0000 (13:52 -0700)]
Merge pull request dotnet/coreclr#3752 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/a5ca4dce8701f409c135504bc328f5f8ff4ee7c1

8 years agoUse root compiler instance for inline result and policy
Andy Ayers [Wed, 16 Mar 2016 17:50:51 +0000 (10:50 -0700)]
Use root compiler instance for inline result and policy

When constructing an InlineResult (and subsequent InlinePolicy)
always use the root compiler instance, so that all policy evaluations
done in a method are consistent.

Add an assert that the initial fact replay during `fgFindJumpTargets`
(force inline state and code size) doesn't change the candidacy when
inlining -- it should just be re-establishing what we knew in the
initial candidate scan.

Closes dotnet/coreclr#3760.

Commit migrated from https://github.com/dotnet/coreclr/commit/77c5f3e8b3aa61fd4e64b42862b572960cf1863e

8 years agoMerge pull request dotnet/coreclr#3761 from kyulee1/fixstack
Kyungwoo Lee [Wed, 16 Mar 2016 20:13:33 +0000 (13:13 -0700)]
Merge pull request dotnet/coreclr#3761 from kyulee1/fixstack

ARM64: Fix Large Stack Allocation

Commit migrated from https://github.com/dotnet/coreclr/commit/00f25cfbe4127cb6524ab43e91d5e98f44fade28

8 years agoARM64: Fix Large Stack Allocation
Kyungwoo Lee [Wed, 16 Mar 2016 16:39:47 +0000 (09:39 -0700)]
ARM64: Fix Large Stack Allocation

This fixes https://github.com/dotnet/coreclr/issues/3666.
When frame size is greater than 512 (frametype=3), JIT saves
callee-save registers followed by var arg registers, and then handles the
remaining frames. When the first callee-save register is saved, the stack
size is expected to be grown including delta amount which is for var arg registers.
For this failing case, actually we don't have any callee-save registers to be
saved while we still need to home var arg registers.
This fix is to handle such case in
```genSaveCalleeSavedRegistersHelp/genRestoreCalleeSavedRegistersHelp``` to
ensure allocating/deallocating delta stack size.

Commit migrated from https://github.com/dotnet/coreclr/commit/81d2210fdfc1274ed14153081a9f39ecc3cb34d9

8 years agoMerge pull request dotnet/coreclr#3758 from gkhanna79/TestGCStress
Gaurav Khanna [Wed, 16 Mar 2016 19:02:09 +0000 (12:02 -0700)]
Merge pull request dotnet/coreclr#3758 from gkhanna79/TestGCStress

Enable tests to run under a specified GCStress mode

Commit migrated from https://github.com/dotnet/coreclr/commit/cad8467e1da9dd13c6293cece45318f13fd6af37

8 years agoMerge pull request dotnet/coreclr#3755 from jkotas/failing-tests
Jan Kotas [Wed, 16 Mar 2016 18:58:14 +0000 (11:58 -0700)]
Merge pull request dotnet/coreclr#3755 from jkotas/failing-tests

Disable tests that are failing in CI on Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/ad7b11b818f3628448f5ec0998471b4cf06c846c

8 years agoDisable tests that are failing in CI on Unix
Jan Kotas [Wed, 16 Mar 2016 11:24:16 +0000 (04:24 -0700)]
Disable tests that are failing in CI on Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/5195d0d0f3c73f559239c7c49b7b5e6b33d182f8

8 years agoMerge pull request dotnet/coreclr#3697 from AndyAyersMS/RandomInliner
Andy Ayers [Wed, 16 Mar 2016 16:29:29 +0000 (09:29 -0700)]
Merge pull request dotnet/coreclr#3697 from AndyAyersMS/RandomInliner

Random inliner

Commit migrated from https://github.com/dotnet/coreclr/commit/c37aae496c6d83ddd49c96e0eeb9cc1bce2bff76

8 years agoMerge pull request dotnet/coreclr#3743 from dagood/remove-nugetbuild-source
Davis Goodin [Wed, 16 Mar 2016 16:04:41 +0000 (11:04 -0500)]
Merge pull request dotnet/coreclr#3743 from dagood/remove-nugetbuild-source

Remove nugetbuild myget feed

Commit migrated from https://github.com/dotnet/coreclr/commit/4879588fb8973c0979a3253bda44d990be8aa9b3

8 years agoEnable tests to run under a specified GCStress mode
Gaurav Khanna [Wed, 16 Mar 2016 09:58:22 +0000 (02:58 -0700)]
Enable tests to run under a specified GCStress mode

Commit migrated from https://github.com/dotnet/coreclr/commit/f9d0c3248f1c8168a67eb836cf758783adfca026

8 years agoMerge pull request dotnet/coreclr#3742 from kyulee1/fixgchole2
Kyungwoo Lee [Wed, 16 Mar 2016 14:30:38 +0000 (07:30 -0700)]
Merge pull request dotnet/coreclr#3742 from kyulee1/fixgchole2

ARM64: Revisit for Fix GC hole in indirect call site

Commit migrated from https://github.com/dotnet/coreclr/commit/97fe1583dd8a9af76f7313568557b5e2da390a9b

8 years agoMerge pull request dotnet/coreclr#3656 from leemgs/upstream-calling-convention-cdecl
Jan Kotas [Wed, 16 Mar 2016 11:15:44 +0000 (04:15 -0700)]
Merge pull request dotnet/coreclr#3656 from leemgs/upstream-calling-convention-cdecl

Remove __cdecl__ calling convention for [-Werror,-Wignored-attributes]

Commit migrated from https://github.com/dotnet/coreclr/commit/4d060bd77a034249459224487ebdb6a8ff1e6fd9

8 years agoMerge pull request dotnet/coreclr#3725 from leemgs/upstream-doc-cross-arm
Jan Kotas [Wed, 16 Mar 2016 11:14:25 +0000 (04:14 -0700)]
Merge pull request dotnet/coreclr#3725 from leemgs/upstream-doc-cross-arm

Documentation: Compiling mscorlib for ARM Linux

Commit migrated from https://github.com/dotnet/coreclr/commit/94a7c57a38ad3c345748d057921d22f0ada2eb9f

8 years agoRemove __cdecl__ calling convention for [-Werror,-Wignored-attributes]
Geunsik Lim [Wed, 16 Mar 2016 07:33:25 +0000 (16:33 +0900)]
Remove __cdecl__ calling convention for [-Werror,-Wignored-attributes]

The cross build for Linux/ARM is broken while doing the compilation
by the [-Werror,-Wignored-attributes] policy of the cross compiler.
Let's remove __cdecl__ calling convention from ./test/src/Interop folder
by handling __cdecl macro handling in xplatform.h for Linux/ARM.

Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/97a516ac008ed1dea5d50e22bf91cd226b4885f7