platform/upstream/freerdp.git
4 years agoFixed OOB Read in license_read_new_or_upgrade_license_packet
akallabeth [Mon, 25 May 2020 07:37:48 +0000 (09:37 +0200)]
Fixed OOB Read in license_read_new_or_upgrade_license_packet

CVE-2020-11099 thanks to @antonio-morales for finding this.

(cherry picked from commit 6ade7b4cbfd71c54b3d724e8f2d6ac76a58e879a)

4 years agoRespect SECBUFFER_READONLY flag in NTLM EncryptMessage
Armin Novak [Wed, 17 Jun 2020 10:18:42 +0000 (12:18 +0200)]
Respect SECBUFFER_READONLY flag in NTLM EncryptMessage

(cherry picked from commit 8e45a2dd50d5db6ac6125e0f60e833b6c6c6ea1b)

4 years agoAdded missing SECBUFFER_READONLY flag in rpc_client_write_call
Armin Novak [Wed, 17 Jun 2020 10:10:33 +0000 (12:10 +0200)]
Added missing SECBUFFER_READONLY flag in rpc_client_write_call

(cherry picked from commit 0d80353bf30de860dcf86285c4e5e2770bc036f7)

4 years agoTSG improvements
Armin Novak [Wed, 17 Jun 2020 06:41:21 +0000 (08:41 +0200)]
TSG improvements

* Respect connection timeout during connect
* Better debug output
* Cleaned up data types,

(cherry picked from commit ff79636d3311269ec35fc1d6cc4246eef500ad5e)

4 years agoFixed missing lock during buffer submit.
akallabeth [Thu, 18 Jun 2020 06:42:24 +0000 (08:42 +0200)]
Fixed missing lock during buffer submit.

(cherry picked from commit c902f583d0911c1e8938c5f14f3f257eb9737745)

4 years agoRevert "winpr/library: Use RTLD_GLOBAL for dlopen"
Bernhard Miklautz [Tue, 16 Jun 2020 14:39:36 +0000 (16:39 +0200)]
Revert "winpr/library: Use RTLD_GLOBAL for dlopen"

Using RTLD_GLOBAL in LoadLibraryA introduces a different behavior than
expected.

This reverts commit d566e00258daffcb4c703afc3685e9a42ad01453.

(cherry picked from commit 529e30c273ba67e3924b9fe4419410888314d31f)

4 years agofix [client channels]: move exported API calls to client/common
Bernhard Miklautz [Tue, 16 Jun 2020 14:35:36 +0000 (16:35 +0200)]
fix [client channels]: move exported API calls to client/common

The functions mappedGeometryRef and mappedGeometryUnref are API
functions ([1]) but were implemented in the geometry channel.
In case FreeRDP was built with BUILTIN_CHANNELS=OFF those functions
weren't available globally but used by the video channel.

Now the functions are fixed part of the freerdp-client library and
therefore available for all channels.

[1] exported in freerdp/client/geometry.h

Fixes #6236

(cherry picked from commit 1628939227fa82fa492f068f178f0cc0a42c518b)

4 years agoFixed double free for uwac buffers
akallabeth [Tue, 16 Jun 2020 11:54:12 +0000 (13:54 +0200)]
Fixed double free for uwac buffers

(cherry picked from commit 1bc48b058f013a8c88db2a1d7da2ad25dcd3bc4c)

4 years agoLock wayland buffer updates
akallabeth [Mon, 15 Jun 2020 13:49:21 +0000 (15:49 +0200)]
Lock wayland buffer updates

(cherry picked from commit 7361f75d11b77f998cf7dee08c8aa619df98754a)

4 years agoserver: proxy: cap plugin: fix var and func declaration
Kubistika [Wed, 3 Jun 2020 10:56:52 +0000 (13:56 +0300)]
server: proxy: cap plugin: fix var and func declaration

(cherry picked from commit 0cf764f170384b1f65aa4950f54c668f8212ac11)

4 years agoserver: proxy: implement session capture plugin
Kobi Mizrachi [Mon, 1 Jun 2020 06:37:53 +0000 (09:37 +0300)]
server: proxy: implement session capture plugin

(cherry picked from commit 19809bf338e5503a33664440d0de9313dca038a3)

4 years agowinpr: image: add API to construct bmp header
Kobi Mizrachi [Mon, 1 Jun 2020 06:33:12 +0000 (09:33 +0300)]
winpr: image: add API to construct bmp header

(cherry picked from commit 920acd4c0ee7f9112d77756b0c41474212446609)

4 years agoFixed compilation issue with shadow pam code
akallabeth [Tue, 16 Jun 2020 12:02:49 +0000 (14:02 +0200)]
Fixed compilation issue with shadow pam code

(cherry picked from commit e1e0f965e8636c587aea7762a94d611e193e07f3)

4 years agoFixed surface locking for shadow server.
akallabeth [Wed, 27 May 2020 08:01:04 +0000 (10:01 +0200)]
Fixed surface locking for shadow server.

(cherry picked from commit a38d6c53a62cdea302fbeb4e466bce22c006d20c)

4 years agoDo not remove transfer data on usb cancel transfer
Armin Novak [Wed, 3 Jun 2020 06:24:17 +0000 (08:24 +0200)]
Do not remove transfer data on usb cancel transfer

(cherry picked from commit a5e2d62e48619d5502f5334d431ee7d66ae9e4aa)

4 years agoFixed double free in urb_isoch_transfer_cb
Armin Novak [Wed, 3 Jun 2020 06:37:45 +0000 (08:37 +0200)]
Fixed double free in urb_isoch_transfer_cb

(cherry picked from commit ef4de12887486857f7eec37ef93df692b2ecedf0)

4 years agoFixed sign compare warnings with constants.
Armin Novak [Wed, 3 Jun 2020 07:53:18 +0000 (09:53 +0200)]
Fixed sign compare warnings with constants.

(cherry picked from commit 5ec66cc6c79dadf4c3426060d5bb30ddb360f292)

4 years agofix +unmap-buttons option having the opposite effect
makki_d [Thu, 4 Jun 2020 09:22:55 +0000 (18:22 +0900)]
fix +unmap-buttons option having the opposite effect

(cherry picked from commit 4607a2766afd2875696b7b7febd9dc63f778b8d7)

4 years agoImprove X11 shadow authentication reason failure log
akallabeth [Wed, 27 May 2020 09:53:28 +0000 (11:53 +0200)]
Improve X11 shadow authentication reason failure log

(cherry picked from commit e66ee477c00b91cddc228adaf1577be602e4f725)

4 years agoFix usage of DsMakeSpn with IP address hostnames
Martin Fleisz [Mon, 15 Jun 2020 13:06:02 +0000 (15:06 +0200)]
Fix usage of DsMakeSpn with IP address hostnames

(cherry picked from commit 4e7b60b0028f5d33139065fb965c5cd9d2f6ec1d)

4 years agoMessageQueue write time to current message not the next
Patrick Chin [Mon, 8 Jun 2020 18:17:35 +0000 (19:17 +0100)]
MessageQueue write time to current message not the next

(cherry picked from commit ea4df3f91a63c17f6a9bbf8d1b54f462004a992c)

4 years agoFixed #6267: adjust write_pixel_16 endian handling
akallabeth [Mon, 8 Jun 2020 05:09:07 +0000 (07:09 +0200)]
Fixed #6267: adjust write_pixel_16 endian handling

(cherry picked from commit 51d3e07c8a4bca32bf82538075e4518b63e8ed4d)

4 years agouwac: don't try to use O_TMPFILE on FreeBSD
Kyle Evans [Mon, 8 Jun 2020 04:13:58 +0000 (23:13 -0500)]
uwac: don't try to use O_TMPFILE on FreeBSD

Currently, this sets an invalid open flag and attempts to open(), which
will fail.  Instead of doing that, don't try to define O_TMPFILE where
such a definition can't exist and force the fallback rather than making
an always-fail open() call.

(cherry picked from commit 082ddb3d2bd068536c17a4dbddcafd465ffcba3a)

4 years agodrdynvc: client: fix #6252 use-after-free
Kubistika [Wed, 3 Jun 2020 16:45:18 +0000 (19:45 +0300)]
drdynvc: client: fix #6252 use-after-free

(cherry picked from commit 6ed765c96052c65f16fb1964705bd5c894b51b78)

4 years agoFixed formatting.
akallabeth [Thu, 4 Jun 2020 05:44:08 +0000 (07:44 +0200)]
Fixed formatting.

(cherry picked from commit d1b310d970592226b2f0a70710ad3ae3da61c4bc)

4 years agosmartcard: Teoretical fix of uninitialized values
Ondrej Holy [Wed, 3 Jun 2020 11:03:11 +0000 (13:03 +0200)]
smartcard: Teoretical fix of uninitialized values

This tries to fixes the following defects reported by covscan tool:
 - channels/smartcard/client/smartcard_operations.c:958: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".
 - channels/smartcard/client/smartcard_operations.c:932: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".

But I am not sure about it...

(cherry picked from commit 53459883529bf659488c4da81c30707ff3662820)

4 years agosmartcard: Fix usage of uninitialized values
Ondrej Holy [Wed, 3 Jun 2020 10:28:32 +0000 (12:28 +0200)]
smartcard: Fix usage of uninitialized values

This fixes the following defect reported by covscan tool:
 - channels/smartcard/client/smartcard_pack.c:942: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:894: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:475: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".

(cherry picked from commit e70e25715f89aac823281d7c0674d2387f70f8a6)

4 years agowlfreerdp: Fix array overrun
Ondrej Holy [Wed, 3 Jun 2020 10:03:44 +0000 (12:03 +0200)]
wlfreerdp: Fix array overrun

This fixes the following defects reported by covscan tool:
 - client/Wayland/wlf_input.c:251: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:308: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:360: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:251: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:308: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:360: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "y" when calling "wlf_scale_coordinates".
 - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "x" when calling "wlf_scale_coordinates".

The maximal number of touches can be higher then 10, see:
https://wayland.freedesktop.org/libinput/doc/latest/touchpads.html

Let's increse the MAX_CONTACTS count and add checks to prevent usage of
uninitialized values.

(cherry picked from commit 6ab79961ef09bc0340633319c388b6b7517b1f3d)

4 years agogdi: Fix missing unlock
Ondrej Holy [Thu, 28 May 2020 06:32:17 +0000 (08:32 +0200)]
gdi: Fix missing unlock

This fixes the following defect reported by covscan tool:
libfreerdp/gdi/gfx.c:144: missing_unlock: Returning without unlocking "update->mux".

(cherry picked from commit 914808f62cd2ac4a6984ee638112e8dc3aad9e52)

4 years ago[generate_argument_docbook] Fix typo in XML entity.
Simon Tatham [Sat, 30 May 2020 09:57:10 +0000 (10:57 +0100)]
[generate_argument_docbook] Fix typo in XML entity.

The character '>' was being rendered as < instead of >.

(cherry picked from commit 98930bf2759905f2290e5d777f57a79e7589f220)

4 years agoFix memory leaks in client/encomsp_main.c and client/remdesk_main.c
Patrick Chin [Fri, 29 May 2020 22:29:58 +0000 (23:29 +0100)]
Fix memory leaks in client/encomsp_main.c and client/remdesk_main.c

(cherry picked from commit 28e29f8ad568b195a9d6a1d785eaa81da13f93ff)

4 years agoFixed #6245: Added additional tests to assistance parser
Armin Novak [Fri, 29 May 2020 15:24:15 +0000 (17:24 +0200)]
Fixed #6245: Added additional tests to assistance parser

(cherry picked from commit 69141aa830b6e73e859f907b9bd2a4cac2777d8f)

4 years agoreport only actual bytes received, not allocated buffer size (interrupt produces...
Florian Staudacher [Fri, 29 May 2020 00:20:15 +0000 (02:20 +0200)]
report only actual bytes received, not allocated buffer size (interrupt produces data, timeout doesn't)

(cherry picked from commit 2e4f27ac9f7bcecb3c3f453341818e538386207f)

4 years agoLock remaining occurances of security_encrypt/security_decrypt variables
akallabeth [Fri, 29 May 2020 07:30:25 +0000 (09:30 +0200)]
Lock remaining occurances of security_encrypt/security_decrypt variables

(cherry picked from commit f01ae7d2573b677eba6c8a50fe12246a23b15f2e)

4 years agoLock security_decrypt to avoid simultaneous counter manipulation
akallabeth [Fri, 29 May 2020 07:20:05 +0000 (09:20 +0200)]
Lock security_decrypt to avoid simultaneous counter manipulation

(cherry picked from commit 164c00f68b64781d8c624a8c71fab6691519d294)

4 years agoonly call 'libusb_set_interface_alt_setting' when value is changed
Florian Staudacher [Thu, 28 May 2020 15:16:15 +0000 (17:16 +0200)]
only call 'libusb_set_interface_alt_setting' when value is changed

(cherry picked from commit ea8c922355c48b6a18900aa543e716b6ae1cd08e)

4 years agowinpr/library: Use RTLD_GLOBAL for dlopen
Ondrej Holy [Wed, 27 May 2020 06:43:00 +0000 (08:43 +0200)]
winpr/library: Use RTLD_GLOBAL for dlopen

LoadLibraryA implementation uses the RTLD_LOCAL flag for dlopen currently.
This flag doesn't allow the symbols to be used by the subsequently loaded
libraries. This is a problem for the video channel when -DBUILTIN_CHANNELS=OFF
is used as it uses functions from the geometry channel. Let's use RTLD_GLOBAL
instead to prevent "undefined symbol" errors in such cases.

Fixes: https://github.com/FreeRDP/FreeRDP/issues/6236
(cherry picked from commit d8cd671cc68d503757e32eb80f7a4dee44e47754)

4 years agoAdded scancodes for launch keys
akallabeth [Tue, 26 May 2020 10:15:27 +0000 (12:15 +0200)]
Added scancodes for launch keys

(cherry picked from commit c97c1ca359db825ee6d172b5860b793dcf3a1e83)

4 years agoAdded release zip creation to script.
Armin Novak [Mon, 25 May 2020 17:30:11 +0000 (19:30 +0200)]
Added release zip creation to script.

(cherry picked from commit 25f62eedddc8fb249e0936f86f9984ee9724c6a1)

4 years agoFixed #6221: Update floatbar position with multitouch input
Armin Novak [Fri, 22 May 2020 09:24:25 +0000 (11:24 +0200)]
Fixed #6221: Update floatbar position with multitouch input

(cherry picked from commit 004910ce5d76e114f4f8cfec6429004b26bc4443)

4 years agoFixed memory leak in rdpei
Armin Novak [Fri, 22 May 2020 08:59:06 +0000 (10:59 +0200)]
Fixed memory leak in rdpei

(cherry picked from commit 8c2c19bbc81eaf69169bd581dbac8c9a906fb5ee)

4 years agonew: add release script
Bernhard Miklautz [Thu, 21 May 2020 09:08:26 +0000 (11:08 +0200)]
new: add release script

Add a updated version of script for creating the release tarball.
If TAG is set the TAG is used otherwise it is tried to detect the last
TAG using git describe.

(cherry picked from commit 93d6de297800568b571e373d6989c54345f1e1da)

4 years agoRead newline from stdio on certificate accept
akallabeth [Wed, 20 May 2020 09:57:01 +0000 (11:57 +0200)]
Read newline from stdio on certificate accept

(cherry picked from commit 5b842bc7a78621218b1179923c002d32c41f15fe)

4 years agoMerge pull request #6212 from akallabeth/stable_backport_cve 2.1.1
Martin Fleisz [Wed, 20 May 2020 14:45:43 +0000 (16:45 +0200)]
Merge pull request #6212 from akallabeth/stable_backport_cve

Stable backport cve

4 years agoPrepared version for 2.1.1
akallabeth [Mon, 18 May 2020 15:10:18 +0000 (17:10 +0200)]
Prepared version for 2.1.1

4 years agoUpdated changelog for 2.1.1
akallabeth [Mon, 18 May 2020 15:10:08 +0000 (17:10 +0200)]
Updated changelog for 2.1.1

4 years agoClear dynamic channel lists on disconnect.
akallabeth [Tue, 19 May 2020 11:11:32 +0000 (13:11 +0200)]
Clear dynamic channel lists on disconnect.

(cherry picked from commit a1eb3e66b31579d3d878dee67913962140f75255)

4 years agocodec: fix typo in progressive codec log
Kobi Mizrachi [Tue, 19 May 2020 12:06:22 +0000 (15:06 +0300)]
codec: fix typo in progressive codec log

(cherry picked from commit 8d72051ab157d89af3f919a441170ca57bf67e84)

4 years agoFixed some more resource cleanup leaks in nla
akallabeth [Tue, 19 May 2020 12:07:15 +0000 (14:07 +0200)]
Fixed some more resource cleanup leaks in nla

(cherry picked from commit 354bb7d6ae98df282775d154b609a39c1068a09b)

4 years agoReformatted to satisfy clang-format
akallabeth [Wed, 20 May 2020 13:24:34 +0000 (15:24 +0200)]
Reformatted to satisfy clang-format

(cherry picked from commit a4e95f8e65dfbfd2625034ad6740645366a6c0c0)

4 years agoAbort on first possible certificate validation error
akallabeth [Wed, 20 May 2020 11:45:57 +0000 (13:45 +0200)]
Abort on first possible certificate validation error

Only retry certificate validation if the purpose was wrong.

(cherry picked from commit de619e9964684eced5fb3108de81440b979aace0)

4 years agoFixed #6197: NULL check in urbdrc
akallabeth [Wed, 20 May 2020 06:59:44 +0000 (08:59 +0200)]
Fixed #6197: NULL check in urbdrc

(cherry picked from commit fb3a0e6b5ae3b4e6523509a0ec0c522425968989)

4 years agoFixed #6195: Wrong length read/write in rdpei
Armin Novak [Tue, 19 May 2020 17:46:01 +0000 (19:46 +0200)]
Fixed #6195: Wrong length read/write in rdpei

(cherry picked from commit a18a732d4b87c85bcd364626b9ab2b8f95f9e955)

4 years agoFixed #6200: Arraysize check
Armin Novak [Tue, 19 May 2020 17:32:42 +0000 (19:32 +0200)]
Fixed #6200: Arraysize check

(cherry picked from commit 06c48df0dfd228646fed00c554a20ae9bcaa5e5e)

4 years agoFixed #6199: Reading version information in tsg
Armin Novak [Tue, 19 May 2020 17:29:32 +0000 (19:29 +0200)]
Fixed #6199: Reading version information in tsg

(cherry picked from commit e501c56e5ca0c76c4019e7048cba3ee63331d830)

4 years agoFixed #6201: event handler count check
Armin Novak [Tue, 19 May 2020 17:25:18 +0000 (19:25 +0200)]
Fixed #6201: event handler count check

(cherry picked from commit 018eaa44f52b3e9e33bfa80493faf9be57713a3d)

4 years agoReset pointer to NULL after free.
akallabeth [Tue, 19 May 2020 13:18:55 +0000 (15:18 +0200)]
Reset pointer to NULL after free.

(cherry picked from commit 33c7f808154c6682d3b84526a46d79f3e8d5c1ac)

4 years agoRenamed variable to avoid MSVC define collission
akallabeth [Tue, 19 May 2020 09:32:59 +0000 (11:32 +0200)]
Renamed variable to avoid MSVC define collission

(cherry picked from commit f9e1f21b0ce47d8eeea40314ce6b8b666964dc7d)

4 years agoFixed missing label
akallabeth [Tue, 19 May 2020 07:05:05 +0000 (09:05 +0200)]
Fixed missing label

4 years agoEnsure buffers are NULL before reuse in NLA
akallabeth [Tue, 19 May 2020 06:16:55 +0000 (08:16 +0200)]
Ensure buffers are NULL before reuse in NLA

(cherry picked from commit 5f53b2b7c7109016b7127d595e13bd333ac77613)

4 years agoRemoved unused variable warnings
akallabeth [Tue, 19 May 2020 06:04:02 +0000 (08:04 +0200)]
Removed unused variable warnings

(cherry picked from commit 8052708f3354a686de98b62d641e9d0eb61a74db)

4 years agoFixed invalid argument to strtok_s
akallabeth [Tue, 19 May 2020 06:01:48 +0000 (08:01 +0200)]
Fixed invalid argument to strtok_s

(cherry picked from commit dc4ac3ba17b6a340b96aa3f6363c6fac866696b7)

4 years agoFixed GHSL-2020-101 missing NULL check
akallabeth [Tue, 19 May 2020 05:48:07 +0000 (07:48 +0200)]
Fixed GHSL-2020-101 missing NULL check

(cherry picked from commit b207dbba35c505bbc3ad5aadc10b34980c6b7e8e)

4 years agoFixed GHSL-2020-102 heap overflow
akallabeth [Tue, 19 May 2020 05:41:14 +0000 (07:41 +0200)]
Fixed  GHSL-2020-102 heap overflow

(cherry picked from commit 197b16cc15a12813c2e4fa2d6ae9cd9c4a57e581)

4 years agoFixed multiple sanitizer errors in codecs
akallabeth [Mon, 18 May 2020 15:40:28 +0000 (17:40 +0200)]
Fixed multiple sanitizer errors in codecs

(cherry picked from commit 2278d92a5d902692a7d1088629b2345c9b4e229c)

4 years agoFixed issues with clang sanitizers and alignemt offsets.
akallabeth [Mon, 18 May 2020 07:36:16 +0000 (09:36 +0200)]
Fixed issues with clang sanitizers and alignemt offsets.

(cherry picked from commit 4c1011fec37459ecc11f6c4453bcd693ed614e5d)

4 years agoFixed history buffer reset.
akallabeth [Mon, 18 May 2020 07:30:59 +0000 (09:30 +0200)]
Fixed history buffer reset.

(cherry picked from commit ccc9cbef2d5d0d9f5cf5ec7621f71bed33f41aba)

4 years agoFixed extended info packet alignment.
akallabeth [Mon, 18 May 2020 07:24:01 +0000 (09:24 +0200)]
Fixed extended info packet alignment.

(cherry picked from commit 03ebaf2dc1547c75f8693dd5087ce2e8dc17765a)

4 years agoFixed rdp_read_info_packet unaligned access and size checks
akallabeth [Mon, 18 May 2020 07:07:49 +0000 (09:07 +0200)]
Fixed rdp_read_info_packet unaligned access and size checks

(cherry picked from commit c75d08d70e878d35cd12ffac2aefcda405576092)

4 years agoFixed memory leak in test
akallabeth [Mon, 18 May 2020 06:10:42 +0000 (08:10 +0200)]
Fixed memory leak in test

(cherry picked from commit 2d630cccf7b1e566f99b74a224805fc25f85d6c1)

4 years agoFixed unaligned access
akallabeth [Mon, 18 May 2020 06:10:29 +0000 (08:10 +0200)]
Fixed unaligned access

(cherry picked from commit cb2ed7f09ad68242bfdfad8967024b063f785d97)

4 years agoFixed rails debug string warnings.
akallabeth [Mon, 18 May 2020 05:54:48 +0000 (07:54 +0200)]
Fixed rails debug string warnings.

(cherry picked from commit e58ea30305e8754ada82018c4f2042ec1b72337c)

4 years agoutf8 behaviour fixes
akallabeth [Fri, 15 May 2020 15:49:55 +0000 (17:49 +0200)]
utf8 behaviour fixes

(cherry picked from commit bb78eb4fa6f8618a70995eaf17aba94cc47a1e74)

4 years agoRewritten rdp_recv_logon_info_v2 to remove unaligned access
akallabeth [Fri, 15 May 2020 15:28:13 +0000 (17:28 +0200)]
Rewritten rdp_recv_logon_info_v2 to remove unaligned access

(cherry picked from commit 66d182a84bed7bf19b6a99d71a4e4c7c6856f583)

4 years agoRewritten check to satisfy BehaviouralSanitizer
akallabeth [Fri, 15 May 2020 15:18:57 +0000 (17:18 +0200)]
Rewritten check to satisfy BehaviouralSanitizer

(cherry picked from commit 14829de866b43e7f2740b46f0c736b9adf5067eb)

4 years agoFixed BehaviourSanitizer warning in rdp parser
akallabeth [Fri, 15 May 2020 14:55:58 +0000 (16:55 +0200)]
Fixed BehaviourSanitizer warning in rdp parser

(cherry picked from commit 771332c04e2dbad964d0cb11a86ff561e792bc35)

4 years agoFixed memory leak in NTLM test
akallabeth [Fri, 15 May 2020 14:38:42 +0000 (16:38 +0200)]
Fixed memory leak in NTLM test

(cherry picked from commit 135458cf27160d50e6294f87ef80f27f1f65d319)

4 years agoFixed undefined behaviour
akallabeth [Fri, 15 May 2020 14:30:02 +0000 (16:30 +0200)]
Fixed undefined behaviour

(cherry picked from commit c15929d821ce99aa8c1069f790f4addbe9439593)

4 years agoFixed undefined behaviour in primitives shift
akallabeth [Fri, 15 May 2020 14:04:28 +0000 (16:04 +0200)]
Fixed undefined behaviour in primitives shift

(cherry picked from commit 436bd3dbb103c7c49e51ffb1cafad6f25ab05d66)

4 years agoFixed undefined behaviour in ncrush
akallabeth [Fri, 15 May 2020 13:43:33 +0000 (15:43 +0200)]
Fixed undefined behaviour in ncrush

(cherry picked from commit 83137d2a1bb732fbea2f20778924a50a79f63fef)

4 years agoFixed undefined behaviour in rfx decoder
akallabeth [Fri, 15 May 2020 13:40:12 +0000 (15:40 +0200)]
Fixed undefined behaviour in rfx decoder

(cherry picked from commit ef611d34d61c6590429c17db5c97f0a9a33147e8)

4 years agoFixed UndefinedBehaviour in planar left shift
akallabeth [Fri, 15 May 2020 13:34:42 +0000 (15:34 +0200)]
Fixed UndefinedBehaviour in planar left shift

(cherry picked from commit 328691c46597c194f01a77a9d33d58b2faa88c9d)

4 years agoFixed BehaviourSanitizer warnings in streams.
akallabeth [Fri, 15 May 2020 13:04:05 +0000 (15:04 +0200)]
Fixed BehaviourSanitizer  warnings in streams.

(cherry picked from commit 66ea3d0579841b468684e05936fabf654727e720)

4 years agoFixed memory leak in ini parser and test functions.
akallabeth [Fri, 15 May 2020 12:49:52 +0000 (14:49 +0200)]
Fixed memory leak in ini parser and test functions.

(cherry picked from commit 7f9997595918e8b6a2acec2ff40f5779fa183038)

4 years agoRefactored settings clone/free, extended tests
akallabeth [Fri, 15 May 2020 10:22:37 +0000 (12:22 +0200)]
Refactored settings clone/free, extended tests

(cherry picked from commit 773ad6e9791844ca3ccdc40d378a37fc0238ef0a)

4 years agoFixed BehaviorSanitizer warnings.
akallabeth [Fri, 15 May 2020 09:20:24 +0000 (11:20 +0200)]
Fixed BehaviorSanitizer warnings.

(cherry picked from commit b5dfc15183b752a5d9c6da01225ed281b20001cf)

4 years agoFixed BehaviorSanitizer warnings
akallabeth [Fri, 15 May 2020 09:16:50 +0000 (11:16 +0200)]
Fixed BehaviorSanitizer warnings

(cherry picked from commit 0d28390319025c86e7e9d7cc776d88ef24f9db0e)

4 years agoAlways require aligned memory for interleaved codec.
akallabeth [Fri, 15 May 2020 09:16:18 +0000 (11:16 +0200)]
Always require aligned memory for interleaved codec.

(cherry picked from commit 20c11fb7178462a8ba36b4fdbfb3e2a03197356f)

4 years agoFixed BehaviorSanitizer warnings
akallabeth [Fri, 15 May 2020 09:15:21 +0000 (11:15 +0200)]
Fixed BehaviorSanitizer warnings

(cherry picked from commit afdd81dab5c484ab95b977a0d71f3809c8fa89a3)

4 years agoFixed BehaviorSantizer warnings.
akallabeth [Fri, 15 May 2020 09:14:44 +0000 (11:14 +0200)]
Fixed BehaviorSantizer warnings.

(cherry picked from commit 7a509fe27749e006a9a58854c4abb4522fc58c81)

4 years agoFixed GHSL-2020-100: oob read in ntlm_read_ChallengeMessage
akallabeth [Fri, 15 May 2020 08:17:31 +0000 (10:17 +0200)]
Fixed GHSL-2020-100: oob read in ntlm_read_ChallengeMessage

* Added length checks for data read from stream
* Unified function resource cleanup

(cherry picked from commit 8357dedbbf7213b7d0d18f1026145b9a5b92235a)

4 years agoFixed typos (Otherweise)
Kentaro Hayashi [Sun, 10 May 2020 07:35:20 +0000 (16:35 +0900)]
Fixed typos (Otherweise)

Otherweise ->
Otherw ise
      ^

(cherry picked from commit 148f3c675d02da2c7f19b3099ba8792f5594416b)

4 years agoimprove RFX DWT algorithm
Vladyslav Hordiienko [Wed, 6 May 2020 09:36:44 +0000 (12:36 +0300)]
improve RFX DWT algorithm

merge multiple loops into the one loop for vertical DWT inverse

(cherry picked from commit fff9eba34af8a54bd93b1a7ccdda0a6a6898f755)

4 years agofix typo in GFX logs
Vladyslav Hordiienko [Wed, 6 May 2020 08:05:04 +0000 (11:05 +0300)]
fix typo in GFX logs

(cherry picked from commit a79635fd1c9e12c4ea543f461f03c0dd83d5e063)

4 years agoWindows Authentication - Then launced with username argument prefill the name in...
Victor K [Fri, 15 May 2020 00:50:20 +0000 (03:50 +0300)]
Windows Authentication - Then launced with username argument prefill the name in the authentication box.

(cherry picked from commit 318075676b5ea610b1ba47da600eb418812951cb)

4 years agoRefactored sam functions to utilize strtok_s
akallabeth [Mon, 18 May 2020 10:07:59 +0000 (12:07 +0200)]
Refactored sam functions to utilize strtok_s

(cherry picked from commit ddb388e1527de69e47d55068d8a318ef270fc4a0)

4 years agoReplaced strtok with strtok_s
akallabeth [Mon, 18 May 2020 09:18:55 +0000 (11:18 +0200)]
Replaced strtok with strtok_s

(cherry picked from commit 7890833af8a891765a475bd7ae2a756aeddd4977)

4 years agoFixed NULL access of context struct on screen draw
akallabeth [Mon, 18 May 2020 12:27:13 +0000 (14:27 +0200)]
Fixed NULL access of context struct on screen draw

Added a log message to fix occurances later on.

(cherry picked from commit cfea3fc6ed01aa33c1a935da42572577ba832feb)

4 years agoExtend lifetime of streampool in drdynvc
akallabeth [Mon, 18 May 2020 12:20:11 +0000 (14:20 +0200)]
Extend lifetime of streampool in drdynvc

The stream pool can not be released until all streams have been
returned. This might happen as late as channel termination, so
change the lifetime scope accordingly.

(cherry picked from commit 5bd4cfcdc013cdd0c0d7c9b6eec878dd8a297575)

4 years agoFixed sample client resource cleanup
akallabeth [Mon, 18 May 2020 08:26:09 +0000 (10:26 +0200)]
Fixed sample client resource cleanup

(cherry picked from commit e716f823115463fc66d94dd6c044ba7c47c43fe1)