platform/upstream/gstreamer.git
2 years agoUpdate ChangeLogs for 1.19.3
Tim-Philipp Müller [Wed, 3 Nov 2021 15:43:32 +0000 (15:43 +0000)]
Update ChangeLogs for 1.19.3

2 years agoci: Do not clone in the trigger job
Nicolas Dufresne [Tue, 2 Nov 2021 20:09:52 +0000 (16:09 -0400)]
ci: Do not clone in the trigger job

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1298>

2 years agomultifilesink: Make minimum distance between keyframes in next-file=key-frame mode...
Sebastian Dröge [Tue, 2 Nov 2021 14:46:08 +0000 (16:46 +0200)]
multifilesink: Make minimum distance between keyframes in next-file=key-frame mode configurable

Previously this was hardcoded to 10s, which is not necessarily the
desired behaviour.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1292>

2 years agoqtmux: Fix deadlock in gst_qt_mux_prepare_moov_recovery
Erlend Eriksen [Mon, 1 Nov 2021 15:32:10 +0000 (16:32 +0100)]
qtmux: Fix deadlock in gst_qt_mux_prepare_moov_recovery

Regression from 5766731bd4200c3a374522a749386f740347661a

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1288>

2 years agoegl: handle configless contexts
Matthias Clasen [Mon, 1 Nov 2021 19:48:58 +0000 (15:48 -0400)]
egl: handle configless contexts

With EGL_KHR_no_config_context, EGL contexts may just not
have an EGLConfig to give you. Deal with it.

Fixes: #858
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1289>

2 years agoexamples: win32-videooverlay-playbin: Add a repeat option
Seungha Yang [Fri, 29 Oct 2021 16:55:38 +0000 (01:55 +0900)]
examples: win32-videooverlay-playbin: Add a repeat option

... in order to test pipeline/element reuse cases.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1275>

2 years agocodecs: mpeg2: Drain before a new_sequence get signalled
Nicolas Dufresne [Tue, 2 Nov 2021 13:40:43 +0000 (09:40 -0400)]
codecs: mpeg2: Drain before a new_sequence get signalled

The decoder may need to re-allocate the output buffer, it is easier if all
pictured have been outputed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agov4l2codecs: gstv4l2codecsmpeg2dec: implement a render delay
Daniel Almeida [Thu, 8 Apr 2021 19:24:49 +0000 (16:24 -0300)]
v4l2codecs: gstv4l2codecsmpeg2dec: implement a render delay

The v4l2 backend support delayed output for performance reasons.
It is then possible to use render delays to queue multiple requests
simultaneously, thus increasing performance.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agocodecs: gstmpeg2decoder: add support for render delay
Daniel Almeida [Thu, 8 Apr 2021 19:07:23 +0000 (16:07 -0300)]
codecs: gstmpeg2decoder: add support for render delay

Some decoding APIs support delayed output for performance reasons.
One example would be to request decoding for multiple frames and
then query for the oldest frame in the output queue.
This also increases throughput for transcoding and improves seek
performance when supported by the underlying backend.

Introduce support in the mpeg2 base class, so that backends that
support render delays can actually implement it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agov4l2codecs: Implement a MPEG2 V4L2 decoder element
Daniel Almeida [Tue, 6 Apr 2021 19:40:28 +0000 (16:40 -0300)]
v4l2codecs: Implement a MPEG2 V4L2 decoder element

Implement a MPEG2 V4L2 decoder element based on the previous h264
implementation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agov4l2codecs: mpeg2: update to the new uAPI
Daniel Almeida [Tue, 6 Apr 2021 19:42:54 +0000 (16:42 -0300)]
v4l2codecs: mpeg2: update to the new uAPI

The mpeg2 stateless api has undergone changes as it is being
destage. Update the v4l2-controls header to match.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agosys: va: GstVaMpeg2Dec: use slice sc_offset and size
Daniel Almeida [Fri, 26 Mar 2021 18:52:21 +0000 (15:52 -0300)]
sys: va: GstVaMpeg2Dec: use slice sc_offset and size

Seeing as how GstMpeg2Slice will now record the start code offset
as well as its size with the above field taken into account, the
manual computation in this class is not needed.

Remove it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agocodecs: GstMpeg2Slice: add field for sc_offset and size
Daniel Almeida [Fri, 26 Mar 2021 18:31:51 +0000 (15:31 -0300)]
codecs: GstMpeg2Slice: add field for sc_offset and size

Downstream might need the start code offset when decoding.

Previously this computation would be scattered in multiple sites. This
is error prone, so move it to the base class. Subclasses can access
slice->sc_offset directly without computing the address themselves
knowing that the size will also take the start code into account.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>

2 years agov4l2codecs: Handle allocator creation failure
James Cowgill [Wed, 20 Oct 2021 11:11:49 +0000 (12:11 +0100)]
v4l2codecs: Handle allocator creation failure

If `VIDIOC_REQBUFS` doesn't return enough buffers the allocator creation
function can fail and return `NULL`. Handle this by generating an error
and returning instead of segfaulting.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220>

2 years agov4l2codecs: Fix segfault when destroying non-detached allocator
James Cowgill [Wed, 20 Oct 2021 11:08:49 +0000 (12:08 +0100)]
v4l2codecs: Fix segfault when destroying non-detached allocator

The GstV4l2CodecAllocator dispose function clears `self->decoder` but
the finalize function then tries to use it if the allocator has no been
detached yet.

Fix by detaching in the dispose function before we clear
`self->decoder`.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220>

2 years agore-add gst-plugins-rs.wrap
Guillaume Desmottes [Tue, 2 Nov 2021 09:14:28 +0000 (10:14 +0100)]
re-add gst-plugins-rs.wrap

It's been lost during the monorepo migration.

Note that building Rust plugins as a subproject is currently broken,
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/171
but I'm going to fix that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1290>

2 years agoalphacombine: use the same allocation query data for both decoders
Julian Bouzas [Fri, 29 Oct 2021 20:08:20 +0000 (16:08 -0400)]
alphacombine: use the same allocation query data for both decoders

This allows downstream elements to set allocation query parameters for both
decoders, which should be always the same.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1277>

2 years agoapplemedia: Add ARGB64_BE, RGBA64_LE support to vtenc/vtdec
Nirbheek Chauhan [Sun, 31 Oct 2021 08:13:40 +0000 (13:43 +0530)]
applemedia: Add ARGB64_BE, RGBA64_LE support to vtenc/vtdec

We can add this now that ARGB64_BE videoconvert support was added in:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agovtenc: Add FieldDetail properties for interlaced input
Nirbheek Chauhan [Tue, 19 Oct 2021 20:49:33 +0000 (02:19 +0530)]
vtenc: Add FieldDetail properties for interlaced input

Standard interlace handling:
* If we have interlace-mode=interleaved and the field order, we just
  set it when creating the session
* If we have interlace-mode=(interleaved|mixed) and no field order, we
  set the field order on the first buffer

The encoder session does not support changing the FieldDetail after it
has started encoding frames, so we cannot support mixed streams
correctly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agovtenc: Add a property to forcibly ignore alpha values
Nirbheek Chauhan [Tue, 19 Oct 2021 20:19:29 +0000 (01:49 +0530)]
vtenc: Add a property to forcibly ignore alpha values

This PropertyKey is not documented in any headers anywhere, so we need
to define it ourselves.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agovtenc: Set colorimetry information
Nirbheek Chauhan [Tue, 19 Oct 2021 18:23:39 +0000 (23:53 +0530)]
vtenc: Set colorimetry information

It looks like VideoToolbox doesn't support all our colorimetries.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agoapplemedia: Add ProRes support to vtenc and vtdec
Nirbheek Chauhan [Sun, 17 Oct 2021 13:24:10 +0000 (18:54 +0530)]
applemedia: Add ProRes support to vtenc and vtdec

For vtdec, we continue to prefer NV12; else we pick whatever
downstream wants. In the special case where we're decoding 10-bit or
12-bit ProRes formats, we will prefer AYUV64.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agovtenc: Improve error reporting in chain function
Nirbheek Chauhan [Sun, 17 Oct 2021 13:49:15 +0000 (19:19 +0530)]
vtenc: Improve error reporting in chain function

Otherwise it is quite difficult to figure out why the chain function
failed. Also assert not reached for case statements that should not be
hit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agovtdec: Remove dead code in switch statement
Nirbheek Chauhan [Thu, 14 Oct 2021 06:44:49 +0000 (12:14 +0530)]
vtdec: Remove dead code in switch statement

We never advertise these formats, so these cases will never be hit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>

2 years agomediatype-video-raw: add ARGB64_LE/BE and variants
Piotrek Brzeziński [Sun, 31 Oct 2021 19:20:08 +0000 (20:20 +0100)]
mediatype-video-raw: add ARGB64_LE/BE and variants

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1286>

2 years agoAllow Strawberry Perl on Windows with Meson >= 0.60.0
Xavier Claessens [Thu, 28 Oct 2021 14:09:21 +0000 (10:09 -0400)]
Allow Strawberry Perl on Windows with Meson >= 0.60.0

Meson now explicitly blacklists pkg-config.bat from Strawberry Perl and
thus building GStreamer on Windows has been fixed.

This allows for instance to build GStreamer on GitHub Action Windows
runners that have Strawberry Perl by default.

It is also useful when needing to build OpenSSL on the same Windows
machine because it requires Perl.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1263>

2 years agovideo: Fix order of new video formats
Sebastian Dröge [Sat, 30 Oct 2021 13:22:39 +0000 (16:22 +0300)]
video: Fix order of new video formats

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1282>

2 years agobase: Fix some annotations
Sebastian Dröge [Sat, 30 Oct 2021 12:50:30 +0000 (15:50 +0300)]
base: Fix some annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1281>

2 years agoCouple more g_memdup() -> g_memdup2() fixes
Tim-Philipp Müller [Fri, 29 Oct 2021 23:58:55 +0000 (00:58 +0100)]
Couple more g_memdup() -> g_memdup2() fixes

Fixes deprecation warnings with newer GLib versions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>

2 years agodtls: don't use deprecated g_binding_get_source() with newer GLib versions
Tim-Philipp Müller [Fri, 29 Oct 2021 23:52:42 +0000 (00:52 +0100)]
dtls: don't use deprecated g_binding_get_source() with newer GLib versions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>

2 years agoUse g_pattern_spec_match() instead of g_pattern_match() which is deprecated since...
Tim-Philipp Müller [Fri, 29 Oct 2021 23:34:35 +0000 (00:34 +0100)]
Use g_pattern_spec_match() instead of g_pattern_match() which is deprecated since glib 2.70

Fixes compiler warnings with glib 2.70

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>

2 years agocodecs: h265decoder: Fix per-slice leak
Seungha Yang [Fri, 29 Oct 2021 16:41:51 +0000 (01:41 +0900)]
codecs: h265decoder: Fix per-slice leak

As documented, slice header parsed via gst_h265_parser_parse_slice_hdr()
should be cleared, otherwise it would result in memory leak.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1274>

2 years agova: Delay decoders downstream negotiation.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 14:05:24 +0000 (16:05 +0200)]
va: Delay decoders downstream negotiation.

Delay decoders downstream negotiation just before an output frame
needs to be allocated.

This is required, are least for H.264 and H.265 decoders, since
codec_data might trigger a new sequence before finishing upstream
negotiation, and sink pad caps need to set before setting source pad
caps, particularly to forward HDR fields. The other decoders are
changed too in order to keep the same structure among them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

2 years agovabasedec: Move warning message to decoder's category.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:41:53 +0000 (09:41 +0200)]
vabasedec: Move warning message to decoder's category.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

2 years agova: Move common variable need_negotiation to GstBaseDec.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:28:10 +0000 (09:28 +0200)]
va: Move common variable need_negotiation to GstBaseDec.

This is a common variable to all decoders, so it's sound to move it to
the base helper.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

2 years agova: Move back parent_object to each element.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:23:42 +0000 (09:23 +0200)]
va: Move back parent_object to each element.

Using GstBaseDec hack to access the parent_object of each element in
the element itself is a bit fragile. It would be better to keep its
own parent object as the usual global variable. It would make it
resistant to code changes.

The GstBaseDec macro to access the parent object now it's internal to
base decoder.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

2 years agovideo-format: Add support for ARGB64 LE/BE and similar variants
Piotrek Brzeziński [Fri, 22 Oct 2021 22:44:57 +0000 (00:44 +0200)]
video-format: Add support for ARGB64 LE/BE and similar variants

Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247>

2 years agoidentity: Fix crash when receiving a gap event outside the current segment
Vivia Nikolaidou [Fri, 29 Oct 2021 10:27:37 +0000 (13:27 +0300)]
identity: Fix crash when receiving a gap event outside the current segment

We were checking if the start time of the gap event was
GST_CLOCK_TIME_NONE, which is superfluous because that cannot happen,
and then not checking if it was NONE after gst_segment_to_running_time,
which caused a crash if an identity received a gap event fully or
partially outside the current segment.

This patch was done in cooperation with:
Jan Alexander Steffens (heftig) <jan.steffens@ltnglobal.com>

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1269>

2 years agortptwcc: don't assume all PacketInfo->data are buffers
Mathieu Duponchelle [Fri, 29 Oct 2021 01:46:25 +0000 (03:46 +0200)]
rtptwcc: don't assume all PacketInfo->data are buffers

They can also be buffer lists

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1268>

2 years agoneon: Allow building against neon 0.32.x
Heiko Becker [Sun, 26 Sep 2021 19:34:30 +0000 (21:34 +0200)]
neon: Allow building against neon 0.32.x

No API/ABI changes: https://github.com/notroj/neon/blob/0.32.0/NEWS#L3

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1267>

2 years agomeson: require matching GStreamer dep versions for unstable development releases
Tim-Philipp Müller [Mon, 25 Oct 2021 10:37:45 +0000 (11:37 +0100)]
meson: require matching GStreamer dep versions for unstable development releases

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/929

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>

2 years agosubprojects: fdk-aac: add fallback_url
Tim-Philipp Müller [Mon, 25 Oct 2021 14:57:36 +0000 (15:57 +0100)]
subprojects: fdk-aac: add fallback_url

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>

2 years agowebrtcbin: fix check_negotiation computing on caps event
Mathieu Duponchelle [Tue, 26 Oct 2021 22:20:57 +0000 (00:20 +0200)]
webrtcbin: fix check_negotiation computing on caps event

It seems logical that check_negotiation be true if received_caps
is *not* equal to the new caps.

Also clean up handling of transceivers' ssrc events, as this
patch triggered a leaky code path.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

2 years agowebrtcbin: connect input stream when receiving caps
Mathieu Duponchelle [Fri, 22 Oct 2021 23:54:05 +0000 (01:54 +0200)]
webrtcbin: connect input stream when receiving caps

.. if a current direction has already been set

When `webrtcbin` has created an offer based on codec_preferences,
it might not have received caps on its sinkpads by the time a
remote description is set, in which case we want to connect the
input stream upon actual reception of the caps instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

2 years agowebrtcbin: consider pads with trans->codec_preferences ready
Mathieu Duponchelle [Mon, 18 Oct 2021 13:23:48 +0000 (15:23 +0200)]
webrtcbin: consider pads with trans->codec_preferences ready

.. when determining whether we can emit on-negotiation-needed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

2 years agompeg4videoparse: fix criticals trying to insert configs that don't exist yet
Tim-Philipp Müller [Thu, 28 Oct 2021 16:41:54 +0000 (17:41 +0100)]
mpeg4videoparse: fix criticals trying to insert configs that don't exist yet

With mpeg4videoparse drop=false config-interval=N|-1 we might be
trying to insert a config before we have actually received one,
in which case we'll try to map a NULL buffer which will generate
lots of criticals.

Fixes #855

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1265>

2 years agoqtdemux: Fix text and closed-caption handling.
Jan Schmidt [Thu, 28 Oct 2021 10:37:47 +0000 (21:37 +1100)]
qtdemux: Fix text and closed-caption handling.

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182
broke text and and closed caption extraction when introducing WebVTT
support, by making the output buffers not have timestamps any more.

Fix that by making the process functions copy buffer metadata
when generating new output buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1262>

2 years agomsdk: Insert hdr sei at hevc encoder
Mengkejiergeli Ba [Wed, 20 Oct 2021 09:46:10 +0000 (17:46 +0800)]
msdk: Insert hdr sei at hevc encoder

There are two HDR SEIs defined in spec: mastering display colour volume and
content light level. Add insertion of HDR SEIs when they are available
during encoding.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1242>

2 years agowebrtcbin: Also check data channel transport when collating connection state
Rob Agar [Thu, 21 Oct 2021 15:12:06 +0000 (16:12 +0100)]
webrtcbin: Also check data channel transport when collating connection state

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/838

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1224>

2 years agovapostproc: Color fixation will choose othercaps' structure.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:54:09 +0000 (11:54 +0200)]
vapostproc: Color fixation will choose othercaps' structure.

gst_va_fixate_format() will iterate all othercaps' structures to find
the one with less information lost at color conversion. If a structure
with same color format is found, the iteration stops. It's like a
smart truncation. Then, this function also will choose the caps
feature.

Later this structure is used fixate its size and no further truncation
is needed.

Don't intersect at fixate, since it kills possible resizing.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

2 years agovapostproc: Ignore direction at orientation swapping.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:53:28 +0000 (11:53 +0200)]
vapostproc: Ignore direction at orientation swapping.

It doesn't matter the direction of the negotiation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

2 years agovapostproc: Consider video orientation for border calculation.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 08:31:04 +0000 (10:31 +0200)]
vapostproc: Consider video orientation for border calculation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

2 years agodecodebin3: Only unblock for GAP events and buffers.
Jan Schmidt [Wed, 27 Oct 2021 11:49:44 +0000 (22:49 +1100)]
decodebin3: Only unblock for GAP events and buffers.

An alternate fix for
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1239
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1236
that makes it clear the intent is to only unblock on a GAP event, and
not any others.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1260>

2 years agopython: Update audiotestsrc to return correct tuple on FlowReturn Errors
Chris Wiggins [Wed, 27 Oct 2021 04:20:39 +0000 (17:20 +1300)]
python: Update audiotestsrc to return correct tuple on FlowReturn Errors

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1259>

2 years agoavtpsrc: Retry receive with same buffer size
Timo Wischer [Wed, 6 Oct 2021 14:00:56 +0000 (16:00 +0200)]
avtpsrc: Retry receive with same buffer size

Without this patch in case of a retry recv() will be called with a
negative size argument.

Signed-off-by: Timo Wischer <timo.wischer@de.bosch.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1078>

2 years agoparsebin: fix critical when sorting pads
Guillaume Desmottes [Tue, 26 Oct 2021 13:12:16 +0000 (15:12 +0200)]
parsebin: fix critical when sorting pads

If the pad does not have a current caps, get_pad() returns the query
caps which can be ANY. In such case the caps does not have any structure
resulting in a critical warning when calling gst_caps_get_structure().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1254>

2 years agocccombiner: fix default value when installing schedule property
Mathieu Duponchelle [Tue, 26 Oct 2021 14:00:36 +0000 (16:00 +0200)]
cccombiner: fix default value when installing schedule property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

2 years agocccombiner: fix emission of selected-samples in one case
Mathieu Duponchelle [Tue, 26 Oct 2021 13:58:26 +0000 (15:58 +0200)]
cccombiner: fix emission of selected-samples in one case

Detected while reading the code, cccombiner must set
self->current_video_buffer to NULL *after* emitting selected-samples
in order for the application to get a useful return when peeking
the next video sample.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

2 years agocccombiner: stop attaching caption buffers when caption pad has gone EOS
Mathieu Duponchelle [Mon, 25 Oct 2021 23:09:58 +0000 (01:09 +0200)]
cccombiner: stop attaching caption buffers when caption pad has gone EOS

When schedule is true (as is the case by default), we insert padding
when no caption data is present in the schedule queue, and previously
weren't checking whether the caption pad had gone EOS, leading to
infinite scheduling of padding after EOS on the caption pad.

Rectify that by adding a "drain" parameter to dequeue_caption()

In addition, update the captions_and_eos test to push valid cc_data
in: without this cccombiner was attaching padding buffers it had
generated itself, and with that patch would now stop attaching
said padding to the second buffer. By pushing valid, non-padding
cc_data we ensure a caption buffer is indeed attached to the first
and second video buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

2 years agoci/fuzzing: update for mono repo
Matthew Waters [Tue, 26 Oct 2021 08:11:19 +0000 (19:11 +1100)]
ci/fuzzing: update for mono repo

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1253>

2 years agocurlsftpsink: Add support for sha256 fingerprint
Mats Lindestam [Wed, 20 Oct 2021 11:19:00 +0000 (13:19 +0200)]
curlsftpsink: Add support for sha256 fingerprint

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1193>

2 years agomsdkvpp: Add 12bit formats
Mengkejiergeli Ba [Thu, 21 Oct 2021 03:09:07 +0000 (11:09 +0800)]
msdkvpp: Add 12bit formats

Add 12bit formats for different chroma samplings at sink pad and
src pad, including P012_LE, Y212_LE and Y412_LE.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1218>

2 years agodevicemonitor: g_queue_clear_full introduced in glib 2.60
Ruben Gonzalez [Mon, 25 Oct 2021 19:55:25 +0000 (21:55 +0200)]
devicemonitor: g_queue_clear_full introduced in glib 2.60

The GStreamer dependency is glib >=2.56.0. Therefore, define
g_queue_clear_full if glib < 2.60.

Issue added in commit 1912bcbc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1251>

2 years agogs: update README to use fixed versions
Floris [Mon, 25 Oct 2021 16:52:24 +0000 (18:52 +0200)]
gs: update README to use fixed versions

Use specific versions, instead of relying on 'master'.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>

2 years agogssrc: use default blocksize
Floris [Mon, 25 Oct 2021 16:47:46 +0000 (18:47 +0200)]
gssrc: use default blocksize

The blocksize is set to 3 * 1024 * 1024 / 2, which is the default download_size of Google-Cloud-CPP.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/846

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>

2 years agovah265dec: Fix end_picture() vmethod.
Víctor Manuel Jáquez Leal [Mon, 25 Oct 2021 14:53:14 +0000 (16:53 +0200)]
vah265dec: Fix end_picture() vmethod.

Since commit 88437a9c the signature of h265decoder's end_picture()
changed to return GstFlowReturn, but vah265dec was not updated.

This commit fixes this regression.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1248>

2 years agodevicemonitor: Only fail start() if no provider at all could be started
Sebastian Dröge [Tue, 19 Oct 2021 10:39:55 +0000 (13:39 +0300)]
devicemonitor: Only fail start() if no provider at all could be started

Also refactor various internals of the monitor code:
  - Don't allow starting twice but just return directly when starting a
    second time.
  - Don't end up in an inconsistent state if call start() a second time
    while the monitor is starting up.
  - Remove complicated cookie code: it was not possible to add/remove
    filters while the monitor was started anyway so this was only useful
    in the very small time-window while starting the monitor or while
    getting the devices. Instead disallow adding/removing filters while
    the monitor is starting, and when getting devices work on a snapshot
    of providers/filters.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/667

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1189>

2 years agodocs: contribute: bump compiler reqs and coding style to C99
Tim-Philipp Müller [Sun, 16 May 2021 00:00:53 +0000 (01:00 +0100)]
docs: contribute: bump compiler reqs and coding style to C99

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-project/-/issues/78

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1243>

2 years agotypefindfunctions: Use memcmp() instead of a strange macro around strncmp()
Sebastian Dröge [Sat, 23 Oct 2021 13:06:54 +0000 (16:06 +0300)]
typefindfunctions: Use memcmp() instead of a strange macro around strncmp()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

2 years agotypefindfunctions: Add various CMAF brands to the MP4 typefinder
Sebastian Dröge [Sat, 23 Oct 2021 11:31:59 +0000 (14:31 +0300)]
typefindfunctions: Add various CMAF brands to the MP4 typefinder

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

2 years agotypefindfunctions: Refactor ftyp brands checking
Sebastian Dröge [Sat, 23 Oct 2021 11:30:02 +0000 (14:30 +0300)]
typefindfunctions: Refactor ftyp brands checking

Store known brands in arrays and add a helper function to check them.

Also add all the `iso3` to `isob` ISO brands and the `hlsf` ISO
fragmented brand.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

2 years agotypefindfunctions: Add various other boxes to the list of known top-level MP4 boxes
Sebastian Dröge [Sat, 23 Oct 2021 11:28:35 +0000 (14:28 +0300)]
typefindfunctions: Add various other boxes to the list of known top-level MP4 boxes

styp, udta, sidx, ssix, prft, mfra, pdin and meta are in the ISOBMFF
spec and emsg in the CMAF spec.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

2 years agova: allocator: Fix possible memory leaks
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:32:30 +0000 (17:32 +0800)]
va: allocator: Fix possible memory leaks

At gst_va_dmabuf_allocator_setup_buffer_full, static code analysis tool
does not know number of objects in descriptor is always larger than 0 if
export_surface_to_dmabuf succeeds. Thus, the tool will assume buf is
allocated with mem but not released when desc.num_objects equals to 0
and raise a mem leak issue.

For gst_va_dambuf_memories_setup, we should also inform the tool that
n_planes will be larger than 0 by checking the value at very beginning.
Then, the defect similar to above will not be raised during static analysis.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1241>

2 years agogst-plugins-ugly: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:36 +0000 (01:02 +0100)]
gst-plugins-ugly: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

2 years agogst-plugins-bad: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:28 +0000 (01:02 +0100)]
gst-plugins-bad: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

2 years agogst-plugins-good: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:07 +0000 (01:02 +0100)]
gst-plugins-good: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

2 years agogst-plugins-base: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:01:56 +0000 (01:01 +0100)]
gst-plugins-base: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

2 years agogstreamer: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:01:28 +0000 (01:01 +0100)]
gstreamer: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

2 years agod3d11: add support for new debug layer versions
Andoni Morales Alastruey [Sat, 23 Oct 2021 17:26:06 +0000 (19:26 +0200)]
d3d11: add support for new debug layer versions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1237>

2 years agoqtdemux: Add pasp box to the list of known boxes
Sebastian Dröge [Sat, 23 Oct 2021 11:38:06 +0000 (14:38 +0300)]
qtdemux: Add pasp box to the list of known boxes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1235>

2 years agoassrender: Add "application/vnd.ms-opentype" mimetype detection
Rafał Dzięgiel [Wed, 20 Jan 2021 11:04:48 +0000 (12:04 +0100)]
assrender: Add "application/vnd.ms-opentype" mimetype detection

The "application/vnd.ms-opentype" mimetype is commonly used in many fonts attached in the matroska videos.
Assrender should treat it as compatible without the need of parsing the file extension.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1207>

2 years agodocs: contribute: update how-to-submit-patches section for monorepo
Tim-Philipp Müller [Fri, 22 Oct 2021 16:56:26 +0000 (17:56 +0100)]
docs: contribute: update how-to-submit-patches section for monorepo

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/840#note_1114907

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1231>

2 years agowrap: libopenjp2: use patch version 7
Stéphane Cerveau [Fri, 22 Oct 2021 16:13:46 +0000 (18:13 +0200)]
wrap: libopenjp2: use patch version 7

Add support for win32 build
Disable the binary to avoid the thirdparty
dependency to be checked.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1229>

2 years agobaseparse: fix invalid avg_bitrate after reset
Pascal Hache [Fri, 22 Oct 2021 15:00:06 +0000 (11:00 -0400)]
baseparse: fix invalid avg_bitrate after reset

gst_base_parse_reset() does not reset data_bytecount to 0, so
gst_base_parse_update_bitrates() uses a wrong value to calculate
the average bitrate on subsequent pipeline starts. This leads to an
excessive amount of "tag" events being pushed. These events include
very high "bitrate" values that diminish over time, and are produced
until the average bitrate is back to sane values.

Fixes #840

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1228>

2 years agoRename toplevel project to gstreamer-full
Xavier Claessens [Fri, 22 Oct 2021 16:38:46 +0000 (12:38 -0400)]
Rename toplevel project to gstreamer-full

This generates better tarball names when doing "meson dist" on the top
level project. It is also consistent with that project providing
gstreamer-full library.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1230>

2 years agogl/egl: install required egl.h header
Matthew Waters [Fri, 22 Oct 2021 06:54:55 +0000 (17:54 +1100)]
gl/egl: install required egl.h header

Fixes build against using the gir.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1227>

2 years agogstvulkan: Constify code in create_shader
Martin Reboredo [Fri, 22 Oct 2021 02:35:41 +0000 (23:35 -0300)]
gstvulkan: Constify code in create_shader

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1226>

2 years agomeson: default to gpl=disabled for gst-plugins-bad and -ugly
Tim-Philipp Müller [Wed, 20 Oct 2021 23:33:06 +0000 (00:33 +0100)]
meson: default to gpl=disabled for gst-plugins-bad and -ugly

This will only affect individual/tarball module builds, as the
options yield to the parent project which was set to gpl=disabled
by default already. We kept it as auto in the original commit
to accommodate the need to update cerbero as well, which had to
be done separately after the initial commit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1217>

2 years agoassrender: Do not iterate over mimetypes without filename
Rafał Dzięgiel [Wed, 20 Jan 2021 12:38:03 +0000 (13:38 +0100)]
assrender: Do not iterate over mimetypes without filename

No point spending time on iterating and comparing strings if we
are going to reject the value due to missing filename anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

2 years agoassrender: Fix mimetype detection
Rafał Dzięgiel [Wed, 20 Jan 2021 10:46:17 +0000 (11:46 +0100)]
assrender: Fix mimetype detection

Previously gst_structure_has_name was used to get a string to compare with supported mimetypes.
This is incorrect as above function returns a user defined structure name which is
not the structure mimetype value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

2 years agomatroska: Set image/attachment structure mimetype
Rafał Dzięgiel [Wed, 20 Jan 2021 10:53:51 +0000 (11:53 +0100)]
matroska: Set image/attachment structure mimetype

Set structure mimetype to fix data detection by mimetype in other plugins.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

2 years agomatroska: Treat non-image structure as attachment
Rafał Dzięgiel [Wed, 20 Jan 2021 10:33:39 +0000 (11:33 +0100)]
matroska: Treat non-image structure as attachment

Otherwise each structure is named as GstTagImageInfo even if
it does not contain any images which is misleading.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

2 years agortpbin: fix leak of pad when a fec encoder and aux sender a created
Matthew Waters [Thu, 21 Oct 2021 09:32:05 +0000 (20:32 +1100)]
rtpbin: fix leak of pad when a fec encoder and aux sender a created

The ghost sink pad retrieved by rtpbin from the aux sender was not freed
when there was a previous element (fec encoder) in the chain.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1222>

2 years agoci: gstreamer-full: remove static build
Stéphane Cerveau [Wed, 20 Oct 2021 15:56:49 +0000 (17:56 +0200)]
ci: gstreamer-full: remove static build

The gstreamer-full jobs act as
static builds,  no need to perform it twice.

gstreamer-full-minimal can be nodebug.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1215>

2 years agoREADME: Remove outdated Windows ARM64 related comment
Seungha Yang [Thu, 21 Oct 2021 09:25:47 +0000 (18:25 +0900)]
README: Remove outdated Windows ARM64 related comment

We bumped required meson version which contains the mentioned
meson patch already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1221>

2 years agovulkan/swapper: add some debug logging for surface size and present modes
Matthew Waters [Thu, 21 Oct 2021 08:17:18 +0000 (19:17 +1100)]
vulkan/swapper: add some debug logging for surface size and present modes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1219>

2 years agointerlace: Replace custom lock with object lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:28:25 +0000 (00:28 +0200)]
interlace: Replace custom lock with object lock

The object lock is sufficient for the task of protecting against
object property data races.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Protect all properties with the lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:37:47 +0000 (00:37 +0200)]
interlace: Protect all properties with the lock

Avoid blatant data races here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Reset src_fps_d together with src_fps_n
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:36:47 +0000 (00:36 +0200)]
interlace: Reset src_fps_d together with src_fps_n

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Clear stored_fields together with stored_frame
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:35:00 +0000 (00:35 +0200)]
interlace: Clear stored_fields together with stored_frame

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>