Louis Dionne [Thu, 3 Jun 2021 22:26:31 +0000 (18:26 -0400)]
[libc++] Simplify apple-install-libcxx since we always use the same CMake cache
Fangrui Song [Thu, 3 Jun 2021 22:26:34 +0000 (15:26 -0700)]
[CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13
In a `-DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_LINK_LLVM_DYLIB=on -DCLANG_LINK_CLANG_DYLIB=on`
build, libLLVM-13git.so is 2% smaller and libclang-cpp.so is 1% smaller (on top of -Wl,-Bsymbolic-functions).
There may be some small performance improvement as well because GCC
-fPIC suppresses interprocedural optimizations for non-inline
definitions by default.
Note: we cannot add -fno-semantic-interposition for Clang<13. Clang<13's
implementation additionally optimizes global variables, which is incompatible
with unfortunate ELF -fno-pic default: direct access relocations for external
data. If the executable has a -fno-pic object file referencing a global variable
declared in a public header, the direct access relocation will cause a copy
relocation. The executable and libLLVM.so/libclang-cpp.so will disagree on the
address.
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D102453
peter klausler [Thu, 3 Jun 2021 00:28:50 +0000 (17:28 -0700)]
[flang] Catch errors in function calls instead of crashing
Add some missing error messages, and permit the appearance
of EntityDetails symbols in dummy argument type characterization.
Differential Revision: https://reviews.llvm.org/D103576
peter klausler [Thu, 3 Jun 2021 00:25:29 +0000 (17:25 -0700)]
[flang] Emit error about missing interface when needed
When a procedure pointer with no interface is called by a
function reference, complain about the lack.
Differential Revision: https://reviews.llvm.org/D103573
Louis Dionne [Thu, 3 Jun 2021 22:18:41 +0000 (18:18 -0400)]
[libc++] Define _LIBCPP_NO_NATIVE_SEMAPHORES even outside of pthread
<semaphore> needs to know about whether native semaphores are supported
or not, even if we're not using the pthread API.
Louis Dionne [Thu, 3 Jun 2021 22:15:13 +0000 (18:15 -0400)]
[libc++] Also build the static library in the Apple cache
peter klausler [Thu, 3 Jun 2021 00:21:41 +0000 (17:21 -0700)]
[flang] Fix crash on structure constructor as selector
In something like "ASSOCIATE(X=>T(1))", the "T(1)" is parsed
as a Variable because it looks like a function reference or
array reference; if it turns out to be a structure constructor,
which is something we can't know until we're able to attempt
generic interface resolution in semantics, the parse tree needs
to be fixed up by replacing the Variable with an Expr.
The compiler could already do this for putative function references
encapsulated as Exprs, so this patch moves some code around and
adds parser::Selector to the overloads of expression analysis.
Differential Revision: https://reviews.llvm.org/D103572
Philip Reames [Thu, 3 Jun 2021 21:35:43 +0000 (14:35 -0700)]
Kill a variable which is unused after
cddcc4cf [nfc]
zero9178 [Thu, 3 Jun 2021 21:28:47 +0000 (23:28 +0200)]
[NFC] Add missing includes for LLVM_ENABLE_MODULES builds
Building LLVM with the LLVM_ENABLE_MODULES cmake option fails when the modules are being compiled due to missing includes. This is a side effect of some transitive includes that changed recently.
Differential Revision: https://reviews.llvm.org/D103645
Leonard Chan [Thu, 3 Jun 2021 21:22:37 +0000 (14:22 -0700)]
[NFC][compiler-rt][hwasan] Refactor hwasan functions
This moves the implementations for HandleTagMismatch, __hwasan_tag_mismatch4,
and HwasanAtExit from hwasan_linux.cpp to hwasan.cpp and declares them in hwasan.h.
This way, calls to those functions can be shared with the fuchsia implementation
without duplicating code.
Differential Revision: https://reviews.llvm.org/D103562
peter klausler [Thu, 3 Jun 2021 00:13:55 +0000 (17:13 -0700)]
[flang] Support known constant lengths in DynamicType
The constexpr-capable class evaluate::DynamicType represented
CHARACTER length only with a nullable pointer into the declared
parameters of types in the symbol table, which works fine for
anything with a declaration but turns out to not suffice to
describe the results of the ACHAR() and CHAR() intrinsic
functions. So extend DynamicType to also accommodate known
constant CHARACTER lengths, too; use them for ACHAR & CHAR;
clean up several use sites and fix regressions found in test.
Differential Revision: https://reviews.llvm.org/D103571
Teresa Johnson [Wed, 2 Jun 2021 23:37:23 +0000 (16:37 -0700)]
[LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch
A recent change (D99683) to support ThinLTO for HIP caused a regression
when compiling cuda code with -flto=thin -fwhole-program-vtables.
Specifically, we now get an error:
error: invalid argument '-fwhole-program-vtables' only allowed with '-flto'
This error is coming from the device offload cc1 action being set up for
the cuda compile, for which -flto=thin doesn't apply and gets dropped.
This is a regression, but points to a potential issue that was silently
occurring before the patch, details below.
Before D99683, the check for fwhole-program-vtables in the driver looked
like:
if (WholeProgramVTables) {
if (!D.isUsingLTO())
D.Diag(diag::err_drv_argument_only_allowed_with)
<< "-fwhole-program-vtables"
<< "-flto";
CmdArgs.push_back("-fwhole-program-vtables");
}
And D.isUsingLTO() returned true since we have -flto=thin. However,
because the cuda cc1 compile is doing device offloading, which didn't
support any LTO, there was other code that suppressed -flto* options
from being passed to the cc1 invocation. So the cc1 invocation silently
had -fwhole-program-vtables without any -flto*. This seems potentially
problematic, since if we had any virtual calls we would get type test
assume sequences without the corresponding LTO pass that handles them.
However, with the patch, which adds support for device offloading LTO
option -foffload-lto=thin, the code has changed so that we set a bool
IsUsingLTO based on either -flto* or -foffload-lto*, depending on
whether this is the device offloading action. For the device offload
action in our compile, since we don't have -foffload-lto, IsUsingLTO is
false, and the check for LTO with -fwhole-program-vtables now fails.
What we should do is only pass through -fwhole-program-vtables to the
cc1 invocation that has LTO enabled (either the device offload action
with -foffload-lto, or the non-device offload action with -flto), and
otherwise drop the -fwhole-program-vtables for the non-LTO action.
Then we should error only if we have -fwhole-program-vtables without any
-f*lto* options.
Differential Revision: https://reviews.llvm.org/D103579
Philip Reames [Thu, 3 Jun 2021 21:14:59 +0000 (14:14 -0700)]
A couple style tweaks on top of
5c0d1b2f9 [nfc]
Philip Reames [Thu, 3 Jun 2021 21:03:21 +0000 (14:03 -0700)]
[LoopUnroll] Eliminate PreserveCondBr parameter and fix a bug in the process
This builds on D103584. The change eliminates the coupling between unroll heuristic and implementation w.r.t. knowing when the passed in trip count is an exact trip count or a max trip count. In theory the new code is slightly less powerful (since it relies on exact computable trip counts), but in practice, it appears to cover all the same cases. It can also be extended if needed.
The test change shows what appears to be a bug in the existing code around the interaction of peeling and unrolling. The original loop only ran 8 iterations. The previous output had the loop peeled by 2, and then an exact unroll of 8. This meant the loop ran a total of 10 iterations which appears to have been a miscompile.
Differential Revision: https://reviews.llvm.org/D103620
peter klausler [Thu, 3 Jun 2021 00:09:42 +0000 (17:09 -0700)]
[flang] Catch procedure pointer interface error
A procedure pointer is allowed to name a specific intrinsic function
from F'2018 table 16.2 as its interface, but not other intrinsic
procedures. Catch this error, and thereby also fix a crash resulting
from a failure later in compilation from failed characteristics;
while here, also catch the similar error with initializers.
Differential Revision: https://reviews.llvm.org/D103570
Fangrui Song [Thu, 3 Jun 2021 20:43:19 +0000 (13:43 -0700)]
[test] Update more clang/test/Profile tests
Julien Pagès [Thu, 3 Jun 2021 20:32:15 +0000 (16:32 -0400)]
[AMDGPU] Fix a crash when selecting a particular case of buffer_load_format_d16
In this particular example, we had a crash when compiling it
for several architectures. This patch extends the legalization
of extract_subvector to avoid this problem.
Differential Revision: https://reviews.llvm.org/D103344
Fangrui Song [Thu, 3 Jun 2021 20:40:01 +0000 (13:40 -0700)]
[test] Update c-linkage-available_externally.c
peter klausler [Thu, 3 Jun 2021 00:02:43 +0000 (17:02 -0700)]
[flang] Accept BOZ in array constructors w/o types
As a benign extension common to other Fortran compilers,
accept BOZ literals in array constructors w/o explicit
types, treating them as integers.
Differential Revision: https://reviews.llvm.org/D103569
Jinsong Ji [Thu, 3 Jun 2021 20:08:35 +0000 (20:08 +0000)]
[Constants][PowerPC] Check exactlyValue for ppc_fp128 in isNullValue
PPC_FP128 determines isZero/isNan/isInf using high-order double value
only. Checking isZero/isNegative might return the isNullValue unexpectedly.
eg:
0xM0000000000000000FFFFFFFFFFFFFFFFF
isZero, but it is not NullValue.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D103634
Fangrui Song [Thu, 3 Jun 2021 20:16:13 +0000 (13:16 -0700)]
[InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat
`__profd_*` variables are referenced by code only when value profiling is
enabled. If disabled (e.g. default -fprofile-instr-generate), the symbols just
waste space on ELF/Mach-O. We change the comdat symbol from `__profd_*` to
`__profc_*` because an internal symbol does not provide deduplication features
on COFF. The choice doesn't matter on ELF.
(In -DLLVM_BUILD_INSTRUMENTED_COVERAGE=on build, there is now no `__profd_*` symbols.)
On Windows this enables further optimization. We are no longer affected by the
link.exe limitation: an external symbol in IMAGE_COMDAT_SELECT_ASSOCIATIVE can
cause duplicate definition error.
https://lists.llvm.org/pipermail/llvm-dev/2021-May/150758.html
We can thus use llvm.compiler.used instead of llvm.used like ELF (D97585).
This avoids many `/INCLUDE:` directives in `.drectve`.
Here is rnk's measurement for Chrome:
```
This reduced object file size of base_unittests.exe, compiled with coverage, optimizations, and gmlt debug info by 10%:
#BEFORE
$ find . -iname '*.obj' | xargs du -b | awk '{ sum += $1 } END { print sum}'
1047758867
$ du -cksh base_unittests.exe
82M base_unittests.exe
82M total
# AFTER
$ find . -iname '*.obj' | xargs du -b | awk '{ sum += $1 } END { print sum}'
937886499
$ du -cksh base_unittests.exe
78M base_unittests.exe
78M total
```
Reviewed By: davidxl, rnk
Differential Revision: https://reviews.llvm.org/D103372
Kevin Athey [Thu, 3 Jun 2021 19:40:14 +0000 (12:40 -0700)]
Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).
In addition:
- optionally add global flag to capture compile intent for UAR:
__asan_detect_use_after_return_always.
The global is a SANITIZER_WEAK_ATTRIBUTE.
for issue: https://github.com/google/sanitizers/issues/1394
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D103304
peter klausler [Wed, 2 Jun 2021 23:59:31 +0000 (16:59 -0700)]
[flang] Fix folding of CMPLX
The code for folding calls to the intrinsic function CMPLX was
incorrectly dependent on the number of arguments to distinguish its
two cases (conversion from one kind of complex to another, and
composition of a complex value from real & imaginary parts).
This was wrong since the optional KIND= argument has already been
taken into account by intrinsic processing; instead, the type of
the first argument should decide the issue.
Differential Revision: https://reviews.llvm.org/D103568
Brendon Cahoon [Sat, 22 May 2021 17:14:58 +0000 (13:14 -0400)]
[GlobalISel] Add G_SBFX/G_UBFX to computeKnownBits
Differential Revision: https://reviews.llvm.org/D102969
Nikita Popov [Thu, 3 Jun 2021 19:41:21 +0000 (21:41 +0200)]
[LoopUnroll] Add additional test with one unpredictable exit (NFC)
One exit is unpredictable, the other has a known trip count. For
one function the predictable exit is the latch exit, for the other
the non-latch exit. Currently they are treated differently.
Louis Dionne [Thu, 3 Jun 2021 18:14:57 +0000 (14:14 -0400)]
[libc++] Implement LWG3435 (constraints on reverse_iterator and move_iterator)
peter klausler [Wed, 2 Jun 2021 23:54:42 +0000 (16:54 -0700)]
[flang] Fix crashes due to failure to find a subprogram
In error recovery situations, the mappings from source locations
to scopes were failing in a way that tripped some asserts.
Specifically, FindPureProcedureContaining() wasn't coping well
when starting at the global scope. (And since the global scope
no longer has a source range, clean up the Semantics constructor
to avoid confusion.)
Differential Revision: https://reviews.llvm.org/D103567
Fangrui Song [Thu, 3 Jun 2021 19:36:27 +0000 (12:36 -0700)]
[docs] Update llvm-cov gcov
Mention some new options.
Remove outdated information about -g and -O0. -g0 works. -O1/-O2/-O3 work.
Louis Dionne [Thu, 3 Jun 2021 18:56:51 +0000 (14:56 -0400)]
[libc++] NFC: Tidy up the reverse_iterator tests
Incidentally, that fixes an error with the modules build.
Alex Richardson [Thu, 3 Jun 2021 18:58:43 +0000 (19:58 +0100)]
[lld-macho] Fix BUILD_SHARED_LIBS build
ca6751043d8899b12baeb48621e61fb352cfee09 added a dependency on XAR (at
least for the shared libs build), so without this change we get the
following linker error:
Undefined symbols for architecture x86_64:
"_xar_close", referenced from:
lld::macho::BitcodeBundleSection::finalize() in SyntheticSections.cpp.o
Reviewed By: #lld-macho, int3, thakis
Differential Revision: https://reviews.llvm.org/D100999
Sam Powell [Thu, 3 Jun 2021 18:11:23 +0000 (11:11 -0700)]
[llvm] llvm-tapi-diff
This patch introduces a new tool, llvm-tapi-diff, that compares and returns the diff of two TBD files.
Reviewed By: ributzka, JDevlieghere
Differential Revision: https://reviews.llvm.org/D101835
Eli Friedman [Fri, 28 May 2021 21:05:07 +0000 (14:05 -0700)]
[AtomicExpand] Merge cmpxchg success and failure ordering when appropriate.
If we're not emitting separate fences for the success/failure cases, we
need to pass the merged ordering to the target so it can emit the
correct instructions.
For the PowerPC testcase, we end up with extra fences, but that seems
like an improvement over missing fences. If someone wants to improve
that, the PowerPC backed could be taught to emit the fences after isel,
instead of depending on fences emitted by AtomicExpand.
Fixes https://bugs.llvm.org/show_bug.cgi?id=33332 .
Differential Revision: https://reviews.llvm.org/D103342
Artur Pilipenko [Thu, 3 Jun 2021 17:53:00 +0000 (10:53 -0700)]
NFC. Mark DOTFuncInfo getters as const
This is a preparatory refactoring for introducing new
types of hidden blocks.
Artur Pilipenko [Thu, 3 Jun 2021 17:50:26 +0000 (10:50 -0700)]
NFC. Refactor DOTGraphTraits::isNodeHidden
Restructure handling of cfg-hide-unreachable-paths and
cfg-hide-deoptimize-paths options so as to make it easier
to introduce new types of hidden blocks.
Adrian Prantl [Thu, 3 Jun 2021 18:22:24 +0000 (11:22 -0700)]
Remove redundant Begin/End form signpost format strings.
The os_signpost API already captures the begin/end part and in
Instruments, this just adds visual noise that gets in the way of the
interesting data. By removing the redundant end text, the display in
Instruments gets even less cluttered.
rdar://
78636200
Differential Revision: https://reviews.llvm.org/D103577
Christopher Di Bella [Wed, 2 Jun 2021 19:46:20 +0000 (19:46 +0000)]
[libcxx][module-map] creates submodules for private headers
Most of our private headers need to be treated as submodules so that
Clang modules can export things correctly. Previous commits that split
monolithic headers into smaller chunks were unaware of this requirement,
and so this is being addressed in one fell swoop. Moving forward, most
new headers will need to have their own submodule (anything that's
conditionally included is exempt from this rule, which means `__support`
headers aren't made into submodules).
This hasn't been marked NFC, since I'm not 100% sure that's the case.
Differential Revision: https://reviews.llvm.org/D103551
Chris Bieneman [Wed, 2 Jun 2021 18:48:58 +0000 (13:48 -0500)]
Don't delete the module you're inspecting
Prior to this patch when you used `clang -module-file-info` clang would
delete the module on completion because the module was treated as an
output file.
This fixes the issue so you don't need to invoke cc1 directly to get
module file information.
Reviewed By: steven_wu, phosek
Differential Revision: https://reviews.llvm.org/D103547
Sanjay Patel [Thu, 3 Jun 2021 17:15:23 +0000 (13:15 -0400)]
[InstCombine] eliminate sext and/or trunc if value has enough signbits
If we have enough signbits in a source value, we can skip an
intermediate cast for a trunc+sext pair:
https://alive2.llvm.org/ce/z/A_mQt-
This is the original problem shown in:
https://llvm.org/PR49543
There's a test that shows we transformed what used to be
a pair of shifts, so that suggests we could add another
ComputeNumSignBits fold starting from a shift.
There does not appear to be any change in compile-time
from the extra analysis:
https://llvm-compile-time-tracker.com/compare.php?from=
3d2c9069dcafd0cbb641841aa3dd6e851fb7d760&to=
b9513cdf2419704c7bb0c3a02a9ca06aae13d902&stat=instructions
Differential Revision: https://reviews.llvm.org/D103617
Victor Kuznetsov [Thu, 3 Jun 2021 17:23:49 +0000 (10:23 -0700)]
Fully-qualify template args of outer types in getFullyQualifiedType
Template args of outer types were not fully-qualified when calling getFullyQualifiedType() for inner types.
For simplicity the patch is a copy-paste of the same call from getFullyQualifiedType().
Reviewed at: https://reviews.llvm.org/D103039
Philip Reames [Thu, 3 Jun 2021 17:28:10 +0000 (10:28 -0700)]
[LoopUnroll] Eliminate PreserveOnlyFirst parameter [nfc]
This is a first step towards simplifying the transform interface to be less error prone. The basic idea is that querying SCEV is cheap (since it's cached) and we can just check for properties related to branch folding in the transform method instead of relying on the heuristic part to pass everything in correctly.
Differential Revision: https://reviews.llvm.org/D103584
Alexey Bataev [Fri, 21 May 2021 17:09:12 +0000 (10:09 -0700)]
[SLP]Improve cost estimation/emission of externally used extractelements.
No need to recalculate the cost of extractelements, just no need to
compensate the cost of all extractelements, need to check before if this
is actually going to be removed at the vectorization. Also, no need to
generate new extractelement instruction, we may just regenerate the
original one. It may improve the final vectorization.
Differential Revision: https://reviews.llvm.org/D102933
Philip Reames [Thu, 3 Jun 2021 17:05:12 +0000 (10:05 -0700)]
[LoopUnroll] Reorder code to max dom tree update more obvious [nfc]
This cleans up the unroll action into two phases. Phase 1 does the mechanical act of unrolling, and leaves all conditional branches in place. Phase 2 optimizes away some of the conditional branches and then simplifies the loop. The primary benefit of the reordering is that we can delete some special cases dom tree update logic.
Differential Revision: https://reviews.llvm.org/D103561
Jinsong Ji [Thu, 3 Jun 2021 16:43:15 +0000 (16:43 +0000)]
add ppc_fp128 bitcode writer testcase
Alexey Bataev [Thu, 27 May 2021 13:19:32 +0000 (06:19 -0700)]
[SLP]Allow to reorder nodes with >2 scalar values.
tryToVectorizeList function allows to reorder only 2 scalars. Patch
allows to reorder >2 scalars. Also, to avoid possible regressions, it
allows extra vectorization of the remaining parts of the scalars
elements if possible.
Part of D57059.
Differential Revision: https://reviews.llvm.org/D103247
Nikita Popov [Thu, 3 Jun 2021 16:58:29 +0000 (18:58 +0200)]
[Tests] Add missing include (NFC)
Fix one more missing include in a unit test after
983565a6fe4a9f40c7caf82b65c650c20dbcc104.
Nikita Popov [Thu, 3 Jun 2021 16:54:23 +0000 (18:54 +0200)]
[lld] Add missing includes (NFC)
Fix lld build after
983565a6fe4a9f40c7caf82b65c650c20dbcc104.
Harald van Dijk [Thu, 3 Jun 2021 16:51:52 +0000 (17:51 +0100)]
[SLP] Avoid std::stable_sort(properlyDominates()).
As noticed by NAKAMURA Takumi back in 2017, we cannot use
properlyDominates for std::stable_sort as properlyDominates only
partially orders blocks. That is, for blocks A, B, C, D, where A
dominates B and C dominates D, we have A == C, B == C, but A < B. This
is not a valid comparison function for std::stable_sort and causes
different results between libstdc++ and libc++. This change uses DFS
numbering to give deterministic results for all reachable blocks.
Unreachable blocks are ignored already, so do not need special
consideration.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D103441
Nikita Popov [Thu, 3 Jun 2021 16:47:51 +0000 (18:47 +0200)]
[MC] Add missing include (NFC)
Try to fix buildbots after
983565a6fe4a9f40c7caf82b65c650c20dbcc104.
Fangrui Song [Thu, 3 Jun 2021 16:45:19 +0000 (09:45 -0700)]
[mailmap] Add my entry
Nikita Popov [Tue, 1 Jun 2021 20:41:08 +0000 (22:41 +0200)]
[ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)
This is a followup to D103422. The DenseMapInfo implementations for
ArrayRef and StringRef are moved into the ArrayRef.h and StringRef.h
headers, which means that these two headers no longer need to be
included by DenseMapInfo.h.
This required adding a few additional includes, as many files were
relying on various things pulled in by ArrayRef.h.
Differential Revision: https://reviews.llvm.org/D103491
Mark de Wever [Wed, 2 Jun 2021 17:54:06 +0000 (19:54 +0200)]
[libc++][nfc] Add more nasty macros.
D101613 added some macros used by Microsofts SAL. D103425 uses `__pre`
and `__post`. They are also used by SAL and cause issues when used on
Windows. Add them to the blacklist making it easier to figure out what
the issue is.
Differential Revision: https://reviews.llvm.org/D103541
Jeremy Morse [Thu, 3 Jun 2021 16:16:58 +0000 (17:16 +0100)]
Revert "[DebugInstrRef][2/3] Track PHI values through register coalescing"
This reverts commit
ae4303b42cfa5c8c14e3fff67d73af2f154aea9a.
Expensive checks buildbot has found a problem with this:
https://lab.llvm.org/buildbot/#/builders/16/builds/11863
Rosie Sumpter [Wed, 2 Jun 2021 15:10:27 +0000 (16:10 +0100)]
[CostModel][AArch64] Add tests for ctlz, ctpop and cttz. NFC.
Differential Revision: https://reviews.llvm.org/D103601
Jeremy Morse [Thu, 3 Jun 2021 15:43:49 +0000 (16:43 +0100)]
[DebugInstrRef][2/3] Track PHI values through register coalescing
In the instruction referencing variable location model, we store variable
locations that point at PHIs in MachineFunction during register
allocation. Unfortunately, register coalescing can substantially change
the locations of registers, and so that PHI-variable-location side table
needs maintenence during the pass.
This patch builds an index from the side table, and whenever a vreg gets
coalesced into another vreg, update the index to record the new vreg that
the PHI happens in. It also accepts a limited range of subregister
coalescing, for example merging a subregister into a larger class.
Differential Revision: https://reviews.llvm.org/D86813
Jez Ng [Thu, 3 Jun 2021 01:53:44 +0000 (21:53 -0400)]
[lld-macho] Parse re-exports of nested TAPI documents
D103423 neglected to call `parseReexports()` for nested TBD
documents, leading to symbol resolution failures when trying to look up
a symbol nested more than one level deep in a TBD file. This fixes the
regression and adds a test.
It also appears that `umbrella` wasn't being set properly when calling
`parseLoadCommands` -- it's supposed to resolve to `this` if `nullptr`
is passed. I didn't write a failing test case for this but I've made
`umbrella` a member so the previous behavior should be preserved.
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D103586
Gerhard Gappmeier [Thu, 3 Jun 2021 14:56:56 +0000 (16:56 +0200)]
[clang-format] Add PPIndentWidth option
This allows to set a different indent width for preprocessor statements.
Example:
#ifdef __linux_
# define FOO
#endif
int main(void)
{
return 0;
}
Differential Revision: https://reviews.llvm.org/D103286
Gerhard Gappmeier [Thu, 3 Jun 2021 14:52:55 +0000 (16:52 +0200)]
[clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations
This re-applies the old patch D27651, which was never landed, into the
latest "main" branch, without understanding the code. I just applied
the changes "mechanically" and made it compiling again.
This makes the right pointer alignment working as expected.
Fixes https://llvm.org/PR27353
For instance
const char* const* v1;
float const* v2;
SomeVeryLongType const& v3;
was formatted as
const char *const * v1;
float const * v2;
SomeVeryLongType const &v3;
This patch keep the *s or &s aligned to the right, next to their variable.
The above example is now formatted as
const char *const *v1;
float const *v2;
SomeVeryLongType const &v3;
It is a pity that this still does not work with clang-format in 2021,
even though there was a fix available in 2016. IMHO right pointer alignment
is the default case in C, because syntactically the pointer belongs to the
variable.
See
int* a, b, c; // wrong, just the 1st variable is a pointer
vs.
int *a, *b, *c; // right
Prominent example is the Linux kernel coding style.
Some styles argue the left pointer alignment is better and declaration
lists as shown above should be avoided. That's ok, as different projects
can use different styles, but this important style should work too.
I hope that somebody that has a better understanding about the code,
can take over this patch and land it into main.
For now I must maintain this fork to make it working for our projects.
Cheers,
Gerhard.
Differential Revision: https://reviews.llvm.org/D103245
Aart Bik [Wed, 2 Jun 2021 23:08:16 +0000 (16:08 -0700)]
[mlir][sparse] add more type combinations to sparse storage scheme
Useful for "exhaustively" testing and benchmarking annotation combinations
to verify correctness and perform state space search for best performing.
Reviewed By: penpornk
Differential Revision: https://reviews.llvm.org/D103566
Tobias Gysi [Thu, 3 Jun 2021 15:23:14 +0000 (15:23 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in capi.
Replace the uses of deprecated Structured Op Interface methods in Linalg.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103619
Hsiangkai Wang [Thu, 3 Jun 2021 13:24:24 +0000 (21:24 +0800)]
[RISCV] Precommit a test case to show overwriting vector frame objects.
Alexander Belyaev [Thu, 3 Jun 2021 14:27:29 +0000 (16:27 +0200)]
[mlir] Fix warnings.
Tobias Gysi [Thu, 3 Jun 2021 14:19:19 +0000 (14:19 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in scalar inlining.
Replace the uses of deprecated Structured Op Interface methods in InlineScalarOperands.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103518
Peter Steinfeld [Wed, 2 Jun 2021 21:55:41 +0000 (14:55 -0700)]
[flang] Check for duplicate definitions of defined input/output procedures
It's possible to specify defined input/output procedures either as a
type-bound procedure of a derived type or as a defined-io-generic-spec. This
means that you can specify the same procedure in both mechanisms, which does
not cause problems. Alternatively, you can specify two different procedures to
be the defined input/output procedure for the same derived type. This is an
error. This change catches this error. The situation is slightly complicated
by parameterized derived types. Types with the same value for a KIND parameter
are treated as the same type while types with different KIND parameters are
treated as different types.
I implemented this check by adding a vector to keep track of which defined
input/output procedures had been seen for which derived types along with the
kind of procedure (read vs write and formatted vs unformatted). I also added
tests for non-parameterized types and types parameterized by KIND and LEN type
parameters.
I also removed an erroneous check from the code that creates runtime type
information.
Differential Revision: https://reviews.llvm.org/D103560
Hamza Mahfooz [Thu, 3 Jun 2021 14:11:00 +0000 (15:11 +0100)]
[Matrix] Preserve existing fast-math flags during lowering
This patch makes it so, floating-point instructions created in
LowerMatrixIntrinsics retain fast-math flags from instructions that are
higher up the chain.
Fixes https://bugs.llvm.org/show_bug.cgi?id=49738
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D103233
Valeriy Savchenko [Tue, 1 Jun 2021 13:26:53 +0000 (16:26 +0300)]
[analyzer] Add forwarding `addVisitor` method
The majority of all `addVisitor` callers follow the same pattern:
addVisitor(std::make_unique<SomeVisitor>(arg1, arg2, ...));
This patches introduces additional overload for `addVisitor` to simplify
that pattern:
addVisitor<SomeVisitor>(arg1, arg2, ...);
Differential Revision: https://reviews.llvm.org/D103457
Tobias Gysi [Thu, 3 Jun 2021 13:33:39 +0000 (13:33 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in op declarations.
Replace the uses of deprecated Structured Op Interface methods in LinalgOps.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103506
Louis Dionne [Wed, 2 Jun 2021 22:24:28 +0000 (18:24 -0400)]
[libc++] Remove unused variable warnings
Since D100581, Clang started flagging this variable which is set but
never read. Based on comparing this function with __match_at_start_posix_nosubs
(which is very similar), I am pretty confident that `__j` was simply left
behind as an oversight in Howard's
6afe8b0a2336.
Also workaround some unused variable warnings in the <random> tests.
It's pretty lame that we're not asserting the skew and kurtosis of
the binomial and negative binomial distributions, but that should be
tackled separately.
Differential Revision: https://reviews.llvm.org/D103533
Tobias Gysi [Thu, 3 Jun 2021 12:55:39 +0000 (12:55 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in loop lowering.
Replace the uses of deprecated Structured Op Interface methods in Loops.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103453
Nicolas Agostini [Thu, 3 Jun 2021 13:07:07 +0000 (22:07 +0900)]
[mlir][linalg] Transform PadTensorOp into InitOp, FillOp, GenericOp
Introduces a test pass that rewrites PadTensorOps with static shapes as a sequence of:
```
linalg.init_tensor // to create output
linalg.fill // to initialize with padding value
linalg.generic // to copy the original contents to the padded tensor
```
The pass can be triggered with:
- `--test-linalg-transform-patterns="test-transform-pad-tensor"`
Differential Revision: https://reviews.llvm.org/D102804
James Henderson [Wed, 26 May 2021 11:53:00 +0000 (12:53 +0100)]
[lit] Fix testing of standalone clang and lld builds
In such cases, the executables are not in the llvm_tools_dir directory, so we need to look in the other search locations. Previously, they were found via the PATH, but this was disabled by default in commit rGa1e6565.
Depends on D103154.
Reviewed By: thopre
Differential Revision: https://reviews.llvm.org/D103156
Tobias Gysi [Thu, 3 Jun 2021 12:24:59 +0000 (12:24 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in drop unit dims.
Replace the uses of deprecated Structured Op Interface methods in DropUnitDims.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103448
Martin Storsjö [Mon, 24 May 2021 12:06:56 +0000 (15:06 +0300)]
[LLD] [COFF] Fix autoexport from LTO objects with comdat symbols
Make sure that comdat symbols also have a non-null dummy
SectionChunk associated.
This requires moving around an existing FIXME regarding comdats in
LTO.
Differential Revision: https://reviews.llvm.org/D103012
Tobias Gysi [Thu, 3 Jun 2021 11:32:11 +0000 (11:32 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in bufferize, detensorize, and interchange.
Replace the uses of deprecated Structured Op Interface methods in Bufferize.cpp, Detensorize.cpp, and Interchange.cpp. The patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103530
Tobias Gysi [Thu, 3 Jun 2021 11:33:30 +0000 (11:33 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in test passes.
Replace the uses of deprecated Structured Op Interface methods in TestLinalgElementwiseFusion.cpp, TestLinalgFusionTransforms.cpp, and Transforms.cpp. The patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103528
David Green [Thu, 3 Jun 2021 11:33:03 +0000 (12:33 +0100)]
[ARM] Prettify gather/scatter debug comments. NFC
Tobias Gysi [Thu, 3 Jun 2021 11:00:36 +0000 (11:00 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in promotion.
Replace the uses of deprecated Structured Op Interface methods in Promotion.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103450
Muhammad Omair Javaid [Thu, 3 Jun 2021 09:52:18 +0000 (14:52 +0500)]
[LLDB] Skip TestDataFormatterStdUniquePtr.py on arm/linux
TestDataFormatterStdUniquePtr.py fails on lldb arm/aarch64 linux
buildbot but not reproducible on test machine. Skipping for now.
Muhammad Omair Javaid [Thu, 3 Jun 2021 09:52:18 +0000 (14:52 +0500)]
[LLDB] Skip TestDataFormatterStdUniquePtr.py on arm/linux
TestDataFormatterStdUniquePtr.py fails on lldb arm/aarch64 linux
buildbot but not reproducible on test machine. Skipping for now.
Fraser Cormack [Wed, 26 May 2021 16:56:26 +0000 (17:56 +0100)]
[RISCV] Reserve an emergency spill slot for any RVV spills
This patch addresses an issue in which fixed-length (VLS) vector RVV
code could fail to reserve an emergency spill slot for their frame index
elimination. This is because we were previously only reserving a spill
slot when there were `scalable-vector` frame indices being used.
However, fixed-length codegen uses regular-type frame indices if it
needs to spill.
This patch does the fairly brute-force method of checking ahead of time
whether the function contains any RVV spill instructions, in which case
it reserves one slot. Note that the second RVV slot is still only
reserved for `scalable-vector` frame indices.
This unfortunately causes quite a bit of churn in existing tests, where
we chop and change stack offsets for spill slots.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D103269
Tobias Gysi [Thu, 3 Jun 2021 09:20:32 +0000 (09:20 +0000)]
[mlir][linalg] Cleanup LinalgOp usage in generalization.
Replace the uses of deprecated Structured Op Interface methods in Generalization.cpp. This patch is based on https://reviews.llvm.org/D103394.
Differential Revision: https://reviews.llvm.org/D103531
Alexander Belyaev [Thu, 3 Jun 2021 09:33:56 +0000 (11:33 +0200)]
[mlir] Split linalg reshape ops into expand/collapse.
Differential Revision: https://reviews.llvm.org/D103548
Fraser Cormack [Wed, 2 Jun 2021 16:58:29 +0000 (17:58 +0100)]
[CodeGen] Fix a scalable-vector crash in VSELECT legalization
The `DAGTypeLegalizer::WidenVSELECTMask` function is not (yet) ready for
scalable vector types, and has numerous places in which it tries to grab
either the fixed size or number of elements of its types.
I believe that it should be possible to update this method to properly
account for scalable-vector types, but we don't have test cases for
that; RISC-V bails out early on as it has legal i1 vector masks. As
such, this patch just prevents it from crashing.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D103536
Raphael Isemann [Thu, 3 Jun 2021 09:17:36 +0000 (11:17 +0200)]
[lldb][NFC] Remove unused 'using ArrayRef' in RegisterValueTest
Yi Kong [Wed, 2 Jun 2021 17:05:18 +0000 (01:05 +0800)]
Add -fno-visibility-inlines-hidden option
This allows overriding -fvisibility-inlines-hidden.
Differential Revision: https://reviews.llvm.org/D103537
David Spickett [Mon, 24 May 2021 14:16:42 +0000 (14:16 +0000)]
[clang][ARM] Remove arm2/3/6/7m CPU names
These legacy CPUs are known to clang but not llvm.
Their use was ignored by llvm and it would print a
warning saying it did not recognise them.
However because some of them are default CPUs for their
architecture, you would get those warnings even if you didn't
choose a cpu explicitly.
(now those architectures will default to a "generic" CPU)
Information is thin on the ground for these older chips
so this is the best I could find:
https://en.wikichip.org/wiki/acorn/microarchitectures/arm2
https://en.wikichip.org/wiki/acorn/microarchitectures/arm3
https://en.wikichip.org/wiki/arm_holdings/microarchitectures/arm6
https://en.wikichip.org/wiki/arm_holdings/microarchitectures/arm7
Final part of fixing https://bugs.llvm.org/show_bug.cgi?id=50454.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D103028
Fraser Cormack [Wed, 2 Jun 2021 16:26:25 +0000 (17:26 +0100)]
[ValueTypes] Fix scalable-vector changeExtendedVectorTypeToInteger
The attached tests check for the regression in DAGCombiner's
`visitVSELECT`, which may call this method.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D103534
Dmitry Polukhin [Thu, 27 May 2021 08:20:35 +0000 (01:20 -0700)]
[clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics
Summary:
suggestPathToFileForDiagnostics is actively used in clangd for converting
an absolute path to a header file to a header name as it should be spelled
in the sources. Current approach converts absolute path to relative path.
This diff implements missing logic that makes a reverse lookup from the
relative path to the key in the header map that should be used in the sources.
Prerequisite diff: https://reviews.llvm.org/D103229
Test Plan: check-clang
Reviewers: dexonsmith, bruno, rsmith
Subscribers: cfe-commits
Tasks:
Tags: #clang
Differential Revision: https://reviews.llvm.org/D103142
Petr Hosek [Thu, 3 Jun 2021 08:17:48 +0000 (01:17 -0700)]
Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain"
This reverts commit
b5dd421a3afa02907777fddf61073274e2a4aa9a which
broke Fuchsia downstream builders.
Chia-hung Duan [Thu, 3 Jun 2021 07:51:49 +0000 (15:51 +0800)]
[mlir-reduce] Create MlirReduceLib
Move the core reducer algorithm into a library so that it'll be easier
for porting to different projects.
Depends On D101046
Reviewed By: jpienaar, rriddle
Differential Revision: https://reviews.llvm.org/D101607
Vitaly Buka [Thu, 3 Jun 2021 07:06:45 +0000 (00:06 -0700)]
[NFC][scudo] Avoid integer overflow in test
releasePagesToOS may shrink RSS below the value stored on start.
Arthur Eubanks [Mon, 31 May 2021 16:18:44 +0000 (09:18 -0700)]
[DFSan] Properly set argument ABI attributes
Calls must properly match argument ABI attributes with the callee.
Found via D103412.
Reviewed By: morehouse
Differential Revision: https://reviews.llvm.org/D103414
Michael Kruse [Thu, 3 Jun 2021 01:47:54 +0000 (20:47 -0500)]
[clang] Fix fail of OpenMP/tile_codegen_tile_for.cpp.
Clang's version string can be customized using CLANG_VENDOR which the
test did not consider. Change the test to accept any version string.
Zhaomo Yang [Thu, 3 Jun 2021 00:15:41 +0000 (00:15 +0000)]
Fix "control reaches end of non-void function" warnings on ppc64le
Warnings can be found here: https://lab.llvm.org/buildbot/#/builders/76/builds/2640
Reviewed By: ymandel
Differential Revision: https://reviews.llvm.org/D103565
Eli Friedman [Thu, 3 Jun 2021 00:23:58 +0000 (17:23 -0700)]
[AArch64] Add regression test for missed bfi optimization.
(See https://reviews.llvm.org/D60358 for the transform that breaks this
case.)
Nathan Ridge [Mon, 19 Apr 2021 07:25:57 +0000 (03:25 -0400)]
[clangd] Improve resolution of static method calls in HeuristicResolver
Differential Revision: https://reviews.llvm.org/D101741
James Y Knight [Thu, 3 Jun 2021 00:17:49 +0000 (20:17 -0400)]
Fix llvm/test/tools/llvm-dwp/X86/type_dedup_v5.test
It was writing files to the source dir after
316da543af14fb4b40ef0377fe770f430745f5ea.
Amy Huang [Wed, 2 Jun 2021 16:49:12 +0000 (09:49 -0700)]
Recommit "Fix tmp files being left on Windows builds." with a fix for
incorrect std::string use. (Also remove redundant call to
RemoveFileOnSignal.)
Clang writes object files by first writing to a .tmp file and then
renaming to the final .obj name. On Windows, if a compile is killed
partway through the .tmp files don't get deleted.
Currently it seems like RemoveFileOnSignal takes care of deleting the
tmp files on Linux, but on Windows we need to call
setDeleteDisposition on tmp files so that they are deleted when
closed.
This patch switches to using TempFile to create the .tmp files we write
when creating object files, since it uses setDeleteDisposition on Windows.
This change applies to both Linux and Windows for consistency.
Differential Revision: https://reviews.llvm.org/D102876
This reverts commit
20797b129f844d4b12ffb2b12cf33baa2d42985c.
Fangrui Song [Wed, 2 Jun 2021 23:49:54 +0000 (16:49 -0700)]
[InstrProfiling] Delete linkage/visibility toggling for Windows
The linkage/visibility of `__profn_*` variables are derived
from the profiled functions.
extern_weak => linkonce
available_externally => linkonce_odr
internal => private
extern => private
_ => unchanged
The linkage/visibility of `__profc_*`/`__profd_*` variables are derived from
`__profn_*` with linkage/visibility wrestling for Windows.
The changes can be folded to the following without changing semantics.
```
if (TT.isOSBinFormatCOFF() && !NeedComdat) {
Linkage = GlobalValue::InternalLinkage;
Visibility = GlobalValue::DefaultVisibility;
}
```
That said, I think we can just delete the code block.
An extern/internal function will now use private `__profc_*`/`__profd_*`
variables, instead of internal ones. This saves some symbol table entries.
A non-comdat {linkonce,weak}_odr function will now use hidden external
`__profc_*`/`__profd_*` variables instead of internal ones. There is potential
object file size increase because such symbols need `/INCLUDE:` directives.
However such non-comdat functions are rare (note that non-comdat weak
definitions don't prevent duplicate definition error).
The behavior changes match ELF.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D103355
Fangrui Song [Wed, 2 Jun 2021 23:12:08 +0000 (16:12 -0700)]
[profile] Add -fprofile-instr-generate tests for weak definition and various linkages
Fangrui Song [Wed, 2 Jun 2021 23:10:18 +0000 (16:10 -0700)]
[MC] Delete unneeded MCAsmParser &Parser