robertphillips@google.com [Wed, 23 Jan 2013 00:36:02 +0000 (00:36 +0000)]
Fix for oversight in r7325
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7328
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Jan 2013 22:04:13 +0000 (22:04 +0000)]
Remove declaration of unimplemented function.
git-svn-id: http://skia.googlecode.com/svn/trunk@7327
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Jan 2013 20:35:13 +0000 (20:35 +0000)]
Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7188046
git-svn-id: http://skia.googlecode.com/svn/trunk@7326
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 Jan 2013 20:29:16 +0000 (20:29 +0000)]
Fix bug in 1xN SkBitmapProcShader optimization
https://codereview.appspot.com/7187047/
git-svn-id: http://skia.googlecode.com/svn/trunk@7325
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Jan 2013 20:10:17 +0000 (20:10 +0000)]
Fix r7321 build errors on non-windows compilers (using forward declared but not defined class in templated function).
git-svn-id: http://skia.googlecode.com/svn/trunk@7324
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 22 Jan 2013 20:00:01 +0000 (20:00 +0000)]
Fix Android only code in SkDraw for 7317.
git-svn-id: http://skia.googlecode.com/svn/trunk@7322
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Jan 2013 19:55:59 +0000 (19:55 +0000)]
Let them eat GrEffectRef.
Changes the remaining existing code that operates on naked GrEffects to GrEffectRef.
Review URL: https://codereview.appspot.com/7124058
git-svn-id: http://skia.googlecode.com/svn/trunk@7321
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 22 Jan 2013 19:49:33 +0000 (19:49 +0000)]
Fix VC++ warning and Android only code for 7317.
git-svn-id: http://skia.googlecode.com/svn/trunk@7319
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 Jan 2013 19:38:46 +0000 (19:38 +0000)]
Added multi-select deletion to debugger
https://codereview.appspot.com/7190043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7318
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 22 Jan 2013 19:25:14 +0000 (19:25 +0000)]
Expose geometry and gamma on device.
https://codereview.appspot.com/6499101/
git-svn-id: http://skia.googlecode.com/svn/trunk@7317
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 22 Jan 2013 18:23:56 +0000 (18:23 +0000)]
Add wrapper for "gcl try"
Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048
git-svn-id: http://skia.googlecode.com/svn/trunk@7315
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 Jan 2013 18:03:56 +0000 (18:03 +0000)]
Fix saving modified skp from debugger
https://codereview.appspot.com/7181048/
git-svn-id: http://skia.googlecode.com/svn/trunk@7314
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 22 Jan 2013 18:01:26 +0000 (18:01 +0000)]
Simple Build fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7313
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 22 Jan 2013 17:50:47 +0000 (17:50 +0000)]
Fixing invalid text clipping on SkPicture playback
The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.
BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045
git-svn-id: http://skia.googlecode.com/svn/trunk@7312
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 Jan 2013 14:32:09 +0000 (14:32 +0000)]
Added toString to SkXfermode-derived classes (for debugger)
https://codereview.appspot.com/7139058/
git-svn-id: http://skia.googlecode.com/svn/trunk@7308
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 22 Jan 2013 13:54:52 +0000 (13:54 +0000)]
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.
git-svn-id: http://skia.googlecode.com/svn/trunk@7307
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 22 Jan 2013 13:34:01 +0000 (13:34 +0000)]
Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test
Review URL: https://codereview.appspot.com/7137050
git-svn-id: http://skia.googlecode.com/svn/trunk@7304
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 22 Jan 2013 12:55:54 +0000 (12:55 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7303
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Jan 2013 21:48:58 +0000 (21:48 +0000)]
Place fix in r7278 behind compile flag
git-svn-id: http://skia.googlecode.com/svn/trunk@7300
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 21 Jan 2013 21:18:14 +0000 (21:18 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7299
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Jan 2013 21:17:16 +0000 (21:17 +0000)]
Placing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@7298
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 21 Jan 2013 03:43:21 +0000 (03:43 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7297
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sun, 20 Jan 2013 16:22:24 +0000 (16:22 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7296
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 20 Jan 2013 07:05:51 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7295
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Sat, 19 Jan 2013 13:22:39 +0000 (13:22 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7294
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 19 Jan 2013 07:05:38 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7293
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 19 Jan 2013 04:56:36 +0000 (04:56 +0000)]
Fix bugs in r7291
TBR=reed
Review URL: https://codereview.appspot.com/7129057
git-svn-id: http://skia.googlecode.com/svn/trunk@7292
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 19 Jan 2013 04:21:27 +0000 (04:21 +0000)]
re-land r7258 with fixes and tests
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060
git-svn-id: http://skia.googlecode.com/svn/trunk@7291
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 18 Jan 2013 21:53:12 +0000 (21:53 +0000)]
Partial revert of r7287 to green up the bots.
git-svn-id: http://skia.googlecode.com/svn/trunk@7290
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Jan 2013 21:45:42 +0000 (21:45 +0000)]
Roll out r7258
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065
git-svn-id: http://skia.googlecode.com/svn/trunk@7289
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 18 Jan 2013 21:20:16 +0000 (21:20 +0000)]
Update gyp revision.
Now allows out-of-source output directories.
git-svn-id: http://skia.googlecode.com/svn/trunk@7288
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 18 Jan 2013 20:48:20 +0000 (20:48 +0000)]
(Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)
Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture. (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome). It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.
Committed: https://code.google.com/p/skia/source/detail?r=7275
Review URL: https://codereview.appspot.com/7033049
git-svn-id: http://skia.googlecode.com/svn/trunk@7287
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Jan 2013 20:03:58 +0000 (20:03 +0000)]
gm self-test: followup to r7284
TBR=rmistry
Review URL: https://codereview.appspot.com/7128056
git-svn-id: http://skia.googlecode.com/svn/trunk@7286
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 18 Jan 2013 19:20:52 +0000 (19:20 +0000)]
Reverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)
git-svn-id: http://skia.googlecode.com/svn/trunk@7285
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Jan 2013 19:19:47 +0000 (19:19 +0000)]
make gm self-test more robust
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7164043
git-svn-id: http://skia.googlecode.com/svn/trunk@7284
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 Jan 2013 18:31:19 +0000 (18:31 +0000)]
fix unused-variable warning in src/effects/SkBicubicImageFilter.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7283
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 18 Jan 2013 18:06:22 +0000 (18:06 +0000)]
tools.gyp: dependencies in apfabetical order
Review URL: https://codereview.appspot.com/7127055
git-svn-id: http://skia.googlecode.com/svn/trunk@7281
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 18 Jan 2013 17:56:31 +0000 (17:56 +0000)]
Removed unused variable in SkBicubicImageFilter.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7280
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 Jan 2013 17:53:36 +0000 (17:53 +0000)]
in SkPath::dump(), add \n after close() printf, so we don't run into the next verb (e.g. moveTo)
git-svn-id: http://skia.googlecode.com/svn/trunk@7279
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 Jan 2013 17:49:28 +0000 (17:49 +0000)]
increase iteration count from 16 to 24, when computing cubic-line intersection.
This fixes crbug 170666. Before the fix, were were finishing the "clip" step
with a curve that was still partly negative, and so as assert would fire.
added unittest to confirm that the assert doesn't fire.
git-svn-id: http://skia.googlecode.com/svn/trunk@7278
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 18 Jan 2013 17:41:26 +0000 (17:41 +0000)]
Fix 7273 for neon
https://codereview.appspot.com/7137059/
git-svn-id: http://skia.googlecode.com/svn/trunk@7277
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 18 Jan 2013 17:32:50 +0000 (17:32 +0000)]
Fix GPU-less build. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7276
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 18 Jan 2013 17:29:15 +0000 (17:29 +0000)]
Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture. (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome). It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.
Review URL: https://codereview.appspot.com/7033049
git-svn-id: http://skia.googlecode.com/svn/trunk@7275
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 18 Jan 2013 17:24:33 +0000 (17:24 +0000)]
Build render_pdfs on buildbot.
Review URL: https://codereview.appspot.com/7134055
git-svn-id: http://skia.googlecode.com/svn/trunk@7274
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 18 Jan 2013 16:38:40 +0000 (16:38 +0000)]
Added shaderproc for 1xN repeatX/repeatY BitmapProcShader
https://codereview.appspot.com/7063054/
git-svn-id: http://skia.googlecode.com/svn/trunk@7273
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 18 Jan 2013 15:21:54 +0000 (15:21 +0000)]
Fix gyp files when building Android for x86
BUG=606
Review URL: https://codereview.appspot.com/7086053
git-svn-id: http://skia.googlecode.com/svn/trunk@7271
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 18 Jan 2013 12:13:40 +0000 (12:13 +0000)]
Whitespace commit to test annotations (AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@7270
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 18 Jan 2013 07:07:28 +0000 (07:07 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7268
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 Jan 2013 22:07:50 +0000 (22:07 +0000)]
change SkPath::dump() to output compilable code snippet, to aid in debugging.
git-svn-id: http://skia.googlecode.com/svn/trunk@7267
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 17 Jan 2013 21:02:47 +0000 (21:02 +0000)]
shape ops work in progress
mostly working on cubic/cubic intersect
git-svn-id: http://skia.googlecode.com/svn/trunk@7266
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 17 Jan 2013 20:19:13 +0000 (20:19 +0000)]
Don't die when there are no fonts available.
https://codereview.appspot.com/7147044/
git-svn-id: http://skia.googlecode.com/svn/trunk@7265
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 19:51:41 +0000 (19:51 +0000)]
Added new bench to test out 1xN BitmapProcShaders
https://codereview.appspot.com/7160043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7264
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 18:43:29 +0000 (18:43 +0000)]
All skp files in Google Storage have been updated
git-svn-id: http://skia.googlecode.com/svn/trunk@7261
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 17 Jan 2013 18:39:59 +0000 (18:39 +0000)]
Fix call to INHERITED::isEqual in GrRadial2Gradient. Should be INHERITED::onIsEqual.
git-svn-id: http://skia.googlecode.com/svn/trunk@7260
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 17 Jan 2013 17:54:28 +0000 (17:54 +0000)]
Reapply r7198 with Mac/Windows fixes
BUG=https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7138056
git-svn-id: http://skia.googlecode.com/svn/trunk@7258
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 17 Jan 2013 16:50:08 +0000 (16:50 +0000)]
Remove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract.
Review URL: https://codereview.appspot.com/7142049
git-svn-id: http://skia.googlecode.com/svn/trunk@7254
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 17 Jan 2013 16:30:56 +0000 (16:30 +0000)]
Make navigating the picture view in debugger more functional.
https://codereview.appspot.com/7134049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7253
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 16:07:04 +0000 (16:07 +0000)]
Fix debugger handling of clip rrects
https://codereview.appspot.com/7135053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7252
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 Jan 2013 16:01:19 +0000 (16:01 +0000)]
cherry-pick from 7241: speed-up matrix44::setconcat when both inputs are
scale+translate by inlining the zero-assignments, rather than calling sk_bzero.
bench: matrix44_setconcat 2x faster
git-svn-id: http://skia.googlecode.com/svn/trunk@7251
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 14:50:59 +0000 (14:50 +0000)]
Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043
git-svn-id: http://skia.googlecode.com/svn/trunk@7247
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 14:39:20 +0000 (14:39 +0000)]
Switch debugger profiling stubs over to being guarded by SK_DEVELOPER
https://codereview.appspot.com/7134053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7246
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 Jan 2013 13:29:35 +0000 (13:29 +0000)]
Revert r7241, which broke tests on most platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@7245
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 17 Jan 2013 13:20:01 +0000 (13:20 +0000)]
Remove unused debugger code from SampleApp.
Review URL: https://codereview.appspot.com/7133049
git-svn-id: http://skia.googlecode.com/svn/trunk@7244
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 12:55:34 +0000 (12:55 +0000)]
Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046
git-svn-id: http://skia.googlecode.com/svn/trunk@7242
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 Jan 2013 12:17:00 +0000 (12:17 +0000)]
Add SSE2 multiplication for SkMatrix44 on some platforms.
Original author whunt@chromium.org.
https://codereview.appspot.com/7058077/
git-svn-id: http://skia.googlecode.com/svn/trunk@7241
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 17 Jan 2013 07:06:06 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7240
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 20:12:22 +0000 (20:12 +0000)]
Fixing expression logic from r7237/r7234
TBR=borenet
git-svn-id: http://skia.googlecode.com/svn/trunk@7238
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Jan 2013 19:57:02 +0000 (19:57 +0000)]
Compiler warning fixes for r7235
git-svn-id: http://skia.googlecode.com/svn/trunk@7237
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 19:24:15 +0000 (19:24 +0000)]
fix int->scalar warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@7236
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 18:54:15 +0000 (18:54 +0000)]
add gm for comparing drawSprite and drawBitmap
git-svn-id: http://skia.googlecode.com/svn/trunk@7235
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 18:43:36 +0000 (18:43 +0000)]
Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRenderer
Chrome uses this flag for recording to skpicture in order to improve performance.
Therefore, skai benchmarks should run with this flag enabled, and we need
gm and render_pictures test coverage to validate it. In gm, the vanilla
SkPicture test step will still run without the flag to ensure that case still gets test
coverage, while the SkPicture test steps that use rtree and tileGrid will now run with
the flag enabled.
Review URL: https://codereview.appspot.com/7111043
git-svn-id: http://skia.googlecode.com/svn/trunk@7234
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 18:18:48 +0000 (18:18 +0000)]
Add option to ignore small pixel diffs for --validate. By default, right
now we will default to max diff of 256, which means that for now we
report all pixels that are not as expected and we do not error out.
Ideally we will decrease the value of max diff to something that does
not have visual impact, e.g. 10, then we will report small changes with
the intensity under 10, but we will error out for anything larger.
Review URL: https://codereview.appspot.com/7137046
git-svn-id: http://skia.googlecode.com/svn/trunk@7232
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 16:28:58 +0000 (16:28 +0000)]
mark default constructor for SkMatrix44 as deprecated, since it calls setIdentity()
and we have explicit (enum-based) constructors to distinguish that from uninitialized.
git-svn-id: http://skia.googlecode.com/svn/trunk@7228
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 16:07:39 +0000 (16:07 +0000)]
Adding SK_API to SkTileGridPicture class declaration
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7227
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:51:47 +0000 (15:51 +0000)]
Change some function/vars from EffectPtr to EffectRef to reflect GrEffectPtr->GrEffectRef renaming.
git-svn-id: http://skia.googlecode.com/svn/trunk@7226
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:38:37 +0000 (15:38 +0000)]
Fix no-static-init (android) build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7225
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:31:06 +0000 (15:31 +0000)]
Fix GPU-less build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7224
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:25:55 +0000 (15:25 +0000)]
Fix missing "class" in friend decls in GrEffect.h
git-svn-id: http://skia.googlecode.com/svn/trunk@7223
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:16:18 +0000 (15:16 +0000)]
Wrap GrEffects in GrEffectPtr.
This is the first step towards automatic recycling of scratch resouces in the cache via ref-cnts.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7092061
git-svn-id: http://skia.googlecode.com/svn/trunk@7222
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 15:15:24 +0000 (15:15 +0000)]
remove legacy build-flags for drawBitmapRect
add SkRect::isetWH()
Review URL: https://codereview.appspot.com/7127045
git-svn-id: http://skia.googlecode.com/svn/trunk@7221
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 15:03:24 +0000 (15:03 +0000)]
revert change 7218
git-svn-id: http://skia.googlecode.com/svn/trunk@7220
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 14:47:06 +0000 (14:47 +0000)]
Add option to ignore small pixel diffs for --validate. By default, right now we will default to max diff of 256, which means that for now we report all pixels that are not as expected and we do not error out. Ideally we will decrease the value of max diff to something that does not have visual impact, e.g. 10, then we will report small changes with the intensity under 10, but we will error out for anything larger.
Review URL: https://codereview.appspot.com/7139043
git-svn-id: http://skia.googlecode.com/svn/trunk@7218
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 16 Jan 2013 13:50:33 +0000 (13:50 +0000)]
Whitespace change to trigger doxygen upload
git-svn-id: http://skia.googlecode.com/svn/trunk@7217
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 16 Jan 2013 13:25:45 +0000 (13:25 +0000)]
Whitespace change to trigger uploads after skia-autogen reset
git-svn-id: http://skia.googlecode.com/svn/trunk@7216
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 16 Jan 2013 07:05:56 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7215
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 Jan 2013 04:19:01 +0000 (04:19 +0000)]
better quick fix for GM self-test: ignore instance-counting lines in Debug output
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7127044
git-svn-id: http://skia.googlecode.com/svn/trunk@7214
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 Jan 2013 03:34:15 +0000 (03:34 +0000)]
quick fix for GM self-test failures after r7206
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7131043
git-svn-id: http://skia.googlecode.com/svn/trunk@7213
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 21:54:27 +0000 (21:54 +0000)]
Add VALIDATE_FAILURE_IS_A_TOOL_FAILURE to specify whether a failure in validation
means the tool should return failure or not. For now it is not defined, which
means any failed pixels are still reported to stdout, but the tool does not
return an error, allowing the bots to go green (until we can fix these failures).
Review URL: https://codereview.appspot.com/7105056
git-svn-id: http://skia.googlecode.com/svn/trunk@7211
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Jan 2013 20:58:17 +0000 (20:58 +0000)]
Fix busted texture coords in GrGLBlendEffect.
Review URL: https://codereview.appspot.com/7095062
git-svn-id: http://skia.googlecode.com/svn/trunk@7209
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:57:45 +0000 (20:57 +0000)]
Have drawBitmapRectToRect devolve to drawBitmap if it can (to avoid creating
a bitmap-shader, which is slower when the matrix is nearly translate-only).
SK_IGNORE_DRAWBITMAPRECT_AS_DRAWBITMAP will disable this if needed.
Review URL: https://codereview.appspot.com/7100058
git-svn-id: http://skia.googlecode.com/svn/trunk@7208
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Jan 2013 20:37:04 +0000 (20:37 +0000)]
Re-enable inst counting in debug builds.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7098066
git-svn-id: http://skia.googlecode.com/svn/trunk@7206
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:34:54 +0000 (20:34 +0000)]
add LF at end of file
git-svn-id: http://skia.googlecode.com/svn/trunk@7205
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:26:59 +0000 (20:26 +0000)]
add LF at end of file to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@7204
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 20:24:03 +0000 (20:24 +0000)]
Revert r7198 until I can fix https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7124043
git-svn-id: http://skia.googlecode.com/svn/trunk@7203
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:21:19 +0000 (20:21 +0000)]
add benches for drawBitmapRectToRect with slight scale/translate
git-svn-id: http://skia.googlecode.com/svn/trunk@7202
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 15 Jan 2013 20:17:47 +0000 (20:17 +0000)]
Added print out of SkShader information to debugger
https://codereview.appspot.com/7105045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7201
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 19:10:16 +0000 (19:10 +0000)]
gm: use new Expectations struct instead of comparison bitmaps
Review URL: https://codereview.appspot.com/7088044
git-svn-id: http://skia.googlecode.com/svn/trunk@7198
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 18:29:41 +0000 (18:29 +0000)]
Update gm self-test results to expect new runtime config debug message
git-svn-id: http://skia.googlecode.com/svn/trunk@7197
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 17:16:51 +0000 (17:16 +0000)]
Separate our jsoncpp dependency from Chromium's jsoncpp overrides.
BUG=https://code.google.com/p/skia/issues/detail?id=909
Review URL: https://codereview.appspot.com/7098047
git-svn-id: http://skia.googlecode.com/svn/trunk@7187
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 15 Jan 2013 16:35:31 +0000 (16:35 +0000)]
Unreviewed mac build fix : Removing unused variable
git-svn-id: http://skia.googlecode.com/svn/trunk@7186
2bbb7eff-a529-9590-31e7-
b0007b416f81