pfeldman@chromium.org [Wed, 11 Apr 2012 08:38:33 +0000 (08:38 +0000)]
Web Inspector: fix category -> type refactoring implications.
https://bugs.webkit.org/show_bug.cgi?id=83680
Reviewed by Yury Semikhatsky.
We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):
* inspector/front-end/resourcesPanel.css:
(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 08:29:12 +0000 (08:29 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/Skipped: Skip failing ref test
* platform/gtk/test_expectations.txt: Mark two tests as crashing
and unskip tests needing rebaseline.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 11 Apr 2012 07:02:17 +0000 (07:02 +0000)]
[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83657
Reviewed by Martin Robinson.
Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 07:00:33 +0000 (07:00 +0000)]
Unreviewed, GTK rebaseline after r113756.
* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
* platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
* platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 11 Apr 2012 06:46:56 +0000 (06:46 +0000)]
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
* GNUmakefile.list.am: Ad missing files.
Source/WebCore:
* GNUmakefile.list.am: Add missing header file.
Source/WebKit2:
* GNUmakefile.am: Add missing header file.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 11 Apr 2012 06:26:39 +0000 (06:26 +0000)]
[chromium] Signedness issue with code informing v8 of PatternSkia memory use
https://bugs.webkit.org/show_bug.cgi?id=83642
Reviewed by James Robinson.
The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.
* platform/graphics/Pattern.h:
(Pattern):
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 05:39:23 +0000 (05:39 +0000)]
Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 11 Apr 2012 05:35:16 +0000 (05:35 +0000)]
[chromium] ImageBuffer minor style fix: remove compound declaration
https://bugs.webkit.org/show_bug.cgi?id=83660
Reviewed by Kent Tamura.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Wed, 11 Apr 2012 05:23:01 +0000 (05:23 +0000)]
Roll Chromium DEPS to last-known good revision
https://bugs.webkit.org/show_bug.cgi?id=83652
Unreviewed, just a DEPS roll (131469:131684)
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 04:58:33 +0000 (04:58 +0000)]
Add gesture event enums for long-press and pinch
https://bugs.webkit.org/show_bug.cgi?id=83640
Patch by Alexandre Elias <aelias@google.com> on 2012-04-10
Reviewed by James Robinson.
Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.
Source/WebCore:
No new tests. (No-op change.)
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/PlatformEvent.h:
Source/WebKit/chromium:
* public/WebInputEvent.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 11 Apr 2012 04:48:41 +0000 (04:48 +0000)]
Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html
markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.
For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
LayoutTests:
* fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
* fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Wed, 11 Apr 2012 04:19:01 +0000 (04:19 +0000)]
Prevent fallthrough to keep static analysis tools happy
https://bugs.webkit.org/show_bug.cgi?id=83639
Reviewed by Darin Adler.
No new tests - no new behaviour.
* css/LengthFunctions.cpp:
(WebCore::valueForLength):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 11 Apr 2012 04:15:37 +0000 (04:15 +0000)]
Don't expose the intrinsic padding concept to the code outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83380
Reviewed by Eric Seidel.
No new tests, refactoring only.
The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.
This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.
* rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Killed the enum paddingOptions!
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.
* rendering/RenderTableCell.h:
(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
Updated these functions after the renaming.
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 03:35:05 +0000 (03:35 +0000)]
TextureMapperGL.cpp breaks build with OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=83622
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.
Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 03:33:17 +0000 (03:33 +0000)]
Calendar Picker: Initialize CalendarPickerElement::m_popup
https://bugs.webkit.org/show_bug.cgi?id=83656
Reviewed by Hajime Morita.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement): Set 0 to m_popup.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 03:26:54 +0000 (03:26 +0000)]
CodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
https://bugs.webkit.org/show_bug.cgi?id=83623
Reviewed by Adam Barth.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Always emit toV8(PassRefPtr), as all wrapped types are RefCounted.
(GenerateImplementation): Always emit code for derefObject, as all wrapped types are RefCounted.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 03:02:10 +0000 (03:02 +0000)]
[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
https://bugs.webkit.org/show_bug.cgi?id=83653
Reviewed by Adrienne Walker.
This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCLayerTreeHostClient
- CCLayerTreeHostImplClient
- CCProxy
- LayerRendererChromiumClient
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/FakeCCLayerTreeHostClient.h:
* tests/LayerRendererChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Wed, 11 Apr 2012 02:59:54 +0000 (02:59 +0000)]
Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104
Source/WebCore:
PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.
The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem
This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8
We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.
It's possible that there's a lower layer fix available in V8 or the
bindings.
Reviewed by David Levin.
Test: storage/indexeddb/pending-version-change-on-exit.html
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.
LayoutTests:
Reviewed by David Levin.
* storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
* storage/indexeddb/pending-version-change-on-exit.html: Added.
* storage/indexeddb/resources/pending-version-change-on-exit.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 02:57:47 +0000 (02:57 +0000)]
Break the association between form controls and their owner when the owner leaves the tree
https://bugs.webkit.org/show_bug.cgi?id=81420
Reviewed by Kent Tamura.
Source/WebCore:
When parsing malformed markup, it's possible for a form and a
form-associated element to not be in an ancestor/descendant relationship.
When that form is later removed from the tree, the relationship needs to be updated.
Test: fast/forms/parser-associated-form-removal.html
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::formRemovedFromTree): New method called when
by the form when it's being removed: handles either resetting the
owner or storing a bit to optimize away a second walk up the tree.
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLFormElement.cpp:
(WebCore::findRoot): Simple helper method copied from FormAssociatedElement (this should probably live elsewhere).
(WebCore::HTMLFormElement::removedFromTree): Override removedFromTree to notify associated elements of the removal.
* html/HTMLFormElement.h:
(HTMLFormElement):
LayoutTests:
* fast/forms/parser-associated-form-removal-expected.txt: Added.
* fast/forms/parser-associated-form-removal.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 02:55:39 +0000 (02:55 +0000)]
[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
https://bugs.webkit.org/show_bug.cgi?id=83646
Reviewed by Adrienne Walker.
This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCFrameRateControllerClient
- CCSchedulerClient
- CCTimeSource
- CCTimeSourceClient
- CCTimerClient
Source/WebCore:
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* tests/CCSchedulerTest.cpp:
* tests/CCSchedulerTestCommon.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 02:51:03 +0000 (02:51 +0000)]
[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83529
Patch by David Alcala <dalcala@adobe.com> on 2012-04-10
Reviewed by Ryosuke Niwa.
* fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Added.
* platform/chromium-linux/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac-leopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 11 Apr 2012 02:49:54 +0000 (02:49 +0000)]
Attempt to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 11 Apr 2012 02:38:12 +0000 (02:38 +0000)]
If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799
Reviewed by Ojan Vafai.
The tests we were skipping in _mark_interrupted_tests_as_skipped
had incorrectly-constructed TestResults, and so they were not
being treated as failures. The JSON generator doesn't record
tests that are passed or skiped in incremental_results, so you
couldn't tell these tests were being skipped at all.
This change changes _mark_interrupted_tests_as_skipped() to
treat the skipped tests as failures; this is arguably still
incorrect but is minimally invasive for now. We probably need to
revisit how we are uploading information about tests that are
skipped and passed altogether in a separate change.
This change also cleans up a couple of other nits that were
unnecessary or broken in this same code path.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._mark_interrupted_tests_as_skipped):
(Manager._upload_json_files): Deletes the check for
chromium-mac-leopard (as it is no longer necessary).
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__): Here we were
recalculating the failure type unnecessarily.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
(FailureEarlyExit): Adds a new failure type so we can tell what
happened.
(FailureEarlyExit.message):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_exit_after_n_failures_upload): Add more checks to
ensure that we are recording the SKIP correctly; this is less
than ideal, because we can't actually test the contents of
incremental_results.json. We should fix that at some point.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 02:27:01 +0000 (02:27 +0000)]
Add a function to set empty clients to a PageClients
https://bugs.webkit.org/show_bug.cgi?id=83555
Reviewed by Adam Barth.
No new tests because of no behavior change.
* CMakeLists.txt: Add EmptyClients.cpp.
* GNUmakefile.list.am: ditto.
* Target.pri: ditto.
* WebCore.gypi: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* loader/EmptyClients.cpp: Added.
(WebCore::fillWithEmptyClients): Some code was moved from SVGImage::dataChanged().
* loader/EmptyClients.h: Add the declaration of fillWithEmptyClients().
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged): Moved some code to fillWithEmptyClients().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Wed, 11 Apr 2012 02:19:47 +0000 (02:19 +0000)]
[EFL] Garden fast/{backgrounds,dynamic,encoding}.
* platform/efl/fast/backgrounds/svg-as-mask-expected.txt:
* platform/efl/fast/dynamic/002-expected.png:
* platform/efl/fast/dynamic/004-expected.png:
* platform/efl/fast/dynamic/006-expected.png:
* platform/efl/fast/dynamic/012-expected.png:
* platform/efl/fast/dynamic/015-expected.png:
* platform/efl/fast/dynamic/anchor-lock-expected.txt:
* platform/efl/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
* platform/efl/fast/dynamic/containing-block-change-expected.png:
* platform/efl/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
* platform/efl/fast/dynamic/float-withdrawal-expected.png:
* platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/efl/fast/dynamic/noninlinebadness-expected.png:
* platform/efl/fast/dynamic/outerHTML-doc-expected.png:
* platform/efl/fast/dynamic/outerHTML-img-expected.png:
* platform/efl/fast/dynamic/selection-highlight-adjust-expected.png:
* platform/efl/fast/dynamic/staticY-marking-parents-regression-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/dynamic/view-overflow-expected.png:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/efl/fast/encoding/invalid-UTF-8-expected.png:
* platform/efl/fast/encoding/utf-16-big-endian-expected.png:
* platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
* platform/efl/fast/encoding/utf-16-little-endian-expected.png:
* platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
* platform/efl/fast/encoding/xmacroman-encoding-test-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 02:13:42 +0000 (02:13 +0000)]
[chromium] Fold LayerChromium::updateCompositorResources into main update
https://bugs.webkit.org/show_bug.cgi?id=83530
Reviewed by Adrienne Walker.
Source/WebCore:
We used to update layer contents in two phases. The first, called paintContentsIfDirty() /
idlePaintContentsIfDirty(), ran on the main WebKit thread and took care of any main-thread work - primarily
WebCore painting as the name implies. The second, called updateCompositorResources(), ran on the compositor
thread with the main thread blocked and took care of any actions that required direct access to the compositor's
context - such as texture uploads into compositor-managed textures. Now that all compositor texture operations
are queued on a CCTextureUpdater, the compositor can take care of these operations on the correct thread at the
right time without needing layer-specific logic.
This folds both functions into one function called LayerChromium::update() (and idleUpdate() for idle
prepainting) and adds a CCTextureUpdater reference for queuing up texture operations.
The CCProxy is responsible for the lifetime of the CCTextureUpdater. In the threaded proxy, the updater is
tied to the lifetime of the beginFrame operation. Specifically it's constructed on the impl thread when the
beginFrame message is generated, is accessed by reference on the main thread during the commit, and then
destroyed by the proxy when the commit is complete. CCTextureUpdater::update should only be called on the impl
thread by the proxy. In the future, it might be worth exposing a more limited interface to layers.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::update):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::idleUpdate):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateLayerRect):
(WebCore::ImageLayerChromium::update):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::update):
(WebCore::LayerChromium::idleUpdate):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::update):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::update):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
Source/WebKit/chromium:
Update tests for interface changes.
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::runTest):
(WTF::ContentLayerChromiumWithUpdateTracking::update):
(WTF::ContentLayerChromiumWithUpdateTracking::idleUpdate):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::TestLayerChromium::update):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::updateLayerRect):
(WebKitTests::FakeTiledLayerChromium::update):
* tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF::idlePaintRepeat):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 11 Apr 2012 02:07:33 +0000 (02:07 +0000)]
fast/forms/implicit-submission.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=39056
Speed up the test by removing unnecessary iframe and navigation,
make it less flaky by removing timeouts.
Reviewed by Hajime Morita.
* fast/forms/implicit-submission.html: Deflakified and sped up.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Wed, 11 Apr 2012 02:05:05 +0000 (02:05 +0000)]
[EFL] Garden fast/css.
Account for some changes related to the jhbuild and font commits
and adjust some wrong results with fonts that are too big.
* platform/efl/fast/css/001-expected.png:
* platform/efl/fast/css/003-expected.png:
* platform/efl/fast/css/004-expected.png:
* platform/efl/fast/css/005-expected.png:
* platform/efl/fast/css/MarqueeLayoutTest-expected.png:
* platform/efl/fast/css/ZeroOpacityLayers-expected.png:
* platform/efl/fast/css/ZeroOpacityLayers2-expected.png:
* platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.png:
* platform/efl/fast/css/acid2-pixel-expected.png:
* platform/efl/fast/css/apple-prefix-expected.png:
* platform/efl/fast/css/begin-end-contain-selector-empty-value-expected.png:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/efl/fast/css/border-radius-outline-offset-expected.png:
* platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png:
* platform/efl/fast/css/color-correction-expected.png:
* platform/efl/fast/css/color-correction-on-text-expected.png:
* platform/efl/fast/css/compare-content-style-expected.png:
* platform/efl/fast/css/continuationCrash-expected.png:
* platform/efl/fast/css/create_element_align-expected.png:
* platform/efl/fast/css/css-imports-expected.png:
* platform/efl/fast/css/css1_forward_compatible_parsing-expected.png:
* platform/efl/fast/css/css2-system-fonts-expected.png:
* platform/efl/fast/css/css3-modsel-22-expected.png:
* platform/efl/fast/css/css3-nth-child-expected.png:
* platform/efl/fast/css/css3-space-in-nth-and-lang-expected.png:
* platform/efl/fast/css/empty-pseudo-class-expected.png:
* platform/efl/fast/css/error-in-last-decl-expected.png:
* platform/efl/fast/css/ex-after-font-variant-expected.png:
* platform/efl/fast/css/fieldset-display-row-expected.png:
* platform/efl/fast/css/find-next-layer-expected.png:
* platform/efl/fast/css/first-child-pseudo-class-expected.png:
* platform/efl/fast/css/first-letter-capitalized-expected.png:
* platform/efl/fast/css/first-letter-detach-expected.png:
* platform/efl/fast/css/first-letter-float-after-float-expected.png:
* platform/efl/fast/css/first-letter-float-expected.png:
* platform/efl/fast/css/first-letter-hover-expected.png:
* platform/efl/fast/css/first-letter-punctuation-expected.png:
* platform/efl/fast/css/first-letter-recalculation-expected.png:
* platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png:
* platform/efl/fast/css/first-letter-visibility-expected.png:
* platform/efl/fast/css/first-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/focus-ring-detached-expected.png:
* platform/efl/fast/css/focus-ring-multiline-expected.png:
* platform/efl/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
* platform/efl/fast/css/focus-ring-outline-offset-expected.png:
* platform/efl/fast/css/font-face-implicit-local-font-expected.png:
* platform/efl/fast/css/font-face-locally-installed-expected.png:
* platform/efl/fast/css/font-face-multiple-faces-expected.png:
* platform/efl/fast/css/font-face-unicode-range-expected.png:
* platform/efl/fast/css/font-weight-1-expected.png:
* platform/efl/fast/css/font_property_normal-expected.png:
* platform/efl/fast/css/h1-in-section-elements-expected.png:
* platform/efl/fast/css/hover-subselector-expected.png:
* platform/efl/fast/css/hsl-color-expected.png:
* platform/efl/fast/css/import-rule-regression-11590-expected.png:
* platform/efl/fast/css/import-rule-regression-11590-expected.txt:
* platform/efl/fast/css/inline-element-line-break-expected.png:
* platform/efl/fast/css/inline-element-line-break-expected.txt:
* platform/efl/fast/css/inline-properties-important-expected.png:
* platform/efl/fast/css/inline-properties-important-expected.txt:
* platform/efl/fast/css/invalid-percentage-property-expected.png:
* platform/efl/fast/css/invalid-percentage-property-expected.txt:
* platform/efl/fast/css/invalidation-errors-2-expected.png:
* platform/efl/fast/css/invalidation-errors-2-expected.txt:
* platform/efl/fast/css/invalidation-errors-3-expected.png:
* platform/efl/fast/css/invalidation-errors-3-expected.txt:
* platform/efl/fast/css/invalidation-errors-expected.png:
* platform/efl/fast/css/invalidation-errors-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.png:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/layerZOrderCrash-expected.png:
* platform/efl/fast/css/layerZOrderCrash-expected.txt:
* platform/efl/fast/css/line-height-expected.png:
* platform/efl/fast/css/line-height-expected.txt:
* platform/efl/fast/css/line-height-overflow-expected.png:
* platform/efl/fast/css/line-height-overflow-expected.txt:
* platform/efl/fast/css/list-outline-expected.png:
* platform/efl/fast/css/list-outline-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-quirk-expected.png:
* platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-strict-expected.png:
* platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/efl/fast/css/namespaces/004-expected.png:
* platform/efl/fast/css/namespaces/005-expected.png:
* platform/efl/fast/css/namespaces/namespaces-comments-expected.png:
* platform/efl/fast/css/namespaces/namespaces-empty-expected.png:
* platform/efl/fast/css/namespaces/namespaces-escapes-expected.png:
* platform/efl/fast/css/namespaces/namespaces-invalid-at-expected.png:
* platform/efl/fast/css/negative-leading-expected.png:
* platform/efl/fast/css/negative-leading-expected.txt:
* platform/efl/fast/css/negative-nth-child-expected.png:
* platform/efl/fast/css/negative-nth-child-expected.txt:
* platform/efl/fast/css/nested-floating-relative-position-percentages-expected.png:
* platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
* platform/efl/fast/css/nested-layers-with-hover-expected.png:
* platform/efl/fast/css/nested-layers-with-hover-expected.txt:
* platform/efl/fast/css/nested-rounded-corners-expected.png:
* platform/efl/fast/css/nth-child-dynamic-expected.png:
* platform/efl/fast/css/nth-child-dynamic-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.png:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/outline-auto-location-expected.png:
* platform/efl/fast/css/outline-auto-location-expected.txt:
* platform/efl/fast/css/outline-narrowLine-expected.png:
* platform/efl/fast/css/outline-narrowLine-expected.txt:
* platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.png:
* platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
* platform/efl/fast/css/percentage-non-integer-expected.png:
* platform/efl/fast/css/percentage-non-integer-expected.txt:
* platform/efl/fast/css/positioned-overflow-scroll-expected.png:
* platform/efl/fast/css/pseudo-element-line-break-expected.png:
* platform/efl/fast/css/pseudo-element-line-break-expected.txt:
* platform/efl/fast/css/pseudo-first-line-border-width-expected.png:
* platform/efl/fast/css/pseudo-first-line-border-width-expected.txt: Added.
* platform/efl/fast/css/quirk-orphaned-units-expected.png:
* platform/efl/fast/css/quirk-orphaned-units-expected.txt:
* platform/efl/fast/css/resize-corner-tracking-expected.png:
* platform/efl/fast/css/resize-corner-tracking-expected.txt:
* platform/efl/fast/css/resize-corner-tracking-transformed-expected.png:
* platform/efl/fast/css/resize-corner-tracking-transformed-expected.txt:
* platform/efl/fast/css/rtl-ordering-expected.png:
* platform/efl/fast/css/rtl-ordering-expected.txt:
* platform/efl/fast/css/selector-set-attribute-expected.png:
* platform/efl/fast/css/selector-set-attribute-expected.txt:
* platform/efl/fast/css/table-text-align-quirk-expected.png:
* platform/efl/fast/css/table-text-align-quirk-expected.txt:
* platform/efl/fast/css/table-text-align-strict-expected.png:
* platform/efl/fast/css/table-text-align-strict-expected.txt:
* platform/efl/fast/css/text-align-expected.png:
* platform/efl/fast/css/text-align-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
* platform/efl/fast/css/text-security-expected.png:
* platform/efl/fast/css/text-security-expected.txt:
* platform/efl/fast/css/text-transform-select-expected.png:
* platform/efl/fast/css/text-transform-select-expected.txt:
* platform/efl/fast/css/textCapitalizeEdgeCases-expected.png:
* platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
* platform/efl/fast/css/transformed-mask-expected.png:
* platform/efl/fast/css/transformed-mask-expected.txt:
* platform/efl/fast/css/universal-hover-quirk-expected.png:
* platform/efl/fast/css/universal-hover-quirk-expected.txt:
* platform/efl/fast/css/value-list-out-of-bounds-crash-expected.png:
* platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
* platform/efl/fast/css/word-space-extra-expected.png:
* platform/efl/fast/css/word-space-extra-expected.txt:
* platform/efl/fast/css/zoom-font-size-expected.png:
* platform/efl/fast/css/zoom-font-size-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 01:57:03 +0000 (01:57 +0000)]
Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
https://bugs.webkit.org/show_bug.cgi?id=83615
Reviewed by Adam Barth.
Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).
No new tests, no expected change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GetDomMapName):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
* bindings/v8/DOMDataStore.h:
(DOMDataStore):
* bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
(StaticDOMDataStore):
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjects):
* bindings/v8/V8DOMMap.h:
(WebCore):
* bindings/v8/V8DOMWrapper.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 11 Apr 2012 01:46:49 +0000 (01:46 +0000)]
[Qt] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83132
Reviewed by Noam Rosenthal.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests, refactoring only, covered by existing canvas tests.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::encodeImage): Output the encoded image to the provided QByteArray.
(WebCore):
(WebCore::ImageBuffer::toDataURL) Format the dataURL encoding of the mimeType
encoded image data here. Clarify the comment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 11 Apr 2012 01:45:09 +0000 (01:45 +0000)]
make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=83401
Reviewed by Adam Barth.
Last patch in the series - no longer look in mac-leopard,
mac-snowleopard, or mac-lion.
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 11 Apr 2012 01:39:23 +0000 (01:39 +0000)]
Build fix for WinCE after r113730.
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 11 Apr 2012 01:37:47 +0000 (01:37 +0000)]
webkit-patch: add a print-expectations command
https://bugs.webkit.org/show_bug.cgi?id=83347
Reviewed by Adam Barth.
This command will print the expected results for a given set of
tests on a given set of ports matching a given set of keywords.
Example output (printing all the tests not expected to pass, and their
expected results, on a Mac):
$ webkit-patch print-expectations -x pass fast/html
// For mac-snowleopard
fast/html/details-open4.html = TEXT
fast/html/details-open2.html = TEXT
fast/html/details-no-summary4.html = TEXT
fast/html/details-open-javascript.html = TEXT
$
You can also print full test-expectatons.txt lines using --full and a
CSV-style report (which can be useful for post-processing) using --csv.
It will replace the 'skipped-files' command (which will be
removed in a subsequent patch) and is a more general (and
cleaner and properly layered) solution.
Also add an update() command to MockOptions() to make overriding keywords easier.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationSerializer.to_string):
(TestExpectationSerializer):
(TestExpectationSerializer.to_csv):
(TestExpectationSerializer._format_result):
(TestExpectationLine.create_passing_expectation):
(TestExpectationsModel.get_test_set_for_keyword):
(TestExpectationsModel.has_keyword):
(TestExpectations.model):
* Scripts/webkitpy/tool/commands/queries.py:
(execute):
(PrintExpectations):
(PrintExpectations.__init__):
(PrintExpectations.execute):
(PrintExpectations._filter_tests):
(PrintExpectations._format_lines):
(PrintExpectations._model):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(TestPrintExpectations): Added.
* Scripts/webkitpy/tool/mocktool.py:
(MockOptions):
(MockOptions.__init__):
(MockOptions.update): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 11 Apr 2012 01:30:24 +0000 (01:30 +0000)]
webkitpy: refactor handling of --platform and related options
https://bugs.webkit.org/show_bug.cgi?id=83525
Reviewed by Adam Barth.
This change moves to centralize handling of --platform, --debug,
--gtk, and other similar flags into a central place next to the
code that actually uses those flags in PortFactory to get the
right Port object.
* Scripts/webkitpy/layout_tests/port/__init__.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
(port_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 11 Apr 2012 01:24:07 +0000 (01:24 +0000)]
<rdar://problem/
10583749> WebKit2 should log to both ASL and stderr
Source/WebKit2:
Replace direct calls to fprintf stderr with calls to WTFLogAlways.
Reviewed by Sam Weinig.
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
(readSandboxProfile):
(WKN_EnterSandbox):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
Source/WTF:
Reviewed by Sam Weinig.
* wtf/Assertions.cpp: Add a WTFLogAlways function that unconditionally logs the given message.
* wtf/Assertions.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 01:15:30 +0000 (01:15 +0000)]
Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/
Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.
https://bugs.webkit.org/show_bug.cgi?id=80200
Patch by Greg Billock <gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.
* Modules/intents/Intent.cpp:
(WebCore::Intent::create):
* Modules/intents/Intent.idl:
* WebCore.gypi:
* bindings/v8/custom/V8IntentCustom.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 11 Apr 2012 01:09:07 +0000 (01:09 +0000)]
Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431
Reviewed by Eric Seidel.
The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.
Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.
Source/JavaScriptCore:
* config.h:
Source/WebCore:
* config.h:
Source/WTF:
* config.h:
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 11 Apr 2012 00:56:02 +0000 (00:56 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
* platform/chromium-mac/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 00:37:04 +0000 (00:37 +0000)]
DFG should flush SetLocals to arguments
https://bugs.webkit.org/show_bug.cgi?id=83554
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This is necessary to match baseline JIT argument capture behavior.
But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.
Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.
Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArgumentPosition.h: Added.
(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGDoubleFormatState.h: Added.
(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):
Source/WTF:
Reviewed by Gavin Barraclough.
Added an isRoot() method that is a faster shorthand for saying
find() == this.
* wtf/UnionFind.h:
(WTF::UnionFind::isRoot):
(UnionFind):
LayoutTests:
Rubber stamped by Gavin Barraclough.
Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.
* fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-double.html: Added.
* fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-int32.html: Added.
* fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset-changetype.html: Added.
* fast/js/dfg-inline-arguments-reset-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset.html: Added.
* fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 11 Apr 2012 00:17:42 +0000 (00:17 +0000)]
Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
As recommended by David Hyatt in
<https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).
As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive. These prefixes appear to be needed
for a number of dashboard widgets. For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).
This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.
* Configurations/FeatureDefines.xcconfig:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
* features.gypi:
WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
* win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
https://bugs.webkit.org/show_bug.cgi?id=83256
Reviewed by Eric Seidel.
Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 00:15:36 +0000 (00:15 +0000)]
Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389
Reviewed by Kentaro Hara.
Source/JavaScriptCore:
* JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.
Source/WTF:
NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.
If someone decides they need this later, they can always revert this patch.
* wtf/PassRefPtr.h:
* wtf/RefPtr.h:
(RefPtr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 11 Apr 2012 00:09:45 +0000 (00:09 +0000)]
Unreviewed build fix after r113791.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 10 Apr 2012 23:44:26 +0000 (23:44 +0000)]
Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604
Reviewed by Julien Chaffraix.
Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.
Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.
No new tests. No change in behavior.
* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.
* editing/RenderedPosition.h:
(RenderedPosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 10 Apr 2012 23:40:51 +0000 (23:40 +0000)]
Initial support for fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786
Reviewed by Noam Rosenthal.
.:
* ManualTests/fixed-position.html: Added.
Source/WebCore:
When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.
* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
Source/WebKit2:
Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.
* Shared/WebLayerTreeInfo.h:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::updateSize):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 10 Apr 2012 23:34:52 +0000 (23:34 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
* platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
* platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
* platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 10 Apr 2012 23:16:06 +0000 (23:16 +0000)]
Remove empty directories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 10 Apr 2012 23:10:20 +0000 (23:10 +0000)]
Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
https://bugs.webkit.org/show_bug.cgi?id=83401
Unreviewed, baseline shuffling.
* platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
* platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
* platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
* platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
* platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
* platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
* platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
* platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
* platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 10 Apr 2012 22:59:52 +0000 (22:59 +0000)]
Add a chromeless view to the individual tests view
https://bugs.webkit.org/show_bug.cgi?id=83541
Reviewed by Daniel Bates.
This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 10 Apr 2012 22:59:04 +0000 (22:59 +0000)]
[CMake] Do not pass -P to the preprocessor when running make_names.pl.
https://bugs.webkit.org/show_bug.cgi?id=83225
Reviewed by Rob Buis.
This is necessary to make CMake-based ports build with the
recently-released GCC 4.7.0, whose preprocessor seems to ignore
empty lines when -P is passed to it. Such behavior breaks
make_names.pl (in fact, InFilesParser.pm), which expects an empty
line to separate common and specific sections in .in files.
A fix for this same problem has been supposedly done in r84123,
but as the CMake-based ports always pass --preprocessor to the
Perl tools the fix never reached us.
The idea is to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS
for (!MSVC && !QNX) and use it in the macros which call
make_names.pl.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitMacros.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 10 Apr 2012 22:52:42 +0000 (22:52 +0000)]
Unreviewed update to test expectations
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 10 Apr 2012 22:41:33 +0000 (22:41 +0000)]
[Chromium] Fix test_expectations.txt from r113776.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:39:39 +0000 (22:39 +0000)]
Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types
https://bugs.webkit.org/show_bug.cgi?id=83390
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-10
Reviewed by Yury Semikhatsky.
Intermediate classes InspectorObjectBase and InspectorArrayBase are created. They have all raw methos
protected. InspectorObject and InspectorArray now inherit the corresponding base classes with exposing
all their protected methods.
"Open types" are left inheriting from InspectorObject, plus field name constants are generated for
an easy random access to all properties.
All the client code is fixed to use type-safe API rather than raw access methods in function parameter
and return types and bodies.
* inspector/CodeGeneratorInspector.py:
(RawTypes.Object):
(RawTypes.Object.get_setter_name):
(RawTypes.Array):
(RawTypes.Array.get_setter_name):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Array):
(Generator):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator.process_types.GenerateContext):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didPause):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::styleWithProperties):
* inspector/InspectorValues.cpp:
(WebCore::InspectorObjectBase::~InspectorObjectBase):
(WebCore::InspectorObjectBase::asObject):
(WebCore::InspectorObjectBase::openAccessors):
(WebCore):
(WebCore::InspectorObjectBase::getBoolean):
(WebCore::InspectorObjectBase::getString):
(WebCore::InspectorObjectBase::getObject):
(WebCore::InspectorObjectBase::getArray):
(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::remove):
(WebCore::InspectorObjectBase::writeJSON):
(WebCore::InspectorObjectBase::InspectorObjectBase):
(WebCore::InspectorArrayBase::~InspectorArrayBase):
(WebCore::InspectorArrayBase::asArray):
(WebCore::InspectorArrayBase::writeJSON):
(WebCore::InspectorArrayBase::InspectorArrayBase):
(WebCore::InspectorArrayBase::get):
* inspector/InspectorValues.h:
(InspectorObjectBase):
(InspectorObject):
(WebCore::InspectorObject::create):
(WebCore):
(InspectorArrayBase):
(WebCore::InspectorArrayBase::length):
(InspectorArray):
(WebCore::InspectorArray::create):
(WebCore::InspectorObjectBase::find):
(WebCore::InspectorObjectBase::setBoolean):
(WebCore::InspectorObjectBase::setNumber):
(WebCore::InspectorObjectBase::setString):
(WebCore::InspectorObjectBase::setValue):
(WebCore::InspectorObjectBase::setObject):
(WebCore::InspectorObjectBase::setArray):
(WebCore::InspectorArrayBase::pushBoolean):
(WebCore::InspectorArrayBase::pushInt):
(WebCore::InspectorArrayBase::pushNumber):
(WebCore::InspectorArrayBase::pushString):
(WebCore::InspectorArrayBase::pushValue):
(WebCore::InspectorArrayBase::pushObject):
(WebCore::InspectorArrayBase::pushArray):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:37:59 +0000 (22:37 +0000)]
[Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes
https://bugs.webkit.org/show_bug.cgi?id=82757
Patch by Tim Dresser <tdresser@chromium.org> on 2012-04-10
Reviewed by Darin Fisher.
If there is no viewport tag, the deviceScaleFactor is set to the defaultDeviceScaleFactor.
Tested by: WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag.
* src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:
(WebKit):
(FixedLayoutTestWebViewClient):
(WebKit::TEST_F):
* tests/data/no_viewport_tag.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 10 Apr 2012 22:36:48 +0000 (22:36 +0000)]
Remove unnecessary calls to RenderSVGShape::createShape()
https://bugs.webkit.org/show_bug.cgi?id=83598
Reviewed by Rob Buis.
RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.
No new tests as this only affects performance, not test results.
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 10 Apr 2012 22:33:40 +0000 (22:33 +0000)]
<rdar://problem/
10912486> CanvasRenderingContext2D does not expose its backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83619
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/canvas/2d.backingStorePixelRatio.html
Added a backingStorePixelRatio attribute to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The attribute
is prefixed with “webkit” for now.
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::deviceScaleFactor): Added this getter.
* html/canvas/CanvasRenderingContext2D.h:
(WebCore::CanvasRenderingContext2D::webkitBackingStorePixelRatio): Added. Returns the canvas
element’s device scale factor.
(CanvasRenderingContext2D):
* html/canvas/CanvasRenderingContext2D.idl: Added webkitBackingStorePixelRatio as a
read-only attribute.
LayoutTests:
* fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
* fast/canvas/2d.backingStorePixelRatio.html: Added.
* platform/mac/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
* platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 10 Apr 2012 22:26:47 +0000 (22:26 +0000)]
[EFL][DRT] Top level SVG rebaselines
https://bugs.webkit.org/show_bug.cgi?id=83585
Unreviewed, EFL rebaseline.
Landing bug 83562 enables us to do a bigger rebaselining and
unskipping of EFL SVG testcases. This is part one.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
* platform/efl/Skipped:
* platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
* platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
* platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/efl/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/efl/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 22:24:16 +0000 (22:24 +0000)]
Segmentation fault in JS drop-down menus in facebook.com
https://bugs.webkit.org/show_bug.cgi?id=82896
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-04-10
Reviewed by Chris Fleizach.
Make sure changes introduced with r110819 affect to the Mac
platform only, since they depend on platform specific behaviour,
as not all the platforms treat attachments in the same way.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::detachFromParent):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::detachFromParent):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 22:18:16 +0000 (22:18 +0000)]
Fix fast/images/exif-orientation.html WebKitTestRunner failure
https://bugs.webkit.org/show_bug.cgi?id=83627
Reviewed by Sam Weinig.
Handle overriding the WebKitShouldRespectImageOrientation preference.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 10 Apr 2012 22:17:14 +0000 (22:17 +0000)]
Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624
Add failing tests to skipped list.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 10 Apr 2012 22:15:30 +0000 (22:15 +0000)]
remove 'win' from chromium-win, chromium-linux fallback paths
https://bugs.webkit.org/show_bug.cgi?id=83613
Reviewed by Ojan Vafai.
The chromium ports no longer need to look at the apple 'win'
directory for baseline results.
Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Tue, 10 Apr 2012 21:57:51 +0000 (21:57 +0000)]
REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter.
<http://webkit.org/b/83540>
Reviewed by Antti Koivisto.
Changed the behavior of getPropertyCSSValueInternal() to actually return the internal
value rather than a cloned one. There is an assertion in the CSSValue bindings that
will catch anyone trying to expose these values to the web.
This avoids constructing "safe" CSSValue objects in the bindings layer, for the cases
where we only want to extract the cssText or numeric value. These cloned objects are
only needed when exposing fully-fledged CSSValues to the web, which must be tied to
a single document.
* css/CSSStyleDeclaration.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 10 Apr 2012 21:52:39 +0000 (21:52 +0000)]
[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675
Source/WebCore:
Added WebCore::GraphicsSurface, a wrapper class to a platform-dependant
surface that can be accessed efficiently by both the CPU and the GPU.
This will allow fast texture uploads for WebKit2, and in the future
fast copies for 2D canvas and WebGL.
The first implementation is for Mac using IOSurfaces.
TextureMapperGL had to be modified to use GL_UNSIGNED_INT_8_8_8_8_REV
for textures on Mac, since that's the native pixel format of BGRA
IOSurfaces.
Though this feature is not written in a Qt-specific way, it's currently
only enabled for Qt and is protected by USE(GRAPHICS_SURFACE).
Reviewed by Kenneth Rohde Christiansen.
Covered by existing API tests.
* Target.pri:
* WebCore.pri:
* platform/graphics/surfaces/GraphicsSurface.cpp: Added.
* platform/graphics/surfaces/GraphicsSurface.h: Added.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: Added.
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp: Added.
(WebCore::GraphicsSurface::didReleaseImage):
(WebCore):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::isOpenGLBacked):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::toBitmapTextureGL):
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::BitmapTextureGL::isOpenGLBacked):
(WebCore):
Source/WebKit2:
Added ShareableSurface, a class allowing the use of GPU-enabled
surfaces for bitmap transfer between the web and UI processes.
Since GraphicsSurfaces may not always be available, ShareableSurface
uses a standard ShareableBitmap as a fallback backend.
The necessary plumbing was added in WebKit2 for passing updates via
ShareableSurfaces instead of ShareableBitmaps. SurfaceUpdateInfo was
added, as to not make UpdateInfo more complicated.
Reviewed by Kenneth Rohde Christiansen.
* Shared/ShareableSurface.cpp: Added.
* Shared/ShareableSurface.h: Added.
* Shared/SurfaceUpdateInfo.cpp: Added.
* Shared/SurfaceUpdateInfo.h: Added.
* Target.pri:
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::updateTile):
* UIProcess/WebLayerTreeRenderer.h:
(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):
* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::updateTile):
* UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
(LayerBackingStore):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
(WebKit):
(TiledBackingStoreRemoteTileClient):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(WebKit::UpdateAtlas::surface):
(WebKit::UpdateAtlas::size):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::beginContentUpdate):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
Tools:
Enable graphics surfaces on Mac for Qt.
Reviewed by Kenneth Rohde Christiansen.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 21:52:13 +0000 (21:52 +0000)]
Add fast/dom/inline-event-attributes-release.html to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:45:35 +0000 (21:45 +0000)]
Web Inspector: split nodes and edges array in heap profiler serialization.
https://bugs.webkit.org/show_bug.cgi?id=83465
Frontend is now able to read format when nodes and edges arrive
in two separate arrays.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-10
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseIntArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
LayoutTests:
* inspector/profiler/heap-snapshot-loader-expected.txt:
* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:41:08 +0000 (21:41 +0000)]
CSS box-shadow default color should be something other than transparent
https://bugs.webkit.org/show_bug.cgi?id=58511
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-10
Reviewed by Simon Fraser.
Source/WebCore:
If box-shadow or text-shadow color is not specified, color defaults to
the value specified in the 'color' property of the element (as specified in W3C
spec).
Test: fast/text/text-shadow-no-default-color.html. Also existing
tests ietestcenter/css3/box-shadow-002 and ietestcenter/css3/box-shadow-003
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
Added new test for the case where no color is specified for text
shadow. This test and two others are marked as expected fail pending
rebaseline.
* fast/text/text-shadow-no-default-color.html: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 10 Apr 2012 21:28:57 +0000 (21:28 +0000)]
AudioParam must support connections from audio-rate signals
https://bugs.webkit.org/show_bug.cgi?id=83524
Source/WebCore:
Reviewed by Eric Carlson.
In the Web Audio API, it's possible to connect one AudioNode to another AudioNode.
Similary we should allow an AudioNode to connect to an AudioParam, thus controlling
a parameter with an audio-rate signal. This is important in many audio processing
applications.
Test: webaudio/audioparam-connect-audioratesignal.html
Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().
* Modules/webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::process):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect): Add connect() method from AudioNode -> AudioParam.
(WebCore):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::finishDeref):
Use AudioNodeOutput::disconnectAll() instead of AudioNodeOutput::disconnectAllInputs().
* Modules/webaudio/AudioNode.h: Add connect() method from AudioNode -> AudioParam.
(WebCore):
(AudioNode):
* Modules/webaudio/AudioNode.idl: Add connect() method from AudioNode -> AudioParam.
Implement support for an AudioNodeOutput to fanout to multiple AudioParams.
* Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateRenderingState): Update rendering state related to AudioParams.
(WebCore::AudioNodeOutput::pull): pull() must now take into account fanout to AudioParams for in-place processing.
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore):
(WebCore::AudioNodeOutput::paramFanOutCount): New method keeping track of number of connections to AudioParams.
(WebCore::AudioNodeOutput::renderingParamFanOutCount): New method keeping track of number of connections to AudioParams for rendering.
(WebCore::AudioNodeOutput::addParam): Add a connection to an AudioParam.
(WebCore::AudioNodeOutput::removeParam): Remove a connection to an AudioParam.
(WebCore::AudioNodeOutput::disconnectAllParams): Remove all connections to AudioParams.
(WebCore::AudioNodeOutput::disconnectAll): New method to disconnect all AudioNodeInputs and AudioParams.
* Modules/webaudio/AudioNodeOutput.h:
(AudioNodeOutput):
Allow an AudioParam to accept a connection from an AudioNodeOutput, thus being controlled
by an audio-rate signal.
* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateSampleAccurateValues): Calculates sample-accurate values from timeline or an AudioNode.
(WebCore):
(WebCore::AudioParam::calculateAudioRateSignalValues): Calculates sample-accurate values from an AudioNode.
(WebCore::AudioParam::calculateTimelineValues): Calculates sample-accurate values scheduled on the timeline.
(WebCore::AudioParam::connect): Connect from an AudioNodeOutput for control from an audio-rate signal.
(WebCore::AudioParam::disconnect): Disconnect from an AudioNodeOutput.
* Modules/webaudio/AudioParam.h:
(WebCore):
(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::hasSampleAccurateValues): Change name from hasTimelineValues() and return true
either if we have timeline values or if we've been connected from an AudioNode.
(AudioParam):
Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().
* Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):
LayoutTests:
Reviewed by Eric Carlson.
* webaudio/audioparam-connect-audioratesignal-expected.txt: Added.
* webaudio/audioparam-connect-audioratesignal.html: Added.
* webaudio/resources/audio-testing.js:
(createLinearRampBuffer):
(createConstantBuffer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:16:54 +0000 (21:16 +0000)]
[CMake][WIN] Add /MP flag when using a compiler with support for it
https://bugs.webkit.org/show_bug.cgi?id=83577
Reviewed by Daniel Bates.
* Source/cmake/OptionsWindows.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:14:45 +0000 (21:14 +0000)]
[CMake] Add missing DERIVED_SOURCES_WEBKIT_DIR variable
https://bugs.webkit.org/show_bug.cgi?id=83573
Reviewed by Daniel Bates.
We need this variable when ports want to generate files in the WebKit target.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 10 Apr 2012 21:12:14 +0000 (21:12 +0000)]
Remove unused data member from Lexer class
https://bugs.webkit.org/show_bug.cgi?id=83429
Reviewed by Kentaro Hara.
I noticed that m_delimited was "write-only", so I deleted it.
* parser/Lexer.cpp:
(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.
* parser/Lexer.h: Deleted m_delimited.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 10 Apr 2012 21:07:26 +0000 (21:07 +0000)]
[CMake] Enable USE_FOLDERS property
https://bugs.webkit.org/show_bug.cgi?id=83571
Reviewed by Daniel Bates.
.:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
* shell/CMakeLists.txt:
Source/WebCore:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WebKit:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WebKit2:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* CMakeLists.txt:
Source/WTF:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* wtf/CMakeLists.txt:
Tools:
Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.
* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* WinCELauncher/CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 21:05:26 +0000 (21:05 +0000)]
[CMake] CMake SVG Code Generation fails to generate code for extra defines
https://bugs.webkit.org/show_bug.cgi?id=83562
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
Reviewed by Rob Buis.
Fixing CMakeLists.txt to generate correct extra defines for SVG code generator.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 10 Apr 2012 20:32:16 +0000 (20:32 +0000)]
Crash due to captions list not updated after section recalc.
https://bugs.webkit.org/show_bug.cgi?id=83552
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: fast/table/table-caption-not-removed-crash.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): no need to set the need for
section recalc. It was needed in old code when we had more than
one caption and we need to call section recalc to destroy the other
captions.
(WebCore::RenderTable::recalcSections): need to rebuild captions list.
This is how the old code worked before r100177. Basically, children can
moved without calling RenderTable::removeChild, so we should depend on
recalcSections to update our captions list. Also, fix a style nit of aligning
case labels with the switch statement.
LayoutTests:
* fast/table/table-caption-not-removed-crash-expected.txt: Added.
* fast/table/table-caption-not-removed-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:55:18 +0000 (19:55 +0000)]
[BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=83567
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-10
Reviewed by Antonio Gomes.
Fixed by checking if there's a layer renderer before calling into it.
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 19:48:06 +0000 (19:48 +0000)]
Unreviewed, rolling out r113611.
http://trac.webkit.org/changeset/113611
https://bugs.webkit.org/show_bug.cgi?id=71541
Broke fast/forms/basic-textareas.html
Source/WebCore:
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
LayoutTests:
* fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Removed.
* fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Removed.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:45:47 +0000 (19:45 +0000)]
Unreviewed, rolling out r113734.
http://trac.webkit.org/changeset/113734
https://bugs.webkit.org/show_bug.cgi?id=83606
causing a bunch of unrelated test failures (Requested by
simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-10
Source/WebCore:
* Modules/battery/BatteryController.cpp:
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Source/WebKit/chromium:
* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Removed.
* public/WebBatteryStatusClient.h: Removed.
* public/WebView.h:
(WebKit):
(WebView):
* public/WebViewClient.h:
(WebKit):
* src/BatteryClientImpl.cpp: Removed.
* src/BatteryClientImpl.h: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 10 Apr 2012 19:41:41 +0000 (19:41 +0000)]
Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528
Reviewed by Kentaro Hara.
Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.
This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.
No new tests, no change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:36:14 +0000 (19:36 +0000)]
Pass PropertyHandler by reference in CSSStyleApplyProperty.h.
https://bugs.webkit.org/show_bug.cgi?id=83551
Reviewed by Kentaro Hara.
No new tests / cleanup only.
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:31:04 +0000 (19:31 +0000)]
Pass FontDescription as const reference instead of by value in CSSStyleSelector.h.
https://bugs.webkit.org/show_bug.cgi?id=83548
Reviewed by Kentaro Hara.
FontDescription is relatively large, so pass-by-reference is preferred.
No new tests / code cleanup only.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 10 Apr 2012 19:23:48 +0000 (19:23 +0000)]
Add TestNode.idl to run-binding-tests
https://bugs.webkit.org/show_bug.cgi?id=83599
Reviewed by Adam Barth.
TestNode.idl is a minimized version of Node.idl with enough attributes
to exercise CodeGenerator.pm's handling of Node subtypes.
* bindings/scripts/test/CPP/WebDOMTestNode.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestNode.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNode.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h: Added.
* bindings/scripts/test/JS/JSTestNode.cpp: Added.
* bindings/scripts/test/JS/JSTestNode.h: Added.
* bindings/scripts/test/ObjC/DOMTestNode.h: Added.
* bindings/scripts/test/ObjC/DOMTestNode.mm: Added.
* bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Added.
* bindings/scripts/test/TestNode.idl: Added.
* bindings/scripts/test/V8/V8TestNode.cpp: Added.
* bindings/scripts/test/V8/V8TestNode.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 19:15:36 +0000 (19:15 +0000)]
msqrt's implied mrow should do operator stretching
https://bugs.webkit.org/show_bug.cgi?id=82353
Patch by David Barton <dbarton@mathscribe.com> on 2012-04-10
Reviewed by Julien Chaffraix.
Source/WebCore:
An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.
To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.
Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.
* css/mathml.css:
(msqrt):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.h:
(RenderMathMLSquareRoot):
LayoutTests:
* mathml/presentation/mo-stretch.html:
* mathml/presentation/style.xhtml:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/style-expected.png:
* platform/mac/mathml/presentation/style-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 19:10:53 +0000 (19:10 +0000)]
Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue().
https://bugs.webkit.org/show_bug.cgi?id=83536
Reviewed by Daniel Bates.
Add a return statement to the case CSSPropertyBaselineShift so that we don't fall through to the next case statement.
No new tests / code cleanup from coverity static analysis.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 10 Apr 2012 18:56:57 +0000 (18:56 +0000)]
2012-04-10 Alejandro G. Castro <alex@igalia.com>
[GTK] Build fix TextureMapper compilation and solve warning.
Reviewed by Martin Robinson.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderManager::getShaderProgram):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 18:46:38 +0000 (18:46 +0000)]
Add fast/events/drop-handler-should-not-stop-navigate.html.
Like fast/events/drop-with-file-paths.html, this expects eventSender.beginDragWithFiles to be implemented.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 10 Apr 2012 18:44:05 +0000 (18:44 +0000)]
Add fast/events/drop-with-file-paths.html to the WebKit2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Tue, 10 Apr 2012 18:29:09 +0000 (18:29 +0000)]
[GTK] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83152
Reviewed by Martin Robinson.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests, refactoring only, covered by existing canvas tests.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage): Output the encoded image to the provided GOwnPtr<gchar>&
buffer. Update GTK document reference to a valid URL. Round the quality argument
to an int like the toDataURL() implementations of other ports. Ditch the success
variable; instead test the GError* error return to indicate success.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType
encoded image data buffer herein.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Tue, 10 Apr 2012 18:20:10 +0000 (18:20 +0000)]
Add test expectations for Mac debug builds.
Unreviewed.
* platform/chromium-mac-snowleopard/fast/dom/shadow: Added.
* platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 10 Apr 2012 18:17:53 +0000 (18:17 +0000)]
[chromium] Defer texture id allocation for copies until the actual copy executes
https://bugs.webkit.org/show_bug.cgi?id=83514
Reviewed by Adrienne Walker.
Source/WebCore:
This allows for queuing a texture copy operation into a ManagedTexture whose texture ID has not yet been
allocated. The ManagedTexture* serves as a promise that an ID will be available when the copy is executed.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::appendManagedCopy):
(WebCore):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(ManagedCopyEntry):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
Source/WebKit/chromium:
* tests/CCTiledLayerTestCommon.cpp:
* tests/CCTiledLayerTestCommon.h:
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 10 Apr 2012 18:14:43 +0000 (18:14 +0000)]
Add ref test expected result.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 10 Apr 2012 18:14:20 +0000 (18:14 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83595
<rdar://problem/
10443278> Overlapping text in table cell across column break
If a cell's height changes such that it is taller than the overall row height because
of pagination, then grow the entire row height to enclose the cell instead of shrinking
the cell.
Reviewed by Dan Bernstein.
Added fast/multicol/cell-shrinkback.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83595
Add new layout test for cells paginating across columns.
Reviewed by Dan Bernstein.
* fast/multicol/cell-shrinkback.html: Added.
* fast/multicol/cell-shrinkback-expected.html: Added.
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 10 Apr 2012 18:10:45 +0000 (18:10 +0000)]
Remove unnecessary null check in void SimplifyMarkupCommand::doApply().
https://bugs.webkit.org/show_bug.cgi?id=83535
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
currentNode cannot be null within the loop body.
It is dereferenced before and after the removed line without checking.
Additionally I have added an assertion to express this loop invariant.
* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 17:47:50 +0000 (17:47 +0000)]
Add Encrypted Media Extensions methods to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82971
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-not-loaded.html
media/encrypted-media/encrypted-media-syntax.html
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitEncryptedMediaEnabled):
* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::exceptionCodeForMediaKeyException):
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::didAddTrack):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(NullMediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayer::generateKeyRequest):
(WebCore::MediaPlayer::addKey):
(WebCore::MediaPlayer::cancelKeyRequest):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::addKey):
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest):
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest):
Source/WebKit/chromium:
* features.gypi:
* public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer):
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit):
(WebKit::WebMediaPlayerClientImpl::generateKeyRequest):
(WebKit::WebMediaPlayerClientImpl::addKey):
(WebKit::WebMediaPlayerClientImpl::cancelKeyRequest):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::isMediaStreamEnabled):
(WebKit::WebRuntimeFeatures::enableEncryptedMedia):
(WebKit):
(WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled):
Tools:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
* media/encrypted-media/encrypted-media-not-loaded-expected.txt: Added.
* media/encrypted-media/encrypted-media-not-loaded.html: Added.
* media/encrypted-media/encrypted-media-syntax-expected.txt: Added.
* media/encrypted-media/encrypted-media-syntax.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 10 Apr 2012 17:28:25 +0000 (17:28 +0000)]
[chromium] Add Battery Status API support.
Source/WebCore:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
This change is covered by tests in batterystatus/.
* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Source/WebKit/chromium:
The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-
20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):
* public/WebBatteryStatusClient.h: Added.
(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):
* public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):
* public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):
* src/BatteryClientImpl.cpp: Added.
(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):
* src/BatteryClientImpl.h: Added.
(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 10 Apr 2012 17:25:01 +0000 (17:25 +0000)]
getShaderFormatPrecision should return sensible values
https://bugs.webkit.org/show_bug.cgi?id=83520
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Fix getShaderPrecisionFormat values.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
* platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
LayoutTests:
* fast/canvas/webgl/shader-precision-format-expected.txt:
* fast/canvas/webgl/shader-precision-format.html: Add tests to make sure getShaderPrecisionFormat returns sensible values.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 17:18:27 +0000 (17:18 +0000)]
Web Inspector: Add Galaxy Nexus to the list of emulated user agents
https://bugs.webkit.org/show_bug.cgi?id=83589
The new record contains the device display metrics and the User Agent string.
Reviewed by Pavel Feldman.
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 10 Apr 2012 17:11:10 +0000 (17:11 +0000)]
Add missing methods and operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=82403
Reviewed by Eric Seidel.
Add missing methods and operators and from branch version of
FractionalLayoutUnit. Also fix overflow assertion and add const keyword
to a couple of methods.
No new tests.
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::abs):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::floor):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator<):
(WebCore):
(WebCore::operator-):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 10 Apr 2012 17:07:21 +0000 (17:07 +0000)]
2012-04-10 Zhenyao Mo <zmo@google.com>
Unreviewed, roll chromium to 131469
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 10 Apr 2012 17:04:41 +0000 (17:04 +0000)]
WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553
Reviewed by Chris Rogers.
No new tests; optimization of existing code path, so covered by existing tests.
Introduce the concept of a "silent" channel:
* platform/audio/AudioChannel.h:
(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set): Clear silent bit.
(WebCore::AudioChannel::zero): Set silent bit.
(WebCore::AudioChannel::clearSilentFlag): Clear silent bit.
(WebCore::AudioChannel::isSilent): Accessor.
Optimize a few channel operations when the source or destination channels are silent.
* platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale): No-op on a silent channel.
(WebCore::AudioChannel::copyFrom): zero() when source is silent.
(WebCore::AudioChannel::copyFromRange): possibly zero() when source is silent.
(WebCore::AudioChannel::sumFrom): No-op when source is silent.
(WebCore::AudioChannel::maxAbsValue): 0 on a silent channel.
Optimize a few bus operations when the source or destination channels are silent.
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo): No-op if source is silent and either
the destination bus is silent, or the output is not summed to the destination.
(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom): zero() if the source is silent
and the lengths of the gain values, source, and destination match.
(WebCore::AudioBus::createBySampleRateConverting): Return an empty bus if the source is silent.
(WebCore::AudioBus::createByMixingToMono): Ditto; clear the destination's silent bit otherwise.
(WebCore::AudioBus::isSilent): Return whether all channels are silent.
(WebCore::AudioBus::clearSilentFlag): Clear silent bit of constituent channels.
* platform/audio/AudioBus.h:
Make sure that classes which generate audio clear their busses' silent bit.
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process): Ditto.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Ditto.
(WebCore::AudioBufferSourceNode::propagatesSilence): Propagate silence only when the source node
has nothing left to render.
* webaudio/AudioBufferSourceNode.h:
(WebCore::AudioBufferSourceNode::playbackState): Made const correct.
(WebCore::AudioBufferSourceNode::isPlaying): Added simple accessor.
(WebCore::AudioBufferSourceNode::hasFinished): Ditto.
* webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::currentSampleFrame): Made const correct.
(WebCore::AudioDestinationNode::currentTime): Ditto.
Audio nodes should not process audio data when the input is silent and the nodes will propagate silences.
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::inputsAreSilent): Convenience function which walk over the node's inputs.
(WebCore::AudioNode::silenceOutputs): Ditto.
(WebCore::AudioNode::unsilenceOutputs): Ditto.
* webaudio/AudioNode.h:
(WebCore::AudioNode::propagatesSilence):
These Nodes can generate audio when given silent input, so return false from propagatesSilence.
* Modules/webaudio/Oscillator.h:
(WebCore::Oscillator::propagatesSilence): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 10 Apr 2012 16:40:46 +0000 (16:40 +0000)]
[Chromium] Unreviewed, add baselines for fast/dom/shadow/selection-in-shadow.html
* platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 10 Apr 2012 16:36:45 +0000 (16:36 +0000)]
It should be possible to see why a code block was not compiled by the DFG
https://bugs.webkit.org/show_bug.cgi?id=83553
Reviewed by Geoff Garen.
If DFG_ENABLE(DEBUG_VERBOSE) and a code block is rejected, then print the
opcode that caused the rejection.
* dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 10 Apr 2012 16:29:47 +0000 (16:29 +0000)]
Unreviewed - adding myself as a committer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc