libevdev 1.5.6

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Fix typos in Documentation

Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to v4.9 linux/input.h headers

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.5.5

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Disable test runs on make distcheck

The tests all need root, but running distcheck as root is not ideal. Disable
the test runs (but not the build) to make it easier to verify distcheck works
as intended.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

Fix minor error in doxygen example code

The incorrect variable was checked as a return code in an example, and
that can be confusing for people trying to learn or use the example code
as a starting point.

tools: print the mean frequency together with the max frequency

And if they're 30% out, print a warning. On the ThinkPad X1 Wireless Touch
Mouse (when connected via bluetooth) we get a bunch of events at the start of
the movement, all less than 1ms apart. Best guess is that the device goes to
low-power, then notices the movement and buffers the event until the BT
connection is back up. Then it sends all events at once. Usually they're less
than 1ms apart, but at one recording showed a 37ms delay before we go back to
the normal 70ms (~15Hz) the mouse has otherwise.

This is unpredictable enough that we can't just work around it so instead
print a warning to the user so they can go investigate.

https://bugs.freedesktop.org/show_bug.cgi?id=97812

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

tools: rename frequency to max_frequency in the dpi tool

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: use uint64_t, not doubles for the µs parameters

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix kernel-announced width/height

Side-effect of 240ba34ebd483 was that "touchpad size as listed by the kernel"
was now dependent on the values we got. This one is a static one based on the
axis info.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

doc: drop the HTML_TIMESTAMP

Allows for reproducible builds. Debian carries a patch for this, and the
timestamp doesn't really add much since the doc is either in sync with master
or represents the release tag. Might as well drop it.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.5.4

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix the touchpad resolution calculation

Previous ones used the absinfo from the kernel but since we never updated that
from within the tool, the output was always the same.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.5.3

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Don't bother sanitizing disabled event codes

Filter them immediately instead of passing them on and relying on the actual
event handling code to filter them.

Reproducer: if EV_ABS is disabled on an Apple MagicMouse we still get events
passed into sanitize_event(). But the code handling EV_ABS events doesn't
update the state, so we end up complaining about double tracking IDs, even
though that is not actually correct.

https://bugzilla.redhat.com/show_bug.cgi?id=1361325

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

tools: require a minimum size for touchpads

This mostly aims to catch users trying to specify the size in inches.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: change touchpad-edge-detector to require physical size

Almost no-one does the calculations for me to update the udev rules (and some
rules were submitted with the <x resolution> placeholders left in).
Require the user to specify the physical size so we just copy/paste the actual
udev rule.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

libevdev 1.5.2

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to v4.6 linux/input.h header

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.5.1

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev: Properly distribute uinput.h

Signed-off-by: Armin K <krejzi@email.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.5

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: allow numeric axis values in tweak-device

Not all axes a device may have are assigned a semantic name.

https://bugs.freedesktop.org/show_bug.cgi?id=95029

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix tweak-device option parsing

https://bugs.freedesktop.org/show_bug.cgi?id=92880

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

doc: reduce doxygen file to the non-default settings

Makes it easier to check what we changed from the defaults.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Fix typo in doc string

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

uinput: support the new UI_DEV_SETUP/UI_ABS_SETUP ioctls

Available in kernel 4.5 and later (uinput version 5), these ioctls allow us to
set the absinfo correctly, i.e. including the resolution.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

uinput: split uinput device creation into a helper function

No functional changes. This is prep work for supporting the new
UIDEV_DEV_SETUP ioctl.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

uinput: drop an unused argument

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

include: update to v4.5 linux/uinput.h

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

Add parsing linux/input-event-codes.h, update to kernel v4.5

The kernel has split most of the event codes out to a new header but the FF_
bits are missing from that header. Until this is fixed upstream, change the
event code parsing so it can take two files (using cat and stdin) so we can
update the kernel headers again.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

test: ignore a failure to UI_DEV_DESTROY the device

Coverity complains about it.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

test: drop unnecessary return value

We abort if anything goes wrong anyway, so we never returned anything but
success.

Found by coverity.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

libevdev 1.4.6

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

uinput: fix race condition in uinput syspath check

In theory, the device could change between stat() call and open(), resulting
in us opening the new device. Change to open() first, then fstat() on the fd.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

tools: shut up coverity about a potential close(-1)

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix coverty "may be used uninitialized" warnings

tools/libevdev-tweak-device.c:390: uninit_use_in_call: Using uninitialized
value "changes" when calling "parse_options_abs".

tools/libevdev-tweak-device.c:376: warning: 'led' may be used uninitialized in
this function

tools/libevdev-tweak-device.c:375: warning: 'axis' may be used uninitialized
in this function

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Document that the fd should be drained before libevdev_set_fd

This is the caller's responsibility, for two reasons:
* we don't know if O_NONBLOCK is set, so draining the fd isn't a simple matter
  of read() until EAGAIN. A select() + read() could work around this of
  course.
* for stateless information, keys and relative data, it is not a problem when
  there are events waiting on the fd already, they are processed correctly,
  albeit with a delay.

So punt this decision to the caller, they openend the fd, they know if they
care about delayed events, they can drain the fd before handing it to us.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Acked-by: David Herrmann <dh.herrmann@gmail.com>

libevdev 1.4.5

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix touchpad-edge-detector udev rule output

off-by-one error on the ABS_ axes printed. ABS_X/Y are 0 and 1.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Add some more files to gitignore

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.4.4

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Fix invalid absinfo range values reported by certain mtk soc

This change will only affect certain touch screens, for which the driver
integration code does not provide meaningful values for the allowed range
of ABS_MT_TRACKING_IDs. The reported range [0, 0] will be overwritten with
[-1, 0xFFFF]

Signed-off-by: Andreas Pokorny <andreas.pokorny@canonical.com>
[Changed from INT_MAX to 0xFFFF to match the kernel, add device name to log
message]

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: print out evdev override udev rule from touchpad edge detector

We're starting to collect overrides for custom devices, making this easier for
users and saves us time. Once we measured everything, print out a
guesstimated udev rule and instructions on how to calculate the resolution.
Extra output now is:

Touchpad size as listed by the kernel: 132x111mm
Calculate resolution as:
x axis: 6076/<width in mm>
y axis: 5021/<height in mm>

Suggested udev rule:
# <Laptop model description goes here>
evdev:input:b0005v05ACp030E*
 EVDEV_ABS_01=-2694:2862:<x resolution>
 EVDEV_ABS_02=-20:121:<y resolution>
 EVDEV_ABS_35=-2694:2862:<x resolution>
 EVDEV_ABS_36=-20:121:<y resolution>

The ABS_MT_ axes are only printed if the device have them, if the device isn't
bluetooth/usb we print the dmi modalias instead.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools - tweak-device: add a --resolution command

So far, 100% of the usages for tweak-tool was to set the x/y resolution of a
device. Make --resolution a shortcut for this.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

tools - tweak-device: revamp to reduce use of globals

Make the code base a bit more modular so it's easier to add new commands.
Main change here is: options are parsed twice now, first time for the mode
(abs/led) and the device path, then again for the mode-specific options.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

Note that libevdev_free() does not close the fd

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools - tweak-device: fix wrong error message if the LED doesn't exist

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools - tweak-device: close the fd on exit

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.4.3

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to 4.1 header

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: complain about devices that don't have abs x/y axes in the edge detector

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: widen frequency resolution to µs in the DPI tool

The Microsoft Arc Touch Mouse claims 8000fps which is higher than we can
measure in the current milliseconds resolution.
http://www.cnet.com/products/microsoft-arc-touch-mouse-black-series/specs/

https://bugs.freedesktop.org/show_bug.cgi?id=90540

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.4.2

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix help string for manual DPI calculation

https://bugs.freedesktop.org/show_bug.cgi?id=90143

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to 4.0 header

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.4.1

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Accept LIBEVDEV_READ_FLAG_BLOCKING as valid flag

https://bugs.freedesktop.org/show_bug.cgi?id=89798

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

ABS_MAX counts as MT axis for the event queue

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

cosmetic: fix a comment

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Disable test-static-link in case of shared only build.

Fixes the following buildroot compile failure:

libtool: link: [..]/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc -std=gnu99 -I.. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -o test-static-link test_static_link-test-link.o  ../libevdev/.libs/libevdev.so -Wl,-rpath -Wl,[...]/build/libevdev-1.4/libevdev/.libs
[...]/arm-buildroot-linux-uclibcgnueabi/bin/ld: attempted static link of dynamic object `../libevdev/.libs/libevdev.so'
collect2: error: ld returned 1 exit status
Makefile:719: recipe for target 'test-static-link' failed

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.4

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

cosmetic: fix a couple of duplicate/missing empty lines

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: use -std=c89 instead of c90 for the build test

They're identical, but RHEL6 doesn't support -std=c90

https://gcc.gnu.org/onlinedocs/gcc/Standards.html
https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html#C-Dialect-Options

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: add a tool to change kernel devices

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: always build the build-tests

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

configure: rename BUILD_TESTS to ENABLE_RUNTIME_TESTS

Avoids confusion when we build tests in the future even though BUILD_TESTS is
disabled.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Use memcpy/memmove instead of loop operations

Signed-off-by: Thilo Schulz <thilo@tjps.eu>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev_uinput_destroy: don't close non-open FD

The returned errno from libevdev_input_create_from_device was returned
incorrectly because libevdev_uinput_destroy() would try to close the
unset value of ->fd, overwriting errno.

That was fixed in debe9b030c8069cdf78307888ef3b65830b25122, this patch avoids
the ioctl/close calls if the fd isn't set.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: note that the mouse frequency measured is the highest frequency

Some devices scale the frequency based on the input and will provide
recordings with different frequencies each time. Recommend to measure multiple
times since we can only know what the highest frequency is.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: fix clang compiler warning

mouse-dpi-tool.c:213:39: warning: missing field 'frequency' initializer
[-Wmissing-field-initializers]
        struct measurements measurements = {0};

Annoying, but a low-cost fix.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Shut up clang compiler warnings

clang looks at GCC pragmas, but doesn't understand -Woverride-init. Instead,
it uses -Winitializer-overrides.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

tools: print the formula to calculate resolutions

And encourage users to move at least 25cm, makes it a lot easier to pick the
resolution.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to 3.18 header

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.3.2

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: zero-pad PID/VID in the dpi tool

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: print the hwdb match line from the dpi tool

Let's make this as easy as possible

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

tools: add a tool to estimate the resolution of a mouse

Relative devices don't provide a physical resolution to the host. For things
like pointer acceleration, the physical amount of movement is better as
baseline than the movement in device units.

Alas, many devices don't come with any information at all, so the users have
to guess. Help that guesswork by providing a tool that does the calculations
for them.

This tool measures the device units covered, then prints the frequency and an
lookup table for various resolutions (in dpi) to match to the physical
movement of the device.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>

doc: add the prefixing * to all @code doxygen sections

These were removed in (7da329b) because for some reason they got copied into
the output. That was either a buggy doxygen or just some other problem. Add
them again, makes it much easier to read the header file.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: add test for clock id setting on an invalid device

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: add test for setting absinfo on invalid devices

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: add test case for grab calls on invalid devices

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: add missing tests for invalid calls on next_event/has_event_pending

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Remove superfluous linebreak in an error message

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

doc: fix uinput example code

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Fix a confusing comment

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.3.1

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

doc: update doxygen.in for current doxygen

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

include: update to 3.17 header

Adds INPUT_PROP_POINTING_STICK

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.3

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

doc: fix slightly confusing code/type comments

Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

configure.ac: print prefix and libdir

When building for multiple prefixes from the same repo it's nice to see a
reminder for what the current prefix is.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

libevdev 1.3RC2

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: fix EVIOCREVOKE test on non-supporting kernels

The ioctl-returned errno is positive.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Add some minimal documentation about static linking

I can't recommend it, but I can't stop people from doing it, so at least
document the ground rules.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Hook up nm to check for leaking symbols in the static library

We ignore anything that starts with an underscore, anything that starts with
libevdev and main (since we test the test-static-link binary) and a couple of
gcov-related functions. This should catch any functions we accidentally
export.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: handle the GCOV_LDFLAGS in all tests

We rebuild the libevdev object files with the gcov flags for the tests, so we
need to make sure those flags are present on all binaries.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: override check-local instead of check

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

test: add basic static link test

Same as the dynamic link test, just with the -static flag

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

uinput: explicitly ignore the UI_DEV_DESTROY return value

This can't fail in the kernel anyway, so cast it to shut up Coverity.
Error message:
"Calling function "ioctl(int, unsigned long, ...)" without checking return
 value (as is done elsewhere 35 out of 36 times)."

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>