msarett [Thu, 17 Mar 2016 14:19:41 +0000 (07:19 -0700)]
Remove uses of SkImageDecoder from gms
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1791583002
Review URL: https://codereview.chromium.org/
1791583002
msarett [Thu, 17 Mar 2016 14:17:54 +0000 (07:17 -0700)]
Remove uses of SkImageDecoder from skdiff
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788643003
Review URL: https://codereview.chromium.org/
1788643003
caryclark [Thu, 17 Mar 2016 14:01:49 +0000 (07:01 -0700)]
make sausages rounder and portable
TBR=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1808203003
Review URL: https://codereview.chromium.org/
1808203003
robertphillips [Thu, 17 Mar 2016 13:58:39 +0000 (06:58 -0700)]
Add SkSpecialImage::extractSubset & NewFromPixmap
This is calved off of: https://codereview.chromium.org/
1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface)
This now relies on: https://codereview.chromium.org/
1813483002/ (ImagePixelLocker now manually allocates SkPixmap) to clean up the uses of SkAutoPixmapStorage in Chromium
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1787883002
Committed: https://skia.googlesource.com/skia/+/
250581493a0859987e482810879e85e5ac2dc002
Review URL: https://codereview.chromium.org/
1787883002
msarett [Thu, 17 Mar 2016 13:30:06 +0000 (06:30 -0700)]
Remove SkipZeroesBench
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784333003
Review URL: https://codereview.chromium.org/
1784333003
mtklein [Thu, 17 Mar 2016 12:36:18 +0000 (05:36 -0700)]
free -> reset
The C++ standard library uses ".reset()" where we sometimes write ".free()".
We also use ".reset()" quite a lot. This standardizes on ".reset()".
This is one more step towards dropping SkAutoTDelete in favor of the standard
std::unique_ptr.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1811723002
Review URL: https://codereview.chromium.org/
1811723002
caryclark [Thu, 17 Mar 2016 12:33:28 +0000 (05:33 -0700)]
don't create zero length intervals
Dashing a pattern without zero-length intervals should
not create them if the end of the on interval coincides
with the beginning of the initial dash offset.
R=reed@google.com
BUG=591993
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1766243004
Committed: https://skia.googlesource.com/skia/+/
18bbd00190623fb6cdb119df4a118ac3c1aed52a
Review URL: https://codereview.chromium.org/
1766243004
mtklein [Thu, 17 Mar 2016 12:31:07 +0000 (05:31 -0700)]
Add back SkAutoTUnref::detach() for Android temporarily.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1812843002
Review URL: https://codereview.chromium.org/
1812843002
mtklein [Thu, 17 Mar 2016 00:33:54 +0000 (17:33 -0700)]
Add back SkAutoTDelete::detach() for Android temporarily.
TBR=
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1811483004
Review URL: https://codereview.chromium.org/
1811483004
senorblanco [Wed, 16 Mar 2016 23:15:53 +0000 (16:15 -0700)]
Image filters: fix the zero-sigma fast path in SkBlurImageFilter.
The fast path was not correctly taking the input srcOffset into account.
BUG=595324
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1807673005
Review URL: https://codereview.chromium.org/
1807673005
benjaminwagner [Wed, 16 Mar 2016 21:01:39 +0000 (14:01 -0700)]
Un-deprecate new methods to fix Android.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1808663004
Review URL: https://codereview.chromium.org/
1808663004
mtklein [Wed, 16 Mar 2016 20:53:35 +0000 (13:53 -0700)]
detach -> release
The C++ standard library uses the name "release" for the operation we call "detach".
Rewriting each "detach(" to "release(" brings us a step closer to using standard library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).
This was a fairly blind transformation. There may have been unintentional conversions in here, but it's probably for the best to have everything uniformly say "release".
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1809733002
Review URL: https://codereview.chromium.org/
1809733002
reed [Wed, 16 Mar 2016 19:29:01 +0000 (12:29 -0700)]
add blitprocs to shaders
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1793883002
Review URL: https://codereview.chromium.org/
1793883002
cjacek [Wed, 16 Mar 2016 18:26:32 +0000 (11:26 -0700)]
Minor mingw cross compilation fix.
Windows.h is actually windows.h.
Review URL: https://codereview.chromium.org/
1804163005
robertphillips [Wed, 16 Mar 2016 17:39:08 +0000 (10:39 -0700)]
Revert of Add SkSpecialImage::extractSubset & NewFromPixmap (patchset #5 id:80001 of https://codereview.chromium.org/
1787883002/ )
Reason for revert:
Need to wean ImagePixelLocker.h off of SkAutoPixmapStorage :(
Original issue's description:
> Add SkSpecialImage::extractSubset & NewFromPixmap
>
> This is calved off of: https://codereview.chromium.org/
1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface)
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1787883002
>
> Committed: https://skia.googlesource.com/skia/+/
250581493a0859987e482810879e85e5ac2dc002
TBR=bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1808833002
mtklein [Wed, 16 Mar 2016 17:28:35 +0000 (10:28 -0700)]
Use std::unique_ptr.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
Committed: https://skia.googlesource.com/skia/+/
3dd9ed37c24611af86f0fe374bd3698b63f09450
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780933003
Committed: https://skia.googlesource.com/skia/+/
2691d76a06e1af6282f8b3a3140cc93361be10c4
Review URL: https://codereview.chromium.org/
1780933003
senorblanco [Wed, 16 Mar 2016 17:25:58 +0000 (10:25 -0700)]
GrTessellator: don't reuse the previous vertex buffer on a cache miss.
Just let the cache give us the correct entry for the given size.
This simplifies the code (no mysterious non-const ref member).
I don't see any performance effect from this change, but will watch
the bots closely.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1800623002
Review URL: https://codereview.chromium.org/
1800623002
halcanary [Wed, 16 Mar 2016 17:19:33 +0000 (10:19 -0700)]
Doc: pdf illustration
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
1807963002
mtklein [Wed, 16 Mar 2016 17:03:14 +0000 (10:03 -0700)]
Revert of Use std::unique_ptr. (patchset #10 id:170001 of https://codereview.chromium.org/
1780933003/ )
Reason for revert:
aww jeez, I dropped ps 8...
Original issue's description:
> Use std::unique_ptr.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
>
> Committed: https://skia.googlesource.com/skia/+/
3dd9ed37c24611af86f0fe374bd3698b63f09450
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780933003
>
> Committed: https://skia.googlesource.com/skia/+/
2691d76a06e1af6282f8b3a3140cc93361be10c4
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1809693002
robertphillips [Wed, 16 Mar 2016 16:47:08 +0000 (09:47 -0700)]
Add SkSpecialImage::extractSubset & NewFromPixmap
This is calved off of: https://codereview.chromium.org/
1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1787883002
Review URL: https://codereview.chromium.org/
1787883002
djsollen [Wed, 16 Mar 2016 15:48:58 +0000 (08:48 -0700)]
Cleanup download scripts related to new Android NDK.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1810603002
Review URL: https://codereview.chromium.org/
1810603002
mtklein [Wed, 16 Mar 2016 15:39:41 +0000 (08:39 -0700)]
Use std::unique_ptr.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
Committed: https://skia.googlesource.com/skia/+/
3dd9ed37c24611af86f0fe374bd3698b63f09450
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780933003
Review URL: https://codereview.chromium.org/
1780933003
mtklein [Wed, 16 Mar 2016 15:37:19 +0000 (08:37 -0700)]
Split uninteresting hash lines correctly on Windows.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1806903002
Review URL: https://codereview.chromium.org/
1806903002
cdalton [Wed, 16 Mar 2016 14:48:20 +0000 (07:48 -0700)]
Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1796713005
Review URL: https://codereview.chromium.org/
1796713005
caryclark [Wed, 16 Mar 2016 14:34:02 +0000 (07:34 -0700)]
pass cap to dash text
Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.
R=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776983002
Review URL: https://codereview.chromium.org/
1776983002
borenet [Wed, 16 Mar 2016 14:27:05 +0000 (07:27 -0700)]
Fix compile on Windows swarming bot
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1791513002
Review URL: https://codereview.chromium.org/
1791513002
borenet [Wed, 16 Mar 2016 14:07:25 +0000 (07:07 -0700)]
Add CMake builder to CQ
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1810523002
Review URL: https://codereview.chromium.org/
1810523002
caryclark [Wed, 16 Mar 2016 13:51:55 +0000 (06:51 -0700)]
add missing API
SkMemoryWStream needs SK_API to be accessible from PDFium.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1808683002
Review URL: https://codereview.chromium.org/
1808683002
jvanverth [Wed, 16 Mar 2016 13:47:39 +0000 (06:47 -0700)]
Create new buffer (if necessary) on vkMap
The assumption here is that we only read via a Map after we
sync the command buffer, and that when writing we don't Map
to update, but to overwrite. This appears to be true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1774913005
Review URL: https://codereview.chromium.org/
1774913005
caryclark [Wed, 16 Mar 2016 13:46:50 +0000 (06:46 -0700)]
skip stroke outset of all teeny lines
Allow a small amount of slop when seeing
if the previous moveTo and subsequent lineTo
are the same.
R=robertphillips@google.com
BUG=593049
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1805913002
Review URL: https://codereview.chromium.org/
1805913002
mtklein [Wed, 16 Mar 2016 13:34:59 +0000 (06:34 -0700)]
Google3 apps are still using Create* shader methods.
This may need to go in DEFINES_ALL,
but definitely needs to affect the main _UNIX builds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1808723002
Review URL: https://codereview.chromium.org/
1808723002
yujieqin [Wed, 16 Mar 2016 12:57:38 +0000 (05:57 -0700)]
Update to new DNG SDK: Integrate integer overflow fixes
BUG=b/
26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1801063002
Review URL: https://codereview.chromium.org/
1801063002
benjaminwagner [Mon, 14 Mar 2016 22:21:12 +0000 (15:21 -0700)]
Fix Google3 build by updating pdf path after https://codereview.chromium.org/
1781773002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1802553003
Review URL: https://codereview.chromium.org/
1802553003
reed [Mon, 14 Mar 2016 19:22:10 +0000 (12:22 -0700)]
Reland of "Finish conversion to sk_sp<SkShader> (patchset #2 id:20001 of https://codereview.chromium.org/
1803763002/ )"
This reverts commit
106e10ddff5d473dc81dd1ce8ade615585ea609b.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1803783002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
TBR=
Review URL: https://codereview.chromium.org/
1803783002
reed [Mon, 14 Mar 2016 18:53:07 +0000 (11:53 -0700)]
Revert of Finish conversion to sk_sp<SkShader> (patchset #2 id:20001 of https://codereview.chromium.org/
1803763002/ )
Reason for revert:
need to update cmake build example
Original issue's description:
> Finish conversion to sk_sp<SkShader>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1803763002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
15c3a0e55bd9134dace0ace2fffb855a0f09542f
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1798133003
reed [Mon, 14 Mar 2016 18:42:58 +0000 (11:42 -0700)]
Finish conversion to sk_sp<SkShader>
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1803763002
TBR=
Review URL: https://codereview.chromium.org/
1803763002
halcanary [Mon, 14 Mar 2016 01:30:24 +0000 (18:30 -0700)]
SkPDF: remove all globally references SkPDFObjects
Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).
Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once. The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization. After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.
BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788263002
Review URL: https://codereview.chromium.org/
1788263002
reed [Sun, 13 Mar 2016 21:13:58 +0000 (14:13 -0700)]
Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium.org/
1789633002/ )"
This reverts commit
9283d20afc27571f7a871d1bd1100dd5df584941.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1793303002
Review URL: https://codereview.chromium.org/
1793303002
reed [Sun, 13 Mar 2016 20:01:57 +0000 (13:01 -0700)]
Revert of more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium.org/
1789633002/ )
Reason for revert:
seems to have changed pictureshadertile
Original issue's description:
> more shader-->sp conversions
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789633002
>
> Committed: https://skia.googlesource.com/skia/+/
ce563cdd48ec7ce4e0420dd88760df9be9dba50c
TBR=fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1790353002
reed [Sun, 13 Mar 2016 19:32:36 +0000 (12:32 -0700)]
more shader-->sp conversions
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789633002
Review URL: https://codereview.chromium.org/
1789633002
fmalita [Sun, 13 Mar 2016 16:46:16 +0000 (09:46 -0700)]
Avoid unneeded ref churn in SkDraw::drawVertices
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1790303002
Review URL: https://codereview.chromium.org/
1790303002
update-skps [Sun, 13 Mar 2016 08:29:52 +0000 (00:29 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1796503002
Review URL: https://codereview.chromium.org/
1796503002
halcanary [Sat, 12 Mar 2016 13:59:39 +0000 (05:59 -0800)]
SkPDF: move all pdf sources into src/pdf
also, consolidate XPS backend into src/xps
remove from include/ almost always a good thing.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781773002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1781773002
kulshin [Fri, 11 Mar 2016 23:26:46 +0000 (15:26 -0800)]
Revert "Initialize the font fallback when the direct write font"
This is apparently causing crashes and hangs in Chromium. Possible cause of 593858 and possible cause of 594047.
This reverts commit
042f859c19f71ca9feacddd1cb058ff59eed8963.
Conflicts:
src/ports/SkFontMgr_win_dw.cpp
Review URL: https://codereview.chromium.org/
1792473003
ericrk [Fri, 11 Mar 2016 23:18:20 +0000 (15:18 -0800)]
Fix BGRA/RGBA readback conversions on mac
Reading back from a BGRA framebuffer as RGBA or vis-versa is slow on mac. On my early 2013 MBP, we see a 40% regression when using
the discrete GPU or a 13% regression on integrated.
This change adds a workaround which causes Mac to use the existing Mesa path and prefer readback from the same format as the
framebuffer.
BUG=581311
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1786813002
Review URL: https://codereview.chromium.org/
1786813002
cdalton [Fri, 11 Mar 2016 22:07:38 +0000 (14:07 -0800)]
Add caps and GL API for buffer texture
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784063003
Review URL: https://codereview.chromium.org/
1784063003
cdalton [Fri, 11 Mar 2016 21:34:32 +0000 (13:34 -0800)]
Add sampler precision to GrTextureAccess
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784023002
Review URL: https://codereview.chromium.org/
1784023002
reed [Fri, 11 Mar 2016 21:02:28 +0000 (13:02 -0800)]
Make sp variants for SkData
Review URL: https://codereview.chromium.org/
1779263003
mtklein [Fri, 11 Mar 2016 20:59:09 +0000 (12:59 -0800)]
Revert of When not writing to file in DM, spew verbose output to stderr (patchset #1 id:1 of https://codereview.chromium.org/
1788743002/ )
Reason for revert:
Looks like not all the bots are using --writePath (think, Valgrind, *SAN) so this causes those bots to spew like crazy.
Looks like we need to find a more explicit way to make this mode work.
Original issue's description:
> When not writing to file in DM, spew verbose output to stderr
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788743002
>
> Committed: https://skia.googlesource.com/skia/+/
40dec542cc12b354762bca2c0d68bc419f0cbebd
TBR=egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1783603006
joshualitt [Fri, 11 Mar 2016 20:08:15 +0000 (12:08 -0800)]
Flush the pipe in skiaserve when we switch to GPU
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789723003
Review URL: https://codereview.chromium.org/
1789723003
joshualitt [Fri, 11 Mar 2016 19:45:53 +0000 (11:45 -0800)]
Fix up no gpu build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1787843002
Review URL: https://codereview.chromium.org/
1787843002
cdalton [Fri, 11 Mar 2016 18:07:37 +0000 (10:07 -0800)]
Add support for vertex and geometry shader textures
Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782583002
Review URL: https://codereview.chromium.org/
1782583002
msarett [Fri, 11 Mar 2016 17:24:20 +0000 (09:24 -0800)]
Update libjpeg-turbo with security fixes from upstream
This includes:
https://github.com/libjpeg-turbo/libjpeg-turbo/commit/
0463f7c9aad060fcd56e98d025ce16185279e2bc
https://github.com/libjpeg-turbo/libjpeg-turbo/commit/
a572622dd654305c86585724c2a1ea34e22c2103
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789693002
Review URL: https://codereview.chromium.org/
1789693002
yujieqin [Fri, 11 Mar 2016 15:32:33 +0000 (07:32 -0800)]
Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only used for DNG format
BUG=b/
27587823
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782913002
Review URL: https://codereview.chromium.org/
1782913002
egdaniel [Fri, 11 Mar 2016 15:14:49 +0000 (07:14 -0800)]
When not writing to file in DM, spew verbose output to stderr
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788743002
Review URL: https://codereview.chromium.org/
1788743002
bsalomon [Fri, 11 Mar 2016 14:46:33 +0000 (06:46 -0800)]
Add deferred texture upload API.
Performs thread-safe decoding of SkImage in order to later create a texture-backed SkImage.
The client allocates storage for the data.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776693002
Review URL: https://codereview.chromium.org/
1776693002
bsalomon [Fri, 11 Mar 2016 14:22:00 +0000 (06:22 -0800)]
Reject dashes from GrAADFR
BUG=skia:5082
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784493004
Review URL: https://codereview.chromium.org/
1784493004
mtklein [Fri, 11 Mar 2016 14:10:30 +0000 (06:10 -0800)]
Revert of Use std::unique_ptr. (patchset #8 id:130001 of https://codereview.chromium.org/
1780933003/ )
Reason for revert:
Another Android ambiguity due to implicit bool...
frameworks/base/core/jni/android/graphics/Utils.cpp:110:35: error: call of overloaded 'SkMemoryStream(SkAutoTUnref<SkData>&)' is ambiguous
return new SkMemoryStream(data);
Original issue's description:
> Use std::unique_ptr.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
>
> Committed: https://skia.googlesource.com/skia/+/
3dd9ed37c24611af86f0fe374bd3698b63f09450
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1785353002
mtklein [Fri, 11 Mar 2016 13:18:48 +0000 (05:18 -0800)]
Use std::unique_ptr.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
Review URL: https://codereview.chromium.org/
1780933003
borenet [Fri, 11 Mar 2016 12:54:42 +0000 (04:54 -0800)]
Fixes for Win toolchain isolate
NOTRY=true
BUG=skia:4763, skia:4553
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782943002
Review URL: https://codereview.chromium.org/
1782943002
reed [Fri, 11 Mar 2016 12:33:52 +0000 (04:33 -0800)]
Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/
1778393002/ )"
Fix was to call get() instead of release() when passing the sp to a bare-ptr method.
This reverts commit
e683c56115a210b5993df9294260bb147b408bfa.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789443002
TBR=
Review URL: https://codereview.chromium.org/
1789443002
benjaminwagner [Fri, 11 Mar 2016 12:33:44 +0000 (04:33 -0800)]
Ensure only fractional floats are converted to SkFixed in SubpixelAlignment.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1779083003
Review URL: https://codereview.chromium.org/
1779083003
robertphillips [Fri, 11 Mar 2016 00:18:46 +0000 (16:18 -0800)]
Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/
1778393002/ )
Reason for revert:
Experimental revert to try to clear up ASAN failures
Original issue's description:
> add Make variations to return SkImage by sk_sp
>
> some internal call-sites update, but not. Will follow-up in future to complete that.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778393002
>
> Committed: https://skia.googlesource.com/skia/+/
bd73ffb83022f1f6b1997e2a91c049949e88a8a2
TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1783063002
bungeman [Thu, 10 Mar 2016 21:39:30 +0000 (13:39 -0800)]
Add SkScalarTruncToScalar and speed up SkScalarFraction.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783583003
Review URL: https://codereview.chromium.org/
1783583003
bsalomon [Thu, 10 Mar 2016 21:38:21 +0000 (13:38 -0800)]
update site dox - windows prefer msvs-ninja and add vulkan
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785743003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1785743003
NOTREECHECKS=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/
1785743003
joshualitt [Thu, 10 Mar 2016 21:29:36 +0000 (13:29 -0800)]
Fix some bugs and performance issues with skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777203003
Review URL: https://codereview.chromium.org/
1777203003
reed [Thu, 10 Mar 2016 20:45:18 +0000 (12:45 -0800)]
add Make variations to return SkImage by sk_sp
some internal call-sites update, but not. Will follow-up in future to complete that.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778393002
Review URL: https://codereview.chromium.org/
1778393002
bsalomon [Thu, 10 Mar 2016 20:31:20 +0000 (12:31 -0800)]
Fix 32bit win Vulkan build
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781013002
Review URL: https://codereview.chromium.org/
1781013002
mtklein [Thu, 10 Mar 2016 19:31:27 +0000 (11:31 -0800)]
Revert of Use std::unique_ptr. (patchset #7 id:120001 of https://codereview.chromium.org/
1780933003/ )
Reason for revert:
Now we remember! The problem was Clank:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/34329
Original issue's description:
> Use std::unique_ptr.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1782973002
fmalita [Thu, 10 Mar 2016 19:18:43 +0000 (11:18 -0800)]
Generic 4f gradient T sampler fallback
Add a generic T sampler fallback impl which uses T series produced by
subclasses mapTs() overrides. The fallback path uses the same interval
structures as the current optimized linear4f impl, but always sorted
in stop order (never inverted to match dx/increasing x order).
Enable the new mechanism for 4f linear w/ perspective.
Other boring changes:
* relocate the interval builder (back) to the base class
* add a private header for shared templates
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783823002
Review URL: https://codereview.chromium.org/
1783823002
bungeman [Thu, 10 Mar 2016 19:14:40 +0000 (11:14 -0800)]
Remove version checks for _MSC_VER < 1800 (msvs2013).
We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.
TBR=reed
No API changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777213003
Review URL: https://codereview.chromium.org/
1777213003
jvanverth [Thu, 10 Mar 2016 19:10:43 +0000 (11:10 -0800)]
Use correct gradient calculation for rotated distance fields.
For all uniform scaled matrices, we were using the y coordinate of the
y-direction gradient of the v texel space coordinate to scale the
distance values. The problem is, if you rotate by 90 degrees this value
becomes 0. The correct answer is to take the length of the y-direction
gradient.
BUG=skia:4864
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776383002
Review URL: https://codereview.chromium.org/
1776383002
halcanary [Thu, 10 Mar 2016 18:31:53 +0000 (10:31 -0800)]
DM: better SkDocument error message.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780253002
Review URL: https://codereview.chromium.org/
1780253002
mtklein [Thu, 10 Mar 2016 18:10:03 +0000 (10:10 -0800)]
Use std::unique_ptr.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1780933003
brianosman [Thu, 10 Mar 2016 17:47:56 +0000 (09:47 -0800)]
Remove anglesrgb config test - that config was removed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778413002
Review URL: https://codereview.chromium.org/
1778413002
mtklein [Thu, 10 Mar 2016 16:52:05 +0000 (08:52 -0800)]
exclude src/ports/*CG* for all targets
We were not excluding it from iOS builds, which fails including MobileCoreServices.h. (Odd!)
Also remove some redudant exclusions of src/ports/SkImageDecoder_CG.cpp, and sorts.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782903002
Review URL: https://codereview.chromium.org/
1782903002
mtklein [Thu, 10 Mar 2016 16:41:34 +0000 (08:41 -0800)]
Android NDK: r10e -> r11
I have tested that skia_lib builds with {gcc,clang} x {arm_v7_neon,arm64} on my Mac.
Bots seem happy.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780223002
Review URL: https://codereview.chromium.org/
1780223002
senorblanco [Thu, 10 Mar 2016 16:38:45 +0000 (08:38 -0800)]
GrTessellator: abstract vertex allocation into caller.
This abstracts all vertex allocation out of GrTessellator via a VertexBuffer interface. This removes all GPU-related calls from GrTessellator.
It also factors vertex drawing into GrTessellatingPathRenderer::drawVertices(), and makes tessellate() (now draw() also responsible for drawing. This means the cache hit case is clearer as an early-out,
and storing into cache is done in draw() as well.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776003002
Review URL: https://codereview.chromium.org/
1776003002
fmalita [Thu, 10 Mar 2016 16:09:51 +0000 (08:09 -0800)]
Fix GM:XfermodesBlur double unref
TBR=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785483004
Review URL: https://codereview.chromium.org/
1785483004
brianosman [Thu, 10 Mar 2016 15:49:08 +0000 (07:49 -0800)]
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with either FP16 linear or sRGB 8888 frambuffers).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1750383002
Committed: https://skia.googlesource.com/skia/+/
a6f58194733c1c50e4fe5f98585e42344f29b6f0
Review URL: https://codereview.chromium.org/
1750383002
bsalomon [Thu, 10 Mar 2016 15:22:25 +0000 (07:22 -0800)]
Fix readback of 565 on Mac and enable tests
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778143003
Review URL: https://codereview.chromium.org/
1778143003
msarett [Thu, 10 Mar 2016 15:15:59 +0000 (07:15 -0800)]
Do not compile CG on Google3 Linux/Android
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783553003
Review URL: https://codereview.chromium.org/
1783553003
borenet [Thu, 10 Mar 2016 15:01:39 +0000 (07:01 -0800)]
Add isolate_win_toolchain.py
Intended to be run manually by a developer on Windows.
Downloads the requested Windows toolchain, uploads it
to the isolate server, records the isolated hash in
the JSON file and uploads a CL to update that file.
BUG=skia:4553, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775073002
Review URL: https://codereview.chromium.org/
1775073002
robertphillips [Thu, 10 Mar 2016 14:56:21 +0000 (06:56 -0800)]
Update debugger to use SkPixmap
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782673003
Review URL: https://codereview.chromium.org/
1782673003
reed [Thu, 10 Mar 2016 14:36:49 +0000 (06:36 -0800)]
sk_sp versions of newWithColorFilter and newWithLocalMatrix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782703002
Review URL: https://codereview.chromium.org/
1782703002
borenet [Thu, 10 Mar 2016 13:49:48 +0000 (05:49 -0800)]
Move llvm from deps to deps_os
Re-upload of https://codereview.chromium.org/
1721943003/
TBR=bsalomon
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782793003
Review URL: https://codereview.chromium.org/
1782793003
msarett [Thu, 10 Mar 2016 13:44:43 +0000 (05:44 -0800)]
Update Skia's YUV API
We should match the recently designed API in SkCodec.
https://codereview.chromium.org/
1549473003/
This requires changes in Chromium as well.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1716523002
Committed: https://skia.googlesource.com/skia/+/
095d31c8a0eeb5d491febf064bc3c8a44e22b94f
Review URL: https://codereview.chromium.org/
1716523002
yujieqin [Thu, 10 Mar 2016 13:15:49 +0000 (05:15 -0800)]
Add a quick check to the TIFF header of DNG image
BUG=b/
27475341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782063002
Review URL: https://codereview.chromium.org/
1782063002
robertphillips [Thu, 10 Mar 2016 12:44:20 +0000 (04:44 -0800)]
Switch SkMergeImageFilter over to new onFilterImage interface
This relies on CL: https://codereview.chromium.org/
1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1763223002
Review URL: https://codereview.chromium.org/
1763223002
bsalomon [Thu, 10 Mar 2016 02:44:43 +0000 (18:44 -0800)]
Restore SkImage::NewTextureFromPixmap changes.
6ceeebd37a43d879c120b6ba100ae1febdd67a18 contained the fix for the issues that prompted the revert (index8 bitmaps weren't drawing).
Revert "TBR=robertphillips@google.com"
This reverts commit
236640872fa8cad105273055fdcf6829d5c025a1.
TBR=
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775263004
Review URL: https://codereview.chromium.org/
1775263004
reed [Wed, 9 Mar 2016 23:21:32 +0000 (15:21 -0800)]
un-restore test, as bug is not fixed
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783633002
TBR=
Review URL: https://codereview.chromium.org/
1783633002
msarett [Wed, 9 Mar 2016 23:12:31 +0000 (15:12 -0800)]
Don't build CG on Linux CMake
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784663002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1784663002
joshualitt [Wed, 9 Mar 2016 23:07:01 +0000 (15:07 -0800)]
Create explicit microhttpd.gyp
Committed: https://skia.googlesource.com/skia/+/
80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1779903002
Review URL: https://codereview.chromium.org/
1779903002
bsalomon [Wed, 9 Mar 2016 22:50:15 +0000 (14:50 -0800)]
TBR=robertphillips@google.com
Revert "Add SkImage::NewTextureFromPixmap"
This reverts commit
045afea97902936869d71389e656a9c6917fa32f.
Revert "Fix Mac bots because of failing readback of 565"
This reverts commit
e344b26a7d3c0efaab21bb17fa5b2d96dfc92edf.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777863003
Review URL: https://codereview.chromium.org/
1777863003
reed [Wed, 9 Mar 2016 22:47:34 +0000 (14:47 -0800)]
SkImage now has makeShader to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785473002
Review URL: https://codereview.chromium.org/
1785473002
reed [Wed, 9 Mar 2016 22:26:26 +0000 (14:26 -0800)]
unify peekPixels around pixmap parameter
requires this chrome CL to land first
https://codereview.chromium.org/
1775393003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784563002
Review URL: https://codereview.chromium.org/
1784563002
joshualitt [Wed, 9 Mar 2016 22:26:15 +0000 (14:26 -0800)]
Revert of Create explicit microhttpd.gyp (patchset #6 id:100001 of https://codereview.chromium.org/
1779903002/ )
Reason for revert:
breaking per commit housekeeper
Original issue's description:
> Create explicit microhttpd.gyp
>
> Committed: https://skia.googlesource.com/skia/+/
80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
TBR=bungeman@google.com,jcgregorio@google.com,ethannicholas@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1781853002
msarett [Wed, 9 Mar 2016 22:20:58 +0000 (14:20 -0800)]
Add an SkImageGeneratorCG
This will serve as a replacement for SkImageDecoder_CG.
BUG=skia:4914
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1718273004
Review URL: https://codereview.chromium.org/
1718273004
joshualitt [Wed, 9 Mar 2016 22:19:37 +0000 (14:19 -0800)]
Add a bit more to the python test driver
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1773263002
Review URL: https://codereview.chromium.org/
1773263002
joshualitt [Wed, 9 Mar 2016 22:00:52 +0000 (14:00 -0800)]
Create explicit microhttpd.gyp
Review URL: https://codereview.chromium.org/
1779903002
projects / platform / upstream / libSkiaSharp.git / log