platform/upstream/dotnet/runtime.git
7 years agoUpdate trusted RHEL build Dockertag to support LTO (dotnet/coreclr#12396)
Daniel Podder [Wed, 21 Jun 2017 02:39:49 +0000 (19:39 -0700)]
Update trusted RHEL build Dockertag to support LTO (dotnet/coreclr#12396)

The new RHEL image was generated using the same Dockerfile as the
previous, but has LLVM recompiled with gold support enabled, which is
required to do a build with -flto (a prerequisite for PGO).

Commit migrated from https://github.com/dotnet/coreclr/commit/bed557d59ab60ede4204d6186ca7daf57eb7869c

7 years agoStub Environment from registry apis inside app-containers. (CoreCLR) (dotnet/coreclr...
Atsushi Kanamori [Tue, 20 Jun 2017 23:44:56 +0000 (16:44 -0700)]
Stub Environment from registry apis inside app-containers. (CoreCLR) (dotnet/coreclr#12390)

We're not going to get exemptions for these inside appcontainers
so we'll change them to behave as they do on Unix (present
an empty reg key that eats writes requests.)

Commit migrated from https://github.com/dotnet/coreclr/commit/c1456fe280d5ea5e3e2f99024d905ce85439493c

7 years agoUpdate building documentation for osx/macOS (dotnet/coreclr#12366)
Tomas Weinfurt [Tue, 20 Jun 2017 23:05:20 +0000 (16:05 -0700)]
Update building documentation for osx/macOS (dotnet/coreclr#12366)

* Update osx-instructions.md

add 10.12 Sierra as minimal needed version and add some more notes for pkg-config add reference to clean.sh

Commit migrated from https://github.com/dotnet/coreclr/commit/d43491dda8f83586f4f4d35679c67509d7920ad3

7 years ago[Local GC] Move handle creation/deletion profiler callbacks out of the GC (dotnet...
Sean Gillespie [Tue, 20 Jun 2017 22:24:05 +0000 (15:24 -0700)]
[Local GC] Move handle creation/deletion profiler callbacks out of the GC (dotnet/coreclr#12314)

* [Local GC] Move handle creation and handle destruction profiler
callbacks out of the GC

* Remove dead code

* Move some handle-related code out of gcheaputilities.cpp and into gchandleutilities.cpp

* Address code review feedback, remove some more dead code and add some style fixes

* Refactor handle creation and destruction helpers to go through a common function

Commit migrated from https://github.com/dotnet/coreclr/commit/e7725a6ff986879f8ff2fd9e09ab636545ba7bca

7 years ago[RyuJIT/ARM32] Implement storing multi-reg/HFA return value at caller (dotnet/coreclr...
Hyung-Kyu Choi [Tue, 20 Jun 2017 21:09:22 +0000 (06:09 +0900)]
[RyuJIT/ARM32] Implement storing multi-reg/HFA return value at caller (dotnet/coreclr#12294)

* [RyuJIT/ARM32] Initial implementation of multi-reg return

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* [RyuJIT/ARM32] Update multi-reg return for ARM32

- Update comment
- Remove wrong implementation
- Handle HFA struct correctly by consitering type

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* Update comments for GetABIReturnReg() and GetABIReturnRegs()

- Remove and update obsolete comment
- Fix format

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/cf63336cbc2597801d62e399be6bdba8938d1034

7 years agoMerge pull request dotnet/coreclr#11629 from pentp/Math-perf
Eric Mellino [Tue, 20 Jun 2017 17:02:02 +0000 (13:02 -0400)]
Merge pull request dotnet/coreclr#11629 from pentp/Math-perf

Optimized Math.Sign

Commit migrated from https://github.com/dotnet/coreclr/commit/69fcf9059b01b252027a4a0b5414b9a78bc13e7c

7 years agoUpdate CI to follow up corefx changes (dotnet/coreclr#12384)
Hyung-Kyu Choi [Tue, 20 Jun 2017 16:21:13 +0000 (01:21 +0900)]
Update CI to follow up corefx changes (dotnet/coreclr#12384)

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/9189de275ead3107de872df10dfe571417f5576c

7 years ago.clang format from jit (dotnet/coreclr#12377)
Sergey Andreenko [Tue, 20 Jun 2017 05:40:25 +0000 (22:40 -0700)]
.clang format from jit (dotnet/coreclr#12377)

Commit migrated from https://github.com/dotnet/coreclr/commit/fed72a18f637fa8b124de312865dfeb157845fdd

7 years agoMerge pull request dotnet/coreclr#12313 from kyulee1/st
Carol Eidt [Mon, 19 Jun 2017 23:10:53 +0000 (16:10 -0700)]
Merge pull request dotnet/coreclr#12313 from kyulee1/st

Remove static for function pointer

Commit migrated from https://github.com/dotnet/coreclr/commit/da0f1a7dd5f662e5ed03238c863f62a9d3bfa77b

7 years agoDon't close passed in FileStream handles in constructor (dotnet/coreclr#12253)
Jeremy Kuhne [Mon, 19 Jun 2017 22:31:01 +0000 (15:31 -0700)]
Don't close passed in FileStream handles in constructor (dotnet/coreclr#12253)

* Don't close passed in FileStream handles in constructor

As the finalizer will run when throwing we need to be
careful to make sure we don't put the passed-in handle
in the member field until we're sure we've succeeeded.

Additionally we need to make sure any wrapping SafeHandle
we create on a passed in IntPtr isn't collected.

* Move platform specific assertion and add comment.

* Comment- fix mistake in CanSeekCore

Commit migrated from https://github.com/dotnet/coreclr/commit/8a8bda14a618b14264cb85c012e097b3e01992e9

7 years agoFixing CompareInfo AssemblyMode.Full serialization between Core <--> Desktop (dotnet...
Viktor Hofer [Mon, 19 Jun 2017 20:59:38 +0000 (22:59 +0200)]
Fixing CompareInfo AssemblyMode.Full serialization between Core <--> Desktop (dotnet/coreclr#12365)

* Fixing CompareInfo AssemblyMode.Full serialization

* Adding reason why culture field is introduced

Commit migrated from https://github.com/dotnet/coreclr/commit/b2cd406d76546d075cdcb79c3255c113f7f1dbfa

7 years agoMerge pull request dotnet/coreclr#12055 from mikedn/lower-long-relops
Pat Gavlin [Mon, 19 Jun 2017 20:10:49 +0000 (13:10 -0700)]
Merge pull request dotnet/coreclr#12055 from mikedn/lower-long-relops

[WIP] Simplify long relop lowering

Commit migrated from https://github.com/dotnet/coreclr/commit/de46ffbca9ee78cf28c30f9f5599171be045ecd5

7 years agoILLink Performance Tests: Enable MusicStore
Swaroop Sridhar [Wed, 24 May 2017 00:19:15 +0000 (17:19 -0700)]
ILLink Performance Tests: Enable MusicStore

Enable the Musicstore tests, since the failure in JitBench is
now fixed.

Commit migrated from https://github.com/dotnet/coreclr/commit/215a4ff0880ecd64f76826942c95b231162668d0

7 years ago[RyuJIT/ARM32] Update LinearScan::resolveLocalRef() for ARM32 (dotnet/coreclr#12194)
Hyung-Kyu Choi [Mon, 19 Jun 2017 17:47:37 +0000 (02:47 +0900)]
[RyuJIT/ARM32] Update LinearScan::resolveLocalRef() for ARM32 (dotnet/coreclr#12194)

Update LinearScan::resolveLocalRef()
- Always update two float register consisting a double register
- Use helper function for ARM32 double register
- Use stronger assertion condition

Introduce updateAssignedInterval() to update assigned interval
of ARM32 register considering register type.

Commit migrated from https://github.com/dotnet/coreclr/commit/f6ce70eb9b6cb08b4ca0fb91692d284a1d37e37b

7 years agoMerge pull request dotnet/coreclr#12364 from adiaaida/removeSudoThroughput
Michelle McDaniel [Mon, 19 Jun 2017 16:16:01 +0000 (09:16 -0700)]
Merge pull request dotnet/coreclr#12364 from adiaaida/removeSudoThroughput

Remove sudo from throughput run

Commit migrated from https://github.com/dotnet/coreclr/commit/312354c3203318e6cc18071903f8daf122b25d88

7 years agoUpdate CoreClr, CoreFx to preview1-25419-02, preview1-25419-02, respectively (dotnet...
dotnet-maestro-bot [Mon, 19 Jun 2017 15:51:33 +0000 (08:51 -0700)]
Update CoreClr, CoreFx to preview1-25419-02, preview1-25419-02, respectively (dotnet/coreclr#12342)

Commit migrated from https://github.com/dotnet/coreclr/commit/383c35f0c2cb28cb215cbeddd1510afcb0a4716a

7 years agoRemove sudo from throughput run
Michelle McDaniel [Mon, 19 Jun 2017 15:24:22 +0000 (08:24 -0700)]
Remove sudo from throughput run

Sudo is not necessary for running throughput testing, so remove sudo so
we don't run into requests for passwords if the ubuntu machines are not
set up correctly.

Commit migrated from https://github.com/dotnet/coreclr/commit/f0f453d7ab1326ef9b7139fdb9fe7795a9df061f

7 years agoCleanup most code in StringBuilder (dotnet/coreclr#10156)
James Ko [Sun, 18 Jun 2017 13:53:45 +0000 (09:53 -0400)]
Cleanup most code in StringBuilder (dotnet/coreclr#10156)

* Cleanup most code in StringBuilder

* Respond to PR feedback

* Document StringBuilder's fields

* VerifyClassInvariant -> AssertInvariants

* Fix always-true assert

* Respond to PR feedback from @stephentoub

Commit migrated from https://github.com/dotnet/coreclr/commit/a8aa9b6c8ef0ce6e1f0cb482a1fbe619926e7c05

7 years agoMerge pull request dotnet/coreclr#12335 from mikedn/assert-prop-alloc
Pat Gavlin [Sun, 18 Jun 2017 02:43:46 +0000 (19:43 -0700)]
Merge pull request dotnet/coreclr#12335 from mikedn/assert-prop-alloc

Remove unnecessary bitvec allocation in assertion prop

Commit migrated from https://github.com/dotnet/coreclr/commit/cd72c54483f9ccdcde08cb42a683d2b4df181378

7 years agoFurther improve perf of Char.IsWhiteSpace (dotnet/coreclr#12353)
Stephen Toub [Sun, 18 Jun 2017 01:40:38 +0000 (21:40 -0400)]
Further improve perf of Char.IsWhiteSpace (dotnet/coreclr#12353)

IsWhiteSpaceLatin1 is not being inlined.  By changing a range check done with two comparison operations to instead be done with a subtraction and a single comparison, the code is shortened to not only be less expensive but also then get inlined into IsWhiteSpace and then further into String.IsNullOrWhiteSpace.  The net result is a measurable throughput improvement for IsNullOrWhiteSpace.

Commit migrated from https://github.com/dotnet/coreclr/commit/7c197b63914af560d467e8a95c04177495f160d9

7 years agoMerge pull request dotnet/corertdotnet/coreclr#3911 from jkotas/nmirror-merge
Jan Kotas [Sat, 17 Jun 2017 21:07:16 +0000 (14:07 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3911 from jkotas/nmirror-merge

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/d6d35047a2d0ef27ccfe5c55bbacdb99bda84e44

7 years agoAdd regression test for issue dotnet/coreclr#12224 (dotnet/coreclr#12331)
Jan Vorlicek [Sat, 17 Jun 2017 14:36:46 +0000 (16:36 +0200)]
Add regression test for issue dotnet/coreclr#12224 (dotnet/coreclr#12331)

This change adds regression test for EH getting stuck in an infinite
loop when NullReferenceException happens inside a handler of another
NullReferenceException.

Commit migrated from https://github.com/dotnet/coreclr/commit/16d41f11e55d1e137cb799d7b1884e02df600c66

7 years agoRemove some dead argument checks for unsigned primitives for less than zero (dotnet...
Hugh Bellamy [Sat, 17 Jun 2017 14:32:10 +0000 (21:32 +0700)]
Remove some dead argument checks for unsigned primitives for less than zero (dotnet/coreclr#12349)

* Remove dead comparisons of unsigned primitive less than zero

* Delete bad assertition that is consistently hit using the Debug coreclr using the tests

Commit migrated from https://github.com/dotnet/coreclr/commit/34f33a8ccb1ce0f522ea14edde8ceb976997855f

7 years agoFix chained hardware exception handling on Unix (dotnet/coreclr#12344)
Jan Vorlicek [Sat, 17 Jun 2017 12:13:39 +0000 (14:13 +0200)]
Fix chained hardware exception handling on Unix (dotnet/coreclr#12344)

There is an issue when hardware exception occurs while handling another hardware exception. In such case,
the exception unwinding ends up in an infinite loop. It is caused by the kernel reusing the same location
for signal handler context.

The fix is to use a windows style context local variable in the common_signal_handler that contains
the right context - it is the original signal context converted to windows style context.

Commit migrated from https://github.com/dotnet/coreclr/commit/a02634eb41284dbd432ef84aa38f526f955e5f64

7 years agoThrow ArgumentNullException on Unix calling Marshal.IsComObject(null) (dotnet/coreclr...
Hugh Bellamy [Sat, 17 Jun 2017 10:49:26 +0000 (17:49 +0700)]
Throw ArgumentNullException on Unix calling Marshal.IsComObject(null) (dotnet/coreclr#12348)

Commit migrated from https://github.com/dotnet/coreclr/commit/a6ed71c6472c8ea0f680507ae34f56aeaf6bb3d2

7 years agoFix perf.groovy
Swaroop Sridhar [Sat, 17 Jun 2017 01:50:31 +0000 (18:50 -0700)]
Fix perf.groovy

Fix perf.groovy so that ILLink perf tests can be triggered.

Commit migrated from https://github.com/dotnet/coreclr/commit/a98c8f20475dbdbfc5e9bdafcfdabf0e8826d5d5

7 years agoLoadFromResolve event handler should return null incase of any load error (dotnet...
Gaurav Khanna [Sat, 17 Jun 2017 00:26:11 +0000 (17:26 -0700)]
LoadFromResolve event handler should return null incase of any load error (dotnet/coreclr#12329)

Commit migrated from https://github.com/dotnet/coreclr/commit/27e625f0108915fb514e20c870072fbef2d6291c

7 years agoFix CompareInfo.Version on Windows (dotnet/coreclr#12330)
Tarek Mahmoud Sayed [Fri, 16 Jun 2017 22:53:03 +0000 (15:53 -0700)]
Fix CompareInfo.Version on Windows (dotnet/coreclr#12330)

We call Windows to get the sort version. We call Windows passing the structure NlsVersionInfoEx but Windows expect we have to initialize the size of this structure which we are missing.

Commit migrated from https://github.com/dotnet/coreclr/commit/660a3e67071e0273eaffe44cf08b72ed675c3ddc

7 years agoSecurity build JSONs. (dotnet/coreclr#12279)
Ravi Eda [Fri, 16 Jun 2017 22:31:17 +0000 (17:31 -0500)]
Security build JSONs. (dotnet/coreclr#12279)

Commit migrated from https://github.com/dotnet/coreclr/commit/d055dcf991a0a24d6c9542cf0f1e5d69e7403205

7 years agoUpdate CoreClr, CoreFx to preview1-25416-04, preview1-25416-02, respectively (dotnet...
dotnet-maestro-bot [Fri, 16 Jun 2017 21:30:57 +0000 (14:30 -0700)]
Update CoreClr, CoreFx to preview1-25416-04, preview1-25416-02, respectively (dotnet/coreclr#12319)

Commit migrated from https://github.com/dotnet/coreclr/commit/01ab148528b5b6216c848c1aff4d1efd7cff77bf

7 years agoAdd path to exception messages (dotnet/coreclr#12322)
Dan Moseley [Fri, 16 Jun 2017 20:45:27 +0000 (13:45 -0700)]
Add path to exception messages (dotnet/coreclr#12322)

* Remove dead code

* Arg_PathIllegal

* IO_PathTooLong

* Remove no longer necessary path sanitization

* Argument_PathFormatNotSupported

* Arg_PathIllegalUNC

* Arg_InvalidSearchPattern

* Dead strings

* Missing nameof

Commit migrated from https://github.com/dotnet/coreclr/commit/6ba74dc2a7194f8d6c86c3aeab572a074ef645c8

7 years agoRemove unnecessary bitvec allocation in assertion prop
Mike Danes [Fri, 16 Jun 2017 18:50:07 +0000 (21:50 +0300)]
Remove unnecessary bitvec allocation in assertion prop

optVnNonNullPropCurStmt is called for each node and every time it allocates an empty BitVec because optNonNullAssertionProp_Call and optAssertionProp_Ind require it, they are also used in other code paths that do provide a non-empty BitVec.

Commit migrated from https://github.com/dotnet/coreclr/commit/53cc741cb949c540834172ee0e813a01bdcfae28

7 years agoMerge pull request dotnet/coreclr#12203 from wtgodbe/Timing
William Godbe [Fri, 16 Jun 2017 18:45:54 +0000 (11:45 -0700)]
Merge pull request dotnet/coreclr#12203 from wtgodbe/Timing

Fix timing issues in some baseservices tests

Commit migrated from https://github.com/dotnet/coreclr/commit/9f0fc63eb9157bbb547ebeb8ab389a7d98cc7f9f

7 years agoMerge pull request dotnet/coreclr#12321 from BruceForstall/FixMeasureSize2
Bruce Forstall [Fri, 16 Jun 2017 17:26:45 +0000 (10:26 -0700)]
Merge pull request dotnet/coreclr#12321 from BruceForstall/FixMeasureSize2

Convert size measurements for nodes to unsigned __int64

Commit migrated from https://github.com/dotnet/coreclr/commit/81fbe2dd57bbf8334b7065a3d7a9db201f7d9334

7 years agoRemove unused source causing restore error
Christopher Costa [Fri, 16 Jun 2017 16:39:13 +0000 (09:39 -0700)]
Remove unused source causing restore error

Commit migrated from https://github.com/dotnet/coreclr/commit/ec9383bcdc7a21942104e18abff823805e82db78

7 years ago[ARM] Set local variables as addr-exposed (for LEGACY_BACKEND) (dotnet/coreclr#12237)
Jonghyun Park [Fri, 16 Jun 2017 15:50:43 +0000 (00:50 +0900)]
[ARM] Set local variables as addr-exposed (for LEGACY_BACKEND) (dotnet/coreclr#12237)

Commit migrated from https://github.com/dotnet/coreclr/commit/16d58b4e2555a8efadba07b57f763f4d7e9a7423

7 years agoDisable Portable RID build for Tizen (dotnet/coreclr#12292)
Hyung-Kyu Choi [Fri, 16 Jun 2017 13:13:46 +0000 (22:13 +0900)]
Disable Portable RID build for Tizen (dotnet/coreclr#12292)

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/72d31187429b9e421433a1db87a5d09e4ea824be

7 years agoFix chained hardware exception handling on Unix (dotnet/coreclr#12316)
Jan Vorlicek [Fri, 16 Jun 2017 11:23:34 +0000 (13:23 +0200)]
Fix chained hardware exception handling on Unix (dotnet/coreclr#12316)

There is an issue when hardware exception occurs while handling another hardware exception. In such case,
the exception unwinding ends up in an infinite loop. It is caused by the kernel reusing the same location
for signal handler context.

The fix is to use the windows style context local variable in the common_signal_handler that contains
the right context - it is the original signal context converted to windows style context.

Commit migrated from https://github.com/dotnet/coreclr/commit/b594d588bc8a7778c30cf0445599ce97cc2edac9

7 years agoMerge pull request dotnet/coreclr#12320 from BruceForstall/CompactGenTreeCall2
Bruce Forstall [Fri, 16 Jun 2017 07:06:05 +0000 (00:06 -0700)]
Merge pull request dotnet/coreclr#12320 from BruceForstall/CompactGenTreeCall2

Compact the size of GenTreeCall nodes

Commit migrated from https://github.com/dotnet/coreclr/commit/23cbc3e9a2d8b0602a8e154b15b2a11ced71c17f

7 years agoMerge pull request dotnet/coreclr#12185 from hqueue/arm/ryujit/lsra_11851_resolve_edges
Carol Eidt [Fri, 16 Jun 2017 02:27:07 +0000 (19:27 -0700)]
Merge pull request dotnet/coreclr#12185 from hqueue/arm/ryujit/lsra_11851_resolve_edges

[RyuJIT/ARM32] Select proper temp register when resolving edges

Commit migrated from https://github.com/dotnet/coreclr/commit/237cbb52f15dc1e8587819626309eb3450e067d6

7 years agoCompact the size of GenTreeCall nodes
Bruce Forstall [Fri, 16 Jun 2017 02:24:50 +0000 (19:24 -0700)]
Compact the size of GenTreeCall nodes

The data stored in GenTreeCall under `#ifdef FEATURE_MULTIREG_RET`
(defined for x86 (RyuJIT), amd64/Linux, arm32, arm64) was poorly
packed. Improving this reduces x86 GenTreeCall node size from 124 to 112 bytes.
Since GenTreeCall is the largest node, it also reduces the size of all
"large" nodes.

Commit migrated from https://github.com/dotnet/coreclr/commit/989ba91ef9f5fd76384a18f9a05b75fc73b7b3d0

7 years agoConvert size measurements for nodes to unsigned __int64
Bruce Forstall [Fri, 16 Jun 2017 02:20:14 +0000 (19:20 -0700)]
Convert size measurements for nodes to unsigned __int64

I found these numbers overflowing a size_t on x86 with a long
SuperPMI run.

Commit migrated from https://github.com/dotnet/coreclr/commit/b11d827dcddaff312293b0d21def4c7da5d2c7fc

7 years agoMerge pull request dotnet/coreclr#12298 from dotnet/revert-12227-PR-12197
Jarret Shook [Fri, 16 Jun 2017 01:13:50 +0000 (18:13 -0700)]
Merge pull request dotnet/coreclr#12298 from dotnet/revert-12227-PR-12197

Revert "[Arm64] JIT_WriteBarrier optimization"

Commit migrated from https://github.com/dotnet/coreclr/commit/f4781d3a6ff2ca9a5553810f8b0fb624a7dfda08

7 years ago[x86/Linux] Enable gcMarkFilterVarsPinned (WIN64EXCEPTIONS) (dotnet/coreclr#11281)
Hanjoung Lee [Fri, 16 Jun 2017 00:53:44 +0000 (09:53 +0900)]
[x86/Linux] Enable gcMarkFilterVarsPinned (WIN64EXCEPTIONS) (dotnet/coreclr#11281)

* [x86/Linux] Enable gcMarkFilterVarsPinned

Do gcMarkFilterVarsPinned() for WIN64EXCEPTIONS

* [x86/Linux] GCInfo : Force this pointer untracked

`this` pointer is now always untracked so we can use pinned flag in tracked lifetimes.
This allows us to make the refs(inside filter) pinned to prevent from double-relocation.

* [x86/Linux] GCInfo : fix comment and formatting

* [x86/Linux] GCInfo : Update

- Force "this" pointer untracked only when "this" is generic context
- Style fixes

* [x86/Linux] GCInfo : remove this_OFFSET_FLAG

Commit migrated from https://github.com/dotnet/coreclr/commit/0c96db33ddb7d784cda9bd0368756046f436e8bc

7 years agoUpdate CoreFx to preview1-25415-03 (dotnet/coreclr#12305)
dotnet-maestro-bot [Thu, 15 Jun 2017 23:05:38 +0000 (16:05 -0700)]
Update CoreFx to preview1-25415-03 (dotnet/coreclr#12305)

Commit migrated from https://github.com/dotnet/coreclr/commit/5580664eb419cb868a3669253d5d9666a3def641

7 years agoRemove static for function pointer
Kyungwoo Lee [Thu, 15 Jun 2017 22:55:34 +0000 (15:55 -0700)]
Remove static for function pointer

qsort with static compare functions crashes with ALTJIT.
It appears due to _guard_check_icall_fptr in Windows 10.
Simply dropping static keyword works.

Commit migrated from https://github.com/dotnet/coreclr/commit/7d12221cbca178280c2f5d576a6fdc538bed35e8

7 years agoMerge pull request dotnet/coreclr#12307 from stephentoub/iswhitespace
Stephen Toub [Thu, 15 Jun 2017 22:49:56 +0000 (18:49 -0400)]
Merge pull request dotnet/coreclr#12307 from stephentoub/iswhitespace

Small cleanup to Char.IsWhiteSpaceLatin1

Commit migrated from https://github.com/dotnet/coreclr/commit/e70c1bd377040ff49ea9a044556debedee1da959

7 years agoMerge pull request dotnet/coreclr#12311 from jashook/arm64_unix_ci
Jarret Shook [Thu, 15 Jun 2017 22:01:00 +0000 (15:01 -0700)]
Merge pull request dotnet/coreclr#12311 from jashook/arm64_unix_ci

Add the arm64 unix CI

Commit migrated from https://github.com/dotnet/coreclr/commit/b73a9d93c9aa8c2c3ca105e235a3d7869484b201

7 years agoFix timing issues in some baseservices tests
wtgodbe [Fri, 9 Jun 2017 20:32:31 +0000 (13:32 -0700)]
Fix timing issues in some baseservices tests

Commit migrated from https://github.com/dotnet/coreclr/commit/2d58bb520fc8beabddeff1a1ba70438ac4192bf0

7 years agoMerge branch 'master' into arm64_unix_ci
Jarret Shook [Thu, 15 Jun 2017 21:36:22 +0000 (14:36 -0700)]
Merge branch 'master' into arm64_unix_ci

Commit migrated from https://github.com/dotnet/coreclr/commit/894ddb42988a1c0d9dcfbf924ded7d7747e4f6ba

7 years agoAdd the arm64 unix CI
jashook [Mon, 17 Apr 2017 22:53:12 +0000 (15:53 -0700)]
Add the arm64 unix CI

This will enable unix arm64 testing in CI. Currently there are no
default tirggers; however, anyone will be able to request the jobs.

Commit migrated from https://github.com/dotnet/coreclr/commit/f75b7093f12137364f1a296545dc6defb528fd10

7 years agoMerge pull request dotnet/coreclr#12310 from dotnet/revert-11743-arm64_unix_ci
Jarret Shook [Thu, 15 Jun 2017 21:31:55 +0000 (14:31 -0700)]
Merge pull request dotnet/coreclr#12310 from dotnet/revert-11743-arm64_unix_ci

Revert "Add the arm64 unix CI"

Commit migrated from https://github.com/dotnet/coreclr/commit/8c4dfb133c7a4d162fdd1030c6316397ab6b892d

7 years agoRevert "Add the arm64 unix CI"
Jarret Shook [Thu, 15 Jun 2017 21:31:30 +0000 (14:31 -0700)]
Revert "Add the arm64 unix CI"

Commit migrated from https://github.com/dotnet/coreclr/commit/1c64ce59afa1d028ee5098166b2030b8a7ed278c

7 years agoMerge pull request dotnet/coreclr#11743 from jashook/arm64_unix_ci
Jarret Shook [Thu, 15 Jun 2017 21:20:11 +0000 (14:20 -0700)]
Merge pull request dotnet/coreclr#11743 from jashook/arm64_unix_ci

Add the arm64 unix CI

Commit migrated from https://github.com/dotnet/coreclr/commit/35ab28fd818de8933f6e02472ea34196b52df40e

7 years agoMerge pull request dotnet/coreclr#12297 from stephentoub/getdatepart
Stephen Toub [Thu, 15 Jun 2017 20:22:10 +0000 (16:22 -0400)]
Merge pull request dotnet/coreclr#12297 from stephentoub/getdatepart

Avoid duplicated computations with DateTime.GetDatePart

Commit migrated from https://github.com/dotnet/coreclr/commit/d5d64fe951e939512eea2bb944691dd427976cc6

7 years agoSmall cleanup to Char.IsWhiteSpaceLatin1
Stephen Toub [Thu, 15 Jun 2017 20:14:32 +0000 (16:14 -0400)]
Small cleanup to Char.IsWhiteSpaceLatin1

For some reason this is resulting in measurably better throughput, in particular for non-whitespace chars, so much so that it's visible in microbenchmarks against string.IsNullOrWhiteSpace.

If nothing else, it's cleaner.

Commit migrated from https://github.com/dotnet/coreclr/commit/2f05efea2ea9e9c9e1ee9772a9da5fae4ca76ad7

7 years agoMerge pull request dotnet/corertdotnet/coreclr#3890 from jkotas/nmirror-merge
Jan Kotas [Thu, 15 Jun 2017 14:32:54 +0000 (07:32 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3890 from jkotas/nmirror-merge

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/dcd16e7fd27fd01309a5e85a20c2d98e0f97a944

7 years agoMerge pull request dotnet/coreclr#12047 from rartemev/issue_4122_2
Roman Artemev [Thu, 15 Jun 2017 19:51:28 +0000 (12:51 -0700)]
Merge pull request dotnet/coreclr#12047 from rartemev/issue_4122_2

Fixed determintaion of need to make code that contains tail.call loop fully interuptible

Commit migrated from https://github.com/dotnet/coreclr/commit/110eebb91dae1a7d2765803be02491802603ef31

7 years ago[Local GC] Fix a number of handle table interface violations (dotnet/coreclr#12277)
Sean Gillespie [Thu, 15 Jun 2017 19:45:12 +0000 (12:45 -0700)]
[Local GC] Fix a number of handle table interface violations (dotnet/coreclr#12277)

* Fix a smattering of GC handle table interface violations

Stub out a few other handle violations

* [Local GC] Add SetExtraInfoForHandle onto GC handle manager interface

* [Local GC] Changes uses of HndGetHandleADIndex to GetHandleContext

* Add HandleGetType to GC handle table interface

1) Change IGCHandleManager methods that take "int" to represent the type of a handle to HandleType, and fix callers to cast to HandleType
2) Add HandleFetchType to IGCHandleManager, returning a HandleType
3) Fix uses of handtablepriv's HandleFetchType and remove the GC directory from the include path

* 9 -> HNDTYPE_WEAK_WINRT, 0 -> HNDTYPE_WEAK_SHORT in assert

Commit migrated from https://github.com/dotnet/coreclr/commit/dda6b6136e21901842758970d831f31687913a35

7 years agoMerge branch 'master' into arm64_unix_ci
Jarret Shook [Thu, 15 Jun 2017 18:28:54 +0000 (11:28 -0700)]
Merge branch 'master' into arm64_unix_ci

Commit migrated from https://github.com/dotnet/coreclr/commit/308c352f07b4e3e0c4069ac1d403900381a0afd5

7 years agoMerge pull request dotnet/coreclr#12287 from briansull/nowarn-SIMD
Brian Sullivan [Thu, 15 Jun 2017 18:16:42 +0000 (11:16 -0700)]
Merge pull request dotnet/coreclr#12287 from briansull/nowarn-SIMD

Crossgen - Disable the Target-dependent SIMD vector types warning

Commit migrated from https://github.com/dotnet/coreclr/commit/d734877cd86016296fc6c6e884a2b119339545ec

7 years agoMerge pull request dotnet/coreclr#12251 from kyulee1/override
Bruce Forstall [Thu, 15 Jun 2017 17:15:47 +0000 (10:15 -0700)]
Merge pull request dotnet/coreclr#12251 from kyulee1/override

Missing override keyword to DoPhase

Commit migrated from https://github.com/dotnet/coreclr/commit/dd2181cde582168752335d7859c92b3274028f77

7 years agoAdd sdmaclea to arm64Users
Steve MacLean [Thu, 15 Jun 2017 15:52:15 +0000 (15:52 +0000)]
Add sdmaclea to arm64Users

Commit migrated from https://github.com/dotnet/coreclr/commit/0d73bbd8c3b26ce311ee4cf8d933bc453de84a0b

7 years agoUpdate CoreClr, CoreFx to preview1-25415-03, preview1-25415-01, respectively (dotnet...
dotnet-maestro-bot [Thu, 15 Jun 2017 15:42:52 +0000 (08:42 -0700)]
Update CoreClr, CoreFx to preview1-25415-03, preview1-25415-01, respectively (dotnet/coreclr#12284)

Commit migrated from https://github.com/dotnet/coreclr/commit/c0214b5a3c22e4134b720f32e72582904b4a11d7

7 years agoRevert "[Arm64] JIT_WriteBarrier optimization (dotnet/coreclr#12227)"
Jarret Shook [Thu, 15 Jun 2017 15:42:07 +0000 (08:42 -0700)]
Revert "[Arm64] JIT_WriteBarrier optimization (dotnet/coreclr#12227)"

This reverts commit dotnet/coreclr@b5914c8d1b20be898b8982a4dfcf9d8e9046b2ec.

Commit migrated from https://github.com/dotnet/coreclr/commit/4aa14e9da9d0f9bf7c0399176b6e0a0b9a9a7eea

7 years agoAvoid duplicated compuations with DateTime.GetDatePart
Stephen Toub [Thu, 15 Jun 2017 15:31:12 +0000 (11:31 -0400)]
Avoid duplicated compuations with DateTime.GetDatePart

- Remove duplicate code in GregorianCalendar. GetDatePart is identical to the implementation in DateTime.  Just reuse it via the Year/Month/Day properties. Also avoids an unnecessary virtual call.
- Then copy GetDatePart into a version that returns year/month/day rather than just one of them.
- And use that in several places throughout corelib where all three are retrieved, avoiding redoing all of the calculations three times.

Commit migrated from https://github.com/dotnet/coreclr/commit/17c23bed6395f3e12dc0b4471b2bb566c3aa136c

7 years ago[RyuJIT/ARM32] Reserve a double register for both TYP_DOUBLE and TYP_FLOAT
Hyung-Kyu Choi [Thu, 15 Jun 2017 08:16:14 +0000 (17:16 +0900)]
[RyuJIT/ARM32] Reserve a double register for both TYP_DOUBLE and TYP_FLOAT

First, try to reserve a double temp register for both TYP_DOUBLE and TYP_FLOAT.
If fails, try to reserve a float temp register for only TYP_FLOAT.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/a0a4799cdea1d779f40579c9223de6bf9ae996f2

7 years ago[RyuJIT/ARM32] Fix typo
Hyung-Kyu Choi [Wed, 14 Jun 2017 03:36:03 +0000 (12:36 +0900)]
[RyuJIT/ARM32] Fix typo

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/64dc94178e3f30b4026ed6b64005af48845e4b46

7 years ago[Arm64] JIT_WriteBarrier optimization (dotnet/coreclr#12227)
Steve MacLean [Thu, 15 Jun 2017 06:35:49 +0000 (02:35 -0400)]
[Arm64] JIT_WriteBarrier optimization (dotnet/coreclr#12227)

* [Arm64] JIT_WriteBarrier optimization

Add skipEphemeralCheck if gcServer=1

Copy all gc parameters into a literal pool which
fits in single cache line

Add dmb ishst on gcHeap changes

Reduce unpredictable branches

Remove unneeded instructiuons

Fixes dotnet/coreclr#11374
Fixes dotnet/coreclr#12197

* [Arm64] fix typo in asm

* Fixup asm

* [Arm64] Revise per comments

Nits - Whitespace, Labels to PascalCase
Fix state change order
Add Suspend/Resume to fix race
Fix errors in Windows arm64 assembly

* [Arm64] Remove SuspendEE/RestartEE in StompWriteBarrierResize

* Use Volatile<> for g_highest_address

* Revise synchronization per comments

Commit migrated from https://github.com/dotnet/coreclr/commit/b5914c8d1b20be898b8982a4dfcf9d8e9046b2ec

7 years agoRemove unused forward declaration (dotnet/coreclr#12288)
Jonghyun Park [Thu, 15 Jun 2017 06:06:41 +0000 (15:06 +0900)]
Remove unused forward declaration (dotnet/coreclr#12288)

Commit migrated from https://github.com/dotnet/coreclr/commit/34320b9242f4e16eedcb9adc2f0901702b19deac

7 years agoFix build break
chcosta [Thu, 15 Jun 2017 06:05:46 +0000 (23:05 -0700)]
Fix build break

Download from Azure task does not retain blob prefix when downloading blobs.

Commit migrated from https://github.com/dotnet/coreclr/commit/ac5484c841eb5ecab69526aeb6400be45308383f

7 years agoCrossgen - Disable the Target-dependent SIMD vector types warning
Brian Sullivan [Thu, 15 Jun 2017 01:44:12 +0000 (18:44 -0700)]
Crossgen - Disable the Target-dependent SIMD vector types warning

When a SIMD type is referenced during CEEPreloader instead of loading it
we throw a type load exception with a unique resource ID and message.
This commit changed the ICorCompileDataStore interface to allow us to pass
the unique resource ID over to the zapper from the VM.

The Zapper can then demote certain resource ID warnings down to the
lowest informational level, so that they aren't printed out  during crossgen.
With this commit we currently are demoting IDS_EE_SIMD_NGEN_DISALLOWED

Commit migrated from https://github.com/dotnet/coreclr/commit/f79d7e81f70739ab9ae266382aecdfd8c750d06d

7 years agoUpdate CoreClr to preview1-25414-05 (dotnet/coreclr#12282)
dotnet-maestro-bot [Thu, 15 Jun 2017 00:29:45 +0000 (17:29 -0700)]
Update CoreClr to preview1-25414-05 (dotnet/coreclr#12282)

Commit migrated from https://github.com/dotnet/coreclr/commit/f5f2e55f67c098d326988aff1f7616fd34ccdf56

7 years agoUpdate buildtools to 2.0.0-prerelease-01714-04 (dotnet/coreclr#12280)
chcosta [Thu, 15 Jun 2017 00:28:10 +0000 (17:28 -0700)]
Update buildtools to 2.0.0-prerelease-01714-04 (dotnet/coreclr#12280)

Commit migrated from https://github.com/dotnet/coreclr/commit/d83f176fdc71dc321eb33a7ea8e20150c5e62e9d

7 years agoFix NullReferenceException thrown when using CurrentCulture (dotnet/coreclr#12281)
Tarek Mahmoud Sayed [Wed, 14 Jun 2017 23:36:24 +0000 (16:36 -0700)]
Fix NullReferenceException thrown when using CurrentCulture (dotnet/coreclr#12281)

CurrentCulture used the static field s_userDefaultCulture which used to store the current culture. We always ensure this field is initialized all the time. When we introduced the v2.0 added APIs, we have added ClearCachedData(). This method was setting s_userDefaultCulture to null which can cause any other thread to throw this NullReferenceException if it is using s_userDefaultCulture. Here is example of such stack

System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace :
   at System.Globalization.NumberFormatInfo.get_CurrentInfo()
   at System.Double.ToString(String format, IFormatProvider provider)

Commit migrated from https://github.com/dotnet/coreclr/commit/018e5252ed8427aeffea43a2935114149e10bc1b

7 years agoRenaming serializable field (dotnet/coreclr#12273)
Viktor Hofer [Wed, 14 Jun 2017 19:57:36 +0000 (21:57 +0200)]
Renaming serializable field (dotnet/coreclr#12273)

Commit migrated from https://github.com/dotnet/coreclr/commit/7f00fec141ca1b222b1c113d2de055e80728bb99

7 years agoRemove the warning about Implicit boxing during crossgen (dotnet/coreclr#12274)
Brian Sullivan [Wed, 14 Jun 2017 19:57:20 +0000 (12:57 -0700)]
Remove the warning about Implicit boxing during crossgen (dotnet/coreclr#12274)

Commit migrated from https://github.com/dotnet/coreclr/commit/2ffe2ba52989a224a524027227509acf1735ca96

7 years agoMerge pull request dotnet/coreclr#12272 from jashook/add_documentation_for_building_t...
Jarret Shook [Wed, 14 Jun 2017 19:47:55 +0000 (12:47 -0700)]
Merge pull request dotnet/coreclr#12272 from jashook/add_documentation_for_building_tests_on_unix

Add documentation for building test(s) on Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/5db60d53a783e1d4a04ec7289b2571a7bcc27d18

7 years agoAdd documentation for building test(s) on Unix
jashook [Wed, 14 Jun 2017 17:01:58 +0000 (10:01 -0700)]
Add documentation for building test(s) on Unix

This also includes steps on how to build individual tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/ba2acbdfe136cb5ab1b875368ed2768193d59b5e

7 years agoFix a COMDouble::Round() issue (dotnet/coreclr#12210)
Han Lee [Wed, 14 Jun 2017 16:14:18 +0000 (09:14 -0700)]
Fix a COMDouble::Round() issue (dotnet/coreclr#12210)

* Fix a COMDouble::Round() issue
fixes https://github.com/dotnet/coreclr/issues/12137

* Add a couple tests for Math.Round(double)
based on https://github.com/dotnet/coreclr/issues/12137

* Use G17 format specifier for printing double values

Commit migrated from https://github.com/dotnet/coreclr/commit/395f145ba0c220afb1d85ff8c26f34909d8ea424

7 years agoUpdate CoreClr to preview1-25414-04 (dotnet/coreclr#12270)
dotnet-maestro-bot [Wed, 14 Jun 2017 16:09:10 +0000 (09:09 -0700)]
Update CoreClr to preview1-25414-04 (dotnet/coreclr#12270)

Commit migrated from https://github.com/dotnet/coreclr/commit/7b051348604398af834713af786ac7d6ee3e5bc7

7 years agoAdd `-PortableBuild=false` option in Tizen CI build (dotnet/coreclr#12241)
Jiyoung Giuliana Yun [Wed, 14 Jun 2017 14:50:51 +0000 (23:50 +0900)]
Add `-PortableBuild=false` option in Tizen CI build (dotnet/coreclr#12241)

Commit migrated from https://github.com/dotnet/coreclr/commit/a2ecf158bf2618e46510ea67352b08fd66ed854b

7 years agoAdditional to fix dotnet/coreclr#12104 for CoreRT issue dotnet/coreclr#3672 (armel...
sergey ignatov [Wed, 14 Jun 2017 14:28:12 +0000 (17:28 +0300)]
Additional to fix dotnet/coreclr#12104 for CoreRT issue dotnet/coreclr#3672 (armel tizen) (dotnet/coreclr#12244)

* Additional to fix dotnet/coreclr#12104 for CoreRT issue dotnet/coreclr#3672 (armel tizen)

* Fix for unregistered info.compLvFrameListRoot

Commit migrated from https://github.com/dotnet/coreclr/commit/9255b5ea1acac68f62207f03dab509de97da93a9

7 years agoFix gethashcode for ordinal comparer (dotnet/coreclr#12267)
Viktor Hofer [Wed, 14 Jun 2017 11:34:45 +0000 (13:34 +0200)]
Fix gethashcode for ordinal comparer (dotnet/coreclr#12267)

Fix GetHashCode for ordinal comparer

Commit migrated from https://github.com/dotnet/coreclr/commit/905efa9828b0b02fcbfd339d155982aa4b36f8be

7 years agoRewrite of OpCodeGen.pl script to generate correctly IL OpCodes (dotnet/coreclr#12040)
Jacek Blaszczynski [Wed, 14 Jun 2017 06:16:26 +0000 (08:16 +0200)]
Rewrite of OpCodeGen.pl script to generate correctly IL OpCodes (dotnet/coreclr#12040)

* Rewrite of OpCodeGen.pl script to generate correctly IL OpCodes related C# code: FlowControl.cs, OpCodes.cs, OpCodeTypes.cs, OperandType.cs, StackBehaviour.cs from opcode.def file

* Update OpcodeType.cs to OpCodeType.cs in System.Private.CorLib.csproj

Commit migrated from https://github.com/dotnet/coreclr/commit/116a6cc7dd0ff0912251f7d1febed36460ea11cd

7 years agoImprove the packing of RefPosition (dotnet/coreclr#12263)
Bruce Forstall [Wed, 14 Jun 2017 06:16:05 +0000 (23:16 -0700)]
Improve the packing of RefPosition (dotnet/coreclr#12263)

The LSRA RefPosition type was not packing well. In particular,
bitfields don't pack unless they have the same base type.

Move all the data member declarations to the top, and make them adjacent,
so it is easier to see them all together. Also, change all bitfields
to "unsigned char" base type.

This reduces the size from 36 to 28 bytes for x86, and 48 to 40 bytes
for x64 (release, on Windows).

Commit migrated from https://github.com/dotnet/coreclr/commit/d7e2ca54816f6a8bda589fde91a5e395f0896d29

7 years ago[Arn64/Unix] Revise Volatile.T barriers (dotnet/coreclr#12156)
Steve MacLean [Wed, 14 Jun 2017 06:04:01 +0000 (02:04 -0400)]
[Arn64/Unix] Revise Volatile.T barriers (dotnet/coreclr#12156)

* [Arm64] Revise Volatile<T> barriers

* Remove VolateStore from CopyValueClassUnchecked

* Replace MemoryBarrier() in CopyValueClassUnchecked

Commit migrated from https://github.com/dotnet/coreclr/commit/d23a2bc131eae32c473e39fcb3b640af1a95d244

7 years agoKeep previous cmake arguments when using buildstandalonegc (dotnet/coreclr#12108)
Omair Majid [Wed, 14 Jun 2017 05:39:08 +0000 (01:39 -0400)]
Keep previous cmake arguments when using buildstandalonegc (dotnet/coreclr#12108)

Currently, using buildstandalonegc makes ./build.sh discard any
previous values of __cmakearg set explicitly or implicitly. Preserve
those arguments.

Without this fix, the following invocations behave differently:

    $ ./build.sh ignorewarnings buildstandalonegc verbose

    $ ./build.sh buildstandalonegc ignorewarnings verbose

Commit migrated from https://github.com/dotnet/coreclr/commit/d2f9e21c69e70f1d0edac2392ff95d4670edff6e

7 years agoUpdate CoreClr, CoreFx to preview1-25414-02, preview1-25414-01, respectively (dotnet...
dotnet-maestro-bot [Wed, 14 Jun 2017 05:29:42 +0000 (22:29 -0700)]
Update CoreClr, CoreFx to preview1-25414-02, preview1-25414-01, respectively (dotnet/coreclr#12258)

Commit migrated from https://github.com/dotnet/coreclr/commit/40228489c1340b02567a23a263378872fcc45fba

7 years agoRemove serializable attribute from OrdinalIgnoreCaseComparer (dotnet/coreclr#12215)
Viktor Hofer [Wed, 14 Jun 2017 01:49:02 +0000 (03:49 +0200)]
Remove serializable attribute from OrdinalIgnoreCaseComparer (dotnet/coreclr#12215)

* Remove serializable attribute from OrdinalIgnoreCaseComparer

* Introducing OrdinalCaseSensitiveComparer to serialize correctly with netfx

* Updated PR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/fe22770b9fe8f665679bde1c08d1372fb9f78e0e

7 years agoMerge pull request dotnet/coreclr#12255 from briansull/concat-fix
Brian Sullivan [Wed, 14 Jun 2017 00:55:05 +0000 (17:55 -0700)]
Merge pull request dotnet/coreclr#12255 from briansull/concat-fix

Removed the unused vararg version of String Concat

Commit migrated from https://github.com/dotnet/coreclr/commit/9def2055bab6e154806a800816a05ab811f056f6

7 years agoRemoved the unused vararg version of String Concat
Brian Sullivan [Tue, 13 Jun 2017 21:19:30 +0000 (14:19 -0700)]
Removed the unused vararg version of String Concat

The __arglist version of varargs is not supported on CoreCLR

Fixes issue dotnet/coreclr#12146 - crossgen warning - Vararg calling convention not supported.

Added a new test case for String Concat
Added <DebugType>None
Fixed src\JIT\Directed\Misc\gettype csproj as well

Commit migrated from https://github.com/dotnet/coreclr/commit/91c8ecf830d0d336bff3337019d6501f6efafc12

7 years agoSkip PGO if clang is too old, and add warnings for skipped PGO (dotnet/coreclr#12248)
Daniel Podder [Tue, 13 Jun 2017 21:51:55 +0000 (14:51 -0700)]
Skip PGO if clang is too old, and add warnings for skipped PGO (dotnet/coreclr#12248)

Clang/LLVM cannot merge profile data generated by a newer version of
itself. Training currently requires 3.6, but we don't want to completely
break the build for 3.5. I'm adding a version check to allow non-PGO
release builds on 3.5, along with a warning message. I'm also updating
the LTO detection to print a warning message if it causes PGO to be
disabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/94788b256bc2aaa930341e27dc5ae3baf3bbf8b5

7 years agoAdded the checked CORE_ROOT path to this
Brian Sullivan [Tue, 13 Jun 2017 20:57:33 +0000 (13:57 -0700)]
Added the checked CORE_ROOT path to this

Commit migrated from https://github.com/dotnet/coreclr/commit/25bc371325b21a4bed9e0337192dd04ad7051b54

7 years agoMerge pull request dotnet/coreclr#12092 from wtgodbe/CoreDisTools
William Godbe [Tue, 13 Jun 2017 20:55:54 +0000 (13:55 -0700)]
Merge pull request dotnet/coreclr#12092 from wtgodbe/CoreDisTools

Explicitly download correct version of CoreDisTools package

Commit migrated from https://github.com/dotnet/coreclr/commit/7e8cb3efb7556eea02ad43292b8baa8651e14e79

7 years agoSpecified where the failing tests are listed.
Brian Sullivan [Tue, 13 Jun 2017 20:08:43 +0000 (13:08 -0700)]
Specified where the failing tests are listed.

Commit migrated from https://github.com/dotnet/coreclr/commit/000343606a00124501cec18badc9ca551a636dc1

7 years agoUpdated the path for the test results html file
Brian Sullivan [Tue, 13 Jun 2017 20:04:12 +0000 (13:04 -0700)]
Updated the path for the test results html file

Commit migrated from https://github.com/dotnet/coreclr/commit/33908992423ac89e7e2fa5af903ce2a3d81d3623

7 years agoFixed typo
Brian Sullivan [Tue, 13 Jun 2017 19:59:42 +0000 (12:59 -0700)]
Fixed typo

Commit migrated from https://github.com/dotnet/coreclr/commit/6708d2db1b51bc2695c7fef2e62eed04701dc598

7 years agoUpdated for checked build testing and corrected some paths
Brian Sullivan [Tue, 13 Jun 2017 19:58:37 +0000 (12:58 -0700)]
Updated for checked build testing and corrected some paths

Commit migrated from https://github.com/dotnet/coreclr/commit/7c02f85f175f3c96b0c77b3683f5132e6dccaacf

7 years agoMissing override keyword to DoPhase
Kyungwoo Lee [Tue, 13 Jun 2017 18:37:14 +0000 (11:37 -0700)]
Missing override keyword to DoPhase

Commit migrated from https://github.com/dotnet/coreclr/commit/a075b765d3ce3707c50f0a87c5c6a8a7e4c65f68