Aaron Robinson [Thu, 16 Aug 2018 18:21:51 +0000 (11:21 -0700)]
Build-test.sh handles native test assets (dotnet/coreclr#19430)
* Respect Windows script argument to skip package building.
* Bring build.sh logic closer to build.cmd with respect to passing CMAKE flags for building tests
* Make cmake gen script find override file without using script arguments
* build-test.sh can now build native test projects
Remove compileoptions.cmake and push contents into configurecompiler.cmake
which contains compiler configuration from repo root CMakeLists.txt
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0f42d4c0fc3cfd782b89171840e2590604392cd
Koundinya Veluri [Thu, 16 Aug 2018 18:20:55 +0000 (11:20 -0700)]
Some JitBench fixes (dotnet/coreclr#19479)
Some JitBench fixes
- Fixed `dotnet run` from the `unofficial_dotnet` folder after `Directory.Build.targets` was added to `coreclr/tests/src`. This file is auto-imported and was adding dependencies and properties for targets that were not necessary. Added files to the root JitBench folder to override.
- Updated JitBench to be able to run against netcoreapp3.0. I haven't changed the default yet, could consider doing so once there are no pending perf issues being looked into.
- Added a `RetargetProjects()` function to the setup steps to replace `TargetFramework` and `RuntimeFrameworkVersion` values in the relevant `.csproj` files to run against the expected runtime. This reduces some dependency on other repos containing the actual perf projects such that we don't have to update every repo to support environment variables to set those values.
- Disabled tiering for the `MinOpts` config
Commit migrated from https://github.com/dotnet/coreclr/commit/
72e9b8d589f114776e3f42058d721058b77133b9
Andy Ayers [Thu, 16 Aug 2018 16:22:05 +0000 (09:22 -0700)]
JIT: bail out in optExtractArrIndex for constant array length (dotnet/coreclr#19493)
Generalize the bail out pattern to handle cases from spans where we may
see a known array length in a bounds check.
Fixes dotnet/coreclr#19454
Commit migrated from https://github.com/dotnet/coreclr/commit/
a52128e8f59f7f824862ff4ecde0d8d9ae1631ef
Pent Ploompuu [Thu, 16 Aug 2018 15:40:59 +0000 (18:40 +0300)]
Optimize NumberBufferToDecimal (dotnet/coreclr#19072)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f5e5d912751b1cec481ec3b3c35cb8c7a4adf0a
Carol Eidt [Thu, 16 Aug 2018 15:11:00 +0000 (08:11 -0700)]
Merge pull request dotnet/coreclr#19396 from CarolEidt/Fix19288
Fix non-lclVar odd-byte struct passing
Commit migrated from https://github.com/dotnet/coreclr/commit/
da7cf5626753baeef42e7bd2d95f2dfe1c894553
Jeremy Kuhne [Thu, 16 Aug 2018 04:16:43 +0000 (21:16 -0700)]
Make file handle checks accurate on Windows (dotnet/coreclr#19508)
* Make handle checks accurate on Windows
We can actually check the async state of a handle on Windows, so check directly when we have the API available.
Also allow all filetypes through when explicitly using extended syntax `\\?\` .
* Fix nits
* Don't throw in the handle constructor overloads
* Whoops
* Removing the close handle entirely. No adverse effects from closing a bad handle- or leaving it open for that matter.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3da101be85ee07b9b625f03b7570a03a5cd028cc
Koundinya Veluri [Thu, 16 Aug 2018 02:43:15 +0000 (19:43 -0700)]
Revert "Temporarily flag a SIMD test as optimization-sensitive (dotnet/coreclr#19163)" (dotnet/coreclr#19505)
This reverts commit dotnet/coreclr@
855ddf52c7b05994cf6728b9169fa6cdc694a537. Issue https://github.com/dotnet/coreclr/issues/19124 was fixed by PR https://github.com/dotnet/coreclr/pull/19234, so re-enabling the test in minopts and with tiering.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c64cede37e206829af24237de037e3c14f7b3cc
elyoh [Thu, 16 Aug 2018 01:03:50 +0000 (02:03 +0100)]
Update JapaneseLunisolarCalendar.cs (dotnet/coreclr#19504)
Corrects an issue with the conversion table for Gregorian to Japanese lunisolar dates.
See: dotnet/coreclr#19450.
Issue: data discrepancy in year 1962.
Table entry for 1962 has incorrect days per month for months 6 and 7.
Notes
The DaysPerMonth flag uses the binary literal for ease of readability.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c258c092b125aa607b669649ddd0e2c0107ccf06
Andy Ayers [Thu, 16 Aug 2018 00:05:28 +0000 (17:05 -0700)]
JIT: properly handle special-case varargs params in minopts (dotnet/coreclr#19489)
We were previously marking all lcl vars as implicitly referenced in minopts,
but there are some special varargs params that can't ever be marked as
referenced, either implicitly or explicitly.
Special case these when computing or checking ref counts in minopts.
Closes dotnet/coreclr#19349.
Commit migrated from https://github.com/dotnet/coreclr/commit/
81c0e509c0e948385268e209db0696f2bbddd575
Jan Kotas [Wed, 15 Aug 2018 22:55:24 +0000 (15:55 -0700)]
Revert "Change CoreLib native image to be R2R by default on all platforms (dotnet/coreclr#19359)" (dotnet/coreclr#19501)
This reverts commit dotnet/coreclr@
d485659348af3528b688ac5b7e4c58dacba6de58.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8e22205c4d9c8660449f66fabe7a1e46c681023
Luqun Lou [Wed, 15 Aug 2018 22:52:28 +0000 (15:52 -0700)]
Add Public API Marshal.IsTypeVisibleFromCom and Marshal.GetEndComSlot (dotnet/coreclr#19507)
Commit migrated from https://github.com/dotnet/coreclr/commit/
81455f6fe9e078902f1fb331ae81d85c4d001c5f
Amy Yu [Wed, 8 Aug 2018 23:52:53 +0000 (16:52 -0700)]
R2RDump - GcInfo for x86
x86 GcInfo headers
x86 GcSlotTable
x86 GcTransitions
Update expected xml for R2RDumpTests
Add license headers
Allow multiple GcTransitions with same codeOffset
Add index property in GcSlot, make GcSlot a class instead of struct, add missing spaces, update tests
Remove placeholder functions for parsing partially interruptible pointer tables
Implement partially interruptible GcInfo
Example GcInfo output:
CodeLength: 22 bytes
InfoHdr:
PrologSize: 7
EpilogSize: 4
EpilogCount: 1
EpilogAtEnd: yes
Callee-saved regs = EBP
EbpFrame: yes
Fully Interruptible: yes
DoubleAlign: no
Arguments Size: 0 DWORDs
Stack Frame Size: 1 DWORDs
UntrackedCnt: 1
VarPtrTableSize: 0
GenericsContext: 0
GenericsContextIsMethodDesc: 0
ReturnKind: RT_Scalar
RevPInvokeOffset: 0
Epilogs: 18
GcSlots:
-------------------------
[EBP-4]
Flags: GC_SLOT_UNTRACKED
LowBits:
-------------------------
28fc: 55 push ebp
28fd: 8b ec mov ebp, esp
28ff: 50 push eax
2900: 89 4d fc mov dword ptr [ebp - 4], ecx
2903: 8b 4d fc mov ecx, dword ptr [ebp - 4]
2906: ff 15 10 10 01 10 call dword ptr [
268505104]
reg ECX becoming live
290c: 90 nop
reg ECX becoming dead
290d: 90 nop
290e: 8b e5 mov esp, ebp
2910: 5d pop ebp
2911: c3 ret
Commit migrated from https://github.com/dotnet/coreclr/commit/
26286b460e53d03ec8b74b85f09c0754bb10605f
dotnet-maestro-bot [Wed, 15 Aug 2018 19:30:35 +0000 (12:30 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03115-01, preview1-26815-04, preview1-26815-04, preview1-26815-01, master-
20180815-0120, respectively (dotnet/coreclr#19494)
Commit migrated from https://github.com/dotnet/coreclr/commit/
024f809869d156f73ea6d7527d9664ce90b5505e
Bruce Forstall [Wed, 15 Aug 2018 03:56:16 +0000 (20:56 -0700)]
Merge pull request dotnet/coreclr#19487 from acmyu/disable
ExcludeList for R2RDumpTests in wrong ItemGroup
Commit migrated from https://github.com/dotnet/coreclr/commit/
3b6210ecb565847dc5e6b5bb01a97e9b09f56a15
Marco Rossignoli [Wed, 15 Aug 2018 01:56:43 +0000 (03:56 +0200)]
Add TypeConverter fallback to DefaultValueAttribute (dotnet/coreclr#19354)
Commit migrated from https://github.com/dotnet/coreclr/commit/
431d041b7697a7ce307caa6090fab01ffd7ae652
Mike McLaughlin [Wed, 15 Aug 2018 01:22:23 +0000 (18:22 -0700)]
Update debugging and createdump docs. (dotnet/coreclr#19495)
Commit migrated from https://github.com/dotnet/coreclr/commit/
21f94f2be12e16bb36187d40c2fa82af9ebfd469
Amy Yu [Tue, 14 Aug 2018 20:19:46 +0000 (13:19 -0700)]
ExcludeList for R2RDumpTests in wrong ItemGroup
Commit migrated from https://github.com/dotnet/coreclr/commit/
99efd808657686aed0d1f3ecab393678ede6a5f9
dotnet-maestro-bot [Tue, 14 Aug 2018 15:08:16 +0000 (08:08 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03110-01, preview1-26814-06, preview1-26814-01, preview1-26814-01, master-
20180814-0056, respectively (dotnet/coreclr#19377)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e20a920fb2caffbee7fba96c295f3a8185700be
Amy [Tue, 14 Aug 2018 14:02:49 +0000 (07:02 -0700)]
Disable R2RDumpTests (dotnet/coreclr#19475)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1c2db2f50bf34e7d0aebab9f9b5969bfd9f46fc
Jan Kotas [Tue, 14 Aug 2018 13:34:34 +0000 (06:34 -0700)]
Delete dead code (dotnet/coreclr#19452)
Unused strong name signing paths and related code
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b5e0648bdaa1abacea803b90384f9b937af9fc3
Tomáš Rylek [Tue, 14 Aug 2018 10:37:19 +0000 (12:37 +0200)]
Translate [rip +- offset] to absolute RVA's in R2RDump (dotnet/coreclr#19219)
* Translate [rip +- offset] to absoluate RVA's in R2RDump
The existing logic for displaying rip-relative addressed on X64
make it very hard to calculate the final addresses. I have added
a horrendous hack using textual analysis of the disassembled
instruction to translate this notation to absolute RVA's.
As part of this effort I have also encapsulated the CorDisTools
helper in a new class Disassembler that also contains customizable
provisions for handling special assembly cases on the individual
architectures.
Thanks
Tomas
* Temporarily block out disassembly to make tests pass
In my initial commit I removed the line blocking out disassembly
however this ends up failing several lab tests so I'm putting the
line back.
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
66b3197f69cf4669ba04a7a8121d33d9aa5d3c9d
Mike McLaughlin [Tue, 14 Aug 2018 07:46:13 +0000 (00:46 -0700)]
Code review feedback for the alternate stack changes (PR dotnet/coreclr#19309). (dotnet/coreclr#19476)
Fixed SOS plugin for core dumps.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c509903171fedf0a4a6f9fffeb6e2b9820f537c2
Andon Andonov [Tue, 14 Aug 2018 03:43:10 +0000 (20:43 -0700)]
Update URLs and exclusion list for staging (dotnet/coreclr#19423)
* Update URLs and exclusion list for staging
* Update Failing tests
* Fix IO test namespace
* Add 2 failing Ubuntu tests
* Exclude test under Ubuntu
* Add regressed test
* Roll-back CI URLs
* Add issue number
Commit migrated from https://github.com/dotnet/coreclr/commit/
821016dc0d94c08a40701f75a09a3d355c515579
Bruce Forstall [Mon, 13 Aug 2018 23:53:22 +0000 (16:53 -0700)]
Merge pull request dotnet/coreclr#19463 from BruceForstall/FixArmHeapVerify
Disable 3 tests for Windows/arm32 HeapVerify runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
21af8273edb1991972dc2223f3de93f249aa4d48
Sergey Andreenko [Mon, 13 Aug 2018 23:16:50 +0000 (16:16 -0700)]
disable tests\src\JIT\Methodical\fp\exgen\10w5d_cs_do (dotnet/coreclr#19465)
in stress modes. The issue is dotnet/coreclr#18988
Commit migrated from https://github.com/dotnet/coreclr/commit/
b0686a29be2eff059f080a66b7aa4febe55a01bc
Bruce Forstall [Mon, 13 Aug 2018 22:21:23 +0000 (15:21 -0700)]
Merge pull request dotnet/coreclr#19469 from BruceForstall/DisableVectorDot
Disable VectorDot_ro.cmd_9267 for Windows arm64 R2R
Commit migrated from https://github.com/dotnet/coreclr/commit/
bf72f70f0e00987470f36bfde89c209c5147fac0
Bruce Forstall [Mon, 13 Aug 2018 22:19:49 +0000 (15:19 -0700)]
Disable VectorDot_ro.cmd_9267 for Windows arm64 R2R
Tracked by dotnet/coreclr#18991
Commit migrated from https://github.com/dotnet/coreclr/commit/
69f9cdb518cf6949f9a58baa2ccb9b70566f431c
Bruce Forstall [Mon, 13 Aug 2018 22:04:49 +0000 (15:04 -0700)]
Merge pull request dotnet/coreclr#19466 from BruceForstall/Disable163200
Disable test b163200 under GCStress
Commit migrated from https://github.com/dotnet/coreclr/commit/
428185baa83bc1a396e862325d5d5eccb096c3b2
Bruce Forstall [Mon, 13 Aug 2018 22:03:23 +0000 (15:03 -0700)]
Disable test b163200 under GCStress
Tracked by dotnet/coreclr#19464
Commit migrated from https://github.com/dotnet/coreclr/commit/
359e8639ff1cdc9b90a2c85b49f6e5e0233c2f92
Bruce Forstall [Mon, 13 Aug 2018 21:06:29 +0000 (14:06 -0700)]
Disable 3 tests for Windows/arm32 HeapVerify runs
They all time out.
Fixes dotnet/coreclr#19462
Commit migrated from https://github.com/dotnet/coreclr/commit/
ebe90ae3c9ccd874c4512b9bc3b3c1b025ca2d21
Bruce Forstall [Mon, 13 Aug 2018 19:42:25 +0000 (12:42 -0700)]
Merge pull request dotnet/coreclr#19459 from BruceForstall/Disable437044
Exclude 437044.cmd_10304 from GCStress runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa4c1c47f9b49e5ee7b320038bb30dfa736bc450
Bruce Forstall [Mon, 13 Aug 2018 19:40:23 +0000 (12:40 -0700)]
Exclude 437044.cmd_10304 from GCStress runs
This test times out on ARM Windows R2R GCStress15 runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c3772b699ab37a07d1be7dd770f693f60b277d8
Omair Majid [Mon, 13 Aug 2018 19:38:37 +0000 (15:38 -0400)]
Add a skipmanaged option to build.sh (dotnet/coreclr#19111)
This option is the opposite of -msbuildonunsupportedplatform, and an
managed version of of -skipnative.
This is useful for bootstrapping on new Linux/x64 distributions, where
dotnet may not work (yet) but coreclr will try and use it anyway,
failing the bootstrap scripts.
See also https://github.com/dotnet/source-build/issues/663 for
additional background information.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cba21515787850baaf02fbbd550a5267a8a4f4cf
Bruce Forstall [Mon, 13 Aug 2018 19:12:23 +0000 (12:12 -0700)]
Merge pull request dotnet/coreclr#19458 from BruceForstall/DisableTests
Disable System.Linq.Expressions.Tests against dotnet/coreclr#19457
Commit migrated from https://github.com/dotnet/coreclr/commit/
1a5e7515ac7d128518b7ec8ce34f632f5b368e66
Bruce Forstall [Mon, 13 Aug 2018 19:10:50 +0000 (12:10 -0700)]
Disable System.Linq.Expressions.Tests against dotnet/coreclr#19457
Commit migrated from https://github.com/dotnet/coreclr/commit/
5dfbf227c3c4723d9f9bf5064f1a6c41f9c1996e
Robin Sue [Mon, 13 Aug 2018 02:49:39 +0000 (04:49 +0200)]
Remove unused local from List<T>.RemoveRange (dotnet/corefxdotnet/coreclr#31727)
`int i` appears to be unused so i removed it.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f02c30e053b1da4410e20c3b715128e3d1e354a
Anipik [Sun, 12 Aug 2018 22:42:34 +0000 (15:42 -0700)]
non shared changes and feedback addressed
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
35dafea02d196d5acb998c8a4fff3e6a37365db8
Koundinya Veluri [Mon, 13 Aug 2018 01:35:48 +0000 (18:35 -0700)]
Fix a couple of apartment state issues (dotnet/coreclr#19384)
* Fix a couple of apartment state issues
Fix for https://github.com/dotnet/coreclr/issues/17822
- The apartment state now defaults to MTA for the main thread along with a CoInitialize
- Calling `Thread.SetApartmentState` with STA now fails as expected (different behavior from previous netcore, same behavior as netfx)
Fix for https://github.com/dotnet/coreclr/issues/17787
- `WaitHandle.WaitAll` for multiple handles is not supported on an STA thread due to issues described in https://github.com/dotnet/coreclr/issues/17787#issuecomment-
385117537
- It now throws `NotSupportedException` as expected (different behavior from previous netcore, same behavior as netfx)
Fix for https://github.com/dotnet/coreclr/issues/19225
* Temporarily exclude invalid CoreFX test
Commit migrated from https://github.com/dotnet/coreclr/commit/
3a56afe6de4113c83b66a5d3a467b8accfaafa1f
Jeremy Kuhne [Sat, 11 Aug 2018 00:06:39 +0000 (17:06 -0700)]
Create Microsoft.IO.Redist (dotnet/corefxdotnet/coreclr#31679)
* Create Microsoft.Internal.IO
Includes all of Path, Directory, *Info, etc. from System.IO with targets of NetFX 4.6.1 and NetCore 2.1.
* Tweaks / minor fixes
* Remove netstandard build.
* Add package
Update to build for 4.7.2 only
* Rename folder to prepare for project rename
* Change the name to Microsoft.IO.Redist
* Namespace tweaks
* Use open key, tweak references
* More tweaks on feedback
Also grab latest build tools for 4.7.x RIDs
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ccd7a52827a9078b35e167bea488b3389538e92
Simon Nattress [Mon, 13 Aug 2018 00:09:55 +0000 (17:09 -0700)]
Silence WinRT type assert in crossgen (dotnet/coreclr#19442)
Disable type loader assert that fires when resolving a type from a WinMD. Instead, compilation should fail gracefully, or at runtime a type load exception will be thrown.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8589689bc34eb7fab6b33c88505bb041de9e9995
David Mason [Sat, 11 Aug 2018 17:11:49 +0000 (10:11 -0700)]
[local gc] disable feature redhawk (dotnet/coreclr#17769)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d4738d1e9e9b50d00023eb4caca225812cabe285
Jan Kotas [Sat, 11 Aug 2018 14:43:16 +0000 (07:43 -0700)]
Make RuntimeType sealed and deleted support for introspection only loads (dotnet/coreclr#19427)
- Sealed Runtime makes `is RuntimeType` and similar checks faster. These checks are fairly common in reflection.
- Delete support for introspection only loads from the runtime. We do not plan to use in .NET Core. The support for introspection loads inherited from RuntimeType and thus it is incompatible with sealed RuntimeType.
Commit migrated from https://github.com/dotnet/coreclr/commit/
af4ec7c89d0192ad14392da04e8c097da8ec9e48
Anirudh Agnihotry [Sat, 11 Aug 2018 07:31:01 +0000 (00:31 -0700)]
moved to shared (dotnet/coreclr#19419)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f551543427176850c84b9e11c7b8d528c3f282a7
Anirudh Agnihotry [Sat, 11 Aug 2018 06:19:28 +0000 (23:19 -0700)]
Moved SpinLock.cs to shared (dotnet/coreclr#19391)
* m removed from names, spaces after \\ and braces added
* Moved to shared
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2c4c8c4713a029b8c59f481c967dec3c98f005a
Ben Adams [Sat, 11 Aug 2018 05:44:19 +0000 (06:44 +0100)]
Don't early terminate on null for 64bit NR HashCode (dotnet/coreclr#19331)
* Don't early terminate on null for 64bit NR HashCode
* Improved GetNonRandomizedHashCode
* Update message on GetNonRandomizedHashCode
* Consume null terminator rather than special case odd lengths
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9ad0e8656df10f3aab4b989a1dc72e548d24176
Bruce Forstall [Sat, 11 Aug 2018 03:00:44 +0000 (20:00 -0700)]
Merge pull request dotnet/coreclr#19434 from BruceForstall/DisableR2rDumpTest2
Disable R2RDumpTest for JIT stress modes
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c9d4e3be809f11750c6bd1a7c68837f1f3bf343
Bruce Forstall [Sat, 11 Aug 2018 00:41:17 +0000 (17:41 -0700)]
Disable R2RDumpTest for JIT stress modes
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ae96a6054de5334c74c68fb233fc50f21d55d19
Bruce Forstall [Sat, 11 Aug 2018 00:32:02 +0000 (17:32 -0700)]
Merge pull request dotnet/coreclr#19433 from BruceForstall/UpdateTriggerPhrases
Update existing trigger phrases documentation
Commit migrated from https://github.com/dotnet/coreclr/commit/
965cfb4557fd3ee80b3145507c075a5ed6eb380b
Bruce Forstall [Sat, 11 Aug 2018 00:29:59 +0000 (17:29 -0700)]
Update existing trigger phrases documentation
Commit migrated from https://github.com/dotnet/coreclr/commit/
91dbe617eac9b4ac4683c54333c2ece3875268de
Konstantin Baladurin [Fri, 10 Aug 2018 23:10:53 +0000 (02:10 +0300)]
CORDbgSetInstruction: clear thumb bit of the address before flushing icache (dotnet/coreclr#19409)
We should clear thumb bit of the address before flushing icache otherwise
we may not flush the cache for the first byte of the instruction.
Commit migrated from https://github.com/dotnet/coreclr/commit/
303c8b78151bb7a8f17b32f6e22f52a2227146b2
Anirudh Agnihotry [Fri, 10 Aug 2018 23:09:48 +0000 (16:09 -0700)]
Moved to shared (dotnet/coreclr#19399)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee09ff4b55b39bd65aecbe6930ca38b5bda6b80c
David Mason [Fri, 10 Aug 2018 22:40:39 +0000 (15:40 -0700)]
update order of locks so jitstress is unblocked (dotnet/coreclr#19401)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8bd4256dc2e3f001be1fa02e99578db0f46b7586
Carol Eidt [Thu, 9 Aug 2018 23:31:11 +0000 (16:31 -0700)]
Fix non-lclVar odd-byte struct passing
When a non-power-of-2 struct is passed, we can only use an IND if the arg is a local.
Fix dotnet/coreclr#19288
Commit migrated from https://github.com/dotnet/coreclr/commit/
74047ae1244062ef383de15163ac026d8b9f549a
Aditya Mandaleeka [Fri, 10 Aug 2018 20:38:09 +0000 (13:38 -0700)]
Merge pull request dotnet/coreclr#19344 from adityamandaleeka/aa64_vm_callconv_changes
CallDescr/TransitionBlock changes for ARM64 calling convention
Commit migrated from https://github.com/dotnet/coreclr/commit/
30f0be906507bef99d951efc5eb9a1664bde9ddd
Fei Peng [Mon, 6 Aug 2018 22:10:50 +0000 (15:10 -0700)]
Add SoA raytracer as a CQ test for Intel hardware intrinsic
Commit migrated from https://github.com/dotnet/coreclr/commit/
b9028b31caba6e69d1fab99bd1219ae879782802
Bruce Forstall [Fri, 10 Aug 2018 18:43:05 +0000 (11:43 -0700)]
Merge pull request dotnet/coreclr#19414 from BruceForstall/ReduceCorefxInnerloopTesting
Reduce the number of innerloop CoreFX jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
a69e1653ed0734cb0d0192abe302978ee0115b4d
Bruce Forstall [Fri, 10 Aug 2018 18:30:04 +0000 (11:30 -0700)]
Reduce the number of innerloop CoreFX jobs
1. Stop doing any OSX CoreFX jobs; they're too unreliable.
2. Stop running Debug jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
72c1ce3c61e46bbe35c1d95dd80872a43e34b8ef
Bruce Forstall [Fri, 10 Aug 2018 18:10:21 +0000 (11:10 -0700)]
Merge pull request dotnet/coreclr#19387 from dotnetrt/parallel-test-build
Reenable parallel msbuild execution - 2x faster test build
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc512301e04098d3b1c9e6de2e6cd8e19bc1807d
Brian Robbins [Fri, 10 Aug 2018 17:22:40 +0000 (10:22 -0700)]
Align the Contents of EventPipeBuffers (dotnet/coreclr#19375)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6850f7830da3ced9e80948263fe821a3c7a3960
Tanner Gooding [Thu, 9 Aug 2018 19:33:21 +0000 (12:33 -0700)]
Updating the ilproj-sdk to also copy native dependencies from Microsoft.NETCore.JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
88690582f2e310c0277d6bd5a349bfac8858e46f
Aditya Mandaleeka [Thu, 9 Aug 2018 22:43:35 +0000 (15:43 -0700)]
Update DynamicHelper for Unix to match Win.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c891df0a89a995c4e559ef9cefc0c07533ae88b4
Bruce Forstall [Thu, 9 Aug 2018 21:01:34 +0000 (14:01 -0700)]
Merge pull request dotnet/coreclr#19385 from BruceForstall/WhichCoreFxCommit
Print out the checked out commit hash
Commit migrated from https://github.com/dotnet/coreclr/commit/
a7dbd1fd87364d7cd7cd48170254bd9d5b4a7feb
Tanner Gooding [Wed, 8 Aug 2018 18:03:53 +0000 (11:03 -0700)]
Adding the Avx.MaskStore tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
40ffce5bb99c77fafe588583ef9a6c1f1c8db90b
Tanner Gooding [Tue, 7 Aug 2018 20:31:30 +0000 (13:31 -0700)]
Implementing the Avx.MaskStore intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
2110b70551bac4f4ad65fcbbdfd853eea9000b4e
Jacek Blaszczynski [Thu, 9 Aug 2018 18:04:43 +0000 (20:04 +0200)]
Reenable parallel msbuild execution - 2x faster test build
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f386bfb3989c0212bfd7bb9c89e3b6cb859b098
Bruce Forstall [Thu, 9 Aug 2018 18:52:56 +0000 (11:52 -0700)]
Print out the checked out commit hash
This is useful to see exactly which version of CoreFX you are testing against.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ceef2eccb16222ac8c1c64c3254ca7db3d287b9
Tanner Gooding [Thu, 9 Aug 2018 15:02:43 +0000 (08:02 -0700)]
Updating init-tools to be inline with the CoreFX copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce175cbb849378c2ef1985ff3994cd0d82f3d8fe
Tanner Gooding [Thu, 9 Aug 2018 14:56:22 +0000 (07:56 -0700)]
Update CheckProjects to support `DebugType=Embedded` for RelType projects
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d2ca2b50ac35e08f2959c71f30a857cf7d320d9
Tanner Gooding [Wed, 8 Aug 2018 19:52:23 +0000 (12:52 -0700)]
Updating the x86 HWIntrinsic tests to include embedded pdbs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2aa0cf8f53a1f51e3c9f87bf743fc082725165ec
Bruce Forstall [Thu, 9 Aug 2018 18:06:21 +0000 (11:06 -0700)]
Merge pull request dotnet/coreclr#19350 from dotnet/dev/unix_test_workflow
Simplify PR trigger creation; fix related bugs
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b40bfb824e0c50b90e197d9ce877ac6ef09ec5a
Bruce Forstall [Thu, 9 Aug 2018 17:38:09 +0000 (10:38 -0700)]
Merge pull request dotnet/coreclr#19382 from BruceForstall/FixSwitch
Fix `--` application to managed tests build command-line
Commit migrated from https://github.com/dotnet/coreclr/commit/
3cbeacca33c39413161d576829860ec99e6d063b
Bruce Forstall [Thu, 9 Aug 2018 17:20:25 +0000 (10:20 -0700)]
Fix `--` application to managed tests build comamnd-line
Commit migrated from https://github.com/dotnet/coreclr/commit/
c517566e4dd1a540a4c75139e18406393ef89364
Jan Kotas [Thu, 9 Aug 2018 06:29:32 +0000 (23:29 -0700)]
Change CoreLib native image to be R2R by default on all platforms (dotnet/coreclr#19359)
* Change CoreLib native image to be R2R by default on all platforms
* Delete unused argument
Commit migrated from https://github.com/dotnet/coreclr/commit/
d485659348af3528b688ac5b7e4c58dacba6de58
Tanner Gooding [Wed, 8 Aug 2018 22:04:07 +0000 (15:04 -0700)]
Updating init-tools.cmd to pass through PACKAGES_DIR
Commit migrated from https://github.com/dotnet/coreclr/commit/
71f72eee4243dafe1a17441269eb155ccde7ee62
dotnet-maestro-bot [Wed, 8 Aug 2018 20:53:23 +0000 (13:53 -0700)]
Update BuildTools, CoreSetup to preview1-03108-01, preview1-26808-05, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
8d8760291df9c91a0085273a0f0304c17d007a8b
Anirudh Agnihotry [Thu, 9 Aug 2018 03:08:38 +0000 (20:08 -0700)]
Move methodbody and exceptionHandlingClause to shared (dotnet/coreclr#19364)
* Changing names and making runtime files
* Movel methodbody and exceptionHandlingClause to shared
* Fixing build error
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f92fa9f95b0e45935374da29066978719a7701d
Bruce Forstall [Thu, 9 Aug 2018 03:03:13 +0000 (20:03 -0700)]
Merge pull request dotnet/coreclr#19363 from nattress/crossgen_skip_windowsruntime
Skip Crossgen of S.R.WindowsRuntime.dll
Commit migrated from https://github.com/dotnet/coreclr/commit/
e197121636cdde973370fe6a3914a1db3503b922
Bruce Forstall [Thu, 9 Aug 2018 02:53:41 +0000 (19:53 -0700)]
Merge pull request dotnet/coreclr#19367 from BruceForstall/RestorePassThroughArg
Restore handling of __PassThroughArg for `--`
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa80abf431111e6e784007021aff1a24a999b9ab
Aditya Mandaleeka [Thu, 9 Aug 2018 02:30:48 +0000 (19:30 -0700)]
Fix R2R DynamicHelper to use the correct offset to x0 reg.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8eb7b455e251035148e8526fdb512de28cee693b
Anirudh Agnihotry [Wed, 8 Aug 2018 22:54:13 +0000 (15:54 -0700)]
ReNaming and rearranging the variables to reduce the diff (dotnet/coreclr#19338)
* Names changes in managed side and native side
* name changes in native side
* Removing serialization field
* lower case corrected
Commit migrated from https://github.com/dotnet/coreclr/commit/
df8e05daed1d45dc5bcec2614667fc3ec0992ce6
Bruce Forstall [Wed, 8 Aug 2018 21:27:22 +0000 (14:27 -0700)]
Restore handling of __PassThroughArg for `--`
Commit migrated from https://github.com/dotnet/coreclr/commit/
74883eb0ce122ed25510fe47d4e81d5739be3892
Bruce Forstall [Wed, 8 Aug 2018 20:38:23 +0000 (13:38 -0700)]
Merge pull request dotnet/coreclr#19275 from dotnetrt/test-warnings-msbuild
build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1804ad5634ef85d88b52331b99b1f58626dacf2
Andy Ayers [Wed, 8 Aug 2018 20:05:47 +0000 (13:05 -0700)]
JIT: update lvaGrabTemp for new minopts/debug ref counting approach (dotnet/coreclr#19351)
If the jit has started normal ref counting and is in minopts or debug,
set all new temps to be implicitly referenced by default.
Closes dotnet/coreclr#19346.
Commit migrated from https://github.com/dotnet/coreclr/commit/
585cd3685fdad34e8a1ab76b3c98265b26b7aa24
Simon Nattress [Wed, 8 Aug 2018 18:44:33 +0000 (11:44 -0700)]
Skip Crossgen of S.R.WindowsRuntime.dll
System.Runtime.WindowsRuntime contains assembly refs to Windows platform WinMD types which are not available on Unix and required to crossgen the assembly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
83be4e97152212bc045a383720563c179603618a
dotnet-maestro-bot [Wed, 8 Aug 2018 17:02:46 +0000 (10:02 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03107-02, preview1-26808-04, preview1-26807-04, preview1-26807-04, master-
20180808-0056, respectively (dotnet/coreclr#19329)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a84a4d68a2059d03f2f1baa348979e244da4f4d
Bruce Forstall [Wed, 8 Aug 2018 05:56:56 +0000 (22:56 -0700)]
Merge pull request dotnet/coreclr#19343 from BruceForstall/SimplifyPrTriggers
Simplify the code to create PR triggers
Commit migrated from https://github.com/dotnet/coreclr/commit/
f8b94076b5796df62537c5f8f0574426a1ad28fd
Bruce Forstall [Wed, 8 Aug 2018 00:46:43 +0000 (17:46 -0700)]
Simplify the code to create PR triggers
Also, create PR triggers for jobs that currently don't have them
(which is a bug), such as Debug and Release Windows x64 jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1a46af39014796606d1f40ecd090602f987a145
Aditya Mandaleeka [Wed, 8 Aug 2018 00:47:43 +0000 (17:47 -0700)]
Fix non-Windows assembly code to match Windows calldescr/arg reg changes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
093dc0e035d1e15ed4a82d4e6afea3184ea211a5
Aaron Robinson [Wed, 8 Aug 2018 00:42:15 +0000 (17:42 -0700)]
Use dotnet MSBuild for tests (dotnet/coreclr#19324)
* Revert "Revert "Build managed tests with dotnet (dotnet/coreclr#19254)""
* Reenable MSBuild support through dotnet instead of global MSBuild
Commit migrated from https://github.com/dotnet/coreclr/commit/
b4131b9f9dc9c73e47b315fff886db66374b1b21
Konstantin Baladurin [Tue, 7 Aug 2018 23:25:07 +0000 (02:25 +0300)]
FillRegDisplay: initialize volatileCurrContextPointers for ARM and ARM64 (dotnet/coreclr#19332)
We need to initialize volatileCurrContextPointers because they could be
used by GC in the case of the leaf frame. This patch fixes crashes during
GC when we are single stepping using managed debugger.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c488296b594db3054e7cd2af2dab10428ccf0e42
Aditya Mandaleeka [Tue, 7 Aug 2018 22:17:52 +0000 (15:17 -0700)]
Make VM-side changes for ARM64 Windows calling convention.
Commit migrated from https://github.com/dotnet/coreclr/commit/
87174a2fdf97938b0ee8d64a0b784f1c01bf2932
Amy [Tue, 7 Aug 2018 22:06:01 +0000 (15:06 -0700)]
R2RDump - Tests for Debug, avoid copying expected xml files (dotnet/coreclr#19321)
* Add Debug expected xml, pass xml path to R2RDumpTest
* Pass expected xml path as argument
* Remove copy expected xml, clean up
Commit migrated from https://github.com/dotnet/coreclr/commit/
25452220f8486f9ecb56b7ffa84a37d80136b750
Bruce Forstall [Tue, 7 Aug 2018 21:58:12 +0000 (14:58 -0700)]
Add basic check that the correct number of tests is built (dotnet/coreclr#19290)
Fixes dotnet/coreclr#19286
Commit migrated from https://github.com/dotnet/coreclr/commit/
01908e9fe3b5a3c51935e1f6622ef4bf10b805c3
Bruce Forstall [Tue, 7 Aug 2018 21:43:39 +0000 (14:43 -0700)]
Merge pull request dotnet/coreclr#19336 from dotnet/dev/unix_test_workflow
Update vc-runtime package used by Windows ARM/ARM64 testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
525b5e1f990a37c16f4db797e6a5e20419f4059a
Andy Ayers [Tue, 7 Aug 2018 21:42:47 +0000 (14:42 -0700)]
Merge pull request dotnet/coreclr#19325 from AndyAyersMS/RecomputeRefCounts2
JIT: recompute local ref counts after lower
Commit migrated from https://github.com/dotnet/coreclr/commit/
6140e3b35f186a6ba45c311e6b5222d71a8dd8f7
Andy Ayers [Tue, 7 Aug 2018 21:19:29 +0000 (14:19 -0700)]
Merge pull request dotnet/coreclr#19335 from AndyAyersMS/FixDumpIssue
fix bug in jit dump output
Commit migrated from https://github.com/dotnet/coreclr/commit/
d7bbded1a41764eb45e0fc99263725b206646329
David Wrighton [Tue, 7 Aug 2018 20:49:03 +0000 (13:49 -0700)]
Add support to use an indirected address for JMP instructions to ARM64 (dotnet/coreclr#19281)
* Add support to use an indirected address for JMP instructions to ARM64
- Merge logic between ARM and ARM64
Commit migrated from https://github.com/dotnet/coreclr/commit/
fde763073fcce978141bf0b31e4479df507acfb8
Bruce Forstall [Tue, 7 Aug 2018 19:35:11 +0000 (12:35 -0700)]
Merge pull request dotnet/coreclr#19291 from BruceForstall/CleanUpBuildCmd
Clean up build.cmd/build-test.cmd/runtest.cmd
Commit migrated from https://github.com/dotnet/coreclr/commit/
b37c6d8ee5b4ad9833f21cfc30582b56797e37b4
Andy Ayers [Tue, 7 Aug 2018 18:25:00 +0000 (11:25 -0700)]
fix bug in jit dump output
Commit migrated from https://github.com/dotnet/coreclr/commit/
d050a4eae353ae82fb56f34aa8f0afb772fc3181
dotnet-maestro-bot [Tue, 7 Aug 2018 05:37:31 +0000 (22:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-
20180802-0110, respectively (master) (dotnet/coreclr#19263)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-
20180802-0110, respectively
* Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab9b4511180d1dfde09d1480c29a7bbacf3587dd