Andon Andonov [Wed, 27 Jun 2018 21:43:36 +0000 (14:43 -0700)]
Windows CoreFX CI (#18365)
* Add test list CL switch
* End-To-End Test Run on Windows
* Cleanup
* MAX_PATH Workaround
* Set Execution directory for CoreFX tests
* Add All CoreFX PR Tests
* Add test dependencies
* Add extra dependencies
* Add parallel test execution
* Disable OuterLoop tests and System.Data.SqlClient.* tests
* Initialize maximum degree of parallelization to Environment.ProcessCount
* Remove unnecessary cli option
* Update Dependencies
* Add "enabled" property to tests
* Remove exclusions due to TestUtilities mismatch
* Add capability to run all tests for running Helix test lists directly
* Refactor build script to build testhost when skipping managed tests
* Disable failing System.Threading.Tests.EventWaitHandleTests.Ctor_InvalidMode
* Add switch to skip native test build
* Add testing documentation
* Don't run tests marked as "disabled" when running all available tests
* Add switch to build only testhost and remove Core_Root_Stage
* Clean up TopN.CoreFX.Windows.issues.json
* Refactor build-test.cmd
* PR feedback - build pipeline and documentation
* PR Feedback - Test Helper headers and comments
* Fix buildtesthost option for only building CoreFX test dependencies
* Disable intermittently failing test DrawBezier_PointFs
Jan Kotas [Wed, 27 Jun 2018 18:55:04 +0000 (11:55 -0700)]
Merge pull request #18645 from tgiphil/readonly
Changed internal value to readonly for primitive types
Anirudh Agnihotry [Wed, 27 Jun 2018 18:36:42 +0000 (11:36 -0700)]
Moved SafeWaitHandle and cancellationToken to shared (#18662)
* Moving SafeWaitHandle to shared
* Moved CancellationToken to shared
* _ remove from variable names
* Default change to Default(Token) and minor changes
* Fixing coreclr unix build
* moving semaphoreSlim to shared
* splitting safeWaitHandle to .windows and .unix
Brian Robbins [Wed, 27 Jun 2018 01:23:07 +0000 (18:23 -0700)]
Remove conditional compilation of DotNETRuntimeEventSource.cs.
Brian Robbins [Wed, 27 Jun 2018 01:22:46 +0000 (18:22 -0700)]
Fix sync.sh to call run.exe -p even if positional parameters are specified after --.
Carol Eidt [Wed, 27 Jun 2018 18:12:33 +0000 (11:12 -0700)]
Merge pull request #18663 from fiigii/fixapis
Fix Aes and Ssse3.Shuffle intrinsic APIs
Amy [Wed, 27 Jun 2018 16:56:21 +0000 (09:56 -0700)]
Merge pull request #18425 from acmyu/xml
R2RDump - Output in XML format
Brian Sullivan [Wed, 27 Jun 2018 16:51:32 +0000 (09:51 -0700)]
Merge pull request #18130 from sdmaclea/PR-ARM64-JIT-Use-LSE-Atomics
[Arm64] JIT generate LSE Atomics
Marek Safar [Wed, 27 Jun 2018 13:53:24 +0000 (15:53 +0200)]
Removes duplicate attributes (#18668)
Jan Kotas [Wed, 27 Jun 2018 05:38:42 +0000 (22:38 -0700)]
Add VM support for Unsafe.AsRef(in T)
Phil Garcia [Wed, 27 Jun 2018 05:03:49 +0000 (22:03 -0700)]
Applying PR feedback
Henry Sharber [Wed, 27 Jun 2018 03:41:33 +0000 (23:41 -0400)]
More Dead String (#18664)
Removed any strings in \src\inc\corerror.xml that appeared only in one or more of the following:
\src\dlls\mscorrc\mscorrc.rc
\src\pal\prebuilt\corerror\mscorurt.rc
\src\pal\prebuilt\inc\corerror.h
Fix #18420
Michal Strehovský [Tue, 26 Jun 2018 14:17:53 +0000 (16:17 +0200)]
Fix bogus assert in ArraySortHelper (dotnet/corert#6018)
Fixes #6016.
Resolves #6015.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Mon, 25 Jun 2018 23:54:41 +0000 (19:54 -0400)]
Simplify built-in types across corefx (dotnet/corefx#30656)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Fei Peng [Tue, 26 Jun 2018 23:20:54 +0000 (16:20 -0700)]
Fix Aes and Ssse3.Shuffle intrinsic APIs
Amy Yu [Tue, 26 Jun 2018 22:25:02 +0000 (15:25 -0700)]
Fix merge errors, replace spaces with tab, print unwind flag name
Amy Yu [Tue, 26 Jun 2018 21:11:46 +0000 (14:11 -0700)]
Dump disasm line by line, changes to dumping bytes to xml, fix
compilerIdentifier typo
Amy Yu [Fri, 22 Jun 2018 23:17:24 +0000 (16:17 -0700)]
Refactor into TextDumper and XmlDumper classes
Amy Yu [Fri, 22 Jun 2018 01:31:22 +0000 (18:31 -0700)]
Xml serialize section contents and gcinfo transitions
Amy Yu [Wed, 20 Jun 2018 00:57:52 +0000 (17:57 -0700)]
XMLSerialize gc transitions and section contents
Amy Yu [Sat, 16 Jun 2018 00:09:48 +0000 (17:09 -0700)]
Make unwindinfo and gcinfo xml serializable
Amy Yu [Mon, 11 Jun 2018 23:02:50 +0000 (16:02 -0700)]
Output in xml format with XmlSerializer
Amy Yu [Mon, 11 Jun 2018 23:01:39 +0000 (16:01 -0700)]
Add public to classes and set accessor to properties needed for serialization
Amy [Tue, 26 Jun 2018 22:01:14 +0000 (15:01 -0700)]
Merge pull request #18435 from acmyu/unwind
R2RDump - Use symbolic names for opcodes
Jakob Botsch Nielsen [Tue, 26 Jun 2018 14:57:47 +0000 (16:57 +0200)]
Fix value numbering when selecting a constant (#18627)
When applying selectors, constants were special-cased to not require any
type casts. However this is wrong if a narrowing needs to be performed.
Fix #18235
Jan Kotas [Tue, 26 Jun 2018 05:56:03 +0000 (22:56 -0700)]
Delete slack link, standardize on gitter (#18644)
Contributes to https://github.com/dotnet/coreclr/issues/18643
Phil Garcia [Tue, 26 Jun 2018 05:27:59 +0000 (22:27 -0700)]
Changed internal value to readonly to all the primitive types
Bruce Forstall [Mon, 25 Jun 2018 21:55:27 +0000 (14:55 -0700)]
Merge pull request #18585 from BruceForstall/FixArmOffsets
Clean up ARM reserved register handling
Rafael Rivera [Mon, 25 Jun 2018 20:13:11 +0000 (13:13 -0700)]
Remove commentary on non-existent appx checks (#18631)
Remove commentary on non-existent appx checks
Stephen Toub [Mon, 25 Jun 2018 03:21:25 +0000 (23:21 -0400)]
Simplify types in non-shared corelib (dotnet/corert#6008)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Egor Chesakov [Mon, 25 Jun 2018 19:25:49 +0000 (12:25 -0700)]
Cross-bitness regular and thread static fields offsets (#18636)
* Define OFFSETOF__DomainLocalModule__m_pDataBlob_ OFFSETOF__DomainLocalModule__NormalDynamicEntry__m_pDataBlob in src/vm/appdomain.hpp
* Define OFFSETOF__ThreadLocalModule__m_pDataBlob OFFSETOF__ThreadLocalModule__DynamicEntry__m_pDataBlob in src/vm/threadstatics.h
* Add assertions and offsets for dynamically allocated statics
* Compensate OffsetOfDataBlob difference
* Check target specific offsets in assertions in src/vm/methodtablebuilder.cpp
Koundinya Veluri [Mon, 25 Jun 2018 16:41:51 +0000 (09:41 -0700)]
Don't close the JIT func info file on shutdown (#18060)
During shutdown there can be a race between closing/nulling `compJitFuncInfoFile` in `compShutdown` and a background thread trying to write to it after checking that it was not null.
Egor Chesakov [Mon, 25 Jun 2018 16:17:00 +0000 (09:17 -0700)]
Cross-bitness in instance fields placement and CORINFO structs (#18366)
* Replace sizeof(OBJECTREF*) with TARGET_POINTER_SIZE
* Define IN_TARGET_32BIT IN_TARGET_64BIT macros
* Replace IN_WIN32 IN_WIN64 with IN_TARGET_32BIT IN_TARGET_64BIT in src/vm/jitinterface.cpp src/vm/methodtablebuilder.cpp
* Define and use OFFSETOF__CORINFO_* constants in clrjit
* Define for all 64-bit targets
* Use unsigned __int32 to emphasize that this is 32-bit number
* Rename Array__u1Elems to Array__data
* Eliminate OFFSETOF__CORINFO_RefArray__length
* Rename OFFSETOF__CORINFO_RefAny__ to OFFSETOF__CORINFO_TypedReference__
* Fix OFFSETOF__CORINFO_TypedReference__dataPtr macro value
Adeel Mujahid [Mon, 25 Jun 2018 12:23:12 +0000 (15:23 +0300)]
Fix nested-anon-types warnings (#18591)
Andon Andonov [Mon, 25 Jun 2018 05:45:27 +0000 (22:45 -0700)]
Remove test logs (#18621)
hsharber [Mon, 25 Jun 2018 01:18:15 +0000 (21:18 -0400)]
Removed dead strings used in debug-only code (#18622)
Removed strings used in debug-only code in ex.cpp
Fix #18420
Jan Kotas [Sun, 24 Jun 2018 20:45:15 +0000 (13:45 -0700)]
Update to latest released dotnet SDK (#18626)
Anipik [Sun, 24 Jun 2018 04:29:23 +0000 (21:29 -0700)]
non shared changes and disabling tests
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Sun, 24 Jun 2018 12:22:35 +0000 (08:22 -0400)]
Simply type names in Corelib (#18623)
Jan Kotas [Sun, 24 Jun 2018 03:20:58 +0000 (20:20 -0700)]
Use correct basic block to check legality of PInvoke callsite for inlining (#18620)
It is the same logic as used in other similar places
Bruce Forstall [Thu, 21 Jun 2018 02:06:27 +0000 (19:06 -0700)]
Clean up ARM reserved register computations
Tighten up and correct the math in compRsvdRegCheck.
Bruce Forstall [Sat, 23 Jun 2018 16:38:05 +0000 (09:38 -0700)]
Merge pull request #18600 from BruceForstall/FixArmFPFrameAddressLimits
Expand ARM local variable R11-based addressing
Bruce Forstall [Sat, 23 Jun 2018 16:36:45 +0000 (09:36 -0700)]
Merge pull request #18615 from A-And/CIFXStaging
CoreFX CI - Correct testResults path
Stephen Toub [Sat, 23 Jun 2018 14:20:29 +0000 (10:20 -0400)]
Change string.Compare(...) == 0 occurrences to string.Equals(...) (#18616)
Anirudh Agnihotry [Sat, 23 Jun 2018 04:12:42 +0000 (21:12 -0700)]
Moved EventWaitHandle.cs to shared (#18612)
* Removed AccessControl Unused arguments
* moving common code to CreateEventCore and using constructor chaining
* Moving Functions to eventwaithandles.windows
* EventWaitHandle matched with corert
* eventwaithandle.windwos matched with corert
* Addding interop functions
* moved files to shared
* Minor changes
* fixing build for corert unix
* Removing Comment
Adeel Mujahid [Sat, 23 Jun 2018 02:51:03 +0000 (05:51 +0300)]
Pass RID to crossgen (#18592)
Noah Falk [Sat, 23 Jun 2018 02:14:15 +0000 (19:14 -0700)]
Fix incorrect usage of ILCodeVersion::AsNode (issue #18602) (#18606)
When the debugger is querying the active rejit IL for an IL method that has not been rejitted it incorrectly creates a VMPTR_ILCodeVersionNode for a code version that shouldn't have one.
Andon Andonov [Sat, 23 Jun 2018 01:11:18 +0000 (18:11 -0700)]
Correct testResults path
Bruce Forstall [Thu, 21 Jun 2018 23:33:02 +0000 (16:33 -0700)]
Expand ARM local variable R11-based addressing
When addressing a local with negative offsets from R11 (if it can't
be reached from SP), allow the full range of negative offsets allowed
in the instructions. Floating-point load/store especially has a much
bigger range than what was previously allowed.
Andon Andonov [Fri, 22 Jun 2018 22:43:05 +0000 (15:43 -0700)]
Fix incorrect script path (#18613)
Amy Yu [Fri, 22 Jun 2018 22:04:12 +0000 (15:04 -0700)]
Move Amd64 specific class to it's own folder and subnamespace
Anipik [Fri, 22 Jun 2018 18:32:13 +0000 (11:32 -0700)]
Non Shared Changed And feedback
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Andon Andonov [Fri, 22 Jun 2018 20:54:45 +0000 (13:54 -0700)]
Remove trigger phrases and add testhost building (#18608)
Luqun Lou [Fri, 22 Jun 2018 18:33:35 +0000 (11:33 -0700)]
Add public implementation MarshalerSupport (#18530)
Aaron Robinson [Fri, 22 Jun 2018 18:24:22 +0000 (11:24 -0700)]
Start moving testing documentation into a single location (#18598)
Start moving testing documentation into a single location
Update `test-configuration.md` with more details on creating a test and requirements
Russ Keldorph [Thu, 21 Jun 2018 20:49:04 +0000 (13:49 -0700)]
Update package version to 3.0.0
This doesn't make much practical difference since CoreCLR's packages aren't
intended for any consumers other than core-setup, but we might as well try
to be consistent with our peer repos in case it provides a useful hint when
something goes wrong.
Carol Eidt [Fri, 22 Jun 2018 16:11:16 +0000 (09:11 -0700)]
Merge pull request #18581 from CarolEidt/Reenable18295
Re-enable tests after fixing 18295
Bruce Forstall [Fri, 22 Jun 2018 06:05:42 +0000 (23:05 -0700)]
Merge pull request #18595 from BruceForstall/FixArmEncoderLimits
Fix ARM encoder limits
Anirudh Agnihotry [Fri, 22 Jun 2018 01:39:23 +0000 (18:39 -0700)]
Moved Semaphore.cs and Semaphore.Windows.cs to shared (#18597)
* TryOpenexistingworker and createsemaphore moved to semaphore.windows.cs
* Common code moved to verifyCounts and CreateMutexCore and then moved to semaphore.windows.cs
* CreateSemaphore merged with CreateSemaphore core
* Moving interop functions from win32Native to inteop.kernel32
* Moving the files to shared
* Minor Formating
Stephen Toub [Fri, 22 Jun 2018 01:36:59 +0000 (21:36 -0400)]
Update behaviors of new TextWriter StringBuilder overloads (#18578)
Two issues addressed:
- CancellationToken was being ignored; the overloads should check whether cancellation was requested. This applies to the existing Write{Line}Async overloads that were added in 2.1.
- The other overloads support inputs (string, char[], etc.) being null, and just treat that the same as an empty string. We should do the same for StringBuilder rather than throwing.
Amy [Thu, 21 Jun 2018 23:19:05 +0000 (16:19 -0700)]
Merge pull request #18570 from acmyu/bugs
R2RDump - Bug fixes
Andon Andonov [Thu, 21 Jun 2018 23:04:54 +0000 (16:04 -0700)]
Windows CoreFX CI Staging Commit (#18388)
* Netci
* Add fake test switch
* Add branch PR trigger
* Add Checked corefx_innerloop jobs
Gleb Balykov [Thu, 21 Jun 2018 22:16:58 +0000 (01:16 +0300)]
Fix unset ZapRelocationType for fixup (#18589)
Bruce Forstall [Thu, 21 Jun 2018 20:11:13 +0000 (13:11 -0700)]
Fix ARM encoder limits
The ARM encoder was using slightly incorrect limits when deciding whether
a particular constant offset was allowed in an addressing mode.
Change the limits to match the instruction definitions.
Bruce Forstall [Thu, 21 Jun 2018 15:57:44 +0000 (08:57 -0700)]
Merge pull request #18031 from kbaladurin/fix-hfa-tests
[JIT/ARM] Fix Compiler::lvaFrameAddress
dotnet-maestro-bot [Thu, 21 Jun 2018 12:34:29 +0000 (05:34 -0700)]
Update PgoData to master-
20180621-0050 (#18587)
Jan Kotas [Thu, 21 Jun 2018 03:38:07 +0000 (20:38 -0700)]
Undo accidental 2.0 -> 2.1 renames (dotnet/corert#5981)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Adeel Mujahid [Thu, 21 Jun 2018 00:06:28 +0000 (03:06 +0300)]
Rev netcoreapp2.0 to netcoreapp2.1 (dotnet/corert#5974)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot [Thu, 21 Jun 2018 03:38:51 +0000 (20:38 -0700)]
Update CoreClr, CoreFx to preview1-26621-01, preview1-26621-01, respectively (#18584)
Wes Haggard [Wed, 20 Jun 2018 23:59:20 +0000 (16:59 -0700)]
Merge pull request #18552 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02920-01, preview1-26620-04, preview1-26620-03, master-
20180620-0039, respectively (master)
Alfred Myers [Wed, 20 Jun 2018 23:31:00 +0000 (20:31 -0300)]
Fixed method name in comment (#18571)
Carol Eidt [Wed, 20 Jun 2018 23:26:58 +0000 (16:26 -0700)]
Merge pull request #18573 from CarolEidt/ExplicitLayoutTest
Add another test for #17971
Carol Eidt [Wed, 20 Jun 2018 22:43:19 +0000 (15:43 -0700)]
Re-enable tests after fixing 18295
dotnet-maestro-bot [Wed, 20 Jun 2018 22:03:51 +0000 (15:03 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02920-01, preview1-26620-04, preview1-26620-03, master-
20180620-0039, respectively
Carol Eidt [Wed, 20 Jun 2018 21:55:12 +0000 (14:55 -0700)]
An UnusedValue still requires a target reg (#18561)
* An UnusedValue still requires a target reg
The BuildSimple method wasn't creating a def for an unused value. Although (in this case) the code is dead, the code generator must still be able to generate code for it.
* Add test case for #18295 to arm/arm64 tests.lst
Marco Rossignoli [Wed, 20 Jun 2018 19:19:06 +0000 (21:19 +0200)]
added concurrent access detection to Remove() (#18524)
Carol Eidt [Wed, 20 Jun 2018 18:02:27 +0000 (11:02 -0700)]
Add another test for #17971
Jarret Shook [Wed, 20 Jun 2018 17:39:04 +0000 (10:39 -0700)]
Remove MaskLoad tests from arm and arm64 lst files (#18569)
This will disable the test from being run with smart in our windows arm
testing. This corresponds to the tests being deleted in #17637.
Amy Yu [Wed, 20 Jun 2018 17:12:39 +0000 (10:12 -0700)]
Make sections optional, throw more descriptive error when rva can't be converted to offset
Tarek Mahmoud Sayed [Wed, 20 Jun 2018 01:50:38 +0000 (18:50 -0700)]
Avoid extra allocation in IDNA (#18551)
* Avoid extra allocation in IDNA
* cache the indexd value in StringBuilder
Sergey Andreenko [Wed, 20 Jun 2018 01:02:11 +0000 (18:02 -0700)]
Fix instruction groups offset on the border between cold/hot code. (#17775)
* add an additional debug printing.
* add additional checks
* Clean-up checks a bit.
* fill unused allocated chunks
* clean up checks
* fix EMITTER_STATS
* optimize padding filling
call to emitCurCodeOffs(cp) is not free.
Sergey Andreenko [Wed, 20 Jun 2018 01:01:36 +0000 (18:01 -0700)]
Fix Complus_JitMinOpts for the first method (#18555)
Viktor Hofer [Tue, 19 Jun 2018 21:34:37 +0000 (23:34 +0200)]
Remove StringBuilderCache usage from System.Text.RegularExpressions (#30474)
* Remove StringBuilderCache usage
* fixed buffer size, manual reverse copying & local textinfo
* Fast path for not to encode string
* avoid one span slice
* code formatting & bounds check opt
* Avoid string allocation in char class
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Amy Yu [Wed, 13 Jun 2018 22:19:21 +0000 (15:19 -0700)]
Make unwind info specific to amd64
Amy Yu [Wed, 13 Jun 2018 18:53:08 +0000 (11:53 -0700)]
Use Registers for FrameRegister
Amy Yu [Tue, 12 Jun 2018 23:38:57 +0000 (16:38 -0700)]
Save frameOffset in 16bits
Amy Yu [Tue, 12 Jun 2018 21:45:10 +0000 (14:45 -0700)]
Dump unwind codes based on opcode
Amy Yu [Tue, 12 Jun 2018 18:55:59 +0000 (11:55 -0700)]
Rename enums with Pascal casing
Amy Yu [Tue, 12 Jun 2018 18:44:16 +0000 (11:44 -0700)]
Use symbolic names for opcodes, get register name for opinfo
Amy Yu [Sat, 16 Jun 2018 00:10:21 +0000 (17:10 -0700)]
Fix bugs
Amy [Tue, 19 Jun 2018 23:34:29 +0000 (16:34 -0700)]
Merge pull request #18357 from acmyu/sections
R2RDump - Dump CompilerIdentifier and ImportSection contents
Amy Yu [Tue, 19 Jun 2018 21:42:05 +0000 (14:42 -0700)]
Parse entries of import section
Stephen Toub [Tue, 19 Jun 2018 21:28:32 +0000 (17:28 -0400)]
Avoid two unnecessary string.Substring calls in PunycodeDecode (#18546)
Tomas Weinfurt [Tue, 19 Jun 2018 20:54:41 +0000 (13:54 -0700)]
fixes for sos on FreeBSD (#18479)
* fixes for sos on FreeBSD
* refactore unwind detection to common block for BSD and Linux
* missing newline
* do not do libunwind detection for OSX
Carol Eidt [Tue, 19 Jun 2018 20:35:02 +0000 (13:35 -0700)]
Fix struct promotion check for SIMD field (#18548)
A struct can have `lvIsRegArg` true but have multiple SIMD fields if it is passed by reference.
John Doe [Tue, 19 Jun 2018 20:26:30 +0000 (13:26 -0700)]
Typo (#18550)
* accesible -> accessible
* acheive -> achieve
* addtional -> additional
* affars -> affairs
* approch -> approach
* archtecture -> architecture
* aritmetic -> arithmetic
* arquired -> acquired
* assigments -> assignments
* assmblies -> assemblies
Amy Yu [Fri, 8 Jun 2018 23:16:23 +0000 (16:16 -0700)]
Dump bytes with offset instead of rva
Amy Yu [Thu, 7 Jun 2018 22:01:23 +0000 (15:01 -0700)]
Parse and dump compiler identifier and import sections, move dump section contents to own function
Amy Yu [Thu, 7 Jun 2018 20:40:37 +0000 (13:40 -0700)]
Dump contents of NativeArray and NativeHashtable
Amy Yu [Thu, 7 Jun 2018 18:53:18 +0000 (11:53 -0700)]
Use GetEntryPointIdFromOffset to get EntryPointId of generic methods