platform/upstream/libSkiaSharp.git
9 years agoFix edge-line artifacts issue on Mali
joel.liang [Thu, 4 Jun 2015 13:52:29 +0000 (06:52 -0700)]
Fix edge-line artifacts issue on Mali

Some GMs show edge-line artifacts on Mali at the bottom/right of the canvas.

Change the 'rtAdjustment' uniform precision from 'midiump' to 'highp' if the GPU vendor is ARM.

NOTE: Vertex Shader should have default 'highp' precision, but now we explicit declared some uniform/attribute precision as 'midiump'.

This patch should fix these issues:

Issue 3693: Some GMs produce random artifacts on Mali in MSAA4
    https://code.google.com/p/skia/issues/detail?id=3693

Issue 3685: srcmode GM has top/right line artifacts on Mali T604 in MSAA4
    https://code.google.com/p/skia/issues/detail?id=3685

BUG=skia:

Review URL: https://codereview.chromium.org/1154163012

9 years agorefactor bitmapshader to use a controller
reed [Thu, 4 Jun 2015 13:31:31 +0000 (06:31 -0700)]
refactor bitmapshader to use a controller

BUG=skia:

Review URL: https://codereview.chromium.org/1153123003

9 years agoremove stray printf
reed [Thu, 4 Jun 2015 13:27:44 +0000 (06:27 -0700)]
remove stray printf

BUG=skia:
TBR=junov@google.com

Review URL: https://codereview.chromium.org/1149083008

9 years agoRemove SK_FREETYPE_HAS_MM.
bungeman [Wed, 3 Jun 2015 19:58:40 +0000 (12:58 -0700)]
Remove SK_FREETYPE_HAS_MM.

The SK_FREETYPE_HAS_MM define was added to delay the changes to
support GX variation fonts on platforms which did not compile ftmm.c
into their FreeType build. Now that all builds should have this file
the define can be removed.

Committed: https://skia.googlesource.com/skia/+/4f61fee53af956a8beb4c56fa6479cb6b1aa5159

Review URL: https://codereview.chromium.org/1143133006

9 years agoReenable reordering
joshualitt [Tue, 2 Jun 2015 20:48:38 +0000 (13:48 -0700)]
Reenable reordering

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1160063003

9 years agoBegin tracking driver info in GrGLContextInfo
cdalton [Tue, 2 Jun 2015 20:05:52 +0000 (13:05 -0700)]
Begin tracking driver info in GrGLContextInfo

BUG=skia:

Review URL: https://codereview.chromium.org/1165463005

9 years agoAdd adb_wait_for_device script
borenet [Tue, 2 Jun 2015 19:38:16 +0000 (12:38 -0700)]
Add adb_wait_for_device script

BUG=skia:3718

Review URL: https://codereview.chromium.org/1149163003

9 years agoFixing leaky handling of SkImage in SkDeferredCanvas.
junov [Tue, 2 Jun 2015 18:47:45 +0000 (11:47 -0700)]
Fixing leaky handling of SkImage in SkDeferredCanvas.

Long lived SkImageHeap objects currently accumulate refs indefinitely.
This leads to massive memory leaks in the gpu-accelerated 2D canvas
code path. This CL does not implement a general fix for SkGPipe, but
it resolves the leak in SkDeferredCanvas (currently the only user
of SkGPipe) by resetting the image heap when the deferral queue is
flushed. This change also fixes the accounting of bytes allocated
by referenced images in order to trigger flushing heuristics
appropriately.

BUG=crbug.com/494148

Review URL: https://codereview.chromium.org/1145893007

9 years agoRevert of Fix dst bound reported by SkTileImageFilter (patchset #3 id:40001 of https...
robertphillips [Tue, 2 Jun 2015 17:57:26 +0000 (10:57 -0700)]
Revert of Fix dst bound reported by SkTileImageFilter (patchset #3 id:40001 of https://codereview.chromium.org/1152553006/)

Reason for revert:
breaking tests

Original issue's description:
> Fix dst bound reported by SkTileImageFilter
>
> In the example from the bug we had the filter DAG:
>
> color filter (table)
>     0: xfermode filter (arith)
>         0: tile filter [0,80,34,114] -> [0,80,800,480]
>              0: color filter (table)
>                  0: bitmap src 34x34 -> [0,80,34,114]
>         1: color filter (table)
>              0: picture filter [0, 80, 800, 480]
>
> computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
>
> This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
>
> BUG=493783
>
> Committed: https://skia.googlesource.com/skia/+/05be93bbdf09576f7903130e3b106b0a8c7c4b4e

TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493783

Review URL: https://codereview.chromium.org/1143083006

9 years agoFix dst bound reported by SkTileImageFilter
robertphillips [Tue, 2 Jun 2015 17:52:43 +0000 (10:52 -0700)]
Fix dst bound reported by SkTileImageFilter

In the example from the bug we had the filter DAG:

color filter (table)
    0: xfermode filter (arith)
        0: tile filter [0,80,34,114] -> [0,80,800,480]
             0: color filter (table)
                 0: bitmap src 34x34 -> [0,80,34,114]
        1: color filter (table)
             0: picture filter [0, 80, 800, 480]

computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.

This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.

BUG=493783

Review URL: https://codereview.chromium.org/1152553006

9 years agocheck (runtime) for null-pixels even when lock succeeds
reed [Tue, 2 Jun 2015 17:47:42 +0000 (10:47 -0700)]
check (runtime) for null-pixels even when lock succeeds

BUG=492818
TBR=

Review URL: https://codereview.chromium.org/1159953006

9 years agoUpdate XPF invariant info to not account for conflation
cdalton [Tue, 2 Jun 2015 17:43:39 +0000 (10:43 -0700)]
Update XPF invariant info to not account for conflation

Renames getInvariantOutput to getInvariantBlendedColor on GrXPFactory
and redefines it to not account for coverage conflation. This is the
information that all the callsites actually wanted to know.

BUG=skia:

Review URL: https://codereview.chromium.org/1161273005

9 years agowhitespace change to trigger android bots
joshualitt [Tue, 2 Jun 2015 17:35:04 +0000 (10:35 -0700)]
whitespace change to trigger android bots

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1160853005

9 years agowhitespace change to trigger android bots
joshualitt [Tue, 2 Jun 2015 17:10:28 +0000 (10:10 -0700)]
whitespace change to trigger android bots

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1164813002

9 years agodisable reordering until android bots clear up
joshualitt [Tue, 2 Jun 2015 16:10:31 +0000 (09:10 -0700)]
disable reordering until android bots clear up

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1167693006

9 years agowhitespace change to get android bots to cycle
joshualitt [Tue, 2 Jun 2015 15:12:08 +0000 (08:12 -0700)]
whitespace change to get android bots to cycle

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1155293008

9 years agofix dm crash
joshualitt [Tue, 2 Jun 2015 14:26:43 +0000 (07:26 -0700)]
fix dm crash

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1149243006

9 years agore-enable reordering
joshualitt [Tue, 2 Jun 2015 14:09:31 +0000 (07:09 -0700)]
re-enable reordering

BUG=skia:

Review URL: https://codereview.chromium.org/1164763002

9 years agoRevert of Remove SK_FREETYPE_HAS_MM. (patchset #1 id:1 of https://codereview.chromium...
reed [Tue, 2 Jun 2015 01:40:52 +0000 (18:40 -0700)]
Revert of Remove SK_FREETYPE_HAS_MM. (patchset #1 id:1 of https://codereview.chromium.org/1143133006/)

Reason for revert:
seems to be breaking DEPS roll

FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -fuse-ld=gold -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a -Wl,--icf=safe -Wl,--warn-shared-textrel -nostdlib --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm  -Wl,--warn-shared-textrel -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -Wl,--version-script=/b/build/slave/android_chromium_gn/build/src/build/android/android_no_jni_exports.lst -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a -o ./libskia.so -Wl,-soname=libskia.so @./libskia.so.rsp && { /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-readelf -d ./libskia.so | grep SONAME ; /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-nm -gD -f p ./libskia.so | cut -f1-2 -d' '; } > ./libskia.so.tmp && if ! cmp -s ./libskia.so.tmp ./libskia.so.TOC; then mv ./libskia.so.tmp ./libskia.so.TOC; fi && mkdir -p lib.stripped && ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip --strip-unneeded -o lib.stripped/libskia.so.tmp libskia.so && if ! cmp -s lib.stripped/libskia.so.tmp lib.stripped/libskia.so; then mv lib.stripped/libskia.so.tmp lib.stripped/libskia.so; fi
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:283: error: undefined reference to 'FT_Get_MM_Var'
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:302: error: undefined reference to 'FT_Set_Var_Design_Coordinates'
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:1766: error: undefined reference to 'FT_Get_MM_Var'
collect2: error: ld returned 1 exit status

Original issue's description:
> Remove SK_FREETYPE_HAS_MM.
>
> The SK_FREETYPE_HAS_MM define was added to delay the changes to
> support GX variation fonts on platforms which did not compile ftmm.c
> into their FreeType build. Now that all builds should have this file
> the define can be removed.
>
> Committed: https://skia.googlesource.com/skia/+/4f61fee53af956a8beb4c56fa6479cb6b1aa5159

TBR=djsollen@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1148303005

9 years agoFix for crashing bots
joshualitt [Mon, 1 Jun 2015 23:17:03 +0000 (16:17 -0700)]
Fix for crashing bots

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1159183006

9 years agoSet GeometryBufferMapThreshold defaults
joshualitt [Mon, 1 Jun 2015 21:17:47 +0000 (14:17 -0700)]
Set GeometryBufferMapThreshold defaults

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1161543003

9 years agosuppress chatty warning about Funkster.ttf not be supported (on mac at least)
reed [Mon, 1 Jun 2015 19:51:23 +0000 (12:51 -0700)]
suppress chatty warning about Funkster.ttf not be supported (on mac at least)

BUG=skia:

Review URL: https://codereview.chromium.org/1146273003

9 years agoRemove SK_FREETYPE_HAS_MM.
bungeman [Mon, 1 Jun 2015 19:05:23 +0000 (12:05 -0700)]
Remove SK_FREETYPE_HAS_MM.

The SK_FREETYPE_HAS_MM define was added to delay the changes to
support GX variation fonts on platforms which did not compile ftmm.c
into their FreeType build. Now that all builds should have this file
the define can be removed.

Review URL: https://codereview.chromium.org/1143133006

9 years agoRevert "Revert of Move copy-surface-as-draw fallback to GrGLGpu. (patchset #12 id...
bsalomon [Mon, 1 Jun 2015 17:41:49 +0000 (10:41 -0700)]
Revert "Revert of Move copy-surface-as-draw fallback to GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/1144433002/)"

This reverts commit 404b3b264b833eb7cffdc833c7e2ebbd708e123a.

Review URL: https://codereview.chromium.org/1161063003

9 years agoFix NULL access
bsalomon [Mon, 1 Jun 2015 17:22:48 +0000 (10:22 -0700)]
Fix NULL access

BUG=skia:

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1157363004

9 years agoanother double square
caryclark [Mon, 1 Jun 2015 17:21:31 +0000 (10:21 -0700)]
another double square

This is also a case where the square term is passed to a helper
function that squares the error term a second time.

R=reed@google.com
BUG=skia:3877

Review URL: https://codereview.chromium.org/1152623005

9 years agoExpand VisualBench to a real benching tool
joshualitt [Mon, 1 Jun 2015 17:03:54 +0000 (10:03 -0700)]
Expand VisualBench to a real benching tool

BUG=skia:

Review URL: https://codereview.chromium.org/1159213002

9 years ago/infra directory
nodir [Mon, 1 Jun 2015 16:39:11 +0000 (09:39 -0700)]
/infra directory

Added /infra directory, it will contain chrome-infra specific files, in
particular configs for chrome infra services.

/infra/project-config/cr-buildbucket.cfg defines buckets on
cr-buildbucket.appspot.com

R=borenet@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1164633002

9 years agodon't square error term twice
caryclark [Mon, 1 Jun 2015 15:40:48 +0000 (08:40 -0700)]
don't square error term twice

The cubic code erroneously passed the error square term to a function
which in turn squares the error term.

R=reed@google.com
BUG=skia:3877

Review URL: https://codereview.chromium.org/1163843003

9 years agoRoll third_party/externals/gyp dd831fd:08429da
bungeman [Mon, 1 Jun 2015 14:25:17 +0000 (07:25 -0700)]
Roll third_party/externals/gyp dd831fd:08429da

Summary of changes available at:
https://chromium.googlesource.com/external/gyp/+log/dd831fd..08429da

Review URL: https://codereview.chromium.org/1162453005

9 years agoStretch small textures up to 16 pixels on PowerVR 54x
bsalomon [Mon, 1 Jun 2015 14:13:42 +0000 (07:13 -0700)]
Stretch small textures up to 16 pixels on PowerVR 54x

Review URL: https://codereview.chromium.org/1161183002

9 years agoadd res to stroke bench
caryclark [Mon, 1 Jun 2015 13:30:06 +0000 (06:30 -0700)]
add res to stroke bench

R=reed@google.com

Review URL: https://codereview.chromium.org/1158183003

9 years agoRefactor GrGpu path rendering functions to GrPathRendering
kkinnunen [Mon, 1 Jun 2015 08:37:26 +0000 (01:37 -0700)]
Refactor GrGpu path rendering functions to GrPathRendering

GrGpu, GrGLGpu, GrPathRendering, GrGLPathRendering all duplicated
each others' path rendering related member functions. Make
GrPathRending the logical extension of GrGpu by removing the methods
from GrGpu. Similarly to the GL variants.

Changes includes and forward declarations due to removing
GrDrawTarget.h include from GrGpu.h. This was necessary due to
GrDrawTarget.h including GrPathRendering.h, and now GrPathRendering.h
includes GrGpu.h. (Also GrGpu.h does not need GrDrawTarget.h anymore).

Very slight runtime improvement on x86_64:
             desk_fontwipe.skp_1  836us ->  841us 1.01x
            desk_silkfinance.skp_1 2.01ms -> 2.01ms 1x
             desk_forecastio.skp_1 7.03ms -> 7.05ms 1x
                desk_weather.skp_1 3.74ms -> 3.74ms 1x
                desk_twitter.skp_1 8.02ms -> 8.01ms 1x
                 desk_mapsvg.skp_1 5.24ms -> 5.23ms 1x
            desk_pokemonwiki.skp_1 7.06ms -> 7.03ms 1x
                 desk_sfgate.skp_1 3.19ms -> 3.17ms 1x
           tabl_cuteoverload.skp_1 2.66ms -> 2.64ms 0.99x
...
           tabl_transformice.skp_1 3.06ms -> 2.98ms 0.98x
         tabl_googlecalendar.skp_1 11.3ms ->   11ms 0.97x
            tabl_gamedeksiam.skp_1 12.8ms -> 12.4ms 0.97x
               desk_samoasvg.skp_1 10.6ms -> 10.3ms 0.97x
           tabl_worldjournal.skp_1 4.44ms ->  4.3ms 0.97x

Review URL: https://codereview.chromium.org/1157683006

9 years agoUpdate SKP version
skia.buildbots [Sun, 31 May 2015 07:49:10 +0000 (00:49 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1155133003

9 years agoRevert[6] of add asserts around results from requestLock
reed [Sat, 30 May 2015 20:41:15 +0000 (13:41 -0700)]
Revert[6] of add asserts around results from requestLock

This reverts commit 11e833d91b5ba2193ed593cb74900dddbec24b6f.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1159183003

9 years agoRevert of Revert[4] of add asserts around results from requestLock (patchset #3 id...
reed [Sat, 30 May 2015 16:20:29 +0000 (09:20 -0700)]
Revert of Revert[4] of add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1159733006/)

Reason for revert:
gfx_unittests (under linux_asan)

@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Direct leak of 368 byte(s) in 1 object(s) allocated from:@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #0 0x4cc74b in __interceptor_malloc (/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #1 0x7f2f7060ebdf in _cairo_image_surface_create_for_pixman_image /build/buildd/cairo-1.10.2/src/cairo-image-surface.c:158@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Indirect leak of 256 byte(s) in 1 object(s) allocated from:@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #0 0x4cc74b in __interceptor_malloc (/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #1 0x7f2f6c7be26a in _pixman_image_allocate /build/buildd/pixman-0.30.2/build/pixman/../../pixman/pixman-image.c:184@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@

I think they are creating a cairo surface, but it has no pixels (zero size?). In this CL, if I see no pixels, I ignore the call-back which is used to free the surface (doh).

Original issue's description:
> Revert[4] of add asserts around results from requestLock
>
> This reverts commit 19663e54c017499406036746e7689193aa6417e6.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/df91b73a34e3a306c93a5e320704736255c3d9f0

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1151063005

9 years agoRevert[4] of add asserts around results from requestLock
reed [Sat, 30 May 2015 13:32:55 +0000 (06:32 -0700)]
Revert[4] of add asserts around results from requestLock

This reverts commit 19663e54c017499406036746e7689193aa6417e6.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1159733006

9 years agoRevert of add asserts around results from requestLock (patchset #3 id:40001 of https...
reed [Sat, 30 May 2015 01:36:07 +0000 (18:36 -0700)]
Revert of add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.or… (patchset #1 id:1 of https://codereview.chromium.org/1165583005/)

Reason for revert:
failure in cc_unittests (need to diagnose)

@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSoftware_1@ResourceProviderTests/ResourceProviderTest.TransferInvalidSoftware/1 (run #1):@@@
@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSoftware_1@[ RUN      ] ResourceProviderTests/ResourceProviderTest.TransferInvalidSoftware/1@@@
@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSoftware_1@[17114:17114:0529/180822:15336467671:INFO:SkPixelRef.cpp(168)] ../../third_party/skia/src/core/SkPixelRef.cpp:168: failed assertion "pixels"@@@

Original issue's description:
> add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1155403003/)"
>
> This reverts commit 3953d360417655b8000df0951699121383db45c3.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/6980f5a96455c8062403c995a64b654a0e9a1319

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1151573009

9 years agoadd asserts around results from requestLock (patchset #3 id:40001 of https://coderevi...
reed [Fri, 29 May 2015 22:46:36 +0000 (15:46 -0700)]
add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1155403003/)"

This reverts commit 3953d360417655b8000df0951699121383db45c3.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1165583005

9 years agoRevert of add asserts around results from requestLock (patchset #3 id:40001 of https...
reed [Fri, 29 May 2015 21:22:05 +0000 (14:22 -0700)]
Revert of add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1155403003/)

Reason for revert:
asserts in ui/gfx unittests (need to investigate why)

[ RUN      ] RenderTextTest.SelectionKeepsLigatures
[14602:14602:0529/134016:16779526944:INFO:SkPixelRef.cpp(164)] ../../third_party/skia/src/core/SkPixelRef.cpp:164: failed assertion "pixels"

Original issue's description:
> add asserts around results from requestLock and lockPixels, ensuring that true always means we have non-null pixels (and non-null colortable if that matches the colortype)
>
> BUG= 491975
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/f941a68126d8fe647eaea902c244c466568b7809

TBR=scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 491975

Review URL: https://codereview.chromium.org/1159013006

9 years agoadd asserts around results from requestLock and lockPixels, ensuring that true always...
reed [Fri, 29 May 2015 18:39:14 +0000 (11:39 -0700)]
add asserts around results from requestLock and lockPixels, ensuring that true always means we have non-null pixels (and non-null colortable if that matches the colortype)

BUG= 491975
TBR=

Review URL: https://codereview.chromium.org/1155403003

9 years agoSkImage::NewFromYUVTexturesCopy
bsalomon [Fri, 29 May 2015 18:37:25 +0000 (11:37 -0700)]
SkImage::NewFromYUVTexturesCopy

Review URL: https://codereview.chromium.org/1149553002

9 years agoRemove GrContext from GrDrawTarget
bsalomon [Fri, 29 May 2015 17:26:19 +0000 (10:26 -0700)]
Remove GrContext from GrDrawTarget

Still exists on clip target (for now).

Review URL: https://codereview.chromium.org/1166553002

9 years agoRemove GrContext from GrClipMaskCache
bsalomon [Fri, 29 May 2015 16:45:57 +0000 (09:45 -0700)]
Remove GrContext from GrClipMaskCache

Review URL: https://codereview.chromium.org/1144013007

9 years agoAdd Em test font.
bungeman [Fri, 29 May 2015 15:42:21 +0000 (08:42 -0700)]
Add Em test font.

This test font contains
☓ U+2613 SALTIRE
⬛ U+2B1B BLACK LARGE SQUARE
⬜ U+2B1C WHITE LARGE SQUARE
All at full EM size (with standard amount above and below the
baseline).

Review URL: https://codereview.chromium.org/1134153002

9 years agouse inline version of eval quad if tangent is not needed
caryclark [Fri, 29 May 2015 15:11:16 +0000 (08:11 -0700)]
use inline version of eval quad if tangent is not needed

R=reed@google.com

Review URL: https://codereview.chromium.org/1160163002

9 years agoRemoving GrAutoMalloc
joshualitt [Fri, 29 May 2015 15:06:48 +0000 (08:06 -0700)]
Removing GrAutoMalloc

BUG=skia:

Review URL: https://codereview.chromium.org/1161993003

9 years agoAdd direct getter for GrCaps to GrContext.
bsalomon [Fri, 29 May 2015 15:02:10 +0000 (08:02 -0700)]
Add direct getter for GrCaps to GrContext.

TBR=joshualitt@google.com

Committed: https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99

Review URL: https://codereview.chromium.org/1149773005

9 years agoadd bench for building strokes
reed [Fri, 29 May 2015 14:17:16 +0000 (07:17 -0700)]
add bench for building strokes

BUG=skia:

Review URL: https://codereview.chromium.org/1160093004

9 years agodelete experimental path renderers
joshualitt [Fri, 29 May 2015 14:09:09 +0000 (07:09 -0700)]
delete experimental path renderers

BUG=skia:

Review URL: https://codereview.chromium.org/1160863006

9 years agoadd context override of GeometryBufferMapThreshold
joshualitt [Fri, 29 May 2015 13:46:47 +0000 (06:46 -0700)]
add context override of GeometryBufferMapThreshold

BUG=skia:

Review URL: https://codereview.chromium.org/1159713006

9 years agoadd assert that the pixelref really did success in requestlock
reed [Thu, 28 May 2015 21:06:06 +0000 (14:06 -0700)]
add assert that the pixelref really did success in requestlock

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1142343010

9 years agoRevert of small CL to experiment with 'disabling' memory mapping (patchset #1 id...
joshualitt [Thu, 28 May 2015 20:40:20 +0000 (13:40 -0700)]
Revert of small CL to experiment with 'disabling' memory mapping (patchset #1 id:1 of https://codereview.chromium.org/1160003004/)

Reason for revert:
experiment complete

Original issue's description:
> small CL to experiment with 'disabling' memory mapping
>
> TBR=bsalomon@google.com
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2e48e1514396b363ecd19372eab637b11bfb8a82

TBR=robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1159133004

9 years agoWhitespace change to test bugdroid
rmistry [Thu, 28 May 2015 18:59:07 +0000 (11:59 -0700)]
Whitespace change to test bugdroid

BUG=493278
BUG=skia:2139

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1166443002

9 years agosmall CL to experiment with 'disabling' memory mapping
joshualitt [Thu, 28 May 2015 18:53:49 +0000 (11:53 -0700)]
small CL to experiment with 'disabling' memory mapping

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1160003004

9 years agoRevert of Add direct getter for GrCaps to GrContext. (patchset #4 id:60001 of https...
bsalomon [Thu, 28 May 2015 15:20:58 +0000 (08:20 -0700)]
Revert of Add direct getter for GrCaps to GrContext. (patchset #4 id:60001 of https://codereview.chromium.org/1149773005/)

Reason for revert:
Breaking

Original issue's description:
> Add direct getter for GrCaps to GrContext.
>
> TBR=joshualitt@google.com
>
> Committed: https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1164443002

9 years agoAdd direct getter for GrCaps to GrContext.
bsalomon [Thu, 28 May 2015 15:13:16 +0000 (08:13 -0700)]
Add direct getter for GrCaps to GrContext.

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/1149773005

9 years agoBreak GrTextContext's reliance on SkGpuDevice
robertphillips [Thu, 28 May 2015 14:45:59 +0000 (07:45 -0700)]
Break GrTextContext's reliance on SkGpuDevice

This CL seems to have 2 main downsides:

1) It duplicates some code in SkBaseDevice::filterTextFlags
2) It makes it tougher to derive from SkGpuDevice

It seems reasonable (at least to me) that the TextContexts get the power to reset the LCD flags.

Review URL: https://codereview.chromium.org/1159973002

9 years agosimplify RawIter - don't return a pt in kClose
reed [Thu, 28 May 2015 02:53:25 +0000 (19:53 -0700)]
simplify RawIter - don't return a pt in kClose

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1156893003

9 years agoImplement Porter Duff XP with a blend table
cdalton [Wed, 27 May 2015 22:08:33 +0000 (15:08 -0700)]
Implement Porter Duff XP with a blend table

Removes the runtime logic used by PorterDuffXferProcessor to decide
blend coeffs and shader outputs, and instead uses a compile-time
constant table of pre-selected blend formulas. Separates out the dst
read fallback into its own XP.

Introduces a new blend strategy for srcCoeff=0 that can apply coverage
with a reverse subtract blend equation instead of dual source
blending.

Adds new macros in GrBlend.h to analyze blend formulas both runtime.

Removes kSetCoverageDrawing_OptFlag and GrSimplifyBlend as they are no
longer used.

Adds a GM that verifies all xfermodes, including arithmetic, with the
color/coverage invariants used by Porter Duff.

Adds a unit test that verifies each Porter Duff formula with every
color/coverage invariant.

Major changes:

 * Uses a reverse subtract blend equation for coverage when srcCoeff=0
   (clear, dst-out [Sa=1], dst-in, modulate). Platforms that don't
   support dual source blending no longer require a dst copy for
   dst-in and modulate.

 * Sets BlendInfo::fWriteColor to false when the blend does not modify
   the dst. GrGLGpu will now use glColorMask instead of blending for
   these modes (dst, dst-in [Sa=1], modulate ignored for [Sc=1]).

 * Converts all SA blend coeffs to One for opaque inputs, and ISA to
   Zero if there is also no coverage. (We keep ISA around when there
   is coverage because we use it to tweak alpha for coverage.)

 * Abandons solid white optimizations for the sake of simplicity
   (screen was the only mode that previous had solid white opts).

Minor differences:

 * Inconsequential differences in opt flags (e.g. we now return
   kCanTweakAlphaForCoverage_OptFlag even when there is no coverage).

 * Src coeffs when the shader outputs 0.

 * IS2C vs IS2A when the secondary output is scalar.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9a70920db22b6309c671f8e5d519bb95570e4414

Review URL: https://codereview.chromium.org/1124373002

9 years agoBetter comments in SkXfermodeInterpretation
halcanary [Wed, 27 May 2015 21:43:40 +0000 (14:43 -0700)]
Better comments in SkXfermodeInterpretation

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1159493003

9 years agorevert reordering
joshualitt [Wed, 27 May 2015 21:28:09 +0000 (14:28 -0700)]
revert reordering

BUG=skia:

Review URL: https://codereview.chromium.org/1155593004

9 years agoAdd caps overrides to GMs
bsalomon [Wed, 27 May 2015 20:23:23 +0000 (13:23 -0700)]
Add caps overrides to GMs

Review URL: https://codereview.chromium.org/1158963002

9 years agoUse SkTArray instead of SkSTArray in movable.
bungeman [Wed, 27 May 2015 20:10:02 +0000 (13:10 -0700)]
Use SkTArray instead of SkSTArray in movable.

SkTArray is trivially movable, but SkSTArray is not, since it may
contain an internal pointer. FontFileInfo is supposed to be
trivially movable but currently isn't due to containing an SkSTArray.
Removing this particular optimization should not affect performance
much as this type is only used for parsing and does not allocate any
memory unless a variation axis is actually specified.

Review URL: https://codereview.chromium.org/1155383002

9 years agoNew CodeSrc* draw mode kScanline_Subset_Mode
emmaleer [Wed, 27 May 2015 19:36:10 +0000 (12:36 -0700)]
New CodeSrc* draw mode kScanline_Subset_Mode

kScanline_Subset_Mode decodes the image in subsets using a
scanline decoder.
The number of subsets can be specified by changing the constant divisor.
The number of subsets is equal to divisor*divisor.

Review URL: https://codereview.chromium.org/1157153003

9 years agoMove SkGpuDevice::internalDrawPath to GrBlurUtils::drawPathWithMaskFilter
robertphillips [Wed, 27 May 2015 18:02:55 +0000 (11:02 -0700)]
Move SkGpuDevice::internalDrawPath to GrBlurUtils::drawPathWithMaskFilter

This CL is ugly but it:

removes the stored SkGpuDevice back pointer from GrTextContext (at the cost of passing more parameters)
moves SkGpuDevice::internalDrawPath to GrDrawContext::drawPathFull

Unfortunately, the GrTextContext-derived classes still need the SkGpuDevice for filterTextFlags calls but I will try removing that in a separate CL.

Review URL: https://codereview.chromium.org/1157773003

9 years agoFall back to older inorder buffer if we have NVPR
joshualitt [Wed, 27 May 2015 17:56:40 +0000 (10:56 -0700)]
Fall back to older inorder buffer if we have NVPR

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b72ec98b2090e5728354dac66eb1886a28e4da6b

Review URL: https://codereview.chromium.org/1143153008

9 years agoRevert of Fall back to older inorder buffer if we have NVPR (patchset #3 id:40001...
joshualitt [Wed, 27 May 2015 17:39:56 +0000 (10:39 -0700)]
Revert of Fall back to older inorder buffer if we have NVPR (patchset #3 id:40001 of https://codereview.chromium.org/1143153008/)

Reason for revert:
breaking bots

Original issue's description:
> Fall back to older inorder buffer if we have NVPR
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b72ec98b2090e5728354dac66eb1886a28e4da6b

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1160663006

9 years agoFall back to older inorder buffer if we have NVPR
joshualitt [Wed, 27 May 2015 17:31:12 +0000 (10:31 -0700)]
Fall back to older inorder buffer if we have NVPR

BUG=skia:

Review URL: https://codereview.chromium.org/1143153008

9 years agoenable reordering
joshualitt [Wed, 27 May 2015 16:20:08 +0000 (09:20 -0700)]
enable reordering

NO_MERGE_BUILDS
BUG=skia:

Review URL: https://codereview.chromium.org/1158213002

9 years agoCL to add setFullscreen and setVsync to SkWindow
joshualitt [Wed, 27 May 2015 16:19:03 +0000 (09:19 -0700)]
CL to add setFullscreen and setVsync to SkWindow

BUG=skia:

Review URL: https://codereview.chromium.org/1151333004

9 years agoSkPDF: with opaque draws, treat SRC mode as SRC_OVER
halcanary [Wed, 27 May 2015 15:53:36 +0000 (08:53 -0700)]
SkPDF: with opaque draws, treat SRC mode as SRC_OVER

BUG=473572

Review URL: https://codereview.chromium.org/1159763004

9 years agofixing onSkipScanlines png error
emmaleer [Wed, 27 May 2015 15:49:04 +0000 (08:49 -0700)]
fixing onSkipScanlines png error

There was a bug in onSkipScanlines where NULL was being passed instead of the SrcRow to png_read_rows.
This caused SkipScanlines to appear to be skipping, as fCurrScanline was updated and SkipScanlines returned success, however png_read_rows was not actually reading anything, and no lines were skipped.

Review URL: https://codereview.chromium.org/1159853003

9 years agodon't use accessBitmap
reed [Wed, 27 May 2015 02:22:17 +0000 (19:22 -0700)]
don't use accessBitmap

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1154293002

9 years agoUnblock DEPS roll by remove SkAutoTUnref from GrDrawContext
robertphillips [Tue, 26 May 2015 21:37:00 +0000 (14:37 -0700)]
Unblock DEPS roll by remove SkAutoTUnref from GrDrawContext

BUG=skia:

Review URL: https://codereview.chromium.org/1156103006

9 years agoFix SkAndroidSDKCanvas virtuals
tomhudson [Tue, 26 May 2015 21:12:24 +0000 (14:12 -0700)]
Fix SkAndroidSDKCanvas virtuals

Catch Android Framework-only code up to a change made in the
SkCanvas signature.

R=scroggo@google.com,reed@google.com

Review URL: https://codereview.chromium.org/1151673004

9 years agospeculative revert change to pixmap for bitmapscaler
reed [Tue, 26 May 2015 20:57:04 +0000 (13:57 -0700)]
speculative revert change to pixmap for bitmapscaler

BUG=491891
TBR=

Review URL: https://codereview.chromium.org/1159793003

9 years agoreal fix for textblob use after gpu free
joshualitt [Tue, 26 May 2015 19:32:23 +0000 (12:32 -0700)]
real fix for textblob use after gpu free

This patch addresses two issues:
1) Textblobs with abandoned strikes were not properly regenerating.
2) Provided by ericrk - GrTextBlobCache removed blobs from |fCache| during freeAll, but left
potentially released blobs in the |fBlobList|. We now remove these from
|fBlobList| as well.
BUG=skia:

Review URL: https://codereview.chromium.org/1160633002

9 years agoSplit GrCaps impl out into its own cpp
bsalomon [Tue, 26 May 2015 19:16:59 +0000 (12:16 -0700)]
Split GrCaps impl out into its own cpp

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/1151503003

9 years agoSplit drawing functionality out of GrContext and into new GrDrawContext
robertphillips [Tue, 26 May 2015 18:38:03 +0000 (11:38 -0700)]
Split drawing functionality out of GrContext and into new GrDrawContext

This is mainly a mechanical CL. There were some fiddly bits in GrContext.cpp where it no longer had access to the GrDrawTarget (and had to use the new GrDrawContext).

I've converted GrAARectRenderer & GrOvalRenderer into static classes so I could stop allocating them.

Review URL: https://codereview.chromium.org/1151283004

9 years agochange internals over to SkPixmap and stop using accessBitmap
reed [Tue, 26 May 2015 18:31:54 +0000 (11:31 -0700)]
change internals over to SkPixmap and stop using accessBitmap

BUG=skia:

Review URL: https://codereview.chromium.org/1155443004

9 years agoMove DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture...
bsalomon [Tue, 26 May 2015 16:49:05 +0000 (09:49 -0700)]
Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names.

Committed: https://skia.googlesource.com/skia/+/bb106b5f6ee18f7453b63f3a95f421b60a957f39

Review URL: https://codereview.chromium.org/1132093004

9 years agoReorder across clears
joshualitt [Tue, 26 May 2015 16:33:48 +0000 (09:33 -0700)]
Reorder across clears

BUG=skia:

Review URL: https://codereview.chromium.org/1161643002

9 years agosync-and-gyp: make smarter
halcanary [Tue, 26 May 2015 15:01:19 +0000 (08:01 -0700)]
sync-and-gyp: make smarter

This fixes two issues: If gyp is run with the CXX and CC environment
variables set, it will produce different ninja build files.
sync-and-gyp now tracks the values of those variables; if they change,
re-run gyp.

Secondly, we introduced find.py, which is used inside gyp files.  If
the contents of certain directories changes, gyp should be re-run.  So
now we track those directories too.

Review URL: https://codereview.chromium.org/1153083002

9 years agoDisabling ~path_hairline in iOS nanobench
stephana [Tue, 26 May 2015 13:19:11 +0000 (06:19 -0700)]
Disabling ~path_hairline in iOS nanobench

Temporary measure to make nanobench succeed.

TBR=borenet
BUG=skia:

Review URL: https://codereview.chromium.org/1144173004

9 years agoremove unneeded device:lockpixels
reed [Tue, 26 May 2015 04:21:27 +0000 (21:21 -0700)]
remove unneeded device:lockpixels

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1156073003

9 years agoAvoid creating GrGLPath to the resource cache when creating GrGLPathRanges
kkinnunen [Mon, 25 May 2015 05:12:21 +0000 (22:12 -0700)]
Avoid creating GrGLPath to the resource cache when creating GrGLPathRanges

Do not create a GrGLPath when loading glyphs with the driver and creating
GrGLPathRange based on those. The path would be inserted to the GPU
resource cache and then immediately be released.

Instead, just init the first path object of the path range as the
template.

Review URL: https://codereview.chromium.org/1146983004

9 years agoUpdate SKP version
skia.buildbots [Sun, 24 May 2015 07:23:16 +0000 (00:23 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1159443003

9 years agodeprecate calling lockPixels
reed [Sun, 24 May 2015 02:14:51 +0000 (19:14 -0700)]
deprecate calling lockPixels

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1156003002

9 years agomove readPixels from bitmap -> pixmap
reed [Sat, 23 May 2015 20:21:06 +0000 (13:21 -0700)]
move readPixels from bitmap -> pixmap

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1153893003

9 years agoremove bitmaps entirely from sprite blits (as source)
reed [Sat, 23 May 2015 19:26:41 +0000 (12:26 -0700)]
remove bitmaps entirely from sprite blits (as source)

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1156713004

9 years agoRevert of Implement Porter Duff XP with a blend table (patchset #12 id:220001 of...
bungeman [Sat, 23 May 2015 00:55:26 +0000 (17:55 -0700)]
Revert of Implement Porter Duff XP with a blend table (patchset #12 id:220001 of https://codereview.chromium.org/1124373002/)

Reason for revert:
Blocking DEPS roll into Chromium. Crashing virtual/gpu/fast/canvas/canvas-composite-*.html tests with the assert

../../third_party/skia/src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp:281: failed assertion "k110_GrGLSLGeneration != gpu->glslGeneration() || fOutputs.empty()"

Original issue's description:
> Implement Porter Duff XP with a blend table
>
> Removes the runtime logic used by PorterDuffXferProcessor to decide
> blend coeffs and shader outputs, and instead uses a compile-time
> constant table of pre-selected blend formulas.
>
> Introduces a new blend strategy for srcCoeff=0 that can apply coverage
> with a reverse subtract blend equation instead of dual source
> blending.
>
> Adds new macros in GrBlend.h to analyze blend formulas both runtime.
>
> Removes kSetCoverageDrawing_OptFlag and GrSimplifyBlend as they are no
> longer used.
>
> Adds a GM that verifies all xfermodes, including arithmetic, with the
> color/coverage invariants used by Porter Duff.
>
> Adds a unit test that verifies each Porter Duff formula with every
> color/coverage invariant.
>
> Major changes:
>
>  * Uses a reverse subtract blend equation for coverage when srcCoeff=0
>    (clear, dst-out [Sa=1], dst-in, modulate). Platforms that don't
>    support dual source blending no longer require a dst copy for
>    dst-in and modulate.
>
>  * Sets BlendInfo::fWriteColor to false when the blend does not modify
>    the dst. GrGLGpu will now use glColorMask instead of blending for
>    these modes (dst, dst-in [Sa=1], modulate ignored for [Sc=1]).
>
>  * Converts all SA blend coeffs to One for opaque inputs, and ISA to
>    Zero if there is also no coverage. (We keep ISA around when there
>    is coverage because we use it to tweak alpha for coverage.)
>
>  * Abandons solid white optimizations for the sake of simplicity
>    (screen was the only mode that previous had solid white opts).
>
> Minor differences:
>
>  * Inconsequential differences in opt flags (e.g. we now return
>    kCanTweakAlphaForCoverage_OptFlag even when there is no coverage).
>
>  * Src coeffs when the shader outputs 0.
>
>  * IS2C vs IS2A when the secondary output is scalar.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9a70920db22b6309c671f8e5d519bb95570e4414

TBR=egdaniel@google.com,bsalomon@google.com,cdalton@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1153993002

9 years agoRevert of Fix LCD coverage regression in GrPorterDuffXPFactory (patchset #3 id:40001...
bungeman [Sat, 23 May 2015 00:54:44 +0000 (17:54 -0700)]
Revert of Fix LCD coverage regression in GrPorterDuffXPFactory (patchset #3 id:40001 of https://codereview.chromium.org/1149883004/)

Reason for revert:
Reverting this fix to revert https://codereview.chromium.org/1124373002

Original issue's description:
> Fix LCD coverage regression in GrPorterDuffXPFactory
>
> Fixes GrPorterDuffXPFactory to not use the blend table when getting
> info about the LCD coverage XP.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3e2d59ef36e1b9a63e524cf1b27d5f7bcfb5ff0b

TBR=bsalomon@google.com,egdaniel@google.com,cdalton@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1153803005

9 years agoEveryone gets a namespace {}.
mtklein [Sat, 23 May 2015 00:18:21 +0000 (17:18 -0700)]
Everyone gets a namespace {}.

If we include Sk4px.h, SkPMFloat.h, or SkNx.h into files with different
SIMD flags, that could cause different definitions of the same method.

Normally that's moot, because all the code inlines, but in Debug it tends not
to.  So in Debug, the linker picks one definition for us.  That breaks _someone_.

Wrapping everything in a namespace {} keeps the definitions separate.

Tested locally, it fixes this bug.
BUG=skia:3861

This code is not yet enabled in Chrome, so shouldn't affect the roll.
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1154523004

9 years agoRevert of Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcop...
bungeman [Fri, 22 May 2015 22:22:48 +0000 (15:22 -0700)]
Revert of Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names. (patchset #6 id:100001 of https://codereview.chromium.org/1132093004/)

Reason for revert:
This is asserting on GTX660 bots with '!dst'. This may just be catching an existing issue.

https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/622/steps/dm/logs/stdio

https://build.chromium.org/p/client.skia/builders/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE/builds/209/steps/dm/logs/stdio

https://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/318/steps/dm/logs/stdio

Original issue's description:
> Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names.
>
> Committed: https://skia.googlesource.com/skia/+/bb106b5f6ee18f7453b63f3a95f421b60a957f39

TBR=egdaniel@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1158453004

9 years agoMove DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture...
bsalomon [Fri, 22 May 2015 21:32:10 +0000 (14:32 -0700)]
Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names.

Review URL: https://codereview.chromium.org/1132093004

9 years agoFix LCD coverage regression in GrPorterDuffXPFactory
cdalton [Fri, 22 May 2015 21:04:37 +0000 (14:04 -0700)]
Fix LCD coverage regression in GrPorterDuffXPFactory

Fixes GrPorterDuffXPFactory to not use the blend table when getting
info about the LCD coverage XP.

BUG=skia:

Review URL: https://codereview.chromium.org/1149883004

9 years agoStore context options on caps.
bsalomon [Fri, 22 May 2015 21:01:46 +0000 (14:01 -0700)]
Store context options on caps.

Committed: https://skia.googlesource.com/skia/+/f28cff71db2cbb1ff18a8fbf1e80ca761d1f69bc

Review URL: https://codereview.chromium.org/1158433006

9 years agofix for atlas is abandoned text corruption
joshualitt [Fri, 22 May 2015 20:09:57 +0000 (13:09 -0700)]
fix for atlas is abandoned text corruption

BUG=skia:

Review URL: https://codereview.chromium.org/1156693004

9 years agoSimpler version of Plus w/ AA. ~25% faster too.
mtklein [Fri, 22 May 2015 19:43:41 +0000 (12:43 -0700)]
Simpler version of Plus w/ AA.  ~25% faster too.

BUG=skia:3852

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1150693003