platform/core/dotnet/diagnostics.git
6 years agoMove CI build to Hosted Ubuntu 1604
Matt Galbraith [Thu, 30 May 2019 17:18:39 +0000 (10:18 -0700)]
Move CI build to Hosted Ubuntu 1604

6 years agoIpc spec update (#290)
John Salem [Thu, 30 May 2019 17:13:11 +0000 (10:13 -0700)]
Ipc spec update (#290)

* create section headers
* Add profiler and dump documentation
* change pipe name in spec to dotnet

6 years agoDo not swallow exception and stuck in case we have an exception thrown during tracing
Andrew Au [Thu, 30 May 2019 00:26:49 +0000 (17:26 -0700)]
Do not swallow exception and stuck in case we have an exception thrown during tracing

6 years agoMissing profile argument
Felipe Pessoto [Thu, 23 May 2019 13:35:45 +0000 (10:35 -0300)]
Missing profile argument

The providers help mention profile, but it is not in the docs.

I took the profile description from https://github.com/dotnet/diagnostics/blob/master/documentation/design-docs/dotnet-tools.md

But I'm not sure if we should keep the information in both places

It also refers to some profiles not available in the current release 1.0.3-preview5.19251.2. The only profile in this version is runtime-basic

6 years agoTwo changes to !dumpasync (#286)
Stephen Toub [Sun, 26 May 2019 02:15:01 +0000 (22:15 -0400)]
Two changes to !dumpasync (#286)

* Display state machine fields in DumpAsync for -stacks

Currently the DumpAsync -fields option just impacts whether the state machine fields are output for the top-level state machines.  We received feedback that it would be more expected for -fields to also cause the fields to be output for all state machines listed as part of continuation chains.  This does that.

* Improve performance of !dumpasync SOS command

A significant majority of the time spent in dumpasync was in getting the type name of each object in order to compare it to "AsyncStateMachineBox".  This switches to comparing by module and mdTypeDef.  On an ~1GB dump, the time to execute !dumpasync dropped from 43 to 11 seconds on my machine.

6 years agoAdd Diagnostic Ipc client (#271)
John Salem [Fri, 24 May 2019 04:10:11 +0000 (21:10 -0700)]
Add Diagnostic Ipc client (#271)

* * Add infrastructure for a new IPC client in line with the propsed spec
* update EventPipeClient to use new IpcClient
* Update DiagnosticHelpers to use IpcClient

* * fix typo
* change to use uint32 instead of INT for generate core dump command

* * remove dead code

* * bring error codes in line with the now checked0in spec

* Remove extra error code

* Rename Miscellaneous to Dump for command sets and Ids

* fix typing issue

* * update profiler attach to use IpcClient

* * Change errors to be int32 HRESULTS

* * remove unnecessary todo
* simplify size checking

* * add ASSERT that MAGIC is always the correct length

* * Fix using statement

6 years agoUpdate dotnet-counters link to docs (#281)
Felipe Pessoto [Thu, 23 May 2019 17:03:45 +0000 (14:03 -0300)]
Update dotnet-counters link to docs (#281)

6 years agoMerge pull request #274 from davmason/profiler_attach
David Mason [Thu, 23 May 2019 08:00:38 +0000 (01:00 -0700)]
Merge pull request #274 from davmason/profiler_attach

Add profiler attach message

6 years agoAdd comment about timeout
David Mason [Wed, 22 May 2019 20:16:55 +0000 (13:16 -0700)]
Add comment about timeout

6 years agoIPC protocol spec (#198)
John Salem [Wed, 22 May 2019 19:54:44 +0000 (12:54 -0700)]
IPC protocol spec (#198)

* Add initial draft of ipc protocol spec

* Update IPC spec to account for feedback:
* add clarity about what needs to be wrapped in a header
* add image representing communication flow
* flesh out packet headers

* fix image rendering

* Remove TODOs

* Rewrite overview and add transport description.

* * update spec to account for feedback
* formalize terminology
* update diagrams to account for new terminology
* update header size

* * Add notes on pipe and socket naming conventions

* * expand error section and define error codes
* simplify description of optional continuation
* clarify terminology w.r.t. Commands and Command specific things
* explicitly write out current set of command_sets and command_ids

* * update EventPipe payload example to be reality
* fix comments
* Update transport name with explicit sprintf codes

* * Document current workings of EventPipe Commands

* specify IpcHeader.magic as uint8_t instead of ambiguous char

* * increase detail of eventpipe commands
* expand on and streamline the error model
* remove hypotheticals
* correct bug in example messages

* * changes in response to feedback
* add notes about MacOS App Group case

6 years agoUpdate message ID
David Mason [Wed, 22 May 2019 10:29:46 +0000 (03:29 -0700)]
Update message ID

6 years agoWindows arm32 and Linux arm/arm64 support (#276)
Mike McLaughlin [Wed, 22 May 2019 00:36:17 +0000 (17:36 -0700)]
Windows arm32 and Linux arm/arm64 support (#276)

Fix issue: https://github.com/dotnet/diagnostics/issues/242

Update command include files from coreclr to fix arm build problems.

Add warning headers to common includes: issue https://github.com/dotnet/diagnostics/issues/38

Added calling dbgeng DAC IOCTL fallback so ".cordll" works.

Added host runtime directory to diasymreader search.

Remove installing sudo on 18.04 docker images (docker-init.sh).

6 years agoChange the dotnet-dump setthread command to take the thread index (#275)
Mike McLaughlin [Tue, 21 May 2019 03:03:45 +0000 (20:03 -0700)]
Change the dotnet-dump setthread command to take the thread index (#275)

6 years agoUpdate System.CommandLine for dotnet-dump (#270)
Mike McLaughlin [Mon, 20 May 2019 22:08:23 +0000 (15:08 -0700)]
Update System.CommandLine for dotnet-dump (#270)

Update System.CommandLine for dotnet-dump

Update System.CommandLine to 0.2.0-alpha.19254.1.

Fixes issues: https://github.com/dotnet/diagnostics/issues/127 https://github.com/dotnet/diagnostics/issues/234

Remove the separate older System.CommandLine version for the Repl. Replaced
the depreciated MethodBinder usage with explicit reflection invoke.

Added the CommandInvoke and HelpInvoke attributes to mark the entry
points into the command class.

Changed the command invoke from async (Task InvokeAsync) to synchronous
(void Invoke) because SOS and CLRMD are basically single threaded.

Allow the screen width for the repl console to change dynamically.

6 years agoadd profiler attach message
David Mason [Thu, 16 May 2019 22:12:40 +0000 (15:12 -0700)]
add profiler attach message

6 years agoAdd list-processes command to dotnet-counters (#243)
Sung Yoon Whang [Fri, 17 May 2019 00:27:24 +0000 (17:27 -0700)]
Add list-processes command to dotnet-counters (#243)

* Add list-processes command

* addressing some pr feedback related to system.commandline

6 years agoAdd alpine/MUSL SOS build/packaging (#264)
Mike McLaughlin [Thu, 16 May 2019 00:10:53 +0000 (17:10 -0700)]
Add alpine/MUSL SOS build/packaging (#264)

Build on alpine docker container.

Add new MUSL SOS binaries to dotnet-dump/dotnet-sos.

Add new "linux-musl-x64" rid to SOS installer and
dotnet-dump.

Skip the "clrstack -i" tests that fail on alpine and 3.0.x.

6 years agoEnable build for arm / arm64 (#268)
Jan Vorlicek [Wed, 15 May 2019 17:55:18 +0000 (10:55 -0700)]
Enable build for arm / arm64 (#268)

Enable build for arm / arm64

6 years agoMerge pull request #269 from MarioHewardt/master
Mario Hewardt [Wed, 15 May 2019 17:20:20 +0000 (10:20 -0700)]
Merge pull request #269 from MarioHewardt/master

fixed hung app markdown

6 years agofixed hung app markdown
Mario Hewardt [Wed, 15 May 2019 17:17:20 +0000 (10:17 -0700)]
fixed hung app markdown

6 years agoMerge pull request #267 from MarioHewardt/master
Mario Hewardt [Wed, 15 May 2019 17:14:24 +0000 (10:14 -0700)]
Merge pull request #267 from MarioHewardt/master

Added new hang scenario

6 years agoAdded new hang scenario
Mario Hewardt [Wed, 15 May 2019 00:44:41 +0000 (17:44 -0700)]
Added new hang scenario

6 years agoMerge pull request #262 from MarioHewardt/master
Noah Falk [Fri, 10 May 2019 22:02:01 +0000 (15:02 -0700)]
Merge pull request #262 from MarioHewardt/master

New tutorial scenario

6 years agopr feedback
Mario Hewardt [Fri, 10 May 2019 18:36:17 +0000 (11:36 -0700)]
pr feedback

6 years agoFilter event counter payloads using CounterType payload (#261)
Sung Yoon Whang [Fri, 10 May 2019 00:24:20 +0000 (17:24 -0700)]
Filter event counter payloads using CounterType payload (#261)

6 years agoadded intermittent mem spike endpoint
Mario Hewardt [Thu, 9 May 2019 21:16:55 +0000 (14:16 -0700)]
added intermittent mem spike endpoint

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 20:46:43 +0000 (13:46 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 20:31:24 +0000 (13:31 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 18:48:25 +0000 (11:48 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 18:46:13 +0000 (11:46 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 18:44:35 +0000 (11:44 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 18:36:04 +0000 (11:36 -0700)]
Update intermittent_memory_spike.md

6 years agoMake SOS packing dependencies invisible in VS's solution viewer (#259)
Juan Hoyos [Thu, 9 May 2019 16:51:40 +0000 (09:51 -0700)]
Make SOS packing dependencies invisible in VS's solution viewer (#259)

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 16:13:35 +0000 (09:13 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 16:00:57 +0000 (09:00 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 15:55:06 +0000 (08:55 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 15:54:43 +0000 (08:54 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 15:53:29 +0000 (08:53 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Thu, 9 May 2019 15:45:03 +0000 (08:45 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Wed, 8 May 2019 23:58:13 +0000 (16:58 -0700)]
Update intermittent_memory_spike.md

6 years agoChange the GenerateCoreDump protocol to use UTF16 dump file name (#258)
Mike McLaughlin [Wed, 8 May 2019 21:45:33 +0000 (14:45 -0700)]
Change the GenerateCoreDump protocol to use UTF16 dump file name (#258)

6 years agoDownload and register DAC with CLRMD (#248)
Mike McLaughlin [Wed, 8 May 2019 16:41:34 +0000 (09:41 -0700)]
Download and register DAC with CLRMD (#248)

Issue https://github.com/dotnet/diagnostics/issues/158

Add SOSInitializeByHost SOS module entry so the SOSHost
code can pass the temp dir created, DAC module path downloaded for
clrmd and the symbol store enabled flag.

Removed ISOSHostServices and replaced initializing the SOSNetCoreCallbacks
initialization as part of the call to SOSInitializeByHost.

Added the "clrmodules" command as a test of a pure CLRMD command and
as place to add the module version requested by some customers.

Catch the DllNotFoundException exception and add "try installing libc6-dev"
to exception message and documentation to work around Microsoft stretch docker
image problems.

Issue: https://github.com/dotnet/diagnostics/issues/201

6 years agoGenerate core dump diagnostic server command (#257)
Mike McLaughlin [Wed, 8 May 2019 07:47:28 +0000 (00:47 -0700)]
Generate core dump diagnostic server command (#257)

Generate core dump diagnostic server command

Add DiagnosticHelpers class with the GenerateCoreDump API.

Change dotnet-dump collect on Linux to use this new API.

Update dotnet-dump collect doc. Remove sudo.

6 years agoMake dotnet-counters exit gracefully on runtime shutdown
Sung Yoon Whang [Tue, 7 May 2019 21:58:42 +0000 (14:58 -0700)]
Make dotnet-counters exit gracefully on runtime shutdown

6 years agoUpdate README.md
Mario Hewardt [Wed, 8 May 2019 00:08:29 +0000 (17:08 -0700)]
Update README.md

6 years agoUpdate README.md
Mario Hewardt [Wed, 8 May 2019 00:07:52 +0000 (17:07 -0700)]
Update README.md

6 years agoUpdate README.md
Mario Hewardt [Wed, 8 May 2019 00:05:17 +0000 (17:05 -0700)]
Update README.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Wed, 8 May 2019 00:03:05 +0000 (17:03 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Wed, 8 May 2019 00:02:37 +0000 (17:02 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Wed, 8 May 2019 00:00:24 +0000 (17:00 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Tue, 7 May 2019 23:09:05 +0000 (16:09 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Tue, 7 May 2019 23:02:23 +0000 (16:02 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Tue, 7 May 2019 22:56:15 +0000 (15:56 -0700)]
Update intermittent_memory_spike.md

6 years agoUpdate intermittent_memory_spike.md
Mario Hewardt [Tue, 7 May 2019 22:20:43 +0000 (15:20 -0700)]
Update intermittent_memory_spike.md

6 years agoinitial add
Mario Hewardt [Tue, 7 May 2019 22:10:23 +0000 (15:10 -0700)]
initial add

6 years ago[dotnet-counters] Make refresh-interval optional (#253)
Sung Yoon Whang [Mon, 6 May 2019 22:28:04 +0000 (15:28 -0700)]
[dotnet-counters] Make refresh-interval optional (#253)

* --refresh-interval is now optional

* Make the default refresh-interval 1

6 years agoRestore commit information to native images (#250)
Juan Hoyos [Mon, 6 May 2019 20:32:47 +0000 (13:32 -0700)]
Restore commit information to native images (#250)

6 years agoTerminate dotnet-trace when the runtime closes the eventpipe
Andrew Au [Mon, 6 May 2019 18:01:28 +0000 (11:01 -0700)]
Terminate dotnet-trace when the runtime closes the eventpipe

6 years agoFix a small typo in memory leak tutorial (#249)
Sung Yoon Whang [Mon, 6 May 2019 08:06:41 +0000 (01:06 -0700)]
Fix a small typo in memory leak tutorial (#249)

6 years agoOverall cleanup for build system - part 1 (#247)
Juan Hoyos [Sat, 4 May 2019 21:31:32 +0000 (14:31 -0700)]
Overall cleanup for build system - part 1 (#247)

* Remove dotnet-analyze from build and CreateVersionFile
* Rename NuGet config file to be compliant with casing
* Use msbuild command in place of hardcoded paths
* Add details file
* Consolidate versions into a single file
* Over all cleanup of project files, properties, and targets
* Little workaround for older version of Arcade around license
* Change format of versioning resources for readability
* Update XUnit versions

6 years agoMerge pull request #245 from MarioHewardt/master
Noah Falk [Fri, 3 May 2019 01:09:16 +0000 (18:09 -0700)]
Merge pull request #245 from MarioHewardt/master

Initial scenario based tutorial

6 years agofix pr feedback
Mario Hewardt [Fri, 3 May 2019 01:05:49 +0000 (18:05 -0700)]
fix pr feedback

6 years agoMoving counters doc to where all other documentations live (#246)
Sung Yoon Whang [Fri, 3 May 2019 00:47:01 +0000 (17:47 -0700)]
Moving counters doc to where all other documentations live (#246)

6 years agoInitial scenario based tutorial
Mario Hewardt [Thu, 2 May 2019 23:52:17 +0000 (16:52 -0700)]
Initial scenario based tutorial

6 years agoUpdate installation instruction for dotnet-counters for P5 (#244)
Sung Yoon Whang [Thu, 2 May 2019 23:30:50 +0000 (16:30 -0700)]
Update installation instruction for dotnet-counters for P5 (#244)

6 years agoDotnet counters doc (#219)
Sung Yoon Whang [Wed, 1 May 2019 23:07:10 +0000 (16:07 -0700)]
Dotnet counters doc (#219)

* some documentation updates to dotnet-counters

* Readme under dotnet-counters directory

* some cleanup

* Adding example for filtering'

* fix list cmd

* Adding some more description in example usage per PR feedback

* PR feedback

* Give some example counters to intro section

* Some syntax fix

* Add dotnet-counters doc to main README

6 years agoFix missing metadata in Linux core dumps. (#229)
Mike McLaughlin [Wed, 1 May 2019 21:54:52 +0000 (14:54 -0700)]
Fix missing metadata in Linux core dumps. (#229)

* Fix missing metadata in Linux core dumps.

Issue #https://github.com/dotnet/diagnostics/issues/56

Both Windows and Linux minidumps don't save all the assemblies' metadata which can cause
stack traces to display !Unknown. On Windows most debuggers like Windbg and VS can load
the module from file for this kind of dumps. On Linux lldb/SOS doesn't load the native
modules and really doesn't know anything about the managed assemblies.

Add metadata callback to datatarget and it's implementation in SOS.NETCore.

Add IsMetadataMemory() and the metadata region list. This is because lldb on core dumps
returns 0's on missing metadata memory reads instead of an error.

6 years agoMerge pull request #236 from dotnet/juhoyosa/rollforward-major
Juan Hoyos [Wed, 1 May 2019 16:24:53 +0000 (09:24 -0700)]
Merge pull request #236 from dotnet/juhoyosa/rollforward-major

Add runtime config template for major rollforward

6 years agoUpdate docs for preview 5. (#238)
Mike McLaughlin [Wed, 1 May 2019 05:29:12 +0000 (22:29 -0700)]
Update docs for preview 5. (#238)

Update the tools version to 1.0.3-preview5.19251.2.

6 years agoAdd runtime config template for major rollforward
Juan Hoyos [Tue, 30 Apr 2019 20:29:49 +0000 (13:29 -0700)]
Add runtime config template for major rollforward

6 years agoIgnore any provider specified via --profile option if they are already specified...
Sung Yoon Whang [Tue, 30 Apr 2019 09:14:06 +0000 (02:14 -0700)]
Ignore any provider specified via --profile option if they are already specified with --providers option (#224)

6 years agoPreview5 doc update. (#225)
Mike McLaughlin [Tue, 30 Apr 2019 02:17:42 +0000 (19:17 -0700)]
Preview5 doc update. (#225)

Add Release notes for dotnet-dump.

Remove --add-source in installation instructions.

6 years agoFix issue with dotnet-counters not being able to target user-defined EventSource...
Sung Yoon Whang [Tue, 30 Apr 2019 01:28:06 +0000 (18:28 -0700)]
Fix issue with dotnet-counters not being able to target user-defined EventSource (#222)

6 years agoFixing list command (#218)
Sung Yoon Whang [Mon, 29 Apr 2019 22:05:22 +0000 (15:05 -0700)]
Fixing list command (#218)

6 years agoMerge pull request #214 from mikem8361/fromrelease
Mike McLaughlin [Sun, 28 Apr 2019 17:13:20 +0000 (10:13 -0700)]
Merge pull request #214 from mikem8361/fromrelease

Commits from release/3.0.

6 years agoMerge pull request #213 from mikem8361/updoc
Mike McLaughlin [Sun, 28 Apr 2019 17:08:29 +0000 (10:08 -0700)]
Merge pull request #213 from mikem8361/updoc

Update tool installation docs to 1.0.3-preview5.19228.1

6 years agoMerge pull request #211 from mikem8361/fixazdo
Mike McLaughlin [Sun, 28 Apr 2019 17:08:12 +0000 (10:08 -0700)]
Merge pull request #211 from mikem8361/fixazdo

Fix artifacts.

6 years agoMerge pull request #209 from mikem8361/fixpush
Mike McLaughlin [Sat, 27 Apr 2019 20:10:03 +0000 (13:10 -0700)]
Merge pull request #209 from mikem8361/fixpush

Fix artifact publishing.

6 years agoFix artifact publishing.
Mike McLaughlin [Sat, 27 Apr 2019 20:08:22 +0000 (13:08 -0700)]
Fix artifact publishing.

6 years agoMerge pull request #208 from mikem8361/fixart
Mike McLaughlin [Sat, 27 Apr 2019 18:07:51 +0000 (11:07 -0700)]
Merge pull request #208 from mikem8361/fixart

Fix naming of artifacts.

6 years agoFix naming of artifacts.
Mike McLaughlin [Sat, 27 Apr 2019 18:06:09 +0000 (11:06 -0700)]
Fix naming of artifacts.

6 years agoAdd Convert command (#196)
John Salem [Fri, 26 Apr 2019 23:34:01 +0000 (16:34 -0700)]
Add Convert command (#196)

* Add Convert command:
* make default format for all platforms 'netperf'
* update spec to refelct impl

* Simplify try/catch to using statements in converter code

* Account for scenario when someone doesn't specify an output filename and the input trace file doesn't have the default name

* Grammar nit

* Update enum value to use Pascal case
* remove -f shorthand for format option

* * remove try/catch
* use ExistingOnly argument extension
* remove unnecessary Arity qualifications

6 years agoAdd command handler to dotnet-counters (#200)
Sung Yoon Whang [Fri, 26 Apr 2019 07:50:47 +0000 (00:50 -0700)]
Add command handler to dotnet-counters (#200)

6 years agoBringing dotnet counters up to spec [part 1] (#199)
Sung Yoon Whang [Fri, 26 Apr 2019 06:15:52 +0000 (23:15 -0700)]
Bringing dotnet counters up to spec [part 1] (#199)

* fix build warnings

* For some reason we dont have CounterType field inside the payload...

* support multiple providers

* Filtering

* Fix broken alignment on list command

* spaces

* support filtering for an entire provider

* Removing -r option

* Add filter for System.Runtime for default monitoring session

6 years agoMake dotnet-counter stream values in real time (#197)
Sung Yoon Whang [Thu, 25 Apr 2019 22:50:00 +0000 (15:50 -0700)]
Make dotnet-counter stream values in real time (#197)

* Streaming counters

* DisplayName stuff

* fix build

* few demo changes

* parsing command-line provided counter list works now

* No more string parsing!!!

* some more fixes in writer

* update license header, display rates

* Removing useless files

* Use known displaynames for known providers

* cleanup

* spaces

* more cleanup

* more cleanup

* PR feedback

6 years agoRenaming non-spec options on dotnet-trace (#192)
José Rivero [Thu, 25 Apr 2019 00:16:10 +0000 (17:16 -0700)]
Renaming non-spec options on dotnet-trace (#192)

* Rename the "profiles" verb to "list-profiles"
* Rename the "endpoints" verb to "list-processes"
* Move pack option/verb to future.
* Move the 'g' command (capture GC heap snapshot) to future.
* Updating docs with missing functionality.

6 years agoNot ready on Non-Windows platform. (#178)
José Rivero [Wed, 24 Apr 2019 15:55:44 +0000 (08:55 -0700)]
Not ready on Non-Windows platform. (#178)

Not ready on Non-Windows platform for **.NET 3.0 Preview5**. This is related to this bug fix: https://github.com/dotnet/coreclr/pull/24198, which will be included in **Preview6**.
The issue manifests when EventPipe is enabled without LTTng. In this case, GC events are disabled after the first GC because LTTng probes are disabled.

6 years agoMerge pull request #187 from mikem8361/fixlldbdoc
Mike McLaughlin [Wed, 24 Apr 2019 00:36:12 +0000 (17:36 -0700)]
Merge pull request #187 from mikem8361/fixlldbdoc

Fix lldb build instructions and scripts.

6 years agoFix lldb build instructions and scripts.
Mike McLaughlin [Tue, 23 Apr 2019 23:28:24 +0000 (16:28 -0700)]
Fix lldb build instructions and scripts.

For CentOS 7, Fedora 24 and OpenSUSE.

6 years agoTypos (#177)
John Doe [Tue, 23 Apr 2019 16:38:48 +0000 (09:38 -0700)]
Typos (#177)

* comamnd -> command
* commited -> committed
* convinient -> convenient
* currnet -> current
* deafualts -> defaults
* defualts -> defaults
* dianostics -> diagnostics
* interogates -> interrogates
* precendent -> precedent
* Redit -> Redis
* if -> is

6 years agoMerge pull request #179 from mikem8361/fixcentos7
Mike McLaughlin [Tue, 23 Apr 2019 05:09:26 +0000 (22:09 -0700)]
Merge pull request #179 from mikem8361/fixcentos7

Fix the build-install-lldb.sh network failure.

6 years agoFix the build-install-lldb.sh network failure.
Mike McLaughlin [Tue, 23 Apr 2019 05:05:46 +0000 (22:05 -0700)]
Fix the build-install-lldb.sh network failure.

Changed downloading binutils from sourceware.org to http://ftp.gnu.org/gnu/binutils.

6 years agoMerge pull request #176 from mikem8361/vs2019fix
Mike McLaughlin [Tue, 23 Apr 2019 04:36:53 +0000 (21:36 -0700)]
Merge pull request #176 from mikem8361/vs2019fix

Fix building with vs2019 only.

6 years agoFix building with vs2019 only.
Mike McLaughlin [Mon, 22 Apr 2019 23:21:30 +0000 (16:21 -0700)]
Fix building with vs2019 only.

6 years agoUpdating gc/gc-collect options to map PerfView flags. (#175)
José Rivero [Mon, 22 Apr 2019 23:12:50 +0000 (16:12 -0700)]
Updating gc/gc-collect options to map PerfView flags. (#175)

6 years agoMerge pull request #164 from github-john-doe/typos
Mike McLaughlin [Mon, 22 Apr 2019 20:54:53 +0000 (13:54 -0700)]
Merge pull request #164 from github-john-doe/typos

Typos

6 years ago[dotnet-trace] Small changes (#173)
José Rivero [Sat, 20 Apr 2019 06:16:54 +0000 (23:16 -0700)]
[dotnet-trace] Small changes (#173)

- Replace hardcoded numbers with existing/equivalent enum.
- Move non-common options to Collect, and started plumbing pack options.
- Remove comment.
- Remove pack changes

6 years agoSpeedscope format (#171)
John Salem [Fri, 19 Apr 2019 18:15:28 +0000 (11:15 -0700)]
Speedscope format (#171)

* Incorporate code from closed PR #114 to enable speedscope output:
* adds format option

* Actually add the converter...

* update dotnet-trace instructions

* Expanded on output format section of instructions

* Change protection level of TraceFileFormatConverter

* Updates in response to feedback

* Update src/Tools/dotnet-trace/TraceFileFormatConverter.cs

Co-Authored-By: josalem <josalem@microsoft.com>
* Update src/Tools/dotnet-trace/CommandLine/Options/CommonOptions.cs

Co-Authored-By: josalem <josalem@microsoft.com>
* Fix typos

6 years ago[dotnet-trace] Adding --profile options and minor fixes. (#172)
José Rivero [Fri, 19 Apr 2019 06:12:37 +0000 (23:12 -0700)]
[dotnet-trace] Adding --profile options and minor fixes. (#172)

* OnStop: rename pid -> processId
* Adding a Versions.props
* Update Collect output format. Added the process main module path.
* Adding profiles verb
* Adding --profile option.
* up-to-spec
* Renaming few ETW instances to EventPipe.

6 years agoMerge pull request #169 from mikem8361/gcheap
Mike McLaughlin [Thu, 18 Apr 2019 22:11:43 +0000 (15:11 -0700)]
Merge pull request #169 from mikem8361/gcheap

Add a destructor for sos::GCHeap