profile/ivi/webkit-efl.git
12 years agoMediaStream API: Update MediaStreamTrackList to match the specification
tommyw@google.com [Mon, 2 Jul 2012 17:24:24 +0000 (17:24 +0000)]
MediaStream API: Update MediaStreamTrackList to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90171

Reviewed by Adam Barth.

Source/Platform:

The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.

* chromium/public/WebMediaStreamCenterClient.h:
(WebKit):
(WebMediaStreamCenterClient):

Source/WebCore:

The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.

Test: fast/mediastream/MediaStreamTrackList.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::addTrack):
(WebCore):
(WebCore::MediaStream::removeTrack):
* Modules/mediastream/MediaStream.h:
(MediaStream):
* Modules/mediastream/MediaStreamTrackEvent.cpp: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp.
(WebCore):
(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::~MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::track):
(WebCore::MediaStreamTrackEvent::interfaceName):
* Modules/mediastream/MediaStreamTrackEvent.h: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.h.
(WebCore):
(MediaStreamTrackEvent):
* Modules/mediastream/MediaStreamTrackEvent.idl: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.idl.
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::detachOwner):
(WebCore):
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
(WebCore::MediaStreamTrackList::stop):
(WebCore::MediaStreamTrackList::interfaceName):
(WebCore::MediaStreamTrackList::scriptExecutionContext):
(WebCore::MediaStreamTrackList::eventTargetData):
(WebCore::MediaStreamTrackList::ensureEventTargetData):
* Modules/mediastream/MediaStreamTrackList.h:
(MediaStreamTrackList):
* Modules/mediastream/MediaStreamTrackList.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* dom/EventTargetFactory.in:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):
* platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
* platform/mediastream/MediaStreamDescriptor.h:
(MediaStreamDescriptorOwner):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::addMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::removeMediaStreamTrack):
* platform/mediastream/chromium/MediaStreamCenterChromium.h:
(WebKit):
(MediaStreamCenterChromium):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):

LayoutTests:

* fast/mediastream/MediaStreamTrackList-expected.txt: Added.
* fast/mediastream/MediaStreamTrackList.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: incorrect height of main timeline pane after switching to memory mode
caseq@chromium.org [Mon, 2 Jul 2012 17:20:10 +0000 (17:20 +0000)]
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387

Reviewed by Pavel Feldman.

- update cached container height when setting vertical splitter position.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[MICRODATA] Build failure in html/HTMLPropertiesCollection.h
commit-queue@webkit.org [Mon, 2 Jul 2012 16:59:15 +0000 (16:59 +0000)]
[MICRODATA] Build failure in html/HTMLPropertiesCollection.h
https://bugs.webkit.org/show_bug.cgi?id=90379

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02
Reviewed by Ryosuke Niwa.

Switch HTMLCollection::append() visibility from private
to protected so that HTMLPropertiesCollection subclass
can call it. This fixes build when MICRODATA flag is
turned on.

No new tests, build fix.

* html/HTMLCollection.h:
(HTMLCollectionCacheBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium expectations update.
eae@chromium.org [Mon, 2 Jul 2012 16:50:11 +0000 (16:50 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed: Fix a flexbox reftest that was failing on most platforms.
tony@chromium.org [Mon, 2 Jul 2012 16:42:05 +0000 (16:42 +0000)]
Unreviewed: Fix a flexbox reftest that was failing on most platforms.

Remove the test case that caused the image diff.  I'll try to come up
with a different way to test this.

* css3/flexbox/anonymous-block-expected.html:
* css3/flexbox/anonymous-block.html:
* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix WebProcess crash on Mac when accessing a site with video tag.
alexis.menard@openbossa.org [Mon, 2 Jul 2012 16:31:10 +0000 (16:31 +0000)]
[Qt] Fix WebProcess crash on Mac when accessing a site with video tag.
https://bugs.webkit.org/show_bug.cgi?id=90384

Reviewed by Jocelyn Turcotte.

We need to initialize the private symbols used by MediaPlayerPrivateQTKit
otherwise they will be null and it will lead to a crash. We copy WebSystemInterface
files for WK2 just like the Mac port as WK2 may have different needs than WK1 layer (we
may add or remove symbols in here). It doesn't fix the video rendering yet but it's
first step.

* Target.pri:
* WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Added.
* WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Added.
(InitWebCoreSystemInterfaceForWK2):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThis test is a flaky crash on the cr-linux-ews, which is causing the
abarth@webkit.org [Mon, 2 Jul 2012 16:22:13 +0000 (16:22 +0000)]
This test is a flaky crash on the cr-linux-ews, which is causing the
bot to be very slow in processing patches and to spam bugs with false
failures. Mark this test as flaky while we investigate.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Read fonts path when running layout tests from alternative fonts dir when main...
carlosgc@webkit.org [Mon, 2 Jul 2012 16:10:49 +0000 (16:10 +0000)]
[GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=89437

Reviewed by Martin Robinson.

If main fonts directory doesn't exist, try with an alternative
fonts directory at build directory.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
(getFontsPath):
(initializeFonts):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
(WTR):
(WTR::getFontsPath):
(WTR::inititializeFontConfigSetting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoA start "body" tag in the "in body" insertion mode is a parse error
commit-queue@webkit.org [Mon, 2 Jul 2012 16:08:26 +0000 (16:08 +0000)]
A start "body" tag in the "in body" insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=90373

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-02
Reviewed by Eric Seidel.

According to HTML5 specification (http://www.w3.org/TR/html5/tree-construction.html#parsing-main-inbody),
a start "body" tag in the "in body" insertion mode is a parse error. So parseError(token) is required here.
No behavior change because parseError(token) is just a marker.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] [WK2] Remove content sniffer and decoder initialization from WebProcess
commit-queue@webkit.org [Mon, 2 Jul 2012 15:59:35 +0000 (15:59 +0000)]
[EFL] [WK2] Remove content sniffer and decoder initialization from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=90275

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-02
Reviewed by Martin Robinson.

Do not initialize content sniffer and decoder in the WebProcess
because the initialization is now done in WebCore.

* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
carlosgc@webkit.org [Mon, 2 Jul 2012 15:54:34 +0000 (15:54 +0000)]
[GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=89435

Reviewed by Martin Robinson.

* Scripts/new-run-webkit-tests: Don't run the tests with the
jhbuild wrapper if there isn't a Dependencies directory inside the
build directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, update expected files, skip new failing tests.
ossy@webkit.org [Mon, 2 Jul 2012 15:32:27 +0000 (15:32 +0000)]
[Qt] Unreviewed gardening, update expected files, skip new failing tests.

* platform/qt-5.0-wk2/Skipped: Skip fast/viewport/viewport-91.html because of bug90376.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Updated after r121599.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Updated after r121599.
* platform/qt/Skipped: Skip inspector/debugger/script-snippet-model.html because of bug90385.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Rename NotificationPresenterEfl with NotificationClientEfl
gyuyoung.kim@samsung.com [Mon, 2 Jul 2012 15:21:35 +0000 (15:21 +0000)]
[EFL] Rename NotificationPresenterEfl with NotificationClientEfl
https://bugs.webkit.org/show_bug.cgi?id=90370

Reviewed by Csaba Osztrogonác.

Source/WebKit:

Bug 80488 renamed NotificationPresenter with NotificationClient. So, EFL port needs to adjust
it as well.

* PlatformEfl.cmake:

Source/WebKit/efl:

Bug 80488 renamed NotificationPresenter with NotificationClient. So, EFL port needs to adjust it as well.

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/NotificationClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp.
(WebCore):
(WebCore::NotificationClientEfl::NotificationClientEfl):
(WebCore::NotificationClientEfl::~NotificationClientEfl):
(WebCore::NotificationClientEfl::show):
(WebCore::NotificationClientEfl::cancel):
(WebCore::NotificationClientEfl::notificationObjectDestroyed):
(WebCore::NotificationClientEfl::notificationControllerDestroyed):
(WebCore::NotificationClientEfl::requestPermission):
(WebCore::NotificationClientEfl::checkPermission):
(WebCore::NotificationClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h.
(WebCore):
(NotificationClientEfl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Unreviewed build fix with ENABLE_NETSCAPE_PLUGIN_API after r121467.
rakuco@webkit.org [Mon, 2 Jul 2012 14:20:03 +0000 (14:20 +0000)]
[EFL] Unreviewed build fix with ENABLE_NETSCAPE_PLUGIN_API after r121467.

* plugins/efl/PluginPackageEfl.cpp:
(WebCore::PluginPackage::load): Move the declaration of `err'
before the first `goto' statement.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: replace recursion with a stack in DOM nodes snapshot traversal.
commit-queue@webkit.org [Mon, 2 Jul 2012 14:18:25 +0000 (14:18 +0000)]
Web Inspector: replace recursion with a stack in DOM nodes snapshot traversal.
https://bugs.webkit.org/show_bug.cgi?id=89889

Number of DOM nodes native snapshots can handle was limited
by the process stack size because of recursion used to traverse the nodes.
The patch changes the recursion to a stack based algorithm.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-02
Reviewed by Yury Semikhatsky.

* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(InstrumentedPointerBase):
(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(WebCore::MemoryInstrumentation::reportInstrumentedPointer):
(WebCore):
(WebCore::::process):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Add requestFileContent command and fileContentReceived event
commit-queue@webkit.org [Mon, 2 Jul 2012 14:12:04 +0000 (14:12 +0000)]
Web Inspector: Add requestFileContent command and fileContentReceived event
https://bugs.webkit.org/show_bug.cgi?id=89642

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/read-file.html

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.get resourceType):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):

LayoutTests:

* http/tests/inspector/filesystem/read-file-expected.txt: Added.
* http/tests/inspector/filesystem/read-file.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Add refresh button to FileSystemView status bar
commit-queue@webkit.org [Mon, 2 Jul 2012 13:10:11 +0000 (13:10 +0000)]
Web Inspector: Add refresh button to FileSystemView status bar
https://bugs.webkit.org/show_bug.cgi?id=90244

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
(WebInspector.FileSystemView.prototype.get statusBarItems):
(WebInspector.FileSystemView.prototype.showView):
(WebInspector.FileSystemView.prototype._refresh):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):

LayoutTests:

* http/tests/inspector/filesystem/directory-tree.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK gardening, removing GTK-specific baseline that's
zandobersek@gmail.com [Mon, 2 Jul 2012 12:56:38 +0000 (12:56 +0000)]
Unreviewed GTK gardening, removing GTK-specific baseline that's
not required anymore after r121661.

* platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Implement snippets evaluation.
vsevik@chromium.org [Mon, 2 Jul 2012 12:51:57 +0000 (12:51 +0000)]
Web Inspector: Implement snippets evaluation.
https://bugs.webkit.org/show_bug.cgi?id=88707

Reviewed by Pavel Feldman.

Source/WebCore:

Implemented snippet evaluation and adjusted breakpoints behavior when editing snippet.
Snippets are evaluated using separate compile and run.
Breakpoints are updated after compilation (once scriptId is available they can be set in debugger).
If separate compile and run is not supported by port or debugger is paused we fall back to evaluation in console.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.runScript.runCallback):
(WebInspector.ConsoleView.prototype.runScript):
(WebInspector.ConsoleView.prototype._printResult):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.supportsEnabledBreakpointsWhileEditing):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._rawLocationToUILocation):
(WebInspector.ScriptSnippetModel.prototype._removeBreakpoints):
(WebInspector.ScriptSnippetModel.prototype._restoreBreakpoints):
(WebInspector.ScriptSnippetModel.prototype._evaluationSourceURL):
(WebInspector.SnippetJavaScriptSource.prototype.isDivergedFromVM):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):
(WebInspector.SnippetJavaScriptSource.prototype.evaluate):
(WebInspector.SnippetJavaScriptSource.prototype.supportsEnabledBreakpointsWhileEditing):
(WebInspector.SnippetJavaScriptSource.prototype.breakpointStorageId):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):

LayoutTests:

* inspector/debugger/script-snippet-model-expected.txt:
* inspector/debugger/script-snippet-model.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: StyleSource should set content using CSSStyleModelResourceBinding...
vsevik@chromium.org [Mon, 2 Jul 2012 12:13:19 +0000 (12:13 +0000)]
Web Inspector: StyleSource should set content using CSSStyleModelResourceBinding directly.
https://bugs.webkit.org/show_bug.cgi?id=89891

Reviewed by Pavel Feldman.

StyleSource now calls CSS resource binding directly.
CSS resource binding now adds resource revision only after setStyleSheetText call returns from backend.
Resource.revertAndClearHistory is now clearing history asynchronously
since Resource.setContent adds revision that should be removed as well.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent.innerCallback):
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.Resource.prototype.revertAndClearHistory.clearHistory):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._createResourceItem):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Add DirectoryContentView for FileSystemView
commit-queue@webkit.org [Mon, 2 Jul 2012 12:07:51 +0000 (12:07 +0000)]
Web Inspector: Add DirectoryContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=89961

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DirectoryContentView.js: Added.
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onattach):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Simplify detection of non-installed module file
vestbo@webkit.org [Mon, 2 Jul 2012 11:27:48 +0000 (11:27 +0000)]
[Qt] Simplify detection of non-installed module file

Has the additional advantage that we do not rely on additional information.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.

* qmake/qt_webkit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Rebaseline needed after r121296 and r121599
commit-queue@webkit.org [Mon, 2 Jul 2012 10:55:19 +0000 (10:55 +0000)]
[EFL] Rebaseline needed after r121296 and r121599
https://bugs.webkit.org/show_bug.cgi?id=90364

Unreviewed EFL gardening. Update baselines for a few
test cases after r121296 and r121599.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02

* platform/efl/TestExpectations:
* platform/efl/fast/backgrounds/size/zero-expected.png:
* platform/efl/fast/backgrounds/size/zero-expected.txt:
* platform/efl/fast/transforms/bounding-rect-zoom-expected.png:
* platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Added.
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Fix compilation error in GamepadsEfl.cpp in debug mode
commit-queue@webkit.org [Mon, 2 Jul 2012 10:44:05 +0000 (10:44 +0000)]
[EFL] Fix compilation error in GamepadsEfl.cpp in debug mode
https://bugs.webkit.org/show_bug.cgi?id=90369

Unreviewed, EFL build fix.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02

* platform/efl/GamepadsEfl.cpp:
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Skip fast/js/navigator-language.html
commit-queue@webkit.org [Mon, 2 Jul 2012 10:30:22 +0000 (10:30 +0000)]
[EFL] Skip fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=90365

Unreviewed EFL gardening.
Skip fast/js/navigator-language.html until
Bug 89639 is fixed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Design WebSockets panel
commit-queue@webkit.org [Mon, 2 Jul 2012 09:50:36 +0000 (09:50 +0000)]
Web Inspector: Design WebSockets panel
https://bugs.webkit.org/show_bug.cgi?id=89461

Use DataGrid to display the data.
Put "Data" column first. Make it wider.
Remove "Mask" column since it appears to be always true for outgoing frames,
and false for incoming.

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-07-02
Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView): Don't show Preview, Response, Cookies
and Timing tabs for succefuly established WebSocket connection.

* inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView):
* inspector/front-end/networkPanel.css:
(.resource-websocket):
(.resource-websocket, .resource-websocket .data-grid):
(.resource-websocket .data-grid .data):
(.resource-websocket td):
(.resource-websocket .data-column div):
(.resource-websocket-row-outcoming):
(.resource-websocket-row-outcoming:not(.selected) td):
(.resource-websocket-row-outcoming:not(.selected) td, .resource-websocket-row-outcoming:not(.selected) + tr td):
(.resource-websocket-row-opcode):
(.resource-websocket-row-opcode td):
(.resource-websocket-row-opcode td, .resource-websocket-row-opcode + tr td):
(.resource-websocket-row-error):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r120329, r121113, and r121138.
commit-queue@webkit.org [Mon, 2 Jul 2012 09:31:11 +0000 (09:31 +0000)]
Unreviewed, rolling out r120329, r121113, and r121138.
http://trac.webkit.org/changeset/120329
http://trac.webkit.org/changeset/121113
http://trac.webkit.org/changeset/121138
https://bugs.webkit.org/show_bug.cgi?id=90368

Introduced noticeable keyboard-related spins due to
synchronous IPC. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-02

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd some expectations for the top flaky tests on chromium-linux.
abarth@webkit.org [Mon, 2 Jul 2012 09:07:56 +0000 (09:07 +0000)]
Add some expectations for the top flaky tests on chromium-linux.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8Binding] Merging v8NumberArray()/v8NumberArrayToVector() to v8Array()/toNativeArra...
commit-queue@webkit.org [Mon, 2 Jul 2012 08:42:29 +0000 (08:42 +0000)]
[V8Binding] Merging v8NumberArray()/v8NumberArrayToVector() to v8Array()/toNativeArray() respectively.
https://bugs.webkit.org/show_bug.cgi?id=90338

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-02
Reviewed by Kentaro Hara.

We can remove v8NumberArray() and v8NumberArrayToVector() implementaion
merging them to current v8Array() and toNativeArray() traits.

Tests: TestObj.idl
Shouldn't cause any behavioural changes.

* bindings/scripts/CodeGeneratorV8.pm: Removed float[]/double[] specific binding code.
(IsRefPtrType):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.
(WebCore::TestObjV8Internal::floatArrayAttrGetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrGetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
* bindings/v8/V8Binding.h: Added templates for float and double.
(WebCore::v8Array):
(WebCore::toNativeArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Updated Chromium test expectations. Added a missing bug
yurys@chromium.org [Mon, 2 Jul 2012 07:50:43 +0000 (07:50 +0000)]
Unreviewed. Updated Chromium test expectations. Added a missing bug
number to the expectations.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
kbalazs@webkit.org [Mon, 2 Jul 2012 07:35:28 +0000 (07:35 +0000)]
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-07-02
Reviewed by Daniel Bates.

Source/WebCore:

Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated.  Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.

* dom/ViewportArguments.h:
(ViewportArguments):

LayoutTests:

Unskip now passing tests.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip new failing test.
kkristof@inf.u-szeged.hu [Mon, 2 Jul 2012 07:10:21 +0000 (07:10 +0000)]
[Qt] Unreviewed gardening, skip new failing test.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r121599.
kkristof@inf.u-szeged.hu [Mon, 2 Jul 2012 07:07:02 +0000 (07:07 +0000)]
[Qt] Unreviewed gardening after r121599.

* platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: add v8 bindings memory info to the native memory graph
yurys@chromium.org [Mon, 2 Jul 2012 07:04:41 +0000 (07:04 +0000)]
Web Inspector: add v8 bindings memory info to the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=90149

Reviewed by Pavel Feldman.

Size of V8 binding maps is now reported on the memory chart.

* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore):
* bindings/v8/DOMDataStore.h:
(WebCore):
(DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
(ChunkedTable):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore):
(WebCore::StringCache::reportMemoryUsage):
* bindings/v8/V8Binding.h:
(WebCore):
(StringCache):
(V8BindingPerIsolateData):
* bindings/v8/V8DOMMap.h:
(WebCore):
(AbstractWeakReferenceMap):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore):
(WebCore::MemoryInstrumentation::reportHashMap): added a method for reporting
size of a HashMap.
* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::domTreeInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Add Gamepad support
commit-queue@webkit.org [Mon, 2 Jul 2012 06:22:14 +0000 (06:22 +0000)]
[EFL] Add Gamepad support
https://bugs.webkit.org/show_bug.cgi?id=90170

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-01
Reviewed by Kenneth Rohde Christiansen.

.:

* Source/cmake/FindEFL.cmake: Bump EFL libs dependencies.
* Source/cmake/OptionsEfl.cmake: Turn on GAMEPAD flag on EFL port.
* Source/cmakeconfig.h.cmake: Add GAMEPAD flag to CMake.

Source/WebCore:

Add support for the Gamepad feature on the EFL port.

The implementation of this class relies on the Linux
kernel joystick API.

Gamepad devices are recognized through the GamepadsEfl
class, of which implementation is based on Eeze
library. This way devices are properly registered on
connection as objects of the GamepadDeviceEfl class
which inherits GamepadDeviceLinux. GamepadDeviceEfl
reads the joystick data through an Ecore_Fd_Handler
and updates the device state accordingly. The
GamepadsEfl object is then polled for gamepads data
through the sampleGamepads method.

No new tests - already tested by gamepad/*

* CMakeLists.txt:
* PlatformEfl.cmake:
* platform/efl/GamepadsEfl.cpp: Added.
(WebCore):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::create):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::~GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(GamepadsEfl):
(WebCore::GamepadsEfl::onGamePadChange):
(WebCore::GamepadsEfl::GamepadsEfl):
(WebCore::GamepadsEfl::~GamepadsEfl):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
(WebCore::GamepadsEfl::updateGamepadList):
(WebCore::sampleGamepads):

Tools:

* Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
by default for EFL port.
* efl/jhbuild.modules: Bump dependency versions of EFL libs
since the latest Eeze is required for gamepad support.

LayoutTests:

Unskip gamepad/gamepad-api.html now that Gamepad
support is enabled on EFL port.

gamepad/gamepad-polling-access.html is still
skipped because it requires additional test
infrastructure.

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove platform/qt/fast/jsnavigator-language.html to fast/js
commit-queue@webkit.org [Mon, 2 Jul 2012 05:21:57 +0000 (05:21 +0000)]
Move platform/qt/fast/jsnavigator-language.html to fast/js
https://bugs.webkit.org/show_bug.cgi?id=90261

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-01
Reviewed by Ryosuke Niwa.

Efl needs a test case for navigator.language.
This test case is modified for all ports.

* fast/js/navigator-language-expected.txt: Copied from LayoutTests/platform/qt/fast/js/navigator-language-expected.txt.
* fast/js/navigator-language.html: Copied from LayoutTests/platform/qt/fast/js/navigator-language.html.
* platform/qt/fast/js/navigator-language-expected.txt: Removed.
* platform/qt/fast/js/navigator-language.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r121650.
keishi@webkit.org [Mon, 2 Jul 2012 05:11:32 +0000 (05:11 +0000)]
Unreviewed, rolling out r121650.
http://trac.webkit.org/changeset/121650
https://bugs.webkit.org/show_bug.cgi?id=90303

runhooks is failing for chromium win bots and
WebAnimationTest.DefaultSettings is crashing

Source/Platform:

* Platform.gypi:
* chromium/public/WebAnimation.h: Removed.
* chromium/public/WebAnimationCurve.h: Removed.
* chromium/public/WebFloatAnimationCurve.h: Removed.
* chromium/public/WebFloatKeyframe.h: Removed.
* chromium/public/WebTransformAnimationCurve.h: Removed.
* chromium/public/WebTransformKeyframe.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* src/WebAnimation.cpp: Removed.
* src/WebAnimationCurveCommon.cpp: Removed.
* src/WebAnimationCurveCommon.h: Removed.
* src/WebFloatAnimationCurve.cpp: Removed.
* src/WebTransformAnimationCurve.cpp: Removed.
* tests/WebAnimationTest.cpp: Removed.
* tests/WebFloatAnimationCurveTest.cpp: Removed.
* tests/WebTransformAnimationCurveTest.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago [Chromium] Fix TestExpectations error caused in r121652.
keishi@webkit.org [Mon, 2 Jul 2012 04:32:17 +0000 (04:32 +0000)]
   [Chromium] Fix TestExpectations error caused in r121652.

Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Removing LEOPARD from TestExpectations so the tests run.
keishi@webkit.org [Mon, 2 Jul 2012 04:15:05 +0000 (04:15 +0000)]
[Chromium] Removing LEOPARD from TestExpectations so the tests run.
Caused by r121595

Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r121635.
jamesr@google.com [Mon, 2 Jul 2012 02:55:42 +0000 (02:55 +0000)]
Unreviewed, rolling out r121635.
http://trac.webkit.org/changeset/121635
https://bugs.webkit.org/show_bug.cgi?id=90286

Breaks compile on clang error: in-class initializer for static
data member of type 'const float' is a GNU extension
[-Werror,-Wgnu]

Source/WebCore:

* dom/ViewportArguments.h:
(ViewportArguments):

LayoutTests:

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Create a WebKit::Web* wrapper for the cc animation classes
commit-queue@webkit.org [Mon, 2 Jul 2012 02:21:19 +0000 (02:21 +0000)]
[chromium] Create a WebKit::Web* wrapper for the cc animation classes
https://bugs.webkit.org/show_bug.cgi?id=90303

Patch by Ian Vollick <vollick@chromium.org> on 2012-07-01
Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:
* chromium/public/WebAnimation.h: Added.
(WebCore):
(WebKit):
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
(WebKit::WebAnimation::~WebAnimation):
* chromium/public/WebAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebAnimationCurve):
(WebKit::WebAnimationCurve::~WebAnimationCurve):
(WebKit::WebAnimationCurve::WebAnimationCurve):
* chromium/public/WebFloatAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
* chromium/public/WebFloatKeyframe.h: Added.
(WebKit):
(WebKit::WebFloatKeyframe::WebFloatKeyframe):
(WebFloatKeyframe):
* chromium/public/WebTransformAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):
* chromium/public/WebTransformKeyframe.h: Added.
(WebKit):
(WebKit::WebTransformKeyframe::WebTransformKeyframe):
(WebTransformKeyframe):

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* src/WebAnimation.cpp: Added.
(WebKit):
(WebKit::WebAnimation::iterations):
(WebKit::WebAnimation::setIterations):
(WebKit::WebAnimation::startTime):
(WebKit::WebAnimation::setStartTime):
(WebKit::WebAnimation::timeOffset):
(WebKit::WebAnimation::setTimeOffset):
(WebKit::WebAnimation::alternatesDirection):
(WebKit::WebAnimation::setAlternatesDirection):
(WebKit::WebAnimation::toCCActiveAnimation):
(WebKit::WebAnimation::initialize):
(WebKit::WebAnimation::destroy):
* src/WebAnimationCurveCommon.cpp: Added.
(WebKit):
(WebKit::createTimingFunction):
* src/WebAnimationCurveCommon.h: Added.
(WebCore):
(WebKit):
* src/WebFloatAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebFloatAnimationCurve::add):
(WebKit::WebFloatAnimationCurve::toCCAnimationCurve):
(WebKit::WebFloatAnimationCurve::initialize):
(WebKit::WebFloatAnimationCurve::destroy):
* src/WebTransformAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebTransformAnimationCurve::add):
(WebKit::WebTransformAnimationCurve::toCCAnimationCurve):
(WebKit::WebTransformAnimationCurve::initialize):
(WebKit::WebTransformAnimationCurve::destroy):
* tests/WebAnimationTest.cpp: Added.
* tests/WebFloatAnimationCurveTest.cpp: Added.
* tests/WebTransformAnimationCurveTest.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][WK2] Add API to inspect a Web Intent
commit-queue@webkit.org [Mon, 2 Jul 2012 02:12:41 +0000 (02:12 +0000)]
[EFL][WK2] Add API to inspect a Web Intent
https://bugs.webkit.org/show_bug.cgi?id=89749

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-01
Reviewed by Kenneth Rohde Christiansen.

Add EFL API to inspect a Web Intent and emit a signal
on the view when a new intent request is made.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_intent.cpp: Added.
(_Ewk_Intent):
(ewk_intent_ref):
(ewk_intent_unref):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
(ewk_intent_new):
* UIProcess/API/efl/ewk_intent.h: Added.
* UIProcess/API/efl/ewk_intent_private.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_request_new):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
abarth@webkit.org [Mon, 2 Jul 2012 00:34:09 +0000 (00:34 +0000)]
Unreviewed.

Using the default start cylinder for fdisk causes a warning about the
partition not starting on physical sector boundary.  The Ubuntu forums
recommend using a number that's divisible by 8, which is what we do in
this patch.

* EWSTools/cold-boot.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the "Inspect Element" context menu item appear in nightly builds again.
timothy@apple.com [Mon, 2 Jul 2012 00:27:20 +0000 (00:27 +0000)]
Make the "Inspect Element" context menu item appear in nightly builds again.

rdar://problem/11702613
https://webkit.org/b/89323

Reviewed by Dan Bernstein.

Source/WebCore:

* platform/ContextMenuItem.h:
Fix the order of the ContextMenuAction enum to be binary compatible with
older versions of WebKit.

Source/WebKit/mac:

* WebView/WebUIDelegatePrivate.h:
Add missing enums that were added in ContextMenuItem.h but left out here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/11785743> [mac] Non-BMP characters in vertical text appear as missing...
mitz@apple.com [Mon, 2 Jul 2012 00:08:47 +0000 (00:08 +0000)]
<rdar://problem/11785743> [mac] Non-BMP characters in vertical text appear as missing glyphs
https://bugs.webkit.org/show_bug.cgi?id=90349

Reviewed by Dean Jackson.

Source/WebCore:

Test: platform/mac/fast/text/vertical-surrogate-pair.html

* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill): When calling wkGetVerticalGlyphsForCharacters or
CTFontGetGlyphsForCharacters with a buffer consisting of surrogate pair, account for those
functions’ behavior of placing glyphs at indices corresponding to the first character of
each pair.

LayoutTests:

* platform/mac/fast/text/vertical-surrogate-pair.html: Added.
* platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
* platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
abarth@webkit.org [Mon, 2 Jul 2012 00:08:17 +0000 (00:08 +0000)]
Unreviewed.

It turns out we need to use Ubuntu 10.04 to get the right image results
for chromium-linux. This patch updates our scripts to be compatible
with Ubuntu 10.04.

* EWSTools/cold-boot.sh:
    - fdisk doesn't have p and 1 as default commands in 10.04.
* EWSTools/start-queue.sh:
    - git doesn't understanding the -B argument in 10.04. We've been
      using this change locally on the EC2 bots for a while.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoArabic shaping is incorrect if ZWNJ exist
bashi@chromium.org [Sun, 1 Jul 2012 23:08:01 +0000 (23:08 +0000)]
Arabic shaping is incorrect if ZWNJ exist
https://bugs.webkit.org/show_bug.cgi?id=89843

Reviewed by Dan Bernstein.

Source/WebCore:

mac port treats ZWJ (zero-width-joiner) and ZWNJ (zero-width-non-joiner) as a part of combining
character sequence. This could cause a problem when the font doesn't have glyph mapping of ZWJ and ZWNJ.
Suppose the text to be rendered is "U+0645(MEEM) U+06CC(FARSI YEH) U+200C(ZWNJ)". In this case, U+0645
and U+06CC are rendered in isolated form if the font doesn't have a glyph for ZWNJ. They should be joined.

This patch changes handling of ZWJ and ZWNJ. Treats ZWJ and ZWNJ as base characters so that a complex text
run isn't separate at the point of ZWJ and ZWNJ even the font doesn't contain glyphs for them.
If ComplexTextController finds ZWJ, it doesn't split the current complex text run.

Test: platform/mac/fast/text/arabic-zwj-and-zwnj.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Don't treat ZWJ and ZWNJ as a part of combining character sequence.
(WebCore::ComplexTextController::collectComplexTextRuns): Set fontData to nextFontData if the baseCharacter is ZWJ.

LayoutTests:

* platform/mac/fast/text/arabic-zwj-and-zwnj-expected.html: Added.
* platform/mac/fast/text/arabic-zwj-and-zwnj.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed rebaseline for mac post r121599.
eae@chromium.org [Sun, 1 Jul 2012 22:54:12 +0000 (22:54 +0000)]
Unreviewed rebaseline for mac post r121599.

* platform/mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
abarth@webkit.org [Sun, 1 Jul 2012 22:49:59 +0000 (22:49 +0000)]
Unreviewed.

* EWSTools/boot.sh:
    - We need to start the screen in detached mode so that we can run
      it remotely via ssh.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed test expectations update for chromium.
eae@chromium.org [Sun, 1 Jul 2012 22:44:36 +0000 (22:44 +0000)]
Unreviewed test expectations update for chromium.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
abarth@webkit.org [Sun, 1 Jul 2012 21:30:26 +0000 (21:30 +0000)]
Unreviewed.

* EWSTools/cold-boot.sh:
    - Turns out we need to sudo this command in order for it to
      actually dimiss the EULA screen. :)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
commit-queue@webkit.org [Sun, 1 Jul 2012 21:01:34 +0000 (21:01 +0000)]
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-07-01
Reviewed by Daniel Bates.

Source/WebCore:

Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated.  Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.

* dom/ViewportArguments.h:
(ViewportArguments):

LayoutTests:

Unskip now passing tests.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClear visited links when clearing history.
staikos@webkit.org [Sun, 1 Jul 2012 17:09:25 +0000 (17:09 +0000)]
Clear visited links when clearing history.
https://bugs.webkit.org/show_bug.cgi?id=90345

Reviewed by Antonio Gomes.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::clearHistory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSObject wastes too much memory on unused property slots
fpizlo@apple.com [Sun, 1 Jul 2012 03:54:49 +0000 (03:54 +0000)]
JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255

Reviewed by Mark Hahnenberg.

Rolling back in after applying a simple fix: it appears that
JSObject::setStructureAndReallocateStorageIfNecessary() was allocating more
property storage than necessary. Fixing this appears to resolve the crash.

This does a few things:

- JSNonFinalObject no longer has inline property storage.

- Initial out-of-line property storage size is 4 slots for JSNonFinalObject,
  or 2x the inline storage for JSFinalObject.

- Property storage is only reallocated if it needs to be. Previously, we
  would reallocate the property storage on any transition where the original
  structure said shouldGrowProperyStorage(), but this led to spurious
  reallocations when doing transitionless property adds and there are
  deleted property slots available. That in turn led to crashes, because we
  would switch to out-of-line storage even if the capacity matched the
  criteria for inline storage.

- Inline JSFunction allocation is killed off because we don't have a good
  way of inlining property storage allocation. This didn't hurt performance.
  Killing off code is better than fixing it if that code wasn't doing any
  good.

This looks like a 1% progression on V8.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
* runtime/Structure.h:
(JSC::Structure::putWillGrowPropertyStorage):
(Structure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium rebaseline for svg/zoom.
eae@chromium.org [Sat, 30 Jun 2012 23:32:48 +0000 (23:32 +0000)]
Unreviewed chromium rebaseline for svg/zoom.

* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium windows rebaseline.
eae@chromium.org [Sat, 30 Jun 2012 23:29:43 +0000 (23:29 +0000)]
Unreviewed chromium windows rebaseline.

* platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
commit-queue@webkit.org [Sat, 30 Jun 2012 22:54:56 +0000 (22:54 +0000)]
[BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
https://bugs.webkit.org/show_bug.cgi?id=90241

This issue is caused by single quotes in option's labels.
We should use the escape character of single quotes in JavaScript's string which
starts and ends with single quotes.
So we replace lablels' single quotes with its escape character during generating the
select popUp's HTML.

.:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.

* ManualTests/blackberry/select-popup-items-unicode-display.html:

Source/WebKit/blackberry:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebkit crashes in DFG on Google Docs when creating a new document
fpizlo@apple.com [Sat, 30 Jun 2012 19:28:26 +0000 (19:28 +0000)]
Webkit crashes in DFG on Google Docs when creating a new document
https://bugs.webkit.org/show_bug.cgi?id=90209

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Don't attempt to short-circuit Phantom(GetLocal) if the GetLocal is for a
captured variable.

* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local-expected.txt: Added.
* fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.html: Added.
* fast/js/script-tests/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.js: Added.
(baz):
(stuff):
(foo):
(o.g):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content...
commit-queue@webkit.org [Sat, 30 Jun 2012 15:55:54 +0000 (15:55 +0000)]
[chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space.
https://bugs.webkit.org/show_bug.cgi?id=90092

The CanvasLayerTextureUpdater currently receives its opaque rects in
layer space, but is expected to return them in content space and does
not convert them. This patch adds this conversion. To avoid numerical
errors, this patch also switches to using float rects to store opaque
rects where appropriate.

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-30
Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebContentLayerClient.h:
(WebKit):
(WebContentLayerClient):

Source/WebCore:

Unit test: ContentLayerTest.ContentLayerPainterWithDeviceScale

* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerDelegate):
(ContentLayerPainter):
* platform/graphics/chromium/LayerPainterChromium.h:
(WebCore):
(LayerPainterChromium):
* platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::paintContents):
* platform/graphics/chromium/LinkHighlight.h:
(LinkHighlight):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:

Source/WebKit/chromium:

* WebKit.gypi:
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::paintContents):
* tests/ContentLayerChromiumTest.cpp: Added.
(WebKit):
(OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::~OpaqueRectDrawingGraphicsContextPainter):
(MockContentLayerDelegate):
(WebKit::MockContentLayerDelegate::MockContentLayerDelegate):
(WebKit::TEST):
* tests/LayerChromiumTest.cpp:
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
* tests/TiledLayerChromiumTest.cpp:
* tests/WebLayerTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r121605.
zandobersek@gmail.com [Sat, 30 Jun 2012 12:09:15 +0000 (12:09 +0000)]
Unreviewed, rolling out r121605.
http://trac.webkit.org/changeset/121605
https://bugs.webkit.org/show_bug.cgi?id=90336

Changes caused flaky crashes in sputnik/Unicode tests on Apple
WK1 and GTK Linux builders

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC):
(JSC::JIT::emitAllocateJSFunction):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
* runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage):
(JSC::Structure::propertyStorageSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Allow surface resizing for use cases other than rotation.
jpetsovits@rim.com [Sat, 30 Jun 2012 11:56:38 +0000 (11:56 +0000)]
[BlackBerry] Allow surface resizing for use cases other than rotation.
https://bugs.webkit.org/show_bug.cgi?id=90295
RIM PR 171459

Reviewed by George Staikos.

A new API method setHasPendingSurfaceSizeChange() is
introduced for that effect, and used inside of
setViewportSize() to let the WebPageClient do the
resizing. Methods are renamed to reflect that this
is not exclusively meant for rotation anymore.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(WebKit):
(BlackBerry::WebKit::WebPage::setHasPendingSurfaceSizeChange):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebPage.h:
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK and EFL gardening, adding image expectation
zandobersek@gmail.com [Sat, 30 Jun 2012 10:39:47 +0000 (10:39 +0000)]
Unreviewed GTK and EFL gardening, adding image expectation
for the failing css3/flexbox/anonymous-block.html test.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK gardening, updating baselines after r121599.
zandobersek@gmail.com [Sat, 30 Jun 2012 10:21:32 +0000 (10:21 +0000)]
Unreviewed GTK gardening, updating baselines after r121599.

* platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Added.
* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Remove unused declaration.
kseo@webkit.org [Sat, 30 Jun 2012 09:29:04 +0000 (09:29 +0000)]
Unreviewed. Remove unused declaration.
HTMLDocumentParser::begin() has no method definition.

* html/parser/HTMLDocumentParser.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTurns out we need zip too.
abarth@webkit.org [Sat, 30 Jun 2012 05:02:16 +0000 (05:02 +0000)]
Turns out we need zip too.

* EWSTools/cold-boot.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a cold-boot.sh script for the EWS
abarth@webkit.org [Sat, 30 Jun 2012 05:00:07 +0000 (05:00 +0000)]
Add a cold-boot.sh script for the EWS
https://bugs.webkit.org/show_bug.cgi?id=90330

Unreviewed.

* EWSTools/cold-boot.sh: Added.
    - This script can take us from a cold GCE instance to a running EWS
      bot in one fell swoop.
* EWSTools/start-queue.sh:
    - The if-block at the top of this script was causing trouble. I
      removed it from the bots a while ago. Now that we're using SVN to
      cold-boot the EWS bots, we need to make this change in the repo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Private non-QtQuick API
commit-queue@webkit.org [Sat, 30 Jun 2012 04:18:40 +0000 (04:18 +0000)]
[Qt][WK2] Private non-QtQuick API
https://bugs.webkit.org/show_bug.cgi?id=84532

.:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

API tests for QRawWebView.

* Source/tests.pri:

Source/WebKit2:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

Adding new private non-QtQuick API. This new C++ API makes it possible
to have control over the lower levels of WebKit without going via QML.

This is a first version of the API, enough to show pages on the screen.
Many features are not implemented.

* Target.pri:
* UIProcess/API/qt/raw/qrawwebview.cpp: Added.
* UIProcess/API/qt/raw/qrawwebview_p.h: Added.
* UIProcess/API/qt/raw/qrawwebview_p_p.h: Added.

The tests for the new API are pixel tests. They use QRawWebView to load
html files and generate images, and them compare those images to the ones
in UIProcess/API/qt/tests/html/resources.

* UIProcess/API/qt/tests/html/bluesquare.html: Added.
* UIProcess/API/qt/tests/html/redsquare.html: Added.
* UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Added.
* UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Added.
* UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Added.
* UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Added.
* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Added.

Tools:

MiniBrowserRaw is an usage example for the QRawWebView API.
It is only an example and is not fully implemented.

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

* MiniBrowser/qt/raw/DerivedSources.pri: Added.
* MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
* MiniBrowser/qt/raw/Target.pri: Added.
* MiniBrowser/qt/raw/View.cpp: Added.
* MiniBrowser/qt/raw/View.h: Added.
* Scripts/webkitpy/style/checker.py:
* Tools.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove leopard bots from garden-o-matic
ojan@chromium.org [Sat, 30 Jun 2012 03:54:21 +0000 (03:54 +0000)]
Remove leopard bots from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90328

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r121569.
noam.rosenthal@nokia.com [Sat, 30 Jun 2012 03:52:17 +0000 (03:52 +0000)]
Unreviewed, rolling out r121569.
http://trac.webkit.org/changeset/121569
https://bugs.webkit.org/show_bug.cgi?id=90082

It broke a couple of tests in Qt Linux Release

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogarden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLoca...
ojan@chromium.org [Sat, 30 Jun 2012 03:36:48 +0000 (03:36 +0000)]
garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
https://bugs.webkit.org/show_bug.cgi?id=90243

Reviewed by Dirk Pranke.

jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
all.

Not really sure how to unittest this. I tested it all manually of course.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
Not related to this patch, but figured I'd update the failing test while I was at it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoupdateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
simon.fraser@apple.com [Sat, 30 Jun 2012 03:36:33 +0000 (03:36 +0000)]
updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=90245

Reviewed by Dan Bernstein.

updateDescendantDependentFlags() and updateTransform() should be
outside the USE(ACCELERATED_COMPOSITING) #ifdef. They do work
that is needed even if accelerated compositing is disabled.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] HTMLCollection wrappers are not retained
arv@chromium.org [Sat, 30 Jun 2012 03:32:05 +0000 (03:32 +0000)]
[V8] HTMLCollection wrappers are not retained
https://bugs.webkit.org/show_bug.cgi?id=90208

Reviewed by Adam Barth.

Source/WebCore:

Generate visitDOMWrapper for HTMLCollection and HTMLAllCollection so that we add an implicit reference from the owner
to the collection.

Tests: fast/dom/htmlallcollection-reachable.html
       fast/dom/htmlcollection-reachable.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Instead of hard coding to use base() for HTMLAllCollection and HTMLCollection we now
annotate the IDL file to use GenerateIsReachable=ImplBaseRoot.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateVisitDOMWrapper): Generate visitDOMWrapper if GenerateIsReachable is ImplBaseRoot.
* bindings/scripts/IDLAttributes.txt: Added ImplBaseRoot.
* html/HTMLAllCollection.idl: Added annotations.
* html/HTMLCollection.idl: Ditto.

LayoutTests:

* fast/dom/htmlallcollection-reachable-expected.txt: Added.
* fast/dom/htmlallcollection-reachable.html: Added.
* fast/dom/htmlcollection-reachable-expected.txt: Added.
* fast/dom/htmlcollection-reachable.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id...
commit-queue@webkit.org [Sat, 30 Jun 2012 03:27:12 +0000 (03:27 +0000)]
Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
https://bugs.webkit.org/show_bug.cgi?id=90309

Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-06-29
Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_http_server):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAll child elements of a flex container should be turned into a flex item
tony@chromium.org [Sat, 30 Jun 2012 03:16:23 +0000 (03:16 +0000)]
All child elements of a flex container should be turned into a flex item
https://bugs.webkit.org/show_bug.cgi?id=90323

Reviewed by Ojan Vafai.

Source/WebCore:

We used to only convert some elements to blocks, but now we convert everything except text nodes.
This was recently changed here:
http://wiki.csswg.org/topics/css3-flexbox-flexbox-replaced-children

Tests: css3/flexbox/anonymous-block.html : Add new test case.
       css3/flexbox/flexitem.html: Update results.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

* css3/flexbox/anonymous-block-expected.html:
* css3/flexbox/anonymous-block.html:
* css3/flexbox/flexitem-expected.txt:
* css3/flexbox/flexitem.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Keep direction on IDBCursor to avoid calls to back end
jsbell@chromium.org [Sat, 30 Jun 2012 03:09:32 +0000 (03:09 +0000)]
IndexedDB: Keep direction on IDBCursor to avoid calls to back end
https://bugs.webkit.org/show_bug.cgi?id=90114

Source/WebCore:

Reviewed by Tony Chang.

Let IDBCursor handle direction() accessor locally, without a call to
the IDBCursorBackendImpl which (in some ports) may reside in a different
process. Not a heavily called function, but further reduces the surface
area exposed by the XXXInterface classes.

No new tests - no functional changes.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::create): Accept direction, known at creation time.
(WebCore::IDBCursor::IDBCursor): Stash in member.
(WebCore::IDBCursor::direction): Use local copy
(WebCore::IDBCursor::stringToDirection): Return enum value, not int.
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Remove accessor.
* Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBCursorBackendInterface.h: Remove accessor.
* Modules/indexeddb/IDBCursorWithValue.cpp:
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
* Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
* Modules/indexeddb/IDBIndex.cpp: Prep IDBRequest with cursor direction too.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBObjectStore.cpp: Ditto.
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBRequest.cpp: Stash direction for pending cursor too.
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::onSuccess): Apply stashed direction to new cursor.
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):

Source/WebKit/chromium:

Stop plumbing IDBCursorBackendInterface::direction() through API.

Reviewed by Tony Chang.

* src/IDBCursorBackendProxy.cpp:
* src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
* src/WebIDBCursorImpl.cpp:
* src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow align-self: stretch to cause the item size to shrink below its intrinsic size
tony@chromium.org [Sat, 30 Jun 2012 02:36:41 +0000 (02:36 +0000)]
Allow align-self: stretch to cause the item size to shrink below its intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=90304

Reviewed by Ojan Vafai.

Source/WebCore:

The spec used to say that stretch could only make items grow, but now
it allows items to shrink.
http://dev.w3.org/csswg/css3-flexbox/#align-items-stretch

Tests: css3/flexbox/flex-align-stretch.html Updated expectations.
       css3/flexbox/child-overflow.html Updated expectations.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

LayoutTests:

* css3/flexbox/child-overflow-expected.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/flex-align-stretch.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNPObjectWrapper may not address all window script object lifetime issues
commit-queue@webkit.org [Sat, 30 Jun 2012 02:02:09 +0000 (02:02 +0000)]
NPObjectWrapper may not address all window script object lifetime issues
https://bugs.webkit.org/show_bug.cgi?id=85679

Source/WebCore:

The ScriptController implementations force-deallocate the window script object to ensure that DOM objects are not leaked if an NPAPI plugin fails to release a reference to it before being destroyed. The NPObjectWrapper was added to ensure that NPAPI scripting could not touch the real window script object after it had been deallocated, by providing the plugin with a small wrapper which will leak if the plugin fails to dereference it.

This patch removes NPObjectWrapper and instead drops the window script NPObject's reference to the underlying V8Object in ScriptController::clearScriptObjects(). If a plugin fails to dereference the object then the NPV8Object wrapper will be leaked but the DOM objects it references will not.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

Test: plugins/npruntime/leak-window-scriptable-object.html

* WebCore.gypi:
* bindings/v8/NPObjectWrapper.cpp: Removed.
* bindings/v8/NPObjectWrapper.h: Removed.
* bindings/v8/NPV8Object.cpp:
(WebCore::disposeUnderlyingV8Object):
(WebCore):
(WebCore::freeV8NPObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
(_NPN_Construct):
* bindings/v8/NPV8Object.h:
(WebCore):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):
* bindings/v8/ScriptController.h:
(ScriptController):

Tools:

TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetProperty):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
* DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
(LeakWindowScriptableObject):
(LeakWindowScriptableObject::LeakWindowScriptableObject):
(LeakWindowScriptableObject::NPP_New):

LayoutTests:

Test that NPAPI plugins that leak references to the window script object don't cause the containing document to be leaked.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

* plugins/npruntime/leak-window-scriptable-object-expected.txt: Added.
* plugins/npruntime/leak-window-scriptable-object.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate complex fonts on Android to use fonts from a newer SDK
abarth@webkit.org [Sat, 30 Jun 2012 01:23:37 +0000 (01:23 +0000)]
Update complex fonts on Android to use fonts from a newer SDK
https://bugs.webkit.org/show_bug.cgi?id=90296

Reviewed by Nate Chapin.

These fonts are available in the Jelly Bean SDK.

* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::getComplexFontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
commit-queue@webkit.org [Sat, 30 Jun 2012 01:20:20 +0000 (01:20 +0000)]
Source/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-06-29
Reviewed by Chang Shu.

Add configuration for building gtest library, testing framework and unit tests.

* PlatformEfl.cmake:

Source/WebKit/efl: [EFL] Implementation of testing framework and unit tests for WebKit-EFL port.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech  <k.czech@samsung.com>, Tomasz Morawski <t.morawski@samsung.com> on 2012-06-29
Reviewed by Chang Shu.

Testing framework is based on gtest library. Gtest library is part of the WebKit project. Framework is devided into base part and view part.
Base part takes care of efl initialization, defines test macros and prepares test to run. View part is a context of each test.

* tests/UnitTestUtils/EWKTestBase.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdown):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests::EWKTestBase::runTest):
* tests/UnitTestUtils/EWKTestBase.h: Added.
(EWKUnitTests):
(EWKTestBase):
* tests/UnitTestUtils/EWKTestConfig.h: Added.
(Config):
* tests/UnitTestUtils/EWKTestView.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
* tests/UnitTestUtils/EWKTestView.h: Added.
(EWKUnitTests):
(EWKTestEcoreEvas):
(EWKTestView):
(EWKUnitTests::EWKTestView::webView):
* tests/resources/default_test_page.html: Added.
* tests/test_ewk_view.cpp: Added.
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
* tests/test_runner.cpp: Added.
(parseCustomArguments):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove warning about protected values when the Heap is being destroyed
mhahnenberg@apple.com [Sat, 30 Jun 2012 01:14:09 +0000 (01:14 +0000)]
Remove warning about protected values when the Heap is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=90302

Reviewed by Geoffrey Garen.

Having to do book-keeping about whether values allocated from a certain
VM are or are not protected makes the JSC API much more difficult to use
correctly. Clients should be able to throw an entire VM away and not have
to worry about unprotecting all of the values that they protected earlier.

* heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium windows rebaselines for r121599.
eae@chromium.org [Sat, 30 Jun 2012 00:58:24 +0000 (00:58 +0000)]
Unreviewed chromium windows rebaselines for r121599.

* platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSObject wastes too much memory on unused property slots
fpizlo@apple.com [Sat, 30 Jun 2012 00:25:01 +0000 (00:25 +0000)]
JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255

Reviewed by Mark Hahnenberg.

This does a few things:

- JSNonFinalObject no longer has inline property storage.

- Initial out-of-line property storage size is 4 slots for JSNonFinalObject,
  or 2x the inline storage for JSFinalObject.

- Property storage is only reallocated if it needs to be. Previously, we
  would reallocate the property storage on any transition where the original
  structure said shouldGrowProperyStorage(), but this led to spurious
  reallocations when doing transitionless property adds and there are
  deleted property slots available. That in turn led to crashes, because we
  would switch to out-of-line storage even if the capacity matched the
  criteria for inline storage.

- Inline JSFunction allocation is killed off because we don't have a good
  way of inlining property storage allocation. This didn't hurt performance.
  Killing off code is better than fixing it if that code wasn't doing any
  good.

This looks like a 1% progression on V8.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
* runtime/Structure.h:
(JSC::Structure::putWillGrowPropertyStorage):
(Structure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium rebaselines for r121599.
eae@chromium.org [Sat, 30 Jun 2012 00:20:21 +0000 (00:20 +0000)]
Unreviewed chromium rebaselines for r121599.

* platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/bounding-rect-zoom-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHTMLCollection's caches should be owned by either ElementRareData or Document
rniwa@webkit.org [Fri, 29 Jun 2012 23:56:42 +0000 (23:56 +0000)]
HTMLCollection's caches should be owned by either ElementRareData or Document
https://bugs.webkit.org/show_bug.cgi?id=90322

Reviewed by Anders Carlsson.

Removed all instances of OwnPtr<HTMLCollection> except ones on ElementRareData and Document.
ElementRareData::ensureCachedHTMLCollection then polymorphically creates HTMLCollection or
its subclass as deemed necessary.

This refactoring allows us to move HTMLCollection to use the same invalidation model as
DynamicNodeList (invalidated during DOM mutations) in a follow up.

* dom/Document.cpp:
(WebCore::Document::all):
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore):
(WebCore::Element::cachedHTMLCollection):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(WebCore):
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
* dom/Node.cpp:
(WebCore):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(WebCore::NodeRareData::setItemType):
(NodeRareData):
* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLElement.cpp:
(WebCore):
(WebCore::HTMLElement::properties):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
* html/HTMLFieldSetElement.h:
(HTMLFieldSetElement):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):
* html/HTMLFormCollection.h:
(HTMLFormCollection):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
* html/HTMLFormElement.h:
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
(WebCore::HTMLOptionsCollection::create):
* html/HTMLOptionsCollection.h:
(HTMLOptionsCollection):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
* html/HTMLSelectElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
* html/HTMLTableElement.h:
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):
* html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd FIXMEs for vertical writing mode and override sizes.
ojan@chromium.org [Fri, 29 Jun 2012 23:49:22 +0000 (23:49 +0000)]
Add FIXMEs for vertical writing mode and override sizes.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer
jamesr@google.com [Fri, 29 Jun 2012 23:45:38 +0000 (23:45 +0000)]
[chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer
https://bugs.webkit.org/show_bug.cgi?id=90300

Reviewed by Adrienne Walker.

* platform/graphics/chromium/RateLimiter.cpp:
(RateLimiter::Task):
(WebCore::RateLimiter::Task::create):
(WebCore::RateLimiter::Task::~Task):
(WebCore::RateLimiter::Task::Task):
(WebCore):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::stop):
(WebCore::RateLimiter::rateLimitContext):
* platform/graphics/chromium/RateLimiter.h:
(WebCore):
(RateLimiter):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove type from screenColorProfile API
commit-queue@webkit.org [Fri, 29 Jun 2012 23:40:35 +0000 (23:40 +0000)]
Remove type from screenColorProfile API
https://bugs.webkit.org/show_bug.cgi?id=90299

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-29
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/Platform.h:
(WebKit::Platform::screenColorProfile): Removed type from chromium
public API's version of screenColorProfile().

Source/WebCore:

Covered by existing tests.

* platform/PlatformScreen.h:
(WebCore): Removed type from screenColorProfile().
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile):
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile):
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile): Updated call to
screenColorProfile() to not pass type param.
* platform/mac/PlatformScreenMac.mm:
(WebCore::screenColorProfile):
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenColorProfile):
* platform/win/PlatformScreenWin.cpp:
(WebCore::screenColorProfile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow non-borders to be adjusted to less than 1 when zoomed out
eae@chromium.org [Fri, 29 Jun 2012 23:26:06 +0000 (23:26 +0000)]
Allow non-borders to be adjusted to less than 1 when zoomed out
https://bugs.webkit.org/show_bug.cgi?id=90104

Reviewed by Eric Seidel.

Source/WebCore:

Change CSSPrimitiveValue::computeLengthDouble to allow values to be
adjusted to less than 1.0 when zoomed out. This avoids an off by one
error for floats with margins when zoomed out that can cause floats to
wrap and break pages.

The logic that prevents the value from being adjusted to less than 1 was
added to ensure that borders are still painted even when zoomed out.
By moving the logic to ApplyPropertyComputeLength::applyValue, which is
used for borders and outlines, that functionality is preserved.

Test: fast/sub-pixel/float-with-margin-in-container.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):

LayoutTests:

Add test ensuring that floats with margins do not wrap in fixed sized
containers and update existing results as needed.

* fast/css/zoom-background-repeat-x.html:
* fast/sub-pixel/float-with-margin-in-container-expected.txt: Added.
* fast/sub-pixel/float-with-margin-in-container.html: Added.
* platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLet Xcode have its own way after r121513.
rniwa@webkit.org [Fri, 29 Jun 2012 22:55:07 +0000 (22:55 +0000)]
Let Xcode have its own way after r121513.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CSS Regions] Adding feature defines for CSS Regions for Windows
commit-queue@webkit.org [Fri, 29 Jun 2012 22:51:09 +0000 (22:51 +0000)]
[CSS Regions] Adding feature defines for CSS Regions for Windows
https://bugs.webkit.org/show_bug.cgi?id=88645

Patch by Mihai Balan <mibalan@adobe.com> on 2012-06-29
Reviewed by Tony Chang.

Source/WebCore:

Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues.

* css/CSSPropertyNames.in: Touched file to make sure property names get properly rebuilt.

Source/WebKit/win:

Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems. This time adding preferences code to make sure the settings
get propagated to DRT (previous experiments by abucur showed they
didn't.).

* WebPreferenceKeysPrivate.h: Added preference key for CSS regions
* Interfaces/IWebPreferences.idl: Added getters and setters for CSS regions settings
* WebPreferences.cpp: ditto
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isCSSRegionsEnabled):
(WebPreferences::setCSSRegionsEnabled):
* WebPreferences.h: ditto
(WebPreferences):
* WebView.cpp: Added settings code to handle CSS regions, too
(WebView::notifyPreferencesChanged):

WebKitLibraries:

Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems.

* win/tools/vsprops/FeatureDefines.vsprops: Added default value for ENABLE_CSS_REGIONS
* win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto

LayoutTests:

Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues. Fixing a couple of non-regions related tests that get different
results once regions are enabled.

* platform/win/fast/js/global-constructors-expected.txt: Added WebKitCSSRule to expected

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: add comment about how determine_full_port_name() works for apple ports...
dpranke@chromium.org [Fri, 29 Jun 2012 22:25:24 +0000 (22:25 +0000)]
webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
https://bugs.webkit.org/show_bug.cgi?id=90314

Reviewed by Ojan Vafai.

Add comments and fix a bug in how we would handle the mac-wk2
and win-wk2 port names after confusion around in bug 90312 :).

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.determine_full_port_name):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: remove support for mac leopard from chromium configurations
dpranke@chromium.org [Fri, 29 Jun 2012 22:16:56 +0000 (22:16 +0000)]
webkitpy: remove support for mac leopard from chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=90313

Reviewed by Tony Chang.

Google has shipped the last version of Chrome that will support
Mac OS 10.5 (Leopard), and we no longer have bots that run this
configuration, so we're removing support for it.

A subsequent change will remove the baselines in platform/chromium-mac-leopard.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_complex_shadowing):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_mac):
(FactoryTest.test_chromium_mac):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_and_copy_test_with_lion_result):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream
abarth@webkit.org [Fri, 29 Jun 2012 22:10:43 +0000 (22:10 +0000)]
[Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream
https://bugs.webkit.org/show_bug.cgi?id=90292

Reviewed by Nate Chapin.

These ifdefs are required to build this file downstream. There's some
sublte difference between how the OS flags are set upstream and
downstream. This is on our list of issues to resolve, but in the
meantime, this patch makes these files identical upstream and
downstream to reduce noise in the upstreaming queue.

* src/linux/WebFontRendering.cpp:
(WebKit::WebFontRendering::setSubpixelPositioning):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Unskip/rebaseline some compositing tests.
noam.rosenthal@nokia.com [Fri, 29 Jun 2012 22:02:37 +0000 (22:02 +0000)]
[Qt][WK2] Unskip/rebaseline some compositing tests.
https://bugs.webkit.org/show_bug.cgi?id=90290

Reviewed by Laszlo Gombos.

Rebaseline compositing tests that have good results that are slightly different than the
generic results, and unskipping several tests that should not be skipped.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/iframe-content-flipping-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-in-composited-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-on-composited-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Web Inspector: Add data length to resource events on timeline to
commit-queue@webkit.org [Fri, 29 Jun 2012 21:57:24 +0000 (21:57 +0000)]
Source/WebCore: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244

Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.

Added data length to inspector timeline popup
content for resources to keep track of the amount of data loaded.
Tests: inspector/timeline/timeline-network-received-data.html

* English.lproj/localizedStrings.js:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createReceiveResourceData):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._showPopover):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
* inspector/timeline/timeline-network-received-data.html: Added.
* inspector/timeline/timeline-network-received-data-expected.txt: Added.
* inspector/timeline/timeline-test.js:

LayoutTests: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length.
https://bugs.webkit.org/show_bug.cgi?id=89244

Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.

Added tests for resource receive data events.

* inspector/timeline/timeline-network-received-data-expected.txt: Added.
* inspector/timeline/timeline-network-received-data.html: Added.
* inspector/timeline/timeline-test.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix optimize-baselines to not move baselines from win to win-7sp0
ojan@chromium.org [Fri, 29 Jun 2012 21:53:42 +0000 (21:53 +0000)]
Fix optimize-baselines to not move baselines from win to win-7sp0
https://bugs.webkit.org/show_bug.cgi?id=90312

Reviewed by Dirk Pranke.

It used to consider win-7sp0 as the common directory for all the Apple
windows ports and incorrectly move results out of win.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2] Move intent delivery code from the frame to the page
commit-queue@webkit.org [Fri, 29 Jun 2012 21:43:31 +0000 (21:43 +0000)]
[WK2] Move intent delivery code from the frame to the page
https://bugs.webkit.org/show_bug.cgi?id=89974

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-29
Reviewed by Anders Carlsson.

Move the intent delivery code from the frame to the page
and add the corresponding C API for WKPage.

* UIProcess/API/C/WKPage.cpp:
(WKPageDeliverIntentToFrame):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::stopLoading):
* UIProcess/WebFrameProxy.h:
(WebKit):
* UIProcess/WebPageProxy.cpp:
(WebKit):
(WebKit::WebPageProxy::deliverIntentToFrame):
* UIProcess/WebPageProxy.h:
(WebPageProxy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix after 121580.
shawnsingh@chromium.org [Fri, 29 Jun 2012 21:25:55 +0000 (21:25 +0000)]
Unreviewed build fix after 121580.

WebKit Linux debug bots was complaining about signed vs unsigned integer comparison.

* html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium xp rebaseline.
eae@chromium.org [Fri, 29 Jun 2012 21:23:14 +0000 (21:23 +0000)]
Unreviewed chromium xp rebaseline.

* platform/chromium-win-xp/http/tests/inspector: Added.
* platform/chromium-win-xp/http/tests/inspector/resource-tree: Added.
* platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Page jumps after post-pinch-zoom re-render
zhajiang@rim.com [Fri, 29 Jun 2012 21:11:39 +0000 (21:11 +0000)]
[BlackBerry] Page jumps after post-pinch-zoom re-render
https://bugs.webkit.org/show_bug.cgi?id=90282

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 170255
In r120622, we moved ScrollableArea::setConstrainsScrollingToContentEdge(false|true)
from WebPage::setScrollPosition() to BackingStorePrivate::setScrollingOrZooming()
to address an overscroll reset issue.
However, when we are ending bitmap zooming, UI thread can call
BackingStorePrivate::setScrollingOrZooming(false) before WebKit thread
calls WebPage::setScrollPosition(), in which case it will set
ScrollableArea::m_constrainsScrollingToContentEdge to true earlier.
To fix this, we can cache ScrollableArea::m_constrainsScrollingToContentEdge
and always set it to false before we set scroll position in WebKit
thread to avoid scroll position clamping during scrolling, and restore
it to what it was after that.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setScrollPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121586 268f45cc-cd09-0410-ab3c-d52691b4dbfc