Stephane Delcroix [Mon, 28 Jan 2019 09:33:23 +0000 (10:33 +0100)]
Merge branch '3.5.0'
E.Z. Hart [Fri, 25 Jan 2019 16:40:17 +0000 (09:40 -0700)]
[iOS] CollectionView single selection (#4985)
* Working single selection on iOS
* Fix rebase errors
* Make ItemsLayout a constructor parameter for the Delegator
* Make common VSM states public consts
* Make file and type name match
* Simplify method we'll be completely rewriting while implementing the next feature
* VS didn't save project file changes
* Update submodule
Pavel Yakovlev [Thu, 24 Jan 2019 20:50:54 +0000 (23:50 +0300)]
[Android] Fixes keyboard navigation in custom view (#4612)
E.Z. Hart [Thu, 24 Jan 2019 18:22:18 +0000 (11:22 -0700)]
[Android] Tests for multiple item collection changes in CollectionView (#4869)
* Add multi-item removal test; handle multi-item removal scenarios on Android;
* Add test harness for adding multiple items to CollectionView at once
* Add test harness for multi-item move/replace; handle Android multi-item move;
Fix bug when replacing differently-sized item sets on Android;
* Add test harness for INotifyCollectionChanged Reset
* Performance improvements and clearer test code
* Remove private modifier
* Fix bug where updating items sources changed source types
* Remove private modifier
* Make index checks clearer
* Remove private modifier
* Remove private modifier
* Move code into if clause
* Use local variable
* Better indication of how to use collection modification tests
* Include end index in items moved
* Make update range include items between source and destination indexes
* Remove commented code
E.Z. Hart [Thu, 24 Jan 2019 17:57:36 +0000 (10:57 -0700)]
Remove unnecessary search for root (#5036)
Rui Marinho [Thu, 24 Jan 2019 15:34:10 +0000 (15:34 +0000)]
Merge branch '3.5.0'
Rui Marinho [Thu, 24 Jan 2019 15:26:46 +0000 (15:26 +0000)]
[Build] Update build settings
Rui Marinho [Thu, 24 Jan 2019 15:10:29 +0000 (15:10 +0000)]
[Build] Update variable for keychain pass
Rui Marinho [Thu, 24 Jan 2019 14:17:40 +0000 (14:17 +0000)]
[Build] Update build def
Rui Marinho [Thu, 24 Jan 2019 13:32:15 +0000 (13:32 +0000)]
[Build] Fix provisioning
Pavel Yakovlev [Tue, 22 Jan 2019 20:15:42 +0000 (23:15 +0300)]
[UWP] Fixes hide DisplayActionSheet behind the dialog box (#3163)
Stephane Delcroix [Mon, 21 Jan 2019 09:49:23 +0000 (10:49 +0100)]
Merge branch '3.5.0'
Yaser Moradi [Sat, 19 Jan 2019 18:20:33 +0000 (21:50 +0330)]
Add Serializable on exception types (#4690)
* Added Serializable on exception types. See #4685
* Make exception types public. See #4685
* Added default-recommended constructors to exception classes. See #4685
* Make exception types compatible with .net standard 1.0 See 4685
* Call base in xaml parse exception. See #4685
* Merged XamlParseException #4685 related changes with chanes of #4582
Pavel Yakovlev [Sat, 19 Jan 2019 18:19:03 +0000 (21:19 +0300)]
[UWP] Fixes IsTabStop property in Layouts (#4703)
* [UWP] the ScrollView does not gain focus
* address comments
fixes #4653
Pavel Yakovlev [Sat, 19 Jan 2019 18:18:01 +0000 (21:18 +0300)]
[UWP] fixes crashing ActivityIndicator with COMException (#4988)
fixes #4982
Gerald Versluis [Sat, 19 Jan 2019 01:10:25 +0000 (02:10 +0100)]
Fixed bug where switch in a `TableView` would disappear on UWP. The method for setting the default color was only called when it was in a ListView. Also renamed the method to be more clear. (#4912)
Samantha Houts [Fri, 18 Jan 2019 23:02:10 +0000 (15:02 -0800)]
Merge branch '3.5.0'
Andrei Nitescu [Fri, 18 Jan 2019 13:32:36 +0000 (15:32 +0200)]
Changed Span default binding to OneWay (#4850)
Stephane Delcroix [Fri, 18 Jan 2019 12:42:21 +0000 (13:42 +0100)]
[C] add null check for FlexLayout.OnPropChanged (#5012)
We had null checks in 3 places, not the fourth one. and that case was
hit by #5001.
- fixes #5001
Samantha Houts [Thu, 17 Jan 2019 00:57:38 +0000 (16:57 -0800)]
Merge branch '3.4.0' into 3.5.0
Gerald Versluis [Thu, 17 Jan 2019 00:03:05 +0000 (01:03 +0100)]
[UWP] Implementation of Switch.OnColor (#4883)
* Implemented Switch.OnColor on UWP
* Processed first feedback
* Removed hardcoded opacity
* Update Xamarin.Forms.Platform.UAP/SwitchRenderer.cs
Co-Authored-By: jfversluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Platform.UAP/SwitchRenderer.cs
Co-Authored-By: jfversluis <github@geraldversluis.nl>
kingces95 [Wed, 16 Jan 2019 23:07:46 +0000 (13:07 -1000)]
.create-nuget.bat + maps (#4952)
E.Z. Hart [Wed, 16 Jan 2019 21:42:48 +0000 (14:42 -0700)]
Implement CollectionView item replace on iOS (#4865)
Matthew Leibowitz [Wed, 16 Jan 2019 07:37:02 +0000 (09:37 +0200)]
Remove Unused Types (#4948)
* Remove NavigationMenu & Renderers
- Never completed and there is the new CollectionView
- Only (partially) implemented on iOS/Android
* Removing ToolbarButton and related types
- `ToolbarButton`, `ToolbarImageButton`, `IToolbarButton`
- this appears not to be used at all
- was part of `ToolbarRenderer` in the old Duplo repo, which has since been removed
* Update Xamarin.Forms.Platform.cs
Samantha Houts [Tue, 15 Jan 2019 23:55:57 +0000 (15:55 -0800)]
Add preserve attr to 1326,1400
Brian Macomber [Tue, 15 Jan 2019 18:46:43 +0000 (12:46 -0600)]
[UWP] Fix ScrollViewer Horizontal Scroll Bar Visibility when set before control load (#3195) fixes #3193
* Fix 3193
* Update to restore default behavior
* Fix 3193
* Update to restore default behavior
* Spelling Fix
Shane Neuville [Tue, 15 Jan 2019 16:01:42 +0000 (09:01 -0700)]
[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4954) fixes #4789
Rui Marinho [Tue, 15 Jan 2019 14:49:40 +0000 (14:49 +0000)]
[UITests] Fix #1685 UITest
Pavel Yakovlev [Tue, 15 Jan 2019 14:05:51 +0000 (17:05 +0300)]
[Shell] fixes navigate to a relative URI (#4977)
Stephane Delcroix [Tue, 15 Jan 2019 12:35:24 +0000 (13:35 +0100)]
[C] Obsolete Vec2 (#4980)
Rui Marinho [Tue, 15 Jan 2019 11:59:26 +0000 (11:59 +0000)]
Merge branch '3.5.0'
Rui Marinho [Tue, 15 Jan 2019 11:54:14 +0000 (11:54 +0000)]
[UITest] Add Preserve to issue #1931 uitest
Matthew Richardson [Tue, 15 Jan 2019 09:57:51 +0000 (09:57 +0000)]
Null/disposed check for spannableString to fix ObjectDisposedException. (#4878) Fixes #4864
Samantha Houts [Tue, 15 Jan 2019 00:19:57 +0000 (16:19 -0800)]
Add instructions to test 33450
fixes #2246
Rui Marinho [Mon, 14 Jan 2019 17:36:20 +0000 (17:36 +0000)]
[UITests] Fix #1685 UITest
Shane Neuville [Mon, 14 Jan 2019 17:05:51 +0000 (10:05 -0700)]
[ios] clear perfect value add ui test (#4968)
- fixes #4957
Stephane Delcroix [Mon, 14 Jan 2019 13:45:30 +0000 (14:45 +0100)]
Merge branch '3.5.0'
Rui Marinho [Mon, 14 Jan 2019 12:39:11 +0000 (12:39 +0000)]
[Build] Fix method accessibility
E.Z. Hart [Mon, 14 Jan 2019 11:48:59 +0000 (04:48 -0700)]
[iOS, Android] Implement Snap alignment for CollectionView (#4414)
* Implement snap alignment for iOS CollectionView
* Add missing End/MandatorySingle implementation for Android
* Implement MandatorySingle snapping on iOS
* Fix issues with Android MandatorySingle skipping items;
* Fix rebase issue
Stephane Delcroix [Mon, 14 Jan 2019 11:35:29 +0000 (12:35 +0100)]
fix merge
Stephane Delcroix [Mon, 14 Jan 2019 11:07:51 +0000 (12:07 +0100)]
fix merge
Gerald Versluis [Mon, 14 Jan 2019 11:02:08 +0000 (12:02 +0100)]
Disable suggestions for all Pickers (#4824) fixes #4629
* Disable suggestions for all Pickers
* Removed redundant disabling of spellcheck
Rui Marinho [Mon, 14 Jan 2019 10:51:49 +0000 (10:51 +0000)]
[iOS] Fix unsubscribing the `PropertyChanged` event of the ViewCell (#4728)
* [Controls] Add repo for comment related with #4186
* [iOS] Fix unsubscribing PropertyChanged when disposing ViewTableCell
* [Controls] Fix test
Shane Neuville [Mon, 14 Jan 2019 10:41:46 +0000 (03:41 -0700)]
Changes that VS Mac and Dev16 automatically make when you open SLN (#4969)
* vsmac changes these when you open it
* dev 16 changes
Stephane Delcroix [Mon, 14 Jan 2019 08:32:43 +0000 (09:32 +0100)]
Merge branch '3.5.0'
E.Z. Hart [Sat, 12 Jan 2019 22:43:08 +0000 (15:43 -0700)]
[Android] Fix brief display of incorrect keyboard (#4384)
* Automate test for 39072
* Add Focus test category
* Add test instructions
* Use named flags value instead of magic number
* Rearrange keyboard hide/show handling when focus changes; fixes #3647
Clean up usings
Add null checks in case Controls are unloaded before the handler executes
* Update Xamarin.Forms.Platform.Android/ContextExtensions.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.Android/ViewRenderer.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Fix bug where programmatic focus of SearchView does not display keyboard;
Add test for programmatic focus of SearchBar, Entry, Editor;
* Prevent object disposed exception if control is disposed before posted ShowKeyboard is run
E.Z. Hart [Sat, 12 Jan 2019 00:02:04 +0000 (17:02 -0700)]
Merge branch 'easy-tests' into 3.5.0
E.Z. Hart [Sat, 12 Jan 2019 00:01:22 +0000 (17:01 -0700)]
Automate test for Issue 1700
E.Z. Hart [Fri, 11 Jan 2019 22:44:29 +0000 (15:44 -0700)]
Automate test for Issue 1685
E.Z. Hart [Fri, 11 Jan 2019 22:11:29 +0000 (15:11 -0700)]
Automate test for Issue 1590
E.Z. Hart [Fri, 11 Jan 2019 22:02:17 +0000 (15:02 -0700)]
Automate test for Issue 1557
E.Z. Hart [Fri, 11 Jan 2019 21:38:41 +0000 (14:38 -0700)]
Auotmate test for Issue 1538
Matthew Leibowitz [Fri, 11 Jan 2019 20:32:57 +0000 (22:32 +0200)]
[tests] UWP requires file extensions (#4944)
Andrei [Fri, 11 Jan 2019 20:17:32 +0000 (23:17 +0300)]
fix #4788 (#4959) fixes #4788
Andrei [Fri, 11 Jan 2019 15:53:45 +0000 (18:53 +0300)]
[macOS] BoxView binding to BackgroundColor broken (#4958)
- fixes #4338
Matthew Leibowitz [Thu, 10 Jan 2019 20:02:46 +0000 (22:02 +0200)]
[tests] UWP requires file extensions (#4945)
Rui Marinho [Thu, 10 Jan 2019 18:50:18 +0000 (18:50 +0000)]
[UITests] Ignore test failure on iOS9, use manual review
Pavel Yakovlev [Thu, 10 Jan 2019 17:56:11 +0000 (20:56 +0300)]
[Android] fixes Right-to-Left Hamburger icon in MasterDetailPage (#4716) fixes #2818
Andrei Nitescu [Thu, 10 Jan 2019 17:52:11 +0000 (19:52 +0200)]
Map with ItemsSource and ItemTemplate (#4269) fixes #1708
Almir Vuk [Thu, 10 Jan 2019 16:21:29 +0000 (17:21 +0100)]
[Enhancement] Entry: Read-only Entry and Editor (#1972)
- fixes #1678
- fixes #4834
* InputView BindableProperty IsReadOnly
* Android Editor and Entry setup
* MacOS Editor and Entry setup
* Tizen Editor and Entry setup
* UAP Editor and Entry setup
* WPF Editor and Entry setup
* iOS Editor and Entry setup
* Issue1678 - TestContentPage added
* Tests added
* Tizen Editor and Entry fix
* UI Test fix
* Android fix for Entry and Editor.
* Unit Tests fix.
* Android Renderer first try.
* MacOS Entry renderer small fix.
* UpdateEditable fix.
* Android Entry and Editor reduced number of calls to BP.
* fix TestAttributes conflicts
* Remove keyboard
* [macOS] relinquish first responder
* [Android] remove call to UpdateCursorSelection
* [UWP] fix tabs
Joris Vergeer [Thu, 10 Jan 2019 16:01:18 +0000 (17:01 +0100)]
[Android] Fix for ListViewRenderer causing ObjectDisposedException (#4931)
* [Android] Fix for ListViewRenderer causing ObjectDisposedException
* Probably cleaner to use _refresh for IsDisposed check
Rui Marinho [Thu, 10 Jan 2019 12:59:38 +0000 (12:59 +0000)]
[UITests] Disable test #1931 on iOS12 for now
Stephane Delcroix [Thu, 10 Jan 2019 11:53:48 +0000 (12:53 +0100)]
hide obsolete API from editor (#4938)
- fixes #4772
E.Z. Hart [Thu, 10 Jan 2019 11:42:40 +0000 (04:42 -0700)]
Only post DisableTimer to the queue if it's not on the UI thread (#4866)
E.Z. Hart [Wed, 9 Jan 2019 22:40:27 +0000 (15:40 -0700)]
Fix incorrect bug description
E.Z. Hart [Wed, 9 Jan 2019 22:24:17 +0000 (15:24 -0700)]
[iOS] CollectionView EmptyView (#4870)
* Implement EmptyView for iOS
* Allow for changes to EmptyView on iOS; rename confusing variables;
Shane Neuville [Wed, 9 Jan 2019 14:06:49 +0000 (07:06 -0700)]
[Android] If drawable doesn't exist don't dispose of it (#4904)
Matthew Leibowitz [Wed, 9 Jan 2019 14:06:00 +0000 (16:06 +0200)]
[Android] Ensure the page background can be un-set (#4916)
Artem Utin [Tue, 8 Jan 2019 01:17:28 +0000 (11:17 +1000)]
added case in GTK listviewrendered for change of SelectedItem property (#4757)
Shane Neuville [Tue, 8 Jan 2019 00:07:50 +0000 (17:07 -0700)]
Material Design Renderers for the Material Visual (#4733)
* Use the auto-generated constants
* [Visual] Work on the Material Frame
* Improving the code for the sample
* Added a controller to help with frames that have additional padding
- Android MaterialCardView does not use the default padding to determine where the content starts, rather it uses the content padding of the view because there is a border that does not affect the content
* [Visual] Added a few extra checks on Android to reduce unnecessary interop
* [Visual] A few more frame changes and some button tweaks
* [Visual] use the themers on iOS and save default properties
* [Visual] Add placeholders for themer and cache defaults
* [Visual] Added the material slider for iOS
- Android does not have a custom control, so uses the existing renderer
* [enhancements] Move from duplicate LoadImageAsync code to GetNativeImageAsync
* [visual] Updated the controls to use the new iOS bits
* [visual] some fixes for material components
* [visual] Added hacks for material alerts
* [visual] removing the alert changes for the main branch
* [visual] Update the MaterialComponents NuGet
* [visual] Rework the theming/customization of Material controls on iOS
* [visual] fix the places where the user colors were being changed
* [visual] Improve the ColorStateList management for Android
* [visual] Re-implemented the Android ProgressBar as a fast, material renderer
* Material Entry
* [visual] Add Android ActivityIndicator
* filter out material layouts for 8.1
* remove folder
* fix __ANDROID_28__
* MaterialContextThemeWrapper
* [visual] remove the `IFrameController` interface
* [visual] reverting the changes to the Frame layout
* [visual] reverting whitespace
* [visual] make sure to raise both property changed
* formatting changes
* fixing colors on android to match with ios themes
* Update Xamarin.Forms.Platform.Android/Material/MaterialButtonRenderer.cs
Co-Authored-By: mattleibow <mattleibow@live.com>
* fix sizing of entry with infinite width size request
* update to release 28 of support
* Update Xamarin.Forms.Platform.Android/Resources/values/styles.xml
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Platform.Android/Resources/values/styles.xml
Co-Authored-By: PureWeen <shane94@hotmail.com>
* PR Comment changes
E.Z. Hart [Mon, 7 Jan 2019 21:12:01 +0000 (14:12 -0700)]
Use PushAsync for 1305 UI test so the toolbar shows up
E.Z. Hart [Mon, 7 Jan 2019 12:13:32 +0000 (05:13 -0700)]
[iOS] Implement item move on iOS CollectionView (#4863)
* Implement item move on iOS CollectionView
* Remove private modifier
Stephane Delcroix [Mon, 7 Jan 2019 09:03:47 +0000 (10:03 +0100)]
Merge branch '3.5.0'
E.Z. Hart [Mon, 7 Jan 2019 00:37:42 +0000 (17:37 -0700)]
Add missing preserve attribute for UI test 1267
E.Z. Hart [Sat, 5 Jan 2019 23:42:09 +0000 (16:42 -0700)]
Fix test 852
E.Z. Hart [Fri, 4 Jan 2019 23:39:44 +0000 (16:39 -0700)]
Merge branch '3.5.0' of github.com:xamarin/Xamarin.Forms into 3.5.0
E.Z. Hart [Fri, 4 Jan 2019 21:11:33 +0000 (14:11 -0700)]
Automate UI test 1267
E.Z. Hart [Fri, 4 Jan 2019 20:12:51 +0000 (13:12 -0700)]
Automate UI test 1236
E.Z. Hart [Fri, 4 Jan 2019 19:55:50 +0000 (12:55 -0700)]
Automate UI test 1219
E.Z. Hart [Fri, 4 Jan 2019 19:34:15 +0000 (12:34 -0700)]
Add manual test instructions for 1075, match button text with actual color
E.Z. Hart [Fri, 4 Jan 2019 19:08:48 +0000 (12:08 -0700)]
Automate UI test 1028
E.Z. Hart [Fri, 4 Jan 2019 18:34:07 +0000 (11:34 -0700)]
Add manual instructions to UI test 1026
E.Z. Hart [Fri, 4 Jan 2019 18:21:24 +0000 (11:21 -0700)]
Add manual test run instructions for UI test 1025
E.Z. Hart [Thu, 3 Jan 2019 22:56:42 +0000 (15:56 -0700)]
Clean up old comments
E.Z. Hart [Thu, 3 Jan 2019 22:37:36 +0000 (15:37 -0700)]
Add instructions for test 764; remove automated test that did nothing;
kingces95 [Thu, 3 Jan 2019 17:46:40 +0000 (07:46 -1000)]
Min viable FontImageSource (#4747)
* min viable fontImageSource
* [UWP] Min viable FontImageSource (#4817)
* [UWP] font image source
* address comment
* [UWP] performance optimization of the rendering of icons font
- the minimum Dpi of the icon is 300
* char -> string; CR feedback
E.Z. Hart [Thu, 3 Jan 2019 17:01:57 +0000 (10:01 -0700)]
Make test button visible on UWP
E.Z. Hart [Thu, 3 Jan 2019 16:57:30 +0000 (09:57 -0700)]
Remove nonsensical comments
E.Z. Hart [Thu, 3 Jan 2019 01:40:48 +0000 (18:40 -0700)]
Add instructions to manual UI test
E.Z. Hart [Thu, 27 Dec 2018 02:16:36 +0000 (19:16 -0700)]
Implement Android single selection in CollectionView (#4651)
* Implement Android single selection
* Fix naming conflicts with SelectionChangedEventArgs
* Split files by class; make SelectionChangedEventArgs constructors internal;
Optimizations for SelectionChangedEventArgs;
Fire selection changed event/command from property changed handler;
* Update Xamarin.Forms.Core/Items/SelectableItemsView.cs
Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
* Set default value for SelectedItemProperty
* Remove unnecessary null check
* Fix order of OnElementChanged and Setup/Teardown Element
* Fix project file weirdness
Akihiko Odaki [Sat, 22 Dec 2018 16:58:06 +0000 (01:58 +0900)]
[XamlC] Test generic parameters to evaluate equality of types (#4062)
E.Z. Hart [Sat, 22 Dec 2018 13:54:18 +0000 (06:54 -0700)]
Make ListView CachingStrategy property visible to Intellisense (#4846)
adrianknight89 [Fri, 21 Dec 2018 15:28:06 +0000 (09:28 -0600)]
[iOS] Added RowAnimationsEnabled platform specific to control row animations (#4709)
* added platform specific
* changed method signatures
* addressed changes
Stephane Delcroix [Fri, 21 Dec 2018 15:27:13 +0000 (16:27 +0100)]
[Shell] fix queryParam navigation (#4843)
when navigating to pages, not shell-section, handle the queryParams
- fixes #4837
Kangho Hur [Fri, 21 Dec 2018 09:04:30 +0000 (01:04 -0800)]
[Tizen] Supports Picker.TitleColor, FontSize, FontFamily and FontAttributes (#4839)
Stephane Delcroix [Fri, 21 Dec 2018 08:23:41 +0000 (09:23 +0100)]
[Flex] fix Padding on the FlexLayout (#4823)
As the flex engine doesn't handle x,y offset on the root layout,
handle that at the XF.FlexLayout level.
- fixes #2663
Stephane Delcroix [Fri, 21 Dec 2018 08:06:52 +0000 (09:06 +0100)]
[*] Drop MenuItem.IsEnabledPropertyName (#4659)
* [*] Drop MenuItem.IsEnabledPropertyName
While doing one of the big refactoring of 2006, we missed an
opportunity to use a propertyKey for IsEnabled, ending up in some
less-than-optimal design choices, like IMenuController.IsEnabledPropertyName.
Properly using a public r-o BP removes the need for IsEnabledPropertyName.
* other plats
* use the key
E.Z. Hart [Thu, 20 Dec 2018 21:58:22 +0000 (14:58 -0700)]
Remove unnecessary OK button check that won't pass on older Android versions
Stephane Delcroix [Thu, 20 Dec 2018 12:16:46 +0000 (13:16 +0100)]
XmlnsPrefix d: (#4781)
be ready for when we'll merge #4743
Stephane Delcroix [Thu, 20 Dec 2018 12:16:40 +0000 (13:16 +0100)]
[X] Design time properties (#4743)
An alternate xaml resource file provider can request the XamlLoader to
_not_ ignore normally ignored properties in prebuilt XF design xmlns, as
in the following snippet:
```xaml
<ContentPage
xmlns="http://xamarin.com/schemas/2014/forms""
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml""
xmlns:d="http://xamarin.com/schemas/2014/forms/design""
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006""
mc:Ignorable="d"">
<Label d:Text="Bar" Text="Foo" x:Name="label" />
</ContentPage>
```
The `d:` should be the prefix used by default for this, but any other
prefix will do too.
The `d:Text` property maps to the exact same property as `Text`, as the
XmllnsDefinitionAttributes are identical (that's convenient from a Intelisense
point of view), but, when (and only when) instructed by a provided Xaml resource
loader, the `d:Text` will override the `Text` property.
This works with virtually all properties defined on built-in Xamarin.Forms
controls, but it doesn't mean it's a sane idea to try to assign design value
to all existing properties.
The APi ofr setting the ResourceLoader had to change, and instead of taking
pre-defined arguments, it accepts and returns query and response types. This
is slightly less convenient to invoke through reflection, but way more easy
to extend in the future.