HyunJong Park [Fri, 10 Jun 2016 09:36:35 +0000 (18:36 +0900)]
COMBO: fix bug that popup list disappears when the text is pressed
When the text in combo is pressed and then the combo is focused out
(e.g. if the parent component is focused, the combo is focused out),
the popup list of combo disappears.
Change-Id: I6b2ad0f45e9f027a9a8732a3c5104689b7976949
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Fri, 10 Jun 2016 06:39:21 +0000 (15:39 +0900)]
BUTTON: Modified the conditions at the click.
To check that click on the button of current window.
Some widgets open a new window when the mouse down.
If the mouse position is on over of the button of new windows,
The button of new windows is clicked.
Change-Id: I6567213ee770be93b2e906934d121c713c0d42b5
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Thu, 2 Jun 2016 09:08:40 +0000 (18:08 +0900)]
BUTTON: Add part of lack of selection events
- Add part of lack of selection events.
- To block unnecessary event that are delivered to the button.
Change-Id: Id875459e0f31d80de6f920f22be9897a4fac1ff2
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
(cherry picked from commit
9882a9074faca1a7acb78ea1dfb4eb1408679bc2)
GiWoong Kim [Thu, 9 Jun 2016 09:40:51 +0000 (18:40 +0900)]
RENDERER: release the color resources
Application code must explicitly invoke the Color.dispose() method to
release the operating system resources managed by each instance when
those instances are no longer required.
Change-Id: I0c4f7f30b385c5bb51775f8873dc0b2051e659ed
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
HyunJong Park [Thu, 2 Jun 2016 05:52:53 +0000 (14:52 +0900)]
PROGRESSBAR: Stop animation of progressbar
-If the client hide the widget, the animation of progressabar is stopped.
Change-Id: I14fa0eb0fc518df45accd3c38c0057dd0ac44c01
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Wed, 1 Jun 2016 06:22:40 +0000 (15:22 +0900)]
TEXT: Change the size of text
- To calculate the size of the text using the font size of GC
Change-Id: I8a8a03ac2884893212da24928895173f8774a9fa
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Tue, 31 May 2016 07:07:34 +0000 (16:07 +0900)]
COMBO: Remove to selecting item when mouse hover
- Roll back to the original source.
Change-Id: I5170cb79732bd221ff774ce0fed3db00d860bd9b
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Tue, 31 May 2016 06:59:53 +0000 (15:59 +0900)]
TEXT: Fix the height of text in the windows
- Add the margin size.
Change-Id: Iea8d41bf6e2ff0583e042a57f3807455efee637f
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 12:00:01 +0000 (21:00 +0900)]
COMBO: Modified layout
- Checked the number of columns of gridlayout
Change-Id: Id56d0d503b912cf4d48496be96e7782f34b1d5a3
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 11:39:35 +0000 (20:39 +0900)]
TEXT: Fix. the height of Text in the ubuntu
- Change the height of text in the case of two or more lines in ubuntu.
Change-Id: I6d355f1c498eb50039e2db9fea46131bb5daaf87
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 06:25:31 +0000 (15:25 +0900)]
COMBO: Applied to the new design
- Change the font color when mouse hover.
- Highlight itme of list when mouse hover.
Change-Id: I595f62bd1c695b1cba3d9530bf92128117455d3d
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 04:45:44 +0000 (13:45 +0900)]
TEXT: Applied to the new design
- Change the background color when mouse hover.
Change-Id: Ied911880873b4df8cfb28c17818bd8218a98d506
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
GiWoong Kim [Fri, 27 May 2016 08:59:03 +0000 (17:59 +0900)]
RENDERER: draw Tizen min/max button
Change-Id: Ie54dac171fd6692d63115f3b7edfa404743d3296
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
HyunJong Park [Mon, 30 May 2016 01:04:16 +0000 (10:04 +0900)]
TEXT: Change text's height
- Change text's height of the computeSize function.
Change-Id: I38230157aff94bbda942ff3a7c72ed153ebbbf5e
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 01:31:13 +0000 (10:31 +0900)]
TEXT: Modified hooking listener
- Fix to remove the listener function that was hooking.
Change-Id: Ia0e5095271181159c3e84dc718d93bf665c7b4ac
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 30 May 2016 01:44:58 +0000 (10:44 +0900)]
BUTTON: Modified the conditions at the click
- Modified the conditions at the click of a button.
Change-Id: I20e3a0d1abe15d9d36b69cc8b3780416a9061068
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Thu, 26 May 2016 10:15:22 +0000 (19:15 +0900)]
TEXT: Modified size computing
Change-Id: Ie102cb7da4fcb99b8a91c6e41f9e11f8ca6c93b9
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
GiWoong Kim [Thu, 26 May 2016 09:44:40 +0000 (18:44 +0900)]
RENDERER: draw Tizen chevron button
Change-Id: I9bca55b11cfd8ae09a1184ea6879d59cb5216159
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
HyunJong Park [Thu, 26 May 2016 06:42:25 +0000 (15:42 +0900)]
TEXT: Modified mistyping
Change-Id: I4e8704db218a0a65bd1df5f21821f27d20cafc92
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Thu, 26 May 2016 05:08:47 +0000 (14:08 +0900)]
CCOMBO: Enable CCombo widget
- Apply the disign of Tizen
- Rename CCombo.java to OriginalCCombo.java
Change-Id: Iaed37a5a1c37f6590dc5a5a4db5f319ad8695c17
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Thu, 26 May 2016 04:21:21 +0000 (13:21 +0900)]
COMMON: Change font color
- Remove the blue color of font.
Change-Id: Ic2dbdbed5a3b620628a00f5576f6bbc742710082
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Thu, 26 May 2016 03:57:19 +0000 (12:57 +0900)]
TEXT: Modified size computing
- The returned size of the native text of each OS is different.
- So, The computerSize() adjust the size.
Change-Id: Ie89cb43d97705617235da3de164fca3573897ed3
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
GiWoong Kim [Wed, 25 May 2016 12:36:16 +0000 (21:36 +0900)]
RENDERER: modified size computing
In CTabFolder, each tab should be narrow presentation mode
if its size is small enough.
Change-Id: Ia7a1dddaed41f61dad7c3e6daf58d9469f6ed107
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
HyunJong Park [Wed, 25 May 2016 05:51:20 +0000 (14:51 +0900)]
TEXT: Add public API of scroll bar
- Return the receiver of scroll bar of OriginalText.
Change-Id: Ia45562692d7c9cb746dfca5025c88c6834d76cdc
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Wed, 25 May 2016 04:53:39 +0000 (13:53 +0900)]
BUTTON: Fix invisible button on Linux
On Linux, button with SWT.CENTER is invisible or disappear
owing to GTK.
This patch is a hack of unmasking SWT.CENTER.
Change-Id: Ib314734ed23c73fc4e6a8979ddd373b8ae4fdf5c
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Wed, 25 May 2016 07:14:01 +0000 (16:14 +0900)]
TEXT: Change the text's border
-The text's border looks always by UX request.
Change-Id: Ifaf05516332f143e378221cd61e12f6f07ac92cd
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Tue, 24 May 2016 10:38:32 +0000 (19:38 +0900)]
TEXT: Apply new design guide
- Apply new color.
- Not apply of the design of the Mouse Over and Focused.
Change-Id: I20ac338e0edcb6c5100e4d6988158c1ddaa29f67
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 23 May 2016 07:46:24 +0000 (16:46 +0900)]
COMBO: apply new design guide
- Apply new color.
- Rename the state of each button.
Change-Id: I79966265cea9a77d7560817288d500e1d6aa58ef
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Wed, 25 May 2016 06:17:04 +0000 (15:17 +0900)]
TEXT: Fix. the vertical scroll bar
- Fill the vertical scroll bar in text
Change-Id: I12c061ab65cb2703a42d1602e92a6fbfc553f733
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 23 May 2016 07:03:04 +0000 (16:03 +0900)]
BUTTON: Apply new design guide
- Apply new icon images and color.
- Rename the state of each button.
- Change the data structure for the resource of the state of each button.
- Declared as an abstract class.
Change-Id: I0e46e6809a8a77978db9ccfcec4cd126873668df
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
GiWoong Kim [Tue, 24 May 2016 10:41:22 +0000 (19:41 +0900)]
RENDERER: remove some leaks
Change-Id: I39f858791e235c00b7afc6aa06c4a393bb56c748
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
GiWoong Kim [Mon, 23 May 2016 07:09:56 +0000 (16:09 +0900)]
RENDERER: expand icon image field in CTabItem
add a new member variable to draw icon image when tab is selected
Change-Id: I282d1f99e9af25d34fe98d7323cebc169fa855d4
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
GiWoong Kim [Thu, 19 May 2016 10:05:19 +0000 (19:05 +0900)]
RENDERER: modified computing formula in CTabRenderer
While compute tab size, must consider the text only state.
And according to Tizen design guide, we need more spacing in
each left & right side.
Change-Id: Id8941400510150828b63520e30cc7e9ce4813fd2
Signed-off-by: GiWoong Kim <giwoong.kim@samsung.com>
HyunJong Park [Wed, 18 May 2016 08:14:24 +0000 (17:14 +0900)]
BUTTON: Modify the application logic for the color of the button.
There is a case that does not exist the color of the user or parent's composite.
Then apply the default color.
Change-Id: Iad0e1bd6681b27060f38db995841a1842e4cc749
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Wed, 18 May 2016 07:53:25 +0000 (16:53 +0900)]
BUTTON: enable the default button
-Enable the default button in wizard.
-Not implement to focus button by TAB key.
Change-Id: I29bdbf433a00360e583e392a4df8b26a0dd28419
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
HyunJong Park [Mon, 16 May 2016 05:43:34 +0000 (14:43 +0900)]
COMBO: change the border's color
Change the border's color of combo in blue whene editing the text box.
Change-Id: I44b7c6c25d6e196b5f3b7d6d9981db92ab5094c1
Signed-off-by: HyunJong Park <paulhj.park@samsung.com>
Yoonki Park [Sat, 14 May 2016 06:16:26 +0000 (15:16 +0900)]
SWT: Drop tizen changes
Change-Id: I29bdfd0cab160c632e9bc0201b3b560cab73ae63
Signed-off-by: Yoonki Park <yoonki.park@samsung.com>
Yoonki Park [Mon, 9 May 2016 11:46:27 +0000 (20:46 +0900)]
Merge tag 'R4_5_2' into upstream
Bug 487983 - Tag Mars.2 (4.5.2) release
JeongHoon Jeon [Mon, 2 May 2016 09:42:27 +0000 (18:42 +0900)]
Initial empty repository
Arun Thondapu [Fri, 12 Feb 2016 18:50:43 +0000 (00:20 +0530)]
v4530
Arun Thondapu [Fri, 12 Feb 2016 18:45:49 +0000 (00:15 +0530)]
v4530
Eric Williams [Fri, 12 Feb 2016 16:35:57 +0000 (11:35 -0500)]
Bug 483096: [GTK3.16+] gtk_widget_override_background_color is
deprecated
This patch is combined backport for the following commits:
9227d728eba1d0a4ac6bdb3c2c1622885187e116
428cc3497ee844b9262d1bdc7cb09a8332eee87c
b32e6b93f9f20497aefb1aafcabe5599e6ab946a
As of GTK3.16, gtk_widget_override_background_color() is deprecated. The
preferred GTK method of setting background colors is through the CSS
theme machinery. Unfortunately this also means some calls to
gtk_widget_override_background_color() will fail (i.e. bug 479998). This
patch aims to prevent cases like that happening in the future.
We already apply certain CSS properties to individual widgets in
Control, therefore setting background colors isn't problematic -- this
patch merely builds off of this functionality. In addition, this patch
implements the ability to read and parse GTK CSS, converting properties
like "background-color" and "background" into GdkRGBA/GdkColor objects.
Note, there are a few widgets that override setBackgroundColor() and
therefore need some additional tweaks: Table/Tree, ToolBar, Text, Label,
and Spinner.
Tested on GTK3.18, 3.16, 3.14, and 2.24. AllNonBrowser JUnit tests pass
on GTK2 and GTK3.
Change-Id: I909c45f36e5dcf16adf884250fb83f259232363e
Signed-off-by: Eric Williams <ericwill@redhat.com>
Arun Thondapu [Wed, 3 Feb 2016 14:37:09 +0000 (20:07 +0530)]
v4529
Markus Keller [Thu, 14 Jan 2016 21:33:38 +0000 (22:33 +0100)]
Bug 485722: [cocoa] Moving cursor with arrow keys on Mac OS not working in "Word Wrap" mode
Change-Id: I03d34fde86aa41b0144e5da0e2e858c807ddb467
Lakshmi Shanmugam [Thu, 28 Jan 2016 09:00:56 +0000 (14:30 +0530)]
Bug 486616 - Mars.2 features and bundles that need a service increase
Updated Manifest.MF, pom.xml and build.xml files
Arun Thondapu [Wed, 27 Jan 2016 05:46:38 +0000 (11:16 +0530)]
v4529
Szymon Ptaszkiewicz [Fri, 8 Jan 2016 11:08:15 +0000 (12:08 +0100)]
Bug 482308 - [win32] Main Menu not refreshed after deactivating Word
editor
Change-Id: I0d268ac91e0317c6eabc5bf0b0334009582b5ea5
Signed-off-by: Szymon Ptaszkiewicz <szymon.ptaszkiewicz@pl.ibm.com>
Arun Thondapu [Wed, 20 Jan 2016 10:03:39 +0000 (15:33 +0530)]
v4529
Snjezana Peco [Wed, 13 Jan 2016 18:41:38 +0000 (19:41 +0100)]
Bug465054 - [GTK3] [GTK3.14] Mixed fonts for labels produces visual garbage on scrolling
Change-Id: Iea3918715b5425e17aa9dd4974c61de9ac3d356c
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
Arun Thondapu [Wed, 13 Jan 2016 13:11:46 +0000 (18:41 +0530)]
v4529
Arun Thondapu [Wed, 13 Jan 2016 13:07:20 +0000 (18:37 +0530)]
v4529
Eric Williams [Thu, 10 Dec 2015 14:37:02 +0000 (09:37 -0500)]
Bug 479998: [GTK3] Form/wizard Composites have incorrect background
colors
UPDATED: This patch also contains fixes to bug 484729.
As of GTK3.16 gtk_widget_override_background_color() is deprecated.
Unfortunately in GTK3.18 it has started to break the background colors
of SwtFixed containers. This is most notably visible in the workspace
selection and commit dialogs, where some background containers had the
default gray background color when they should have been white.
This fix overrides the draw signal in Composite, which allows for CSS
rendering of the background color using gtk_render_background(), which
is the recommended fix as per the GTK team's changes. This ensures that
every composite is drawn with the correct background color if it is set.
The only additional side effect is that ToolBar background colors need
to be set with CSS also, since some SwtFixed containers that were
previously being overridden by ToolBar background colors now are
correctly displaying their own background. This means that ToolBars need
to be rendered with CSS as well. This can be accomplished very easily by
overriding the setBackgroundColor() method in ToolBar.java.
This change will only affect SWT using GTK3.16 and upward. Anything
below 3.16 still uses the old function (which works reliably on those
versions).
Change-Id: I215871be8b6b652d4e77017118415425ae650386
Signed-off-by: Eric Williams <ericwill@redhat.com>
Lakshmi Shanmugam [Mon, 11 Jan 2016 11:57:50 +0000 (17:27 +0530)]
Bug 481611 - Table/tree column header events have incorrect coordinates
in OS X 10.11 El Capitan
In OSX 10.11, the origin of the tree is the header, not the top-left of
the rows. Adjust the co-ordinates accordingly.
Fixed getClientArea, getTopItem, setTopItem, setTopIndex & getTopIndex()
for 10.11. The behavior on older OSX versions remains unchanged.
Lakshmi Shanmugam [Tue, 1 Dec 2015 12:08:30 +0000 (17:38 +0530)]
Bug 434393 - [10.11] OS X: NPE in Control.internal_new_GC
NSGraphicsContext currentContext() returns null on OSX 10.11 when called
from a
non-drawing method, for eg, Table.cellSize(). The fix to is to check if
the context returned is valid, if not we create a new context using
NSGraphicsContext.graphicsContextWithWindow.
Arun Thondapu [Wed, 6 Jan 2016 14:52:50 +0000 (20:22 +0530)]
v4528
Arun Thondapu [Wed, 6 Jan 2016 14:44:39 +0000 (09:44 -0500)]
Revert "Bug 479998: [GTK3] Form/wizard Composites have incorrect background colors "
This reverts commit
a6809d2829e8dba637cdcebd3962e699b1a152b4.
Change-Id: I93f512e8058f88ce5045b0b5af39200e4da01d89
Eric Williams [Thu, 10 Dec 2015 14:37:02 +0000 (09:37 -0500)]
Bug 479998: [GTK3] Form/wizard Composites have incorrect background
colors
As of GTK3.16 gtk_widget_override_background_color() is deprecated.
Unfortunately in GTK3.18 it has started to break the background colors
of SwtFixed containers. This is most notably visible in the workspace
selection and commit dialogs, where some background containers had the
default gray background color when they should have been white.
This fix overrides the draw signal in Composite, which allows for CSS
rendering of the background color using gtk_render_background(), which
is the recommended fix as per the GTK team's changes. This ensures that
every composite is drawn with the correct background color if it is set.
The only additional side effect is that ToolBar background colors need
to be set with CSS also, since some SwtFixed containers that were
previously being overridden by ToolBar background colors now are
correctly displaying their own background. This means that ToolBars need
to be rendered with CSS as well. This can be accomplished very easily by
overriding the setBackgroundColor() method in ToolBar.java.
This change will only affect SWT using GTK3.16 and upward. Anything
below 3.16 still uses the old function (which works reliably on those
versions).
Change-Id: I7b7de3faa53d2ad82b5b546b0e0e607299f123b0
Signed-off-by: Eric Williams <ericwill@redhat.com>
Arun Thondapu [Wed, 6 Jan 2016 13:49:34 +0000 (19:19 +0530)]
Bug 480794: [GTK3] TabFolder cannot be traversed with Tab key;
TabFolder#getChildren() is empty
Fix missing import for ArrayList in
Test_org_eclipse_swt_widgets_TabFolder
Change-Id: I9692bff76b7ef35bda1647c58ac4613bb218572b
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
Markus Keller [Thu, 5 Nov 2015 20:13:46 +0000 (21:13 +0100)]
Bug 480794: [GTK3] TabFolder cannot be traversed with Tab key; TabFolder#getChildren() is empty
Change-Id: Ib9559713fcf327a535b32be3b12de08467eb9c15
Arun Thondapu [Wed, 23 Dec 2015 14:29:38 +0000 (19:59 +0530)]
v4528
Niraj Modi [Tue, 6 Oct 2015 06:03:14 +0000 (11:33 +0530)]
Bug 465644 - [GTK3] Investigate a GTK+ specific fix outside CTabFolder
for rendering issues with GTK3
Change-Id: Iaafdf409ec383f2d1d4f94b3f3cf528df37add01
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Niraj Modi [Thu, 24 Sep 2015 17:54:30 +0000 (23:24 +0530)]
Bug 477798 - [Win32][Cocoa]CTabFolder has wrong initial size
Change-Id: I0d17531b4875f65a7dc3889cc9bf05f897cf481c
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Arun Thondapu [Wed, 14 Oct 2015 11:35:00 +0000 (17:05 +0530)]
v4528
Arun Thondapu [Thu, 1 Oct 2015 08:17:32 +0000 (13:47 +0530)]
Bug 478688 - Update parent pom to 4.5.2
Change-Id: Ifc91556fbbf6dbdfa4f9bd477b734e926470c445
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
Arun Thondapu [Tue, 25 Aug 2015 11:43:22 +0000 (17:13 +0530)]
v4528
Lina Kemmel [Tue, 18 Aug 2015 20:54:28 +0000 (02:24 +0530)]
Bug 467852 - [Win32][bidi] Control#setTextDirection(int) on Composite
doesn't memorize AUTO state on Button and Group children
Change-Id: Ifd04c2268de593c7065d4328a2acb58dcda3d5d8
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
Markus Keller [Fri, 21 Aug 2015 13:23:20 +0000 (15:23 +0200)]
Bug 471835 - Build succeeds, even when "old" parent pom is referred to
Arun Thondapu [Wed, 12 Aug 2015 12:39:15 +0000 (18:09 +0530)]
v4528
Arun Thondapu [Wed, 12 Aug 2015 12:29:39 +0000 (17:59 +0530)]
v4528
Snjezana Peco [Thu, 21 May 2015 08:41:39 +0000 (10:41 +0200)]
Bug 466499 - [GTK3] Path text not drawn in column of commit dialog
window
Change-Id: I508432a354314ca11839e03fbac7b5adc44fff3c
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
Sravan Kumar Lakkimsetti [Wed, 27 May 2015 06:25:37 +0000 (11:55 +0530)]
Bug 468208 - [GTK3] Background not painted correctly when using
SWT.EraseItem
Change-Id: Iea209de4f7386ed096a9988c6013a06292726697
Change-Id: I1bbee7468ba50f59d22ff75bf11239d33622a35c
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Leo Ufimtsev [Tue, 7 Jul 2015 18:16:01 +0000 (14:16 -0400)]
Bug 312568 (part 3) - [GTK] Editor does not get focus after double click
from Project/Package Explorer.
Refactoring code to better match swt style.
Tested, works as before.
Change-Id: I87990a451a9cda562f1af07fc57be11965fe2ad2
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Leo Ufimtsev [Thu, 11 Jun 2015 17:50:29 +0000 (13:50 -0400)]
Bug 312568 (Part 2) [GTK] Editor does not get focus after double click
from Project/Package Explorer.
Moving DefaultSelection event to be sent *after* MouseDoubleClick.
Removing row-activation handler from Tree/Table/List. Instead sending
DefaultSelection event manually in situations described here:
https://developer.gnome.org/gtk3/stable/GtkTreeView.html#GtkTreeView-row-activated
- Double click.
- Space (no modifiers).
- Shift+Space (no other modifiers).
- Return (no modifiers).
This fixes the focus issue in package explorer and also in all widgets
that rely on doubleClick to shift focus, e.g doubleclicking a breakpoint
now shifts focus to the actual breakpoint in the code.
Tests:
(Eclipse + ControlExample + (other snippets) + (SWT Junit tests))
* (Gtk2 + Gtk3)
Change-Id: I1a3d6432d68d29a479fcfe6a64f3f4d54e6127d6
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Leo Ufimtsev [Thu, 11 Jun 2015 15:23:42 +0000 (11:23 -0400)]
Bug 312568 (Part 1) - [GTK] Editor does not get focus after double click
from Project/Package Explorer
This is part 1 of the fix to prevent package explorer from stealing
focus.
Here I remove a workaround introduced 11 years ago. See:
git show
300ace8e3eaec6136b4861feec65efae8fe149fc
Originally not-returning focus caused a seg-fault in GtkTree.
But this is no longer the case with current Gtk.
TESTS PERFORMED after removal:
- 64 bit machine
- (SWT Tree+List+Table) * (Gtk2.24 + Gtk3.14)
-> No crashes observed.
I Used snippet in my Repo for testing:
https://github.com/LeoUfimtsev/LeoSwtTests/blob/master/src/standaloneTests/LTEST_465984_TreeDoubleClick.java
But any Tree/Table/List snippet will do.
Noticible changes in the behaviour of the snippet:
- GTK2 : No changes can be observed with/without patch.
- GKT3 : Focus now stays in the text field after double-clicking on
SWT Tree/List/Table.
Part 2 of the fix is on it's way.
Change-Id: Ie27503caac60a97459b3cb86dc9e024f2e879cd0
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Leo Ufimtsev [Wed, 20 May 2015 20:09:43 +0000 (16:09 -0400)]
Bug 457476 - [GTK3] DND issue with overlapping widgets w/ absolute
positioning.
Fixed *_forall(..) traversal of child widgets in swtFixed. Incorrect
direction of the traversal caused things like DnD Drop & DnD Motion to
find the incorrect widget as destination in the case of overlapping
widgets with absolute positioning (bottom of stack instead of
top).
This fix has a wide reach. If you notice issues with overlapping
widgets, this may affect it's behaviour.
This may also affect layout of internals of a widget, if you observe
odd behaviour (e.g layout is in inverse of what you expect), please
re-open this bug.
Tests carried out: (Gtk2/Gtk3.14):
- DnD with overlapping widgets.
- SWT Juint tests.
- running an Eclipse, fast-view and the application as a whole.
- LayoutExample, (Row/Column/Fill/Grid/FormAttach/Stack).
- Control Example.
I did a code inspection of code that can be affected. All seems good.
Change-Id: Ide88c6b80f69aadd87f0dc0cb68f65317b9587cb
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Arun Thondapu [Wed, 5 Aug 2015 12:02:08 +0000 (17:32 +0530)]
v4527
Lakshmi Shanmugam [Thu, 2 Jul 2015 10:22:54 +0000 (15:52 +0530)]
Bug 471431 - Problems with Table/Tree with header on OSX 10.10.3.
Revert "Bug 446534 - [10.10] Table/tree with column headers visible has
issues on OS X 10.10 Yosemite"
This reverts the following commits:
5c5a1960ed4fe39af5c026e122d7c1e5145e25fa.
adf7f16f5cf34e63f05f2da0e0bae04f43495e01.
f05b4fbf416f2b0b093907de82f9762b4ada1375.
e36ad026bcc2ea955980a2ee3df2c148939b95c0.
Niraj Modi [Wed, 5 Aug 2015 11:16:25 +0000 (16:46 +0530)]
Bug 474305 (Part 2) - SWT should increase bundle version in Mars SR1 to
3.104.1 qualifier
Change-Id: I6c8194771586649167ada0766689071cdeb8d73d
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Niraj Modi [Wed, 5 Aug 2015 10:15:34 +0000 (15:45 +0530)]
Bug 474305 - SWT should increase bundle version in Mars SR1 to 3.104.1
qualifier
Change-Id: I5ec147619d25124592f6bd726afe0f6073b64e48
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Niraj Modi [Tue, 4 Aug 2015 14:41:51 +0000 (20:11 +0530)]
Bug 472956 - [Regression][XULRunner] XULRunner crashes when profile path
does not exist
Change-Id: I48a6cc7236c8000fbfbf3f8698d5741d95845740
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Niraj Modi [Thu, 16 Jul 2015 07:49:55 +0000 (13:19 +0530)]
Bug 334234 - [Viewers] TableViewer scrolls the leftmost column into view
unexpectedly
Change-Id: Ic2e90e1349270c5aed9b6e9816b23febd900e109
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Arun Thondapu [Tue, 7 Jul 2015 14:04:44 +0000 (19:34 +0530)]
Bug 469765 - Prep for 4.6 (Neon) and 4.5 (Mars) maintenance builds
Update pom files to use 4.5.1 for parent pom
Change-Id: Iaf85f7c70a80cae531ff499140674ed590208de8
Arun Thondapu [Thu, 28 May 2015 06:11:10 +0000 (11:41 +0530)]
v4527
Lakshmi Shanmugam [Wed, 27 May 2015 07:18:39 +0000 (12:48 +0530)]
Bug 468439 - Do the annual javadoc bash for 4.5
- javadoc changes.
Change-Id: I7407abcffd09e1e2e5f65aff39fdd4d6e4448ad6
Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
Arun Thondapu [Sun, 24 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527
Arun Thondapu [Sat, 23 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527
Arun Thondapu [Fri, 22 May 2015 23:01:16 +0000 (04:31 +0530)]
v4527
Arun Thondapu [Thu, 21 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527
Arun Thondapu [Thu, 21 May 2015 12:25:57 +0000 (17:55 +0530)]
v4527
Lina Kemmel [Thu, 21 May 2015 12:17:00 +0000 (17:47 +0530)]
Bug 467601 - [Win32][bidi] Control#setTextDirection(int) doesn't
propagate AUTO to children of Composite
Change-Id: I13de91b4d8024132f26f037869a1ff5b9fd75354
Signed-off-by: Lina Kemmel <lkemmel@il.ibm.com>
Sravan Kumar Lakkimsetti [Wed, 20 May 2015 17:27:04 +0000 (22:57 +0530)]
Bug 467687 - SWT: Invalid thread access in GC.drawImage
On Windows created a new method getActualDPI() that works in non ui
threads as well and using this to get the dpi
On linux modified the getActualdpi() method to not use getbounds call
which is actually not required as we need on only x and y of the
display. these are always 0, 0 in all cases of getBounds.
Updated with review comments
Change-Id: I7154ca7a2493fc21d1e38388a2f19c885ce9e4bf
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Arun Thondapu [Wed, 20 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527
Arun Thondapu [Wed, 20 May 2015 12:09:13 +0000 (17:39 +0530)]
v4527
Arun Thondapu [Wed, 20 May 2015 12:05:02 +0000 (17:35 +0530)]
v4527
Niraj Modi [Wed, 20 May 2015 11:57:40 +0000 (17:27 +0530)]
Bug 467656 - CCombo dropdown popup doesn't close automatically
Change-Id: Icedbaaf8bb692861225511711b7adf257cf66bf3
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Sravan Kumar Lakkimsetti [Wed, 20 May 2015 11:11:17 +0000 (16:41 +0530)]
Bug 467664 - [GTK3][ppc64le] Add support for GTK3 in SWT for
Power8/ppc64le platform
Change-Id: I057b853d75651f6fd8f4ef81719077030c50ff3d
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Niraj Modi [Wed, 20 May 2015 10:22:27 +0000 (15:52 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear
Change-Id: I56cac9c5799d3009b3a480a81604944c8251e23b
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Arun Thondapu [Tue, 19 May 2015 23:01:16 +0000 (04:31 +0530)]
v4526
Niraj Modi [Tue, 19 May 2015 12:22:17 +0000 (17:52 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear
- fixed JavaDoc changes to use the term "escape sequences"
Change-Id: I141c0dd13fb97fee5c6d7b5edb5d9cf739822b0c
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Arun Thondapu [Mon, 18 May 2015 23:01:16 +0000 (04:31 +0530)]
v4526