Yusuke Sato [Wed, 16 Feb 2011 14:42:27 +0000 (23:42 +0900)]
Add async version of set_global_engine.
Patch from Zach Kuznia <zork@chromium.org>, modified by Yusuke Sato <yusukes@chromium.org>.
Review URL: http://codereview.appspot.com/4175047
Yusuke Sato [Wed, 16 Feb 2011 06:45:29 +0000 (15:45 +0900)]
Implement async version of ibus_config_set_value.
BUG=crosbug.com/11903
Review URL: http://codereview.appspot.com/4185041
Yusuke Sato [Tue, 15 Feb 2011 07:44:05 +0000 (16:44 +0900)]
Add engine_name parameter to the global-engine-changed signal.
This makes it possible for a client to know the current global engine w/o issuing GetGlobalEngine reqeust.
BUG=chromium-os:11908
Review URL: http://codereview.appspot.com/4177045
Yusuke Sato [Tue, 15 Feb 2011 01:27:03 +0000 (10:27 +0900)]
Use LC_MESSAGES instead of LC_ALL in bus_ibus_impl_set_default_preload_engines.
This is a fix for https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/716314. Calling setlocale(LC_ALL, NULL); in the function seems not to be a good idea since the function could return a complex string like "LC_CTYPE=ja_JP.UTF-8;LC_NUMERIC=C;LC..." when two or more values are used for LC_xxx variables (e.g. ja_JP.UTF-8 and C.)
BUG=1204
Review URL: http://codereview.appspot.com/4160046
Yusuke Sato [Tue, 15 Feb 2011 01:24:20 +0000 (10:24 +0900)]
Never use ibus's US keymap in bus_input_context_filter_key, and use the keyval from X as-is.
I think this is important for supporting non-US keyboards like a Japanese-106 keyboard correctly.
Currently, when use_sys_layout config is unchecked (the default), ibus-daemon discards a keyval being passed from X, and regenerates a keyval from a keycode assuming the US layout.
However, I believe this behavior is not good for non-US keyboard layout users (e.g. Japanese or Korean keyboard users.) For example, the Japanese 106 keyboard has a key called Zenkaku_Hankaku (全角_半角, whose keycode is 49) on the left hand of the '1' key, and most users want to use the key for toggling IME. But, even if a user set 'Zenkaku_Hankaku' as the toggle hotkey using ibus-setup, the user cannot toggle IME unless the 'Use system keyboard layout' option is explicitly turned on. This is because when use_sys_layout is unchecked, ibus-daemon treats the Zenkaku_Hankaku key press (keycode=49) as tilde (~) key press (remember that the tilde's keycode is also 49 in the US keyboard layout.) This is very inconvenient and confusing.
Please also note that the hotkey configuration tool in ibus-setup always respects a keyval from X, and never checks the use_sys_layout value.
Review URL: http://codereview.appspot.com/4173046
Yusuke Sato [Tue, 15 Feb 2011 01:22:48 +0000 (10:22 +0900)]
Always call g_simple_async_result_complete in ibus_input_context_process_key_event_done in order to handle IPC errors correctly.
Review URL: http://codereview.appspot.com/4171049
Ahmad Sharif [Sat, 12 Feb 2011 14:38:35 +0000 (23:38 +0900)]
Fix compiler warnings in util/IMdkit/.
BUG=1201
Review URL: http://codereview.appspot.com/4171046
Patch from Ahmad Sharif <asharif@chromium.org>.
Yusuke Sato [Sat, 12 Feb 2011 13:56:49 +0000 (22:56 +0900)]
Ran 'make update-po' in po/.
BUG=1173
Review URL: http://codereview.appspot.com/4181044
Yusuke Sato [Fri, 11 Feb 2011 14:53:34 +0000 (23:53 +0900)]
Reimplement ibus_bus_watch_dbus_signal for GDBus and export it.
BUG=crosbug.com/11479
Review URL: http://codereview.appspot.com/4186041
Yusuke Sato [Fri, 11 Feb 2011 14:48:42 +0000 (23:48 +0900)]
Support enable/disable hotkeys that enable or disable ibus unconditionally (i.e. not toggle.)
I'll update ibus/po/*po files if the change looks good to you.
BUG=http://code.google.com/p/ibus/issues/detail?id=1173
TEST=manually
Review URL: http://codereview.appspot.com/3807047
phuang [Wed, 9 Feb 2011 12:02:44 +0000 (21:02 +0900)]
Fix ibus-daemon deadlock in engineproxy.c.
How to reproduce the deadlock on a desktop Linux like Ubuntu Maverick:
1. Add 20 seconds sleep in the beginning of the main() function of an engine (e.g. ibus-engine-mozc). See http://crosbug.com/11379#c16 .
2. Set preload_engines to "mozc" using ibus-setup.
3. Start ibus-daemon.
4. press the trigger hotkey twice within the 20 seconds.
Expected:
The second trigger hotkey press cancels the bus_engine_proxy_new operation started by the first one.
Actual:
ibus-daemon freezes. Stack trace: http://crosbug.com/11379#c20
BUG=http://crosbug.com/11379
TEST=see the steps above.
Review URL: http://codereview.appspot.com/4125053
Patch from phuang <shawn.p.huang@gmail.com>.
fujiwarat [Tue, 8 Feb 2011 15:51:39 +0000 (00:51 +0900)]
Add pkgdatadir in ibus-1.0.pc.in
fujiwarat [Tue, 8 Feb 2011 15:50:44 +0000 (00:50 +0900)]
Add GTK3 definitions.
fujiwarat [Tue, 8 Feb 2011 15:50:56 +0000 (00:50 +0900)]
Fix typo.
Yusuke Sato [Thu, 3 Feb 2011 01:15:24 +0000 (10:15 +0900)]
Overwrite Gtk+'s default compose table to fix crosbug.com/11421.
BUG=chromium-os:11421
TEST=manually done on Chrome OS.
Review URL: http://codereview.appspot.com/3989060
Peng Huang [Thu, 27 Jan 2011 23:01:34 +0000 (18:01 -0500)]
Fix build debian package error.
BUG=
TEST=make dpkg
Review URL: http://codereview.appspot.com/4013046
Peng Huang [Thu, 27 Jan 2011 15:06:09 +0000 (10:06 -0500)]
Export async version ibus_input_context_process_key_event.
Some application may want to integrate with ibus directly, and want to
use async mode for processing key events. So I make
ibus_input_context_process_key_event to be an async function,
and also added ibus_input_context_process_key_event_sync.
Fix problem in introspection of Engine.
BUG=none
TEST=Tested in Ubuntu 10.10
Review URL: http://codereview.appspot.com/4032044
Peng Huang [Thu, 27 Jan 2011 00:18:05 +0000 (19:18 -0500)]
Fix problem in introspection of Engine.
BUG=http://code.google.com/p/ibus/issues/detail?id=1194
TEST=Tested in Ubuntu 10.10
Review URL: http://codereview.appspot.com/4084046
fujiwarat [Wed, 26 Jan 2011 04:15:08 +0000 (13:15 +0900)]
Fix introspection definitions.
fujiwarat [Wed, 26 Jan 2011 05:01:25 +0000 (14:01 +0900)]
Set QT_IM_MODULE=xim in case of no ibus-qt.
fujiwarat [Wed, 26 Jan 2011 05:01:17 +0000 (14:01 +0900)]
Add signals in IBusPanelService for non-C classes.
fujiwarat [Mon, 24 Jan 2011 03:25:48 +0000 (12:25 +0900)]
Set GdkEventKey time for gdk_event_put with IBUS_FORWARD_MASK.
Yusuke Sato [Mon, 24 Jan 2011 01:56:05 +0000 (10:56 +0900)]
Add <signal name='ValueChanged'> to introspection_xml in src/ibusconfigservice.c.
I don't think that GDBus library in glib-2.26.[01] uses the information to filter out undefined signals, but just in case.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/4015043
Peng Huang [Fri, 21 Jan 2011 15:57:54 +0000 (10:57 -0500)]
Fix some race conditions during create engine, also fix dpkg build error.
BUG=chromium-os:10750
TEST=on Linux desktop
Review URL: http://codereview.appspot.com/3970044
Yusuke Sato [Fri, 21 Jan 2011 12:03:23 +0000 (21:03 +0900)]
Emit the connected signal after setting up the connection.
Otherwise, we might miss the first a few DBus and IBus signals.
BUG=http://crosbug.com/11144
TEST=see the bug.
Review URL: http://codereview.appspot.com/4029043
Yusuke Sato [Wed, 19 Jan 2011 01:55:16 +0000 (10:55 +0900)]
Fix race condition between ibus_bus_set_global_engine() and ibus_bus_get_global_engine().
If focus moves between the two API calls, ibus_bus_get_global_engine() might return an unexpected engine name:
1. context A is focused, and the current global engine is "X".
2. ibus_bus_set_global_engine("Y") is called.
3. a user moves the focus from A to B. First, A's engine is set to NULL in bus_ibus_impl_set_focused_context(). Then, in the same function, B's engine is set to "X" (not "Y") since the _ibus_set_global_engine asynchronous call is not finished yet.
4. ibus_bus_set_global_engine("Y") async call successfully finishes. Context A's (not B's) engine is set to "Y", but context B, which has a focus, is not updated.
5. ibus_bus_get_global_engine() is called.
expected:
Y is returned.
actual:
X is returned. Since the context B has a focus, and B's engine is X.
BUG=http://crosbug.com/11031
TEST=see the bug
Review URL: http://codereview.appspot.com/4063041
Yusuke Sato [Wed, 19 Jan 2011 01:18:13 +0000 (10:18 +0900)]
Do not allow clients to destroy the server-side config service for safety.
Unset the own flag of priv->config so that the config proxy object never destroys the config service even if a client wrongly unref()s the priv->config object.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/4060041
Yusuke Sato [Tue, 18 Jan 2011 13:00:57 +0000 (22:00 +0900)]
Fix possible SEGV in ibus_bus_get_global_engine.
The g_variant_get returns NULL when the IPC call times out.
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3974043
Yusuke Sato [Tue, 18 Jan 2011 12:51:40 +0000 (21:51 +0900)]
Handle GlobalEngineChanged signals from ibus-daemon.
BUG=http://crosbug.com/11011
TEST=manually
Review URL: http://codereview.appspot.com/4037042
Yusuke Sato [Tue, 18 Jan 2011 01:33:48 +0000 (10:33 +0900)]
On ChromeOS, we don't have to (and don't want to) set default preload engines.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/4054041
Daiki Ueno [Mon, 17 Jan 2011 05:22:18 +0000 (14:22 +0900)]
Set nonzero serial number for RegistryChanged / EngineChanged signals.
libdbus expects each message serial is greater than 0.
https://code.google.com/p/ibus/issues/detail?id=1186
BUG=none
TEST=manual test described in the issue#1186
Review URL: http://codereview.appspot.com/4050041
Yusuke Sato [Sun, 16 Jan 2011 02:35:09 +0000 (11:35 +0900)]
Fix typo in the default configuration of the trigger hotkeys.
According to setup/keyboardshortcut.py, "Control" seems to be correct.
BUG=none
TEST=compile ibus with --enable-memconf, start ibus-daemon, start ibus-setup, click "..." button for the "Enable or disable" hotkey, then verify that the "Control" checkbox in the pop-up dialog is checked from the beginning.
Review URL: http://codereview.appspot.com/4017042
Yusuke Sato [Sun, 16 Jan 2011 02:34:34 +0000 (11:34 +0900)]
Set correct g-flags to proxy objects.
This change is similar to https://github.com/ibus/ibus/commit/
19247aac5a348185a0e180f254ab3858c5f85703.
The flag can prevent unnecessary communications between ibus-daemon and e.g. engines like this:
$ . ~/.config/ibus/bus/*-unix-0 ; dbus-monitor --address $IBUS_ADDRESS 2>&1 | tee /tmp/ibus.log
...
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=3 path=/org/freedesktop/IBus/Factory; interface=org.freedesktop.IBus.Factory; member=CreateEngine
string "mozc-jp"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=3
object path "/org/freedesktop/IBus/Engine/1"
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=4 path=/org/freedesktop/IBus/Engine/1; interface=org.freedesktop.DBus.Properties; member=GetAll
string "org.freedesktop.IBus.Engine"
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=4
array [
]
Calling an engine's org.freedesktop.DBus.Properties.GetAll method when the engine is created is unnecessary for ibus-daemon, while it's not harmful though.
BUG=none
TEST=verified using dbus-monitor that ibus-daemon does not call GetAll anymore.
Review URL: http://codereview.appspot.com/4036041
Yusuke Sato [Wed, 12 Jan 2011 13:44:08 +0000 (22:44 +0900)]
Fix a gcc warning seen in Chromium OS build.
Please note that gcc's warn_unused_result check is enforced on the build environment. Anyway, I believe it's good to check the return value in this case.
BUG=none
TEST=ran emerge-x86-generic ibus.
Review URL: http://codereview.appspot.com/3904044
Yusuke Sato [Wed, 12 Jan 2011 13:43:16 +0000 (22:43 +0900)]
Remove a gcc warning.
ibusxml.c: In function 'ibus_xml_parse_file':
ibusxml.c:213: error: 'retval' may be used uninitialized in this function
BUG=none
TEST=ran make CFLAGS="-Wall -O2"
Review URL: http://codereview.appspot.com/3858044
Yusuke Sato [Wed, 12 Jan 2011 13:42:24 +0000 (22:42 +0900)]
Fix typo in ibus_bus_exit.
BUG=none
TEST=ran make CFLAGS="-Wall -O2"
Review URL: http://codereview.appspot.com/3900045
Yusuke Sato [Mon, 10 Jan 2011 05:25:07 +0000 (14:25 +0900)]
Fix the return value of ibus_bus_register_component so it returns TRUE on success.
Do the same for ibus_bus_set_global_engine as well. Currently it always returns TRUE regardless of the result of the method call.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3902043
Yusuke Sato [Sun, 9 Jan 2011 06:12:11 +0000 (15:12 +0900)]
Change the return type of ibus_bus_exit to make it compatible with ibus-1.3 API.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3923042
Daiki Ueno [Fri, 7 Jan 2011 01:42:44 +0000 (10:42 +0900)]
Set correct sender and interface when sending org.freedesktop.IBus signals.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3775042
Yusuke Sato [Thu, 6 Jan 2011 16:38:23 +0000 (01:38 +0900)]
Set the "g-default-timeout" property for ibusconfig, ibusinputcontext, and ibusbus objects. The GDBus default timeout (25 seconds) seems to be too long for IBus.
BUG=none
TEST=manually, with IBUS_BUS_TIMEOUT=-3,-2,-1,0,1,1000,6000,abc,1abc,abc1
Review URL: http://codereview.appspot.com/3799049
Yusuke Sato [Thu, 6 Jan 2011 03:28:54 +0000 (12:28 +0900)]
Use the G_DBUS_CALL_FLAGS_NO_AUTO_START flag just in case.
BUG=none
TEST=manually on Chromium OS.
Review URL: http://codereview.appspot.com/3774043
Yusuke Sato [Thu, 6 Jan 2011 03:24:36 +0000 (12:24 +0900)]
Do not write empty string to "preload_engines" for safety.
Without the change, bus_ibus_impl_set_default_preload_engines() might erase an existing preload_engines config when --timeout option for ibus-daemon is too short for ibus_config_get() to success.
BUG=none
TEST=manually with 'ibus-daemon --timeout=1'
Review URL: http://codereview.appspot.com/3789046
Yusuke Sato [Wed, 5 Jan 2011 23:44:49 +0000 (08:44 +0900)]
Call ibus_hotkey_profile_remove_hotkey_by_event in bus_ibus_impl_set_trigger before registering the fallback hotkey, just in case.
Probably it's better to call the remove function in bus_ibus_impl_set_trigger just as bus_ibus_impl_set_hotkey already does, so that a wierd error message like 'IBUS-CRITICAL **: ...: file ibushotkey.c: line 381 (ibus_hotkey_profile_add_hotkey): should not be reached' will not be shown.
The fallback hotkey could be registered twice, via bus_ibus_impl_init and _dbus_name_owner_changed_cb, if the --timeout parameter is too small to talk to the configuration daemon, for example.
BUG=none
TEST=ran ibus-daemon with --timeout=1 and verified that the IBUS-CRITICAL message above was not shown.
Review URL: http://codereview.appspot.com/3796044
Yusuke Sato [Wed, 5 Jan 2011 23:25:47 +0000 (08:25 +0900)]
Replace g_return_if_fail with g_warning since the error message 'desc != NULL' seems confusing.
BUG=none
TEST=manually. removed all engines using ibus-setup and ran ibus-daemon, then press a trigger hot-key.
Review URL: http://codereview.appspot.com/3786047
Yusuke Sato [Wed, 5 Jan 2011 23:22:38 +0000 (08:22 +0900)]
Fix --timeout command line option of ibus-daemon.
On 1.3.99, currently the option is just ignored and '-1' (i.e. the default timeout of gdbus which is 25 seconds in glib-2.26.1) is always used. We should fix this since the default, 25 secs, is too long for some platforms like Chromium OS.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3784047
Yusuke Sato [Sat, 1 Jan 2011 08:34:37 +0000 (17:34 +0900)]
Support hotkeys that use Super/Hyper modifiers.
BUG=1175
TEST=checked that Super+space and Hyper+space work as intended with and without the use_sys_layout option enabled.
Review URL: http://codereview.appspot.com/3856041
Peng Huang [Tue, 28 Dec 2010 23:44:16 +0000 (16:44 -0700)]
Reply an error message to sender, if ibus-daemon can not forward method call message successfully.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3825042
Daiki Ueno [Tue, 28 Dec 2010 03:46:25 +0000 (12:46 +0900)]
Fix g_variant_get() call in DeleteSurroundingText signal handler.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3820042
Yusuke Sato [Sun, 26 Dec 2010 22:58:29 +0000 (07:58 +0900)]
Fix API compatibility issue in ibus_config_new.
On ibus-1.3, ibus_config_new returns NULL when ibus-gconf is not started yet, but on 1.4 it returns a valid, non-NULL IBusConfig object. This patch fixes the discrepancy by changing the behavior of ibus_config_new of 1.4.
If we don't return NULL when ibus-gconf does not exist, successive calls e.g. ibus_config_set_value will fail with a cryptic error message like 'IBUS-WARNING **: org.freedesktop.IBus.Config.SetValue: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag'. I believe returning NULL makes it easier to use the ibusconfig.h APIs.
Please note that this patch is particularly important for Chromium OS. Since ibus_config_new is called shortly after ibus-daemon starts on the OS, ibus_config_new is sometimes called before ibus-memconf starts actually. This change helps the glue between chrome and ibus-daemon to remain clean.
BUG=none
TEST=manually on Chromium OS
Review URL: http://codereview.appspot.com/3784043
Yusuke Sato [Sun, 26 Dec 2010 22:57:09 +0000 (07:57 +0900)]
Create an instance of GDBusProxy with G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES flag.
Without the flag, on_name_owner_changed() in glib-2.26.x/gio/gdbusproxy.c might invoke a remote method named GetAll in org.freedesktop.DBus.Properties interface, but the method is not implemented in ibus-daemon. Since ibus-daemon ignores the method call, the caller, which is UI thread of Chrome on Chromium OS, will block for 25 seconds (i.e. the default timeout of GDBus) waiting for a reply.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3836042
Peng Huang [Sun, 26 Dec 2010 05:05:13 +0000 (22:05 -0700)]
Fix Alt+Shift hotkey issue for chrome os
BUG=chromium-os:6225
TEST=manual
Review URL: http://codereview.appspot.com/3741043
Yusuke Sato [Wed, 22 Dec 2010 14:03:03 +0000 (23:03 +0900)]
Fix hot-key handling in inputcontext.c.
Without the fix, some key combinations might not trigger a hot-key event.
For example, one of Chrome OS hot-keys, "press Shift, then press Alt, then release Alt", does not work without the fix.
BUG=none
TEST=manually checked using ChromeOS and IBus-1.4
Review URL: http://codereview.appspot.com/3828041
Yusuke Sato [Mon, 20 Dec 2010 16:04:49 +0000 (01:04 +0900)]
Add comments to ibusproxy.[ch] and related functions.
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3802042
Yusuke Sato [Mon, 20 Dec 2010 16:04:05 +0000 (01:04 +0900)]
Fix ibus_input_context_get_input_context() so IBus.Service.Destroy will not be called when the returned object is disposed.
BUG=none
TEST=verified that calling g_object_unref(the_returned_object) does not result in the remote method call.
Review URL: http://codereview.appspot.com/3803041
Daiki Ueno [Mon, 20 Dec 2010 09:19:04 +0000 (18:19 +0900)]
Don't call nonexistent org.freedesktop.IBus.InputContext.Destroy.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3800041
Yusuke Sato [Mon, 20 Dec 2010 06:02:20 +0000 (15:02 +0900)]
Fix typo in introspection_xml[] for InputContext.
https://github.com/ibus/ibus/commit/
ed778cd7cfc78eb39fc74167f2169b69f4d72a6b was incomplete, sorry.
BUG=none
TEST=verified that properties can be changed via input context on Chrome OS.
Review URL: http://codereview.appspot.com/3795041
Daiki Ueno [Wed, 15 Dec 2010 09:33:33 +0000 (18:33 +0900)]
Init GError before calling g_dbus_proxy_call*().
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3669041
Daiki Ueno [Wed, 15 Dec 2010 09:32:17 +0000 (18:32 +0900)]
Fix gtk version check for deprecated keysyms.
From the git log of gtk3, they started adding _KEY from 2.91.0 not 2.90.0.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3670041
Peng Huang [Wed, 15 Dec 2010 09:04:43 +0000 (17:04 +0800)]
Disconnect closed signal from GDBusConnection before creating a new connection.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3668041
Yusuke Sato [Wed, 15 Dec 2010 06:13:00 +0000 (15:13 +0900)]
Fix assertion failure in ibusbus.c.
The following code does not work since the underlying connection for IBus-1.4 is not a sub class of IBusObject.
ibus_object_destroy ((IBusObject *)priv->connection);
g_assert (priv->connection == NULL);
BUG=none
TEST=ran Chrome for Chrome OS.
Review URL: http://codereview.appspot.com/3658041
Yusuke Sato [Wed, 15 Dec 2010 05:36:19 +0000 (14:36 +0900)]
Fix type mismatch in src/ibuspanelservice.c.
BUG=none
TEST=ran candidate_window for Chrome OS.
Review URL: http://codereview.appspot.com/3661041
Yusuke Sato [Wed, 15 Dec 2010 05:09:20 +0000 (14:09 +0900)]
Use unsigned for the parameter of the PropertyActivate message.
unsigned would be better since the Python binding and engine proxy use unsigned for this purpose.
BUG=none
TEST=ran Chrome for Chrome OS.
Review URL: http://codereview.appspot.com/3660041
Yusuke Sato [Wed, 15 Dec 2010 02:55:16 +0000 (11:55 +0900)]
Fix type mismatch in the PropertyActivate message.
src/ibusinputcontext.c sends the massage with "(si)" but the daemon use the massage as "(&su)". This triggers assertion failure on Chrome OS.
BUG=none
TEST=change ibus-mozc's property on Chrome OS via the IME menu.
Review URL: http://codereview.appspot.com/3636041
Peng Huang [Thu, 2 Dec 2010 05:12:53 +0000 (13:12 +0800)]
Fix crash in im-ibus.so
BUG=chromium-os:9868
TEST=manual
Review URL: http://codereview.appspot.com/3401041
Peng Huang [Sun, 21 Nov 2010 10:26:18 +0000 (19:26 +0900)]
Focus out/in fake input context if the input window changed.
BUG=chromium-os:8855
TEST=manual
Review URL: http://codereview.appspot.com/3199042
Peng Huang [Tue, 14 Dec 2010 02:16:32 +0000 (10:16 +0800)]
Focus out the fake context in im-ibus.so, when a real context gets the focus.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3561042
Peng Huang [Tue, 14 Dec 2010 02:14:45 +0000 (10:14 +0800)]
Add fake context back in IBusIMContext.
The fake context is removed by mistake in ibus-1.4. It is necessary for Chrome OS.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3574042
Peng Huang [Mon, 13 Dec 2010 09:37:09 +0000 (17:37 +0800)]
Fix typo and annotation.
Fix typo in IBusEngineDesc:rank doc and GI transfer mode for
ibus_component_get_engines().
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3614041
Peng Huang [Wed, 8 Dec 2010 08:37:42 +0000 (16:37 +0800)]
Fix GI transfer mode annotation in ibus_bus_list_*engines() comment.
See https://bugzilla.gnome.org/show_bug.cgi?id=635248. Also, do not mark those
functions as "not implemented", since they are apparently implemented.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3274044
Yusuke Sato [Thu, 2 Dec 2010 15:42:45 +0000 (00:42 +0900)]
Add #include <ibuspanelservice.h> to ibus.h.
Add #include <ibuspanelservice.h> to ibus.h so an external project (e.g. Chromium OS project) could implement its own panel component in C/C++.
Review URL: http://codereview.appspot.com/3411041
Yusuke Sato [Thu, 2 Dec 2010 15:41:15 +0000 (00:41 +0900)]
Remove unused header file, src/ibusconfigprivate.h
Review URL: http://codereview.appspot.com/3412041
Yusuke Sato [Wed, 1 Dec 2010 13:00:44 +0000 (22:00 +0900)]
Fix compile errors on Chromium OS.
This is for the master branch of ibus.
BUG=crosbug.com/9685
TEST=ran emerge-x86-generic ibus.
Review URL: http://codereview.appspot.com/3368041
Yusuke Sato [Mon, 29 Nov 2010 03:04:27 +0000 (12:04 +0900)]
Do not call g_critical when ibus->config is NULL since it's not an error.
The change is originally for chromeos branch of ibus (http://codereview.appspot.com/3304043/) but I believe this is also good for the master branch of ibus.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3269043
Yusuke Sato [Fri, 26 Nov 2010 07:07:56 +0000 (16:07 +0900)]
Add the "destroy" signal handler back following Peng's suggestion at codereview.appspot.com/3293042/.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3335041
Yusuke Sato [Fri, 26 Nov 2010 01:15:08 +0000 (10:15 +0900)]
Add function comments to bus/panelproxy.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3293042
Yusuke Sato [Thu, 25 Nov 2010 08:54:19 +0000 (17:54 +0900)]
Fix unexpected client capabilities in ibus-daemon.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3323041
Yusuke Sato [Thu, 25 Nov 2010 08:40:43 +0000 (17:40 +0900)]
Change the order of engine method calls for consistency.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3304042
Yusuke Sato [Thu, 25 Nov 2010 07:55:04 +0000 (16:55 +0900)]
Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch].
Removed a temporary hack for PREEDIT_CONDITION by adding bus_ibus_impl_is_embed_preedit_text function to ibusimpl.c.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3321041
Yusuke Sato [Wed, 24 Nov 2010 09:50:57 +0000 (18:50 +0900)]
Re-enable the use_sys_layout feature.
Currently use_sys_layout cannot be disabled.
BUG=none
TEST=manually
Review URL: http://codereview.appspot.com/3306041
Peng Huang [Wed, 24 Nov 2010 08:46:12 +0000 (17:46 +0900)]
Pass cancellable object to bus_factory_proxy_create_engine
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3304041
Peng Huang [Wed, 24 Nov 2010 02:33:10 +0000 (11:33 +0900)]
Clean up the code of focus switch logic, and fix a crash when focused context is destroyed.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3192042
Peng Huang [Wed, 24 Nov 2010 02:29:19 +0000 (11:29 +0900)]
Fix some crashs when engine processes are killed.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3152042
Peng Huang [Wed, 24 Nov 2010 01:29:26 +0000 (10:29 +0900)]
Use g_object_add_weak_pointer to make code simpler.
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3252041
Jim Huang [Sun, 21 Nov 2010 17:37:04 +0000 (01:37 +0800)]
Add generated files into .gitignore
Jim Huang [Sun, 21 Nov 2010 17:24:08 +0000 (01:24 +0800)]
Avoid comparison of unsigned expression
comparison of unsigned expression < 0 is always false
Jim Huang [Sun, 21 Nov 2010 17:15:25 +0000 (01:15 +0800)]
Add assertions to connection_destroy callback
Peng Huang [Sun, 21 Nov 2010 10:13:34 +0000 (19:13 +0900)]
Remove some unused header files.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3218041
fujiwarat [Thu, 18 Nov 2010 03:23:45 +0000 (12:23 +0900)]
Fix NULL of focused input context
Yusuke Sato [Wed, 17 Nov 2010 10:15:38 +0000 (19:15 +0900)]
Add comments to bus/connection.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3164041
Yusuke Sato [Wed, 17 Nov 2010 10:14:44 +0000 (19:14 +0900)]
Add comments to bus/factoryproxy.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3163041
Yusuke Sato [Wed, 17 Nov 2010 08:34:29 +0000 (17:34 +0900)]
Add comments to bus/registry.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3162041
Yusuke Sato [Wed, 17 Nov 2010 08:12:32 +0000 (17:12 +0900)]
Add comments about thread safety.
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3156041
Yusuke Sato [Wed, 17 Nov 2010 07:01:17 +0000 (16:01 +0900)]
Add comments to bus/component.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3161041
Yusuke Sato [Wed, 17 Nov 2010 04:49:55 +0000 (13:49 +0900)]
Add comments to bus/ibusimpl.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3154041
fujiwarat [Tue, 16 Nov 2010 09:11:37 +0000 (18:11 +0900)]
Fix no defined '_' in EngineAbout
Peng Huang [Tue, 16 Nov 2010 08:59:48 +0000 (17:59 +0900)]
Add introspection data for org.freedesktop.IBus.Panel and remove Destroy method.
Add introspection data for org.freedesktop.IBus.Panel interface.
And remove Destroy method from Panel interface, because it is moved to
org.freedesktop.IBus.Service interface.
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3137041
Yusuke Sato [Tue, 16 Nov 2010 06:43:12 +0000 (15:43 +0900)]
Add comments to bus/dbusimpl.[ch].
BUG=none
TEST=none
Review URL: http://codereview.appspot.com/3132041
Peng Huang [Tue, 16 Nov 2010 05:22:23 +0000 (14:22 +0900)]
Make sure send the reply of method IBus.Exit out before the daemon exits.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3133041
Peng Huang [Tue, 16 Nov 2010 05:02:34 +0000 (14:02 +0900)]
Add global variable DOMAINNAME to replace "ibus10" in everywhere.
BUG=none
TEST=manual
Review URL: http://codereview.appspot.com/3093042
fujiwarat [Tue, 16 Nov 2010 03:08:53 +0000 (12:08 +0900)]
Fix ibus_version in configure and translation domain in ibus-setup.