Tomas Matousek [Thu, 21 Feb 2019 02:07:28 +0000 (18:07 -0800)]
Set copyright and package license
Stephen Toub [Wed, 20 Feb 2019 18:34:32 +0000 (13:34 -0500)]
Fix bug introduced during cleanup in JapaneseLunisolarCalendar (#22717)
Ben Adams [Wed, 20 Feb 2019 18:32:40 +0000 (18:32 +0000)]
Allow Task.WaitAny completion to run synchronously (#21245)
Sinan Kaya [Wed, 20 Feb 2019 16:59:22 +0000 (11:59 -0500)]
Abstract deprecated and selectany for GCC and remove LLVM'ism where possible (#22662)
* Abstract selectany
* Fix initializer element is not constant
src/corefx/System.Globalization.Native/pal_icushim.c:58:34: error: initializer element is not constant
static const int MaxICUVersion = MinICUVersion + 20;
* Enable ms extensions
* Apply LLVM patterns to GCC
* Remove deprecated function
* Fix const conversion error
src/corefx/System.Globalization.Native/pal_calendarData.c:390:16: warning: passing argument 1 of ‘ures_close_ptr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
ures_close(erasResBundle);
src/corefx/System.Globalization.Native/pal_calendarData.c:419:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
char* name = GetCalendarName(calendarId);
* Remove old compiler option
Stephen Toub [Wed, 20 Feb 2019 11:54:11 +0000 (06:54 -0500)]
Fix race condition in ManualResetValueTaskSourceCore (#22711)
* Fix race condition in ManualResetValueTaskSourceCore
ManualResetValueTaskSourceCore.GetStatus is used from ValueTaskAwaiter.IsCompleted. If GetStatus returns Success too early, then IsCompleted will also return true too early, which will result in GetResult being called too early. This doesn't happen today when an MRVTSC is used sequentially. But if an instance is pooled by the object its stored on getting put back into a pool as part of a call to the wrapper's GetResult, then we can end up in the following situation:
- Thread 1 starts an await on an instance containing an MRVTSC. It calls IsCompleted.
- Thread 2 starts to complete that instance, getting as far as calling SignalCompletion and setting _completed to true but not yet setting _continuation.
- Thread 1 sees _completed == true and returns true from IsCompleted. It calls GetResult, and the wrapper extracts the result from the instance, resets it, and puts it back into the pool.
- Thread 3 takes the object out of the pool and starts using it.
- Thread 2 continues SignalCompletion on that instance, and sets _continuation to the sentinel.
- Now Thread 3's instance's _continuation is the sentinel when it should be null. If it calls SignalCompletion, it'll erroneously find that _continuation is not null and will queue _continuation/_continuationState for execution, resulting in the sentinel getting executed. If it calls OnCompleted, it'll find that the _continuation is not null, and will queue the supplied continuation/state to execute immediately even though the operation may not yet actually be done.
The fix is simply to check not just _completed but also _continuation. The operation is considered pending if either _completed is false, meaning SignalCompletion has not yet been called, or if _continuation is still null, meaning it's neither been set to the supplied delegate nor to the sentinel. We can't just rely on _completed for the above outlined reasons, and we can't just rely on _continuation because it can be non-null if OnCompleted was called to hook up a callback (if we only cared about the await pattern, then we could just check _continuation and wouldn't need _completed, but we also need to support non-await access).
* Address PR feedback
Mike McLaughlin [Wed, 20 Feb 2019 07:16:25 +0000 (23:16 -0800)]
Fix CLRDataCreateInstance export. This was breaking SOS. (#22701)
Fix CLRDataCreateInstance export. This was breaking SOS.
Added the right cmake magic so the function is exported properly.
Sung Yoon Whang [Wed, 20 Feb 2019 05:40:12 +0000 (21:40 -0800)]
Add ManagedRuntimeEventSource (#22515)
* Adding a dummy ManagedRuntimeEventSource
* Add ManagedRuntimeEventSource
* Renaming ManagedRuntimeEventSource to RuntimeEventSource
* some cleanup
* use Condition instead of ifdefing out the whole file
* some cleanups
* remove unused namespaces
* Move m_RuntimeEventSource to RuntimeEventSource from EventPipeController
* Adding some TODO items
* address more pr comments
* Use GUID to initialize RuntimeEventSource
* Exclude BasicEventSourceTests from CoreFX test CI leg
* Addressing rest of the PR feedback
* dont dispose counters on disable command to avoid races
Jan Kotas [Wed, 20 Feb 2019 04:48:19 +0000 (20:48 -0800)]
Early out from vectored exception handler on uninitialized threads (#22702)
Fixes #22698
Jan Kotas [Wed, 20 Feb 2019 04:38:15 +0000 (20:38 -0800)]
Use out arguments in UmAlQuraCalendar (#22704)
Jan Kotas [Wed, 20 Feb 2019 04:36:46 +0000 (20:36 -0800)]
Cleanup CoreLib makefiles (#22706)
Tanner Gooding [Wed, 20 Feb 2019 02:07:44 +0000 (18:07 -0800)]
Adding tannergooding to the arm64Users list. (#22665)
Brian Sullivan [Wed, 20 Feb 2019 01:31:27 +0000 (17:31 -0800)]
Merge pull request #22656 from briansull/fix_arm64_assert
ARM64: Correct the assert to add R8 as a potential valid arg register
Brian Sullivan [Tue, 19 Feb 2019 23:30:09 +0000 (15:30 -0800)]
Fix formatting
Stephen Toub [Tue, 19 Feb 2019 22:35:06 +0000 (17:35 -0500)]
Use RunContinuationsAsynchronously in SemaphoreSlim.WaitAsync (#22686)
SemaphoreSlim.Release shouldn't invoke arbitrary continuations as part of its invocation, so when it dequeues a task waiter and goes to complete it, rather than just calling TrySetResult, it queues the task to the thread pool to have TrySetResult invoked there. Now that we have RunContinuationsAsynchronously, though, we can just use that functionality instead. This has two main benefits:
1. We avoid queueing a work item entirely if there are no continuations from the task. This might happen, for example, if the semaphore is released so quickly after waiting on it that the WaitAsync caller hasn't yet hooked up a continuation, in which case the await on the WaitAsync task will just see IsCompleted as true and continue running.
2. We avoid queueing a work item when the task represents a synchronous Wait, which happens if there's already a pending WaitAsync when Wait goes to block. The main benefit here is avoiding potential thread pool starvation, if threads in the pool are blocked in such Waits, and previously another thread pool thread would have been needed to run the queued work item to complete the synchronous Wait.
Brian Sullivan [Sat, 16 Feb 2019 02:06:38 +0000 (18:06 -0800)]
Correct the assert to add R8 as a potential valid register
Also fix the calls to RemoveElemD to use lvVarIndex
Re-enable the interop tests that were failing on ARM64
Hugh Bellamy [Tue, 19 Feb 2019 21:33:26 +0000 (21:33 +0000)]
Cleanup Calendars code (#22582)
Tanner Gooding [Tue, 19 Feb 2019 21:24:30 +0000 (13:24 -0800)]
Fixing extension method overload resolution for some S.R.I.Vector methods (#22696)
dotnet-maestro[bot] [Tue, 19 Feb 2019 18:42:20 +0000 (10:42 -0800)]
Update dependencies from https://github.com/dotnet/core-setup build
20190218.4 (#22689)
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27418-4
Egor Chesakov [Tue, 19 Feb 2019 18:12:43 +0000 (10:12 -0800)]
Use testGroup for defining test jobs (#22608)
This adds a mapping between testGroup string and values of the following parameters:
* scenarios
* priority
* timeoutTotalInMinutes
* timeoutPerTestCollectionInMinutes
* timeoutPerTestInMinutes
and uses testGroup on a level of azure-pipeline.yml to set these values.
Russ Keldorph [Fri, 15 Feb 2019 23:47:01 +0000 (15:47 -0800)]
Enable telemetry for official builds
Fei Peng [Tue, 19 Feb 2019 15:50:15 +0000 (07:50 -0800)]
Optimize Vector128/256<T>.Get/WithElement (#22353)
Tanner Gooding [Tue, 19 Feb 2019 15:29:07 +0000 (07:29 -0800)]
Adding an update-dependencies.cmd script, like CoreFX has. (#22672)
Michal Strehovský [Tue, 19 Feb 2019 12:47:50 +0000 (13:47 +0100)]
Fail loading types with default interface methods for fragile ngen (#22603)
We are not generating the right data structures for this. Since fragile crossgen is no longer a mainstream scenario, it's not worth the effort to add default interface methods support for it.
This avoids `!"Precode::GetPrecodeFromEntryPoint: Unexpected code in precode"` and similar issues.
Andy Ayers [Tue, 19 Feb 2019 07:43:46 +0000 (23:43 -0800)]
Adjust gc stress compatibility settings for two tests (#22633)
* enable eventsourcetrace for gc stress. Closes #17188.
* disable GitHub_12224 for gc stress (relies on timeout). Closes #19086.
Jan Kotas [Tue, 19 Feb 2019 00:38:20 +0000 (16:38 -0800)]
Use correct version for Microsoft.NETCore.Platforms (#22683)
Jan Kotas [Tue, 19 Feb 2019 00:37:19 +0000 (16:37 -0800)]
Remove resetting of unmanaged thread locale from thread pool APIs (#22682)
The cost of doing this is showing up in the TechEmpower profiles. There is a lot of thread locale state in unmanaged libraries and OS APIs that the threadpool friendly code has to be aware off. It does not make sense to keep reseting just the Locale.
dotnet-maestro[bot] [Mon, 18 Feb 2019 19:04:44 +0000 (11:04 -0800)]
Update dependencies from https://github.com/dotnet/corefx build
20190218.1 (#22678)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19118.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19118.1
Michal Strehovský [Mon, 18 Feb 2019 16:19:55 +0000 (17:19 +0100)]
Fix constrained call corner cases (#22464)
Fixes #22423. I'm still unclear on how JitStress manages to get itself into that situation, but I was able to write a repro that triggers the `!pMDAfterConstraintResolution->IsInterface()` assert using regular IL, so we need to handle that either way. The repro for that is constrained3.il.
While figuring out the repro, I wrote a bunch of other test code and found another bug (constrained2), where we would box in a situations that doesn't require boxing (canonically ambiguous situation where there's a suitable default interface implementation and a valuetype implementation of the constrained method that does not requires boxing once we no longer deal with __Canon).
Ben Adams [Mon, 18 Feb 2019 08:17:13 +0000 (08:17 +0000)]
Fix warning causing error in warning as error (Windows) (#22660)
BOOL -> bool conversion
dotnet-maestro[bot] [Mon, 18 Feb 2019 05:16:42 +0000 (21:16 -0800)]
Update dependencies from https://github.com/dotnet/arcade build
20190215.1 (#22669)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19115.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19115.1
dotnet-maestro[bot] [Mon, 18 Feb 2019 05:16:20 +0000 (21:16 -0800)]
Update dependencies from https://github.com/dotnet/corefx build
20190217.1 (#22670)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19117.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19117.1
Sinan Kaya [Mon, 18 Feb 2019 05:12:28 +0000 (00:12 -0500)]
Fix Integer Rounding issue and duplicate definition of __deref in sal.h (#22645)
* Fix large integer truncation
pal/pal.h:4988:43:
warning: large integer implicitly truncated to unsigned type
[-Woverflow]
static const SIZE_T NoTargetFrameSp = SIZE_MAX;
^~~~~~~~
* Fix compilation error with GCC
/usr/include/c++/7.3.0/debug/functions.h:452:15: error: expected unqualified-id before ')' token
__deref();
^
/usr/include/c++/7.3.0/debug/functions.h:455:34: error: expected primary-expression before '<' token
typename = decltype(__deref<_It>() < __deref<_It>())>
^
/usr/include/c++/7.3.0/debug/functions.h:455:38: error: expected primary-expression before '>' token
typename = decltype(__deref<_It>() < __deref<_It>())>
^
/usr/include/c++/7.3.0/debug/functions.h:455:40: error: expected primary-expression before ')' token
typename = decltype(__deref<_It>() < __deref<_It>())>
^
Adeel Mujahid [Mon, 18 Feb 2019 04:29:23 +0000 (06:29 +0200)]
Delete RtlMoveMemory and tests (#22668)
Swaroop Sridhar [Sun, 17 Feb 2019 21:27:41 +0000 (13:27 -0800)]
Fix the build of Loader/NativeLib test (#22648)
The native test assets were not build correctly on Unix platforms.
The native library exports were generated as private symbols by clang.
This change fixes the export declaration so that the global symbols are
correctly generated for exported symbols.
Fixes #22549
Tanner Gooding [Sun, 17 Feb 2019 03:38:04 +0000 (19:38 -0800)]
Only import the RoslynPropsFile if it exists. (#22657)
Adeel Mujahid [Sun, 17 Feb 2019 01:50:17 +0000 (03:50 +0200)]
Fix visibility and signed comparison issues for GCC (#22586)
* Fix visibility and signed comparison issues for GCC
* Fix hidden _CLRDataCreateInstance warned by macOS
* Fix indentation in vswprintf/test1
* Change void* to PVOID in implementation files
Jan Kotas [Sun, 17 Feb 2019 01:49:06 +0000 (17:49 -0800)]
Avoid pulling in Lazy<T> during startup (#22659)
Environment constructor runs on every startup path. Remove dependency on Lazy<T> from it.
Carol Eidt [Sat, 16 Feb 2019 15:06:45 +0000 (07:06 -0800)]
Merge pull request #22528 from mikedn/idx-addr
Fix genCodeForIndexAddr
dotnet-maestro[bot] [Sat, 16 Feb 2019 07:50:21 +0000 (23:50 -0800)]
[master] Update dependencies from dotnet/corefx (#22595)
* Update dependencies from https://github.com/dotnet/corefx build
20190213.23
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19113.23
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19113.23
* Update dependencies from https://github.com/dotnet/corefx build
20190215.1
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19115.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19115.1
* Fixing up the tests dependent on the S.R.I.Vector API changes
* Regenerating the tests dependent on the S.R.I.Vector API changes
* Disabling an outdated CoreFX test.
Aaron Robinson [Sat, 16 Feb 2019 05:28:50 +0000 (21:28 -0800)]
Set the 'PLATFORM_OSX' constant during OSX build (#22639)
* Set the 'PLATFORM_OSX' constant during OSX build
* Remove PLATFORM_OSX define from SPCL
Aaron Robinson [Sat, 16 Feb 2019 05:25:08 +0000 (21:25 -0800)]
Fix bug in FindDispatchSlot usage
Tanner Gooding [Sat, 16 Feb 2019 05:11:56 +0000 (21:11 -0800)]
Update BuildTools, IbcData, PgoData to 3.0.0-preview1-03715-01, master-
20190208.1, master-
20190208.1, respectively (master) (#22647)
Tanner Gooding [Fri, 15 Feb 2019 23:17:52 +0000 (15:17 -0800)]
Updating some local functions to be 'static' (captureless). (#22635)
Andy Ayers [Fri, 15 Feb 2019 22:39:33 +0000 (14:39 -0800)]
JIT: modify how jit determines when to update a type (#22618)
For single-def locals, the type of a reference seen at the assignment to the
local may be a more specific type than the local's declared type. If so the jit
would prefer to use the assignment type to describe the local's value, as this
will lead to better optimization. For instance in
```
object x = "a string"; // only assignment to x
```
the jit can optimize better if it models the type of `x` as `string`.
Instead of relying on `mergeClasses` plus some jit-side screening to decide if
the assignment type is a more specific type, implement a new jit interface
method `isMoreSpecificType` that tries to answer this question more directly.
Added a test case with type equivalence that hit asserts.
Closes #22583.
Sergey Andreenko [Fri, 15 Feb 2019 22:03:47 +0000 (14:03 -0800)]
Disable arm64 contracts. (#22605)
* Fix ifdef for `g_DbgSuppressAllocationAsserts`.
It needs to be defined under `FEATURE_INTEROP_DEBUGGING`.
* Unify contracts disabling for UNIX/ARM.
It also disables some parts that were disabled for ARM, but not for UNIX.
It fixes the difference that we see between ARM32 and ARM64 Unix Checked.
* Disable contracts on arm64.
FIxes the difference that we see between windows arm32 and arm64 in checked/debug builds.
* Revert CoreFX arm64 timeout change.
That is no longer necessary.
* Reenable arm64 corefx jobs.
They should not fail with timeouts anymore.
* Don't allow `g_DbgSuppressAllocationAsserts` defnition in release builds.
* delete AssertAllocationAllowed
David Mason [Fri, 15 Feb 2019 22:02:31 +0000 (14:02 -0800)]
Port profiler howtos from David Broman's blog to the documentation folder (#22363)
Steve MacLean [Mon, 11 Feb 2019 21:39:44 +0000 (16:39 -0500)]
Publish version to dotnet/versions
Steve MacLean [Thu, 14 Feb 2019 21:04:47 +0000 (16:04 -0500)]
Fix UpdatePublishedVersions.ps1
Mike Danes [Fri, 15 Feb 2019 18:56:59 +0000 (20:56 +0200)]
Widen index to a temporary register
Jan Kotas [Fri, 15 Feb 2019 19:23:45 +0000 (11:23 -0800)]
Delete references to System.Memory package that does not exist anymore (#22626)
Jan Kotas [Fri, 15 Feb 2019 18:25:05 +0000 (10:25 -0800)]
Disable failing corefx test (#22625)
Related to https://github.com/dotnet/corefx/issues/35351
Tanner Gooding [Fri, 15 Feb 2019 17:20:37 +0000 (09:20 -0800)]
Manually update the dependencies.props and move S.P.Corelib to use LangVersion=8.0 (#22452)
* Update BuildTools to preview1-03713-01 (master)
* Updating CoreCLR to use LangVersion=8.0
* Moving the Windows scripts to default to `dotnet msbuild` for managed components
* Setting UseSharedCompilation=true
* Changing some additional callsites that were using msbuild to use dotnet msbuild
* Revert packages.builds to use Desktop msbuild on Windows
* Fixing runtest.cmd to always set DotNetCli
Jan Kotas [Fri, 15 Feb 2019 16:20:12 +0000 (08:20 -0800)]
Reserve fast dictionary slots for Tier1 code (#22619)
Disable use of fast dictionary slots for R2R images when tiered JITing is enabled.
Fixes #22400
dotnet-maestro[bot] [Fri, 15 Feb 2019 16:10:14 +0000 (08:10 -0800)]
Update dependencies from https://github.com/dotnet/arcade build
20190214.4 (#22621)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19114.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19114.4
Stephen Toub [Fri, 15 Feb 2019 16:05:07 +0000 (11:05 -0500)]
Remove CoreLib's src\Interop\Windows directory (#22622)
It contains only one file with an interop signature that's not actually being used. Deleting the dup.
Jan Kotas [Fri, 15 Feb 2019 08:11:29 +0000 (00:11 -0800)]
Fix CoreFX build breaks
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Tanner Gooding [Fri, 15 Feb 2019 06:24:40 +0000 (22:24 -0800)]
Fixing the number formatting code to only recognize 'R' for double/float. (#22613)
Marek Safar [Fri, 15 Feb 2019 02:28:01 +0000 (03:28 +0100)]
Move Reflection.Emit Tokens to shared partition (#22602)
Grant [Fri, 15 Feb 2019 02:21:52 +0000 (18:21 -0800)]
Missed optimization from #22497
Egor Chesakov [Fri, 15 Feb 2019 01:26:18 +0000 (17:26 -0800)]
Remove unnecessary ProjectReferences to CoreCLRTestLibrary (#22539)
Remove the ProjectReferences to CoreCLRTestLibrary.csproj in the project files where CoreCLRTestLibrary is not actually being used.
Each ProjectReference item is ended up in PrepareProjectReferences target that creates unnecessary items.
David Wrighton [Fri, 15 Feb 2019 01:07:14 +0000 (17:07 -0800)]
Replace multi-loaderallocator hash implementation in MethodDescBackpatchInfo (#22285)
* GCHeapHash
- Hashtable implementation for runtime use
- Implementation written in C++
- Data storage in managed heap memory
- Based on SHash design, but using managed memory
CrossLoaderAllocatorHash
- Hash for c++ Pointer to C++ pointer where the lifetimes are controlled by different loader allocators
- Support for add/remove/visit all entries of 1 key/visit all entries/ remove all entries of 1 key
- Supports holding data which is unmanaged, but data items themselves can be of any size (key/value are templated types)
* Swap MethodDescBackpatchInfo to use the CrossLoaderAllocatorHash
* The MethodDescBackpatchCrst needs to be around an allocation
- Adjust the Crst so that it can safely be used around code which allocates
- Required moving its use out from within the EESuspend logic used in rejit
Filip Navara [Thu, 14 Feb 2019 23:02:20 +0000 (00:02 +0100)]
Remove unnecessary fields from WaitHandle (#22593)
* Remove unnecessary fields from WaitHandle
* Drop volatile from _waitHandle
* Address race condition in unmanaged code
* Remove unused hasThreadAffinity parameters
* Fix FCDECL argument counts
Eugene Rozenfeld [Thu, 14 Feb 2019 22:43:26 +0000 (14:43 -0800)]
Fix check for memory containment safety. (#22563)
This change ensures that if an operand can produce an exception
and any instructions executed after the operand evaluation but before
the operand's parent can also produce an exception, the operand
shouldn't be contained. The reason is that in this case operand
containment may reorder exceptions.
With `strict` set to true the containment is blocked here:
https://github.com/dotnet/coreclr/blob/
d27fff3f65193dd71c6197e9876101f496bbd28b/src/jit/sideeffects.cpp#L485-L488
Also, make the check for ordering side-effect interference less
conservative.
Fixes #22556.
Juan Hoyos [Thu, 14 Feb 2019 21:52:10 +0000 (13:52 -0800)]
Revert signing to fixed version (#22609)
SPC signing got broken when #22544 unpinned the SignTool version. Pin the tool version again until issue gets fixed.
@jashook
Grant [Thu, 14 Feb 2019 21:51:03 +0000 (13:51 -0800)]
Consolidate implementation of Rotate and PopCount (#22584)
* Perf: BitOps.LeadingZeroCount
* Remove redundant MSIL cast, conv.u8
* Use local functions for SoftwareFallback
* Target BIT32/64
Stephen Toub [Wed, 13 Feb 2019 22:58:52 +0000 (17:58 -0500)]
Adjust corert for shared SafeHandle and EventRegistrationToken
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Wed, 13 Feb 2019 19:49:15 +0000 (14:49 -0500)]
Fix netfx build break in Microsoft.Diagnostics.Tracing.EventSource.Redist
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Marek Safar [Thu, 14 Feb 2019 20:14:52 +0000 (21:14 +0100)]
Move FrameworkEventSource to shared partition (#22507)
* Move FrameworkEventSource to shared partition
and remove unused code
* Remove more unused code
* Remove CA8001 suppress message
Sinan Kaya [Thu, 14 Feb 2019 19:06:57 +0000 (14:06 -0500)]
Gnuport cleanup 3 (#22581)
* Reorder extern "C" and visibility statements
In file included from coreclr/src/pal/inc/pal.h:70:0,
coreclr/src/pal/inc/pal_mstypes.h:30:25: error: expected unqualified-id
before string constant
#define EXTERN_C extern "C"
^
coreclr/src/pal/inc/rt/palrt.h:216:30: note:
in expansion of macro 'EXTERN_C'
#define STDAPI_(type) EXTERN_C type STDAPICALLTYPE
* Need double quotes around single quotes in error statements
fix error statements
Can't have ' character in error statement
* Abstract __declspec(noinline)
Generate compiler independent macros for noinline request.
* Remove unused DBG_NOINLINE_X86__RET_INLINE
* Abstract __declspec(nothrow)
Levi Broderick [Thu, 14 Feb 2019 19:00:02 +0000 (11:00 -0800)]
Add Rune creation API from UTF-16 surrogate pair (#22590)
Also brings in some perf improvements to existing char and UnicodeUtility APIs
dotnet-maestro[bot] [Thu, 14 Feb 2019 18:29:06 +0000 (13:29 -0500)]
Update dependencies from https://github.com/dotnet/arcade build
20190213.1 (#22594)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19113.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19113.1
Egor Chesakov [Thu, 14 Feb 2019 16:20:06 +0000 (08:20 -0800)]
Add coreclr-outerloop build definition jobs (#22578)
Egor Chesakov [Thu, 14 Feb 2019 16:17:52 +0000 (08:17 -0800)]
Don't use $(_HelixSource) and $(_HelixType) in test-job.yml (#22589)
Michal Strehovsky [Wed, 13 Feb 2019 12:45:42 +0000 (04:45 -0800)]
Annotate PlatformID as a moved type
This should have been annotated along with the rest in dotnet/corert#6928 but I missed it.
[tfs-changeset: 1733685]
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Andrew Au [Tue, 29 Jan 2019 21:46:30 +0000 (13:46 -0800)]
Improving an assert in fgInsertInlineeBlocks
Juan Hoyos [Thu, 14 Feb 2019 02:14:35 +0000 (18:14 -0800)]
Use dependency flow for core-setup and corefx dependencies (#22544)
* Remove old use of signing package used to work around SPC signing now that arcade has bubbled up the version.
* Move dependency update for CoreFX and Core-setup dependencies to BAR/Darc/Maestro++ flow
* Update property references in tests.
* Version bump for CoreFX and Core-Setup dependencies.
* Update test Github_20958 to use revised System.Range constructor as surface area changed with #22331.
Carol Eidt [Thu, 14 Feb 2019 00:30:44 +0000 (16:30 -0800)]
Merge pull request #22327 from BrianBohe/refactoring_genCodeForBBList
Moving structures initialization before generating code for blocks to…
Jeremy Koritzinsky [Wed, 13 Feb 2019 23:52:35 +0000 (15:52 -0800)]
Remove Marshaling MDA (#22579)
Remove the "marshaling" MDA. In .NET Framework it was off by default and in .NET Core it was commented out in the boilerplate file. Additionally, from what I can tell only half of its functionality was ever implemented in .NET Core.
Contributes to #22538.
Aaron Robinson [Wed, 13 Feb 2019 23:04:59 +0000 (15:04 -0800)]
Remove some CAS cruft (#22576)
* Update comment on SuppressUnmanagedCodeSecurityAttribute.
* Remove unused declsec.h header.
Grant [Wed, 13 Feb 2019 22:17:01 +0000 (14:17 -0800)]
Perf: Consolidate implementation of LeadingZeroCount (#22497)
* Perf: BitOps.LeadingZeroCount
* CR fix
* CR fixes
* Optimization
* Revert
* Confirmed fix
* Simplify
* Return int
* Fixes
* Simplify
* CR fixes
* CR fixes
* Fix unit failure on Linux-musl x64 Debug
* CR fixes
* CR fixes
* Cleanup
Sergey Andreenko [Wed, 13 Feb 2019 20:15:10 +0000 (12:15 -0800)]
Fix comment placement. (#22580)
Brian Bohe [Wed, 13 Feb 2019 19:26:49 +0000 (11:26 -0800)]
Moving structures initialization before generating code for blocks to other function
Stephen Toub [Wed, 13 Feb 2019 18:43:13 +0000 (13:43 -0500)]
Replace Win32Native.cs with Interop files (#22540)
* Replace Win32Native.cs with Interop files
- Replace Win32Native usage with existing Interop.* calls where they already existed
- Moved Win32Native.* to their own files otherwise, and changed call sites
- Left a stub Win32Native in place to handle some emitted IL from the runtime. The current infrastructure doesn't support targeting nested types, like Interop.Kernel32, and fixing that would be more involved.
* Remove Win32Native.cs
Replace emitted calls with ones to Marshal.
* Fix incorrectly changed field
* Fix Kernel32 -> Ole32
Stephen Toub [Wed, 13 Feb 2019 16:12:10 +0000 (11:12 -0500)]
Move SafeHandle to managed code and shared (#22564)
* Move SafeHandle to managed code and shared
This moves the implementation of SafeHandle from native code in the runtime to managed. I used corert's implementation as a base, and reviewed it again against the existing native implementation, making a few tweaks to better match the existing semantics.
This should be a valid move because of the reduced goals around CERs, thread aborts, etc.
However, there are places in the runtime that access SafeHandle functionality via its native counterpart, so I kept the relevant pieces of the native code intact. Most code will continue to use the managed APIs, but the runtime can continue calling into the native versions when needed.
* Address PR feedback
* Address PR feedback
dotnet-maestro[bot] [Wed, 13 Feb 2019 16:10:48 +0000 (11:10 -0500)]
Update dependencies from https://github.com/dotnet/arcade build
20190212.3 (#22568)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19112.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19112.3
Stephen Toub [Wed, 13 Feb 2019 16:10:31 +0000 (11:10 -0500)]
Move EventRegistrationToken to shared (#22565)
* Move EventRegistrationToken to shared
* Address PR feedback
Tanner Gooding [Wed, 13 Feb 2019 15:36:57 +0000 (07:36 -0800)]
Fixing the double/float formatting code to use a fallback precision for custom-format strings. (#22522)
Juan Hoyos [Wed, 13 Feb 2019 14:30:34 +0000 (06:30 -0800)]
Fix gen-buildsys-win for vs2019 x86 (#22567)
Ben Adams [Wed, 13 Feb 2019 14:20:44 +0000 (14:20 +0000)]
Improve SpanHelpers.Byte (#22503)
Carol Eidt [Wed, 13 Feb 2019 04:49:56 +0000 (20:49 -0800)]
Fix min-opts spill of tree temp large vectors (#22530)
* Fix min-opts spill of tree temp large vectors
Even if we're not enregistering local vars, we may have large vectors live across a call that need to be spilled.
Fix #22200
Brian Bohe [Wed, 13 Feb 2019 01:22:35 +0000 (17:22 -0800)]
Refactoring siVarLoc creation (#22543)
* Moving siVarLoc and siVarLocType from compiler.h to CodeGenInterface.h
* Encapsulating siVarLoc construction with siScope and LclVarDsc
* Encapsulating siVarLoc construction from psiScope
* Adding some argument description on genSetScopInfo header
* Changing const siVarLoc& to const siVarLoc* on eeSetLVInfo
* Changing siVarLoc& to siVarLoc* in genSetScopeInfo arguments
* Rename var in genSetScopeInfo header
Jan Kotas [Tue, 12 Feb 2019 06:33:34 +0000 (22:33 -0800)]
Fix CoreRT build breaks - Adjust resource name - Workaround C# compiler/analyzer bug
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Eugene Rozenfeld [Tue, 12 Feb 2019 22:43:14 +0000 (14:43 -0800)]
Fix exception sets for indirections in value numbering. (#22542)
fgValueNumberAddExceptionSetForIndirection had a bug
where INDIR(ADD(x, <big_offset>)) had NullReferenceException(x)
added instead of NullReferenceException(ADD(x, <big_offset>)).
Fixes #20358.
Jarret Shook [Tue, 12 Feb 2019 22:38:27 +0000 (14:38 -0800)]
Enable arm64 linux musl builds (#22495)
* Enable arm64 linux musl builds
Note that -clang5.0 is required to be passed.
* Fix syntax error
* Pass clang arg to build-test.sh
José Rivero [Tue, 12 Feb 2019 21:54:33 +0000 (13:54 -0800)]
Bug Fix: Calling System.Diagnostics.Tracing.EventPipe.Enable twice asserts #22247 (#22318)
After disabling EventPipe -> SampleProfiler, we were not closing the thread shutdown event, thus asserting on reentrance of the EventPipe.
* Adding regression test, and removing comment.
* Waits until the specified object is in the signaled state.
Sung Yoon Whang [Tue, 12 Feb 2019 19:53:39 +0000 (11:53 -0800)]
Renaming RuntimeEventSource to NativeRuntimeEventSource (#22533)
* Renaming RuntimeEventSource to NativeRuntimeEventSource
* missed a couple of comments and XPlatEventLogger
* rename DotNETRuntimeEventSource.cs to NativeRuntimeEventSource.cs
* use condition= instead of ifdef
* removing ifdef from NativeRuntimeEventSource.cs
* Fix case for 'eventing' directory in csproj
* Fix unix builds
* This should fix unix build...
Aditya Mandaleeka [Tue, 12 Feb 2019 18:20:35 +0000 (10:20 -0800)]
Enable portable fast alloc helpers on ARM64 Windows. (#22541)
Tanner Gooding [Tue, 12 Feb 2019 17:28:02 +0000 (09:28 -0800)]
Add extensions methods for several of the VectorXXX<T> helper methods (#22336)
* Moving several of the Vector128<T> instance methods to be extension methods.
* Moving several of the Vector256<T> instance methods to be extension methods.
* Moving several of the Vector64<T> instance methods to be extension methods.
Michal Strehovský [Tue, 12 Feb 2019 12:45:47 +0000 (13:45 +0100)]
Ifdef out code that triggers UTC bug (dotnet/corert#7003)
This results in bad codegen on AMD64. I filed a bug internally; hopefully we can get a fix soon.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Aaron Robinson [Tue, 12 Feb 2019 16:33:58 +0000 (08:33 -0800)]
Update COM Activator class (#22317)
* Update COM Activator to use ALCs
* Update tests to now supply an assembly name rather than an binary "path"
since the COM activator is now using ALCs.
* Add test for non-rooted assembly path.
* Move the hostpolicy mock project to a Common area
Move hostpolicy mock API to CoreCLR test library
* Add test for COM server isolation
* Move ComActivator class and logic to Internal namespace.