Lakshmi Priya Sekar [Fri, 8 Sep 2017 00:25:33 +0000 (17:25 -0700)]
Move DefaultCredentialsTest to windows only.
Commit migrated from https://github.com/dotnet/corefx/commit/
d961c15b20539f5638953e9506d35f49d038237a
Lakshmi Priya Sekar [Thu, 7 Sep 2017 22:20:41 +0000 (15:20 -0700)]
Remove duplicate bug ids in source code.
Commit migrated from https://github.com/dotnet/corefx/commit/
22c66999a49f73002f8e6b04e54c10c7e5f2fe15
Lakshmi Priya Sekar [Thu, 7 Sep 2017 18:18:43 +0000 (11:18 -0700)]
Consolidate code between different Http handlers.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ef59053709ef8b6f5b30b709bffbe38fcb19823
Lakshmi Priya Sekar [Wed, 6 Sep 2017 00:59:17 +0000 (17:59 -0700)]
Use only CredentialCache when redirecting Uris in ManagedHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
9d5f5d1f8630e3c50404647926496b0d45cf1203
José Rivero [Wed, 6 Sep 2017 00:39:16 +0000 (17:39 -0700)]
Moving the Windows Performance runs from Server 2012 to Server 2016. (dotnet/corefx#23714)
Commit migrated from https://github.com/dotnet/corefx/commit/
06b1365d9881ed26a921490d7edd2d4e4de35565
Viktor Hofer [Tue, 5 Sep 2017 23:34:07 +0000 (01:34 +0200)]
Fixing uap serialization errors for exceptions (dotnet/corefx#23808)
* Fixing uap serialization errors for exceptions
* pr changes
* Revert two updated blobs
Commit migrated from https://github.com/dotnet/corefx/commit/
c89b4fb5050d9ca3de86dddce7fe3fd9dc34dc33
lajones [Tue, 5 Sep 2017 22:07:21 +0000 (15:07 -0700)]
Merge pull request dotnet/corefx#23581 from JonHanna/annotation_refactor
Some refactoring in System.ComponentModel.DataAnnotations
Commit migrated from https://github.com/dotnet/corefx/commit/
7269a3b3cd0873d85cd93ba7435d15887fac2fd2
Tarek Mahmoud Sayed [Tue, 5 Sep 2017 22:03:06 +0000 (15:03 -0700)]
Enable detecting Red Hat distors in PlatformDetection (dotnet/corefx#23775)
* Enable detecting Red Hat distors in PlatformDetection
* Add RedHat properties to PlatformDetection class
Commit migrated from https://github.com/dotnet/corefx/commit/
f0a9551d38ddf76a02c4c65cce74559263466ddd
Gene Lee [Tue, 5 Sep 2017 21:00:09 +0000 (14:00 -0700)]
Fix connection pool & connection pool group fragmentation (dotnet/corefx#23722)
Commit migrated from https://github.com/dotnet/corefx/commit/
4839aaf6dbbf2d453b9c27283325e0df90db5f5d
Jon Hanna [Tue, 5 Sep 2017 20:48:09 +0000 (21:48 +0100)]
Remove code in Microsoft.CSharp for casting from method groups. (dotnet/corefx#23371)
As a method group cannot be cast to object, the casting from method
group to delegate that can be done in static code is not relevant, and
code related to such casts is never reached.
Remove it. Includes removal of ExprFuncPtr, and ERR_MethGrpToNonDel,
ERR_BadRetType, ERR_DelegateOnNullable & ERR_BadDelegateConstructor,
contributes to dotnet/corefx#22470
Commit migrated from https://github.com/dotnet/corefx/commit/
ac9ccd4f02e0c4f2c887618048bcca4c33c89200
Santiago Fernandez Madero [Tue, 5 Sep 2017 20:30:09 +0000 (13:30 -0700)]
Add BinPlaceConfiguration for test projects to have a working directory per BuildConfiguration (dotnet/corefx#23633)
* With this change we will have the next behavior when building/running tests:
-When building the tests we will still bin place the test assets to the OutputDirectory (corefx\bin\OSGroup.Configuration\TestProject\TargetGroup/)
-When running the tests we will bin place the tests assets to this new TestPath which will be the TestPath. This new path will be the test's working directory where we will bin place the RunTests.cmd and necessary dependencies in tests.targets. Also the testResults.xml will be found here after the test execution.
-TestPath is set to be bin/tests/<TestProject>/<BuildConfiguration>/ (i.e corefx\bin\tests\System.Collections.Immutable.Tests\netcoreapp-Windows_NT-Debug-x64) in dir.props
-This TestPath will be added to the BinPlaceDir in FrameworkTargeting.targets when BinPlaceTest is set to true. Then in the BinPlaceFiles target the test assets will be hardlinked to the TestPath.
This will isolate every test execution per build configuration and will allow people to run the same test project for all of the supported configurations on the same repo without having to clean the repo.
Commit migrated from https://github.com/dotnet/corefx/commit/
664ca9508a03483a7fb2714b55b9cba885593d90
Jon Hanna [Tue, 5 Sep 2017 20:29:54 +0000 (21:29 +0100)]
Remove Microsoft.CSharp's checks on pointer or static type parameters. (dotnet/corefx#23286)
Since types come from live instances, and pointer operations are
already prohibited, this case can't come up.
Entails removal of ERR_BadTypeArgument and ERR_GenericArgIsStaticClass,
contributes to dotnet/corefx#22470
Commit migrated from https://github.com/dotnet/corefx/commit/
23cd62dfaf37712c4acf765e9b21914f848e0d84
Jon Hanna [Tue, 5 Sep 2017 20:25:39 +0000 (21:25 +0100)]
Remove unused properties from ErrorType (dotnet/corefx#23248)
* Remove parent parameter to CreateError and pParentType to GetErrorType
Only ever called with null; the one path that sets it to something else
only being hit if another ErrorType instance had it set to something
else, and so never happening.
* Remove TypeParent from ErrorType
Never not null
* Remove by-parent-type lookup for ErrorType instances.
Never used.
* Remove ErrAppendParentType
If called with an ErrorType calls ErrAppendParentCore which returns immediately if the namespace parent is either null or the rootNS, which is the only two possibilities.
As such it's always an no-op, so remove that call. Since this is the only call existing, remove entirely.
* Remove namespace parameter from LookupError and InsertError
Always the root namespace, so doesn't affect lookup.
* Make HasParent a simple boolean property.
Since the namespace, if set, is always the same one, and not examined beyond whether it is set, it's essentially a flag.
* Determine ErrorType.HasParent by whether nameText is null.
Always false if it's null, true otherwise, so use that as the storage.
* Add explanatory comment.
Commit migrated from https://github.com/dotnet/corefx/commit/
10a76752c95853ed74297fa817ff897ad389e3d8
Stephen Toub [Tue, 5 Sep 2017 17:04:59 +0000 (13:04 -0400)]
Fix behavior of Dns.GetHost* with empty string (dotnet/corefx#23794)
On Windows, passing an empty string to gethostbyname/GetAddrInfoW results in the host's information being used; that behavior then bubble's up through (and is documented for) the Dns.GetHost* APIs in .NET. On Unix, the native functions being used don't provide that same behavior, instead returning an error.
This just special-cases empty string in the Unix implementation.
Commit migrated from https://github.com/dotnet/corefx/commit/
e9bd4c87e5032184c51ba03b81ef74328bbdfb1a
Tom Deseyn [Tue, 5 Sep 2017 16:53:36 +0000 (18:53 +0200)]
Truncate sendmsg/recvmsg to IOV_MAX (dotnet/corefx#23781)
* Truncate sendmsg/recvmsg to IOV_MAX
* PR feedback
* Remove newline
Commit migrated from https://github.com/dotnet/corefx/commit/
b15aab8a6fa286585da10f3f4c017852f89edbd7
Stephen Toub [Tue, 5 Sep 2017 16:51:14 +0000 (12:51 -0400)]
Increase allowed timeout range in SendTimesOut_Throws (dotnet/corefx#23803)
Commit migrated from https://github.com/dotnet/corefx/commit/
3b09025f61de5963596f7f978eb991d5bf55ef98
Matt Mitchell [Tue, 5 Sep 2017 16:15:38 +0000 (09:15 -0700)]
Re-enable retrying checkout (dotnet/corefx#23801)
Patching the Windows OS seems to have resolved the checkout hangs. It appeared to have been hanging in some Windows filesystem code. It also may have been because of git performance issues in 2.11+ when fetching large numbers of refs, which was resolved by a recent change to only fetch the ref relevant to the current PR.
Commit migrated from https://github.com/dotnet/corefx/commit/
0cf06a47a2181bab69b6801fc56564420e4e8844
Stephen Toub [Tue, 5 Sep 2017 15:53:23 +0000 (11:53 -0400)]
Disable several StackFrameTests on netfx (dotnet/corefx#23798)
Commit migrated from https://github.com/dotnet/corefx/commit/
eaa8af681f1c54f6f0f47d7bb0b99f8c217a569a
Stephen Toub [Tue, 5 Sep 2017 15:53:03 +0000 (11:53 -0400)]
Disable several DirectoryServices tests failing OuterLoop in CI (dotnet/corefx#23802)
Commit migrated from https://github.com/dotnet/corefx/commit/
b48660cee3031c873bbdbb3693fe242ead29b433
Jan Vorlicek [Tue, 5 Sep 2017 15:19:02 +0000 (17:19 +0200)]
Remove unused SSLv3_method (dotnet/corefx#23791)
This API is not used anymore, so remove it from the openssl shim.
Commit migrated from https://github.com/dotnet/corefx/commit/
53a72a7b2982df243028ae08c5d07e63bc52ab0c
Stephen Toub [Sun, 3 Sep 2017 23:07:47 +0000 (19:07 -0400)]
Enable disabled HttpClientEKUTests on ManagedHandler (dotnet/corefx#23754)
They appear to all be passing now.
Commit migrated from https://github.com/dotnet/corefx/commit/
2443b0d5f2a25f9c619aff9dca8ec2625eba1c96
David Shulman [Sun, 3 Sep 2017 12:57:12 +0000 (05:57 -0700)]
Merge pull request dotnet/corefx#23772 from davidsh/disable_networking
Disable some networking tests
Commit migrated from https://github.com/dotnet/corefx/commit/
20fbf6cc1110ed30832b2f67fdb84f0fd37c268a
David Shulman [Sat, 2 Sep 2017 23:50:54 +0000 (16:50 -0700)]
Disable some networking tests
Disabling tests.
dotnet/corefx#23765 dotnet/corefx#23766 dotnet/corefx#23767 dotnet/corefx#23768 dotnet/corefx#23769 dotnet/corefx#23770 dotnet/corefx#23771
Commit migrated from https://github.com/dotnet/corefx/commit/
acafae51592f7e09fba003a3684d550dba155a2e
David Shulman [Sat, 2 Sep 2017 23:33:45 +0000 (16:33 -0700)]
Merge pull request dotnet/corefx#23752 from davidsh/22735_1
Re-enable HTTP/2 test
Commit migrated from https://github.com/dotnet/corefx/commit/
e35c540f90daa70604d54df72223ce11cb230cea
Cory Rivera [Sat, 2 Sep 2017 05:54:29 +0000 (22:54 -0700)]
Rollback UDT changes to SqlDataReader.GetValue() and GetSqlValue(), since they are expected to throw PlatformNotSupportedExceptions with UDTs. (dotnet/corefx#23723)
Commit migrated from https://github.com/dotnet/corefx/commit/
cd610ce6a3493b8b089a63d19ae1e1dcd2b78f2a
Eric Mellino [Fri, 1 Sep 2017 23:18:04 +0000 (16:18 -0700)]
Disable all Graphics.CopyFromScreen tests -- they are unstable. (dotnet/corefx#23761)
Commit migrated from https://github.com/dotnet/corefx/commit/
b9d22c687f4d0282509bb127dcf41fb3cb778932
Dan Moseley [Fri, 1 Sep 2017 23:16:20 +0000 (16:16 -0700)]
Disable RecursiveDelete_DeepNesting for desktop (dotnet/corefx#23757)
Commit migrated from https://github.com/dotnet/corefx/commit/
499e099dc8e9e8495b602a623c96c8695d5a4d53
Eric Mellino [Fri, 1 Sep 2017 22:58:01 +0000 (15:58 -0700)]
Merge pull request dotnet/corefx#23755 from mellinoe/system.drawing-reenable-systemfonts-test
Re-enable SystemFonts test on Linux.
Commit migrated from https://github.com/dotnet/corefx/commit/
97e61e05faff624fae646d080985b9827079be2a
Justin Van Patten [Fri, 1 Sep 2017 22:01:18 +0000 (15:01 -0700)]
XmlJsonWriter: Avoid unnecessary allocations (dotnet/corefx#23736)
* XmlJsonWriter: Avoid unnecessary allocations
While it only runs once to initialize a readonly static field,
`CreateEscapedJsonStringTable` was allocating a lot of unnecessary
garbage. For each char in the table, either 2 box allocations for the
`string.Concat(object, object)` call, or 1 box allocation plus
`string.Format` overhead. These unnecessary allocations can be avoided
by just pre-generating the table.
* Add more DataContractJsonSerializer tests
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
62d27daf94f0131350c6ae32fcafc2bbd4306626
Eric StJohn [Fri, 1 Sep 2017 21:06:57 +0000 (14:06 -0700)]
Merge pull request dotnet/corefx#23719 from ericstj/rollBackRefAssmVerInbox
Fix library packages overlapping with framework packages
Commit migrated from https://github.com/dotnet/corefx/commit/
35e0a7fcc693dbb73996e8dae5d8841a4ba00d6f
Justin Van Patten [Fri, 1 Sep 2017 20:57:17 +0000 (13:57 -0700)]
System.Net.Http: Remove unnecessary null validator check (dotnet/corefx#23675)
A null validator is never passed-in when creating `ObjectCollection<T>`
instances internally, so we can avoid the unnecessary null checks.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa71a8d698df216b625391198b726e06b5232459
Eric Mellino [Fri, 1 Sep 2017 20:01:06 +0000 (13:01 -0700)]
Re-enable SystemFonts test on Linux.
Commit migrated from https://github.com/dotnet/corefx/commit/
73a24420e37ef6e1f1bc66992721d5f0146d862b
Eric Mellino [Fri, 1 Sep 2017 19:52:10 +0000 (12:52 -0700)]
Merge pull request dotnet/corefx#23747 from mellinoe/system.drawing-unify-icon
Fix up Unix Icon implementation and enable more tests
Commit migrated from https://github.com/dotnet/corefx/commit/
2c73b4aef4f1feb47f73b3ab80b0ae3e63f7485b
David Shulman [Fri, 1 Sep 2017 19:33:26 +0000 (12:33 -0700)]
Re-enable HTTP/2 test
Turning back on the HTTP/2 test that relied on www.microsoft.com being
HTTP/2 now that the HTTP/2 server farm processing those requests is
working again.
Fixes dotnet/corefx#22735
Commit migrated from https://github.com/dotnet/corefx/commit/
169daaad2062ab623fdafa738c3fdbc778d3652e
Eric Mellino [Fri, 1 Sep 2017 18:55:13 +0000 (11:55 -0700)]
Respond to PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
99d2e2d2444eabd2ddca52906d2527a7bb7028c3
Eric Mellino [Fri, 1 Sep 2017 18:03:35 +0000 (11:03 -0700)]
Throw several more exceptions for compat in Icon.Unix.cs. Re-enable tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
6420325e176d3bfe026afab018d3674567fd7682
Matt Mitchell [Fri, 1 Sep 2017 16:09:50 +0000 (09:09 -0700)]
[DO NOT MERGE] Remove retry to attempt to track down cloning hangs (dotnet/corefx#23709)
Remove retry to remove cloning hangs
Commit migrated from https://github.com/dotnet/corefx/commit/
bb074ddd44b21fefb704778bda7e0054c39ffe6e
Eric St. John [Fri, 1 Sep 2017 16:02:43 +0000 (09:02 -0700)]
Avoid downgrading from runtime to IL implementations
Both System.Buffers and System.Memory have fast/shared implementations in the core
assembly. Make sure we don't degrade to using the IL copy just because a newer build
is installed.
Commit migrated from https://github.com/dotnet/corefx/commit/
75962dae7f338445b57d7d276d018774e1dd2e46
Eric St. John [Thu, 31 Aug 2017 22:02:51 +0000 (15:02 -0700)]
Fix library packages overlapping with framework packages
Many library packages overlap with assemblies we include in our framework packages.
In the first release we handled this by preventing the library package from applying any
assets.
This becomes problematic if the reference assembly needs to version, and especially
if the library wants to add API. The new version will be greater than what was previously
shipped inbox, and we wouldn't want to restrict the new version just to future TFMs.
To address this problem I've made a couple fixes:
1. For packages which are shipping brand new API that's not present in desktop, we'll
omit any placeholders and allow conflict resolution to decide if the library package
or framework package should be used (based on version). In some cases this required
bringing some configurations into the package so that it could always be "up to date".
2. For packages which are just exposing API in desktop, and thus already tied/anchored
to netstandard versions, we'll freeze the reference assembly version for the non-desktop
builds. This ensures that the reference assembly will never move past the version that's
inbox in the framework package.
Update BuildToolsVersion to 2.0.0-prerelease-01931-01
Commit migrated from https://github.com/dotnet/corefx/commit/
7ee51be7ed472a12266c8cc2ab25a9e1862c1d00
dotnet-maestro-bot [Fri, 1 Sep 2017 14:47:30 +0000 (07:47 -0700)]
Update CoreClr, CoreFx, Standard to preview2-25701-02, preview2-25701-02, preview1-25701-01, respectively (dotnet/corefx#23740)
Commit migrated from https://github.com/dotnet/corefx/commit/
b400e4a82e9f6a06f8661e30bde79d1c3ca69634
Adrian Godong [Fri, 1 Sep 2017 13:31:17 +0000 (06:31 -0700)]
Moved all StringAsSpanXXX tests to AsReadOnlySpan.cs (dotnet/corefx#23728)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b4dd30e4f13061c4ba2e7fa010cc9ad4d103633
Justin Van Patten [Fri, 1 Sep 2017 13:26:52 +0000 (06:26 -0700)]
Avoid unnecessary string[] allocation (dotnet/corefx#23729)
Previously this was concatenating a string and then passing the result
to `String.Concat(params string[])`, resulting in an unnecessary
`string[]` allocation.
Commit migrated from https://github.com/dotnet/corefx/commit/
910af7b6e74cd9bdc3c774125296ec9fdf517de6
dotnet-maestro-bot [Fri, 1 Sep 2017 12:26:13 +0000 (05:26 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25701-00, beta-25701-00, respectively (dotnet/corefx#23732)
Commit migrated from https://github.com/dotnet/corefx/commit/
9c8f9e2065664a441a9316ee65d8d8bf65a0d033
Santiago Fernandez Madero [Fri, 1 Sep 2017 07:18:59 +0000 (00:18 -0700)]
Port rollback of System.IO DCR from release branch to master (dotnet/corefx#23566)
* Port rollback of System.IO DCR from release branch to master
Commit migrated from https://github.com/dotnet/corefx/commit/
7f1c480a6a280fbced29606120b507596bafbefc
dotnet-maestro-bot [Fri, 1 Sep 2017 03:14:25 +0000 (20:14 -0700)]
Update CoreFx, CoreSetup to preview2-25701-01, preview2-25631-02, respectively (dotnet/corefx#23724)
Commit migrated from https://github.com/dotnet/corefx/commit/
8a41dac1874124bbc0e1f8b4c01d778528c05b6e
Cory Rivera [Fri, 1 Sep 2017 00:18:10 +0000 (17:18 -0700)]
Enable SqlDataReader.GetValue() and GetSqlValue() for UDT types. (dotnet/corefx#23718)
Commit migrated from https://github.com/dotnet/corefx/commit/
2b790aa855ef28c84711f4c8f8fc9e630548b207
Eric Mellino [Fri, 1 Sep 2017 00:05:07 +0000 (17:05 -0700)]
Throw ArgumentNullException in Icon.ExtractAssociatedIcon.
Commit migrated from https://github.com/dotnet/corefx/commit/
4a1d546b01f4fbfb1bf263246c1ac0348b96068a
Eric Mellino [Thu, 31 Aug 2017 23:59:15 +0000 (16:59 -0700)]
Throw ObjectDisposedException in Icon.Handle.
Commit migrated from https://github.com/dotnet/corefx/commit/
fb9ac9bf8cbd98385276c533b946a8f23433b122
Eric Mellino [Thu, 31 Aug 2017 23:54:18 +0000 (16:54 -0700)]
Throw ArgumentException instead of FileNotFoundException in Icon resource constructor.
Commit migrated from https://github.com/dotnet/corefx/commit/
1e1eaebe86033ad7817e8845a063a251e2da5666
Maryam Ariyan [Thu, 31 Aug 2017 23:52:31 +0000 (19:52 -0400)]
Added GetAssemblyName API for AssemblyDefinition and AssemblyReference (dotnet/corefx#23396)
* Added GetAssemblyName API to MetadataReader
Also added GetAssemblyName API to AssemblyReference and
AssemblyDefinition
* Adding more changes
Removing unnecessary usings in StringUtils and StringUtilsTests
Adding private methods in MetadataReader to set flags and hashAlgorithm
* adding helper class for AssemblyName
* Removing helper class and simplifying flag setup
Adding sample unit tests. will add more in next changeset
* Correcting two impl. mistakes in GetAssemblyName()
Correcting EnableJITcompileOptimizer flag casting
Correcting flag casting mistake on AssemblyNameFlag
* new GetAssemblyName tests + fix for netstandard1.1
* applying the code review comments
* correcting public key computation and improving flag computation
* code cleanup in the AssemblyDefinitionTests class
* using AssemblyFlags.ContentTypeMask instead of magic number 0x0E00
* refactored tests + renamed files to netstandard2.1
* setting methods to private in test class
* added test validating assemblyname with publickey
added another test validating assemblyname with culture
applied some code review comments
* code cleanup in AssemblyDefinitionTests
* renaming new netstandard2.0 files to versionless netstandard
* further cleaning up test classes
Commit migrated from https://github.com/dotnet/corefx/commit/
146fd85208e0251a480318d419cdc178db350761
Eric Mellino [Thu, 31 Aug 2017 23:47:31 +0000 (16:47 -0700)]
Throw correct ArgumentNullException in Icon ctor. Re-enable test.
Commit migrated from https://github.com/dotnet/corefx/commit/
93065cde1aa816118022bb0ea54221576e1334eb
Eric Mellino [Thu, 31 Aug 2017 23:41:58 +0000 (16:41 -0700)]
Throw correct exception type in Icon ctor for null stream.
Commit migrated from https://github.com/dotnet/corefx/commit/
d378b8e3aea3294f89268ffc75ddfdaa5252d099
Eric Mellino [Thu, 31 Aug 2017 22:53:19 +0000 (15:53 -0700)]
Clean up dead code in Icon.Unix.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
5ebd90ca2cb833b84ae7d5cb22998061b7eab8cc
Eric Mellino [Thu, 31 Aug 2017 22:35:45 +0000 (15:35 -0700)]
Move Unix Icon into regular folder structure.
Also, remove its ISerializable implementation, as required.
Commit migrated from https://github.com/dotnet/corefx/commit/
21173b47621d5519f45a0a1546bcb38f4feb33c1
Stephen Toub [Thu, 31 Aug 2017 21:42:18 +0000 (17:42 -0400)]
Merge pull request dotnet/corefx#23712 from stephentoub/ipaddress_parse_fix
Fix IPv6 address parsing when last number is too long
Commit migrated from https://github.com/dotnet/corefx/commit/
5b4aea4dec6729c6c2887c93946994727a2c8d80
Stephen Toub [Thu, 31 Aug 2017 21:41:55 +0000 (17:41 -0400)]
Expose/test span-based Version methods (dotnet/corefx#23338)
Commit migrated from https://github.com/dotnet/corefx/commit/
f2584d288fa6eec1ebbcdcb21740a22d409af255
Geoff Kizer [Thu, 31 Aug 2017 21:33:28 +0000 (14:33 -0700)]
Merge pull request dotnet/corefx#23694 from Drawaes/MinorSslStreamTweaks
SslStream - Making the reset buffer logic clearer
Commit migrated from https://github.com/dotnet/corefx/commit/
0a8cbad8b8ac259ed60a1a160277849475b914bb
Stephen Toub [Thu, 31 Aug 2017 20:37:36 +0000 (16:37 -0400)]
Merge pull request dotnet/corefx#23563 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25631-03, preview2-25631-02, preview2-25631-01, beta-25627-00, beta-25630-04, beta-25630-04, preview1-25631-01, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
a1050c9ae912d0944cff1ec1b0af830da8dc9266
Jan Kotas [Thu, 31 Aug 2017 19:33:34 +0000 (12:33 -0700)]
Fix UAP build break
S.R.WindowsRuntime is a friend with CoreLib. HResults definition in CoreLib has changed and it is
colliding local HResults definition in S.R.WindowsRuntime now.
Commit migrated from https://github.com/dotnet/corefx/commit/
1c502040a69bcd3a256131f6005feed36122926c
Stephen Toub [Thu, 31 Aug 2017 18:45:29 +0000 (14:45 -0400)]
Update AsSpan to AsReadOnlySpan to fix break with latest coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
f4b098d4170e74e84d1530f4a40d821fe0f97cda
dotnet-maestro-bot [Thu, 31 Aug 2017 17:45:29 +0000 (10:45 -0700)]
Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25631-03, preview2-25631-02, preview2-25631-01, beta-25627-00, beta-25630-04, beta-25630-04, preview1-25631-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
a25b6d066701f37b3a4198663f6226cb77990d30
Huangli Wu [Thu, 31 Aug 2017 18:28:30 +0000 (11:28 -0700)]
Improve Sgen package for better customer experience (dotnet/corefx#23348)
* Sgen Package improvement.
* move json file to test folder.
* Rename the binary. Use filestream only.
* delete old file
* Update the referencefromruntime
* Add json file for package
* fix the typo.
* Remove the unused lines.
Commit migrated from https://github.com/dotnet/corefx/commit/
fb66f3f61ff55ae1f0178571e54084d4157604a9
Stephen Toub [Thu, 31 Aug 2017 18:24:37 +0000 (14:24 -0400)]
Fix handling of last number in IPv6 address
A previous fix for mishandling of certain IPv6 addresses ended up introducing another bug, where we may fail to fail parsing on an address that has too many numbers in its last sequence. The issue is that, if the string doesn't end with ']', we're not looping around again in the parsing loop, where the beginning of the loop would see the sequence thus far as being too long and error out (the previous fix included removing the adding of a ']' if it didn't exist). The fix is just to do the check again at the end.
Commit migrated from https://github.com/dotnet/corefx/commit/
594c9a13ac8a704f80ae8c6cc978df711e5de6e9
Stephen Toub [Thu, 31 Aug 2017 18:10:53 +0000 (14:10 -0400)]
Fix IPAddress parsing tests for netfx
The recent PRs that added span-based APIs and tests for them inadvertently caused the IPAddress string parsing tests to not run on netfx. I've fixed them and removed a lot of unnecessary duplication.
Commit migrated from https://github.com/dotnet/corefx/commit/
31918c05ddf3648a1e226d065d50fd00337d1198
Stephen Toub [Thu, 31 Aug 2017 16:44:00 +0000 (12:44 -0400)]
Add IPv6 tests that validate failure of IPv4-as-IPv6 addresses
Commit migrated from https://github.com/dotnet/corefx/commit/
2186cd87366b5c02b095a491274ffe48aebafe1b
Stephen Toub [Thu, 31 Aug 2017 15:45:46 +0000 (11:45 -0400)]
Add IPAddress parsing cases for components being too long
Commit migrated from https://github.com/dotnet/corefx/commit/
52a1c7a0e45200231f2b4236769ae9c478cdd686
Brian Chavez [Thu, 31 Aug 2017 13:29:39 +0000 (06:29 -0700)]
Grammar check - "a [a,e]" rule. (dotnet/corefx#23697)
* Grammar check - "a [a,e]" rule.
* Corrected "a attributes" to "an attribute"
Commit migrated from https://github.com/dotnet/corefx/commit/
be75987c628347e1d44bba15c5272ade3dcfa65c
Drawaes [Thu, 31 Aug 2017 09:12:02 +0000 (10:12 +0100)]
Moved offset reset inside else branch in ResetReadBuffer
Commit migrated from https://github.com/dotnet/corefx/commit/
f795a0fd71dc2be3bb1b9b63269b3a982b04b38b
Eric Mellino [Thu, 31 Aug 2017 07:58:50 +0000 (00:58 -0700)]
Merge pull request dotnet/corefx#23693 from mellinoe/system.drawing-unify-stringformat-2
Unify implementations of StringFormat.
Commit migrated from https://github.com/dotnet/corefx/commit/
53ab4f27097da80a3a358389fbda3393f4fbcc7c
Brian Chavez [Thu, 31 Aug 2017 04:26:17 +0000 (21:26 -0700)]
Miscellaneous typo corrections. (dotnet/corefx#23698)
Commit migrated from https://github.com/dotnet/corefx/commit/
e3b2c5491ac38efdfec5f017f72223b7d8c10f5d
Eric Mellino [Wed, 30 Aug 2017 23:30:33 +0000 (16:30 -0700)]
Re-enable some StringFormatTests on Unix. Fix exception behavior in StringFormat.
Commit migrated from https://github.com/dotnet/corefx/commit/
ad1d00a3f956f878466697966ad368bcef2236fb
Eric Mellino [Wed, 30 Aug 2017 22:19:25 +0000 (15:19 -0700)]
Unify implementations of StringFormat.
Commit migrated from https://github.com/dotnet/corefx/commit/
15471d4110665a0bb971008c533884e1e57e609f
Eric Mellino [Wed, 30 Aug 2017 23:51:38 +0000 (16:51 -0700)]
Unify implementations of SystemFonts as much as possible. (dotnet/corefx#23668)
* Unify implementations of SystemFonts as much as possible.
* Add more basic tests for SystemFonts static property accessors.
* Mark a SystemFonts test as PlatformSpecific.
* Disable new SystemFonts test on Linux until fonts are installed on CI machines.
Commit migrated from https://github.com/dotnet/corefx/commit/
0b16938f178f4cb509b7cdd0737037439b8b7d8c
Drawaes [Wed, 30 Aug 2017 23:33:57 +0000 (00:33 +0100)]
Fix logic
Commit migrated from https://github.com/dotnet/corefx/commit/
f15d809af0374ddf87754c7acf7bfabc0d1e0609
Drawaes [Wed, 30 Aug 2017 23:08:00 +0000 (00:08 +0100)]
Making the reset buffer logic clearer
Commit migrated from https://github.com/dotnet/corefx/commit/
dfee428695667ebff942c4aa891c6ab9ab3154db
Matt Mitchell [Wed, 30 Aug 2017 20:29:12 +0000 (13:29 -0700)]
Remove EOL openSuSE 42.1 (dotnet/corefx#23684)
Commit migrated from https://github.com/dotnet/corefx/commit/
8f7c22e5ccd1920ecc8894f6d8540715f4b98c14
Eric StJohn [Wed, 30 Aug 2017 18:24:25 +0000 (11:24 -0700)]
Merge pull request dotnet/corefx#23611 from ericstj/removeNetFxSupportLibs
Remove NetFx support libs
Commit migrated from https://github.com/dotnet/corefx/commit/
70201d1f97465882eda716c66da09d22c3933edc
Frederik Carlier [Wed, 30 Aug 2017 17:41:08 +0000 (19:41 +0200)]
System.Drawing: Consolidate Clip-related code in Graphics (dotnet/corefx#23577)
* Consolidate Clip-related code
- Move common Clip-related code from Graphics.Unix and Graphics.Windows to Graphics
- Move P/Invoke methods to GdiplusNative
* PR feedback
* Fix whitespace
Commit migrated from https://github.com/dotnet/corefx/commit/
950f8f9e1180c03c729521d61cceead375d5cb1a
Eric Mellino [Wed, 30 Aug 2017 17:39:34 +0000 (10:39 -0700)]
Merge pull request dotnet/corefx#23562 from mellinoe/system.drawing.remove-printing-assertions
Remove some assertions from AssertDefaultPageSettings in PrintDocumentTests.cs.
Commit migrated from https://github.com/dotnet/corefx/commit/
0cb0b14fd9b49baf4eb2d4c53d287473fbaa8784
Stephen Toub [Wed, 30 Aug 2017 13:30:57 +0000 (09:30 -0400)]
Handle EAGAIN in Console.Write (dotnet/corefx#23539)
If stdout/stderr is configured as a non-blocking file descriptor, Console.Write{Line} may fail if the descriptor is full and would block. With this commit, we instead poll in that case waiting for the ability to write and then retry.
Commit migrated from https://github.com/dotnet/corefx/commit/
e84604edbcd9281f1eb8d69d807c2e531e3c2367
John Doe [Wed, 30 Aug 2017 12:48:29 +0000 (05:48 -0700)]
Typo (dotnet/corefx#23644)
* typo
* typo
* Typo
* Typo
Commit migrated from https://github.com/dotnet/corefx/commit/
40368b2aa9ade8e5f495bfb6f474cd16561abe59
Jim Ma [Wed, 30 Aug 2017 11:38:24 +0000 (23:38 +1200)]
Added tests for struct Equals issue. (dotnet/corefx#23596)
* Added tests for struct Equals issue.
Added tests to cover following scenarios:
- Compare 2 tightly packed struct instances with double/float fields.
- Compare 2 tightly packed struct instances with nested struct which contains double/float fields.
- Compare 2 struct instances with overridden Equals and GetHashCode.
Note the tests have been disabled on netfx. Once the bug fix been included in full .NET Framework, we can enable these tests on netfx.
Fix dotnet/corefx#23516
* Added test cases for regular scenarios.
- Compare 2 struct instances contain pointers.
- Compare 2 not tightly packed struct instances with double/float fields.
- Compare 2 not tightly packed struct instances with nested struct contains double/fload fields.
- Compare 2 struct instances without overridden Equals and GetHashCode.
* Updated code according to the feedback.
- Assert.Equal(true, obj1.Equals(obj2)) -> Assert.True(obj1.Equals(obj2)).
- Assert.Equal(false, obj1.Equals(obje2)) -> Assert.False(obj1.Equals(obj2)).
- String -> string
- Rearranged field order in StructWithDoubleFieldNotTightlyPacked
Commit migrated from https://github.com/dotnet/corefx/commit/
47acda8601a538f37ba719d71b394be9b52d9541
Henk Mollema [Wed, 30 Aug 2017 05:35:01 +0000 (07:35 +0200)]
Remove obsolete workaround for self-contained apps (dotnet/corefx#23637)
Commit migrated from https://github.com/dotnet/corefx/commit/
5a65f3457d46350e4648b16e3119ead57c9241c1
Brian Chavez [Wed, 30 Aug 2017 05:33:36 +0000 (22:33 -0700)]
String literal spelling corrections - A through Z (dotnet/corefx#23674)
Commit migrated from https://github.com/dotnet/corefx/commit/
dd2428300b982775f9ede37104ef8ccbb0350ec2
Dan Moseley [Wed, 30 Aug 2017 01:16:34 +0000 (18:16 -0700)]
Disable test for netfx (dotnet/corefx#23649)
Commit migrated from https://github.com/dotnet/corefx/commit/
110456f81407fc434cc5ef4ab62c4d07e64b3d7b
Tim Seaward [Wed, 30 Aug 2017 01:15:49 +0000 (02:15 +0100)]
Remove pinnable buffer from SslStream (dotnet/corefx#23572)
Commit migrated from https://github.com/dotnet/corefx/commit/
168832a1e88c4a0dfac7aa2a3ce4b28896893ad7
Brian Chavez [Wed, 30 Aug 2017 00:10:01 +0000 (17:10 -0700)]
XML doc spelling corrections - D through H. :shower: (dotnet/corefx#23638)
Commit migrated from https://github.com/dotnet/corefx/commit/
a27929935d2782cdc3e7be21653e8c4530274c6f
Eric Mellino [Wed, 30 Aug 2017 00:08:08 +0000 (17:08 -0700)]
Disable CopyFromScreen test which intermittently fails. (dotnet/corefx#23663)
Commit migrated from https://github.com/dotnet/corefx/commit/
67e755a1e8d16d0e5a2f5919c71e531fbf708188
Atsushi Kanamori [Wed, 30 Aug 2017 00:03:43 +0000 (17:03 -0700)]
Expose IsByRefLike api. (dotnet/corefx#23659)
* Expose IsByRefLike api.
Api was approved today:
Fixes https://github.com/dotnet/corefx/issues/17232
CoreRT/CoreCLR implementations were done
some time ago (we needed them internally.)
So this just exposes the api in the contract.
* Also need to override on EnumBuilder and GenericTypeParameterBuilder
* TypeFromCLSID not supported on Unix
Commit migrated from https://github.com/dotnet/corefx/commit/
836f28cf999a8d320d8f8f8c0dad44e20cc42594
Eric Mellino [Tue, 29 Aug 2017 22:59:10 +0000 (15:59 -0700)]
Merge pull request dotnet/corefx#23632 from safern/disable-drawing
Disable System.Drawing.Tests flaky test failing in CI
Commit migrated from https://github.com/dotnet/corefx/commit/
a3a6a73284d93cd5e348d8a1016956b5e9bfaaae
Tarek Mahmoud Sayed [Tue, 29 Aug 2017 22:58:12 +0000 (15:58 -0700)]
Update BuildTools (dotnet/corefx#23658)
This version of the build tools has the fix for the race condition problem when handling the resources during the compile time. because of the Assembly normalization target
Commit migrated from https://github.com/dotnet/corefx/commit/
229c2083a619cfd0c9cfcb9f81b1322572bdfa76
Brian Chavez [Tue, 29 Aug 2017 22:42:23 +0000 (15:42 -0700)]
XML doc spelling corrections - I through P. :shower: (dotnet/corefx#23651)
Commit migrated from https://github.com/dotnet/corefx/commit/
b09fab5799bb1ca4bea4b4bb086d2c9870dd5191
Brian Chavez [Tue, 29 Aug 2017 22:40:48 +0000 (15:40 -0700)]
XML doc spelling corrections - Q through Z. (dotnet/corefx#23655)
Commit migrated from https://github.com/dotnet/corefx/commit/
723c7feed515abbeece068e05fdf2f918a74ca85
Eric St. John [Tue, 29 Aug 2017 22:24:10 +0000 (15:24 -0700)]
Disable BasicEventSourceTests.TestEventCounter.Test_Write_Metric_EventListener on netfx
This test is failing after we corrected the build to use the assemblies
from the netstandard support package.
Commit migrated from https://github.com/dotnet/corefx/commit/
df2c1540ad86036e0e365babb95d27072e21a771
Dan Moseley [Tue, 29 Aug 2017 22:31:50 +0000 (15:31 -0700)]
Update windows-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
244efc5332bc55c96873c242ed520e85a04e0e03
lajones [Tue, 29 Aug 2017 22:28:14 +0000 (15:28 -0700)]
Merge pull request dotnet/corefx#23580 from JonHanna/annotation_tests
Tests for System.ComponentModel.DataAnnotations
Commit migrated from https://github.com/dotnet/corefx/commit/
54a3552c4f6d6d656cd6722f27c0d06c280e505a
Eric Mellino [Tue, 29 Aug 2017 20:20:29 +0000 (13:20 -0700)]
Merge pull request dotnet/corefx#23652 from mellinoe/system.drawing-remove-system-events
Remove all code related to system events tracking.
Commit migrated from https://github.com/dotnet/corefx/commit/
091bab09445e4052ccdda31114f1d5ba7c9b98ad
Eric Mellino [Tue, 29 Aug 2017 18:50:16 +0000 (11:50 -0700)]
Remove all code related to system events tracking.
Commit migrated from https://github.com/dotnet/corefx/commit/
a18848ae5b843b4bd862aac22daca45ea4f97a4f
Eric Mellino [Tue, 29 Aug 2017 18:33:32 +0000 (11:33 -0700)]
Remove PageSettings assertions which are system-dependent.
* The PrintableArea of a PageSettings is not always the same as its
Bounds. Relatedly, PrintableArea.Location is not always (0, 0).
* PageSettings.Color does not always default to true.
* HardMarginX and HardMarginY are not always 0.
Commit migrated from https://github.com/dotnet/corefx/commit/
bedcd53ba4aa19eb1076d906f2cb660b2ce567de
Vance Morrison [Tue, 29 Aug 2017 18:12:39 +0000 (11:12 -0700)]
Merge pull request dotnet/corefx#23553 from vancem/EventCounterRobustness.8-25-17
Make EventCounter test more robust
Commit migrated from https://github.com/dotnet/corefx/commit/
8abe71350bb24404040102f68975384e0ae1b744