Matt Clarkson [Thu, 6 Apr 2017 13:12:15 +0000 (14:12 +0100)]
build-sys: correct ARM32 GNU EFI boot binary build
Due to ARM not having an EFI capable objcopy we need to use the binary
output argument. This is correctly set up for AArch64 but is missed
when building for ARM32. This patch adds the ARCH_ARM automake define
which can then be used in the makefile to determine if to use the
correct linker flags.
The addition of the ARM32 flags is a copy and paste from the AArch64 to
create a logical OR for the ARCH_AARCH64 and ARCH_ARM variables. I
couldn't figure out a better way to create the conditional with basic
Make language constructs.
Matt Clarkson [Thu, 6 Apr 2017 13:12:11 +0000 (14:12 +0100)]
build-sys: correctly search for gnu-efi header
When the user provides the --with-efi-includedir we incorrectly search
for the header at /usr/include not the provided location. This patch
changes the check to use the provided value so that non-standard header
locations are supported.
This situation occurs commonly when cross-compiling systemd because the
GNU EFI headers and library will not be installed into the root
locations but highly likely a temporary system root.
Lennart Poettering [Wed, 1 Mar 2017 21:43:06 +0000 (22:43 +0100)]
NEWS: 'systemd' is always spelt with a lowercase 's'
Zbigniew Jędrzejewski-Szmek [Wed, 1 Mar 2017 21:29:38 +0000 (16:29 -0500)]
NEWS: add note about 'make install-tests' (#5512)
Lennart Poettering [Wed, 1 Mar 2017 21:14:33 +0000 (22:14 +0100)]
Merge pull request #5502 from poettering/coredump-mini-fixes
Coredump mini improvments
Zbigniew Jędrzejewski-Szmek [Wed, 1 Mar 2017 21:14:12 +0000 (16:14 -0500)]
NEWS: reorder entries by subject, fix some typos and descriptions (#5511)
This doesn't add anything major, but moves some stuff around.
In particular changes which might require updates to the build
environment (new kernel requirements, cgroup stuff, dbus, etc)
are moved to the top, where it's most likely that people will
read them. In particular cgroup hierarchy changes are moved to the
top because they're most likely to be problematic.
Various items are grouped by subject where it's easy.
The description of list-jobs --after/--before was reversed.
Viktor Mihajlovski [Wed, 1 Mar 2017 20:30:17 +0000 (21:30 +0100)]
udev: Use parent bus id for virtio disk builtin path-id (#5500)
The builtin path id for virtio block devices has been changed
to use the bus id without a prefix "virtio-pci" to be
compatible with all virtio transport types.
In order to not break existing setups, the by-path symlinks for
virtio block devices on the PCI bus are reintroduced by udev rules.
The virtio-pci symlinks are considered to be deprecated and
should be replaced by the native PCI symlinks.
Example output for a virtio disk in PCI slot 7:
$ ls /dev/disk/by-path
pci-0000:00:07.0
pci-0000:00:07.0-part1
virtio-pci-0000:00:07.0
virtio-pci-0000:00:07.0-part1
See also
[1] https://lists.freedesktop.org/archives/systemd-devel/2017-February/038326.html
[2] https://lists.freedesktop.org/archives/systemd-devel/2017-March/038397.html
This reverts f073b1b but keeps the same symlinks for compatibility.
Lucas Werkmeister [Wed, 1 Mar 2017 20:24:18 +0000 (21:24 +0100)]
man: escape: fix --suffix examples (#5508)
systemd-escape does not permit the suffix to begin with a dot.
Lennart Poettering [Wed, 1 Mar 2017 20:22:02 +0000 (21:22 +0100)]
Revert "util: Fine tune running_in_chroot() a bit" (#5506)
This reverts commit
295ee9845c801300298d01256eb5a9e3ff117ae0.
Let'd revert this for now, see #5446 for discussions.
We want systemd-detect-virt --chroot to return true for all chroot-like stuff, for
example mock environments which have use a mount namespace. The downside
of this revert that systemctl will not work from our own namespaced services, anything
with RootDirectory=/RootImage= set.
Lucas Werkmeister [Wed, 1 Mar 2017 17:33:02 +0000 (18:33 +0100)]
man: systemd: fix description of SIGRTMIN+26,27,28 (#5505)
Lennart Poettering [Wed, 1 Mar 2017 15:00:47 +0000 (16:00 +0100)]
coredump: define a macro for a "short bus call timeout"
I think it would be a good idea to move such fixed, picked values out of
the main sources into the head of a file, to make sure they are
ultimately tunables.
Lennart Poettering [Wed, 1 Mar 2017 14:58:40 +0000 (15:58 +0100)]
coredump: introduce is_journald_crash() and is_pid1_crash() helpers
We check these a number of times, hence let's unify these checks here.
This also allows us to make the PID 1 check more elaborate as we can
check both the PID and the cgroup. Checking the PID has the benefit that
we'll also cover cases where PID 1 might still be in the root cgroup, and
the cgroup check has the benefit that we also cover crashes in forked
off crasher processes (the way we actually do it in systemd)
Lennart Poettering [Wed, 1 Mar 2017 14:46:54 +0000 (15:46 +0100)]
coredump: normalize generation/parsing of COREDUMP_TRUNCATED=
Given that this is a field primarily processed by computers, and not so
much by humans, assign "1" instead of "yes". Also, use parse_boolean()
as we usually do for parsing it again.
This makes things more alike udev options (as one example), such as
SYSTEMD_READY where we also spit out "1" and "0", and parse with
parse_boolean().
Lennart Poettering [Wed, 1 Mar 2017 16:35:05 +0000 (17:35 +0100)]
mount-util: accept that name_to_handle_at() might fail with EPERM (#5499)
Container managers frequently block name_to_handle_at(), returning
EACCES or EPERM when this is issued. Accept that, and simply fall back
to to fdinfo-based checks.
Note that we accept either EACCES or EPERM here, as container managers
can choose the error code and aren't very good on agreeing on just one.
(note that this is a non-issue with nspawn, as we permit
name_to_handle_at() there, only block open_by_handle_at(), which should
be sufficiently safe).
Lennart Poettering [Wed, 1 Mar 2017 16:21:29 +0000 (17:21 +0100)]
update NEWS for v233 (#5503)
Lennart Poettering [Wed, 1 Mar 2017 15:25:08 +0000 (16:25 +0100)]
core: when a unit's SourcePath points to API VFS pretend we are never out-of-date (#5487)
If the unit's SourcePath is below /proc then it's a unit genreated from
a kernel resource (such as a .mount or .swap unit). And those we watch
anyway, and hence should never be out-of-date.
Fixes: #5461
Lennart Poettering [Wed, 1 Mar 2017 13:37:15 +0000 (14:37 +0100)]
Merge pull request #5458 from keszybz/coredump
Fix for coredump crash
Zbigniew Jędrzejewski-Szmek [Wed, 1 Mar 2017 04:03:12 +0000 (23:03 -0500)]
Merge pull request #5494 from poettering/run-fixes
systemd-run --user fixes.
Lennart Poettering [Wed, 1 Mar 2017 03:49:19 +0000 (04:49 +0100)]
resolved: add the new KSK to the built-in resolved trust anchor (#5486)
Fixes: #5482
Lennart Poettering [Wed, 1 Mar 2017 03:03:48 +0000 (04:03 +0100)]
automount: if an automount unit is masked, don't react to activation anymore (#5445)
Otherwise we'll hit an assert sooner or later.
This requires us to initialize ->where even if we come back in "masked"
mode, as otherwise we don't know how to operate on the automount and
detach it.
Fixes: #5441
Zbigniew Jędrzejewski-Szmek [Wed, 1 Mar 2017 02:47:45 +0000 (21:47 -0500)]
coredumpctl: avoid spurious warning about systemd-coredump@0.service
Fixes #5477.
Zbigniew Jędrzejewski-Szmek [Sun, 26 Feb 2017 23:07:39 +0000 (18:07 -0500)]
coredumpctl: print a hint when no journal files are found
[guest@fedora ~]$ coredumpctl
No coredumps found.
[guest@fedora ~]$ ./coredumpctl
Hint: You are currently not seeing messages from other users and the system.
Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
Pass -q to turn off this notice.
No coredumps found.
Fixes #1733.
Zbigniew Jędrzejewski-Szmek [Sun, 26 Feb 2017 23:00:39 +0000 (18:00 -0500)]
journalctl: move access_check() to shared/
The only functional change is that log_notice("No journal files were found.")
is not printed any more with --quiet. log_error("No journal files were opened
due to insufficient permissions.") is still printed.
I wasn't quite sure where to put this function, but shared/ seems to be the
right place and none of the existing files seem to fit too well.
v2: rename journal_access_check to journal_access_check_and_warn.
Zbigniew Jędrzejewski-Szmek [Sun, 26 Feb 2017 22:00:01 +0000 (17:00 -0500)]
coredumpctl: use a 3s timeout for checking units
This is just a hint, so we shouldn't wait too long. A short timeout
helps for the case where pid1 of dbus have crashed.
Zbigniew Jędrzejewski-Szmek [Sun, 26 Feb 2017 21:46:23 +0000 (16:46 -0500)]
coredump: process special crashes in an (almost) normal way
We would only log a terse message when pid1 or systemd-journald crashed.
It seems better to reuse the normal code paths as much as possible,
with the following differences:
- if pid1 crashes, we cannot launch the helper, so we don't analyze the
coredump, just write it to file directly from the helper invoked by the
kernel;
- if journald crashes, we can produce the backtrace, but we don't log full
structured messages.
With comparison to previous code, advantages are:
- we go through most of the steps, so for example vacuuming is performed,
- we gather and log more data. In particular for journald and pid1 crashes we
generate a backtrace, and for pid1 crashes we record the metadata (fdinfo,
maps, etc.),
- coredumpctl shows pid1 crashes.
A disavantage (inefficiency) is that we gather metadata for journald crashes
which is then ignored because _TRANSPORT=kernel does not support structued
messages.
Messages for the systemd-journald "crash" have _TRANSPORT=kernel, and
_TRANSPORT=journal for the pid1 "crash".
Feb 26 16:27:55 systemd[1]: systemd-journald.service: Main process exited, code=dumped, status=11/SEGV
Feb 26 16:27:55 systemd[1]: systemd-journald.service: Unit entered failed state.
Feb 26 16:37:54 systemd-coredump[18801]: Process 18729 (systemd-journal) of user 0 dumped core.
Feb 26 16:37:54 systemd-coredump[18801]: Coredump diverted to /var/lib/systemd/coredump/core.systemd-journal.0.
36c14bf3c6ce4c38914f441038990979.18729.
1488145074000000.lz4
Feb 26 16:37:54 systemd-coredump[18801]: Stack trace of thread 18729:
Feb 26 16:37:54 systemd-coredump[18801]: #0 0x00007f46d6a06b8d fsync (libpthread.so.0)
Feb 26 16:37:54 systemd-coredump[18801]: #1 0x00007f46d71bfc47 journal_file_set_online (libsystemd-shared-233.so)
Feb 26 16:37:54 systemd-coredump[18801]: #2 0x00007f46d71c1c31 journal_file_append_object (libsystemd-shared-233.so)
Feb 26 16:37:54 systemd-coredump[18801]: #3 0x00007f46d71c3405 journal_file_append_data (libsystemd-shared-233.so)
Feb 26 16:37:54 systemd-coredump[18801]: #4 0x00007f46d71c4b7c journal_file_append_entry (libsystemd-shared-233.so)
Feb 26 16:37:54 systemd-coredump[18801]: #5 0x00005577688cf056 write_to_journal (systemd-journald)
Feb 26 16:37:54 systemd-coredump[18801]: #6 0x00005577688d2e98 dispatch_message_real (systemd-journald)
Feb 26 16:37:54 kernel: systemd-coredum: 9 output lines suppressed due to ratelimiting
Feb 26 16:37:54 systemd-journald[18810]: Journal started
Feb 26 16:50:59 systemd-coredump[19229]: Due to PID 1 having crashed coredump collection will now be turned off.
Feb 26 16:51:00 systemd[1]: Caught <SEGV>, dumped core as pid 19228.
Feb 26 16:51:00 systemd[1]: Freezing execution.
Feb 26 16:51:00 systemd-coredump[19229]: Process 19228 (systemd) of user 0 dumped core.
Stack trace of thread 19228:
#0 0x00007fab82075c47 kill (libc.so.6)
#1 0x000055fdf7c38b6b crash (systemd)
#2 0x00007fab824175c0 __restore_rt (libpthread.so.0)
#3 0x00007fab82148573 epoll_wait (libc.so.6)
#4 0x00007fab8366f84a sd_event_wait (libsystemd-shared-233.so)
#5 0x00007fab836701de sd_event_run (libsystemd-shared-233.so)
#6 0x000055fdf7c4a380 manager_loop (systemd)
#7 0x000055fdf7c402c2 main (systemd)
#8 0x00007fab82060401 __libc_start_main (libc.so.6)
#9 0x000055fdf7c3818a _start (systemd)
Poor machine ;)
Martin Pitt [Tue, 28 Feb 2017 22:23:18 +0000 (23:23 +0100)]
Merge pull request #5493 from poettering/service-mini-fixes
three small mini-fixes for src/core/service.c
David Herrmann [Tue, 28 Feb 2017 20:57:58 +0000 (21:57 +0100)]
hostname: detect detachable dmi chassis type (#5489)
Detect the 'Detachable' dmi chassis type properly. Use the new
'convertible' chassis class of hostnamed, instead of returning the
generic 'computer' chassis class.
Mauricio Faria de Oliveira [Tue, 28 Feb 2017 20:30:22 +0000 (17:30 -0300)]
cryptsetup-generator: run cryptsetup service before swap unit (#5480)
If the cryptsetup service unit and swap unit for a swap device
are not strictly ordered, it might happen that the swap unit
activates/mounts the swap device before its cryptsetup service unit
has a chance to run the 'mkswap' command (that it is programmed to).
This leads to the following error:
Starting Cryptography Setup for sda3_crypt...
[ OK ] Found device /dev/mapper/sda3_crypt.
Activating swap /dev/mapper/sda3_crypt...
[ OK ] Activated swap /dev/mapper/sda3_crypt.
[ OK ] Reached target Swap.
[FAILED] Failed to start Cryptography Setup for sda3_crypt.
See 'systemctl status systemd-cryptsetup@sda3_crypt.service' for
details.
[DEPEND] Dependency failed for Encrypted Volumes.
Which happens because the swap device is already mounted:
# systemctl status systemd-cryptsetup@sda3_crypt.service
<...>
Active: failed (Result: exit-code) since Mon 2017-02-27 14:21:43 CST;
54s ago
<...>
<...> systemd[1]: Starting Cryptography Setup for sda3_crypt...
<...> mkswap[2420]: mkswap: error: /dev/mapper/sda3_crypt is mounted;
will not make swapspace
<...>
So, modify cryptsetup-generator to include a 'Before=' option for the
respective 'dev-mapper-%i.swap' device in the cryptsetup service unit.
Now, correct ordering is ensured, and the error no longer occurs:
Starting Cryptography Setup for sda3_crypt...
[ OK ] Found device /dev/mapper/sda3_crypt.
[ OK ] Started Cryptography Setup for sda3_crypt.
Activating swap /dev/mapper/sda3_crypt...
[ OK ] Reached target Encrypted Volumes.
[ OK ] Activated swap /dev/mapper/sda3_crypt.
[ OK ] Reached target Swap.
Lennart Poettering [Tue, 28 Feb 2017 20:28:21 +0000 (21:28 +0100)]
udev rules: add udev rule to create /dev/ptp_kvm (#5495)
Its necessary to specify the KVM PTP device name in userspace.
In case a network card with PTP device is assigned to the guest,
it might be the case that KVM PTP gets /dev/ptp0 instead of /dev/ptp1.
Fix a device name for the KVM PTP device.
Lennart Poettering [Tue, 28 Feb 2017 17:27:42 +0000 (18:27 +0100)]
run: also pin unit when we we are in --pty mode
Since
95f1d6bfecde60b245fae1ab0313b550201e7880 we'll subscribe to unit
signals to figure out when to disconnect the pty. But that can only work
correctly if we actually subscribe to the unit's signals. Hence,
explicitly pin (and thus subscribe to) the unit we just created not only
in --wait mode but also in --pty mode.
Or to say this differently: we need to pin the unit in the same cases as
we install the signal match.
95f1d6bfecde60b245fae1ab0313b550201e7880
forgot to do that.
This is relevant to make sure systemd-run works correctly in --user
mode, and correctly exits when the spawned service dies. To test:
systemd-run --user -t /bin/bash
And then press ^D. This will hang before this change, but exit cleanly
after it.
Lennart Poettering [Tue, 28 Feb 2017 16:55:57 +0000 (17:55 +0100)]
core: always consider clients that pinned a unit to be subscribers
If a client pins a unit, then it makes sense to also implicitly make it
a subscriber. This is useful for clients that just want to watch one
specific unit: they can pin it and receive its messages.
Lennart Poettering [Tue, 28 Feb 2017 16:22:14 +0000 (17:22 +0100)]
update TODO
Lennart Poettering [Tue, 28 Feb 2017 15:55:18 +0000 (16:55 +0100)]
systemctl: fix bad memory access when mangle_names() fails (#5485)
Fixes #5483
Martin Pitt [Tue, 28 Feb 2017 15:52:46 +0000 (16:52 +0100)]
Merge pull request #5491 from poettering/hwdb-update-v233
hwbd: update once again for 233
Lennart Poettering [Tue, 28 Feb 2017 15:08:40 +0000 (16:08 +0100)]
service: refuse using PID 1 as MAINPID for a service
Lennart Poettering [Tue, 28 Feb 2017 15:08:21 +0000 (16:08 +0100)]
service: make use of log_unit_warning_errno()'s return value
Lennart Poettering [Tue, 28 Feb 2017 15:07:56 +0000 (16:07 +0100)]
core: use PID_FMT where appropriate
Lennart Poettering [Tue, 28 Feb 2017 14:24:10 +0000 (15:24 +0100)]
update TODO
Lennart Poettering [Tue, 28 Feb 2017 14:20:22 +0000 (15:20 +0100)]
update TODO
Lennart Poettering [Tue, 28 Feb 2017 14:11:57 +0000 (15:11 +0100)]
Merge pull request #5464 from ssahani/label
socket-util: introduce address_label_valid
Lennart Poettering [Tue, 28 Feb 2017 14:11:36 +0000 (15:11 +0100)]
Merge pull request #5484 from dvdhrm/convertible
hostname: support 'convertible' chassis
Lennart Poettering [Tue, 28 Feb 2017 14:07:49 +0000 (15:07 +0100)]
hwbd: update once again for 233
Lennart Poettering [Tue, 28 Feb 2017 11:32:18 +0000 (12:32 +0100)]
Merge pull request #5438 from ssahani/vxlan-address
networkd: add symlinks for Makefile (netdev and wait-online) , vxlan enhancements.
Susant Sahani [Tue, 28 Feb 2017 11:24:33 +0000 (16:54 +0530)]
networkd: use address_label_valid for label validation
Susant Sahani [Tue, 28 Feb 2017 11:23:58 +0000 (16:53 +0530)]
socket-util: introduce address_label_valid
David Herrmann [Tue, 28 Feb 2017 10:58:14 +0000 (11:58 +0100)]
hostname: detect convertible dmi chassis type
Detect the 'Convertible' dmi chassis type properly. Use the new
'convertible' chassis class of hostnamed, instead of returning the
generic 'computer' chassis class.
Based on a patch by Jani Nikula <jani.nikula@intel.com>.
David Herrmann [Tue, 28 Feb 2017 10:54:52 +0000 (11:54 +0100)]
hostname: add 'convertible' chassis type
Add the 'convertible' type to the set of allowed chassis. This applies
to all devices that can be transformed by the user from laptop style to
tablet style.
This does not add any auto-detection, yet. It only makes 'set-chassis'
accept 'convertible' as valid input.
YunQiang Su [Tue, 28 Feb 2017 10:35:40 +0000 (18:35 +0800)]
Fix MIPS N64 and N32 LIB_ARCH_TUPLE (#5469)
* Fix MIPS N64 and N32 LIB_ARCH_TUPLE
For mips, we have 3 major ABIs, they are N64, N32 and O32.
Both N32 and N64 defined __mips64__, and only N64 defined __LP64__.
Susant Sahani [Tue, 28 Feb 2017 09:32:22 +0000 (15:02 +0530)]
networkd: fix assertion crash for tunnel, log error instead (#5465)
GRE6 and IP6TNL address should be a IPv6.
fix :
```
Assertion 't->family == AF_INET6' failed at src/network/netdev/tunnel.c:170,
function netdev_ip6gre_fill_message_create(). Aborting.
```
xTibor [Mon, 27 Feb 2017 19:55:43 +0000 (20:55 +0100)]
hwdb: release PageUp on Acer Aspire 7750G (#5476)
Martin Pitt [Mon, 27 Feb 2017 19:54:11 +0000 (20:54 +0100)]
build-sys: add LIB_ARCH_TUPLE for tilegx-linux-gnu (#5474)
Fix build failure on the tilegx architecture.
https://bugs.debian.org/856306
Mikko Ylinen [Mon, 27 Feb 2017 19:03:07 +0000 (21:03 +0200)]
sd-boot: stub: check LoadOptions contains data (#5467)
With some UEFI shells LoadOptionsSize is reported being > 0
but the corresponding LoadOptions does not contain any data
(the first element has value 0).
When that happens, the stub feature that allows .cmdline to be
replaced by what's in LoadOptions ends up copying nothing/random
data to the kernel cmdline resulting in different kinds of boot
problems.
To fix this, add a check to see if LoadOptions contains data
before replacing the .cmdline.
Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
AsciiWolf [Mon, 27 Feb 2017 12:59:11 +0000 (13:59 +0100)]
man: fix typo (#5468)
Mark Stosberg [Mon, 27 Feb 2017 01:03:30 +0000 (20:03 -0500)]
man: systemctl list-timers: Provide sample output and document it. (#5463)
As with `systemctl list-sockets` and `systemctl status`, we provide a sample
output for `systemctl list-timers` and document what the columns mean.
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 22:29:14 +0000 (17:29 -0500)]
coredumpctl,man: mark truncated messages as such in output
Unit systemd-coredump@1-3854-0.service is failed/failed, not counting it.
TIME PID UID GID SIG COREFILE EXE
Fri 2017-02-24 11:11:00 EST 10002 1000 1000 6 none /home/zbyszek/src/systemd-work/.libs/lt-Sat 2017-02-25 00:49:32 EST 26921 0 0 11 error /usr/libexec/fprintd
Sat 2017-02-25 11:56:30 EST 30703 1000 1000 - - /usr/bin/python3.5
Sat 2017-02-25 13:16:54 EST 3275 1000 1000 11 present /usr/bin/bash
Sat 2017-02-25 17:25:40 EST 4049 1000 1000 11 truncated /usr/bin/bash
For info and gdb output, the filename is marked in red and "(truncated)" is
appended. (Red is necessary because the annotation is hard to see when running
under a pager.)
Fixed #3883.
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 22:14:00 +0000 (17:14 -0500)]
coredumpctl: add debug information which services count towards the warning
A few times I have seen the hint unexpectedly. Add this so debug info
so it's easier to see what's happening.
...
Unit systemd-coredump@0-3119-0.service is failed/failed, not counting it.
Unit systemd-coredump@1-3854-0.service is activating/start-pre, counting it.
...
-- Notice: 1 systemd-coredump@.service unit is running, output may be incomplete.
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 21:38:00 +0000 (16:38 -0500)]
coredump: when storing an incomplete coredump, add COREDUMP_TRUNCATED=yes
We logged about this, but did not attach information directly to the log
entry. It *would* be nice to log the full untruncated size, but afaict, to do
this, we would have to read the full data from the kernel. Doing this just to
log that information seems a bit excessive, in particular when the limit could
be set quite low. So for now let's just add a boolean field.
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 19:00:39 +0000 (14:00 -0500)]
coredump: do not try to access unitialized CONTEXT_COMM field
Most of the fields in the context array come from the kernel (passed
through argv), but two are special: comm and exe. We allocate them
ourselves. We forgot to initialize context[CONTEXT_COMM] with the value
we allocated (introduced in
9aa820231414baa28e6bf02a033932cb69ff6b8b).
To simplify things, just set context[CONTEXT_COMM] and context[CONTEXT_EXE],
and free those two fields at the end.
Fixes #5442.
Martin Pitt [Sun, 26 Feb 2017 20:28:43 +0000 (21:28 +0100)]
build-sys: make "incomatible pointer types" warnings fatal (#5459)
This isn't something that can be safely ignored, and easy to miss. This
prevents errors like issue #5452.
Zbigniew Jędrzejewski-Szmek [Sun, 26 Feb 2017 07:24:39 +0000 (02:24 -0500)]
gpt-auto-generator: fix warning when compiling w/o efi (#5456)
Fixes #5452.
Mike Gilbert [Sun, 26 Feb 2017 03:42:27 +0000 (22:42 -0500)]
README: document dependency on kernel crypto/hash API (#5457)
The hmac and sha256 algorithms are used in sd-id128.
Closes: https://github.com/systemd/systemd/issues/5454
Closes: https://github.com/systemd/systemd/issues/5455
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 14:35:09 +0000 (09:35 -0500)]
coredump: slight simplification
Thomas H. P. Andersen [Sat, 25 Feb 2017 14:19:26 +0000 (15:19 +0100)]
NEWS: fix typo (#5453)
Martin Pitt [Sat, 25 Feb 2017 11:25:27 +0000 (12:25 +0100)]
Merge pull request #5449 from keszybz/blkd-error-handling
blkid error handling
Zbigniew Jędrzejewski-Szmek [Sat, 25 Feb 2017 02:35:38 +0000 (21:35 -0500)]
Merge pull request #5429 from GiedriusS/master
coredumpctl: implement --since/--until (-S/-U) for info/list verbs
Zbigniew Jędrzejewski-Szmek [Fri, 24 Feb 2017 23:48:57 +0000 (18:48 -0500)]
Merge pull request #5444 from poettering/cgroups-revert-no-error
Revert "core: simplify cg_[all_]unified()" and more.
Giedrius Statkevičius [Fri, 24 Feb 2017 19:30:59 +0000 (21:30 +0200)]
shell-completion: include the new coredumpctl options
Giedrius Statkevičius [Fri, 24 Feb 2017 19:30:41 +0000 (21:30 +0200)]
man/coredumpctl: document the new options -S/-U
Giedrius Statkevičius [Fri, 24 Feb 2017 19:29:40 +0000 (21:29 +0200)]
coredumpctl: implement --since/--until (-S/-U) for info/list verbs
Implement --since/--until (-S/-U) in the same fashion as journalctl.
This lets the user filter the results a bit so it would be easier to
find relevant info in case there were many core dumps.
Susant Sahani [Thu, 23 Feb 2017 11:11:47 +0000 (16:41 +0530)]
networkd: add symlinks to the Makefile for dir netdev and wait-online
Susant Sahani [Fri, 24 Feb 2017 19:01:47 +0000 (00:31 +0530)]
networkd: add support for vxlan Remote and Local.
This patch add supports to configure IFLA_VXLAN_LOCAL
and IFLA_VXLAN_GROUP.
The "Group" is renamed to "Remote" which is a multicast address.`
```
Description=vxlan-test
Name=vxlan1
Kind=vxlan
[VXLAN]
Id=33
Local=2001:db8:2f4:4bff:fa71:1a56
Remote=FF02:0:0:0:0:0:1:9
```
output
```
ip -d link show vxlan1
16: vxlan1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1430 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
link/ether fe:b4:97:03:f8:e5 brd ff:ff:ff:ff:ff:ff promiscuity 0
vxlan id 33 group ff02::1:9 local 2001:db8:02f4:4bff:fa71:1a56 dev enp0s3 srcport 0 0 dstport 8472 ageing 300 noudpcsum noudp6zerocsumtx noudp6zerocsumrx addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
```
AsciiWolf [Fri, 24 Feb 2017 17:14:02 +0000 (18:14 +0100)]
Fix missing space in comments (#5439)
Lennart Poettering [Fri, 24 Feb 2017 17:05:31 +0000 (18:05 +0100)]
cgroup: rework cg_all_unified()
Let's just check the unified level, directly. There's really no value in
wrapping cg_unified_controllers() with this, i.e. potentially do string
comparison when there's no reason to.
Also, this makes the clal more alike cg_hybrid_unified().
Lennart Poettering [Fri, 24 Feb 2017 17:03:09 +0000 (18:03 +0100)]
cgroup: rename cg_update_unified() → cg_unified_update()
We usually put the noun first, the verb (i.e. method) secont, for
example in cg_unified_flush(), let's follow the logic here...
Lennart Poettering [Fri, 24 Feb 2017 17:00:04 +0000 (18:00 +0100)]
cgroup: rename cg_unified() → cg_unified_controller()
cg_unified() is a bit generic a name, let's make clear that it checks
whether a specified controller is in unified mode.
Lennart Poettering [Fri, 24 Feb 2017 16:52:58 +0000 (17:52 +0100)]
cgroup: change cg_unified() to possibly return errors again
We use our cgroup APIs in various contexts, including from our libraries
sd-login, sd-bus. As we don#t control those environments we can't rely
that the unified cgroup setup logic succeeds, and hence really shouldn't
assert on it.
This more or less reverts
415fc41ceaeada2e32639f24f134b1c248b9e43f.
Lennart Poettering [Fri, 24 Feb 2017 14:53:17 +0000 (15:53 +0100)]
cgroup-util: check unified_cache before invoking streq()
Just a minor optimization.
Susant Sahani [Thu, 23 Feb 2017 18:03:55 +0000 (23:33 +0530)]
sd-netlink: fix type for IFLA_VXLAN_LOCAL
Susant Sahani [Thu, 23 Feb 2017 17:59:31 +0000 (23:29 +0530)]
test: add support for in_addr_is_multicast tests
Susant Sahani [Thu, 23 Feb 2017 17:58:12 +0000 (23:28 +0530)]
socket-util: introduce in_addr_is_multicast
This patch add support to test whether a internet
address is multicast or not.
Lennart Poettering [Thu, 23 Feb 2017 15:23:02 +0000 (16:23 +0100)]
Merge pull request #4670 from htejun/systemd-controller-on-unified-v2
Systemd controller on unified v2
Evgeny Vereshchagin [Thu, 23 Feb 2017 12:06:03 +0000 (15:06 +0300)]
Merge pull request #5434 from poettering/udev-log-revert
Udev log revert
Namhyung Kim [Thu, 23 Feb 2017 12:04:57 +0000 (21:04 +0900)]
journal: avoid duplicated call to get cgroup path (#5404)
The cg_pid_get_path_shifted() is called twice during
server_dispatch_message(). We can get rid of the second by passing the
path to dispatch_message_real().
Lennart Poettering [Thu, 23 Feb 2017 11:36:07 +0000 (12:36 +0100)]
Revert "udev: Introduce UDEV_PROPAGATE_LOG macro (#5302)"
This reverts commit
c22569eeeafa94cf510267071f5b75c4ab714e09.
Let's revert this for now, since it apparently doesn't fix the problem
at hand.
Lennart Poettering [Thu, 23 Feb 2017 11:36:04 +0000 (12:36 +0100)]
Revert "Makefile.am: add a `\` (#5422)"
This reverts commit
00d1e0c9def4557c74f46cc2fe3a7ebc32a1dc8a.
Zbigniew Jędrzejewski-Szmek [Thu, 23 Feb 2017 00:57:11 +0000 (19:57 -0500)]
test-cgroup-util: add a "test" to print out cg_is_*_wanted() values
This isn't terribly useful because /sys/fs/cgroup will usually be mounted.
But it at least allows checking if the values make sense in this case.
Zbigniew Jędrzejewski-Szmek [Thu, 23 Feb 2017 00:55:31 +0000 (19:55 -0500)]
cgroup-util: fix the case of default=unified, unified-cgroup-hierarchy=0
We should mount the hybrid hierarchy if the user disabled the unified
hierarchy on the kernel command line.
Peter Hutterer [Thu, 23 Feb 2017 00:02:17 +0000 (10:02 +1000)]
Merge pull request #5424 from segfault-cc/master
Added hwdb rule for E5570 laptop (PointingStick)
Lucas Werkmeister [Wed, 22 Feb 2017 18:58:01 +0000 (19:58 +0100)]
man: journalctl: update --new-id128 format count (#5423)
The Python format was added in
d489071fb3.
Zbigniew Jędrzejewski-Szmek [Wed, 22 Feb 2017 17:57:43 +0000 (12:57 -0500)]
cgroup-util: cache all cg_is_*_wanted answers, disable /sys/fs/cgroups/unified on unified
If we encounter an error in proc cmdline parsing, just treat that as permanent,
i.e. the same as if the option was not specified. Realistically, it is better
to use the same condition for all related mounts, then to have e.g.
/sys/fs/cgroup mounted and /sys/fs/cgroup/unified not. If we find something is
mounted and base our answer on that, cache that result too.
Fix the conditions so that if "unified" is used, make sure any "hybrid" mounts
are not mounted.
Zbigniew Jędrzejewski-Szmek [Wed, 22 Feb 2017 16:56:16 +0000 (11:56 -0500)]
Merge pull request #5421 from ssahani/net7
networkd: Do not set config to NULL immediately.
Zbigniew Jędrzejewski-Szmek [Mon, 20 Feb 2017 01:02:12 +0000 (20:02 -0500)]
man: update descriptions of argument-less kernel cmdline args
This updates the man page for the changes introduced in
1d84ad944520fc3e062ef518c4db4e1d3a1866af.
"=" is kep if the option is predominantly used with an argument, and dropped
otherwise.
v2:
- update also description of log_color
- drop '=' in all cases where it is optional
(previous rule of dropping it only in some cases was just too arbitrary.)
Zbigniew Jędrzejewski-Szmek [Mon, 20 Feb 2017 00:33:48 +0000 (19:33 -0500)]
man: describe the cgroup hierarchy kernel commandline options
Fixes #4827.
v2:
- update for the inverted interpration of systemd.legacy_systemd_cgroup_controller
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 20:59:21 +0000 (15:59 -0500)]
core/mount-setup: if unified hierarchy is not supported, fall back to legacy
We need this to gracefully support older or strangely configured kernels.
v2:
- do not install a callback handler, just embed the right conditions into
cg_is_*_wanted()
v3:
- fix bug in cg_is_legacy_wanted()
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 20:36:56 +0000 (15:36 -0500)]
Rename cg_is_unified_systemd_controller_wanted to cg_is_hybrid_wanted
Less typing and doesn't make the table so incredibly wide.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 05:09:31 +0000 (00:09 -0500)]
build-sys: default to hybrid cgroup hierarchy
It is expected that general-purpose distributions might want to override this.
This commit is made separate from grandparent to make it easy to revert if
needed.
v2:
- use hybrid as the default
(We tested that the default of unified seems boot correctly everywhere and behave
correctly in general, but it is incompatible with docker/lxc and probably some
other tools, so for now we default to hybrid. The new "hybrid" mode should work
be OK for those tools.)
Fixes #4669.
Vitaly Sulimov [Wed, 22 Feb 2017 09:57:21 +0000 (12:57 +0300)]
Added hwdb rule for E5570 laptop (PointingStick)
Trackpoint sensivity is very high by default
https://bugs.freedesktop.org/show_bug.cgi?id=99860
Susant Sahani [Wed, 22 Feb 2017 05:41:28 +0000 (11:11 +0530)]
networkd: address config add error checking
We not looking for hashmap_put return error code.
Susant Sahani [Wed, 22 Feb 2017 05:25:03 +0000 (10:55 +0530)]
networkd: Do not set config to NULL immediately.
fd45e52 sets
n to NULL which leads to crash.
fixes: #5418
Susant Sahani [Wed, 22 Feb 2017 04:04:02 +0000 (09:34 +0530)]
Makefile.am: add a `\` (#5422)
fixes: #5419