Santiago Fernandez Madero [Wed, 27 Mar 2019 03:04:55 +0000 (20:04 -0700)]
Fix CI, use helix secret only for official builds (dotnet/corefx#36390)
Commit migrated from https://github.com/dotnet/corefx/commit/
477f208f350119a311eb6397b3ac8f19c7ed7a8c
Steve Harter [Tue, 26 Mar 2019 23:10:28 +0000 (16:10 -0700)]
Update API based on review (dotnet/corefx#36385)
Commit migrated from https://github.com/dotnet/corefx/commit/
bfdc19995af287c2028c59cbbeee1497d1e34e58
Tomas Weinfurt [Tue, 26 Mar 2019 22:36:33 +0000 (15:36 -0700)]
32bit process may not throw on negative allocation (dotnet/corefx#36381)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c0f15cb5fa7919056f0882660556ead69fe9887
Tomas Weinfurt [Tue, 26 Mar 2019 22:35:03 +0000 (15:35 -0700)]
add Alpine.39 and update ARM64 container (dotnet/corefx#36377)
Commit migrated from https://github.com/dotnet/corefx/commit/
d44c43b64de0f942c81fea7a535bf8bade508db0
Eric StJohn [Tue, 26 Mar 2019 21:41:45 +0000 (14:41 -0700)]
Use Microsoft.DotNet.VersionTools.Tasks (dotnet/corefx#36369)
Commit migrated from https://github.com/dotnet/corefx/commit/
0e672db1594b72f9af5de60ea959ec7b78ae3e5f
Tanner Gooding [Tue, 26 Mar 2019 20:56:13 +0000 (13:56 -0700)]
Adding more floating-point parsing test coverage and re-enabling some tests (dotnet/corefx#35899)
* Adding some tests to validate too large exponents are handled correctly.
* Re-enabling the tests that were skipped due to 35566
* Re-enabling the tests that were skipped due to 35864
* Changing RealFormatterTestsBase to be UTF8
Commit migrated from https://github.com/dotnet/corefx/commit/
9e9b1d05358bddbf5aa74224c91784322897f5ad
Liudmila Molkova [Tue, 26 Mar 2019 20:41:25 +0000 (13:41 -0700)]
Fix: TraceId is not available before Activity starts (dotnet/corefx#36345)
* Fix: TraceId is not available before Activity starts
* minor fixes
* review: Move TraceId parsing from parent to helper method
* fix netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
b1f81d6480909bfe41fa6299fbfd38376df6f240
Tomas Weinfurt [Tue, 26 Mar 2019 19:26:11 +0000 (12:26 -0700)]
disable UWP on arm (dotnet/corefx#36356)
* disable UWP on arm
* build but not test UAP_arm_Release
Commit migrated from https://github.com/dotnet/corefx/commit/
c0e280d22177f9a471b2f80ef7e1bcba59c438a1
Jeremy Koritzinsky [Tue, 26 Mar 2019 19:24:45 +0000 (12:24 -0700)]
Fix WinRT marshalling for NotifyPropertyChangedEventArgs and NotifyCollectionChangedEventArgs (CoreFX side) (dotnet/corefx#36224)
The fix for dotnet/corefxdotnet/corefx#35909 requires both some runtime work and some framework work since the marshalling helpers for NotifyPropertyChangedEventArgs and NotifyCollectionChangedEventArgs lives in corefx.
In this PR:
- Update the signatures of `INotifyCollectionChangedEventArgsFactory.CreateInstanceWithAllParameters` and `INotifyPropertyChangedEventArgsFactory.CreateInstance` to be as close to their official `winmd` signature as possible.
We cannot update the return types since we need to make sure we return the raw COM object pointer and not a pointer to an RCW that was projected through our WinRT type projection back to managed. (depends on dotnet/coreclrdotnet/corefx#23401)
- Call a new function on `System.Runtime.InteropServices.WindowsRuntimeMarshal` called `GetUniqueObjectForIUnknownWithoutUnboxing` (introduced in dotnet/coreclrdotnet/corefx#23401) to get back an RCW for the IUnknown pointer without going through the WinRT projections. The WinRT projections for `INotifyPropertyChangedEventArgs` and `INotifyCollectionChangedEventArgs` go through this code to project themselves to the managed code, so we need a way to get back a "raw" RCW that is not projected to avoid infinitely recursing into a stack-overflow (current behavior) and avoid having to manually traversing the vtable of the native interfaces (impractical to implement).
Depends on dotnet/coreclrdotnet/corefx#23401
Fixes dotnet/corefx#35909
Co-authored-by: Jeff Schwartz <JeffSchw@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
b0123b9bdd9a4bf0b1447d9d2a4c4b77ed708f05
Tanner Gooding [Tue, 26 Mar 2019 15:48:03 +0000 (08:48 -0700)]
Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning (dotnet/corefx#36071)
* Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning
* Responding to PR feedback.
* Dropping support for low resolution stopwatch
* Removing BestFitMapping=false
* Removing unneeded unsafe declarations
* Addressing more PR feedback
* Fixing the pal_time header file
* Fixing the Unix P/Invoke signatures for GetTimestamp and GetTimestampResolution to return ulong.
* Fixing GetTimestampResolution to scale the result for HAVE_CLOCK_MONOTONIC
Commit migrated from https://github.com/dotnet/corefx/commit/
c1328f49f69d501618f1d867265efacedf107f23
Afsaneh Rafighi [Tue, 26 Mar 2019 15:18:51 +0000 (08:18 -0700)]
Merge pull request dotnet/corefx#34709 from Wraith2/sqlfix-13439
SqlClient add TestPacketNumberWraparound fix and test
Commit migrated from https://github.com/dotnet/corefx/commit/
d4e6617c6a1a63b3d58e7ab4d8d52c1ff679eb3e
Levi Broderick [Tue, 26 Mar 2019 01:05:53 +0000 (18:05 -0700)]
Remove corefx references to String.Copy and mark it obsolete (dotnet/corefx#36131)
* Remove references to string.Copy.
* Obsolete String.Copy and mark EditorBrowsable.Never
* Suppress String.Copy obsolete warning from String unit tests
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
dd917a1ce1f812fbd6d3d2268c9ebc3728fd2dfb
Steve Harter [Tue, 26 Mar 2019 00:09:49 +0000 (17:09 -0700)]
Add ignore and propertyname features (dotnet/corefx#36353)
Commit migrated from https://github.com/dotnet/corefx/commit/
f4fa8a1c44d1d675d7f60e320f36da195ab56633
Tomas Weinfurt [Mon, 25 Mar 2019 23:30:53 +0000 (16:30 -0700)]
test Linux/arm32 queue (dotnet/corefx#36054)
* add test queue for Linux/arm32
Commit migrated from https://github.com/dotnet/corefx/commit/
df31ca60165196a4de06615faf0dfb91a9de2688
Santiago Fernandez Madero [Mon, 25 Mar 2019 23:26:30 +0000 (16:26 -0700)]
Fix corefx official builds (dotnet/corefx#36344)
Commit migrated from https://github.com/dotnet/corefx/commit/
8e31744bf284cd03469c876833d450ad30d915c7
Tomas Weinfurt [Mon, 25 Mar 2019 21:43:28 +0000 (14:43 -0700)]
make mmap tests friendlier to containers (dotnet/corefx#36342)
* make mmap tests friendlier to containers
* move { to right place
Commit migrated from https://github.com/dotnet/corefx/commit/
7cdbadc0399009202d3821024f106efcf12b23c4
Tom Deseyn [Mon, 25 Mar 2019 21:15:45 +0000 (22:15 +0100)]
Process.Unix: fix unexpected Process.Exited events (dotnet/corefx#36333)
* Process.Unix: fix unexpected Process.Exited events
Extract ProcessWaitHandle creation from EnsureWatchingForExit to avoid
Process.Exited events when user hasn't set EnableRaisingEvents.
Fixes https://github.com/dotnet/corefx/issues/36331
* Rework
* Move GetOrOpenProcessHandle into Windows EnsureWatchingForExit
* Code formatting
Commit migrated from https://github.com/dotnet/corefx/commit/
cd710b371a1ae86f0c215261b021101d491910a1
David Shulman [Mon, 25 Mar 2019 18:39:33 +0000 (11:39 -0700)]
Fix Kerberos/NTLM for multiple domain/realm environments in Linux (dotnet/corefx#36329)
This PR addresses some issues reported by a customer (not thru GitHub). They noticed that
multiple domain scenarios were working in .NET Core 2.0 but broke in .NET Core 2.1 on Linux.
While the previous PR dotnet/corefx#35383 solved the Negotiate Kerberos to NTLM fallback issue,
it added more complexity than necessary. The retry logic I added wasn't really necessary
because the original code that used GSS_KRB5_NT_PRINCIPAL_NAME format for the target name
was wrong. That logic only works for pure Kerberos environments and doesn't handle domain
or realm referrals. So, it only handles the default Kerberos realm on the the single Linux
client. In addition, using GSS_KRB5_NT_PRINCIPAL_NAME defeats the logic of the SPNEGO mechanism. That is why I originally needed to add the retry logic using GSS_C_NT_HOSTBASED_SERVICE format for the target name.
The multiple domain/realm scenario worked in .NET Core 2.0 because it used CurlHandler.
And libcurl always uses GSS_C_NT_HOSTBASED_SERVICE format for target name.
This PR reworks the logic to use the GSS_C_NT_HOSTBASED_SERVICE format. It also removes the
now unneeded retry logic. I tested this against Windows and Linux as well as pure Kerberos
and Kerberos to NTLM fallback (using SPNEGO).
I added more tests. These tests are currently part of the enterprise scenario tests we are
building. They are activated via environment variables.
By defining all of the environment variables below, I am able to run the System.Net.Security
and System.Net.Http enterprise-scenario tests. Both SocketsHttpHandler in System.Net.Http and
NegotiateStream in System.Net.Security use the same common GSS-API logic in CoreFx.
Define domain-joined server remote endpoint:
* COREFX_NET_SECURITY_NEGOSERVERURI
* COREFX_DOMAINJOINED_HTTPHOST
* COREFX_NET_AD_DOMAINNAME
* COREFX_NET_AD_PASSWORD
* COREFX_NET_AD_USERNAME
Define standalone server remote endpoint:
* COREFX_WINDOWSSERVER_HTTPHOST
* COREFX_NET_SERVER_PASSWORD
* COREFX_NET_SERVER_USERNAME
Commit migrated from https://github.com/dotnet/corefx/commit/
658ec735698affec9ce99a59a9342bf7ac5778db
dotnet-maestro-bot [Mon, 25 Mar 2019 14:42:06 +0000 (07:42 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27525-00, beta-27525-00, respectively (dotnet/corefx#36332)
Commit migrated from https://github.com/dotnet/corefx/commit/
aed4009a7d58a34c2fb9f3b4739a027a8309f4da
Nick Schonning [Sun, 24 Mar 2019 20:47:05 +0000 (16:47 -0400)]
typo: infering -> inferring (dotnet/corefx#36315)
Commit migrated from https://github.com/dotnet/corefx/commit/
d3942d4671919edb0cca6ddc1840190f524a809d
Nick Schonning [Sun, 24 Mar 2019 20:45:38 +0000 (16:45 -0400)]
typo: ArgumenNullException -> ArgumentNullException (dotnet/corefx#36316)
Commit migrated from https://github.com/dotnet/corefx/commit/
07a810549072855ea5214060d0ca6e50fd634f33
Nick Schonning [Sun, 24 Mar 2019 20:44:51 +0000 (16:44 -0400)]
typo: Double word "never" (dotnet/corefx#36300)
Commit migrated from https://github.com/dotnet/corefx/commit/
e86b522c7d25985224e6e06f4746e2ae42a50b77
Nick Schonning [Sun, 24 Mar 2019 20:44:15 +0000 (16:44 -0400)]
typo: Double word "on" (dotnet/corefx#36265)
Commit migrated from https://github.com/dotnet/corefx/commit/
63d0fb143a66400fd62099f60cd7958b8461ffda
Nick Schonning [Sun, 24 Mar 2019 20:43:54 +0000 (16:43 -0400)]
typo: Double word "to" (dotnet/corefx#36264)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a3bb4814319b31de87d5ff2c73c2b55f5e209f1
Nick Schonning [Sun, 24 Mar 2019 20:43:29 +0000 (16:43 -0400)]
typo: Double word "from" (dotnet/corefx#36266)
Commit migrated from https://github.com/dotnet/corefx/commit/
47b33a152bce3a8c097de62dec9c0dd10826c2aa
Nick Schonning [Sun, 24 Mar 2019 20:43:04 +0000 (16:43 -0400)]
typo: Double word "that" (dotnet/corefx#36269)
Commit migrated from https://github.com/dotnet/corefx/commit/
591afaa5155b7f4402ab67ab827df29bb941b99a
Nick Schonning [Sun, 24 Mar 2019 20:42:29 +0000 (16:42 -0400)]
typo: Double word "be" (dotnet/corefx#36267)
Commit migrated from https://github.com/dotnet/corefx/commit/
1a31fdb873bf998a93aa4715a66e83d7b9d208b4
Nick Schonning [Sun, 24 Mar 2019 20:42:07 +0000 (16:42 -0400)]
typo: Double word "they" (dotnet/corefx#36268)
Commit migrated from https://github.com/dotnet/corefx/commit/
075b85c5e23ce3a7d1de3b647827563fcd3e5c00
Nick Schonning [Sun, 24 Mar 2019 20:41:37 +0000 (16:41 -0400)]
typo: Double word "in" (dotnet/corefx#36270)
* typo: Double word "in"
* Update src/System.Console/src/System/Console.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
be1561c8fd02411c60edf551aa2c4f48377281d6
Nick Schonning [Sun, 24 Mar 2019 20:41:06 +0000 (16:41 -0400)]
typo: Double word "a" (dotnet/corefx#36271)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cfd38ee1b889cf5e5d47e78e9c6579856ce6b3c
Nick Schonning [Sun, 24 Mar 2019 20:40:35 +0000 (16:40 -0400)]
typo: Double word "this" (dotnet/corefx#36273)
Commit migrated from https://github.com/dotnet/corefx/commit/
97e6256f05945f7b20025e5c14cae6a8871c87ef
Nick Schonning [Sun, 24 Mar 2019 20:40:10 +0000 (16:40 -0400)]
typo: Double word "the" (dotnet/corefx#36274)
* typo: Double word "the"
* Apply suggestions from code review
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
aa67d40064f652b48f7ee0cd85dbfe39c7deebac
Nick Schonning [Sun, 24 Mar 2019 20:38:32 +0000 (16:38 -0400)]
typo: Double word "for" (dotnet/corefx#36278)
Commit migrated from https://github.com/dotnet/corefx/commit/
45e06bf1dc8c95ba60a89c253ceefb75200f427e
Nick Schonning [Sun, 24 Mar 2019 20:38:10 +0000 (16:38 -0400)]
typo: Double word "should" (dotnet/corefx#36279)
Commit migrated from https://github.com/dotnet/corefx/commit/
25de6ddf6ba4248a1225762fa71a3793fd6a98e8
Nick Schonning [Sun, 24 Mar 2019 20:37:48 +0000 (16:37 -0400)]
typo: Double word "it" (dotnet/corefx#36280)
Commit migrated from https://github.com/dotnet/corefx/commit/
e8ce19a3485646cb45a8cecf30566629b98c04ff
Nick Schonning [Sun, 24 Mar 2019 20:37:20 +0000 (16:37 -0400)]
typo: Double word "when" (dotnet/corefx#36281)
Commit migrated from https://github.com/dotnet/corefx/commit/
bb7f2008c6ae0f391d7969ad5f102ff40f8acd83
Nick Schonning [Sun, 24 Mar 2019 20:36:59 +0000 (16:36 -0400)]
typo: Double word "at" (dotnet/corefx#36282)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a8df7168eb30c760880c4b78976048f24ea373f
Nick Schonning [Sun, 24 Mar 2019 20:36:34 +0000 (16:36 -0400)]
typo: Double word "is" (dotnet/corefx#36283)
Commit migrated from https://github.com/dotnet/corefx/commit/
6322be5f3b6010b29dd2402eb236c5881f7ae6de
Nick Schonning [Sun, 24 Mar 2019 20:36:10 +0000 (16:36 -0400)]
typo: Double word "were" (dotnet/corefx#36284)
Commit migrated from https://github.com/dotnet/corefx/commit/
3cc4cd7585e71741b5b4e3a4a9e84abf5a5b3545
Nick Schonning [Sun, 24 Mar 2019 20:35:42 +0000 (16:35 -0400)]
typo: Double word "into" (dotnet/corefx#36285)
Commit migrated from https://github.com/dotnet/corefx/commit/
98b3c513c6961a84c2fd4a34fa2899dd5b0211c0
Nick Schonning [Sun, 24 Mar 2019 20:35:19 +0000 (16:35 -0400)]
typo: Double word "if" (dotnet/corefx#36287)
Commit migrated from https://github.com/dotnet/corefx/commit/
1d90371b87ace4c18de620c0df9365592c378743
Nick Schonning [Sun, 24 Mar 2019 20:34:57 +0000 (16:34 -0400)]
typo: Double word "we" (dotnet/corefx#36288)
Commit migrated from https://github.com/dotnet/corefx/commit/
e949cd08e8dded42cad58f451fc12f5c75949780
Nick Schonning [Sun, 24 Mar 2019 20:34:26 +0000 (16:34 -0400)]
typo: Double word "old" (dotnet/corefx#36289)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf57fa6009a0b82e5a011a42770ce9b77a41c276
Nick Schonning [Sun, 24 Mar 2019 20:34:02 +0000 (16:34 -0400)]
typo: Double word "get" (dotnet/corefx#36290)
Commit migrated from https://github.com/dotnet/corefx/commit/
8d8efa4f09e216242f16910c3b0b3be173a7c2c7
Nick Schonning [Sun, 24 Mar 2019 20:33:40 +0000 (16:33 -0400)]
typo: Double word "no" (dotnet/corefx#36299)
Commit migrated from https://github.com/dotnet/corefx/commit/
20bfcdab43877055a8e0b7dc910cd7e66f3a9903
Nick Schonning [Sun, 24 Mar 2019 20:33:08 +0000 (16:33 -0400)]
typo: arguemnts -> arguments (dotnet/corefx#36306)
Commit migrated from https://github.com/dotnet/corefx/commit/
ff82f8b010021657c7e8dc40a2f78e8ed443fec9
Nick Schonning [Sun, 24 Mar 2019 20:32:44 +0000 (16:32 -0400)]
typo: Double word "over" (dotnet/corefx#36296)
Commit migrated from https://github.com/dotnet/corefx/commit/
5bddeb29c4821ab13c2b26338a90e9ff18c9afb8
Nick Schonning [Sun, 24 Mar 2019 20:32:15 +0000 (16:32 -0400)]
typo: Double word "than" (dotnet/corefx#36295)
Commit migrated from https://github.com/dotnet/corefx/commit/
86af3ac4c9d1d34c4bdf61a2a170ed83bf937696
Nick Schonning [Sun, 24 Mar 2019 20:31:53 +0000 (16:31 -0400)]
typo: Double word "or" (dotnet/corefx#36291)
Commit migrated from https://github.com/dotnet/corefx/commit/
35f52c329dffbeb6e79cc2b51e2d966bbb3402fd
Nick Schonning [Sun, 24 Mar 2019 20:31:24 +0000 (16:31 -0400)]
typo: Double word "and" (dotnet/corefx#36301)
* typo: Double word "and"
* Update src/System.Linq.Expressions/tests/BinaryOperators/Bitwise/BinaryExclusiveOrTests.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
9978c8db1d5d6496d133627446bfc9165f207264
Nick Schonning [Sun, 24 Mar 2019 20:30:29 +0000 (16:30 -0400)]
typo: Double word "set" (dotnet/corefx#36293)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a1f9024a44865cd46fb43795bd3ddad6e379e87
Nick Schonning [Sun, 24 Mar 2019 20:29:41 +0000 (16:29 -0400)]
typo: Similarily -> Similarly (dotnet/corefx#36305)
Commit migrated from https://github.com/dotnet/corefx/commit/
eef2c036a727bdae8f94b06b319a8f223a9403c5
Nick Schonning [Sun, 24 Mar 2019 20:29:15 +0000 (16:29 -0400)]
typo: rearange -> rearrange (dotnet/corefx#36302)
Commit migrated from https://github.com/dotnet/corefx/commit/
c7184a05826f62d090c71368661149b4fb1909c3
Nick Schonning [Sun, 24 Mar 2019 20:28:44 +0000 (16:28 -0400)]
typo: Simplied -> Simplified (dotnet/corefx#36313)
- Falback -> Fallback
Commit migrated from https://github.com/dotnet/corefx/commit/
0306790ea27c2f40b34de7ee5ced4565249d14a0
Nick Schonning [Sun, 24 Mar 2019 20:27:50 +0000 (16:27 -0400)]
typo: Procider -> Provider (dotnet/corefx#36310)
Commit migrated from https://github.com/dotnet/corefx/commit/
21e6dc84663aa8b9036730733c1c4b8854e5dbf9
Nick Schonning [Sun, 24 Mar 2019 20:27:27 +0000 (16:27 -0400)]
typo: excpetions -> exceptions (dotnet/corefx#36308)
Commit migrated from https://github.com/dotnet/corefx/commit/
e25fd65195e9538499d9f65fdd1c8536830b9170
Nick Schonning [Sun, 24 Mar 2019 20:27:03 +0000 (16:27 -0400)]
typo: Double word "Version" (dotnet/corefx#36297)
Looks like old commented out code
Commit migrated from https://github.com/dotnet/corefx/commit/
3ff2bf2051e030c8e30c1e98550fa45736b9b143
Nick Schonning [Sun, 24 Mar 2019 20:26:37 +0000 (16:26 -0400)]
typo: Double word "my" (dotnet/corefx#36298)
* typo: Double word "my"
* Update src/System.Private.Xml/src/System/Xml/Xsl/Xslt/XslAstAnalyzer.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
* typo: depend -> depends
Commit migrated from https://github.com/dotnet/corefx/commit/
8676c526ade623c0eb41a09deb9b11ae718a89c8
Nick Schonning [Sun, 24 Mar 2019 20:26:09 +0000 (16:26 -0400)]
typo: Double word "have" (dotnet/corefx#36286)
Commit migrated from https://github.com/dotnet/corefx/commit/
85c15c2a0ca211eee54fd89d3143f0620aefb303
Nick Schonning [Sun, 24 Mar 2019 20:25:27 +0000 (16:25 -0400)]
typo: Double word "methods" (dotnet/corefx#36294)
Commit migrated from https://github.com/dotnet/corefx/commit/
e37dd4fb6eab9f62a45b52cc34dd8bf2e071d052
Nick Schonning [Sun, 24 Mar 2019 20:24:58 +0000 (16:24 -0400)]
typo: exisiting -> existing (dotnet/corefx#36303)
Commit migrated from https://github.com/dotnet/corefx/commit/
9950ab52b14ac9c01c001472bb2592c284aa643a
Nick Schonning [Sun, 24 Mar 2019 20:24:26 +0000 (16:24 -0400)]
typo: asociated -> associated (dotnet/corefx#36307)
Commit migrated from https://github.com/dotnet/corefx/commit/
3db0ad26e7c08e6515f3b99b5f1abb202e27afe0
Nick Schonning [Sun, 24 Mar 2019 20:24:01 +0000 (16:24 -0400)]
typo: Constrast -> Contrast (dotnet/corefx#36309)
Commit migrated from https://github.com/dotnet/corefx/commit/
25e017e845539affbe39938416f73e099c3433aa
Nick Schonning [Sun, 24 Mar 2019 20:23:26 +0000 (16:23 -0400)]
typo: explaination -> explanation (dotnet/corefx#36304)
Commit migrated from https://github.com/dotnet/corefx/commit/
e6bfaf4ab82b45e33368e80226fe6097367f48b7
Nick Schonning [Sun, 24 Mar 2019 20:22:59 +0000 (16:22 -0400)]
typo: Double word "with" (dotnet/corefx#36292)
Commit migrated from https://github.com/dotnet/corefx/commit/
39be8ad93570eee3de91e46104ea94e6f14a727d
Nick Schonning [Sun, 24 Mar 2019 20:22:14 +0000 (16:22 -0400)]
typo: propegate -> propagate (dotnet/corefx#36311)
Commit migrated from https://github.com/dotnet/corefx/commit/
dd9511f132fe00bbf439c1d10db6cae8bf83caac
Wraith2 [Sun, 24 Mar 2019 13:04:55 +0000 (13:04 +0000)]
add console debug into to TestPacketnumberWraparound and extend timeout for CI
Commit migrated from https://github.com/dotnet/corefx/commit/
7869e4d858378b21fa1df7f543b24bc0692cd242
Erhan Atesoglu [Sat, 23 Mar 2019 23:18:54 +0000 (16:18 -0700)]
Fixed Project's Interop.Zlib.cs link to use common/src/Interop instead. (dotnet/corefx#36253)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3effbbd54289597f711cceda6bc3a56e825230b
Steve Harter [Sat, 23 Mar 2019 18:50:51 +0000 (11:50 -0700)]
Add serializer programming model doc (dotnet/corefx#36259)
Commit migrated from https://github.com/dotnet/corefx/commit/
3e9860314a67d13885c19f11918aa711f1912f18
Levi Broderick [Sat, 23 Mar 2019 04:46:32 +0000 (21:46 -0700)]
Add ASCIIUtility tests (dotnet/corefx#36227)
Commit migrated from https://github.com/dotnet/corefx/commit/
c50a04ab209526f37850560a5164ac02887f6df9
Layomi Akinrinade [Sat, 23 Mar 2019 00:58:36 +0000 (20:58 -0400)]
Add (Try)GetGuid to Utf8JsonReader (dotnet/corefx#36122)
* Add (Try)GetGuid to Utf8JsonReader
This partially addresses https://github.com/dotnet/corefx/issues/34690.
* Address review feedback
* Address memory-related comments
* Address more review comments
* Re-add length check for span to be parsed
* Reduce code duplication
Commit migrated from https://github.com/dotnet/corefx/commit/
ab9d80e25d0c4d579afd41d024b9f94d91bc7fdc
Ahson Khan [Sat, 23 Mar 2019 00:14:57 +0000 (17:14 -0700)]
Correctly show the '}', ']' within the exception message in Utf8JsonWriter (dotnet/corefx#36229)
* Correctly show the '{', '[' within the exception message in
Utf8JsonWriter
* Address PR feedback - don't make throwhelper parameters optional.
Commit migrated from https://github.com/dotnet/corefx/commit/
d3b66400c6b415416163b865a7856a7e93de3338
Stephen Toub [Fri, 22 Mar 2019 23:36:03 +0000 (19:36 -0400)]
Fix WSAStartup interop (dotnet/corefx#36245)
Our WSAStartup interop is incorrect, but thankfully other than it adding some unnecessary cost, it doesn't actually break anything.
The WSADATA struct in Windows differs in layout between 32-bit and 64-bit, making our interop signature wrong. But, we don't actually read out any of the resulting data, so the incorrectness doesn't negatively impact consumption. It does incur some unnecessary cost, though, in that the marshaling attributes and the inclusion of `string` in the struct is causing two strings to be allocated that are unnecessary.
This change just deletes the contents of the struct so as to avoid any potential future misuse and to eliminate those allocations. It then uses the Size on the StructLayout to ensure that the struct is large enough for either the 32-bit or 64-bit interop cases. And it hides this all with private visibility so that it doesn't leak out into the consuming code.
Commit migrated from https://github.com/dotnet/corefx/commit/
958b6e380a4f6151c7451e089a490baff7c61634
Stephen Toub [Fri, 22 Mar 2019 22:21:56 +0000 (18:21 -0400)]
Avoid thread pool work item allocation in Socket.Send/ReceiveAsync (dotnet/corefx#36242)
In an async method when you await a task, there are effectively three possible flows:
1. the task is already completed, and execution simply continues
2. the task is not yet completed, we hook up a continuation, and at some point later the task completes and invokes the continuation
3. the task is not yet completed, but by the time we go to hook up the continuation, it has completed.
In case (3), the C# await code is already assuming that things are completing asynchronously, so we can't just keep executing the C# code synchronously. And if we were to invoke the delegate synchronously, we risk a stack dive, as we're now further down the stack, and if that kept happening, we could run out of stack space. So we're forced to queue the continuation.
With sockets, case (3) happens more frequently than we might expect: data isn't available immediately but is very soon. Every time it does, we incur an allocation from using QueueUserWorkItem.
However, in the common case where we're inside an async method, which means it's handling ExecutionContext flow for us, and we can instead use UnsafeQueueUserWorkItem, which has a fast-path that's AsyncStateMachineBox-aware, and can avoid a work item allocation if the continuation/state are coming from an async method.
So, this change just sees whether we need to flow context, and if we don't, uses UnsafeQueueUserWorkItem instead of QueueUserWorkItem, avoiding the allocation in the common case.
Commit migrated from https://github.com/dotnet/corefx/commit/
0d698f1496c33ddf23735b45164e39d5a093899b
Max Kerr [Fri, 22 Mar 2019 21:56:14 +0000 (14:56 -0700)]
Add additional diagnostics to PostAsync_RedirectWith307_LargePayload (dotnet/corefx#36239)
* Add additional diagnostics.
* Remove redundant check.
Commit migrated from https://github.com/dotnet/corefx/commit/
eca5e9b5399475750d0562752428885220a3c927
dotnet-maestro-bot [Fri, 22 Mar 2019 14:39:36 +0000 (07:39 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27522-00, beta-27522-00, respectively (dotnet/corefx#36230)
Commit migrated from https://github.com/dotnet/corefx/commit/
31781586a489a7cecc61bc3d1f14fc0edbb3be06
Tom Deseyn [Fri, 22 Mar 2019 14:01:33 +0000 (15:01 +0100)]
Process.Kill: don't throw for exited processes (dotnet/corefx#36184)
* Process.Kill: don't throw for exited processes
Implements https://github.com/dotnet/corefx/issues/35257
* Fix exception type
* Fix Windows build failure
* Windows: avoid HasExited side-effects, Unix: refactor code a bit
* Unix: fix error code check
* Refactor test to eliminate timeouts
* Remove !HasExited checks before Process.Kill calls
Commit migrated from https://github.com/dotnet/corefx/commit/
1a04816bf3c5be25de09c6cfbb4290752583713b
Stephen Toub [Fri, 22 Mar 2019 06:55:05 +0000 (02:55 -0400)]
Fix build break in System.Console due to conflicting PRs (dotnet/corefx#36231)
Commit migrated from https://github.com/dotnet/corefx/commit/
c63e5e712e58b8c418921e3224e11f36712deda7
Tom Deseyn [Fri, 22 Mar 2019 02:49:42 +0000 (03:49 +0100)]
Console: Unix: Improve Cursor{Left,Top} performance by caching them (dotnet/corefx#36049)
* Console: Unix: Improve Cursor{Left,Top} performance by caching them
We keep a cached version for CursorLeft and CursorTop. When we write
data to stdout, we try to update the cached values based on the buffer
content, or we invalidate the cursor position.
A lock is used to deal with multi-threading issues. We synchronize
between some blocks using a 'version' field. This field is incremented
each time a cursor change may have occured. If the value has not
changed between two blocks, we know the the cursor is still at the same
position.
On signals that may mean the cursor position has changed (SIGCONT,
SIGCHLD, SIGWINCH) we invalidate the cached values.
* PR feedback
* lock on Console.Out and rework invalidation on signals
* fix: pass cursorVersion also in UpdateCachedCursorPosition
* Since we check invalidated before reading cached settings, there is no need to invalidate after writing
* Use GetWindowSize instead of getting WindowWidth, WindowHeight
* Update comment
* Fix swapped width and height
* ReadKey: avoid write call for '\0' characters
Commit migrated from https://github.com/dotnet/corefx/commit/
be7db2582f9842927a57e66863cc6212d7d6f67b
Santiago Fernandez Madero [Fri, 22 Mar 2019 00:23:38 +0000 (17:23 -0700)]
Enable publishing build logs in the publish step (dotnet/corefx#36225)
Commit migrated from https://github.com/dotnet/corefx/commit/
00c395eeff363e0ed890622e068817c8d463a72b
Steve Harter [Thu, 21 Mar 2019 23:49:47 +0000 (18:49 -0500)]
Fix issue with object stack frame re-use (dotnet/corefx#36218)
Commit migrated from https://github.com/dotnet/corefx/commit/
59c5ebe82e223fa77ee33bdeea927e9a68c207ba
Steve Harter [Thu, 21 Mar 2019 21:49:55 +0000 (16:49 -0500)]
Add JsonSerializer Xml doc and change DefaultBufferSize semantics (dotnet/corefx#36201)
Commit migrated from https://github.com/dotnet/corefx/commit/
67482220ab7cd18092ccf62749355d280ece4cea
dotnet-maestro-bot [Thu, 21 Mar 2019 20:05:20 +0000 (13:05 -0700)]
Update BuildTools, ProjectNTfs, ProjectNTfsTestILC to preview1-03805-01, beta-27521-00, beta-27521-00, respectively (dotnet/corefx#36215)
Commit migrated from https://github.com/dotnet/corefx/commit/
a1027e9c932a716da65825223e5dce635dcba30f
Stephen Toub [Thu, 21 Mar 2019 18:34:05 +0000 (14:34 -0400)]
Tweak Console's read buffer size (dotnet/corefx#36212)
Unlike most buffer sizes throughout .NET, where buffer size primarily impacts performance, the size used for the Console's read buffer actually impacts visible functionality to an end user. On Windows, when ReadFile/Console are called to read from a cmd window configured in the default fashion, the size of the buffer passed in determines how long a line can be typed by the user; the shorter the buffer, the less the user will be able to type. Currently .NET uses a buffer of size 256, which ends up meaning a user can't type a line longer than 254 characters.
There is also a performance impact to the buffer size of the read buffer, in that (in particular for redirected input where the input might be coming from a large file) the smaller the buffer the more reads are required to consume the contents of the file. In local measurements, reading a 365M text file with Console.ReadLine took ~6s with a 256 char buffer and ~1.3s with a 4K char buffer (a 16K char buffer improved on that only slightly, at around ~1.1s). Changing the size of the write buffers doesn't have a significant impact in contrast, as Console is configured to flush automatically on every read.
In experimenting with other languages/environments, I found that VC++, Go, and Rust by default all appear to use a 4K buffer (it looks like Python defaults to a 16K buffer).
Given all this, I'm changing Console's read buffer to be 4096 chars instead of 256 chars. I've left the rest of the buffer sizes at 256, but consolidated some of the constants.
If a developer wants a larger or smaller size, they can effectively change it with:
```C#
Console.SetIn(new StreamReader(Console.OpenStandardInput(), Encoding.UTF8, false, BufferSize));
```
Commit migrated from https://github.com/dotnet/corefx/commit/
f37461280a3c843000aa79642ba700baa5a1fc30
Santiago Fernandez Madero [Thu, 21 Mar 2019 17:57:21 +0000 (10:57 -0700)]
Move test ilc to 1.0.0 since that is the version the produce in the dev branch (dotnet/corefx#36214)
Commit migrated from https://github.com/dotnet/corefx/commit/
97effb6eb90bd1cb3b83550610b39d068d276581
Liudmila Molkova [Thu, 21 Mar 2019 17:50:50 +0000 (10:50 -0700)]
Ignore invalid correlation context tokens in Http Diagnostics Listener (dotnet/corefx#35906)
* Fix 31687: ignore invalid correlation context tokens
* add comments
* Add outerloop category
* url-encode correlation context keys and values
Commit migrated from https://github.com/dotnet/corefx/commit/
fcbd6804cee9ededfb9db50d7540749640137952
Liudmila Molkova [Thu, 21 Mar 2019 17:19:26 +0000 (10:19 -0700)]
Fix 31687 on netfx: escape Correlation-Context keys and values (dotnet/corefx#36203)
* Fix 31687 on Desktop: escape Correlation-Context keys and values
* review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
39f825ed5fe5a19b0379f0ac0e7113f6d1b5d7b6
Viktor Hofer [Thu, 21 Mar 2019 17:01:23 +0000 (18:01 +0100)]
Fix update-dependencies maestro invocations
Commit migrated from https://github.com/dotnet/corefx/commit/
922492558648039b520d40941966486921a8da19
Stephen Toub [Thu, 21 Mar 2019 16:52:52 +0000 (12:52 -0400)]
Make Process.{Safe}Handle be a waitable event handle on Unix (dotnet/corefx#36199)
The documentation for Process.{Safe}Handle state that its value can be used to initialize a SafeWaitHandle that can then be used with a method like WaitHandle.WaitAny. However, on Unix, the SafeProcessHandle we currently return from Process.SafeHandle just uses the process ID as its faux handle value, since on Unix there isn't actually an OS process handle that's waitable in this fashion.
We already have to manufacture a ManualResetEvent to serve as such a wait handle, though. as we use that for WaitForExit, raising the Exited event, and so on. As such, we can change SafeProcessHandle to be backed by that MRE's handle rather than by the process ID.
Commit migrated from https://github.com/dotnet/corefx/commit/
71122bb4921e0239ea679dd275d53695b94e52f4
bitbonk [Thu, 21 Mar 2019 16:49:12 +0000 (17:49 +0100)]
Update old reference of ASP.NET 5
Commit migrated from https://github.com/dotnet/corefx/commit/
7f19370238c42dacfc2a5399ebb0bdce28450e59
Viktor Hofer [Thu, 21 Mar 2019 16:25:52 +0000 (17:25 +0100)]
Disable Match_ExcessPrefix on ARM (dotnet/corefx#36209)
Commit migrated from https://github.com/dotnet/corefx/commit/
9b9e7a777fe1040ff18d189740be6306eb2dbba0
Viktor Hofer [Thu, 21 Mar 2019 12:09:04 +0000 (13:09 +0100)]
Merge pull request dotnet/corefx#35781 from adamsitnik/removePerfTests
Switch to the dotnet/performance repo
Commit migrated from https://github.com/dotnet/corefx/commit/
d395dafdb31fde67cb8632de75f5c85f6575f176
Wraith2 [Thu, 21 Mar 2019 00:05:44 +0000 (00:05 +0000)]
Merge remote-tracking branch 'dotnet/master' into sqlfix-13439
Commit migrated from https://github.com/dotnet/corefx/commit/
835440e01612cf9c623afd9a634c6519bc95bbac
Tarikul Sabbir [Wed, 20 Mar 2019 23:13:06 +0000 (16:13 -0700)]
Merge pull request dotnet/corefx#35549 from Wraith2/sqlfix-34414
SqlClient shrink SqlParameter and fix 34414
Commit migrated from https://github.com/dotnet/corefx/commit/
cd45097d0066c936676ce1f35958e715dc250a44
David Shulman [Wed, 20 Mar 2019 20:15:58 +0000 (13:15 -0700)]
Fix HttpWebRequest proxy test (dotnet/corefx#36191)
Change test so that it doesn't trip up CredScan.
Fixes dotnet/corefx#36187
Commit migrated from https://github.com/dotnet/corefx/commit/
d09d8f77620ff2c62d2245c5093c3fcfcf4c8352
Adam Sitnik [Wed, 20 Mar 2019 19:35:37 +0000 (20:35 +0100)]
update the docs
Commit migrated from https://github.com/dotnet/corefx/commit/
be8fe7d2402b9f8a8f1a19472d7a36d71296225d
Wraith2 [Wed, 20 Mar 2019 19:49:19 +0000 (19:49 +0000)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
a15c35040c6bdcf8a7e762ed5071ad2a19be426b
Tyler Brinkley [Wed, 20 Mar 2019 19:07:51 +0000 (14:07 -0500)]
Removed need for Nullable converters in Json serialization (dotnet/corefx#35754)
Added support for Nullable<T> properties where a Nullable converter is no longer required.
Enum converter has generic constraint to `Enum` type.
Commit migrated from https://github.com/dotnet/corefx/commit/
b0751dcd4a419ba6731dcaa7d240a8a1946c934c
Jan Kotas [Wed, 20 Mar 2019 15:09:01 +0000 (08:09 -0700)]
Delete *.netcoreappaot.txt baselines
Commit migrated from https://github.com/dotnet/corefx/commit/
1caac52208d277ce673e17bc0069ded9b9fcb4c2
Jan Kotas [Wed, 20 Mar 2019 00:09:11 +0000 (17:09 -0700)]
Delete remaining uses of RuntimeThread
Update ProjectNTfs dependency
Commit migrated from https://github.com/dotnet/corefx/commit/
1f65248b2bc62b35818789e56b913ac87d794445