platform/upstream/efl.git
4 years agoefl_ui_layout_part_*: declare stable
Marcel Hollerbach [Tue, 17 Sep 2019 14:41:49 +0000 (16:41 +0200)]
efl_ui_layout_part_*: declare stable

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9995

4 years agoefl_ui_widget_*: declare parts stable
Marcel Hollerbach [Tue, 17 Sep 2019 13:59:07 +0000 (15:59 +0200)]
efl_ui_widget_*: declare parts stable

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9994

4 years agoefl_ui_layout_part_box/table: remove real_part_set
Marcel Hollerbach [Tue, 17 Sep 2019 14:39:55 +0000 (16:39 +0200)]
efl_ui_layout_part_box/table: remove real_part_set

real part set was used to set the real part on the part, so the obj
pointer of Layout_Part_Data points to the correct evas object. With this
commit, this API is removed from the public .eo files, and is refactored
into the same API which is private.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9993

4 years agoefl_ui_layout_part_table: implement Efl.Pack.pack API
Marcel Hollerbach [Tue, 17 Sep 2019 14:25:37 +0000 (16:25 +0200)]
efl_ui_layout_part_table: implement Efl.Pack.pack API

this api was missing, the pack method here is behaving in the same
manner as Efl.Ui.Table.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9992

4 years agoefl_ui_widget_part: implement all the missing API
Marcel Hollerbach [Tue, 17 Sep 2019 13:51:54 +0000 (15:51 +0200)]
efl_ui_widget_part: implement all the missing API

Efl.Color and Efl.File cannot be done due to composition. Efl.Gfx.Image
can, so we can solve this via composition, this also resolves all the
other cases for Efl.Gfx.Image.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9991

4 years agoefl_test_multi_selectable: test for the correct event
Marcel Hollerbach [Wed, 18 Sep 2019 15:42:28 +0000 (17:42 +0200)]
efl_test_multi_selectable: test for the correct event

EFL_UI_EVENT_ITEM_SELECTED / UNSELECTED is the wrong event here. We
should check of the selection changed event. ITEM_SELECTED is the legacy
event. this was not found based on the fact that we test for this event
to NOT be executed.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10011

4 years agoelm_test_widget_focus: cleanup callbacks correctly
Marcel Hollerbach [Thu, 19 Sep 2019 12:43:31 +0000 (14:43 +0200)]
elm_test_widget_focus: cleanup callbacks correctly

we need to delete the callback here, otherwise the objects are deleted
later on, which:
- changes focus, which leads to
- callbacks executed with stacked addresses from a dead function

this fixes a testsuite failure on the release build.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10020

4 years agoefl_ui_collection: fix null pointer dereferences
Yeongjong Lee [Tue, 17 Sep 2019 09:15:05 +0000 (09:15 +0000)]
efl_ui_collection: fix null pointer dereferences

This will fix Coverity issue.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9986

4 years agoeo: custom created legacy events should be unfreezable
Marcel Hollerbach [Thu, 19 Sep 2019 07:27:59 +0000 (09:27 +0200)]
eo: custom created legacy events should be unfreezable

a while back we have moved event submission from custom lists to eo
events. We also merged together the freeze and thaw functions, however,
this brought up one bug. smart_callbacks and the likes (those that used
custom lists before) are not effected by the legacy freeze and thaw
functions. This means, we should declare these legacy wrapper objects
unfreezable in order to obtain this behaviour.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10016

4 years agoefl_ui: further unbreak headers
Mike Blumenkrantz [Thu, 19 Sep 2019 14:54:47 +0000 (10:54 -0400)]
efl_ui: further unbreak headers

move more header includes around to fix building with Efl_Ui.h

ref T8228

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10022

4 years agoecore/signal: increase maximum signal throughput
Mike Blumenkrantz [Thu, 19 Sep 2019 18:52:23 +0000 (14:52 -0400)]
ecore/signal: increase maximum signal throughput

this adds 4 more signal handling fds and loops over them for reading/writing
signal info in order to handle more signals when the buffer of one (or more)
pipes is full

also update the unit test to verify that we are receiving all the events without
dropping any and bump the number of signals to 2000 since we should now be able to
handle that many

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10027

4 years agotests/ecore: add stress test for main loop signal handling
Mike Blumenkrantz [Thu, 19 Sep 2019 18:15:45 +0000 (14:15 -0400)]
tests/ecore: add stress test for main loop signal handling

this explodes after about 500 signals, so make it 1000 for a good test

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10026

4 years agoecore/signal: also use nonblock for writing side of signal pipe
Mike Blumenkrantz [Thu, 19 Sep 2019 18:03:59 +0000 (14:03 -0400)]
ecore/signal: also use nonblock for writing side of signal pipe

if any efl-based process receives a bunch of signals in a short period of
time, it will deadlock in the signal handler. this is unavoidable given the
current signal handling architecture

by setting nonblock, we can at least avoid deadlocking even if it means we'll
be losing signal events

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10025

4 years agoecore_evas_tbm: set tbm_surface_queue to ecore window 37/214037/2
Changyeon Lee [Mon, 16 Sep 2019 12:31:52 +0000 (21:31 +0900)]
ecore_evas_tbm: set tbm_surface_queue to ecore window

Change-Id: I598666204d347c84a7af233865addf94bb07a868

4 years agobuild: resolve build error
Jongmin Lee [Thu, 19 Sep 2019 22:48:18 +0000 (07:48 +0900)]
build: resolve build error

Efl_Ui.h include some private headers that are not installed, therefore
application that include Efl_Ui.h became failed to build due to missing
private headers. This patch install private headers to include directories
in order to avoid those build errors

@tizen_fix

Change-Id: I94323ff9a749cbe2014cacd2a09ab0eda75f5abd

4 years agobuild: resolve build error according to header cleaning up
Jongmin Lee [Thu, 19 Sep 2019 21:47:22 +0000 (06:47 +0900)]
build: resolve build error according to header cleaning up

@tizen_fix

Change-Id: I9d078a817c0d530423d35b60cd3cec5edb3a991e

4 years agoeolian: remove the composite keyword (replaced by composites)
Daniel Kolesa [Thu, 19 Sep 2019 16:17:37 +0000 (18:17 +0200)]
eolian: remove the composite keyword (replaced by composites)

4 years agoefl: replace composite with composites and dedup implements
Daniel Kolesa [Thu, 19 Sep 2019 15:32:56 +0000 (17:32 +0200)]
efl: replace composite with composites and dedup implements

Since using 'composites' now automatically implements what has not
been implemented yet, remove the unnecessary duplicates.

4 years agoeolian: allow composites keyword in place of composite
Daniel Kolesa [Thu, 19 Sep 2019 15:26:48 +0000 (17:26 +0200)]
eolian: allow composites keyword in place of composite

Fixes T8218.

4 years agoeolian: auto-add composited interfaces into implements if needed
Daniel Kolesa [Thu, 19 Sep 2019 14:49:31 +0000 (16:49 +0200)]
eolian: auto-add composited interfaces into implements if needed

The condition here is that the composited interface does not
already appear in the inheritance tree of the given class. If
it does, don't add. If it doesn't, add it to the class that
specifies the composited block.

4 years agodocs: Update documentation for Efl.Gfx.Color_Class
Xavi Artigas [Thu, 19 Sep 2019 14:51:04 +0000 (16:51 +0200)]
docs: Update documentation for Efl.Gfx.Color_Class

4 years agoeolian: return NULL instead of EINA_FALSE on safety checks
Daniel Kolesa [Thu, 19 Sep 2019 14:04:56 +0000 (16:04 +0200)]
eolian: return NULL instead of EINA_FALSE on safety checks

4 years agodocs: Update docs for Efl.Gfx.Image_Orientable
Xavi Artigas [Thu, 19 Sep 2019 11:11:00 +0000 (13:11 +0200)]
docs: Update docs for Efl.Gfx.Image_Orientable

4 years agoefl_model: fix links
Marcel Hollerbach [Thu, 19 Sep 2019 09:36:27 +0000 (11:36 +0200)]
efl_model: fix links

Summary: Depends on D10009

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10010

4 years agoefl_model: improve docs
Marcel Hollerbach [Thu, 19 Sep 2019 09:36:26 +0000 (11:36 +0200)]
efl_model: improve docs

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10009

4 years agodocs: Update documentation on Gestures
Xavi Artigas [Thu, 19 Sep 2019 09:17:49 +0000 (11:17 +0200)]
docs: Update documentation on Gestures

We need to keep in mind that the Manager and the Recognizers are not visible to the user.
The user only sees the events and the different Efl.Canvas.Gesture_* payloads.

4 years agodoc: fix typo and indentation.
Hermet Park [Thu, 19 Sep 2019 06:29:15 +0000 (15:29 +0900)]
doc: fix typo and indentation.

4 years agodoc: improves single line description of gesture class.
Myoungwoon Roy, Kim [Thu, 19 Sep 2019 06:23:07 +0000 (15:23 +0900)]
doc: improves single line description of gesture class.

Summary: This patch improves single line descriptions described on T7717

Test Plan: NA

Reviewers: segfaultxavi, woohyun, Hermet, cedric

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10002

4 years agoevas mask: refactoring code.
Hermet Park [Thu, 19 Sep 2019 04:59:05 +0000 (13:59 +0900)]
evas mask: refactoring code.

This clearly separate the condition cases clear so that
the analizyer tool doesn't bother us anymore.

No logical changes.

Change-Id: I8e543993bec16270b81031264c1ddb771a0c825f

4 years agoevas gl: remove unnecessary null check.
Hermet Park [Thu, 19 Sep 2019 04:39:48 +0000 (13:39 +0900)]
evas gl: remove unnecessary null check.

If we check reference validation, the rest of other usage
should keep the reference check as well.

Remove it since gl prorgram must be valid always here
to shutdown the static analyzer reporting this suspicous logic.

Change-Id: I26aea9b29756e36d36d5ea18415f07905849ffd9

4 years agoevas map: disable the anti_aliasing code which can't be reached.
Hermet Park [Thu, 19 Sep 2019 04:24:08 +0000 (13:24 +0900)]
evas map: disable the anti_aliasing code which can't be reached.

This anti-aliasing is a little buggy, should be improved.

But just leaving to fix later when it's necessary.

Change-Id: I00f4800e77562dc156b997a8206982f92fcc1d2d

4 years agoeolian: disallow void for out/inout for stable API
Daniel Kolesa [Wed, 18 Sep 2019 17:46:58 +0000 (19:46 +0200)]
eolian: disallow void for out/inout for stable API

4 years agotests/elm: add eventing test for normal check widget, verify api compatibility
Mike Blumenkrantz [Thu, 5 Sep 2019 14:53:59 +0000 (10:53 -0400)]
tests/elm: add eventing test for normal check widget, verify api compatibility

legacy check widgets should not emit a "changed" event when using the api to
change the widget's state

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9852

4 years agotests/check: add unit test for elm_toggle (check) callback
Mike Blumenkrantz [Tue, 3 Sep 2019 18:56:24 +0000 (14:56 -0400)]
tests/check: add unit test for elm_toggle (check) callback

verify that the "changed" callback is triggered as expected

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9832

4 years agoelm/check: fix emission of legacy "changed" callback
Mike Blumenkrantz [Wed, 18 Sep 2019 16:02:35 +0000 (12:02 -0400)]
elm/check: fix emission of legacy "changed" callback

legacy "check" and "toggle" widgets operate differently:
* check emits only the "toggle" event
* toggle emits "toggle", "on", "off"

legacy also must not emit events when the widget's state is changed
programmatically

to handle this effectively, check whether the event has been emitted for
each state when the signal is emitted from the theme, and track this
for subsequent uses to ensure that exactly one event is triggered
when it should be

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9831

4 years agoefl/radio/box: handle non-radio-objects
Mike Blumenkrantz [Tue, 17 Sep 2019 18:00:19 +0000 (14:00 -0400)]
efl/radio/box: handle non-radio-objects

this improves the usefulness of radio box by presenting it as a box widget
which has the additional feature of being able to manage radio widgets

also fix all the image cases in elm_test which relied on there being only
a single box in the window

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9998

4 years agobuild: firmly split legacy and unified API into Efl_Ui.h and Elementary.h
Mike Blumenkrantz [Mon, 16 Sep 2019 19:22:33 +0000 (15:22 -0400)]
build: firmly split legacy and unified API into Efl_Ui.h and Elementary.h

these headers should be usable independently without having one secretly
pull in the other

fix T7667

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9981

4 years agobuild: remove efl_ui_calendar.h
Mike Blumenkrantz [Mon, 16 Sep 2019 19:22:03 +0000 (15:22 -0400)]
build: remove efl_ui_calendar.h

this was somehow actually a legacy header which duplicated elm_calendar.h
...sort of

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9980

4 years agobuild: use correct animation_view headers in Efl_Ui.h and Elementary.h
Mike Blumenkrantz [Mon, 16 Sep 2019 19:17:15 +0000 (15:17 -0400)]
build: use correct animation_view headers in Efl_Ui.h and Elementary.h

efl_ui_animation_view.h is the legacy header (but why?)
efl_ui_animation_view.eo.h is the unified header

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9979

4 years agobuild: fix elm header usage
Mike Blumenkrantz [Mon, 16 Sep 2019 19:10:34 +0000 (15:10 -0400)]
build: fix elm header usage

.c files in src/lib/elementary should only include elm_priv.h to ensure
that all the include ordering is correct and that all necessary headers
are pulled in

.c files outside of src/lib/elementary should include either/both
Efl_Ui.h, Elementary.h as needed

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9978

4 years agoelm/priv: fix this header
Mike Blumenkrantz [Mon, 16 Sep 2019 19:09:27 +0000 (15:09 -0400)]
elm/priv: fix this header

this should include emotion, since that component is used internally,
and it should not explicitly include api headers which should be in
public headers

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9977

4 years agoelm/widget: make this header usable without elm_priv.h again
Mike Blumenkrantz [Mon, 16 Sep 2019 19:08:13 +0000 (15:08 -0400)]
elm/widget: make this header usable without elm_priv.h again

supposedly this header should be usable if someone wants to create an
elm widget, so ensure that it can be included without issues

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9976

4 years agoefl_ui/image_zoomable: include header for internal pan
Mike Blumenkrantz [Mon, 16 Sep 2019 19:07:38 +0000 (15:07 -0400)]
efl_ui/image_zoomable: include header for internal pan

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9975

4 years agoelm/scrollable: unbreak this header
Mike Blumenkrantz [Mon, 16 Sep 2019 18:59:56 +0000 (14:59 -0400)]
elm/scrollable: unbreak this header

this is a legacy header, it can't include any unified api types

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9974

4 years agobuild: add include guards for a couple elm headers
Mike Blumenkrantz [Mon, 16 Sep 2019 18:59:28 +0000 (14:59 -0400)]
build: add include guards for a couple elm headers

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9973

4 years agoefl_ui/win: fix prototype decls for eo api versions of autodel
Mike Blumenkrantz [Mon, 16 Sep 2019 18:57:49 +0000 (14:57 -0400)]
efl_ui/win: fix prototype decls for eo api versions of autodel

this is still pretty broken, but at least the headers aren't

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9972

4 years agobuild: use legacy api in places where legacy should be used
Mike Blumenkrantz [Mon, 16 Sep 2019 18:53:54 +0000 (14:53 -0400)]
build: use legacy api in places where legacy should be used

these seem to randomly have been changed when they shouldn't have

also install elm_clock_eo.h since this is required but we didn't install it

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9971

4 years agoTABS
Xavi Artigas [Wed, 18 Sep 2019 14:05:17 +0000 (16:05 +0200)]
TABS

4 years agocanvas vg: code refactoring.
Hermet Park [Wed, 18 Sep 2019 12:51:14 +0000 (21:51 +0900)]
canvas vg: code refactoring.

remove unnecessary reference cooridnates.

4 years agoelm_config: fix to check if eet_open fails
Wonki Kim [Wed, 18 Sep 2019 12:21:02 +0000 (08:21 -0400)]
elm_config: fix to check if eet_open fails

Summary: this patch adds a guard block in case of failure of eet_open().

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9987

4 years agoRevert "efl_io_model: remove custom counting logic"
Marcel Hollerbach [Wed, 18 Sep 2019 12:21:00 +0000 (08:21 -0400)]
Revert "efl_io_model: remove custom counting logic"

Summary:
This reverts commit d794a0d3d95c3addcb21df75606c444c6e3ed6d8.

This breaks Efl_Io_Model.

Reviewers: cedric, zmike

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10003

4 years agoEfl.ThreadIO: replace empty implementations with @pure_virtual
Xavi Artigas [Wed, 18 Sep 2019 11:40:32 +0000 (13:40 +0200)]
Efl.ThreadIO: replace empty implementations with @pure_virtual

The implementation for call and call_async are empty on this mixin.
I think removing them and marking them as @pure_virtual in the EO file is cleaner.

4 years agodocs: Update Efl.Threadio and Efl.Appthread
Xavi Artigas [Wed, 18 Sep 2019 11:40:05 +0000 (13:40 +0200)]
docs: Update Efl.Threadio and Efl.Appthread

4 years agodocs: Fill-in docs for Efl.Threadio, Efl.Appthread
Woochanlee [Wed, 18 Sep 2019 10:51:40 +0000 (12:51 +0200)]
docs: Fill-in docs for Efl.Threadio, Efl.Appthread

Reviewers: myoungwoon, segfaultxavi

Subscribers: stefan_schmidt, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10000

4 years agoefl/image: merge preload and unload events into preload_state,changed
Mike Blumenkrantz [Wed, 18 Sep 2019 08:08:58 +0000 (10:08 +0200)]
efl/image: merge preload and unload events into preload_state,changed

Summary:
this reduces the necessary event subscriptions for cases where someone
is likely to want to listen on these events

ref T7875
Depends on D9996

Subscribers: cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D9997

4 years agoefl/image: rename "border" -> "border_insets"
Mike Blumenkrantz [Wed, 18 Sep 2019 08:08:56 +0000 (10:08 +0200)]
efl/image: rename "border" -> "border_insets"

Summary:
this is a clearer name which makes the intent of the API more obvious at
a glance

ref T7875

Subscribers: cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D9996

4 years agoeolian-mono: add compiler's complaint methods.
Bruno da Silva Belo [Tue, 17 Sep 2019 22:35:31 +0000 (19:35 -0300)]
eolian-mono: add compiler's complaint methods.

Summary: New default checkers breaks mono's test.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9999

4 years agoelm_slider: fix focus for legacy slider on tizen 55/214255/2
Bowon Ryu [Thu, 19 Sep 2019 09:05:02 +0000 (18:05 +0900)]
elm_slider: fix focus for legacy slider on tizen

@tizen fix

Change-Id: Ib8ed3bae13dbc34937d4d88db7fba0b4a56f2e9e
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 years agoRevert "efl_ui_widget: reorder constructor code to fix event callback registration... 98/214198/2
Yeongjong Lee [Thu, 19 Sep 2019 04:36:10 +0000 (13:36 +0900)]
Revert "efl_ui_widget: reorder constructor code to fix event callback registration issue"

The issue has been fixed on c7837260936a02cac6357c62b73ce7a7e8dcad59.

This reverts commit 6844f8731f47197f3906f02c080c69caaf3ada9f.

Change-Id: Idea67c4cf9aa79bf3cd1459958cf96711e0e1c40

4 years agoefl_ui_layout: restore sizing_eval logic to keep backward compatibility 37/214237/1
Yeongjong Lee [Thu, 19 Sep 2019 06:43:01 +0000 (15:43 +0900)]
efl_ui_layout: restore sizing_eval logic to keep backward compatibility

efl_canvas_group_calculate should be called when sub_object size hint is
changed, because some widget(e.g. scroller) expect sub_objects have done
calculating size.

see also, 74a63bdc3900523e6648e3e8915c4577d7145e33.

Change-Id: I20743885bf74231868e6f621b3a8360f3370bd05

4 years agoelm_spinner: Fix issue during migration. 27/214227/2
Woochanlee [Thu, 19 Sep 2019 06:15:23 +0000 (15:15 +0900)]
elm_spinner: Fix issue during migration.

_elm_spinner_efl_ui_widget_widget_event -> _elm_spinner_efl_ui_widget_widget_input_event_handler

Change-Id: I7ee32644424baab39473f908532b7ff668ef7e46

4 years agoevas mask: refactoring code. 06/214206/2
Hermet Park [Thu, 19 Sep 2019 04:59:05 +0000 (13:59 +0900)]
evas mask: refactoring code.

This clearly separate the condition cases clear so that
the analizyer tool doesn't bother us anymore.

No logical changes.

Change-Id: Ic267db0b52536cba7a7c1e771d7655fd84cf1f12

4 years agoecore_device: remove unused variable 03/214203/2 accepted/tizen/unified/20190923.011149 submit/tizen/20190919.052822
Yeongjong Lee [Thu, 19 Sep 2019 04:57:03 +0000 (13:57 +0900)]
ecore_device: remove unused variable

@tizen_fix

Change-Id: Idb1d256ebc4a9f4106a11917f88f24c520edff90

4 years agoecore_device: initialize _ecore_devices to null in ecore_shutdown 85/214185/3
Yeongjong Lee [Thu, 19 Sep 2019 01:03:40 +0000 (10:03 +0900)]
ecore_device: initialize _ecore_devices to null in ecore_shutdown

eina_list will be freed in ecore_shutdown(eina_shutdown). if `_ecore_devices` is
used agian without being initialized to null after being freed, unexpected error
will occur. see example code. `ecore_device_add` is called during
`ecore_evas_new`.

```

static Ecore_Evas *ee = NULL;

static Eina_Bool
_timer_cb(void *data)
{
   ecore_main_loop_quit();
   return EINA_FALSE;
}

static void
setup(void)
{
   ecore_evas_init();

   ee = ecore_evas_new(NULL, 0, 0, 480, 200, NULL);

   ecore_timer_add(0.1, _timer_cb, NULL);
   ecore_main_loop_begin();
}

static void
teardown(void)
{
   if (ee != NULL)
     {
        ecore_evas_free(ee);
     }
   ecore_evas_shutdown();
}

int
main(int argc, const char **argv)
{
   setup();
   teardown();
   setup();
   teardown();
   return 0;
}
```

@tizen_fix

Change-Id: I9add945ec8184af2e0ed6b9ff4a84a62861710ac

4 years agoevas gl: remove unnecessary null check. 01/214201/1
Hermet Park [Thu, 19 Sep 2019 04:39:48 +0000 (13:39 +0900)]
evas gl: remove unnecessary null check.

If we check reference validation, the rest of other usage
should keep the reference check as well.

Remove it since gl prorgram must be valid always here
to shutdown the static analyzer reporting this suspicous logic.

Change-Id: Ia23a5e8d7325fd8aec2d21de9a5f995dfc81c576

4 years agoevas map: disable the anti_aliasing code which can't be reached. 96/214196/1
Hermet Park [Thu, 19 Sep 2019 04:24:08 +0000 (13:24 +0900)]
evas map: disable the anti_aliasing code which can't be reached.

This anti-aliasing is a little buggy, should be improved.

But just leaving to fix later when it's necessary.

Change-Id: Ie984795b00514e012f1f1a99bfef41a41e1df5a2

4 years agoefl_ui_layout: call group_calculate in sizing_eval 95/214095/1
Yeongjong Lee [Wed, 18 Sep 2019 04:05:28 +0000 (13:05 +0900)]
efl_ui_layout: call group_calculate in sizing_eval

`efl_canvas_group_calculate` should be called in _elm_layout_sizing_eval, not in
`_elm_layout_efl_canvas_group_change`.

@tizen_fix

ref 74a63bdc3900523e6648e3e8915c4577d7145e33

Change-Id: I33adf51258c15a0f2050cd9c82a1547d8a3e6ac5

4 years agoelementary: properly shutdown and cleanup Efl.Ui.Position_Manager.
Cedric Bail [Fri, 13 Sep 2019 17:43:42 +0000 (10:43 -0700)]
elementary: properly shutdown and cleanup Efl.Ui.Position_Manager.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9946

4 years agoelementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
Cedric Bail [Sun, 15 Sep 2019 05:22:27 +0000 (22:22 -0700)]
elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set

Model do not own the Eina_Value when it is set on them. They can make a copy of it,
but shouldn't free it.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9945

4 years agoecore: remove unused variable after code migration. Fix warning.
Cedric Bail [Mon, 16 Sep 2019 05:37:59 +0000 (22:37 -0700)]
ecore: remove unused variable after code migration. Fix warning.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9944

4 years agoeina: prevent leak of Eina_Value internal allocation.
Cedric Bail [Sun, 15 Sep 2019 02:13:04 +0000 (19:13 -0700)]
eina: prevent leak of Eina_Value internal allocation.

eina_value_copy assume the given Eina_Value as target is not initialized
when it copy the source in it. In eina_value_reference_copy we were initialising
before calling eina_value_copy which would then override and leak the internal
pointer no fault of the users.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9943

4 years agoeina: turn on Eina_Mempool tests for OneBig too.
Cedric Bail [Sat, 14 Sep 2019 17:52:37 +0000 (10:52 -0700)]
eina: turn on Eina_Mempool tests for OneBig too.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9940

4 years agoeina: fix free support in eina OneBig mempool.
Cedric Bail [Sat, 14 Sep 2019 17:49:28 +0000 (10:49 -0700)]
eina: fix free support in eina OneBig mempool.

We use an Eina_Trash to store freed pointer, which require the item size
to be at least the size of a pointer. There wasn't any test suite enable
for OneBig mempool and we never used free on a small item size...

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9939

4 years agoeina: fix eina_mempool_from to not report pointer that have never been allocated...
Cedric Bail [Sat, 14 Sep 2019 17:16:56 +0000 (10:16 -0700)]
eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9938

4 years agoefl_ui_widget_part_bg: improve docs
Marcel Hollerbach [Tue, 17 Sep 2019 13:51:19 +0000 (15:51 +0200)]
efl_ui_widget_part_bg: improve docs

Reviewers: segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9990

4 years agoefl_ui_image: implement missing API
Marcel Hollerbach [Tue, 17 Sep 2019 12:16:14 +0000 (14:16 +0200)]
efl_ui_image: implement missing API

the API calls have not been implemented, this revision implements these
APIs as redirects to the image if those are a edje object.

Normally this should be a calling the legacy edje API. However, this is
here really hard as imitating the correct callback behaviour is hard.
And the correct behaviour with the eina value type is also just leading
to copying the implementation from edje. So in order to keep the amount
of code low here, this just uses the efl-api to redirect the requests.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9989

4 years agotests/ecore_wl2: Fix resource leak
Chris Michael [Tue, 17 Sep 2019 13:35:43 +0000 (09:35 -0400)]
tests/ecore_wl2: Fix resource leak

Small patch to fix resource leak pointed out by Coverity

Fixes Coverity CID1403883

4 years agoefl_ui_caching_factory: Fix resource leaks
Chris Michael [Tue, 17 Sep 2019 13:23:46 +0000 (09:23 -0400)]
efl_ui_caching_factory: Fix resource leaks

Small patch to fix resource leaks pointed out by Coverity

Fixes Coverity CID1404762

4 years agoefl_ui_widget_factory: Fix resource leaks
Chris Michael [Tue, 17 Sep 2019 13:21:15 +0000 (09:21 -0400)]
efl_ui_widget_factory: Fix resource leaks

Small patch to fix resource leaks pointed out by Coverity

Fixes Coverity CID1404766

4 years agoevas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue

Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9988

Change-Id: I83d92054db29758ecaca9b08bfca700500857798

4 years agoeolian: skip funcs from beta-classes when unimplemented-checking
Daniel Kolesa [Tue, 17 Sep 2019 11:48:15 +0000 (13:48 +0200)]
eolian: skip funcs from beta-classes when unimplemented-checking

4 years agoefl_ui_multi_selectable: remove SINGLE_ALWAYS
Marcel Hollerbach [Tue, 17 Sep 2019 08:56:42 +0000 (10:56 +0200)]
efl_ui_multi_selectable: remove SINGLE_ALWAYS

this should get a better solution later on. There is also no real usage
for that.

ref T7922

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9985

4 years agoeolian: enable unimplemented function errors for stable API
Daniel Kolesa [Tue, 17 Sep 2019 10:36:13 +0000 (12:36 +0200)]
eolian: enable unimplemented function errors for stable API

4 years agoevas - in case handle scope data being null
Carsten Haitzler (Rasterman) [Tue, 17 Sep 2019 10:30:17 +0000 (11:30 +0100)]
evas - in case handle scope data being null

apbbb saw something that had this scope return null ... so handel -
but it shouldn't get this far... can't figure out why though.

4 years agoefl_ui_table: protect again negative tests
Marcel Hollerbach [Tue, 17 Sep 2019 10:26:01 +0000 (12:26 +0200)]
efl_ui_table: protect again negative tests

Summary:
these tests are checking for errors, which is fine, we should expect a
error here
Depends on D9983

Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9984

4 years agoefl_ui_box: make this test expect the errors it is triggering
Marcel Hollerbach [Tue, 17 Sep 2019 10:25:59 +0000 (12:25 +0200)]
efl_ui_box: make this test expect the errors it is triggering

Summary:
there are checks for testing that something is not possible, which is
fine. However, the errors should be expected

Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9983

4 years agomono-docs: Allow embedding examples in XML format
Xavi Artigas [Tue, 17 Sep 2019 10:02:19 +0000 (12:02 +0200)]
mono-docs: Allow embedding examples in XML format

XML examples must provide their own <example> and <code> tags, and these
tags MUST be escaped: \< \> \" etc.
This is more inconvenient, but it allows adding explanatory text outside
the <code> and inside the <example>.
Examples are first looked for in XML format, and if not found, in CS format.

4 years agoector: refer exact stride size for jumping buffer lines.
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.

Actual buffer and used width size could be different,
stride must be referred.

Change-Id: I06d8cf5c0b84a266c8c4260804da6a2b979e98ea

4 years agoevas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue 60/214060/1
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue

Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9988

Change-Id: If02ab894a40da21ba372ed033d155718b1834d78

4 years agoecore_evas: fix invalid function usage 14/213914/2
jeon [Mon, 16 Sep 2019 10:45:13 +0000 (19:45 +0900)]
ecore_evas: fix invalid function usage

  - _ecore_evas_mouse_move_with_multi_ifo_process is a
    (Ecore_Event_Mouse_With_Multi_Cb) type function

Change-Id: I45852a92c5be74b4b9c36831bc4880a11207a209

4 years agoector: refer exact stride size for jumping buffer lines. 51/213951/1 submit/tizen/20190917.043123
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.

Actual buffer and used width size could be different,
stride must be referred.

Change-Id: I37d476223fe63aebda063d60ad05f7cba73f2cb0

4 years agoefl.ui.scrollable: fix event name for scrollable submit/tizen/20190917.040942
Jongmin Lee [Mon, 16 Sep 2019 21:18:22 +0000 (06:18 +0900)]
efl.ui.scrollable: fix event name for scrollable

@tizen_fix

Change-Id: I829c20c5fbc42424c3c2307ea425e8bb169cfee1

4 years agoRevert "cxx: Fix some warnings from -Wextra"
Mike Blumenkrantz [Mon, 16 Sep 2019 18:19:43 +0000 (14:19 -0400)]
Revert "cxx: Fix some warnings from -Wextra"

This reverts commit bdb8505f3b7318b024530d1f9559c91978a3b421.

more review pending on this

4 years agocxx: Fix some warnings from -Wextra
Lauro Moura [Mon, 16 Sep 2019 16:41:37 +0000 (12:41 -0400)]
cxx: Fix some warnings from -Wextra

Summary:
- As we don't have C++17's [[fallthrough]], rely on GCC'd detection
  of fallthrough comments.

See https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

- Add some missing copy assignment operators as reported by
  -Wdeprecated-copy

- Cast a Eina_Bool/bool narrowing conversion

Reviewers: zmike, brunobelo, felipealmeida

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9934

4 years agoefl_ui_format: fix some more harmless Coverity warnings
Xavi Artigas [Mon, 16 Sep 2019 16:10:09 +0000 (18:10 +0200)]
efl_ui_format: fix some more harmless Coverity warnings

1403023 Unchecked return value
1403024 Unchecked return value
1403026 Unchecked return value

If the eina value conversion fails the default value (0) will be used, which is already a good default.
ERRs have been added so the developer has a hint of what is happening.

4 years agoefl_ui_focus_manager_calc: fix resource leaks
Marcel Hollerbach [Mon, 16 Sep 2019 15:49:43 +0000 (17:49 +0200)]
efl_ui_focus_manager_calc: fix resource leaks

this fixes CIDs 1396965 & 1396984

4 years agodocs: Update Efl.Ui.Box_Stack docs
Xavi Artigas [Mon, 16 Sep 2019 15:44:56 +0000 (17:44 +0200)]
docs: Update Efl.Ui.Box_Stack docs

4 years agoefl_ui_*: fix dereferencing of possible NULL values
Marcel Hollerbach [Mon, 16 Sep 2019 15:19:49 +0000 (17:19 +0200)]
efl_ui_*: fix dereferencing of possible NULL values

this fixes CID 1404763 & 1404751 & 1403904

4 years agodocs: Clarify event emission in Image.Gfx.Image_Load_Controller
Xavi Artigas [Mon, 16 Sep 2019 14:53:16 +0000 (16:53 +0200)]
docs: Clarify event emission in Image.Gfx.Image_Load_Controller

And minor formatting.

4 years agoelm/datepicker, timepicker: Fix uninitialized vars
Xavi Artigas [Mon, 16 Sep 2019 14:01:31 +0000 (10:01 -0400)]
elm/datepicker, timepicker: Fix uninitialized vars

Summary:
Should fix all timepicker and datepicker uninitializer variable usage detected by Coverity:
1396954 Uninitialized scalar variable: efl_ui_timepicker.c
1396978 Uninitialized scalar variable: efl_ui_timepicker.c
1397006 Uninitialized scalar variable: efl_ui_timepicker.c
1396979 Uninitialized scalar variable: efl_ui_datepicker.c
1404748 Uninitialized scalar variable: efl_ui_datepicker.c
1404757 Uninitialized scalar variable: efl_ui_datepicker.c

Test Plan: Everything builds and passes tests. Coverity should complain less.

Reviewers: stefan_schmidt, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9967