platform/upstream/gcc.git
7 years agoDaily bump.
GCC Administrator [Tue, 18 Jul 2017 00:16:34 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250294

7 years agoalpha.c: Include predict.h.
Uros Bizjak [Mon, 17 Jul 2017 20:54:31 +0000 (22:54 +0200)]
alpha.c: Include predict.h.

* config/alpha/alpha.c: Include predict.h.

From-SVN: r250290

7 years agore PR tree-optimization/81162 (UBSAN switch triggers incorrect optimization in SLSR)
Bill Schmidt [Mon, 17 Jul 2017 19:12:11 +0000 (19:12 +0000)]
re PR tree-optimization/81162 (UBSAN switch triggers incorrect optimization in SLSR)

2017-07-17  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

PR tree-optimization/81162
* gcc.dg/pr81162.c: Move this to...
* gcc.dg/ubsan/pr81162.c: ...here.

From-SVN: r250284

7 years agoparser.c (cp_parser_decl_specifier_seq): Add fix-it hints for friend outside class...
Volker Reichelt [Mon, 17 Jul 2017 16:58:00 +0000 (16:58 +0000)]
parser.c (cp_parser_decl_specifier_seq): Add fix-it hints for friend outside class and obsolete auto as...

        * parser.c (cp_parser_decl_specifier_seq): Add fix-it hints for
        friend outside class and obsolete auto as storage-class-specifier.

        * g++.dg/diagnostic/friend1.C: New test.
        * g++.dg/cpp0x/auto1.C: Add check for fix-it hint.

From-SVN: r250282

7 years agoclass.c (maybe_warn_about_overly_private_class): Ignore public copy ctors.
Nathan Sidwell [Mon, 17 Jul 2017 16:52:31 +0000 (16:52 +0000)]
class.c (maybe_warn_about_overly_private_class): Ignore public copy ctors.

* class.c (maybe_warn_about_overly_private_class): Ignore public
copy ctors.

* g++.dg/warn/ctor-dtor-privacy-3.C: New.

From-SVN: r250281

7 years agoclass.c (type_has_user_declared_move_constructor, [...]): Combine into ...
Nathan Sidwell [Mon, 17 Jul 2017 15:57:59 +0000 (15:57 +0000)]
class.c (type_has_user_declared_move_constructor, [...]): Combine into ...

* class.c (type_has_user_declared_move_constructor,
type_has_user_declared_move_assign): Combine into ...
(classtype_has_user_move_assign_or_move_ctor_p): ... this new function.
* cp-tree.h (type_has_user_declared_move_constructor,
type_has_user_declared_move_assign): Combine into ...
(classtype_has_user_move_assign_or_move_ctor_p): ... this. Declare.
* method.c (maybe_explain_implicit_delete): Use it.
(lazily_declare_fn): Use it.
* tree.c (type_has_nontrivial_copy_init): Use it.

From-SVN: r250280

7 years agogcc-dg.exp: Increase expect's match buffer size.
Bernd Edlinger [Mon, 17 Jul 2017 15:54:32 +0000 (15:54 +0000)]
gcc-dg.exp: Increase expect's match buffer size.

2017-07-17  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * lib/gcc-dg.exp: Increase expect's match buffer size.

From-SVN: r250279

7 years agotree-vrp.c (compare_assert_loc): Fix comparison function to return predictable results.
Yury Gribov [Mon, 17 Jul 2017 14:58:00 +0000 (14:58 +0000)]
tree-vrp.c (compare_assert_loc): Fix comparison function to return predictable results.

2017-07-17  Yury Gribov  <tetra2005@gmail.com>

gcc/
        * tree-vrp.c (compare_assert_loc): Fix comparison function
to return predictable results.

From-SVN: r250278

7 years ago[ARC] Deprecate mexpand-adddi option.
Claudiu Zissulescu [Mon, 17 Jul 2017 12:59:56 +0000 (14:59 +0200)]
[ARC] Deprecate mexpand-adddi option.

Emitting subregs in the expand will result in broken code due to LRA handling of them. Issue observed while turning on mlra and mexpand-adddi options using dejagnu test suite. Deprecate this
option.

gcc/
2017-04-26  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.md (adddi3): Remove support for mexpand-adddi
option.
(subdi3): Likewise.
* config/arc/arc.opt (mexpand-adddi): Deprecate it.
* doc/invoke.texi (mexpand-adddi): Update text.

From-SVN: r250276

7 years ago[ARC] [LRA] Avoid emitting COND_EXEC during expand.
Claudiu Zissulescu [Mon, 17 Jul 2017 12:59:45 +0000 (14:59 +0200)]
[ARC] [LRA] Avoid emitting COND_EXEC during expand.

Emmitting COND_EXEC rtxes during expand does introduces errors due to LRA handling of them. Issue discovered while running dejagnu test suit with mlra option on.

gcc/
2017-07-17  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.md (clzsi2): Expand to an arc_clzsi2 instruction
that also clobbers the CC register. The old expand code is moved
to ...
(*arc_clzsi2): ... here.
(ctzsi2): Expand to an arc_ctzsi2 instruction that also clobbers
the CC register. The old expand code is moved to ...
(arc_ctzsi2): ... here.

From-SVN: r250275

7 years ago[ARC] Enable indexed loads for elf targers.
Claudiu Zissulescu [Mon, 17 Jul 2017 12:32:02 +0000 (14:32 +0200)]
[ARC] Enable indexed loads for elf targers.

Enable indexed loads only for elf target, as the linux ones need more testing.

gcc/
2017-02-28  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.opt (mindexed-loads): Use initial value
TARGET_INDEXED_LOADS_DEFAULT.
(mauto-modify-reg): Use initial value
TARGET_AUTO_MODIFY_REG_DEFAULT.
* config/arc/elf.h (TARGET_INDEXED_LOADS_DEFAULT): Define.
(TARGET_AUTO_MODIFY_REG_DEFAULT): Likewise.
* config/arc/linux.h (TARGET_INDEXED_LOADS_DEFAULT): Define.
(TARGET_AUTO_MODIFY_REG_DEFAULT): Likewise.

From-SVN: r250274

7 years agosemantics.c (classtype_has_nothrow_assign_or_copy_p): Clarify semantics, simplify...
Nathan Sidwell [Mon, 17 Jul 2017 11:54:03 +0000 (11:54 +0000)]
semantics.c (classtype_has_nothrow_assign_or_copy_p): Clarify semantics, simplify implementation.

* semantics.c (classtype_has_nothrow_assign_or_copy_p): Clarify
semantics, simplify implementation.

From-SVN: r250272

7 years agoDo not allow -fgnu-tm w/ -fsanitize={kernel-,}address (PR sanitizer/81302).
Martin Liska [Mon, 17 Jul 2017 11:44:54 +0000 (13:44 +0200)]
Do not allow -fgnu-tm w/ -fsanitize={kernel-,}address (PR sanitizer/81302).

2017-07-17  Martin Liska  <mliska@suse.cz>

PR sanitizer/81302
* opts.c (finish_options): Do not allow -fgnu-tm
w/ -fsanitize={kernel-,}address.  Say sorry.

From-SVN: r250271

7 years agore PR tree-optimization/81369 (ICE in generate_code_for_partition)
Bin Cheng [Mon, 17 Jul 2017 11:40:54 +0000 (11:40 +0000)]
re PR tree-optimization/81369 (ICE in generate_code_for_partition)

PR target/81369
* tree-loop-distribution.c (classify_partition): Only assert on
numer of iterations.
(merge_dep_scc_partitions): Delete prameter.  Update function call.
(distribute_loop): Remove code handling loop with unknown niters.
(pass_loop_distribution::execute): Skip loop with unknown niters.

From-SVN: r250270

7 years agore PR tree-optimization/81369 (ICE in generate_code_for_partition)
Bin Cheng [Mon, 17 Jul 2017 11:38:15 +0000 (11:38 +0000)]
re PR tree-optimization/81369 (ICE in generate_code_for_partition)

PR target/81369
* tree-loop-distribution.c (merge_dep_scc_partitions): Sink call to
function sort_partitions_by_post_order.

gcc/testsuite
* gcc.dg/tree-ssa/pr81369.c: New.

From-SVN: r250269

7 years agore PR tree-optimization/81374 (ICE in bb_top_order_cmp, at tree-loop-distribution...
Bin Cheng [Mon, 17 Jul 2017 11:34:30 +0000 (11:34 +0000)]
re PR tree-optimization/81374 (ICE in bb_top_order_cmp, at tree-loop-distribution.c:391)

PR tree-optimization/81374
* tree-loop-distribution.c (pass_loop_distribution::execute): Record
the max index of basic blocks, rather than number of basic blocks.

From-SVN: r250268

7 years ago[ARC] Consolidate PIC implementation.
Claudiu Zissulescu [Mon, 17 Jul 2017 11:04:37 +0000 (13:04 +0200)]
[ARC] Consolidate PIC implementation.

This patch refactors a number of functions and compiler hooks into using a
single function which checks if a rtx is suited for pic or not. Removed
functions are arc_legitimate_pc_offset_p and arc_legitimate_pic_operand_p
beeing replaced by calls to arc_legitimate_pic_addr_p. Thus we have an
unitary way of checking a rtx beeing pic.

gcc/
2017-07-17  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc-protos.h (arc_legitimate_pc_offset_p): Remove
proto.
(arc_legitimate_pic_operand_p): Likewise.
* config/arc/arc.c (arc_legitimate_pic_operand_p): Remove
function.
(arc_needs_pcl_p): Likewise.
(arc_legitimate_pc_offset_p): Likewise.
(arc_legitimate_pic_addr_p): Remove LABEL_REF case, as this
function is also used in constrains.md.
(arc_legitimate_constant_p): Use arc_legitimate_pic_addr_p to
validate pic constants. Handle CONST_INT, CONST_DOUBLE, MINUS and
PLUS.  Only return true/false in known cases, otherwise assert.
(arc_legitimate_address_p): Remove arc_legitimate_pic_addr_p as it
is already called in arc_legitimate_constant_p.
* config/arc/arc.h (CONSTANT_ADDRESS_P): Consider also LABEL for
pic addresses.
(LEGITIMATE_PIC_OPERAND_P): Use
arc_raw_symbolic_reference_mentioned_p function.
* config/arc/constraints.md (Cpc): Use arc_legitimate_pic_addr_p
function.
(Cal): Likewise.
(C32): Likewise.

gcc/testsuite
2017-07-17  Claudiu Zissulescu  <claziss@synopsys.com>

* gcc.target/arc/pr9000674901.c: New file.
* gcc.target/arc/pic-1.c: Likewise.
* gcc.target/arc/pr9001191897.c: Likewise.

From-SVN: r250267

7 years ago[PATCH] [ARC] Add support for naked functions.
Claudiu Zissulescu [Mon, 17 Jul 2017 10:46:55 +0000 (12:46 +0200)]
[PATCH] [ARC] Add support for naked functions.

gcc/
2017-07-17  Claudiu Zissulescu  <claziss@synopsys.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>

        * config/arc/arc-protos.h (arc_compute_function_type): Change prototype.
        (arc_return_address_register): New function.
        * config/arc/arc.c (arc_handle_fndecl_attribute): New function.
        (arc_handle_fndecl_attribute): Add naked attribute.
        (TARGET_ALLOCATE_STACK_SLOTS_FOR_ARGS): Define.
        (TARGET_WARN_FUNC_RETURN): Likewise.
        (arc_allocate_stack_slots_for_args): New function.
        (arc_warn_func_return): Likewise.
        (machine_function): Change type fn_type.
        (arc_compute_function_type): Consider new naked function type,
        change function return type.
        (arc_must_save_register): Adapt to handle new
        arc_compute_function_type's return type.
        (arc_expand_prologue): Likewise.
        (arc_expand_epilogue): Likewise.
        (arc_return_address_regs): Delete.
        (arc_return_address_register): New function.
        (arc_epilogue_uses): Use above function.
        * config/arc/arc.h (arc_return_address_regs): Delete prototype.
        (arc_function_type): Change encoding, add naked type.
        (ARC_INTERRUPT_P): Change to handle the new encoding.
        (ARC_FAST_INTERRUPT_P): Likewise.
        (ARC_NORMAL_P): Define.
        (ARC_NAKED_P): Likewise.
        (arc_compute_function_type): Delete prototype.
        * config/arc/arc.md (in_ret_delay_slot): Use
        arc_return_address_register function.
        (simple_return): Likewise.
        (p_return_i): Likewise.

gcc/testsuite
2017-07-17  Claudiu Zissulescu  <claziss@synopsys.com>
            Andrew Burgess  <andrew.burgess@embecosm.com>

        * gcc.target/arc/naked-1.c: New file.
        * gcc.target/arc/naked-2.c: Likewise.

Co-Authored-By: Andrew Burgess <andrew.burgess@embecosm.com>
From-SVN: r250266

7 years agore PR tree-optimization/81428 (ICE: in build_one_cst, at tree.c:2079 with -O2. Fixed...
Jakub Jelinek [Mon, 17 Jul 2017 10:20:41 +0000 (12:20 +0200)]
re PR tree-optimization/81428 (ICE: in build_one_cst, at tree.c:2079 with -O2. Fixed point division.)

PR tree-optimization/81428
* match.pd (X / X -> one): Don't optimize _Fract divisions, as 1
can't be built for those types.

* gcc.dg/fixed-point/pr81428.c: New test.

From-SVN: r250265

7 years agoRemove stuff dead since r239246.
Georg-Johann Lay [Mon, 17 Jul 2017 09:32:42 +0000 (09:32 +0000)]
Remove stuff dead since r239246.

* config/avr/avr-arch.h (avr_inform_devices): Remove dead proto.
* config/avr/avr-devices.c (mcu_name, comparator, avr_mcus_str)
(avr_inform_devices): Remove dead stuff.

From-SVN: r250264

7 years agogcc_update (files_and_dependencies): Remove dead entry.
Georg-Johann Lay [Mon, 17 Jul 2017 09:13:36 +0000 (09:13 +0000)]
gcc_update (files_and_dependencies): Remove dead entry.

* gcc_update (files_and_dependencies)
[gcc/config/avr/avr-tables.opt]: Remove dead entry.

From-SVN: r250263

7 years agoarm_neon.h: Fix softp typo.
Tamar Christina [Mon, 17 Jul 2017 09:12:57 +0000 (09:12 +0000)]
arm_neon.h: Fix softp typo.

2017-07-17  Tamar Christina  <tamar.christina@arm.com>

* config/arm/arm_neon.h: Fix softp typo.

From-SVN: r250262

7 years agore PR tree-optimization/81365 (GCC miscompiles swap)
Jakub Jelinek [Mon, 17 Jul 2017 09:10:23 +0000 (11:10 +0200)]
re PR tree-optimization/81365 (GCC miscompiles swap)

PR tree-optimization/81365
* tree-ssa-phiprop.c (propagate_with_phi): When considering hoisting
aggregate moves onto bb predecessor edges, make sure there are no
loads that could alias the lhs in between the start of bb and the
loads from *phi.

* g++.dg/torture/pr81365.C: New test.

From-SVN: r250261

7 years agore PR middle-end/80929 (Division with constant no more optimized to mult highpart)
Georg-Johann Lay [Mon, 17 Jul 2017 08:56:06 +0000 (08:56 +0000)]
re PR middle-end/80929 (Division with constant no more optimized to mult highpart)

PR 80929
* config/avr/avr.c (avr_mul_highpart_cost): New static function.
(avr_rtx_costs_1) [TRUNCATE]: Use it to compute mul_highpart cost.
[LSHIFTRT, outer_code = TRUNCATE]: Same.

From-SVN: r250258

7 years agore PR tree-optimization/81396 (Optimization of reading Little-Endian 64-bit number...
Jakub Jelinek [Mon, 17 Jul 2017 08:14:16 +0000 (10:14 +0200)]
re PR tree-optimization/81396 (Optimization of reading Little-Endian 64-bit number with portable code has a regression)

PR tree-optimization/81396
* tree-ssa-math-opts.c (struct symbolic_number): Add n_ops field.
(init_symbolic_number): Initialize it to 1.
(perform_symbolic_merge): Add n_ops from both operands into the new
n_ops.
(find_bswap_or_nop): Don't consider n->n == cmpnop computations
without base_addr as useless if they need more than one operation.
(bswap_replace): Handle !bswap case for NULL base_addr.

* gcc.dg/tree-ssa/pr81396.c: New test.

From-SVN: r250257

7 years agoInsert diverging jump alap in nvptx_single
Tom de Vries [Mon, 17 Jul 2017 07:49:22 +0000 (07:49 +0000)]
Insert diverging jump alap in nvptx_single

2017-07-17  Tom de Vries  <tom@codesourcery.com>

PR target/81069
* config/nvptx/nvptx.c (nvptx_single): Insert diverging branch as late
as possible.

From-SVN: r250256

7 years ago[SPARC/RTEMS] Add __FIX_LEON3FT_B2BST
Sebastian Huber [Mon, 17 Jul 2017 05:27:13 +0000 (05:27 +0000)]
[SPARC/RTEMS] Add __FIX_LEON3FT_B2BST

In case the LEON3FT back-to-back store workaround is active
(sparc_fix_b2bst), then define the builtin define __FIX_LEON3FT_B2BST on
RTEMS.  The intended use case for this is operating system code in
assembly language.  See also:

https://lists.rtems.org/pipermail/devel/2017-July/018463.html

gcc/
*  gcc/config/sparc/rtemself.h (TARGET_OS_CPP_BUILTINS): Add
conditional builtin define __FIX_LEON3FT_B2BST.

From-SVN: r250254

7 years ago[RTEMS] Add multilibs for LEON3FT back-to-back store workaround
Daniel Cederman [Mon, 17 Jul 2017 05:18:42 +0000 (05:18 +0000)]
[RTEMS] Add multilibs for LEON3FT back-to-back store workaround

Replace MULTILIB_EXCEPTIONS with MULTILIB_REQUIRED for readability.
-mfix-gr712rc and -mfix-ut700 are currently equivalent.

gcc/
* config/sparc/t-rtems: Add mfix-gr712rc multilibs. Replace
MULTILIB_EXCEPTIONS with MULTILIB_REQUIRED. Match -mfix-gr712rc
with -mfix-ut700.

From-SVN: r250252

7 years agoDaily bump.
GCC Administrator [Mon, 17 Jul 2017 00:16:33 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250251

7 years agore PR rtl-optimization/81424 (internal error on GPRbuild with -O2)
Eric Botcazou [Sun, 16 Jul 2017 22:03:54 +0000 (22:03 +0000)]
re PR rtl-optimization/81424 (internal error on GPRbuild with -O2)

PR rtl-optimization/81424
* optabs.c (prepare_cmp_insn): Use copy_to_reg instead of force_reg
to remove potential trapping from operands if -fnon-call-exceptions.

From-SVN: r250246

7 years agotree-ssa-loop-manip.c (tree_transform_and_unroll_loop): Use profile_proability for...
Jan Hubicka [Sun, 16 Jul 2017 18:25:26 +0000 (20:25 +0200)]
tree-ssa-loop-manip.c (tree_transform_and_unroll_loop): Use profile_proability for scalling.

* tree-ssa-loop-manip.c (tree_transform_and_unroll_loop): Use
profile_proability for scalling.
* scale_profile_for_vect_loop.c (scale_profile_for_vect_loop): Likewise.

From-SVN: r250245

7 years ago* cgraph.c (cgraph_edge::redirect_call_stmt_to_caller): Cleanup.
Jan Hubicka [Sun, 16 Jul 2017 16:36:48 +0000 (18:36 +0200)]
* cgraph.c (cgraph_edge::redirect_call_stmt_to_caller): Cleanup.

From-SVN: r250243

7 years agocfgloopmanip.c (scale_loop_profile): Avoid use of REG_BR_PROB_BASE fixpoint arithmetics.
Jan Hubicka [Sun, 16 Jul 2017 16:35:00 +0000 (18:35 +0200)]
cfgloopmanip.c (scale_loop_profile): Avoid use of REG_BR_PROB_BASE fixpoint arithmetics.

* cfgloopmanip.c (scale_loop_profile): Avoid use of REG_BR_PROB_BASE
fixpoint arithmetics.

From-SVN: r250242

7 years agotree-ssa-loop-unswitch.c (hoist_guard): Avoid use of REG_BR_PROB_BASE fixpoint arithm...
Jan Hubicka [Sun, 16 Jul 2017 16:30:40 +0000 (18:30 +0200)]
tree-ssa-loop-unswitch.c (hoist_guard): Avoid use of REG_BR_PROB_BASE fixpoint arithmetics.

* tree-ssa-loop-unswitch.c (hoist_guard): Avoid use of REG_BR_PROB_BASE
fixpoint arithmetics.

From-SVN: r250241

7 years agoasan.c (create_cond_insert_point): Avoid use of REG_BR_PROB_BASE fixpoint arithmetics.
Jan Hubicka [Sun, 16 Jul 2017 16:28:57 +0000 (18:28 +0200)]
asan.c (create_cond_insert_point): Avoid use of REG_BR_PROB_BASE fixpoint arithmetics.

* asan.c (create_cond_insert_point): Avoid use of REG_BR_PROB_BASE
fixpoint arithmetics.

From-SVN: r250240

7 years agoprofile-count.h (profile_probability::from_reg_br_prob_note, [...]): New functions.
Jan Hubicka [Sun, 16 Jul 2017 16:10:58 +0000 (18:10 +0200)]
profile-count.h (profile_probability::from_reg_br_prob_note, [...]): New functions.

* profile-count.h (profile_probability::from_reg_br_prob_note,
profile_probability::to_reg_br_prob_note): New functions.
* doc/rtl.texi (REG_BR_PROB_NOTE): Update documentation.
* reg-notes.h (REG_BR_PROB, REG_BR_PRED): Update docs.
* predict.c (probability_reliable_p): Update.
(edge_probability_reliable_p): Update.
(br_prob_note_reliable_p): Update.
(invert_br_probabilities): Update.
(add_reg_br_prob_note): New function.
(combine_predictions_for_insn): Update.
* asan.c (asan_clear_shadow): Update.
* cfgbuild.c (compute_outgoing_frequencies): Update.
* cfgrtl.c (force_nonfallthru_and_redirect): Update.
(update_br_prob_note): Update.
(rtl_verify_edges): Update.
(purge_dead_edges): Update.
(fixup_reorder_chain): Update.
* emit-rtl.c (try_split): Update.
* ifcvt.c (cond_exec_process_insns): Update.
(cond_exec_process_if_block): Update.
(dead_or_predicable): Update.
* internal-fn.c (expand_addsub_overflow): Update.
(expand_neg_overflow): Update.
(expand_mul_overflow): Update.
* loop-doloop.c (doloop_modify): Update.
* loop-unroll.c (compare_and_jump_seq): Update.
* optabs.c (emit_cmp_and_jump_insn_1): Update.
* predict.h: Update.
* reorg.c (mostly_true_jump): Update.
* rtl.h: Update.
* config/aarch64/aarch64.c (aarch64_emit_unlikely_jump): Update.
* config/alpha/alpha.c (emit_unlikely_jump): Update.
* config/arc/arc.c: (emit_unlikely_jump): Update.
* config/arm/arm.c: (emit_unlikely_jump): Update.
* config/bfin/bfin.c (cbranch_predicted_taken_p): Update.
* config/frv/frv.c (frv_print_operand_jump_hint): Update.
* config/i386/i386.c (ix86_expand_split_stack_prologue): Update.
(ix86_print_operand): Update.
(ix86_split_fp_branch): Update.
(predict_jump): Update.
* config/ia64/ia64.c (ia64_print_operand): Update.
* config/mmix/mmix.c (mmix_print_operand): Update.
* config/powerpcspe/powerpcspe.c (output_cbranch): Update.
(rs6000_expand_split_stack_prologue): Update.
* config/rs6000/rs6000.c: Update.
* config/s390/s390.c (s390_expand_vec_strlen): Update.
(s390_expand_vec_movstr): Update.
(s390_expand_cs_tdsi): Update.
(s390_expand_split_stack_prologue): Update.
* config/sh/sh.c (sh_print_operand): Update.
(expand_cbranchsi4): Update.
(expand_cbranchdi4): Update.
* config/sparc/sparc.c (output_v9branch): Update.
* config/spu/spu.c (get_branch_target): Update.
(ea_load_store_inline): Update.
* config/tilegx/tilegx.c (cbranch_predicted_p): Update.
* config/tilepro/tilepro.c: Update.
* gcc.dg/predict-8.c: Update.

From-SVN: r250239

7 years agogimplify.c (mostly_copy_tree_r): Revert latest change.
Eric Botcazou [Sun, 16 Jul 2017 13:36:27 +0000 (13:36 +0000)]
gimplify.c (mostly_copy_tree_r): Revert latest change.

* gimplify.c (mostly_copy_tree_r): Revert latest change.
(gimplify_save_expr): Likewise.

From-SVN: r250238

7 years ago* ipa-visibility.c (function_and_variable_visibility): Fix pasto.
Jan Hubicka [Sun, 16 Jul 2017 11:21:39 +0000 (13:21 +0200)]
* ipa-visibility.c (function_and_variable_visibility): Fix pasto.

From-SVN: r250237

7 years agoipa-fnsummary.c (pass_data_ipa_fn_summary): Use TV_IPA_FNSUMMARY.
Jan Hubicka [Sun, 16 Jul 2017 11:19:44 +0000 (13:19 +0200)]
ipa-fnsummary.c (pass_data_ipa_fn_summary): Use TV_IPA_FNSUMMARY.

* ipa-fnsummary.c (pass_data_ipa_fn_summary): Use
TV_IPA_FNSUMMARY.
* timevar.def (TV_IPA_FNSUMMARY): Define.

From-SVN: r250236

7 years agosparc.md (divdf3_fix): Add NOP to prevent back to back store errata sensitive sequenc...
Daniel Cederman [Sun, 16 Jul 2017 10:43:15 +0000 (10:43 +0000)]
sparc.md (divdf3_fix): Add NOP to prevent back to back store errata sensitive sequence from being...

* config/sparc/sparc.md (divdf3_fix): Add NOP to prevent back
to back store errata sensitive sequence from being generated.
(sqrtdf2_fix): Likewise.

From-SVN: r250234

7 years agotree-ssa-threadupdate.c (compute_path_counts, [...]): Use profile_probability.
Jan Hubicka [Sun, 16 Jul 2017 10:06:00 +0000 (12:06 +0200)]
tree-ssa-threadupdate.c (compute_path_counts, [...]): Use profile_probability.

* tree-ssa-threadupdate.c (compute_path_counts,
update_joiner_offpath_counts): Use profile_probability.

From-SVN: r250233

7 years agoAdd forgotten Changelog entries for
Volker Reichelt [Sun, 16 Jul 2017 09:57:50 +0000 (09:57 +0000)]
Add forgotten Changelog entries for

        * parser.c (cp_parser_cast_expression): Use %q#T instead of %qT
        in old-style cast diagnostic.
        * typeck.c (maybe_warn_about_useless_cast): Use %q#T instead of %qT
        in useless cast diagnostic.
        * error.c (type_to_string): Remove enum special handling.

        * g++.dg/cpp1z/direct-enum-init1.C: Revert special enum handling.
        * g++.dg/warn/pr12242.C: Likewise.

From-SVN: r250232

7 years agoparser.c (cp_parser_cast_expression): Use %q#T instead of %qT in old-style cast diagn...
Volker Reichelt [Sun, 16 Jul 2017 09:55:18 +0000 (09:55 +0000)]
parser.c (cp_parser_cast_expression): Use %q#T instead of %qT in old-style cast diagnostic.

        * parser.c (cp_parser_cast_expression): Use %q#T instead of %qT
        in old-style cast diagnostic.
        * typeck.c (maybe_warn_about_useless_cast): Use %q#T instead of %qT
        in useless cast diagnostic.
        * error.c (type_to_string): Remove enum special handling.

        * g++.dg/cpp1z/direct-enum-init1.C: Revert special enum handling.
        * g++.dg/warn/pr12242.C: Likewise.

From-SVN: r250231

7 years agoDaily bump.
GCC Administrator [Sun, 16 Jul 2017 00:16:22 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250230

7 years agoMakefile.am (CHECK_ENV): Set GOROOT.
Ian Lance Taylor [Sat, 15 Jul 2017 17:50:18 +0000 (17:50 +0000)]
Makefile.am (CHECK_ENV): Set GOROOT.

* Makefile.am (CHECK_ENV): Set GOROOT.
(ECHO_ENV): Report setting GOROOT.
* Makefile.in: Rebuild.

From-SVN: r250226

7 years agore PR ada/81446 (building Ada fails due to missing No_Elaboration_Code_All)
John Paul Adrian Glaubitz [Sat, 15 Jul 2017 17:01:03 +0000 (17:01 +0000)]
re PR ada/81446 (building Ada fails due to missing No_Elaboration_Code_All)

PR ada/81446
* system-linux-m68k.ads: Add pragma No_Elaboration_Code_All.

From-SVN: r250224

7 years agoReorder std::scoped_lock parameters as per P0739R0 DR status
Jonathan Wakely [Sat, 15 Jul 2017 15:43:22 +0000 (16:43 +0100)]
Reorder std::scoped_lock parameters as per P0739R0 DR status

* include/std/mutex (scoped_lock): Reorder std::adopt_lock_t parameter
as per P0739R0.
* testsuite/30_threads/scoped_lock/cons/1.cc: Reorder arguments.
* testsuite/30_threads/scoped_lock/cons/deduction.cc: Test deduction
with std::adopt_lock_t.
* testsuite/30_threads/scoped_lock/requirements/typedefs.cc: Check
feature-test macro.

From-SVN: r250223

7 years agoRevert "[ARM] Fix definition of __ARM_FEATURE_NUMERIC_MAXMIN"
Thomas Preud'homme [Sat, 15 Jul 2017 11:16:28 +0000 (11:16 +0000)]
Revert "[ARM] Fix definition of __ARM_FEATURE_NUMERIC_MAXMIN"

This reverts commit r250206.

2017-07-15  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    Revert:
    2017-07-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc
    * config/arm/arm-c.c (arm_cpu_builtins): Define
    __ARM_FEATURE_NUMERIC_MAXMIN solely based on TARGET_VFP5.

From-SVN: r250222

7 years agoDaily bump.
GCC Administrator [Sat, 15 Jul 2017 00:16:21 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250221

7 years agolibgo: don't copy semt into runtime.inc
Ian Lance Taylor [Fri, 14 Jul 2017 22:25:26 +0000 (22:25 +0000)]
libgo: don't copy semt into runtime.inc

    https://gcc.gnu.org/PR81449 reports a problem with the definition semt
    in runtime.inc on some systems. Since the C code in libgo/runtime
    doesn't need semt, just don't copy it into runtime.inc.

    Reviewed-on: https://go-review.googlesource.com/48593

From-SVN: r250217

7 years agocmd/go: use gccSupportsFlag for -fsplit-stack
Ian Lance Taylor [Fri, 14 Jul 2017 22:21:37 +0000 (22:21 +0000)]
cmd/go: use gccSupportsFlag for -fsplit-stack

    Don't assume that all (or only) 386/amd64 compilers support
    -fsplit-stack.

    Reviewed-on: https://go-review.googlesource.com/48592

From-SVN: r250216

7 years agors6000-c.c (altivec_overloaded_builtins): Add array entries to represent __ieee128...
Kelvin Nilsen [Fri, 14 Jul 2017 20:16:57 +0000 (20:16 +0000)]
rs6000-c.c (altivec_overloaded_builtins): Add array entries to represent __ieee128 versions of the scalar_test_data_class...

gcc/ChangeLog:

2017-07-14  Kelvin Nilsen  <kelvin@gcc.gnu.org>

* config/rs6000/rs6000-c.c (altivec_overloaded_builtins): Add
array entries to represent __ieee128 versions of the
scalar_test_data_class, scalar_test_neg, scalar_extract_exp,
scalar_extract_sig, and scalar_insert_exp built-in functions.
(altivec_resolve_overloaded_builtin): Add special case handling
for the __builtin_scalar_insert_exp function, as represented by
the P9V_BUILTIN_VEC_VSIEDP constant.
* config/rs6000/rs6000-builtin.def (VSEEQP): Add scalar extract
exponent support for __ieee128 argument.
(VSESQP): Add scalar extract signature support for __ieee128
argument.
(VSTDCNQP): Add scalar test negative support for __ieee128
argument.
(VSIEQP): Add scalar insert exponent support for __int128 argument
with __ieee128 result.
(VSIEQPF): Add scalar insert exponent support for __ieee128
argument with __ieee128 result.
(VSTDCQP): Add scalar test data class support for __ieee128
argument.
(VSTDCNQP): Add overload support for scalar test negative with
__ieee128 argument.
(VSTDCQP): Add overload support for scalar test data class
__ieee128 argument.
* config/rs6000/vsx.md (UNSPEC_VSX_SXSIG) Replace
UNSPEC_VSX_SXSIGDP.
(UNSPEC_VSX_SIEXPQP): New constant.
(xsxexpqp): New insn for VSX scalar extract exponent quad
precision.
(xsxsigqp): New insn for VSX scalar extract significand quad
precision.
(xsiexpqpf): New insn for VSX scalar insert exponent quad
precision with floating point argument.
(xststdcqp): New expand for VSX scalar test data class quad
precision.
(xststdcnegqp): New expand for VSX scalar test negative quad
precision.
(xststdcqp): New insn to match expansions for VSX scalar test data
class quad precision and VSX scalar test negative quad precision.
* config/rs6000/rs6000.c (rs6000_expand_binop_builtin): Add
special case operand checking to enforce that second operand of
VSX scalar test data class with quad precision argument is a 7-bit
unsigned literal.
* doc/extend.texi (PowerPC AltiVec Built-in Functions): Add
prototypes and descriptions of __ieee128 versions of
scalar_extract_exp, scalar_extract_sig, scalar_insert_exp,
scalar_test_data_class, and scalar_test_neg built-in functions.

gcc/testsuite/ChangeLog:

2017-07-14  Kelvin Nilsen  <kelvin@gcc.gnu.org>

* gcc.target/powerpc/bfp/scalar-cmp-exp-eq-3.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-eq-4.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-gt-3.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-gt-4.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-lt-3.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-lt-4.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-unordered-3.c: New test.
* gcc.target/powerpc/bfp/scalar-cmp-exp-unordered-4.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-exp-3.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-exp-4.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-exp-5.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-exp-6.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-exp-7.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-sig-3.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-sig-4.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-sig-5.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-sig-6.c: New test.
* gcc.target/powerpc/bfp/scalar-extract-sig-7.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-10.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-11.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-12.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-13.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-14.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-15.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-6.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-7.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-8.c: New test.
* gcc.target/powerpc/bfp/scalar-insert-exp-9.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-10.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-11.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-12.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-13.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-14.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-15.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-8.c: New test.
* gcc.target/powerpc/bfp/scalar-test-data-class-9.c: New test.
* gcc.target/powerpc/bfp/scalar-test-neg-4.c: New test.
* gcc.target/powerpc/bfp/scalar-test-neg-5.c: New test.
* gcc.target/powerpc/bfp/scalar-test-neg-6.c: New test.
* gcc.target/powerpc/bfp/scalar-test-neg-7.c: New test.
* gcc.target/powerpc/bfp/scalar-test-neg-8.c: New test.
* gcc.target/powerpc/bfp/vec-extract-exp-4.c: New test.
* gcc.target/powerpc/bfp/vec-extract-exp-5.c: New test.
* gcc.target/powerpc/bfp/vec-extract-sig-4.c: New test.
* gcc.target/powerpc/bfp/vec-extract-sig-5.c: New test.
* gcc.target/powerpc/bfp/vec-insert-exp-10.c: New test.
* gcc.target/powerpc/bfp/vec-insert-exp-11.c: New test.
* gcc.target/powerpc/bfp/vec-insert-exp-8.c: New test.
* gcc.target/powerpc/bfp/vec-insert-exp-9.c: New test.
* gcc.target/powerpc/bfp/vec-test-data-class-8.c: New test.
* gcc.target/powerpc/bfp/vec-test-data-class-9.c: New test.

From-SVN: r250214

7 years agoConstrain std::variant constructor for class template argument deduction
Jason Merrill [Fri, 14 Jul 2017 19:13:49 +0000 (15:13 -0400)]
Constrain std::variant constructor for class template argument deduction

2017-07-14  Jason Merrill  <jason@redhat.com>
    Jonathan Wakely  <jwakely@redhat.com>

* include/std/variant (variant::variant(_Tp&&)): Constrain to remove
the constructor for empty variants from the candidate functions
during class template argument deduction.
* testsuite/20_util/variant/deduction.cc: New.

Co-Authored-By: Jonathan Wakely <jwakely@redhat.com>
From-SVN: r250213

7 years agore PR tree-optimization/81162 (UBSAN switch triggers incorrect optimization in SLSR)
Bill Schmidt [Fri, 14 Jul 2017 18:06:45 +0000 (18:06 +0000)]
re PR tree-optimization/81162 (UBSAN switch triggers incorrect optimization in SLSR)

[gcc]

2016-07-14  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

PR tree-optimization/81162
* gimple-ssa-strength-reduction.c (replace_mult_candidate): Don't
replace a negate with an add.

[gcc/testsuite]

2016-07-14  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

PR tree-optimization/81162
* gcc.dg/pr81162.c: New file.

From-SVN: r250212

7 years agossa-dse-30.c: Correct test to look for memmove that bcopy is expected to be transform...
Martin Sebor [Fri, 14 Jul 2017 16:16:23 +0000 (16:16 +0000)]
ssa-dse-30.c: Correct test to look for memmove that bcopy is expected to be transformed to.

gcc/testsuite/ChangeLog:

* gcc.dg/tree-ssa/ssa-dse-30.c: Correct test to look for memmove
that bcopy is expected to be transformed to.

From-SVN: r250209

7 years ago[Patch ARM] Document the +crypto extension on CPUs.
James Greenhalgh [Fri, 14 Jul 2017 15:48:57 +0000 (15:48 +0000)]
[Patch ARM] Document the +crypto extension on CPUs.

We don't document the list of CPU names which can take a +crypto extension
in the ARM port. This patch fixes that oversight.

gcc/

2017-14-07  James Greenhalgh  <james.greenhalgh@arm.com>

* doc/invoke.texi (arm/-mcpu): Document +crypto.

From-SVN: r250207

7 years ago[ARM] Fix definition of __ARM_FEATURE_NUMERIC_MAXMIN
Thomas Preud'homme [Fri, 14 Jul 2017 15:26:28 +0000 (15:26 +0000)]
[ARM] Fix definition of __ARM_FEATURE_NUMERIC_MAXMIN

Definition of __ARM_FEATURE_NUMERIC_MAXMIN checks for
TARGET_ARM_ARCH >= 8 and TARGET_NEON being true in addition to
TARGET_VFP5. However, instructions covered by this macro are part of
FPv5 which is available in ARMv7E-M architecture. This commit fixes the
macro to only check for TARGET_VFP5.

2017-07-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc/
    * config/arm/arm-c.c (arm_cpu_builtins): Define
    __ARM_FEATURE_NUMERIC_MAXMIN solely based on TARGET_VFP5.

From-SVN: r250206

7 years ago[ARM] Add support for ARM Cortex-R52 processor
Thomas Preud'homme [Fri, 14 Jul 2017 15:26:19 +0000 (15:26 +0000)]
[ARM] Add support for ARM Cortex-R52 processor

2017-07-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc/
    * config/arm/arm-cpus.in (cortex-r52): Add new entry.
    (armv8-r): Set ARM Cortex-R52 as default CPU.
    * config/arm/arm-tables.opt: Regenerate.
    * config/arm/arm-tune.md: Regenerate.
    * config/arm/driver-arm.c (arm_cpu_table): Add entry for ARM
    Cortex-R52.
    * doc/invoke.texi: Mention -mtune=cortex-r52 and availability of fp.dp
    extension for -mcpu=cortex-r52.

From-SVN: r250205

7 years ago[ARM] Rewire -mfpu=fp-armv8 as VFPv5 + D32 + DP
Thomas Preud'homme [Fri, 14 Jul 2017 15:26:09 +0000 (15:26 +0000)]
[ARM] Rewire -mfpu=fp-armv8 as VFPv5 + D32 + DP

fp-armv8 is currently defined as a double precision FPv5 with 32 D
registers *and* a special FP_ARMv8 bit. However FP for ARMv8 should only
bring 32 D registers on top of FPv5-D16 so this FP_ARMv8 bit is
spurious. As a consequence, many instruction patterns which are guarded
by TARGET_FPU_ARMV8 are unavailable to FPv5-D16 and FPv5-SP-D16.

This commit gets rid of TARGET_FPU_ARMV8 and rewire all uses to
expressions based on TARGET_VFP5, TARGET_VFPD32 and TARGET_VFP_DOUBLE.
It also redefine ISA_FP_ARMv8 to include the D32 capability to
distinguish it from FPv5-D16. At last, it sets the +fp.sp for ARMv8-R to
enable FPv5-SP-D16 (ie FP for ARMv8 with single precision only and 16 D
registers).

2017-07-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc/
    * config/arm/arm-isa.h (isa_bit_FP_ARMv8): Delete enumerator.
    (ISA_FP_ARMv8): Define as ISA_FPv5 and ISA_FP_D32.
    * config/arm/arm-cpus.in (armv8-r): Define fp.sp as enabling FPv5.
    (fp-armv8): Define it as FP_ARMv8 only.
    config/arm/arm.h (TARGET_FPU_ARMV8): Delete.
    (TARGET_VFP_FP16INST): Define using TARGET_VFP5 rather than
    TARGET_FPU_ARMV8.
    config/arm/arm.c (arm_rtx_costs_internal): Replace checks against
    TARGET_FPU_ARMV8 by checks against TARGET_VFP5.
    * config/arm/arm-builtins.c (arm_builtin_vectorized_function): Define
    first ARM_CHECK_BUILTIN_MODE definition using TARGET_VFP5 rather
    than TARGET_FPU_ARMV8.
    * config/arm/arm-c.c (arm_cpu_builtins): Likewise for
    __ARM_FEATURE_NUMERIC_MAXMIN macro definition.
    * config/arm/arm.md (cmov<mode>): Condition on TARGET_VFP5 rather than
    TARGET_FPU_ARMV8.
    * config/arm/neon.md (neon_vrint): Likewise.
    (neon_vcvt): Likewise.
    (neon_<fmaxmin_op><mode>): Likewise.
    (<fmaxmin><mode>3): Likewise.
    * config/arm/vfp.md (l<vrint_pattern><su_optab><mode>si2): Likewise.
    * config/arm/predicates.md (arm_cond_move_operator): Check against
    TARGET_VFP5 rather than TARGET_FPU_ARMV8 and fix spacing.

From-SVN: r250204

7 years agoc/c++: Add fix-it hints for suggested missing #includes
David Malcolm [Fri, 14 Jul 2017 15:09:00 +0000 (15:09 +0000)]
c/c++: Add fix-it hints for suggested missing #includes

gcc/c-family/ChangeLog:
* c-common.c (try_to_locate_new_include_insertion_point): New
function.
(per_file_includes_t): New typedef.
(added_includes_t): New typedef.
(added_includes): New variable.
(maybe_add_include_fixit): New function.
* c-common.h (maybe_add_include_fixit): New decl.

gcc/c/ChangeLog:
* c-decl.c (implicitly_declare): When suggesting a missing
#include, provide a fix-it hint.

gcc/cp/ChangeLog:
* name-lookup.c (get_std_name_hint): Add '<' and '>' around
the header names.
(maybe_suggest_missing_header): Update for addition of '<' and '>'
to above.  Provide a fix-it hint.
* pt.c: Include "gcc-rich-location.h"
(listify): Attempt to add fix-it hint for missing
#include <initializer_list>.
* rtti.c: Include "gcc-rich-location.h".
(typeid_ok_p): Attempt to add fix-it hint for missing
#include <typeinfo>.

gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/missing-initializer_list-include.C: New test case.
* g++.dg/lookup/missing-std-include-2.C: New test case.
* g++.dg/lookup/missing-std-include-3.C: New test case.
* g++.dg/rtti/missing-typeinfo-include.C: New test case.
* gcc.dg/missing-header-fixit-1.c: New test case.
* gcc.dg/missing-header-fixit-2.c: New test case.
* gcc.dg/missing-header-fixit-2.h: New header.

From-SVN: r250203

7 years ago[Patch][Aarch64] Refactor comments in aarch64_print_operand
Jackson Woodruff [Fri, 14 Jul 2017 09:18:09 +0000 (09:18 +0000)]
[Patch][Aarch64] Refactor comments in aarch64_print_operand

This patch refactors comments in config/aarch64/aarch64.c aarch64_print_operand
to provide a table of aarch64 specific formating options.

---
gcc/

2017-07-14  Jackson Woodruff  <jackson.woodruff@arm.com>

* config/aarch64/aarch64.c (aarch64_print_operand): Move comments
to top of function.

From-SVN: r250202

7 years agoUpdate comment in gimple-ssa-store-merging.c
Kyrylo Tkachov [Fri, 14 Jul 2017 09:11:20 +0000 (09:11 +0000)]
Update comment in gimple-ssa-store-merging.c

* gimple-ssa-store-merging.c (clear_bit_region): Replace reference to
loop in comment with memset.

From-SVN: r250201

7 years agore PR sanitizer/81066 (sanitizer_stoptheworld_linux_libcdep.cc:276:22: error: aggrega...
Jakub Jelinek [Fri, 14 Jul 2017 09:10:45 +0000 (11:10 +0200)]
re PR sanitizer/81066 (sanitizer_stoptheworld_linux_libcdep.cc:276:22: error: aggregate ‘sigaltstack handler_stack’ has incomplete type and cannot be defined)

PR sanitizer/81066
* sanitizer_common/sanitizer_linux.h: Cherry-pick upstream r307969.
* sanitizer_common/sanitizer_linux.cc: Likewise.
* sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc: Likewise.
* tsan/tsan_platform_linux.cc: Likewise.

From-SVN: r250200

7 years agoRemove Java references in source code.
Martin Liska [Fri, 14 Jul 2017 07:44:33 +0000 (09:44 +0200)]
Remove Java references in source code.

2017-07-14  Martin Liska  <mliska@suse.cz>

* cfgexpand.c (expand_gimple_basic_block): Remove dead comment.
* dwarf2out.c (is_java): Remove the function.
(output_pubname): Remove usage of the function.
(lower_bound_default): Remove usage of DW_LANG_Java.
(gen_compile_unit_die): Likewise.
* gcc.c: Remove compiler defaults for .java and .zip files.
* gimple-expr.c (remove_suffix): Change as there's no longer
extension than 4-letter one.
* gimplify.c (mostly_copy_tree_r): Remove Java-special part.
(gimplify_save_expr): Likewise.
* ipa-utils.h (polymorphic_type_binfo_p): Remove the comment
as it's possible even for other languages than Java.
* langhooks.h (struct lang_hooks): Remove Java from a comment.
* lto-opts.c (lto_write_options): Remove reference to Java.
* opts.c (strip_off_ending): Update file extension handling.
* tree-cfg.c (verify_gimple_call): Remove comment with Java.
* tree-eh.c (lower_resx): Likewise.
* tree.c (free_lang_data_in_type): Remove dead code.
(find_decls_types_r): Likewise.
(build_common_builtin_nodes): Remove Java from a comment.
(verify_type): Remove dead code.
* varasm.c (assemble_external): Remove Java from a comment.

From-SVN: r250199

7 years agoAdd additional quotes to opts.c.
Martin Liska [Fri, 14 Jul 2017 07:21:40 +0000 (09:21 +0200)]
Add additional quotes to opts.c.

2017-07-14  Martin Liska  <mliska@suse.cz>

* opts.c (finish_options): Add quotes.
(common_handle_option): Likewise.

From-SVN: r250198

7 years agoRemove Pascal language in source code.
Martin Liska [Fri, 14 Jul 2017 07:05:27 +0000 (09:05 +0200)]
Remove Pascal language in source code.

2017-07-14  Martin Liska  <mliska@suse.cz>

* dbxout.c (get_lang_number): Do not handle GNU Pascal.
* dbxout.h (extern void dbxout_stab_value_internal_label_diff):
Remove N_SO_PASCAL.
* dwarf2out.c (lower_bound_default): Do not handle
DW_LANG_Pascal83.
(gen_compile_unit_die): Likewise.
* gcc.c: Remove default extension binding for GNU Pascal.
* stmt.c: Remove Pascal language from a comment.
* xcoffout.c: Likewise.

From-SVN: r250197

7 years agoDaily bump.
GCC Administrator [Fri, 14 Jul 2017 00:16:19 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250195

7 years agodiagnostics: fix crash when consolidating out-of-order fix-it hints (PR c/81405)
David Malcolm [Thu, 13 Jul 2017 19:30:42 +0000 (19:30 +0000)]
diagnostics: fix crash when consolidating out-of-order fix-it hints (PR c/81405)

PR c/81405 identifies a crash when printing fix-it hints from
-Wmissing-braces when there are excess elements.

The fix-it hints are bogus (which I've filed separately as PR c/81432),
but they lead to a crash within the fix-it consolidation logic I added
in r247548, in line_corrections::add_hint.

The root cause is that some of the fix-it hints are out-of-order
with respect to the column numbers they affect, which can lead to negative
values when computing the gap between the fix-it hints, leading to bogus
memcpy calls that generate out-of-bounds buffer accesses.

The fix is to sort the fix-it hints after filtering them, ensuring that
the gap >= 0.  The patch also adds numerous assertions to the code, both
directly, and by moving the memcpy calls and their args behind
interfaces (themselves containing gcc_assert).

This fixes the crash; it doesn't fix the bug in -Wmissing-braces that
leads to the bogus hints.

gcc/ChangeLog:
PR c/81405
* diagnostic-show-locus.c (fixit_cmp): New function.
(layout::layout): Sort m_fixit_hints.
(column_range::column_range): Assert that the values are valid.
(struct char_span): New struct.
(correction::overwrite): New method.
(struct source_line): New struct.
(line_corrections::add_hint): Add assertions.  Reimplement memcpy
calls in terms of classes source_line and char_span, and
correction::overwrite.
(selftest::test_overlapped_fixit_printing_2): New function.
(selftest::diagnostic_show_locus_c_tests): Call it.

gcc/testsuite/ChangeLog:
PR c/81405
* gcc.dg/Wmissing-braces-fixits.c: Add coverage for PR c/81405.  */

From-SVN: r250187

7 years agors6000.c (rs6000_gimple_fold_builtin): Return early if there is no lhs.
Will Schmidt [Thu, 13 Jul 2017 14:09:12 +0000 (14:09 +0000)]
rs6000.c (rs6000_gimple_fold_builtin): Return early if there is no lhs.

[gcc]

2017-07-12  Will Schmidt  <will_schmidt@vnet.ibm.com>

* config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): Return
early if there is no lhs.

[testsuite]

2017-07-12  Will Schmidt  <will_schmidt@vnet.ibm.com>

* gcc.target/powerpc/fold-vec-missing-lhs: New.

From-SVN: r250185

7 years agoCleanup #2 of Pascal references.
Martin Liska [Thu, 13 Jul 2017 13:54:26 +0000 (15:54 +0200)]
Cleanup #2 of Pascal references.

2017-07-13  Martin Liska  <mliska@suse.cz>

* dwarf2out.c (gen_pointer_type_die): Remove dead code.
(gen_reference_type_die): Likewise.
* stor-layout.c: Remove Pascal-related comment.

From-SVN: r250184

7 years agoP0512R0 - Deduction from an initializer list.
Jason Merrill [Thu, 13 Jul 2017 13:04:04 +0000 (09:04 -0400)]
P0512R0 - Deduction from an initializer list.

* pt.c (do_class_deduction): Do list deduction in two phases.

From-SVN: r250183

7 years ago900520_03.C: Limit error to c++14_down.
Jason Merrill [Thu, 13 Jul 2017 13:00:32 +0000 (09:00 -0400)]
900520_03.C: Limit error to c++14_down.

* g++.old-deja/g++.bugs/900520_03.C: Limit error to c++14_down.
* g++.old-deja/g++.law/array2.C: Likewise.

From-SVN: r250182

7 years agorevert previous premature commit
Nathan Sidwell [Thu, 13 Jul 2017 12:38:32 +0000 (12:38 +0000)]
revert previous premature commit

From-SVN: r250181

7 years agolibcp1plugin.cc (plugin_build_decl): Use DECL_CXX_{CON,DE}STRUCTOR directly.
Nathan Sidwell [Thu, 13 Jul 2017 12:35:52 +0000 (12:35 +0000)]
libcp1plugin.cc (plugin_build_decl): Use DECL_CXX_{CON,DE}STRUCTOR directly.

* libcp1plugin.cc (plugin_build_decl): Use
DECL_CXX_{CON,DE}STRUCTOR directly.

From-SVN: r250180

7 years agoAdd quotes to error messages related to Sanitizers.
Martin Liska [Thu, 13 Jul 2017 12:13:29 +0000 (14:13 +0200)]
Add quotes to error messages related to Sanitizers.

2017-07-13  Martin Liska  <mliska@suse.cz>

* opts.c (finish_options): Add quotes to error messages.
(parse_sanitizer_options): Likewise.
2017-07-13  Martin Liska  <mliska@suse.cz>

* c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern.
* c-c++-common/ubsan/sanitize-recover-1.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-2.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-5.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-7.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-8.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-9.c:Likewise.

From-SVN: r250179

7 years ago[ARM] Mention ARMv8-R +fp.sp option
Thomas Preud'homme [Thu, 13 Jul 2017 10:38:52 +0000 (10:38 +0000)]
[ARM] Mention ARMv8-R +fp.sp option

2017-07-13  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc/
    * doc/invoke.texi (armv8-r): Document +fp.sp ARMv8-R extension.

From-SVN: r250178

7 years ago[ARM, VXworks] Fix build
Richard Earnshaw [Thu, 13 Jul 2017 10:01:55 +0000 (10:01 +0000)]
[ARM, VXworks] Fix build

My patch last week to address selection of be8 linking mode broke the
build for vxworks.  It turns out that this port is one of the few
remaining that is still not based on the EABI/AAPCS.

This patch fixes the build, but I've not really tested it beyond
building the core compiler binaries.  Building a workable compiler
entails downloading a load of vxworks stuff that I'm not sure where to
find.

* config/arm/vxworks.h (TARGET_ENDIAN_DEFAULT): Define.

From-SVN: r250177

7 years agoASAN: fix ICE in gcc.dg/asan/pr80168.c on aarch64 -mabi=ilp32
Maxim Ostapenko [Thu, 13 Jul 2017 07:48:49 +0000 (07:48 +0000)]
ASAN: fix ICE in gcc.dg/asan/pr80168.c on aarch64 -mabi=ilp32

gcc/
* asan.c (asan_emit_allocas_unpoison): Use ptr_mode for arguments
during expansion.
* builtins.c (expand_asan_emit_allocas_unpoison): Likewise.

From-SVN: r250176

7 years agore PR go/81393 (Bootstrap failure on s390x-linux while building libgo against recent...
Ian Lance Taylor [Thu, 13 Jul 2017 03:44:14 +0000 (03:44 +0000)]
re PR go/81393 (Bootstrap failure on s390x-linux while building libgo against recent glibc)

PR go/81393
    syscall: don't use GETREGS/SETREGS on s390

    They were removed in recent glibc.

    Patch by Andreas Krebbel for GCC PR 81393.

    Reviewed-on: https://go-review.googlesource.com/48231

From-SVN: r250174

7 years agoDaily bump.
GCC Administrator [Thu, 13 Jul 2017 00:16:24 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250173

7 years agore PR target/81193 (PowerPC GCC __builtin_cpu_is and __builtin_cpu_supports should...
Michael Meissner [Wed, 12 Jul 2017 23:07:50 +0000 (23:07 +0000)]
re PR target/81193 (PowerPC GCC __builtin_cpu_is and __builtin_cpu_supports should warn about old libraries)

[gcc]
2017-07-12  Michael Meissner  <meissner@linux.vnet.ibm.com>

PR target/81193
* config/rs6000/rs6000-c.c (rs6000_cpu_cpp_builtins): If GLIBC
provides the hardware capability bits, define the macro
__BUILTIN_CPU_SUPPORTS__.
* config/rs6000/rs6000.c (cpu_expand_builtin): Generate a warning
if GLIBC does not provide the hardware capability bits.  Add a
gcc_unreachable call if the built-in cpu function is neither
__builtin_cpu_is nor __builtin_cpu_supports.
(rs6000_get_function_versions_dispatcher): Change the warning
that an old GLIBC is used which does not export the capability
bits to be an error.
* doc/extend.texi (target_clones attribute): Document the
restriction that GLIBC 2.23 or newer is needed on the PowerPC.
(PowerPC built-in functions): Document that GLIBC 2.23 or newer is
needed by __builtin_cpu_is and __builtin_cpu_supports.  Document
the macros defined by GCC if the newer GLIBC is available.

[gcc/testsuite]
2017-07-12  Michael Meissner  <meissner@linux.vnet.ibm.com>

PR target/81193
* gcc.target/powerpc/bmi-andn-1.c: Add guard against using
__builtin_cpu_supports with old GLIBC's.
* gcc.target/powerpc/bmi-andn-2.c: Likewise.
* gcc.target/powerpc/bmi-bextr-1.c: Likewise.
* gcc.target/powerpc/bmi-bextr-2.c: Likewise.
* gcc.target/powerpc/bmi-bextr-4.c: Likewise.
* gcc.target/powerpc/bmi-bextr-5.c: Likewise.
* gcc.target/powerpc/bmi-blsi-1.c: Likewise.
* gcc.target/powerpc/bmi-blsi-2.c: Likewise.
* gcc.target/powerpc/bmi-blsmsk-1.c: Likewise.
* gcc.target/powerpc/bmi-blsmsk-2.c: Likewise.
* gcc.target/powerpc/bmi-blsr-1.c: Likewise.
* gcc.target/powerpc/bmi-blsr-2.c: Likewise.
* gcc.target/powerpc/bmi-tzcnt-1.c: Likewise.
* gcc.target/powerpc/bmi-tzcnt-2.c: Likewise.
* gcc.target/powerpc/bmi2-bzhi32-1.c: Likewise.
* gcc.target/powerpc/bmi2-bzhi64-1.c: Likewise.
* gcc.target/powerpc/bmi2-mulx32-1.c: Likewise.
* gcc.target/powerpc/bmi2-mulx32-2.c: Likewise.
* gcc.target/powerpc/bmi2-mulx64-1.c: Likewise.
* gcc.target/powerpc/bmi2-mulx64-2.c: Likewise.
* gcc.target/powerpc/bmi2-pdep32-1.c: Likewise.
* gcc.target/powerpc/bmi2-pdep64-1.c: Likewise.
* gcc.target/powerpc/bmi2-pext32-1.c: Likewise.
* gcc.target/powerpc/bmi2-pext64-1.c: Likewise.
* gcc.target/powerpc/cpu-builtin-1.c: Likewise.

[libgcc]
2017-07-12  Michael Meissner  <meissner@linux.vnet.ibm.com>

PR target/81193
* configure.ac (PowerPC float128 hardware support): Test whether
we can use __builtin_cpu_supports before enabling the ifunc
handler.
* configure: Regenerate.

From-SVN: r250165

7 years agoriscv.c: Remove unnecessary includes.
Jeff Law [Wed, 12 Jul 2017 21:43:40 +0000 (15:43 -0600)]
riscv.c: Remove unnecessary includes.

* config/riscv/riscv.c: Remove unnecessary includes.  Reorder
remaining includes slightly.
* config/riscv/riscv-builtins.c: Include profile-count.h.

From-SVN: r250162

7 years agolibcp1plugin.cc (plugin_build_decl): Use DECL_CXX_{CON,DE}STRUCTOR directly.
Nathan Sidwell [Wed, 12 Jul 2017 19:46:33 +0000 (19:46 +0000)]
libcp1plugin.cc (plugin_build_decl): Use DECL_CXX_{CON,DE}STRUCTOR directly.

* libcp1plugin.cc (plugin_build_decl): Use
DECL_CXX_{CON,DE}STRUCTOR directly.

From-SVN: r250159

7 years agocp-tree.h (DECL_CONSTRUCTOR_P, [...]): Look at identifier flags.
Nathan Sidwell [Wed, 12 Jul 2017 17:29:11 +0000 (17:29 +0000)]
cp-tree.h (DECL_CONSTRUCTOR_P, [...]): Look at identifier flags.

* cp-tree.h (DECL_CONSTRUCTOR_P, DECL_MAYBE_IN_CHARGE_CONSTRUCTOR,
DECL_DESTRUCTOR_P, DECL_MAYBE_IN_CHARGE_DESTRCTOR): Look at
identifier flags.
* decl.c (grokfndecl): Set DECL_CXX_CONSTRUCTOR and
DECL_CXX_DESTRUCTOR explicitly.
* decl2.c (grokclassfn): Likewise.
* friend.c (do_friend): Likewise.
* method.c (make_thunk, make_alias_for,
implicitly_declare_fn): Likewise.

From-SVN: r250158

7 years agore PR target/79883 (avr i18n: untranslated "interrupt" or "signal")
Georg-Johann Lay [Wed, 12 Jul 2017 15:25:07 +0000 (15:25 +0000)]
re PR target/79883 (avr i18n: untranslated "interrupt" or "signal")

PR target/79883
* config/avr/avr.c (avr_set_current_function): In diagnostic
messages: Quote keywords and (parts of) identifiers.
[WITH_AVRLIBC]: Warn for functions named "ISR", "SIGNAL" or
"INTERUPT".

From-SVN: r250156

7 years agors6000-c.c: Add support for built-in functions vector bool char vec_revb (vector...
Carl Love [Wed, 12 Jul 2017 15:10:21 +0000 (15:10 +0000)]
rs6000-c.c: Add support for built-in functions vector bool char vec_revb (vector bool char)...

gcc/ChangeLog:

2017-07-12  Carl Love  <cel@us.ibm.com>

* config/rs6000/rs6000-c.c: Add support for built-in functions
vector bool char vec_revb (vector bool char);
vector bool short vec_revb (vector short char);
vector bool int vec_revb (vector bool int);
vector bool long long vec_revb (vector bool long long);
* doc/extend.texi: Update the built-in documentation file for the
new built-in functions.

gcc/testsuite/ChangeLog:

2017-07-12  Carl Love  <cel@us.ibm.com>

* gcc.target/powerpc/p9-xxbr-1.c (rev_bool_char, rev_bool_short,
rev_bool_int): Add test cases for builtins.
* gcc.target/powerpc/p9-xxbr-2.c (rev_long_long, rev_ulong_ulong): Add
test cases for builtins.

From-SVN: r250155

7 years agobuiltins-1-p9-runnable.c (dg-ddo run): Add lp64 && p9vector_hw.
Carl Love [Wed, 12 Jul 2017 15:04:44 +0000 (15:04 +0000)]
builtins-1-p9-runnable.c (dg-ddo run): Add lp64 && p9vector_hw.

gcc/testsuite/ChangeLog:

2017-07-12  Carl Love  <cel@us.ibm.com>

* gcc.target/powerpc/builtins-1-p9-runnable.c (dg-ddo run): Add
lp64 && p9vector_hw.

From-SVN: r250154

7 years agoS/390: Remove loc splitter
Andreas Krebbel [Wed, 12 Jul 2017 15:00:58 +0000 (15:00 +0000)]
S/390: Remove loc splitter

The backend splitter splitting a 3 operand load on condition into 2 is
wrong.  The S/390 load on condition instruction might trap on the
memory operand even if the condition is false.  So if the first load
on condition overwrites a register used as part of the memory address
of the second the second might trigger a segfault even if it does not
actually perform the load.

Trying to fix this I noticed that the generated code looks anyway
better without the splitter.  So removing the splitter entirely is the
way to go here.

gcc/ChangeLog:

2017-07-12  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

* config/s390/s390.md: Remove movcc splitter.

From-SVN: r250153

7 years agoS/390: Calculate costs for load/store on condition
Andreas Krebbel [Wed, 12 Jul 2017 14:59:36 +0000 (14:59 +0000)]
S/390: Calculate costs for load/store on condition

This adds code to the backend rtx_costs function in order to model the
costs of a load/store on condition.

gcc/ChangeLog:

2017-07-12  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

* config/s390/s390.c (s390_rtx_costs): Return proper costs for
load/store on condition.

From-SVN: r250152

7 years agore PR target/81407 ([avr] Diagnose if a variable in progmem needs constructing.)
Georg-Johann Lay [Wed, 12 Jul 2017 13:58:34 +0000 (13:58 +0000)]
re PR target/81407 ([avr] Diagnose if a variable in progmem needs constructing.)

PR target/81407
* config/avr/avr.c (avr_encode_section_info)
[progmem && !TREE_READONLY]: Error if progmem object needs
constructing.

From-SVN: r250151

7 years ago[testsuite] Fix dg-require-stack-check
Christophe Lyon [Wed, 12 Jul 2017 07:53:28 +0000 (07:53 +0000)]
[testsuite] Fix dg-require-stack-check

2017-07-12  Christophe Lyon  <christophe.lyon@linaro.org>

* lib/target-supports.exp (check_stack_check_available): Make
testcase name depend on stack_kind.

From-SVN: r250149

7 years agoaarch64-simd.md (aarch64_sub<mode>_compare0): New pattern.
Michael Collison [Wed, 12 Jul 2017 02:18:06 +0000 (02:18 +0000)]
aarch64-simd.md (aarch64_sub<mode>_compare0): New pattern.

2017-07-11  Michael Collison  <michael.collison@arm.com>

* config/aarch64/aarch64-simd.md(aarch64_sub<mode>_compare0):
New pattern.
* testsuite/gcc.target/aarch64/cmp-2.c: New testcase.

From-SVN: r250148

7 years agoDaily bump.
GCC Administrator [Wed, 12 Jul 2017 00:16:28 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r250147

7 years agore PR c++/51270 (missed warning about returning reference to temporary)
Paolo Carlini [Tue, 11 Jul 2017 21:24:11 +0000 (21:24 +0000)]
re PR c++/51270 (missed warning about returning reference to temporary)

2017-07-11  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/51270
* g++.dg/warn/Wreturn-local-addr-3.C: New.

From-SVN: r250140

7 years agoCore DR 393 - parameter pointer to array of unknown bound
Jason Merrill [Tue, 11 Jul 2017 18:41:32 +0000 (14:41 -0400)]
Core DR 393 - parameter pointer to array of unknown bound

* decl.c (grokparms): Downgrade error about array of unknown bound
to pedwarn and disable it for C++17.

From-SVN: r250137

7 years agors6000-c.c: Add support for builtins vector unsigned int vec_parity_lsbb (vector...
Carl Love [Tue, 11 Jul 2017 14:53:06 +0000 (14:53 +0000)]
rs6000-c.c: Add support for builtins vector unsigned int vec_parity_lsbb (vector signed int)...

gcc/ChangeLog:

2017-07-11  Carl Love  <cel@us.ibm.com>

* config/rs6000/rs6000-c.c: Add support for builtins
vector unsigned int vec_parity_lsbb (vector signed int);
vector unsigned int vec_parity_lsbb (vector unsigned int);
vector unsigned __int128 vec_parity_lsbb (vector signed __int128);
vector unsigned __int128 vec_parity_lsbb (vector unsigned __int128);
vector unsigned long long vec_parity_lsbb (vector signed long long);
vector unsigned long long vec_parity_lsbb (vector unsigned long long);
* config/rs6000/rs6000-builtin.def (VPARITY_LSBB): Add BU_P9V_OVERLOAD1.
* config/rs6000/altivec.h (vec_parity_lsbb): Add define.
* doc/extend.texi: Update the built-in documentation file for the
new built-in functions.

gcc/testsuite/ChangeLog:

2017-07-11  Carl Love  <cel@us.ibm.com>

* gcc.target/powerpc/builtins-2-p9-runnable.c: Add new file with
test cases for the builtins.

From-SVN: r250135

7 years agoFix ChangeLog omission in r250133
David Malcolm [Tue, 11 Jul 2017 14:02:27 +0000 (14:02 +0000)]
Fix ChangeLog omission in r250133

From-SVN: r250134

7 years agodiagnostics: support compact printing of secondary locations
David Malcolm [Tue, 11 Jul 2017 13:43:31 +0000 (13:43 +0000)]
diagnostics: support compact printing of secondary locations

gcc/ChangeLog:
* diagnostic-show-locus.c: Include "gcc-rich-location.h".
(layout::m_primary_loc): New field.
(layout::layout): Initialize new field.  Move location filtering
logic from here to...
(layout::maybe_add_location_range): ...this new method.  Add
support for filtering to just the lines already specified by other
locations.
(layout::will_show_line_p): New method.
(selftest::test_add_location_if_nearby): New test function.
(selftest::diagnostic_show_locus_c_tests): Call it.
* gcc-rich-location.h (gcc_rich_location::add_location_if_nearby):
New method.

From-SVN: r250133

7 years ago* decl2.c (reset_type_linkage_2): Dont't change ctor name.
Nathan Sidwell [Tue, 11 Jul 2017 12:28:21 +0000 (12:28 +0000)]
* decl2.c (reset_type_linkage_2): Dont't change ctor name.

From-SVN: r250130

7 years agoAdd extra initialization of broadcasted condition variables
Tom de Vries [Tue, 11 Jul 2017 12:25:01 +0000 (12:25 +0000)]
Add extra initialization of broadcasted condition variables

2017-07-11  Tom de Vries  <tom@codesourcery.com>

* config/nvptx/nvptx.c (WORKAROUND_PTXJIT_BUG): New macro.
(bb_first_real_insn): New function.
(nvptx_single): Add extra initialization of broadcasted condition
variables.

From-SVN: r250129