egdaniel [Fri, 5 Dec 2014 20:40:52 +0000 (12:40 -0800)]
Fix include for GrPortderDuffXferProcessor.cpp
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
771353005
bungeman [Fri, 5 Dec 2014 20:26:44 +0000 (12:26 -0800)]
Factor text size device mapping in SkScalerContext.
All of our font back-ends use the text size in some way other than
simple concatentation with the current matrix. The code here finds
the full device matrix and then decomposes it to extract the text
size.
FreeType, GDI, and DirectWrite use the text size as the pre-hint scale.
CoreText will not scale color emoji above the requested text size,
and certain features like 'trak' are performed on the text size.
Review URL: https://codereview.chromium.org/
748883005
joshualitt [Fri, 5 Dec 2014 20:14:43 +0000 (12:14 -0800)]
get rid of static gps
This may cause a perf regression
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
749413003
egdaniel [Fri, 5 Dec 2014 20:14:26 +0000 (12:14 -0800)]
Move GrPorterDuffXferProcessor to include/gpu/effects.
BUG=skia:
Review URL: https://codereview.chromium.org/
780263003
qiankun.miao [Fri, 5 Dec 2014 19:16:25 +0000 (11:16 -0800)]
Use size of SkRect as the key for blur mask cache
BUG=429409
Review URL: https://codereview.chromium.org/
708073002
reed [Fri, 5 Dec 2014 17:18:27 +0000 (09:18 -0800)]
rebaseline after change to imagefilterscropped gm change
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
779313002
jvanverth [Fri, 5 Dec 2014 15:56:53 +0000 (07:56 -0800)]
Fix overoptimization in distance field code on N7 and N10.
BUG=skia:3188
Review URL: https://codereview.chromium.org/
772633003
reed [Fri, 5 Dec 2014 15:33:00 +0000 (07:33 -0800)]
remove unnecessary save/clip/restore
BUG=skia:
Review URL: https://codereview.chromium.org/
785493003
mtklein [Fri, 5 Dec 2014 15:25:16 +0000 (07:25 -0800)]
Don't upload metrics we don't want to track.
BUG=skia:
Review URL: https://codereview.chromium.org/
758853004
bungeman [Fri, 5 Dec 2014 15:14:53 +0000 (07:14 -0800)]
Tolerate unstarted builds in rebaseline server.
Currently server.py --rietveld-issue will crash if there are any
unstarted trybots on the latest patch. Instead of crashing, warn
that the bot hasn't started yet.
Review URL: https://codereview.chromium.org/
758793003
skia.buildbots [Fri, 5 Dec 2014 07:03:33 +0000 (23:03 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
781043002
jvanverth [Fri, 5 Dec 2014 00:01:53 +0000 (16:01 -0800)]
Ignore failures for n7 and n10 dftext GM.
BUG=skia:3188
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
785433002
bsalomon [Thu, 4 Dec 2014 21:02:47 +0000 (13:02 -0800)]
clean up default precision handling
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
766753006
joshualitt [Thu, 4 Dec 2014 19:35:33 +0000 (11:35 -0800)]
Remove backend factories
BUG=skia:
Review URL: https://codereview.chromium.org/
778453002
mtklein [Thu, 4 Dec 2014 18:47:02 +0000 (10:47 -0800)]
nanobench: upload peak memory usage as its own trace.
We'll end up with a result like this:
"memory_usage" : {
"meta" : {
"max_rss_mb" : 57
}
}
BUG=skia:
Review URL: https://codereview.chromium.org/
780013002
jvanverth [Thu, 4 Dec 2014 18:46:50 +0000 (10:46 -0800)]
Ganesh text rendering cleanup.
Rename GrTextStrike.{cpp.h} to GrFontCache.{cpp,h}
Move contents of GrTextStrike_impl.h to GrFontCache.h
Move glyph uploading to a separate function and remove harmful gotos
Add assert on glyph upload failure (shouldn't happen)
Review URL: https://codereview.chromium.org/
780923002
halcanary [Thu, 4 Dec 2014 18:41:45 +0000 (10:41 -0800)]
rebaseline pdf-native
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
779073002
joshualitt [Thu, 4 Dec 2014 18:41:40 +0000 (10:41 -0800)]
create and thread batch tracker object
I remove the factory on the next CL
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
c3a6eb23483e5d28073b509a5f637f41660de294
Review URL: https://codereview.chromium.org/
772513002
halcanary [Thu, 4 Dec 2014 18:21:04 +0000 (10:21 -0800)]
pdf-mac clear to black rebaseline
NOTRY=true
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
783543002
joshualitt [Thu, 4 Dec 2014 16:59:10 +0000 (08:59 -0800)]
move program descriptor generation to flush
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
829e1b80b1020b17f2078020c990e079b70c077c
Review URL: https://codereview.chromium.org/
777673003
mtklein [Thu, 4 Dec 2014 16:46:51 +0000 (08:46 -0800)]
Upload picture byte size and op count metrics for SKP recording.
Look okay?
{
"results" : {
"desk_amazon.skp_1264_3999" : {
"nonrendering" : {
"bytes" : 75656,
"max_ms" : 1.150187,
"mean_ms" : 1.150187,
"median_ms" : 1.150187,
"min_ms" : 1.150187,
"ops" : 659,
"options" : {
"bench_type" : "recording",
"clip" : "0 0 1000 1000",
"name" : "desk_amazon.skp",
"scale" : "1",
"source_type" : "skp"
}
}
},
...
BUG=skia:
Review URL: https://codereview.chromium.org/
773323002
robertphillips [Thu, 4 Dec 2014 16:43:53 +0000 (08:43 -0800)]
Rebaseline multipicturedraw GMs
This is clean up after https://codereview.chromium.org/
753253002/ (Use variable length key (rather than accumulated matrix) as save layer hoisting key)
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
783523002
reed [Thu, 4 Dec 2014 16:39:09 +0000 (08:39 -0800)]
quick fix to land clear() change
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
774863003
robertphillips [Thu, 4 Dec 2014 16:31:02 +0000 (08:31 -0800)]
Fix SKPBench tiling so MPD and non-MPD match
Two issues with the SKPBench tile computation were causing the MPD path to do more work:
The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles
The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling).
Review URL: https://codereview.chromium.org/
776273002
reed [Thu, 4 Dec 2014 16:06:17 +0000 (08:06 -0800)]
check (thread-tricky) colortable after we've copied the bitmap into a per-thread context
BUG=skia:
Review URL: https://codereview.chromium.org/
766283004
mtklein [Thu, 4 Dec 2014 15:53:21 +0000 (07:53 -0800)]
Fix up RecordReplaceDrawTest memory leak.
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/151/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/
779973002
reed [Thu, 4 Dec 2014 15:50:14 +0000 (07:50 -0800)]
Change clear() to respect the clip
This reverts commit
af641a1c10f176cb9617026d3cc93c117a85d13d.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
783493002
qiankun.miao [Thu, 4 Dec 2014 14:27:03 +0000 (06:27 -0800)]
Add SSSE3 acceleration for S32_D16_filter_DXDY
With this CL, related nanobench can be improved for 565 config.
bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
Review URL: https://codereview.chromium.org/
773753002
joshualitt [Thu, 4 Dec 2014 14:01:45 +0000 (06:01 -0800)]
Revert of move program descriptor generation to flush (patchset #7 id:120001 of https://codereview.chromium.org/
777673003/)
Reason for revert:
breaking linux build
Original issue's description:
> move program descriptor generation to flush
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
829e1b80b1020b17f2078020c990e079b70c077c
TBR=egdaniel@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
776243005
joshualitt [Thu, 4 Dec 2014 14:00:41 +0000 (06:00 -0800)]
Revert of create and thread batch tracker object (patchset #9 id:160001 of https://codereview.chromium.org/
772513002/)
Reason for revert:
Breaking linux layout test
Original issue's description:
> create and thread batch tracker object
>
> I remove the factory on the next CL
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
c3a6eb23483e5d28073b509a5f637f41660de294
TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774133003
reed [Thu, 4 Dec 2014 11:48:34 +0000 (03:48 -0800)]
make clear private (before we delete it)
BUG=skia:
Review URL: https://codereview.chromium.org/
781593002
skia.buildbots [Thu, 4 Dec 2014 07:04:09 +0000 (23:04 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
776873006
jam [Wed, 3 Dec 2014 23:56:36 +0000 (15:56 -0800)]
Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY (patchset #3 id:40001 of https://codereview.chromium.org/
773753002/)
Reason for revert:
breaks build when not using SSE3, since the two method definitions differ in parameter types (typo)
Original issue's description:
> Add SSSE3 acceleration for S32_D16_filter_DXDY
>
> With this CL, related nanobench can be improved for 565 config.
> bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
TBR=mtklein@google.com,qkmiao@gmail.com,qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
761103003
joshualitt [Wed, 3 Dec 2014 23:34:20 +0000 (15:34 -0800)]
create and thread batch tracker object
I remove the factory on the next CL
BUG=skia:
Review URL: https://codereview.chromium.org/
772513002
joshualitt [Wed, 3 Dec 2014 21:57:36 +0000 (13:57 -0800)]
move program descriptor generation to flush
BUG=skia:
Review URL: https://codereview.chromium.org/
777673003
reed [Wed, 3 Dec 2014 21:17:29 +0000 (13:17 -0800)]
Revert of Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
777003002/)
Reason for revert:
fix landed in chrome to allow this (I hope)
Original issue's description:
> Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
765643004/)
>
> Reason for revert:
> ../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
>
>
> Original issue's description:
> > remove unused device::eraseColor
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/
b1ab276c3719d6690e58f347c25126d2b8929c5d
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
8b0197ef2e32be9d62e79d58f8b50811975c79c6
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
779543004
tfarina [Wed, 3 Dec 2014 21:13:02 +0000 (13:13 -0800)]
Add SK_SUPPORT_LEGACY_PORTER_DUFF macro.
This trick will be used to remove deprecated SkPorterDuff API. But first
we need to add it so Android can be updated later.
BUG=skia:3178
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
758133004
mtklein [Wed, 3 Dec 2014 21:07:39 +0000 (13:07 -0800)]
Turn on MPD threading in nanobench.
Seems okay after this small patch to skip lockPixels() / unlockPixels().
BUG=skia:3149
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot
Review URL: https://codereview.chromium.org/
773203003
egdaniel [Wed, 3 Dec 2014 20:22:51 +0000 (12:22 -0800)]
Remove guard on and enable vertexAttrib function pts on GrGLInterface.
BUG=skia:
Review URL: https://codereview.chromium.org/
774303003
egdaniel [Wed, 3 Dec 2014 19:41:54 +0000 (11:41 -0800)]
Use static XPF for porter duff xp factories.
BUG=skia:
Review URL: https://codereview.chromium.org/
776843004
mtklein [Wed, 3 Dec 2014 19:08:47 +0000 (11:08 -0800)]
Copy src in SkDrawLooper::computeFastBounds().
We do alias src and dst when building the BBH. This meant we calculated
the wrong bounds in LayoutTests/ietestcenter/css3/text/textshadow-010.htm.
Not sure how best to test this inside Skia. It may become moot after I
work through the API changes we were talking about today, but if not I'll
make sure it's tested somehow before I'm done with SkDrawLoopers.
BUG=skia:3186
Review URL: https://codereview.chromium.org/
760023004
halcanary [Wed, 3 Dec 2014 19:03:52 +0000 (11:03 -0800)]
Fix PdfViewer BGR byte order
BUG=skia:3184
Review URL: https://codereview.chromium.org/
775763003
bsalomon [Wed, 3 Dec 2014 18:46:08 +0000 (10:46 -0800)]
Add glGetShaderPrecisionFormat
Review URL: https://codereview.chromium.org/
778703003
halcanary [Wed, 3 Dec 2014 18:41:11 +0000 (10:41 -0800)]
Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
765643004/)
Reason for revert:
../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
Original issue's description:
> remove unused device::eraseColor
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
b1ab276c3719d6690e58f347c25126d2b8929c5d
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
777003002
egdaniel [Wed, 3 Dec 2014 18:40:13 +0000 (10:40 -0800)]
Add XferProcessor factory in GrPaint and GrDrawState.
In this CL the XP should have zero effect on the actual rendering pipeline.
BUG=skia:
Review URL: https://codereview.chromium.org/
751283002
Brian Salomon [Wed, 3 Dec 2014 18:36:10 +0000 (13:36 -0500)]
rebaseline images
TBR=
Review URL: https://codereview.chromium.org/
776983003
jvanverth [Wed, 3 Dec 2014 18:35:37 +0000 (10:35 -0800)]
Update color emoji GMs after https://codereview.chromium.org/
759613005/.
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
775163002
reed [Wed, 3 Dec 2014 17:47:48 +0000 (09:47 -0800)]
remove unused device::eraseColor
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
765643004
joshualitt [Wed, 3 Dec 2014 17:29:52 +0000 (09:29 -0800)]
bug fix for cubic low precision
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
776953002
halcanary [Wed, 3 Dec 2014 16:59:48 +0000 (08:59 -0800)]
update tileimagefilter gm expectations
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
777683002
mtklein [Wed, 3 Dec 2014 16:48:57 +0000 (08:48 -0800)]
Decompose a weird assert.
I got my hands on a list of new warnings coming out of MSVC when run with /analyze.
I scanned over them and didn't see any bugs, but I did notice this is just a weird
way to write this expression. (MSVC /analyze was wary of '=' in a boolean expression.)
BUG=skia:
Review URL: https://codereview.chromium.org/
776033002
Mike Klein [Wed, 3 Dec 2014 16:32:37 +0000 (11:32 -0500)]
Rebaseline verylargebitmap
BUG=skia:
Review URL: https://codereview.chromium.org/
778693002
mtklein [Wed, 3 Dec 2014 16:18:46 +0000 (08:18 -0800)]
Remove unused constants.
BUG=skia:
Review URL: https://codereview.chromium.org/
773193004
halcanary [Wed, 3 Dec 2014 16:17:57 +0000 (08:17 -0800)]
(re)baseline several of my gms
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
780593002
robertphillips [Wed, 3 Dec 2014 15:33:57 +0000 (07:33 -0800)]
Fuse GrReplacements and GrLayerCache
The conversion step from GrCachedLayer to ReplacementInfo isn't necessary.
Review URL: https://codereview.chromium.org/
769533004
joshualitt [Wed, 3 Dec 2014 14:24:10 +0000 (06:24 -0800)]
First step to moving vertex attributes to the geometryProcessor
BUG=skia:
Review URL: https://codereview.chromium.org/
761563002
kkinnunen [Wed, 3 Dec 2014 14:18:12 +0000 (06:18 -0800)]
Make debugger not fail with webpages_playback script and multiple skp files
The debugger accepts either a single skp or a directory as a parameter.
The webpages_playback script used to pass multiple files using a '*'
glob.
Review URL: https://codereview.chromium.org/
775073002
kkinnunen [Wed, 3 Dec 2014 13:51:24 +0000 (05:51 -0800)]
Update webpages_playback documentation
Update the documentation on how to run webpages_playback. It was out of
date.
Review URL: https://codereview.chromium.org/
778633002
kkinnunen [Wed, 3 Dec 2014 12:38:46 +0000 (04:38 -0800)]
Remove Google Storage scheme prefix correctly from gs base name in webpages_playback
In python, str.lstrip([chars]) means "lstrip any of the chars from str",
not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia".
Replace with custom function stripping the prefix from lstrip()ed gs
base name.
Review URL: https://codereview.chromium.org/
780493002
kkinnunen [Wed, 3 Dec 2014 12:22:06 +0000 (04:22 -0800)]
Make render_pdfs not crash webpages_playback script
The render_pdfs nowadays seems to input the skps from
the dir passed as '-r' parameter.
The app will not output anything, but it will not crash the
webpages_playback script either. Affects only runs that have
--skia_tools=<dir> argument.
Review URL: https://codereview.chromium.org/
776873004
skia.buildbots [Wed, 3 Dec 2014 07:05:53 +0000 (23:05 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
773113004
reed [Wed, 3 Dec 2014 04:04:40 +0000 (20:04 -0800)]
Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE (patchset #1 id:1 of https://codereview.chromium.org/
759303004/)
Reason for revert:
reverted clear() change
Original issue's description:
> rebaseline after clear change -- pdf was not treating clear as SRC_MODE
>
> BUG=skia:
> NOTRY=True
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
2fb352abebc342a322d4a66c054bbff8bd565767
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774073002
reed [Wed, 3 Dec 2014 03:40:18 +0000 (19:40 -0800)]
Revert "Change clear() to respect the clip"
This reverts commit
3729469d6a12266037b697c2192768545e097ab0.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
778563002
reed [Wed, 3 Dec 2014 03:11:30 +0000 (19:11 -0800)]
Revert of implement device::clear until we can remove callers in chrome skia/ext (patchset #1 id:1 of https://codereview.chromium.org/
773903002/)
Reason for revert:
failing win unittests
Original issue's description:
> implement device::clear until we can remove callers in chrome skia/ext
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
252fccfb546efe83fb1d2c7a0b3c18a96ff46ea4
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774063002
qiankun.miao [Wed, 3 Dec 2014 02:26:09 +0000 (18:26 -0800)]
Add SSSE3 acceleration for S32_D16_filter_DXDY
With this CL, related nanobench can be improved for 565 config.
bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
BUG=skia:
Review URL: https://codereview.chromium.org/
773753002
abarth [Tue, 2 Dec 2014 23:47:33 +0000 (15:47 -0800)]
Add matrix operations to C canvas API
R=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
769123002
halcanary [Tue, 2 Dec 2014 22:01:46 +0000 (14:01 -0800)]
work in progress
Review URL: https://codereview.chromium.org/
769423002
derekf [Tue, 2 Dec 2014 21:51:29 +0000 (13:51 -0800)]
check matrix does not have rotation or perspective transformation
When checking whether we need apply AA to a rect for non-msaa target,
simply checking that the mapped rect is integer is not enough.
We need to check whether the transformation matrix has transformations
other than simple translation.
Original-Author: Henry Song <henrysong@samsung.com>
Review URL: https://codereview.chromium.org/
772953002
mtklein [Tue, 2 Dec 2014 21:17:05 +0000 (13:17 -0800)]
Flail a little against LLVM crash.
Cannot reproduce this in my local Chromium checkout (using their Clang, just like the bots).
BUG=skia:
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
764433003
reed [Tue, 2 Dec 2014 20:53:04 +0000 (12:53 -0800)]
implement device::clear until we can remove callers in chrome skia/ext
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
773903002
halcanary [Tue, 2 Dec 2014 20:31:26 +0000 (12:31 -0800)]
baseline colorwheelnative
TBR=scroggo@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
777443002
scroggo [Tue, 2 Dec 2014 20:30:38 +0000 (12:30 -0800)]
Remove SK_SUPPORT_DEPRECATED_SCALARROUND.
Our clients no longer require it.
Review URL: https://codereview.chromium.org/
772933002
reed [Tue, 2 Dec 2014 20:21:02 +0000 (12:21 -0800)]
rebaseline after clear change -- pdf was not treating clear as SRC_MODE
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
759303004
Justin Novosad [Tue, 2 Dec 2014 19:50:56 +0000 (14:50 -0500)]
Adding a PictureResolution option to SkPictureImageFilter
This change adds an option to SkPictureImageFilter to make it
rasterize SkPicture in a resolution that matches the local coordinate
space (equivalent to the record-time device space).
BUG=skia:3176
R=reed@google.com, senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
753073010
derekf [Tue, 2 Dec 2014 19:02:06 +0000 (11:02 -0800)]
use drawRect when drawing a bitmap with anti-aliasing on a non-msaa target
If the dest isn't pixel aligned, or if a non 90 degree rotation is
present, we need to use drawRect() for drawing anti-aliased bitmaps on
non-msaa targets or the edges won't be anti-aliased as intended.
Note: If the bitmap size is bigger than max texture size we fall back to drawBitmapCommon.
Original-Author: Henry Song <henrysong@samsung.com>
Review URL: https://codereview.chromium.org/
649313003
halcanary [Tue, 2 Dec 2014 19:00:40 +0000 (11:00 -0800)]
use portable fonts
Review URL: https://codereview.chromium.org/
769343002
reed [Tue, 2 Dec 2014 18:08:11 +0000 (10:08 -0800)]
Change clear() to respect the clip
patch from issue
769703002 at patchset 1 (http://crrev.com/
769703002#ps1)
BUG=skia:
Review URL: https://codereview.chromium.org/
772533004
mtklein [Tue, 2 Dec 2014 18:02:47 +0000 (10:02 -0800)]
Make SkColorTable explicitly thread-safe.
Mostly this means using SkLazyPtr for the 16-bit cache.
We can remove the copy constructor now and just ref it instead.
BUG=skia:
Review URL: https://codereview.chromium.org/
769323002
bsalomon [Tue, 2 Dec 2014 17:40:12 +0000 (09:40 -0800)]
move some copy surface stuff to GrFlushToGpuDrawTarget
Review URL: https://codereview.chromium.org/
770813002
halcanary [Tue, 2 Dec 2014 17:37:17 +0000 (09:37 -0800)]
colorwheelnative gm, to test that colors look right under all conditions.
Motivation: colorwheel on pdf-native (MacOS coregraphics) reverses Blue and Red. I want to see if this has anything to do with image decoding.
BUG=skia:3184
Review URL: https://codereview.chromium.org/
774713003
mtklein [Tue, 2 Dec 2014 17:11:25 +0000 (09:11 -0800)]
SkColorTable locking serves no purpose anymore.
The only thing the unlock methods were doing was assert their balance.
This removes the unlock methods and renames the lock methods "read".
BUG=skia:
Review URL: https://codereview.chromium.org/
719213008
robertphillips [Tue, 2 Dec 2014 17:00:59 +0000 (09:00 -0800)]
Remove comment
Review URL: https://codereview.chromium.org/
770323002
hendrikw [Tue, 2 Dec 2014 15:30:30 +0000 (07:30 -0800)]
skia: Prevent GL_RED from being used with MESA
MESA unfortunately doesn't support GL_RED or GL_RG when used with frame buffers.
Don't allow fTextureRedSupport to be set when using MESA.
BUG=skia:3181
Review URL: https://codereview.chromium.org/
769073003
halcanary [Tue, 2 Dec 2014 15:29:18 +0000 (07:29 -0800)]
updated expectations from
d476a176b774
BUG=skia:3180
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
773833002
halcanary [Tue, 2 Dec 2014 14:37:21 +0000 (06:37 -0800)]
Remove PDF JPEG shortcut, since it fails on grayscale JPEGs.
BUG=436079
Review URL: https://codereview.chromium.org/
767343002
bungeman [Mon, 1 Dec 2014 23:04:53 +0000 (15:04 -0800)]
Remove support for OSX 10.5.
No user supports OSX 10.5 at this point, so remove the
last support for building there.
Review URL: https://codereview.chromium.org/
768133005
bungeman [Mon, 1 Dec 2014 23:03:54 +0000 (15:03 -0800)]
Remove SkASSERT_CONTINUE.
This macro is no longer used.
Review URL: https://codereview.chromium.org/
770923002
abarth [Mon, 1 Dec 2014 22:04:03 +0000 (14:04 -0800)]
Add scale and skew to C canvas API
R=reed@chromium.org
BUG=skia:
Review URL: https://codereview.chromium.org/
762493005
bungeman [Mon, 1 Dec 2014 22:01:32 +0000 (14:01 -0800)]
Clean up FreeType library ref counting.
The existing reference counting and code for LCD is difficult to
understand. This cleans it up a bit in preperation for the typefaces
holding the references and faces themselves which will clean this up
quite a bit more.
Review URL: https://codereview.chromium.org/
742483004
reed [Mon, 1 Dec 2014 21:54:01 +0000 (13:54 -0800)]
add gm to test rounding between clips and drawBitmapRect
BUG=skia:3179
Review URL: https://codereview.chromium.org/
766333002
mtklein [Mon, 1 Dec 2014 21:03:22 +0000 (13:03 -0800)]
SkDrawLooper: No need for virtual bounds computation methods.
No subclass overrides either method.
This is just warmup. Perf is neutral. The real meat of the time spent
is inside canComputeFastBounds / computeFastBounds, not getting to them.
BUG=skia:
Review URL: https://codereview.chromium.org/
772573003
egdaniel [Mon, 1 Dec 2014 20:30:50 +0000 (12:30 -0800)]
Add function to return an unpremuled version of a GrColor
BUG=skia:
Review URL: https://codereview.chromium.org/
773553002
halcanary [Mon, 1 Dec 2014 20:21:25 +0000 (12:21 -0800)]
multipage_pdf_profiler, gmtoskp
Review URL: https://codereview.chromium.org/
769083003
mtklein [Mon, 1 Dec 2014 20:06:24 +0000 (12:06 -0800)]
Pre-cache local matrix type in shader constructor.
TSAN points out we race when choosing our blitter without this.
BUG=437511
Review URL: https://codereview.chromium.org/
773563002
mtklein [Mon, 1 Dec 2014 19:47:08 +0000 (11:47 -0800)]
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.
This was needed for pictures before v33, and we're now requiring v35+.
Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
52c293547b973f7fb5de3c83f5062b07d759ab88
Review URL: https://codereview.chromium.org/
769953002
robertphillips [Mon, 1 Dec 2014 19:39:59 +0000 (11:39 -0800)]
Add additional clean up code in MPD path
This addresses an edge case where a picture only has one layer which is atlasable but doesn't make it into the atlas. In this case asserts can fire since there is no atlased layer to clean up the tracking picture object.
Review URL: https://codereview.chromium.org/
764393002
scroggo [Mon, 1 Dec 2014 19:35:19 +0000 (11:35 -0800)]
Remove orphaned SkImageDecoder::Target.
This was used by an experimental method on SkImageDecoder, which no
longer exists.
Review URL: https://codereview.chromium.org/
760923003
mtklein [Mon, 1 Dec 2014 19:03:37 +0000 (11:03 -0800)]
Force SkMatrix type while recording too.
This switches to a new way of doing this, enforcing the caching with the type
recorded rather than having to do it in SkRecorder. Should be more foolproof.
Updated SkPath and SkBitmap's equivalents too. ImmutableBitmap was close,
but using inheritance now makes the rest of the code less weird.
BUG=437511
I'm not sure whether or not this will _fix_ the SkMatrix aspect of that bug.
There may be other SkMatrices that we're racing on. It does cover the obvious
ones, though, and removing the SkTRacy<> wrapper will allow TSAN to show
us any other races.
It turned out to be easier to turn missing optional matrices into I early rather
than late. I figure this should be harmless. Recording and playback perf both
look neutral.
Review URL: https://codereview.chromium.org/
773433003
mtklein [Mon, 1 Dec 2014 18:56:05 +0000 (10:56 -0800)]
Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (patchset #1 id:1 of https://codereview.chromium.org/
769953002/)
Reason for revert:
Breaks canary builds. Will reland after the Chromium change lands.
Original issue's description:
> Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.
>
> This was needed for pictures before v33, and we're now requiring v35+.
>
> Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
52c293547b973f7fb5de3c83f5062b07d759ab88
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
768183002
mtklein [Mon, 1 Dec 2014 18:23:11 +0000 (10:23 -0800)]
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.
This was needed for pictures before v33, and we're now requiring v35+.
Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc
BUG=skia:
Review URL: https://codereview.chromium.org/
769953002