Paul Wilkins [Sat, 4 Dec 2010 10:04:12 +0000 (10:04 +0000)]
Change to inter_minq table.
The inter_minq table controls the range of quantizers available
for a particular frame in two pass relative to a max Q value.
The changes reduces the range somewhat. The effect of this
was a small increase (0.3% average) in psnr for the test set
but it should also help encode speed somewhat for higher
quality modes as it will reduce the number of iterations in the
recode loop.
The change damps the range of quantizers available locally
within a section of a clip and should therefore help keep quality
more uniform. If there is systematic overshoot or undershoot the
range can shift gradually to accommodate. However, there is
some increased risk of overshoot or undershoot against the target
bit rate in VBR mode and this risk will be more pronounced for short
clips.
The change damps the range of quantizers available locally
within a section of a clip and should therefore help keep quality
more uniform. If there is systematic overshoot or undershoot the
range can shift gradually to accommodate. However, there is
some increased risk of overshoot or undershoot against the
target bit rate in VBR mode and this risk will be more
pronounced for short clips.
Change-Id: I84465567d49ae767c6c73ff2a2aac30c895adb52
Fritz Koenig [Thu, 18 Nov 2010 18:40:58 +0000 (10:40 -0800)]
Set refresh_alt_ref_frame on keyframe encode.
On a keyframe alt ref and golden are refreshed. The flag was
not being set and so on the frame after a keyframe, motion
search would occur on the alt ref frame. This is not necessary
because the alt ref frame identical to the last frame in this
scenario.
Handle corner case where a forward alt-ref frame is put
directly after a keyframe.
Change-Id: I9be4cf290d694f8cf2f9a31852014b5ccf1504d3
Pascal Massimino [Wed, 24 Nov 2010 08:22:59 +0000 (00:22 -0800)]
allow dimensions as low as 1 pixel
remove warning comment in vpxenc.c: in case of 1x1 picture,
detect_bytes will be equal to '3' and we'll fall back to
RAW_TYPE.
fix read_frame() by tracking the pre-read buffer length
in the struct detect
Change-Id: If1ed86ee5260dcdbc8f9d10da6cbb84a4cc2f151
John Koleszar [Tue, 23 Nov 2010 20:39:03 +0000 (12:39 -0800)]
Merge "vpxdec: fix use of uninitialized memory for raw files"
John Koleszar [Tue, 23 Nov 2010 20:38:20 +0000 (12:38 -0800)]
Merge changes I3aed713e,I9ef7f56e,Ic18c60df
* changes:
vp8_set_maps: remove hard-coded width/height
vp8mt_alloc_temp_buffers: make prototype return void
Disable compile warning for ERROR macro
John Koleszar [Tue, 23 Nov 2010 18:40:31 +0000 (13:40 -0500)]
vpxdec: fix use of uninitialized memory for raw files
The sz member of the vpx_codec_stream_info_t structure must be
initialized when passed to vpx_codec_peek_stream_info().
Change-Id: I2d13d287d9639262b932cf44671a595fdf3c38ef
Paul Wilkins [Mon, 22 Nov 2010 13:17:35 +0000 (13:17 +0000)]
Recalibration of bits per MB tables
The baseline bits per MB prediction tables have been
re calibrated based on the assumption that bits per mb
is inversely proportional to the quantizer level.
Change-Id: Ibd355c7acac4b8053dda1baf1032fe35f11da7f7
Paul Wilkins [Mon, 22 Nov 2010 12:11:20 +0000 (04:11 -0800)]
Merge "Added extra two pass stats gathering."
Paul Wilkins [Fri, 12 Nov 2010 11:35:30 +0000 (11:35 +0000)]
Added extra two pass stats gathering.
Added code to record spend so far against planed budget.
Change-Id: I5a3335346fa1771b2b1219df9f6127f9993d2594
Pascal Massimino [Thu, 18 Nov 2010 00:50:02 +0000 (16:50 -0800)]
remove warning
was having: "vp8/encoder/onyx_if.c:5365: warning: comparison of unsigned expression >= 0 is always true"
Scott LaVarnway [Wed, 17 Nov 2010 19:28:22 +0000 (11:28 -0800)]
Merge "Removed unnecessary checks."
Scott LaVarnway [Wed, 17 Nov 2010 18:15:13 +0000 (13:15 -0500)]
Removed unnecessary checks.
macro_block_yrd and vp8_rdcost_mby are not called for SPLITMV.
Change-Id: I2224d3c8725df526d48426447482768d543752f1
Paul Wilkins [Wed, 17 Nov 2010 15:12:04 +0000 (15:12 +0000)]
Replaced recode loop test with a function call
Replaced existing code to decide if a frame recode is required
with a function call. This is to simplify addition of extra clauses
that may be needed for the planned constrained quality mode.
Also fixed a bug where by alt ref not considered in the test.
Change-Id: I3d40bb21abe3e19f8456761e6849deb171738b60
John Koleszar [Wed, 17 Nov 2010 14:23:52 +0000 (09:23 -0500)]
vp8_set_maps: remove hard-coded width/height
The example for disabling the active map used a hard-coded 320x240
resolution, rather than using what was passed on the command line.
Fixes #218
Change-Id: I3aed713e8aa7fcbf18dfbffd57f142b5cd9ee492
John Koleszar [Wed, 17 Nov 2010 14:13:54 +0000 (09:13 -0500)]
vp8mt_alloc_temp_buffers: make prototype return void
This function was never called in a context expecting a return value,
the return value was always a constant, and the !CONFIG_MULTITHREAD
path didn't have a return statement, which caused a compiler warning.
This patch changes the function to return void instead.
Fixes issue #231
Change-Id: I9ef7f56e54418b7265026c54fc4ed5660c1418d1
John Koleszar [Wed, 17 Nov 2010 14:08:47 +0000 (09:08 -0500)]
Disable compile warning for ERROR macro
The ERROR macro collides wiith the MS SDK on Windows. Since we're not
making any win32 calls in this function, just #undef it first to take
ownership.
Change-Id: Ic18c60dfa3a33c52e6c49d3f4f8d3e7e3ac3341d
Fritz Koenig [Wed, 17 Nov 2010 00:11:39 +0000 (16:11 -0800)]
Merge "Comments for alt ref flags."
Fritz Koenig [Tue, 16 Nov 2010 23:16:24 +0000 (15:16 -0800)]
Comments for alt ref flags.
Clarify what the alt ref flags do when encoding.
Change-Id: I71f78e0f42edae633fb91840f29dfbe64362c44c
Yaowu Xu [Tue, 16 Nov 2010 22:06:44 +0000 (14:06 -0800)]
Merge "correct errors in token alphabet descriptions"
tomfinegan [Tue, 16 Nov 2010 19:52:05 +0000 (14:52 -0500)]
Add x86_64-darwin10-gcc target.
Adds native build configuration for Snow Leopard. Useful when
users configure without arguments on OSX 10.6.
Change-Id: I0bd63912a25bbfb9d4c8d58a781d0f390792429c
Yaowu Xu [Tue, 16 Nov 2010 18:51:43 +0000 (10:51 -0800)]
correct errors in token alphabet descriptions
There were a few errors in the comment section that describe VP8 token
alphabet table.
Change-Id: Ie6728a0e08bc3798893221b60408d5b201064bdc
Fritz Koenig [Thu, 11 Nov 2010 18:15:58 +0000 (10:15 -0800)]
Remove stack shadowing for x86-x64 for SAD functions.
x86-64 passes arguments in registers. There is no need to push
them to the stack before using them.
This fixes
15acc84f10cefd98b2f8dbd2eac2cc92c5a3f851 where ebx
was not getting preserved on x86.
Change-Id: I1214b5f818a0201f75ab6ad7d5c6f448e09b16c2
Paul Wilkins [Mon, 15 Nov 2010 17:55:35 +0000 (09:55 -0800)]
Merge "Bad cost tables used in ARNR filtering."
Paul Wilkins [Mon, 15 Nov 2010 17:47:12 +0000 (17:47 +0000)]
Bad cost tables used in ARNR filtering.
The use of incorrect mv costing tables in the ARNR sub-pel
filtering code led to corruption of the altref buffer in some cases,
particularly at low data rates.
The average gain from this fix is about 0.3% but there are a few
extreme cases where nasty and visible artifacts manifested and
for these few data points the improvement is > 10%.
PGW and AWG
Change-Id: I95cc02b196a433e71d0d2bd2b933fe68ed31e796
Yaowu Xu [Mon, 15 Nov 2010 17:22:45 +0000 (09:22 -0800)]
Merge "make rdmult adaptive for intra in quantizer RDO"
Frank Galligan [Thu, 4 Nov 2010 03:33:00 +0000 (23:33 -0400)]
Fixed bug first cluster timecode of webm file is wrong.
When the first pts equaled 0 ivfenc was incorrectly increasing the
pts by 1. I changed the pts and last pts to be signed. I also set
the default value of last pts to -1.
Change-Id: I30bcec5af9b16d93fa9e3abbea7764b133e9cd73
Yaowu Xu [Thu, 11 Nov 2010 05:16:17 +0000 (21:16 -0800)]
make rdmult adaptive for intra in quantizer RDO
This intends to correct the tendency that VP8 aggressively favors rate
on intra coded frames. Experiments tested different numbers in [0, 1]
and found 9/16 overall provided about 2-4% gains for all-intra coded
clips based on vpx-ssim metric. The impact on regular encoded clips
is much smaller but positive overall. Overall impact on psnr is also
positive even though very small.
Change-Id: If808553aaaa87fdd44691f9787820ac9856d9f8a
John Koleszar [Thu, 11 Nov 2010 17:41:07 +0000 (12:41 -0500)]
quantizer: fix assertion in fast quantizer path
The fast quantizer assembly code has not been updated to match the new
exact quantizer, which was made the default in commit 6adbe09.
Specifically, they are not aware of the potential for the coefficient
to be scaled, which results in the quantized result exceeding the range
of the DCT. This patch restores the previous behavior of using the
non-shifted coefficients when in the fast quantizer code path, but
unfortunately requires rebuilding the tables when switching between the
two.
Change-Id: I0a33f5b3850335011a06906f49fafed54dda9546
Fritz Koenig [Thu, 11 Nov 2010 16:19:37 +0000 (08:19 -0800)]
Revert "Remove stack shadowing for x86-64"
This reverts commit
15acc84f10cefd98b2f8dbd2eac2cc92c5a3f851.
Change-Id: Ia640be8cbc134432914849c1750f62575ea084e6
Paul Wilkins [Thu, 11 Nov 2010 10:39:20 +0000 (02:39 -0800)]
Merge "Relax rate control for last few frames"
Fritz Koenig [Wed, 10 Nov 2010 22:51:49 +0000 (14:51 -0800)]
configure : Incorrect syntax in configure
Check to see if postproc was enabled when enabling the
postproc visualizer was wrong.
Fix for bug introduced in Change Ia74f357d
Change-Id: I4bee9ad2caee3cfe3bac6972047f6af7c54cad4e
Fritz Koenig [Wed, 10 Nov 2010 22:36:10 +0000 (14:36 -0800)]
Merge "Remove stack shadowing for x86-64"
Fritz Koenig [Thu, 21 Oct 2010 17:53:15 +0000 (10:53 -0700)]
FDCT optimizations.
Fixed up the fdct for mmx and 8x4 sse2 to match them
most recent changes.
Change-Id: Ibee2d6c536fe14dcf75cd6eb1c73f4848a56d719
Fritz Koenig [Thu, 4 Nov 2010 23:03:36 +0000 (16:03 -0700)]
postproc : Re-work posproc calling to allow more flags.
Debugging in postproc needs more flags to allow for specific
block types to be turned on or off in the visualizations.
Must be enabled with --enable-postproc-visualizer during
configuration time.
Change-Id: Ia74f357ddc3ad4fb8082afd3a64f62384e4fcb2d
Paul Wilkins [Wed, 10 Nov 2010 10:09:45 +0000 (10:09 +0000)]
Relax rate control for last few frames
VBR rate control can become very noisy for the last few frames.
If there are a few bits to spare or a small overshoot then the
target rate and hence quantizer may start to fluctuate wildly.
This patch prevents further adjustment of the active Q limits for
the last few frames.
Patch also removes some redundant variables and makes one small bug fix.
Change-Id: Ic167831bec79acc9f0d7e4698bcc4bb188840c45
Paul Wilkins [Mon, 8 Nov 2010 15:28:54 +0000 (15:28 +0000)]
Tuning for the more exact quantizer.
Small changes to the default zero bin and rounding tables.
Though the tables are currently the same for the Y1 and Y2 cases
I have left them as separate tables in case we want to tune this later.
There is now some adjustment of the zbin based on the prediction mode.
Previously this was restricted to an adjustment for gf/arf 0,0 MV.
The exact quantizer now marginal outperforms and is the default.
The overall average gain is about 0.5%
Change-Id: I5e4353f3d5326dde4e86823684b236a1e9ea7f47
John Koleszar [Tue, 9 Nov 2010 16:52:16 +0000 (08:52 -0800)]
Merge "improve average framerate calculation"
John Koleszar [Fri, 5 Nov 2010 20:49:17 +0000 (16:49 -0400)]
Merge commit 'fix integer promotion bug in partition size check'
Change-Id: I4081917b46013fa8f4218cade8bd12cb2d013aee
John Koleszar [Thu, 4 Nov 2010 20:59:26 +0000 (16:59 -0400)]
fix integer promotion bug in partition size check
The check '(user_data_end - partition < partition_size)' must be
evaluated as a signed comparison, but because partition_size was
unsigned, the LHS was promoted to unsigned, causing an incorrect
result on 32-bit. Instead, check the upper and lower bounds of
the segment separately.
Change-Id: I6266aba7fd7de084268712a3d2a81424ead7aa06
John Koleszar [Thu, 4 Nov 2010 19:05:45 +0000 (15:05 -0400)]
improve average framerate calculation
Change Ice204e86 identified a problem with bitrate undershoot due to
low precision in the timestamps passed to the library. This patch
takes a different approach by calculating the duration of this frame
and passing it to the library, rather than using a fixed duration
and letting the library average it out with higher precision
timestamps. This part of the fix only applies to vpxenc.
This patch also attempts to fix the problem for generic applications
that may have made the same mistake vpxenc did. Instead of
calculating this frame's duration by the difference of this frame's
and the last frame's start time, we use the end times instead. This
allows the framerate calculation to scavenge "unclaimed" time from
the last frame. For instance:
start | end | calculated duration
======+=======+====================
0ms 33ms 33ms
33ms 66ms 33ms
66ms 99ms 33ms
100ms 133ms 34ms
Change-Id: I92be4b3518e0bd530e97f90e69e75330a4c413fc
John Koleszar [Fri, 5 Nov 2010 02:18:53 +0000 (19:18 -0700)]
Merge "vpxdec: report parse errors from webm_guess_framerate()"
John Koleszar [Thu, 4 Nov 2010 18:54:51 +0000 (14:54 -0400)]
vpxdec: report parse errors from webm_guess_framerate()
If this function fails silently, the nestegg context is destroyed and
future nestegg calls will segfault.
Change-Id: Ie6a0ea284ab9ddfa97b1843ef8030a953937c8cd
Fritz Koenig [Thu, 4 Nov 2010 18:28:18 +0000 (11:28 -0700)]
Merge "postproc : Update visualizations."
Fritz Koenig [Thu, 4 Nov 2010 17:35:02 +0000 (10:35 -0700)]
postproc : Update visualizations.
Change color reference frame to blend the macro block edge.
This helps with layering of visualizations.
Add block coloring for intra prediction modes.
Change-Id: Icefe0e189e26719cd6937cebd6727efac0b4d278
Yaowu Xu [Wed, 3 Nov 2010 19:56:31 +0000 (12:56 -0700)]
Increase the resolution of default timebase
The old value 1000 was too low, which caused the effective duration and
frame rate calculation to have an 1% error for typical 30 frame/second
inputs. Symptom of the issue has been that most 2 pass encodings were
undershooting target bit rate by 1% or so for 30 fps input.
Change-Id: Ice204e86f844ceb9ce973456f2b995cc095283cf
John Koleszar [Wed, 3 Nov 2010 17:58:40 +0000 (13:58 -0400)]
vpxenc: require width and height for raw streams
Defaulting to 320x240 for raw streams is arbitrary and error-prone.
Instead, require that the width and height be set manually if they
can't be parsed from the input file.
Change-Id: Ic61979857e372eed0779c2677247e894f9fd6160
John Koleszar [Wed, 3 Nov 2010 00:01:54 +0000 (17:01 -0700)]
Merge "fix pipe support on windows"
Fritz Koenig [Tue, 2 Nov 2010 20:29:13 +0000 (13:29 -0700)]
postproc : Fix display of motion vectors.
Split motion vectors were all being treated as 4x4
blocks. Now correctly handle 16x8, 8x16, 8x8, 4x4
blocks.
Change-Id: Icf345c5e69b5e374e12456877ed7c41213ad88cc
Scott LaVarnway [Tue, 2 Nov 2010 13:27:29 +0000 (06:27 -0700)]
Merge "SSSE3 version of fast quantizer"
John Koleszar [Tue, 2 Nov 2010 13:11:57 +0000 (09:11 -0400)]
fix pipe support on windows
STDIO streams are opened in text mode by default on Windows. This patch
changes the stdin/stdout streams to be in binary mode if they are being
used for I/O from the vpxenc or vpxdec tools.
Fixes issue #216. Thanks to mw AT hesotech.de for the fix.
Change-Id: I34525b3ce2a4a031d5a48d36df4667589372225b
Fritz Koenig [Mon, 1 Nov 2010 21:41:41 +0000 (14:41 -0700)]
Merge "postproc : Added SPLITMV visualization, fix line constrain."
Fritz Koenig [Sat, 30 Oct 2010 00:09:33 +0000 (17:09 -0700)]
postproc : Added SPLITMV visualization, fix line constrain.
Now draw 16 vectors for SPLITMV mode.
Fixed constrain line to block divide by zero issues.
Blend block was not centering the shaded area correctly.
Change-Id: I1edabd8b4e553aac8d980f7b45c80159e9202434
Scott LaVarnway [Mon, 1 Nov 2010 20:24:15 +0000 (16:24 -0400)]
SSSE3 version of fast quantizer
(test clip: tulip)
For good quality mode with speed=1, this gave the encoder
a small (2 - 3%) performance boost.
Change-Id: I8a1d4269465944ac0819986c2f0be4b0a2ee0b35
Scott LaVarnway [Mon, 1 Nov 2010 15:42:37 +0000 (08:42 -0700)]
Merge "Finding first label"
John Koleszar [Fri, 29 Oct 2010 15:07:31 +0000 (11:07 -0400)]
cosmetic: remove alt_ref from vpxenc usage message
Undo an automatic transform.
Change-Id: Ie730a6a31b4680b34e54b61691d67c4b3ed2f2aa
Scott LaVarnway [Wed, 27 Oct 2010 18:38:33 +0000 (14:38 -0400)]
Finding first label
Using tables for the label count and label offset.
Change-Id: Iac3d5b292c37341a881be0af282f5cac3b3e01eb
Yunqing Wang [Thu, 28 Oct 2010 20:59:03 +0000 (16:59 -0400)]
Save XMM registers in asm functions
XMM6/7 are used in these functions, and need to be saved.
Change-Id: I3dfaddaf2a69cd4bf8e8735c7064b17bac5a14e5
Yunqing Wang [Thu, 28 Oct 2010 20:46:35 +0000 (13:46 -0700)]
Merge "Fix full-search SAD function crash in Visual Studio"
John Koleszar [Thu, 28 Oct 2010 20:01:03 +0000 (16:01 -0400)]
Merge branch 'aylesbury'
Yunqing Wang [Thu, 28 Oct 2010 19:26:58 +0000 (15:26 -0400)]
Fix full-search SAD function crash in Visual Studio
Unlike GCC, Visual Studio compiler doesn't allocate SAD output
array 16-byte aligned, which causes crash in visual studio.
Change-Id: Ia755cf5a807f12929bda8db94032bb3c9d0c2362
John Koleszar [Thu, 28 Oct 2010 13:14:14 +0000 (09:14 -0400)]
CHANGELOG: correct date
Change-Id: I146a7f241efad4f0684cf8613c7fa42bd5cf42f3
John Koleszar [Wed, 27 Oct 2010 20:27:56 +0000 (16:27 -0400)]
Update CHANGELOG for v0.9.5 (Aylesbury) release
Change-Id: Ic9f05dbbe90480d5b172233c87eaf1d4e2f1b48e
Timothy B. Terriberry [Wed, 27 Oct 2010 23:04:02 +0000 (16:04 -0700)]
Eliminate more warnings.
This eliminates a large set of warnings exposed by the Mozilla build
system (Use of C++ comments in ISO C90 source, commas at the end of
enum lists, a couple incomplete initializers, and signed/unsigned
comparisons).
It also eliminates many (but not all) of the warnings expose by newer
GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
without checking the return values).
There are a few spurious warnings left on my system:
../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
uninitialized in this function
gcc seems to be unable to figure out that the value shortcut doesn't
change between the two if blocks that test it here.
../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
expression >= 0 is always true
../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
expression >= 0 is always true
This is true, so far as it goes, but it's comparing against an enum,
and the C standard does not mandate that enums be unsigned, so the
checks can't be removed.
Change-Id: Iead6cd561a2afaa3d801fd63f1d8d58953da7426
Fritz Koenig [Wed, 27 Oct 2010 19:50:16 +0000 (12:50 -0700)]
postproc: Tweaks to line drawing and blending.
Turned down the blending level to make colored blocks obscure
the video less.
Not blending the entire block to give distinction to macro
block edges.
Added configuration so that macro block blending function can
be optimized.
Change to constrain line as to when dx and dy are computed.
Now draw two lines to form an arrow.
Change-Id: I986784e6abff65ea3e0d1437dfca7d06d44ede71
Frank Galligan [Wed, 27 Oct 2010 15:28:56 +0000 (11:28 -0400)]
Output the PSNR for the entire file.
If --psnr option is enabled vpxenc will output PSNR values for the
entire file. Added a \n before final output to make sure the output
is on its own line. Overall and Avg psnr matches the values written
to opsnr.stt file.
Change-Id: Ibac5fa9baf8d5a626ea0d6ba161b484e6e8427ee
Timothy B. Terriberry [Wed, 27 Oct 2010 23:04:02 +0000 (16:04 -0700)]
Eliminate more warnings.
This eliminates a large set of warnings exposed by the Mozilla build
system (Use of C++ comments in ISO C90 source, commas at the end of
enum lists, a couple incomplete initializers, and signed/unsigned
comparisons).
It also eliminates many (but not all) of the warnings expose by newer
GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
without checking the return values).
There are a few spurious warnings left on my system:
../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
uninitialized in this function
gcc seems to be unable to figure out that the value shortcut doesn't
change between the two if blocks that test it here.
../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
expression >= 0 is always true
../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
expression >= 0 is always true
This is true, so far as it goes, but it's comparing against an enum, and the C
standard does not mandate that enums be unsigned, so the checks can't be
removed.
Change-Id: Iaf689ae3e3d0ddc5ade00faa474debe73b8d3395
Fritz Koenig [Wed, 27 Oct 2010 20:20:56 +0000 (13:20 -0700)]
Merge "postproc: Tweaks to line drawing and blending."
Fritz Koenig [Wed, 27 Oct 2010 19:50:16 +0000 (12:50 -0700)]
postproc: Tweaks to line drawing and blending.
Turned down the blending level to make colored blocks obscure
the video less.
Not blending the entire block to give distinction to macro
block edges.
Added configuration so that macro block blending function can
be optimized.
Change to constrain line as to when dx and dy are computed.
Now draw two lines to form an arrow.
Change-Id: Id3ef0fdeeab2949a6664b2c63e2a3e1a89503f6c
John Koleszar [Wed, 27 Oct 2010 19:06:23 +0000 (12:06 -0700)]
Merge "Output the PSNR for the entire file."
Frank Galligan [Wed, 27 Oct 2010 15:28:56 +0000 (11:28 -0400)]
Output the PSNR for the entire file.
If --psnr option is enabled vpxenc will output PSNR values for the
entire file. Added a \n before final output to make sure the output
is on its own line. Overall and Avg psnr matches the values written
to opsnr.stt file.
Change-Id: I869268b704fe8b0c8389d318cceb6072fea102f8
Yunqing Wang [Wed, 27 Oct 2010 12:45:24 +0000 (08:45 -0400)]
Full search SAD function optimization in SSE4.1
Use mpsadbw, and calculate 8 sad at once. Function list:
vp8_sad16x16x8_sse4
vp8_sad16x8x8_sse4
vp8_sad8x16x8_sse4
vp8_sad8x8x8_sse4
vp8_sad4x4x8_sse4
(test clip: tulip)
For best quality mode, this gave encoder a 5% performance boost.
For good quality mode with speed=1, this gave encoder a 3%
performance boost.
Change-Id: I083b5a39d39144f88dcbccbef95da6498e490134
John Koleszar [Wed, 27 Oct 2010 15:28:43 +0000 (11:28 -0400)]
Fix half-pixel variance RTCD functions
This patch fixes the system dependent entries for the half-pixel
variance functions in both the RTCD and non-RTCD cases:
- The generic C versions of these functions are now correct.
Before all three cases called the hv code.
- Wire up the ARM functions in RTCD mode
- Created stubs for x86 to call the optimized subpixel functions
with the correct parameters, rather than falling back to C
code.
Change-Id: I1d937d074d929e0eb93aacb1232cc5e0ad1c6184
John Koleszar [Wed, 27 Oct 2010 14:08:17 +0000 (10:08 -0400)]
vpxdec: don't require -o with --noblit
Specifiying the output file is meaningless when we're not writing to
it.
Change-Id: I271e1d3ae1994d79f0773747477124600f98ca58
John Koleszar [Wed, 27 Oct 2010 14:06:45 +0000 (10:06 -0400)]
makefile: remove ivf{enc,dec} on make clean
Prior clean-up removed the object files, but not the binaries
themselves.
Change-Id: Ic2332188cea88094c14457ebb8b77680a60d581b
John Koleszar [Wed, 27 Oct 2010 14:05:55 +0000 (10:05 -0400)]
vpxenc: add unique track id
MKV requires a unique(ish) TrackID element in the track info header.
Instead of the current hard-coded ID, take a hash of the video track
and use that. This value is not written in the deterministic output
mode, despite being a deterministic value itself, to give flexibility
to change the hash algorithm and not affect bisecting across the
change.
Change-Id: I807fc3ea6d1427a151c3ef703269b67e80aef860
Johann [Wed, 27 Oct 2010 16:59:28 +0000 (09:59 -0700)]
Merge "fix implicit declarations"
Johann [Wed, 27 Oct 2010 16:59:01 +0000 (09:59 -0700)]
Merge "RTCD build is bringing old errors to light"
Fritz Koenig [Tue, 26 Oct 2010 20:26:17 +0000 (13:26 -0700)]
vpxdec : Change --pp-debug-info to be a bit field.
This allows multiple post processor debug levels to be overlayed.
i.e. can show colored reference blocks and visual motion vectors.
Change-Id: Ic4a1df438445b9f5780fe73adb3126e803472e53
Fritz Koenig [Wed, 27 Oct 2010 16:04:39 +0000 (09:04 -0700)]
Merge "postproc: Add mode and refrence frame visualizers."
Johann [Wed, 27 Oct 2010 15:21:02 +0000 (11:21 -0400)]
fix implicit declarations
ARM used to explicitly remove this file from the build. With the RTCD
changes, that's no longer possible. These errors also exist for x86 w/o
RTCD, but that's not the default configuration
Change-Id: I3e10e5553ddf3278e8d3c9365ca6fb84f52f5066
Johann [Wed, 27 Oct 2010 14:47:48 +0000 (10:47 -0400)]
RTCD build is bringing old errors to light
needs to be _recon_ not _recon_recon_
Change-Id: I7a8b9ddcb4fb72c2b723c563932c9ea52ff15982
John Koleszar [Wed, 27 Oct 2010 13:50:02 +0000 (06:50 -0700)]
Merge "vpxenc: add deterministic output option"
John Koleszar [Wed, 27 Oct 2010 03:05:02 +0000 (20:05 -0700)]
Merge "Add half-pixel variance RTCD functions"
John Koleszar [Wed, 27 Oct 2010 03:02:57 +0000 (20:02 -0700)]
Merge "make vp8_recon16x16mb{,y} RTCD functions"
John Koleszar [Wed, 27 Oct 2010 03:02:37 +0000 (20:02 -0700)]
Merge "make arm hex search the generic implementation"
John Koleszar [Wed, 27 Oct 2010 03:02:18 +0000 (20:02 -0700)]
Merge "arm: move unrolled loops back to generic code"
John Koleszar [Wed, 27 Oct 2010 03:01:54 +0000 (20:01 -0700)]
Merge "arm: remove duplicate functions"
John Koleszar [Tue, 26 Oct 2010 19:34:16 +0000 (15:34 -0400)]
Add half-pixel variance RTCD functions
NEON has optimized 16x16 half-pixel variance functions, but they
were not part of the RTCD framework. Add these functions to RTCD,
so that other platforms can make use of this optimization in the
future and special-case ARM code can be removed.
A number of functions were taking two variance functions as
parameters. These functions were changed to take a single
parameter, a pointer to a struct containing all the variance
functions for that block size. This provides additional flexibility
for calling additional variance functions (the half-pixel special
case, for example) and by initializing the table for all block sizes,
we don't have to construct this function pointer table for each
macroblock.
Change-Id: I78289ff36b2715f9a7aa04d5f6fbe3d23acdc29c
Fritz Koenig [Tue, 26 Oct 2010 19:58:51 +0000 (12:58 -0700)]
postproc: Add mode and refrence frame visualizers.
Post process option to color the block for either the mode
of the macro block, or the frame that the macro block references.
Change-Id: Ie498175497f2d20e3319924d352dc4ddc16f4134
John Koleszar [Tue, 26 Oct 2010 20:22:22 +0000 (16:22 -0400)]
vpxenc: add deterministic output option
By baking the version number into the output file, a hash of the file
will vary from commit to commit, even if the output is otherwise bit
exact. Add a -D option to suppress this behavior, for use when
bisecting or other debugging.
Change-Id: I5089a8ce5719920ffaf47620fa9069b81fa15673
John Koleszar [Tue, 26 Oct 2010 20:10:59 +0000 (13:10 -0700)]
Merge "Update AUTHORS"
John Koleszar [Tue, 26 Oct 2010 20:10:22 +0000 (16:10 -0400)]
Update AUTHORS
Change-Id: I18e0a9e00731c23a2bdd1a978c8cb38f71e9029d
John Koleszar [Tue, 26 Oct 2010 15:37:23 +0000 (11:37 -0400)]
make vp8_recon16x16mb{,y} RTCD functions
ARM NEON has a platform specific version of vp8_recon16x16mb, though
it's just a stub to extract the various parameters from the
MACROBLOCKD struct and pass them to vp8_recon16x16mb_neon(). Using
that function's prototype directly will be a better long term solution,
but it's quite an invasive change.
Change-Id: I04273149e2ade34749e2d09e7edb0c396e1dd620
John Koleszar [Tue, 26 Oct 2010 14:46:31 +0000 (10:46 -0400)]
make arm hex search the generic implementation
The ARM version of vp8_hex_search() is a faster implementation
of the same algorithm. Since it doesn't use any ARM specific
code, it can be made the default implementation. This removes
a linking error.
Change-Id: I77d10f2c16b2515bff4522c350004e03b7659934
John Koleszar [Tue, 26 Oct 2010 14:05:21 +0000 (07:05 -0700)]
Merge "add missing GET_GOT/RESTORE_GOT pairs"
John Koleszar [Tue, 26 Oct 2010 13:51:35 +0000 (09:51 -0400)]
arm: move unrolled loops back to generic code
Some of the ARM functions differed from their generic counterparts
only by unrolling their loops. Since this change may be useful
on other platforms, or might even supercede the looped version
in the generic case, move it back to the generic file.
This code is left under #if ARCH_ARM for now, but it may be worth
considering a different (possibly new) conditional for these. If
it turns out that this should be runtime selectable, these
functions will have to move to the RTCD infrastructure. Don't want
to take that step at this time without more profile data.
Change-Id: I4612fdbc606fbebba4971a690fb743ad184ff15f
John Koleszar [Tue, 26 Oct 2010 13:37:44 +0000 (09:37 -0400)]
arm: remove duplicate functions
These functions were true duplicates of functions present in the
generic code. This fixes some of the link errors when building
with --enable-shared --enable-pic.
Change-Id: Idff26599d510d954e439207883607ad6b74df20c
Jim Bankoski [Tue, 26 Oct 2010 11:34:57 +0000 (07:34 -0400)]
Merge commit 'refs/changes/09/809/1' of https://review.webmproject.org/p/libvpx
John Koleszar [Tue, 26 Oct 2010 03:45:02 +0000 (23:45 -0400)]
add missing GET_GOT/RESTORE_GOT pairs
These functions made global references but did not set up the GOT,
causing compilation failures in PIC mode.
Change-Id: Iac473bf46733f87eb2e001cd736af4acf73fa51d
John Koleszar [Tue, 26 Oct 2010 02:59:23 +0000 (22:59 -0400)]
Merge WebM input/output branch
Change-Id: I83a6f18d2314e5d97759b4ae49afaa52fd8b3c44