platform/upstream/gst-plugins-good.git
5 years agomeson: Rename caca option to libcaca
Nirbheek Chauhan [Fri, 17 Aug 2018 13:41:21 +0000 (19:11 +0530)]
meson: Rename caca option to libcaca

All options must match the plugin directory name.

5 years agomeson: Add build files for osxaudio, osxvideo, waveform
Nirbheek Chauhan [Fri, 17 Aug 2018 13:26:54 +0000 (18:56 +0530)]
meson: Add build files for osxaudio, osxvideo, waveform

osxaudio is for macOS and iOS
osxvideo is for macOS
waveform is for Windows

5 years agodocs: update for changes in master
Tim-Philipp Müller [Fri, 17 Aug 2018 13:44:26 +0000 (14:44 +0100)]
docs: update for changes in master

5 years agoexamples: dist qt examples
Tim-Philipp Müller [Fri, 17 Aug 2018 10:45:47 +0000 (11:45 +0100)]
examples: dist qt examples

https://bugzilla.gnome.org/show_bug.cgi?id=796968

5 years agomeson: Add an option for tests
Nirbheek Chauhan [Thu, 16 Aug 2018 18:57:59 +0000 (00:27 +0530)]
meson: Add an option for tests

This is needed because we don't always have gstreamer-check available,
for instance inside Cerbero on iOS.

5 years agomp4 robust muxing: improve documentation and logging
Mathieu Duponchelle [Thu, 16 Aug 2018 16:55:29 +0000 (18:55 +0200)]
mp4 robust muxing: improve documentation and logging

5 years agortph26*pay: Update param set timestamp even if parameters unchanged
Jan Alexander Steffens (heftig) [Tue, 3 Jul 2018 21:11:56 +0000 (23:11 +0200)]
rtph26*pay: Update param set timestamp even if parameters unchanged

rtph264pay and rtph265pay skip updating the parameter set timestamp if
the units they see contain no new configuration. This can result in
them injecting duplicate parameters.

https://bugzilla.gnome.org/show_bug.cgi?id=796748

5 years agortspsrc: Add support for SET_PARAMETER and GET_PARAMETER using signals
Ulf Olsson [Wed, 15 Aug 2018 11:43:53 +0000 (13:43 +0200)]
rtspsrc: Add support for SET_PARAMETER and GET_PARAMETER using signals

https://bugzilla.gnome.org/show_bug.cgi?id=792131

5 years agosplitmuxsink: Don't leak old muxer/sink in async mode
Jan Schmidt [Tue, 14 Aug 2018 16:28:20 +0000 (02:28 +1000)]
splitmuxsink: Don't leak old muxer/sink in async mode

Make sure to clear the reference taken earlier in the function
when switching muxer/sink asynchronously so they don't leak

5 years agosplitmuxsink: Fix reference counting loop
Jan Schmidt [Tue, 14 Aug 2018 16:10:25 +0000 (02:10 +1000)]
splitmuxsink: Fix reference counting loop

The stream context was holding a reference to the
internal queue and pads, with pad probes that were
in turn holding references to the stream context.

This lead to a leak if the request pads weren't explicitly
released.

https://bugzilla.gnome.org/show_bug.cgi?id=796893

5 years agoaacparse: fix codec_data buffer leak
Roland Jon [Sat, 11 Aug 2018 08:45:25 +0000 (16:45 +0800)]
aacparse: fix codec_data buffer leak

https://bugzilla.gnome.org/show_bug.cgi?id=740101

5 years agoqtdemux: Handle closed captions as subtitle streams
Sebastian Dröge [Thu, 2 Aug 2018 13:12:45 +0000 (16:12 +0300)]
qtdemux: Handle closed captions as subtitle streams

5 years agov4l2src: fix first input used is always used next times
Iñigo Huguet [Thu, 2 Aug 2018 06:40:17 +0000 (08:40 +0200)]
v4l2src: fix first input used is always used next times

The input from an v4l2 device that was used the first time was
remembered for next times, and set again always the pipeline is
set to READY state. This was making that users wasn't able to
select a different input without having to create a new pipeline.

This patch makes that v4l2src element forget previous used input
when going to NULL state, so it will check again for the current
selected input when going again to READY state. Users can change
to NULL state, select a new input with a VIDIOC_S_INPUT ioctl
and change to PLAYING again.

https://bugzilla.gnome.org/show_bug.cgi?id=796908

5 years agoqtmux: The sample size we have to reserve is 256+8 bytes for the header for CDP packets
Sebastian Dröge [Thu, 2 Aug 2018 10:40:09 +0000 (13:40 +0300)]
qtmux: The sample size we have to reserve is 256+8 bytes for the header for CDP packets

5 years agoqtmux: Properly allocate 256 bytes per CDP packet in prefill mode
Sebastian Dröge [Thu, 2 Aug 2018 09:27:45 +0000 (12:27 +0300)]
qtmux: Properly allocate 256 bytes per CDP packet in prefill mode

Instead of allowing 256 but only pre-allocating 100.

5 years agoRevert "qtmux: Allow for CDP packets up to 320 bytes"
Sebastian Dröge [Thu, 2 Aug 2018 09:27:17 +0000 (12:27 +0300)]
Revert "qtmux: Allow for CDP packets up to 320 bytes"

This reverts commit 5eed1d49bdb7e7a632c7135656c482ed38a6ac2a.

255 is actually the maximum, there's a bug if more is arriving.

5 years agoqtmux: Allow for CDP packets up to 320 bytes
Sebastian Dröge [Wed, 1 Aug 2018 13:50:03 +0000 (16:50 +0300)]
qtmux: Allow for CDP packets up to 320 bytes

Apparently they can be bigger than 256 bytes sometimes.

5 years agortppayload: Fix VP8/VP9/OPUS dual encoding name handling
Nicolas Dufresne [Sat, 14 Jul 2018 02:31:04 +0000 (22:31 -0400)]
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling

All these were copy pasted and would lead to assertion when chained with
rtpmux. This commit rewrite the negotiation with downstream. This also
drop the fallback to ancient names if the pad is unlinked. This was
completly arbitrary decision that made no sense.

https://bugzilla.gnome.org/show_bug.cgi?id=796809

5 years agoqt: Ensure GL headers are included
Matthew Waters [Wed, 1 Aug 2018 02:06:23 +0000 (12:06 +1000)]
qt: Ensure GL headers are included

Otherwise there may be no valid typedef of GLsync.

...
/usr/include/gstreamer-1.0/gst/gl/gstglfuncs.h:93:24: note: in definition of macro 'GST_GL_EXT_FUNCTION'
   ret (GSTGLAPI *name) args;
                        ^~~~
/usr/include/gstreamer-1.0/gst/gl/glprototypes/sync.h:33:23: error: 'GLsync' has not been declared
                      (GLsync sync))
                       ^~~~~~
...

https://bugzilla.gnome.org/show_bug.cgi?id=796879

5 years agomeson: Fix oss4 header checks
Nirbheek Chauhan [Tue, 31 Jul 2018 21:48:58 +0000 (03:18 +0530)]
meson: Fix oss4 header checks

Otherwise, oss4 ends up getting built when force-disabled.

5 years agomeson: Fix missing variable in v4l2 build
Nirbheek Chauhan [Tue, 31 Jul 2018 19:40:49 +0000 (01:10 +0530)]
meson: Fix missing variable in v4l2 build

5 years agoqtdemux: Don't assert in prefill mode if a track has no samples at all
Sebastian Dröge [Tue, 31 Jul 2018 09:47:47 +0000 (12:47 +0300)]
qtdemux: Don't assert in prefill mode if a track has no samples at all

Just write it with a duration of 0, no samples, etc.

5 years agoqtdemux: Don't assert if a file does not have any active streams
Sebastian Dröge [Tue, 31 Jul 2018 09:33:54 +0000 (12:33 +0300)]
qtdemux: Don't assert if a file does not have any active streams

** (gst-play-1.0:9113): CRITICAL **: 12:31:54.360: qtdemux_is_streams_update: assertion 'qtdemux->active_streams != NULL' failed

5 years agoqtmux: Reserve 256 bytes for CDP packets in pre-fill mode
Sebastian Dröge [Mon, 30 Jul 2018 10:33:28 +0000 (13:33 +0300)]
qtmux: Reserve 256 bytes for CDP packets in pre-fill mode

92 is sometimes too small and compared to the wasted space for other
codecs 256 bytes is small (and should be the maximum CDP packet size)

5 years agomeson: Add feature options for all plugins
Nirbheek Chauhan [Wed, 25 Jul 2018 02:05:28 +0000 (07:35 +0530)]
meson: Add feature options for all plugins

Checks for GL, Qt5, and C++ are still automagic. FIXMEs have been
added for these so they can be fixed later.

https://bugzilla.gnome.org/show_bug.cgi?id=795107

5 years agodeinterlace: Closed caption pass-through
Vivia Nikolaidou [Wed, 25 Jul 2018 14:15:53 +0000 (17:15 +0300)]
deinterlace: Closed caption pass-through

Pass through closed caption data when deinterlacing. When two
deinterlaced frames are created for the same interlaced frame (e.g.
fields=all), the second of the two frames will have no closed caption
data.

Also fixed memory leaks related to timecode meta pass-through.

https://bugzilla.gnome.org/show_bug.cgi?id=796876

5 years agoqtmux: Implement muxing of AV1 into MP4 files
Olivier Crête [Wed, 25 Jul 2018 22:37:48 +0000 (18:37 -0400)]
qtmux: Implement muxing of AV1 into MP4 files

According to
https://aomediacodec.github.io/av1-isobmff/

5 years agomatroskamux: Put codec_data as CodecPrivate for AV1
Olivier Crête [Wed, 25 Jul 2018 21:09:06 +0000 (17:09 -0400)]
matroskamux: Put codec_data as CodecPrivate for AV1

5 years agomatroskamux: Accept muxing AV1
Olivier Crête [Wed, 25 Jul 2018 21:08:53 +0000 (17:08 -0400)]
matroskamux: Accept muxing AV1

5 years agoqtdemux: Recognize more AV1 atoms
Olivier Crête [Wed, 25 Jul 2018 20:51:38 +0000 (16:51 -0400)]
qtdemux: Recognize more AV1 atoms

5 years agomatroskademux: Extract codec_data for AV1
Olivier Crête [Wed, 25 Jul 2018 20:39:18 +0000 (16:39 -0400)]
matroskademux: Extract codec_data for AV1

According to
https://github.com/Matroska-Org/matroska-specification/blob/av1-mappin/codec/av1.md

5 years agoqtdemux: Extract AV1 codec_data and put it in the caps
Olivier Crête [Wed, 25 Jul 2018 18:31:39 +0000 (14:31 -0400)]
qtdemux: Extract AV1 codec_data and put it in the caps

Also extract the presentation-delay and put it in the caps.

5 years agoqtdemux: Add initial support for AV1 demuxing
Olivier Crête [Wed, 25 Jul 2018 14:43:11 +0000 (10:43 -0400)]
qtdemux: Add initial support for AV1 demuxing

Following the spec at
https://aomediacodec.github.io/av1-isobmff/

5 years agortspsrc: Add a small configurable teardown delay
Jan Schmidt [Thu, 26 Jul 2018 14:41:57 +0000 (00:41 +1000)]
rtspsrc: Add a small configurable teardown delay

This causes rtspsrc to send a teardown and wait on
PAUSED->READY transition, with a configurable delay.
Otherwise, typically teardown never gets sent in
playbin / uridecodebin where the transition back to NULL
happens too quickly.

The timeout is set to 100ms default.

https://bugzilla.gnome.org/show_bug.cgi?id=751994

5 years agortpgstpay: Add support for force-keyunit events
Sebastian Dröge [Thu, 26 Jul 2018 13:43:28 +0000 (16:43 +0300)]
rtpgstpay: Add support for force-keyunit events

This triggers immediate re-sending of the configuration data in-band.

https://bugzilla.gnome.org/show_bug.cgi?id=796877

5 years agortp: Use running_time instead of PTS for config-interval calculations
Sebastian Dröge [Fri, 13 Jul 2018 16:45:19 +0000 (19:45 +0300)]
rtp: Use running_time instead of PTS for config-interval calculations

PTS can start again from a different offset while the running time is
increasing. The only thing that matters here is the running time.

https://bugzilla.gnome.org/show_bug.cgi?id=796807

5 years agoexample: Build GTK and GTK GL example code
Nicolas Dufresne [Fri, 20 Jul 2018 02:48:34 +0000 (22:48 -0400)]
example: Build GTK  and GTK GL example code

5 years agortpL8pay: don't try to modify a read-only structure
Michael Olbrich [Thu, 19 Jul 2018 15:31:03 +0000 (17:31 +0200)]
rtpL8pay: don't try to modify a read-only structure

Just remove the code. It's not doing anything useful anyways. The modified
caps are the result of a caps query, so either not used afterwards of a
reference to some internal caps of another element that should not be
modified.

https://bugzilla.gnome.org/show_bug.cgi?id=796837

5 years agoqmlgl: Fix conflicting declaration of type GLsync for non-android
Iñigo Huguet [Tue, 17 Jul 2018 06:23:54 +0000 (08:23 +0200)]
qmlgl: Fix conflicting declaration of type GLsync for non-android

https://bugzilla.gnome.org/show_bug.cgi?id=796821

5 years agodeinterlace: Timecode pass-through
Vivia Nikolaidou [Mon, 16 Jul 2018 16:03:39 +0000 (19:03 +0300)]
deinterlace: Timecode pass-through

When it is trivial to pass-through a timecode, by only removing the
"interlaced" flag, do pass-through. Otherwise, double the fps_n and
adjust the "frames" field.

https://bugzilla.gnome.org/show_bug.cgi?id=796818

5 years agosplitmux: Improve handling of repeated timestamps
Jan Schmidt [Mon, 16 Jul 2018 14:03:19 +0000 (00:03 +1000)]
splitmux: Improve handling of repeated timestamps

When handling input with timestamps that repeat, sometimes
splitmuxsink would get confused and ignore a keyframe.

The logic in question is a holdover from before the cmd queue
moved the file cutting to the multiqueue output side and made
it deterministic, so it's no longer needed on the input
here.

https://bugzilla.gnome.org/show_bug.cgi?id=796773

5 years agoRevert "splitmuxsrc: Make sure events are writable"
Jan Schmidt [Mon, 16 Jul 2018 15:33:55 +0000 (01:33 +1000)]
Revert "splitmuxsrc: Make sure events are writable"

This reverts commit 3ac5430311b20f30814cdabf5724fb687748bb5b.

There's no need to make a freshly created event writable,
and the other half of this patch was already fixed
and pushed in f2f15a1

5 years agosplitmuxsrc: Make sure events are writable
Jan Schmidt [Mon, 16 Jul 2018 13:43:29 +0000 (23:43 +1000)]
splitmuxsrc: Make sure events are writable

Before setting the seqnum on events sent downstream,
make sure they are writable.

5 years agov4l2bufferpool: Validate that capture buffers were queued
Nicolas Dufresne [Fri, 13 Jul 2018 20:51:24 +0000 (16:51 -0400)]
v4l2bufferpool: Validate that capture buffers were queued

When the pool is started, we allocate and release buffer, expecting
the pool release-buffer handler to queue them. Though, as we rely
on release function, there is no direct way to detect that this
process didn't work.

To check this, validate that the number of queued buffer is the same
as the number of allocated buffers. This allow returning an error
when buffer importation was refused by the driver.

https://bugzilla.gnome.org/show_bug.cgi?id=583890

5 years agov4l2bufferpool: Only return eos for M2M devices
Nicolas Dufresne [Fri, 13 Jul 2018 20:02:02 +0000 (16:02 -0400)]
v4l2bufferpool: Only return eos for M2M devices

This will avoid sending EOS on v4l2src when a driver sends an empty
buffers. This case would be a bug in the driver, but yet the camera
should keep running.

This also removes the check for corrupted buffers, as this check is
already done later.

https://bugzilla.gnome.org/show_bug.cgi?id=794842

5 years agov4l2: Add a macro to check for M2M
Nicolas Dufresne [Fri, 13 Jul 2018 19:58:36 +0000 (15:58 -0400)]
v4l2: Add a macro to check for M2M

https://bugzilla.gnome.org/show_bug.cgi?id=794842

5 years agov4l2allocator: Fix userptr importation
Nicolas Dufresne [Fri, 13 Jul 2018 18:41:13 +0000 (14:41 -0400)]
v4l2allocator: Fix userptr importation

The length passed to the driver was always 0 instead of the size of
the memory. This would fail validation in videobuf2.

5 years agov4l2bufferpool: Remove duplicate check
Nicolas Dufresne [Thu, 12 Jul 2018 19:11:39 +0000 (15:11 -0400)]
v4l2bufferpool: Remove duplicate check

We were calling gst_v4l2_is_buffer_valid() before and inside
gst_v4l2_buffer_pool_qbuf() as we needed to access the group. The second
check failed since the writability of the buffer get inherited from the
GstMemory, which lead to pipeline failure. As we cannot avoid the extra
ref, it would be racy otherwise, just pass the group to _dbuf() so it
does not have to call gst_v4l2_is_buffer_valid() again.

https://bugzilla.gnome.org/show_bug.cgi?id=796692

5 years agortpsession: Don't start the RTCP thread until it's needed
Havard Graff [Fri, 25 Aug 2017 09:58:12 +0000 (11:58 +0200)]
rtpsession: Don't start the RTCP thread until it's needed

Always wait with starting the RTCP thread until either a RTP or RTCP
packet is sent or received. Special handling is needed to make sure the
RTCP thread is started when requesting an early RTCP packet.

We want to wait with starting the RTCP thread until it's needed in order
to not send RTCP packets for an inactive source.

https://bugzilla.gnome.org/show_bug.cgi?id=795139

5 years agov4l2src: Try to avoid TRY_FMT when camera is streaming
Nicolas Dufresne [Wed, 11 Jul 2018 16:21:44 +0000 (12:21 -0400)]
v4l2src: Try to avoid TRY_FMT when camera is streaming

Some camera firmware crash is TRY_FMT is called during streaming. As a
side effect. This try and detect that the same format as currently
running is about to be tried, and skip renegotiation.

https://bugzilla.gnome.org/show_bug.cgi?id=796789

5 years agov4l2videodec: Protect double calls to set_format()
Nicolas Dufresne [Mon, 9 Jul 2018 17:59:02 +0000 (13:59 -0400)]
v4l2videodec: Protect double calls to set_format()

In some cases, set_format() may get called twice before the output
format is set. Running an allocation query in this case is both not
needed and will cause assertion due tot he NULL caps.

5 years agoscaletempo: Mark as Audio in classification
Thibault Saunier [Mon, 9 Jul 2018 00:08:18 +0000 (20:08 -0400)]
scaletempo: Mark as Audio in classification

5 years agoqtdemux: Store and propagate SEGMENT sequence numbers
Edward Hervey [Fri, 6 Jul 2018 13:21:33 +0000 (15:21 +0200)]
qtdemux: Store and propagate SEGMENT sequence numbers

* When receiving a segment in TIME, use that seqnum
* Only reset the stored sequence number when doing HARD reset
  (and not when we get a FLUSH event from upstream)

5 years agov4l2transform: Implement stable element name
Michael Tretter [Sun, 1 Jul 2018 19:27:32 +0000 (15:27 -0400)]
v4l2transform: Implement stable element name

The first converter to be found will now gain the name v4l2convert.
Other converters will be named after the m2m dev node end point they are
attached to.

https://bugzilla.gnome.org/show_bug.cgi?id=784958

5 years agomatroskademux: Set subtitle tag title from TrackName field
Philippe Normand [Wed, 13 Jun 2018 16:39:57 +0000 (17:39 +0100)]
matroskademux: Set subtitle tag title from TrackName field

GUI applications can then use the title tag to set menu items or labels
representing the track.

https://bugzilla.gnome.org/show_bug.cgi?id=796567

5 years agov4l2videoenc: Only renegotiate with upstream
Nicolas Dufresne [Thu, 28 Jun 2018 23:08:35 +0000 (19:08 -0400)]
v4l2videoenc: Only renegotiate with upstream

When the decoder get linked further, it will receive a renegotiation
event from downstream. This case is not supported and should be ignored.

This fixes issues when this encoder is used inside an GstRtspServer
pipeline.

https://bugzilla.gnome.org/show_bug.cgi?id=796525

5 years agoqtdemux: rework segment event pushing, again
Alicia Boya García [Sat, 9 Jun 2018 21:58:01 +0000 (23:58 +0200)]
qtdemux: rework segment event pushing, again

This patch aims at fixing the recent regressions in the adaptive test
suite.

All segment pushing in push mode is now done with
gst_qtdemux_check_send_pending_segment(), which is idempotent and
handles both edit lists cases and cases where the upstream TIME segments
have to be sent directly.

Fragmented files that start with a non-zero tfdt are also taken into
account, but their handling has been vastly simplified: now they are
handled as implicit default seeks so there is no need to extend the
GstSegment formulas as was being done before.

qtdemux->segment.duration is no longer modified when
upstream_format_is_time, respecting in this way the durations provided
by dashdemux and fixing bugs in reverse playback tests where mangled
durations appeared in the emitted segments.

https://bugzilla.gnome.org/show_bug.cgi?id=752603

5 years agoqtdemux: Don't send EOS during upstream reverse playback
Alicia Boya García [Sun, 17 Jun 2018 00:01:59 +0000 (02:01 +0200)]
qtdemux: Don't send EOS during upstream reverse playback

Upstream driving elements such as dashdemux often do reverse playback by
feeding qtdemux with the fragments containing the requested playback
range in reverse order.

But the requested playback range stop may be somewhere in the
middle of a fragment. In that case, a naive pts >= segment.stop
condition may declare end of segment prematurely when demuxing this
first fragment.

This used not to happen because there were places in moov parsing where
segment.stop was overwritten to GST_CLOCK_TIME_NONE even if
upstream_format_is_time -- resulting in this case in a segment with rate
< 0 and stop == -1 and hence not triggering the EOS check, but that was
likely an accident.

This patch modifies the EOS check to take this case into account, not
sending EOS when upstream_format_is_time if rate < 0.

This fixes adaptive.dash.playback.seek_end_live.DASHIF_livestream_testpic_2s

https://bugzilla.gnome.org/show_bug.cgi?id=752603

5 years agov4l2transform: fold property set/get PROP_OUTPUT_IO_MODE case into default
Peter Seiderer [Tue, 6 Feb 2018 12:51:14 +0000 (13:51 +0100)]
v4l2transform: fold property set/get PROP_OUTPUT_IO_MODE case into default

https://bugzilla.gnome.org/show_bug.cgi?id=796714

5 years agov4l2videoenc: Don't set colorimetry on capture
Nicolas Dufresne [Fri, 22 Jun 2018 14:56:31 +0000 (14:56 +0000)]
v4l2videoenc: Don't set colorimetry on capture

The colorimetry will be set along with the raw format and those fields
will then be copied from sink to src caps by the gst encoder.

https://bugzilla.gnome.org/show_bug.cgi?id=791471

5 years agov4l2object: Really always set colorimetry
Nicolas Dufresne [Wed, 27 Jun 2018 20:57:29 +0000 (16:57 -0400)]
v4l2object: Really always set colorimetry

This fixes patch dd1c5aed656e07e3dad01f83410f3af16cfb14cf which
pretended to always set colorimetry but the patch was incomplete.
This is again best effort considering the spec says that for CAPTURE
you may only read this value.

5 years agov4l2videodec: do not call streamon while pool is flushing
Michael Tretter [Tue, 26 Jun 2018 13:04:39 +0000 (15:04 +0200)]
v4l2videodec: do not call streamon while pool is flushing

gst_v4l2_buffer_pool_flush() executes streamoff for the output, but
streamoff->streamon for the capture of the decoder.
gst_v4l2_buffer_pool_streamon() on capture assumes that is able to
resurrect the buffers from the pool, but acquiring buffers fails if the
buffer pool is still flushing.

The decoder needs to stop flushing the pools before calling
gst_v4l2_buffer_pool_flush() to restart the v4l2 device. Otherwise
starting the decoding thread might fail, because there are no buffers in
the capture pool.

This fixes a regression that was introduced in 97985a335c78
("v4l2videodec: Add dynamic resolution change support").

https://bugzilla.gnome.org/show_bug.cgi?id=796681

5 years agov4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop
Philipp Zabel [Mon, 25 Jun 2018 14:03:17 +0000 (16:03 +0200)]
v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop

The S_CROP call doesn't work on mem2mem output queues. Use the
S_SELECTION call to set the crop rectangle and only fall back to
S_CROP for ancient kernels.
This will allow v4l2videoenc to set the coded size on the output
queue via S_FMT and then set the visible size via the crop rectangle,
as required by the V4L2 codec API.

https://bugzilla.gnome.org/show_bug.cgi?id=796672

5 years agov4l2videoenc: activate capture pool after output pool
Marian Mihailescu [Wed, 27 Jun 2018 13:46:00 +0000 (13:46 +0000)]
v4l2videoenc: activate capture pool after output pool

Some drivers need output buffers set before capture buffers.
CODA cannot set output format if capture is streaming.
Exynos MFC fails on output STREAMON if capture is already streaming.
This patch delays capture activation until output is configured and
streaming

https://bugzilla.gnome.org/show_bug.cgi?id=796693

5 years agoUpdate for g_type_class_add_private() deprecation in recent GLib
Tim-Philipp Müller [Sat, 23 Jun 2018 21:44:19 +0000 (23:44 +0200)]
Update for g_type_class_add_private() deprecation in recent GLib

https://gitlab.gnome.org/GNOME/glib/merge_requests/7

5 years agosouphttpsrc: Protect input stream with lock
Edward Hervey [Wed, 20 Jun 2018 08:03:59 +0000 (10:03 +0200)]
souphttpsrc: Protect input stream with lock

This was the last remaining place where modifying/unreffing the
input stream was not protected by the lock

https://bugzilla.gnome.org/show_bug.cgi?id=796639

5 years agosplitmuxsrc: Make sure events are writable before setting their seqnum
Sebastian Dröge [Mon, 18 Jun 2018 09:13:48 +0000 (12:13 +0300)]
splitmuxsrc: Make sure events are writable before setting their seqnum

5 years agov4l2bufferpool: Drop truncated frames
Nicolas Dufresne [Mon, 28 May 2018 19:19:52 +0000 (15:19 -0400)]
v4l2bufferpool: Drop truncated frames

Drop truncated frames regardless if they have the ERROR flag or not.
Truncated frame causes video frame map failure in many elements
including cluttersink, glupload etc.

5 years agov4l2bufferpool: Try return input buffer soon
Nicolas Dufresne [Mon, 2 Apr 2018 16:59:33 +0000 (12:59 -0400)]
v4l2bufferpool: Try return input buffer soon

In this patch we use a non-blocking poll in order to return all input
buffers (buffers from v4l2-output queue). This prevent holding too long
on upstreaming buffer in importing.

https://bugzilla.gnome.org/show_bug.cgi?id=794904

5 years agoqt: also check for un-suffixed moc
Matthew Waters [Thu, 7 Jun 2018 03:56:03 +0000 (13:56 +1000)]
qt: also check for un-suffixed moc

e.g. Qt windows installer doesn't have suffixes

5 years agoqtdemux: Do not set INVALID seqnum on events
Thibault Saunier [Wed, 6 Jun 2018 15:44:33 +0000 (11:44 -0400)]
qtdemux: Do not set INVALID seqnum on events

5 years agotests: qtdemux: Add checking exposed segment event
Seungha Yang [Fri, 1 Jun 2018 13:47:10 +0000 (22:47 +0900)]
tests: qtdemux: Add checking exposed segment event

https://bugzilla.gnome.org/show_bug.cgi?id=796480

5 years agoqtdemux: Forward upstream time-format segment without mapping
Seungha Yang [Fri, 1 Jun 2018 12:08:10 +0000 (21:08 +0900)]
qtdemux: Forward upstream time-format segment without mapping

Sample table based segment event (genereted by qtdemux) could break
presentation timeline. For example, qtdemux should not modify upstream
time format segment (e.g., adaptivedemux use case)

https://bugzilla.gnome.org/show_bug.cgi?id=796480

5 years agortspsrc: Seek handling is always done with a valid event
Edward Hervey [Thu, 19 Apr 2018 06:14:47 +0000 (08:14 +0200)]
rtspsrc: Seek handling is always done with a valid event

Remove the checks

5 years agowavparse: Don't set invalid seqnum on events
Edward Hervey [Wed, 6 Jun 2018 05:46:54 +0000 (07:46 +0200)]
wavparse: Don't set invalid seqnum on events

Some codepath will call gst_wavparse_perform_seek without an event
and therefore without a valid seqnum

6 years agoqtdemux: Clarify field name about stream-encryption-system
Thibault Saunier [Fri, 25 May 2018 10:28:04 +0000 (12:28 +0200)]
qtdemux: Clarify field name about stream-encryption-system

This field is actually only informatory and the user can potentially
choose something else. EME tests in WebKit testsuite actually doesn't
take it into and force another encryption system to be used, and expects
to be given the occasion to do so.

This basically also reverts 3e063703b3a51b8aaa7f75f36c4660c583a60e93.

6 years agoqtdemux: mark segment as sent after pushing when moov is received
Thiago Santos [Mon, 28 May 2018 18:01:42 +0000 (11:01 -0700)]
qtdemux: mark segment as sent after pushing when moov is received

Otherwise we would try to send it a second time if the same moov is
received or in any other situation that might trigger segment sending.

https://bugzilla.gnome.org/show_bug.cgi?id=752603

6 years agotests: qtdemux: Avoid using data beyond array and improve error msg
Thiago Santos [Mon, 28 May 2018 17:59:14 +0000 (10:59 -0700)]
tests: qtdemux: Avoid using data beyond array and improve error msg

Makes it easier to debug the failures as well as prevents problems
reading out of bounds data.

6 years agov4l2object: Don't open the device in get property
Nicolas Dufresne [Thu, 17 May 2018 00:16:44 +0000 (20:16 -0400)]
v4l2object: Don't open the device in get property

This is both racy and inefficient. This function is still missing some
locking which will be address in later patch.

https://bugzilla.gnome.org/show_bug.cgi?id=796185

6 years agotests: rtpstorage: fix potential crashes / test failures on 32-bit
Tim-Philipp Müller [Sun, 27 May 2018 19:29:47 +0000 (20:29 +0100)]
tests: rtpstorage: fix potential crashes / test failures on 32-bit

Pass 64 bits to g_object_set() for 64-bit integer properties like
rtpstorage's "size-time" property.

https://bugzilla.gnome.org/show_bug.cgi?id=796429

6 years agoqtdemux: do not update segment.stop is it is not a valid time
Thiago Santos [Mon, 14 May 2018 04:59:49 +0000 (21:59 -0700)]
qtdemux: do not update segment.stop is it is not a valid time

Otherwise it overflows and starts having a meaningful and wrong value.

https://bugzilla.gnome.org/show_bug.cgi?id=752603

6 years agoqtdemux: offset edts segments by the min timestamp of the stream
Thiago Santos [Tue, 26 Apr 2016 19:54:30 +0000 (16:54 -0300)]
qtdemux: offset edts segments by the min timestamp of the stream

Otherwise if the stream is starting at timestamp=X it would wait
'X' to start playing.

https://bugzilla.gnome.org/show_bug.cgi?id=752603

6 years agoqtdemux: rework segment event pushing
Thiago Santos [Tue, 26 Apr 2016 17:34:16 +0000 (14:34 -0300)]
qtdemux: rework segment event pushing

Instead of always keeping a safe segment (start=0) event from the beginning,
delay the creation of this event to when we really know the timestamp of the
first sample. This is important to properly start fragmented streams that
we might join in the middle or to play isolated fragment files that might
have an advanced tfdt.

https://bugzilla.gnome.org/show_bug.cgi?id=752603

6 years agoqtdemux: Do not unref a NULL stream_tags
Thibault Saunier [Fri, 25 May 2018 08:49:21 +0000 (10:49 +0200)]
qtdemux: Do not unref a NULL stream_tags

stream->stream_tags is reset to NULL once we expose the stream and
these have been consumed, we need to check that when cleaning up
the stream.

6 years agoqtdemux: Do not run the preferred decryptor context query if no decryptor avalaible
Thibault Saunier [Fri, 25 May 2018 08:17:29 +0000 (10:17 +0200)]
qtdemux: Do not run the preferred decryptor context query if no decryptor avalaible

Ultimately this avoids a segfault as the code expect a non NULL array
here.

6 years agoqtdemux: Allow edit lists on fragmented files on push mode
Alicia Boya García [Fri, 30 Mar 2018 15:03:13 +0000 (17:03 +0200)]
qtdemux: Allow edit lists on fragmented files on push mode

Fragmented files often use elst.duration=0 which before
ee78825eaef2c5fffac7d6c5526fe18cec6b3eef was wrongly interpreted as
having no frames.

Since that issue has now been fixed, there is no reason to disable edit
lists in fragmented files. This commit enables them, therefore producing
correct stream time for files containing edit lists.

https://bugzilla.gnome.org/show_bug.cgi?id=793058

6 years agoqtdemux: fix computation of first_duration for fragmented files in push mode
Alicia Boya García [Thu, 24 May 2018 10:58:00 +0000 (12:58 +0200)]
qtdemux: fix computation of first_duration for fragmented files in push mode

Since ca068865c391e87932b1268d0c675be233dd2ffe the duration of the first
frame is not used for estimating the frame rate.

For this purpose, stream->first_duration was initialized with the
duration of the first frame. In fragmented files, this was previously
done by peeking the first moof, but that can only be done in pull mode.

Fortunately, we don't really need to do that, at least with the current
design: When we are estimating the frame rate we already have the
sample table, regardless of the scheduling mode and whether the file is
fragmented or not, so we can obtain first_duration there much more
reliably.

This fixes frame rate estimation for fragmented files in push mode.

https://bugzilla.gnome.org/show_bug.cgi?id=796384

6 years agosplitmuxsink: Added new async-finalize mode
Vivia Nikolaidou [Tue, 13 Jun 2017 14:42:55 +0000 (17:42 +0300)]
splitmuxsink: Added new async-finalize mode

This mode is useful for muxers that can take a long time to finalize a
file. Instead of blocking the whole upstream pipeline while the muxer is
doing its stuff, we can unlink it and spawn a new muxer+sink combination
to continue running normally.

This requires us to receive the muxer and sink (if needed) as factories,
optionally accompanied by their respective properties structures. Also
added the muxer-added and sink-added signals, in case custom code has to
be called for them.

https://bugzilla.gnome.org/show_bug.cgi?id=783754

6 years agoqtdemux: Don't send gaps bigger than 1 second (now in push mode too)
Alicia Boya García [Wed, 23 May 2018 17:00:48 +0000 (19:00 +0200)]
qtdemux: Don't send gaps bigger than 1 second (now in push mode too)

This applies the same workaround to gaps that is being used in pull
mode.

https://bugzilla.gnome.org/show_bug.cgi?id=778426

6 years agoqtdemux: Properly handle edit list in push mode
Seungha Yang [Wed, 23 May 2018 11:08:56 +0000 (20:08 +0900)]
qtdemux: Properly handle edit list in push mode

If there are empty segments in edit list, demux should
adjust "accumulated_base" to apply it into running time.

https://bugzilla.gnome.org/show_bug.cgi?id=778426

6 years agomatroska-mux: write colorimetry
Mathieu Duponchelle [Tue, 22 May 2018 20:14:03 +0000 (22:14 +0200)]
matroska-mux: write colorimetry

This is a straightforward translation of 5dd39d8, can be trivially
checked by running:

gst-launch-1.0 -v videotestsrc ! video/x-raw, colorimetry=2:4:7:1 ! \
matroskamux ! matroskademux ! fakesink

and verifying that the colorimetry is correctly preserved.

https://bugzilla.gnome.org/show_bug.cgi?id=796344

6 years agoqtdemux: fix buggy duration in edits with duration=0 in fragmented files without...
Alicia Boya García [Sat, 31 Mar 2018 15:19:03 +0000 (17:19 +0200)]
qtdemux: fix buggy duration in edits with duration=0 in fragmented files without a mehd

https://bugzilla.gnome.org/show_bug.cgi?id=794858

6 years agodocs: fix typos
Tim-Philipp Müller [Wed, 23 May 2018 12:14:27 +0000 (13:14 +0100)]
docs: fix typos

6 years agoqtdemux: Clarify variable name
Seungha Yang [Sat, 31 Mar 2018 09:42:47 +0000 (18:42 +0900)]
qtdemux: Clarify variable name

As defined by spec, use "empty edit". It's more straightforward.

https://bugzilla.gnome.org/show_bug.cgi?id=778426

6 years agoqtdemux: add context for a preferred protection
Xabier Rodriguez Calvar [Wed, 21 Jun 2017 15:59:21 +0000 (17:59 +0200)]
qtdemux: add context for a preferred protection

qtdemux selected the first system corresponding to a working GStreamer
decryptor. With this change, before selecting that decryptor, qtdemux
will check if it has context (a preferred decryptor id) and if not, it
will request it.

The request includes track-id, available key system ids for the
available decryptors and even the events so that the init data is
accessible.

[eocanha@igalia.com: select the preferred protection system even if not available]

Test "4. ClearKeyVideo" in YouTube leanback EME conformance tests 2016 for
H.264[1] uses a media file[2] with cenc encryption which embeds 'pssh' boxes
with the init data for the Playready and Widevine encryption systems, but not
for the ClearKey encryption system (as defined by the EMEv0.1b spec[3] and with
the encryption system id defined in [4]).

Instead, the ClearKey encryption system is manually selected by the web page
code (even if not originally detected by qtdemux) and the proper decryption key
is dispatched to the decryptor, which can then decrypt the video successfully.

[1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html?test_type=encryptedmedia-test&webm=false
[2] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/media/car_cenc-20120827-86.mp4
[3] https://dvcs.w3.org/hg/html-media/raw-file/eme-v0.1b/encrypted-media/encrypted-media.html#simple-decryption-clear-key
[4] https://www.w3.org/Bugs/Public/show_bug.cgi?id=24027#c2

https://bugzilla.gnome.org/show_bug.cgi?id=770107

6 years agoqtdemux: also push buffers without encryption info instead of dropping them
Enrique Ocaña González [Sat, 20 May 2017 16:55:40 +0000 (16:55 +0000)]
qtdemux: also push buffers without encryption info instead of dropping them

Test "17. PlayReadyH264Video" in YouTube leanback EME conformance tests 2016
for H.264[1] uses a media file[2] with cenc encryption whose first two 'moof'
boxes have no encryption information (no 'saiz' and 'saio' boxes).

Those boxes are actually not encrypted and the current qtdemux implementation
was just dropping them, breaking the test use case.

This patch detects those kind of situations and just lets the unencrypted
buffers pass. Of course, this needs some collaboration by the decryptors,
which should also do the same and not to try to decrypt those clear buffers.

[1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html?test_type=encryptedmedia-test&webm=false
[2] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/media/oops_cenc-20121114-142.mp4

https://bugzilla.gnome.org/show_bug.cgi?id=770107

6 years agomeson: use cdata.set_quoted() in more places
Tim-Philipp Müller [Mon, 21 May 2018 10:49:08 +0000 (11:49 +0100)]
meson: use cdata.set_quoted() in more places

6 years agomeson: add 'nls' option to disable translations
Tim-Philipp Müller [Mon, 21 May 2018 10:46:59 +0000 (11:46 +0100)]
meson: add 'nls' option to disable translations

And enable by default. Was implicitly disabled because
ENABLE_NLS was not defined.

6 years agoid3v2mux: ensure valid sentinal for gst_structure_get()
Andre McCurdy [Tue, 9 Feb 2016 22:00:00 +0000 (14:00 -0800)]
id3v2mux: ensure valid sentinal for gst_structure_get()

gst_structure_get() is declared with G_GNUC_NULL_TERMINATED, ie
__attribute__((__sentinel__)), which means gcc will generate a
warning if the last parameter passed to the function is not NULL
(where a valid NULL in this context is defined as zero with any
pointer type).

The C code callers to gst_structure_get() within gst-plugins-good
use the C NULL definition (ie ((void*)0)), which is a valid sentinel.

However gstid3v2mux.cc uses the C++ NULL definition (ie 0L), which
is not a valid sentinel without an explicit cast to a pointer type.

Upstream-Status: Pending

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
6 years agoraw1394: avoid including <sys/poll.h> directly
Andre McCurdy [Thu, 4 Feb 2016 02:12:38 +0000 (18:12 -0800)]
raw1394: avoid including <sys/poll.h> directly

Note from Edward Hervey: Patch from git.yoctoproject.org

musl libc generates warnings if <sys/poll.h> is included directly.

Upstream-Status: Pending

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>