Pat Gavlin [Mon, 9 Jan 2017 19:36:28 +0000 (11:36 -0800)]
Format code and improve a function name.
Commit migrated from https://github.com/dotnet/coreclr/commit/
27361397bfe65aed784c2bd7031f0f28d27616da
Pat Gavlin [Mon, 9 Jan 2017 19:20:23 +0000 (11:20 -0800)]
Fix some comments.
Commit migrated from https://github.com/dotnet/coreclr/commit/
53ef803c69af6b04cbd88e0be4513758b30263b1
Pat Gavlin [Mon, 9 Jan 2017 18:41:16 +0000 (10:41 -0800)]
Encapsulate live var analysis in its own class.
This change moves the implementation of live variable analysis from a
single function into a class in which the per-block portion of the
algorithm is contained in its own function. There is no functional
change.
Commit migrated from https://github.com/dotnet/coreclr/commit/
474e27a5ac4ee651e2456a7503d4a8cf2ce7b00c
Pat Gavlin [Fri, 6 Jan 2017 19:11:19 +0000 (11:11 -0800)]
Remove the `asgdLclVar` analysis from liveness.
This analysis is not necessary for correctness and does not appear to
have any impact on the generated code: in particualr, internal assembly
diffs show no changes with this analysis disabled.
For example, consider the following statement:
`(asg (lclVar V0) (add (lclVar V0) (icon 4)))`
Under the `asgdLclVar` analysis, the visit of the lclVar node that is an
operand to the add would mark the lclVar node that is the target of the
assignment with `GTF_VAR_USEDEF` and exit without adding V0 to the
current set of used lclVars. Instead, the visit of the lclVar node that
is the target of the assignment would add V0 to both the set of used
lclVar nodes and the set of defined lclVar nodes.
With this analysis disabled, the visit of the lclVar node that is an
operand to the add will add V0 to the set of used lclVar nodes and the
visit of the lclVar node that is the target of the assignment will add
V0 to the set of defined lclVar nodes. In both cases, the result is the
same.
Commit migrated from https://github.com/dotnet/coreclr/commit/
583733b399edb423719e4754a3184913495e7575
Jürgen Hötzel [Fri, 6 Jan 2017 00:15:49 +0000 (01:15 +0100)]
Use POSIX "command" instead of non-standard "which" (dotnet/coreclr#8823)
GNU which might not be installed on a minimal GNU/Linux installation.
Refs dotnet/coreclr#6994 and dotnet/coreclr#7025.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f8557fb17c58a093bf54bd17e965b9181bba772
Pat Gavlin [Thu, 5 Jan 2017 23:57:58 +0000 (15:57 -0800)]
Merge pull request dotnet/coreclr#8820 from pgavlin/RemoveVarTmp
Remove `BasicBlock::bbVarTmp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ba20a12ef18140d0ee1867fe5b0c0106bdbaf57
Gaurav Khanna [Thu, 5 Jan 2017 21:43:19 +0000 (13:43 -0800)]
Merge pull request dotnet/coreclr#8781 from hqueue/arm/rootfs/tizen
Add Tizen rootfs for armel
Commit migrated from https://github.com/dotnet/coreclr/commit/
871448a28a6cf2a5ef49a40b9c929d854b380794
Gaurav Khanna [Thu, 5 Jan 2017 18:59:50 +0000 (10:59 -0800)]
Merge pull request dotnet/coreclr#8818 from SedarG/sedarg
Revert "Adding Microsoft.NETCore.Native package (dotnet/coreclr#8791)"
Commit migrated from https://github.com/dotnet/coreclr/commit/
323eac861670dbdd931bf16f4d370b1a198c5af3
Pat Gavlin [Thu, 5 Jan 2017 18:11:39 +0000 (10:11 -0800)]
Remove `BasicBlock::bbVarTmp`.
This field was never used.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4baf892c0c7bd7cfcf7e6cbaca02e9ad159bb85e
Gaurav Khanna [Thu, 5 Jan 2017 17:55:59 +0000 (09:55 -0800)]
Merge pull request dotnet/coreclr#8813 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24904-03, beta-24905-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ab14b02e0f96eb133ad82cdc3b68450dacac19d
Sedar Gokbulut [Thu, 5 Jan 2017 16:53:53 +0000 (08:53 -0800)]
Revert "Adding Microsoft.NETCore.Native package (dotnet/coreclr#8791)"
This reverts commit dotnet/coreclr@
eea7b4691c0a489435814e48a257a9d047475006.
Commit migrated from https://github.com/dotnet/coreclr/commit/
dcf5aaa0c7579b9d427a6f29ec62f410ce4c729c
Dan Moseley [Thu, 5 Jan 2017 16:52:34 +0000 (08:52 -0800)]
fix link
Fix https://github.com/dotnet/coreclr/issues/8816
Commit migrated from https://github.com/dotnet/coreclr/commit/
25dc0b6b7d9ee40a9d64a570ada8821d2e8f0f76
dotnet-bot [Thu, 5 Jan 2017 15:45:36 +0000 (15:45 +0000)]
Update CoreClr, CoreFx to beta-24904-03, beta-24905-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1d4b63a52141a1b73bd83344feb5f353012547d
Hyeongseok Oh [Thu, 5 Jan 2017 12:32:44 +0000 (21:32 +0900)]
Use x86 crossbuild for cross-architecture component on x64-linux (dotnet/coreclr#8722)
* Use x86 crossbuild for cross-architecture component on x64-linux
Fix build.sh and build system generator to use x86 cross-build system on x64-linux
- x86-host/ARM32-target cross-architecture component build on x64 linux
- use x86 root file system and cross buildtool
* Modify build.sh
- define new function: build_cross_arch_component
- fix typo
* Additional fix: build.sh
add usage description
- environment variable: CAC_ROOTFS_DIR
- argument: crosscomponent
Commit migrated from https://github.com/dotnet/coreclr/commit/
f66ba4a14a5e729778d66ea6cc1409f0e8b4a5b0
Hyung-Kyu Choi [Thu, 5 Jan 2017 06:17:18 +0000 (15:17 +0900)]
Update cmake file for armel
Enable build using Tizen rootfs
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
d593e48ea8b1dba8c6f8c81ac66eb5c5f88c1300
pius.lee [Tue, 3 Jan 2017 10:19:11 +0000 (19:19 +0900)]
Add a script to fetch tizen packages
Fetch packages for build RootFS by XML information in download.tizen.org
Signed-off-by: pius.lee <pius.lee@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
b92ae42b6664271d335057c9f8519fb091211ae1
Hyung-Kyu Choi [Thu, 5 Jan 2017 05:48:10 +0000 (14:48 +0900)]
Add Tizen rootfs for armel
- This rootfs can be used for CoreCLR, CoreFX and Core-Setup.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
55a1b2f1ad9c1389712f064bb6cf58e1df71949e
Hyung-Kyu Choi [Thu, 5 Jan 2017 09:29:49 +0000 (18:29 +0900)]
Use armel instead of arm-softfp (dotnet/coreclr#8771)
* Use armel instead of arm-softfp for CoreCLR
- Update scripts for rootfs, build, build system generation and CI
- Update managed build project
- Rename rootfs directory
- Fix bug in rootfs script related to lldb package
lldb package only usable lldb-3.5-dev for jessie/arm-softfp
We cannot get lldb-3.6-dev or lldb-3.8-dev from jessie/arm-softfp repository
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Singed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Update ARM32 CI script
We don't need a patch anymore, because we fixed cmake file.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
165fa5cebf0b937f74855584ca5b658e7e83c41b
Jan Vorlicek [Thu, 5 Jan 2017 01:37:25 +0000 (02:37 +0100)]
Fix unsigned_abs function on Unix (dotnet/coreclr#8805)
The unsigned_abs function in jit.h is implemented using labs function.
However labs has 32 bit argument / result, while the unsigned_abs expects
it to be 64 bit.
The correct function to use for FEATURE_PAL is llabs. But since we now have
abs overload for __int64 in pal.h, we can just remove the #ifdef for FEATURE_PAL
and use the same implementation for both Unix and Windows.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2daeccabf5c64c67a080928fc48a4d18d0464f9
Pat Gavlin [Thu, 5 Jan 2017 00:34:55 +0000 (16:34 -0800)]
Merge pull request dotnet/coreclr#8809 from pgavlin/FixJitStressFailure
Add a missing ref count bump in DecomposeLclFld.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d200352c3567f77020e3eb36706fa9484bd30bf6
Sivarv [Wed, 4 Jan 2017 23:36:58 +0000 (15:36 -0800)]
Merge pull request dotnet/coreclr#8711 from sivarv/simdAbsOpt
Accelerate Abs intrinsic even in cases where there is no direct instruction support available.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9202ba5b7bbd92e53c560882887aaffba4ae5a15
Pat Gavlin [Wed, 4 Jan 2017 23:30:13 +0000 (15:30 -0800)]
Fix VSO 359733. (dotnet/coreclr#8803)
* Fix VSO 359733.
This bug was an assertion when extracting side effects that failed when
checking that the presence or absence of value numbers on the head of
the side effect list matched the presence or absence of value numbers on
the node being added to the list. This condition does not hold when
remorphing, as remorphing may create nodes without value numbers. In
this case, the new comma node will have no value numbers for
conservative correctness. The failing assertion was weakened to allow
the presence/absence of value numbers on the head of the list and the
node being added to differ during remorphing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4af7d40e0eeaa961f55ea8abff2eb03fc5dcdd56
Michelle McDaniel [Wed, 4 Jan 2017 22:36:45 +0000 (14:36 -0800)]
Merge pull request dotnet/coreclr#8804 from adiaaida/devdiv_362706
Fix DevDiv 362706
Commit migrated from https://github.com/dotnet/coreclr/commit/
c4972463338d49481373219fa35b13c872a880ed
Pat Gavlin [Wed, 4 Jan 2017 22:36:17 +0000 (14:36 -0800)]
Add a missing ref count bump in DecomposeLclFld.
DecomposeLclFld transforms a single lclFld node into two lclFld nodes
that reference the same lclVar, but was missing a corresponding ref
count bump. This was causing a failure in JIT/Methodical/fp/exgen/10w5d_cs_do
under JITStress=1 and JITStress=2.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1a7cef4ecec8f9fadc564a4125b478e3e8ccb9c
Jan Vorlicek [Wed, 4 Jan 2017 21:05:43 +0000 (22:05 +0100)]
Fix NULL string printing in printf (dotnet/coreclr#8800)
The functions implementing various printf flavors in PAL were not handling
correctly the case when a string pointer passed to them for %S and %s formats
was NULL. Instead of printing `(null)`, they were crashing.
This change fixes the problem and also adds PAL tests to verify it is working
properly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
edc1320180a3d68a16855da8da82f01871bf3a1d
Michelle McDaniel [Wed, 4 Jan 2017 17:42:19 +0000 (09:42 -0800)]
Fix DevDiv 362706
The issue here was that when we morphed a mod into a sub mul div, we would
ultimately decrease the ref counts to the numerator of the original mod
without performing a corresponding increase. The fix is to increase the
ref count when morphing into the sub mul div.
Commit migrated from https://github.com/dotnet/coreclr/commit/
86b09f9cfbbebfe4c1b37900e58477bcfaedace1
sivarv [Thu, 22 Dec 2016 22:59:32 +0000 (14:59 -0800)]
Accelerate Abs intrinsic even in cases where there is no direct instruction support available.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6421a60dd64415f8689fbb14a16c8bbe19f7fa09
Michelle McDaniel [Wed, 4 Jan 2017 19:32:11 +0000 (11:32 -0800)]
Merge pull request dotnet/coreclr#8802 from adiaaida/fixCorefxGroovy
Do not supply fx_root to run-corefx-tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
06c78a5f7b27efeb7d462b1ba1c139f320d3fb80
adiaaida [Wed, 4 Jan 2017 18:30:28 +0000 (10:30 -0800)]
Do not validate fx_root in run-corefx-tests
Users are able to supply an fx_root that does not yet exist and
run-corefx-tests.py will create that directory. However,
run-corefx-tests.py checks to confirm that fx_root already exists when
we validate. This causes the script to exit with an error when fx_root
does not yet exist. This change modifies run-corefx-tests.py so that we
do not validate the fx_root path.
This change also fixes the path to WORKSPACE for ubuntu corefx testing
in netci.groovy.
Commit migrated from https://github.com/dotnet/coreclr/commit/
02731360a9d24f3083d3ad05b271f9edea4b48d0
Sedar Gokbulut [Wed, 4 Jan 2017 19:21:20 +0000 (11:21 -0800)]
Adding Microsoft.NETCore.Native package (dotnet/coreclr#8791)
* "Adding Microsoft.NETCore.Native package"
* Adding generic linux configuration to Microsoft.NETCore.Native package
* Fixing the OSX pkgproj of Microsoft.NETCore.Native to include S.Globalization.Native.dylib and not .so
Commit migrated from https://github.com/dotnet/coreclr/commit/
eea7b4691c0a489435814e48a257a9d047475006
Jan Kotas [Wed, 4 Jan 2017 17:18:14 +0000 (09:18 -0800)]
Merge pull request dotnet/coreclr#8719 from jkotas/native-buffer
Use ArrayPool for PathHelper
Commit migrated from https://github.com/dotnet/coreclr/commit/
4b93ba94828c879356ef9dd3246397cee3431e2e
Stephen Toub [Wed, 4 Jan 2017 15:48:29 +0000 (10:48 -0500)]
Merge pull request dotnet/coreclr#8796 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24904-02, beta-24904-01, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
79e470cef63003fc84e4b26c4d3d3f127612eb1f
Jan Kotas [Wed, 4 Jan 2017 14:31:17 +0000 (06:31 -0800)]
Path normalization performance improvements
- Use const variant of path separators in the Path implementation
- Add fast paths for common cases to hot parsing routines
- Avoid redundant caches for MaxPath on Unix
Commit migrated from https://github.com/dotnet/coreclr/commit/
d682dd337ccdc71e29a762d9bda8bf2cca93c122
Jan Kotas [Mon, 26 Dec 2016 08:08:01 +0000 (00:08 -0800)]
Delete unused file
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd7ab891d2d0c961a32f0779125ce9190b6ce9e3
Jan Kotas [Wed, 21 Dec 2016 23:46:53 +0000 (15:46 -0800)]
Use ArrayPool for PathHelper
Replace special unmanaged memory pool used by PathHelper by shared ArrayPool. Custom memory pools are not good for global system performance, and the particular implementation of the unmanaged memory pool was also problematic for CoreRT port because of its dependencies.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ad209e8aa6e0f7c64fa7d8da238d4074ef7bc3a
SaeHie Park [Wed, 4 Jan 2017 14:06:24 +0000 (23:06 +0900)]
[x86/Linux] Implement ResolveWorkerChainLookupAsmStub (dotnet/coreclr#8780)
Replace ResolveWorkerChainLookupAsmStub with actual implementation
- code is copied from Win32 version
- replaced some parts to compile in linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb01a98245ea734000f287799cdff4657e552feb
SaeHie Park [Wed, 4 Jan 2017 10:10:13 +0000 (19:10 +0900)]
[x86/Linux] Implement SinglecastDelegateInvokeStub (dotnet/coreclr#8799)
Implement SinglecastDelegateInvokeStub for x86/Linux
- Code copied from that of AMD64 and some translation
- Fixes LargeObjectAlloc.exe unit test case and maybe others
Commit migrated from https://github.com/dotnet/coreclr/commit/
4519be41745ea4c46d29078dc7e2524966b75436
dotnet-bot [Wed, 4 Jan 2017 09:44:37 +0000 (09:44 +0000)]
Update CoreClr, CoreFx to beta-24904-02, beta-24904-01, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
473be4f1fd28e1328f083352458c16a8b1648d0a
Julien Couvreur [Wed, 4 Jan 2017 02:09:17 +0000 (18:09 -0800)]
Remove un-necessary ITuple constraint (dotnet/coreclr#8793)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3bb7653f9f2fa470c577586230687c01a3a729f8
Stephen A. Imhoff [Wed, 4 Jan 2017 00:43:59 +0000 (16:43 -0800)]
Redo some argument name corrections (dotnet/coreclr#8727)
* TraceLogging
* SignatureHelper
* RuntimeReflectionExtensions
* RuntimeHandles - Public
* SemaphoreSlim - Public
* Directory - Public
* ModuleBuilder - Public
* EncoderFallback - Public - Test Failures
* StringBuilder - Public - Test Failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
0bf7fe6df4abbdedc6b1fb80add919fa7ab9cb1a
Joseph Tremoulet [Tue, 3 Jan 2017 23:05:01 +0000 (18:05 -0500)]
Merge pull request dotnet/coreclr#8757 from JosephTremoulet/FixHeapLiveIn
Fix heap live-in calculation
Commit migrated from https://github.com/dotnet/coreclr/commit/
e082e210c705168be25096ab384b13ee20a14095
Pat Gavlin [Tue, 3 Jan 2017 22:36:31 +0000 (14:36 -0800)]
Merge pull request dotnet/coreclr#8789 from pgavlin/VSO359737
Fix DevDiv bug 359737.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8fb7726f6b8535a014a3080e8e3ac2530626212f
Pat Gavlin [Tue, 3 Jan 2017 22:34:54 +0000 (14:34 -0800)]
Add a comment per code review.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ac913bc473b6b0ce2665afeefc5533b3d08cff74
John Chen [Tue, 3 Jan 2017 22:18:50 +0000 (14:18 -0800)]
Merge pull request dotnet/coreclr#8788 from JohnChen0/apiset
Fix a typo that caused AVX2 flag to be unset
Commit migrated from https://github.com/dotnet/coreclr/commit/
e72eafb76d1b94b90e12a0e3d03e5e3fe06e3d1f
Eric Mellino [Tue, 3 Jan 2017 22:07:59 +0000 (14:07 -0800)]
Merge pull request dotnet/coreclr#8751 from mellinoe/corelibraries-unix
Add CORE_LIBRARIES to the TPA list if it's set in unixcoreruncommon
Commit migrated from https://github.com/dotnet/coreclr/commit/
1dc8c8594693e66a24f21676b04b4c37d298f7ca
Justin Van Patten [Tue, 3 Jan 2017 22:02:38 +0000 (14:02 -0800)]
Remove unnecessary `canEndWithoutSeparator` parameter (dotnet/coreclr#8786)
Commit migrated from https://github.com/dotnet/coreclr/commit/
17ace3a1ae855303ee32799a45cbd898195eb9d3
Justin Van Patten [Tue, 3 Jan 2017 21:51:26 +0000 (13:51 -0800)]
TimeZoneInfo.StringSerializer can be a struct (dotnet/coreclr#8784)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ad20fb5ed153c01082611c6afc97c362c34a82e
Andy Ayers [Tue, 3 Jan 2017 21:30:09 +0000 (13:30 -0800)]
Adjust ref counts during EH normalization (dotnet/coreclr#8713)
EH normalization can leave incorrect ref counts. This caused asserts in a few
cases with the forthcoming finally cloning, as these EH related blocks were
exposed to flow optimizations.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7be8f56ce218029bcd4d68f013aacd4070994b22
Pat Gavlin [Tue, 3 Jan 2017 20:24:56 +0000 (12:24 -0800)]
Fix DevDiv bug 359737.
This bug was an assertion during CSE that ensures that all CSE
candidates have value numbers. This assertion tripped because an earlier
CSE in the same tree as the faulty candidate re-morphed modulus by a
constant into a divide and subtract; the resulting tree was left without
value numbers. This change disables the problematic transform when
remorphing as part of CSE.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7b32c8db705fc861ab3c52c47aecc6b647b7d5e8
John Chen (CLR) [Tue, 3 Jan 2017 20:06:03 +0000 (12:06 -0800)]
Fix a typo that caused AVX2 flag to be unset
Fix issue dotnet/coreclr#8736, a regression caused by PR dotnet/coreclr#8624. A typo in
the code causes the AVX2 flag to be always unset.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a5c706416d46c71c7f1cede625a339e85ca52e70
Justin Van Patten [Tue, 3 Jan 2017 20:00:46 +0000 (12:00 -0800)]
TimeZoneInfo.StringSerializer: Avoid some unnecessary allocations (dotnet/coreclr#8783)
Instead of using multiple calls to `string.Replace` to escape reserved
chars before appending to a `StringBuilder`, do the replacing while
appending the chars directly to the `StringBuilder`.
Also, append numbers/dates directly instead of running it through the
escape method, as these Invariant-formatted strings will not contain any
chars that need to be escaped.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1d15b16516ebc580d88d179e8cdf800bbeac1b4b
Eric Mellino [Tue, 3 Jan 2017 19:22:13 +0000 (11:22 -0800)]
Only add CORE_LIBRARIES to TPA list if it is different from clrFilesAbsolutePath
This avoids placing duplicate entries on the TPA list.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f90e95606c8c335327c0729c16a90fbf5dddcfd1
Gaurav Khanna [Tue, 3 Jan 2017 19:15:03 +0000 (11:15 -0800)]
Merge pull request dotnet/coreclr#8785 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24903-03, beta-24903-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
cbd69efb748e76485dfe0b783387ed34de82be9e
dotnet-bot [Tue, 3 Jan 2017 17:42:21 +0000 (17:42 +0000)]
Update CoreClr, CoreFx to beta-24903-03, beta-24903-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
4046bce5f4e72653c513eee775bc1df30bcaa0fe
Gaurav Khanna [Tue, 3 Jan 2017 16:10:15 +0000 (08:10 -0800)]
Merge pull request dotnet/coreclr#8777 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24903-02, beta-24903-01, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ea7c115703fe37734121d6423a6f9a38b216cf14
Jan Kotas [Tue, 3 Jan 2017 14:13:46 +0000 (06:13 -0800)]
ArrayPool fixes (dotnet/coreclr#8774)
* Use Array.Empty<T>() to make the code identical to CoreRT copy
The internal EmptyArray<T> does not exist in CoreRT.
* Remove unnecessary helper type for lazy initialization
All generic types are beforefieldinit by design.
* Use | for clarity
Commit migrated from https://github.com/dotnet/coreclr/commit/
65b50f1143cc0b0f1523f62f9c048cb3c89d4afb
dotnet-bot [Tue, 3 Jan 2017 09:48:14 +0000 (09:48 +0000)]
Update CoreClr, CoreFx to beta-24903-02, beta-24903-01, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1f8c728e9c8960e945c78ee601c3b1084cb7f93
Justin Van Patten [Tue, 3 Jan 2017 04:41:04 +0000 (20:41 -0800)]
TimeZoneInfo: Reduce intermediate allocations in GetTimeZoneIds on Unix (dotnet/coreclr#8769)
Avoid intermediate underlying array allocations as items are added to
the resulting List<string> by specifying the capacity. Also, change
the signature of the private method to return List<string> instead of
IEnumerable<string> to avoid the enumerator allocation when enumerating
the ids.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0bca3c16e17f199bd8734aa1e2579e8d07ffe560
dotnet bot [Tue, 3 Jan 2017 00:50:22 +0000 (16:50 -0800)]
Update CoreClr, CoreFx to beta-24902-03, beta-24902-02, respectively (dotnet/coreclr#8745)
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc7199f76b2bb6ebb9f9bcc5e1ce4f9a399e3331
Hyeongseok Oh [Mon, 2 Jan 2017 22:37:42 +0000 (07:37 +0900)]
[Linux/ARM32] duplicated definition in crosscomp.h (dotnet/coreclr#8729)
Some structs in crosscomp.h are already defined in pal.h or palrt.h
Fix to avoid duplicated definition
Commit migrated from https://github.com/dotnet/coreclr/commit/
a60210e62b935dda4a412537099f83cc5500526e
SaeHie Park [Mon, 2 Jan 2017 14:59:40 +0000 (23:59 +0900)]
[x86/Linux] Fix UMThunkStub calling convension (dotnet/coreclr#8714)
This fixes reverse P/Invoke segment faults by handling cdecl from UM to
fastcall for Managed code, which corrects many CoreFX unit test cases including CharMinValue.exe.
First and second parameter(s) are set to ECX, EDX and rest to the stack.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a11492d52faa85c551761f8390be5de9d74e5ec
James Ko [Mon, 2 Jan 2017 04:25:45 +0000 (23:25 -0500)]
Delete unused Diagnostics files (dotnet/coreclr#8754)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a5c304b5115ddcd8ac7838a1ce87c5d4ad03ccf
James Ko [Mon, 2 Jan 2017 01:40:39 +0000 (20:40 -0500)]
Delete unused Threading types/members (dotnet/coreclr#8766)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d99e34c932ba91440665335e8e7d48260c4e0be
James Ko [Mon, 2 Jan 2017 01:32:07 +0000 (20:32 -0500)]
Delete unused SymbolStore files (dotnet/coreclr#8767)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f45d03e0118fe91d27a5b31983f599b41b9c31dd
James Ko [Sun, 1 Jan 2017 01:25:17 +0000 (20:25 -0500)]
Delete unused IO files (dotnet/coreclr#8753)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8206d0c11e035aa4419782fa0a3b6cd27091b85
Joseph Tremoulet [Sat, 31 Dec 2016 21:43:23 +0000 (16:43 -0500)]
Merge pull request dotnet/coreclr#8755 from JosephTremoulet/DeadParam
Remove dead parameter in value-numbering
Commit migrated from https://github.com/dotnet/coreclr/commit/
b263960813a58bd5dc57d289d1db828d063f3754
Joseph Tremoulet [Fri, 30 Dec 2016 16:54:56 +0000 (08:54 -0800)]
Fix heap live-in calculation
Update the code in liveness that sets the `fgCurHeapUse` flag (which needs
to identify whether the current block has an upwards-exposed use of the
heap) to set this unconditionally for opcodes that use the heap.
Previously, this code was avoiding setting the flag if the block has a
prior def of the heap, but in the absence of a guarantee to the contrary,
we must assume that the heap use may not alias the heap def, and so still
be upwards-exposed and cause the heap to be live-in to the block.
Also remove the OptRepeat workaround for the lack of this, in
`ResetOptAnnotations`.
Fixes dotnet/coreclr#7846.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d8e66b969c31360f89ac6afa9008fd8cf85219aa
Joseph Tremoulet [Fri, 30 Dec 2016 16:29:49 +0000 (11:29 -0500)]
Remove dead parameter in value-numbering
Parameter `newVNsForPhis` of method `fgValueNumberBasicBlocks` is unused;
its presence and comment are confusing/misleading. What actually happens
is that `fgValueNumberBlock` itself checks whether the value numbers for
incoming Phi args' SSA defs are defined yet or not.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e06469cca70364bea4e5562f6f770c90ac200934
Eric Mellino [Thu, 29 Dec 2016 22:53:46 +0000 (14:53 -0800)]
Add CORE_LIBRARIES to the TPA list if it's set in unixcoreruncommon
Commit migrated from https://github.com/dotnet/coreclr/commit/
f8d72ed4407b01a06ca9a3495e06da6b6be8538d
sandreenko [Thu, 29 Dec 2016 01:02:01 +0000 (17:02 -0800)]
Merge pull request dotnet/coreclr#8743 from sandreenko/an-additional-shift-test
an additional shift test. fix dotnet/coreclr#7216 .
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e67c8f8a95dddd5716e1b60705ff63c5a09a805
darxis [Wed, 28 Dec 2016 22:51:30 +0000 (23:51 +0100)]
Typo in documentation (dotnet/coreclr#8740)
Commit migrated from https://github.com/dotnet/coreclr/commit/
19a2fe078db73d593242fdc73210720401648ef4
dotnet bot [Wed, 28 Dec 2016 22:48:41 +0000 (14:48 -0800)]
Update CoreClr, CoreFx to beta-24828-03, beta-24828-03, respectively (dotnet/coreclr#8741)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e64b2972c02481331bc2473b21ba5da43c1c5cdf
Sergey Andreenko [Wed, 28 Dec 2016 20:35:30 +0000 (12:35 -0800)]
an additional shift test. fix dotnet/coreclr#7216 .
Test long and ulong shifts by 0, 32 and 64 constants.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b61252425a5e8bff749347237c65257f857e1181
Gaurav Khanna [Wed, 28 Dec 2016 16:33:01 +0000 (08:33 -0800)]
Merge pull request dotnet/coreclr#8738 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-24828-02 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
642565e9bf8843a5710665890654ff5837d41abb
Caio Kinelski [Wed, 28 Dec 2016 16:11:05 +0000 (08:11 -0800)]
Fix order of raising AssemblyLoadContext.Unloading and AppDomain.ProcessExit (dotnet/coreclr#8737)
The AssemblyLoadContext.Unloading event must be raised before the AppDomain.ProcessExit event.
AssemblyLoadContext.OnUnloading now subscribes to AppContext.Unloading.
Then AppContext.OnAppContextUnloading and AppContext.OnProcessExit, in that order, subscribe to AppDomain.ProcessExit.
Part of fix for dotnet/corefxdotnet/coreclr#14566
Commit migrated from https://github.com/dotnet/coreclr/commit/
d178b1287377a837773defb6b2a7f2b4e2dfc667
Hyeongseok Oh [Wed, 28 Dec 2016 15:33:04 +0000 (00:33 +0900)]
Fix Bitposition funtion (dotnet/coreclr#8739)
Fix Bitposition(value) function implementation to check platform, not target.
- cross-architecture component build error for ARM32/linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
96400a730d7d4385c17f0930803ad79bd20edeb0
dotnet-bot [Wed, 28 Dec 2016 09:42:01 +0000 (09:42 +0000)]
Update CoreClr to beta-24828-02
Commit migrated from https://github.com/dotnet/coreclr/commit/
bcd5efeda29d531a6cc2c52fc6eb9310ac80f904
Jan Kotas [Wed, 28 Dec 2016 03:35:37 +0000 (19:35 -0800)]
Merge pull request dotnet/coreclr#8734 from justinvp/tzi_files
TimeZoneInfo: Move nested types and Win32/Unix implementations to separate files
Commit migrated from https://github.com/dotnet/coreclr/commit/
688ed8280eec93acb49ced2d563c1f31c4557f6a
Jan Kotas [Wed, 28 Dec 2016 03:33:07 +0000 (19:33 -0800)]
Update issue guide (dotnet/coreclr#8728)
* Revert "Update IssuesFeedbackEngagement.md"
This reverts commit dotnet/coreclr@
124754f2f5382f2781db8f132e3c89d21b56600b.
* Update wording
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c7347aa87a12f7f008370c827e17f9580760754
Justin Van Patten [Tue, 27 Dec 2016 22:49:32 +0000 (14:49 -0800)]
Remove ifdefs from TimeZoneInfo
Move Win32 and Unix -specific implementation details to their own files.
Commit migrated from https://github.com/dotnet/coreclr/commit/
95f269dec4ec9af5e27a681360a0c2831c67521c
Gaurav Khanna [Tue, 27 Dec 2016 19:03:39 +0000 (11:03 -0800)]
Merge pull request dotnet/coreclr#8712 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24827-03, beta-24827-01, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0bfe1518aee98fcc69257f07af4f8fb31c57dc29
dotnet-bot [Tue, 27 Dec 2016 17:35:38 +0000 (17:35 +0000)]
Update CoreClr, CoreFx to beta-24827-03, beta-24827-01, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
151942b727cefdf18586eae76b82248ed80a9c98
Justin Van Patten [Mon, 26 Dec 2016 19:40:01 +0000 (11:40 -0800)]
Move nested TimeZoneInfo types to their own files
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c78f69e54cda6ce0b553a8e8a4e483c550ed0c9
Robert [Mon, 26 Dec 2016 19:25:24 +0000 (19:25 +0000)]
Remove files related to legacy build system (dotnet/coreclr#8723)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee6f9795615bf21936a4c443e312fee03d5db0bf
Justin Van Patten [Sun, 25 Dec 2016 07:53:44 +0000 (23:53 -0800)]
TimeZoneInfo Cleanup (dotnet/coreclr#8720)
Update TimeZoneInfo to use CoreFX coding style and other minor cleanup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
94502643d53d5ded7542d9ed883a45be06fdf6e7
Jan Kotas [Fri, 23 Dec 2016 18:19:52 +0000 (10:19 -0800)]
Improve ArrayPool core affinity (dotnet/coreclr#8716)
- Move the ExecutionId to non-generic type so that it can be shared by all ArrayPool instances.
- Add logic to refresh it periodically. It avoids pathological cases where the OS scheduler ends up reassigns the preferred cores and multiple active threads start competing over the same buckets.
- Removed flushing of ExecutionId on LockedStack lock contention since it was not very effective
Commit migrated from https://github.com/dotnet/coreclr/commit/
281b93760c7c6a7e9059f9a5dc6a5c6cfc0e4879
Jan Vorlicek [Fri, 23 Dec 2016 13:41:28 +0000 (14:41 +0100)]
Remove all usage of vsnprintf (dotnet/coreclr#8709)
This change removes all usages of vsnprintf and modifies runtime to not to use
vsnprintf or _vsnprintf
I've also fixed two issues in PAL TRACE function string format parameters that
caused crashes when I was trying to run all PAL tests with PAL tracing enabled.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5cbe4c9cab2873b60cd3c991732a250d2e164a2
Hyeongseok Oh [Fri, 23 Dec 2016 13:18:32 +0000 (22:18 +0900)]
[Linux] Fix cross-architecture component build configuration for ARM32-target (dotnet/coreclr#8687)
* fix CMakeLists.txt for palrt
* Modify CMakeLists.txt for cross-architecture component configuaration
Add coreclrpal project to fix a dependency issue when CMake configuration
* Allow only x64-host/arm-target for linux
allow x64-host/arm-target only, because pal is not stable for x86 now
* Update build.sh
delete NumProc=1 (inserted for debugging)
* Change x64-host to x86-host for arm-target
JIT correctness problem,
and fix CMake configuration for x86 in pal
* Fix type
* Update CMakeLists.txt
* fix style
* Set x86 when arm-target/x64-host
* fix typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ef3df8ffe059d5f91c6bae09d8f95a0332f1363
Gaurav Khanna [Thu, 22 Dec 2016 19:05:52 +0000 (11:05 -0800)]
Merge pull request dotnet/coreclr#8707 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24822-03, beta-24822-03, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
55ea631f84ba1e9084f12b95a43135b526169cd9
Carol Eidt [Thu, 22 Dec 2016 18:52:39 +0000 (10:52 -0800)]
Merge pull request dotnet/coreclr#8680 from mskvortsov/ryujit-arm32-backend
[WIP] ARM32 RyuJIT backend
Commit migrated from https://github.com/dotnet/coreclr/commit/
f305035f29220d2673623d61f663b96f4fb5f56e
Michelle McDaniel [Thu, 22 Dec 2016 18:23:14 +0000 (10:23 -0800)]
Merge pull request dotnet/coreclr#8682 from adiaaida/newjobs
Script to run CoreFx tests against a private CoreCLR
Commit migrated from https://github.com/dotnet/coreclr/commit/
73fe1dbe78a89766c60bffd04f5961b524ea6294
dotnet-bot [Thu, 22 Dec 2016 17:29:49 +0000 (17:29 +0000)]
Update CoreClr, CoreFx to beta-24822-03, beta-24822-03, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ab4df8fc393a703a7be58219ff56f3086c99d1e
Mikhail Skvortcov [Fri, 16 Dec 2016 10:41:10 +0000 (13:41 +0300)]
ARM: A step towards the RyuJIT/ARM32 backend.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ca9f5f7062bdf4970f124d64d8d8e0a10fb26cc3
Julien Couvreur [Thu, 22 Dec 2016 07:01:38 +0000 (23:01 -0800)]
Adding ValueTuple and ITuple to corlib in CoreCLR (dotnet/coreclr#8695)
* Adding ValueTuple
* Adding ITuple
* Porting equality comparer optimization from corefx PR dotnet/coreclr#14187
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d49c2c743831b7078c4360f28a81ba28fc47a05
Jan Kotas [Thu, 22 Dec 2016 04:08:37 +0000 (20:08 -0800)]
Delete FEATURE_LEGACYSURFACE (dotnet/coreclr#8704)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1d03b8fd8d650bd215623a7b035e68db96697e59
Sivarv [Thu, 22 Dec 2016 01:34:39 +0000 (17:34 -0800)]
Merge pull request dotnet/coreclr#8706 from sivarv/simdAbs
Use Pabsd/pabsw/pabsb instructions for Abs SIMD intrinsic on SSE3_4 and above targets.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e88965d26433025ff36b9164b06833ca2253b61c
sivarv [Wed, 21 Dec 2016 23:17:08 +0000 (15:17 -0800)]
Use Pabsd/pabsw/pabsb instructions for Abs SIMD intrinsic on SSE4 and above targets.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c887cfd237e767454c7a8eca51aac5a6c4357aa
Jan Kotas [Wed, 21 Dec 2016 20:49:34 +0000 (12:49 -0800)]
Move EditorBrowsableAttribute to CoreLib (dotnet/coreclr#8703)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3f9ec2a41a809ae6e39e727871d1d7d6c29106b7
Gaurav Khanna [Wed, 21 Dec 2016 19:27:39 +0000 (11:27 -0800)]
Merge pull request dotnet/coreclr#8701 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24821-04, beta-24821-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
426e4da54f3b79b381f0d5deb11cdc32ffeb4f4d
Sivarv [Wed, 21 Dec 2016 18:30:14 +0000 (10:30 -0800)]
Merge pull request dotnet/coreclr#8697 from sivarv/lockAddFix
Fix GT_LOCKADD register specification.
Commit migrated from https://github.com/dotnet/coreclr/commit/
77561c87ed48f5af122aecc104f6a0b6a6382121