Thomas McGuire [Fri, 7 Sep 2012 10:31:43 +0000 (12:31 +0200)]
Add QML_RENDER_TIMING output for the single-threaded case
Change-Id: Ia3958c7c26bf2fd9dd72a07fc6f5ff3a28b0a349
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Thomas McGuire [Fri, 7 Sep 2012 08:16:39 +0000 (10:16 +0200)]
Use DEFINE_BOOL_CONFIG_OPTION for QML_RENDER_TIMING
This makes it easier to grep for.
Change-Id: I7630e05c4afddb4ab3ce1a7691466d7307325988
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Thiago Macieira [Wed, 29 Aug 2012 19:40:03 +0000 (21:40 +0200)]
Update the git-archive export options
The .gitattributes and .gitignore files do not need to be present in
packaged sources, as they are for people using the Git repository.
People who download tarballs usually don't reimport into Git -- they
should just download the actual repositories.
Meanwhile, the .tag file is quite useful. Instead of making Git extract
to the useless SHA-1 of the "$Id$\n" string, ask git-archive to store
the SHA-1 of the commit being packaged.
Change-Id: I5850800f9706dda342596a9db383e9d2c60e3c3e
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Sergio Ahumada [Sat, 8 Sep 2012 15:39:02 +0000 (17:39 +0200)]
doc: fix some more typos
Change-Id: I7fa055049b9e5900d597754c6004febb153de12b
Reviewed-by: Jerome Pasion <jerome.pasion@nokia.com>
Sergio Ahumada [Sun, 9 Sep 2012 14:04:08 +0000 (16:04 +0200)]
test: Check for null string comparison
Do not compare a QString to QString(). Instead use the .isEmpty() method.
Change-Id: I4ef0c050f97b2070ed13d89305ad894479e42dd6
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
J-P Nurmi [Thu, 6 Sep 2012 08:52:29 +0000 (10:52 +0200)]
tst_qquickfontloader: remove unnecessary skips on Windows
Change-Id: I319d0a5cc2387c5bc1b308e6e12a33e720a2d722
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
J-P Nurmi [Thu, 6 Sep 2012 12:35:31 +0000 (14:35 +0200)]
Fix tst_qquickanimatedimage::mirror_running()
Change-Id: I6916d90736144101b52449485b09335ac124e498
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Sean Harmer [Sat, 25 Aug 2012 10:47:53 +0000 (11:47 +0100)]
Compile following qreal -> float change in QtGui/math3d classes
This is needed following change
https://codereview.qt-project.org/#change,33148
Change-Id: I836d4037306d1efbff48668ff8dd2b7b5ce97516
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
J-P Nurmi [Fri, 7 Sep 2012 09:10:28 +0000 (11:10 +0200)]
QtQml tests: remove QSKIP -> wrap within !QTEST_CROSS_COMPILED guards
Change-Id: I200bf6feb137e39061f144bdabd825dea70bd539
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
J-P Nurmi [Thu, 6 Sep 2012 12:55:54 +0000 (14:55 +0200)]
tst_QQuickPathView::package(): updated QSKIP()
QTBUG-21590 has been marked as resolved, but the problem persists.
A new bug QTBUG-27170 has been reported and the QSKIP() updated
accordingly.
Task-number: QTBUG-27170
Change-Id: I91d7df2588d87af833502f6c11d2e6a051e4ebb5
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Sergio Ahumada [Thu, 6 Sep 2012 21:44:08 +0000 (23:44 +0200)]
doc: fix some typos in .cpp files
Change-Id: Ica7685aefde84ec80d8af7a67541af454de4adce
Reviewed-by: Jerome Pasion <jerome.pasion@nokia.com>
Kai Koehne [Fri, 7 Sep 2012 09:37:19 +0000 (11:37 +0200)]
qmlplugindump: Fix dumping of types
Dumping broke with commit
70a2c049.
Change-Id: Ifbae3dbc3e2d255c1e7f8848c579c04d0bf4b48e
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Kai Koehne [Fri, 7 Sep 2012 08:43:18 +0000 (10:43 +0200)]
qmlplugindump: Take care of 'void' types
QMetaMethod::typeName() does now return "void" instead of an empty string (change
22d621dd).
Change-Id: I70affc450a7dd36b121cbcf580c0ca6fd5944f0b
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
J-P Nurmi [Thu, 6 Sep 2012 15:03:36 +0000 (17:03 +0200)]
Updated tst_QJSEngine
Replaced several QSKIP() instances with QEXPECT_FAIL() and removed
execScript from the list global object properties as it has been
removed from V8: http://codereview.chromium.org/7046002/
Task-number: QTBUG-27169
Change-Id: I28bbb38971ad80551ec24285a321e545db44a79d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
J-P Nurmi [Thu, 6 Sep 2012 13:42:03 +0000 (15:42 +0200)]
tst_qquickflickable: fix compilation warning
warning: converting 'false' to pointer type for argument 2 of
'void QQmlContext::setContextProperty(const QString&, QObject*)'
Change-Id: Iec0f8bba115f05c7392d6654cd1f52d06ff96e97
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
J-P Nurmi [Fri, 7 Sep 2012 09:06:59 +0000 (11:06 +0200)]
Wrap tst_qqmllocale::timeZoneUpdated() within Q_OS_UNIX to remove QSKIP
Change-Id: I9cb0da7dbca6401069f572aef15d5375aadce30d
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
Kim Motoyoshi Kalland [Wed, 5 Sep 2012 13:51:02 +0000 (15:51 +0200)]
Doc: Fix documentation issues.
Change-Id: I03c4faa1aee60cd1ad706cb6c1b983f03311d251
Reviewed-by: aavit <qt_aavit@ovi.com>
Sergio Ahumada [Thu, 6 Sep 2012 20:53:50 +0000 (22:53 +0200)]
doc: fix some typos in .qml files
Change-Id: Ice5d60b06ec9ab81fbd98fd1679c8834f3018938
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
J-P Nurmi [Thu, 6 Sep 2012 11:30:13 +0000 (13:30 +0200)]
Attempt to fix tst_QQuickListView::sectionsDelegate_headerVisibility()
Task-number: QTBUG-24395
Change-Id: I07b0fc17566e86dcebf913721f293378cf15466b
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Caroline Chao <caroline.chao@nokia.com>
Sérgio Martins [Wed, 5 Sep 2012 15:43:55 +0000 (16:43 +0100)]
Fix typo in documentation.
Change-Id: I4d8d12cfce58e49789146639cc6734b6cf1643fa
Reviewed-by: David Faure <faure@kde.org>
Casper van Donderen [Mon, 3 Sep 2012 09:00:19 +0000 (11:00 +0200)]
Doc: Use settings from global qdocconf.
Depends on the integration of #34077
Change-Id: I188d7617c4805d00226d0fb8d5768a02d24c6933
Reviewed-by: Geir Vattekar <geir.vattekar@nokia.com>
Kim Motoyoshi Kalland [Tue, 4 Sep 2012 14:25:25 +0000 (16:25 +0200)]
Doc: Fix some documentation issues.
Change-Id: I0f7e60fd6060381bd8790dfaacc3a39a890a0fe7
Reviewed-by: aavit <qt_aavit@ovi.com>
Gunnar Sletta [Fri, 17 Aug 2012 12:59:19 +0000 (14:59 +0200)]
Remove windowmanager hacks form the incubation controller.
Tie incubation directly to wether animations are running
or not. When animations are running, we incubate for
a third of a frame only. When animations are not running
we incubate whatever is left as the scene is anyway idle.
Change-Id: I88c9248e9d7b3b35c99fca52aeb9c681d1b4a306
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Thomas McGuire [Tue, 14 Aug 2012 12:19:09 +0000 (14:19 +0200)]
Delete weak JS objects on exit right away
This reduces memory leaks on exit when the engine is destroyed
after exec() has finished.
Change-Id: I917d103966d55b4dd3ba4e986ff902e29d8fb0ac
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Aaron Kennedy [Wed, 30 May 2012 09:16:13 +0000 (10:16 +0100)]
Evaluate bindings more intelligently during construction
Instead of just evaluating bindings in a fixed order, and possibly
having to evaluate a single binding multiple times, prior to reading
a property, we check if there are any bindings "pending" on it and
evaluate them then. A pending binding is one that has been assigned
to the property, but not yet evaluated.
To minimize side effects we only do this for "safe" bindings. A
safe binding is one that has no side effects, which we currently
define as not calling functions or otherwise assigning values during
its evaluation. This isn't an entirely foolproof way to ensure that
the evaluation has no side effects, but it should be good enough.
Change-Id: I98aa76a95719e5d182e8941738d64f8d409f404a
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Alan Alpert [Tue, 7 Aug 2012 07:31:46 +0000 (17:31 +1000)]
Only test qtdeclarative examples for naming convention
Change-Id: Id34e29546a22a74a7ae2ad90ee3a8deabccddddd
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Kai Koehne [Tue, 28 Aug 2012 14:49:37 +0000 (16:49 +0200)]
Fix compiler warnings from MSVC2010
Change-Id: I44eb0113374c221a166609c4fd29b5dad05ecc94
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Stephen Kelly [Tue, 28 Aug 2012 11:12:32 +0000 (13:12 +0200)]
Test metatype registration errors with non-metatypes.
QList<QPoint> is to become automatically registered
with https://codereview.qt-project.org/#change,32897
and https://codereview.qt-project.org/#change,33031
Change-Id: I455028e226c15e922162bae21db7e5e9de07063b
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Aurindam Jana [Tue, 5 Jun 2012 11:34:40 +0000 (13:34 +0200)]
Console API: Print JS object
Calling console.log(), console.debug(), print() etc would only
print out "Object" if a JS Object was passed as an argument.
This patch calls the toString() on the object.
Change-Id: Iadf8b4d1fe81c3e2c7bd65e3c153a930fd994bef
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Yuchen Deng [Sat, 25 Aug 2012 02:44:04 +0000 (10:44 +0800)]
Add doc/qtqml and doc/qtquick to .gitignore
Change-Id: I17fa26d5d1481318656b45776f38c3699e873718
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Matthew Vogt [Tue, 28 Aug 2012 05:00:42 +0000 (15:00 +1000)]
Fix property overriding lookup to exclude functions
Function overriding is required by QmlTest, and is likely to be used by
other existing QML users.
Change-Id: I04086a933456145bda5cede74aba753799feb555
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Thomas McGuire [Fri, 24 Aug 2012 13:28:46 +0000 (15:28 +0200)]
Reduce memory usage of QV4Bindings::Subscription by 8 bytes.
There is no need to store the method, as it can be calculated via
pointer arithmetic.
That leaves the active flag, which now is the last bit of the bindings
pointer.
Change-Id: I17b443e63be2d950aa80ad15cc76372b415c3dd6
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Bea Lam [Tue, 28 Aug 2012 01:21:19 +0000 (11:21 +1000)]
Docs - add missing images and code, clean up sections
Includes the removal of concepts/modelviewsdata/localstorage.qdoc
since that is a duplicate of the existing Local Storage module docs.
Also removes classes from whatsnew.qdoc that are internal.
Change-Id: I4170c1797bbec09bb67784b0b2ad67fd990365a8
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Matthew Vogt [Tue, 28 Aug 2012 01:56:51 +0000 (11:56 +1000)]
Document the current behavior of overridden properties
Change-Id: I0d9cf0285824e05b846ffeca2d26fe573f93ccf4
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Thomas McGuire [Tue, 14 Aug 2012 09:08:33 +0000 (11:08 +0200)]
Doc: Clarify ownership semantics of objects returned by property getters
Change-Id: I8d19756e95ff02ed67b39ba4741aff4fda5896ce
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Bea Lam [Mon, 27 Aug 2012 07:04:17 +0000 (17:04 +1000)]
Fix various doc errors
Also restore the main module "reference documentation" links
added in
0e0f46c01cf6a183996d36c31987ca4a46b50bd9
Change-Id: I421f5a17e2946a2569537d8ba8a021f219aaf75a
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Martin Jones [Tue, 21 Aug 2012 04:47:48 +0000 (14:47 +1000)]
Add cacheItemCount property to PathView
cacheItemCount specifies the number of items to cache off the path when
pathItemCount is specified. This allows up to cacheItemCount items to be
kept alive when they move off the path, and also to asynchronously
create items off path in preparation for display when the path offset
changes. This is the equivalent of cacheBuffer for other views.
Task-number: QTBUG-23931
Change-Id: I03497537d3f929e5e3579536850dd43eb2724c38
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Michael Brasser [Tue, 28 Aug 2012 00:49:28 +0000 (10:49 +1000)]
Refactor QQmlPropertyCacheMethodArguments creation.
Change-Id: Ic7215741b26ddf0a36181cf7c7daaff095e797da
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Michael Brasser [Tue, 28 Aug 2012 00:48:50 +0000 (10:48 +1000)]
Fix leak introduced in
0853343c33e394f35c31c161b019b2aed17f9256.
Change-Id: I7e23f2ba8e7ecbcfaddce1ac4224434aa5fbe69b
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Chris Adams [Tue, 14 Aug 2012 01:44:49 +0000 (11:44 +1000)]
Refactor singleton type registration code
Previously each singleton type was registered as an implicit separate
import. This commit changes the code so that these types are treated
just like any other type in the registration sense.
It also ensures that singleton types are instantiated per-engine.
Change-Id: I5c81c4ca5bf65210f7125d74a62a282a21838068
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Michael Brasser [Wed, 18 Jul 2012 03:53:40 +0000 (13:53 +1000)]
Update usage of smooth and antialiasing.
Change-Id: Icc8b28bdd466389ed3f269f076f1bdb6e9abe3f2
Reviewed-by: Yunqiao Yin <charles.yin@nokia.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Bea Lam [Mon, 27 Aug 2012 03:13:36 +0000 (13:13 +1000)]
Improve docs related to visual parent concept
Change-Id: I73cc63c8a55cf949b94a2fa502cb331fb8adbda3
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Bea Lam [Fri, 24 Aug 2012 03:00:52 +0000 (13:00 +1000)]
Clean up structure of JavaScript related docs
The global object and list of javascript functions should be linked to
as subsections from the "JavaScript Host Environment" topic page, and
all of the subsections should be visible from the module index page.
Also move the "restrictions" docs to this topic page as it's more
relevant to this section.
Also includes some minor doc improvements.
Task-number: QTBUG-26380
Change-Id: Iba6e4e510191bf5e4603d6cbb2826ad7bcdbd10c
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Bea Lam [Fri, 24 Aug 2012 01:41:18 +0000 (11:41 +1000)]
Move data ownership docs and improve docs
Move data ownership docs to where they can be found more easily.
Change-Id: Id5262cee9b082bc472e4b6ccea853c57e66489ac
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Charles Yin [Mon, 27 Aug 2012 01:36:42 +0000 (11:36 +1000)]
Use the new antialiasing property for canvas painting
Change-Id: I76f21d055696978f2f6936006eea038dd73cce6c
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Jason Barron [Tue, 21 Aug 2012 12:04:36 +0000 (14:04 +0200)]
Document QSGTexture.
Task-number: QTBUG-23192
Change-Id: I4a91dfaa0aa80d3cdc6c785fcaefdeafe60a2149
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Michael Brasser [Mon, 27 Aug 2012 01:56:15 +0000 (11:56 +1000)]
Fix potential memory leak in AnchorChanges.
Task-number: QTBUG-24708
Change-Id: I4e24b3859f3881ebea4780872b7e4f3790e42d54
Reviewed-by: Yunqiao Yin <charles.yin@nokia.com>
Chris Adams [Mon, 20 Aug 2012 07:13:48 +0000 (17:13 +1000)]
Move the Property Modifier Type documentation
Property Modifier Types are just another sort of QML object type, and
don't deserve explicit top-level documentation. This commit moves the
docs into the object types documentation, and adds documentation to the
syntax page about the "<PropertyModifierObject> on <propertyName>"
syntax.
Change-Id: Ia9b707739b562d2c8b75fa99b88795ba4d415cf7
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Matthew Vogt [Fri, 23 Mar 2012 04:16:43 +0000 (14:16 +1000)]
Restrict v8 property lookup to the execution context
When resolving property names, only properties known to the current
context of execution should be available. If a property name has
been overriden by a component extension, code executing in the
context of the base component should resolve the property name to
the property available inside the base component or its bases.
Task-number: QTBUG-24891
Change-Id: I9687cc28e108226d5a939627a901c8254344b598
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Thu, 9 Aug 2012 00:24:50 +0000 (10:24 +1000)]
Remove unreachable code paths from QQuickChangeSet.
In any circumstance these if statements would evaluate to true, a
previous branch of the else if block will be taken first.
Change-Id: I7f48769ebfbb1cf5105b875a63530d1c37056c11
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Tue, 21 Aug 2012 03:49:48 +0000 (13:49 +1000)]
Fix relative import path
Change-Id: I4c63c4c4ca58b630a454e455360080f7e4f4e4cc
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Bea Lam [Fri, 24 Aug 2012 04:09:36 +0000 (14:09 +1000)]
Add docs for "animation on property" syntax and fix topic page
Also the "States and Animations" topic page doesn't need a section for
behaviors since these are described on the "Animations and
Transitions in Qt Quick" page.
Task-number: QTBUG-20324
Change-Id: I46259402b8790df3aba9717f77fafef9f27a8d44
Reviewed-by: Damian Jansen <damian.jansen@nokia.com>
Kent Hansen [Fri, 24 Aug 2012 11:31:52 +0000 (13:31 +0200)]
Make samegame work again
Fixes regression caused by commit
6ebf215fdaf2d757ab90ae4d46c4b938e978e2dc. The commit did update the
autotests to use "Sql.LocalStorage.openDatabaseSync" instead of the
old "Sql.openDatabaseSync", but the examples and demos were not
updated accordingly.
Task-number: QTBUG-26928
Change-Id: Ifcff830e195a05a26ee095e11d4185f6d94eb1aa
Reviewed-by: Leonardo Sobral Cunha <leo.cunha@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Thomas McGuire [Tue, 14 Aug 2012 12:17:10 +0000 (14:17 +0200)]
Immediatley delete QV8QObjectResource objects to reduce memory leaks
This reduces memory leaks when deleting the v8 engine.
Otherwise, the memory would only be reclaimed during a full GC run,
which might not happen at all.
Change-Id: Iac34bad1f2280adc530d3b3d7a074c5d022005a4
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Thomas McGuire [Mon, 13 Aug 2012 13:48:44 +0000 (15:48 +0200)]
Don't put JavaScript-owned objects on the stack.
Only the fact that the object wrapper uses deleteLater() instead of
delete made this not crash.
Change-Id: I034d8c7f24b963be9e031446ffdfa33e6bc266cc
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Thomas McGuire [Wed, 15 Aug 2012 07:33:18 +0000 (09:33 +0200)]
Document the vTable hack.
This was not immediately obvious, so better document this clever trick.
Change-Id: I0d4a06396b9a709b29b46726d9a65d53600e3fa2
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Matthew Vogt [Fri, 24 Aug 2012 00:05:53 +0000 (10:05 +1000)]
Fix warnings in QtQml
Change-Id: Ibba3b8e878257f7019bdc90a1344462b77f95a21
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Fri, 24 Aug 2012 03:12:42 +0000 (13:12 +1000)]
Fix doc links
Change-Id: Iafbcd39472f3e6f12169ae1a17b4a040dbb9a8a4
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Bea Lam [Thu, 23 Aug 2012 04:16:11 +0000 (14:16 +1000)]
Improvements for coding conventions docs
Shouldn't advise using "__" for "private" properties since this
mightn't be the best solution. This doesn't work with the onXChanged
handler syntax.
Also grouped and dot property syntax are both valid. We use both
throughout our code.
Change-Id: Ibd86f20136dc0e7225558e234afb79f566ca1039
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Bea Lam [Thu, 23 Aug 2012 04:10:50 +0000 (14:10 +1000)]
Link to Coding Conventions page
Change-Id: I4c2870bf37ea1f9f110ced4120d4a622096d8dfe
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Andrew den Exter [Thu, 23 Aug 2012 04:20:47 +0000 (14:20 +1000)]
Fix assert when a VisualDataModels context has been invalidated.
Verify the context is valid before attempting to access its engine. The
context should normally be valid but there is a small window between
a delegate item being released and the DeferredDelete event being
processed when it is not.
Task-number: QTBUG-26949
Change-Id: I79f3affaed8904cbe0974476010b68305666cd29
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Michael Brasser [Sun, 20 May 2012 23:27:43 +0000 (09:27 +1000)]
Avoid dynamic lookup of signal handler arguments
Rewrite signal handlers to include the parameters
in the rewrite. Also check whether parameters are
actually used when possible, and if not don't
provide them to the expression.
Change-Id: I7d65c05f4639979dd61035cf7478119ef7647c25
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Matthew Vogt [Tue, 21 Aug 2012 02:44:42 +0000 (12:44 +1000)]
Increase test coverage for V4
Add test for integer operations, Math functions and exercise some
previously uncovered code.
Change-Id: Idff3f3672498775ac117ca98bf34b0fe96cbf760
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Jerome Pasion [Mon, 13 Aug 2012 13:16:51 +0000 (15:16 +0200)]
Doc: Tidied links, titles, and HTML pages.
-used "Qt Quick" and "Qt QML" to refer to the module
-qtquick-index.html and qtqml-index.html for the landing pages
Change-Id: I1569949f7875ac6008a5b80a169e327f93f330ae
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Alan Alpert [Wed, 15 Aug 2012 04:30:31 +0000 (14:30 +1000)]
Fixes a reference in the Animation docs.
repeat was renamed to loops long ago
Change-Id: Iaaabc155aa16e92367dee2082974856769bad90a
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Bea Lam [Mon, 20 Aug 2012 05:27:07 +0000 (15:27 +1000)]
Remove some incorrect animation docs
Task-number: QTBUG-23233
Change-Id: I2f0b65ff4553f49e9248ead33a6a06f2076e9a25
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Bea Lam [Fri, 17 Aug 2012 03:05:39 +0000 (13:05 +1000)]
Document various undocumented attributes of QQuickItem
Add docs for various properties and methods that are public but weren't
documented. Also marked various things that shouldn't be documented as
\internal.
Newly documented attributes in C++ API include:
- x, y, z, implicitWidth/Height, baselineOffset
- transformOrigin, rotation, scale
- stackBefore(), stackAfter()
- mapTo*(), mapFrom*(), mapRectTo*(), mapRectFrom*()
- childItems(), childAt()
- updatePolish() and polish()
- state
- opacity, visible, enabled
- mouse, hover, wheel, key, touch and grab event handlers
- drag and drop event handlers
- acceptedMouseButtons(), filtersChildMouseEvents(),
acceptHoverEvents(), grabMouse, ungrabMouse()
- focus, activeFocus, isFocusScope(), scopedFocusItem()
- methodInputEvent(), inputMethodQuery()
- Flag enum, setFlags(), flags()
- window()
Newly documented attributes in QML API include:
- smooth, antialiasing
- baselineOffset
Change-Id: If8596b2a488e6ae37a3eb1f7d6dd0911479e9c0e
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Stephen Kelly [Wed, 22 Aug 2012 09:41:55 +0000 (11:41 +0200)]
Port away from qWaitForWindowShown.
It is deprecated.
Change-Id: Icf29b1f5ab6cb06ee7fd375fb96242df7ee3083e
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Thomas McGuire [Tue, 17 Jul 2012 15:35:53 +0000 (17:35 +0200)]
Make connectNotify() work with QML
Call connectNotify() and disconnectNotify() in QQmlNotifierEndPoint,
which works for QML signal handlers and for QML bindings.
Task-number: QTBUG-11284
Change-Id: Ic9a08ee6687e5c7e606f315c8fb30eec1493cd83
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Stephen Kelly [Tue, 21 Aug 2012 16:19:01 +0000 (18:19 +0200)]
Trim trailing whitespace.
Change-Id: I3d268d3ce8d73c7287f51abe9a28c165cb75acb9
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Chris Adams [Mon, 20 Aug 2012 02:37:42 +0000 (12:37 +1000)]
Fix signal offset in dynamic sig param lookup
Related to
4317c442fd492121e2fc037a39b40653bbc34294
Change-Id: I6aa505b9dc13813d4996c0b5761e9c3e5eea0292
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Aaron McCarthy [Wed, 18 Jul 2012 03:13:47 +0000 (13:13 +1000)]
Export QV8ValueTypeWrapper.
This is required to implement value types in other modules.
Change-Id: I0d59abb321b046efbaa73a5dcd24b72ee343fba7
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Bea Lam [Mon, 20 Aug 2012 05:01:22 +0000 (15:01 +1000)]
Fix snippets to compile to ensure they are valid
Also deletes snippets that are no longer used by docs.
Task-number: QTBUG-26637
Change-Id: I63e129f3169ae78aeb7ac840b6f5b5925dbd06b4
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Bea Lam [Mon, 20 Aug 2012 03:44:47 +0000 (13:44 +1000)]
Link to "Deploying QML Applications"
Change-Id: Ic5403ac972ff71648a8f957baec292a0a207b00c
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Joona Petrell [Tue, 21 Aug 2012 21:09:55 +0000 (00:09 +0300)]
Remove deprecated openSoftwareInputPanel function calls from the declarative examples
Change-Id: I458bb1ed08f587b13a52a2615ba4d7966363a12b
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Matthew Vogt [Mon, 20 Aug 2012 06:42:11 +0000 (16:42 +1000)]
Fix V4 calculations that vary from V8 results
Task-number: QTBUG-24706
Change-Id: I4475a772c5cd92776f2cb73dab9bc06ae4c019fa
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Sean Harmer [Tue, 21 Aug 2012 09:26:05 +0000 (10:26 +0100)]
Fix compilation on Linux with gcc-4.6
Also make use of the seed.
Change-Id: I03bd961489d95504bf973c02d51979904fbd9b1c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Sean Harmer [Mon, 20 Aug 2012 20:09:48 +0000 (21:09 +0100)]
Fix compilation on OSX 10.6
OS X 10.6 does not support the GL_ARB_framebuffer_sRGB extension.
Change-Id: Ifea8eaf3ffca6242d908538afeb983131a113c73
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Kent Hansen [Thu, 16 Aug 2012 12:11:52 +0000 (14:11 +0200)]
Use object identity to detect cycles in JS-to-C++ type conversion
The documentation for v8::Object::GetIdentityHash() states that the
hash value is not guaranteed to be unique (the current implementation
just returns a random number). Hence, the hash value should not be
used to determine whether an object has already been visited during
type conversion; in the worst (and non-deterministic) case, the
conversion will be "cut off" prematurely (due to identical hash
values for two different objects), resulting in data loss.
Instead, represent the visited objects as a set of V8 object handles.
This is safe since the type conversion is always done on the stack,
within a handle scope. Use v8::Object::GetIdentityHash() merely to
implement the qHash() specialization needed for the set.
V8 already provides an operator==() for handles, and it is documented
to return true "if the objects to which they refer are identical",
which is the behavior required by the set implementation.
Task-number: QTBUG-21681
Change-Id: I1f2a1eee8f7c197c02c2ffeaaa1fc0274e8ab740
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Kent Hansen [Thu, 16 Aug 2012 10:16:38 +0000 (12:16 +0200)]
Get rid of engine-wide state of visited objects for type conversion
Pass the state through to internal conversion functions instead.
Change-Id: Ifab9a9472d7271ee5da103ed915427dfd4f2b15b
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Andrew den Exter [Thu, 16 Aug 2012 06:13:56 +0000 (16:13 +1000)]
Add internal documentation and comments to QQuickListCompositor.
Change-Id: Idc140a8a83502a9d2d10591d8f3179f130dca53a
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Bea Lam [Fri, 17 Aug 2012 01:28:28 +0000 (11:28 +1000)]
setImplicitWidth/Height should be public
They are used as property setters.
Change-Id: Id7461277f19b495cced04e7919f234b0917eca80
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kent Hansen [Thu, 16 Aug 2012 11:48:57 +0000 (13:48 +0200)]
Add missing QT_{BEGIN,END}_NAMESPACE
Change-Id: Id924df99bd000ca5e7ffbef122c0087733f53685
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Gunnar Sletta [Fri, 17 Aug 2012 08:00:06 +0000 (10:00 +0200)]
Stabilize QQuickWindow tests a bit
Change-Id: I11a28e203c978e5675b088a5bb999c34b46f80da
Reviewed-by: aavit <qt_aavit@ovi.com>
Thomas Hartmann [Fri, 17 Aug 2012 09:21:43 +0000 (11:21 +0200)]
Fixing easing curve editor
Explicitly close the Qt Quick window.
Change-Id: I9f3ed6155577b6d066ab00c407ce99f31b1263aa
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Matthew Vogt [Fri, 17 Aug 2012 01:10:10 +0000 (11:10 +1000)]
Reduce memory consumption in QV4Bindings::Binding
As with QV8Bindings::Binding, access details from the QML IR
instruction object rather than storing a copy of the values.
Change-Id: I2b629ee1b06ed74c7b38e6d047ef6a98acd45086
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Sean Harmer [Mon, 30 Jul 2012 17:33:42 +0000 (18:33 +0100)]
Compile on OpenGL ES2 when using Khronos headers
This change is needed to allow qtdeclarative to build with change
https://codereview.qt-project.org/#change,28334 as OpenGL ES 2 and
the EXT_sRGB do not define the symbol GL_FRAMEBUFFER_SRGB.
Also use symbols defined by OES extensions where needed.
The #defines will be removed in a follow-up commit once 28334 has
been merged.
Change-Id: I1c4e5297c29ecf723463da7fbfe353628c4c35ef
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Kent Hansen [Wed, 15 Aug 2012 11:02:31 +0000 (13:02 +0200)]
Document QJSEngine's lack of exception handling API
Since we consider throwing non-Error values an edge case, we decided
not to add a an exception handling API (like
QScriptEngine::hasUncaughtException() or v8::TryCatch) yet.
Document this limitation in QJSEngine::evaluate().
Task-number: QTBUG-25857
Change-Id: I7f4869a152f176e613e3e8d2f81efeae198bd560
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Frederik Gladhorn [Tue, 14 Aug 2012 12:24:54 +0000 (14:24 +0200)]
Remove redundant QT_NO_ACCESSIBILTY.
The whole file is already ifdef'ed out.
Change-Id: I0456fcb8bd1440787aa5a16ca4c0c0234aea594c
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
Chris Adams [Wed, 25 Jul 2012 01:03:35 +0000 (11:03 +1000)]
Fix crash in signal change notification override
Manual overrides of automatically generated property change
notification signals can cause crashes. They also don't work
properly in the situations where they don't crash. This patch
ensures that it is now a compile error to attempt to override a
signal with a manual signal or slot.
Note that this includes signals defined in superclasses.
Task-number: QTBUG-26723
Task-number: QTBUG-26818
Change-Id: I4ecf448ce9de5d97526606126991e280debea2d6
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Alan Alpert [Thu, 16 Aug 2012 03:10:21 +0000 (13:10 +1000)]
Avoid overriding changed signal
This functionality is not officially supported and may break in the future.
Change-Id: I35ec69a4fd91cbda2249046eec0b3bfb34805f50
Reviewed-by: Chris Adams <christopher.adams@nokia.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Bea Lam [Fri, 10 Aug 2012 04:40:52 +0000 (14:40 +1000)]
Move docs closer to the members that they document
This will make it easier to add docs for undocumented members in a
later change.
Includes some minor doc improvements.
Change-Id: I809e1382297af604f7cac3abd4fed4a8e4e55967
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Matthew Vogt [Thu, 9 Aug 2012 03:26:32 +0000 (13:26 +1000)]
Reduce memory consumption of source coordinates
Reduce memory consumption by storing source location coordinates
as 16-bit variables (in run-time structures). Also modify qmlmin
to restrict line lengths so that the column bound is not normally
exceeded.
Change-Id: I08605626ffbdf081b6da2aea1116bdfe24998572
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Stephen Kelly [Tue, 7 Aug 2012 08:54:39 +0000 (10:54 +0200)]
Remove the use of QWidgetStar from QtQml.
The enum value can be removed so that it can be replaced in functionality
with QMetaType::PointerToQObject. There is no advantage to QtDeclarative
knowing that a value is a QWidget pointer.
Change-Id: I14530132bc37fbb0dc55ba8aaa5bb68db0d87bad
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Frederik Gladhorn [Mon, 13 Aug 2012 20:08:26 +0000 (22:08 +0200)]
Fix build with QT_NO_ACCESSIBILITY.
Change-Id: I52e4f54e0308d9fef4b9a19586d3e2ff696f0a5b
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Frederik Gladhorn [Mon, 13 Aug 2012 13:07:46 +0000 (15:07 +0200)]
Only build accessibility test when a11y is enabled.
Change-Id: I4f3012801b2775c75cf84b640c7a9821a6b21075
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
Gunnar Sletta [Mon, 30 Jul 2012 09:09:23 +0000 (11:09 +0200)]
Three scene graph examples with docs.
How to make a custom QSGGeometry, how to use QSGSimpleMaterial and how
to use render with raw GL.
Change-Id: I3e5a32b6ae12d7d781c11050ed26a54845e92cca
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Stephen Kelly [Fri, 3 Aug 2012 13:36:12 +0000 (15:36 +0200)]
Fix the dependencies of QQuickTest.
It consists of only one public method whose API only depends on QtCore headers.
Make everything else 'private' in the sense of what is communicated by the
buildsystem.
Task-number: QTBUG-26753
Change-Id: Id9d78339173c8f3f733103325c6593b8960a0585
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Oswald Buddenhagen [Tue, 7 Aug 2012 17:34:44 +0000 (19:34 +0200)]
make use of QT_PRIVATE to specify private Qt dependencies
Change-Id: Ia6bf273ff8ed63e13ea9f5c469b5f8e2702a4ee7
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Oswald Buddenhagen [Tue, 7 Aug 2012 17:08:54 +0000 (19:08 +0200)]
follow rename of qt_module_config.prf to qt_module.prf
Change-Id: I8a13b3aca195b9e8331478d73cd338ab66d65d1f
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>