Zoltan Varga [Sat, 28 Jan 2023 01:41:56 +0000 (20:41 -0500)]
[mono][jit] Improve handling of the ldtoken+ltoken+Type::op_Equal optimization. (#81277)
Previously, only comparisons with gshared types were handled, but if gsharing
is disabled, its possible to run into cases where both ldtoken calls product
a concrete type.
Andrew Au [Fri, 27 Jan 2023 23:43:56 +0000 (15:43 -0800)]
Fix x86 clrgc loading (#81176)
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Miha Zupan [Fri, 27 Jan 2023 23:04:39 +0000 (15:04 -0800)]
Reduce the size of HttpRequestMessage and HttpRequestHeaders (#81251)
* Reduce the size of HttpRequestMessage and HttpRequestHeaders
* Assert that the request message can't transition from Disposed to non-Disposed
Ankit Jain [Fri, 27 Jan 2023 22:56:38 +0000 (17:56 -0500)]
[wasm] Pin the sdk version to avoid a regression (#81301)
.. in manifest ordering in `IncludedWorkloadManifests.txt` caused by
https://github.com/dotnet/installer/pull/15346/commits/
717f422202f5fb3494e8f79f96e3a27e83fc72c0
, which the workload causing relinking to break in WBT.
The version with the bug is : 8.0.100-alpha.1.23077.4
Michal Strehovský [Fri, 27 Jan 2023 21:55:33 +0000 (06:55 +0900)]
Revert "Fix generic parameter data flow validation in NativeAOT (#80956)" (#81259)
This reverts commit
aa5e31310ef892995e7832f30acf8d78bfd0f5c2.
Pavel Savara [Fri, 27 Jan 2023 21:32:00 +0000 (22:32 +0100)]
[browser][MT] conditional revert of wasm imports optimization (#81275)
* conditional revert of https://github.com/dotnet/runtime/pull/79466
* feedback
Jakob Botsch Nielsen [Fri, 27 Jan 2023 20:52:04 +0000 (21:52 +0100)]
JIT: Switch tailcall implicit byref optimization to use last use information (#81033)
The last use information is more general in most cases (for example, the
old logic cannot allow the optimization when there are previous field
writes to the implicit byref). In addition the old logic can interact
with the new last-use copy elision optimization in an incorrect way.
Fix #81019
Tanner Gooding [Fri, 27 Jan 2023 20:46:26 +0000 (12:46 -0800)]
Change the default loop unroll limit to 4 (#80353)
* Change the default loop unroll limit to 4
* Remove verification testing for two complex tests involving both loop unrolling and large amounts of dead code elimination
Tanner Gooding [Fri, 27 Jan 2023 20:46:04 +0000 (12:46 -0800)]
Ensure various scalar cross platform helper APIs are handled directly as intrinsic (#80789)
* Ensure various scalar cross platform helper APIs are handled directly as intrinsic
* Small refactoring to lookupNamedIntrinsic and impIntrinsic to improve TP
Buyaa Namnan [Fri, 27 Jan 2023 20:35:56 +0000 (12:35 -0800)]
Make System.Reflection.Emit public types abstract (#78544)
* Add abstract AssemblyBuilder
* Create managed RuntimeAssemblyBuilder
* Add RuntimeAssemblyBuilder to the build
* Boilerplate for RuntimeAssemblyBuilder
* Emit Assembly record
* Fixups after rebase
* Add temporary ReflectionEmitLoadContext
* Factor out RuntimeModuleBuilder
* Abstract TypeBuilder and EventBuilder
* Refactor PropertyBuilder
* Refactor EnumBuilder
* Refactor FieldBuilder
* Refactor ConstructorBuilder and MethodBuilder
* Move suppressions into the common file
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sven Boemer [Fri, 27 Jan 2023 20:31:02 +0000 (12:31 -0800)]
Target lower glibc for Linux arm64 (#80939)
This uses new cross-build images that target Ubuntu 16.04,
lowering the glibc requirements. The initial change is only for
Linux arm64, to match what we plan to do in .NET 7. The 8.0
change will let us validate the PGO instrumentation, which
happens in official builds, but not in PR jobs.
Sandro Bollhalder [Fri, 27 Jan 2023 20:24:05 +0000 (21:24 +0100)]
Add MemoryExtensions.Count (#80662)
* Add MemoryExtensions.Count
* add test cases
* fix implementation
* fix review comments part I
* more tests
* return 0 if value is Empty
* Address PR feedback
---------
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Andrew Au [Fri, 27 Jan 2023 20:10:51 +0000 (12:10 -0800)]
Make sure we specify arguments only when the test ask for it (#80947)
Andrew Au [Fri, 27 Jan 2023 20:06:58 +0000 (12:06 -0800)]
Avoid using a null heap to decommit the mark array (#80640)
Radek Doulik [Fri, 27 Jan 2023 19:12:54 +0000 (20:12 +0100)]
[wasm] Force partial trim mode for browser bench (#81284)
Before we fix json [de]serialization to work with full trim
Andy Ayers [Fri, 27 Jan 2023 19:08:30 +0000 (11:08 -0800)]
JIT: update `fgReplaceJumpTarget` to maintain pred lists (#81246)
This is used some early phases; make it pred list aware.
Contributes to #80193.
Miha Zupan [Fri, 27 Jan 2023 18:43:06 +0000 (10:43 -0800)]
Avoid allocations in 'Transfer-Encoding: Chunked' check (#81253)
Stephen Toub [Fri, 27 Jan 2023 18:15:27 +0000 (13:15 -0500)]
Use IndexOf in StringBuilder.Replace(string, string, ...) (#81098)
* Use IndexOf in StringBuilder.Replace
StringBuilder.Replace(string, string, ...) currently walks character-by-character to find the next location of the oldValue. This change adds the use of MemoryExtensions.IndexOf to search for the oldValue, and only falls back to the character-by-character walk when it nears and needs to account for a chunk boundary. It also switches to track replacement indices using more stack space and the array pool (via ValueListBuilder) rather than less stack space and array allocations.
* Fix faulty assert
dotnet-maestro[bot] [Fri, 27 Jan 2023 17:45:17 +0000 (11:45 -0600)]
Update dependencies from https://github.com/dotnet/arcade build
20230126.1 (#81263)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23075.2 -> To Version 8.0.0-beta.23076.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Pavel Ivanov [Fri, 27 Jan 2023 17:43:20 +0000 (22:43 +0500)]
Disposed change token registration should not raise consumer (#79966)
Youssef Victor [Fri, 27 Jan 2023 15:53:39 +0000 (17:53 +0200)]
Update analyzers.md (#79768)
* Update analyzers.md
* Apply suggestions from code review
* Update analyzers.md
* Apply suggestions from code review
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Apply suggestions from code review
---------
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Miizukii [Fri, 27 Jan 2023 15:51:06 +0000 (16:51 +0100)]
Fixed CA1854 occurrences (#80996)
Steve Pfister [Fri, 27 Jan 2023 15:50:14 +0000 (10:50 -0500)]
[mono] Re-enable System.Threading.Tasks tests for desktop interp (#81046)
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Andy Ayers [Fri, 27 Jan 2023 15:46:13 +0000 (07:46 -0800)]
JIT: consolidate inlining code in fgInline.cpp (#81198)
When I reorganized and split up the flowgraph.cpp a while back I created
fgInline.cpp to hold all the inlining related methods, but didn't move
the inlining related methods from morph.cpp. Now I am moving them.
Austin Wise [Fri, 27 Jan 2023 15:26:52 +0000 (07:26 -0800)]
[NativeAOT] Objective-C exception propagation (#80334)
* [NativeAOT] Objective-C exception interception
* Fix Windows build
* Add back UnwoundReversePInvoke flag after re-initing.
* Switch to preemptive mode before jumping to propagation callback
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fix windows AMD64 offsets.
Vlad Brezae [Fri, 27 Jan 2023 14:26:56 +0000 (16:26 +0200)]
[mono][interp] Reduce redundant moves with calls (#79905)
We were marking INTERP_LOCAL_FLAG_NO_CALL_ARGS for source vars of non calls. With further optimizations, the var could end up being used only for the call but we never unset the flag. Reuse the ref count data, which is kept updated following optimizations, to achieve same thing. If cprop is not run then we always duplicate the args, but this is an unused scenario.
Vlad Brezae [Fri, 27 Jan 2023 13:57:58 +0000 (15:57 +0200)]
[mono][interp] Fix type pushed by mkrefanytype (#81261)
This instruction pushes a RuntimeTypeHandle.
Zoltan Varga [Fri, 27 Jan 2023 13:25:34 +0000 (08:25 -0500)]
[mono][aot] Emit native-to-managed wrappers for [UnmanagedCallersOnly] methods in non-full aot mode as well. (#80918)
Stephen Toub [Fri, 27 Jan 2023 11:36:27 +0000 (06:36 -0500)]
Add additional bool-only ToFrozenDictionary/Set overloads (#81256)
API review decided to include additional overloads to enable only specifying the bool.
Antoine Martin [Fri, 27 Jan 2023 11:22:27 +0000 (06:22 -0500)]
Mono musl support (#76500)
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Fixes https://github.com/dotnet/runtime/issues/76805
Šimon Rozsíval [Fri, 27 Jan 2023 10:11:26 +0000 (11:11 +0100)]
Skip tests that need RemoteExecutor (#81231)
Eirik Tsarpalis [Fri, 27 Jan 2023 09:35:03 +0000 (09:35 +0000)]
Make a number of improvements to the System.Text.Json source generator (#81239)
* Ensure singleton JsonTypeInfo instances are preconfigured using JsonSerializerOptions.
* Fix indentation & whitespace issues in the source generator.
* Fix #76829.
* Fix nullability annotations in GetTypeInfo gen.
* Add clarifying comment.
* Add testing for types without metadata or fast-path generation.
Vlad Brezae [Fri, 27 Jan 2023 08:22:39 +0000 (10:22 +0200)]
[mono][interp] Add @kotlarmilos as code owner (#81209)
AndyJGraham [Fri, 27 Jan 2023 08:07:09 +0000 (08:07 +0000)]
Replace successive "ldr" and "str" instructions with "ldp" and "stp" (#77540)
* Replace successive "ldr" and "str" instructions with "ldp" and "stp"
This change serves to address the following four Github tickets:
1. ARM64: Optimize pair of "ldr reg, [fp]" to ldp #35130
2. ARM64: Optimize pair of "ldr reg, [reg]" to ldp #35132
3. ARM64: Optimize pair of "str reg, [reg]" to stp #35133
4. ARM64: Optimize pair of "str reg, [fp]" to stp #35134
A technique was employed that involved detecting an optimisation
opportunity as instruction sequences were being generated.
The optimised instruction was then generated on top of the previous
instruction, with no second instruction generated. Thus, there were no
changes to instruction group size at “emission time” and no changes to
jump instructions.
* No longer use a temporary buffer to build the optimized instruction.
* Addressed assorted review comments.
* Now optimizes ascending locations and decending locations with
consecutive STR and LDR instructions.
* Modification to remove last instructions.
* Ongoing improvements to remove previously-emitted instruction
during ldr / str optimization.
* Stopped optimization of consecutive instructions that straddled an instruction group boundary.
* Addressed code change requests in GitHub.
* Various fixes to ldp/stp optimization
Add code to update IP mappings when an instruction is removed.
* Delete unnecessary and incorrect assert
* Diagnostic change only, to confirm whether a theory is correct or
not when chasing an error.
* Revert "Diagnostic change only, to confirm whether a theory is correct or"
This reverts commit
4b0e51e87af44cbef5b9e643f9c5bf7aff48b548.
* Do not merge. Temporarily removed calls to
"codeGen->genIPmappingUpdateForRemovedInstruction()".
Also, corrected minor bug in instruction numbering
when removing instructions during optimization.
* Modifications to better update the IP mapping table for a replaced instruction.
* Minor formatting change.
* Check for out of range offsets
* Don't optimise during prolog/epilog
* Fix windows build error
* IGF_HAS_REMOVED_INSTR is ARM64 only
* Add OptimizeLdrStr function
* Fix formatting
* Ensure local variables are tracked
* Don't peephole local variables
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
Co-authored-by: Alan Hayward <alan.hayward@arm.com>
Co-authored-by: Alan Hayward <a74nh@users.noreply.github.com>
Kunal Pathak [Fri, 27 Jan 2023 07:44:23 +0000 (23:44 -0800)]
Produce crashreport.json and use llvm-symbolizer to create stack trace (#77578)
* add DOTNET_EnableCrashReport
* Enable JitStress and JitStressRegs by default to see some test failures
* Enable stress switches only for JIT
* fix the build errors
* Revert "Set DNER for all local fields (#77341)"
This reverts commit
4e85471628214a3e6257132cadd8f7fd33299eb0.
* Set EnableCrashReport in testenvironment.proj
* Pass --crashReport to capture for hangs
* Comment bunch of jobs to trigger
* Comment all runs except Linux_x64
* Stop running libraries job
* Fix the tag in testenvironment.proj
* Use keepnativesymbols
* Update JitStress/JitStressRegs
* Embed native_image_offset field in crashreport.json
* Add TryPrintStackTraceFromCrashReport()
* Call TryPrintStackTraceFromCrashReport() even for crashes
* Add newtonsoft in CoreCLRTestLibrary.csproj
* Fix the crash dump folder
* Add random failure in jit
* Add some logging around TryPrintStackTraceFromCrashReport
* Move the error randomization to GetLayout() that has compiler object access
* Seach for crashreport.json files
* Switch to System.Text.Json
* fix the json path
* Add some logging
* Fix the clrjit symbols
* Add a comment
* Add few more commnets
* chown
* ls -l, chmod
* Change to chown
* USER environment variable
* update runtime.yml
* fix runtime.yml
* add logging
* Add llvm-symbolizer -h
* Skip superpmi pipelines
* read contents before process exit
* Add error output also
* fix some parameters for llvm-symbolizer
* Also enable OSX_x64 runs
* Remove the debugging code:
* Revert "Revert "Set DNER for all local fields (#77341)""
This reverts commit
5cfff119dbd8dd7a925a5db6fdb33f4f6487cb3a.
* Undo JIT changes to trigger assert
* Undo some yml changes
* Review feedback
* Undo runtime.yml changes
* Add some comments
* Address review feedback
Anton Lapounov [Fri, 27 Jan 2023 07:29:29 +0000 (23:29 -0800)]
Temporarily disable eventsourceerror test for Windows ARM32 (#81244)
Will Smith [Fri, 27 Jan 2023 03:43:27 +0000 (19:43 -0800)]
[JIT] - X64 - Peephole optimization to possibly skip emitting `and reg, -1` (#80468)
* Optimize 'x & -1' to a cast
* Check for small type
* Update gentree.cpp
* Use peephole optimization instead as it catches more cases
* Simplify logic
* Fix comment. Added test case.
* Update IntAnd.cs
* Check for set flags
* Check explicitly for TYP_INT
Adeel Mujahid [Fri, 27 Jan 2023 00:48:15 +0000 (02:48 +0200)]
Improve -static-pie support (#81163)
Dan Moseley [Fri, 27 Jan 2023 00:44:46 +0000 (17:44 -0700)]
Improve error for missing Python (#81202)
* add error
* Fix a case were missing VC components didn't error
* handle non empty stdout
* Remove self assignment
Stephen Toub [Thu, 26 Jan 2023 23:31:54 +0000 (18:31 -0500)]
Remove defensive Task[] copy from non-generic Task.WhenAll (#81065)
When calling it with a `Task[]` or `List<Task>`, we'll no longer generate a temporary array; the only allocation in those cases will be for the returned Task itself, at least if it completes successfully (if multiple of the constituent tasks fail or are canceled, we'll end up with an additional list allocation beyond what we had before). If you call it with an enumerable that's not an `ICollection<Task>`, we'll also save a `Task[]`.
Radek Doulik [Thu, 26 Jan 2023 23:02:13 +0000 (00:02 +0100)]
[wasm] Add Vector.Normalize measurement (#81237)
Andy Ayers [Thu, 26 Jan 2023 22:44:00 +0000 (14:44 -0800)]
JIT: build pred lists before patchpoint expansion (#81196)
Move pred list building 3 phases earlier. It now happens just after
instrumentation (or importation if we're not instrumenting) and just before
expanding patchpoints.
Revise the patchpoint, indirect call, and post importer cleanup phases
to do proper pred list maintenance.
Update the flow checker to handle cases we see when we haven't yet run
the post importer cleanup.
Contributes to #80193.
Stephen Toub [Thu, 26 Jan 2023 21:55:10 +0000 (16:55 -0500)]
Use RunContinuationsAsynchronously for block completion tasks (#81013)
* Use RunContinuationsAsynchronously for block completion tasks
* Tweak test
Co-authored-by: Petr Onderka <gsvick@gmail.com>
Tarek Mahmoud Sayed [Thu, 26 Jan 2023 20:50:40 +0000 (12:50 -0800)]
Fix Configuration Binding with Instantiated Objects (#81050)
Zoltan Varga [Thu, 26 Jan 2023 19:55:58 +0000 (14:55 -0500)]
[mono][wasm] Avoid saving the result of OP_AOTCONST into the gc pin area, its not needed. (#81179)
Jan Vorlicek [Thu, 26 Jan 2023 19:41:12 +0000 (20:41 +0100)]
Disable the /JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests (#81195)
* Disable the /JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests
Disable the test until a dotnet with a fix of the issue #81103 is used
in the runtime repo to build / run tests.
* Moving the disabling to crossgen2 specific section
Stephen Toub [Thu, 26 Jan 2023 19:23:25 +0000 (14:23 -0500)]
Fix a variety of issues in FrozenCollections (#81194)
- Add the new ToFrozenDictionary/Set methods that take optimizedForReading and make the existing overloads cheaper for construction. This makes construction time and allocation by default much closer to that of a normal dictionary or set while also enabling more of the implementation to be trimmed away by default.
- Fixed the use of FrozenSet/Dictionary.Empty such that we only use the singleton when its comparer matches; otherwise, we could end up handing back an instance with the wrong comparer.
- Avoided passing both a dictionary/set and a comparer down through constructors, as the dictionary/set contains the comparer and we don't want to accidentally end up in a situation where we pass through the wrong one.
- Condensed some of the construction code to be a bit less verbose
- Removed unused locals from ToFrozenDictionary (the min/max/range were no longer being used)
- Remove unnecessary array allocations from PickIntegerDictionary
- Delete the sparse range integer sets, which are rarely needed and are broken for TryGetValue
- Fix CheckUniqueAndUnfoundElements to slice down to only the relevant size prior to clearing
dotnet-maestro[bot] [Thu, 26 Jan 2023 19:14:43 +0000 (13:14 -0600)]
Update dependencies from https://github.com/dotnet/arcade build
20230125.2 (#81213)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23074.2 -> To Version 8.0.0-beta.23075.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 26 Jan 2023 19:14:17 +0000 (13:14 -0600)]
[main] Update dependencies from 9 repositories (#80916)
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230120.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23068.2 -> To Version 3.3.5-beta1.23070.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230120.1
Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100
From Version 8.0.0-alpha.1.23066.1 -> To Version 8.0.0-alpha.1.23070.1
* Update dependencies from https://github.com/dotnet/runtime build
20230122.5
Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-alpha.1.23065.5 -> To Version 8.0.0-alpha.1.23072.5
* Update dependencies from https://github.com/dotnet/llvm-project build
20230123.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.23066.1 -> To Version 1.0.0-alpha.1.23073.1
* Update Versions.props
fix previos merge
* Update dependencies from https://github.com/dotnet/icu build
20230123.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-alpha.1.23066.1 -> To Version 8.0.0-alpha.1.23073.1
* Update dependencies from https://github.com/dotnet/xharness build
20230123.2
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.23068.2 -> To Version 1.0.0-prerelease.23073.2
* Update dependencies from https://github.com/dotnet/runtime-assets build
20230123.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23066.2 -> To Version 8.0.0-beta.23073.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230123.2
Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100
From Version 8.0.0-alpha.1.23066.1 -> To Version 8.0.0-alpha.1.23073.2
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230123.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.1.0-alpha.0.23066.1 -> To Version 1.1.0-alpha.0.23073.1
* Update dependencies from https://github.com/dotnet/cecil build
20230123.1
Microsoft.DotNet.Cecil , Microsoft.DotNet.Cecil.Pdb
From Version 0.11.4-alpha.23067.1 -> To Version 0.11.4-alpha.23073.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20230124.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 14.0.0-alpha.1.23066.2 -> To Version 14.0.0-alpha.1.23074.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230124.3
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23068.2 -> To Version 3.3.5-beta1.23074.3
* Update dependencies from https://github.com/dotnet/icu build
20230126.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-alpha.1.23066.1 -> To Version 8.0.0-alpha.1.23076.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230126.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23068.2 -> To Version 3.3.5-beta1.23076.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Jan Vorlicek [Thu, 26 Jan 2023 16:17:33 +0000 (17:17 +0100)]
Fix max chunk size limiting (#81192)
When the new stub heaps were implemented, the chunk size needed to be
limited so that all precodes for a chunk fit into a single memory page.
That was done in `MethodDescChunk::CreateChunk`. But it was discovered
now that there is another place where it needs to be limited, the
`MethodTableBuilder::AllocAndInitMethodDescChunk`. The
JIT\opt\ObjectStackAllocation\ObjectStackAllocationTests started to fail
in the outerloop due to too long chunk. The failure happens in crossgen2
as it is using a separate build of runtime in release and only that
uncovers the problem. And only when DOTNET_TieredCompilation=0 and
DOTNET_ProfApi_RejitOnAttach=0.
This change fixes the problem. With this change applied to the dotnet
runtime version used by the crossgen2 and patching it in place in the
.dotnet/shared/.... directory, the issue doesn't occur.
Close #81103
Larry Ewing [Thu, 26 Jan 2023 15:43:28 +0000 (09:43 -0600)]
[mono] Fix missing simd mul/div case (#81201)
* Test missing case
* Update src/mono/mono/mini/simd-intrinsics.c
* Update src/mono/mono/mini/simd-intrinsics.c
Marek Fišera [Thu, 26 Jan 2023 14:31:13 +0000 (15:31 +0100)]
[wasm] Always allocate when computing temp file name (#81085)
The wasm implementation of __randname uses pointer address as another entry into the randomness.
Vlad Brezae [Thu, 26 Jan 2023 13:49:07 +0000 (15:49 +0200)]
[mono][interp] Extract code outside of interp main loop (#81208)
Stephen Toub [Thu, 26 Jan 2023 13:25:39 +0000 (08:25 -0500)]
Add SYSLIB* analyzers to global configs (#80930)
* Add SYSLIB* analyzers to global configs
* Address PR feedback
Tanner Gooding [Thu, 26 Jan 2023 10:17:57 +0000 (02:17 -0800)]
Add Lerp to IFloatingPointIeee754 (#81186)
* Add Lerp to IFloatingPointIeee754
* Add tests covering Lerp
* Fix build error
* Handle negative zero
Jan Vorlicek [Thu, 26 Jan 2023 09:34:16 +0000 (10:34 +0100)]
Fix GC interfaces versioning (#81188)
* Fix GC interfaces versioning
The change that introduced GC interfaces versioning had a bug preventing
it from using .NET 8 GC being used with .NET 7 runtime. The
GC_VersionInfo return value should have been the minimum supported
version, not the current one. But more importantly there was also
some confusion on what interface the GC_INTERFACE_MAJOR_VERSION
represents. While the change considered it to be a version of the
IGCToCLR interface, it really means the version of the IGCHeap
interface. This change creates a separate version,
EE_INTERFACE_MAJOR_VERSION for versioning o the IGCToCLR interface to
rectify that.
@Maoni0 also didn't like the way of creating a new version of
IGCToCLR interface for each major version change, so I am changing it to
single IGCToCLR interface.
* Fix version check at the call site of the LogErrorToHost
Michal Strehovský [Thu, 26 Jan 2023 09:30:29 +0000 (18:30 +0900)]
Fix CA2021 in MethodBodyScanner (#81200)
DeepakRajendrakumaran [Thu, 26 Jan 2023 07:47:24 +0000 (23:47 -0800)]
Updating JitInterface to support Vector512. (#81197)
* Auto-generated changes for adding Vector512 in JitInterface.
* Additional Interface Changes.
* Updating JITEEVersionIdentifier.
Aleksey Kliger (λgeek) [Thu, 26 Jan 2023 02:33:00 +0000 (21:33 -0500)]
BrowserDebugProxy: unify debug metadata reading for PE and Webcil (#81099)
* DebugStore: factor common PE and Webcil reading logic
* Move common logic to a MetadataDebugSummary class
Also switch from cascade of 'if's to a 'switch' when looking at debug entries
* Implement PDB checksum reader for WebcilReader
* Move WebcilReader reflection to a helper; add lazy initialization
Co-authored-by: Ankit Jain <radical@gmail.com>
dotnet-maestro[bot] [Thu, 26 Jan 2023 01:38:31 +0000 (19:38 -0600)]
Update dependencies from https://github.com/dotnet/arcade build
20230124.2 (#81161)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23073.10 -> To Version 8.0.0-beta.23074.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tanner Gooding [Thu, 26 Jan 2023 01:24:09 +0000 (17:24 -0800)]
Update the JIT to track `Span.Length` and `ReadOnlySpan.Length` as "never negative" (#81055)
* Update the JIT to track `Span.Length` and `ReadOnlySpan.Length` as "never negative"
* Updating the "is never negative" info to be tracked in LclVarDsc
* Apply formatting patch
* Ensure lvIsNeverNegative is propagated to shadows
* Update src/coreclr/jit/gentree.h
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
* Responding to PR feedback
* Adding two asserts
* Rename GenTreeField::IsNeverNegative to IsSpanLength and add a comment
* Fix an assert
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
Tomas Weinfurt [Wed, 25 Jan 2023 23:59:01 +0000 (15:59 -0800)]
avoid allocation of SelectClientCertificate delegate (#81096)
* avoid allocation of SelectClientCertificate delegate
* cleanup
Ilya Leoshkevich [Wed, 25 Jan 2023 23:38:15 +0000 (00:38 +0100)]
[mono] Build mono logging profiler on s390x (#72049)
At the moment we don't have too many profiling options on s390x, and
the logging profiler comes in handy. Enable building it on s390x and
define MONO_DLL_EXPORT in order to unhide mono_profiler_init_log().
Andy Gocke [Wed, 25 Jan 2023 23:30:51 +0000 (15:30 -0800)]
Change banana build to Release (#81127)
Works around https://github.com/dotnet/runtime/issues/79561
Michal Strehovský [Wed, 25 Jan 2023 23:30:16 +0000 (08:30 +0900)]
Beef up `WithoutFunctionPointerType` (#81147)
We don't have a `MethodTable` shape for function pointer types because how they should look like hasn't been defined until .NET 8.
Beef up the CoreCLR compat shim. We'll not be 100% compatible with this because `typeof(Tuple<delegate*<void>[]>)` doesn't actually load as `typeof(Tuple<IntPtr[]>)`, but this'll do until #71883.
Jan Vorlicek [Wed, 25 Jan 2023 21:58:39 +0000 (22:58 +0100)]
Fix PAL exception SXS test (#81169)
The test was failing in the outerloop CI testing because of a bug in the
test. One global variable that was modified by the main and checked by
the SIGSEGV handler was not marked as volatile.
Close #81113
Kunal Pathak [Wed, 25 Jan 2023 20:47:09 +0000 (12:47 -0800)]
Add missing case for upper save/restore (#81091)
* Add missing case for upper save/restore
* PR review feedback:
Ankit Jain [Wed, 25 Jan 2023 17:39:35 +0000 (12:39 -0500)]
[wasm] Disable ExceptionTests due to issue #81170, to get CI green (#81171)
Issue #81170
Jo Shields [Wed, 25 Jan 2023 17:37:05 +0000 (09:37 -0800)]
Allow forced building of mobile manifest pkgs, outside mobile builds (#80920)
Vitek Karas [Wed, 25 Jan 2023 16:34:17 +0000 (08:34 -0800)]
Fix generic parameter data flow validation in NativeAOT (#80956)
Previously generic data flow was done from generic dictionary nodes. Problem with that approach is that there's no origin information at that point. The warnings can't point to the place where the problematic instantiation is in the code - we only know that it exists.
Aside from it being unfriendly for the users, it means any RUC or suppressions don't work on these warnings the same way they do in linker/analyzer.
This change modifies the logic to tag the method as "needs data flow" whenever we spot an instantiation of an annotated generic in it somewhere.
Then the actualy validation/marking is done from data flow using the trim analysis patterns.
The only exception to this is generic data flow for base types and interface implementations, that one is done on the EEType nodes.
Note that AOT implements a much more precise version of the generic data flow validation as compared to linker/analyzer. See the big comment at the bening of GenericParameterWarningLocation.cs for how that works.
Changes the expected warning validation to use tokens to compare message origins (same reason as with Kept validation - consistently converting things to string is hard)
Adds a new dependency node with the generic type definition to the graph and then does analysis on that node.
This is to avoid potential noise warnings which could happen due to multiple instantiations calling the checking code multiple times. With this the check is done only once on the type definition.
Tweaked some tests to try to cover the multiple instances scenario.
LateApexEarlySpeed [Wed, 25 Jan 2023 16:17:52 +0000 (00:17 +0800)]
Add Utf8JsonWriter.WriteRawValue(System.Buffers.ReadOnlySequence). (#76444)
* Add Utf8JsonWriter.WriteRawValue(System.Buffers.ReadOnlySequence).
* Fix comment: remove TODO; rename GrowIfNeeded().
* Fix comment: consider ReadOnlySequence.Length >= int.Max.
* Make test case more generic for long typed length test data.
* Fix comment: add back TODO issue; checked cast long length to int at begin.
* Fix comment: revert checked cast long length.
Eirik Tsarpalis [Wed, 25 Jan 2023 16:17:15 +0000 (16:17 +0000)]
Ensure converter factories do not throw on unsupported types. (#81133)
* Ensure converter factories do not throw on unsupported types.
* Update src/libraries/System.Text.Json/tests/System.Text.Json.FSharp.Tests/UnionTests.fs
* Properly implement the Multi-dimensional array converter in tests.
Jakob Botsch Nielsen [Wed, 25 Jan 2023 08:05:29 +0000 (09:05 +0100)]
JIT: Fix tailcall-to-loop improper locals zeroing (#81083)
The zeroing that the tailcall-to-loop optimization does was zeroing the
promoted copies for implicit byrefs even when promotion of them was undone.
This was introducing unexpected references to the promoted fields.
Fix #81081
Viktor Hofer [Wed, 25 Jan 2023 07:18:21 +0000 (08:18 +0100)]
Re-enable ApiCompat ref<->src assembly validation (#81104)
* Re-eanble ApiCompat ref<->src assembly validation
* Fix API compatibility differences and update ApiCompat baseline
* Fix mono build
* Disable ApiCompat for linker
Radek Doulik [Wed, 25 Jan 2023 06:41:15 +0000 (07:41 +0100)]
[wasm] Enable Vector4.Dot (#81130)
* [wasm] Enable Vector4.Dot
We have all the pieces already in place
* fix condition
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Michal Strehovský [Wed, 25 Jan 2023 05:40:10 +0000 (14:40 +0900)]
Simplify getting full names for type loader purposes (#81069)
Michal Strehovský [Wed, 25 Jan 2023 05:39:42 +0000 (14:39 +0900)]
Avoid constraint validation (#81068)
Avoids bringing ConstructorInfo to simple apps.
Katelyn Gadd [Wed, 25 Jan 2023 02:34:16 +0000 (18:34 -0800)]
[wasm] Improve jiterpreter jit calls (#81071)
* Misc. cleanups and jiterpreter refactorings
* Optimize the ldloca + tnn.load pair in direct jit calls
* Fix argOffsets size calculation
* Turn stats back off
dotnet-maestro[bot] [Wed, 25 Jan 2023 02:26:21 +0000 (20:26 -0600)]
[main] Update dependencies from dotnet/arcade (#81079)
* Update dependencies from https://github.com/dotnet/arcade build
20230123.10
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23067.5 -> To Version 8.0.0-beta.23073.10
* Update tests.proj
In reaction to https://github.com/dotnet/arcade/commit/
20e5e15262b7666d9e7b22bdc7ec3fb3d5e67a8f
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
dotnet-maestro[bot] [Wed, 25 Jan 2023 02:19:05 +0000 (20:19 -0600)]
[main] Update dependencies from dotnet/roslyn (#80997)
* Update dependencies from https://github.com/dotnet/roslyn build
20230121.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.6.0-1.23070.10 -> To Version 4.6.0-1.23071.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230123.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.6.0-1.23070.10 -> To Version 4.6.0-1.23073.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Steve Pfister [Wed, 25 Jan 2023 01:50:34 +0000 (20:50 -0500)]
Move mono llvm fullaot runtime test leg to rolling build (#81125)
Since it takes quite a while to complete this leg, we should move it off of running every PR.
Addresses #65626
Carlos Sanchez [Wed, 25 Jan 2023 01:18:20 +0000 (17:18 -0800)]
Fix TarWriter.TarEntry exception when adding file whose Unix group owner does not exist in the system (#81070)
* Do not throw if a unix group is non-existent when creating a TarEntry from a file using TarWriter.
* Adjust test that was consuming removed interop method.
* Add unit tests to add file entry whose group owner does not exist.
* Address src feedback.
* Address test feedback
* Delay creation/deletion of group in test
* Test all PosixTarEntry formats
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Radek Doulik [Wed, 25 Jan 2023 00:38:58 +0000 (01:38 +0100)]
[wasm] Fix S.N.Vector4 related assert (#81126)
Fixes
error : Precompiling failed for /root/helix/work/workitem/e/wbt/blazorwasm_Release_aot_mv10loow.lgf/obj/Release/net8.0/wasm/for-publish/aot-in/aot-instances.dll with exit code 134. [/root/helix/work/workitem/e/wbt/blazorwasm_Release_aot_mv10loow.lgf/blazorwasm_Release_aot_mv10loow.lgf.csproj]
error : %6 = load %System.Numerics.Vector4.15073, %System.Numerics.Vector4.15073* %5, align 1 [/root/helix/work/workitem/e/wbt/blazorwasm_Release_aot_mv10loow.lgf/blazorwasm_Release_aot_mv10loow.lgf.csproj]
error : <4 x float> [/root/helix/work/workitem/e/wbt/blazorwasm_Release_aot_mv10loow.lgf/blazorwasm_Release_aot_mv10loow.lgf.csproj]
error : * Assertion: should not be reached at /__w/1/s/src/mono/mono/mini/mini-llvm.c:1455
where we were getting wrong llvm type for Vector4
Radek Doulik [Wed, 25 Jan 2023 00:37:17 +0000 (01:37 +0100)]
[wasm] Fix type check for PackedSimd.Splat (#81100)
The Splat's 1st parameter is not Vector128'1, but element type.
Fixes this assertion:
converting llvm method System.Runtime.Intrinsics.Vector128`1<sbyte> System.Runtime.Intrinsics.Wasm.PackedSimd:Splat (sbyte)
* Assertion at D:\git\wa-local\src\mono\mono\mini\simd-intrinsics.c:690, condition `vector_type->type == MONO_TYPE_GENERICINST' not met
Andy Ayers [Tue, 24 Jan 2023 23:24:10 +0000 (15:24 -0800)]
JIT: build pred lists before inlining (#81000)
Move pred list building up a bit further. Note that this impacts both the root
method and all inlinees, since we run a number of the initial phases on both.
Since inlinees build their basic blocks and flow edges in the root compiler's
memory pool, the only work required to unify the pred lists for a successful
inline is to get things right at the boundaries. And for failed inlines there
is no cross-referencing so we can just let the new pred lists leak away (like
we already do for the inlinee blocks).
Contributes towards #80193.
Egor Bogatov [Tue, 24 Jan 2023 21:04:32 +0000 (22:04 +0100)]
Disable eventsourceerror test (#81094)
Pavel Savara [Tue, 24 Jan 2023 20:52:27 +0000 (21:52 +0100)]
[browser] improve default initial memory size (#80507)
make EmccInitialHeapSize dynamic based on size of the assemblies and AOT DATA segments
Co-authored-by: Ankit Jain <radical@gmail.com>
Ankit Jain [Tue, 24 Jan 2023 20:45:30 +0000 (15:45 -0500)]
[wasm] ManagedToNativeGenerator: Skip unmanaged dlls (#81066)
* [wasm] ManagedToNativeGenerator: Skip unmanaged dlls
.. instead crashing with an exception like:
```
src/mono/wasm/build/WasmApp.Native.targets(296,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ManagedToNativeGenerator" task failed unexpectedly.
System.BadImageFormatException: This PE image is not a managed executable.
at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream)
at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath)
at PInvokeTableGenerator.Generate(String[] pinvokeModules, String[] assemblies, String outputPath) in /_/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42
at ManagedToNativeGenerator.ExecuteInternal() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 68
at ManagedToNativeGenerator.Execute() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 53
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
```
The wasm targets currently are not able to differentiate the managed
assemblies from the unmanaged ones. so it needs to be handled here.
* [wasm] WasmAppHost: Add support for host arguments
* Drop reallocation of managed dlls.
Co-authored-by: Marek Fišera <mara@neptuo.com>
Adeel Mujahid [Tue, 24 Jan 2023 18:52:48 +0000 (20:52 +0200)]
Fix a few static linking issues (#81086)
* Fix a few static linking issues
* Dedup paths
* Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Šimon Rozsíval [Tue, 24 Jan 2023 18:51:17 +0000 (19:51 +0100)]
[Android] Bump target SDK version in Android manifest (#80923)
* Set target SDK version
* Update Android docs
* Disable tests that do not pass with target API 31
* Check if the installed Android SDK is up-to-date
* Update skip explanation
* Use latest SDK
* Disable failing System.Net.Security test
Martin Taillefer [Tue, 24 Jan 2023 17:20:58 +0000 (09:20 -0800)]
Minor cleanup in frozen collection code (#81080)
Co-authored-by: Martin Taillefer <mataille@microsoft.com>
Will Smith [Tue, 24 Jan 2023 17:08:41 +0000 (09:08 -0800)]
Fixed assertion for targetType and op1 type not being the same (#81060)
Tomáš Rylek [Tue, 24 Jan 2023 16:00:43 +0000 (17:00 +0100)]
Fix publishing to Arcade when there are no merged tests in the set (#81054)
Egor Bogatov [Tue, 24 Jan 2023 15:54:43 +0000 (16:54 +0100)]
Optimize "new DateTime(<const args>)" via improvements in JIT VN (#81005)
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
Šimon Rozsíval [Tue, 24 Jan 2023 15:46:25 +0000 (16:46 +0100)]
[Android] Add option to skip generating apk for a specific project (#80909)
* Add option to skip generating apk for a specific project
* Replace _SkipAndroidGenerateAppBundle with AndroidGenerateAppBundle
Vlad Brezae [Tue, 24 Jan 2023 14:32:52 +0000 (16:32 +0200)]
[mono][interp] Remove dependence on svar/dvar when computing call offset (#81017)
* [mono][interp] Rename field to better reflect its content
* [mono][interp] Fix stack alignment
* [mono][interp] Move assertion to catch misalignment sooner
* [mono][interp] Remove dependence on svar/dvar when computing call offset
On optimized code, we made sure we always had a svar set, even if the call had no args. We then resolved the offset of the call as the offset of the first arg.
On unoptimized code, we made sure we always had a dvar set, even if the call has void return. We then resolved the offset of the call as the offset of the dvar. As we are introducing alignment guarantees of param area and, in the future, the dvar (only if it is simd type), the offset of the dvar and svar can end up with quite different offsets.
This commit solves these complications by introducing a call_offset field in the call info data, which represents the offset of the call args. This field is set either by the var offset allocator or on the fly, during compilation, in unoptimized case. The dvar offset is allocated independently and when emitting compacted instruction for calls, we do it now in an unified way between optimized and unoptimized compilation.
* Enable assertion temporarily for CI
Martin Taillefer [Tue, 24 Jan 2023 11:54:43 +0000 (03:54 -0800)]
Speed up frozen string dictionaries and sets by ~25-30% (#81021)
- Replace the specialized comparer types with specialized dictionary
and set types, to avoid virtual dispatch overhead and enable better
inlining.
Co-authored-by: Martin Taillefer <mataille@microsoft.com>
Jakob Botsch Nielsen [Tue, 24 Jan 2023 10:20:22 +0000 (11:20 +0100)]
JIT: Add Statement::m_treeListEnd (#81031)
Before this change statements have only one field for the "tree list"
even though bidirectional iteration is supported after nodes have been
linked. This worked fine before the locals tree list existed since the
"root node" was always the last node.
This does not work for the locals tree list since the "root node" is not
part of the list, meaning that we need somewhere else to store the
'last' node. Before this PR the assumption was that the root node was
_never_ part of the locals linked list, so we could use the
gtNext/gtPrev fields of the root node. However, the added test case
shows that in fact it is possible we end up with a top level local.
This PR fixes the problem by adding a Statement::m_treeListEnd field
that can keep the last node of the locals linked list. While this takes
some memory, it seems like the most maintainable way to resolve the
problem. I experimented with making the linked list circular or by
allocating a new stand-in node when necessary but eventually I ended up
here.
Fix #81018
Steve Pfister [Tue, 24 Jan 2023 09:16:33 +0000 (04:16 -0500)]
[iOS][Android] ActiveIssue SpanTests and Matrix4x4Tests that are failing on CI (#80877)
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Katelyn Gadd [Tue, 24 Jan 2023 06:33:57 +0000 (22:33 -0800)]
[wasm] Add direct jit calls to jiterpreter (#80968)
* Introduce 'direct jit call' mode where jiterpreter compiled trampolines invoke the target directly instead of using gsharedvt wrappers
* Fix jitcall target cache being keyed on the wrapper instead of the actual call target