reed [Sun, 13 Mar 2016 19:32:36 +0000 (12:32 -0700)]
more shader-->sp conversions
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789633002
Review URL: https://codereview.chromium.org/
1789633002
fmalita [Sun, 13 Mar 2016 16:46:16 +0000 (09:46 -0700)]
Avoid unneeded ref churn in SkDraw::drawVertices
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1790303002
Review URL: https://codereview.chromium.org/
1790303002
update-skps [Sun, 13 Mar 2016 08:29:52 +0000 (00:29 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1796503002
Review URL: https://codereview.chromium.org/
1796503002
halcanary [Sat, 12 Mar 2016 13:59:39 +0000 (05:59 -0800)]
SkPDF: move all pdf sources into src/pdf
also, consolidate XPS backend into src/xps
remove from include/ almost always a good thing.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781773002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1781773002
kulshin [Fri, 11 Mar 2016 23:26:46 +0000 (15:26 -0800)]
Revert "Initialize the font fallback when the direct write font"
This is apparently causing crashes and hangs in Chromium. Possible cause of 593858 and possible cause of 594047.
This reverts commit
042f859c19f71ca9feacddd1cb058ff59eed8963.
Conflicts:
src/ports/SkFontMgr_win_dw.cpp
Review URL: https://codereview.chromium.org/
1792473003
ericrk [Fri, 11 Mar 2016 23:18:20 +0000 (15:18 -0800)]
Fix BGRA/RGBA readback conversions on mac
Reading back from a BGRA framebuffer as RGBA or vis-versa is slow on mac. On my early 2013 MBP, we see a 40% regression when using
the discrete GPU or a 13% regression on integrated.
This change adds a workaround which causes Mac to use the existing Mesa path and prefer readback from the same format as the
framebuffer.
BUG=581311
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1786813002
Review URL: https://codereview.chromium.org/
1786813002
cdalton [Fri, 11 Mar 2016 22:07:38 +0000 (14:07 -0800)]
Add caps and GL API for buffer texture
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784063003
Review URL: https://codereview.chromium.org/
1784063003
cdalton [Fri, 11 Mar 2016 21:34:32 +0000 (13:34 -0800)]
Add sampler precision to GrTextureAccess
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784023002
Review URL: https://codereview.chromium.org/
1784023002
reed [Fri, 11 Mar 2016 21:02:28 +0000 (13:02 -0800)]
Make sp variants for SkData
Review URL: https://codereview.chromium.org/
1779263003
mtklein [Fri, 11 Mar 2016 20:59:09 +0000 (12:59 -0800)]
Revert of When not writing to file in DM, spew verbose output to stderr (patchset #1 id:1 of https://codereview.chromium.org/
1788743002/ )
Reason for revert:
Looks like not all the bots are using --writePath (think, Valgrind, *SAN) so this causes those bots to spew like crazy.
Looks like we need to find a more explicit way to make this mode work.
Original issue's description:
> When not writing to file in DM, spew verbose output to stderr
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788743002
>
> Committed: https://skia.googlesource.com/skia/+/
40dec542cc12b354762bca2c0d68bc419f0cbebd
TBR=egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1783603006
joshualitt [Fri, 11 Mar 2016 20:08:15 +0000 (12:08 -0800)]
Flush the pipe in skiaserve when we switch to GPU
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789723003
Review URL: https://codereview.chromium.org/
1789723003
joshualitt [Fri, 11 Mar 2016 19:45:53 +0000 (11:45 -0800)]
Fix up no gpu build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1787843002
Review URL: https://codereview.chromium.org/
1787843002
cdalton [Fri, 11 Mar 2016 18:07:37 +0000 (10:07 -0800)]
Add support for vertex and geometry shader textures
Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782583002
Review URL: https://codereview.chromium.org/
1782583002
msarett [Fri, 11 Mar 2016 17:24:20 +0000 (09:24 -0800)]
Update libjpeg-turbo with security fixes from upstream
This includes:
https://github.com/libjpeg-turbo/libjpeg-turbo/commit/
0463f7c9aad060fcd56e98d025ce16185279e2bc
https://github.com/libjpeg-turbo/libjpeg-turbo/commit/
a572622dd654305c86585724c2a1ea34e22c2103
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789693002
Review URL: https://codereview.chromium.org/
1789693002
yujieqin [Fri, 11 Mar 2016 15:32:33 +0000 (07:32 -0800)]
Rename the kRAW_SkEncodedFormat to kDNG_SkEncodedFormat as it is actually only used for DNG format
BUG=b/
27587823
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782913002
Review URL: https://codereview.chromium.org/
1782913002
egdaniel [Fri, 11 Mar 2016 15:14:49 +0000 (07:14 -0800)]
When not writing to file in DM, spew verbose output to stderr
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1788743002
Review URL: https://codereview.chromium.org/
1788743002
bsalomon [Fri, 11 Mar 2016 14:46:33 +0000 (06:46 -0800)]
Add deferred texture upload API.
Performs thread-safe decoding of SkImage in order to later create a texture-backed SkImage.
The client allocates storage for the data.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776693002
Review URL: https://codereview.chromium.org/
1776693002
bsalomon [Fri, 11 Mar 2016 14:22:00 +0000 (06:22 -0800)]
Reject dashes from GrAADFR
BUG=skia:5082
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784493004
Review URL: https://codereview.chromium.org/
1784493004
mtklein [Fri, 11 Mar 2016 14:10:30 +0000 (06:10 -0800)]
Revert of Use std::unique_ptr. (patchset #8 id:130001 of https://codereview.chromium.org/
1780933003/ )
Reason for revert:
Another Android ambiguity due to implicit bool...
frameworks/base/core/jni/android/graphics/Utils.cpp:110:35: error: call of overloaded 'SkMemoryStream(SkAutoTUnref<SkData>&)' is ambiguous
return new SkMemoryStream(data);
Original issue's description:
> Use std::unique_ptr.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
>
> Committed: https://skia.googlesource.com/skia/+/
3dd9ed37c24611af86f0fe374bd3698b63f09450
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1785353002
mtklein [Fri, 11 Mar 2016 13:18:48 +0000 (05:18 -0800)]
Use std::unique_ptr.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
Review URL: https://codereview.chromium.org/
1780933003
borenet [Fri, 11 Mar 2016 12:54:42 +0000 (04:54 -0800)]
Fixes for Win toolchain isolate
NOTRY=true
BUG=skia:4763, skia:4553
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782943002
Review URL: https://codereview.chromium.org/
1782943002
reed [Fri, 11 Mar 2016 12:33:52 +0000 (04:33 -0800)]
Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/
1778393002/ )"
Fix was to call get() instead of release() when passing the sp to a bare-ptr method.
This reverts commit
e683c56115a210b5993df9294260bb147b408bfa.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1789443002
TBR=
Review URL: https://codereview.chromium.org/
1789443002
benjaminwagner [Fri, 11 Mar 2016 12:33:44 +0000 (04:33 -0800)]
Ensure only fractional floats are converted to SkFixed in SubpixelAlignment.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1779083003
Review URL: https://codereview.chromium.org/
1779083003
robertphillips [Fri, 11 Mar 2016 00:18:46 +0000 (16:18 -0800)]
Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/
1778393002/ )
Reason for revert:
Experimental revert to try to clear up ASAN failures
Original issue's description:
> add Make variations to return SkImage by sk_sp
>
> some internal call-sites update, but not. Will follow-up in future to complete that.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778393002
>
> Committed: https://skia.googlesource.com/skia/+/
bd73ffb83022f1f6b1997e2a91c049949e88a8a2
TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1783063002
bungeman [Thu, 10 Mar 2016 21:39:30 +0000 (13:39 -0800)]
Add SkScalarTruncToScalar and speed up SkScalarFraction.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783583003
Review URL: https://codereview.chromium.org/
1783583003
bsalomon [Thu, 10 Mar 2016 21:38:21 +0000 (13:38 -0800)]
update site dox - windows prefer msvs-ninja and add vulkan
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785743003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1785743003
NOTREECHECKS=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/
1785743003
joshualitt [Thu, 10 Mar 2016 21:29:36 +0000 (13:29 -0800)]
Fix some bugs and performance issues with skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777203003
Review URL: https://codereview.chromium.org/
1777203003
reed [Thu, 10 Mar 2016 20:45:18 +0000 (12:45 -0800)]
add Make variations to return SkImage by sk_sp
some internal call-sites update, but not. Will follow-up in future to complete that.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778393002
Review URL: https://codereview.chromium.org/
1778393002
bsalomon [Thu, 10 Mar 2016 20:31:20 +0000 (12:31 -0800)]
Fix 32bit win Vulkan build
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781013002
Review URL: https://codereview.chromium.org/
1781013002
mtklein [Thu, 10 Mar 2016 19:31:27 +0000 (11:31 -0800)]
Revert of Use std::unique_ptr. (patchset #7 id:120001 of https://codereview.chromium.org/
1780933003/ )
Reason for revert:
Now we remember! The problem was Clank:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/34329
Original issue's description:
> Use std::unique_ptr.
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
20c1e3abfc681771f73eb19fde7284196e028940
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1782973002
fmalita [Thu, 10 Mar 2016 19:18:43 +0000 (11:18 -0800)]
Generic 4f gradient T sampler fallback
Add a generic T sampler fallback impl which uses T series produced by
subclasses mapTs() overrides. The fallback path uses the same interval
structures as the current optimized linear4f impl, but always sorted
in stop order (never inverted to match dx/increasing x order).
Enable the new mechanism for 4f linear w/ perspective.
Other boring changes:
* relocate the interval builder (back) to the base class
* add a private header for shared templates
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783823002
Review URL: https://codereview.chromium.org/
1783823002
bungeman [Thu, 10 Mar 2016 19:14:40 +0000 (11:14 -0800)]
Remove version checks for _MSC_VER < 1800 (msvs2013).
We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.
TBR=reed
No API changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777213003
Review URL: https://codereview.chromium.org/
1777213003
jvanverth [Thu, 10 Mar 2016 19:10:43 +0000 (11:10 -0800)]
Use correct gradient calculation for rotated distance fields.
For all uniform scaled matrices, we were using the y coordinate of the
y-direction gradient of the v texel space coordinate to scale the
distance values. The problem is, if you rotate by 90 degrees this value
becomes 0. The correct answer is to take the length of the y-direction
gradient.
BUG=skia:4864
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776383002
Review URL: https://codereview.chromium.org/
1776383002
halcanary [Thu, 10 Mar 2016 18:31:53 +0000 (10:31 -0800)]
DM: better SkDocument error message.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780253002
Review URL: https://codereview.chromium.org/
1780253002
mtklein [Thu, 10 Mar 2016 18:10:03 +0000 (10:10 -0800)]
Use std::unique_ptr.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1780933003
brianosman [Thu, 10 Mar 2016 17:47:56 +0000 (09:47 -0800)]
Remove anglesrgb config test - that config was removed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778413002
Review URL: https://codereview.chromium.org/
1778413002
mtklein [Thu, 10 Mar 2016 16:52:05 +0000 (08:52 -0800)]
exclude src/ports/*CG* for all targets
We were not excluding it from iOS builds, which fails including MobileCoreServices.h. (Odd!)
Also remove some redudant exclusions of src/ports/SkImageDecoder_CG.cpp, and sorts.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782903002
Review URL: https://codereview.chromium.org/
1782903002
mtklein [Thu, 10 Mar 2016 16:41:34 +0000 (08:41 -0800)]
Android NDK: r10e -> r11
I have tested that skia_lib builds with {gcc,clang} x {arm_v7_neon,arm64} on my Mac.
Bots seem happy.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780223002
Review URL: https://codereview.chromium.org/
1780223002
senorblanco [Thu, 10 Mar 2016 16:38:45 +0000 (08:38 -0800)]
GrTessellator: abstract vertex allocation into caller.
This abstracts all vertex allocation out of GrTessellator via a VertexBuffer interface. This removes all GPU-related calls from GrTessellator.
It also factors vertex drawing into GrTessellatingPathRenderer::drawVertices(), and makes tessellate() (now draw() also responsible for drawing. This means the cache hit case is clearer as an early-out,
and storing into cache is done in draw() as well.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776003002
Review URL: https://codereview.chromium.org/
1776003002
fmalita [Thu, 10 Mar 2016 16:09:51 +0000 (08:09 -0800)]
Fix GM:XfermodesBlur double unref
TBR=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785483004
Review URL: https://codereview.chromium.org/
1785483004
brianosman [Thu, 10 Mar 2016 15:49:08 +0000 (07:49 -0800)]
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with either FP16 linear or sRGB 8888 frambuffers).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1750383002
Committed: https://skia.googlesource.com/skia/+/
a6f58194733c1c50e4fe5f98585e42344f29b6f0
Review URL: https://codereview.chromium.org/
1750383002
bsalomon [Thu, 10 Mar 2016 15:22:25 +0000 (07:22 -0800)]
Fix readback of 565 on Mac and enable tests
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778143003
Review URL: https://codereview.chromium.org/
1778143003
msarett [Thu, 10 Mar 2016 15:15:59 +0000 (07:15 -0800)]
Do not compile CG on Google3 Linux/Android
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783553003
Review URL: https://codereview.chromium.org/
1783553003
borenet [Thu, 10 Mar 2016 15:01:39 +0000 (07:01 -0800)]
Add isolate_win_toolchain.py
Intended to be run manually by a developer on Windows.
Downloads the requested Windows toolchain, uploads it
to the isolate server, records the isolated hash in
the JSON file and uploads a CL to update that file.
BUG=skia:4553, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775073002
Review URL: https://codereview.chromium.org/
1775073002
robertphillips [Thu, 10 Mar 2016 14:56:21 +0000 (06:56 -0800)]
Update debugger to use SkPixmap
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782673003
Review URL: https://codereview.chromium.org/
1782673003
reed [Thu, 10 Mar 2016 14:36:49 +0000 (06:36 -0800)]
sk_sp versions of newWithColorFilter and newWithLocalMatrix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782703002
Review URL: https://codereview.chromium.org/
1782703002
borenet [Thu, 10 Mar 2016 13:49:48 +0000 (05:49 -0800)]
Move llvm from deps to deps_os
Re-upload of https://codereview.chromium.org/
1721943003/
TBR=bsalomon
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782793003
Review URL: https://codereview.chromium.org/
1782793003
msarett [Thu, 10 Mar 2016 13:44:43 +0000 (05:44 -0800)]
Update Skia's YUV API
We should match the recently designed API in SkCodec.
https://codereview.chromium.org/
1549473003/
This requires changes in Chromium as well.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1716523002
Committed: https://skia.googlesource.com/skia/+/
095d31c8a0eeb5d491febf064bc3c8a44e22b94f
Review URL: https://codereview.chromium.org/
1716523002
yujieqin [Thu, 10 Mar 2016 13:15:49 +0000 (05:15 -0800)]
Add a quick check to the TIFF header of DNG image
BUG=b/
27475341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782063002
Review URL: https://codereview.chromium.org/
1782063002
robertphillips [Thu, 10 Mar 2016 12:44:20 +0000 (04:44 -0800)]
Switch SkMergeImageFilter over to new onFilterImage interface
This relies on CL: https://codereview.chromium.org/
1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1763223002
Review URL: https://codereview.chromium.org/
1763223002
bsalomon [Thu, 10 Mar 2016 02:44:43 +0000 (18:44 -0800)]
Restore SkImage::NewTextureFromPixmap changes.
6ceeebd37a43d879c120b6ba100ae1febdd67a18 contained the fix for the issues that prompted the revert (index8 bitmaps weren't drawing).
Revert "TBR=robertphillips@google.com"
This reverts commit
236640872fa8cad105273055fdcf6829d5c025a1.
TBR=
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775263004
Review URL: https://codereview.chromium.org/
1775263004
reed [Wed, 9 Mar 2016 23:21:32 +0000 (15:21 -0800)]
un-restore test, as bug is not fixed
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1783633002
TBR=
Review URL: https://codereview.chromium.org/
1783633002
msarett [Wed, 9 Mar 2016 23:12:31 +0000 (15:12 -0800)]
Don't build CG on Linux CMake
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784663002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1784663002
joshualitt [Wed, 9 Mar 2016 23:07:01 +0000 (15:07 -0800)]
Create explicit microhttpd.gyp
Committed: https://skia.googlesource.com/skia/+/
80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1779903002
Review URL: https://codereview.chromium.org/
1779903002
bsalomon [Wed, 9 Mar 2016 22:50:15 +0000 (14:50 -0800)]
TBR=robertphillips@google.com
Revert "Add SkImage::NewTextureFromPixmap"
This reverts commit
045afea97902936869d71389e656a9c6917fa32f.
Revert "Fix Mac bots because of failing readback of 565"
This reverts commit
e344b26a7d3c0efaab21bb17fa5b2d96dfc92edf.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777863003
Review URL: https://codereview.chromium.org/
1777863003
reed [Wed, 9 Mar 2016 22:47:34 +0000 (14:47 -0800)]
SkImage now has makeShader to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785473002
Review URL: https://codereview.chromium.org/
1785473002
reed [Wed, 9 Mar 2016 22:26:26 +0000 (14:26 -0800)]
unify peekPixels around pixmap parameter
requires this chrome CL to land first
https://codereview.chromium.org/
1775393003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784563002
Review URL: https://codereview.chromium.org/
1784563002
joshualitt [Wed, 9 Mar 2016 22:26:15 +0000 (14:26 -0800)]
Revert of Create explicit microhttpd.gyp (patchset #6 id:100001 of https://codereview.chromium.org/
1779903002/ )
Reason for revert:
breaking per commit housekeeper
Original issue's description:
> Create explicit microhttpd.gyp
>
> Committed: https://skia.googlesource.com/skia/+/
80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
TBR=bungeman@google.com,jcgregorio@google.com,ethannicholas@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1781853002
msarett [Wed, 9 Mar 2016 22:20:58 +0000 (14:20 -0800)]
Add an SkImageGeneratorCG
This will serve as a replacement for SkImageDecoder_CG.
BUG=skia:4914
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1718273004
Review URL: https://codereview.chromium.org/
1718273004
joshualitt [Wed, 9 Mar 2016 22:19:37 +0000 (14:19 -0800)]
Add a bit more to the python test driver
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1773263002
Review URL: https://codereview.chromium.org/
1773263002
joshualitt [Wed, 9 Mar 2016 22:00:52 +0000 (14:00 -0800)]
Create explicit microhttpd.gyp
Review URL: https://codereview.chromium.org/
1779903002
yujieqin [Wed, 9 Mar 2016 21:49:36 +0000 (13:49 -0800)]
Limit the maximum buffer size of SkRawBufferedStream
BUG=b/
27475341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780643003
Review URL: https://codereview.chromium.org/
1780643003
Brian Salomon [Wed, 9 Mar 2016 21:27:49 +0000 (16:27 -0500)]
Fix Mac bots because of failing readback of 565
TBR=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784553003
Review URL: https://codereview.chromium.org/
1784553003 .
robertphillips [Wed, 9 Mar 2016 20:05:00 +0000 (12:05 -0800)]
Fix Windows clang compiler complaint
https://codereview.chromium.org/
1740533003 ( Initialize font fallback when creating DWrite font manager) seems to have broken the clang/win builds with:
..\..\third_party\skia\src\ports\SkFontMgr_win_dw.cpp(272,11) : error: field
'fLocaleName' will be initialized after field 'fFontFallback'
[-Werror,-Wreorder]
, fLocaleName(localeNameLength)
^
1 error generated.
I have also created skbug.com/5078 (Add Windows clang bot)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784533002
Review URL: https://codereview.chromium.org/
1784533002
bsalomon [Wed, 9 Mar 2016 19:31:18 +0000 (11:31 -0800)]
Add SkImage::NewTextureFromPixmap
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776913003
Review URL: https://codereview.chromium.org/
1776913003
halcanary [Wed, 9 Mar 2016 19:26:50 +0000 (11:26 -0800)]
experimental: coreGraphicsPdf2png
motivation: used for testing on my macbook.
TBR=
Review URL: https://codereview.chromium.org/
1131643004
halcanary [Wed, 9 Mar 2016 18:49:23 +0000 (10:49 -0800)]
SkPDF/Bench becnchmark new SkPDFUtils::FloatToDecimal function.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1735063004
Review URL: https://codereview.chromium.org/
1735063004
robertphillips [Wed, 9 Mar 2016 18:17:41 +0000 (10:17 -0800)]
Switch SkPaintImageFilter over to new onFilterImage interface
This CL relies on: https://codereview.chromium.org/
1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1761373002
Review URL: https://codereview.chromium.org/
1761373002
bungeman [Wed, 9 Mar 2016 18:12:06 +0000 (10:12 -0800)]
Fully specify libmicrohttpd.a path in build.
This is more uniform and also makes things work with the cmake gyp
generator.
Review URL: https://codereview.chromium.org/
1777573005
msarett [Wed, 9 Mar 2016 18:09:02 +0000 (10:09 -0800)]
Remove uses SkImageDecoder in imgblur and imgslice
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777753002
Review URL: https://codereview.chromium.org/
1777753002
joshualitt [Wed, 9 Mar 2016 18:07:02 +0000 (10:07 -0800)]
Fix up picture clip bounds in SkiaServe
BUG=skia:5067
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781653002
Review URL: https://codereview.chromium.org/
1781653002
jvanverth [Wed, 9 Mar 2016 17:57:52 +0000 (09:57 -0800)]
Fix some issues for Linux Vulkan build
lifecycle in GrVkGpu was tagged as uninitialized before use, and err in GrVkImage as unused.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782453004
Review URL: https://codereview.chromium.org/
1782453004
bsalomon [Wed, 9 Mar 2016 17:55:55 +0000 (09:55 -0800)]
Reenable dev bounds clip reduction
TBR=joshualitt@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1781663002
Review URL: https://codereview.chromium.org/
1781663002
bsalomon [Wed, 9 Mar 2016 17:52:45 +0000 (09:52 -0800)]
Fix nullptr access in GrTextureProvider::createMipMappedTexture
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777013002
Review URL: https://codereview.chromium.org/
1777013002
reed [Wed, 9 Mar 2016 17:50:50 +0000 (09:50 -0800)]
partial switch over to sp usage of shaders
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776973003
Review URL: https://codereview.chromium.org/
1776973003
robertphillips [Wed, 9 Mar 2016 16:37:23 +0000 (08:37 -0800)]
Revert of don't create zero length intervals (patchset #1 id:1 of https://codereview.chromium.org/
1766243004/ )
Reason for revert:
This may, or may not, be blocking the DEPS roll with:
svg/W3C-SVG-1.1/painting-stroke-04-t.svg
- LayoutSVGPath {path} at (50,127) size 380x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"]
+ LayoutSVGPath {path} at (60,127) size 370x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"]
Original issue's description:
> don't create zero length intervals
>
> Dashing a pattern without zero-length intervals should
> not create them if the end of the on interval coincides
> with the beginning of the initial dash offset.
>
> R=reed@google.com
> BUG=591993
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1766243004
>
> Committed: https://skia.googlesource.com/skia/+/
18bbd00190623fb6cdb119df4a118ac3c1aed52a
TBR=reed@google.com,fmalita@chromium.org,caryclark@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591993
Review URL: https://codereview.chromium.org/
1779803002
halcanary [Wed, 9 Mar 2016 15:52:09 +0000 (07:52 -0800)]
SkPDF: use sk_ref_sp
s/sk_sp<[^>]*>(SkRef(\([^)]*\)))/sk_ref_sp(\1)/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1777923002
Review URL: https://codereview.chromium.org/
1777923002
bungeman [Wed, 9 Mar 2016 15:42:54 +0000 (07:42 -0800)]
Add SkDrawPosTextHCommand JSON, fix skiaserve build.
Adds SkDrawPosTextHCommand ::fromJSON and ::toJSON.
Both SkDrawPosTextCommand and SkDrawPosTextHCommand's
::toJSON write the correct number of positions, preventing reading
uninitialized memory.
The microhttpd build is now done in the build tree as opposed to in a
temporary directory.
The microhttpd build script uses os.path.join so that absolute paths
do not confuse the build. This allows compatibility with the cmake
gyp generator as CMake likes to pass absolute paths.
The microhttpd gyp target is now marked as 'none' since it is not
a 'static_library' target (which directs gyp to compile sources into
a static library). The dependencies to the action are updated to the
minimum required for sane re-building.
The everything gyp target now depends on the skiaserve gyp target.
This means that when using skia_build_server=1, building 'most' will
build skiaserve, but when skia_build_server is not defined the
skiaserve target will still be available if specified manually.
The old json.gyp is removed as it currently does not build anything.
All of the files currently referenced by it as sources no longer exist.
Review URL: https://codereview.chromium.org/
1775203002
msarett [Wed, 9 Mar 2016 15:14:41 +0000 (07:14 -0800)]
Deprecate SkImageDecoder
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1776153003
Review URL: https://codereview.chromium.org/
1776153003
bsalomon [Wed, 9 Mar 2016 14:25:15 +0000 (06:25 -0800)]
Don't allow nullptr in texels array params (unless using a transfer buffer).
Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1765633002
Committed: https://skia.googlesource.com/skia/+/
8ee78f31b2a29a5f76403755ea17bad9be74a3ec
Review URL: https://codereview.chromium.org/
1765633002
msarett [Wed, 9 Mar 2016 14:16:55 +0000 (06:16 -0800)]
Remove usage of SkImageDecoder in debugger
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1774313003
Review URL: https://codereview.chromium.org/
1774313003
caryclark [Wed, 9 Mar 2016 13:55:53 +0000 (05:55 -0800)]
don't create zero length intervals
Dashing a pattern without zero-length intervals should
not create them if the end of the on interval coincides
with the beginning of the initial dash offset.
R=reed@google.com
BUG=591993
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1766243004
Review URL: https://codereview.chromium.org/
1766243004
robertphillips [Wed, 9 Mar 2016 13:17:10 +0000 (05:17 -0800)]
Switch SkImageSource image filter over to new onFilterImage interface
This CL relies on: https://codereview.chromium.org/
1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1772933002
Review URL: https://codereview.chromium.org/
1772933002
reed [Wed, 9 Mar 2016 02:50:00 +0000 (18:50 -0800)]
use Make instead of Create to return a shared shader
Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1772463002
Review URL: https://codereview.chromium.org/
1772463002
kulshin [Wed, 9 Mar 2016 01:30:05 +0000 (17:30 -0800)]
Initialize the font fallback when the direct write font
manager is created.
This ensures that the fallback is initialized prior to
sandbox startup in Chromium.
This enables the use of font fallback when combined with
Chromium change https://codereview.chromium.org/
1740593002/
Review URL: https://codereview.chromium.org/
1740533003
halcanary [Tue, 8 Mar 2016 23:10:16 +0000 (15:10 -0800)]
SkPDF: Add sk_sp setters; .release() becomes std::move()
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Committed: https://skia.googlesource.com/skia/+/
9904c9212074279380e21f96575078734dbbd308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775043002
Review URL: https://codereview.chromium.org/
1775043002
mtklein [Tue, 8 Mar 2016 21:25:42 +0000 (13:25 -0800)]
Revert of nanobench: turn on f16 and sRGB on the bots (patchset #1 id:1 of https://codereview.chromium.org/
1769163006/ )
Reason for revert:
Debug bots failing at
Running writepix_RGBA_UPM f16
../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr for config\"""
Original issue's description:
> nanobench: turn on f16 and sRGB on the bots
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1769163006
>
> Committed: https://skia.googlesource.com/skia/+/
6b5c5cc7b7bdffb4882706b915b544aba8714961
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1780463003
joshualitt [Tue, 8 Mar 2016 21:24:33 +0000 (13:24 -0800)]
Fix skiaserve in debug mode
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1774263002
Review URL: https://codereview.chromium.org/
1774263002
halcanary [Tue, 8 Mar 2016 21:03:55 +0000 (13:03 -0800)]
Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset #2 id:20001 of https://codereview.chromium.org/
1775043002/ )
Reason for revert:
https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio
Original issue's description:
> SkPDF: Add sk_sp setters; .release() becomes std::move()
>
> Note to reviewers: Start with changes to SkPDFTypes.h
>
> Many places that had a bare pointer owning a reference are refactored to
> use a sk_sp.
>
> There remain several places where a non-owning pointer `T*` should be
> replaced with `const sk_sp<T>&` to eliminate the common pattern
> `sk_sp<T>(SkRef(x))`.
>
> Committed: https://skia.googlesource.com/skia/+/
9904c9212074279380e21f96575078734dbbd308
TBR=bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1775143002
reed [Tue, 8 Mar 2016 20:54:48 +0000 (12:54 -0800)]
Add sk_ref_sp helper function.
Review URL: https://codereview.chromium.org/
1773943004
halcanary [Tue, 8 Mar 2016 20:38:22 +0000 (12:38 -0800)]
SkPDF: Add sk_sp setters; .release() becomes std::move()
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Review URL: https://codereview.chromium.org/
1775043002
mtklein [Tue, 8 Mar 2016 20:34:11 +0000 (12:34 -0800)]
nanobench: turn on f16 and sRGB on the bots
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1769163006
Review URL: https://codereview.chromium.org/
1769163006
egdaniel [Tue, 8 Mar 2016 20:19:54 +0000 (12:19 -0800)]
Fill out more information in GrVkCaps
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1768083003
Review URL: https://codereview.chromium.org/
1768083003
brianosman [Tue, 8 Mar 2016 20:15:09 +0000 (12:15 -0800)]
Remove SkImageGeneratorUtils. None of this code is used.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1778613002
Review URL: https://codereview.chromium.org/
1778613002
jvanverth [Tue, 8 Mar 2016 20:09:27 +0000 (12:09 -0800)]
Buffer fix for VkProgram caching
When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1774963003
Review URL: https://codereview.chromium.org/
1774963003
robertphillips [Tue, 8 Mar 2016 20:05:37 +0000 (12:05 -0800)]
Switch SkComposeImageFilter over to new onFilterImage interface
This CL depends on https://codereview.chromium.org/
1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1768283002
Review URL: https://codereview.chromium.org/
1768283002
bsalomon [Tue, 8 Mar 2016 19:53:31 +0000 (11:53 -0800)]
Expand coverage of vertices gm
Review URL: https://codereview.chromium.org/
1361173003
yujieqin [Tue, 8 Mar 2016 19:47:31 +0000 (11:47 -0800)]
Update DNG SDK version.
* Integrate integer overflow changes from security branch
BUG=b/
26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1748363004
Committed: https://skia.googlesource.com/skia/+/
be2924ad17d47f4ed49666894d87571a28f89567
Committed: https://skia.googlesource.com/skia/+/
62c0f75159674087079140e09ef1396316577754
Review URL: https://codereview.chromium.org/
1748363004
mtklein [Tue, 8 Mar 2016 19:31:11 +0000 (11:31 -0800)]
add f16 and srgb --configs to nanobench
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775093002
Review URL: https://codereview.chromium.org/
1775093002
aleksandar.stojiljkovic [Tue, 8 Mar 2016 19:18:21 +0000 (11:18 -0800)]
4377: drawVertices crashes when shader+colorfilter in the paint
Fix memory corruption that is result of static_casting SkFilterShaderContext*
to SkTriColorShaderContext* and then changing it's state using setup()
SkTriColorShader and it's Context could be wrapped by Compose, 3DShader and
SkFilterShader, but the link SkTriColorShaderContext -> SkTriColorShader
(fShader) always remain - so this way, data about triangle is propagated.
BUG=4377
Didn't add new unit test - it would be redundant since the GM vertices update here: https://codereview.chromium.org/
1361173003/ is covering the bug. With this patch it passes.
Review URL: https://codereview.chromium.org/
1431713003