abarth@webkit.org [Thu, 15 Mar 2012 00:10:30 +0000 (00:10 +0000)]
More fun with repainting-after-animation-element-removal. These
results differ by only one pixel.
* platform/chromium-linux/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 15 Mar 2012 00:10:02 +0000 (00:10 +0000)]
NRWT should respect --additional-platform-directory's Skipped list
https://bugs.webkit.org/show_bug.cgi?id=81172
Reviewed by Timothy Hatcher.
Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
from said path are already used, but the Skipped file is ignored.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_skipped_file_search_paths):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 15 Mar 2012 00:08:34 +0000 (00:08 +0000)]
[chromium] Fix a few more compositing baselines. Unreviewed.
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 15 Mar 2012 00:07:49 +0000 (00:07 +0000)]
Add some chromium-mac-leopard overrides for tests I rebaselined earlier.
* platform/chromium-mac-leopard/css2.1/
20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 00:06:07 +0000 (00:06 +0000)]
Run cacheFlush page by page to assure of flushing all the requested ranges
https://bugs.webkit.org/show_bug.cgi?id=77712
Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.
Current MetaAllocator concept, always coalesces adjacent free spaces,
doesn't meet memory management of Linux kernel.
In a certain case Linux kernel doesn't regard contiguous virtual memory areas as one but two.
Therefore cacheFlush page by page guarantees a flush-requested range.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 15 Mar 2012 00:02:54 +0000 (00:02 +0000)]
Add missing image baselines for new test added in <trac.webkit.org/changeset/110769>.
* platform/chromium-linux/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium-mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium-win/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 00:02:18 +0000 (00:02 +0000)]
Unreviewed, rolling out r110565.
http://trac.webkit.org/changeset/110565
https://bugs.webkit.org/show_bug.cgi?id=81173
chromium deps are now far enough along that the original cl
should work (Requested by thakis on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
* WebCore.gyp/mac/adjust_visibility.sh:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 15 Mar 2012 00:01:55 +0000 (00:01 +0000)]
Unreviewed, rolling out r110783.
http://trac.webkit.org/changeset/110783
https://bugs.webkit.org/show_bug.cgi?id=81054
Caused existing test expectation lines to expand to one for
each test configuration.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.has_warnings):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_macro_overrides):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._save_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_tests_to_update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 23:57:19 +0000 (23:57 +0000)]
Unreviewed, rolling out r110641.
http://trac.webkit.org/changeset/110641
https://bugs.webkit.org/show_bug.cgi?id=81170
Causes an ASAN failure (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
Source/WebCore:
* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.cpp:
* html/track/TextTrackList.idl:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 23:54:07 +0000 (23:54 +0000)]
[chromium] Unreviewed. Update many compositing baselines and expectations now that one major cause of flake is
fixed by r110741.
Filelist trimmed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 23:48:26 +0000 (23:48 +0000)]
Update chromium-mac-lion expectations after <trac.webkit.org/changeset/110763>.
* platform/chromium-mac/media/audio-repaint-expected.png: Added.
* platform/chromium-mac/media/audio-repaint-expected.txt: Added.
* platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Wed, 14 Mar 2012 23:41:04 +0000 (23:41 +0000)]
Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
https://bugs.webkit.org/show_bug.cgi?id=80922
<rdar://problem/
11035082>
Reviewed by Jian Li.
You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
new API. Therefore, APIs that are common between the two will have:
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
Source/WebCore:
* bindings/scripts/InFilesCompiler.pm: Update the script to handle the "|" flag in a conditional.
(preferredConditional):
(conditionalStringFromAttributeValue):
(generateInterfacesHeader):
(generateHeadersHeader):
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCore.exp.in:
* bindings/cpp/WebDOMEventTarget.cpp:
(toWebKit):
* bindings/js/JSDesktopNotificationsCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* dom/EventTargetFactory.in:
* notifications/Notification.cpp:
* notifications/Notification.h:
* notifications/Notification.idl:
* notifications/NotificationCenter.cpp:
* notifications/NotificationCenter.h:
* notifications/NotificationCenter.idl:
* notifications/NotificationContents.h:
* notifications/NotificationController.cpp:
* notifications/NotificationController.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:
* page/Frame.cpp:
(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
* workers/WorkerThread.h:
(WorkerThread):
Source/WebKit/blackberry:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/NotificationPresenterImpl.cpp:
* WebCoreSupport/NotificationPresenterImpl.h:
Source/WebKit/chromium:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* src/AssertMatchingEnums.cpp:
* src/NotificationPresenterImpl.cpp:
* src/NotificationPresenterImpl.h:
* src/WebNotification.cpp:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableNotifications):
(WebKit::WebRuntimeFeatures::isNotificationsEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/efl:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* WebCoreSupport/NotificationPresenterClientEfl.cpp:
* WebCoreSupport/NotificationPresenterClientEfl.h:
Source/WebKit/mac:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/WebNotificationClient.h:
* WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
* WebView/WebNotification.mm:
(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification replaceID]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):
* WebView/WebNotificationInternal.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/qt:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPage::setFeaturePermission):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::dumpNotification):
(DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore):
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::openerPageUrl):
(WebCore::NotificationWrapper::notificationClicked):
(WebCore::NotificationWrapper::notificationClosed):
* WebCoreSupport/NotificationPresenterClientQt.h:
(WebCore):
Source/WebKit/win:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
Source/WebKit/wince:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):
Source/WebKit2:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit):
(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit):
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):
* WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
* WebProcess/WebCoreSupport/WebNotificationClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetTestController):
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
(DRTDesktopNotificationPresenter::checkNotificationPermission):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 23:36:53 +0000 (23:36 +0000)]
Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054
Reviewed by Dirk Pranke.
This will allow us to use the All Failures tab in garden-o-matic
to rebaseline tests without making test_expectations.txt stale.
It's conservative and only removes lines if the test is
not flaky and fails in a way the rebaseline would fix (e.g.
CRASH/TIMEOUT will not be touched).
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._is_supported_port):
(RebaselineTest):
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 23:34:13 +0000 (23:34 +0000)]
Unreviewed, rolling out r110744.
http://trac.webkit.org/changeset/110744
https://bugs.webkit.org/show_bug.cgi?id=81168
Causes many WebAudio tests to crash in debug (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 23:29:08 +0000 (23:29 +0000)]
[Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class
https://bugs.webkit.org/show_bug.cgi?id=80627
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.
No impact to QML API.
* UIProcess/qt/QtDialogRunner.cpp:
(BaseAuthenticationContextObject):
(BaseAuthenticationContextObject::BaseAuthenticationContextObject):
(HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::realm):
(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(QtDialogRunner::initForAuthentication):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 23:27:17 +0000 (23:27 +0000)]
With tiled drawing enabled, clicking a link to a PDF causes a cross-fade
https://bugs.webkit.org/show_bug.cgi?id=79247
<rdar://problem/
10910808>
Reviewed by Sam Weinig.
Instead of creating a new CALayer for the WKView when we're in tiled mode, re-use the existing layer that AppKit makes for us.
This way, we won't get any implicit animations when we change layer properties (such as sublayers in this case).
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView wantsUpdateLayer]):
(-[WKView updateLayer]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 23:25:41 +0000 (23:25 +0000)]
[chromium] Unreviewed. Update a few compositing baselines for tests that were marked flaky.
* platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
* platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png:
* platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png:
* platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 23:21:07 +0000 (23:21 +0000)]
Promote a number of chromium-mac-snowleopard results to chromium-mac.
Also, fix a wrong chromium-mac-leopard expectation. (The new
expectation show the drop shadow, like other platforms.)
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Removed.
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/filtered-compositing-descendant-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 23:14:14 +0000 (23:14 +0000)]
Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
https://bugs.webkit.org/show_bug.cgi?id=81167
Reviewed by Sam Weinig.
Do not use 0 as a key in a HashMap.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Mar 2012 23:08:51 +0000 (23:08 +0000)]
<rdar://problem/
11045584> and https://bugs.webkit.org/show_bug.cgi?id=81166 Repro crash in compositing/iframes/page-cache-layer-tree.html
Reviewed by Sam Weinig.
No new tests. (Discovered from and covered by existing test)
ScriptCachedFrameData doesn't need to keep a DOMWindow:
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
* bindings/js/ScriptCachedFrameData.h:
(ScriptCachedFrameData):
CachedFrame should grab it off the Frame directly and store it locally:
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
* history/CachedFrame.h:
(WebCore::CachedFrameBase::domWindow):
(CachedFrameBase):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 23:01:05 +0000 (23:01 +0000)]
I've already updated the baselines for this test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 22:58:38 +0000 (22:58 +0000)]
Update baselines for a number of svg/repaint tests and for some
tables/mozilla tests. These results all appear to be correct.
* platform/chromium-linux-x86/tables/mozilla: Removed.
* platform/chromium-linux/svg/repaint/filter-repaint-expected.png: Added.
* platform/chromium-linux/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-mac/svg/repaint/image-href-change-expected.png: Added.
* platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
* platform/chromium-mac/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs: Removed.
* platform/chromium-win/svg/repaint/filter-repaint-expected.png: Added.
* platform/chromium-win/svg/repaint/filter-repaint-expected.txt: Added.
* platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* platform/chromium-win/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug86708-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Added.
* platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Removed.
* platform/mac/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 22:58:18 +0000 (22:58 +0000)]
[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523
Reviewed by Darin Fisher.
* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 14 Mar 2012 22:56:15 +0000 (22:56 +0000)]
fix negative flexing in auto sized columns
https://bugs.webkit.org/show_bug.cgi?id=80069
Reviewed by Ojan Vafai.
Source/WebCore:
New test cases in css3/flexbox/columns-auto-size.html.
* rendering/RenderFlexibleBox.cpp:
(WebCore):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Properly compute this for auto sizing columns. Previously, we would always return 0.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Drop an unnecessary check against undefined. isSpecified covers this for us.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
* css3/flexbox/columns-auto-size-expected.txt:
* css3/flexbox/columns-auto-size.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 22:44:28 +0000 (22:44 +0000)]
Update baselines for these URL tests. These tests exist to document
differnces in behavior between KURL and GURL.
* platform/chromium-linux/fast/url/file-http-base-expected.txt: Added.
* platform/chromium-linux/fast/url/segments-expected.txt:
* platform/chromium-linux/fast/url/segments-from-data-url-expected.txt:
* platform/chromium-win/fast/url/file-http-base-expected.txt: Added.
* platform/chromium-win/fast/url/segments-expected.txt:
* platform/chromium-win/fast/url/segments-from-data-url-expected.txt:
* platform/chromium/fast/url/anchor-expected.txt: Added.
* platform/chromium/fast/url/file-http-base-expected.txt: Added.
* platform/chromium/fast/url/ipv4-expected.txt: Added.
* platform/chromium/fast/url/segments-expected.txt: Added.
* platform/chromium/fast/url/segments-from-data-url-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 22:39:41 +0000 (22:39 +0000)]
These baselines all either look very similar to their expectations or
like improvements.
* platform/chromium-linux/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac-leopard/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac-leopard/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
* platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/mozilla-tests-expected.txt: Added.
* platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png:
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
* platform/chromium-mac/css1/text_properties/text_transform-expected.txt: Added.
* platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-win/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-win/fast/xsl/transform-xhr-doc-expected.txt: Removed.
* platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 22:24:38 +0000 (22:24 +0000)]
Incorrect handling of sizes in "em" when first-line changes font size
https://bugs.webkit.org/show_bug.cgi?id=79526
Patch by Grace Ku <gracek@codeaurora.org> on 2012-03-14
Reviewed by Eric Seidel.
Source/WebCore:
When a first-line pseudo class changes the font size, the "em" unit is handled incorrectly.
It uses the paragraph's original font size (the size of the rest of the paragraph) rather than
the font-size of the first-line of the paragraph.
This was corrected by checking if the InlineFlowBox was the first line using the existing
InlineFlowBox::isFirstLineStyle() function. The corrected behaviour matches Gecko and Presto.
Trident seems to get it half-wrong in the use case we are testing, painting the correct width for
the border but leaving the wrong amount of space.
The CSS specification doc at the time of this patch specifies that ':first-line' should only support
certain properties, though UAs may choose to apply more properties. Furthermore, the spec does not
define the exact rendering of all cases of ':first-line'. It notes that a more precise definition
may appear in future revisions.
Test: fast/css/pseudo-first-line-border-width.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
(WebCore::RenderBoxModelObject::borderObscuresBackground):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
LayoutTests:
Checks that the width of the left-border of the span is the desired 10px
rather than 100px. The expect file is somewhat misleading since the computed
border width is still printed as 100px. The true test is in the position of the
RenderText box beside the left-border.
* fast/css/pseudo-first-line-border-width.html: Added.
* fast/css/pseudo-first-line-border-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 22:17:36 +0000 (22:17 +0000)]
Update some compositing baselines. These look correct. They just differ in scrollbars, etc.
* platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
* platform/chromium-win/compositing/direct-image-compositing-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 22:13:59 +0000 (22:13 +0000)]
WebKitTestRunner needs layoutTestController.displayInvalidatedRegion
Add a test that uses it to the wk2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 22:06:25 +0000 (22:06 +0000)]
Add results for transforms/3d/general/background-visibility-layers.html.
* platform/chromium-mac/transforms/3d: Added.
* platform/chromium-mac/transforms/3d/general: Added.
* platform/chromium-mac/transforms/3d/general/background-visibility-layers-expected.png: Added.
* platform/chromium-win/transforms/3d/general: Added.
* platform/chromium-win/transforms/3d/general/background-visibility-layers-expected.png: Added.
* platform/chromium/transforms: Added.
* platform/chromium/transforms/3d: Added.
* platform/chromium/transforms/3d/general: Added.
* platform/chromium/transforms/3d/general/background-visibility-layers-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 14 Mar 2012 22:05:55 +0000 (22:05 +0000)]
Fix the TextureMapper build for GTK+.
No new tests. This is just a build fix.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/TextureMapper.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 22:05:07 +0000 (22:05 +0000)]
Display attribute for video controls changed from display:block
to display:-webkit-box. Tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=80727
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-14
Reviewed by Eric Carlson.
* platform/chromium-linux-x86/media/video-empty-source-expected.txt:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.txt:
* platform/chromium-mac-leopard/media/audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/audio-repaint-expected.png: Added.
* platform/chromium-mac/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/audio-repaint-expected.txt.
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
* platform/chromium-mac/media/controls-strict-expected.png: Added.
* platform/chromium-mac/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-strict-expected.txt.
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.png: Added.
* platform/chromium-mac/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt.
* platform/chromium-mac/media/media-controls-clone-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt.
* platform/chromium-mac/media/video-controls-rendering-expected.png: Added.
* platform/chromium-mac/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt.
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-playing-and-pause-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.png: Added.
* platform/chromium-mac/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt.
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-win-vista/media/video-empty-source-expected.txt:
* platform/chromium-win-xp/media/video-empty-source-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/audio-repaint-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-controls-clone-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-playing-and-pause-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 14 Mar 2012 22:04:50 +0000 (22:04 +0000)]
[GTK] Menulist buttons have separators even when the theme turns them off
https://bugs.webkit.org/show_bug.cgi?id=80668
Reviewed by Daniel Bates.
No new tests. GTK+ theme differences are notoriously difficult
to test, because consistent results depend on having certain themes
and certain versions of themes installed.
Instead of using the GTK_TYPE_BUTTON and GTK_TYPE_SEPARATOR tags to get the
style context, use GTK_TYPE_COMBO_BOX which should provide more accurate theme settings.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::getComboBoxMetrics): Get metrics from a GTK_TYPE_COMBO_BOX style context.
(WebCore::RenderThemeGtk::paintMenuList): Get separator settings from the GTK_TYPE_COMBO_BOX style context.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 14 Mar 2012 22:02:00 +0000 (22:02 +0000)]
Implement proper sub-pixel support in RenderFileUploadControl
https://bugs.webkit.org/show_bug.cgi?id=80881
Reviewed by Dimitri Glazkov.
Correcting improper usage of LayoutUnits when interacting with the graphics context
and platform code. Specifically:
- pixel snapping the clip rect and paint offsets before sending values to the
graphics context in paintObject.
- using on-screen (pixel snapped) values to pass off to platform code to determine
the max length of the filename to be drawn.
No new tests. No change in behavior.
* rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 21:56:46 +0000 (21:56 +0000)]
[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
https://bugs.webkit.org/show_bug.cgi?id=81082
Source/WebCore:
Don't return an invalid JSValue. Check if the ScriptValue
has no value and return undefined in that case.
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.
Updated test: inspector/console/command-line-api.html
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):
LayoutTests:
Test for an undefined inspectedObject.
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.
* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 14 Mar 2012 21:43:20 +0000 (21:43 +0000)]
[chromium] Unreviewed, mark two compositing tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=75568
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 21:42:28 +0000 (21:42 +0000)]
[chromium] Remove canRecoverFromContextLoss attribute, it's unused
https://bugs.webkit.org/show_bug.cgi?id=81158
Reviewed by Stephen White.
Source/WebCore:
Canvas accelerated no longer depends on the canRecoverFromContextLoss attribute after r110716.
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::get):
Source/WebKit/chromium:
Deletes the canRecoverFromContextLoss attribute from WebCore::GraphicsContext3D::Attributes. This is still left in
WebGraphicsContext3D::Attributes, since chromium-side code still references it.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 14 Mar 2012 21:34:23 +0000 (21:34 +0000)]
Opening a URL in a MediaDocument does not propagate MIME type info to media element
https://bugs.webkit.org/show_bug.cgi?id=81148
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/media-document.html
Pass through the mime type from the DocumentLoader into the <source type=""> attribute of the
generated video element.
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
LayoutTests:
* http/tests/media/media-document-expected.txt: Added.
* http/tests/media/media-document.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 14 Mar 2012 21:27:48 +0000 (21:27 +0000)]
[chromium] Fix accelerated Canvas2D with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=80998
Reviewed by James Robinson.
Source/WebCore:
Covered by unit tests Canvas2DLayerChromiumTest and
TreeSynchronizerTest.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore):
Delay creation of the front texture for double-buffering until the
first call to paintContentsIfDirty().
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
Remove setTextureManager() and setLayerTreeHost(), since their job
has been subsumed by paintContentsIfDirty().
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
Perform an early-out if the passed-in layer is NULL.
Source/WebKit/chromium:
* tests/Canvas2DLayerChromiumTest.cpp:
Instantiate a CCLayerTreeHost, so that Canvas2DLayerChromium can
retrieve its texture manager. Also move the test into the unnamed
namespace -- since it's already using WebCore, there's little reason for
it to also be in the namespace.
* tests/TreeSynchronizerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):
Add a new test for trying to synchronize NULL tree.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 14 Mar 2012 21:21:42 +0000 (21:21 +0000)]
Make ARMv7 work again
https://bugs.webkit.org/show_bug.cgi?id=81157
Reviewed by Geoffrey Garen.
We were trying to use the ARMv7 dataRegister as a scratch register in a scenario
where we the ARMv7MacroAssembler would also try to use dataRegister for its own
nefarious purposes.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::store32):
* assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Wed, 14 Mar 2012 21:20:56 +0000 (21:20 +0000)]
IndexedDB layout tests: factor out prefix-handling-code
https://bugs.webkit.org/show_bug.cgi?id=80664
This makes our tests vendor neutral so that we can load them in any
browser to check what that browser does.
Also changed some instances of 'window' to 'self' so that they are more
worker friendly.
Reviewed by Tony Chang.
* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-shared-workers-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required.html:
* storage/indexeddb/createObjectStore-null-name-expected.txt:
* storage/indexeddb/createObjectStore-null-name.html:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue.html:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-key-order.html:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-primary-key-order.html:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-reverse-bug.html:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required.html:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-basics.html:
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/database-name-undefined.html:
* storage/indexeddb/database-odd-names-expected.txt:
* storage/indexeddb/database-odd-names.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/delete-closed-database-object.html:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/delete-range.html:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/deleteIndex.html:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required.html:
* storage/indexeddb/deleteObjectStore-null-name-expected.txt:
* storage/indexeddb/deleteObjectStore-null-name.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/factory-basics.html:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-count.html:
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/index-get-key-argument-required.html:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-multientry.html:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/index-population.html:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/invalid-keys.html:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-generator.html:
* storage/indexeddb/key-sort-order-across-types-expected.txt:
* storage/indexeddb/key-sort-order-across-types.html:
* storage/indexeddb/key-sort-order-date-expected.txt:
* storage/indexeddb/key-sort-order-date.html:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array.html:
* storage/indexeddb/key-type-infinity-expected.txt:
* storage/indexeddb/key-type-infinity.html:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-basics.html:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-edges.html:
* storage/indexeddb/keypath-fetch-key-expected.txt:
* storage/indexeddb/keypath-fetch-key.html:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange-required-arguments-expected.txt:
* storage/indexeddb/keyrange-required-arguments.html:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/list-ordering.html:
* storage/indexeddb/mozilla/add-twice-failure-expected.txt:
* storage/indexeddb/mozilla/add-twice-failure.html:
* storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
* storage/indexeddb/mozilla/autoincrement-indexes.html:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/clear.html:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-index-unique.html:
* storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
* storage/indexeddb/mozilla/create-index-with-integer-keys.html:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics.html:
* storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-null-name.html:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
* storage/indexeddb/mozilla/cursor-mutation.html:
* storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
* storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/cursors.html:
* storage/indexeddb/mozilla/delete-result-expected.txt:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/mozilla/event-source-expected.txt:
* storage/indexeddb/mozilla/event-source.html:
* storage/indexeddb/mozilla/global-data-expected.txt:
* storage/indexeddb/mozilla/global-data.html:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/indexes.html:
* storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
* storage/indexeddb/mozilla/key-requirements-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key.html:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key.html:
* storage/indexeddb/mozilla/key-requirements.html:
* storage/indexeddb/mozilla/object-cursors-expected.txt:
* storage/indexeddb/mozilla/object-cursors.html:
* storage/indexeddb/mozilla/object-identity-expected.txt:
* storage/indexeddb/mozilla/object-identity.html:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/object-store-remove-values.html:
* storage/indexeddb/mozilla/objectstorenames-expected.txt:
* storage/indexeddb/mozilla/objectstorenames.html:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/odd-result-order.html:
* storage/indexeddb/mozilla/open-database-null-name-expected.txt:
* storage/indexeddb/mozilla/open-database-null-name.html:
* storage/indexeddb/mozilla/put-get-values-expected.txt:
* storage/indexeddb/mozilla/put-get-values.html:
* storage/indexeddb/mozilla/readonly-transactions-expected.txt:
* storage/indexeddb/mozilla/readonly-transactions.html:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions.html:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/readyState.html:
* storage/indexeddb/mozilla/remove-index-expected.txt:
* storage/indexeddb/mozilla/remove-index.html:
* storage/indexeddb/mozilla/remove-objectstore-expected.txt:
* storage/indexeddb/mozilla/remove-objectstore.html:
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/mozilla/versionchange-abort.html:
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mozilla/versionchange.html:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectStore-required-arguments.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-count.html:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/odd-strings.html:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/open-close-version.html:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/open-during-transaction.html:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071.html:
* storage/indexeddb/queued-commands-expected.txt:
* storage/indexeddb/queued-commands.html:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/readonly-properties.html:
* storage/indexeddb/readonly.html:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/index-basics.js:
(test):
* storage/indexeddb/resources/objectstore-basics.js:
(test):
(setVersionSuccess):
(createIndex):
(addData):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
* storage/indexeddb/resources/shared.js:
(removeVendorPrefixes):
* storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
* storage/indexeddb/setVersion-null-expected.txt:
* storage/indexeddb/setVersion-null.html:
* storage/indexeddb/setVersion-undefined-expected.txt:
* storage/indexeddb/setVersion-undefined.html:
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/set_version_blocked.html:
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/set_version_queue.html:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort-workers-expected.txt:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/transaction-rollback.html:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/transaction-storeNames-required.html:
* storage/indexeddb/two-version-changes-expected.txt:
* storage/indexeddb/two-version-changes.html:
* storage/indexeddb/value-undefined-expected.txt:
* storage/indexeddb/value-undefined.html:
* storage/indexeddb/values-odd-types-expected.txt:
* storage/indexeddb/values-odd-types.html:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-abort.html:
* storage/indexeddb/version-change-exclusive-expected.txt:
* storage/indexeddb/version-change-exclusive.html:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 21:20:51 +0000 (21:20 +0000)]
Move EntriesCallback to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81032
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-14
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/filesystem/EntriesCallback.h: Copied from Source/WebCore/fileapi/EntriesCallback.h.
* Modules/filesystem/EntriesCallback.idl: Copied from Source/WebCore/fileapi/EntriesCallback.idl.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/EntriesCallback.h: Removed.
* fileapi/EntriesCallback.idl: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 14 Mar 2012 21:14:16 +0000 (21:14 +0000)]
Heap::destroy leaks CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=81055
Reviewed by Geoffrey Garen.
Added a destroy() function to CopiedSpace that moves all normal size
CopiedBlocks from the CopiedSpace to the Heap's list of free blocks
as well as deallocates all of the oversize blocks in the CopiedSpace.
This function is now called in Heap::destroy().
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::destroy):
(JSC):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/Heap.cpp:
(JSC::Heap::destroy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 14 Mar 2012 21:10:24 +0000 (21:10 +0000)]
multiline column flexbox with auto height wrap too much
https://bugs.webkit.org/show_bug.cgi?id=80929
Reviewed by David Hyatt.
Source/WebCore:
Test: css3/flexbox/multiline-column-auto.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore):
(WebCore::RenderBox::computeContentLogicalHeightUsing): Pull out into a separate method.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::lineBreakLength): Compute the value based on height & max-height for column layout.
(WebCore):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
* css3/flexbox/multiline-column-auto-expected.txt: Added.
* css3/flexbox/multiline-column-auto.html: Added.
* css3/flexbox/multiline-shrink-to-fit-expected.html:
* css3/flexbox/multiline-shrink-to-fit.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 21:04:37 +0000 (21:04 +0000)]
Unreviewed, rolling out r110559.
http://trac.webkit.org/changeset/110559
https://bugs.webkit.org/show_bug.cgi?id=81142
Broke Dromaeo tests (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
* Dromaeo/resources/dromaeorunner.js:
(.):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 21:04:25 +0000 (21:04 +0000)]
PeerConnection was renamed to DeprecatedPeerConnection in r110587. Update the expected
results.
The rebaseline landed for Qt in 110685 should actually have been landed for all ports.
Land it for all ports, and remove the Qt specific expected results.
* fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/qt/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 21:01:37 +0000 (21:01 +0000)]
Optimize the multiply-add in Biquad.cpp::process
https://bugs.webkit.org/show_bug.cgi?id=75528
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-14
Reviewed by Chris Rogers.
Pipeline the multiply-add with SSE2 instructions and get about 20% improvement for the function.
* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 14 Mar 2012 20:59:53 +0000 (20:59 +0000)]
WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitProvisionalLoad after running regression tests
https://bugs.webkit.org/show_bug.cgi?id=81150
<rdar://problem/
11002254>
Reviewed by Anders Carlsson.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
It's not great, but for now we need to handle this case. Hopefully, some day we'll make
both WebKit2 processes better aware of what's going on with loading in WebCore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 20:57:36 +0000 (20:57 +0000)]
Clean up a few more baseline.
* platform/chromium-mac-snowleopard/css2.1/
20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates: Removed.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 20:52:42 +0000 (20:52 +0000)]
[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=79823
Reviewed by Adrienne Walker.
Source/WebCore:
LayerRendererChromium was storing a weak pointer to the current render surface in m_currentRenderSurface and
using this in useRenderSurface() to avoid rebinding if we called useRenderSurface() multiple times in a row on
the same surface. This pointer was never cleared, so if any subsequent surface landed at the same address this
caching would misbehave and we'd fail to correctly initialize the new render surface. The caching wasn't
actually buying us anything anyway since we only call useRenderSurface() once per surface per frame and we
always set the viewport for the default render surface.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 20:38:09 +0000 (20:38 +0000)]
WKTR doesn't have an implemenation of hasSpellingMarker yet.
Add more tests that rely on it to the WK2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 20:30:16 +0000 (20:30 +0000)]
Add the chromium lion bot to garden-o-matic and remove
the platform_move_to in builders.py since the Chromium Lion
port is now a normal port.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* Scripts/webkitpy/layout_tests/port/builders.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 20:22:55 +0000 (20:22 +0000)]
Frame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
https://bugs.webkit.org/show_bug.cgi?id=80155
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.
Source/WebCore:
This patch ensures that an iframe only schedules and calls parent's layout,
when it is going to be flattened. Non-flattened iframe does not affect
parent's layout, so normal layout flow applies. isInSubframeLayoutWithFrameFlattening()
function has been added to test whether a particular child frame is changing
parent's layout. This function also ensures that scheduleRelayout() and layout()
are in sync of checking againts frame flattening.
Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html
* page/FrameView.cpp:
(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
(FrameView):
* rendering/RenderIFrame.h:
(RenderIFrame):
(WebCore::RenderIFrame::renderName):
LayoutTests:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout-expected.txt: Added.
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 20:07:42 +0000 (20:07 +0000)]
Don't cap the scroll position if layout happens when a FrameView's overhangAmount is non-zero
https://bugs.webkit.org/show_bug.cgi?id=81146
<rdar://problem/
10850075>
Reviewed by Beth Dakin.
If layout happens when a page has a non-zero overhang amount, we shouldn't cap the scroll position
to be inside of the valid maximum/minimum scroll offsets because that will cause the page to jump back, which
can look really bad if layout happens in response to the page being scrolled.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 19:58:02 +0000 (19:58 +0000)]
Add Lion failures in order to green the lion bot.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tommyw@google.com [Wed, 14 Mar 2012 19:53:23 +0000 (19:53 +0000)]
MediaStream API (JSEP): Introducing IceCandidate
https://bugs.webkit.org/show_bug.cgi?id=80699
Reviewed by Adam Barth.
Patch #2 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the JS object IceCandidate and its WebCore/platform sibling IceCandidateDescriptor.
This object will be created both from JS and the embedder.
Not possible to test until the entire JSEP feature is commited.
* GNUmakefile.list.am:
* Modules/mediastream/IceCandidate.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidate::create):
(WebCore::IceCandidate::IceCandidate):
(WebCore::IceCandidate::~IceCandidate):
(WebCore::IceCandidate::label):
(WebCore::IceCandidate::candidateLine):
(WebCore::IceCandidate::toSdp):
(WebCore::IceCandidate::descriptor):
* Modules/mediastream/IceCandidate.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidate):
* Modules/mediastream/IceCandidate.idl: Added.
* WebCore.gypi:
* platform/mediastream/IceCandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidateDescriptor::create):
(WebCore::IceCandidateDescriptor::IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::~IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::toSdp):
* platform/mediastream/IceCandidateDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::label):
(WebCore::IceCandidateDescriptor::candidateLine):
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSdp):
(WebCore):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamCenter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 19:51:26 +0000 (19:51 +0000)]
Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
Unreviewed, build fix.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_tests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 14 Mar 2012 19:50:28 +0000 (19:50 +0000)]
background-visibility:hidden should create a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=81134
Source/WebCore:
Reviewed by Dean Jackson.
Background-visibility:hidden has to create RenderLayers, because it's implemented
via compositing and/or paint short-circuiting in RenderLayer code.
Test: transforms/3d/general/background-visibility-layers.html
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasHiddenBackface):
* rendering/RenderTableRow.h:
LayoutTests:
Reviewed by Dean Jackson.
Test for background-visibility: hidden making a RenderLayer.
* transforms/3d/general/background-visibility-layers-actual.png: Added.
* transforms/3d/general/background-visibility-layers-actual.txt: Added.
* transforms/3d/general/background-visibility-layers.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 19:48:06 +0000 (19:48 +0000)]
[CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882
Patch by Raul Hudea <rhudea@adobe.com> on 2012-03-14
Reviewed by David Hyatt.
Source/WebCore:
Adding the regionLayoutEvent that is dispatch for all regions after each flow-thread layout.
Tests: fast/regions/region-event-add-to-flow.html
fast/regions/region-event-remove-from-dom.html
fast/regions/region-event-remove-from-flow.html
fast/regions/region-event.html
* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Added check for regionLayoutUpdate listeners
* dom/Document.h:
* dom/EventNames.h:
(WebCore):
* dom/Node.cpp:
(WebCore::Node::dispatchRegionLayoutUpdateEvent):
(WebCore):
* dom/Node.h:
(Node):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): Start the event dispatch timer but only if there are regionLayoutUpdate listeners and there is at least one region that had its layout updated.
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Mark regions that might had a layout update
(WebCore::RenderFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setDispatchRegionLayoutUpdateEvent):
(WebCore::RenderRegion::shouldDispatchRegionLayoutUpdateEvent):
(RenderRegion):
LayoutTests:
* fast/regions/region-event-add-to-flow-expected.txt: Added.
* fast/regions/region-event-add-to-flow.html: Added.
* fast/regions/region-event-expected.txt: Added.
* fast/regions/region-event-remove-from-dom-expected.txt: Added.
* fast/regions/region-event-remove-from-dom.html: Added.
* fast/regions/region-event-remove-from-flow-expected.txt: Added.
* fast/regions/region-event-remove-from-flow.html: Added.
* fast/regions/region-event.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Wed, 14 Mar 2012 19:45:31 +0000 (19:45 +0000)]
[Qt] Add support for vertical sliders in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=80179
This makes sliders using the "slider-vertical" appearance more sensible.
Reviewed by Simon Hausmann.
No new tests, since the mobile theme still isn't used in layout tests.
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
* platform/qt/RenderThemeQtMobile.h:
(StylePainterMobile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 19:30:54 +0000 (19:30 +0000)]
Rebaseline chromium-lion tests that have "MISSING" results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 19:26:11 +0000 (19:26 +0000)]
Fix UI process crash when a plug-in process crashes with a modal dialog showing
https://bugs.webkit.org/show_bug.cgi?id=81139
<rdar://problem/9641197>
Reviewed by Dan Bernstein.
When a plug-in process crashes, its corresponding PluginProcessProxy object is deleted immediately,
which is bad if we're currently running a nested run loop.
Fix this by making PluginProcessProxy ref-counted and protecting it before the call to -[NSApp runModalForWindow:].
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginProcessWithPath):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
* UIProcess/Plugins/PluginProcessManager.h:
(PluginProcessManager):
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
* UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::beginModal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 14 Mar 2012 19:24:19 +0000 (19:24 +0000)]
WebProcess spins beneath [QTMovie movieFileTypes:]
https://bugs.webkit.org/show_bug.cgi?id=81133
Reviewed by Eric Carlson.
No new tests; speculative fix for top WebProcess spin.
When checking to see if a given mime type is supported by QuickTime,
immediately exclude all types that do not begin with 'audio/' or 'video/'.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::supportsType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 19:10:47 +0000 (19:10 +0000)]
Update SVG baseline after work on <use> element. These results all
seem to be minor differences or progressions.
* platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 18:55:58 +0000 (18:55 +0000)]
Please add a way to manually skip some tests in NRWT
https://bugs.webkit.org/show_bug.cgi?id=81019
Reviewed by Ojan Vafai.
This patch implements the -i / --ignore-tests flag from ORWT
and refactors the test_expectations.py code slightly to handle
it.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_ignore_tests):
(MainTest.test_ignore_tests.assert_ignored):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 18:53:34 +0000 (18:53 +0000)]
nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
https://bugs.webkit.org/show_bug.cgi?id=81028
Reviewed by Ojan Vafai.
The mac port had incorrect lookups for 'mac-lion' and
'mac-future' in some places. This patch fixes that and adds a
bunch of tests.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.baseline_path):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.assert_skipped_file_search_paths):
(MacTest.test_skipped_file_search_paths):
(_assert_search_path):
(test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_file_search_paths):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 18:37:37 +0000 (18:37 +0000)]
WK2: Spelling tests that rely on getting the marked range or the marked count synchronously fail
https://bugs.webkit.org/show_bug.cgi?id=81138
Add some expected failing results for such tests to get the bots green.
* platform/mac-wk2/editing/spelling/markers-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-insert-html-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 14 Mar 2012 18:33:16 +0000 (18:33 +0000)]
[Chromium] Unreviewed, remove expectations for non-crashing tests
https://bugs.webkit.org/show_bug.cgi?id=78038
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 18:29:32 +0000 (18:29 +0000)]
Make RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
https://bugs.webkit.org/show_bug.cgi?id=80301
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.
Reorganize RenderIFrame flattenFrame() code, so that it returns
earlier for the normal use case, when frame flattening is disabled.
It also removes leftover null check.
No new tests, since there's no new functionality.
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 18:12:29 +0000 (18:12 +0000)]
[chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=80667
Reviewed by Darin Fisher.
Source/WebCore:
Query the platform to see if we can instantiate a context suitable for accelerating 2d canvas. If we can't, for
instance if we're on a system that can't preserve a context when the screensaver comes up, then immediately fall
back to software.
Covered by canvas layout tests in the virtual-gpu mode.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::canAccelerate2dCanvas):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 18:03:01 +0000 (18:03 +0000)]
Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552
https://bugs.webkit.org/show_bug.cgi?id=69946
Add some tests that use eventSender.dragMode to the WK2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 14 Mar 2012 17:56:59 +0000 (17:56 +0000)]
[GTK] Handle printing errors in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=77197
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
* platform/gtk/ErrorsGtk.cpp:
(WebCore::printError): Create a generic print error.
(WebCore::printerNotFoundError): Create a print error to notify
that the selected printer could not be found.
(WebCore::invalidPageRangeToPrint): Create a print error when the
selected page range is invalid and there are no pages to print.
* platform/gtk/ErrorsGtk.h:
(WebCore): Add print error doamin.
Source/WebKit2:
* UIProcess/API/gtk/WebKitError.cpp:
(webkit_print_error_quark): Add new error domain for print
errors.
* UIProcess/API/gtk/WebKitError.h: Ad print errors.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init): Add
WebKitPrintOperation::failed signal.
(drawPagesForPrintingCompleted): Emit WebKitPrintOperation::failed
when the print operation failed with the given error.
(webkitPrintOperationPrintPagesForFrame): Use
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrint):
(testPrintOperationErrors): Test different print errors are
correctly reported.
(beforeAll):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate print finished callbacks
map.
(WebKit::WebPageProxy::printFinishedCallback): Callback called
when the print operation has finished in the web process.
(WebKit::WebPageProxy::processDidCrash): Invalidate print finished
callbacks map.
(WebKit::WebPageProxy::drawPagesForPrinting): Use a
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/WebPageProxy.h:
(WebKit): Delcare PrintFinishedCallback as a generic callback.
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in: Use PrintFinishedCallback
instead of VoidCallback as callback argument of
DrawPagesForPrinting message.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Mark the data as invalid
when there are no pages to print.
(PrintPagesData): Add isValid parameter to mark the data struct as
invalid.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Call
printPagesDone() instead of printDone().
(WebKit::WebPrintOperationGtk::printPagesDone): Renamed.
(WebKit::WebPrintOperationGtk::printDone): Notify the UI process
that the print operation has finsihed.
(WebKit::WebPrintOperationGtk::print): Finish the print if the
PrintPagesData struct is not valid.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 17:32:27 +0000 (17:32 +0000)]
[EFL] Enable HTML5 Summary and Details elements
https://bugs.webkit.org/show_bug.cgi?id=81027
Enabling Summary and Details elements by default and removing related
tests from skip list since they should pass now.
.:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
LayoutTests:
Tests expectations from Ubuntu 11.10 using EFL from SVN. Hopefully the
same as the build bot.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
* platform/efl/fast/html/details-add-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-nested-1-expected.txt: Added.
* platform/efl/fast/html/details-nested-2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary1-expected.txt: Added.
* platform/efl/fast/html/details-no-summary2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary3-expected.txt: Added.
* platform/efl/fast/html/details-no-summary4-expected.txt: Added.
* platform/efl/fast/html/details-open-javascript-expected.txt: Added.
* platform/efl/fast/html/details-open1-expected.txt: Added.
* platform/efl/fast/html/details-open2-expected.txt: Added.
* platform/efl/fast/html/details-open3-expected.txt: Added.
* platform/efl/fast/html/details-open4-expected.txt: Added.
* platform/efl/fast/html/details-open5-expected.txt: Added.
* platform/efl/fast/html/details-open6-expected.txt: Added.
* platform/efl/fast/html/details-position-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/efl/fast/html/details-replace-text-expected.txt: Added.
* platform/efl/fast/html/details-writing-mode-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 17:05:06 +0000 (17:05 +0000)]
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-14
Reviewed by Rob Buis.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::isActive):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(WebKit):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
* Api/BackingStore.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::toWebCoreMouseEventType):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 14 Mar 2012 16:59:16 +0000 (16:59 +0000)]
Make SVGUseElement respect & support externalResourcesRequired
https://bugs.webkit.org/show_bug.cgi?id=81109
Reviewed by Rob Buis.
Source/WebCore:
Generalize the existing externalResourcesRequired support from SVGScriptElement
into SVGExternalResourcesRequired, so it can be shared with SVGUseElement, which
was lacking proper externalResourcesRequired support.
<use xlink:href="external.svg" onload="alert('hi')" externalResourcesRequired="true"/>
The onload handler now fires _after_ the external resources loaded, making it possible
to write reliable tests that switch from internal to external resources or the other
way around. Converted the new tests in svg/dynamic-updates/SVGUseElement* to listen
to SVGLoad events, to make them reliable.
We may be able to generalize this to cover SVGImageElement as well (the only other class which
is currently supporting externalResourcesRequired - but that's more involved, so I left it TODO).
Covered by existing tests and the changes to the new SVGUseElement tests.
* svg/SVGElement.h:
(SVGElement): Make haveLoadedRequiredResources() public so SVGExternalResourcesRequired can call it.
* svg/SVGExternalResourcesRequired.cpp: Refactored code from SVGScriptElement, 1:1 copies w/o changes.
(WebCore::SVGExternalResourcesRequired::handleAttributeChange):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent):
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
(WebCore::SVGExternalResourcesRequired::finishParsingChildren):
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources):
* svg/SVGExternalResourcesRequired.h: Add new virtual functions, that must be available in classes that inherit from SVGExternalResourcesRequired.
(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent):
(WebCore::SVGExternalResourcesRequired::isParserInserted):
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent):
* svg/SVGScriptElement.cpp: Refactored externalResourcesRequired handling into SVGExternalResourcesRequired.
(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::finishParsingChildren):
* svg/SVGScriptElement.h: Ditto.
(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::setHaveFiredLoadEvent):
(WebCore::SVGScriptElement::isParserInserted):
(WebCore::SVGScriptElement::haveFiredLoadEvent):
* svg/SVGTests.cpp: Fix obvious typo, that leads to an assertion. Always return true if we know the attributeName.
(WebCore::SVGTests::handleAttributeChange):
* svg/SVGTests.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument): Remove ambigous call warning.
* svg/SVGUseElement.cpp: Support externalResourcesRequired="true/false" + dynamic changes of it. Covered by existing tests.
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren):
(WebCore):
* svg/SVGUseElement.h: Ditto.
(WebCore::SVGUseElement::haveLoadedRequiredResources):
(WebCore::SVGUseElement::setHaveFiredLoadEvent):
(WebCore::SVGUseElement::isParserInserted):
(WebCore::SVGUseElement::haveFiredLoadEvent):
* svg/svgtags.in: Pass "bool wasInsertedByParser" to SVGUseElement constructor.
LayoutTests:
Fix flakiness of new external <use> tests introduced in r110676.
* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt:
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt:
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js:
(repaintTest):
(externalLoadDone):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js:
(repaintTest):
(externalLoadDone):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 16:32:40 +0000 (16:32 +0000)]
Mac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=81125
Add expected failing results for Mac WK2 to get the bots green.
* platform/mac-wk2/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 16:23:02 +0000 (16:23 +0000)]
[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=81000
Source/JavaScriptCore:
Enable WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
* wtf/Platform.h:
Source/WebCore:
Add BlackBerry port for DisplayRefreshMonitor using AnimationFrameRateController.
Moved refreshDisplayOnMainThread to platform independant part of header.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
requestAnimationFrame already covered by tests in LayoutTests/fast/animation.
* PlatformBlackBerry.cmake:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore):
(DisplayAnimationClient):
(WebCore::DisplayAnimationClient::~DisplayAnimationClient):
(DisplayRefreshMonitor):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Added.
(WebCore):
(WebCore::DisplayAnimationClient::DisplayAnimationClient):
(WebCore::DisplayAnimationClient::animationFrameChanged):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::startAnimationClient):
(WebCore::DisplayRefreshMonitor::stopAnimationClient):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
Source/WebKit/blackberry:
Set the platform display ID, needed for DisplayRefreshMonitor.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 14 Mar 2012 16:21:05 +0000 (16:21 +0000)]
Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
https://bugs.webkit.org/show_bug.cgi?id=81056
Reviewed by Jessie Berlin.
Source/WebKit2:
Give the InjectedBundlePageFullScreenClient a first crack at beganEnterFullScreen and beganExitFullScreen:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
And call the client function if it exists; otherwise, continue to message the page:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::beganEnterFullScreen):
(WebKit::InjectedBundlePageFullScreenClient::beganExitFullScreen):
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
Add a custom APIClientTraits for InjectedBundlePageFullScreenClient to handle the API number change.
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
Tools:
Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 14 Mar 2012 16:20:16 +0000 (16:20 +0000)]
Web Inspector: use class name indexes instead of class names when evaluating aggregates
https://bugs.webkit.org/show_bug.cgi?id=81100
Class name and type name indexes are now used when calculating class aggregates
in heap snapshots instead of string lookup followed by a string comparison.
Class names like "Window / www.webkit.org" are now left as is in the UI (it used
to be trimed to just "Window").
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get classNameIndex):
(WebInspector.HeapSnapshotNode.prototype.hasType):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 14 Mar 2012 16:04:38 +0000 (16:04 +0000)]
Web Inspector: add didCancelFrame timeline event
https://bugs.webkit.org/show_bug.cgi?id=80994
Reviewed by Pavel Feldman.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
- add an ability to cancel certain timeline events, unless they've been followed by other events.
- implement didCancelFrame() event, fired when a platform decides not to render frame after didBeginFrame() was called.
Test: inspector/timeline/timeline-frames.html
* WebCore.exp.in:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCancelFrameImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCancelFrame):
(WebCore):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
(WebCore::InspectorTimelineAgent::cancelRecord):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
* testing/Internals.cpp:
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore):
(WebCore::Internals::emitInspectorDidCancelFrame):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/chromium:
- add intrumentCanceFrame(), called when renderer decides not to
render frame after instrumentBeginFrame() was called.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentCancelFrame):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
- added test for didBeginFrame()/didCancelFrame()
* inspector/timeline/timeline-frames-expected.txt: Added.
* inspector/timeline/timeline-frames.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Wed, 14 Mar 2012 15:42:51 +0000 (15:42 +0000)]
The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. https://bugs.webkit.org/show_bug.cgi?id=81112
Reviewed by Kenneth Rohde Christiansen.
This patch fixes the issue by withdrawing two times the anchor
margins.
* MiniBrowser/qt/qml/ScrollIndicator.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 15:37:33 +0000 (15:37 +0000)]
Region can acquire an empty span by subtracting an empty Region
https://bugs.webkit.org/show_bug.cgi?id=81074
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-14
Reviewed by Anders Carlsson.
Source/WebCore:
Subtracting an empty Region B from a Region A can cause A to end
up with an empty span. This violates the rule that two Regions
that cover the exact same area should have equal spans and segments.
Unit test: RegionTest.emptySpan
* platform/graphics/Region.cpp:
(WebCore::Region::subtract):
Source/WebKit/chromium:
* tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 14 Mar 2012 15:31:56 +0000 (15:31 +0000)]
[Textmap] Disable driver based BGRA swizzling for OpenGL/ES
Reviewed by Noam Rosenthal.
The current way of detecting swizzling support (check for GL_EXT_texture_format_BGRA8888)
is unfortunately not reliable. We need a better way of detection that (filed bug 81103).
In the meantime this patch reverts back to doing the swizzling in the texture mapper to
get pixels back onto the screen.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 14 Mar 2012 15:28:34 +0000 (15:28 +0000)]
[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Wed, 14 Mar 2012 15:24:13 +0000 (15:24 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=81086
Reviewed by Rob Buis.
Source/WebCore:
* platform/Cursor.h:
(WebCore):
(WebCore::Cursor::Cursor):
Add the BlackBerry specific PlatformCursor.
* platform/blackberry/PageClientBlackBerry.h:
There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly in this file.
(PageClientBlackBerry):
Source/WebKit/blackberry:
There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCursor):
* Api/WebPage_p.h:
(WebPagePrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 15:15:34 +0000 (15:15 +0000)]
[EFL] Implement LayoutTestController::clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=80142
Tools:
Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearBackForwardList): Implemented.
LayoutTests:
Unskip tests connected with clearBackForwardList.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 14 Mar 2012 15:02:14 +0000 (15:02 +0000)]
[Qt] RunLoopQt is missing reentrancy guards
https://bugs.webkit.org/show_bug.cgi?id=80982
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-14
Reviewed by Tor Arne Vestbø.
Avoid recursive calls to RunLoop::performWork() with a simple
counting mechanism, to avoid out-of-order message dispatching.
* platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 14 Mar 2012 14:41:26 +0000 (14:41 +0000)]
Source/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
https://bugs.webkit.org/show_bug.cgi?id=81033
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
Source/WebKit/chromium: Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-13
* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):
LayoutTests: Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205
Patch by Kentaro Hara <haraken@chromium.org> on 2012-03-14
Reviewed by Adam Barth.
shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument
* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 13:23:10 +0000 (13:23 +0000)]
Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.
Fix build error introduced by r110669.
* platform/network/soup/DNSSoup.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 13:01:17 +0000 (13:01 +0000)]
Unreviewed rebaseline update for <use> related SVG files.
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Removed.
* platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textPosition-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textStyles-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.txt:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/smallFonts-expected.png:
* platform/chromium-win/svg/batik/text/smallFonts-expected.txt:
* platform/chromium-win/svg/batik/text/textAnchor-expected.png:
* platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
* platform/chromium-win/svg/batik/text/textDecoration-expected.png:
* platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect2-expected.png:
* platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.png:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout-expected.png:
* platform/chromium-win/svg/batik/text/textLayout-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout2-expected.png:
* platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
* platform/chromium-win/svg/batik/text/textLength-expected.png:
* platform/chromium-win/svg/batik/text/textLength-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition-expected.png:
* platform/chromium-win/svg/batik/text/textPosition-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.png:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties2-expected.png:
* platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.txt:
* platform/chromium-win/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/batik/text/verticalText-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac-future/svg/batik/masking/maskRegions-expected.png: Removed.
* platform/mac/svg/batik/masking/maskRegions-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 12:41:37 +0000 (12:41 +0000)]
WebHTTPBody: Keep track of whether the data includes passwords.
https://bugs.webkit.org/show_bug.cgi?id=81003
Patch by Marja Hölttä <marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.
This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.
Source/WebCore:
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Check if the data contains passwords.
* platform/network/FormData.cpp:
(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.
* platform/network/FormData.h:
(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):
Source/WebKit/chromium:
* public/platform/WebHTTPBody.h:
(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 14 Mar 2012 12:23:08 +0000 (12:23 +0000)]
Web Inspector: Add snippets tab to scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=81018
Reviewed by Pavel Feldman.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/SnippetsModel.js:
LayoutTests:
* http/tests/inspector/debugger-test.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 14 Mar 2012 12:03:48 +0000 (12:03 +0000)]
Web Inspector: Copy on the Console gives a mangled result.
https://bugs.webkit.org/show_bug.cgi?id=81091
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
LayoutTests:
* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* inspector/console/console-assert-expected.txt:
* inspector/console/console-big-array-expected.txt:
* inspector/console/console-clear-expected.txt:
* inspector/console/console-command-clear-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-external-array-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/console/console-log-before-inspector-open-expected.txt:
* inspector/console/console-log-document-proto-expected.txt:
* inspector/console/console-log-syntax-error-expected.txt:
* inspector/console/console-log-toString-object-expected.txt:
* inspector/console/console-nested-group-expected.txt:
* inspector/console/console-object-constructor-name-expected.txt:
* inspector/console/console-repeat-count-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/console/console-trace-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
* platform/chromium/inspector/console/alert-toString-exception-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-log-document-proto-expected.txt:
* platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
* platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
* platform/qt/inspector/console/console-format-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 14 Mar 2012 12:00:44 +0000 (12:00 +0000)]
2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Zoltan Herczeg.
Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
Replace xml:id with id everywhere, to make the new tiny tests work.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
* svg/custom/use-external-crash-expected.txt: Added.
* svg/custom/use-external-crash.svg: Added.
2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Zoltan Herczeg.
Follow-up fix after r110676.
Assertions are firing due last minute changes in isExternalURIReference.
Fix detecting local resources properly, when the given iri contains a /complex/path.
Use document->completeURL() instead, and compare with the document->url() to decide
if its a local reference or not.
If an external document load fails with an error (eg. file missing) don't assert
in debug builds, instead handle it gracefully.
I decided to clean the code up as well, to make it more safe & obvious.
Test: svg/custom/use-external-crash.svg
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::targetElementFromIRIString):
* svg/SVGURIReference.h:
(WebCore::SVGURIReference::isExternalURIReference):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::buildPendingResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 11:56:47 +0000 (11:56 +0000)]
3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.
The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.
No new tests. Tested by current compositing layout tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginScissorClip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 14 Mar 2012 11:47:36 +0000 (11:47 +0000)]
[Qt] Rebaseline after r110667.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 11:43:53 +0000 (11:43 +0000)]
[Qt] Unreviewed. Add platform specific expectaions after r110593
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 11:39:46 +0000 (11:39 +0000)]
Unreviewed flakiness marking.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 11:06:09 +0000 (11:06 +0000)]
Unreviewed rebaselining expectations.
* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLayout-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLength-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:44:51 +0000 (10:44 +0000)]
[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703
Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc