epoger@google.com [Tue, 14 May 2013 15:17:46 +0000 (15:17 +0000)]
GM: include filename extension (.png) of each output file in JSON summary
Doing this so that, once we *do* start writing PDF checksums into the JSON
summary, we'll be able to distinguish those from the PNG checksums.
Otherwise, we could have naming collisions.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
14890017
git-svn-id: http://skia.googlecode.com/svn/trunk@9119
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 14 May 2013 14:20:28 +0000 (14:20 +0000)]
Make GrAAConvexPathRender support paths with > 64K verts.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
15120004
git-svn-id: http://skia.googlecode.com/svn/trunk@9118
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 14 May 2013 07:01:11 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9117
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 13 May 2013 19:43:59 +0000 (19:43 +0000)]
add separate impl file for SkFontMgr_fontconfig, so we don't polute
SkFontHost_fontconfig, which should be sharable w/ android. Eventaully
we will remove that FontHost file completely, and just use the SkFontMgr.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
15077008
git-svn-id: http://skia.googlecode.com/svn/trunk@9114
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 13 May 2013 18:50:25 +0000 (18:50 +0000)]
Key shader on whether frag pos read is relative to top-left or bottom-left
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
14633007
git-svn-id: http://skia.googlecode.com/svn/trunk@9113
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 13 May 2013 18:48:40 +0000 (18:48 +0000)]
Remove 16bit asserts and casts of string length.
R=reed@google.com
Review URL: https://codereview.chromium.org/
14711011
git-svn-id: http://skia.googlecode.com/svn/trunk@9112
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 13 May 2013 14:41:03 +0000 (14:41 +0000)]
Fix stroked roundrects on Nexus 10.
Due to floating point precision errors, using the formula b^2x^2 + a^2y^2 - a^2b^2
doesn't work on the Nexus 10 GPU. Changed to use x^2/a^2 + y^2/b^2 - 1.
Addresses issue 1290.
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
15039016
git-svn-id: http://skia.googlecode.com/svn/trunk@9110
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 13 May 2013 14:40:34 +0000 (14:40 +0000)]
Fix for Debug check failures in r9108
git-svn-id: http://skia.googlecode.com/svn/trunk@9109
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 13 May 2013 14:10:31 +0000 (14:10 +0000)]
add bench for blurred rectori case
https://codereview.chromium.org/
14690014/
git-svn-id: http://skia.googlecode.com/svn/trunk@9108
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 13 May 2013 14:09:13 +0000 (14:09 +0000)]
API modifications needed to upstream Android font changes.
Committed: http://code.google.com/p/skia/source/detail?r=9083
R=reed@google.com
Author: djsollen@google.com
Review URL: https://chromiumcodereview.appspot.com/
14761003
git-svn-id: http://skia.googlecode.com/svn/trunk@9107
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 13 May 2013 13:38:35 +0000 (13:38 +0000)]
Partial revert of r9087
https://codereview.chromium.org/
14858035/
git-svn-id: http://skia.googlecode.com/svn/trunk@9106
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 11 May 2013 13:21:43 +0000 (13:21 +0000)]
Check for NULL texture in GrAutoScratchTexture::detach()
R=sugoi@chromium.org, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
14683009
git-svn-id: http://skia.googlecode.com/svn/trunk@9104
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 11 May 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9103
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 10 May 2013 19:08:22 +0000 (19:08 +0000)]
Don't call purgeCache() from within GrResource memebers.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
14864020
git-svn-id: http://skia.googlecode.com/svn/trunk@9102
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 10 May 2013 18:29:43 +0000 (18:29 +0000)]
[PDF] Only output the Dests dictionary if it isn't epmpty
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
15028012
git-svn-id: http://skia.googlecode.com/svn/trunk@9100
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 10 May 2013 17:22:48 +0000 (17:22 +0000)]
Fix memory leak in SkTypeface.cpp
https://codereview.chromium.org/
14617019/
git-svn-id: http://skia.googlecode.com/svn/trunk@9099
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 10 May 2013 17:14:06 +0000 (17:14 +0000)]
Remove GrPathCmd
R=reed@google.com
Review URL: https://codereview.chromium.org/
15068008
git-svn-id: http://skia.googlecode.com/svn/trunk@9097
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 10 May 2013 15:16:13 +0000 (15:16 +0000)]
add wildcard test name matching to gm and bench.
This adds the same set of options in unit tests, i.e:
--match [~][^]match[$] [~][^]match[$] ...
~ causes a matching test to always be skipped
^ requires the start of the test to match
$ requires the end of the test to match
^ and $ requires an exact match
If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/
14746017
git-svn-id: http://skia.googlecode.com/svn/trunk@9096
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 10 May 2013 14:51:54 +0000 (14:51 +0000)]
Fix memory leak in filter tool
https://codereview.chromium.org/
15029008/
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9094
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 10 May 2013 14:39:26 +0000 (14:39 +0000)]
Remove duplicated code in SkPictureRecord::drawRRect
Review URL: https://codereview.chromium.org/
15057005
git-svn-id: http://skia.googlecode.com/svn/trunk@9093
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 10 May 2013 14:12:08 +0000 (14:12 +0000)]
Make gms use getTopDevice() rather than getDevice().
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
14885012
git-svn-id: http://skia.googlecode.com/svn/trunk@9091
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 10 May 2013 14:09:54 +0000 (14:09 +0000)]
Further defer devRect computation in gpu rect drawing
https://codereview.chromium.org/
14798007/
git-svn-id: http://skia.googlecode.com/svn/trunk@9090
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 10 May 2013 13:16:13 +0000 (13:16 +0000)]
Update shader rect drawing path for r9087 (removal of isIRect "opt")
https://codereview.chromium.org/
14972013/
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9089
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 10 May 2013 11:05:58 +0000 (11:05 +0000)]
Remove isIRect "optimization" & defer computation of device Rect in AA rect rendering
https://chromiumcodereview.appspot.com/
14890021/
git-svn-id: http://skia.googlecode.com/svn/trunk@9087
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 10 May 2013 07:01:04 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9086
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 9 May 2013 22:47:33 +0000 (22:47 +0000)]
Reverting 9083 & 9084 due to Android failures
git-svn-id: http://skia.googlecode.com/svn/trunk@9085
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 9 May 2013 22:02:35 +0000 (22:02 +0000)]
fix warning/error of uninitialized len
BUG=
Review URL: https://codereview.chromium.org/
15001019
git-svn-id: http://skia.googlecode.com/svn/trunk@9084
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 9 May 2013 20:54:20 +0000 (20:54 +0000)]
API modifications needed to upstream Android font changes.
R=reed@google.com
Author: djsollen@google.com
Review URL: https://chromiumcodereview.appspot.com/
14761003
git-svn-id: http://skia.googlecode.com/svn/trunk@9083
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 9 May 2013 20:01:26 +0000 (20:01 +0000)]
Revert r9081
Review URL: https://codereview.chromium.org/
14773022
git-svn-id: http://skia.googlecode.com/svn/trunk@9082
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 9 May 2013 19:37:41 +0000 (19:37 +0000)]
add SkString::append(const char c)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
14813013
git-svn-id: http://skia.googlecode.com/svn/trunk@9081
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 9 May 2013 19:08:57 +0000 (19:08 +0000)]
Fix for compiler warnings/errors in r9078
git-svn-id: http://skia.googlecode.com/svn/trunk@9079
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 9 May 2013 19:03:48 +0000 (19:03 +0000)]
Added game-like bench marks
https://codereview.chromium.org/
14772019/
git-svn-id: http://skia.googlecode.com/svn/trunk@9078
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 9 May 2013 18:09:06 +0000 (18:09 +0000)]
GM self-test: add --writePath and --mismatchPath , but in a way that works cross-platform
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
15085007
git-svn-id: http://skia.googlecode.com/svn/trunk@9077
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 9 May 2013 18:05:32 +0000 (18:05 +0000)]
Fix some warnings in SkPath.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
14969003
git-svn-id: http://skia.googlecode.com/svn/trunk@9076
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 9 May 2013 16:15:20 +0000 (16:15 +0000)]
remove unneeded reference to SkTScopedPtr
R=djsollen@google.com, scroggo@google.com
Author: reed@google.com
Review URL: https://chromiumcodereview.appspot.com/
14057013
git-svn-id: http://skia.googlecode.com/svn/trunk@9075
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 9 May 2013 14:55:46 +0000 (14:55 +0000)]
Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or fragment position
R=senorblanco@chromium.org, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
14998007
git-svn-id: http://skia.googlecode.com/svn/trunk@9074
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 9 May 2013 13:45:02 +0000 (13:45 +0000)]
Move loops that chain together effects into GrGLShaderBuilder from GrGLProgram.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
14925010
git-svn-id: http://skia.googlecode.com/svn/trunk@9073
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 9 May 2013 07:02:04 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9072
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 21:08:21 +0000 (21:08 +0000)]
need to clamp all of the cubic points after a chop, in case our finite precision
meant we didn't compute values below the chop-point.
crbug:234190
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
14607012
git-svn-id: http://skia.googlecode.com/svn/trunk@9071
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 8 May 2013 19:14:23 +0000 (19:14 +0000)]
Write/compare against expectations in skimage tool.
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.
gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com
Review URL: https://codereview.chromium.org/
14670021
git-svn-id: http://skia.googlecode.com/svn/trunk@9069
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 17:46:48 +0000 (17:46 +0000)]
negate FontBox.bottom, since it is negative, but we want it positive (doh)
git-svn-id: http://skia.googlecode.com/svn/trunk@9067
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 8 May 2013 16:24:05 +0000 (16:24 +0000)]
fix BitmapHasher unittest failure as of r9064
git-svn-id: http://skia.googlecode.com/svn/trunk@9066
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 8 May 2013 16:04:02 +0000 (16:04 +0000)]
Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
15060008/
git-svn-id: http://skia.googlecode.com/svn/trunk@9064
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 8 May 2013 15:39:13 +0000 (15:39 +0000)]
Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip ops correctly.
BUG=crbug.com/229011
TEST=Picture unit test + complexclip* GMs
Review URL: https://codereview.chromium.org/
14820021
git-svn-id: http://skia.googlecode.com/svn/trunk@9063
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 15:32:41 +0000 (15:32 +0000)]
remove dead code (SkBitmapSampler)
git-svn-id: http://skia.googlecode.com/svn/trunk@9062
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 8 May 2013 15:31:43 +0000 (15:31 +0000)]
Revert r9055.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@9061
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 8 May 2013 15:22:36 +0000 (15:22 +0000)]
Roll out r9059 to unbreak bots
git-svn-id: http://skia.googlecode.com/svn/trunk@9060
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 8 May 2013 14:49:50 +0000 (14:49 +0000)]
Remove third-party cityhash, unused since r8992
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
15027013
git-svn-id: http://skia.googlecode.com/svn/trunk@9059
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 14:19:08 +0000 (14:19 +0000)]
we only need one fontmetrics, since the paint (and fontcache) now know explicitly
if they are horizontal or vertical.
Review URL: https://codereview.chromium.org/
14940018
git-svn-id: http://skia.googlecode.com/svn/trunk@9058
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 14:11:28 +0000 (14:11 +0000)]
Use more fields from OutlineFontMEtrics: linegap, bbox.
Up our canonical size to 2048 to reduce precision loss.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
14759021
git-svn-id: http://skia.googlecode.com/svn/trunk@9057
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 8 May 2013 14:10:28 +0000 (14:10 +0000)]
GM self-test: add option to exercise --writePath and --mismatchPath, but not on bots
(individual developers can set WRITE_IMAGE_FILES=1 for local testing)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
14863009
git-svn-id: http://skia.googlecode.com/svn/trunk@9056
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 8 May 2013 13:59:36 +0000 (13:59 +0000)]
Better method for rendering AA ellipses.
This uses the standard ellipse equation as a signed distance
test, and adjusts the result by the length of the gradient
at that point to get a better approximation of the distance
to the ellipse. It replaces the standard ellipse and
roundrect shader renderers.
Also adds a check to see if the curvature extrema of the
stroke are less than the curvature extrema of the ellipse (i.e.
the radius of curvature is larger). In this case, it's no
longer an ellipse and we can't use this renderer.
Committed: http://code.google.com/p/skia/source/detail?r=9016
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
14938004
git-svn-id: http://skia.googlecode.com/svn/trunk@9055
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 8 May 2013 13:25:02 +0000 (13:25 +0000)]
add SK_API
git-svn-id: http://skia.googlecode.com/svn/trunk@9054
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 8 May 2013 12:49:49 +0000 (12:49 +0000)]
Comment out invalid assert.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
15021008
git-svn-id: http://skia.googlecode.com/svn/trunk@9053
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 8 May 2013 11:18:34 +0000 (11:18 +0000)]
Autogen has been reset. Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@9052
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 8 May 2013 07:01:40 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9051
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 8 May 2013 01:55:49 +0000 (01:55 +0000)]
share derivative code with extrema logic, remove some dead code.
git-svn-id: http://skia.googlecode.com/svn/trunk@9050
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 8 May 2013 01:15:54 +0000 (01:15 +0000)]
fix impl for conic derivative (tangent)
git-svn-id: http://skia.googlecode.com/svn/trunk@9049
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 May 2013 20:42:35 +0000 (20:42 +0000)]
add (untested) tangent calc for conics
git-svn-id: http://skia.googlecode.com/svn/trunk@9048
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 7 May 2013 19:48:31 +0000 (19:48 +0000)]
path ops -- make combined clips soft if one is soft
Review URL: https://codereview.chromium.org/
14786018
git-svn-id: http://skia.googlecode.com/svn/trunk@9047
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 7 May 2013 19:36:43 +0000 (19:36 +0000)]
Reland r9043 with fix.
git-svn-id: http://skia.googlecode.com/svn/trunk@9046
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 7 May 2013 19:31:20 +0000 (19:31 +0000)]
Make make.bat and gyp_skia work with VS 2012.
Review URL: https://codereview.chromium.org/
14963005/
git-svn-id: http://skia.googlecode.com/svn/trunk@9045
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 7 May 2013 19:19:24 +0000 (19:19 +0000)]
revert 9043
git-svn-id: http://skia.googlecode.com/svn/trunk@9044
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 7 May 2013 19:17:02 +0000 (19:17 +0000)]
SkGpuDevice: Delay locking bitmap pixels until we have a known texture cache miss.
Reivew URL: https://codereview.chromium.org/
15035004/
git-svn-id: http://skia.googlecode.com/svn/trunk@9043
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 7 May 2013 18:51:31 +0000 (18:51 +0000)]
path ops -- fix skp bugs
This fixes a series of bugs discovered by running
the small set of Skia skp files through pathops
to flatten the clips.
Review URL: https://codereview.chromium.org/
14798004
git-svn-id: http://skia.googlecode.com/svn/trunk@9042
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 7 May 2013 17:43:22 +0000 (17:43 +0000)]
Nexus 7 performance trigger rebaselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9040
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 May 2013 15:59:16 +0000 (15:59 +0000)]
add block comment describing sync nature of SkStream
git-svn-id: http://skia.googlecode.com/svn/trunk@9039
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 7 May 2013 15:51:54 +0000 (15:51 +0000)]
GM: now that we use MD5 instead of CityHash, the JSON should say so
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 7 May 2013 15:28:15 +0000 (15:28 +0000)]
XPS ttc handling.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/
14873006
git-svn-id: http://skia.googlecode.com/svn/trunk@9037
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 7 May 2013 14:45:40 +0000 (14:45 +0000)]
Revert "Allow supporting 1 older PICTURE_VERSION."
This reverts commit
deb9d6990ef2d153230340d960d86b0966f261e1.
That change was just to allow us to bump the PICTURE_VERSION
without changing the SKPs to the new one. Since it is not
entirely reliable, I am removing it.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
14741007
git-svn-id: http://skia.googlecode.com/svn/trunk@9035
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 7 May 2013 14:32:58 +0000 (14:32 +0000)]
Check whether font creation is failed to avoid segment fault.
In some rare cases, SkFontHost::CreateTypeface in src/ports/SkFontHost_fontconfig.cpp will return NULL, this will lead to segment fault because the previous code would access to 0x0 by (SkTypeface *)NULL->unref().
BUG=
R=reed@google.com, bungeman@google.com
Author: yunchao.he@intel.com
Review URL: https://chromiumcodereview.appspot.com/
14907005
git-svn-id: http://skia.googlecode.com/svn/trunk@9034
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 May 2013 14:11:40 +0000 (14:11 +0000)]
reverting 9031
git-svn-id: http://skia.googlecode.com/svn/trunk@9033
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 May 2013 13:26:18 +0000 (13:26 +0000)]
Fix SkPicture path bound optimization to handle inverse filled paths.
BUG=crbug.com/229011
TEST=Picture unit test
Review URL: https://codereview.chromium.org/
14819008
git-svn-id: http://skia.googlecode.com/svn/trunk@9031
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 7 May 2013 13:08:41 +0000 (13:08 +0000)]
Nexus 7 performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9030
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 7 May 2013 13:03:21 +0000 (13:03 +0000)]
Add stroked oval benches.
Reviewed by: bsalomon
Review URL: https://codereview.chromium.org/
14849011/
git-svn-id: http://skia.googlecode.com/svn/trunk@9029
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 7 May 2013 12:09:54 +0000 (12:09 +0000)]
Run bench_pictures with "--config msaa4" on Razr I, Nexus 10, and GNex
Addresses: https://code.google.com/p/skia/issues/detail?id=1276
Review URL: https://codereview.chromium.org/
15012002
git-svn-id: http://skia.googlecode.com/svn/trunk@9027
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 7 May 2013 07:01:03 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9023
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 6 May 2013 22:23:08 +0000 (22:23 +0000)]
Mask orientation and layout correctly.
R=reed@google.com, clefru@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/
14884010
git-svn-id: http://skia.googlecode.com/svn/trunk@9022
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 6 May 2013 19:29:23 +0000 (19:29 +0000)]
Reverting r9016 due to Nexus7 GM regressions
git-svn-id: http://skia.googlecode.com/svn/trunk@9020
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 6 May 2013 18:08:05 +0000 (18:08 +0000)]
lockPixels before calling getColorTable.
Fixes a bug where we try to dereference a NULL pointer.
Update the comment for SkBitmap::getColorTable, telling
the client that pixels must be locked for it to return
non-NULL.
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
15002002
git-svn-id: http://skia.googlecode.com/svn/trunk@9018
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 6 May 2013 16:44:03 +0000 (16:44 +0000)]
Better method for rendering AA ellipses.
This uses the standard ellipse equation as a signed distance
test, and adjusts the result by the length of the gradient
at that point to get a better approximation of the distance
to the ellipse. It replaces the standard ellipse and
roundrect shader renderers.
Also adds a check to see if the curvature extrema of the
stroke are less than the curvature extrema of the ellipse (i.e.
the radius of curvature is larger). In this case, it's no
longer an ellipse and we can't use this renderer.
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
14938004
git-svn-id: http://skia.googlecode.com/svn/trunk@9016
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 May 2013 15:59:51 +0000 (15:59 +0000)]
by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float
instead of a double. Otherwise we can't properly test for overflow with large values.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
14884011
git-svn-id: http://skia.googlecode.com/svn/trunk@9015
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 6 May 2013 15:39:11 +0000 (15:39 +0000)]
Nexus 7 performance trigger rebaselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9014
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 6 May 2013 14:28:43 +0000 (14:28 +0000)]
Don't use writeData to write the document in GM.
https://codereview.chromium.org/
14824003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9013
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 6 May 2013 14:08:08 +0000 (14:08 +0000)]
Updated performance trigger baseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9012
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 6 May 2013 14:03:53 +0000 (14:03 +0000)]
Remove unused complex script support from android builds
R=reed@google.com
Author: djsollen@google.com
Review URL: https://chromiumcodereview.appspot.com/
14942003
git-svn-id: http://skia.googlecode.com/svn/trunk@9011
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 6 May 2013 13:49:41 +0000 (13:49 +0000)]
Use exportVar function in nacl_make
Dumps out the variables as they are defined for debugging
(SkipBuildbotRuns)
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
14655006
git-svn-id: http://skia.googlecode.com/svn/trunk@9010
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 6 May 2013 12:50:00 +0000 (12:50 +0000)]
Copy NaCl directory into trunk/platform_tools, adjust paths
(SkipBuildbotRuns)
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
14771017
git-svn-id: http://skia.googlecode.com/svn/trunk@9008
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 May 2013 12:21:16 +0000 (12:21 +0000)]
reimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the
risk of over/under-flow w/ the current fixed-point intermediates.
Review URL: https://codereview.chromium.org/
14736005
git-svn-id: http://skia.googlecode.com/svn/trunk@9005
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sat, 4 May 2013 11:51:20 +0000 (11:51 +0000)]
Refreshed SKP files. Whitespace change to trigger rebuilds.
(AddDashboardAnnotation)
Review URL: https://codereview.chromium.org/
14947003
git-svn-id: http://skia.googlecode.com/svn/trunk@9003
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 4 May 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9002
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 3 May 2013 20:43:37 +0000 (20:43 +0000)]
Add a new mode to render_pictures.
In the new mode, if an SKP file has encoded bitmap data, draw
the data to a file with the appropriate name.
R=borenet@google.com
Review URL: https://codereview.chromium.org/
14637011
git-svn-id: http://skia.googlecode.com/svn/trunk@9001
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 3 May 2013 20:39:22 +0000 (20:39 +0000)]
Fix more warnings.
BUG=
Review URL: https://codereview.chromium.org/
14624008
git-svn-id: http://skia.googlecode.com/svn/trunk@9000
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 May 2013 20:24:54 +0000 (20:24 +0000)]
Make rebaseline.py pull GN Debug images.
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
14743004
git-svn-id: http://skia.googlecode.com/svn/trunk@8999
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 3 May 2013 20:21:17 +0000 (20:21 +0000)]
Fix build (warning).
BUG=
Review URL: https://codereview.chromium.org/
14789014
git-svn-id: http://skia.googlecode.com/svn/trunk@8998
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 3 May 2013 20:14:28 +0000 (20:14 +0000)]
Test region decoding in skimage, plus fixes.
Add tests in skimage to perform region decoding. Write out a
PNG of the region as well as a bitmap obtained with extractSubset
for comparison.
Rename decodeRegion to decodeSubset, so it will not be confused
with SkRegion. (Leave a function called decodeRegion which calls
decodeSubset.)
Clean up some comments.
Use png_set_interlaced_pass instead of modifying pass directly.
Make some changes to region decoding to fix problems I discovered
during testing:
Only call getAddr within a valid range.
Check for a NULL fInputStream.
Return a boolean for whether cropBitmap succeeded.
In cropBitmap, do not attempt to draw to a bitmap to an Index8
bitmap, which crashes. Use extractSubset instead.
Remove an assert.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
14567011
git-svn-id: http://skia.googlecode.com/svn/trunk@8996
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 May 2013 18:11:00 +0000 (18:11 +0000)]
add (temporary) diagnostic code for normalize test
git-svn-id: http://skia.googlecode.com/svn/trunk@8994
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 May 2013 18:06:31 +0000 (18:06 +0000)]
add endian tests (reviewed by bungeman)
git-svn-id: http://skia.googlecode.com/svn/trunk@8993
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 3 May 2013 17:35:39 +0000 (17:35 +0000)]
SkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
BUG=https://code.google.com/p/skia/issues/detail?id=1257
(if we change our mind within the next few days, we can toggle the
BITMAPHASHER_USES_TRUNCATED_MD5 #ifdef ; at some point, we'll remove that
option so we can delete our CityHash implementation entirely)
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
14054012
git-svn-id: http://skia.googlecode.com/svn/trunk@8992
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 May 2013 16:30:44 +0000 (16:30 +0000)]
trick the compiler into not knowning that I will generate an overflow
(which is the point of the test). This avoids a warning, which breaks
our bots.
git-svn-id: http://skia.googlecode.com/svn/trunk@8991
2bbb7eff-a529-9590-31e7-
b0007b416f81