Guilherme Iscaro [Tue, 20 Sep 2016 16:40:31 +0000 (13:40 -0300)]
Efl_Input_Device: Implement efl_input_device_parent_set().
This commits moves the parent_set implementation where it should be.
Carsten Haitzler (Rasterman) [Tue, 27 Sep 2016 00:09:21 +0000 (09:09 +0900)]
po - update
Carsten Haitzler (Rasterman) [Tue, 27 Sep 2016 00:08:24 +0000 (09:08 +0900)]
efl - fix build to build multip.edj from the right edc source
the makefile was wrong making multip.edj for the multitouch test in
elm the wrong src thus breaking the crosshairs. this fixes that again
so the test is right.
@fix
Cedric BAIL [Mon, 26 Sep 2016 23:35:52 +0000 (16:35 -0700)]
ecore: add a prototype ecore_thread helper with Efl_Promise/Efl_Future coupled.
Shilpa Singh [Mon, 26 Sep 2016 21:28:09 +0000 (14:28 -0700)]
elm_atspi_bridge: Active descendant changed signal not sent issue fix.
Summary:
Active descendant changed signal send function checks for wrong object,
hence always returns with out actually sending signal.
The state is set to pd->object_broadcast_mask and not
pd->object_children_broadcast_mask in _set_broadcast_flag function.
Test Plan:
Send the active descandant changed signal from any widget, but signal
is not sent.
Reviewers: kimcinoo, lukasz.stanislawski, cedric
Reviewed By: cedric
Subscribers: jpeg, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D4318
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Mon, 26 Sep 2016 21:26:17 +0000 (14:26 -0700)]
elementary: set the extension on the extension, not the overlay !
@fix
This is a port of D4317
Chris Michael [Mon, 26 Sep 2016 18:01:15 +0000 (14:01 -0400)]
elementary: Fix potential resource leak
If we fail to allocate memory for savedtypes.types here, then the
"known" array would end up leaking. Defer creation of 'known' array
until after savedtypes.types is allocated, this way we don't leak.
Fixes CID1363216
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Mon, 26 Sep 2016 13:50:08 +0000 (14:50 +0100)]
Ecore promise: Renamed shadow variable.
Please everyone, use -Wshadow and fix your damn wranings.
Youngbok Shin [Mon, 26 Sep 2016 13:03:45 +0000 (16:03 +0300)]
elementary entry: send a signal to edje for notifying scrollable mode
Summary:
If entry edje should be changed according to scrollable mode,
the signal will be used. The following signals are added.
"elm,scroll,enable"
"elm,scroll,disable"
Test Plan: N/A
Reviewers: raster, tasn, herdsman, cedric
Subscribers: minkyu, jpeg, akanad, z-wony, Blackmole
Differential Revision: https://phab.enlightenment.org/D4254
Marcel Hollerbach [Mon, 26 Sep 2016 09:44:47 +0000 (11:44 +0200)]
ecore_wl2: fix array overflow
fixes CID 1363215
Marcel Hollerbach [Mon, 26 Sep 2016 09:41:12 +0000 (11:41 +0200)]
ecore_wl2: support parallel receiving of different mimetypes
The mimetypes are now populated with the event and the data.
This also fixes CID 1363217
Marcel Hollerbach [Mon, 26 Sep 2016 09:29:12 +0000 (11:29 +0200)]
ecore_wl2: fix null dereference issue
if we dont get the userdata of a offer something in the protocol went
very very bad, we should not emit there a error, just return.
Also if we are getting a null offer we should dereference the nulled out
offer object.
This fixes CID 1363214
Jaehyun Cho [Mon, 26 Sep 2016 09:08:41 +0000 (18:08 +0900)]
elm_config: Remove unnecessary NULL check.
Since _config_load() is called and _elm_config is not initialized, NULL
check for _elm_config is not necessary.
The unnecessary NULL check causes false alarm because _elm_config is not
checked in other cases.
Jee-Yong Um [Mon, 26 Sep 2016 06:04:15 +0000 (15:04 +0900)]
eina_matrix/quad: clean up documentation
Summary: adjust grouping to show reference correctly
Reviewers: Hermet, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4313
Carsten Haitzler (Rasterman) [Mon, 26 Sep 2016 00:16:21 +0000 (09:16 +0900)]
eo ptr indir - handle unlock on error with shared eoids correctly
this fixes the error handling for shared objects which would fail to
unlock on lookup error.
Andy Williams [Sun, 25 Sep 2016 16:21:40 +0000 (17:21 +0100)]
elm: Update toolbar test to show fix
Andy Williams [Sun, 25 Sep 2016 14:57:08 +0000 (15:57 +0100)]
elm_toolbar: Show icons in icon only mode
When passing NULL as label the icon would get hidden.
@fix
Carsten Haitzler (Rasterman) [Sun, 25 Sep 2016 14:50:53 +0000 (23:50 +0900)]
efreet - fix command generation by fixing string buffer expansion
so by chance i discovered efreet is doing bad things(tm) when
expanding/appending to string buffers to generate commands based off
desktop files. the string append basically was buggy, so fixed it by
making it a lot simpler and more obvious and now reliable.
@fix
Daniel Zaoui [Sun, 25 Sep 2016 10:11:32 +0000 (13:11 +0300)]
Emotion: modify the playback finish behavior as before
The callbacks are never invoked due to sd->play equal to 0. The
function _emotion_decode_stop is called before and resets this field.
Before the change to Efl.Canvas.Video, sd->play was not checked.
Marcel Hollerbach [Sat, 24 Sep 2016 17:01:37 +0000 (19:01 +0200)]
ecore_wl2: utilize the event window_ids
if a dnd operation enters a surface the window_id is clear, so a offer
is always specific to a window. If we have a source we try to fetch the
id from the focus/prevfocus or keyboardfocus.
This fixes dropping into a efl app which never got focus before.
Marcel Hollerbach [Fri, 23 Sep 2016 20:00:11 +0000 (22:00 +0200)]
elm_cnp: handle format of a drop correctly
the format can also be the result of mutliple orĀ“ed values.
The new code now also uses the same mimetypes to format type relation
than the selection code.
This fixes dragging onto a container with multiple formats.
Spotted by ApBBB while dragging from ephoto to terminology.
This also fixes T3320
Carsten Haitzler (Rasterman) [Sat, 24 Sep 2016 06:12:09 +0000 (15:12 +0900)]
eo op resolv - do micro optimization to move init to goto blob
as per other recent benchmarking, moving rearely run code (in this
case code to init the op etc.) out of the l1 cacheline prefetch inot a
blob of code at the end of the function where we goto and goto back
again should provide decent-ish speedups for the resolv cache in
avoding this code. yes it makes the code less pretty to read but at
this really low level hot path ... evil things must happen to get the
speed we want/need.
Vitor Sousa [Fri, 23 Sep 2016 14:32:46 +0000 (11:32 -0300)]
eio model: use empty mime type when efreet is unable to determine it
FIX T4502
@fix
Stephen Houston [Fri, 23 Sep 2016 14:38:15 +0000 (09:38 -0500)]
Add updated drop part for the new pager gadget. This will be required for the new pager to work.
Chris Michael [Fri, 23 Sep 2016 12:53:32 +0000 (08:53 -0400)]
ecore-drm2: Use Atomic State to enable/disable an output
If Atomic Modesetting is supported, we can use that to enable/disable
a given output.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 23 Sep 2016 12:51:35 +0000 (08:51 -0400)]
ecore-drm2: Remove useless if check for atomic_modeset flag
As we always set this flag in the drm2_fb_flip function, having this
check here is now pointless.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Carsten Haitzler (Rasterman) [Fri, 23 Sep 2016 11:10:16 +0000 (20:10 +0900)]
edje signal emits - enable DBG for being able to debug edj files
this would allow all emits from embryo script or otherwise to be seen
and debugged via eina-log.
Marcel Hollerbach [Fri, 23 Sep 2016 10:03:07 +0000 (12:03 +0200)]
AUTHORS: add myself to the authors file
Marcel Hollerbach [Fri, 23 Sep 2016 08:45:03 +0000 (10:45 +0200)]
elm_cnp: refactor selection_get callbacks
before the format was not passed correctly, now the format is passed
correctly to the callback.
Also if a dnd operation was started while a cnp receive call was
going on (this happend because weston-editor failed to close the fd, so
EOF was never sent), then elm_cnp would behave wrong, since the
requestwidget, action, format would be different.
Marcel Hollerbach [Thu, 22 Sep 2016 19:35:20 +0000 (21:35 +0200)]
ecore_wl2: add more documentation on ecore_wl2 cnp/dnd api
Marcel Hollerbach [Thu, 22 Sep 2016 19:22:51 +0000 (21:22 +0200)]
elm_cnp: handle actions probebly
ecore_wl2 passes the action which should be performed, this action is
now converted and passed to the action of the elm callback.
Marcel Hollerbach [Thu, 22 Sep 2016 07:13:48 +0000 (09:13 +0200)]
ecore_wl2: introduce offer api
This commits adds api to deal with wayland offers.
It also ports elm_cnp to use the new api.
The selection_get and dnd_drag_get calls are replaced by simply receive
data from the offer.
The Offer object is now also emitted in every Enter,Motion,Drop and
Leave event, so a potential user can prefetch data and display it.
To finish a dnd operation positiv, the user has to call the finish call
before the offer is destroyed
Marcel Hollerbach [Thu, 22 Sep 2016 07:26:02 +0000 (09:26 +0200)]
ecore_wl2: save action of data source in seperated field
the drag.source is only available if the drag is happing inside the same
client.
So for the case there are two efl apps (A,B) , where A started the dnd and
the B is currently entered by the dnd, then A has the data source, and B
has the offer, if B sets a action on the offer A tried to set it on a
field which does not exist there, this fixes that. It saves the action
to a undepended field.
Thiep Ha [Fri, 23 Sep 2016 08:51:37 +0000 (17:51 +0900)]
text/entry: add more key controls for os x
In OS X, cmd-c,v, ... keys are used instead of ctrl-c,v...,
this patch adapts these key handlings.
Thiep Ha [Fri, 23 Sep 2016 08:49:34 +0000 (17:49 +0900)]
ecore_cocoa: quit application with key
In OS X, cmd-q is used to quit application,
this patch adds that feature.
Jean-Philippe Andre [Fri, 23 Sep 2016 08:28:57 +0000 (17:28 +0900)]
evas_fb: Avoid invalid dereference
If buf->priv.fb.fb was NULL the function would have crashed. So
buf->priv.fb.fb can't be NULL. I'm keeping the if(buf->priv.fb.fb)
anyway, but not sure the else case is valid.
Thanks @jiin.moon for the report.
Jee-Yong Um [Fri, 23 Sep 2016 02:56:19 +0000 (11:56 +0900)]
edje_cc: allow combine lazEDC keywords
Summary:
Fix parsing error which occurs when lazEDC keyword is combined
with other keyword by period. (like parts.rect)
@fix
Test Plan: Download attached file and run "make"
Reviewers: Hermet, cedric, jpeg
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D4309
Jean-Philippe Andre [Thu, 22 Sep 2016 11:45:04 +0000 (20:45 +0900)]
evas: Prevent crashes in case of error
SEGV would happen if the cache was NULL, as the error pointer
was also NULL in some cases (root cause for cache == NULL not
quite known, happens in elm_suite with CK_FORK=no).
Note: simply adding evas_common_init() to evas_init() leads to
a whole new set of issues with CK_FORK=no elm_suite - not good.
Jean-Philippe Andre [Thu, 22 Sep 2016 06:24:40 +0000 (15:24 +0900)]
elm_image: Add smart cbs for async open
This adds a few callbacks to inform applications about
async open and preload:
- load,open
- load,ready
- load,error
- load,cancel
This patch adds a new EAPI as well: elm_image_async_open_set.
This is the only way to use async file open with the legacy APIs
and should be easily matched with whatever EO API we end up using
(be it based on promises or events).
Alter the test cases for make check as they were using the
unstable EO API which I just removed.
Thanks @arosis for the original patch. And sorry for the huge
delay in merging this.
See also: https://phab.enlightenment.org/D4215
@feature
WooHyun Jung [Fri, 23 Sep 2016 01:08:01 +0000 (10:08 +0900)]
elm: _propagate_event should react only when the obj is focused obj
In efl_ui_win, _evas_event_key_cb gives efl_event_callback_call,
though the focused object is not the window itself.
Becuase of this, _propagate_event was called twice for event single
key down.
So, now, _propagate_event returns itself whenever focused object is
not the win but it's called from efl_ui_win's event call.
The problem can be checked with following stpes.
1. elementary_test -> focus
2. Input any directions (ex: Down)
3. Focus movement happens twice for every single input.
Felipe Magno de Almeida [Thu, 22 Sep 2016 22:27:56 +0000 (19:27 -0300)]
eina-cxx: Implement aligned_union for GCC 4.9
Derek Foreman [Thu, 22 Sep 2016 19:52:14 +0000 (14:52 -0500)]
drm: Fix typoe
DRM_MODE_ATOMIC_ALLOW_MODSET should have been _MODESET
Chris Michael [Thu, 22 Sep 2016 18:26:05 +0000 (14:26 -0400)]
Merge branch 'devs/devilhorns/atomic'
This merge adds initial support for Atomic Modesetting and Nuclear
Pageflipping. These features require a new kernel (>= 4.8) and have
only been testing on Intel i915 drivers. There are runtime checks in
the code to only enable these features when supported so this should
not break anything for "normal users". For those lucky enough to be
able to use these features, please enjoy the buttery smoothness ;)
@feature
Derek Foreman [Thu, 22 Sep 2016 18:20:13 +0000 (13:20 -0500)]
ecore-drm2: Merge initial modesetting with atomic flip code
Chris Michael [Thu, 22 Sep 2016 18:18:58 +0000 (14:18 -0400)]
ecore-drm2: Use just DRM_MODE_ATOMIC_ALLOW_MODESET for initial setting
of mode
This fixes an issue where gl_drm engine would end up flickering
everytime a frame was being set.
Thanks derek ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 17:30:49 +0000 (13:30 -0400)]
ecore-drm2: Add support for Atomic Pageflips
This patch modifies our ecore_drm2_fb_flip code to use Atomic/Nuclear
pageflips.
NB: Works perfectly under software drm engine .. some flickering with the
gl_drm engine that needs investigating.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 16:35:23 +0000 (12:35 -0400)]
ecore-drm2: Add code to support setting DPMS levels via Atomic
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 16:28:07 +0000 (12:28 -0400)]
ecore-drm2: Add code to use Atomic for Edid if available
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 16:13:18 +0000 (12:13 -0400)]
ecore-drm2: Add code to setup Plane Atomic state for Outputs
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 16:01:38 +0000 (12:01 -0400)]
ecore-drm2: Add code to setup Connector Atomic state for Outputs
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 16:00:53 +0000 (12:00 -0400)]
ecore-drm2: Add code to setup Crtc Atomic state for Outputs
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 15:42:57 +0000 (11:42 -0400)]
ecore-drm2: Add code to free Atomic state on shutdown
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 15:07:17 +0000 (11:07 -0400)]
ecore-drm2: Add code to fill Plane Atomic state
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 15:02:49 +0000 (11:02 -0400)]
ecore-drm2: Add code to fill Connector Atomic state
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 14:58:27 +0000 (10:58 -0400)]
ecore-drm2: Add code to fill Atomic Crtc State
This patch adds code to enable Atomic Modesetting support (via ioctl)
and to fill in Atomic Crtc state during startup.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 14:34:03 +0000 (10:34 -0400)]
ecore-drm2: Add code to check if Atomic Modesettting is usable
This code will detect the drm driver name and check that the kernel
itself is new enough to use Atomic Modesetting. This is needed as some
drivers (i915) do not handle Atomic Modesetting propertly without a
new enough kernel.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 13:35:44 +0000 (09:35 -0400)]
ecore-drm2: Add private structures to support Atomic Modesetting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 22 Sep 2016 17:50:09 +0000 (13:50 -0400)]
elementary: Remove unused but set variable in test_image
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Shuhrat Dehkanov [Thu, 22 Sep 2016 13:57:28 +0000 (22:57 +0900)]
elm: remove dulicate ELM_POPUP_ACTION_BUTTON_MAX definition
Summary: ELM_POPUP_ACTION_BUTTON_MAX is already defined in the included header file, elm_widget_popup.h.
Reviewers: cedric, jpeg, minkyu, Hermet
Reviewed By: Hermet
Subscribers: seoz, jehun.lim
Differential Revision: https://phab.enlightenment.org/D4312
Tom Hacohen [Thu, 22 Sep 2016 13:07:44 +0000 (14:07 +0100)]
Update gitignore.
Tom Hacohen [Thu, 22 Sep 2016 12:16:18 +0000 (13:16 +0100)]
Eo: introducing libeo_dbg.so.
This has been in the making for a very long time. Thanks to Marcel for
reminding me to do it.
What is it?
This is a tool to help application developers debug their apps with
everything Eo. Eo is strict, but not as strict as it can be. Many strict
tests and debug are very expensive to implement, and we have so many
hot-paths that even basic "ifs" to check if debugging is enabled will
add significant overhead to normal running applications. This is why I
created this library. All the expensive tests and bookkeeping should be
wrapped around with "#ifdef EO_DEBUG". With this change, libeo.so is
compiled twice, once normally, and once with this define set (as
libeo_dbg.so). This means that normal eo code will not be affected, but
if you decide to debug your application, all you need to do is:
LD_PRELOAD=/path/to/libeo_dbg.so ./app
Or use the convenient wrapper:
eo_debug ./app
Which will load the debug heavy version.
What's currently there: at the moment, EO_DEBUG enables xref and
data_xref and stricter tests when fetching object data.
In the future, I also plan introducing "zombie objects", which
essentially mean that objects are never really deleted, so you can query
them long after they are gone to get more information on what they were.
So if for example you have an object id that you want to query after the
object has been deleted, you can.
I also plan on having a way to disable/enable certain debug mode
features via env vars, and maybe make the test suite link against this
one instead of the normal one, and possibly add more internal hooks for
the test suite to better inspect internal state?
P.S: The amount of errors spewed out when running it on elementary_test
makes me wish I wrote this earlier. :(
@feature
Stefan Schmidt [Thu, 22 Sep 2016 09:44:59 +0000 (11:44 +0200)]
modules: emotion: fix event name after EFL Canvas Video convert
In commit
7b90e1147442d6a8023422400bffd77e2815fe0b the event name changed but
this module was not updated. Luckily we are building it on Jenkins or it would
have gone unnoticed for a long time.
Stefan Schmidt [Thu, 22 Sep 2016 09:43:34 +0000 (11:43 +0200)]
examples: emotion: fix event naming after convert to EFL Canvas Object
In commit
7b90e1147442d6a8023422400bffd77e2815fe0b the event names changed
but examples have not been updated.
Jean-Philippe Andre [Thu, 22 Sep 2016 03:36:27 +0000 (12:36 +0900)]
elm_image: Move back download events to legacy only
The events for (async) image download will be redefined by
@cedric later. So, remove them from eo now and only keep their
legacy implementation.
Also, improve elm_test example and add docs.
Amitesh Singh [Thu, 22 Sep 2016 05:04:54 +0000 (10:34 +0530)]
photocam: add missing EOLIAN prefix
Hosang Kim [Wed, 21 Sep 2016 11:44:53 +0000 (20:44 +0900)]
scrollable_interface: fixed gravity_set() API.
Summary: elm_scroller_gravity_set() API is not working.
Test Plan: elementary_test -> scroller3
Reviewers: jaehwan, SanghyeonLee, Hermet, jypark, raster, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4252
Carsten Haitzler (Rasterman) [Wed, 21 Sep 2016 23:31:04 +0000 (08:31 +0900)]
Revert "edje/edje_cc: use strncpy() instead of strcpy()."
This reverts commit
ab1a72f5e7df6fe0adef54bdcddd9867a2ebe3a6.
just dismiss in coverity if the code is not actually wrong
Carsten Haitzler (Rasterman) [Wed, 21 Sep 2016 23:31:00 +0000 (08:31 +0900)]
Revert "edje edje_embryo: use strncpy()."
This reverts commit
06bd8dcf330fe31891475c92aa340d4886f47e2b.
just dismiss in coverity if the code is not actually wrong
Carsten Haitzler (Rasterman) [Wed, 21 Sep 2016 23:30:37 +0000 (08:30 +0900)]
Revert "edje edje_cc_out: use strncpy()."
This reverts commit
6de3b2c5d36993cf3dbe94e8fbefd04043f91740.
just dismiss in coverity if the code is not actually wrong
Cedric BAIL [Wed, 21 Sep 2016 23:19:26 +0000 (16:19 -0700)]
ecore,ecore_con: simplify destructor by linking future life cycle with object.
maxerba [Wed, 21 Sep 2016 19:40:50 +0000 (21:40 +0200)]
Updating slovenian translation
Yeshwanth Reddivari [Wed, 21 Sep 2016 17:37:59 +0000 (10:37 -0700)]
emotion: convert Emotion_Object into Efl.Canvas.Video
Reviewers: singh.amitesh, raster, jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D3994
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Wed, 21 Sep 2016 17:34:05 +0000 (10:34 -0700)]
emile: fix typos.
Cedric BAIL [Wed, 21 Sep 2016 17:33:44 +0000 (10:33 -0700)]
eet: fix gnutls support with newer version.
Stefan Schmidt [Wed, 21 Sep 2016 08:56:36 +0000 (10:56 +0200)]
tests: elm_win: fix compiler warning about signed vs. unsigned comparison
The variable i only goes from 0 to 4 here but it gets compared against a normal
int so we make sure i also is a normal int.
Stefan Schmidt [Wed, 21 Sep 2016 08:41:58 +0000 (10:41 +0200)]
elm: progressbar: hide unit if unit_format_func is invalid
In commit
03882d558824f657f5c5a54fcd2d632eafeafd87 this was introduced but in
the end the visible signal was send in all cases. This looks like an oversight
to me. Fixed.
Stefan Schmidt [Wed, 21 Sep 2016 08:29:18 +0000 (10:29 +0200)]
evas: model_save: remove unused label after error handling change
In commit
8272d1492796657978c5591971768d37d4e15a7e the error handling was
moved upwards and the need for the goto label removed. Catching up here and
removing the label as well.
Sungtaek Hong [Wed, 21 Sep 2016 08:40:53 +0000 (17:40 +0900)]
evas: remove unnecessary check for clip coords.
Summary: (dst_clip_w <= 0 || dst_clip_h <= 0) is already checked.
Reviewers: jpeg, cedric, Hermet
Reviewed By: Hermet
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4303
Thiep Ha [Wed, 21 Sep 2016 07:54:09 +0000 (16:54 +0900)]
elm_config: add null check before usage
Thiep Ha [Wed, 21 Sep 2016 07:49:12 +0000 (16:49 +0900)]
elm_atspi: remove redundant null checking
The type is always _ADDED or _REMOVED, therefore atspi_desc
is always "add" or "remove"; no need to have null checking for it.
Hermet Park [Wed, 21 Sep 2016 07:24:42 +0000 (16:24 +0900)]
evas software_engine: ++safety code.
Hermet Park [Wed, 21 Sep 2016 06:19:19 +0000 (15:19 +0900)]
edje edje_cc_out: use strncpy().
This change is not much meaningful but avoids an annoying coverity detection.
Hermet Park [Wed, 21 Sep 2016 06:03:11 +0000 (15:03 +0900)]
edje edje_embryo: use strncpy().
This change is not meaningful but avoids an annoying coverity detection.
Hermet Park [Wed, 21 Sep 2016 04:30:44 +0000 (13:30 +0900)]
edje/edje_cc: use strncpy() instead of strcpy().
strncpy() is better for security.
Also, this change avoids annoying coverity detection.
Hermet Park [Wed, 21 Sep 2016 04:16:36 +0000 (13:16 +0900)]
evas engine: correct null check
check null first, before access it.
Hermet Park [Wed, 21 Sep 2016 04:06:18 +0000 (13:06 +0900)]
Revert "evas engine: return as soon as possible if the surface or context is not valid."
This reverts commit
2f158ebe65cc3d007c1eae0e25590f092931ee25.
misunderstood ^ operator.
pinged by jpeg.
previous code was correct.
Hermet Park [Wed, 21 Sep 2016 03:24:49 +0000 (12:24 +0900)]
evas engine: return as soon as possible if the surface or context is not valid.
And later, the surface and context are accessed.
So both of arguments should be valid necessarily.
Felipe Magno de Almeida [Wed, 21 Sep 2016 02:30:13 +0000 (23:30 -0300)]
eo-cxx: Add progress to future and promise
JunsuChoi [Tue, 20 Sep 2016 14:34:17 +0000 (23:34 +0900)]
edje_edit : add null check and close eet
Signed-off-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
JunsuChoi [Tue, 20 Sep 2016 14:23:29 +0000 (23:23 +0900)]
edje_decc: modified fclose location
modified fclose location. because of file pointer can become NULL.
Signed-off-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Bruno Dilly [Tue, 20 Sep 2016 23:13:25 +0000 (16:13 -0700)]
ecore_con,elput: fix warnings
Summary:
elput: fix warning for unused write result
ecore_con: fix warning for unused asprintf result
Reviewers: iscaro, devilhorns, cedric
Reviewed By: cedric
Subscribers: cedric, seoz, jpeg
Differential Revision: https://phab.enlightenment.org/D4308
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 23:07:18 +0000 (16:07 -0700)]
elm_progressbar: show status when unit_format_func is set
Summary:
- elm,state,units,visible signal is emitted only when
unit is set, but not when unit_format_func is set.
- Since default unit has been set, this signal is emitted
but signal will not be emitted after unit is set to NULL.
Test Plan:
1. Create a progressbar.
2. elm_progressbar_unit_format_set(obj, NULL);
3. set unit_format_func by elm_progressbar_unit_format_function_set()
and observe elm.text.status part visible.
Reviewers: Hermet, jpeg, cedric
Reviewed By: cedric
Subscribers: D-TAU, eunue, conr2d, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4210
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Piotr Ganicz [Tue, 20 Sep 2016 21:46:11 +0000 (14:46 -0700)]
atspi: fix parent-child relationship for elm_list and elm_toolbar
Summary:
This patch provides proper parent-child relationship for elm_list and elm_toolbar
while atsapi_mode is set for icon and end element.
This patch is moved from:
bf188e59431ad9c4ca877b2632884d3d430de6b1
Change-Id: Iae855aacf29bef3808a0b5ec159f46cbf0f4539d
Reviewers: stanluk, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4259
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Piotr Ganicz [Tue, 20 Sep 2016 21:44:53 +0000 (14:44 -0700)]
atspi: fix state macros
Summary:
This patch changes the value of 1 to 1ULL in STATE_TYPE macros
to signal the compiler that the value must be considered
as a unsigned long long, it has to be done cause state_set variable
can be longer than 32 bits.
This patch is moved. Orginal commit hash:
a559e473c21c8da7c4e5a87b9c8583ce519cc35e
Change-Id: Ida89f3be185736f61543d37010d0f5cb8d80a751
Reviewers: cedric, stanluk
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4260
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
jiin.moon [Tue, 20 Sep 2016 21:22:33 +0000 (14:22 -0700)]
eet: fix memory leak
Summary:
If ef is null, have to return before _set_material_to_eet_file_from_mesh api.
New momory will be allocated in the api.
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4305
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 21:20:48 +0000 (14:20 -0700)]
eet: set alpha_texture for ETC1+Alpha
Summary:
alpha_texture need to be set EINA_TRUE to support ETC1+Alpha
@fix
Test Plan:
Create an EDC file with png image with Alpha.
compress image with ETC1 and ETC2.
Observe Alpha is properly applied in both case.
Reviewers: jpeg, Hermet, cedric
Reviewed By: cedric
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4307
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Stephen Houston [Tue, 20 Sep 2016 21:02:33 +0000 (16:02 -0500)]
Evas: Don't access members of a null struct. Fixes T4616
Gustavo Sverzut Barbieri [Tue, 20 Sep 2016 18:00:17 +0000 (15:00 -0300)]
libproxy: dlopen() and make it runtime optional.
Artem Popov [Tue, 20 Sep 2016 16:52:23 +0000 (19:52 +0300)]
ecore_file: Fix improper way of comparing in ecore_file_path_dir_exists @fix
Summary: There is wrong comparing while using strcmp function. Should be inverted.
Reviewers: cedric, raster, NikaWhite
Reviewed By: NikaWhite
Subscribers: cedric, NikaWhite, jpeg
Differential Revision: https://phab.enlightenment.org/D4291
Derek Foreman [Tue, 20 Sep 2016 16:33:33 +0000 (11:33 -0500)]
eina_cpu, evas: Remove _eina_cpu_fast_core_get, don't set render thread affinity
We've decided it would be best to just let the scheduler do its job.