Konstantin Baladurin [Mon, 9 Oct 2017 17:21:22 +0000 (20:21 +0300)]
[GDBJIT] Make gdbjit thread-safe & bug fix (dotnet/coreclr#14390)
* [GDBJIT] Fix DW_AT_comp_dir setting
We should use cuPath to set dirPath in NotifyGdb::EmitDebugInfo instead of
DebugString[1].
* [GDBJIT] Make gdbjit thread-safe
NotifyGdb::MethodPrepared method can be called from multiple threads
simultaneously in this case gdbjit will work incorrectly as it uses
global variable without synchronization.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ba964d19b84a690a451a61a38fa12c4ebf4f890
dotnet-maestro-bot [Sat, 7 Oct 2017 15:52:05 +0000 (10:52 -0500)]
Update CoreFx, PgoData to preview1-25807-01, master-
20171007-0052, respectively (dotnet/coreclr#14378)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b4734edeacf5f93404edc0f1ee35963ae53270f
Jan Vorlicek [Sat, 7 Oct 2017 09:56:24 +0000 (11:56 +0200)]
Fix numa build break (dotnet/coreclr#14370)
This change fixes a break in build of coreclr on machines with libnuma
installed. The problem was that the numa header contains a couple of
inlined functions and we were using one of them. That made it to
have a hard reference to a function from the numa library that we
need to be soft so that coreclr can work even on machines without
the libnuma installed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
909a772b034e1259507f3a84b8e7477c688095ca
Bruce Forstall [Sat, 7 Oct 2017 01:42:37 +0000 (18:42 -0700)]
Merge pull request dotnet/coreclr#14353 from BruceForstall/ArmAssertFixes
Fix RyuJIT/arm32 asserts
Commit migrated from https://github.com/dotnet/coreclr/commit/
b230bf9f9f71284f913724f33ac08979b5adee73
Jan Kotas [Sat, 7 Oct 2017 00:51:29 +0000 (17:51 -0700)]
Delete dead code (dotnet/coreclr#14365)
Delete some dead code related to Windows Phone and code access security
Commit migrated from https://github.com/dotnet/coreclr/commit/
44736b809edaacc39d9bab1d18e04067e3fdb13d
Stephen Toub [Sat, 7 Oct 2017 00:25:43 +0000 (20:25 -0400)]
Merge pull request dotnet/coreclr#14369 from stephentoub/fix_cont_handling
Fix handling of continuations for captured context
Commit migrated from https://github.com/dotnet/coreclr/commit/
273b482fd0345de3dadad6fee4544517b2b8de62
Stephen Toub [Fri, 6 Oct 2017 22:38:00 +0000 (18:38 -0400)]
Fix handling of continuations for captured context
My recent delegate optimization for async methods introduced a race condition that breaks posting back to a captured context. If the awaited task completes between the time we check IsCompleted and when we try to store the continuation into the Task, we need to queue the continuation for execution, but my change incorrectly queued it to the thread pool rather than to the captured context.
Commit migrated from https://github.com/dotnet/coreclr/commit/
702670e3040fa2c49782da16409e557409ada445
Stephen Toub [Fri, 6 Oct 2017 22:12:27 +0000 (18:12 -0400)]
Merge pull request dotnet/coreclr#14352 from stephentoub/datetime_span
Add Span-based methods to DateTime{Offset}
Commit migrated from https://github.com/dotnet/coreclr/commit/
5fed4faadbdb99a1774c1921ece0e8408643ba10
Bruce Forstall [Fri, 6 Oct 2017 05:14:08 +0000 (22:14 -0700)]
Fix RyuJIT/arm32 asserts
Fix dotnet/coreclr#14199: propagate `GTF_EXCEPT` bits from the end of `GT_FIELD_LIST`
lists to the beginning, to avoid "Missing flags on tree" asserts.
Fix dotnet/coreclr#14198: for RyuJIT/arm32, `GT_BITCAST` needs to be a MultiRegOp.
This is required when a varargs function, which includes the tailcall
helper, needs to pass a double in integer registers. We can end up
with `GT_PUTARG_REG/long(GT_BITCAST/long(double tree))`.
Fixed various GenTree node flags dumping issues.
Commit migrated from https://github.com/dotnet/coreclr/commit/
39569ec9e5ea675f5daf0bed8d2fde0ae3421110
Stephen Toub [Fri, 6 Oct 2017 21:34:04 +0000 (17:34 -0400)]
Merge pull request dotnet/coreclr#14333 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02106-01, preview1-25806-01, preview1-25806-02, master-
20171006-0051, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
df20715d46403a238953d2839887248fecd75ea4
Tomas Weinfurt [Fri, 6 Oct 2017 20:30:24 +0000 (13:30 -0700)]
undef NULL to fix compilation problems on FreeBSD after 08d39dd. (dotnet/coreclr#14341)
* undef NULL to fix compilation problems on FreeBSD after 08d39dd.
* remove unneccesary #ifndef NULL
Commit migrated from https://github.com/dotnet/coreclr/commit/
d379aa3040c9c55bf596709c5858cfc81b9762b6
Stephen Toub [Fri, 6 Oct 2017 20:19:00 +0000 (16:19 -0400)]
Fix asserts in Unix build
Commit migrated from https://github.com/dotnet/coreclr/commit/
d06905be39bebfea9c5c3950b39804a0e6d799e2
Sergey Andreenko [Fri, 6 Oct 2017 19:37:20 +0000 (12:37 -0700)]
impImportCall: make the failed imports obvious. (dotnet/coreclr#14343)
* impImportCall: make the failed imports obvious.
Delete unnecessary and confusing dependency on callRetType.
* delete unreached code that calls impImportCall
Commit migrated from https://github.com/dotnet/coreclr/commit/
6aa119dcdb88ba1157191600a992aa94eee59b22
Jan Kotas [Fri, 6 Oct 2017 18:11:35 +0000 (11:11 -0700)]
Reorder checks in CEEInfo::getClassLayout (dotnet/coreclr#14356)
Check for native value type has to be first to handle byref-like native value types correctly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
643b09f966e68e06d5f0930755985a01a2a2b096
Brian Sullivan [Fri, 6 Oct 2017 17:59:39 +0000 (10:59 -0700)]
Merge pull request dotnet/coreclr#14329 from sdmaclea/PR-ARM64-ATOMIC-OPS
[Arm64] Implement GT_XADD, GT_XCHG, GT_CMPXCHG ...
Commit migrated from https://github.com/dotnet/coreclr/commit/
77b5ee4f53eb6a098898afbba1c8d85cb9a632d8
Stephen Toub [Fri, 6 Oct 2017 16:34:08 +0000 (12:34 -0400)]
Merge pull request dotnet/coreclr#14358 from stephentoub/convertspan
Add Span-based Convert Base64 methods
Commit migrated from https://github.com/dotnet/coreclr/commit/
573796d3727e474e7075d5d4184faa1d36a502d1
Steve MacLean [Fri, 6 Oct 2017 15:25:14 +0000 (11:25 -0400)]
Fix comments per review
Commit migrated from https://github.com/dotnet/coreclr/commit/
f6c7baa1a34a2542c7d9c4946a486f2cef78c49b
Jan Vorlicek [Fri, 6 Oct 2017 14:35:26 +0000 (16:35 +0200)]
Remove explicit dependency on libnuma (dotnet/coreclr#14359)
Currently, when coreclr is built on machine that has libnuma installed,
it adds libnuma to its dependencies and so it cannot be used on machines
that don't have libnuma installed. But that is not necessary, the
dependency was changed to soft dependency - PAL loads it only if it is
present and falls back to the non-numa behavior if it is not found.
This change removes the hard libnuma dependency.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b3230750776043f0e78e5adb60e8130580591a8
dotnet-maestro-bot [Fri, 6 Oct 2017 14:20:56 +0000 (07:20 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02106-01, preview1-25806-01, preview1-25806-02, master-
20171006-0051, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7ba9483fc912a41178783ec082398e5af110e3a
Stephen Toub [Thu, 5 Oct 2017 23:30:07 +0000 (19:30 -0400)]
Add DateTime{Offset}.TryFormat methods
The existing implementations just format to a StringBuilder and then get the string from that StringBuilder. For now at least, these TryFormats share the same code, and just copy the StringBuilder to the span instead of using ToString.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e4533291b47ff4292bed37dd18d1e4d4658e0cf1
Stephen Toub [Thu, 5 Oct 2017 21:47:49 +0000 (17:47 -0400)]
Add DateTime{Offset} span-based {Try}Parse{Exact} overloads
Commit migrated from https://github.com/dotnet/coreclr/commit/
f87bf901f58edff70a0a3c30fd3c7a1f2965949f
Stephen Toub [Thu, 5 Oct 2017 21:23:41 +0000 (17:23 -0400)]
Address perf issues
Workaround regressions from the span switch and also fix a few other issues that popped while profiling.
- Specialize Compare{String} methods to take one span and one string
- Ensure frequently called methods get inlined
- Avoid unnecessary writes to a ref
- Avoid unnecessary Math.Pow calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
92408358a76eb9b908b9e9ce317f2386617f64d1
Stephen Toub [Fri, 8 Sep 2017 14:25:01 +0000 (10:25 -0400)]
Remove StringBuilder allocations from roundtrip format DateTime parsing
Commit migrated from https://github.com/dotnet/coreclr/commit/
78ae3ab5ed9e198599a4577aa6ae73f053ac1c02
Stephen Toub [Fri, 8 Sep 2017 13:57:55 +0000 (09:57 -0400)]
Add IsValidYear/Day overrides to GregorianCalendar
The base implementation makes several virtual calls that the derived implementation can avoid.
Commit migrated from https://github.com/dotnet/coreclr/commit/
63829851715ecf694bbdb07bc5677d6df83a4b15
Stephen Toub [Fri, 8 Sep 2017 14:05:22 +0000 (10:05 -0400)]
Avoid slicing/extra method call while tokenizing in common case
Commit migrated from https://github.com/dotnet/coreclr/commit/
89a825e4a74445bdf29b9114a209ed45f16ddc79
Stephen Toub [Fri, 8 Sep 2017 13:52:05 +0000 (09:52 -0400)]
Move DateTimeParse to use spans internally
So that we can reuse the same implementation for the public span-based APIs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
99fa77856e5c871e9feaa94e16badd23df7217f3
Stephen Toub [Fri, 6 Oct 2017 12:21:47 +0000 (08:21 -0400)]
Add Span-based Convert Base64 methods
Commit migrated from https://github.com/dotnet/coreclr/commit/
d739ce4748863e944a83702fac7f5174b8ba6ffb
Michelle McDaniel [Fri, 6 Oct 2017 12:15:16 +0000 (05:15 -0700)]
Disable PGO optimization on linux (dotnet/coreclr#14290)
With the update to llvm 3.9, the pgo data is incompatible since it was
generated with llvm 3.6. Currently, both the pgo data generation builds
and the automatic updates of counts are currently down, so pgo data is
not being updated. Until these problems are fixed, disable pgo
optimization for release builds on linux.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9c6e5b689e043beccdb97385727367e5f0277ac1
Tomas Weinfurt [Fri, 6 Oct 2017 08:43:54 +0000 (01:43 -0700)]
enable lttng for FreeBSD. (dotnet/coreclr#14342)
* enable lttng for FreeBSD. it is supported for user space
* unify Linux and FreeBSD branches for lttng. At lest for now, they are identical
Commit migrated from https://github.com/dotnet/coreclr/commit/
46e6857e92f9dfbd248217ccf1f42ff70e2763dd
Bruce Forstall [Fri, 6 Oct 2017 05:31:17 +0000 (22:31 -0700)]
Merge pull request dotnet/coreclr#14253 from wateret/fix-14251
[RyuJIT/armel] Fix regression
Commit migrated from https://github.com/dotnet/coreclr/commit/
60374d77dacc076b30673c37ddace25d12cabcd9
Jan Kotas [Tue, 3 Oct 2017 04:28:12 +0000 (21:28 -0700)]
Update Microsoft.NETCore.Native package (dotnet/corertdotnet/coreclr#4646)
Partial port of https://github.com/dotnet/coreclr/pull/10264
Fixes dotnet/coreclr#4640
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
6ef58bae7c5ffc966cae00d37906769e66b98485
Jan Vorlicek [Fri, 6 Oct 2017 01:12:04 +0000 (03:12 +0200)]
Update CentOS 6 and 7 docker images (dotnet/coreclr#14349)
The images now contains clang 3.9 with PGO support
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e033eabe262457733b7f4f8045083eb1baca582
Steve MacLean [Thu, 5 Oct 2017 22:10:45 +0000 (18:10 -0400)]
[Arm64] Respond to feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
fdf8606b62288725caf4ba04fed7e3aaf3f03e5a
Koundinya Veluri [Thu, 5 Oct 2017 19:06:07 +0000 (12:06 -0700)]
Fix new deadlock possibility in ReaderWriterLockSlim from a recent change (dotnet/coreclr#14337)
Fix new deadlock possibility in ReaderWriterLockSlim from a recent change
Fixed the following scenario that would lead to deadlock (rare, but frequently reproducible if code is changed):
- Thread T0 signals the write waiter event or the upgradeable read waiter event to wake a waiter
- There are no threads waiting on the event, but T1 is in WaitOnEvent() after exiting the spin lock and before actually waiting on the event (that is, it's recorded that there is one waiter for the event). It remains in this region for a while, in the repro case it typically gets context-switched out.
- T2 acquires the RW lock in some fashion that blocks T0 or T3 from acquiring the RW lock
- T0 or T3 fails to acquire the RW lock enough times for it to enter WaitOnEvent for the same event as T1
- T0 or T3 resets the event
- T2 releases the RW lock and does not wake a waiter because the reset at the previous step lost a signal but _waiterStates was not updated to reflect that
- T1 and other threads begin waiting on the event, but there's no longer any thread that would wake them
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e43a10cdb136cc1213b1f5b2db406b9830108e4
Andy Ayers [Thu, 5 Oct 2017 18:31:58 +0000 (11:31 -0700)]
JIT: More type equality opts (dotnet/coreclr#14317)
* JIT: Wrap some runtime lookups in new node type
Work based on the plan outlined in dotnet/coreclr#14305.
Introduce a new unary node type GT_RUNTIMELOOKUP that wraps existing
runtime lookup trees created in `impLookupToTree` and holds onto the
handle that inspired the lookup.
Note there are other importer paths that create lookups directly that
we might also want to wrap, though wrapping is not a requirement for
correctness.
Keep this node type around through morph, then unwrap and just use
the wrapped node after that.
* JIT: More enhancements to type equality testing
The jit is now able to optimize some type equality checks in shared
method instances where one or both of the types require runtime lookup,
for instance comparing `T` to a value type, or comparing two different
value types `V1<T>` and `V2<T>`.
Add two new jit interface methods, one for testing for type equality and
the other for type casting.
These return Must/MustNot/Maybe results depending on whether or not
the equality or cast can be resolved at jit time.
Implement the equality check. Use this to enhance the type equality opts
in the jit for both direct comparison and the checking done by unbox.any.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b085bfacb5eed105e3e55681f75c5413d91c1f86
Sergey Andreenko [Thu, 5 Oct 2017 18:21:19 +0000 (11:21 -0700)]
fix gtDispTree (dotnet/coreclr#14326)
* fix gtDispTree
It is legal situation when we pass ILNone (for example for local stores:
gtDispChild(tree->gtOp.gtOp1, indentStack, IINone);). In this code we
poped value and didn't push anything back, it ended with the stack
underflow.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c18b66b6f4cc904065f8abaa442fd112493a36c
Hanjoung Lee [Fri, 29 Sep 2017 09:50:16 +0000 (18:50 +0900)]
[RyuJIT/armel] Fix regression
Fix calling a function passing double-type stack arguments.
Fix dotnet/coreclr#14251
Commit migrated from https://github.com/dotnet/coreclr/commit/
045492911eec18308c360e70f08de3baee13c199
Konstantin Baladurin [Thu, 5 Oct 2017 10:07:31 +0000 (13:07 +0300)]
[SOS] Fix address types inconsistency (dotnet/coreclr#14188)
GetObjFieldOffset function expects that cdaObj and cdaMT arguments
have CLRDATA_ADDRESS type (sign-extended) but in some cases we
use TADDR instead of CLRDATA_ADDRESS that isn't sign-extended.
Due to it some SOS commands (for example DumpRuntimeTypes) don't
work on x86 and ARM32.
Commit migrated from https://github.com/dotnet/coreclr/commit/
076a61ef2eb3baf69182139f36b948f104e3b740
Konstantin Baladurin [Thu, 5 Oct 2017 08:31:44 +0000 (11:31 +0300)]
[x86/Linux][SOS] Fix clrstack command of lldb sosplugin on x86 (dotnet/coreclr#13973)
* [x86/Linux][SOS] Add support for x86 in GetContextFromFrame
It's need for 'clrstack -f' command of SOS plugin on x86.
* [x86/Linux] Fix RtlpGetFunctionEndAddress function
We should use PTR_UNWIND_INFO instead of PUNWIND_INFO for pointer to
UNWIND_INFO structure because it's pointer from other process and
we need to use DAC to read data using it.
* [x86/Linux][SOS] Define DEBUG_STACK_CONTEXT for x86
It's needed for 'clrstack -f' command in libsosplugin.
* [x86/Linux] Fix undefined references in libmscordbi.so on x86
Asm block like following:
__asm fnsave currentFPUState
where currentFPUState is structure works with MSVC but leads to
undefined reference currentFPUState in the binary with other
compilers. So rewrite such asm blocks for them.
This patch fixes error "Unable to load 'libmscordbi.so'" during
execution of 'clrstack -f' command of SOS plugin on x86.
* [x86/Linux] Fix calling convention inconsistency
WINAPI and STDAPI are defined as __cdecl but in some cases functions
with these attributes are called using stdcall calling convention.
It leads to crashes during execution of 'clrstack -i' command of
SOS plugin on x86.
Commit migrated from https://github.com/dotnet/coreclr/commit/
de4daccc1ea52ddc1ae8ac9e48cde603c507b868
mikedn [Thu, 5 Oct 2017 05:04:26 +0000 (08:04 +0300)]
Fix condition flags reuse optimization (dotnet/coreclr#14323)
This optimization is not valid for unsigned LT/LE/GT/GE relops. Using the Carry flag this way indicates that the operation overflowed, not that the result is less than 0, that's impossible for unsigned integers.
This is also not valid for signed LT/LE/GT/GE relops due to integer overflow.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d0baa73f54eb0f7eba1364e207c02afa984760cb
Sergey Andreenko [Thu, 5 Oct 2017 04:34:26 +0000 (21:34 -0700)]
fgDebugCheckFlags should use OperMayThrow for all nodes. (dotnet/coreclr#14330)
GT_CATCH_ARG should not be marled as MayThrow.
Commit migrated from https://github.com/dotnet/coreclr/commit/
be23e23f76b37059db4756bd77f6feeb2eef2731
Bruce Forstall [Wed, 4 Oct 2017 23:29:46 +0000 (16:29 -0700)]
Tweaks for arm/arm64 altjit CI jobs (dotnet/coreclr#14306)
1. Make trigger phrase for default job include "Build And Test". Otherwise,
triggering a stress mode also causes the default job to be triggered.
2. Change the SetStressModes.bat creation command to be a single Jenkins
executed command, not multiple separate commands.
3. To aid debugging, display the resulting SetStressModes.bat script so it
gets captured in the run output log.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fafd08ca7db1b5535f2d472a2ed2d4a86abc26f9
Steve MacLean [Tue, 3 Oct 2017 18:23:57 +0000 (14:23 -0400)]
[Arm64] Implement GT_XADD, GT_XCHG, GT_CMPXCHG ...
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6c542efba8cf4f239ab6b97e4641d67c13ff564
Chris Rummel [Wed, 4 Oct 2017 22:02:48 +0000 (17:02 -0500)]
Merge pull request dotnet/coreclr#14328 from crummel/cmakeDocUpdate
Update official version of CMake.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff41d13691fd0e224d8632b683b731ffa7935820
Michelle McDaniel [Wed, 4 Oct 2017 21:50:47 +0000 (14:50 -0700)]
Merge pull request dotnet/coreclr#14315 from adiaaida/addPerfPipeline
Change name of perf-pipelinejobs to perf_pipelinejobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
58ea417e8a58706a448786f7fa606cdb22b8b6da
Chris Rummel [Wed, 4 Oct 2017 21:43:10 +0000 (16:43 -0500)]
Update official version of CMake.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e6e921755d37877e399729713c771cf3d2fb3907
Bruce Forstall [Wed, 4 Oct 2017 21:09:03 +0000 (14:09 -0700)]
Merge pull request dotnet/coreclr#14307 from fiigii/removeavxflag
[RyuJIT] Remove FEATURE_AVX_SUPPORT flag
Commit migrated from https://github.com/dotnet/coreclr/commit/
76dcdad7c77705e99b4077d81cfd8f22c3d01711
Brian Sullivan [Wed, 4 Oct 2017 20:52:18 +0000 (13:52 -0700)]
Merge pull request dotnet/coreclr#14294 from sdmaclea/PR-ARM64-EMIT-Exclusives
[Arm64] Add LD/ST exclusive emitters
Commit migrated from https://github.com/dotnet/coreclr/commit/
b14731d7de804a1d895ceaca43c94e37d5e79780
Brian Sullivan [Wed, 4 Oct 2017 20:51:50 +0000 (13:51 -0700)]
Merge pull request dotnet/coreclr#14318 from sdmaclea/PR-Fix-jump-bind-typo
[Arm64] Fix emitJumpDistBind typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2e373f2b1b96dde833a905d03bf21143820b3fe
Brian Sullivan [Wed, 4 Oct 2017 20:51:10 +0000 (13:51 -0700)]
Merge pull request dotnet/coreclr#14293 from sdmaclea/PR-ARM64-SMUL-DIS
[Arm64] Fix smul[lh] disassembly
Commit migrated from https://github.com/dotnet/coreclr/commit/
90fba838752eaec0ba2ff3dfc74985a8ad9b10de
Jan Kotas [Wed, 4 Oct 2017 15:39:18 +0000 (08:39 -0700)]
Move String.Searching.cs to shared CoreLib partition (dotnet/corertdotnet/coreclr#4673)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
238907f69662dda53dee0afd9848756a5bb790e9
Brian Sullivan [Wed, 4 Oct 2017 19:18:02 +0000 (12:18 -0700)]
Merge pull request dotnet/coreclr#14325 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
2de0bce49beeaf1bc6fcedd006114f4c8df7566a
Brian Sullivan [Wed, 4 Oct 2017 17:15:26 +0000 (10:15 -0700)]
Allow X86 Hardware intrinsics for non-Legacy 32-bit x86
Unit tests exisist for this functionality on x86 CoreCLR
[tfs-changeset: 1677287]
Commit migrated from https://github.com/dotnet/coreclr/commit/
44228205d9ce0c25d6f11638c17cfe07b1d7baab
Steve MacLean [Sat, 23 Sep 2017 05:10:20 +0000 (01:10 -0400)]
[Arm64] Fix emitJumpDistBind typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
406d2d6924e3df776ec4a57da0115d3514d81ff7
Steve MacLean [Tue, 3 Oct 2017 20:23:35 +0000 (16:23 -0400)]
[Arm64] Fix IF_LS_3D emitter
Commit migrated from https://github.com/dotnet/coreclr/commit/
fba51b04114bd0a8265455e32a33fdcb087124e2
Jan Kotas [Tue, 3 Oct 2017 23:25:20 +0000 (16:25 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#4663 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
65738239e7a50615d0fc50dcbe5b1b6086f96ef2
Stephen Toub [Wed, 4 Oct 2017 02:14:26 +0000 (22:14 -0400)]
Merge pull request dotnet/coreclr#14298 from stephentoub/stringconcat_char
Special-case T==char in string.Concat(IEnumerable<T>)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e67311def9f8eaf2dfad73df5090a63eb34c7f53
Stephen Toub [Wed, 4 Oct 2017 02:13:53 +0000 (22:13 -0400)]
Make CancellationTokenRegistration.Token public (dotnet/coreclr#14310)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6f006e03151b32b87045718b3011a920fda93dba
Jan Vorlicek [Wed, 4 Oct 2017 01:35:12 +0000 (03:35 +0200)]
Fix broken ARM64 build (dotnet/coreclr#14313)
The std::max was being passed arguments of different types (int and DWORD).
Commit migrated from https://github.com/dotnet/coreclr/commit/
10f5a84bfd5a38000e34f8ed75150110bb9440de
Fei Peng [Tue, 3 Oct 2017 23:37:56 +0000 (16:37 -0700)]
remove FEATURE_AVX_SUPPORT flag
Commit migrated from https://github.com/dotnet/coreclr/commit/
2fcfb32883e14bffab0511274d4bad25eb8301f9
Tomas Weinfurt [Tue, 3 Oct 2017 23:42:14 +0000 (16:42 -0700)]
Few build changes to support Freebsd (dotnet/coreclr#14121)
* also look for python27
* add more locations to search for lldb.h so it just work on FreeBSD
* add adm64 to ARCH selection. This is mostly cosmetic to avoild warning on FreeBSD
* add support for -osgroup=XXX - this is mostly for conistency. -OSGroup=FreeBSD is similar to freebsdmscorlib in build.cmd
* fix typo adm->amd
* add back fi removed by mistake
* add __HostDistroRid for FreeBSD
* adress fedback from review: make python lookup consistent - starting with most specific version. uddate warning message about lldb.h and remove composite flag
* feedback from review: type and small change on OSGroup syntax
* few more minor fixes
Commit migrated from https://github.com/dotnet/coreclr/commit/
858f5e0658a63c39eaf14c34a2146a34950c387f
Michelle McDaniel [Tue, 3 Oct 2017 22:55:38 +0000 (15:55 -0700)]
Change name of perf-pipelinejobs to perf_pipelinejobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
8e4352c7a753ce06d679fa1a1f752e900a66b296
Jose Perez Rodriguez [Tue, 3 Oct 2017 22:21:52 +0000 (15:21 -0700)]
Update Buildtools and Roslyn (dotnet/coreclr#14228)
* Update Buildtools and Roslyn
* Fixing importing of the roslyn files on msbuild 14.0
* Correctly looking for the latest VS Installation
Commit migrated from https://github.com/dotnet/coreclr/commit/
aae414026671e3dc1ccf0f308d351ac04cc746a4
Brian Sullivan [Tue, 3 Oct 2017 21:58:17 +0000 (14:58 -0700)]
Fix for x86 JIT build break
[tfs-changeset: 1677224]
Commit migrated from https://github.com/dotnet/coreclr/commit/
f87c34ccfc93a35407ce15468ee490779ff8e6c0
Michelle McDaniel [Tue, 3 Oct 2017 21:53:56 +0000 (14:53 -0700)]
Merge pull request dotnet/coreclr#14312 from adiaaida/addPerfPipeline
Add empty perf pipeline job
Commit migrated from https://github.com/dotnet/coreclr/commit/
3716918ee67ea2e8d8271c9a214159e56687f043
Bruce Forstall [Tue, 3 Oct 2017 21:06:59 +0000 (14:06 -0700)]
Merge pull request dotnet/coreclr#14295 from BruceForstall/FixArm64FastTailcallGSCookie
Put JIT64 compat assert under `_TARGET_AMD64_` ifdef
Commit migrated from https://github.com/dotnet/coreclr/commit/
790406c39e1ce3e0df8f557ae853caa2d7728c11
Michelle McDaniel [Tue, 3 Oct 2017 21:00:41 +0000 (14:00 -0700)]
Add empty perf pipeline job
This is step one of adding the pipeline job for performance runs. In
this change, we add perf-pipelinejobs.groovy, which defines what Jenkins
will see in the UI. perf-pipeline.groovy is basically an empty job, so
we can test the actual perf-pipeline work after this is checked in,
which is step two.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b19210d68ac8905c9017f8719010dd900b54c127
Stephen Toub [Tue, 3 Oct 2017 20:59:31 +0000 (16:59 -0400)]
Optimize Memory<T> to ReadOnlyMemory<T> cast (dotnet/coreclr#14309)
They have the same layout; we can just use Unsafe.As. In a microbenchmark that just repeatedly reads from a `Memory<byte>` field and writes it to a `ReadOnlyMemory<byte>` field, this doubles throughput.
Commit migrated from https://github.com/dotnet/coreclr/commit/
895a755d090ff04ed2e043e851dadc1c30f0cb35
Sergey Andreenko [Tue, 3 Oct 2017 20:38:02 +0000 (13:38 -0700)]
Fix IsSafeToContained. (dotnet/coreclr#14268)
When AliasSet adds a node, it should also add all its nodes that are
executed inside it (marked as contained).
Commit migrated from https://github.com/dotnet/coreclr/commit/
32bb7e16d5b741c12ed2388d44b5d736ae0ab240
Andy Ayers [Tue, 3 Oct 2017 20:29:00 +0000 (13:29 -0700)]
JIT: run type equality optimizations earlier (dotnet/coreclr#14244)
Refactor the type equality optimizations embedded in morph so that they can
also be invoked earlier, in particular, during importation. This allows the
importer to short-circut importing blocks that are provably unreachable. For
instance in generic methods with type specialization (via equality) the jit
will now selectively import just the applicable regions of the method. In some
cases this means the jit may avoid importing EH regions and so remove EH from
a specialized method all together.
Also, generalize the handle compare pattern to look through the handle indirs
that can arise when prejitting.
Running the type opts early also improves jit throughput a little.
Mark the embedded handle indirs as nonfaulting. Would also like to mark
them as invariant, but CSE gets overly enthusiastic and we see bad diffs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
aadf2b0e2230d716b7c9b822ff7cd4f90364e9e0
t-jekor [Wed, 5 Jul 2017 17:44:15 +0000 (10:44 -0700)]
Enable CLR Thread Pool via a MSBuild flag (default enabled on Unix)
This PR completes, adds tests for, and enables the CLR Thread Pool on Unix. It also adds Windows implementations for the low level primitives used in the CLR Thread Pool.
The thread pool is enabled by setting the MSBuild property FeaturePortableThreadPool to true, which is the default on Unix.
Supersedes dotnet/coreclr#4039.
Rebased and squashed replacement for original PR dotnet/coreclr#4124.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e0b592dfafe7735d7eef23198b772a771817d5c
Jan Vorlicek [Tue, 3 Oct 2017 20:09:43 +0000 (22:09 +0200)]
Fix build with latest Xcode on OSX (dotnet/coreclr#14282)
* Fix build with latest Xcode on OSX
The latest Xcode 9 cannot successfully build CoreCLR PAL. There are
several issues. First, it complains that min / max macros cannot be defined
in C++ code, since they would collide with the std::min and std::max
functions. Second, some of the headers that PAL includes pull in declarations
of several template classes that we explicitly define in PAL and also
the new operator declaration.
To fix that, I have undefined the min and max macros for PAL and replaced
their usage by the std::min / max functions. I have also removed the manual
declaration of the colliding template classes and new operator and added
inclusion of the proper C++ headers instead.
The PAL was including non-pal safemath.h and to make this change compatible
with it, I have added definition of USE_STL that makes safemath.h include
type_trait from STL instead of our local trimmed copy.
I have also removed some dead code that I have discovered during the process.
Fixes dotnet/coreclr#14279
* Fix build on ARM32 and very recent GLIBCXX
Commit migrated from https://github.com/dotnet/coreclr/commit/
08d39ddf02c81c99bd49c19b808c855235cbabdc
Carol Eidt [Tue, 3 Oct 2017 19:24:49 +0000 (12:24 -0700)]
Merge pull request dotnet/coreclr#14292 from sdmaclea/PR-ARM64-Unreached
[Arm64] Fix TODO-Cleanup add unreached
Commit migrated from https://github.com/dotnet/coreclr/commit/
4cfd557c2d1e80123d5a37aaea00636ddcc7be49
Carol Eidt [Tue, 3 Oct 2017 19:07:20 +0000 (12:07 -0700)]
Merge pull request dotnet/coreclr#14027 from mikedn/simd-eq-opt
Simplify some relop/jtrue related optimizations
Commit migrated from https://github.com/dotnet/coreclr/commit/
a27c269770c0ecd5ad2ea9e7159fe64ae24d702a
Steve MacLean [Mon, 2 Oct 2017 22:30:01 +0000 (18:30 -0400)]
[Arm64] Fix smul[lh] disassembly
Commit migrated from https://github.com/dotnet/coreclr/commit/
70165e7e97ec395c648835773d79653737e9029b
Konstantin Baladurin [Tue, 3 Oct 2017 18:28:06 +0000 (21:28 +0300)]
[SOS] Use addresses without sign extension in lldb plugin (dotnet/coreclr#14009)
lldb doesn't expect sign-extended addresses so we need to convert
them before using with lldb API.
This patch allows to use SOS plugin for core files in lldb on 32-bit
platforms and also fixes output of the 'clrstack -f' command.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ad0b6a18fe24864ff11760e9b313a0d6dbe9d3b
Stephen Toub [Tue, 3 Oct 2017 15:29:06 +0000 (11:29 -0400)]
Special-case T==char in string.Concat(IEnumerable<T>)
This allows string.Concat to be used as an efficient mechanism for creating a `string` from an `IEnumerable<char>`. The JIT specializes the implementation for char vs non-char, so there's minimal impact on the non-char case, and for the char case, we a) avoid creating a string for each individual char, and b) use StringBuilder's fast path for adding individual chars. This can result in a massive allocation savings for long enumerations (for <= 1 char, there's no difference, but each character after that is an allocation saved), and for more than a few characters can yield up to a 2x increase in throughput.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5236ffd6679b3380327fd43cbc4fdfca208a0edd
Konstantin Baladurin [Tue, 3 Oct 2017 11:08:06 +0000 (14:08 +0300)]
[x86/Linux] Fix regdisplay initialization in case of WIN64EXCEPTIONS (dotnet/coreclr#14296)
Method Debugger::IsThreadAtSafePlaceWorker for x86 sets values only
for ControlPC and PCTAddr fields of REGDISPLAY but there is assert
in StackFrameIterator::Init that checks that field pCurrentContext
is not NULL if WIN64EXCEPTIONS is defined.
This patch uses FillRegDisplay function to correctly initialize
regdisplay in case of WIN64EXCEPTIONS.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8eb9adbe7f069638c1457b458c2c5a569eaaabf8
Bruce Forstall [Tue, 3 Oct 2017 03:03:00 +0000 (20:03 -0700)]
Put JIT64 compat assert under `_TARGET_AMD64_` ifdef
Fixes dotnet/coreclr#14205
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8f72d4e07bbed9beab7ac16f9744d425631a340
Sergey Andreenko [Tue, 3 Oct 2017 02:09:01 +0000 (19:09 -0700)]
delete the old workaround. (dotnet/coreclr#14288)
gcc is not supported.
Commit migrated from https://github.com/dotnet/coreclr/commit/
71f15df5a6d2c003f3c132b07a103a159d3831b5
Steve MacLean [Mon, 2 Oct 2017 22:19:29 +0000 (18:19 -0400)]
[Arm64] Add LD/ST exclusive emitters
Commit migrated from https://github.com/dotnet/coreclr/commit/
375107fade072f81e011c16e8a7ac68b58ccdd03
Bruce Forstall [Mon, 2 Oct 2017 23:29:45 +0000 (16:29 -0700)]
Merge pull request dotnet/coreclr#14220 from wateret/ryu-arm-bitcast-cleanup
[RyuJIT/arm32] Code cleanup
Commit migrated from https://github.com/dotnet/coreclr/commit/
70b3c9e5dd35d898562e980d1e5b3349cc75d13e
Steve MacLean [Mon, 2 Oct 2017 22:41:07 +0000 (18:41 -0400)]
[Arm64] Fix TODO-Cleanup add unreached
Commit migrated from https://github.com/dotnet/coreclr/commit/
029da7011f300faf17e955b490def2832bc6df91
Hanjoung Lee [Mon, 2 Oct 2017 23:22:48 +0000 (08:22 +0900)]
Improve runtest.sh concurrency (dotnet/coreclr#14036)
* Imporove runtest.sh concurrency
`runtest.sh` runs next tests immediately after any of child processes is done
* Fix runtest.sh getting number of processors
For linux, check if `nproc` or `getconf` exists
when getting number of processors.
* Add tests that fail with OOM to unsupported list
Add several tests that consumes a lot of memory to unsupported test list(arm32).
This change is temporary until we properly handle these test with memory issue.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5643bfeb4b507a1d70465ddcf245a5866d331b38
Carol Eidt [Mon, 2 Oct 2017 20:44:10 +0000 (13:44 -0700)]
Merge pull request dotnet/coreclr#14274 from fiigii/vexencoding
[RyuJIT] Fix VEX.vvvv for cvtss2sd and cvtsd2ss
Commit migrated from https://github.com/dotnet/coreclr/commit/
bd7493440cefe9cdfb3648de99178e208f8df5df
Sean Gillespie [Mon, 2 Oct 2017 20:27:31 +0000 (13:27 -0700)]
Fix a jump over variable initialization (dotnet/coreclr#14286)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c9e96e1c2c484e7c80bf7f7a7765e6650cbdf73
Viktor Hofer [Mon, 2 Oct 2017 19:54:19 +0000 (21:54 +0200)]
Merge pull request dotnet/coreclr#14181 from ViktorHofer/MutexCodeCleanup
Mutex code cleanup and removal of unused types
Commit migrated from https://github.com/dotnet/coreclr/commit/
97e0093e0941e7d5650d3f705bae17f1041c839f
Stephen Toub [Mon, 2 Oct 2017 19:17:58 +0000 (15:17 -0400)]
Workaround GetSystemTimePreciseAsFileTime inaccuracies (dotnet/coreclr#14283)
* Workaround GetSystemTimePreciseAsFileTime inaccuracies
On misconfigured systems, GetSystemTimePreciseAsFileTime may drift quickly from GetSystemTimeAsFileTime. We want to use the former, though. As a workaround/heuristic, when checking whether we have GetSystemTimePreciseAsFileTime, invoke both and ensure they're "close", falling back to GetSystemTimeAsFileTime if it seems like the precise variant has run away.
* Update comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e8bc684c6e15591708d49a773183fb6cd9eda34
José Rivero [Mon, 2 Oct 2017 16:53:20 +0000 (09:53 -0700)]
Small bug fixes on "perf.groovy" (dotnet/coreclr#14259)
- `submission-metadata` option is `--user-email`, not `--user`
- We need to escape user input. On batch, " -> ""
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5d08755c552961640df581ff532e87d187a4be3
tvass83 [Mon, 2 Oct 2017 13:27:48 +0000 (15:27 +0200)]
The !DumpArray sos command emits invalid DML for array elements (dotnet/coreclr#13855)
Element Methodtable is reported correctly but for individual elements, the generated DML uses the MT of the array, not the element, thus giving incorrect results
Only value types are affected
0:007> !DumpArray /d
02b16574
Name: WindowsFormsApplication2_SOS_bug.Test[]
MethodTable:
011c82ec
EEClass:
011c8290
Size: 412(0x19c) bytes
Array: Rank 1, Number of elements 100, Type VALUETYPE
Element Methodtable:
011c824c
[0]
02b1657c => here is the problem
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb2064e5d8b621dad56db25ad7b1af9909b4b4a2
Mike Danes [Sun, 1 Oct 2017 10:53:42 +0000 (13:53 +0300)]
Move JCMP transform to LowerJTrue
Unlike many other relop transforms we do this one is only triggerred by the presence of a conditional branch (JTRUE) so it makes more sense to do it when lowering JTRUE nodes, avoids unnecessary calls to TryGetUse.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5402ec55b132188d9a04f30af9e814695409f913
Mike Danes [Fri, 29 Sep 2017 21:34:07 +0000 (00:34 +0300)]
Extend flag reuse optimization to all relops
Commit migrated from https://github.com/dotnet/coreclr/commit/
848fd7427f4abc718ece9a7d74deb7ea70720c3b
Mike Danes [Sun, 17 Sep 2017 21:26:58 +0000 (00:26 +0300)]
Reimplement compare flags reuse using SETCC/JCC
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1f8cd25e0b79bfdf4e3b7a595fa22bbf7bdae26
Mike Danes [Sun, 17 Sep 2017 09:49:10 +0000 (12:49 +0300)]
Simplify SIMD EQ/NE optimization
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b637a639e8b8972b0a17322cecb50bf0d99b7c6
Ahson Ahmed Khan [Sat, 30 Sep 2017 01:56:42 +0000 (18:56 -0700)]
Adding a patch to fix coreclr build for VS 15.5 (using older SDKs). (dotnet/coreclr#14272)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c90a41bb6b9b5c5cc7f8f29a9d06aa2f9d0e51fd
Fei Peng [Sat, 30 Sep 2017 00:35:34 +0000 (17:35 -0700)]
Fix VEX.vvvv for cvtss2sd and cvtsd2ss
Commit migrated from https://github.com/dotnet/coreclr/commit/
806de466073c81d0ae67829cc146a2b0ba1b7fab
Sergey [Fri, 29 Sep 2017 23:16:44 +0000 (02:16 +0300)]
StompWriteBarrier initialization path refactoring (dotnet/coreclr#14105)
* refactored arm, arm64, amd64 and x86 to signal about icache flush and ee restarts
* refactored gc init stage to stomp write barrier (hence flush icache) only once
* review fixes, care taken of icache invalidation during StompResize
* fixed heap boundaries initialization bug introduced after refactoring gc.cpp
* stylistic review fixe
* global variable rename
* global variable rename once more
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b10f0eb85d8e8ccdcf9b5e38e5dd372e241e24e
Mike McLaughlin [Fri, 29 Sep 2017 22:54:48 +0000 (15:54 -0700)]
Update build clang/llvm/lldb 3.9 (dotnet/coreclr#14096)
Update build scripts, docs and build pipeline docker images to clang/llvm/lldb 3.9
Commit migrated from https://github.com/dotnet/coreclr/commit/
32c46737c396afa05ab748fbcc243de7512c11ec
Borislav Ivanov [Fri, 29 Sep 2017 22:52:46 +0000 (01:52 +0300)]
Fix spelling errors (dotnet/coreclr#14218)
Fix some spelling errors and capitalization.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ed2739e1a9c6f621f800ba0ffd3a28797149a1b
Mike McLaughlin [Fri, 29 Sep 2017 22:50:10 +0000 (15:50 -0700)]
Add info on loading core dumps in lldb. (dotnet/coreclr#13955)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5dd0b008a62233d6d296268e931295a4f971ce44