platform/core/csapi/xsf.git
5 years agoMake building easier on Windows by setting PowerShell execution policy (attempt 2...
Eilon Lipton [Tue, 2 Jul 2019 20:36:22 +0000 (13:36 -0700)]
Make building easier on Windows by setting PowerShell execution policy (attempt 2) (#6755)

* Make building easier on Windows by setting PowerShell execution policy

* Update build.cake to reference cmd as well as ps1

* remove . on instructions

5 years agoCherry pick Issue4597 fixes back to branch 4.0.0 (#6724)
Shane Neuville [Mon, 1 Jul 2019 16:42:41 +0000 (10:42 -0600)]
Cherry pick Issue4597 fixes back to branch 4.0.0 (#6724)

* Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

* fix automationid binding

* remove extra file

* fix tabs

5 years agorequest layout of measure changes force layout if it doesn't (#6704)
Shane Neuville [Sun, 30 Jun 2019 16:00:34 +0000 (10:00 -0600)]
request layout of measure changes force layout if it doesn't (#6704)

5 years agoreturn empty dictionary instead of null (#6675) fixes #6614
Shane Neuville [Fri, 28 Jun 2019 10:17:11 +0000 (04:17 -0600)]
return empty dictionary instead of null (#6675) fixes #6614

* return empty dictionary instead of null

* add warning if Element is being reparented

* fix warning message

* only fire warning if parent has inner children

5 years ago[iOS] Provide a base CarouselViewRenderer (#6686)
Rui Marinho [Thu, 27 Jun 2019 23:34:52 +0000 (00:34 +0100)]
[iOS] Provide a base CarouselViewRenderer (#6686)

* [iOS] Don't provide a CarouselViewRenderer

* [iOS] Fix CarouselViewRenderer

* Update CarouselViewRenderer.cs

5 years agowait for animation to complete (#6652)
Shane Neuville [Wed, 26 Jun 2019 15:57:26 +0000 (09:57 -0600)]
wait for animation to complete (#6652)

5 years agoIssue1733 change Query to WaitForElement (#6588)
Shane Neuville [Wed, 26 Jun 2019 04:52:09 +0000 (22:52 -0600)]
Issue1733 change Query to WaitForElement (#6588)

- rename test

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 20 Jun 2019 02:25:10 +0000 (19:25 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agodon't setup webview if running as designer (#6592)
Shane Neuville [Wed, 19 Jun 2019 23:52:31 +0000 (17:52 -0600)]
don't setup webview if running as designer (#6592)

5 years agoMake ShellTabLayoutAppearanceTracker public (#6530)
Gerald Versluis [Wed, 19 Jun 2019 23:30:33 +0000 (01:30 +0200)]
Make ShellTabLayoutAppearanceTracker public (#6530)

fixes #6529

5 years ago[Android] Fixes loading image from uri (#6394)
Pavel Yakovlev [Wed, 19 Jun 2019 23:26:41 +0000 (16:26 -0700)]
[Android] Fixes loading image from uri (#6394)

* [Android] Fixes loading image form uri

* - modified Issue4597 test

* nested function is removed

* moved redundant code

* Update Xamarin.Forms.Platform.Android/Extensions/ImageViewExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6313

5 years ago[Android] Fixes layout in AppCompat ButtonRenderer (#6329)
Pavel Yakovlev [Wed, 19 Jun 2019 23:24:51 +0000 (16:24 -0700)]
[Android] Fixes layout in AppCompat ButtonRenderer (#6329)

* [Android] Fixes layout in AppCompact ButtonRenderer

* - fixes button alignment when fast changing padding
- fixes material button alignment

* refactoring

* forceLayout

* generalize force layout

* if APP check on ui test
fixes #6282

5 years ago[Android] Add disposed check to MasterDetailPageRenderer (#6354)
Samantha Houts [Wed, 19 Jun 2019 22:55:59 +0000 (15:55 -0700)]
[Android] Add disposed check to MasterDetailPageRenderer (#6354)

* [Android] Add disposed check to MasterDetailPageRenderer

Co-Authored-By: Felipe Silveira <transis2@users.noreply.github.com>
* Fix dispose pattern

a la #6305

* apply same set of changes to NavigationPageRenderer

fixes #3489
closes #4586

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 19 Jun 2019 22:48:36 +0000 (23:48 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoDynamic view gallery support all Enum properties (#6434)
Pavel Yakovlev [Wed, 19 Jun 2019 18:45:54 +0000 (11:45 -0700)]
Dynamic view gallery support all Enum properties (#6434)

5 years ago[UITests] Wait a little bit longer for go to test button to appear (#6570)
Shane Neuville [Wed, 19 Jun 2019 17:21:08 +0000 (11:21 -0600)]
[UITests] Wait a little bit longer for go to test button to appear (#6570)

5 years ago[Build] Don't push NuGet packages from build
Rui Marinho [Tue, 18 Jun 2019 12:01:26 +0000 (13:01 +0100)]
[Build] Don't push NuGet packages from build

5 years agowait for test to finish so it doesn't break later tests (#6562)
Shane Neuville [Tue, 18 Jun 2019 10:21:30 +0000 (04:21 -0600)]
wait for test to finish so it doesn't break later tests (#6562)

5 years ago[Android] Fix context actions icon so that it loads (#6437) fixes #6258
Shane Neuville [Tue, 18 Jun 2019 10:20:37 +0000 (04:20 -0600)]
[Android] Fix context actions icon so that it loads (#6437) fixes #6258

* fix icon load loading and setting accessibility on menuitem

* instructions

* clean up

* Update Xamarin.Forms.Platform.Android/Extensions/AccessibilityExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.Android/ResourceManager.cs

* Update Xamarin.Forms.Platform.Android/CellAdapter.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Fix load TitleIcon on non app compact

* apply valid check one more place

* automate titleicon fixes

* fix ui tests and removed _isdisposed

* toolbaritem ui test tweaks

* toolbar tweaks

* ios toolbaritem tweak

* update menuitem to read like other platforms

* retain automationid if content desc not set

5 years ago[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150...
Pavel Yakovlev [Mon, 17 Jun 2019 11:43:11 +0000 (04:43 -0700)]
[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150 fixes #6447

* [Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame
- fixes float values in Dynamic ViewGallery

* added on-screen instructions for test

* added API check

* added SetClipToOutline to ViewExtensions

* added button to toggle IsClippedToBounds

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 17 Jun 2019 11:15:59 +0000 (12:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Android] Retrieve PackageName from the correct Platform instance (#6420)
Shane Neuville [Thu, 13 Jun 2019 19:57:30 +0000 (13:57 -0600)]
[Android] Retrieve PackageName from the correct Platform instance (#6420)

* Fix getting packagename and pass context into RM
- fixes #6327

* spacing

5 years ago[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes ...
Rui Marinho [Thu, 13 Jun 2019 13:21:09 +0000 (14:21 +0100)]
[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes #6368 fixes #6328

* [Controls] Add repo for issue #6368 and #6328

* [iOS] Protect against no Element from CustomRenderers bad usage

* [Controls] Drop private on sample code

5 years ago[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)
Pavel Yakovlev [Wed, 12 Jun 2019 23:41:46 +0000 (16:41 -0700)]
[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)

* [UWP] Fixes IndexOutOfRangeException on TabbedPage

* add tab page category

* fix update colors

* optimization

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 11 Jun 2019 09:08:29 +0000 (10:08 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[UWP] fixes ListView displays null values black (#6211)
Pavel Yakovlev [Sat, 8 Jun 2019 01:11:42 +0000 (18:11 -0700)]
[UWP] fixes ListView displays null values black (#6211)

fixes #6154
fixes #6233

5 years ago[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes...
Pavel Yakovlev [Thu, 6 Jun 2019 13:55:17 +0000 (06:55 -0700)]
[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes #5268

* [Android] fixes ListView pull-to-refresh gesture in non-data areas

* refactoring

* addressing comments

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 6 Jun 2019 04:10:49 +0000 (21:10 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Fix Bounds for PageContainer (#6405)
Rui Marinho [Thu, 6 Jun 2019 04:07:59 +0000 (05:07 +0100)]
[iOS] Fix Bounds for PageContainer  (#6405)

* [Controls] Add repo for issue #6334

* [iOS] Give a default size to the PageContainer so Effects can use Bounds

* {UITests] Update AutomationID

fixes #6334
fixes #6372

5 years ago[WPF] restore missed assembly attribute (#6418) fixes #6399
Pavel Yakovlev [Wed, 5 Jun 2019 16:09:17 +0000 (09:09 -0700)]
[WPF] restore missed assembly attribute (#6418) fixes #6399

5 years ago[CSS] workaround for corner-radius (#6401)
Stephane Delcroix [Wed, 5 Jun 2019 06:26:51 +0000 (08:26 +0200)]
[CSS] workaround for corner-radius (#6401)

Frame and Button implement IBorderElement bot do not share the CornerRadiusProperty.
This ifx workaround that so the CSS engine is not confused. This is a workaround,
a proper, but breaking, change is required and will happen on master

5 years agoMerge branch '3.6.0' into 4.0.0
ShaneN [Tue, 4 Jun 2019 23:49:27 +0000 (17:49 -0600)]
Merge branch '3.6.0' into 4.0.0

5 years agoCherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)
Shane Neuville [Tue, 4 Jun 2019 23:48:29 +0000 (17:48 -0600)]
Cherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)

* [Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

* sln changes that vs wants to apply

5 years agoCherry pick Tizen project changes to 3.6.0 and modify SLN changes VS makes (#6407)
Shane Neuville [Tue, 4 Jun 2019 23:47:21 +0000 (17:47 -0600)]
Cherry pick Tizen project changes to 3.6.0 and modify SLN changes VS makes (#6407)

* [Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

* sln changes that vs wants to apply

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 1 Jun 2019 01:50:16 +0000 (18:50 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoRoll back assembly version to 2.0.0.0 (#6379)
Samantha Houts [Sat, 1 Jun 2019 01:36:34 +0000 (18:36 -0700)]
Roll back assembly version to 2.0.0.0 (#6379)

fixes #6375

5 years ago[Android] Remove call to update Image on button during measure (#6274)
Shane Neuville [Wed, 29 May 2019 01:40:39 +0000 (19:40 -0600)]
[Android] Remove call to update Image on button during measure (#6274)

* remove update call before measure

* apply to material as well
fixes #6260

5 years agoroll back IButtonLayoutRenderer to its former 3.6 glory (#6290)
Shane Neuville [Wed, 29 May 2019 00:27:26 +0000 (18:27 -0600)]
roll back IButtonLayoutRenderer to its former 3.6 glory (#6290)

5 years agoCheck for correct API version (#6306)
E.Z. Hart [Tue, 28 May 2019 19:48:17 +0000 (13:48 -0600)]
Check for correct API version (#6306)

fixes #5693

5 years ago[Android] propagate elevation after initial elevation changes android (#6271)
Shane Neuville [Tue, 28 May 2019 18:56:40 +0000 (12:56 -0600)]
[Android] propagate elevation after initial elevation changes android (#6271)

fixes #6262

5 years ago[Shell, Android] Fixes crash on api 22 or less (#6198)
Pavel Yakovlev [Tue, 28 May 2019 17:56:31 +0000 (10:56 -0700)]
[Shell, Android] Fixes crash on api 22 or less (#6198)

fixes #6197

5 years ago[Build] This actually doesn't fix the issue
Rui Marinho [Tue, 28 May 2019 11:01:09 +0000 (12:01 +0100)]
[Build] This actually doesn't fix the issue

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Sat, 25 May 2019 00:33:08 +0000 (01:33 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix env variable for release nuget (#6311)
Rui Marinho [Sat, 25 May 2019 00:30:00 +0000 (01:30 +0100)]
[Build]  Fix env variable for release nuget (#6311)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 23:18:10 +0000 (00:18 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix release variable name
Rui Marinho [Fri, 24 May 2019 23:02:44 +0000 (00:02 +0100)]
[Build] Fix release variable name

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 21:10:57 +0000 (22:10 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoFix packageversion (#6288)
Rui Marinho [Fri, 24 May 2019 21:08:24 +0000 (22:08 +0100)]
Fix packageversion (#6288)

* [Build] Simplify package version

* [Build] Update the semver package version

* [Build] Remove prepare and set tags

* [Build] Update win build

* [Build] Fix tags

* Update Version.targets

* Update azure-pipelines.yml

* Update Version.targets

* [Build] Fix sign

* Update azure-pipelines.yml

5 years ago[Build] Add a global.json to specify what netcore sdk to use (#6279)
Rui Marinho [Thu, 23 May 2019 15:09:08 +0000 (16:09 +0100)]
[Build] Add a global.json to specify what netcore sdk to use (#6279)

5 years agoProperly guard against statusbar usage (#5999)
Morten Nielsen [Thu, 23 May 2019 00:44:22 +0000 (17:44 -0700)]
Properly guard against statusbar usage (#5999)

If you add the `Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer` nuget package, you'll find the analyzer points out these locations as not correctly guarded against usage.

5 years agoAllow third party libs to display animated images correctly in view recycling scenari...
Daniel Luberda [Thu, 23 May 2019 00:31:01 +0000 (02:31 +0200)]
Allow third party libs to display animated images correctly in view recycling scenarios (#6153)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

* Allows to display animated images on iOS in recycled views (CollectionView, ListView)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 23 May 2019 00:06:47 +0000 (01:06 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Update version target (#6270)
Rui Marinho [Thu, 23 May 2019 00:04:53 +0000 (01:04 +0100)]
[Build] Update version target (#6270)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 21:21:31 +0000 (22:21 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build]Yaml consolidate nuget (#6266)
Rui Marinho [Wed, 22 May 2019 18:33:27 +0000 (19:33 +0100)]
[Build]Yaml consolidate nuget (#6266)

* [Build] Consolidate nuget version

* [Build] Allow to continue to other steps if package fails to push on internal feed

* [Build] Fix script

5 years ago[Build] Clean Xamarin.Forms.Build
Rui Marinho [Wed, 22 May 2019 16:37:20 +0000 (17:37 +0100)]
[Build] Clean Xamarin.Forms.Build

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 15:23:05 +0000 (16:23 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix Version for branches with dashes
Rui Marinho [Wed, 22 May 2019 03:04:10 +0000 (04:04 +0100)]
[Build] Fix Version for branches with dashes

5 years ago[Build] Also build tags on yaml
Rui Marinho [Wed, 22 May 2019 01:45:17 +0000 (02:45 +0100)]
[Build] Also build tags on yaml

5 years ago[Build] Update yaml builds (#6230)
Rui Marinho [Wed, 22 May 2019 01:16:26 +0000 (02:16 +0100)]
[Build] Update yaml builds (#6230)

* [Build] Update build yaml

* [MacOS]Fix warning

* [Build] Enable binlog

* [Build] Run tests after build, update nuget version

* [Build] Don't build PagesGallery and Embedding

5 years ago[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)
Rui Marinho [Wed, 22 May 2019 00:06:59 +0000 (01:06 +0100)]
[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)

* [Build] Remove submodule

* [Build] Use GitInfo to set Assembly metadata

* [Build] Remove extra prop

* [Build] Update version

* [Build] Update versions to be consistent with existing Build.Tasks

* [Build] Update build number

* [Build] make sure build tasks gets info

* [Build] Add assembly info unit test

* [Test] Refactor test for gitinfo on vsts

5 years agoHeight -> Width; fixes #6168 (#6213)
E.Z. Hart [Fri, 17 May 2019 00:21:16 +0000 (17:21 -0700)]
Height -> Width; fixes #6168 (#6213)

5 years agoInvalidateLayout after reload to avoid iOS 10 crash (#6190)
E.Z. Hart [Tue, 14 May 2019 19:20:29 +0000 (12:20 -0700)]
InvalidateLayout after reload to avoid iOS 10 crash (#6190)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 11 May 2019 19:12:26 +0000 (12:12 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoitem template attached, fix icon propagations (#6173)
Shane Neuville [Sat, 11 May 2019 19:09:10 +0000 (12:09 -0700)]
item template attached, fix icon propagations (#6173)

* item template attached, fix icon propagations

* tabs

5 years ago[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)
Samantha Houts [Sat, 11 May 2019 19:08:21 +0000 (12:08 -0700)]
[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)

* Add repro for #5888

Co-Authored-By: melimion <melimion@users.noreply.github.com>
* [iOS] Fix HasUnevenRows for iOS11+

Co-Authored-By: melimion <melimion@users.noreply.github.com>
fixes #5888

5 years agoremove safe area from inset (#6169)
Shane Neuville [Sat, 11 May 2019 19:07:49 +0000 (12:07 -0700)]
remove safe area from inset (#6169)

5 years ago[iOS] Fix NRE when looking for internal buttons (#6170)
Rui Marinho [Sat, 11 May 2019 01:33:50 +0000 (18:33 -0700)]
[iOS] Fix NRE when looking for internal buttons (#6170)

5 years ago[iOS] Shell _headerView can apparently be null (#6164)
Samantha Houts [Fri, 10 May 2019 20:57:55 +0000 (13:57 -0700)]
[iOS] Shell _headerView can apparently be null (#6164)

5 years ago[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties...
Samantha Houts [Fri, 10 May 2019 20:38:39 +0000 (13:38 -0700)]
[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText... (#6165)

* [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText

But more concerning is that the `shellIconTextDescription` isn't used at all. Is it leftover code, or is this a mistake?

* [Android] Remove dead code from shellIconTextDescripion

5 years agostack the elevation of elements (#6108)
Shane Neuville [Fri, 10 May 2019 04:08:14 +0000 (21:08 -0700)]
stack the elevation of elements (#6108)

* stack the elevation of elements

* only layer implicit elevations

* check elevation of incoming elemelements

* fix api 19
fixes #2989
fixes #3543

5 years agofix up shell menu items, fix templates, fix bindings (#6117)
Shane Neuville [Fri, 10 May 2019 03:58:04 +0000 (20:58 -0700)]
fix up shell menu items, fix templates, fix bindings (#6117)

* fix up shell menu items, fix templates, fix bindings

* propagate bindingcontext changed on menu items

* address feedback
fixes #4399
fixes #5707

5 years agoRemove experimental flag for shell and change a few apis (#6086) fixes #2415
Shane Neuville [Thu, 9 May 2019 21:18:04 +0000 (14:18 -0700)]
Remove experimental flag for shell and change a few apis (#6086) fixes #2415

* api changes for shell official

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellSection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItem.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix compile errors

* fix ui test

* fix ui test

* removed some more properties

* remove a couple more

5 years ago[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956
Shane Neuville [Thu, 9 May 2019 21:17:30 +0000 (14:17 -0700)]
[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956

* create an actual logical child structure for page to use for propagation

* JustTheLogicalChildren

* only iterate over ActuallyLogicalChildren

* fix naming

* reuse ChildrenNotDrawnByThisElement

* testing

* fix unit test

5 years ago[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109...
Shane Neuville [Thu, 9 May 2019 21:16:52 +0000 (14:16 -0700)]
[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109) fixes #3875

* fix the flyout header to size based on content opposed to a fixed height

* update storeshell

* added height slider into storeshell

* resize header if underlying measure changes

* unsubscribe

5 years ago[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)
Samantha Houts [Thu, 9 May 2019 18:00:14 +0000 (11:00 -0700)]
[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)

* Add tests for #6132 and #6130

* [Android] Fix EnableZoomControl BP name and fix helper methods

fixes #6132
fixes #6130

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

5 years ago[Android] VisualElementRenderer and ElevationHelper should be public (#6131)
Daniel Luberda [Thu, 9 May 2019 17:57:59 +0000 (19:57 +0200)]
[Android] VisualElementRenderer and ElevationHelper should be public (#6131)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

5 years ago[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchH...
Rui Marinho [Thu, 9 May 2019 17:42:19 +0000 (10:42 -0700)]
[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchHandler (#5810)

* [Shell,iOS] Add Colors, Font , HorizontalAlignment and keyboard support to SearchHandler

* {Android]Allow set colors and customize text on Shell SearchHandler

* [Android] Update icons color on SearchView

* [Android] Update Placeholdericon color from one place

* [iOS] Update shell cancel button colours

* [iOS,Android] Update IconPlaceholder color

* [Core] Fix missing region

* [Controls] Add shell SearchHandlerPage

* [iOS] Fix alignment changes on SearchHandlerAppearanceTraccker

* [Shell,Core] Add focus to SearchHandler

* [Android] Add SearchHandler focus

* [iOS] Add SearchHandler focus

* [Controls] Reuse dynamic gallery for SearchHandler

* [Controls] Fixes to gallery

* [Android] Remove cancel button code

* [Android] Add extension point for SearchHandlerAppearanceTracker

* [Android] Fix spelling

* fix bad merge

fixes #3125
fixes #5768

5 years ago[Android] Fix Frame size (#6115) fixes #5766
Pavel Yakovlev [Thu, 9 May 2019 16:20:37 +0000 (19:20 +0300)]
[Android] Fix Frame size (#6115) fixes #5766

5 years ago4.0 ABI Fixes (#6133) fixes #6123
Shane Neuville [Thu, 9 May 2019 16:17:59 +0000 (10:17 -0600)]
4.0 ABI Fixes (#6133) fixes #6123

* fix background image type

* additional abi fixes

* updated 4915 to test nav icon

* uwp fixes

* Update Xamarin.Forms.Platform.UAP/TabbedPageStyle.xaml

5 years ago[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items...
Rui Marinho [Thu, 9 May 2019 16:14:25 +0000 (09:14 -0700)]
[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items (#5758) fixes #5132

* [Controls,Shell] Add automation properties to FlyoutIcon

* [iOS] Set accessibility properties from flyout icon on ShellPageRenderer

* [Android] Add accessibility features to Shell flyout icon

* [Android] Add accessibility to shell toolbar and button items

* [Controls] Add uitest for issue #5132

* [Controls] Fix uitest android

* [Controls] Use new types

* [UItests] Only run on iOS and Android

Co-Authored-By: rmarinho <me@ruimarinho.net>
* [Controls] Add scrollview to test page

* [Android] Set icon AutomationId using NavigationContentDescription

* [Android] Restore code on AutomationPropertiesProvider

* [Android] Set help text or AutomationID for toolbar navigation content description

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

5 years ago[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)
Shane Neuville [Thu, 9 May 2019 07:05:57 +0000 (01:05 -0600)]
[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)

* add DesignerFlyoutRenderer

* private and hack comment

* internal

5 years agoremove route params from shell (#6081)
Shane Neuville [Wed, 8 May 2019 23:15:43 +0000 (17:15 -0600)]
remove route params from shell (#6081)

* remove route params from shell

* Update Xamarin.Forms.Core.UnitTests/ShellTests.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix unit test

5 years ago[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)
Shane Neuville [Wed, 8 May 2019 23:15:18 +0000 (17:15 -0600)]
[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)

* add tab bar and promote implicit tabs to same tabbar

* - remove parent

* remove tab bar from flyout

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoMake Android CollectionView smarter about recycling elements/renderers (#5980)
E.Z. Hart [Wed, 8 May 2019 23:14:18 +0000 (17:14 -0600)]
Make Android CollectionView smarter about recycling elements/renderers (#5980)

5 years ago[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089...
E.Z. Hart [Wed, 8 May 2019 16:02:14 +0000 (10:02 -0600)]
[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089) fixes #5793

* Add missing call to ReloadData on INCC Reset; fixes #5793

* Automated test for INCC Reset

5 years agoApply round corners shape based on radius (#6099)
Shane Neuville [Tue, 7 May 2019 16:52:53 +0000 (10:52 -0600)]
Apply round corners shape based on radius (#6099)

* Apply round corners shape based on radius

* update gallery

* apply to SmallComponentShape

* add color scheme back

* basic fixes

* - make corner radius default the same
- reapply theme on ios so corner is changeable
- force set ios border width to size

* fix border width for default and remove extra call to bgcolor

5 years agoreturn from designer earlier (#6102)
Shane Neuville [Tue, 7 May 2019 01:44:00 +0000 (19:44 -0600)]
return from designer earlier (#6102)

* return from designer earlier

* - initialize fake coordinator layout for designer

* change to a non appcompat compatible layout

5 years agoUpdate screen size info after orientation change on Android/iOS (#5975)
E.Z. Hart [Mon, 6 May 2019 22:27:43 +0000 (16:27 -0600)]
Update screen size info after orientation change on Android/iOS (#5975)

* Update Android screen size info in Device when changing orientation;
Fixes #4992

* Add test instructions

* Update iOS screen size on orientation change

* Fix build error in UI Test projects

* Fix errors with #if directives in iOS/macOS projects

* Update Xamarin.Forms.Platform.MacOS/MacDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.Android/Forms.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.iOS/IOSDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
5 years agorename SearchBoxVisibility (#6103)
Shane Neuville [Mon, 6 May 2019 20:31:06 +0000 (14:31 -0600)]
rename SearchBoxVisibility (#6103)

5 years agoHopefully fix the mdoc issues with the localization typo (#6105)
E.Z. Hart [Mon, 6 May 2019 20:29:27 +0000 (14:29 -0600)]
Hopefully fix the mdoc issues with the localization typo (#6105)

5 years ago[Android] Image load fixes (#6062)
Shane Neuville [Mon, 6 May 2019 17:13:36 +0000 (11:13 -0600)]
[Android] Image load fixes (#6062)

* fix loading for lollipop

* cache

* fix some loading behavior

* requested changes

* cache fixes

* API 19 fix

* fix sizeof and use lazy

* add better management over requests to same key

* add caching validity checks

* remove remove and fire and forget put

* synchronous put

* add disposed check for bitmap data

* max memory

5 years agochanges transition to enter mask (#6066)
Shane Neuville [Fri, 3 May 2019 18:38:46 +0000 (12:38 -0600)]
changes transition to enter mask (#6066)

fixes #5216

5 years ago[Android] Fix previewer exceptions with shell (#5955)
Shane Neuville [Thu, 2 May 2019 10:26:42 +0000 (04:26 -0600)]
[Android] Fix previewer exceptions with shell (#5955)

* shell preivewer

* nonappcompat hack

* - moove up null check

* internal IsDesignerContext

5 years agoretain local variable of page so not collected (#6054)
Shane Neuville [Wed, 1 May 2019 16:12:41 +0000 (10:12 -0600)]
retain local variable of page so not collected (#6054)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Mon, 29 Apr 2019 23:42:15 +0000 (16:42 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agofix global routes to push onto stack correctly (#6025)
Shane Neuville [Mon, 29 Apr 2019 23:40:12 +0000 (17:40 -0600)]
fix global routes to push onto stack correctly (#6025)

fixes #6016

5 years agoadditional proguard rules for shell (#6032)
Shane Neuville [Sat, 27 Apr 2019 19:21:30 +0000 (13:21 -0600)]
additional proguard rules for shell (#6032)

* additional proguard rules for shell

* add property to disable file

fixes #5799

5 years agoadd check for null track drawable (#6029)
Shane Neuville [Sat, 27 Apr 2019 19:18:33 +0000 (13:18 -0600)]
add check for null track drawable (#6029)

fixes #5970

5 years ago[Android] set dialog to null when dismissed (#6031)
Shane Neuville [Sat, 27 Apr 2019 19:18:08 +0000 (13:18 -0600)]
[Android] set dialog to null when dismissed (#6031)

fixes #5945