Kamil Klimek [Mon, 23 Jun 2014 10:44:31 +0000 (12:44 +0200)]
Fix issue with calling Render*::FromID outside UI thread
Problem : the entire hit test code was using some chromium functionality from the wrong thread
Issue: CBEFL-103, CBWEBCORE-471
Change-Id: I5e5ad931c45f10833f07da69d964d8a7aba86ebf
Karol Furmaniak [Tue, 1 Jul 2014 11:30:00 +0000 (13:30 +0200)]
Add triggering download callback.
Issue: CBBROWSER-292, CBBROWSER-293, CBBROWSER-294, CBBROWSER-295
Also added null check in cookie_manager.
This patch require chromium-ewk "ewk_view_get_cookies_for_url fix char* return"
to avoid crash in com.samsung.browser
Change-Id: I69ebae7ff074f7d84338b9bf31f9a0ee4ae19bb8
Mikolaj Czyzewski [Fri, 27 Jun 2014 09:48:17 +0000 (11:48 +0200)]
Fix ewk_context_local_file_system_all_delete.
When given URL was empty, returned GURL was "://".
Now returned GURL is an empty string "".
Change-Id: Ic9caba3a4515abf915de86483a2ecfc6bde6a099
Piotr An Nguyen [Thu, 12 Jun 2014 15:53:51 +0000 (17:53 +0200)]
Implement ewk_context_memory_sampler_start and ewk_context_memory_sampler_stop
Issue: CBWEBVIEW-559, CBWEBVIEW-560
Change-Id: I791b7e19b70eb266b15acf2af64b2efedd3433c6
Conflicts:
impl/chromium-efl.gyp
Lukasz Krok [Tue, 8 Jul 2014 21:13:33 +0000 (14:13 -0700)]
Add the required null checks to EWebView::handleFocusIn() method.
The patch fixes occasional webview segfaults (observed in email application).
Issue: CBWEBVIEW-875
Change-Id: I5aaaab8f41ee7515dd3a672a032aeeb85e2f6a4f
Karol Furmaniak [Tue, 8 Jul 2014 21:00:44 +0000 (14:00 -0700)]
Fix position of text selection menu when paste.
Patch fixed position of text selection menu when paste.
Issue: CBBROWSER-285
Change-Id: I692d6d31d152ada93fb8662f7ffe468ded55bd72
Kamil Klimek [Tue, 8 Jul 2014 19:36:23 +0000 (12:36 -0700)]
Fix for an issue with ewk_view_hit_test_new API
This commit fixes open link issue in email app.
The solution is to apply the device scale factor and offset to x, y coords.
Issue: CBEFL-103 CBWEBVIEW-839
Change-Id: Icb937f97adf80cfeb82f7db2b81135a8bd1c42c9
Lukasz Krok [Tue, 24 Jun 2014 13:12:46 +0000 (15:12 +0200)]
Fix for the text Align* buttons not working ok in email application.
It is possible to make the text align buttons all to be clicked in the same time.
Issue: CBWEBVIEW-877
Change-Id: I7428213c1475d8a3ed166ed599dab96d5695292a
Prashant Nevase [Tue, 24 Jun 2014 22:47:22 +0000 (04:17 +0530)]
Optimize the RWHV EvasObjectImagePixelsGetCallback function
This improves canvas benchmark performance by ~ 0.03.
Issue: CBGRAPHICS-299
Change-Id: Iebf38c93a65b786acceabe8b65580a5c08dd3a29
Piotr An Nguyen [Mon, 7 Jul 2014 22:49:34 +0000 (15:49 -0700)]
Fix problem when ContextMenuItemSelected callback is not called when it should.
Issue: CBWEBVIEW-855
Repairing [UnitTest] Unit test Fail - ewk_context_menu_item_link_url_get
Change-Id: I0bfbd38ae611956dafccc7463c4c1ba9e4661dc9
Youngcheol Kang [Mon, 7 Jul 2014 20:58:44 +0000 (13:58 -0700)]
Add "policy,decision,new,window" smart callback for Tizen TV
Patch only added declaration, so implementation is required.
Change-Id: I56e79790709ad372a43228b7177cbec550300665
Sergey [Wed, 18 Jun 2014 11:31:14 +0000 (20:31 +0900)]
Magnifier shown at wrong place of screen in email application
Issue :CBWEBVIEW-854
Change-Id: Ice0f0c175c74fcefcfddc0606ac5e5b4ce00ddba
Kamil Klimek [Mon, 7 Jul 2014 20:33:39 +0000 (13:33 -0700)]
Enable orientation event, fix a related crash and APIs
Change-Id: I948e70e9b7b1344ccd2dc7f2d6264b98e01a961a
Conflicts:
impl/eweb_view.cc
Jongsoo Yoon [Tue, 24 Jun 2014 13:23:54 +0000 (22:23 +0900)]
Add "ui-gadget::client" permission
Composer is pending when it is replied by click email address.
According to the result of checking smack log (/var/log/audit/audit.log),
chromium-efl cannot access to "ui-gadget::client".
As Adding "ui-gadget::client" permission, composer can avoid pending issue.
Issue : CBWEBVIEW-878
Change-Id: I7f2fc81001fb870ef6f9648d916bd850d71536a0
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Conflicts:
packaging/org.tizen.chromium-efl.manifest
Karol Furmaniak [Mon, 7 Jul 2014 23:04:08 +0000 (16:04 -0700)]
Fix text selection problem when mouse/touch events are prevented.
Issue: CBBROWSER-204, CBBROWSER-205, CBBROWSER-247
When mousemove/down/up events are prevent defaulted,
text selection should be hided after tap.
When touchend event is prevent defaulted,
text selection should not be hided after tap.
Change-Id: Ic5041f7da9fa0efcc3d8f087d7ad3ef41dac9364
Karol Furmaniak [Mon, 7 Jul 2014 20:45:49 +0000 (13:45 -0700)]
Fix hiding context menu when selection is covered.
Issue: CBBROWSER-271, CBBROWSER-151
[Problem]: When selection is covered context menu and selection handlers are still visible.
[Solution]: Add check if in selection point is not covered.
Change-Id: I270a14c8f8080b9a826be46fce368c292097e63d
Sergey [Fri, 20 Jun 2014 05:47:59 +0000 (14:47 +0900)]
Add switch(kUseSWRenderingPath) to choose SW render path during runtime
It works only under TIZEN_OS.
Issue : CBGRAPHICS-341
Change-Id: I84ea9fb6d3bfec86c4c60d2b494a6a0af289694a
Conflicts:
impl/browser/renderer_host/render_widget_host_view_efl.cc
impl/command_line_efl.cc
Lukasz Krok [Tue, 17 Jun 2014 10:41:40 +0000 (12:41 +0200)]
Bold, Italic and Underline Icons are bugged.
Issue: CBEFL-152 / CBWEBVIEW-852
Cause: _ewk_view_text_style_state_cb in email application was not executed on text input in order to
make the rich text toolbar to become dimmed.
Solution: Query for selection style on text input state changed.
Change-Id: If7f8545a0d95d1c58a34dbdc75cc49714721e050
Tomasz Olszak [Thu, 12 Jun 2014 15:22:25 +0000 (17:22 +0200)]
Omit creation of debug packages.
Debug packages should not be created when nodebug
flag is passed. The libraries don't contain debug
information so these steps (extract debug info,
create debug packages) only result in longer build
process.
Change-Id: I6599916b263bbbc2d2bee20d44bfc3069127ac10
Issue-Id: CBEFL-150
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
SeungSeop Park [Mon, 16 Jun 2014 00:26:52 +0000 (09:26 +0900)]
Refactor policy decision: use const char* instead of Eina_Stringshare*
Replaced because no good reason for Eina_Stringshare* was found.
Issue: CBWEBVIEW-387
Change-Id: I74eaa843e7f9759c43cd7fdfbb7a16ca94b0c410
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 23 Jun 2014 04:13:02 +0000 (13:13 +0900)]
refactor dependency : ewkUpdateWebkitPreference() (removed ewk_view_private.h)
The function is not used by chormium-efl and hence better to belong to ewk layer.
Issue: CBEFL-95
Change-Id: Iba3b13921e858f499d8e1fb7533a37fa23670184
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Conflicts:
impl/chromium-efl.gyp
SeungSeop Park [Sat, 21 Jun 2014 10:01:07 +0000 (19:01 +0900)]
break dependency to EWebView
EWebView has complicated dependencies to chromium internal, which makes it hard
to break dependency between chromium-efl and ewk.
To simplify the dependency, this commit does followings:
- hide EWebView from outside use
- add new class, tizen_webview::WebView, for public use
- bridge EWebView as private impl for tizen_webview::WebView.
The next step is to tidy up EWebView and move some of the implementations to
proper location.
Issue: CBEFL-92
Change-Id: I6fe1b2c396c8be1fed4253d2441d6dbb961ac88f
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Conflicts:
impl/chromium-efl.gyp
Marek Ruszczynski [Thu, 12 Jun 2014 12:05:26 +0000 (14:05 +0200)]
Implement ewk_settings_link_magnifier_enabled_set and get.
The link magnifier is enabled by default.
Issue: CBWEBVIEW-569
Change-Id: I850d8e7d0a0cdcad1fe1b9db63ebe08719874662
w.basiak [Fri, 13 Jun 2014 07:05:53 +0000 (09:05 +0200)]
Implement ewk_view_encoding_custom_set
Issue: CBWEBVIEW-843
Change-Id: I84e1a5049aeec5168d6c94a79f4f784f9c991265
Marcin Lapinski [Mon, 7 Jul 2014 21:23:58 +0000 (14:23 -0700)]
Changed implementation of EWebView::GetSnapshot
Previously snapshot was obtained from BackingStore, which is not a valid
approach any more. In this patch, the implemenation is changed so as to
get snapshot directly from GPU buffer via RenderViewHostViewEfl.
From EWK perspective, this fixes UTC ewk_view_screenshot_contents_get fail,
and the ewk side patch http://suprem.sec.samsung.net/gerrit/#/c/2214/ should
be merged after landing this patch.
Issue: CBWEBVIEW-526
Change-Id: I010375946983685be2e97b1bd46d5b0db2ccdcd5
Conflicts:
impl/eweb_view.cc
Shadakshari B C [Thu, 29 May 2014 09:20:26 +0000 (14:50 +0530)]
[GStreamer] Handle play/pause when Home/Power key is pressed in Mobile.
Patch fixes HTML5 TC #13 and #14.
PS: Once application sends proper events then this patch will be modified
IssueID: CBWEBCORE-486
Change-Id: I73db8222d915d2d3ed978d77df5a69f75d9eff0f
young bae kim [Mon, 12 May 2014 06:46:05 +0000 (15:46 +0900)]
[Gstreamer] Add README. Gstreamer packages installation guide for media element. IssueID-CBWEBCORE-482
Change-Id: I5ddc591e0663261c93eceb7a7f0bb47b33c79650
Vinod Keshav [Mon, 16 Jun 2014 19:02:53 +0000 (12:02 -0700)]
WebAudio Implementation - Decoder using GST
Patch implements WebAudio decoder by using GST.
Issue id: CBMM-14
Change-Id: Iceaa49d3426db5049b180d5b9c01ec6424673286
Conflicts:
src/content/content_browser.gypi
src/media/media.gyp
Youngcheol Kang [Fri, 23 May 2014 09:57:29 +0000 (18:57 +0900)]
Implement webrtc features.
Implement the audio / video port using CAPI for webrtc.
Issue: CBMM-99 CBMM-410
Change-Id: I149bb29f835aa82ce4577b22a230d0119ecb4536
KANGYONG PARK [Mon, 21 Jul 2014 12:13:21 +0000 (21:13 +0900)]
Fix GetUserAgent
ISSUE : CBWEBCORE-440
Change-Id: Ic2e2d631509abba2c2b0daabf563d3abfed17a82
Piotr Tworek [Mon, 21 Jul 2014 12:41:58 +0000 (14:41 +0200)]
Fix URLRequestContext creation to work with chromium M37.
Change-Id: I07ab0d6e615d1ded9d2165d4a78d8151f1d8e06c
Karol Furmaniak [Tue, 10 Jun 2014 13:20:28 +0000 (15:20 +0200)]
Fix show/hide Largehandler.
Issue: CBBROWSER-196, CBWEBCORE-417
[Problem]:After input field focus change large handler is showing,
but it shouldn't.
[Solution]: Add unsetting caret selection status on FocusedNodeChanged.
Also fixed disapearing selected text when predictive mode is on.
Change-Id: If9f7eb01170119a8bb8d9cf66fa5ac6dcb562a8d
Conflicts:
impl/browser/renderer_host/render_widget_host_view_efl.cc
Adam Banasiak [Fri, 6 Jun 2014 12:23:55 +0000 (14:23 +0200)]
Implement ewk_view_url_request_set
[Issue#] CBWEBVIEW-253
[Depend on] http://suprem.sec.samsung.net/gerrit/#/c/2213/
Change-Id: I729134c586aab87b3113b9cac0146858d4e1bae4
Conflicts:
impl/eweb_view.cc
Lukasz Krok [Fri, 6 Jun 2014 18:19:41 +0000 (20:19 +0200)]
Current legacy font size mode support added.
Issue : CBWEBVIEW-174
Font size on editing mode is not changed.
This commit is a follow-up for
f0cf3481 and
0fa07a7 (chromium-ewk) commits.
Without correct legacy font size mode manipulation possibility,
the FontSizeCSS editor command does not work fully properly,
e.g. when in email application user sets
text font size to 12px and then selects the text again,
the rich text toolbar will show 2px instead of 12, that is legacy (not pixel) font size value.
Solution : Migrate required implementation from tizen webkit2.
Change-Id: I3cd42256c24f771704ec7307a84ddc43075ca8a3
Conflicts:
src/third_party/WebKit/Source/core/editing/EditingStyle.cpp
src/third_party/WebKit/Source/core/frame/Settings.h
Conflicts:
src/content/public/common/common_param_traits_macros.h
src/content/renderer/web_preferences.cc
src/third_party/WebKit/Source/core/editing/EditingStyle.cpp
src/webkit/common/webpreferences.cc
src/webkit/common/webpreferences.h
Umesh Kumar Patel [Fri, 6 Jun 2014 11:47:20 +0000 (17:17 +0530)]
WCS Feature : Chrome reused files
Change-Id: Ie7498630ba2cd1e0891e1b5b6bdd65be0cdf25ff
Michał Obrembski [Thu, 12 Jun 2014 13:47:50 +0000 (15:47 +0200)]
Fix bad hardware back key behavior.
On mobile, when context menu is shown, and user presses hardware back
key, browser opens previous site instead of closing menu.
This commit fixes this issue.
Issue-Id: CBBROWSER-76
Change-Id: Ic336dbd2ca63c847c87bc092b391af90e32437e2
kapil.kumar [Tue, 10 Jun 2014 14:10:36 +0000 (19:40 +0530)]
Add attributes recognition for mediacapture
When capture attribute is present and one of accept types
is one of "video/*", "image/*" or "audio/*", file should be
captured from camera. In other cases, file selector
should be launched.
In this solution I assume that if there is at least one of
accept types mentioned above (and there may be many of them),
mediacapture will be launched.
Issue Id : CBWEBCORE-315, CBMM-129
Change-Id: Ib94dc90a09affdc657fff5c385d543e43e6d22b7
Dong-Jun Kim [Wed, 11 Jun 2014 09:01:25 +0000 (18:01 +0900)]
Implement SelectPicker (multi type)
1. implement about multi type
2. clean-up code
Issue : CBBROWSER-59, CBBROWSER-61, CBBROWSER-62
Change-Id: Id48caf0f317026d8a9bf4c30d781b0a7f96585dd
Conflicts:
impl/browser/selectpicker/popup_picker.h
Youngsoo Choi [Thu, 26 Jun 2014 00:08:34 +0000 (17:08 -0700)]
Support multilingual operation for context menu
[issue]
Multilingual operation hasn't been supported for image and link.
[solved]
Providing multilingual operation.
But this needs to be changed later, not to use language set of Webkit.
Change-Id: I3483fb1cec01fb8dbeaa436b329f952bbac7a467
Umesh Kumar Patel [Wed, 11 Jun 2014 05:06:36 +0000 (10:36 +0530)]
Implement PlatformLocale
Change-Id: Ia702747c6aa1792fe3882e00fc368ab24199cd6f
venu.musham [Thu, 29 May 2014 05:17:04 +0000 (14:17 +0900)]
Temporarily disable zero copy as it causes browser crash during regression
Related to CBGRAPHICS-335
Change-Id: I1308c334c1035fef8d05d434ee01946b03049afc
Conflicts:
impl/command_line_efl.cc
Zhang-hoon Oh [Wed, 25 Jun 2014 18:06:01 +0000 (11:06 -0700)]
Set policy decision to "USE" for webfonts.
[Problem]
When a user opens Ringmark web site - http://rng.io/?all - in an efl-browser,
the browser hangs up after 101 passed, "CSS3 Fonts" test step.
While it works well in a mini_browser and an efl_webview_app.
[Cause]
Policy decision were "DOWNLOAD" for webfonts which come with
"application/octet-stream" MIME type.
[Solution]
Set policy decision to "USE" to use webfonts - a.k.a. CSS Fonts -
in efl-browser - a.k.a. MCD browser.
Issue: CBWEBCORE-307
Change-Id: If03c8714971f63763ea6c666f6c932e629482d21
Piotr Tworek [Tue, 24 Jun 2014 23:47:11 +0000 (16:47 -0700)]
Implement support for overriding content mime type.
This adds EFL port implementation of ResourceDispatcherHostDelegate's
ShouldOverrideMimeType function. The code exposes this interface via EWK
context object. Due to the fact chromium resource dispatcher host
delegate is a singleton object the interface is exposed as a static
function in WebContext.
Issue-Id: CBWEBCORE-306
Change-Id: I1de8e03c5d5bd529901cb2e6ac05fa4e1d35d231
Conflicts:
impl/content_main_delegate_efl.cc
Tomasz Olszak [Wed, 28 May 2014 11:23:02 +0000 (13:23 +0200)]
Remove webcore debug symbols.
Half of chromium-efl debug symbols comes from
webcore. These symbols are rarely used in platform
integration development so can be freely removed.
The result are faster build, link and extracting
debug output.
Task: CBEFL-27
Change-Id: I45c58ef5c9e429275238341202b80af952b965c0
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Michał Obrembski [Fri, 13 Jun 2014 11:22:24 +0000 (13:22 +0200)]
Fix image context menu options
Save image, Copy Image and Show image in new window was shown
even if user open context menu not on a Image.
Open link in new tab and Open image was buggy. Fixed
Change-Id: If7e8c2eedcd5904c98186dd3a88ad6638312ceb8
Conflicts:
src/content/public/common/context_menu_params.cc
Michał Obrembski [Fri, 13 Jun 2014 09:53:14 +0000 (11:53 +0200)]
Fix "Select All" option not shown
Select All context menu option wasn't shown when
user opens context menu on non-editable field.
Issue-Id: CBBROWSER-71
Change-Id: I55c805e6b4d8414c3f7a39ea2bff80c8faf65da1
Marcin Lapinski [Fri, 6 Jun 2014 13:57:58 +0000 (15:57 +0200)]
Refactor of DeleteAllApplicationCache
Issue: CBWEBVIEW-821
Needed by: http://suprem.sec.samsung.net/gerrit/#/c/2276/
wthout it test segfaults.
Change-Id: I4e604bbd688c083f3247d93099dcddbe58bfbdfb
Piotr Sieduszewski [Tue, 3 Jun 2014 14:24:46 +0000 (16:24 +0200)]
Implementation of ewk_view_inspector_server_stop
Issue: CBWEBVIEW-575
Change-Id: I23657c515e7a8826e0e62386d92352b9edd56293
Conflicts:
impl/eweb_view.h
Piotr Sieduszewski [Thu, 5 Jun 2014 11:35:45 +0000 (13:35 +0200)]
Implementation of ewk_view_inspector_server_start
Issue: CBWEBVIEW-575 & CBWEBVIEW-126
Change-Id: I9713dd654f8d03368e14f8581642f0e7461da462
Conflicts:
impl/eweb_view.h
Conflicts:
impl/devtools_delegate_efl.cc
Piotr Tworek [Tue, 24 Jun 2014 21:25:00 +0000 (14:25 -0700)]
Refactor of ResourceDispatcherHostDelegateEfl
The class implements a well defined chromium interface. Placing it in
content_main_delegate_efl.cc along with three different classes makes it
harder to find and modify. Move it to a dedicated file as is done for
implementation of other similar chromium interfaces.
Issue-Id: CBWEBCORE-306
Change-Id: I069ee4bc31341446d24d35e39caed97f443d7ad4
Conflicts:
impl/content_main_delegate_efl.cc
uzair jaleel [Thu, 12 Jun 2014 12:17:30 +0000 (17:47 +0530)]
Fix for black screen in long text mail
Issue: CBGRAPHICS-339
Change-Id: I0c2d40e3f06d98b4b0b4bcc38f29c40dc6b96a3b
Adam Banasiak [Mon, 2 Jun 2014 10:34:47 +0000 (12:34 +0200)]
Implement setAuthorizationIfNecessary
[Issue#] CBWEBVIEW-655
[Issue#] CBWEBVIEW-656
[Problem] No possibility to set username and password
[Solution] Added function to set username and password
Change-Id: Icfd64bff159205f249ebb11551da76013b4f1257
Piotr Grad [Mon, 23 Jun 2014 22:06:17 +0000 (15:06 -0700)]
Implementation of image and link context menu options.
Patch implements copy and save image.
Issue-Id: CBBROWSER-76, CBBROWSER-77, CBBROWSER-78
Change-Id: I5635e7f79b8f4d75df5238fd7ad576ee6e3aa0ae
Conflicts:
impl/content_main_delegate_efl.cc
SeungSeop Park [Fri, 13 Jun 2014 05:57:08 +0000 (14:57 +0900)]
break dependency to Ewk_Notification_Permission_Request (removed ewk_notification.h)
Added tizen_webview::NotificationPermissionRequest class which uses existing
_Ewk_Notification as its implementation.
Issue: CBEFL-92
Change-Id: I6a2e4ed96219f5f3085685055a8e7006d81f3cd2
Conflicts:
impl/content_main_delegate_efl.cc
SeungSeop Park [Thu, 19 Jun 2014 07:21:55 +0000 (16:21 +0900)]
break dependency to Ewk_Policy_Decision (removed ewk_policy_decision.h)
It's replaced by tizen_webview::PolicyDecision.
Issue: CBEFL-92
Change-Id: Ibd87d9763cef2eafdb1e1651913c713a0188db42
SeungSeop Park [Mon, 16 Jun 2014 11:15:03 +0000 (20:15 +0900)]
break dependency to ewk_view.h callbacks
callback declarations moved to tw_callbacks.h
Issue: CBEFL-92
Change-Id: I78950c69a8d95e2fe37d22e6c78cde4d3ce867cd
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 16 Jun 2014 10:21:24 +0000 (19:21 +0900)]
break dependency to enum Ewk_CSP_Header_Type
Replaced by tizen_webview::ContentSecurityPolicyType
Issue: CBEFL-92
Change-Id: I3f3f650a186a6ffe02a0bee9f3ecf68d42f399cc
SeungSeop Park [Sat, 14 Jun 2014 06:37:04 +0000 (15:37 +0900)]
break dependency to Ewk_IPC_Wrt_Message_Data (removed ewk_ipc_message.h)
It's renamed to tizen_webview::WrtIpcMessageData with additional methods.
In addition, following refactorings were performed during the task.
* rename function:
- ewk_ipc_wrt_message_send_private
=> tizen_webview::WrtIpc::SendMessage
- ewk_ipc_plugins_message_send_private
=> tizen_webview::WrtPluginsIpc::SendMessage
- ewk_ipc_plugins_sync_message_send_private
=> tizen_webview::WrtPluginsIpc::SendSyncMessage
* delete file:
- impl/API/ewk_ipc_message_private.h|cc => merged to tw_wrt.h|cc
Issue: CBEFL-92
Change-Id: I3bd7ee4d296a5e04b6852f357c3746af8c2b5aaa
SeungSeop Park [Thu, 12 Jun 2014 04:15:10 +0000 (13:15 +0900)]
break dependency to Ewk_Hit_Test (removed ewk_hit_test.h)
Issue: CBEFL-92
Change-Id: Id6b2e26d3b8ca56a96d8c8075987aaed655653fd
SeungSeop Park [Fri, 13 Jun 2014 04:11:45 +0000 (13:11 +0900)]
break dependency to Ewk_Notification
- Added tizen_webview::Notification class which uses existing _Ewk_Notification
as its implementation.
- Replaced include guard for ewk_notification_private.h to avoid conflict with
ewk side header. The file name should be renamed in next refactoring.
- Deleted redundant NotificationControllerEfl::RemoveClosedNotifications()
which can be implemented in ewk side using other method, hence not fundamental.
Issue: CBEFL-92, CBWEBVIEW-386
Change-Id: Iaecce42cfc047915356b7cdf9226e8bba5a16ff7
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Conflicts:
impl/API/ewk_notification_private.cc
impl/content_main_delegate_efl.cc
SeungSeop Park [Thu, 12 Jun 2014 23:57:41 +0000 (08:57 +0900)]
break dependency to struct Ewk_Notification_Permission
It turned out to be unnecessary struct because
- no usage in current EWK api scope
- no caller for SetPermissionForAllNotifications()
- no chance for NotificationControllerEfl::ewk_notification_permissions_ to
have its element
- NotificationControllerEfl::IsDefaultAllowed() always return false
- NotificationControllerEfl::RemoveStoredOrigins() does no operation
Therefore, deleted the above mentioned member variable and functions.
Issue: CBEFL-92
Change-Id: I67b56caecf18dc427630ea581c5c6a658755974d
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Conflicts:
impl/content_main_delegate_efl.cc
SeungSeop Park [Tue, 24 Jun 2014 22:41:03 +0000 (15:41 -0700)]
break dependency to Ewk_Context v2 (removed ewk_context.h, ewk_object.h)
Ewk_Context is replaced by new class tizen_webview::WebContext.
To implement it, tizen_webview::RefCounted class is created to support intrusive
reference counting. The implementation was extracted from chromium's
base::RefCounted class, and then simplified (tizen_webview/tw_ref_counted.h).
The reason why not just rely on chromium's implementation is to avoid chromium
header inclusion in the tizen_webview's public headers, which should be exported
with dev package. With the same reason, a helper macro DISALLOW_COPY_AND_ASSIGN
is duplicated (tizen_webview/tw_macro.h) from chromium code.
Issue: CBEFL-92
Change-Id: I2adf95b446a68d9c71a30b7373e5ea7ffa73324c
SeungSeop Park [Mon, 9 Jun 2014 06:31:31 +0000 (15:31 +0900)]
break dependency to struct Ewk_Security_Origin (removed ewk_security_origin.h)
In Webkit2-efl, the definition for struct _Ewk_Security_Origin is hidden in
ewk_security_origin.cpp, and hence it's safe to redefine it as our need.
This commit redefines it as tizen_webview::Security_Origin class.
In addition,
- added tizen_webview::URL class to remove chromium's internal GURL
class dependency from tizen_webview::Security_Origin api.
- added a utility functions to convert between GURL and tizen_webview::URL
As a result, following files are added:
- src/tizen_webview/public/tw_security_origin.cc|h
- src/tizen_webview/public/tw_url.cc|h
- src/tizen_webview/tw_misc_utility.cc|h
Issue: CBEFL-92
Change-Id: Ic4d73a0a617b830c638fc2f9e5e701dfc7afbead
Conflicts:
impl/API/ewk_notification_private.h
impl/content_main_delegate_efl.cc
SeungSeop Park [Mon, 9 Jun 2014 02:19:56 +0000 (11:19 +0900)]
break dependency to struct Ewk_Touch_Point (removed ewk_touch.h)
Research for existing code:
- Ewk_Touch_Point's data layout is defined in the public ewk_touch.h, hence is
not changeable.
- ewk_view_feed_touch_event is the only EWK api related with it, but is not
depending directly on Ewk_Touch_Point but Eina_List of Ewk_Touch_Point
This commit is adopting a (rather simple) solution to remove the dependency:
- define a new class, tizen_webview::Touch_Point, for use inside chromium-efl
- let the ewk api implementation adapt itself to the new class
Note:
Currently, Touch_Point has the same layout with Ewk_Touch_Point. Therefore it's
possible to static_cast between them although may become incorrect in future.
Issue: CBEFL-92
Change-Id: I119f0a60262fda268459d61c4f45bee000833d87
SeungSeop Park [Sat, 7 Jun 2014 08:26:24 +0000 (17:26 +0900)]
break dependency to enum Ewk_Find_Options
Issue: CBEFL-92
Change-Id: I1ca7f84c9f0af20c7611702d23aadae5b842f9be
SeungSeop Park [Sat, 7 Jun 2014 08:12:00 +0000 (17:12 +0900)]
break dependency to enum Ewk_Input_Type
Note: No change was needed in chromium-ewk.
Issue: CBEFL-92
Change-Id: I14c9e0be1ea5d262afb463b809bcd616cdf6f1eb
SeungSeop Park [Sat, 7 Jun 2014 07:39:04 +0000 (16:39 +0900)]
break dependency to ewk_view.h (partial) : removed unused enums
Removed following enums which are used nowhere by chromium-efl:
- Ewk_Text_Direction
- Ewk_Selection_Handle_Type
- Ewk_Unfocus_Direction
- Ewk_Password_Popup_Option
- Ewk_Page_Visibility_State
- Ewk_Http_Method
In addition, deprecated unused smart api.
Issue: CBEFL-92
Change-Id: I75815f456cd49b40104f8428ce762f69dd7a368a
SeungSeop Park [Sat, 7 Jun 2014 00:11:41 +0000 (09:11 +0900)]
break dependency to Ewk_Custom_Handlers_(Data|Status) (removed ewk_custom_handlers.h)
Changes are:
- Ewk_Custom_Handlers_Data -> tizen_webview::Custom_Handlers_Data
- Ewk_Custom_Handlers_Status -> tizen_webview::Custom_Handlers_Status
- removed unused function declarations from ewk_view_private.h
. ewkCustomHandlersCreateData
. ewkCustomHandlersDeleteData
. ewkViewRegisterProtocolHandlers
. ewkViewIsProtocolHandlerRegistered
. ewkViewUnregisterProtocolHandlers
. ewkViewRegisterContentHandlers
. ewkViewIsContentHandlerRegistered
. ewkViewUnregisterContentHandlers
Issue: CBEFL-92
Change-Id: Ic7d6536d0376b8d1f7df543d8e89da850586a08a
Conflicts:
impl/API/ewk_view_private.h
SeungSeop Park [Sat, 7 Jun 2014 05:18:20 +0000 (14:18 +0900)]
break dependency: added tw_export.h (defines TW_EXPORT macro)
Although currently symbol export is managed by chromium-efl.filters export map,
it would be desirable to control the visibility in the source file, following
the chromium convention.
This commit defines TW_EXPORT macro to controll the symbol visibility, by
referencing CONTENT_EXPORT of content module.
Issue: CBEFL-92
Change-Id: I75ca8ae049bac6425f80651f6e02dc754bb2e810
SeungSeop Park [Fri, 6 Jun 2014 05:04:52 +0000 (14:04 +0900)]
break dependency to enum Ewk_Touch_Event_Type
Issue: CBEFL-92
Change-Id: Ib6a574da18eb14fb8b2f8a836c97e8d752f0673c
SeungSeop Park [Fri, 6 Jun 2014 04:37:46 +0000 (13:37 +0900)]
break dependency to Ewk_Policy_[Decision|Navigation]_Type
Issue: CBEFL-92
Change-Id: I143fff1e4e2e1d90d32323ba7a2442fcb64fc75b
SeungSeop Park [Fri, 6 Jun 2014 02:48:29 +0000 (11:48 +0900)]
break dependency to enum Ewk_Gesture_Type (removed ewk_enums.h)
Issue: CBEFL-92
Change-Id: I3371f0019d8c56669a83e961ef2f8a63734a56ae
SeungSeop Park [Thu, 5 Jun 2014 13:18:51 +0000 (22:18 +0900)]
break dependency to enum Ewk_Hit_Test_(Mode|Result_Context)
Issue: CBEFL-92
Change-Id: Id26628e92842b77453adf9171a1d8ca050202628
SeungSeop Park [Thu, 5 Jun 2014 08:29:55 +0000 (17:29 +0900)]
break dependency to enum Screen_Orientation_Degrees
Screen_Orientation_Degrees was used by eweb_view.h but not by chromium-ewk.
The orientation value is one of 0, 90, -90, 128, 270. Since it's not a public API
and ewk uses plain integers as does chromium content module, the enum has been
removed as using plain integer for orientation value.
In addition,
- enum Sreen_Orientation has been deleted becasue of no usage,
- Remove EWebView::GetCurrentOrienation() and the cached vEWebView::orientation_ :
use RenderViewHostImpl::GetOrientation() instead
TODO:
remove Ewk_Screen_Orientation_* from chromium-ewk's ewk_enums.h
if unnecessary for ewk api.
Issue: CBEFL-92
Change-Id: Id9ea7feb847769a562f724554eaa48626d2cdecf
Conflicts:
impl/eweb_view.cc
SeungSeop Park [Mon, 2 Jun 2014 11:35:47 +0000 (20:35 +0900)]
break dependency to ewk_context.h callbacks
- moved callbacks in ewk_context.h to tizen_webview/public/tw_callbacks.h
Issue: CBEFL-92
Change-Id: Iee7508ae39164e26b7bf4360d9de6db9f8e721ae
SeungSeop Park [Wed, 4 Jun 2014 08:12:38 +0000 (17:12 +0900)]
break dependency to enum Ewk_Legacy_Font_Size_Mode (removed ewk_settings.h)
- replaced Ewk_Legacy_Font_Size_Mode -> tizen_webview::Legacy_Font_Size_Mode
Issue: CBEFL-92
Change-Id: Ic6012ec2fe0817521067bf2f8df3b76ef85b3956
SeungSeop Park [Wed, 4 Jun 2014 05:27:41 +0000 (14:27 +0900)]
break dependency to enum Ewk_Cookie_Accept_Policy (remove ewk_cookie_manager.h)
- replaced Ewk_Cookie_Accept_Policy -> tizen_webview::Cookie_Accept_Policy
Issue: CBEFL-92
Change-Id: I154dc50d465193da235b2915dc3e7356b9b0b00d
SeungSeop Park [Sat, 31 May 2014 08:44:26 +0000 (17:44 +0900)]
break dependency to enum Ewk_Cache_Model
Refoctored Ewk_Cache_Model into tizen_webview::Cache_Model
This commit is also to setup tizen webview public api:
- add new namespace: tizen_webview
- add new directory: src/tizen_webview/public
The future direction for the public api is described in
src/tizen_webview/public/README.
Issue: CBEFL-92
Change-Id: Ie05a8152add4c2633778dbf15aa57cb6d41c191f
SeungSeop Park [Tue, 27 May 2014 04:55:33 +0000 (13:55 +0900)]
break dependency to ewk headers : preliminary step
chromium-efl should not depend on chromium-ewk, which is a higher level
module than chromium-efl.
This commit is the first step to break the dependency:
- simplified the header inclusions
- removed unnecessary ewk headers if possible
- removed redundant code lines in the remaining ewk headers
By this work the dependencies become more clear, which will ease the
ongoing works for dependency break.
Deleted headers are:
- ewk_auto_fill_profile.h
- ewk_csp_header_types.h (merged to ewk_view.h following webkit2-efl)
- ewk_error.h
- ewk_export.h
- ewk_history.h
- ewk_intercept_request.h
- ewk_private.h
Issue: CBEFL-92
Change-Id: Ibcf73be15f989f3a21ee5b394c34d3faab2ba457
Conflicts:
impl/browser/inputpicker/InputPicker.cc
Conflicts:
impl/web_contents_delegate_efl.cc
Dong-Jun Kim [Thu, 12 Jun 2014 02:44:52 +0000 (11:44 +0900)]
Fix memory leak issue on EWK_HIT_TEST
Change-Id: I8fd8b2b869091f6a2f3d77d29c3ba43f4300db6c
Umesh Kumar Patel [Fri, 6 Jun 2014 12:14:07 +0000 (17:44 +0530)]
WCS Feature: Autofill and Password Manager changes
Change-Id: Ib8493c89e6d82b04f572a0b800013f8a5593b905
Kamil Klimek [Mon, 2 Jun 2014 15:06:49 +0000 (17:06 +0200)]
Implement ewk_frame_is_main_frame
There are few cases when there is no RenderFrameHost or event
RenderViewHost associated with response. Such cases were not handled by
PolicyResponseDelegateEfl. This commit fixes behaviour with such
situations.
Issue: CBWEBVIEW-789
Change-Id: I96b4d0cf6f2db1a04176bfed5b4d4916c7c47100
Filip Piechocki [Fri, 6 Jun 2014 07:21:24 +0000 (09:21 +0200)]
Add implementation needed by ewk_view_web_application_icon_urls_get
Issue: CBWEBVIEW-579
Change-Id: I9056159a3a4fa966d87b4798ec863e407f804c83
Jan Zakrzewski [Wed, 4 Jun 2014 13:23:13 +0000 (15:23 +0200)]
Implementation of struct Ewk_Web_App_Icon_Data
Issue: CBWEBVIEW-580
Change-Id: I7a8ffd8baa3ac061298b9e86871db896b8e7e8e1
Kamil Klimek [Fri, 30 May 2014 08:29:20 +0000 (10:29 +0200)]
Fix an assert being hit in PolicyResponseDelegateEfl.
Change-Id: I85351e0b37a4c60d4fe0feb971ecd498ecfcbef9
Sergey [Thu, 19 Jun 2014 22:02:47 +0000 (15:02 -0700)]
Fix wrong magnifier image and refactoring of GetSnapshot from GPU.
Patch fixed wrong magnifier image on the top of a page and
refactoring of taking snapshot from frame buffer of GPU.
It contains only composed web page without browser controll elements.
Issue: CBGRAPHICS-248
Change-Id: I436d80a5c5f109b799331379ea738f8c25384796
Conflicts:
src/content/browser/gpu/gpu_process_host_ui_shim.cc
src/content/common/gpu/gpu_channel_manager.h
src/content/common/gpu/gpu_messages.h
src/content/port/browser/render_widget_host_view_port.h
Conflicts:
impl/browser/renderer_host/render_widget_host_view_efl.cc
src/content/port/browser/render_widget_host_view_port.h
Conflicts:
src/ui/gl/gl_surface.h
Dong-Jun Kim [Mon, 23 Jun 2014 23:16:56 +0000 (16:16 -0700)]
Patch for selectpicker(single type)
1. implement to single type of select picker
Issue : CBBROWSER-54, CBBROWSER-55, CBBROWSER-58, CBWRT-266
Change-Id: If3b331859c6010be02a40cf8c2f12da70bb2143d
Conflicts:
src/content/browser/renderer_host/render_view_host_impl.cc
Conflicts:
impl/eweb_view.h
Conflicts:
impl/web_contents_delegate_efl.h
src/content/renderer/render_thread_impl.cc
Kamil Klimek [Mon, 23 Jun 2014 21:18:30 +0000 (14:18 -0700)]
Implementation of text_selection_down and text_selection_up
Patch implements text_selection_down and text_selection_up.
Issue: CBWEBVIEW-523, CBWEBVIEW-524
Change-Id: Ib6fd99c402ec9d0a9fc26a055bb82cace89b5e4d
jywings.lee [Mon, 23 Jun 2014 18:22:37 +0000 (11:22 -0700)]
Implement the SDK WebInspector
JIRA: CBWEBCORE-24 CBWEBCORE-248
Change-Id: I2fbd7f24bc078bb4bc6acbedbadcf613406dc21d
Conflicts:
impl/eweb_view.h
src/content/browser/devtools/devtools_http_handler_impl.cc
Conflicts:
src/content/browser/devtools/devtools_http_handler_impl.h
Umesh Kumar Patel [Tue, 27 May 2014 09:56:38 +0000 (15:26 +0530)]
Add DB Path for Autofill FormData and LoginData support
Patch added DB path for Autofill FormData and LoginData support.
The path (/opt/usr/apps/org.tizen.chromium-efl/data/db) is assigned
Read & Write permission.
Jira ID: CBBROWSER-275
Change-Id: I20bcd2ae2f07eda3c9d31701ded43e6cc82bbd5f
Conflicts:
packaging/org.tizen.chromium-efl.manifest
Filip Piechocki [Thu, 19 Jun 2014 22:28:36 +0000 (15:28 -0700)]
Implement ewk_view_web_application_capable_get
Issue: CBWEBVIEW-577
Change-Id: I1d0eb5bd81ad883f11040d130722ce02d3d4b737
w.basiak [Tue, 27 May 2014 14:13:41 +0000 (16:13 +0200)]
Empty callback added to prevent crash for application cache delete all
Issue: CBWEBVIEW-317
Change-Id: I48cc96fc1b97246facda1f7cfb2d85f9d4f7e239
Tomasz Olszak [Sat, 17 May 2014 08:48:31 +0000 (10:48 +0200)]
Add possibility of using ccache in gbs build.
Task: CBEFL-34
Change-Id: If0ef10bffff3c2332e74d02d884814024504729b
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Kamil Klimek [Mon, 23 Jun 2014 18:19:09 +0000 (11:19 -0700)]
Dummy implementation of Smart API exceeded_database_quota
Issue: CBWEBVIEW-510
Change-Id: I3a4f7bbc886b0bcbcb93c0fafeda689c8f2528a9
Youngcheol Kang [Fri, 30 May 2014 08:57:21 +0000 (17:57 +0900)]
Dummy implementation for text_selection_up|down Smart API
Issue : CBWEBVIEW-523, CBWEBVIEW-523
Change-Id: I627d76aab8f1a8097b2ed81446de42f9ae244854
Lukasz Krok [Thu, 5 Jun 2014 13:52:28 +0000 (15:52 +0200)]
Fix for the Ordered / Unordered Icon Bug in email application
Issue : CBWEBVIEW-822
Cause : _ewk_view_text_style_state_cb callback was not executed on list style change in email application.
Solution : Query for selection style on editor command execution request.
Change-Id: I4fcc789c7d7ba45f76c0d00f96ecccd43dc42eb7
Piotr Tworek [Thu, 29 May 2014 17:10:16 +0000 (19:10 +0200)]
Fix race conditions in policy decision handling
The problems were:
1. The CompletionCallback delivered to browser process via
NetworkDelegateEfl::OnHeadersReceived could be called from the
browser process after content layer has canceled the request and
informed us about this via NetworkDelegateEfl::OnCompleted
2. The original HttpResponseHeders delivered to the browser through
NetworkDelegateEfl::OnHeadersReceived on IO thread can be accessed
from the UI thread after the content layer has invoked
NetworkDelegateEfl::OnURLRequestDestroyed (done through
_Ewk_Policy_Decision constructor). According to chromium
documentation the original HttpResponseHeaders are invalid after this
function is invoked.
The patch refactors NetworkDelegateEfl to avoid both situations.
1. Pending policy decisions storred in
NetworkDelegateEfl::policy_decision_delegate_map_ are removed in the
OnCompleted function when the status of the request is CANCELED or
FAILED. The policy decision is marked as processed.
2. The _Ewk_Policy_Decision is instantiated directly in the
PolicyResponseDelegateEfl constructor. The constructor is always called
from the IO thread so there is no chance HttpResponseHeaders will be
invalid there.
The patch was tested on both http://seojin.github.com/jsgamebench/ and
http://rng.io/?all. Previously both test suites would crash after a
couple of seconds at best. With the patch in place I could not reproduce
those crashes anymore.
Change-Id: Ia5217db9862b106f9f8dcd78cae4e557868dda7f
Issue-Id: CBWEBCORE-285, CBWEBCORE-290
Conflicts:
impl/web_contents_delegate_efl.cc
Youngbok Yoon [Wed, 28 May 2014 00:43:41 +0000 (09:43 +0900)]
Apply 'bold' type in editable field using JS execCommand('bold', ...)
Patch allows JS execCommand('bol', ...) to apply 'bold' type
in editable field.
Issue: CBBROWSER-247
Change-Id: Ie6a252d45d950fbcf537a10f8d9eb1aa0635a6f2
Piotr Tworek [Thu, 19 Jun 2014 18:34:42 +0000 (11:34 -0700)]
Improve text selection handling
This patch fixes several selection handle drawing issues caused by the
fact that SelectionBoxEfl was only fully updated from after mouse up event
handler was invoked. If a user manipulated the handles in a way that the
handles needed to be updated several times during one selection the end
results were not always matching the real state of the selection.
Long term, it'd be good if the selection state could be storred only in
one class. As it is right now the actual state of the selection resides
in the SelectionBoxEfl, while the visible state of the handles is in
SelectionHandleEfl. Those states are 'synchronized' in
SelectionControllerEfl. Such approach is very error prone as it's not
always obvious which state is valid at any given point in time.
Patch also hide context menu during magnifier is showing.
Issue-Id: CBBROWSER-156
Change-Id: I8c13e6c2734b294b5e912ce3a9fa78899da7e6de
Conflicts:
impl/browser/renderer_host/render_widget_host_view_efl.cc
impl/browser/renderer_host/render_widget_host_view_efl.h
impl/selection_controller_efl.cc
impl/selection_controller_efl.h
Piotr Tworek [Wed, 18 Jun 2014 23:08:30 +0000 (16:08 -0700)]
Implement text selection handles hiding.
Text selection handles should be hidden whenever they are scrolled
outside of visible text input area.
Issue-Id: CBBROWSER-156, CBBROWSER-190
Change-Id: I1fe7f97e03bcdd5bad0c2fdd207e492cdba41a12