profile/ivi/qtbase.git
13 years agoRemove code to selectively run test functions.
Jason McDonald [Wed, 5 Oct 2011 06:23:06 +0000 (16:23 +1000)]
Remove code to selectively run test functions.

QTestLib already makes a superior version of this functionality
available to all tests, without the need to recompile.  Each qtestlib
test program can be passed, via the command line, a list of test
functions and test data tags to be executed instead of executing all
test functions.

Change-Id: I1b54fc70a0c58a17209817afabfb953b5748dac4
Reviewed-on: http://codereview.qt-project.org/6015
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAvoid QSKIP in lieu of compile-time checks.
Jason McDonald [Wed, 5 Oct 2011 05:28:42 +0000 (15:28 +1000)]
Avoid QSKIP in lieu of compile-time checks.

Change compiler autotest to omit inapplicable functions at compile-time
in preference to skipping at run-time.

Change-Id: I8a221cadbb7b59d926754862332c0665673b8a56
Reviewed-on: http://codereview.qt-project.org/6011
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAvoid QSKIP in lieu of compile-time check.
Jason McDonald [Wed, 5 Oct 2011 05:10:37 +0000 (15:10 +1000)]
Avoid QSKIP in lieu of compile-time check.

Omit focusColors test function at compile-time in preference to
skipping at run-time.  Also removed commented out code.

Change-Id: Ib8955656f5a43b30df95b4c9865e52902dbd6b1e
Reviewed-on: http://codereview.qt-project.org/6010
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoTidy QActionGroup autotest.
Jason McDonald [Wed, 5 Oct 2011 04:43:11 +0000 (14:43 +1000)]
Tidy QActionGroup autotest.

Remove empty constructor/destructor.  Remove dropDownDeleted test
function which has been entirely skipped since before Qt 4.0, is
obviously incomplete (it attempts to use a QComboBox that does not
exist) and provides no statement of intention that might allow the
incompleteness to be addressed.

Change-Id: I4975b6d5a5dde1e58dab1dd393be92eddeb4c9f8
Reviewed-on: http://codereview.qt-project.org/6009
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoDon't build qwindowsurface autotest on Mac OS.
Jason McDonald [Tue, 4 Oct 2011 06:58:55 +0000 (16:58 +1000)]
Don't build qwindowsurface autotest on Mac OS.

The test was a no-op on Mac OS. It's better to avoid building or running
it on Mac OS, rather than spending time compiling and running a test
that does nothing on that platform.

Change-Id: I4aa579036788e404f8a6a8f1a80acd32338fb3cd
Reviewed-on: http://codereview.qt-project.org/5958
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoA QPA build on Linux requires xcb or wayland
Lincoln Ramsay [Wed, 5 Oct 2011 03:32:01 +0000 (13:32 +1000)]
A QPA build on Linux requires xcb or wayland

Require the user to pass -no-xcb and -no-wayland in order to produce
a build that has only the minimal plugin available.

This prevents "useless" builds from being accidentally created.

Change-Id: If2f7f516a52b75998f3ae7bf802f89f93f6e8218
Reviewed-on: http://codereview.qt-project.org/6005
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoIf -xcb is passed and we can't enable xcb, die
Lincoln Ramsay [Tue, 4 Oct 2011 03:20:42 +0000 (13:20 +1000)]
If -xcb is passed and we can't enable xcb, die

Needed to resolve issue QTBUG-21486

Change-Id: I5493cfa73f0433fda60fb0dd850380021e13b928
Reviewed-on: http://codereview.qt-project.org/5944
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoShow the -xcb default properly.
Lincoln Ramsay [Wed, 5 Oct 2011 03:18:59 +0000 (13:18 +1000)]
Show the -xcb default properly.

The * was not appearing against the default for the -xcb switch because
of a spelling mistake.

Change-Id: I3491cc9772d02179711b0d474db7ab2ef2398e88
Reviewed-on: http://codereview.qt-project.org/6003
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lincoln Ramsay <lincoln.ramsay@nokia.com>
13 years agoAdd QTest::keyRelease() accepting a Qt::Key value
Martin Jones [Wed, 5 Oct 2011 23:28:24 +0000 (09:28 +1000)]
Add QTest::keyRelease() accepting a Qt::Key value

Change-Id: Id7943820a71472ab1e3c81ea76701738d7600815
Reviewed-on: http://codereview.qt-project.org/6085
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoAccessible: remove calls with virtual int children in test.
Frederik Gladhorn [Wed, 5 Oct 2011 07:40:04 +0000 (09:40 +0200)]
Accessible: remove calls with virtual int children in test.

Change-Id: I08ba2fab8ed17b75b971c86cb085af4d3828ec8a
Reviewed-on: http://codereview.qt-project.org/6025
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoClean up accessible spin box test.
Frederik Gladhorn [Tue, 4 Oct 2011 14:46:45 +0000 (16:46 +0200)]
Clean up accessible spin box test.

Change-Id: Ic56f5a99ee57a23d43a81d66af82324ecba8964c
Reviewed-on: http://codereview.qt-project.org/5994
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoRemove empty test function.
Frederik Gladhorn [Tue, 4 Oct 2011 14:48:23 +0000 (16:48 +0200)]
Remove empty test function.

Change-Id: I02b688a25ab77a2df2da8beb57eb94a7432e537d
Reviewed-on: http://codereview.qt-project.org/5995
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoUse child/parent function in QAccessibleWidget and test.
Frederik Gladhorn [Tue, 4 Oct 2011 12:20:05 +0000 (14:20 +0200)]
Use child/parent function in QAccessibleWidget and test.

This also uncovered a missing implementation of child for
dock widgets.

Change-Id: Iac4c5a51d4626769af11b277a9a345e1e31dc490
Reviewed-on: http://codereview.qt-project.org/5987
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoRemove obsolete QMatrix test function.
Jason McDonald [Tue, 4 Oct 2011 07:19:52 +0000 (17:19 +1000)]
Remove obsolete QMatrix test function.

The operator tested by this function (QMatrix * QRect) has not existed
since Qt 2.x.

Change-Id: Id09154de2bdda70c0fe342fe78b82709953e2b56
Reviewed-on: http://codereview.qt-project.org/5965
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoDon't build qitemview autotest on IRIX.
Jason McDonald [Tue, 4 Oct 2011 06:24:54 +0000 (16:24 +1000)]
Don't build qitemview autotest on IRIX.

The test was being skipped one test function at a time on IRIX.  It's
better to avoid building or running it, rather than spending time
running a test that does nothing on that platform.

This commit also turns a silent skip on other platforms into an explicit
QSKIP to make it more obvious that there's an unfixed TODO there.

Change-Id: I7cae4f0f2eaebf5977a781b2ce15d1e71ef13b36
Reviewed-on: http://codereview.qt-project.org/5957
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemoved disabled test data in QDir autotest.
Jason McDonald [Tue, 4 Oct 2011 06:03:02 +0000 (16:03 +1000)]
Removed disabled test data in QDir autotest.

The unprintablenames test was designed to prevent an old failure in
QDir from returning, but the test can't be run reliably on some
file-systems and certainly isn't going to achieve its goal when it's
commented out.

Change-Id: Ib4cb965d59c291ab2436130b87e865ac21b9b483
Reviewed-on: http://codereview.qt-project.org/5956
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove last remnants of Maemo 5 from autotests
Jason McDonald [Tue, 4 Oct 2011 04:48:26 +0000 (14:48 +1000)]
Remove last remnants of Maemo 5 from autotests

Change-Id: I69bc9a3fc5ec4f7f9b927919ca7627a8a1e61700
Reviewed-on: http://codereview.qt-project.org/5951
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove last remnants of symbian in autotests.
Jason McDonald [Tue, 4 Oct 2011 04:22:40 +0000 (14:22 +1000)]
Remove last remnants of symbian in autotests.

Change-Id: I91489614653cfe4bcf16b723976e33531402a464
Reviewed-on: http://codereview.qt-project.org/5948
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoQNAM - fix poor performance of HEAD request with authentication
Shane Kearns [Mon, 3 Oct 2011 15:27:34 +0000 (16:27 +0100)]
QNAM - fix poor performance of HEAD request with authentication

QHttpNetworkReply was waiting for a body to be sent for 401 and 407
responses, whereas with a HTTP HEAD request, there will be no body.

This delayed the authentication signal until after the http channel
is closed by the server after a timeout. For example with the server
used for autotesting, the authentication signal is delayed 15 seconds.

When the server has a very long timeout, the authentication signal may
not be emitted at all.

Task-Number: QT-5304
Reviewed-By: Martin Petersson
(cherry picked from commit 8610ee14b8636641651a8ba6040cca16c4141ed6)

Change-Id: Ie4ce6c598df86ce59910f793fd5ae7c1ccf39f9d
Reviewed-on: http://codereview.qt-project.org/6032
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
13 years agoQtGui: Add command line arguments to the platform plugin.
Friedemann Kleint [Wed, 5 Oct 2011 09:08:32 +0000 (11:08 +0200)]
QtGui: Add command line arguments to the platform plugin.

Set -platformargument foo[=bar] as a dynamic property
on the native interface.

Change-Id: Ica8b25478da0ce9508b90370f15812fd11ff5d13
Reviewed-on: http://codereview.qt-project.org/6031
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oliver Wolff <oliver.wolff@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoDon't use implicit QAtomic* casts in QFreeList
Bradley T. Hughes [Thu, 29 Sep 2011 09:45:01 +0000 (11:45 +0200)]
Don't use implicit QAtomic* casts in QFreeList

Pair the _next.testAndSetRelease() call in QFreeList<T>::release() with
_next.loadAcquire(), to ensure that the update to the bucket
being released is properly fenced.

QFreeList<T>:next() does not need a release fence, only an acquire fence,
which is placed on the memory bucket address load.

Change-Id: Ib5b9d6ef6107f87aa8e3ea2dd3a7f9116c75da70
Reviewed-by: Thiago Macieira
Reviewed-on: http://codereview.qt-project.org/5802
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
13 years agoFix boolean logic issues in qcoreapplication_win
Kent Hansen [Wed, 5 Oct 2011 09:58:34 +0000 (11:58 +0200)]
Fix boolean logic issues in qcoreapplication_win

Task-number: QTBUG-20482

Change-Id: Iadbde59953a86d5f74d68c7cdc36b7706525612c
Reviewed-on: http://codereview.qt-project.org/6046
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
13 years agoRemove duplicate check for glDeleteProgram
Kent Hansen [Wed, 5 Oct 2011 10:31:14 +0000 (12:31 +0200)]
Remove duplicate check for glDeleteProgram

It's already checked for earlier in the expression.

Task-number: QTBUG-20482
Change-Id: Iad7e8fa80aab98d47d90ecb0c497245450cdfa40
Reviewed-on: http://codereview.qt-project.org/6052
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoAdd missing Q_OBJECT macro to GoToStateTransition
Kent Hansen [Wed, 5 Oct 2011 09:33:01 +0000 (11:33 +0200)]
Add missing Q_OBJECT macro to GoToStateTransition

The missing macro caused qFindChild() to return any
QAbstractTransition.

Task-number: QTBUG-21813
Change-Id: I80507aa86c8c32d7fa59a1b5ae551043f5f90315
Reviewed-on: http://codereview.qt-project.org/6044
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
13 years agoAdd font family alias resolving to QPA
Jiang Jiang [Tue, 4 Oct 2011 12:52:13 +0000 (14:52 +0200)]
Add font family alias resolving to QPA

By default it doesn't do anything special, but for fontconfig font db
it will do some tricks to convert alias like serif to actualy font
family names like Times.

Change-Id: I73058d187a5422e6f93bc1b728cecdc0250d5e1e
Reviewed-on: http://codereview.qt-project.org/5984
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
13 years agoAdded QWindow::isActive() and focus in / out events.
Samuel Rødal [Thu, 29 Sep 2011 16:02:54 +0000 (18:02 +0200)]
Added QWindow::isActive() and focus in / out events.

Renamed QGuiApplication::activeWindow() to
QGuiApplication::focusWindow(), implemented QWindow::isActive() as a
style hint, and added focus in / out events.

Change-Id: I71866e76c5a817def3e17bcc20a4fc32081a0e7a
Reviewed-on: http://codereview.qt-project.org/5811
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
13 years agoAvoid using QSKIP in lieu of compile-time checks
Jason McDonald [Tue, 4 Oct 2011 03:23:23 +0000 (13:23 +1000)]
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: I582732e3dd657df834f9a98fd52d7ee368f2f29b
Reviewed-on: http://codereview.qt-project.org/5946
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove Symbian-only test function.
Jason McDonald [Tue, 4 Oct 2011 02:14:01 +0000 (12:14 +1000)]
Remove Symbian-only test function.

Change-Id: I817c234a6104a072f131c17e9492c68d79ca5f8d
Reviewed-on: http://codereview.qt-project.org/5943
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAvoid using QSKIP in lieu of compile-time checks
Jason McDonald [Tue, 4 Oct 2011 01:51:31 +0000 (11:51 +1000)]
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: Ib2025339422749cf216e87ac414a3056250bf8f9
Reviewed-on: http://codereview.qt-project.org/5942
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoCocoa: Fix a variable shadowing issue that caused a crash on mac
Zeno Albisser [Tue, 4 Oct 2011 16:16:34 +0000 (18:16 +0200)]
Cocoa: Fix a variable shadowing issue that caused a crash on mac

Change-Id: I2d5ceb9502c769b5a585cdc6f1053168dfadbf12
Reviewed-on: http://codereview.qt-project.org/6000
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
13 years agoDeclarative: Fix linking of the testlib plugin (Windows).
Friedemann Kleint [Tue, 4 Oct 2011 13:33:34 +0000 (15:33 +0200)]
Declarative: Fix linking of the testlib plugin (Windows).

qtdeclarative/src/imports/testlib uses the exported variable
QTest::printAvailableFunctions.

As it is a plugin, it has only QT_DLL defined and not QT_SHARED
and thus sees Q_TESTLIB_EXPORT=''.

Change-Id: I34646e920a812fb907b60e0c4c9399499d689a01
Reviewed-on: http://codereview.qt-project.org/5990
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoImplement showFullScreen, showNormal, and showMaximized/Minimized in QWindow.
Alexis Menard [Tue, 4 Oct 2011 13:09:34 +0000 (15:09 +0200)]
Implement showFullScreen, showNormal, and showMaximized/Minimized in QWindow.

The implementation was just missing to call the proper APIs.

Merge-request: 65
Change-Id: I52f7825360bf55d37762421562484af684bf2dc8
Reviewed-on: http://codereview.qt-project.org/5986
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agomake it possible to disable wayland support
Oswald Buddenhagen [Wed, 21 Sep 2011 09:11:14 +0000 (11:11 +0200)]
make it possible to disable wayland support

Change-Id: I8640b5fdc0f2a20d7349f7a43e61e6b37f59d3a0
Reviewed-on: http://codereview.qt-project.org/5334
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
13 years agoWindows/configure.exe: Build V8 by default.
Friedemann Kleint [Thu, 29 Sep 2011 14:53:43 +0000 (16:53 +0200)]
Windows/configure.exe: Build V8 by default.

Change-Id: I01f31f683fcac322c2a8bec313a48057939ebeb0
Reviewed-on: http://codereview.qt-project.org/5809
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoCocoa: Add env variable for disabling foreground.
Morten Sorvig [Tue, 4 Oct 2011 07:54:38 +0000 (09:54 +0200)]
Cocoa: Add env variable for disabling foreground.

Setting QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM
prevents the process from having an dock icon and
taking focus.

Change-Id: Id127967d8ec1dadda790128f36a7c1f50d581433
Reviewed-on: http://codereview.qt-project.org/5968
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Zeno Albisser <zeno.albisser@nokia.com>
13 years agoFix compilation on Harmattan
Simon Hausmann [Mon, 3 Oct 2011 15:19:07 +0000 (17:19 +0200)]
Fix compilation on Harmattan

Include Xlib.h for XInitThreads and add the SUPPORT_X11 macro
to DEFINES for Harmattan's EGL library.

Change-Id: I34ad284fe5b671f3924e406a18b8c5520df8346a
Reviewed-on: http://codereview.qt-project.org/5935
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix XCB back-end on Harmattan
Simon Hausmann [Tue, 4 Oct 2011 08:36:47 +0000 (10:36 +0200)]
Fix XCB back-end on Harmattan

Use RGB16 as image format on 16-bpp displays.

Based on patch by Jocelyn

Change-Id: Ic91ab33132769da59a2097abb43b64a2d09c0009
Reviewed-on: http://codereview.qt-project.org/5971
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoDon't crash by modifying read-only shared_null
Bradley T. Hughes [Mon, 3 Oct 2011 13:21:02 +0000 (15:21 +0200)]
Don't crash by modifying read-only shared_null

Functions that modify the d-pointer must detach or otherwise take
measures to not modify the const, read-only shared_null.

The setSharable(bool) function takes care to detach when setting
sharable to false, but should avoid setting the sharable data member
unless d is not the shared null.

Similarly, QMap<Key, T>::setInsertInOrder() needs to detach if it is
shared with the shared_null (the logic has been updated to be the same
as setSharable()).

Change-Id: Ida5cb9818b86695f1b9f0264418b955c56424898
Reviewed-on: http://codereview.qt-project.org/5929
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agotestlib: Fix header guard files
Sergio Ahumada [Mon, 3 Oct 2011 16:49:51 +0000 (18:49 +0200)]
testlib: Fix header guard files

Change-Id: Ia33423f9bd3f85259da908706d73cc2da4d8964d
Reviewed-on: http://codereview.qt-project.org/5937
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
13 years agoAvoid using QSKIP in lieu of compile-time checks
Jason McDonald [Tue, 4 Oct 2011 00:32:49 +0000 (10:32 +1000)]
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: I21664d8d92b27c26c64789fc08d0ec7b8988456a
Reviewed-on: http://codereview.qt-project.org/5941
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAdded bug ref in insignificant_test comment
Jo Asplin [Mon, 3 Oct 2011 16:11:57 +0000 (18:11 +0200)]
Added bug ref in insignificant_test comment

Task-number: QTBUG-21814

Change-Id: I56907f2a1fb5555d338b6f1f695b741e1590e5d2
Reviewed-on: http://codereview.qt-project.org/5936
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
13 years ago[fontdatabase] Use the CONFIG += qpa/genericunixfontdatabase
Holger Hans Peter Freyther [Mon, 3 Oct 2011 14:46:08 +0000 (16:46 +0200)]
[fontdatabase] Use the CONFIG += qpa/genericunixfontdatabase

Late follow up of fc9a648dc03ec4531553bc3d65ae4dba3c5b5980 that
tries to make plugins indifferent of where the source is located
in relation to qtbase.

Change-Id: I9a5944fe737056216c7174d8d9151c8d0e776a22
Merge-request: 64
Reviewed-on: http://codereview.qt-project.org/5933
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix compilation on Harmattan
Simon Hausmann [Mon, 3 Oct 2011 14:40:01 +0000 (16:40 +0200)]
Fix compilation on Harmattan

Improved fix from e327401743dba9112faca77fd764869709ae4367 to add the
necessary includes in the header file, where the types are also needed.
The same header file is also included from the xcb plugin.

Change-Id: I52a891be1ecc67d49a088a4db698270a06db6b54
Reviewed-on: http://codereview.qt-project.org/5932
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix compilation on Harmattan
Simon Hausmann [Mon, 3 Oct 2011 13:27:37 +0000 (15:27 +0200)]
Fix compilation on Harmattan

The inclusion of qbearerengine_p.h requires network-private

Change-Id: Ie28136dc6ee423721978d073fd401fecde2a7d35
Reviewed-on: http://codereview.qt-project.org/5930
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix compilation on Harmattan
Simon Hausmann [Mon, 3 Oct 2011 13:22:14 +0000 (15:22 +0200)]
Fix compilation on Harmattan

Include X11 headers to get VisualID and other "types".

Change-Id: Idbb323329d346726b98312b1e02c9b199f2b7a65
Reviewed-on: http://codereview.qt-project.org/5928
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix ́́`macros' function test of `tst_headers'
Sergio Ahumada [Mon, 3 Oct 2011 11:17:30 +0000 (13:17 +0200)]
Fix ́́`macros' function test of `tst_headers'

Task-number: QTQAINFRA-324
Change-Id: I3202d9ee42de8174c5170f1b853884b19d5895e3
Reviewed-on: http://codereview.qt-project.org/5925
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoFix bug in QGraphicsItem::isVisibleTo().
Andreas Aardal Hanssen [Thu, 29 Sep 2011 12:54:15 +0000 (14:54 +0200)]
Fix bug in QGraphicsItem::isVisibleTo().

Task-number: QTBUG-21612
Reviewed-by: James Perrett
Reviewed-by: Magne Pettersen Zachrisen
Change-Id: I570c673a817c3c01593fcd7fa46d545f34e2c38d
Merge-request: 1396
Reviewed-by: Jan-Arve Saether <jan-arve.saether@nokia.com>
Reviewed-on: http://codereview.qt-project.org/5927
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoSimplify QAccessibleAbstractScrollArea and Calendar.
Frederik Gladhorn [Wed, 28 Sep 2011 13:36:52 +0000 (15:36 +0200)]
Simplify QAccessibleAbstractScrollArea and Calendar.

Change-Id: Iea1df37fd9fd486295458ec7627f5b6908053cdf
Reviewed-on: http://codereview.qt-project.org/5727
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoCocoa: Send proper mouse coordinates.
Morten Sorvig [Thu, 29 Sep 2011 12:24:59 +0000 (14:24 +0200)]
Cocoa: Send proper mouse coordinates.

Clear up coordinate system confusion. Also change
QApplicationPrivate::pickMouseReceiver to indicate
that, yes, it does modify the 3rd argument in
addition to returning the mouse receiver widget.

Change-Id: If2c44eff65aedfdc78c6da1728f31d6e2db71f9d
Reviewed-on: http://codereview.qt-project.org/5919
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
13 years agoMoving wayland plugin to the qtwayland submodule
Paul Olav Tvete [Fri, 30 Sep 2011 07:13:32 +0000 (09:13 +0200)]
Moving wayland plugin to the qtwayland submodule

The wayland platform plugin now lives in its own Qt module, together with
the qtcompositor library.

Change-Id: I4e85292cf41da4ef021ea832545ac37f5ed4e991
Reviewed-on: http://codereview.qt-project.org/5836
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Reviewed-by: Andy Nichols
13 years agoqpixmap: Use the primaryScreen for QPixmap::defaultDepth
Holger Hans Peter Freyther [Mon, 3 Oct 2011 08:16:22 +0000 (10:16 +0200)]
qpixmap: Use the primaryScreen for QPixmap::defaultDepth

Currently tst_QPixmap::testMetrics can fail if the native
display resolution is below 32 bpp. Upate the documentation,
use the primary screen to find the depth.

Tested-on: XCB and directFB plugin.

Change-Id: I29c08db25d8f6bcee01f9315ed90685fef668e0c
Merge-request: 61
Reviewed-on: http://codereview.qt-project.org/5917
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoPrevent QPixmapCache potentially growing indefinitely.
Samuel Rødal [Fri, 9 Sep 2011 07:51:18 +0000 (09:51 +0200)]
Prevent QPixmapCache potentially growing indefinitely.

QPixmapCache has until now refused to throw out shared pixmaps, i.e.
ones that still have shallow copies lying around. This leads to problems
when someone inserts two shallow copies using different keys, causing
the cache itself containing multiple shallow copies and thus forever
refusing to throw out those entries.

It's rather easy for this to accidentally happen in a user application
since QPixmap::load() or QPixmap(const QString &fileName, ...)
automatically cache the pixmap in the QPixmapCache, thus if the user
then calls QPixmapCache::insert() on the same pixmap or a shallow copy
it is locked in the QPixmapCache forever.

The only reason for not throwing out a pixmap that's shared would be to
prevent re-loading a pixmap from file when a user has a direct reference
to it in his application, but in that case the user is unlikely to
re-load the pixmap from file in any case. Therefore it seems the best
fix is to get rid of this limitation.

Task-number: QTBUG-21359
Reviewed-by: John Brooks
Reviewed-by: Olivier Goffart
(cherry picked from commit 7ab0bed3a56d46c386e65abc381264c57137cb43)

Change-Id: I46dce19227e19a25e0287cf7372177430da15a66
Reviewed-on: http://codereview.qt-project.org/4563
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
13 years agoRename description to localizedDescription in Action interface.
Frederik Gladhorn [Mon, 26 Sep 2011 13:19:49 +0000 (15:19 +0200)]
Rename description to localizedDescription in Action interface.

Change-Id: I9e15dabd47bb7dc27cb3748f6763789d8ccc7b42
Reviewed-on: http://codereview.qt-project.org/5622
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoUse interfaces in QAccessibleWidget childAt.
Frederik Gladhorn [Wed, 28 Sep 2011 15:03:07 +0000 (17:03 +0200)]
Use interfaces in QAccessibleWidget childAt.

Simplify the implementation of childAt.
Using rect(child) depends on the virtual children.

For QAccessibleMenuBar the implementation would assert.

Change-Id: I6ef018a063beee67d7436dff148e8b0219ff2a3c
Reviewed-on: http://codereview.qt-project.org/5742
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoFix selection update in QTableView accessibility.
Frederik Gladhorn [Wed, 28 Sep 2011 14:47:16 +0000 (16:47 +0200)]
Fix selection update in QTableView accessibility.

Change-Id: Ib9353f8be3614798767578c34f1bc6d1a9e66c13
Reviewed-on: http://codereview.qt-project.org/5740
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoMove the documentation for the classes to their modules.
Casper van Donderen [Tue, 20 Sep 2011 21:22:36 +0000 (23:22 +0200)]
Move the documentation for the classes to their modules.

All documented classes under src/widgets should now be
under the QtWidgets module in the documentation. The
QtPrintSupport classes should now be under the QtPrintSupport
module in the documentation.

Change-Id: I236b15443b8b93a61578a1d10f52b64dba938f29
Reviewed-on: http://codereview.qt-project.org/5520
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
13 years agoCocoa: Fix spelling errors in comments.
Morten Sorvig [Wed, 28 Sep 2011 08:35:17 +0000 (10:35 +0200)]
Cocoa: Fix spelling errors in comments.

This could be the basis for a "english spelling
for norwegians" course.

Change-Id: I1d6de11b6673ec0a8ba3c2ff12dd8472fb467703
Reviewed-on: http://codereview.qt-project.org/5691
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
13 years agoCocoa: Fix window resizing
Morten Sorvig [Fri, 30 Sep 2011 06:52:00 +0000 (08:52 +0200)]
Cocoa: Fix window resizing

Set the geomeotry on the platform window on resize. (There
used to be a callback form the QWindow earlier.)

Change-Id: I2298a03d1e015279b28a02da9f05f90f25148efb
Reviewed-on: http://codereview.qt-project.org/5834
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
13 years agoUse QGuiApp::activeWindow()->accessibleRoot() to find focus child
Jan-Arve Saether [Thu, 22 Sep 2011 15:21:36 +0000 (17:21 +0200)]
Use QGuiApp::activeWindow()->accessibleRoot() to find focus child

queryAccessibleInterface will return 0 if the object is a QWindow, so
it would never find the focus child.

Change-Id: Ib5bb6a0e4ffbf1b8491b71d1ba5a039e7a6584e0
Reviewed-on: http://codereview.qt-project.org/5842
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoSmall cleanup.
Jan-Arve Saether [Tue, 27 Sep 2011 11:01:32 +0000 (13:01 +0200)]
Small cleanup.

Change-Id: I8661e28fca2069bf4034f7a9d2b5e1bbde2d542a
Reviewed-on: http://codereview.qt-project.org/5843
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoFix QWindowsAccessible::GetWindow()
Jan-Arve Saether [Thu, 22 Sep 2011 14:10:35 +0000 (16:10 +0200)]
Fix  QWindowsAccessible::GetWindow()

Since we added QAI::window() we now have a more reliable way of
getting hold of a HWND.

Change-Id: I330ecee67f041d5b204ef4bc1401ce4cc76de2b7
Reviewed-on: http://codereview.qt-project.org/5840
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoMake all uses of QBasicAtomicInt and Pointer use load() and store()
Thiago Macieira [Tue, 5 Jul 2011 21:46:19 +0000 (23:46 +0200)]
Make all uses of QBasicAtomicInt and Pointer use load() and store()

Most of these changes are search-and-replace of d->ref ==, d->ref !=
and d->ref =.

The QBasicAtomicPointer in QObjectPrivate::Connection didn't need to
be basic, so I made it QAtomicPointer.

Change-Id: Ie3271abd1728af599f9ab17c6f4868e475f17bb6
Reviewed-on: http://codereview.qt-project.org/5030
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoAdd placeholders for loadAcquire and storeRelease in the atomics
Thiago Macieira [Sat, 2 Jul 2011 10:02:10 +0000 (12:02 +0200)]
Add placeholders for loadAcquire and storeRelease in the atomics

This should be replaced later with proper loadAcquire and storeRelease
functions in the architectures that require them. The code right now
is enough for x86, x86-64 and IA-64. It's probably not good for ARM
and MIPS.

Change-Id: Iaa28a18cad64772539662439c2c14690ec26940f
Reviewed-on: http://codereview.qt-project.org/5029
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoAdded QWindow::requestedFormat()
Gunnar Sletta [Thu, 29 Sep 2011 18:42:27 +0000 (20:42 +0200)]
Added QWindow::requestedFormat()

Change-Id: I9e69ddd8ceefeda87216fb3d2507c40bc7220cf5
Reviewed-on: http://codereview.qt-project.org/5846
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoadd a latency after simulating keyevets since they are queued up
Gunnar Sletta [Wed, 28 Sep 2011 18:09:34 +0000 (20:09 +0200)]
add a latency after simulating keyevets since they are queued up

Change-Id: Iaaaf01ab464cb2d310ed738de85ffdecd6cd854f
Reviewed-on: http://codereview.qt-project.org/5770
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Matthew Cattell <matthew.cattell@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agoWindows plugin: Fix compilation with MinGW.
Friedemann Kleint [Fri, 30 Sep 2011 13:59:33 +0000 (15:59 +0200)]
Windows plugin: Fix compilation with MinGW.

Change-Id: I6c522b121fbac31ac5fc60a9125e1565e78d50c0
Reviewed-on: http://codereview.qt-project.org/5890
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoTests: Fix compilation on Windows.
Friedemann Kleint [Thu, 29 Sep 2011 07:39:33 +0000 (09:39 +0200)]
Tests: Fix compilation on Windows.

Replace Q_WS_... by Q_OS_... in corelib tests.

Change-Id: I14c41dca1ec490b3c49ba2c24e60def14c6de9da
Reviewed-on: http://codereview.qt-project.org/5778
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agotest: Re-enabled `tst_moc' test that is now passing on Linux
Sergio Ahumada [Thu, 29 Sep 2011 09:46:38 +0000 (11:46 +0200)]
test: Re-enabled `tst_moc' test that is now passing on Linux

This test was fixed by 1cc70b92c8c838a013b45af6814ea6532245067a

Change-Id: If6fa3724f7c31e952ebff1dd27fea1a1e4635a85
Reviewed-on: http://codereview.qt-project.org/5783
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
13 years agoRemove the remaining traces of QT3_SUPPORT
Lars Knoll [Wed, 28 Sep 2011 20:20:06 +0000 (22:20 +0200)]
Remove the remaining traces of QT3_SUPPORT

The only place that now still knows about it is moc,
so it can still parse old headers.

Change-Id: Iafec080f99c67560974e9ebc0cbfb27d9a4b2d6f
Reviewed-on: http://codereview.qt-project.org/5755
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoUpdate .gitignore
Bradley T. Hughes [Thu, 29 Sep 2011 12:25:29 +0000 (14:25 +0200)]
Update .gitignore

Add these 3 files to .gitignore:
src/platformsupport/qtplatformsupportversion.h
src/printsupport/qtprintsupportversion.h
src/widgets/qtwidgetsversion.h

Change-Id: Ie13360de9e64e79cb714adba0d2f6e6da0051ae8
Reviewed-on: http://codereview.qt-project.org/5797
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agotest: Re-enabled `tst_qtranslator' test that is now passing on Linux
Sergio Ahumada [Fri, 30 Sep 2011 11:44:30 +0000 (13:44 +0200)]
test: Re-enabled `tst_qtranslator' test that is now passing on Linux

This test was fixed by db3418c10b7831db0e6c567ccf49c34698cad1ab

Task-number: QTBUG-21125
Change-Id: I1bc549353f16c0df2b6c33533298b302fcc4d4ed
Reviewed-on: http://codereview.qt-project.org/5877
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoDon't use un-guarded printfs for debug logging in XCB platform plugin
Tor Arne Vestbø [Fri, 30 Sep 2011 11:43:44 +0000 (13:43 +0200)]
Don't use un-guarded printfs for debug logging in XCB platform plugin

Using qDebug() instead of printf and friends allows clients to install a
message handler to supress the output.

The remaining printfs in the code are all guarded by custom debug ifdefs.

Change-Id: I38edc7452184783152f26b4dde6342c3bb9ef799
Reviewed-on: http://codereview.qt-project.org/5875
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoAvoid using QSKIP in lieu of compile-time checks
Jason McDonald [Fri, 30 Sep 2011 03:19:21 +0000 (13:19 +1000)]
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278
Change-Id: I31e069f5476f8adf9851e94b33c6afac4394b88e
Reviewed-on: http://codereview.qt-project.org/5824
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove QT_MOC_COMPAT signals
Lars Knoll [Wed, 28 Sep 2011 20:34:12 +0000 (22:34 +0200)]
Remove QT_MOC_COMPAT signals

These are also obsolete since quite some time.

Change-Id: Id04543ff4a4464922a204f59989abaeedb18df14
Reviewed-on: http://codereview.qt-project.org/5756
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoSend key events to the active window when tlw in qpa event is null
Laszlo Agocs [Thu, 29 Sep 2011 07:28:28 +0000 (10:28 +0300)]
Send key events to the active window when tlw in qpa event is null

Change-Id: Ie055918276d716b0f4f23b6a9d34c23c5459d960
Reviewed-on: http://codereview.qt-project.org/5777
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
13 years agoRename Qt::escape to QString::toHtmlEscaped, add compat method
David Faure [Thu, 29 Sep 2011 11:31:39 +0000 (13:31 +0200)]
Rename Qt::escape to QString::toHtmlEscaped, add compat method

Merge-request: 56
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: I46bbb2df10968e88b5eb5ef8dae182a651b622b8
Reviewed-on: http://codereview.qt-project.org/5793
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoMove Qt::escape to QtCore
David Faure [Thu, 29 Sep 2011 11:31:39 +0000 (13:31 +0200)]
Move Qt::escape to QtCore

Merge-request: 56
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: I25c5f46cf53a653db26dbeb92865e61f69980bfd
Reviewed-on: http://codereview.qt-project.org/5792
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoRefactor accessibility for Qt5
Jan-Arve Saether [Fri, 16 Sep 2011 04:56:48 +0000 (06:56 +0200)]
Refactor accessibility for Qt5

* Moved most stuff to gui\accessible
* Moved widget-specific stuff to widgets\accessible
* Moved platform-specific code to either the bridge plugin (this was already the case)
  or to the platform plugin.
* Added several classes and functions. These have not yet gone through an API
  review. The plan is to do that in a later commit.
  Classes:
   - QPlatformAccessibility
   - QWindowsAccessibility
  Functions:
   - QWindow *QAccessibleInterface::window();
   - QPlatformAccessibility *QPlatformIntegration::accessibility()

* The bridge code can now either be a plugin or integrated into the platform plugin
* Mac accessibility is left out for now. Unix "should still work" (tm). These platforms
  should be fixed soon.

Change-Id: Ib49ffa73b647ee0af90864544c2769440157f562
Reviewed-on: http://codereview.qt-project.org/5330
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
13 years agoRemove obsolete function isHeaderVisible.
Frederik Gladhorn [Thu, 29 Sep 2011 10:53:02 +0000 (12:53 +0200)]
Remove obsolete function isHeaderVisible.

This function was deprecated in Qt4 and has
been replaced by isNavigationBarVisible.
Same for the setter.

Change-Id: Ifdcbaa2db0d4d8d475d959a6409347fa19d443a9
Reviewed-on: http://codereview.qt-project.org/5788
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dietrich-de@nokia.com>
13 years agoFix the qtranslator autotest
Lars Knoll [Wed, 28 Sep 2011 21:06:00 +0000 (23:06 +0200)]
Fix the qtranslator autotest

Properly propagate the language change event
to all widgets.

Change-Id: I6650205abe1acc6979e28ca5c5dde5ae33a406b9
Reviewed-on: http://codereview.qt-project.org/5758
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
13 years agoFix moc autotest
Lars Knoll [Wed, 28 Sep 2011 20:42:28 +0000 (22:42 +0200)]
Fix moc autotest

QWidget is not in QtGui anymore, this broke the
test. Simply use QWindow instead.

Change-Id: Ic0176410f08b10771b663aa3ecd70295c124b662
Reviewed-on: http://codereview.qt-project.org/5757
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
13 years agoGet rid of the last traces of QMimeSource
Lars Knoll [Wed, 28 Sep 2011 18:30:25 +0000 (20:30 +0200)]
Get rid of the last traces of QMimeSource

The class has been deprecated since Qt 4.0, but
couldn't be removed as QDropEvent inherited from
it.

Change-Id: I9caa19b30977a319e79255900dee8b2425783f46
Reviewed-on: http://codereview.qt-project.org/5754
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
13 years agoRemove Symbian-specific code from tests.
Jason McDonald [Tue, 27 Sep 2011 09:53:01 +0000 (19:53 +1000)]
Remove Symbian-specific code from tests.

Symbian is not a supported platform for Qt5, so this code is no longer
required.

Change-Id: I1172e6a42d518490e63e9599bf10579df08259aa
Reviewed-on: http://codereview.qt-project.org/5657
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoreimplemented doUpdateMicroFocus to work without calling the base implementation
Matthew Cattell [Wed, 28 Sep 2011 11:52:59 +0000 (13:52 +0200)]
reimplemented doUpdateMicroFocus to work without calling the base implementation

Change-Id: Ic96ab2bb93248e6d3ba1c8b789ed3c21f8ad39bd
Reviewed-on: http://codereview.qt-project.org/5716
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
Reviewed-by: Holger Ihrig <holger.ihrig@nokia.com>
13 years agoRegister whether a glyph run goes from RTL or LTR
Eskil Abrahamsen Blomfeldt [Wed, 28 Sep 2011 10:36:39 +0000 (12:36 +0200)]
Register whether a glyph run goes from RTL or LTR

This is needed by scene graph when embedding text objects in
RTL text. Since the number of flags required for
QGlyphRun is increasing, I've also refactored the
underline/overline/strikethrough settings to use a common
QFlags interface.

Task-number: QTBUG-20917
Change-Id: I070649c014f4a51cfd66a9579d2d221a8f22302f
Reviewed-on: http://codereview.qt-project.org/5739
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agoQTemporaryFile: Test what happens if current dir isn't writable.
David Faure [Wed, 28 Sep 2011 11:32:37 +0000 (13:32 +0200)]
QTemporaryFile: Test what happens if current dir isn't writable.

No surprises, QTemporaryFile("tempXXXXXX") fails. But that is
consistent with QFile::open, and it's documented, so ok.

Change-Id: I04c805a242aeda8327d25be238da6120b3c90f5a
Merge-request: 57
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-on: http://codereview.qt-project.org/5714
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoQTemporaryFile: use QCoreApplication::applicationName() as base filename
David Faure [Wed, 28 Sep 2011 11:32:36 +0000 (13:32 +0200)]
QTemporaryFile: use QCoreApplication::applicationName() as base filename

Merge-request: 57
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: I2a29b2ba925ea92a5299272b80164658775e9c0e
Reviewed-on: http://codereview.qt-project.org/5713
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoImplement support for QGuiApp::setOverrideCursor()
Lars Knoll [Mon, 26 Sep 2011 20:59:46 +0000 (22:59 +0200)]
Implement support for QGuiApp::setOverrideCursor()

Properly support application override cursors and move
the documentation into the proper place.

Change-Id: I0198b38e0d2e7b10f0fcae342b468e7f8341bf02
Reviewed-on: http://codereview.qt-project.org/5562
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
13 years agoAdapted most QInputContext usage on widgets to QInputPanel
Pekka Vuorela [Tue, 27 Sep 2011 11:36:56 +0000 (14:36 +0300)]
Adapted most QInputContext usage on widgets to QInputPanel

Including most of stuff excluding mouse event handling
which differs between the classes.

Change-Id: Iff1e56b9c50c3f84de2d1c43a3416a1952197a17
Reviewed-on: http://codereview.qt-project.org/5640
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoRemove support for QWidget specific input contexts
Pekka Vuorela [Fri, 23 Sep 2011 12:28:19 +0000 (15:28 +0300)]
Remove support for QWidget specific input contexts

QInputContext is migrated to QInputPanel, which allows only one
instance.

Change-Id: I4912164790d5a6bdff41e11cbe4bc4e2f9f111ec
Reviewed-on: http://codereview.qt-project.org/5641
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoAdapt QGraphicsView from QInputContext to QInputPanel
Pekka Vuorela [Fri, 23 Sep 2011 11:29:07 +0000 (14:29 +0300)]
Adapt QGraphicsView from QInputContext to QInputPanel

Change-Id: Icbb458af7914f0af3e37ac012aa7c1cbd5f3a023
Reviewed-on: http://codereview.qt-project.org/5631
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Joona Petrell <joona.t.petrell@nokia.com>
13 years agoAdd missing Q_ENUMS macro to QInputPanel
Joona Petrell [Wed, 28 Sep 2011 08:40:05 +0000 (11:40 +0300)]
Add missing Q_ENUMS macro to QInputPanel

Change-Id: I4e27013a06ea4fc9899a8a737e90d6792e6fb3a0
Reviewed-on: http://codereview.qt-project.org/5699
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Pekka Vuorela <pekka.ta.vuorela@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoMake examples build with Qt-in-namespace
Kent Hansen [Wed, 28 Sep 2011 07:49:05 +0000 (09:49 +0200)]
Make examples build with Qt-in-namespace

Change-Id: Ie4710b8f3afb44191927bab94eb47e00207cb831
Reviewed-on: http://codereview.qt-project.org/5684
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoMake qtbase build with Qt-in-namespace again
Kent Hansen [Fri, 23 Sep 2011 13:01:04 +0000 (15:01 +0200)]
Make qtbase build with Qt-in-namespace again

Change-Id: I5faa8690a05d6ec352fc69c0b69848539f2ed216
Reviewed-on: http://codereview.qt-project.org/5460
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoMake QTest::qWarn() use __FILE__ and __LINE__.
Jason McDonald [Thu, 25 Aug 2011 05:43:01 +0000 (15:43 +1000)]
Make QTest::qWarn() use __FILE__ and __LINE__.

This change makes QTest::qWarn() consistent with similar testlib
functions, which take __FILE__ and __LINE__.

Change-Id: I12977cb30672899ab38877b4a656f0cc0c7ea02c
Reviewed-on: http://codereview.qt-project.org/3559
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRe-enable the Windows plugin.
Friedemann Kleint [Wed, 28 Sep 2011 06:59:08 +0000 (08:59 +0200)]
Re-enable the Windows plugin.

Revert 732bfbe8e8445a95965874752e586887f1dcbbc1.

Change-Id: Ia24d06b4e89936ede97c89b76214d1a9c9de9b53
Reviewed-on: http://codereview.qt-project.org/5679
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoAdd qtcore.qdoc. The QtCore main page was missing from the docs.
Casper van Donderen [Tue, 20 Sep 2011 12:27:05 +0000 (14:27 +0200)]
Add qtcore.qdoc. The QtCore main page was missing from the docs.

Change-Id: Id81f7b11302538dee9d3459b1feb0ad93c53fada
Reviewed-on: http://codereview.qt-project.org/5519
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
13 years agoUse module prefixed include paths, avoids warnings in configure.
Pekka Vuorela [Tue, 27 Sep 2011 12:19:20 +0000 (15:19 +0300)]
Use module prefixed include paths, avoids warnings in configure.

Change-Id: I081fa49073da532647836ddd1087c0f5fcf32775
Reviewed-on: http://codereview.qt-project.org/5634
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoWidgets: Remove QT3_SUPPPORT.
Friedemann Kleint [Tue, 27 Sep 2011 12:48:51 +0000 (14:48 +0200)]
Widgets: Remove QT3_SUPPPORT.

Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Change-Id: Ie884f0cc9b3970b01c3c0c26600b1bcd92548077
Reviewed-on: http://codereview.qt-project.org/5629
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoRemoved obsolete QWidget::resetInputContext()
Pekka Vuorela [Fri, 23 Sep 2011 09:13:39 +0000 (12:13 +0300)]
Removed obsolete QWidget::resetInputContext()

Replaced functionality with new QInputPanel interface.

Change-Id: I5543f725724b2b208dcf18366712a18b665439b2
Reviewed-on: http://codereview.qt-project.org/5630
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Joona Petrell <joona.t.petrell@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>