platform/upstream/mesa.git
20 months agoradv: emit PA_SU_PRIM_FILTER_CNTL in the graphics preamble
Samuel Pitoiset [Thu, 10 Nov 2022 16:54:43 +0000 (17:54 +0100)]
radv: emit PA_SU_PRIM_FILTER_CNTL in the graphics preamble

This register doesn't change.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19654>

20 months agoradv: determine if sample positions are needed at pipeline bind time
Samuel Pitoiset [Tue, 8 Nov 2022 10:28:36 +0000 (11:28 +0100)]
radv: determine if sample positions are needed at pipeline bind time

Like other ring stuff that depends on pipelines.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19654>

20 months agoradv: simplify load_sample_mask_in lowering
Samuel Pitoiset [Thu, 10 Nov 2022 16:19:19 +0000 (17:19 +0100)]
radv: simplify load_sample_mask_in lowering

From the Vulkan spec:
    "Sample shading is enabled if at least one of the following
     conditions is true:

     - VkPipelineMultisampleStateCreateInfo::sampleShadingEnable is
       set to VK_TRUE, or
     - the fragment shader’s entry point interface includes input
       variables decorated with a BuiltIn of SampleId or SamplePosition
       built-ins."

We don't need to pass the number of rasterization samples, checking
for sample shading is enough. This will help for dynamic rasterization
samples.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19654>

20 months agoetnaviv: rs: set TS_MODE for inplace resolve
Lucas Stach [Tue, 15 Nov 2022 16:30:22 +0000 (17:30 +0100)]
etnaviv: rs: set TS_MODE for inplace resolve

When using the inplace resolve the TS_MODE isn't taken from the
RS_SOURCE_STRIDE state, but need to be set in RS_EXTRA_CONFIG.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19751>

20 months agoetnaviv: update headers from rnndb
Lucas Stach [Tue, 15 Nov 2022 16:28:39 +0000 (17:28 +0100)]
etnaviv: update headers from rnndb

Update to etna_viv commit 59403372cb48.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19751>

20 months agoetnaviv: don't select TS modifier when not FAST_CLEAR capable
Lucas Stach [Tue, 15 Nov 2022 16:24:56 +0000 (17:24 +0100)]
etnaviv: don't select TS modifier when not FAST_CLEAR capable

When presented with a list of modifiers to choose from we must never
pick a shared TS modifier if the local instance isn't FAST_CLEAR capable.

Fixes: c2b06e1a3820 ("etnaviv: add support for sharing the TS buffer")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19751>

20 months agoradv/ci: mark the whole texturequerylod subtests as flakes on renoir
Martin Roukala (né Peres) [Tue, 15 Nov 2022 10:49:53 +0000 (12:49 +0200)]
radv/ci: mark the whole texturequerylod subtests as flakes on renoir

Seems like we keep on getting more of these flakes, so let's be a bit
broader.

Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19742>

20 months agogallium/pipe: Trim trailing spaces in src/gallium/include/pipe/*.h
Yonggang Luo [Sat, 5 Nov 2022 06:44:12 +0000 (14:44 +0800)]
gallium/pipe: Trim trailing spaces in src/gallium/include/pipe/*.h

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19545>

20 months agoci: Drop a couple of -Werror exceptions from fedora-release job
Michel Dänzer [Tue, 15 Nov 2022 10:59:54 +0000 (11:59 +0100)]
ci: Drop a couple of -Werror exceptions from fedora-release job

No corresponding warnings left.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19744>

20 months agoci: Drop -Wno-error=unused-const-variable from debian-clang job
Michel Dänzer [Tue, 15 Nov 2022 10:57:26 +0000 (11:57 +0100)]
ci: Drop -Wno-error=unused-const-variable from debian-clang job

No corresponding warnings left.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19744>

20 months agoci: Drop a couple of -Werror exceptions from debian-android job
Michel Dänzer [Tue, 15 Nov 2022 10:55:22 +0000 (11:55 +0100)]
ci: Drop a couple of -Werror exceptions from debian-android job

No corresponding warnings left.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19744>

20 months agoradv: rework how vertex buffer descriptors are flushed
Samuel Pitoiset [Mon, 14 Nov 2022 10:38:12 +0000 (11:38 +0100)]
radv: rework how vertex buffer descriptors are flushed

Dirty the flag at pipeline bind time, instead of passing this useless
pipeline_is_dirty flag.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19724>

20 months agoradv: use more radv_dynamic_state pointers in radv_emit_XXX() helpers
Samuel Pitoiset [Tue, 8 Nov 2022 08:52:20 +0000 (09:52 +0100)]
radv: use more radv_dynamic_state pointers in radv_emit_XXX() helpers

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19678>

20 months agoradv: cleanup radv_emit_viewport()
Samuel Pitoiset [Tue, 8 Nov 2022 08:49:50 +0000 (09:49 +0100)]
radv: cleanup radv_emit_viewport()

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19678>

20 months agoradv: constify more pointers in radv_emit_XXX() helpers
Samuel Pitoiset [Tue, 8 Nov 2022 08:43:01 +0000 (09:43 +0100)]
radv: constify more pointers in radv_emit_XXX() helpers

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19678>

20 months agoradv: cleanup radv_CmdSetXXX() functions
Samuel Pitoiset [Tue, 8 Nov 2022 08:35:04 +0000 (09:35 +0100)]
radv: cleanup radv_CmdSetXXX() functions

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19678>

20 months agoaco: adjust an assertion about nir_texop_txf_ms and GFX11
Samuel Pitoiset [Wed, 9 Nov 2022 09:46:30 +0000 (10:46 +0100)]
aco: adjust an assertion about nir_texop_txf_ms and GFX11

This can fail with RADV_DEBUG=nofmask.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19613>

20 months agoradv: introduce RADV_DEBUG=nofmask
Samuel Pitoiset [Tue, 8 Nov 2022 14:09:02 +0000 (15:09 +0100)]
radv: introduce RADV_DEBUG=nofmask

To disable MSAA compression on MSAA images. This will also allow us to
emulate GFX11 (FMASK has been removed) and to experiment 32 byte
descriptor sizes.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19613>

20 months agoci: Add va frontend to windows-build-rules
Sil Vilerino [Tue, 15 Nov 2022 22:59:30 +0000 (17:59 -0500)]
ci: Add va frontend to windows-build-rules

Fixes: 2d504bc5 ("CI: Add gallium-va and video-codecs in windows-vs2019 and debian-mingw32-x86_64")

Signed-off-by: Sil Vilerino <sivileri@microsoft.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19767>

20 months agofreedreno/a6xx: Fix dummy binning pass FS shader
Rob Clark [Sun, 13 Nov 2022 21:30:55 +0000 (13:30 -0800)]
freedreno/a6xx: Fix dummy binning pass FS shader

No changes, but it looks funning to see in the binning pass that FS uses
r0 and hr0.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/a6xx: Un-open-code some event names
Rob Clark [Sun, 13 Nov 2022 21:29:50 +0000 (13:29 -0800)]
freedreno/a6xx: Un-open-code some event names

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/a6xx: Don't disable LRZ for invalid channels
Rob Clark [Sun, 13 Nov 2022 16:35:54 +0000 (08:35 -0800)]
freedreno/a6xx: Don't disable LRZ for invalid channels

Similar idea to commit ("c9db71c8ba1 turnip: Don't disable LRZ for color
write mask channels beyond the format's"), but different implementation.
If the blend state masks writes to a color channel that doesn't exist,
that doesn't mean we need to disable LRZ write.  In particular, this
scenario will come up with z-prepasses (doh!)

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/a6xx: Improve LRZ test for stencil write
Rob Clark [Sat, 12 Nov 2022 20:49:15 +0000 (12:49 -0800)]
freedreno/a6xx: Improve LRZ test for stencil write

If all the ops are KEEP, we don't actually write the stencil, and can
avoid falling off the LRZ fastpath.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/a6xx: Use same LRZ state for draw and binning
Rob Clark [Sat, 12 Nov 2022 20:24:51 +0000 (12:24 -0800)]
freedreno/a6xx: Use same LRZ state for draw and binning

Originally these where split as that is what the blob GL driver did (at
least at the time).  But that turns out to be unnecessary, so simplify
things and combine them into a single LRZ state object like tu does.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/a6xx: Handle additional depth test funcs
Rob Clark [Sat, 12 Nov 2022 19:48:52 +0000 (11:48 -0800)]
freedreno/a6xx: Handle additional depth test funcs

These were left as a TODO, and we forgot to revisit.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agofreedreno/drm: Fix suballoc alignment
Rob Clark [Sat, 12 Nov 2022 23:34:08 +0000 (15:34 -0800)]
freedreno/drm: Fix suballoc alignment

IBO/etc descriptors need to be aligned to 64.. this was handled
correctly in the stateobj case (for tex descriptors) but not in
the streaming case (for IBO).

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19710>

20 months agopanfrost: Don't set job_barrier on vertex jobs
Alyssa Rosenzweig [Sat, 29 Oct 2022 20:41:05 +0000 (16:41 -0400)]
panfrost: Don't set job_barrier on vertex jobs

This was a hack needed for the old transform feedback code. This barrier
is handled by the explicit XFB emulation that we're using on Midgard
now, so we don't need the barrier in the general case.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19760>

21 months agor300: tweak nir loop unrolling hint for r500 vertex shaders
Pavel Ondračka [Sat, 12 Nov 2022 19:48:47 +0000 (20:48 +0100)]
r300: tweak nir loop unrolling hint for r500 vertex shaders

This should prevent some cxbx-r shaders from unrolling above the
instruction limit and results in 3 gained cxbx-r shaders on RV530
with no other changes in shader-db.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5967

Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Filip Gawin <filip@gawin.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19702>

21 months agofreedreno: Add one flake
Yonggang Luo [Tue, 15 Nov 2022 19:40:34 +0000 (03:40 +0800)]
freedreno: Add one flake

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7713

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19759>

21 months agoglsl: Drop borrow/carry lowerings in favor of nir
M Henning [Sat, 12 Nov 2022 20:53:30 +0000 (15:53 -0500)]
glsl: Drop borrow/carry lowerings in favor of nir

Unconditionally lowering prevents GL drivers from natively
implementing these ops. Drivers that need lowering should set
lower_uadd_carry and lower_usub_borrow on nir_shader_compiler_options to
get the nir lowerings.

Tested with dEQP-GLES31.functional.shaders.builtin_functions.integer.*

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19704>

21 months agopps: make pps-producer RT only on freedreno
Chia-I Wu [Fri, 11 Nov 2022 01:45:28 +0000 (17:45 -0800)]
pps: make pps-producer RT only on freedreno

Calling sched_setscheduler twice every sample period has high CPU
overhead.  For intel and panfrost, their dump_perfcnt is preemptible and
they don't need the scheduler change.

For freedreno, simply makes the main thread RT at all time.  This solves
most of the cpu overhead issue.

v2: removed pthread_t param and just change the scheduler for the
    calling thread

Acked-by: Rob Clark <robdclark@chromium.org> (v1)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19668>

21 months agoutil: Include the needed util/detect*.h headers in multiple files
Yonggang Luo [Fri, 11 Nov 2022 11:40:28 +0000 (19:40 +0800)]
util: Include the needed util/detect*.h headers in multiple files

This is discovered either by manually or -W-no-def option

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agoutil: Remove the unused PIPE_(ARCH|OS|CC) macro defines from src/util/detect_arch...
Yonggang Luo [Fri, 11 Nov 2022 11:15:27 +0000 (19:15 +0800)]
util: Remove the unused PIPE_(ARCH|OS|CC) macro defines from src/util/detect_arch.h and src/util/detect_cc.h

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agotree-wide: Convert all usage of PIPE_(OS|ARCH|CC)_* to DETECT_(OS|ARCH|CC)_* by use...
Yonggang Luo [Fri, 11 Nov 2022 11:04:14 +0000 (19:04 +0800)]
tree-wide: Convert all usage of PIPE_(OS|ARCH|CC)_* to DETECT_(OS|ARCH|CC)_* by use grep

This should be the last commit, and should be take care that can only in comment block or
version
Exclude files:
src/util/detect_*.h

From:
PIPE_(OS|ARCH|CC)_([0-9A-Z_]+)
To:
DETECT_$1_$2

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agotree-wide: Convert all usage of #ifndef PIPE_(OS|ARCH|CC)_* to #if DETECT_(OS|ARCH...
Yonggang Luo [Fri, 11 Nov 2022 11:01:06 +0000 (19:01 +0800)]
tree-wide: Convert all usage of #ifndef PIPE_(OS|ARCH|CC)_* to #if DETECT_(OS|ARCH|CC)_* by use grep

From:
#ifndef[\s]+PIPE_(OS|ARCH|CC)_([0-9A-Z_]+)
To:
#if !DETECT_$1_$2

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agotree-wide: Convert all usage of #ifdef PIPE_(OS|ARCH|CC)_* to #if DETECT_(OS|ARCH...
Yonggang Luo [Fri, 11 Nov 2022 11:00:31 +0000 (19:00 +0800)]
tree-wide: Convert all usage of #ifdef PIPE_(OS|ARCH|CC)_* to #if DETECT_(OS|ARCH|CC)_* by use grep

From:
#ifdef[\s]+PIPE_(OS|ARCH|CC)_([0-9A-Z_]+)
To:
#if DETECT_$1_$2

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agotree-wide: Convert all usage of defined PIPE_(OS|ARCH|CC)_* to DETECT_(OS|ARCH|CC...
Yonggang Luo [Fri, 11 Nov 2022 10:59:55 +0000 (18:59 +0800)]
tree-wide: Convert all usage of defined PIPE_(OS|ARCH|CC)_* to DETECT_(OS|ARCH|CC)_* by use grep

From:
defined[\s]*PIPE_(OS|ARCH|CC)_([0-9A-Z_]+)
To:
DETECT_$1_$2

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agotree-wide: Convert all usage of defined(PIPE_(OS|ARCH|CC)_*) to DETECT_(OS|ARCH|CC...
Yonggang Luo [Fri, 11 Nov 2022 10:59:21 +0000 (18:59 +0800)]
tree-wide: Convert all usage of defined(PIPE_(OS|ARCH|CC)_*) to DETECT_(OS|ARCH|CC)_* by use grep

From:
defined[\s]*\([\s]*PIPE_(OS|ARCH|CC)_([0-9A-Z_]+)[\s]*\)
To:
DETECT_$1_$2

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agoutil: Add DETECT_ARCH_* and DETECT_CC_* macros for latter usage
Yonggang Luo [Thu, 10 Nov 2022 17:06:36 +0000 (01:06 +0800)]
util: Add DETECT_ARCH_* and DETECT_CC_* macros for latter usage

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agoutil: Move compiler configuration defines from detect_arch.h into detect_cc.h
Yonggang Luo [Thu, 10 Nov 2022 06:14:10 +0000 (14:14 +0800)]
util: Move compiler configuration defines from detect_arch.h into detect_cc.h

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agoutil: Rename src/gallium/include/pipe/p_config.h to src/util/detect_arch.h
Yonggang Luo [Wed, 9 Nov 2022 07:00:37 +0000 (15:00 +0800)]
util: Rename src/gallium/include/pipe/p_config.h to src/util/detect_arch.h

Even though the defines in p_config.h are stared with PIPE_, they are indeed
are generic detecting mechanics, we will rename them to DETECT_* in latter MR

We rename src/gallium/include/pipe/p_config.h src/util/detect_arch.h because
the detect code in src/gallium/include/pipe/p_config.h are most about
processor architecture detecting.

The file util/detect.h is added to replace functional of src/gallium/include/pipe/p_config.h
So we replace of #include "pipe/p_config.h" with #include "util/detect.h"

The file util/detect_cc.h is added as a placeholder for moving compiler related macro defines
from p_config.h into it in following commits

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agoutil: Test __PPC64__ for getting PIPE_ARCH_PPC_64 respond to __PPC64__ take effect
Yonggang Luo [Sun, 6 Nov 2022 12:34:28 +0000 (20:34 +0800)]
util: Test __PPC64__ for getting PIPE_ARCH_PPC_64 respond to __PPC64__ take effect

Fixes: e737a99a6fb ("Fix PPC detection on darwin")

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19674>

21 months agofrontend/va: Fix WIN32 VA_DRIVER_INIT_FUNC declaration. Remove declspec as it uses...
Sil Vilerino [Tue, 15 Nov 2022 17:04:19 +0000 (12:04 -0500)]
frontend/va: Fix WIN32 VA_DRIVER_INIT_FUNC declaration. Remove declspec as it uses .def file

Fixes: b557ceb7 ("frontends/va: Add windows VA frontend support via vl_winsys_win32 and libva-win32")
Closes: #7702

Signed-off-by: Sil Vilerino <sivileri@microsoft.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19754>

21 months agoutil: Add test for util_get_process_name_may_override
Yonggang Luo [Thu, 10 Nov 2022 16:16:52 +0000 (00:16 +0800)]
util: Add test for util_get_process_name_may_override

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Add tests for os_mman.h and util_get_process_name_may_override
Yonggang Luo [Thu, 10 Nov 2022 12:06:14 +0000 (20:06 +0800)]
util: Add tests for os_mman.h and util_get_process_name_may_override

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Move src/gallium/auxiliary/os/os_mman.h to src/util/os_mman.h
Yonggang Luo [Thu, 10 Nov 2022 11:25:01 +0000 (19:25 +0800)]
util: Move src/gallium/auxiliary/os/os_mman.h to src/util/os_mman.h

Use "util/detect_os.h" instead of "pipe/p_config.h" and "pipe/p_compiler.h"
in src/util/os_mman.h

This is a prepare to implement os_mman on windows

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Replace the usage of os_get_command_line with util_get_command_line
Yonggang Luo [Thu, 10 Nov 2022 15:40:11 +0000 (23:40 +0800)]
util: Replace the usage of os_get_command_line with util_get_command_line

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Merge the code from os_process.c into u_process.c
Yonggang Luo [Thu, 10 Nov 2022 11:05:07 +0000 (19:05 +0800)]
util: Merge the code from os_process.c into u_process.c

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Remove usage of boolean and duplicated code in os_process.*
Yonggang Luo [Thu, 10 Nov 2022 10:56:26 +0000 (18:56 +0800)]
util: Remove usage of boolean and duplicated code in os_process.*

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: Merge the __getProgramName code under HAIKU os
Yonggang Luo [Thu, 10 Nov 2022 10:31:42 +0000 (18:31 +0800)]
util: Merge the __getProgramName code under HAIKU os

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19645>

21 months agoutil: cleanup cpuinfo.* and it's related files
Yonggang Luo [Mon, 7 Nov 2022 03:00:21 +0000 (11:00 +0800)]
util: cleanup cpuinfo.* and it's related files

_mesa_get_cpu_features is no more a needed thing as all it's usage are
replaced with util_get_cpu_caps in u_cpu_detect.h

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19564>

21 months agomesa/vbo: Replace the usage of cpu_has_sse4_1 with util_get_cpu_caps()->has_sse4_1...
Yonggang Luo [Mon, 7 Nov 2022 02:44:39 +0000 (10:44 +0800)]
mesa/vbo: Replace the usage of cpu_has_sse4_1 with util_get_cpu_caps()->has_sse4_1 in vbo/vbo_minmax_index.c

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19564>

21 months agoutil: Use util_get_cpu_caps instead cpu_has_sse4_1 macro
Yonggang Luo [Sat, 5 Nov 2022 13:35:29 +0000 (21:35 +0800)]
util: Use util_get_cpu_caps instead cpu_has_sse4_1 macro

cpu_has_sse4_1 doesn't belongs to src/util, so do not depends on it,
this is a follow up of that u_cpu_detect.* doesn't depends on
pipe/p_*.h anymore

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19564>

21 months agoutil: Drop include "pipe/p_config.h" in src/util/u_cpu_detect.h
Yonggang Luo [Fri, 11 Nov 2022 12:55:22 +0000 (20:55 +0800)]
util: Drop include "pipe/p_config.h" in src/util/u_cpu_detect.h

It's comes from src/gallium/include/pipe/p_config.h and that getting
streaming-load-memcpy.c can not use of it

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19564>

21 months agoci/nouveau: Add some recent flakes
Emma Anholt [Tue, 15 Nov 2022 18:42:41 +0000 (10:42 -0800)]
ci/nouveau: Add some recent flakes

Closes: #7708
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19757>

21 months agomicrosoft/compiler: Delete now-unused memcpy lowering pass
Jesse Natalie [Tue, 15 Nov 2022 17:00:21 +0000 (09:00 -0800)]
microsoft/compiler: Delete now-unused memcpy lowering pass

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19752>

21 months agomicrosoft/clc: Optimize memcpys
Jesse Natalie [Tue, 15 Nov 2022 16:59:30 +0000 (08:59 -0800)]
microsoft/clc: Optimize memcpys

Use the optimization pass to try to remove them, and if that fails,
at least use the core nir lowering pass which is better about fixed-
size memcpys compared to the one we wrote for DXIL.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19752>

21 months agoaco: move statistics enum to aco_shader_info.h
Daniel Schürmann [Fri, 1 Jul 2022 09:19:19 +0000 (11:19 +0200)]
aco: move statistics enum to aco_shader_info.h

to make it accessible from the driver.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19721>

21 months agoradv: use radv_fill_nir_compiler_options() helper for prolog/epilog
Daniel Schürmann [Mon, 26 Sep 2022 13:04:00 +0000 (15:04 +0200)]
radv: use radv_fill_nir_compiler_options() helper for prolog/epilog

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19721>

21 months agoradv: create radv_fill_nir_compiler_options() helper function
Daniel Schürmann [Thu, 30 Jun 2022 14:34:18 +0000 (16:34 +0200)]
radv: create radv_fill_nir_compiler_options() helper function

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19721>

21 months agoaco: fix p_interp_gfx11 to not overwrite SCC
Samuel Pitoiset [Tue, 15 Nov 2022 05:51:24 +0000 (05:51 +0000)]
aco: fix p_interp_gfx11 to not overwrite SCC

s_wqm_b64 clobbers SCC.
Found this while working on dual source blending.

Fixes: 6113ee650a2 ("aco/gfx11: fix FS input loads in quad-divergent control flow")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19747>

21 months agoci/alpine: build Mesa on top of Alpine 3.16
David Heidelberg [Fri, 14 Oct 2022 02:19:31 +0000 (21:19 -0500)]
ci/alpine: build Mesa on top of Alpine 3.16

Alpine is lightweight distribution with musl-libc. We currently testing
with Debian and Fedora, which are both Glibc based distro, so this
option should be able give us chance to catch more build-system bugs.

Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19588>

21 months agoci/freedreno: add missing traces
David Heidelberg [Mon, 5 Sep 2022 12:05:13 +0000 (14:05 +0200)]
ci/freedreno: add missing traces

Tested with:
```
.gitlab-ci/bin/ci_run_n_monitor.py --rev $(git rev-parse HEAD) --target ".*a[0-9]*-traces$" --force-manual
```

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19503>

21 months agoclover: empty soversion when on win32
Yonggang Luo [Thu, 10 Nov 2022 16:45:56 +0000 (00:45 +0800)]
clover: empty soversion when on win32

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7675
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Prodea Alexandru-Liviu <liviuprodea@yahoo.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19653>

21 months agointel: Use common CONCAT/PASTE macros
Matt Coster [Thu, 9 Jun 2022 14:03:01 +0000 (15:03 +0100)]
intel: Use common CONCAT/PASTE macros

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agoglx: Use common CONCAT/PASTE macros
Matt Coster [Wed, 8 Jun 2022 10:44:55 +0000 (11:44 +0100)]
glx: Use common CONCAT/PASTE macros

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agogallium: Use common CONCAT/PASTE macros
Matt Coster [Wed, 8 Jun 2022 10:44:49 +0000 (11:44 +0100)]
gallium: Use common CONCAT/PASTE macros

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agoamd: Use common CONCAT/PASTE macros
Matt Coster [Wed, 8 Jun 2022 10:44:40 +0000 (11:44 +0100)]
amd: Use common CONCAT/PASTE macros

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agoutil: Add common CONCAT/PASTE macros
Matt Coster [Wed, 8 Jun 2022 10:39:45 +0000 (11:39 +0100)]
util: Add common CONCAT/PASTE macros

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agointel: Unify naming of CONCAT/PASTE macros
Matt Coster [Thu, 9 Jun 2022 13:57:30 +0000 (14:57 +0100)]
intel: Unify naming of CONCAT/PASTE macros

In isl/isl_priv.h:
 - __PASTE2 => PASTE2
 - __PASTE => CONCAT2

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Lionel Landwerlin <lionel.g.landwerlin@intel.com>

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agoglx: Unify naming of CONCAT/PASTE macros
Matt Coster [Thu, 9 Jun 2022 13:56:05 +0000 (14:56 +0100)]
glx: Unify naming of CONCAT/PASTE macros

In glxextensions.c:
 - CONCAT => PASTE2

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agogallium: Unify naming of CONCAT/PASTE macros
Matt Coster [Thu, 9 Jun 2022 13:55:13 +0000 (14:55 +0100)]
gallium: Unify naming of CONCAT/PASTE macros

In auxiliary/draw/draw_pt_vsplit_tmp.h:
 - CONCAT2 => PASTE2
 - CONCAT => CONCAT2

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agoamd: Unify naming of CONCAT/PASTE macros
Matt Coster [Thu, 9 Jun 2022 13:52:37 +0000 (14:52 +0100)]
amd: Unify naming of CONCAT/PASTE macros

In compiler/tests/framework.h:
 - _PASTE => PASTE2
 - PASTE => CONCAT2

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16945>

21 months agodocs: move generic gallium envvars to root doc
Erik Faye-Lund [Tue, 8 Nov 2022 10:10:45 +0000 (11:10 +0100)]
docs: move generic gallium envvars to root doc

It makes little sense to document the gallium envvars in multiple
places. Let's merge them all into the root envvar document.

This also moves GALLIUM_OVERRIDE_CPU_CAPS to toe root envvars doc, as
it's more generic than just LLVMpipe.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: remove duplicate envvars
Erik Faye-Lund [Tue, 8 Nov 2022 10:02:24 +0000 (11:02 +0100)]
docs: remove duplicate envvars

These envvars are also documented in the "envvars" document, which is
more prominent. Let's just drop these duplicate definitions to avoid
confusion.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: fix badly encoded envvar-roles
Erik Faye-Lund [Tue, 8 Nov 2022 09:52:17 +0000 (10:52 +0100)]
docs: fix badly encoded envvar-roles

Sphinx thinks the equals sign and the stuff that follows are parts of
the role, leading to warnings in nit-picky mode, as well as missing
links in the rendered result. Let's fix that by inserting some
whitespace.

While we're at it, fixup an incorrectly quoted literal.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: use envvar directive
Erik Faye-Lund [Tue, 8 Nov 2022 07:50:34 +0000 (08:50 +0100)]
docs: use envvar directive

When declaring an envvar, we should use the envvar directive, not the
envvar role. The latter is meant to reference the declaration, not the
other way around.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: remove stale envvar-reference
Erik Faye-Lund [Tue, 8 Nov 2022 09:37:10 +0000 (10:37 +0100)]
docs: remove stale envvar-reference

This reference was left over when the envvar was removed.

Fixes: 231ccb6100e ("docs: Remove no-longer-accurate text about the xlib driver")

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: drop custom envvar directive
Erik Faye-Lund [Tue, 8 Nov 2022 09:24:07 +0000 (10:24 +0100)]
docs: drop custom envvar directive

The custom envvar directive is strange. It overloads the global
namespace, where there's already a well-known envvar directive, but the
envvar role won't resolve to envvars defined using the custom directive.

It's not really critical to declare the type and default value here, and
many descriptions already include this. Let's just use the plain one,
and let the description take care of the details where needed.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: properly nest envvar descriptions
Erik Faye-Lund [Tue, 8 Nov 2022 09:18:02 +0000 (10:18 +0100)]
docs: properly nest envvar descriptions

These were not nested properly, making the definitions not part of the
definition lists.

Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19593>

21 months agodocs: remove rogue "the"
Erik Faye-Lund [Mon, 14 Nov 2022 10:18:40 +0000 (11:18 +0100)]
docs: remove rogue "the"

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: add missing extension-link
Erik Faye-Lund [Mon, 14 Nov 2022 10:57:50 +0000 (11:57 +0100)]
docs: add missing extension-link

Not sure why I missed this one during the last round, but it seems I
did. Let's add the link!

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: do not mention EGL_MESA_drm_display
Erik Faye-Lund [Mon, 14 Nov 2022 10:49:24 +0000 (11:49 +0100)]
docs: do not mention EGL_MESA_drm_display

This extension was removed back in 2016, but it seems we left a mention
of it in the docs.

The entire section with this extension seems kinda pointless now, so
let's drop it entirely.

Fixes: f3e23ead536 ("egl: remove remnants of MESA_drm_display")
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs/tgsi: xDArray -> xD_ARRAY
Erik Faye-Lund [Fri, 11 Nov 2022 07:58:24 +0000 (08:58 +0100)]
docs/tgsi: xDArray -> xD_ARRAY

This matches what we have in tgsi_strings.c, as well as the non-constant
part of the corresponding enum tgsi_texture_type values.

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs/gallium: move period out of quotes
Erik Faye-Lund [Tue, 8 Nov 2022 06:58:55 +0000 (07:58 +0100)]
docs/gallium: move period out of quotes

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: lifecycle -> life cycle
Erik Faye-Lund [Mon, 7 Nov 2022 20:03:01 +0000 (21:03 +0100)]
docs: lifecycle -> life cycle

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: dll -> DLL
Erik Faye-Lund [Mon, 7 Nov 2022 19:59:29 +0000 (20:59 +0100)]
docs: dll -> DLL

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: un-committed -> uncommitted
Erik Faye-Lund [Mon, 7 Nov 2022 19:53:26 +0000 (20:53 +0100)]
docs: un-committed -> uncommitted

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs: IPE -> PIPE
Erik Faye-Lund [Mon, 7 Nov 2022 19:27:41 +0000 (20:27 +0100)]
docs: IPE -> PIPE

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs/asahi: use console blocks for console commands
Erik Faye-Lund [Mon, 7 Nov 2022 19:35:31 +0000 (20:35 +0100)]
docs/asahi: use console blocks for console commands

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs/asahi: use literal-block for build-options
Erik Faye-Lund [Mon, 7 Nov 2022 19:32:52 +0000 (20:32 +0100)]
docs/asahi: use literal-block for build-options

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agodocs/asahi: fix indent
Erik Faye-Lund [Mon, 7 Nov 2022 19:31:01 +0000 (20:31 +0100)]
docs/asahi: fix indent

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19719>

21 months agoetnaviv: don't always emit PE_DEPTH_CONFIG on shader changes
Lucas Stach [Fri, 11 Nov 2022 16:29:18 +0000 (17:29 +0100)]
etnaviv: don't always emit PE_DEPTH_CONFIG on shader changes

Since b29fe26d4387 ("etnaviv: rework ZSA into a derived state") the PE
depth config is adjusted by etna_update_zsa() when the shader is changed.
When the PE depth config is actually changing as a result of this
adjustment the ZSA state is dirtied, so there is no need to emit the
state unconditionally when the shader is changed.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19686>

21 months agoetnaviv: switch to late Z when linear PE is used
Lucas Stach [Fri, 11 Nov 2022 16:20:41 +0000 (17:20 +0100)]
etnaviv: switch to late Z when linear PE is used

In linear PE mode the early and late depth stage do not only disagree
about the cache layout, but they seem to fundamentally disagree about
the buffer layout. When Z was written via the late stage, early tests
always show spurious zfails, even if they are not in the same draw
call. Cache flushing and pipe stalls don't help in that case.

The only option to get reliable Z tests with linear render targets is
to move all Z handling into the PE stage. Even when early Z writes
are possible, we don't know if any other draw to the same surface
needs late Z handling, so we must never use the early stage.

Fixes: 53445284a427 ("etnaviv: add linear PE support")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19686>

21 months agoetnaviv: fix shader register control with MSAA
Lucas Stach [Mon, 7 Nov 2022 15:12:52 +0000 (16:12 +0100)]
etnaviv: fix shader register control with MSAA

Apparently MSAA doesn't only add another input, but it also increases
required temporaries by one. Simple programs where the register demand
is given by the number of inputs did work fine, while more complex ones,
where register demand is given by the number of temporaries exhibit
rendering issues without this fix.

Cc: 22.3 mesa-stable
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19582>

21 months agogallium: Avoid nullptr-with-nonzero-offset
vabr-g [Wed, 19 Oct 2022 19:49:47 +0000 (19:49 +0000)]
gallium: Avoid nullptr-with-nonzero-offset

reserve() in rtasm_x86sse compares a pointer difference with some
integers to check if reallocation is needed.
It unfortunately groups the first pointer with an int, which makes it
possible to hit nullptr-with-nonzero-offset under Undefined Behavior
Sanitizer.
This patch suggests a reordering of the arithmetic expression so that
first the pointer difference is computed, and from that on it's just a
usual integer arithmetic, avoiding nullptr-with-nonzero-offset.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18522>

21 months agoci/update_traces_checksum.py: make output more clean and implement colors
David Heidelberg [Thu, 3 Nov 2022 16:47:26 +0000 (17:47 +0100)]
ci/update_traces_checksum.py: make output more clean and implement colors

Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19510>

21 months agoci/update_traces_checksum.py: check if checksum is in the array, not it's value
David Heidelberg [Thu, 3 Nov 2022 16:48:26 +0000 (17:48 +0100)]
ci/update_traces_checksum.py: check if checksum is in the array, not it's value

Fixes: 45eda069531a ("ci: introduce update_traces_checksum.py")

Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19510>

21 months agoac/llvm: fix gfx11 fs input load for 16bit varying
Qiang Yu [Thu, 10 Nov 2022 08:44:56 +0000 (16:44 +0800)]
ac/llvm: fix gfx11 fs input load for 16bit varying

Otherwise we get empty output.

Fixes: b07204d7804 ("radeonsi/gfx11: interp changes for 16bit")
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19637>

21 months agoac/nir/ngg: remove nuw for negative value add
Qiang Yu [Mon, 14 Nov 2022 07:28:44 +0000 (15:28 +0800)]
ac/nir/ngg: remove nuw for negative value add

Add negative value is possible to wrap around. I haven't seen this
"nuw" causes any problem yet, but let's remove it for safe.

Fixes: 60ac5dda82e ("ac: Add NIR lowering for NGG GS.")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19718>