platform/upstream/libSkiaSharp.git
10 years agoInclude SkTypes so that SK_SUPPORT_GPU is meaningful.
scroggo [Tue, 4 Nov 2014 16:11:07 +0000 (08:11 -0800)]
Include SkTypes so that SK_SUPPORT_GPU is meaningful.

For the Android framework build, we get our defines from
SkUserConfig, rather than from the makefile, so we need to
include it (via SkTypes) before we can use our defines.

Fixes Android framework build.

Review URL: https://codereview.chromium.org/700893002

10 years agoEnable distance field path rendering in Chrome.
jvanverth [Tue, 4 Nov 2014 15:59:01 +0000 (07:59 -0800)]
Enable distance field path rendering in Chrome.

- Add stat tracking for df-renderable paths
- Modify GPU rasterization veto to account for df-renderable paths
- Remove #define hiding df paths from Chromium and Android

BUG=skia:2935

Review URL: https://codereview.chromium.org/685113003

10 years agoRoll common to d7c2e2b9464.
bungeman [Tue, 4 Nov 2014 15:55:41 +0000 (07:55 -0800)]
Roll common to d7c2e2b9464.

Picks up code removal and changes to download_file.

https://skia.googlesource.com/common.git/+log/5eee100ab..d7c2e2b9464

Review URL: https://codereview.chromium.org/700763003

10 years agoremoving setVertexArraySource from drawtarget
joshualitt [Tue, 4 Nov 2014 15:47:55 +0000 (07:47 -0800)]
removing setVertexArraySource from drawtarget

BUG=skia:

Review URL: https://codereview.chromium.org/699733002

10 years agoSeparate JSON functions from DMWriteTask.
scroggo [Tue, 4 Nov 2014 15:21:10 +0000 (07:21 -0800)]
Separate JSON functions from DMWriteTask.

Add JsonWriter, which handles Json output from DM, in preparation for
adding json output for tests. This change should not affect behavior.

BUG=skia:2454

Review URL: https://codereview.chromium.org/702513003

10 years agoFix layer cache memory leak
robertphillips [Tue, 4 Nov 2014 14:46:11 +0000 (06:46 -0800)]
Fix layer cache memory leak

The issue was that, with caching disabled, the layer cache code was removing layers outside of a purge (i.e., in unlock) but not correctly cleaning up the GrPictureInfo objects (as is done in purgePlot).

Review URL: https://codereview.chromium.org/703643002

10 years agoremove dead SK_DISABLE_DASHING_OPTIMIZATION flag
reed [Tue, 4 Nov 2014 13:17:39 +0000 (05:17 -0800)]
remove dead SK_DISABLE_DASHING_OPTIMIZATION flag

BUG=skia:

Review URL: https://codereview.chromium.org/698003004

10 years agoUpdate SKP version
skia.buildbots [Tue, 4 Nov 2014 07:13:10 +0000 (23:13 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/698223002

10 years agoupdate slide content
reed [Tue, 4 Nov 2014 06:32:07 +0000 (22:32 -0800)]
update slide content

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/698563004

10 years agoadd textblobs to lua
reed [Tue, 4 Nov 2014 03:55:41 +0000 (19:55 -0800)]
add textblobs to lua

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/688363003

10 years agoupdate baselines and ignores for texture_domain
joshualitt [Tue, 4 Nov 2014 01:47:47 +0000 (17:47 -0800)]
update baselines and ignores for texture_domain

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/697233003

10 years agoTurn SkTaskGroups back on.
mtklein [Tue, 4 Nov 2014 01:41:08 +0000 (17:41 -0800)]
Turn SkTaskGroups back on.

Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."

NOTREECHECKS=true

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

Review URL: https://codereview.chromium.org/687263007

10 years agoManually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).
mtklein [Tue, 4 Nov 2014 01:25:54 +0000 (17:25 -0800)]
Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).

Tested by running DM on XP.  Before this patch, it fails at startup (even just out/Debug/dm --help).  Now it asserts for other reasons later on in user code, which is just fine by me.

The net effect is that SkTaskGroups will always be synchronous on XP.  That's not ideal, but a step up from crashing.

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot

BUG=skia:

Review URL: https://codereview.chromium.org/700683002

10 years agoExport (SK_API) SkSurfaceProps
fmalita [Tue, 4 Nov 2014 01:07:35 +0000 (17:07 -0800)]
Export (SK_API) SkSurfaceProps

R=reed@google.com

Review URL: https://codereview.chromium.org/693973003

10 years agoCleanup: Remove SimpleiOSApp xcode project file.
tfarina [Mon, 3 Nov 2014 23:10:49 +0000 (15:10 -0800)]
Cleanup: Remove SimpleiOSApp xcode project file.

There is already an GYP version for it in:
https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp

BUG=None
TEST=None
R=caryclark@google.com

Review URL: https://codereview.chromium.org/691133004

10 years agomove SkTextBox into utils
reed [Mon, 3 Nov 2014 22:55:40 +0000 (14:55 -0800)]
move SkTextBox into utils

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/696293005

10 years agoOptimize SkRect::sort()
qiankun.miao [Mon, 3 Nov 2014 22:34:30 +0000 (14:34 -0800)]
Optimize SkRect::sort()

This optimization can reduce comparison and assignments. For
geo_rect_sort benchmark, performance improved to 1.63us from 3.28us.

BUG=skia:

Review URL: https://codereview.chromium.org/695443005

10 years agoRename and clarify semantics of GrContext::resolveRenderTarget.
bsalomon [Mon, 3 Nov 2014 22:28:32 +0000 (14:28 -0800)]
Rename and clarify semantics of GrContext::resolveRenderTarget.

Review URL: https://codereview.chromium.org/696293004

10 years agoTemporary fix to remove drawrect call from GpuGL
joshualitt [Mon, 3 Nov 2014 22:16:35 +0000 (14:16 -0800)]
Temporary fix to remove drawrect call from GpuGL

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

Review URL: https://codereview.chromium.org/694933002

10 years agoImprove quality of distance field rendering
jvanverth [Mon, 3 Nov 2014 22:00:24 +0000 (14:00 -0800)]
Improve quality of distance field rendering
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs

BUG=skia:2933,skia:2935

Review URL: https://codereview.chromium.org/703463002

10 years agoDetect Mesa OpenGL ES
derekf [Mon, 3 Nov 2014 21:36:40 +0000 (13:36 -0800)]
Detect Mesa OpenGL ES

Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/700633002

10 years agoRevert changes to GrContext::resolveRenderTarget
bsalomon [Mon, 3 Nov 2014 21:32:00 +0000 (13:32 -0800)]
Revert changes to GrContext::resolveRenderTarget

TBR=joshualitt@google.com,egdaniel@google.com

Review URL: https://codereview.chromium.org/700483003

10 years agoAdd comments to SkRecordDraw to help people follow.
danakj [Mon, 3 Nov 2014 20:43:30 +0000 (12:43 -0800)]
Add comments to SkRecordDraw to help people follow.

The calls to visit() to execute the SkRecord::Draw::operator() code path
is not clear to read, so adding some comments to help other new-comers
follow this through to the SkCanvas calls.

R=mtklein@chromium.org

Review URL: https://codereview.chromium.org/695403003

10 years agoTest factory uses the inorder draw buffer
joshualitt [Mon, 3 Nov 2014 20:31:14 +0000 (12:31 -0800)]
Test factory uses the inorder draw buffer

BUG=skia:

Review URL: https://codereview.chromium.org/696353002

10 years agoadd bullets to slides
reed [Mon, 3 Nov 2014 20:18:24 +0000 (12:18 -0800)]
add bullets to slides

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/699723002

10 years agoDon't allow renderTarget==NULL to GrContext::clear() and friends.
bsalomon [Mon, 3 Nov 2014 20:08:42 +0000 (12:08 -0800)]
Don't allow renderTarget==NULL to GrContext::clear() and friends.

Review URL: https://codereview.chromium.org/680413005

10 years agorebase and ignore dash cubics winnvpr
joshualitt [Mon, 3 Nov 2014 20:03:06 +0000 (12:03 -0800)]
rebase and ignore dash cubics winnvpr

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691803005

10 years agorelease expectations rebase
joshualitt [Mon, 3 Nov 2014 19:36:40 +0000 (11:36 -0800)]
release expectations rebase
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/700613002

10 years agorebase nvpr expectations
joshualitt [Mon, 3 Nov 2014 19:14:25 +0000 (11:14 -0800)]
rebase nvpr expectations

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/688413004

10 years agoRemove GrGLTexID
bsalomon [Mon, 3 Nov 2014 19:07:12 +0000 (11:07 -0800)]
Remove GrGLTexID

BUG=skia:2889

Review URL: https://codereview.chromium.org/695133003

10 years agoignoring degenerat segments across all nvprm
joshualitt [Mon, 3 Nov 2014 18:51:42 +0000 (10:51 -0800)]
ignoring degenerat segments across all nvprm
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/696373002

10 years agopatch from issue 697743002
mtklein [Mon, 3 Nov 2014 18:45:50 +0000 (10:45 -0800)]
patch from issue 697743002
working

The key here was to get everything into a single library.  Our shared library build is the easiest way to do that.  Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too.

BUG=skia:

Review URL: https://codereview.chromium.org/698943002

10 years agoForce input coverage to be only a byte in gpu shaders.
egdaniel [Mon, 3 Nov 2014 18:07:07 +0000 (10:07 -0800)]
Force input coverage to be only a byte in gpu shaders.

Prime coverage invariant output calculations with single component

BUG=skia:

Review URL: https://codereview.chromium.org/649783003

10 years agoAdd class GrGLTextureRenderTarget for GL texture/rendertarget objects
bsalomon [Mon, 3 Nov 2014 16:47:23 +0000 (08:47 -0800)]
Add class GrGLTextureRenderTarget for GL texture/rendertarget objects

BUG=skia:2889

Review URL: https://codereview.chromium.org/695813003

10 years agoCleanup: Remove svn.py script.
tfarina [Mon, 3 Nov 2014 16:33:53 +0000 (08:33 -0800)]
Cleanup: Remove svn.py script.

We have moved on to a git world.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/691203002

10 years agoCleanup: Remove unnecessary forward declarations from some views files.
tfarina [Mon, 3 Nov 2014 16:31:23 +0000 (08:31 -0800)]
Cleanup: Remove unnecessary forward declarations from some views files.

Cautch in
https://skia.googlesource.com/skia/+/a3a706fcd4cc9376a1223a53f57589f29d4a36ea

BUG=None
TEST=None
R=djsollen@google.com

Review URL: https://codereview.chromium.org/680253004

10 years agoRebaselines for new colortype-xfermodes gm
egdaniel [Mon, 3 Nov 2014 16:26:28 +0000 (08:26 -0800)]
Rebaselines for new colortype-xfermodes gm

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/695343002

10 years agoShrink saveLayer device bounds when it supplies an explicit bounds and has a complex...
robertphillips [Mon, 3 Nov 2014 16:19:44 +0000 (08:19 -0800)]
Shrink saveLayer device bounds when it supplies an explicit bounds and has a complex paint

This CL shrinks the bound computed for saveLayers that possess both an explicit
bound and a complex paint (e.g., one that affects transparent black). In this
case the bound of the layer should be the clipped explicit bound rather then
the clip prior/after the saveLayer/restore block.

In the following the first bound is the currently computed bound
while the second is the new/desired one:

For a 100x100 picture

saveLayer (no bound, no paint) [ 0 0 100 100 ]  [ 50 50 100 100 ]
  setMatrix (translate 50, 50) [ 0 0 100 100 ] [ 50 50 100 100 ]
  saveLayer (bound of 0, 0, 50, 50 - complex paint) [ 0 0 100 100 ] [ 50 50 100 100 ]
  restore [ 0 0 100 100 ] [ 50 50 100 100 ]
restore [ 0 0 100 100 ] [ 50 50 100 100 ]

Review URL: https://codereview.chromium.org/696763002

10 years agoAlways enable layer hoisting in Skia
robertphillips [Mon, 3 Nov 2014 15:19:30 +0000 (07:19 -0800)]
Always enable layer hoisting in Skia

This will prevent bit rot of the layer hoisting code and position us better for turning this on in Chromium.

Review URL: https://codereview.chromium.org/698493002

10 years agoUpdate SKP version
skia.buildbots [Mon, 3 Nov 2014 06:41:23 +0000 (22:41 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/692313007

10 years agoadd code-style for slides
reed [Mon, 3 Nov 2014 03:19:34 +0000 (19:19 -0800)]
add code-style for slides

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/697923002

10 years agoUpdate SKP version
skia.buildbots [Sun, 2 Nov 2014 05:32:12 +0000 (22:32 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/697003003

10 years agoUpdate SKP version
skia.buildbots [Sat, 1 Nov 2014 06:17:24 +0000 (23:17 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/696103002

10 years agoRevert of Temporary fix to remove drawrect call from GpuGL (patchset #6 id:90005...
joshualitt [Fri, 31 Oct 2014 23:32:22 +0000 (16:32 -0700)]
Revert of Temporary fix to remove drawrect call from GpuGL (patchset #6 id:90005 of https://codereview.chromium.org/694933002/)

Reason for revert:
patch breaks angle bots and K1

Original issue's description:
> Temporary fix to remove drawrect call from GpuGL
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693223002

10 years agorebaseline
joshualitt [Fri, 31 Oct 2014 23:16:56 +0000 (16:16 -0700)]
rebaseline
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/696853002

10 years agoTemporary fix to remove drawrect call from GpuGL
joshualitt [Fri, 31 Oct 2014 22:49:46 +0000 (15:49 -0700)]
Temporary fix to remove drawrect call from GpuGL

BUG=skia:

Review URL: https://codereview.chromium.org/694933002

10 years agoGrContext no longer ever draws on Gpu
joshualitt [Fri, 31 Oct 2014 21:04:35 +0000 (14:04 -0700)]
GrContext no longer ever draws on Gpu

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0

Review URL: https://codereview.chromium.org/683733005

10 years agoBeginning to refactor nvpr code
joshualitt [Fri, 31 Oct 2014 20:56:50 +0000 (13:56 -0700)]
Beginning to refactor nvpr code

BUG=skia:

Review URL: https://codereview.chromium.org/687563008

10 years agoSome distance field text optimizations.
jvanverth [Fri, 31 Oct 2014 19:59:57 +0000 (12:59 -0700)]
Some distance field text optimizations.

- Add clipRect check
- Remove creation of scalerContext to check for color fonts in canDraw()
   (no longer needed)

BUG=skia:2933

Review URL: https://codereview.chromium.org/696503004

10 years agoRevert of GrContext no longer ever draws on Gpu (patchset #7 id:120001 of https:...
joshualitt [Fri, 31 Oct 2014 19:20:08 +0000 (12:20 -0700)]
Revert of GrContext no longer ever draws on Gpu (patchset #7 id:120001 of https://codereview.chromium.org/683733005/)

Reason for revert:
breaks some android bots

Original issue's description:
> GrContext no longer ever draws on Gpu
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/694983002

10 years agoGrContext no longer ever draws on Gpu
joshualitt [Fri, 31 Oct 2014 18:34:53 +0000 (11:34 -0700)]
GrContext no longer ever draws on Gpu

BUG=skia:

Review URL: https://codereview.chromium.org/683733005

10 years agoRevert of Turn SkTaskGroups back on. (patchset #1 id:1 of https://codereview.chromium...
mtklein [Fri, 31 Oct 2014 18:30:22 +0000 (11:30 -0700)]
Revert of Turn SkTaskGroups back on. (patchset #1 id:1 of https://codereview.chromium.org/687263007/)

Reason for revert:
precautionary revert.  may have caused WinXP crashes on Chrome tree: https://code.google.com/p/chromium/issues/detail?id=429207

Original issue's description:
> Turn SkTaskGroups back on.
>
> Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
> Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693993002

10 years agosmall fix for cache clear
joshualitt [Fri, 31 Oct 2014 15:27:39 +0000 (08:27 -0700)]
small fix for cache clear

BUG=skia:

Review URL: https://codereview.chromium.org/695873002

10 years agoSK_USE_SCALED_FONTMETRICS for correct scaling
reed [Fri, 31 Oct 2014 15:20:46 +0000 (08:20 -0700)]
SK_USE_SCALED_FONTMETRICS for correct scaling

related blink change:
https://codereview.chromium.org/691133002

Review URL: https://codereview.chromium.org/692083002

10 years agoRebaseline GMs for https://codereview.chromium.org/687283002/
jvanverth [Fri, 31 Oct 2014 14:16:54 +0000 (07:16 -0700)]
Rebaseline GMs for https://codereview.chromium.org/687283002/

BUG=skia:2935

Review URL: https://codereview.chromium.org/684833003

10 years agoObjects should be unrefed instead of deleted
sugoi [Fri, 31 Oct 2014 14:16:16 +0000 (07:16 -0700)]
Objects should be unrefed instead of deleted

When an error occurs reading a flattenable object, it should be unrefed instead of deleted because, in the case of SkXferMode, for example, we'd actually be deleting a cached object kept in a static array.

BUG=428789

Review URL: https://codereview.chromium.org/695633003

10 years agoQuick and dirty test to call the C interface from GO.
stephana [Fri, 31 Oct 2014 14:11:19 +0000 (07:11 -0700)]
Quick and dirty test to call the C interface from GO.

BUG=skia:

Review URL: https://codereview.chromium.org/670303005

10 years agoCleanup: Go with SkDebugf instead of GrPrintf.
tfarina [Fri, 31 Oct 2014 14:11:12 +0000 (07:11 -0700)]
Cleanup: Go with SkDebugf instead of GrPrintf.

Since GrPrintf is just defined to SkDebugf, we can go with the later
directly.

BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/695663003

10 years agoUpdate SKP version
skia.buildbots [Fri, 31 Oct 2014 14:06:08 +0000 (07:06 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/689833006

10 years agoCleanup: Remove GR_ARRAY_COUNT macro.
tfarina [Fri, 31 Oct 2014 14:06:00 +0000 (07:06 -0700)]
Cleanup: Remove GR_ARRAY_COUNT macro.

It is defined to SK_ARRAY_COUNT, and there are no uses of it.

Lets just use the SK_ variant.

BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/691133003

10 years agoAdd support for clang to the android build scripts
djsollen [Fri, 31 Oct 2014 14:00:59 +0000 (07:00 -0700)]
Add support for clang to the android build scripts

Review URL: https://codereview.chromium.org/692953002

10 years agoRemove adb from Skia repository
djsollen [Fri, 31 Oct 2014 14:00:54 +0000 (07:00 -0700)]
Remove adb from Skia repository

Review URL: https://codereview.chromium.org/696463003

10 years agoUse Color Processor for color bitmap text draws on gpu.
egdaniel [Fri, 31 Oct 2014 13:55:45 +0000 (06:55 -0700)]
Use Color Processor for color bitmap text draws on gpu.

This change is here since previously color bitmap text was rendered using a
geometry processor in the coverage stage. The problem with this is that we
cannot correctly do xfer modes with this method. So I now make color bitmap text
draw using a color stage in the same was as a draw bitmap call.

One issue that arrises from this fix is that we end up adding this final color
processor after any previous color processors. Thus if we have a custom blend
implemented as a color processor it will be before this text one and we won't
blend correctly. This issue will get fixed once an xfer processor is fully
implemented. I have hacked a test locally to show that if we can add the text
color processor to the begining of the color stages we do blend correctly in all
cases (so the xfer processor will be a fix).

BUG=skia:

Review URL: https://codereview.chromium.org/689923004

10 years agobegin clean up for scalar is double option
reed [Fri, 31 Oct 2014 13:55:41 +0000 (06:55 -0700)]
begin clean up for scalar is double option

BUG=skia:

Review URL: https://codereview.chromium.org/694693002

10 years agoTurn SkTaskGroups back on.
mtklein [Fri, 31 Oct 2014 13:38:24 +0000 (06:38 -0700)]
Turn SkTaskGroups back on.

Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/687263007

10 years agoUpgrade GPUOptimize
robertphillips [Thu, 30 Oct 2014 23:45:02 +0000 (16:45 -0700)]
Upgrade GPUOptimize

This will be a bit hairy to review.

The FillBounds and CollectLayers code has diverged significantly resulting in the rendering path seeing different bounds than the hoisting path. This CL merges the FillBounds changes into CollectLayers. A follow on CL will, hopefully, find a way to layer CollectLayers on top of FillBounds.

The only code in CollectLayers that is different from FillBounds is bracketed by "LAYER HOISTING" comments.

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/685263004

10 years agoTrying to be consistent when members are allowed to be NULL
sugoi [Thu, 30 Oct 2014 21:05:14 +0000 (14:05 -0700)]
Trying to be consistent when members are allowed to be NULL

Got a few crashes running the fuzzer locally, all related to handling NULL members/parameters in an inconsistent way.

BUG=skia:

Review URL: https://codereview.chromium.org/675013003

10 years agoUpdate the Android NDK to r10c
djsollen [Thu, 30 Oct 2014 20:27:26 +0000 (13:27 -0700)]
Update the Android NDK to r10c

Review URL: https://codereview.chromium.org/689943002

10 years agoBlind GM rebaseline for Galaxy S4
borenet [Thu, 30 Oct 2014 20:27:20 +0000 (13:27 -0700)]
Blind GM rebaseline for Galaxy S4

BUG=skia:3032

Review URL: https://codereview.chromium.org/694573002

10 years agoCleanup conversion that the new NDK compiler tries to over optimize.
djsollen [Thu, 30 Oct 2014 18:54:43 +0000 (11:54 -0700)]
Cleanup conversion that the new NDK compiler tries to over optimize.

This allows us to upgrade to NDK r10c as the dftext gm no longer fails
when compiled with -O2.

Review URL: https://codereview.chromium.org/690053002

10 years agoAdd return value on GrRecordReplaceDraw
robertphillips [Thu, 30 Oct 2014 18:54:31 +0000 (11:54 -0700)]
Add return value on GrRecordReplaceDraw

This assists debugging layer hoisting errors (e.g., when a layer is hoisted but not actually used in subsequent rendering).

Review URL: https://codereview.chromium.org/694533004

10 years agoFix member variable naming
robertphillips [Thu, 30 Oct 2014 18:49:37 +0000 (11:49 -0700)]
Fix member variable naming

This renaming was missed in (MultiPictureDraw is taskgroup aware - https://codereview.chromium.org/684923002)

TBR=reed@google.com

Review URL: https://codereview.chromium.org/654293005

10 years agoCombine nameFontStyleProc and FindByNameStyle.
bungeman [Thu, 30 Oct 2014 18:49:27 +0000 (11:49 -0700)]
Combine nameFontStyleProc and FindByNameStyle.

These two functions do the same thing, combine them.

Review URL: https://codereview.chromium.org/688133003

10 years agoAdd skimage expectations for GalaxyS4.
scroggo [Thu, 30 Oct 2014 18:44:27 +0000 (11:44 -0700)]
Add skimage expectations for GalaxyS4.

Fixes build.

Review URL: https://codereview.chromium.org/692913003

10 years agoMake RTree handle the case where the playback canvas has empty clip bounds
junov [Thu, 30 Oct 2014 18:44:19 +0000 (11:44 -0700)]
Make RTree handle the case where the playback canvas has empty clip bounds

BUG=skia:3074

Review URL: https://codereview.chromium.org/678303004

10 years agoFix bug in aggressive layer cache purging
robertphillips [Thu, 30 Oct 2014 18:39:19 +0000 (11:39 -0700)]
Fix bug in aggressive layer cache purging

A picture may possess many layers that get placed in one plot of the atlas. In this case we can only remove the plot from the plotUsage tracking structure when all the layers belonging to the picture in that plot have been removed.

Review URL: https://codereview.chromium.org/654463004

10 years agoCleanup android to ensure it can compile with clang
djsollen [Thu, 30 Oct 2014 18:39:13 +0000 (11:39 -0700)]
Cleanup android to ensure it can compile with clang

Review URL: https://codereview.chromium.org/694533002

10 years agoallow SkUserConfig.h to control NOGPU
reed [Thu, 30 Oct 2014 18:34:15 +0000 (11:34 -0700)]
allow SkUserConfig.h to control NOGPU

BUG=skia:

Review URL: https://codereview.chromium.org/685243002

10 years agoUpdate SKP version
skia.buildbots [Thu, 30 Oct 2014 18:34:04 +0000 (11:34 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/688793003

10 years agotell our grcontext to abandon its backend
reed [Thu, 30 Oct 2014 18:29:08 +0000 (11:29 -0700)]
tell our grcontext to abandon its backend

BUG=skia:

Review URL: https://codereview.chromium.org/692803003

10 years agoAdd SkDocument::getStream() method.
halcanary [Thu, 30 Oct 2014 18:29:00 +0000 (11:29 -0700)]
Add SkDocument::getStream() method.

Motivation: SkDocument_PDF can be refactored to stream all
PDF objects as SkCanvas calls are made, to save memory!

BUG=skia:3030
BUG=skia:2683

Review URL: https://codereview.chromium.org/691783002

10 years agoRevert of scale xmin and xmax for FontMetrics (patchset #1 id:1 of https://codereview...
robertphillips [Thu, 30 Oct 2014 16:59:43 +0000 (09:59 -0700)]
Revert of scale xmin and xmax for FontMetrics (patchset #1 id:1 of https://codereview.chromium.org/685153004/)

Reason for revert:
Experimental revert to see if this is blocking the DEPS roll

Original issue's description:
> scale xmin and xmax for FontMetrics
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/79c276e4fd93d9c9fd57a45bc6929c48e4415b2f

TBR=mtklein@google.com,bungeman@google.com,reed@google.com,reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/691033002

10 years agoRevert harder, removing SkTaskGroup.cpp from core temporarily.
mtklein [Thu, 30 Oct 2014 15:19:19 +0000 (08:19 -0700)]
Revert harder, removing SkTaskGroup.cpp from core temporarily.

Not all linkers are seeing the SkThread code is not needed.

BUG=skia:
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/673903007

10 years agoDisable SkTaskGroup in SkMultiPictureDraw temporarily.
mtklein [Thu, 30 Oct 2014 14:19:11 +0000 (07:19 -0700)]
Disable SkTaskGroup in SkMultiPictureDraw temporarily.

Think this should be enough to get rolling again.

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/687273006

10 years agoUse the most recent version of ADB from the SDK if necessary.
djsollen [Thu, 30 Oct 2014 12:57:31 +0000 (05:57 -0700)]
Use the most recent version of ADB from the SDK if necessary.

This removes ADB from the Skia checkout and also does some quick
checks to make sure the version of ADB used meets a minimum threshold

Review URL: https://codereview.chromium.org/692513003

10 years agoSupport multiple scales for dfpaths.
jvanverth [Thu, 30 Oct 2014 12:57:21 +0000 (05:57 -0700)]
Support multiple scales for dfpaths.

Adds miplevel as part of dfpath key, and scale factor so we know
how much to adjust to fit desired scale.

BUG=skia:2935

Review URL: https://codereview.chromium.org/687283002

10 years agoIncrease wait time for spreadsheetdashed pageset
rmistry [Thu, 30 Oct 2014 12:52:25 +0000 (05:52 -0700)]
Increase wait time for spreadsheetdashed pageset

BUG=skia:3049
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/692843002

10 years agoWhitespace change to see how the Android bots behave
borenet [Thu, 30 Oct 2014 12:52:16 +0000 (05:52 -0700)]
Whitespace change to see how the Android bots behave

NOTRY=true
TBR=rmistry
NOTREECHECKS=true
BUG=skia:

Review URL: https://codereview.chromium.org/693483003

10 years agoIncrease timeout of blogger pageset and re-enable weather pageset
Ravi Mistry [Thu, 30 Oct 2014 11:37:07 +0000 (07:37 -0400)]
Increase timeout of blogger pageset and re-enable weather pageset

BUG=skia:3049

10 years agobreak transitions into separate file
reed [Thu, 30 Oct 2014 03:36:05 +0000 (20:36 -0700)]
break transitions into separate file

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/692543004

10 years agocleanup reentrance logic in CMM
joshualitt [Thu, 30 Oct 2014 01:29:27 +0000 (18:29 -0700)]
cleanup reentrance logic in CMM

BUG=skia:

Review URL: https://codereview.chromium.org/684223002

10 years agoUpdate SKP version
skia.buildbots [Wed, 29 Oct 2014 23:51:53 +0000 (16:51 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/665233005

10 years agoRevert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #5...
mtklein [Wed, 29 Oct 2014 23:07:10 +0000 (16:07 -0700)]
Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #5 id:80001 of https://codereview.chromium.org/680363003/)

Reason for revert:
Mac mini asserting

Original issue's description:
> Use SkTypeface::getBounds() in bounding-box calculations.
>
> This should produce tighter conservative bounding boxes for text than the
> approximation code it replaces.
>
> Recording performance is neutral on my desktop.  Playback performance
> improves by up to 15% on text heavy pages, e.g.
>
>   desk_pokemonwiki.skp_1 3.24ms -> 2.83ms  0.87x
>         desk_baidu.skp_1 1.91ms -> 1.58ms  0.83x
>
> Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/c51add674dfb89b988a7fbc05f41838c203f9dcd

TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/690833002

10 years agouse SkTaskGroup::batch
reed [Wed, 29 Oct 2014 22:44:25 +0000 (15:44 -0700)]
use SkTaskGroup::batch

BUG=skia:

Review URL: https://codereview.chromium.org/688753002

10 years agoUse SkTypeface::getBounds() in bounding-box calculations.
mtklein [Wed, 29 Oct 2014 22:36:38 +0000 (15:36 -0700)]
Use SkTypeface::getBounds() in bounding-box calculations.

This should produce tighter conservative bounding boxes for text than the
approximation code it replaces.

Recording performance is neutral on my desktop.  Playback performance
improves by up to 15% on text heavy pages, e.g.

  desk_pokemonwiki.skp_1 3.24ms -> 2.83ms  0.87x
        desk_baidu.skp_1 1.91ms -> 1.58ms  0.83x

Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot

Review URL: https://codereview.chromium.org/680363003

10 years agoIncrease timeouts of wowwiki and youtube
Ravi Mistry [Wed, 29 Oct 2014 21:39:15 +0000 (17:39 -0400)]
Increase timeouts of wowwiki and youtube

10 years agoSkTaskGroup::batch(fn, args, N)
mtklein [Wed, 29 Oct 2014 21:17:13 +0000 (14:17 -0700)]
SkTaskGroup::batch(fn, args, N)

Porting QuiltTask isn't important in itself; this is mostly an API feeler.

BUG=skia:

Review URL: https://codereview.chromium.org/689673003

10 years agoTry out SkTree in nanobench.
mtklein [Wed, 29 Oct 2014 21:15:10 +0000 (14:15 -0700)]
Try out SkTree in nanobench.

Looks like a fairly large recording speed win with no playback cost.

BUG=skia:

Review URL: https://codereview.chromium.org/653023003

10 years agoMoving weather pageset since it is crashing
Ravi Mistry [Wed, 29 Oct 2014 21:03:22 +0000 (17:03 -0400)]
Moving weather pageset since it is crashing

10 years agoDiscard atlas after every MultiPictureDraw::draw
robertphillips [Wed, 29 Oct 2014 20:56:02 +0000 (13:56 -0700)]
Discard atlas after every MultiPictureDraw::draw

This is intended to prevent ghosting on tiled architectures.

This CL also defers creation of the atlas (and its texture) until it is actually needed.

Committed: https://skia.googlesource.com/skia/+/6d5b5455743414ddb11d2b8c1fe9d7959f2b853d

Review URL: https://codereview.chromium.org/678403002