Mike Blumenkrantz [Mon, 21 Oct 2019 19:52:17 +0000 (15:52 -0400)]
tests/genlist: fix tree test sizing
for some reason I used 10px as the base height of a genlist item when clearly
they are more like 30px
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10513
Mike Blumenkrantz [Thu, 24 Oct 2019 15:37:32 +0000 (11:37 -0400)]
tests/elm: add utility function to trigger a mouse drag
a drag may require a lot of internal calculating to successfully trigger
the intended test behavior, so this has a flag which allows it to perform
loop iterations and canvas calcs in order to be more universal, along with
a global #define for determining exactly how many mouse moves were triggered
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10512
Mike Blumenkrantz [Mon, 21 Oct 2019 19:51:28 +0000 (15:51 -0400)]
tests/elm: make argv a static char so it never goes out of scope and crashes
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10511
Mike Blumenkrantz [Mon, 21 Oct 2019 14:34:57 +0000 (10:34 -0400)]
tests/elm: add util functions for clicking objects/parts with event flags
this is useful for synthesizing e.g., double click events
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10510
Mike Blumenkrantz [Mon, 21 Oct 2019 14:30:45 +0000 (10:30 -0400)]
tests/elm: add util callback for incrementing an int data
this is a common functionality
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10509
Woochanlee [Tue, 29 Oct 2019 13:47:48 +0000 (09:47 -0400)]
efl_ui_win: Delete useless geometry set for legacy.edje
Summary:
It will be resized on window_resize_job. when the window got specific size.
I don't think this is needed here. It cause doing a calc in vain.
Test Plan: Launching Test applications.
Reviewers: raster, Hermet, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10550
Woochanlee [Tue, 29 Oct 2019 13:37:56 +0000 (09:37 -0400)]
edje_calc: Delete duplicated conditional statement.
Summary: this is identical to the conditional above and can be merged
to improve code clarity
Reviewers: raster, Hermet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10549
Xavi Artigas [Tue, 29 Oct 2019 13:56:01 +0000 (14:56 +0100)]
Replace tabs with spaces
As our coding conventions mandate.
JunsuChoi [Tue, 29 Oct 2019 04:17:05 +0000 (13:17 +0900)]
vg_common_svg: Free node tree for memory leak after eet write.
Summary:
The node tree created from vg_common_svg_create_svg_node is not used after eet_data_write().
Therefore, to prevent memory leaks, free the node tree.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10443
Lauro Moura [Mon, 28 Oct 2019 23:35:39 +0000 (20:35 -0300)]
eolian_cxx: Add key/value to function_def
Summary:
This commit adds explicit eolian key/value/return info to function_def. The
original parameter/return types are kept for compatibility.
parameter/return -> Mimics the behavior of the generated C API (i.e.
single-valued getters have their lone value translated to be their
return type)
explicit_return -> The actual return value for that block in the EO
file.
keys/values -> The values for respectively key and values blocks.
This should help working with properties in the generators instead of
fumbling with paremeter/return directly
Fixes T8431
Test Plan: extra tests in the diff
Reviewers: felipealmeida, brunobelo, segfaultxavi, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Maniphest Tasks: T8431
Differential Revision: https://phab.enlightenment.org/D10494
Bruno da Silva Belo [Mon, 28 Oct 2019 23:34:55 +0000 (20:34 -0300)]
csharp: Add comparables operator to eina_error.
Summary: ref T8394
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8394
Differential Revision: https://phab.enlightenment.org/D10456
Bruno da Silva Belo [Mon, 28 Oct 2019 23:34:25 +0000 (20:34 -0300)]
csharp: Add comparables operators to eina_value.
Summary: ref T8394
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho, bu5hm4n
Reviewed By: YOhoho
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8394
Differential Revision: https://phab.enlightenment.org/D10458
Yeongjong Lee [Mon, 28 Oct 2019 23:33:47 +0000 (20:33 -0300)]
eina_mono: remove exceptions in unexpected locations
Summary:
Unexpected locations are listed in
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1065
fix CA1065
ref T8402
Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test
Reviewers: lauromoura, felipealmeida, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8402
Differential Revision: https://phab.enlightenment.org/D10461
Lauro Moura [Mon, 28 Oct 2019 22:06:38 +0000 (19:06 -0300)]
mono: encapsulate internal NativeModule
Summary:
Depends on D10342
Depends on D10338
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10343
Lauro Moura [Mon, 28 Oct 2019 22:04:33 +0000 (19:04 -0300)]
mono: encapsulate internal FunctionWrapper
Summary: Depends on D10340
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10342
Lauro Moura [Mon, 28 Oct 2019 21:48:26 +0000 (18:48 -0300)]
mono: encapsulate internal nativemethods
Summary: Depends on D10337
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10340
Yeongjong Lee [Mon, 28 Oct 2019 21:24:15 +0000 (18:24 -0300)]
mono: encapsulate internal Add/RemoveNativeEventHandler
Summary: Depends on D10337
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10341
Yeongjong Lee [Mon, 28 Oct 2019 21:08:01 +0000 (18:08 -0300)]
mono: encapsulate internal CustomMarshaler
Summary: Depends on D10337
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10344
Yeongjong Lee [Mon, 28 Oct 2019 20:10:48 +0000 (17:10 -0300)]
mono: introduce friend assembly
Summary:
Friend assemblies can access efl_mono assembly's internal types and members.
If `build-tests` option is true, `efl-mono-suite.exe` and `efl_mono_test.dll`
will become friend assemblies.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: felipealmeida, cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10337
Xavi Artigas [Mon, 28 Oct 2019 18:32:23 +0000 (19:32 +0100)]
docs: Polished docs for Efl.Ui.Scrollable
Xavi Artigas [Mon, 28 Oct 2019 17:46:13 +0000 (18:46 +0100)]
docs: Formatting and polishing Efl.Ui.Factory docs
Marcel Hollerbach [Mon, 28 Oct 2019 16:40:27 +0000 (12:40 -0400)]
spec-suite: verify correct widget-hiding behaviour.
Summary:
These checks are ensuring that when we are hiding a widget, that
everything inside these widgets are also hidden correctly. Due to
clipper or due to visibility flag.
Depends on D10468
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10474
Marcel Hollerbach [Mon, 28 Oct 2019 16:40:17 +0000 (12:40 -0400)]
efl_ui_spotlight_manager: apply vis changes to subobj
Summary:
when the sportlight is hidden, the state should be applied to the
backclip and foreclip, in order to hide the subobjects correctly.
This fixes dangling showing widgets.
Reviewers: Jaehyun_Cho, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10468
Xavi Artigas [Mon, 28 Oct 2019 15:05:08 +0000 (16:05 +0100)]
docs: Improve documentation on cache-related classes
Also, code comments and typos.
Bruno da Silva Belo [Mon, 28 Oct 2019 14:43:56 +0000 (11:43 -0300)]
csharp: Add missing exception ctor from Errors.cs.
Summary: ref T8392
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8392
Differential Revision: https://phab.enlightenment.org/D10455
Bruno da Silva Belo [Mon, 28 Oct 2019 14:59:52 +0000 (11:59 -0300)]
csharp: Add missing exception ctr from iwrapper.
Summary: ref T8392
Reviewers: felipealmeida, lauromoura, segfaultxavi, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8392
Differential Revision: https://phab.enlightenment.org/D10454
Xavi Artigas [Mon, 28 Oct 2019 14:12:35 +0000 (15:12 +0100)]
Silence mono warning in tests
../src/tests/efl_mono/Model.cs(35,13): warning CS0219: The variable `veggies' is assigned but its value is never used
This was driving me nuts... Am I the only one seeing these things?
thierry1970 [Mon, 28 Oct 2019 13:07:12 +0000 (09:07 -0400)]
efreet : Check that the file has a protocol in efreet_desktop_command_file_process()
if a path has a '/' character in it before the ':' character then it
should be treated as a local file which contains a ':' character in
its name
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10409
Xavi Artigas [Mon, 28 Oct 2019 08:40:33 +0000 (09:40 +0100)]
Typo in comment
Yeongjong Lee [Fri, 25 Oct 2019 22:14:58 +0000 (19:14 -0300)]
eina_array: add paramName argument of ArgumentNullException
Summary:
ArgumentNullException constructor included `message` is
`public ArgumentNullException (string paramName, string message);`
Fix CA2208
ref T8428
Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test
Reviewers: lauromoura, felipealmeida, brunobelo
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8428
Differential Revision: https://phab.enlightenment.org/D10464
Xavi Artigas [Fri, 25 Oct 2019 21:00:31 +0000 (18:00 -0300)]
Efl.Ui.Text: Fix Text Cursor composition
Summary:
This is a temporary fix while Text is being revamped.
Efl.Ui.Text internally composites Efl.Text_Cursor (through some other interfaces)
but this was not being advertised in the EO file.
This caused no trouble to C but was preventing C# from using the Cursors API
(because C# relies on the EO composites section).
On top of this, the cursor_new() method has been removed, since it was redundant.
Test Plan:
Builds and passes tests, and C# is able to do things like:
```
Efl.TextCursorCursor cursor = screen.GetTextCursor(Efl.TextCursorGetType.Main);
screen.InsertCursorText(cursor, str);
```
Reviewers: lauromoura, cedric, tasn
Reviewed By: lauromoura
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10465
Bruno da Silva Belo [Fri, 25 Oct 2019 18:02:54 +0000 (15:02 -0300)]
csharp:Changing ex access modifier from Errors.cs.
Summary: ref T8401
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8401
Differential Revision: https://phab.enlightenment.org/D10502
Cedric BAIL [Fri, 25 Oct 2019 19:45:14 +0000 (15:45 -0400)]
evas: disable Eina Cow Garbage Collection on dynamic content.
Summary:
Dynamic content are likely to trigger an image state change at pretty
much every frame. This lead to unecessary attempt by Eina_Cow to
deduplicate/cleanup data that are changing all the time. This reduce
memory consumption in Expedite tests that in some small amount. The
gain get bigger the more animation you get on screen. There might be
other potential gain for heavy animated case.
Reviewers: zmike, Hermet, bu5hm4n, smohanty
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8302
Differential Revision: https://phab.enlightenment.org/D10532
Marcel Hollerbach [Fri, 25 Oct 2019 18:05:00 +0000 (14:05 -0400)]
elm_interface_scrollable: correctly honor looping over
Summary:
when looping is enabled, we need to ensure that the correct arrows are
enabled.
ref D9906
Depends on D9908
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9917
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:54 +0000 (14:04 -0400)]
elm_interface_scrollable: correctly emit the signals always
Summary:
our default theme defaults to show everything, the code here assumes
that everything is hidden by default, this fixes all this.
fix T4918
Depends on D9907
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T4918
Differential Revision: https://phab.enlightenment.org/D9908
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:46 +0000 (14:04 -0400)]
elm_interface_scrollable: correctly handle bouncing
Summary:
if bounding is enabled, those values can get smaller and bigger than the
max value.
ref T4918
Depends on D9906
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T4918
Differential Revision: https://phab.enlightenment.org/D9907
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:39 +0000 (14:04 -0400)]
theme: redo scroller theme of elm
Summary:
this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).
With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.
ref T4918
Reviewers: zmike, eagleeye, woohyun
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T4918
Differential Revision: https://phab.enlightenment.org/D9906
Mike Blumenkrantz [Fri, 25 Oct 2019 17:33:41 +0000 (13:33 -0400)]
ci: use shell to directly set base_dir for osx builds
Summary: this crashes somehow and is impossible to debug remotely
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10529
Bruno da Silva Belo [Fri, 25 Oct 2019 16:49:24 +0000 (13:49 -0300)]
csharp: Using Array.Empty Eina.
Summary: ref T8421
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8421
Differential Revision: https://phab.enlightenment.org/D10500
Bruno da Silva Belo [Fri, 25 Oct 2019 16:57:48 +0000 (13:57 -0300)]
csharp:Using Array.Empty genericmodel.
Summary: ref T8421
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8421
Differential Revision: https://phab.enlightenment.org/D10501
Bruno da Silva Belo [Fri, 25 Oct 2019 16:08:37 +0000 (13:08 -0300)]
csharp: Changing Count() to Length on eina_value.
Summary: ref T8422
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8422
Differential Revision: https://phab.enlightenment.org/D10499
Bruno da Silva Belo [Fri, 25 Oct 2019 16:06:59 +0000 (13:06 -0300)]
csharp: Using Count eina_promises.
Summary: ref T8422
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8422
Differential Revision: https://phab.enlightenment.org/D10498
Bruno da Silva Belo [Fri, 25 Oct 2019 14:23:08 +0000 (11:23 -0300)]
csharp: Calling ConfigureAwait on tasks GM.
Summary: ref T8424
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8424
Differential Revision: https://phab.enlightenment.org/D10497
Bruno da Silva Belo [Fri, 25 Oct 2019 14:22:35 +0000 (11:22 -0300)]
csharp: Calling ConfigureAwait on tasks Model.
Summary: ref T8424
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8424
Differential Revision: https://phab.enlightenment.org/D10496
Bruno da Silva Belo [Fri, 25 Oct 2019 14:17:53 +0000 (11:17 -0300)]
csharp: Calling ConfigureAwait on task eopromises.
Summary: ref T8424
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8424
Differential Revision: https://phab.enlightenment.org/D10495
Yeongjong Lee [Thu, 24 Oct 2019 20:46:13 +0000 (17:46 -0300)]
mono: implement dispose method based on dispose pattern
Summary:
Fix CA1063, CA1816
ref T8400, T8419
Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test
Reviewers: felipealmeida, brunobelo, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8419, T8400
Differential Revision: https://phab.enlightenment.org/D10460
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:41 +0000 (09:42 -0400)]
tests/layout: add legacy layout test to verify behavior with legacy size hints
Summary:
this verifies that user-set legacy size hints will be applied accurately during
calc, and that the size of a layout can accurately decrease when its contents min
sizes decrease
ref
95b5731461c53df2691ef43db61f321de5b366d3
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10453
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:33 +0000 (09:42 -0400)]
efl_ui/text_scroller: fix null derefs
Summary: CIDs 1403890, 1396964, 1396945
Reviewers: cedric, vtorri
Reviewed By: cedric
Subscribers: vtorri, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10447
Bruno da Silva Belo [Thu, 24 Oct 2019 21:50:48 +0000 (18:50 -0300)]
csharp: Returning only method name iwrapper.
Summary:
GetUserMethods returning only strings,
not the whole method informations.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10503
Yeongjong Lee [Tue, 15 Oct 2019 06:21:16 +0000 (06:21 +0000)]
efl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity
child, target should be graphical object.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10401
Mike Blumenkrantz [Thu, 17 Oct 2019 14:23:34 +0000 (10:23 -0400)]
elm/code: check save file attrs after opening
ensure that they haven't changed between time of check and time of open
CID 1396966
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10440
Hosang Kim [Thu, 24 Oct 2019 07:27:37 +0000 (07:27 +0000)]
efl_message: add pending queue for filtering message.
Sometimes message is appended when message queue is walking.
In this case, newly added messages are not filtered.
So I add message pending queue for filtering message.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10459
Yeongjong Lee [Thu, 24 Oct 2019 21:21:39 +0000 (18:21 -0300)]
eina_mono: re-throw exception to preserve stack details
Summary:
fix CA2200
ref T8426
Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test
Reviewers: lauromoura, felipealmeida, brunobelo
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8426
Differential Revision: https://phab.enlightenment.org/D10462
Yeongjong Lee [Thu, 24 Oct 2019 21:24:07 +0000 (18:24 -0300)]
eina_mono: Initialize UNHANDLED_EXCEPTION inline
Summary:
fix CA2207
ref T8427
Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test
Reviewers: lauromoura, felipealmeida, brunobelo
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8427
Differential Revision: https://phab.enlightenment.org/D10463
Lauro Moura [Thu, 24 Oct 2019 16:42:40 +0000 (18:42 +0200)]
csharp: Add since information to EoWrapper.cs
Reviewers: brunobelo, segfaultxavi, felipealmeida, woohyun
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10429
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:14 +0000 (18:23 +0200)]
tests/ecore: ensure that we attempt to re-set PATH in ecore-file tests
Summary:
if this test failed before for any reason, PATH would be permanently changed
for the current shell and process, which is obviously not what we want
Depends on D10414
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10415
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:11 +0000 (18:23 +0200)]
tests/ecore: replace all bespoke strcats with snprintf
Summary:
CID 1400812
Depends on D10413
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10414
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:03 +0000 (18:23 +0200)]
tests/ecore: unset app args after app args unit test to prevent invalid reads
Summary:
various internal components in efl access the app args and read them which
will result in invalid memory access since these are stack-allocated strings
Depends on D10412
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10413
Mike Blumenkrantz [Thu, 24 Oct 2019 16:14:25 +0000 (18:14 +0200)]
ecore/app: permit resetting app args to uninitialized (zeroed) state
Summary:
this is mainly useful for unit testing, but unsetting values should not be
treated as an error
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10412
Mike Blumenkrantz [Thu, 24 Oct 2019 15:53:23 +0000 (17:53 +0200)]
tests/eina: use slstr_steal function in slstr_steal test
Summary: CID 1401043
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10404
Mike Blumenkrantz [Thu, 24 Oct 2019 15:43:19 +0000 (17:43 +0200)]
tests/spec: free array in multi selectable tests
Summary: CIDs 1405810, 1405807, 1405806, 1405805, 1405803, 1405801, 1403902
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10403
Yeongjong Lee [Thu, 24 Oct 2019 15:18:44 +0000 (17:18 +0200)]
mono: merge namespaces in manual bindings
Summary:
It will enhance readability.
Before
```
namespace Efl {
namespace Eo {
```
After
```
namespace Efl.Eo {
```
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10466
Felipe Magno de Almeida [Thu, 24 Oct 2019 13:36:42 +0000 (10:36 -0300)]
cxx: Add license to CXX bindings.
Summary:
Like C#, it will also be Apache 2.0
Depends on D9414
Reviewers: vitor.sousa, woohyun, jpeg, lauromoura
Reviewed By: lauromoura
Subscribers: jpeg, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9418
Lauro Moura [Thu, 24 Oct 2019 13:01:50 +0000 (10:01 -0300)]
csharp: Add licensing information.
Summary:
C# bindings will be lincensed under Apache Sofware License 2.0.
This commit adds the license text to the licenses folder and a copyright
notice to the binding files.
Fixes T8039
Reviewers: woohyun, felipealmeida, vitor.sousa
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8039
Differential Revision: https://phab.enlightenment.org/D9414
Mike Blumenkrantz [Thu, 24 Oct 2019 12:50:27 +0000 (14:50 +0200)]
examples/efl_thread: fix oob writes
Summary: CIDs 1403896, 1403895, 1403892
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10395
Mike Blumenkrantz [Thu, 24 Oct 2019 12:35:28 +0000 (14:35 +0200)]
examples/ecore: use correct type for getchar() return
Summary:
correct prototype is int getchar(void);
CID 1400794
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10391
Carsten Haitzler (Rasterman) [Thu, 24 Oct 2019 12:13:29 +0000 (13:13 +0100)]
spaces--
Daniel Kolesa [Wed, 23 Oct 2019 13:51:34 +0000 (15:51 +0200)]
eina: remove eina_config.h.in
This is never actually used since meson generates eina_config.h
from scratch. Apart from the byteswap checks done in the previous
commit, all of the other things already seem to be done by meson,
so just remove it.
Daniel Kolesa [Wed, 23 Oct 2019 13:44:22 +0000 (15:44 +0200)]
eina: unbreak byteswap checks
For one, eina_config.h.in is never used by anything since meson,
so doing any checks in it and expecting them to work is wrong.
Byteswaps are one place where this is the case, so move the
checks back in their appropriate place.
Xavi Artigas [Wed, 23 Oct 2019 08:15:30 +0000 (10:15 +0200)]
docs: small fixes to Efl.Text
Christopher Michael [Tue, 22 Oct 2019 14:59:29 +0000 (10:59 -0400)]
ecore-evas-wayland: Minor formatting fixes
NB: No functional changes
Christopher Michael [Tue, 22 Oct 2019 14:42:54 +0000 (10:42 -0400)]
ecore-wl2: Minor formatting fix
NB: No functional changes
Christopher Michael [Tue, 22 Oct 2019 14:12:51 +0000 (10:12 -0400)]
ecore_evas_wayland: Fix array step size
Fix bug where eina_array step size was being increased by 10 everytime
a handler was pushed to the array. There is no need to increase array
size by 10 each time we add 1 pointer to handler.
@fix
Christopher Michael [Tue, 22 Oct 2019 14:11:24 +0000 (10:11 -0400)]
ecore-evas-wayland: Add handler to array
Small patch to fix bug where last event handler was not being added to
the event_hdls array
@fix
Christopher Michael [Tue, 22 Oct 2019 14:06:23 +0000 (10:06 -0400)]
ecore-evas-wayland: Minor formatting fix
NB: No functional changes
Christopher Michael [Tue, 22 Oct 2019 14:04:01 +0000 (10:04 -0400)]
ecore-evas-wayland: Minor formatting fix
NB: No functional changes
Daniel Kolesa [Sun, 20 Oct 2019 16:49:04 +0000 (18:49 +0200)]
eina: fix network byte order swap funcs on big endian
Jongmin Lee [Mon, 21 Oct 2019 23:24:41 +0000 (08:24 +0900)]
build: resolve migration build error
Change-Id: I7ab5cb4a3e283546a25670ab35f03db25a1918b3
Ali Alzyod [Sat, 19 Oct 2019 05:01:36 +0000 (14:01 +0900)]
evas_object_textblock: add support for variation sequences
Summary: update font processing to handle variation sequences unicodes to select proper glypg in respect to variation seqences
Test Plan:
```
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Evas_Object *win, *textblock;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("Main", "");
elm_win_autodel_set(win, EINA_TRUE);
textblock = evas_object_textblock_add(win);
efl_canvas_text_style_set(textblock,NULL,"DEFAULT='font=DejaVuSans font_fallbacks=SamsungColorEmoji color=#000 font_size=20'");
evas_object_textblock_text_markup_set(textblock, "8️⃣☪️AAA☪︎1234567️⃣");
evas_object_size_hint_weight_set(textblock, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(textblock, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_show(textblock);
evas_object_move(textblock, 0, 0);
evas_object_resize(textblock, 320, 320);
evas_object_resize(win, 320, 320);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: woohyun, bowonryu, segfaultxavi, cedric, bu5hm4n
Reviewed By: woohyun, cedric
Subscribers: bu5hm4n, subodh6129, herdsman, segfaultxavi, zmike, cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9053
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:10 +0000 (13:30 -0400)]
fix various trivial null derefs
Summary:
CIDs 1401081, 1401044, 1400983, 1400960, 1400927, 1400799, 1396946, 1396944,
1383851, 1383847, 1382211, 1379921, 1379921
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10452
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:03 +0000 (13:30 -0400)]
efl/io: return EINVAL if null slice is passed for writing
Summary: CIDs 1396996, 1396983, 1396953
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10451
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:57 +0000 (13:29 -0400)]
tests/ecore_con: clarify pointer usage in ecore_con_url tests
Summary:
this was pretty bizarre
CID 1401029
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10450
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:51 +0000 (13:29 -0400)]
elm/main: fix null deref
Summary: CID 1402697
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10449
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:44 +0000 (13:29 -0400)]
efl/engines: fix null derefs
Summary: CIDs 1402640, 1402709
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10448
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:38 +0000 (13:29 -0400)]
evas_vg/svg: fix null deref
Summary: CID 1405672
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10446
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:32 +0000 (13:29 -0400)]
eina/convert: init endptr in failure case of eina_convert_strtod_c
Summary:
there is not any way to determine that this function has failed other
than to check this pointer, so ensure that it always has a value which
is meaningful in failure cases
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10445
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:26 +0000 (13:29 -0400)]
efl/boolean_model: remove misleading null check
Summary:
this is always a pointer to a stack variable
CID 1405799
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10444
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:20 +0000 (13:29 -0400)]
embryo: don't use sizeof() when strlen() is intended
Summary: CID 1402617
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10411
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:13 +0000 (13:29 -0400)]
tests: fix minor string leaks
Summary: CIDs 1404754, 1401022, 1400965
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10405
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:07 +0000 (13:29 -0400)]
benchmarks/eina: fix possible div by zero in ecore_hash
Summary: CID 1400768
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10397
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:01 +0000 (13:29 -0400)]
ecore/main: avoid calling FD_SET with invalid fd value
Summary:
it's possible that _ecore_get_epoll_fd() can return -1, so ensure that we
correctly handle this
CID 1383850
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10394
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:54 +0000 (13:28 -0400)]
ecore/getopt: handle negative return in arg parsing
Summary:
_ecore_getopt_parse_find_nonargs_base() can return -1 on errors
CID 1402615
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10393
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:48 +0000 (13:28 -0400)]
tests/eldbus: add va_end for va_args usage in message test
Summary: CIDs 1400977, 1400974
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10390
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:41 +0000 (13:28 -0400)]
evas/language: #ifdef guard variable which is only used inside #ifdef
Summary:
this variable is already only changed inside an #ifdef, so declare and
free it only inside the same ifdef for clarity
ref
9d9aa8b6ae0c07ebe23e1ea3fcb81f8050311651
CID 1400807
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10389
Bruno da Silva Belo [Fri, 18 Oct 2019 14:40:33 +0000 (11:40 -0300)]
csharp: Setting ELM_ENGINE if it is none.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8322
Differential Revision: https://phab.enlightenment.org/D10442
Carsten Haitzler (Rasterman) [Fri, 18 Oct 2019 11:49:21 +0000 (12:49 +0100)]
wl egl - use platform get display
if possible, use the platform specific egl get display as a wl egl
client. this fixes client side init with ... some drivers that can't
auto-detect the display type passed in.
@fix
Yeongjong Lee [Thu, 17 Oct 2019 23:23:11 +0000 (20:23 -0300)]
mono: encapsulate invoke method
Summary: This patch will fix compiler warning CA1401.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10338
Bruno da Silva Belo [Thu, 17 Oct 2019 18:53:48 +0000 (15:53 -0300)]
csharp: updating eldbus_message doc and hide api.
Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8361
Differential Revision: https://phab.enlightenment.org/D10431
Bruno da Silva Belo [Thu, 17 Oct 2019 18:39:47 +0000 (15:39 -0300)]
csharp: updating eldbus_proxy doc and hide api.
Summary: ref T8361
Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8361
Differential Revision: https://phab.enlightenment.org/D10428
Bruno da Silva Belo [Thu, 17 Oct 2019 18:25:17 +0000 (15:25 -0300)]
csharp: updating eldbus_pending docs and hide api.
Summary: ref T8361
Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8361
Differential Revision: https://phab.enlightenment.org/D10427
projects / platform / upstream / efl.git / log